searching for reviewer(jgilbert)
c1ef18d0a27ec4c2736cbb2c8ae8b061bd728f2e: Bug 1769499 [Linux/EGL] Create GBM based surface for headless GL context r=jgilbert default tip
stransky <stransky@redhat.com> - Thu, 19 May 2022 15:18:22 +0000 - rev 618250
Push 39720 by nbeleuzu@mozilla.com at Thu, 19 May 2022 18:03:18 +0000
Bug 1769499 [Linux/EGL] Create GBM based surface for headless GL context r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D146555
d13c0a1c7a19860435622b1786d6059a701ab5d1: Bug 1769499 [Linux/EGL] Create GBM based surface for headless GL context r=jgilbert
stransky <stransky@redhat.com> - Thu, 19 May 2022 06:34:20 +0000 - rev 618205
Push 39719 by smolnar@mozilla.com at Thu, 19 May 2022 16:03:14 +0000
Bug 1769499 [Linux/EGL] Create GBM based surface for headless GL context r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D146555
177273d61850201b8e6de0e545013f3181228a41: Bug 1769710 [Linux] Use GLContextProviderLinux on Linux r=jgilbert
stransky <stransky@redhat.com> - Wed, 18 May 2022 12:01:50 +0000 - rev 618110
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769710 [Linux] Use GLContextProviderLinux on Linux r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D146549
0a64e06c72f00ec14bae5e08a55daafe970000e3: Bug 1769710 [Linux] Remove GLContextProviderX11 r=jgilbert
stransky <stransky@redhat.com> - Wed, 18 May 2022 12:01:50 +0000 - rev 618109
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769710 [Linux] Remove GLContextProviderX11 r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D146548
89b924add412492779b8ae11ada910bfa4b2925e: Bug 1769710 [Linux] Remove GLContextProviderWayland r=jgilbert
stransky <stransky@redhat.com> - Wed, 18 May 2022 12:01:49 +0000 - rev 618108
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769710 [Linux] Remove GLContextProviderWayland r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D146547
99b5acb248deea6fa1901f4a1507518192338726: Bug 1769710 [Linux] Add GLContextProviderLinux for GLX/EGL r=jgilbert
stransky <stransky@redhat.com> - Wed, 18 May 2022 12:01:49 +0000 - rev 618107
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769710 [Linux] Add GLContextProviderLinux for GLX/EGL r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D146546
05fe9638ac051be144123cda6edcce609fd43d18: Bug 1769710 [Linux] Use GLContextProviderLinux on Linux r=jgilbert
stransky <stransky@redhat.com> - Wed, 18 May 2022 06:43:48 +0000 - rev 618076
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769710 [Linux] Use GLContextProviderLinux on Linux r=jgilbert Depends on D146548 Differential Revision: https://phabricator.services.mozilla.com/D146549
7ddd8fdfe957a4a49124d4b0261a514c489d4368: Bug 1769710 [Linux] Remove GLContextProviderX11 r=jgilbert
stransky <stransky@redhat.com> - Wed, 18 May 2022 06:43:48 +0000 - rev 618075
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769710 [Linux] Remove GLContextProviderX11 r=jgilbert Depends on D146547 Differential Revision: https://phabricator.services.mozilla.com/D146548
b8191e074d6dcbfb8aa7cf53d5350de6d4f4b703: Bug 1769710 [Linux] Remove GLContextProviderWayland r=jgilbert
stransky <stransky@redhat.com> - Wed, 18 May 2022 06:43:47 +0000 - rev 618074
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769710 [Linux] Remove GLContextProviderWayland r=jgilbert Depends on D146546 Differential Revision: https://phabricator.services.mozilla.com/D146547
202d09293cf2d44ef04d9e0395cc9ed6f338b1d9: Bug 1769710 [Linux] Add GLContextProviderLinux for GLX/EGL r=jgilbert
stransky <stransky@redhat.com> - Wed, 18 May 2022 06:43:47 +0000 - rev 618073
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769710 [Linux] Add GLContextProviderLinux for GLX/EGL r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D146546
806470110fa5ade73a6e1526f89e6e20e48a3284: Bug 1769633: Update wgpu to b51fd851. r=jgilbert
Jim Blandy <jimb@red-bean.com> - Tue, 17 May 2022 03:09:07 +0000 - rev 617827
Push 39708 by bszekely@mozilla.com at Tue, 17 May 2022 09:27:45 +0000
Bug 1769633: Update wgpu to b51fd851. r=jgilbert Fix Firefox for compute_pass_dispatch functions renamed upstream. Remove set_index_buffer ffi functions; they're now in wgpu. Differential Revision: https://phabricator.services.mozilla.com/D146509
d7b9bac2ace5670fc190b3ffc17f2980567da506: Bug 1769633: Update wgpu to b51fd851. r=jgilbert
Jim Blandy <jimb@red-bean.com> - Tue, 17 May 2022 00:26:01 +0000 - rev 617807
Push 39708 by bszekely@mozilla.com at Tue, 17 May 2022 09:27:45 +0000
Bug 1769633: Update wgpu to b51fd851. r=jgilbert Fix Firefox for compute_pass_dispatch functions renamed upstream. Remove set_index_buffer ffi functions; they're now in wgpu. Differential Revision: https://phabricator.services.mozilla.com/D146509
cc5f20871d684ec9fce1a09707704992aee64b84: Bug 1752538: Properly report GPURenderPassDescriptors with too many color attachments. r=jgilbert
Jim Blandy <jimb@red-bean.com> - Tue, 17 May 2022 00:25:35 +0000 - rev 617805
Push 39708 by bszekely@mozilla.com at Tue, 17 May 2022 09:27:45 +0000
Bug 1752538: Properly report GPURenderPassDescriptors with too many color attachments. r=jgilbert The WebGPU spec says that `beginRenderPass` should generate a validation error if the valid usage rules for `GPURenderPassDescriptor` are not satisfied. In particular, a `GPURenderPassDescriptor` may not contain more than eight color attachments. The `wgpu-core` crate will panic if a `wgpu_core::command::RenderPassDescriptor` contains too many color attachments. This is safe, but panics are not acceptable in Firefox, so it falls to our WebGPU implementation to perform the error checks described by the spec. Since WebGPU error handling records the first error to occur within each error scope, the API is sensitive to the order in which errors are generated. To ensure that the error is properly ordered with respect to other messages sent to the device, we must send the error to compositor process. The WebGPUParent will then handle it interleaved appropriately with other Device timeline activity. Differential Revision: https://phabricator.services.mozilla.com/D146391
93868cb5faa3fb33a1c1e7425f8a207db0dd8093: Bug 1763503 - Hold layers::CanvasRenderer in ClientWebGLContext::mNotLost r=jgilbert,gfx-reviewers
sotaro <sotaro.ikeda.g@gmail.com> - Fri, 13 May 2022 00:17:42 +0000 - rev 617142
Push 39689 by bszekely@mozilla.com at Fri, 13 May 2022 09:35:38 +0000
Bug 1763503 - Hold layers::CanvasRenderer in ClientWebGLContext::mNotLost r=jgilbert,gfx-reviewers bug 1733732 decreased the size of the display port on Android. When you scroll to the bottom of the page, the canvas leaves the display port. It triggers to destroy WebRenderCanvasData and WebRenderCanvasRendererAsync. And then RenderAndroidSurfaceTextureHost::NotifyNotUsed() is called and RenderAndroidSurfaceTextureHost is destroyed. Then if scrolling makes the canvas into the display port again, WebRenderCanvasData, WebRenderCanvasRendererAsync and RenderAndroidSurfaceTextureHost are recreated again. But there is no rendering update at SharedSurface_SurfaceTexture. Since the page does WebGL rendering only once during page load. It caused the problem to RenderAndroidSurfaceTextureHost. RenderAndroidSurfaceTextureHost::NotifyNotUsed() returns SurfaceTexture's buffer to client side. For using SurfaceTexture again in RenderAndroidSurfaceTextureHost, Client side needs to do re-rendering to SurfaceTexture. But SharedSurface_SurfaceTexture did nothing in this case. To address the problem, we could hold layers::CanvasRenderer in ClientWebGLContext::mNotLost. If WebRenderCanvasRendererAsync is kept alive, RenderAndroidSurfaceTextureHost::NotifyNotUsed() and destruction of WebRenderCanvasRendererAsync do not happen. Then if WebRenderCanvasData is re-created, the stored WebRenderCanvasRendererAsync is set in the new WebRenderCanvasData in ClientWebGLContext::UpdateWebRenderCanvasData(). Differential Revision: https://phabricator.services.mozilla.com/D143811
7fd565174880e56df2b5ad70cc01b0e40420b4dd: Bug 1766923: Fix default component for `gfx/wgpu_bindings` directory. r=jgilbert
Jim Blandy <jimb@red-bean.com> - Tue, 10 May 2022 22:53:56 +0000 - rev 616936
Push 39680 by bszekely@mozilla.com at Wed, 11 May 2022 09:42:52 +0000
Bug 1766923: Fix default component for `gfx/wgpu_bindings` directory. r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D145027
bef9104f01c528a0b0fac514ebcf35b505924224: Bug 1756598 [Linux] Make GL context creation thread safe r=sotaro,jgilbert
stransky <stransky@redhat.com> - Mon, 09 May 2022 17:52:11 +0000 - rev 616710
Push 39673 by nbeleuzu@mozilla.com at Tue, 10 May 2022 03:50:31 +0000
Bug 1756598 [Linux] Make GL context creation thread safe r=sotaro,jgilbert Differential Revision: https://phabricator.services.mozilla.com/D144284
47697e51f9a7b9dffb6cc77d45d473943ecdd960: Bug 1752869: Handle invalid BindGroupLayouts better. r=jgilbert
Jim Blandy <jimb@red-bean.com> - Fri, 29 Apr 2022 00:31:20 +0000 - rev 615635
Push 39627 by abutkovits@mozilla.com at Fri, 29 Apr 2022 09:48:42 +0000
Bug 1752869: Handle invalid BindGroupLayouts better. r=jgilbert Arrange for passing an invalid `BindGroupLayout` to `CreatePipelineLayout` or `CreateBindGroup` to produce an invalid `PipelineLayout`/`BindGroup`, instead of trying to pass the `BindGroupLayout`'s bogus `RawId` (which is zero) over to the GPU process, causing a panic in deserialization (thank you, Rust!). Arrange for a `PipelineLayout` constructed with a zero `RawId` to mark itself invalid, as most other WebGPU content objects do. This permits `WebGPUChild::DeviceCreatePipelineLayout` to return zero if the descriptor is invalid. Differential Revision: https://phabricator.services.mozilla.com/D145036
c565d4e86bf9d15afca09bb4d5ba93121ff0c1b4: Bug 1766754: Document WebGPU FFI `ErrorBuffer` types. r=jgilbert DONTBUILD
Jim Blandy <jimb@red-bean.com> - Thu, 28 Apr 2022 05:27:25 +0000 - rev 615549
Push 39625 by nfay@mozilla.com at Thu, 28 Apr 2022 21:47:15 +0000
Bug 1766754: Document WebGPU FFI `ErrorBuffer` types. r=jgilbert DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D144904
191f7843f8fb0d200249ae95d5eaf55c06786b9a: Bug 1766569: Remove `wgpu_bindings::server::GlobalExt` trait. r=jgilbert
Jim Blandy <jimb@red-bean.com> - Thu, 28 Apr 2022 05:26:26 +0000 - rev 615548
Push 39625 by nfay@mozilla.com at Thu, 28 Apr 2022 21:47:15 +0000
Bug 1766569: Remove `wgpu_bindings::server::GlobalExt` trait. r=jgilbert Replace the `GlobalExt` trait with a simple `impl Global` block, which has exactly the same effect. Differential Revision: https://phabricator.services.mozilla.com/D144782
ec45e06b8143025fd88b56350e2ae9105d439210: Bug 1709951 - Make WebGPU handle GPU process loss. r=gfx-reviewers,webidl,jgilbert,smaug
Andrew Osmond <aosmond@mozilla.com> - Wed, 27 Apr 2022 21:13:21 +0000 - rev 615521
Push 39625 by nfay@mozilla.com at Thu, 28 Apr 2022 21:47:15 +0000
Bug 1709951 - Make WebGPU handle GPU process loss. r=gfx-reviewers,webidl,jgilbert,smaug Differential Revision: https://phabricator.services.mozilla.com/D143247
3a6dbb3555cb5338a73c67499564cf97b4ec1063: Bug 1763781 Part 2: Update test expectations. r=jgilbert
Brad Werth <bwerth@mozilla.com> - Mon, 25 Apr 2022 21:13:38 +0000 - rev 615257
Push 39615 by ncsoregi@mozilla.com at Tue, 26 Apr 2022 09:46:09 +0000
Bug 1763781 Part 2: Update test expectations. r=jgilbert This gives us better correctness for 10-bit vp9 reftests. In the WPTs, we turn off some tests on macos because of the difficulty that our screenshots have in analyzing srgb image data. It seems to consistently report 191,255,191,73 when we are expecting 255,0,0,255. Depends on D144039 Differential Revision: https://phabricator.services.mozilla.com/D144228
ed2a721a38c5b3f62d6bec4c93c025af079a383b: Bug 1763781 Part 2: Update test expectations. r=jgilbert
Brad Werth <bwerth@mozilla.com> - Mon, 25 Apr 2022 19:13:52 +0000 - rev 615244
Push 39615 by ncsoregi@mozilla.com at Tue, 26 Apr 2022 09:46:09 +0000
Bug 1763781 Part 2: Update test expectations. r=jgilbert This gives us better correctness for 10-bit vp9 reftests. In the WPTs, we turn off some tests on macos because of the difficulty that our screenshots have in analyzing srgb image data. It seems to consistently report 191,255,191,73 when we are expecting 255,0,0,255. Depends on D144039 Differential Revision: https://phabricator.services.mozilla.com/D144228
3b1422986294d2f38d6dee1e44635d38f015f793: Bug 1763781 Part 2: Update test expectations. r=jgilbert
Brad Werth <bwerth@mozilla.com> - Fri, 22 Apr 2022 23:38:00 +0000 - rev 615153
Push 39606 by ncsoregi@mozilla.com at Sat, 23 Apr 2022 21:27:33 +0000
Bug 1763781 Part 2: Update test expectations. r=jgilbert This gives us better correctness for 10-bit vp9 reftests. In the WPTs, we turn off some tests on macos because of the difficulty that our screenshots have in analyzing srgb image data. It seems to consistently report 191,255,191,73 when we are expecting 255,0,0,255. Differential Revision: https://phabricator.services.mozilla.com/D144228
bd9a00d21306f600e4d1aa077e167cef5947e1a1: Bug 1764618 Part 2: Make macOS software decode respect transfer functions. r=media-playback-reviewers,gfx-reviewers,jgilbert
Brad Werth <bwerth@mozilla.com> - Fri, 22 Apr 2022 22:10:18 +0000 - rev 615144
Push 39606 by ncsoregi@mozilla.com at Sat, 23 Apr 2022 21:27:33 +0000
Bug 1764618 Part 2: Make macOS software decode respect transfer functions. r=media-playback-reviewers,gfx-reviewers,jgilbert Differential Revision: https://phabricator.services.mozilla.com/D143838
25a864f2627db9196b7995d74180acc2d2b42bf3: Bug 1755702: Return NOT_IMPLEMENTED from mozilla::webgpu::CanvasContext::GetInputStream. r=jgilbert
Jim Blandy <jimb@red-bean.com> - Thu, 21 Apr 2022 18:01:38 +0000 - rev 615005
Push 39598 by nfay@mozilla.com at Fri, 22 Apr 2022 03:39:15 +0000
Bug 1755702: Return NOT_IMPLEMENTED from mozilla::webgpu::CanvasContext::GetInputStream. r=jgilbert Continue to set the returned stream to `nullptr` (which callers do not check for, but is safe), but return `NS_ERROR_NOT_IMPLEMENTED` instead of `NS_OK` --- callers do check the `nsresult`. Returning an `NS_FAILED` result from our `GetInputStream` implementation causes `HTMLCanvasElement.prototype.toDataURL` to return the fallback value `"data:,"`. Differential Revision: https://phabricator.services.mozilla.com/D144242
20da19c572f948e55128a5ae37908c8d3e25ccb6: Bug 1765462: Update wgpu to 0b61a191 (2022-4-18) r=jgilbert
Jim Blandy <jimb@red-bean.com> - Wed, 20 Apr 2022 16:29:04 +0000 - rev 614794
Push 39593 by ctuns@mozilla.com at Wed, 20 Apr 2022 21:53:00 +0000
Bug 1765462: Update wgpu to 0b61a191 (2022-4-18) r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D144074
92df14b122b48b058b82ac3cc26eaf2639c44ea1: Bug 1765179: Remove dom/webgpu/ffi. r=jgilbert DONTBUILD
Jim Blandy <jimb@red-bean.com> - Tue, 19 Apr 2022 22:26:40 +0000 - rev 614656
Push 39589 by nbeleuzu@mozilla.com at Wed, 20 Apr 2022 03:39:48 +0000
Bug 1765179: Remove dom/webgpu/ffi. r=jgilbert DONTBUILD Remove the unused source directory `dom/webgpu/ffi`. The `wgpu_ffi_generated.h` header actually #included by `gfx/wgpu_bindings/wgpu.h` is generated by `gfx/wgpu_bindings/moz.build` at build time and placed in the obj directory. The copy in the source directory is ignored, and it's confusing to keep it around. Differential Revision: https://phabricator.services.mozilla.com/D143931
424e46671d4f42460c4b29cd5b2a06db9c27f584: Bug 1763782 Part 3: Update test expectations. r=jgilbert,gfx-reviewers
Brad Werth <bwerth@mozilla.com> - Tue, 19 Apr 2022 01:06:30 +0000 - rev 614534
Push 39585 by smolnar@mozilla.com at Tue, 19 Apr 2022 09:30:10 +0000
Bug 1763782 Part 3: Update test expectations. r=jgilbert,gfx-reviewers Differential Revision: https://phabricator.services.mozilla.com/D143667
0ad6c07468faca4c5d65c120d66f31e3dba673bd: Bug 1763782 Part 2: Set color primaries and transfer functions for HD and HDR. r=gfx-reviewers,jgilbert
Brad Werth <bwerth@mozilla.com> - Tue, 19 Apr 2022 01:06:30 +0000 - rev 614533
Push 39585 by smolnar@mozilla.com at Tue, 19 Apr 2022 09:30:10 +0000
Bug 1763782 Part 2: Set color primaries and transfer functions for HD and HDR. r=gfx-reviewers,jgilbert This derives sane values for color primaries and transfer functions from the colorspace value. A better solution would be to extract those values from the video itself, but these are good enough for common encodings and match the behavior for hardware-decoded video in AppleVTDecoder. Depends on D143436 Differential Revision: https://phabricator.services.mozilla.com/D143542
e39c412b70413e5152d2efd75e572e2728eb0598: Bug 1763782 Part 1: Allow AV1 10-bit to be decoded. r=gfx-reviewers,jgilbert
Brad Werth <bwerth@mozilla.com> - Tue, 19 Apr 2022 01:06:29 +0000 - rev 614532
Push 39585 by smolnar@mozilla.com at Tue, 19 Apr 2022 09:30:10 +0000
Bug 1763782 Part 1: Allow AV1 10-bit to be decoded. r=gfx-reviewers,jgilbert This decodes 10-bit AV1 into the P010 surface format. Because of the needed bit shifting to move the 10-bits to the MSB positions, it can't use a straight memcpy for the Y values. Differential Revision: https://phabricator.services.mozilla.com/D143436
b38b90bc7a4d68d1c0c10d980ade8660e3b55b33: Bug 1763782 Part 3: Update test expectations. r=jgilbert,gfx-reviewers
Brad Werth <bwerth@mozilla.com> - Fri, 15 Apr 2022 19:03:24 +0000 - rev 614434
Push 39573 by imoraru@mozilla.com at Sat, 16 Apr 2022 09:48:14 +0000
Bug 1763782 Part 3: Update test expectations. r=jgilbert,gfx-reviewers Depends on D143542 Differential Revision: https://phabricator.services.mozilla.com/D143667
fefcfb0559bfaea8f6c0c3494bcfbabe42af30d2: Bug 1763782 Part 2: Set color primaries and transfer functions for HD and HDR. r=gfx-reviewers,jgilbert
Brad Werth <bwerth@mozilla.com> - Fri, 15 Apr 2022 19:03:24 +0000 - rev 614433
Push 39573 by imoraru@mozilla.com at Sat, 16 Apr 2022 09:48:14 +0000
Bug 1763782 Part 2: Set color primaries and transfer functions for HD and HDR. r=gfx-reviewers,jgilbert This derives sane values for color primaries and transfer functions from the colorspace value. A better solution would be to extract those values from the video itself, but these are good enough for common encodings and match the behavior for hardware-decoded video in AppleVTDecoder. Depends on D143436 Differential Revision: https://phabricator.services.mozilla.com/D143542
2f02711a485f621d9b0ab4acbeae7d61f1ccf6e6: Bug 1763782 Part 1: Allow AV1 10-bit to be decoded. r=gfx-reviewers,jgilbert
Brad Werth <bwerth@mozilla.com> - Fri, 15 Apr 2022 19:03:24 +0000 - rev 614432
Push 39573 by imoraru@mozilla.com at Sat, 16 Apr 2022 09:48:14 +0000
Bug 1763782 Part 1: Allow AV1 10-bit to be decoded. r=gfx-reviewers,jgilbert This decodes 10-bit AV1 into the P010 surface format. Because of the needed bit shifting to move the 10-bits to the MSB positions, it can't use a straight memcpy for the Y values. Differential Revision: https://phabricator.services.mozilla.com/D143436
0b5d13bcf3674a48d9bcba58948fdfbc19b89fc7: Bug 1762730: Update wgpu-core, wgpu-hal, and wgpu-types to 75e82afd. r=jgilbert
Jim Blandy <jimb@red-bean.com> - Thu, 07 Apr 2022 00:33:59 +0000 - rev 613575
Push 39531 by ccozmuta@mozilla.com at Thu, 07 Apr 2022 15:37:22 +0000
Bug 1762730: Update wgpu-core, wgpu-hal, and wgpu-types to 75e82afd. r=jgilbert New versions of several crates are introduced to third_party/rust, by changing the versions requested in `gfx/wgpu_bindings/Cargo.toml` and running `mach vendor rust`: - `wgpu-core`, `wgpu-hal`, and `wgpu-types`, as used by `wgpu_bindings` - `naga`, `ash`, and `metal`, as used by the above These are all exact copies of the upstream sources, at the git revisions listed in `.cargo/config.in`. This brings in fixes for some upstream `wgpu` bugs that were fuzzblockers: - Compute pipelines never freed at runtime, leaking memory #2564 https://github.com/gfx-rs/wgpu/issues/2564 - Device::drop doesn't actually free the device when using backend::direct::Context #2563 https://github.com/gfx-rs/wgpu/issues/2563 The Firefox sources also needed some adjustments to catch up with upstream changes: - The C type `mozilla::webgpu::ffi::WGPUTextureFormat` is now a struct containing a tag enum and a union, not just an enum. This is needed for [gfx-rs/wgpu#2477](https://github.com/gfx-rs/wgpu/pull/2477). (Note that Firefox's `WebGPU.webidl` is behind the current spec, so even though the newest ASTC texture formats are supported in `wgpu`, they're not available in Firefox yet.) - `wgpu` got a new feature, `id32`, which cbindgen needed to be told about so that it would generate preprocessor-protected code like this: #if defined(WGPU_FEATURE_ID32) typedef uint32_t WGPUNonZeroId; #endif #if !defined(WGPU_FEATURE_ID32) typedef uint64_t WGPUNonZeroId; #endif instead of just spitting out two conflicting definitions of `WGPUNonZeroId`. - The `wgpu_core::hub::IdentityHandlerFactory` trait's `spawn` method no longer takes a `min_index` argument. (Our implementations of that trait never used that argument anyway, so this was easy to accommodate.) Differential Revision: https://phabricator.services.mozilla.com/D142779
b67fef0360d97cf4adbaf210abf4d0df07d1abd5: Bug 1762730: Update wgpu-core, wgpu-hal, and wgpu-types to 75e82afd. r=jgilbert
Jim Blandy <jimb@red-bean.com> - Tue, 05 Apr 2022 20:13:28 +0000 - rev 613446
Push 39524 by ctuns@mozilla.com at Wed, 06 Apr 2022 04:35:13 +0000
Bug 1762730: Update wgpu-core, wgpu-hal, and wgpu-types to 75e82afd. r=jgilbert New versions of several crates are introduced to third_party/rust, by changing the versions requested in `gfx/wgpu_bindings/Cargo.toml` and running `mach vendor rust`: - `wgpu-core`, `wgpu-hal`, and `wgpu-types`, as used by `wgpu_bindings` - `naga`, `ash`, and `metal`, as used by the above These are all exact copies of the upstream sources, at the git revisions listed in `.cargo/config.in`. This brings in fixes for some upstream `wgpu` bugs that were fuzzblockers: - Compute pipelines never freed at runtime, leaking memory #2564 https://github.com/gfx-rs/wgpu/issues/2564 - Device::drop doesn't actually free the device when using backend::direct::Context #2563 https://github.com/gfx-rs/wgpu/issues/2563 The Firefox sources also needed some adjustments to catch up with upstream changes: - The C type `mozilla::webgpu::ffi::WGPUTextureFormat` is now a struct containing a tag enum and a union, not just an enum. This is needed for [gfx-rs/wgpu#2477](https://github.com/gfx-rs/wgpu/pull/2477). (Note that Firefox's `WebGPU.webidl` is behind the current spec, so even though the newest ASTC texture formats are supported in `wgpu`, they're not available in Firefox yet.) - `wgpu` got a new feature, `id32`, which cbindgen needed to be told about so that it would generate preprocessor-protected code like this: #if defined(WGPU_FEATURE_ID32) typedef uint32_t WGPUNonZeroId; #endif #if !defined(WGPU_FEATURE_ID32) typedef uint64_t WGPUNonZeroId; #endif instead of just spitting out two conflicting definitions of `WGPUNonZeroId`. - The `wgpu_core::hub::IdentityHandlerFactory` trait's `spawn` method no longer takes a `min_index` argument. (Our implementations of that trait never used that argument anyway, so this was easy to accommodate.) Differential Revision: https://phabricator.services.mozilla.com/D142779
688cbe362065a433ce9903541e73e0417bc3df0a: Bug 1753302 - Part 3. Add basic worker thread tests for WebGPU. r=gfx-reviewers,jgilbert
Andrew Osmond <aosmond@mozilla.com> - Mon, 04 Apr 2022 16:42:02 +0000 - rev 613288
Push 39521 by abutkovits@mozilla.com at Tue, 05 Apr 2022 09:40:56 +0000
Bug 1753302 - Part 3. Add basic worker thread tests for WebGPU. r=gfx-reviewers,jgilbert Differential Revision: https://phabricator.services.mozilla.com/D141503
36f8c9b4065d3e2bb2224eaf22ed61edc7a754fd: Bug 1753302 - Part 1. Integrate WebGPU with OffscreenCanvas plumbing. r=gfx-reviewers,jgilbert
Andrew Osmond <aosmond@mozilla.com> - Mon, 04 Apr 2022 16:42:02 +0000 - rev 613286
Push 39521 by abutkovits@mozilla.com at Tue, 05 Apr 2022 09:40:56 +0000
Bug 1753302 - Part 1. Integrate WebGPU with OffscreenCanvas plumbing. r=gfx-reviewers,jgilbert Differential Revision: https://phabricator.services.mozilla.com/D141491
7403fb5ad11f0c605630c1c71eccb912a4685821: Bug 1761832 - Protect GLLibraryEGL singleton against race conditions. r=jgilbert
Andrew Osmond <aosmond@mozilla.com> - Mon, 28 Mar 2022 21:16:58 +0000 - rev 612633
Push 39488 by nfay@mozilla.com at Tue, 29 Mar 2022 09:56:04 +0000
Bug 1761832 - Protect GLLibraryEGL singleton against race conditions. r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D142257
5da6ab7735ff8ca5e2aea4817129c553feee7dd1: Bug 1759845 - used !foo.empty() instead of foo.size(). r=jgilbert
abhii-now <jainabhinav2k16@gmail.com> - Mon, 28 Mar 2022 20:14:45 +0000 - rev 612625
Push 39488 by nfay@mozilla.com at Tue, 29 Mar 2022 09:56:04 +0000
Bug 1759845 - used !foo.empty() instead of foo.size(). r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D142263
3286946246e7ac78990f2ea120dfa9fd6a94048e: Bug 1760786 - Ensure we only use WebGL in the content process on Android for DOM workers. r=jgilbert
Andrew Osmond <aosmond@mozilla.com> - Fri, 25 Mar 2022 23:50:24 +0000 - rev 611968
Push 39475 by nerli@mozilla.com at Sat, 26 Mar 2022 09:28:42 +0000
Bug 1760786 - Ensure we only use WebGL in the content process on Android for DOM workers. r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D141724
d94b85c99fb0228236cc6f9d7cc884b06a347f9a: Bug 1759432 - Don't check for the WebVR pref in VRProcessChild::Init. r=jgilbert
Andrew McCreight <continuation@gmail.com> - Wed, 16 Mar 2022 14:36:39 +0000 - rev 610763
Push 39429 by ctuns@mozilla.com at Wed, 16 Mar 2022 21:49:37 +0000
Bug 1759432 - Don't check for the WebVR pref in VRProcessChild::Init. r=jgilbert This check seems to fail even if the VR pref is enabled. I think this is because we are running this code while very early in process startup. I think it will not introduce risk because the other process in this case will be the parent process, so if that's been taken over then we've already lost. This also seems to fix the leak that I had to ignore before, probably because the VR process wasn't even starting up properly before, so I've removed the leak threshold I had to add. Differential Revision: https://phabricator.services.mozilla.com/D141170
eda238b99aeadc142ac5cc1a50ba555e15392b26: Bug 1757755 - Add size validation when restoring a WebGL context. r=jgilbert
Andrew Osmond <aosmond@mozilla.com> - Tue, 15 Mar 2022 23:25:25 +0000 - rev 610726
Push 39424 by nbeleuzu@mozilla.com at Wed, 16 Mar 2022 04:13:25 +0000
Bug 1757755 - Add size validation when restoring a WebGL context. r=jgilbert This matches the validation done in ClientWebGLContext::SetDimensions. Differential Revision: https://phabricator.services.mozilla.com/D141136
0db4289797430d01a77bd2f34b8b31518d4e3fbd: Bug 1758549, part 2 - Guard a few more entry points into VRManager. r=jgilbert
Andrew McCreight <continuation@gmail.com> - Sat, 12 Mar 2022 15:30:37 +0000 - rev 610457
Push 39407 by nbeleuzu@mozilla.com at Sat, 12 Mar 2022 21:44:34 +0000
Bug 1758549, part 2 - Guard a few more entry points into VRManager. r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D140785
9a30fd6463adad2e3d4bbbb4763bdb369cacc373: Bug 1758549, part 1 - Check that WebVR is enabled before creating PVR, PVRGPU and PVRLayer actors. r=jgilbert
Andrew McCreight <continuation@gmail.com> - Sat, 12 Mar 2022 15:30:37 +0000 - rev 610456
Push 39407 by nbeleuzu@mozilla.com at Sat, 12 Mar 2022 21:44:34 +0000
Bug 1758549, part 1 - Check that WebVR is enabled before creating PVR, PVRGPU and PVRLayer actors. r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D140784
bf1b56a58efff97575768745243d31394e9d82db: Bug 1758549, part 2 - Guard a few more entry points into VRManager. r=jgilbert
Andrew McCreight <continuation@gmail.com> - Fri, 11 Mar 2022 16:43:31 +0000 - rev 610406
Push 39402 by ctuns@mozilla.com at Fri, 11 Mar 2022 21:51:10 +0000
Bug 1758549, part 2 - Guard a few more entry points into VRManager. r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D140785
13be61e5ccd3453f189cd9ec1cfd66db9fdcdb32: Bug 1758549, part 1 - Check that WebVR is enabled before creating PVR, PVRGPU and PVRLayer actors. r=jgilbert
Andrew McCreight <continuation@gmail.com> - Fri, 11 Mar 2022 16:43:31 +0000 - rev 610405
Push 39402 by ctuns@mozilla.com at Fri, 11 Mar 2022 21:51:10 +0000
Bug 1758549, part 1 - Check that WebVR is enabled before creating PVR, PVRGPU and PVRLayer actors. r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D140784
1c21d0d3cd56abaae3836cb54b2eb1c62fe3afcc: Bug 1758776 - Replace the unused mVRDisplayID with a bool. r=jgilbert
Andrew McCreight <continuation@gmail.com> - Thu, 10 Mar 2022 17:40:43 +0000 - rev 610243
Push 39397 by nbeleuzu@mozilla.com at Thu, 10 Mar 2022 21:50:57 +0000
Bug 1758776 - Replace the unused mVRDisplayID with a bool. r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D140699
6b2d2aa1114592ae4ae92c8228ff5ae8e78d3644: Bug 1757067 - Explicitly specify chroma subsampling scheme for YCbCr data. r=jgilbert,jrmuizel
Lee Salzman <lsalzman@mozilla.com> - Thu, 10 Mar 2022 09:24:15 +0000 - rev 610187
Push 39395 by smolnar@mozilla.com at Thu, 10 Mar 2022 17:23:56 +0000
Bug 1757067 - Explicitly specify chroma subsampling scheme for YCbCr data. r=jgilbert,jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D139656
36c6350bc7d13e2e55d633c124538d5de5b63cdd: Bug 1757067 - Explicitly specify chroma subsampling scheme for YCbCr data. r=jgilbert,jrmuizel
Lee Salzman <lsalzman@mozilla.com> - Thu, 10 Mar 2022 07:48:53 +0000 - rev 610179
Push 39395 by smolnar@mozilla.com at Thu, 10 Mar 2022 17:23:56 +0000
Bug 1757067 - Explicitly specify chroma subsampling scheme for YCbCr data. r=jgilbert,jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D139656
b6d822cc9c0d3c609ad0e64b959aebe2c6b0ffd3: Bug 1758119 - Add some extra fuzziness for android hw tests r=gfx-reviewers,jgilbert
Glenn Watson <git@intuitionlibrary.com> - Sat, 05 Mar 2022 02:54:29 +0000 - rev 609646
Push 39375 by smolnar@mozilla.com at Sat, 05 Mar 2022 09:26:13 +0000
Bug 1758119 - Add some extra fuzziness for android hw tests r=gfx-reviewers,jgilbert Differential Revision: https://phabricator.services.mozilla.com/D140407