Bug 1716045 - Unify font-family storage. r=mats,jfkthame This changes font-family storage to reuse the rust types, removing a bunch of code while at it. This allows us to, for example, use a single static font family for -moz-bullet and clone it, rather than creating a lot of expensive copies. Differential Revision: https://phabricator.services.mozilla.com/D118011

Bug 1716045 - Optimize ArcSlice equality operator for pointer equality. r=jfkthame Just drive-by, but seems reasonable to avoid the per-element comparison if the pointers are the same. Depends on D118015 Differential Revision: https://phabricator.services.mozilla.com/D118016

Bug 1716045 - Implement ArcSlice copy/move-assignment operators. r=jfkthame We're going to use them. Differential Revision: https://phabricator.services.mozilla.com/D118015

Bug 1542807 part 4 - Exclude fonts loaded from User and UserAgent origin sheets from 'document.fonts'. r=jfkthame Per https://github.com/w3c/csswg-drafts/issues/6126 these were never intended to be included in the first place so this is just fixing a bug. Note that I'm leaving them in the mRuleFaces array so that the font loading machinery works the same as before. I'm just excluding them when queried by document.fonts. Differential Revision: https://phabricator.services.mozilla.com/D111694

Bug 1542807 part 4 - Exclude fonts loaded from User and UserAgent origin sheets from 'document.fonts'. r=jfkthame Per https://github.com/w3c/csswg-drafts/issues/6126 these were never intended to be included in the first place so this is just fixing a bug. Note that I'm leaving them in the mRuleFaces array so that the font loading machinery works the same as before. I'm just excluding them when queried by document.fonts. Differential Revision: https://phabricator.services.mozilla.com/D111694

Bug 1714293 - Add Scots (sco) to language names and accept languages locales, r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D116685

Bug 1707096 - fix the build for `clang-trunk`. r=jfkthame With D100581 LLVM added support for -Wunused-but-set-parameter and -Wunused-but-set-variable. 1. we shouldn't treat these warning as errors 2. for harfbuzz we apply a patch that has also been upstreamed, #2995, since pragma directives are somehow borken in clang vs gcc. Differential Revision: https://phabricator.services.mozilla.com/D116604

Bug 1711437 - Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame Instead, fix up the various content data structures when the stylesheet is mutated. This makes reading a stylesheet not disable style sharing. Differential Revision: https://phabricator.services.mozilla.com/D115203

Bug 1711437 - Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame Instead, fix up the various content data structures when the stylesheet is mutated. This makes reading a stylesheet not disable style sharing. Differential Revision: https://phabricator.services.mozilla.com/D115203

Bug 1712130 - Make print.print_via_parent a static pref. r=layout-reviewers,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D115612

Bug 1711472 - Update HarfBuzz to 2.8.1. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D115212

Bug 1690954 - Draw the menulist arrow button using currentColor rather than a fixed color. r=jfkthame As its background might not be themed. Differential Revision: https://phabricator.services.mozilla.com/D115194

Bug 1694104: Add a Mutex to nsPrinterWin and lock around most driver calls. r=jfkthame This also removes the fix from bug 1677388, which worked in some circumstances, but is effectively superseded by this one. Removing that fix also reduces potential contention for copying the default DEVMODE. Differential Revision: https://phabricator.services.mozilla.com/D112635

Bug 1709647 - Use NS_SAME_AS_FOREGROUND_COLOR instead of NS_DONT_CHANGE_COLOR. r=jfkthame I don't think they are meaningfully different. Depends on D114390 Differential Revision: https://phabricator.services.mozilla.com/D114391

Bug 1709647 - Remove unused NS_CHANGE_COLOR_IF_SAME_AS_BG. r=jfkthame It was introduced in bug 1024930, but it is unused since. Differential Revision: https://phabricator.services.mozilla.com/D114389

Bug 1708285 - Pass default font settings from parent to child processes. r=jfkthame Instead of relying on GTK to be initialized in the child process. Differential Revision: https://phabricator.services.mozilla.com/D113784

Bug 1692676 - Disable gfx.font_rendering.fallback.async for css-counter-styles/myanmar/ tests. r=layout-reviewers,jfkthame Also, adjust test expectations because they are now running reliably. Differential Revision: https://phabricator.services.mozilla.com/D112874

Bug 1705826 - Disable skip-ink-multiline-position.html on Windows 7. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D112832

Bug 1704466 - Make sure to preserve face order from fontconfig when appropriate. r=jfkthame This seems to help: https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=158613f137b8fe9409f19a3b6abbe5ce773a7b4f&newProject=try&newRevision=c87de791fbfc5d269d0f2071dc8a6dd28707bebc&framework=13 My patch reversed the ordering of faces with different weight / style / etc for a single font (which shouldn't matter for correctness, but seems to have some perf implications). Based on logging, fontconfig on automation returns "regular" faces first and "bold / semibold / italic / etc" later. My guess is that putting the regular faces later (which are more commonly used) affected performance of these test-cases. This patch should address it and restore the original order, by tweaking the prioritization code to stop doing "insert to front" / "insert to back", but instead moving aliases to the end. Differential Revision: https://phabricator.services.mozilla.com/D112674

Bug 1700565 - Disallow spaces to contribute to minimum advance width when line breaking is everywhere. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D112255

Bug 1476524 - Don't require so much contrast for selection background-against-background checks. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D111794

Bug 1704167 - When a pattern ends in whitespace, try to collapse adjacent white-space. r=jfkthame This I'm not 100% sure. Should be harmless, but it's a bit subtle. Maybe we should special-case it with "we're at the beginning of the pattern"? Reasoning below: The previous patch restores the performance of the original test-case. However, if you go to the reduced test-case and try to type " re" in the findbar, we still take a long time. The reason for that is not that the previous patch is not effective, but that the findbar sends find requests as soon as you type, and thus we end up with a request to find " ", which matches a gazillion spaces in the page and causes us to use tons of memory and time. Finding " re" is actually super-fast :-) This fixes it, but it is a bit subtle, so thoughts? Perhaps the findbar should wait a bit to perform the search before sending a query for " " instead or something? But I'd rather make it fast. Differential Revision: https://phabricator.services.mozilla.com/D111634

Bug 1704167 - Don't rewind if we're still at the beginning of the pattern. r=jfkthame This can happen with whitespace, and can cause us to scan whitespace exponentially. Should be straight-forward and have no behavior change. This restores the performance characteristics of the findbar before the regressing bug. Differential Revision: https://phabricator.services.mozilla.com/D111633

Bug 1703693 - Prefer faces for fonts that can only be named in one way. r=jfkthame This produces the desired rendering here by effectively "deprioritizing" faces from fonts that have multiple names. Your call whether this is a good idea or not, seems reasonable off-hand to me. Differential Revision: https://phabricator.services.mozilla.com/D111283

Bug 1695937 - Switch FluentBundle to use intl::NumberFormat; r=zbraniecki,hsivonen,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D107224

Bug 1698043 - Upstream the test for this bug to WPT. r=layout-reviewers,jfkthame Seems like a reasonable thing to expect that the placeholder renders at the same place as the text it's a placeholder for. Differential Revision: https://phabricator.services.mozilla.com/D111239

Bug 1695937 - Switch FluentBundle to use intl::NumberFormat; r=zbraniecki,hsivonen,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D107224

Bug 1703222 - Make sure to set gfxFontStyle::systemFont in LookAndFeelFontToStyle. r=jfkthame All NativeGetFont implementations do, so child processes see something different from parent processes which is pretty unfortunate, and isn't the goal of RemoteLookAndFeel. I found this by code inspection. Seems this is mostly used for debugging etc? Differential Revision: https://phabricator.services.mozilla.com/D110914

Bug 1701942 - Use bitwise equality for font variation value comparisons. r=jfkthame Just like we do for font sizes / size-adjust in gfxFontStyle. Differential Revision: https://phabricator.services.mozilla.com/D110519

Bug 1701942 - Normalize font size when font inflation is involved. r=jfkthame Bug 1646224 made font sizes floats, which caused conversion to nscoord not happen. Style fonts should never have NaN, but in this case a massive SVG transform matrix ends up causing a NaN font inflation factor. This in turn caused the scaled size to be NaN, and to get stuck on the font variations array here: https://searchfox.org/mozilla-central/rev/4fa18c26fa907f38d56b599571b9846af1506f3c/gfx/src/nsFont.cpp#283 That NaN in turn caused the font variations to have a NaN, and font styles comparing unequal, which prevents the font from getting removed from the cache, causing the issue. This should prevent it, but I have a more in-depth patch incoming. Differential Revision: https://phabricator.services.mozilla.com/D110518

Bug 1698885 - Update HarfBuzz to 2.8.0. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D109838

Bug 1679645 - Cache the selection state in nsTextFrame rather than in nsDisplayText r=emilio,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D108646

Bug 1700677 - set layout.css.font-metrics-overrides.enabled to let css-fonts test pass with Beta and Release. r=jfkthame DONTBUILD They are slated to ride the trains starting with this cycle (Gecko 89). @font-face metrics override is only enabled in Nightly and controlled by the preference layout.css.font-metrics-overrides.enabled (added in bug 1681691). Differential Revision: https://phabricator.services.mozilla.com/D109651

Bug 708901 - Migrate to nsTHashSet in gfx/thebes. r=jfkthame,jrmuizel Depends on D108602 Differential Revision: https://phabricator.services.mozilla.com/D108603

Bug 1697666 - Move IsSingleFaceFamily into gfxFontFamily. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D108810

Bug 1697076 - Drop assertion from mozilla::unicode::GetNaked. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D107942

Bug 1696935 - Update OTS to 8.1.4. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D107493

Bug 1696940: Use nsRuleBreaker code in nsUniscribeBreaker when win32k lockdown is enabled. r=jfkthame This is only intended for testing, because win32k lockdown is disabled by default for content. Differential Revision: https://phabricator.services.mozilla.com/D107495

Bug 1696407: Don't use GDI font table loading for DWrite when win32k lockdown is enabled. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D107488

Bug 1649187 - Fix diacritic stripping for characters outside the BMP. r=jfkthame Due to an unfortunate typo I made in base_chars.py, I thought that there were no mappings we care about outside of the basic multilingual plane. This patch adds back the non-BMP mappings that we do care about. Differential Revision: https://phabricator.services.mozilla.com/D107404

Bug 1649187 - Use a fallback table to strip diacritics from non-decomposable characters. r=jfkthame Implement the design suggested at https://bugzilla.mozilla.org/show_bug.cgi?id=1652910#c5 Differential Revision: https://phabricator.services.mozilla.com/D106674

Bug 1692809 - Move some word-break tests into WPT. r=jfkthame Actually, WPT has no some word-break tests for Japanese (ID and CJ) and Korean (Hangul Jamos). So I would like to move layout/reftests/text/wordbreak-2.html and layout/reftests/text/wordbreak-4a.html into WPT. Differential Revision: https://phabricator.services.mozilla.com/D105227

Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in intl/locale. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D106117

Bug 1692220 - Add a test to ensure the com.apple.FontRegistry dir is readable from content processes r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D105822

Bug 1693395 - Add XROutputColor:PrintAsGrayscale to the grayscale values for CUPS. r=jfkthame See bug 1676191 comment 32. Differential Revision: https://phabricator.services.mozilla.com/D105513

Bug 1692316 - Part 3: Document Duplex Printing Constants r=dholbert,jfkthame This patch attempts to add a clear explanation and mapping among the duplex-printing constants that vary across platforms. Differential Revision: https://phabricator.services.mozilla.com/D105512

Bug 1691875 Part 3 - Always compute inner table's border and padding before initializing its ReflowInput. r=layout-reviewers,jfkthame,mats This is a preparation patch for bug 1674302. We'll need border padding to reduce the size for inner table size overrides. Differential Revision: https://phabricator.services.mozilla.com/D104643

Bug 1691875 Part 2 - Pass the area occupied by caption into CreateReflowInputForInnerTable(). r=mats,jfkthame If the table wrapper frame has a caption, several sizes that are used to initialized inner table's ReflowInput needs to be reduced: 1. the available block-size, 2. containing block size, 3. StyleSizeOverrides (will be considered in bug 1674302). This patch gives CreateReflowInputForInnerTable() an argument to pass the space occupied by the caption in order to reduce the above sizes. Note the old code doesn't reduce the constrained available block-size when recreating ReflowInput for a table grid item, but this patch does. Also, this patch goes ahead to recreate ReflowInput when the area occupied by caption is non-empty, which may or may not affect the containing block size for grid item. But for now, I keep it simple because bug 16743202 is going to add logic that needs to recreate ReflowInput when there is any size overrides. I tend not to over-optimize the performance. Differential Revision: https://phabricator.services.mozilla.com/D104642

Bug 1691875 Part 1 - Split and rename nsTableWrapperFrame::ChildShrinkWrapISize() into two methods for caption and inner table. r=layout-reviewers,jfkthame This patch is similar to Bug 1690901 Part 2, but for ChildShrinkWrapISize(). https://hg.mozilla.org/mozilla-central/rev/33171dca5ccd Also, aCBSize should be passed by const-reference, not by value. Differential Revision: https://phabricator.services.mozilla.com/D104641

Bug 1691256 - Don't reflow for background/border changes on xul appearance values. r=jfkthame This is an optimization, but also papers about XUL widgets not dealing particularly well with it. Differential Revision: https://phabricator.services.mozilla.com/D105169