Bug 1789693 - Refactor gfxFont and gfxFontCache expiration tracking. r=jfkthame This patch reverts our behaviour closer to how we worked prior to bug 1780193. Parts of bug 1780193 remain because they are necessary to ensure there are no race conditions when interacting with the cache from multiple threads. Now we remove fonts from the expiration tracker when there are strong references remaining to the object. When the last strong reference is cleared, we readd the font to the expiration tracker. A lookup will remove it from the tracker (and creates a strong reference). If it expires from the tracker, it is then destroy. There are several race conditions we need to manage because the refcount can be updated without holding the gfxFontCache mutex. Differential Revision: https://phabricator.services.mozilla.com/D156716

Bug 1814696 - Hint directionality of label content for crop="start" labels. r=Gijs,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D168788

Bug 1814047 - Add a test for this bug. r=jfkthame Depends on D168491 Differential Revision: https://phabricator.services.mozilla.com/D168492

Bug 1814047 - Add support for testing print-background options on reftests. r=jfkthame Depends on D168382 Differential Revision: https://phabricator.services.mozilla.com/D168491

Bug 1814047 - Make buttons not ignore the "print backgrounds" setting. r=jfkthame,layout-reviewers We were ignoring print backgrounds, but still darkening colors, which obviously breaks. I tracked this down to bug 191574 / https://searchfox.org/mozilla-central/commit/0757c0a5b18b646554969a67eedf2bcb0ad41b63 > Make sure all caller have to pass in the "ignore 'print backgrounds' > Make block/inline _not_ ignore that pref Which was just preserving behavior. So this seems all rather accidental. Implement backgrounds for page / page sequence frame using print-color-adjust, and remove the virtual method. The XUL box removal stuff seems harmless. The only XUL boxes we have around in content are scrollbars, and we don't have scrollbars when printing. Differential Revision: https://phabricator.services.mozilla.com/D168382

Bug 1813865: Add 'Material Icons Extended' to the allowlist of known ligature icon fonts. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D168326

Bug 1811863 - Use a more precise RFP check in nsPresContext::UpdateFontVisibility. r=jfkthame Depends on D167822 Differential Revision: https://phabricator.services.mozilla.com/D167823

Bug 1810234 - Null-check in nsNumberControlFrame::SpinnerStateChanged. r=layout-reviewers,jfkthame I don't have a repro, but it doesn't seem too unbelievable that if the appearance changes mid-click we could end up with no spinners but a call here. Differential Revision: https://phabricator.services.mozilla.com/D167930

Bug 1809126 - Remove moz-fonttable protocol. r=jfkthame,necko-reviewers We only use it to generate a dummy URI for SVG-in-Opentype documents. We don't really need the URIs to be unique or anything in practice. I noticed this code while looking at the load flags set up for bug 1809006. Differential Revision: https://phabricator.services.mozilla.com/D166291

Bug 1809657: Start next line break chunk from start of previous search when no breaks found. r=jfkthame This means that we start from a known non-break and that we shouldn't be in any danger of causing false breaks once Uniscribe gets to unprocessed characters. This also makes the crash tests manual and debug only. Manual because now that the win32k pref is default on and not dynamic the tests will not run on try any more. Debug only so that we don't include code in opt builds that is only for manual tests. Differential Revision: https://phabricator.services.mozilla.com/D167271

Bug 1811240 - Clean up list interpolation code. r=jfkthame Factor out duplicated / common code to its own module, add / fix spec links, and clean-up callers. Differential Revision: https://phabricator.services.mozilla.com/D167253

Bug 1808997: Use an even font-size in WPT position-sticky-writing-modes.html, so that it's not laying out text with a fractional central baseline. r=jfkthame Before this patch, this test was using Ahem text with a 25px font-size and a vertical writing mode. The vertical writing-mode causes the text to be baseline-aligned using a *central* baseline, which ends up being at a half-pixel position, since our font-size is odd. Specifically: the central baseline is 25px/2 = 12.5px inwards from the edge of the glyph. The UA may choose to round this fractional central baseline to a whole pixel value when sizing/placing content, which in turn casues this test to fail with content being 1px away from where the test expects it to be. This patch addresses this issue by making the test use an even number as the font-size (30px), which produces a nice whole-number pixel value for the central basleine. This avoids creating a depending on the UA's choice of rounding behavior. This makes the test pass in Firefox, and I believe it continues to pass in other browsers where it was already passing. Differential Revision: https://phabricator.services.mozilla.com/D166232

Bug 1804812 - Allow authors to override listbox select overflow styles. r=jfkthame,layout-reviewers This matches what Chromium does, and seems generally better. Differential Revision: https://phabricator.services.mozilla.com/D165693

Bug 1808642 - adjust reftest expectations for windows 11. jfkthame r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D166205

Bug 1808182 - Use of uninitialised values originating from NS_GetComplexLineBreaks (in nsPangoBreaker.cpp). r=jfkthame. NS_GetComplexLineBreaks (in nsPangoBreaker.cpp) adds elements of type `PangoLogAttr` to an array with `attrBuffer.AppendElements(aLength + 1);`. However, `PangoLogAttr` doesn't have a default constructor, so those elements are uninitialised, and that eventually leaks back to the the caller, `ComplexBreaker::GetBreaks` and are used in a couple of different places after that. This patch fixes that by manually zeroing out the new area. Differential Revision: https://phabricator.services.mozilla.com/D165846

Bug 1503662 - Use used, rather than computed font-size for font-metric dependent units. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D165737

no bug - remove +x on dic files r=platform-i18n-reviewers,jfkthame DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D165680

Bug 1806167 - Always append the access key in uppercase. r=jfkthame,layout-reviewers Make accesskey reftest use modern box layout to test this code path. Differential Revision: https://phabricator.services.mozilla.com/D164942

Bug 1806764 - Update mapped_hyph to current master. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D165251

Bug 1798591. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D163295

Bug 1798591. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D163295

Bug 1803331 - skia/generator: remove SK_OUTLINE_EMBOLDEN_DIVISOR r=jfkthame DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D164566

Bug 1802957 - Allow to specify system fonts via prefs. r=jfkthame Much like we allow to do so with colors and ints/floats. Read a string pref for the font name, and a few float/bools for size/weight/italic, which is what our LookAndFeel back-end supports. Depends on D163270 Differential Revision: https://phabricator.services.mozilla.com/D163271

Bug 1802957 - Remove windows-specific condition for system font font-size adjustment. r=jfkthame Now that the non-native theme is everywhere, let's do this consistently across platforms. Note that these fonts aren't used for XUL anyways, so this shouldn't change behavior in practice. Depends on D163269 Differential Revision: https://phabricator.services.mozilla.com/D163270

Bug 1802957 - Remove non-standard and unused system font values. r=jfkthame And hide internal but used values. System fonts are not exposed in the computed style so this should be fine. If we need the old values for some obscure reason, it's trivial to alias them to e.g., menu or so. Differential Revision: https://phabricator.services.mozilla.com/D163269

Bug 1802957 - Allow to specify system fonts via prefs. r=jfkthame Much like we allow to do so with colors and ints/floats. Read a string pref for the font name, and a few float/bools for size/weight/italic, which is what our LookAndFeel back-end supports. Depends on D163270 Differential Revision: https://phabricator.services.mozilla.com/D163271

Bug 1802957 - Remove windows-specific condition for system font font-size adjustment. r=jfkthame Now that the non-native theme is everywhere, let's do this consistently across platforms. Note that these fonts aren't used for XUL anyways, so this shouldn't change behavior in practice. Depends on D163269 Differential Revision: https://phabricator.services.mozilla.com/D163270

Bug 1802957 - Remove non-standard and unused system font values. r=jfkthame And hide internal but used values. System fonts are not exposed in the computed style so this should be fine. If we need the old values for some obscure reason, it's trivial to alias them to e.g., menu or so. Differential Revision: https://phabricator.services.mozilla.com/D163269

Bug 1798494. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D162616

Bug 1792775 - Part 9: Handle new script codes in GetCommonFallbackFonts. r=platform-i18n-reviewers,jfkthame Use the fallback path for both new script codes. Differential Revision: https://phabricator.services.mozilla.com/D160187

Bug 1792775 - Part 8: Remove no longer needed ICU draft API guards. r=platform-i18n-reviewers,jfkthame `UDAT_STANDALONE_NARROW_QUARTERS` has been promoted from draft to stable. Differential Revision: https://phabricator.services.mozilla.com/D160186

Bug 1792775 - Part 7: Update Gecko to Unicode 15. r=platform-i18n-reviewers,jfkthame Update Gecko to Unicode 15 by running `genUnicodePropertyData.pl` and `genSpecialCasingData.pl`. Differential Revision: https://phabricator.services.mozilla.com/D160185

Bug 1792775 - Part 9: Handle new script codes in GetCommonFallbackFonts. r=platform-i18n-reviewers,jfkthame Use the fallback path for both new script codes. Differential Revision: https://phabricator.services.mozilla.com/D160187

Bug 1792775 - Part 8: Remove no longer needed ICU draft API guards. r=platform-i18n-reviewers,jfkthame `UDAT_STANDALONE_NARROW_QUARTERS` has been promoted from draft to stable. Differential Revision: https://phabricator.services.mozilla.com/D160186

Bug 1792775 - Part 7: Update Gecko to Unicode 15. r=platform-i18n-reviewers,jfkthame Update Gecko to Unicode 15 by running `genUnicodePropertyData.pl` and `genSpecialCasingData.pl`. Differential Revision: https://phabricator.services.mozilla.com/D160185

Bug 1792775 - Part 9: Handle new script codes in GetCommonFallbackFonts. r=platform-i18n-reviewers,jfkthame Use the fallback path for both new script codes. Differential Revision: https://phabricator.services.mozilla.com/D160187

Bug 1792775 - Part 8: Remove no longer needed ICU draft API guards. r=platform-i18n-reviewers,jfkthame `UDAT_STANDALONE_NARROW_QUARTERS` has been promoted from draft to stable. Differential Revision: https://phabricator.services.mozilla.com/D160186

Bug 1792775 - Part 7: Update Gecko to Unicode 15. r=platform-i18n-reviewers,jfkthame Update Gecko to Unicode 15 by running `genUnicodePropertyData.pl` and `genSpecialCasingData.pl`. Differential Revision: https://phabricator.services.mozilla.com/D160185

Bug 1800722: Let harfbuzz be managed by Updatebot r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D162146

Bug 1800722: Let harfbuzz be vendored by moz.yaml harfbuzz r=jfkthame This obsoletes update.sh so you now call ./mach vendor gfx/harfbuzz/moz.yaml It is set to track new tags. Differential Revision: https://phabricator.services.mozilla.com/D162145

Bug 1800722: Add a moz.yaml for harfbuzz r=jfkthame Depends on D162131 Differential Revision: https://phabricator.services.mozilla.com/D162144

Bug 1787551 - Disable Android's Font Match API on OPPO, realme and OnePlus. r=jfkthame According to crash data, some devices by OPPO and realme and OnePlus seem to crash when using Font Match API. I would like to disable it until root cause finds. Differential Revision: https://phabricator.services.mozilla.com/D162185

Bug 1799460 - Implement label[value] and start/end cropping with CSS rather than XUL layout. r=Gijs,jfkthame This reduces the weird interactions that can appear on menus. This also progresses BiDi support, including for accesskeys. Differential Revision: https://phabricator.services.mozilla.com/D161498

Bug 1800187 - Part 2: Refactor libpixman moz.build file. r=jfkthame * Remove workaround for a long-fixed LLVM bug * Remove extra flags on pixman-mmx.c * Remove unneeded -Winline flags * Drop SIMD exceptions for macOS * Use correct MMX define * Enable all SIMD optimizations for Intel builds * Clean up platform-specific logic * Enable aarch64 optimizations on Android & Linux Besides removing a lot of old cruft and improving general readability, this also re-enables MMX optimizations (the define changed upstream and wasn't updated in moz.build to reflect that) along with unconditionally compiling with all available Intel SIMD optimization levels. Pixman does runtime CPU feature detection, so this should be safe. It also enables AArch64 optimizations on Android and Linux. Depends on D161868 Differential Revision: https://phabricator.services.mozilla.com/D161869

Bug 1800187 - Part 1: Update libpixman to version 0.42.2. r=jfkthame Depends on D161867 Differential Revision: https://phabricator.services.mozilla.com/D161868

Bug 1800187 - Part 0: Clean up pixman patches. r=jfkthame Removes patches which are no longer being applied to our import and updates the patches that are applied to the current upstream. Differential Revision: https://phabricator.services.mozilla.com/D161867

Bug 1800072 - Remove special-case for XUL type="menu-button". r=jfkthame It broke in bug 1799343, and the TB folks are using type="menu", so let's remove this. Differential Revision: https://phabricator.services.mozilla.com/D161795

Bug 1799748 - Backport fix for libpixman CVE-2022-44638. r=jfkthame Backport of upstream commit: https://gitlab.freedesktop.org/pixman/pixman/-/commit/a1f88e842e0216a5b4df1ab023caebe33c101395 Differential Revision: https://phabricator.services.mozilla.com/D161624

Bug 1798953 part 2: Annotate gfxSkipCharsIterator as MOZ_STACK_CLASS. r=jfkthame In practice, it's only instantiated on the stack; and that's kinda important, to reduce the likelihood that it somehow outlives the 'gfxSkipChars' instance that it maintains a raw pointer to and is iterating over. Differential Revision: https://phabricator.services.mozilla.com/D159922

Bug 1798953 part 1: Initialize ClusterIterator::mIterator in the init list. r=jfkthame Before this patch, we implicitly invoke the default constructor for this member-var, and then immediately stomp on the results with a reassignment. This patch avoids that unnecessary usage of the default constructor, saving ourslves a bit of work and getting this member-var more directly into a fully-initialized/valid state. Differential Revision: https://phabricator.services.mozilla.com/D159903