searching for reviewer(jdescottes)
b15788319f82900902fd617a79599fe6883dd292: Bug 1662798 - [marionette] Port WebDriver:GetActiveElement to JSWindowActor r=marionette-reviewers,jdescottes,whimboo
Maja Frydrychowicz <mjzffr@gmail.com> - Fri, 25 Sep 2020 16:14:18 +0000 - rev 550366
Push 37812 by cbrindusan@mozilla.com at Fri, 25 Sep 2020 21:47:43 +0000
Bug 1662798 - [marionette] Port WebDriver:GetActiveElement to JSWindowActor r=marionette-reviewers,jdescottes,whimboo Differential Revision: https://phabricator.services.mozilla.com/D91327
7d03e78f456f2bb50fb94e45fe28a1915bb8e041: Bug 1660332 - [marionette] Port WebDriver:ElementClick to JSWindowActor. r=marionette-reviewers,jdescottes,maja_zf
Henrik Skupin <mail@hskupin.info> - Thu, 24 Sep 2020 19:53:30 +0000 - rev 550219
Push 37809 by apavel@mozilla.com at Fri, 25 Sep 2020 03:37:48 +0000
Bug 1660332 - [marionette] Port WebDriver:ElementClick to JSWindowActor. r=marionette-reviewers,jdescottes,maja_zf Differential Revision: https://phabricator.services.mozilla.com/D91006
7b2de9e57a768d949b569ac83fe5d58147e731b5: Bug 1662475 - [marionette] Port WebDriver:ElementClear to JSWindowActor r=marionette-reviewers,jdescottes,whimboo
Maja Frydrychowicz <mjzffr@gmail.com> - Wed, 23 Sep 2020 19:42:19 +0000 - rev 550144
Push 37808 by apavel@mozilla.com at Thu, 24 Sep 2020 21:53:48 +0000
Bug 1662475 - [marionette] Port WebDriver:ElementClear to JSWindowActor r=marionette-reviewers,jdescottes,whimboo Differential Revision: https://phabricator.services.mozilla.com/D90606
45e631b0acc8dfd334dafc404d110fdd17c37987: Bug 1663614 - Throttle resources on the client side from ResourceWatcher. r=jdescottes,bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 24 Sep 2020 11:04:57 +0000 - rev 550122
Push 37808 by apavel@mozilla.com at Thu, 24 Sep 2020 21:53:48 +0000
Bug 1663614 - Throttle resources on the client side from ResourceWatcher. r=jdescottes,bomsy Because of this, in netmonitor stubs tests, the resource objects ends up loosing "intermediate" state and now contains all information that we gathered by the time we emit throttled resources. The only way to address that would be to do an archived copy of each resource state, but I don't think we want to do that... Differential Revision: https://phabricator.services.mozilla.com/D89628
623937cef0c55f8dcc6fb6932ded4f2d6e290a71: Bug 1663614 - Do not use EventEmitter API in ResourceWatcher. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 24 Sep 2020 07:11:18 +0000 - rev 550121
Push 37808 by apavel@mozilla.com at Thu, 24 Sep 2020 21:53:48 +0000
Bug 1663614 - Do not use EventEmitter API in ResourceWatcher. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D90259
c6cd31e46c96adb8a4ce2e98846109013c13a9e8: Bug 1394354 - [marionette] Don't update capabilities synchronously in the framescript. r=marionette-reviewers,jdescottes,maja_zf
Henrik Skupin <mail@hskupin.info> - Wed, 23 Sep 2020 19:11:39 +0000 - rev 550050
Push 37807 by dluca@mozilla.com at Thu, 24 Sep 2020 09:34:15 +0000
Bug 1394354 - [marionette] Don't update capabilities synchronously in the framescript. r=marionette-reviewers,jdescottes,maja_zf To not cause extra synchronous IPC round-trips with the parent process each method in the framescript that needs capabilities would have to get those passed along with its call. This will reduce code complexity and safety because there is only a single object of truth. Also performance will be greatly improved for the affected commands. Differential Revision: https://phabricator.services.mozilla.com/D91125
2218f0b3f5341fa7402e02e9a2d78d570e883b21: Bug 1663649 - [devtools] Enable target switching by default. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 23 Sep 2020 17:50:20 +0000 - rev 550044
Push 37807 by dluca@mozilla.com at Thu, 24 Sep 2020 09:34:15 +0000
Bug 1663649 - [devtools] Enable target switching by default. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D91020
efc5aeff23bd99963e66e314ddd0104740a9d0e5: Bug 1665306 - Process "network updates" in console with only one `networkUpdateRequest` action call. r=jdescottes,nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 23 Sep 2020 11:29:38 +0000 - rev 549962
Push 37806 by btara@mozilla.com at Wed, 23 Sep 2020 21:23:16 +0000
Bug 1665306 - Process "network updates" in console with only one `networkUpdateRequest` action call. r=jdescottes,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D90394
303c768aa887e219ff26f7ccc87af7c0aad66838: Bug 1665305 - Process "message network updates" in console with only one `networkMessageUpdate` action call. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 23 Sep 2020 11:29:30 +0000 - rev 549961
Push 37806 by btara@mozilla.com at Wed, 23 Sep 2020 21:23:16 +0000
Bug 1665305 - Process "message network updates" in console with only one `networkMessageUpdate` action call. r=jdescottes This help modifying redux state only once and prevent many uncesarry copies of the whole messages/network events Maps. This will also later help getting rid of WebConsoleWrapper throttling in favor of upcoming ResourceWatcher one, as we could call only one action from onResourceAvailable/Updated. Differential Revision: https://phabricator.services.mozilla.com/D90367
d587f427a634b47f4fdb5ff000edd9a4700541fe: Bug 1665293 - Call WebConsoleWrapper methods only once from WebConsoleUI.onResourceAvailable/Updated. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 21 Sep 2020 16:46:42 +0000 - rev 549482
Push 37801 by malexandru@mozilla.com at Tue, 22 Sep 2020 03:47:42 +0000
Bug 1665293 - Call WebConsoleWrapper methods only once from WebConsoleUI.onResourceAvailable/Updated. r=jdescottes This will ultimately help get rid of throttling done in WebConsoleWrapper in favor of the upcoming one to be done from ResourceWatcher. Differential Revision: https://phabricator.services.mozilla.com/D90366
78f8c89ab46e381fc39b1571d3ed6d6dbf197c6c: Bug 1572662 - Remove unnecessary getRuleViewSelectorHighlighterIcon() from tests r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Wed, 16 Sep 2020 14:40:11 +0000 - rev 549262
Push 37793 by cbrindusan@mozilla.com at Fri, 18 Sep 2020 15:11:18 +0000
Bug 1572662 - Remove unnecessary getRuleViewSelectorHighlighterIcon() from tests r=jdescottes Depends on D90249 These calls to `getRuleViewSelectorHighlighterIcon` appear to [wait for the selector icon to be generated](https://searchfox.org/mozilla-central/rev/0c97a6410ff018c22e65a0cbe4e5f2ca4581b22e/devtools/client/inspector/rules/views/rule-editor.js#162-197) from an async operation. But they don't test anything to do with that DOM structure. Test seem to pass without it. Differential Revision: https://phabricator.services.mozilla.com/D90250
2d21e50aec091c4e8f1bfa0c7af973347af4be8e: Bug 1572662 - Update tests for SelectorHighlighter r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Thu, 17 Sep 2020 14:00:38 +0000 - rev 549261
Push 37793 by cbrindusan@mozilla.com at Fri, 18 Sep 2020 15:11:18 +0000
Bug 1572662 - Update tests for SelectorHighlighter r=jdescottes Depends on D90248 This patch combines two test helpers into one: removes `getRuleViewSelectorHighlighterIcon()` and folds its logic into `clickSelectorIcon()`. The other callsites for `getRuleViewSelectorHighlighterIcon()` are removed in D90250. The augmented `clickSelectorIcon()` will toggle the selector highlighter accordingly (on or off for the given selector depending on its current state). It returns a promise that resolves with the event data from either the "highlighter-hidden" or "highlighter-shown" events emitted by the selector highlighter. Tests check this data for the expected results. Tests no longer use mocks for selector highlighter. They test the real thing. Differential Revision: https://phabricator.services.mozilla.com/D90249
e133fd9557cf69e521d618465a84778ba374c787: Bug 1572662 - Update logic to toggle SelectorHighlighter from the new React-based Rules view r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Thu, 17 Sep 2020 12:43:16 +0000 - rev 549260
Push 37793 by cbrindusan@mozilla.com at Fri, 18 Sep 2020 15:11:18 +0000
Bug 1572662 - Update logic to toggle SelectorHighlighter from the new React-based Rules view r=jdescottes Depends on D90247 The new React-based Rules view is a stalled project, but not yet abandoned. This patch updates the logic to toggle the selector highlighter so it doesn't fall too far behind in parity with the legacy but still active Rules view. Flip this pref to test the new Rules view: `devtools.inspector.new-rulesview.enabled`. It will add a new Rules panel to the Inspector sidebar at the far right end of the tabs. To avoid confusion and bugs, disable 3-pane mode so you only see one Inspector sidebar panel at a time. Differential Revision: https://phabricator.services.mozilla.com/D90248
b5294440f415966b1d54771c30434c6db636fa6d: Bug 1572662 - Update logic to toggle SelectorHighlighter from Rules view r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Fri, 18 Sep 2020 10:34:08 +0000 - rev 549259
Push 37793 by cbrindusan@mozilla.com at Fri, 18 Sep 2020 15:11:18 +0000
Bug 1572662 - Update logic to toggle SelectorHighlighter from Rules view r=jdescottes Depends on D90246 This patch updates the logic to toggle the selector highlighter (icon next to CSS selectors in the Rules view) using the process-agnostic approach introduced in `HighlightersOverlay`. There are 3 main chunks of logic: - A) Introduce event delegation in the Rules view (`CssRuleView.handleEvent()`) - B) Introduce generic handler for highligther events in Rules view (`CssRuleView.handleHighlighterEvent()`) - C) Toggle the selector highlighter using the `HighlightersOverlay.showHighlighterTypeForNode()`/`HighlightersOverlay.hideHighlighterType()` methods with the `SELECTOR` highlighter type. ### Part A With Part A, CssRuleView.handleEvent(), we're laying the groundwork to have the Rules view react to events within its DOM tree. Currently, `HighlightersOverlay` is doing too much. Along with managing highlighters, it acts as an event delegate for the Rules view and Computed view via [HighlightersOverlay.addToView()](https://searchfox.org/mozilla-central/rev/0c97a6410ff018c22e65a0cbe4e5f2ca4581b22e/devtools/client/inspector/shared/highlighters-overlay.js#415-428). This adds [cumbersome logic to check the target](https://searchfox.org/mozilla-central/rev/0c97a6410ff018c22e65a0cbe4e5f2ca4581b22e/devtools/client/inspector/shared/highlighters-overlay.js#1402-1428) of an event in order to know whether to react to it. This isn't wrong per-se, but it concentrates DOM knowledge from a broad part of the Inspector away from where it is generated. Ideally, `HighlightersOverlay` should only manage highlighters. It should be called from various endpoints without regard to who is calling and in reaction to which events. The intent is to reuse this `CssRuleView.handleEvent()` for: - toggling the CSS Transforms Highlighter by reacting to mouseover events from corresponding CSS values - toggling the Flexbox / Grid / Shapes highlighters by reacting to clicks on corresponding swatch icons next to CSS values ### Part B Part B, `CssRuleView.handleHighlighterEvent()`, adds a generic highlighter event handler to the Rules view. Checking the event name and highlighter type, the Rules view can update itself in reaction to highlighters triggered from elsewhere in the Inspector. In this patch, we're using it to toggle the active CSS class name on the selector highlighter icon in response to "highlighter-shown" / "highlighter-hidden" events of the `SELECTOR` highlighter type. Probably a bit overkill here. But it gets more useful with the Flexbox and Grid Highlighters which have call sites in multiple places with indicators that need to be reconciled: - Flex/Grid badges in Markup view - Checkboxes in Layout panel - Swatch icons for Flex and Grid in Rules view ### Part C Part C replaces the legacy toggling logic for selector highlighter with the abstract methods in `HighligthersOverlay`, does some slight clean-up, and fixes some bugs in the previous implementation. All CSS rules matching the same selector will be marked when the selector is active (see inline comment) When editing a selector, the selector highlighter for another CSS rule will no longer be hidden (see inline comment) Differential Revision: https://phabricator.services.mozilla.com/D90247
3f98c27d224a94db32ddfe766e9ebdd18096fa51: Bug 1572662 - Clean-up SelectorHighlighter and clarify code comments r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Wed, 16 Sep 2020 10:09:11 +0000 - rev 549258
Push 37793 by cbrindusan@mozilla.com at Fri, 18 Sep 2020 15:11:18 +0000
Bug 1572662 - Clean-up SelectorHighlighter and clarify code comments r=jdescottes Depends on D90245 Differential Revision: https://phabricator.services.mozilla.com/D90246
eb8359116c4f3594102d7fa459486e4738d860ed: Bug 1572662 - Remove unused option to customize fill color on SelectorHighlighter and BoxModelHighlighter r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Wed, 16 Sep 2020 13:43:57 +0000 - rev 549257
Push 37793 by cbrindusan@mozilla.com at Fri, 18 Sep 2020 15:11:18 +0000
Bug 1572662 - Remove unused option to customize fill color on SelectorHighlighter and BoxModelHighlighter r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D90245
5d5f176f72311e83ed11791547f89aa0c4b17e53: Bug 1665306 - Process "network updates" in console with only one `networkUpdateRequest` action call. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 17 Sep 2020 17:51:56 +0000 - rev 549226
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1665306 - Process "network updates" in console with only one `networkUpdateRequest` action call. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D90394
241fc01aced8be0d9eb64b77d240d70d69fcd07c: Bug 1665305 - Process "message network updates" in console with only one `networkMessageUpdate` action call. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 17 Sep 2020 16:39:27 +0000 - rev 549225
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1665305 - Process "message network updates" in console with only one `networkMessageUpdate` action call. r=jdescottes This help modifying redux state only once and prevent many uncesarry copies of the whole messages/network events Maps. This will also later help getting rid of WebConsoleWrapper throttling in favor of upcoming ResourceWatcher one, as we could call only one action from onResourceAvailable/Updated. Differential Revision: https://phabricator.services.mozilla.com/D90367
5055331a7b6eaad0c0169b357aeaa1989c4feafd: Bug 1665293 - Call WebConsoleWrapper methods only once from WebConsoleUI.onResourceAvailable/Updated. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 17 Sep 2020 15:28:43 +0000 - rev 549224
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1665293 - Call WebConsoleWrapper methods only once from WebConsoleUI.onResourceAvailable/Updated. r=jdescottes This will ultimately help get rid of throttling done in WebConsoleWrapper in favor of the upcoming one to be done from ResourceWatcher. Differential Revision: https://phabricator.services.mozilla.com/D90366
cc3404de8f4d2498eb72ec22691b7bc5701f569b: Bug 1665341 - Remove obsolete BoxModelRenderer. r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Wed, 16 Sep 2020 14:05:30 +0000 - rev 548943
Push 37790 by btara@mozilla.com at Thu, 17 Sep 2020 10:09:40 +0000
Bug 1665341 - Remove obsolete BoxModelRenderer. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D90402
7e3fa8d62f2b61f867dca3baa4f195b34224cac3: Bug 1665307 - [marionette] Lazily load Log.get in all JS modules. r=marionette-reviewers,jdescottes
Henrik Skupin <mail@hskupin.info> - Wed, 16 Sep 2020 11:51:36 +0000 - rev 548896
Push 37790 by btara@mozilla.com at Thu, 17 Sep 2020 10:09:40 +0000
Bug 1665307 - [marionette] Lazily load Log.get in all JS modules. r=marionette-reviewers,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D90382
63b929aedf5f2776a068362414512d078d3362bb: Bug 1664438 - Ignore errors when destroying target scoped fronts. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 16 Sep 2020 08:15:03 +0000 - rev 548866
Push 37788 by ccoroiu@mozilla.com at Wed, 16 Sep 2020 15:37:38 +0000
Bug 1664438 - Ignore errors when destroying target scoped fronts. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D90237
a3c3c04383a512ab2339495a2573adf0efbecbc8: Bug 1664438 - Destroy pending protocol.js requests when a remote connector closes. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 16 Sep 2020 08:15:01 +0000 - rev 548865
Push 37788 by ccoroiu@mozilla.com at Wed, 16 Sep 2020 15:37:38 +0000
Bug 1664438 - Destroy pending protocol.js requests when a remote connector closes. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D90236
bcf6908307f71714798acb55a7e8b41e8a2b9bfb: Bug 1493108 - [marionette] Each command has to check the appropriate BrowsingContext for existence. r=marionette-reviewers,maja_zf,jdescottes
Henrik Skupin <mail@hskupin.info> - Tue, 15 Sep 2020 18:33:45 +0000 - rev 548795
Push 37787 by malexandru@mozilla.com at Wed, 16 Sep 2020 09:56:56 +0000
Bug 1493108 - [marionette] Each command has to check the appropriate BrowsingContext for existence. r=marionette-reviewers,maja_zf,jdescottes Given by the WebDriver specification each command has to check if the appropriate browsing context it operates in is still open. If it's not the case a "no such window" error will be thrown. Until now the code only checked the top-level browsing context for each of the supported commands. That means if the current browsing context was not open anymore a command running in a specific frame of the website has thrown unknown or type errors. That change makes our implementation WebDriver compliant. Differential Revision: https://phabricator.services.mozilla.com/D88951
de30f8e710b25c89c036ce6b39b936f24ca8a72f: Bug 1664393: Load all images in reps/ in devtools using chrome:. r=jdescottes
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Mon, 14 Sep 2020 12:24:07 +0000 - rev 548531
Push 37783 by rmaries@mozilla.com at Mon, 14 Sep 2020 21:29:41 +0000
Bug 1664393: Load all images in reps/ in devtools using chrome:. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D89883
e6c6a83c4de71878ccfa1b3a39d8ace923943695: Bug 1663847 part 2 - Change Debugger.Environment.callee getter to calleeScript getter. r=tcampbell,jdescottes
Jan de Mooij <jdemooij@mozilla.com> - Fri, 11 Sep 2020 09:24:34 +0000 - rev 548295
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1663847 part 2 - Change Debugger.Environment.callee getter to calleeScript getter. r=tcampbell,jdescottes The callee getter returned |undefined| for certain functions because it's hard to recover the callee consistently for all environments (and we can't return the internal canonical function). See also bug 1414684. This patch fixes that by exposing the script instead of the callee. Devtools is only interested in the displayName and parameterNames properties and those are also available on scripts (the previous patch adds Script.parameterNames). Differential Revision: https://phabricator.services.mozilla.com/D89701
87eb340508f76308d45d55b98bb84405ee02f15c: Bug 1664177: Load all images in devtools/client/debugger/images using chrome:. r=jdescottes
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Thu, 10 Sep 2020 17:04:35 +0000 - rev 548193
Push 37774 by nbeleuzu@mozilla.com at Fri, 11 Sep 2020 02:31:36 +0000
Bug 1664177: Load all images in devtools/client/debugger/images using chrome:. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D89727
19e4fcbb39f68de8098c8723e92d3b2f79a6715f: Bug 1646028 - Rename show/hide events for CssTransformHighlighter to avoid conflicts with generic highlighter events. r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Thu, 10 Sep 2020 12:00:17 +0000 - rev 548128
Push 37774 by nbeleuzu@mozilla.com at Fri, 11 Sep 2020 02:31:36 +0000
Bug 1646028 - Rename show/hide events for CssTransformHighlighter to avoid conflicts with generic highlighter events. r=jdescottes Depends on D85863 Follow-up for code review https://phabricator.services.mozilla.com/D81526#inline-471516 Renaming existing events emitted on behalf of `CssTransformHighlighter` to avoid conflict and confusion with the generic show/hide highlighter events introduced in HighlightersOverlay. When migrating the CssTransformHighlighter to the Fission-ready highlighters approach, these event names will go away completely. Differential Revision: https://phabricator.services.mozilla.com/D89570
75a8335648a8cc74b0ce0216fedef23d89cb7049: Bug 1646028 - Hide the correct Box Model Highlighter before a node screenshot. r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Thu, 10 Sep 2020 11:57:58 +0000 - rev 548127
Push 37774 by nbeleuzu@mozilla.com at Fri, 11 Sep 2020 02:31:36 +0000
Bug 1646028 - Hide the correct Box Model Highlighter before a node screenshot. r=jdescottes Depends on D85862 Differential Revision: https://phabricator.services.mozilla.com/D85863
42e5958e33ddfe0ccc288cf23423413b9129ec9f: Bug 1646028 - Fix Inspector tests using node reps to use Box Model Highlighter r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Thu, 10 Sep 2020 11:57:25 +0000 - rev 548126
Push 37774 by nbeleuzu@mozilla.com at Fri, 11 Sep 2020 02:31:36 +0000
Bug 1646028 - Fix Inspector tests using node reps to use Box Model Highlighter r=jdescottes Depends on D85861 Differential Revision: https://phabricator.services.mozilla.com/D85862
f244dea69b4b5eeda889302add411fcb1ac43c29: Bug 1646028 - Update Animation Inspector to use Box Model Highlighter r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Thu, 10 Sep 2020 11:57:12 +0000 - rev 548125
Push 37774 by nbeleuzu@mozilla.com at Fri, 11 Sep 2020 02:31:36 +0000
Bug 1646028 - Update Animation Inspector to use Box Model Highlighter r=jdescottes Depends on D85860 Differential Revision: https://phabricator.services.mozilla.com/D85861
ea3f6fd17ccfe2859c83a77b1d32544ce00359be: Bug 1646028 - Update Box Model diagram to use Box Model Highlighter. r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Thu, 10 Sep 2020 11:57:09 +0000 - rev 548124
Push 37774 by nbeleuzu@mozilla.com at Fri, 11 Sep 2020 02:31:36 +0000
Bug 1646028 - Update Box Model diagram to use Box Model Highlighter. r=jdescottes Depends on D85859 The Box Model diagram in the Layout sidebar panel of the Inspector shows a Box Model Highlighter on hover over its components parts: margin, border, padding, content. This patch routes the calls to the highlighter to use the approach introduced in `HighlightersOverlay` in D81526 Differential Revision: https://phabricator.services.mozilla.com/D85860
6faaa43b85818921c68924704046487d8028b1da: Bug 1646028 - Update Markup view to use Box Model Highlighter. r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Thu, 10 Sep 2020 11:55:57 +0000 - rev 548123
Push 37774 by nbeleuzu@mozilla.com at Fri, 11 Sep 2020 02:31:36 +0000
Bug 1646028 - Update Markup view to use Box Model Highlighter. r=jdescottes Depends on D85858 The Markup view uses the highlighter in a few places: - while hovering over nodes in the node tree - while hovering over nodes in the breadcrumbs view under the node tree - after clicking a node from the node tree, a highlighter is shown, then it is automatically hidden after a delay This patch routes all calls to show and hide the highlighter to the newly implemented approach in `HighlightersOverlay` which ensures hiding existing instances before showing others regardless of target. A slight change is made in `HighlightersOverlay` to allow passing in an option to automatically hide the highlighter after a delay. This removes the need for discrete handling of timers within the markup view (removes [_brieflyShowBoxModel](https://searchfox.org/mozilla-central/source/devtools/client/inspector/markup/markup.js#742-756)) and enables reusing this mechanism with the Node Picker after picking (see `onPickerPicked` in [this diff](https://phabricator.services.mozilla.com/D81528?vs=321451&id=332813#toc) from D81528) `HighlightersOverlay.showHighlighterTypeForNode()` no longer skips duplicate calls with the same highlighter type and nodeFront if the options provided are different between calls. This supports scheduling autohide on an already visible highlighter. Use case: in the node tree, hover over a node (shows highlighter), then click on the node (shows highlighter again, but schedules autohide after a delay) NOTE: This automatic hiding after a delay can cause intermittent test failures. Slow running tests can find themselves without a highlighter midway through the checks. To mitigate this, while testing, highlighters are not automatically hidden. See `HIGHLIGHTER_AUTOHIDE_TIMER` in [this diff](https://phabricator.services.mozilla.com/D81528?vs=321451&id=332813#toc) from D81528. Tests which explicitly check the autohide behavior can reinstate `inspector.HIGHLIGHTER_AUTOHIDE_TIMER`. Tests are updated to invoke actual highlighters and listen to their events. No more mocking. Differential Revision: https://phabricator.services.mozilla.com/D85859
1a827ef694de33cac19613abc21a808f499defa4: Bug 1646028 - Add test helpers for waiting on highlighter events r=jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Thu, 10 Sep 2020 11:55:03 +0000 - rev 548122
Push 37774 by nbeleuzu@mozilla.com at Fri, 11 Sep 2020 02:31:36 +0000
Bug 1646028 - Add test helpers for waiting on highlighter events r=jdescottes Depends on D81528 Differential Revision: https://phabricator.services.mozilla.com/D85858
41f041e761d2e17bbf017cdced0cb0bdba293e32: Bug 1646028 - Update Node Picker to use Box Model Highlighter. r=ochameau,jdescottes
Razvan Caliman <rcaliman@mozilla.com> - Thu, 10 Sep 2020 11:54:25 +0000 - rev 548121
Push 37774 by nbeleuzu@mozilla.com at Fri, 11 Sep 2020 02:31:36 +0000
Bug 1646028 - Update Node Picker to use Box Model Highlighter. r=ochameau,jdescottes Depends on D81526 This patch updates tests pertaining only to node picker behavior. Run one-by-one, they're all expected to pass. However, running the whole Inspector test suite at this point in the commit series will fail some other tests because: - we're updating shared test helpers here without also updating the other tests; - there is inter-dependence in the other tests between node picker and markup view which is being migrated to the new highlighters approach in D81530 The rest of the tests are getting updated in the subsequent patches in this commit series. Differential Revision: https://phabricator.services.mozilla.com/D81528
4652bdecc92cdeb19859073004b6bcbe8f429197: Bug 1663974 - Unwatch for resources when closing the debugger. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 09 Sep 2020 16:27:48 +0000 - rev 548090
Push 37773 by malexandru@mozilla.com at Thu, 10 Sep 2020 15:21:10 +0000
Bug 1663974 - Unwatch for resources when closing the debugger. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D89626
f45532667b4c56151535a6319582bf7402edec54: Bug 1663974 - Fix rebase, unwatch for network event stack trace resource. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 09 Sep 2020 16:25:11 +0000 - rev 548089
Push 37773 by malexandru@mozilla.com at Thu, 10 Sep 2020 15:21:10 +0000
Bug 1663974 - Fix rebase, unwatch for network event stack trace resource. r=jdescottes I'm slicing this in this bug. This new resource type was added while I added the code for calling unwatchResources... Differential Revision: https://phabricator.services.mozilla.com/D89625
b6b846f492368cae39462555a89939d57ad89f6c: Bug 1663873 - Unwatch for resources when closing the toolbox. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 09 Sep 2020 13:03:15 +0000 - rev 548088
Push 37773 by malexandru@mozilla.com at Thu, 10 Sep 2020 15:21:10 +0000
Bug 1663873 - Unwatch for resources when closing the toolbox. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D89560
b474cd9d95d866b820725265659446ca0650be46: Bug 1663873 - Unwatch for resources when closing the inspector. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 09 Sep 2020 11:55:02 +0000 - rev 548087
Push 37773 by malexandru@mozilla.com at Thu, 10 Sep 2020 15:21:10 +0000
Bug 1663873 - Unwatch for resources when closing the inspector. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D89559
0a79a1d1db874e4bc152988bde75fe7b1782b495: Bug 1616381 - Do not try to emit error packets when the actor is destoyed. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 10 Sep 2020 09:14:47 +0000 - rev 548086
Push 37773 by malexandru@mozilla.com at Thu, 10 Sep 2020 15:21:10 +0000
Bug 1616381 - Do not try to emit error packets when the actor is destoyed. r=jdescottes I also added another early return in order to avoid trying to send a method response if the actor is destroyed, as it isn't really useful and would also throw. Both ifs added by this changeset fixes the test failure independently of the other one. But I think we would benefit from both. The one in writeError would avoid throwing exception in the last change catch handler and so avoid unhandled promise rejections. The one in sendReturn probably helps having more meaningful error report! Differential Revision: https://phabricator.services.mozilla.com/D89682
d8e2f2a19b77b5a9e39717656ccd307d625a1b20: Bug 1663717 - Stop watching for resources in the console frontend. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 08 Sep 2020 20:49:54 +0000 - rev 547956
Push 37768 by dluca@mozilla.com at Wed, 09 Sep 2020 16:10:02 +0000
Bug 1663717 - Stop watching for resources in the console frontend. r=jdescottes It looks like we forgot to re-enable this code. Hopefully this doesn't break any test. Without that, DAMP is throwing because of late onResourceAvailable calls. This might tells us that the throttling should check if it is still relevant to emit the throttled event? I'm not having such check yet. Differential Revision: https://phabricator.services.mozilla.com/D89476
b84a7c4c8e68ff36bc31295abf05b1c14c6b9e2b: Bug 1663636 - Prevent trying to fetch font faces of destroyed node fronts. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 08 Sep 2020 16:31:03 +0000 - rev 547876
Push 37767 by dluca@mozilla.com at Wed, 09 Sep 2020 09:39:57 +0000
Bug 1663636 - Prevent trying to fetch font faces of destroyed node fronts. r=jdescottes This isn't really related to EventLoop, but this is another exception thrown when running DAMP. This time related to a request made against an already destroyed NodeFront. Differential Revision: https://phabricator.services.mozilla.com/D89451
e779fe9cf7f7bff75d901ae849c1638fb5eb0528: Bug 1663636 - Prevent trying to resume destroyed documents. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 08 Sep 2020 16:31:01 +0000 - rev 547875
Push 37767 by dluca@mozilla.com at Wed, 09 Sep 2020 09:39:57 +0000
Bug 1663636 - Prevent trying to resume destroyed documents. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D89450
8f4e13d50214f8fc198c99aee50effadda084862: Bug 1663567 - Fix browser_inspector_fission_frame_navigation.js failure on fission. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 08 Sep 2020 11:35:37 +0000 - rev 547832
Push 37765 by abutkovits@mozilla.com at Tue, 08 Sep 2020 16:13:32 +0000
Bug 1663567 - Fix browser_inspector_fission_frame_navigation.js failure on fission. r=jdescottes `navigateIframeTo` now returns a resource object. Differential Revision: https://phabricator.services.mozilla.com/D89438
9cca0967f023a7d11c33128ba6d633866bee1cf6: Bug 1660466 - Fix attaching target/thread test intermittents. r=jdescottes.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 02 Sep 2020 14:43:23 +0000 - rev 547473
Push 37750 by nerli@mozilla.com at Wed, 02 Sep 2020 21:57:21 +0000
Bug 1660466 - Fix attaching target/thread test intermittents. r=jdescottes. Move the function taking care of closing the Browser Console to shared-head so we can close it before closing the tabs opened during the test. While attaching the worker, check that the Worker Debugger isn't closed, and if it is, reject the promise. On the target list, catch rejection while attaching and simply bail out so we don't call the rest of the code in onTargetAvailable. Those guards are not enough to prevent any failure while attaching, so we're wrapping calls to `attachAndInitThread`/`_onThreadInitialized` in try/catch blocks to avoid test failures. Differential Revision: https://phabricator.services.mozilla.com/D88766
9b8ca74d313f9b7d8f445229036b6fc7d87b8fda: Bug 1662054 - Add a destroy function to targetList. r=jdescottes.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 02 Sep 2020 14:39:42 +0000 - rev 547472
Push 37750 by nerli@mozilla.com at Wed, 02 Sep 2020 21:57:21 +0000
Bug 1662054 - Add a destroy function to targetList. r=jdescottes. At the moment, we don't have any guards in the targetList to _not_ execute the creation/destruction listeners once the toolbox gets destroyed. We only have a stopListening function on the targetList that is called when we close the toolbox, but we can't rely only on that since it's also called when doing a target switch (and working around that is very racy). One solution would be to follow the common pattern we have everywhere by having a destroy method that we would check before trying to call the listeners callback. This might help with intermittent test failures. Differential Revision: https://phabricator.services.mozilla.com/D88765
9a55dbee660aa04ca170b03082e4edd58eb42c1e: Bug 1659589: Handle importing stylesheet from file using resource watcher mechanism to keep consistency. r=ochameau,devtools-backward-compat-reviewers,jdescottes
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 27 Aug 2020 22:31:52 +0000 - rev 546690
Push 37736 by apavel@mozilla.com at Fri, 28 Aug 2020 15:31:26 +0000
Bug 1659589: Handle importing stylesheet from file using resource watcher mechanism to keep consistency. r=ochameau,devtools-backward-compat-reviewers,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D87040
e45cf0154d7fbb8cbcc827ede0623231ddfe8e6d: Bug 1654218 - Consolidate style assignments into objects. r=nchevobbe,jdescottes
Cody Welsh <codyw@protonmail.com> - Tue, 25 Aug 2020 06:49:11 +0000 - rev 545910
Push 37730 by abutkovits@mozilla.com at Tue, 25 Aug 2020 15:44:12 +0000
Bug 1654218 - Consolidate style assignments into objects. r=nchevobbe,jdescottes Reduces explicit "elem.style.x = 'y' assignments by consolidating them into associated Objects, and using `Object.assign` to make the style modifications to the respective elements." Depends on D86866 Differential Revision: https://phabricator.services.mozilla.com/D86867
c8c45320ddaf91733777382ed02334ad77490427: Bug 1660032 - Make the JS Context selector scrollable. r=jdescottes,nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 21 Aug 2020 09:59:34 +0000 - rev 545865
Push 37728 by malexandru@mozilla.com at Tue, 25 Aug 2020 03:39:00 +0000
Bug 1660032 - Make the JS Context selector scrollable. r=jdescottes,nchevobbe I had to put it in toolbox.css as it wasn't working from EvaluationContextSelector.css. I imagine that's because the context DOM element are actually in toolbox document rather than the console one. Also, React must be re-creating all DOM elements anytime there is an update as you can see the list scroll up, everytime there is an update. We should probably have a look at that as well. Differential Revision: https://phabricator.services.mozilla.com/D87620
0fc6c987a4ba54316df080c65bcc5c4102cc6479: Bug 1657680 - Make the scrollable badge clickable and add click handler. r=gl,jdescottes,bradwerth
manas <manas.khurana20@gmail.com> - Sat, 22 Aug 2020 09:12:12 +0000 - rev 545717
Push 37721 by apavel@mozilla.com at Sat, 22 Aug 2020 21:38:08 +0000
Bug 1657680 - Make the scrollable badge clickable and add click handler. r=gl,jdescottes,bradwerth Differential Revision: https://phabricator.services.mozilla.com/D86245