searching for reviewer(jchen)
e19d324e5970979c11c697c600d60fc366314ed8: Bug 1493317 Part 2 - Enable AccessibleCaret in unit tests. r=jchen
Ting-Yu Lin <tlin@mozilla.com> - Sat, 16 Mar 2019 07:38:34 +0000 - rev 464481
Push 35716 by aciure@mozilla.com at Sun, 17 Mar 2019 09:42:17 +0000
Bug 1493317 Part 2 - Enable AccessibleCaret in unit tests. r=jchen And use correct AccessibleCaret preference to disable it individually in tests. Differential Revision: https://phabricator.services.mozilla.com/D10299
0bb898d00ed7b9d1bdaf3b4320cbc2ac5bca00fc: Bug 1485045 - Make Java parts of GeckoView independent from build ABI r=jchen
James Willcox <snorp@snorp.net> - Fri, 23 Nov 2018 20:32:40 +0000 - rev 447890
Push 35092 by dluca@mozilla.com at Sat, 24 Nov 2018 09:44:31 +0000
Bug 1485045 - Make Java parts of GeckoView independent from build ABI r=jchen This allows us to use the same Java code for any native platform, enabling a "fat" AAR. Differential Revision: https://phabricator.services.mozilla.com/D11497
bae43dfd3700460a55f3559eabbc888975f3a3c0: Bug 1485045 - Make Java parts of GeckoView independent from build ABI r=jchen
James Willcox <snorp@snorp.net> - Wed, 21 Nov 2018 15:22:06 +0000 - rev 447475
Push 35081 by ccoroiu@mozilla.com at Wed, 21 Nov 2018 21:41:51 +0000
Bug 1485045 - Make Java parts of GeckoView independent from build ABI r=jchen This allows us to use the same Java code for any native platform, enabling a "fat" AAR. Differential Revision: https://phabricator.services.mozilla.com/D11497
900cd4bf995f4b6a9651da7b9245f66b324e5847: Bug 1494713 - Add `HistoryDelegate` and wire up the Java history handlers. r=jchen,snorp
Lina Cambridge <lina@yakshaving.ninja> - Fri, 16 Nov 2018 17:32:04 +0000 - rev 446800
Push 35052 by apavel@mozilla.com at Sat, 17 Nov 2018 11:25:40 +0000
Bug 1494713 - Add `HistoryDelegate` and wire up the Java history handlers. r=jchen,snorp Differential Revision: https://phabricator.services.mozilla.com/D11291
a1fe5c7791a7fec71e6c3a6b7c362e5ec00ba49f: Bug 1494713 - Implement a `GeckoViewHistory` backend. r=jchen,snorp,smaug
Lina Cambridge <lina@yakshaving.ninja> - Fri, 16 Nov 2018 17:32:02 +0000 - rev 446799
Push 35052 by apavel@mozilla.com at Sat, 17 Nov 2018 11:25:40 +0000
Bug 1494713 - Implement a `GeckoViewHistory` backend. r=jchen,snorp,smaug Differential Revision: https://phabricator.services.mozilla.com/D11290
6644b6e14bde969270ccb646bb501a11221e3041: Bug 1494713 - Add `nsWindow::From`. r=jchen
Lina Cambridge <lina@yakshaving.ninja> - Fri, 16 Nov 2018 17:31:58 +0000 - rev 446798
Push 35052 by apavel@mozilla.com at Sat, 17 Nov 2018 11:25:40 +0000
Bug 1494713 - Add `nsWindow::From`. r=jchen Differential Revision: https://phabricator.services.mozilla.com/D11289
7174015fbbd584f9afa8783c1ac119ab3ac8bbf4: Bug 1485045 - Make Java parts of GeckoView independent from build ABI r=jchen
James Willcox <snorp@snorp.net> - Wed, 14 Nov 2018 17:48:58 +0000 - rev 446211
Push 35038 by rmaries@mozilla.com at Wed, 14 Nov 2018 22:12:17 +0000
Bug 1485045 - Make Java parts of GeckoView independent from build ABI r=jchen This allows us to use the same Java code for any native platform, enabling a "fat" AAR. Differential Revision: https://phabricator.services.mozilla.com/D11497
24e87b02707bee36e1e98eb37c94fbaf3834e898: Bug 1499418 - [3.2] Refactor and move Fennec's telemetry classes to geckoview/. r=jchen
Eugen Sawin <esawin@mozilla.com> - Tue, 13 Nov 2018 15:29:21 +0100 - rev 446036
Push 35033 by rgurzau@mozilla.com at Tue, 13 Nov 2018 21:46:24 +0000
Bug 1499418 - [3.2] Refactor and move Fennec's telemetry classes to geckoview/. r=jchen
8bc653b02e2f7aa97fc460cfa1dc1cd7e5e16302: Bug 1499418 - [1.3] Add GeckoView page load and startup performance telemetry probes. r=snorp,chutten,jchen
Eugen Sawin <esawin@mozilla.com> - Tue, 13 Nov 2018 15:39:11 +0100 - rev 446035
Push 35033 by rgurzau@mozilla.com at Tue, 13 Nov 2018 21:46:24 +0000
Bug 1499418 - [1.3] Add GeckoView page load and startup performance telemetry probes. r=snorp,chutten,jchen
46ddb51e149152ab2feb664e101474c3f406d4a8: Bug 1436754 - Merge LayerSession into GeckoSession; r=snorp,jchen
Agi Sferro <agi@mozilla.com> - Fri, 09 Nov 2018 17:04:38 +0000 - rev 445450
Push 35016 by rmaries@mozilla.com at Fri, 09 Nov 2018 21:48:23 +0000
Bug 1436754 - Merge LayerSession into GeckoSession; r=snorp,jchen Depends on D10990 Differential Revision: https://phabricator.services.mozilla.com/D10991
4c759f171cefc121537bfdcc2213a04effc72057: Bug 1498246 - Add GeckoView Media API r=rbarker,snorp,esawin,jchen,cvan
Imanol Fernandez <mortimergoro@gmail.com> - Fri, 09 Nov 2018 11:59:28 +0000 - rev 445419
Push 35015 by dluca@mozilla.com at Fri, 09 Nov 2018 17:45:20 +0000
Bug 1498246 - Add GeckoView Media API r=rbarker,snorp,esawin,jchen,cvan Add GeckoView Media API which provides a way to listen to HTMLMediaElement events in a GeckoSession and control the playback externally Differential Revision: https://phabricator.services.mozilla.com/D9026
a6b390c7b9791dfa760f9b09248ff84bd2a4c3e6: Bug 1498246 - Add GeckoView Media API r=rbarker,snorp,esawin,jchen,cvan
Imanol Fernandez <mortimergoro@gmail.com> - Thu, 08 Nov 2018 22:11:36 +0000 - rev 445212
Push 35012 by btara@mozilla.com at Fri, 09 Nov 2018 05:26:19 +0000
Bug 1498246 - Add GeckoView Media API r=rbarker,snorp,esawin,jchen,cvan Add GeckoView Media API which provides a way to listen to HTMLMediaElement events in a GeckoSession and control the playback externally Differential Revision: https://phabricator.services.mozilla.com/D9026
4f8d41b9bb67403c5021a9829ff9fae13ccc8b5c: Bug 1501648 - Prevent crashes for unregistered receivers from MmaDelegate and GeckoMediaControlAgent; r=jchen,JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 08 Nov 2018 12:08:40 +0000 - rev 445118
Push 35010 by btara@mozilla.com at Thu, 08 Nov 2018 18:47:03 +0000
Bug 1501648 - Prevent crashes for unregistered receivers from MmaDelegate and GeckoMediaControlAgent; r=jchen,JanH Although this two receivers are guarded by checks for if they were initialized (and so registered) there are reports of crashes because of trying to unregister them without them actually being registered. The underlying issue will be investigated further in bug 1505685 but for the moment wrapping the unregister operations in a try-catch saves the users from a crash and because the unregister is done when the app is closed (for the MmaDelegate receiver) or when the app finished playing media (for the GeckoMediaControlAgent receiver) the user doesn't loose any functionality going forward. Differential Revision: https://phabricator.services.mozilla.com/D11177
60659171e4140a2e38b05d7c85cb2747a83e2964: Bug 1498246 - Add GeckoView Media API r=rbarker,snorp,esawin,jchen,cvan
Imanol Fernandez <mortimergoro@gmail.com> - Thu, 08 Nov 2018 01:37:56 +0000 - rev 445116
Push 35010 by btara@mozilla.com at Thu, 08 Nov 2018 18:47:03 +0000
Bug 1498246 - Add GeckoView Media API r=rbarker,snorp,esawin,jchen,cvan Add GeckoView Media API which provides a way to listen to HTMLMediaElement events in a GeckoSession and control the playback externally Differential Revision: https://phabricator.services.mozilla.com/D9026
fe3f1d254a1ffcb5f074bca1ec63f358e9f26118: Bug 1502187 - Implement Java part of viewport tree caching. r=jchen
Eitan Isaacson <eitan@monotonous.org> - Mon, 05 Nov 2018 22:35:35 +0000 - rev 444696
Push 35001 by ncsoregi@mozilla.com at Wed, 07 Nov 2018 09:52:11 +0000
Bug 1502187 - Implement Java part of viewport tree caching. r=jchen Depends on D9866 Differential Revision: https://phabricator.services.mozilla.com/D9867
70def5ae1d1128924c54f104fff71c5fbf337f9f: Bug 1502187 - Add FULL_ACCESSIBILITY_TREE to GeckoSessionSettings. r=jchen
Eitan Isaacson <eitan@monotonous.org> - Tue, 06 Nov 2018 17:04:12 +0000 - rev 444694
Push 35001 by ncsoregi@mozilla.com at Wed, 07 Nov 2018 09:52:11 +0000
Bug 1502187 - Add FULL_ACCESSIBILITY_TREE to GeckoSessionSettings. r=jchen Defaults now to 'true', when caching is good enough I'll switch it off. Generally, this would be used for apps/cases when full accessible tree is needed like UIAutomator. Depends on D9864 Differential Revision: https://phabricator.services.mozilla.com/D9865
1fafb01078dbb3602bcdac29d40f91f67f71fba3: Bug 1498233 - Stub out getBrowserForOuterWindowID for GeckoViewTab. r=jchen
Mike Conley <mconley@mozilla.com> - Tue, 06 Nov 2018 04:35:00 +0000 - rev 444673
Push 35001 by ncsoregi@mozilla.com at Wed, 07 Nov 2018 09:52:11 +0000
Bug 1498233 - Stub out getBrowserForOuterWindowID for GeckoViewTab. r=jchen GeckoViewTab stubs out gBrowser on the root window for WebExtension compatibility. LoginManagerParent also looks for gBrowser on windows that are handling username and password form fills, and expects it to implement getBrowserForOuterWindowID. This patch makes the stub implement getBrowserForOuterWindowID, which just returns the lone GeckoViewTab browser. Differential Revision: https://phabricator.services.mozilla.com/D10750
91f7f603954c1b7265bb8746dfd2d656e376981a: Bug 1405081 - Add WebRequest, WebResponse, and GeckoWebExecutor to GeckoView r=jchen,esawin
James Willcox <snorp@snorp.net> - Thu, 18 Oct 2018 08:28:09 -0500 - rev 443977
Push 34977 by dvarga@mozilla.com at Thu, 01 Nov 2018 22:29:07 +0000
Bug 1405081 - Add WebRequest, WebResponse, and GeckoWebExecutor to GeckoView r=jchen,esawin This exposes Gecko networking to GeckoView apps. It includes speculative connections, name resolution, and a Fetch-like HTTP API. Differential Revision: https://phabricator.services.mozilla.com/D7799 squash to executor
e24c0262f83ecdeb93ec0571df7528a377a4779e: Bug 1405081 - Move default timeout logic into Environment utility class r=jchen
James Willcox <snorp@snorp.net> - Tue, 16 Oct 2018 13:23:05 -0500 - rev 443975
Push 34977 by dvarga@mozilla.com at Thu, 01 Nov 2018 22:29:07 +0000
Bug 1405081 - Move default timeout logic into Environment utility class r=jchen Differential Revision: https://phabricator.services.mozilla.com/D8781
778ef7a62d5d321ce67b0c2ed06b79006e308e8b: Bug 1405081 - Move GeckoSessionTestRule.waitForResult() into UiThreadUtils r=jchen
James Willcox <snorp@snorp.net> - Tue, 16 Oct 2018 13:22:26 -0500 - rev 443974
Push 34977 by dvarga@mozilla.com at Thu, 01 Nov 2018 22:29:07 +0000
Bug 1405081 - Move GeckoSessionTestRule.waitForResult() into UiThreadUtils r=jchen Differential Revision: https://phabricator.services.mozilla.com/D7798
5fda5eb5fd01b8c4d77ed10279d931665c4e86f7: Bug 1405081 - Add WebRequestError and use it in NavigationDelegate.onLoadError r=esawin,jchen
James Willcox <snorp@snorp.net> - Tue, 16 Oct 2018 13:21:49 -0500 - rev 443973
Push 34977 by dvarga@mozilla.com at Thu, 01 Nov 2018 22:29:07 +0000
Bug 1405081 - Add WebRequestError and use it in NavigationDelegate.onLoadError r=esawin,jchen Differential Revision: https://phabricator.services.mozilla.com/D7797
017c51559d4afdbe3478b38d2585ec5566787965: Bug 1405081 - Move GeckoRuntime creation out of GeckoSesionTestRule r=jchen
James Willcox <snorp@snorp.net> - Thu, 04 Oct 2018 17:47:14 -0500 - rev 443972
Push 34977 by dvarga@mozilla.com at Thu, 01 Nov 2018 22:29:07 +0000
Bug 1405081 - Move GeckoRuntime creation out of GeckoSesionTestRule r=jchen This allows us to easily share a GeckoRuntime with other tests that don't use GeckoSessionTestRule. Differential Revision: https://phabricator.services.mozilla.com/D7796
9cfb0bf7cb66ab1b53492550d88832821b74be54: Bug 1485718 - Enable setting of javascript on GeckoView sessions through `GeckoSessionSettings.` r=jchen
Emily Toop <etoop@mozilla.com> - Thu, 01 Nov 2018 12:45:37 +0000 - rev 443914
Push 34976 by dvarga@mozilla.com at Thu, 01 Nov 2018 22:26:55 +0000
Bug 1485718 - Enable setting of javascript on GeckoView sessions through `GeckoSessionSettings.` r=jchen This is a resubmission due to issues landing old one. Not sure if this needs a re-review? Old review: https://phabricator.services.mozilla.com/D8093. This has now been closed so I cannot update it. Differential Revision: https://phabricator.services.mozilla.com/D10199
3992a5ddbac3421ba1ecba0a95e7649644db2b38: Bug 1502435 - 3 - Update tests to include checks for canary clientId; r=jchen
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 31 Oct 2018 01:14:57 +0200 - rev 443605
Push 34963 by aciure@mozilla.com at Wed, 31 Oct 2018 05:07:31 +0000
Bug 1502435 - 3 - Update tests to include checks for canary clientId; r=jchen
5cb4e28e1eb88a03a8a707f53f97cbf4cfe45b12: Bug 1502435 - 2 - Include new `bug_1501329_affected` property in the core ping; r=jchen
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 31 Oct 2018 01:13:57 +0200 - rev 443604
Push 34963 by aciure@mozilla.com at Wed, 31 Oct 2018 05:07:31 +0000
Bug 1502435 - 2 - Include new `bug_1501329_affected` property in the core ping; r=jchen Summary: Depends on D10202 Reviewers: jchen Reviewed By: jchen Subscribers: jchen, janerik Bug #: 1502435 Differential Revision: https://phabricator.services.mozilla.com/D10205
e0a9b2e68b8f8554bd1c410f3def294b2084eeea: Bug 1502435 - 1 - Set valid clientId and save if previous was canary clientId; r=jchen
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 30 Oct 2018 16:28:02 +0000 - rev 443582
Push 34963 by aciure@mozilla.com at Wed, 31 Oct 2018 05:07:31 +0000
Bug 1502435 - 1 - Set valid clientId and save if previous was canary clientId; r=jchen Differential Revision: https://phabricator.services.mozilla.com/D10202
ef5037b7a3cdabb2bee19adcc36186e9d279ea8e: Bug 1501571 - Update <Product and feature tips> setting summary when disabled; r=jchen
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 29 Oct 2018 16:24:10 +0000 - rev 443360
Push 34954 by rgurzau@mozilla.com at Mon, 29 Oct 2018 22:00:12 +0000
Bug 1501571 - Update <Product and feature tips> setting summary when disabled; r=jchen Needed to allow localizers more control over what needs to be translated in a String that contains another already translated String that should be bolded. Differential Revision: https://phabricator.services.mozilla.com/D9629
8d38810fdc7309de2520fb9b36abbb09767a4bee: Bug 1497526 - TransactionTooLargeException when downloading from Data URLs; r=jchen
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 26 Oct 2018 07:39:01 +0000 - rev 443100
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1497526 - TransactionTooLargeException when downloading from Data URLs; r=jchen The issue stems from putting download's source url as `cookie` in the pending intent for when the download notification is clicked. This cookie functions like a tag, allowing to identify a particular download. The problem is that a download's url can be a Data URL for which Mozilla imposes no size limit. When an Android Intent with that payload is used it counts against Binder's 1MB limit which can result in the TransactionTooLargeException. If we are to truncate download's source url to an arbitrary length of 100 we should still get a unique `cookie` for that download and at the same time avoid cluttering Notification's contentIntent. Differential Revision: https://phabricator.services.mozilla.com/D9666
73cfb79f183ac786b56dd97e63e969642ed0919f: Bug 1500906 - Suppress FileUriExposedExceptions when launching helper apps. r=jchen
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 24 Oct 2018 16:00:06 +0000 - rev 442825
Push 34924 by rgurzau@mozilla.com at Wed, 24 Oct 2018 21:58:52 +0000
Bug 1500906 - Suppress FileUriExposedExceptions when launching helper apps. r=jchen Sharing tabs with file:// URIs is not possible, but users can still send them to other apps via the helper app system in the URL bar/context menu. "Intent:Open" and "Intent:OpenForResult" are both sent from Gecko by HelperApps.jsm. The same reasoning as in bug 1450449 applies as to why for publicly accessible files content:// URIs are more trouble than they're worth. Differential Revision: https://phabricator.services.mozilla.com/D9420
a263875f2a4c7c1b02445f9b90cb4ed9c3875c8a: Bug 1500511 - Fix javadoc issue in GeckoRuntimeSettings. r=jchen.
Agi Sferro <agi@mozilla.com> - Wed, 24 Oct 2018 15:58:39 +0000 - rev 442802
Push 34924 by rgurzau@mozilla.com at Wed, 24 Oct 2018 21:58:52 +0000
Bug 1500511 - Fix javadoc issue in GeckoRuntimeSettings. r=jchen. Differential Revision: https://phabricator.services.mozilla.com/D9295
307ddcb2187bd1a1f95e537d745c7dfc4de11d24: Bug 1485718 - Enable setting of javascript on GeckoView sessions through `GeckoSessionSettings.` r=jchen
Emily Toop <etoop@mozilla.com> - Tue, 23 Oct 2018 15:40:30 +0000 - rev 442589
Push 34914 by aiakab@mozilla.com at Tue, 23 Oct 2018 22:16:27 +0000
Bug 1485718 - Enable setting of javascript on GeckoView sessions through `GeckoSessionSettings.` r=jchen Differential Revision: https://phabricator.services.mozilla.com/D8093
6eaed80ae36ffeaffe0bad1e969e5c92e1c9922c: Bug 1459864 - Modify <Product and feature tips> setting summary when disabled; r=jchen
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 19 Oct 2018 14:25:57 +0000 - rev 442188
Push 34890 by dvarga@mozilla.com at Sat, 20 Oct 2018 09:40:11 +0000
Bug 1459864 - Modify <Product and feature tips> setting summary when disabled; r=jchen Inform the user about why is this feature disabled and what to do to enable it. Differential Revision: https://phabricator.services.mozilla.com/D8545
b9614de52765a2da6de9eb067c2431c9517b95cd: Bug 1499895 - [2.1] Update onLoadRequest tests. r=jchen
Eugen Sawin <esawin@mozilla.com> - Thu, 18 Oct 2018 23:51:56 +0200 - rev 442085
Push 34887 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:11:55 +0000
Bug 1499895 - [2.1] Update onLoadRequest tests. r=jchen
45e3efb5e07666bd7e6e7bb0c0db34aa2cd75b4a: Bug 1499895 - [1.3] Add triggering URI to onLoadRequest. r=snorp,jchen
Eugen Sawin <esawin@mozilla.com> - Wed, 17 Oct 2018 10:06:42 +0200 - rev 442084
Push 34887 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:11:55 +0000
Bug 1499895 - [1.3] Add triggering URI to onLoadRequest. r=snorp,jchen
740c3623a44aed64203d830a03682e14f90917f9: Bug 1496745 - Allow GeckoResult to be used without a Looper r=agi,jchen
James Willcox <snorp@snorp.net> - Thu, 18 Oct 2018 18:01:18 +0000 - rev 441952
Push 34880 by csabou@mozilla.com at Thu, 18 Oct 2018 21:53:44 +0000
Bug 1496745 - Allow GeckoResult to be used without a Looper r=agi,jchen GeckoResult can now be created on a thread with no Looper present. You can use `then` as before after creating a derived GeckoResult with a Handler via `withHandler`, or poll for the value via the new `poll` method. Differential Revision: https://phabricator.services.mozilla.com/D7896
50cc3c94b20d7ba104fc24b887e15064cad69d41: Bug 1499188 - Make accessibility entry input type an int in bundle message. r=jchen,Jamie
Eitan Isaacson <eitan@monotonous.org> - Tue, 16 Oct 2018 16:43:16 +0000 - rev 441951
Push 34880 by csabou@mozilla.com at Thu, 18 Oct 2018 21:53:44 +0000
Bug 1499188 - Make accessibility entry input type an int in bundle message. r=jchen,Jamie Differential Revision: https://phabricator.services.mozilla.com/D8871
222a23f1044ac44b3c2defb9b816bb80b90fd0b6: Bug 1499182 - Make Android role class names enums. r=jchen,Jamie
Eitan Isaacson <eitan@monotonous.org> - Wed, 17 Oct 2018 20:43:49 +0000 - rev 441777
Push 34876 by ebalazs@mozilla.com at Thu, 18 Oct 2018 10:19:51 +0000
Bug 1499182 - Make Android role class names enums. r=jchen,Jamie Differential Revision: https://phabricator.services.mozilla.com/D8764
2fee8f9b283dac85340edf7815fd62b93352bd33: Bug 1496745 - Allow GeckoResult to be used without a Looper r=agi,jchen
James Willcox <snorp@snorp.net> - Tue, 16 Oct 2018 18:21:40 +0000 - rev 441694
Push 34873 by dluca@mozilla.com at Wed, 17 Oct 2018 22:54:14 +0000
Bug 1496745 - Allow GeckoResult to be used without a Looper r=agi,jchen GeckoResult can now be created on a thread with no Looper present. You can use `then` as before after creating a derived GeckoResult with a Handler via `withHandler`, or poll for the value via the new `poll` method. Differential Revision: https://phabricator.services.mozilla.com/D7896
af27cdf736f592782bb9f6d0a0bff62222a55e3e: Bug 1495786 - Replace ambiguous Booleans with AllowOrDeny, an enum with clearly named values. r=snorp,jchen
Dylan Roeh <droeh@mozilla.com> - Tue, 16 Oct 2018 12:23:42 -0500 - rev 441517
Push 34867 by shindli@mozilla.com at Wed, 17 Oct 2018 00:55:53 +0000
Bug 1495786 - Replace ambiguous Booleans with AllowOrDeny, an enum with clearly named values. r=snorp,jchen
7413b2c7cdb4f45da50d2130a9403978977a36ed: Bug 1498854 - Rework dismissing of TabHistoryFragment. r=jchen
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 16 Oct 2018 16:17:18 +0000 - rev 441488
Push 34866 by shindli@mozilla.com at Wed, 17 Oct 2018 00:54:47 +0000
Bug 1498854 - Rework dismissing of TabHistoryFragment. r=jchen 1. The patch from bug 1476710 was nonsense and had the same effect as simply deleting that line, because the ChildFragmentManager is only of interest if the TabHistoryFragment loaded further Fragments itself. 2. The issue at hand is that under some circumstances the TabHistoryFragment will be trying to dismiss itself while its responsible FragmentManager is already busy transacting some Fragment state changes. More precisely, the fact that the Fragment is calling popBackStack*Immediately*, which isn't allowed if the FragmentManager is already handling some other transaction. 3. The dismiss() calls in response to the onClick() handlers are unproblematic, because they won't trigger any FragmentManager activity through any route other than the dismiss() call itself. 4. The dismiss() calls in onPause() *are* problematic because the Fragment- Manager will already be busy pausing the TabHistoryFragment, so triggering a further synchronous transaction is not allowed (and originally caused bug 1476710). 5. If the onPause() call happened because some external entity was attempting to remove the fragment (either BrowserApp directly, or indirectly by forwarding a back button press to the FragmentManager), then the Fragment trying to additionally remove itself is unnecessary. 6. If the onPause() call happens because the containing activity itself is being paused, then the Fragment being dismissed is the desired outcome (see bug 1093209), however the Fragment won't be able to remove itself because a) A synchronous transaction is illegal at that point in time. b) An async transaction would be possible, but might not complete until after onSaveInstanceState() had subsequently already been called, which again would be illegal because of state loss. c) An async transaction allowing state loss would succeed in any case, but would mean that if BrowserApp was subsequently destroyed while in back- ground and then later recreated from the savedInstanceState, the Tab- HistoryFragment would be recreated as well, which is undesired. 7. Therefore, the only way to dismiss the TabHistoryFragment when the containing activity is pausing is to synchronously dismiss the Fragment from inside the activity, *before* the onPause() call is forwarded to the FragmentManager. 8. Calling dismiss() in response to onDestroy() is unnecessary, because the Fragment is already irrevocably being removed as soon as we hit onPause(). 9. Because it doesn't make sense to have multiple TabHistoryFragments active at the same time, we also change the logic such that any attempt to show a new TabHistoryFragment will now replace the previous fragment. This is also useful in view of the fact that in order to close the Fragment, BrowserApp retrieves it by calling findFragmentByTag(), which simply returns the first matching Fragment, i.e. wouldn't properly handle things if we ever accidentally ended up with multiple Fragment instances active at the same time. Differential Revision: https://phabricator.services.mozilla.com/D8680
8eaeb557ba9f438afb0d6a7bd3bfc19f7b6df098: Bug 1498849 - Check for SDK compatibility on CollectionInfo.obtain(). r=jchen
Eitan Isaacson <eitan@monotonous.org> - Tue, 16 Oct 2018 16:00:15 +0000 - rev 441486
Push 34866 by shindli@mozilla.com at Wed, 17 Oct 2018 00:54:47 +0000
Bug 1498849 - Check for SDK compatibility on CollectionInfo.obtain(). r=jchen One method signature was introduced in API 19, and another, with selectionMode was introduced in 21. Differential Revision: https://phabricator.services.mozilla.com/D8788
f992e8a4e7e61a599e8007bf6dfdcb15a3b132f8: Bug 1005268 - Remove "datetime" UI from Fennec and fix capitalization issue r=jchen
Rob Wu <rob@robwu.nl> - Tue, 16 Oct 2018 15:57:26 +0000 - rev 441484
Push 34866 by shindli@mozilla.com at Wed, 17 Oct 2018 00:54:47 +0000
Bug 1005268 - Remove "datetime" UI from Fennec and fix capitalization issue r=jchen `<input type=datetime>` was dropped from the spec many years ago, and is not supported by the platform. To JS code, it looks like a regular text input box. With removed support for "datetime" inputs, we can also fix a bug in the InputWidgetHelper. Due to the use of getAttribute, if the attribute value was capitalized, then the special date/time picker UI would not be shown. This is corrected by using the "type" property instead. I verified on Android Nougat that all other input types (date, datetime-local, week, month, time) still work as intended. Depends on D8668 Differential Revision: https://phabricator.services.mozilla.com/D8666
12fcdbe6ef8d97441fe879432bd664bf1c048ba4: Bug 1498787 - Support seconds in time inputs r=jchen
Rob Wu <rob@robwu.nl> - Tue, 16 Oct 2018 15:59:24 +0000 - rev 441483
Push 34866 by shindli@mozilla.com at Wed, 17 Oct 2018 00:54:47 +0000
Bug 1498787 - Support seconds in time inputs r=jchen When a time input expects seconds, e.g. via `<input type=time step=1>`, then the UI should show a way to input seconds. On Nougat, `data:text/html,<input type=time step=1>`, the UI used to show a clock to select hours and minutes. As of this commit, three spinners are shown (HH mm ss), and if 24-hour mode is disabled, four of them (HH mm ss AM). Depends on D8667 Differential Revision: https://phabricator.services.mozilla.com/D8668
d530c99c2be5dc8f5cfa39f1f965bb9751f274e2: Bug 1498787 - Support seconds in datetime-local inputs r=jchen
Rob Wu <rob@robwu.nl> - Tue, 16 Oct 2018 16:04:08 +0000 - rev 441482
Push 34866 by shindli@mozilla.com at Wed, 17 Oct 2018 00:54:47 +0000
Bug 1498787 - Support seconds in datetime-local inputs r=jchen The "seconds" field is now supported for type="datetime-local". Examples, tested on Android Nougat (7.0): ``` No seconds because step is a whole minute: data:text/html,<input type="datetime-local" step="60"> No seconds because datetime is not a supported type (it is treated like input type=text by the DOM, but somehow a datepicker still appears): data:text/html,<input type="datetime" step="0"> Seconds because step is a second: data:text/html,<input type="datetime-local" step="1"> ``` The UI looks only slightly different: After "HH mm" there is now a "ss" spinner, optionally followed by AM/PM. Differential Revision: https://phabricator.services.mozilla.com/D8667
dbab4e3611fb95778c944fc66ab9edca42c88133: Bug 1351308 - Ensure sanitizing before shutdown; r=jchen
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 12 Oct 2018 15:46:02 +0000 - rev 440903
Push 34840 by dvarga@mozilla.com at Fri, 12 Oct 2018 21:54:33 +0000
Bug 1351308 - Ensure sanitizing before shutdown; r=jchen Need to use the already initialized instance of DownloadIntegration, which has an already initialized DownloadStore to actually store the updated list of downloads. Differential Revision: https://phabricator.services.mozilla.com/D8403
d1adf0333d63a102d7e91c887586da7219c0d650: Bug 1493864 - Assign site notifications to a dedicated notification channel. r=jchen
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 12 Oct 2018 12:08:51 +0000 - rev 440853
Push 34837 by ncsoregi@mozilla.com at Fri, 12 Oct 2018 16:56:54 +0000
Bug 1493864 - Assign site notifications to a dedicated notification channel. r=jchen Bug 1378445 made those audible and we want to preserve the behaviour. Differential Revision: https://phabricator.services.mozilla.com/D8113
b57be7d7343c78e4484b03d98c4a1a21e03ea941: Bug 1493864 - Assign site notifications to a dedicated notification channel. r=jchen
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 10 Oct 2018 19:44:01 +0000 - rev 440770
Push 34832 by nbeleuzu@mozilla.com at Fri, 12 Oct 2018 03:43:40 +0000
Bug 1493864 - Assign site notifications to a dedicated notification channel. r=jchen Bug 1378445 made those audible and we want to preserve the behaviour. Differential Revision: https://phabricator.services.mozilla.com/D8113
d41905041ca7f615f90fce70e1de3c325e490c44: Bug 1479037 - Introduce native event support 4/4. r=jchen,yzen?jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 11 Oct 2018 16:22:11 +0000 - rev 440734
Push 34832 by nbeleuzu@mozilla.com at Fri, 12 Oct 2018 03:43:40 +0000
Bug 1479037 - Introduce native event support 4/4. r=jchen,yzen?jamie Depends on D6683 Differential Revision: https://phabricator.services.mozilla.com/D6684
dab75afa1e1e7e10abb5f7c7931d3fd889778fe8: Bug 1479037 - Remove virtual content node, js autofill, and event support 2/4. r=jchen,yzen
Eitan Isaacson <eitan@monotonous.org> - Thu, 11 Oct 2018 16:21:01 +0000 - rev 440732
Push 34832 by nbeleuzu@mozilla.com at Fri, 12 Oct 2018 03:43:40 +0000
Bug 1479037 - Remove virtual content node, js autofill, and event support 2/4. r=jchen,yzen Disabled most jsunit tests temporarily in this patch. Will modify and bring them back up in later patches, as stuff is reimplemented. Disabled most jsat mochitests. Will have a followup for but re├źnabling or porting, depending on the test. Depends on D6681 Differential Revision: https://phabricator.services.mozilla.com/D6682
e9dfaf584e37774a7cfc24242ebb02c11539be97: Bug 1478735 Download with target=_blank switches to other tab target=_blank r=JanH,jchen
Andrei Lazar <andrei.a.lazar@softvision.ro> - Wed, 10 Oct 2018 09:49:07 +0000 - rev 440436
Push 34820 by dvarga@mozilla.com at Wed, 10 Oct 2018 16:07:50 +0000
Bug 1478735 Download with target=_blank switches to other tab target=_blank r=JanH,jchen Download with target=_blank now switches to the parent tab. Differential Revision: https://phabricator.services.mozilla.com/D6928