searching for reviewer(hsivonen)
381a74484140c4183bc8d3b094848a95214795ed: Bug 1315460 - Removal of keygen element r=keeler,baku,jld,hsivonen
Jonathan Kingston <jkt@mozilla.com> - Thu, 13 Jun 2019 08:58:07 +0000 - rev 478642
Push 36148 by shindli@mozilla.com at Thu, 13 Jun 2019 21:50:57 +0000
Bug 1315460 - Removal of keygen element r=keeler,baku,jld,hsivonen Differential Revision: https://phabricator.services.mozilla.com/D22810
4e074fb721487359c4e9cfbafef213f2741b1bdd: Bug 1558546, ensure range element has a frame before starting drag operation, r=hsivonen
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 12 Jun 2019 15:53:48 +0000 - rev 478516
Push 36145 by aciure@mozilla.com at Thu, 13 Jun 2019 03:50:31 +0000
Bug 1558546, ensure range element has a frame before starting drag operation, r=hsivonen This should be the minimal patch to fix the issue (should be safe for branches too). Reusing an existing mouse/touch test for the crash testing. Differential Revision: https://phabricator.services.mozilla.com/D34717
13c976344b699aab96156c7dedd8c41413c8ad69: Bug 1557254 - Enable char range check on Nightly/DevEdition and make warnings more dire. r=hsivonen
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Tue, 11 Jun 2019 13:27:16 +0000 - rev 478335
Push 36140 by dluca@mozilla.com at Wed, 12 Jun 2019 12:02:49 +0000
Bug 1557254 - Enable char range check on Nightly/DevEdition and make warnings more dire. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D34287
55fd70d72e0873ecc75240956253288d3df4345b: Bug 1556746 - Remove kCharsetFromHintPrevDoc that have been accidentally restored by resolving merge conflict. r=hsivonen
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Tue, 04 Jun 2019 14:47:34 +0000 - rev 476822
Push 36108 by nbeleuzu@mozilla.com at Tue, 04 Jun 2019 21:42:40 +0000
Bug 1556746 - Remove kCharsetFromHintPrevDoc that have been accidentally restored by resolving merge conflict. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D33642
022a6145be0779ab26a2bd164987f084e895068c: Bug 1554589 - Turn nsCharsetSource constants into an enum. r=hsivonen
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Mon, 03 Jun 2019 09:13:50 +0000 - rev 476595
Push 36104 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:45:41 +0000
Bug 1554589 - Turn nsCharsetSource constants into an enum. r=hsivonen Since unscoped enums implicitly convert to underlying types, we don't have to change everything at once. It is worth enough to introduce auto-numbering, IMO. Differential Revision: https://phabricator.services.mozilla.com/D32841
445271e41b4a242bff39e0ad5a515697c1357119: Bug 1554222: delegate serializing in `nsDocumentEncoder` depending on encoding scope to separate methods. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 27 May 2019 07:50:19 +0000 - rev 475686
Push 36072 by dluca@mozilla.com at Tue, 28 May 2019 09:38:00 +0000
Bug 1554222: delegate serializing in `nsDocumentEncoder` depending on encoding scope to separate methods. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D32486
b9a2470096c313f2f210f04782b5dd97ae43d5a0: Bug 1554147: default initialize member in `EncodedDocumentWithContext`. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 27 May 2019 07:24:37 +0000 - rev 475685
Push 36072 by dluca@mozilla.com at Tue, 28 May 2019 09:38:00 +0000
Bug 1554147: default initialize member in `EncodedDocumentWithContext`. r=hsivonen Just for consistency. Differential Revision: https://phabricator.services.mozilla.com/D32469
7cf8441c08b6f9491985ecdcffdf87d372987d33: Bug 1554147: rename `mCommonParent` and encapsulate `mStartDepth` and `mEndDepth` in `ContextInfoDepth`. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 27 May 2019 07:45:15 +0000 - rev 475684
Push 36072 by dluca@mozilla.com at Tue, 28 May 2019 09:38:00 +0000
Bug 1554147: rename `mCommonParent` and encapsulate `mStartDepth` and `mEndDepth` in `ContextInfoDepth`. r=hsivonen In order to simplify `nsDocumentEncoder`. Differential Revision: https://phabricator.services.mozilla.com/D32468
0cdcafff0e52f5355747ee52f9413422bce21399: Bug 1553766: encapsulate range boundary specific members of `nsDocumentEncoder` and free their memory in `nsDocumentEncoder::Initialize`. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Thu, 23 May 2019 14:47:10 +0000 - rev 475207
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1553766: encapsulate range boundary specific members of `nsDocumentEncoder` and free their memory in `nsDocumentEncoder::Initialize`. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D32304
6e0badbe0b1dc0ac395fbe42d9308238de0e2f17: Bug 1553480: make resetting members of nsIDocumentEncoder consistent r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Thu, 23 May 2019 10:22:15 +0000 - rev 475183
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1553480: make resetting members of nsIDocumentEncoder consistent r=hsivonen Moreover, prepone deleting the cached serializer with LAST_RELEASE already. Differential Revision: https://phabricator.services.mozilla.com/D32286
227b93441c8360a43e05c58402ccd27d3dd30e63: Bug 1553122: split off encoding scope of `nsDocumentEncoder` to separate class. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Wed, 22 May 2019 08:39:02 +0000 - rev 474949
Push 36052 by btara@mozilla.com at Thu, 23 May 2019 04:37:46 +0000
Bug 1553122: split off encoding scope of `nsDocumentEncoder` to separate class. r=hsivonen In order to clean up `nsDocumentEncoder`. Differential Revision: https://phabricator.services.mozilla.com/D32102
0e382475292d9801921403db032eb0e9dba31c12: Bug 1552752: Part 2) Rename `ConvertAndWrite` to `EncodeAndWrite` and slighlty simplify method. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Tue, 21 May 2019 07:36:49 +0000 - rev 474676
Push 36044 by rmaries@mozilla.com at Tue, 21 May 2019 15:45:34 +0000
Bug 1552752: Part 2) Rename `ConvertAndWrite` to `EncodeAndWrite` and slighlty simplify method. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D31768
2aadfad018d5d63ecdc95c5c2ca15ebf4c9406d9: Bug 1552869: propagate `nsresult` values of various `Append*` calls in `SerializeNodeStart`, `SerializeNodeEnd` r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Tue, 21 May 2019 05:38:20 +0000 - rev 474674
Push 36044 by rmaries@mozilla.com at Tue, 21 May 2019 15:45:34 +0000
Bug 1552869: propagate `nsresult` values of various `Append*` calls in `SerializeNodeStart`, `SerializeNodeEnd` r=hsivonen Might helpt to discover and prevent bugs. Differential Revision: https://phabricator.services.mozilla.com/D31798
acf1896be423cca5678a9f10dcd793974b204231: Bug 1552752: Part 1) Split off text streaming in `nsDocumentEncoder` to separate class. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Tue, 21 May 2019 05:38:06 +0000 - rev 474673
Push 36044 by rmaries@mozilla.com at Tue, 21 May 2019 15:45:34 +0000
Bug 1552752: Part 1) Split off text streaming in `nsDocumentEncoder` to separate class. r=hsivonen Abstracts the streaming details away. Reduces complexity of `nsDocumentEncoder`. Differential Revision: https://phabricator.services.mozilla.com/D31767
bb69a96aea8403f807a74652168c71c97da6fbeb: Bug 1550845. Don't terminate the old parser, if we have one, in document.open() until after we remove event listeners. r=hsivonen
Boris Zbarsky <bzbarsky@mit.edu> - Sun, 12 May 2019 02:47:58 +0000 - rev 474570
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1550845. Don't terminate the old parser, if we have one, in document.open() until after we remove event listeners. r=hsivonen This way we won't accidentally run script during termination, hopefully. Differential Revision: https://phabricator.services.mozilla.com/D30763
c27a9d7837349ab8b0a49e00892346c5a1351d21: Bug 325352 part 2. Don't no-op document.open if our parser has a script nesting level equal to 0. r=hsivonen
Boris Zbarsky <bzbarsky@mit.edu> - Sun, 12 May 2019 02:47:58 +0000 - rev 474569
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 325352 part 2. Don't no-op document.open if our parser has a script nesting level equal to 0. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D30314
68b3e0acc50371007c682e55c79158d98d6325ae: Bug 1550524 part 3. Remove the now-unused aContentType argument to nsHtml5Parser::Parse. r=hsivonen
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 14 May 2019 19:46:26 +0000 - rev 474555
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1550524 part 3. Remove the now-unused aContentType argument to nsHtml5Parser::Parse. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D30752
3eef21fc64b778f57aaa416f2b0c2ed469033a10: Bug 1550524 part 2. Add an explicit StartExecutor method on nsHtml5Parser, for use from document.open(). r=hsivonen
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 14 May 2019 19:46:26 +0000 - rev 474554
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1550524 part 2. Add an explicit StartExecutor method on nsHtml5Parser, for use from document.open(). r=hsivonen The code has mostly moved, but there are a few simplifications: 1) If !GetStreamParser(), then GetChannel() always returns null and hence we never set isSrcdoc to true. Which is good, because we don't want to apply the special srcdoc-parsing rules to document.open() stuff. So we just pass false to setIsSrcdocDocument(): It's the same behavior as before, but a lot clearer. I've confirmed that code coverage says the "isSrcdoc = NS_IsSrcdocChannel(channel)" line is unreached in our tests. 2) In the document.write-after-document.open case, aContentType is now always "text/html" (because that's what document.open sets mContentTypeForWriteCalls to. So the block checking for it not being "text/html" was dead code (also confirmed via code coverage results) and I'm just removing it. Differential Revision: https://phabricator.services.mozilla.com/D30751
0c1f4aee5de04bbef034b98f39c4e367b34cc5ba: Bug 1550524 part 1. Make NewHtml5Parser() return an nsHtml5Parser. r=hsivonen
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 14 May 2019 19:46:25 +0000 - rev 474553
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1550524 part 1. Make NewHtml5Parser() return an nsHtml5Parser. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D30750
63a8fe448f092dcf0f5a70d72b27909a8aec6280: Bug 1550881. Prevent document.open() calls from descendant subframes' unload handlers triggered by document.open() from doing anything useful. r=hsivonen
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 17 May 2019 12:45:35 +0000 - rev 474549
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1550881. Prevent document.open() calls from descendant subframes' unload handlers triggered by document.open() from doing anything useful. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D30728
1d9f4477a199f8c33b520683384a11f22b4e51ce: Bug 1552490: rename `nsCopySupport::HTMLCopy`, change `nsDocumentEncoder::IsVisible`, add unit to buffer size name. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 20 May 2019 07:43:43 +0000 - rev 474472
Push 36040 by rgurzau@mozilla.com at Mon, 20 May 2019 13:43:21 +0000
Bug 1552490: rename `nsCopySupport::HTMLCopy`, change `nsDocumentEncoder::IsVisible`, add unit to buffer size name. r=hsivonen Because it states more clearly what the functions and the constant are about. Differential Revision: https://phabricator.services.mozilla.com/D31615
2c353f21c1dce7f28d8a35594f4628b38d5a1bbd: Bug 1550671: split `SelectionCopyHelper` to more informative functions r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Wed, 15 May 2019 12:14:12 +0000 - rev 474221
Push 36027 by shindli@mozilla.com at Fri, 17 May 2019 16:24:38 +0000
Bug 1550671: split `SelectionCopyHelper` to more informative functions r=hsivonen The name `SelectionCopyHelper` didn't state what the function does. Now, instead of `SelectionCopyHelper`, the following two call sequences exist: 1) `EncodeDocumentWithContext`, `PutToClipboard`. 2) `EncodeDocumentWithContextAndCreateTransferable`, calling `EncodeDocumentWithContext` and `CreateTransferable`. Apart from additional nullptr checks, the semantics didn't change. Differential Revision: https://phabricator.services.mozilla.com/D31044
2fe5b3d2dca7c1883b6e6d4bca81da5dc349733b: Bug 1551857: declare static methods of `nsHTMLCopyEncoder` as such r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Wed, 15 May 2019 13:22:30 +0000 - rev 473920
Push 36019 by dvarga@mozilla.com at Wed, 15 May 2019 21:30:39 +0000
Bug 1551857: declare static methods of `nsHTMLCopyEncoder` as such r=hsivonen Simplifies reasoning about the code. Differential Revision: https://phabricator.services.mozilla.com/D31240
66cff9aa39bcbf1b39aaf21c6759d1c97ad2fe1b: Bug 1174452: Part 2 -- scan `nsTextNode`'s parent element for preformat in nsDocumentEncoder r=masayuki,hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Thu, 09 May 2019 07:40:47 +0000 - rev 473754
Push 36013 by csabou@mozilla.com at Tue, 14 May 2019 16:01:08 +0000
Bug 1174452: Part 2 -- scan `nsTextNode`'s parent element for preformat in nsDocumentEncoder r=masayuki,hsivonen This takes into account `white-space: pre` style of `nsTextNode`'s parent element when formatting the selected text of the `nsTextNode` node. Differential Revision: https://phabricator.services.mozilla.com/D29159
fe847bf289767657759062cf54d5a93a1f12c6fb: Bug 1174452: Part 1 -- test collapsing and extending selection before copy-pasting for `style="white-space: pre` r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Thu, 09 May 2019 07:40:37 +0000 - rev 473753
Push 36013 by csabou@mozilla.com at Tue, 14 May 2019 16:01:08 +0000
Bug 1174452: Part 1 -- test collapsing and extending selection before copy-pasting for `style="white-space: pre` r=hsivonen This closer mimics user behaviour, compared to the existing tests using `getSelection().selectAllChildren`. Differential Revision: https://phabricator.services.mozilla.com/D28850
08eb61c337951a2f136faa08b029e34234aae08b: Bug 1550811. Back out the second part of the fix for bug 325352 until we have a fix for the crash issues it causes. r=hsivonen
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 11 May 2019 13:52:27 +0000 - rev 473541
Push 36001 by cbrindusan@mozilla.com at Sun, 12 May 2019 09:30:34 +0000
Bug 1550811. Back out the second part of the fix for bug 325352 until we have a fix for the crash issues it causes. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D30682
264fe248bca56c113116bd5cfde490ebb554e56a: Bug 325352 part 2. Don't no-op document.open if our parser has a script nesting level equal to 0. r=hsivonen
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 08 May 2019 16:03:37 +0000 - rev 473094
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 325352 part 2. Don't no-op document.open if our parser has a script nesting level equal to 0. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D30314
990c8a382cf38762b2d81bbcba3c56e1b9920bec: Bug 325352 part 1. Align our "defined insertion point" concept more closely with the spec's "script nesting level" concept. r=hsivonen
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 08 May 2019 06:10:47 +0000 - rev 473093
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 325352 part 1. Align our "defined insertion point" concept more closely with the spec's "script nesting level" concept. r=hsivonen This also exposes an accessor for whether the parser has a nonzero script nesting level. Differential Revision: https://phabricator.services.mozilla.com/D30313
b5344f8392c0bae8dd62280f3b608b1f907f6568: Bug 1549696: factor out functionality to determine fixup node in nsDocumentEncoder. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Wed, 08 May 2019 11:09:51 +0000 - rev 473043
Push 35986 by opoprus@mozilla.com at Wed, 08 May 2019 21:49:24 +0000
Bug 1549696: factor out functionality to determine fixup node in nsDocumentEncoder. r=hsivonen In order to reduce code duplication and make the code more legible. Differential Revision: https://phabricator.services.mozilla.com/D30199
59306f187449c5f35614f7e86293dd53ec1f5422: Bug 1549283: add missing calls to `SerializeNodeEnd` r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Mon, 06 May 2019 13:49:53 +0000 - rev 472767
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1549283: add missing calls to `SerializeNodeEnd` r=hsivonen In order to have one call of `SerializeNodeEnd` for every `SerializeNodeStart` call. In the current state of the code, the absence of these calls doesn't cause bugs, but this can change anytime `SerializeNodeEnd` is changed. Moreover, it makes it simpler to reason about the code. Differential Revision: https://phabricator.services.mozilla.com/D29987
4abfc5c2a4ee418302a99a2662a78f88b84d44b9: Bug 1533673 - Allow APZ to send fission matrices with the GPU process. r=hsivonen
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 06 May 2019 16:17:55 +0000 - rev 472713
Push 35976 by opoprus@mozilla.com at Mon, 06 May 2019 21:44:12 +0000
Bug 1533673 - Allow APZ to send fission matrices with the GPU process. r=hsivonen With the IPC fix in the previous patch this seems to work now. Differential Revision: https://phabricator.services.mozilla.com/D29942
676cf3a452c659ff68c89200770fd9fe7cd9d8f5: Bug 1524232 - Add a mechanism for dispatching synthesized mousemove events to an OOP iframe. r=hsivonen
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 06 May 2019 08:12:21 +0000 - rev 472676
Push 35976 by opoprus@mozilla.com at Mon, 06 May 2019 21:44:12 +0000
Bug 1524232 - Add a mechanism for dispatching synthesized mousemove events to an OOP iframe. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D29731
f92e2f3f7fa9b920780230a3db4695ecb15d55eb: Bug 1540551 - Disable window height tests failing on Windows 7 DevEdition r=hsivonen
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 06 May 2019 05:42:51 +0000 - rev 472669
Push 35976 by opoprus@mozilla.com at Mon, 06 May 2019 21:44:12 +0000
Bug 1540551 - Disable window height tests failing on Windows 7 DevEdition r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D29948
735492db6be1230705cbda8c45c5b115414bc2a1: Bug 1539003 - update InternalHeaders get/set/append/delete to match the spec; r=hsivonen
Thomas Wisniewski <twisniewski@mozilla.com> - Tue, 16 Apr 2019 06:34:05 +0000 - rev 469657
Push 35878 by apavel@mozilla.com at Tue, 16 Apr 2019 15:43:40 +0000
Bug 1539003 - update InternalHeaders get/set/append/delete to match the spec; r=hsivonen update Fetch InternalHeaders get/set/append/delete to match the spec Differential Revision: https://phabricator.services.mozilla.com/D27531
fb2348a826fb04245e8863536815febddf8f8627: Bug 1541598 - Have FetchBody::SetMimeType convert from ByteStrings to UTF8 CStrings to not corrupt Unicode values; r=hsivonen
Thomas Wisniewski <twisniewski@mozilla.com> - Sun, 14 Apr 2019 15:02:39 +0000 - rev 469437
Push 35868 by nbeleuzu@mozilla.com at Sun, 14 Apr 2019 21:47:46 +0000
Bug 1541598 - Have FetchBody::SetMimeType convert from ByteStrings to UTF8 CStrings to not corrupt Unicode values; r=hsivonen Have FetchBody::SetMimeType convert from ByteStrings to UTF8 CStrings to not corrupt Unicode values Differential Revision: https://phabricator.services.mozilla.com/D26011
a5fe792348ed187dd06b3047d18e731f4dd4b227: Bug 1542019 - Split the dispatch-to-content flag into three. r=botond,hsivonen
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 11 Apr 2019 13:31:53 +0000 - rev 469001
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1542019 - Split the dispatch-to-content flag into three. r=botond,hsivonen This patch extracts two additional CompositorHitTestInfo flags from the eDispatchToContent flag; eApzAwareListeners for elements that have APZ-aware listeners, and eInactiveScrollframe for inactive scrollframe or unlayerized scrollthumbs. The eDispatchToContent is then renamed to eIrregularArea to reflect the fact that it is used for irregular-shaped areas that require main-thread hit-testing. Additionally, it is important to note that when using the non-WebRender codepath, all three of these flags still end up gettings squashed into the "dispatch to content" region on the EventRegions; when APZ reconstructs a CompositorHitTestInfo it will turn anything in this region back into an eIrregularArea. So this is a lossy round-trip conversion for the non-WebRender case. However it should still result in correct behaviour because the semantics of eIrregularArea result in APZ relying on the main-thread to do hit-testing and so any APZ-aware listeners and inactive scrollframes are also handled by the main-thread. Differential Revision: https://phabricator.services.mozilla.com/D26440
517e71d9bccc900b144fde4bb53acbd9051bfa67: bug 1520711 - EME key system constants are used with UTF-8 functions where ASCII functions would do r=hsivonen,jya
Khyati Agarwal <f20160385@hyderabad.bits-pilani.ac.in> - Tue, 09 Apr 2019 08:02:24 +0000 - rev 468497
Push 35841 by csabou@mozilla.com at Tue, 09 Apr 2019 16:23:02 +0000
bug 1520711 - EME key system constants are used with UTF-8 functions where ASCII functions would do r=hsivonen,jya EME key system constants are used with UTF-8 functions where ASCII functions would do Differential Revision: https://phabricator.services.mozilla.com/D25730
d73129a2b182f4419cd975574ab493d050beeb6d: Bug 1541138 - Update MimeType.cpp to consider HTTP whitespace, not ASCII whitespace; r=hsivonen
Thomas Wisniewski <twisniewski@mozilla.com> - Fri, 05 Apr 2019 16:08:53 +0000 - rev 468232
Push 35824 by apavel@mozilla.com at Sat, 06 Apr 2019 10:57:50 +0000
Bug 1541138 - Update MimeType.cpp to consider HTTP whitespace, not ASCII whitespace; r=hsivonen Update MimeType.cpp to consider HTTP whitespace, not ASCII whitespace Differential Revision: https://phabricator.services.mozilla.com/D25863
edeb3a9d5b066127224b93e9c209b6b67640a402: Bug 1541024 - parser/ automated ESLint no-throw-literal fixes. r=hsivonen
Ian Moody <moz-ian@perix.co.uk> - Fri, 05 Apr 2019 11:31:01 +0000 - rev 468129
Push 35820 by btara@mozilla.com at Fri, 05 Apr 2019 16:17:46 +0000
Bug 1541024 - parser/ automated ESLint no-throw-literal fixes. r=hsivonen Result of running: $ mach eslint -funix parser/ | sed -Ee 's/:.+//' - | xargs sed -E \ -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \ -e 's/throw \(/throw new Error(/g' -i Differential Revision: https://phabricator.services.mozilla.com/D25757
3ebf6f2a81387d7087ef235c3ce60452baf550f3: Bug 1495880 - update our cors/no-cors header safelisting to match the Fetch spec; r=hsivonen,ckerschb a=reland
Thomas Wisniewski <twisniewski@mozilla.com> - Mon, 01 Apr 2019 05:20:15 +0000 - rev 467423
Push 35798 by csabou@mozilla.com at Tue, 02 Apr 2019 04:07:40 +0000
Bug 1495880 - update our cors/no-cors header safelisting to match the Fetch spec; r=hsivonen,ckerschb a=reland update XHR cors/no-cors header safelisting to match the Fetch spec Differential Revision: https://phabricator.services.mozilla.com/D7771
aaedb3306c2e4444ff3b89fff1ea701fcd9ec6b8: Bug 1495880 - update our cors/no-cors header safelisting to match the Fetch spec; r=hsivonen,ckerschb
Thomas Wisniewski <twisniewski@mozilla.com> - Mon, 01 Apr 2019 05:20:15 +0000 - rev 467043
Push 35795 by csabou@mozilla.com at Mon, 01 Apr 2019 21:54:51 +0000
Bug 1495880 - update our cors/no-cors header safelisting to match the Fetch spec; r=hsivonen,ckerschb update XHR cors/no-cors header safelisting to match the Fetch spec Differential Revision: https://phabricator.services.mozilla.com/D7771
710481a0ddfa6826b5d06e93d683547f4da97402: Bug 1534878 - xpcom: Re-enable NonASCII16 UTF-16 string tests. r=hsivonen
Chris Peterson <cpeterson@mozilla.com> - Sun, 24 Feb 2019 21:45:15 -0800 - rev 464365
Push 35714 by apavel@mozilla.com at Sat, 16 Mar 2019 09:47:26 +0000
Bug 1534878 - xpcom: Re-enable NonASCII16 UTF-16 string tests. r=hsivonen The NonASCII16 test function was removed in bug 1402247 but the NonASCII16_helper() function was not: https://hg.mozilla.org/mozilla-central/rev/4ef0f163fdeb xpcom/tests/gtest/TestUTF.cpp:119:6 [-Wmissing-prototypes] no previous prototype for function 'NonASCII16_helper' Differential Revision: https://phabricator.services.mozilla.com/D23267
dc422efc31037bbf666a830bfa02c157612c9bbb: Bug 1525662 - Part 2: Remember plain-textness of HTML documents post loading. r=hsivonen
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 23 Feb 2019 17:06:52 +0100 - rev 464090
Push 35708 by rmaries@mozilla.com at Fri, 15 Mar 2019 03:45:36 +0000
Bug 1525662 - Part 2: Remember plain-textness of HTML documents post loading. r=hsivonen Based on the current implementation of nsContentUtils::IsPlainTextType(), we could just call that function again if we need to know whether we're dealing with plain text content or not later on, but doing it this way ensures we're always consistent with the current code in StartDocumentLoad(), which includes some additional sanity checks. Differential Revision: https://phabricator.services.mozilla.com/D20952
0077a71108eb4bd58348a697fafb7e43eddedf50: Bug 1497604 - Enable ESLint for dom/cache (manual changes) r=Standard8,hsivonen
monmanuela <manuela.monika97@gmail.com> - Wed, 06 Mar 2019 08:03:42 +0000 - rev 462561
Push 35655 by ncsoregi@mozilla.com at Wed, 06 Mar 2019 16:12:01 +0000
Bug 1497604 - Enable ESLint for dom/cache (manual changes) r=Standard8,hsivonen Depends on D20943 Differential Revision: https://phabricator.services.mozilla.com/D20944
36052e9424f7f356a197707303874940652f4eae: Bug 1497604 - Enable ESLint for dom/cache (automatic changes) r=Standard8,hsivonen
monmanuela <manuela.monika97@gmail.com> - Wed, 06 Mar 2019 08:04:15 +0000 - rev 462560
Push 35655 by ncsoregi@mozilla.com at Wed, 06 Mar 2019 16:12:01 +0000
Bug 1497604 - Enable ESLint for dom/cache (automatic changes) r=Standard8,hsivonen Differential Revision: https://phabricator.services.mozilla.com/D20943
f07e25fac5b20976178fb2e4dd7f95a6e252207a: Bug 1525662 - Part 2: Remember plain-textness of HTML documents post loading. r=hsivonen
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 05 Mar 2019 18:01:11 +0000 - rev 462429
Push 35652 by shindli@mozilla.com at Wed, 06 Mar 2019 04:36:55 +0000
Bug 1525662 - Part 2: Remember plain-textness of HTML documents post loading. r=hsivonen Based on the current implementation of nsContentUtils::IsPlainTextType(), we could just call that function again if we need to know whether we're dealing with plain text content or not later on, but doing it this way ensures we're always consistent with the current code in StartDocumentLoad(), which includes some additional sanity checks. Differential Revision: https://phabricator.services.mozilla.com/D20952
977a0ba7ec7051844703272ddcc5910d112dfc63: Bug 1523969 part 20 - Move method definition inline comments to new line in 'parser/'. r=hsivonen
Ryan Hunt <rhunt@eqrion.net> - Mon, 25 Feb 2019 16:11:34 -0600 - rev 461901
Push 35631 by rgurzau@mozilla.com at Fri, 01 Mar 2019 13:06:03 +0000
Bug 1523969 part 20 - Move method definition inline comments to new line in 'parser/'. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D21121
869a4e8b520bb9f6cb97074d7a9cc6d12e16e309: Bug 1521931 - Parser should yield if there is a pending high priority event before first contentful paint, r=hsivonen
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 30 Jan 2019 15:35:02 +0200 - rev 456103
Push 35471 by dvarga@mozilla.com at Wed, 30 Jan 2019 21:55:39 +0000
Bug 1521931 - Parser should yield if there is a pending high priority event before first contentful paint, r=hsivonen
d9ae827234990ad8ce27a2337df9dbc9dc578b05: Bug 1521334, make parser to flush its tree operation queue sooner, r=hsivonen
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 21 Jan 2019 16:03:03 +0200 - rev 454682
Push 35410 by rmaries@mozilla.com at Mon, 21 Jan 2019 17:51:39 +0000
Bug 1521334, make parser to flush its tree operation queue sooner, r=hsivonen
6098b2652c6c0a1749a87aab9999a3fbee8cde2d: Bug 1520812. Remove bogus assertion in nsExpatDriver::HandleError. r=hsivonen
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 17 Jan 2019 15:34:15 +0000 - rev 454332
Push 35395 by ebalazs@mozilla.com at Fri, 18 Jan 2019 09:38:33 +0000
Bug 1520812. Remove bogus assertion in nsExpatDriver::HandleError. r=hsivonen Any time we stop a load of an XML document before we've gotten all the data, we'll end up in this code with mSink null, because nsParser::Terminate ends up calling nsExpatDriver::DidBuildModel which nulls out mSink, and not getting all the data means the XML won't be well-formed. Differential Revision: https://phabricator.services.mozilla.com/D16856