searching for reviewer(hsivonen)
d40f09821d64faa7a36d126b0b850173ec612b93: Bug 1694297 - Re-enable legacy-mb-tchinese/big5/ WPTs on Linux Fission. r=hsivonen
Andrew McCreight <continuation@gmail.com> - Wed, 24 Feb 2021 15:39:12 +0000 - rev 568614
Push 38235 by ncsoregi@mozilla.com at Wed, 24 Feb 2021 21:51:51 +0000
Bug 1694297 - Re-enable legacy-mb-tchinese/big5/ WPTs on Linux Fission. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D106052
86304e6b883aa18ed31edd42f048f38bcee852bf: Bug 1679929 - Cap the User-Agent string's reported macOS version at 10.15 like Safari does. r=valentin,necko-reviewers,hsivonen
Chris Peterson <cpeterson@mozilla.com> - Wed, 17 Feb 2021 17:48:32 +0000 - rev 567858
Push 38213 by cbrindusan@mozilla.com at Thu, 18 Feb 2021 04:16:06 +0000
Bug 1679929 - Cap the User-Agent string's reported macOS version at 10.15 like Safari does. r=valentin,necko-reviewers,hsivonen Fixes webcompat bugs like bug 1680516. Some UA-sniffing sites assume the User-Agent string's macOS version always begin with "10." and they break if the User-Agent string reports version 11.0 on macOS Big Sur (11.0 aka 10.16). Differential Revision: https://phabricator.services.mozilla.com/D99856
5d644dc9bc635941082cf3fa180a05dc31dafd10: Bug 1690747 - Should also check blur is allowed in BrowsingContext::Blur(); r=hsivonen
Edgar Chen <echen@mozilla.com> - Tue, 09 Feb 2021 14:56:56 +0000 - rev 566622
Push 38186 by ncsoregi@mozilla.com at Tue, 09 Feb 2021 21:49:21 +0000
Bug 1690747 - Should also check blur is allowed in BrowsingContext::Blur(); r=hsivonen When binding delegates blur() to BrowsingContext::Blur, the remote side skips the check given that there is no js on the stack, but we should not skip the check. This only affects design-mode which allows the focus moving to the root element. Differential Revision: https://phabricator.services.mozilla.com/D104008
d3539dfe1b07c4937e084844999c515475e869bb: Bug 1691214 - Take focus from window.open etc even if we're already active but not in the active window. r=hsivonen
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Feb 2021 13:03:32 +0000 - rev 566602
Push 38186 by ncsoregi@mozilla.com at Tue, 09 Feb 2021 21:49:21 +0000
Bug 1691214 - Take focus from window.open etc even if we're already active but not in the active window. r=hsivonen With multiple windows, a browsing context being active doesn't guarantee being in the active window, so we explicitly check for that. We need to introduce an special case for the initial document because the initial document in the active window requesting focus breaks focusing the urlbar on a new window. Differential Revision: https://phabricator.services.mozilla.com/D104326
ebb61065ad47bcb98d80b0b0b0640f645837f53f: Bug 1690747 - Should also check blur is allowed in BrowsingContext::Blur(); r=hsivonen
Edgar Chen <echen@mozilla.com> - Tue, 09 Feb 2021 12:18:15 +0000 - rev 566595
Push 38186 by ncsoregi@mozilla.com at Tue, 09 Feb 2021 21:49:21 +0000
Bug 1690747 - Should also check blur is allowed in BrowsingContext::Blur(); r=hsivonen When binding delegates blur() to BrowsingContext::Blur, the remote side skips the check given that there is no js on the stack, but we should not skip the check. This only affects design-mode which allows the focus moving to the root element. Differential Revision: https://phabricator.services.mozilla.com/D104008
d807fa812d8fd040b0ca860ee5ada95bd258f226: Bug 1691214 - Take focus from window.open etc even if we're already active. r=hsivonen
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 08 Feb 2021 08:01:49 +0000 - rev 566312
Push 38181 by csabou@mozilla.com at Mon, 08 Feb 2021 16:31:12 +0000
Bug 1691214 - Take focus from window.open etc even if we're already active. r=hsivonen With multiple windows, being active doesn't guarantee being in the foreground window. Differential Revision: https://phabricator.services.mozilla.com/D104326
0b4ca02ee3aa0c211abf6375db74e161db5c2ffb: Bug 1665330 - If a script is a module, increment the IgnoreDestructiveWrites counter r=hsivonen
yulia <ystartsev@mozilla.com> - Fri, 05 Feb 2021 11:00:23 +0000 - rev 566168
Push 38176 by apavel@mozilla.com at Sat, 06 Feb 2021 09:42:43 +0000
Bug 1665330 - If a script is a module, increment the IgnoreDestructiveWrites counter r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D99898
f3ca9333ae5f6bc055ab3b1746b110405e06c1c1: Bug 1690984 - Allow data, dialog, main, picture, and template in nsTreeSanitizer r=hsivonen
Frederik Braun <fbraun@mozilla.com> - Fri, 05 Feb 2021 12:34:58 +0000 - rev 566126
Push 38175 by malexandru@mozilla.com at Fri, 05 Feb 2021 21:39:46 +0000
Bug 1690984 - Allow data, dialog, main, picture, and template in nsTreeSanitizer r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D104153
06c045f7240a7f168e904e1e278e08cf1d3ed928: Bug 1690099 - Move focus for window.open() on a targeted tab. r=hsivonen
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 02 Feb 2021 14:33:48 +0000 - rev 565598
Push 38164 by malexandru@mozilla.com at Tue, 02 Feb 2021 21:48:09 +0000
Bug 1690099 - Move focus for window.open() on a targeted tab. r=hsivonen That doesn't go through BrowsingContext::InternalLoad. This matches the behavior of clicking links and the behavior of other browsers. Differential Revision: https://phabricator.services.mozilla.com/D103720
dde9b51dd13b2daf7ec7266152e2ad3d5f7b244a: Bug 1598613 - Account for <link media=""> for speculative loads of stylesheet and preload links. r=hsivonen
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 01 Feb 2021 08:03:57 +0000 - rev 565376
Push 38160 by apavel@mozilla.com at Mon, 01 Feb 2021 21:36:20 +0000
Bug 1598613 - Account for <link media=""> for speculative loads of stylesheet and preload links. r=hsivonen <link media> applies to both <link rel="stylesheet"> (see HTMLLinkElement::GetStyleSheetInfo) and all link rel="preload" links, regardless of as value (see HTMLLinkElement::CheckPreloadAttrs), so pass it down and check them for all of those cases. Note that in the <link rel="stylesheet"> case we'd still have to load it, but it doesn't block rendering and we defer its loading until more important stylesheets are done (see SheetLoadData::ShouldDefer() which returns false if the media attribute didn't match). So speculatively loading it seems counter-productive. Differential Revision: https://phabricator.services.mozilla.com/D103565
8abc47cc74049e6e7d61b4ece9e0ad209314fd13: Bug 1687947: keep `Atom` declarations on a single line and exclude from `black` formatting r=hsivonen
Connor Sheehan <sheehan@mozilla.com> - Thu, 21 Jan 2021 18:00:16 +0000 - rev 564152
Push 38130 by btara@mozilla.com at Fri, 22 Jan 2021 04:37:37 +0000
Bug 1687947: keep `Atom` declarations on a single line and exclude from `black` formatting r=hsivonen These lines are parsed by the `htmlparser` and are expected to be on a single line. The `black` reformat has moved some of these definitions to multiple lines due to line length. This commit moves all declarations back to a single line and adds `fmt: {off,on}` statements so they will be ignored in future reformats. Differential Revision: https://phabricator.services.mozilla.com/D102626
20be56fe1d22cde4808066468fffff854c885939: Bug 1619197 Added .opus file to audiofilter r=hsivonen
Akshat Dixit <Akshat Dixit> <Akshat Dixit> - Mon, 18 Jan 2021 09:18:43 +0000 - rev 563531
Push 38115 by cbrindusan@mozilla.com at Mon, 18 Jan 2021 21:42:32 +0000
Bug 1619197 Added .opus file to audiofilter r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D100526
760123aa17581f22f82be3dd404956132da6d611: Bug 1665330 - If a script is a module, increment the IgnoreDestructiveWrites counter r=hsivonen
yulia <ystartsev@mozilla.com> - Wed, 13 Jan 2021 11:41:01 +0000 - rev 562890
Push 38101 by apavel@mozilla.com at Wed, 13 Jan 2021 21:34:39 +0000
Bug 1665330 - If a script is a module, increment the IgnoreDestructiveWrites counter r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D99898
84c7fedec3a2a2769c7e035a1c0aa7c3813f0e30: Bug 1619197 Added .opus file to audiofilter r=hsivonen
Akshat Dixit <Akshat Dixit> - Tue, 12 Jan 2021 05:14:54 +0000 - rev 562744
Push 38097 by rmaries@mozilla.com at Tue, 12 Jan 2021 15:55:11 +0000
Bug 1619197 Added .opus file to audiofilter r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D100526
51d688ae992bb4fc8a57e4c6df043a72dd884d32: Bug 1685161 - Use consistent namespace in nsHtml5TreeBuilderCppSupplement.h; r=hsivonen
Edgar Chen <echen@mozilla.com> - Mon, 11 Jan 2021 13:27:31 +0000 - rev 562629
Push 38094 by btara@mozilla.com at Mon, 11 Jan 2021 21:51:43 +0000
Bug 1685161 - Use consistent namespace in nsHtml5TreeBuilderCppSupplement.h; r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D100818
651fc83db5afee760e42fba68f600ca4a12d8030: Bug 1489437 - Part 1: Make HTML parser distinguish network, document.write and fragments in append operation; r=smaug,hsivonen
Edgar Chen <echen@mozilla.com> - Wed, 06 Jan 2021 09:29:41 +0000 - rev 562137
Push 38082 by malexandru@mozilla.com at Wed, 06 Jan 2021 15:51:27 +0000
Bug 1489437 - Part 1: Make HTML parser distinguish network, document.write and fragments in append operation; r=smaug,hsivonen For custom element reaction invocation in the parser, we need a way to distinguish the tree appending operation is from fragments or not, since we don't want to execute reactions until innerHTML finishes running. (See spec changes https://github.com/whatwg/html/issues/4025) We don't need to do anything for opAppendText and opAppendCommand since the text and command won't have any chance to be a custom element. Differential Revision: https://phabricator.services.mozilla.com/D10226
7515fe184b0143370d8a017ff948c62b3f093a7d: Bug 1664036 - Add tests for SVG onload r=hsivonen
Kagami Sascha Rosylight <krosylight@mozilla.com> - Tue, 05 Jan 2021 01:47:42 +0000 - rev 561958
Push 38075 by dluca@mozilla.com at Tue, 05 Jan 2021 04:31:31 +0000
Bug 1664036 - Add tests for SVG onload r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D89383
dff2fd52da6c98f5f92c08cf5c172a8dd44b0d87: Bug 582459 - Reset the focused element when a frame loses document focus; r=mikedeboer,NeilDeakin,hsivonen,jaws
Edgar Chen <echen@mozilla.com> - Mon, 21 Dec 2020 21:35:49 +0000 - rev 561517
Push 38050 by malexandru@mozilla.com at Tue, 22 Dec 2020 09:35:33 +0000
Bug 582459 - Reset the focused element when a frame loses document focus; r=mikedeboer,NeilDeakin,hsivonen,jaws Resetting focus would also clear selection on editable element, so get current selected text before moving focus to findbar to make prefill-with-selection work if the content is loaded in chrome process. Differential Revision: https://phabricator.services.mozilla.com/D89557
2ac614e69ecbe34e95776a2bd77f2917c9f696a6: Bug 582459 - Reset the focused element when a frame loses document focus; r=mikedeboer,NeilDeakin,hsivonen,jaws
Edgar Chen <echen@mozilla.com> - Tue, 15 Dec 2020 19:55:35 +0000 - rev 560855
Push 38035 by ccoroiu@mozilla.com at Wed, 16 Dec 2020 09:36:04 +0000
Bug 582459 - Reset the focused element when a frame loses document focus; r=mikedeboer,NeilDeakin,hsivonen,jaws Resetting focus would also clear selection on editable element, so get current selected text before moving focus to findbar to make prefill-with-selection work if the content is loaded in chrome process. Differential Revision: https://phabricator.services.mozilla.com/D89557
1ff4a99632d3fdbca65cf5913e624fe5feeacd39: Bug 1682121 - Add a ToJSValue overload for nsACString. r=hsivonen
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 14 Dec 2020 11:12:11 +0000 - rev 560561
Push 38031 by archaeopteryx@coole-files.de at Mon, 14 Dec 2020 23:03:37 +0000
Bug 1682121 - Add a ToJSValue overload for nsACString. r=hsivonen I wrote this for bug 1682003, but I split it off it because I don't really _need_ it (I need it on one place where I know I have valid utf-8). I think this is a sensible thing to do though. This throws on invalid utf-8 via: https://searchfox.org/mozilla-central/rev/0bcf81557b89e7757c44e25bb4bc7f4cb8619dc9/js/src/vm/CharacterEncoding.cpp#432 This would allow doing stuff like resolving promises using nsCStrings slightly more conveniently / efficiently than using NS_ConvertUTF*. Differential Revision: https://phabricator.services.mozilla.com/D99589
e024884814b239a841bbee0fb9433f1d2bf20cbd: Bug 1680269 - Fix includes for nsHtml5StreamParser. r=hsivonen
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 07 Dec 2020 14:21:43 +0000 - rev 559690
Push 38011 by btara@mozilla.com at Mon, 07 Dec 2020 21:55:05 +0000
Bug 1680269 - Fix includes for nsHtml5StreamParser. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D98576
9755f95ce00538a4b868734b7e3a9867088c9f6f: Bug 1615151 - Don't set the chrome offset for OOP iframe's browser. r=hsivonen
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 03 Dec 2020 10:42:55 +0000 - rev 559319
Push 38002 by rmaries@mozilla.com at Fri, 04 Dec 2020 03:34:50 +0000
Bug 1615151 - Don't set the chrome offset for OOP iframe's browser. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D98557
c8f03513e3a59cdf47f1b81ad911a84eae9b2ff9: Bug 1678349 - Part 2: Suppress additional blur/focus event on OOP iframe; r=hsivonen
Edgar Chen <echen@mozilla.com> - Wed, 02 Dec 2020 13:03:58 +0000 - rev 559048
Push 37997 by btara@mozilla.com at Wed, 02 Dec 2020 21:42:50 +0000
Bug 1678349 - Part 2: Suppress additional blur/focus event on OOP iframe; r=hsivonen for the case that framer calls iframe.focus() on OOP iframe and the OOP iframe already has the focus. Differential Revision: https://phabricator.services.mozilla.com/D98304
ef077201b2a49d238e08256d968b97274a16fbb6: Bug 1678349 - Part 1: Compute focus-in-other-content-process flag in nsFocusManager::Focus; r=hsivonen
Edgar Chen <echen@mozilla.com> - Wed, 02 Dec 2020 12:59:59 +0000 - rev 559047
Push 37997 by btara@mozilla.com at Wed, 02 Dec 2020 21:42:50 +0000
Bug 1678349 - Part 1: Compute focus-in-other-content-process flag in nsFocusManager::Focus; r=hsivonen This simplify the code a bit and also fix FocusIsOutOfProcess isn't set correctly for a certain case, e.g. framer calls iframe.focus() on a OOP iframe. Differential Revision: https://phabricator.services.mozilla.com/D96720
3c44bafab3214d0b749e732a32638240f7e4095f: Bug 1680158 - Expose focused content browsing context to chrome code. r=hsivonen
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 02 Dec 2020 08:50:45 +0000 - rev 559021
Push 37997 by btara@mozilla.com at Wed, 02 Dec 2020 21:42:50 +0000
Bug 1680158 - Expose focused content browsing context to chrome code. r=hsivonen This is useful for printing. Naming is confusing IMO, but my read of the docs and experimentation agree this is what we want :) Differential Revision: https://phabricator.services.mozilla.com/D98415
caeb8dad360fc5467db8dee6392d0baa00ca8afa: Bug 1679422: move serializers from dom/base/ to dom/serializers/. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Sun, 29 Nov 2020 15:58:13 +0000 - rev 558625
Push 37990 by csabou@mozilla.com at Mon, 30 Nov 2020 21:52:46 +0000
Bug 1679422: move serializers from dom/base/ to dom/serializers/. r=hsivonen Required fixing some `EXPORTS` and the unified build. Differential Revision: https://phabricator.services.mozilla.com/D98057
333c9484ab46e7919b94bdcad01cbfb3c5cf77df: Bug 1673931 - Move parts of implementation of nsIScriptElement to cpp file. r=hsivonen
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:12:39 +0000 - rev 558388
Push 37978 by nerli@mozilla.com at Tue, 24 Nov 2020 09:22:28 +0000
Bug 1673931 - Move parts of implementation of nsIScriptElement to cpp file. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D97737 Depends on D97620
85fdfcf74e07afe0a26a6df6a3f980ec04b2b16c: Bug 1674044 - Make `IMEStateManager` put off to handle focused browser change while the application becomes activated r=hsivonen
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 Nov 2020 14:55:31 +0000 - rev 558190
Push 37971 by apavel@mozilla.com at Sat, 21 Nov 2020 09:27:54 +0000
Bug 1674044 - Make `IMEStateManager` put off to handle focused browser change while the application becomes activated r=hsivonen `IMEStateManager::OnFocusMovedBetweenBrowsers()` is called by `BrowserParent::UnsetTopLevelWebFocusAll()` from `nsFocusManager::WindowRaised()` when a window becomes active from the app itself is deactivated. At this time, `aBlur` is set to the last `BrowserParent` which had focus before inactivated, and `aFocus` is always `nullptr` because of assuming the following code in `nsFocusManager::WindowRised()` will call `OnFocusMovedBetweenBrowsers()` to set focus to focused browser part at that time. However, the first call of `OnFocusMovedBetweenBrowsers()` requesting to commit composition if there is a composition because it believes that the focused process is just blurred and nobody would take focus. So, `IMEStateManager::OnFocusMovedBetweenBrowsers()` needs to wait to handle its jobs until another its call for setting focus to the remote process when the app is activated. Therefore, this patch makes `IMEStateManager` manage whether the process is active or not from the point of view of IME handling. I.e., in the main process, it can be treated as active when a window is the focused window in the desktop, and in a content process, it can be treated as active when the process has focus. So, this is managed by `sIsActive`. Then, `IMEStateManager` needs information of first blurred `BrowserParent` and `last focused `BrowserParent` in the case for putting off to handle its jobs. Therefore, this patch adds `IMEStateManager::sPendingFocusedBrowserSwitchingData` to manage them. Finally, this patch makes `IMEStateManager::OnFocusMovedBetweenBrowsers()` cancel pending handling if first blurred `BrowserParent` and last focused `RrowserParent`are same. And also making `IMEStateManager::OnFocusChangeInternal()` call `OnFocusMoveBetweenBrowsers()` if there is pending jobs of `OnFocusMoveBetweenBrowsers()`. UThis requires an API to create the case to all windows deactive to test it. However, there is no way to do that. Therefore, this patch does not have any tests. Differential Revision: https://phabricator.services.mozilla.com/D97687
15090a85909d17468bb795efbc960f5cb6202cb9: Bug 1669050: add `href` to the allowed SVG attributes in `nsTreeSanitizer`. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Thu, 19 Nov 2020 08:19:12 +0000 - rev 557946
Push 37966 by cbrindusan@mozilla.com at Thu, 19 Nov 2020 21:44:32 +0000
Bug 1669050: add `href` to the allowed SVG attributes in `nsTreeSanitizer`. r=hsivonen This follows the pattern of `kAttributesHTML` and `kURLAttributesHTML`, which both contain `href`. Now, `kAttributesSVG` and `kURLAttributesSVG` contain `href` too. Unfortunately, the WPT-support for filling and reading the clipboard is scanty (see bug 1676643), hence adding a Mochitest. Differential Revision: https://phabricator.services.mozilla.com/D97451
6d5a7637d34f358b0825f8286e2385859b984098: Bug 1660752 - Enable dom/events/test_bug238987.html on fission and cross-origin; r=hsivonen
Edgar Chen <echen@mozilla.com> - Tue, 17 Nov 2020 13:11:13 +0000 - rev 557630
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1660752 - Enable dom/events/test_bug238987.html on fission and cross-origin; r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D96701
15ceb99908caea1e4a0d82113fc08a7ef23d976d: Bug 1674702 - Do not bounce IPC message to framer if focus is handled synchronously in OOP iframe; r=hsivonen
Edgar Chen <echen@mozilla.com> - Tue, 17 Nov 2020 11:47:27 +0000 - rev 557521
Push 37959 by btara@mozilla.com at Tue, 17 Nov 2020 21:55:29 +0000
Bug 1674702 - Do not bounce IPC message to framer if focus is handled synchronously in OOP iframe; r=hsivonen This suppress unnecessary blur and focus actions in the framer, we would need to find a way to notify framer that the focus has moved to OOP iframe to dispatch corresponding blur event, see bug 1677474. Differential Revision: https://phabricator.services.mozilla.com/D97158
17658a2394cf21d332184a5f78f8dec6637c8a4d: Bug 1674743 - Synchronously raise window when window.focus() called in OOP iframe; r=hsivonen
Edgar Chen <echen@mozilla.com> - Wed, 11 Nov 2020 11:19:15 +0000 - rev 556736
Push 37940 by ccoroiu@mozilla.com at Wed, 11 Nov 2020 16:38:50 +0000
Bug 1674743 - Synchronously raise window when window.focus() called in OOP iframe; r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D96184
573d2567eef65e5c2bca3f98ed1ffd30d748c565: Bug 1676601 - Remove activeelement-after-immediately-focusing-same-site-iframe-outer-contenwindow.html; r=hsivonen
Edgar Chen <echen@mozilla.com> - Wed, 11 Nov 2020 11:19:53 +0000 - rev 556735
Push 37940 by ccoroiu@mozilla.com at Wed, 11 Nov 2020 16:38:50 +0000
Bug 1676601 - Remove activeelement-after-immediately-focusing-same-site-iframe-outer-contenwindow.html; r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D96693
c143f1a70eb11ca0885b03254ead0c9e843892c4: Bug 1676127 - Don't deactivate top-level remote browser twice when browser window is lowered; r=hsivonen
Edgar Chen <echen@mozilla.com> - Mon, 09 Nov 2020 14:57:54 +0000 - rev 556435
Push 37935 by nbeleuzu@mozilla.com at Mon, 09 Nov 2020 21:53:49 +0000
Bug 1676127 - Don't deactivate top-level remote browser twice when browser window is lowered; r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D96404
6f32f9a87905b42659c20643e6e7a1a6db5932f4: Bug 1675397 - Part 2: Use AutoRestore to reset nsFocusManager::mFirst{Blur|Focus}Event; r=hsivonen
Edgar Chen <echen@mozilla.com> - Thu, 05 Nov 2020 09:05:05 +0000 - rev 555967
Push 37923 by btara@mozilla.com at Thu, 05 Nov 2020 16:09:03 +0000
Bug 1675397 - Part 2: Use AutoRestore to reset nsFocusManager::mFirst{Blur|Focus}Event; r=hsivonen Depends on D95946 Differential Revision: https://phabricator.services.mozilla.com/D95947
4ba1d1e9d326f86867a0675d0c27f78d01195630: Bug 1675397 - Part 1: Use RefPtr<Element> for nsFocusManager::mFirst{Blur|Focus}Event; r=hsivonen
Edgar Chen <echen@mozilla.com> - Thu, 05 Nov 2020 09:04:38 +0000 - rev 555966
Push 37923 by btara@mozilla.com at Thu, 05 Nov 2020 16:09:03 +0000
Bug 1675397 - Part 1: Use RefPtr<Element> for nsFocusManager::mFirst{Blur|Focus}Event; r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D95946
f4242b119e61e5e2f793cec1c5519279752df004: Bug 1665752 - Do not send IPC to request focus if the browsing context already has the focus; r=hsivonen
Edgar Chen <echen@mozilla.com> - Mon, 26 Oct 2020 14:19:59 +0000 - rev 554526
Push 37894 by dluca@mozilla.com at Tue, 27 Oct 2020 04:41:26 +0000
Bug 1665752 - Do not send IPC to request focus if the browsing context already has the focus; r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D94678
6e98f4aae8d696b6eb8a85b1a0626c3443d9fde8: Bug 1673309 - Sanitizer should be behind a pref r=hsivonen
Frederik Braun <fbraun@mozilla.com> - Mon, 26 Oct 2020 13:58:05 +0000 - rev 554515
Push 37894 by dluca@mozilla.com at Tue, 27 Oct 2020 04:41:26 +0000
Bug 1673309 - Sanitizer should be behind a pref r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D94704
d431052b6decebaa49c7bd0c4c674b17f2f7fbd9: Bug 1673309 - Sanitizer should be behind a pref r=hsivonen
Frederik Braun <fbraun@mozilla.com> - Mon, 26 Oct 2020 12:29:30 +0000 - rev 554495
Push 37894 by dluca@mozilla.com at Tue, 27 Oct 2020 04:41:26 +0000
Bug 1673309 - Sanitizer should be behind a pref r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D94704
e551d2c638d4d561ebdb746c43893b2189238a17: Bug 1669664 - Don't speculatively load scripts, etc inside a template element. r=hsivonen
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Oct 2020 21:58:50 +0000 - rev 553248
Push 37868 by dluca@mozilla.com at Fri, 16 Oct 2020 21:45:37 +0000
Bug 1669664 - Don't speculatively load scripts, etc inside a template element. r=hsivonen I guess in order to make this 100% sound we should check the whole template mode stack, but that seemed more expensive than what I'd really like, and I think it's not likely to be an issue in practice (maybe we can too-eagerly preload some images inside tables inside templates, or something of that sort?). Differential Revision: https://phabricator.services.mozilla.com/D92773
6d79ef2d6881adca3925c4115cf269f5a6d87951: Bug 1666843 - Clear mFocusedWindow while burring; r=hsivonen
Edgar Chen <echen@mozilla.com> - Mon, 12 Oct 2020 11:58:50 +0000 - rev 552754
Push 37856 by ncsoregi@mozilla.com at Tue, 13 Oct 2020 03:29:28 +0000
Bug 1666843 - Clear mFocusedWindow while burring; r=hsivonen The expectation is that the blurring would eventually result in an IPC message doing this anyway, but this doesn't happen if the focus is in OOP iframe which won't try to bounce an IPC message to its parent frame. Differential Revision: https://phabricator.services.mozilla.com/D93210
b5679d9b789fb72fbffff3ca5fc06284eb52ac39: Bug 1539769 - Make `eSetSelection` event go to focused `BrowserParent` instead of `BrowserPargent` for focused content in the main process r=hsivonen
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 09 Oct 2020 07:01:20 +0000 - rev 552559
Push 37850 by ncsoregi@mozilla.com at Sat, 10 Oct 2020 09:37:08 +0000
Bug 1539769 - Make `eSetSelection` event go to focused `BrowserParent` instead of `BrowserPargent` for focused content in the main process r=hsivonen when there is no composition, `IMEStateManager::HandleSelectionEvent()` calls `TextComposition::HandleSelectionEvent()` with `BrowserParent` which is retrieved from `aEventTargetContent` which is focused content in the main process. This means that `eSetSelection` event is handled in root document of the focused tab when there is no composition. However, following composition events will go to focused `BrowserParent`, i.e., if an OOP iframe has focus in the tab, `eSetSelection` event won't be handled in it. Therefore, IME always fails to replace existing text with new composition. This patch makes both `IMEStateManager::HandleSelectionEvent()` and `PresShell::EventHandler::DispatchEventToDOM()` use `IMEStateManager::GetActiveBrowserParent()` for sending both `eSetSelection` and composition events to same process. Additionally, this patch make `IMEStateManager::GetActiveBrowserParent()` returns `IMEStateManager::sFocusedIMEBrowserParent` when it's set to non-nullptr because native IME tries to modify the editor which enabled IME context. On the other hand, for making the behavior safer, we should make `eCompositionStart` event have replacing range optionally. I filed bug 1669907 to change the design, but it requires several non-tiny patches. Once we fix it, we can write automated tests for this simply, but without the fix, I need to write too many lines with low level API, and it becomes unnecessary after fixing the bug. Therefore, I give up to write a test for this for now. Differential Revision: https://phabricator.services.mozilla.com/D93053
0191bd914f91717a358593e509044ba5c2ab253a: Bug 1669664 - Don't speculatively load scripts, etc inside a template element. r=hsivonen
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Oct 2020 10:58:27 +0000 - rev 552176
Push 37845 by nbeleuzu@mozilla.com at Thu, 08 Oct 2020 16:14:24 +0000
Bug 1669664 - Don't speculatively load scripts, etc inside a template element. r=hsivonen I guess in order to make this 100% sound we should check the whole template mode stack, but that seemed more expensive than what I'd really like, and I think it's not likely to be an issue in practice (maybe we can too-eagerly preload some images inside tables inside templates, or something of that sort?). Differential Revision: https://phabricator.services.mozilla.com/D92773
7cac1e1cc3dfdbe28873379a584f8c13c468e911: Bug 1667081 - Part 9: Remove SetFocusedWindowWithCallerType in nsIFocusManager; r=hsivonen
Edgar Chen <echen@mozilla.com> - Tue, 29 Sep 2020 07:22:45 +0000 - rev 550679
Push 37820 by dluca@mozilla.com at Tue, 29 Sep 2020 15:38:31 +0000
Bug 1667081 - Part 9: Remove SetFocusedWindowWithCallerType in nsIFocusManager; r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D91346
f5233336041cf3da0b3e2fe503f2f18383396e50: Bug 1667081 - Part 8: Remove parentActivated in nsIFocusManager; r=hsivonen
Edgar Chen <echen@mozilla.com> - Tue, 29 Sep 2020 07:22:32 +0000 - rev 550678
Push 37820 by dluca@mozilla.com at Tue, 29 Sep 2020 15:38:31 +0000
Bug 1667081 - Part 8: Remove parentActivated in nsIFocusManager; r=hsivonen And make nsFocusManager::ParentActivated just returning void given all caller doesn't actaully check the return value. Differential Revision: https://phabricator.services.mozilla.com/D91294
87fccbe06702afe096b1691f3de30ed2223100d4: Bug 1667081 - Part 7: Remove focusPlugin in nsIFocusManager; r=hsivonen
Edgar Chen <echen@mozilla.com> - Tue, 29 Sep 2020 07:22:25 +0000 - rev 550677
Push 37820 by dluca@mozilla.com at Tue, 29 Sep 2020 15:38:31 +0000
Bug 1667081 - Part 7: Remove focusPlugin in nsIFocusManager; r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D91293
5a020e0ef312c1e89ebb0f84a880aac0a6f27000: Bug 1667081 - Part 6: Remove fireDelayedEvents in nsIFocusManager; r=hsivonen
Edgar Chen <echen@mozilla.com> - Tue, 29 Sep 2020 07:22:12 +0000 - rev 550676
Push 37820 by dluca@mozilla.com at Tue, 29 Sep 2020 15:38:31 +0000
Bug 1667081 - Part 6: Remove fireDelayedEvents in nsIFocusManager; r=hsivonen This patch also does following changes, - Assert aDocument instead of early return given all caller passes a non-null document. - Make it returning void given all caller doesn't actaully check the return value. Differential Revision: https://phabricator.services.mozilla.com/D91292
812142d8a1ca38d3fc25d01d2d4676fead7e2386: Bug 1667081 - Part 5: Remove windowHidden in nsIFocusManager; r=hsivonen
Edgar Chen <echen@mozilla.com> - Tue, 29 Sep 2020 07:21:59 +0000 - rev 550675
Push 37820 by dluca@mozilla.com at Tue, 29 Sep 2020 15:38:31 +0000
Bug 1667081 - Part 5: Remove windowHidden in nsIFocusManager; r=hsivonen And make nsFocusManager::WindowHidden just returning void given all caller doesn't actaully check the return value. Differential Revision: https://phabricator.services.mozilla.com/D91291
20a78a587af79797040d53530dc44f6195897c7e: Bug 1667081 - Part 4: Remove windowShown in nsIFocusManager; r=hsivonen
Edgar Chen <echen@mozilla.com> - Tue, 29 Sep 2020 07:21:47 +0000 - rev 550674
Push 37820 by dluca@mozilla.com at Tue, 29 Sep 2020 15:38:31 +0000
Bug 1667081 - Part 4: Remove windowShown in nsIFocusManager; r=hsivonen And make nsFocusManager::WindowShown just returning void given all caller doesn't actaully check the return value. Differential Revision: https://phabricator.services.mozilla.com/D91290
c86136e5ec87074304ecfabf41f52a6b165e39a6: Bug 1667081 - Part 3: Remove windowLowered in nsIFocusManager; r=hsivonen
Edgar Chen <echen@mozilla.com> - Tue, 29 Sep 2020 07:21:34 +0000 - rev 550673
Push 37820 by dluca@mozilla.com at Tue, 29 Sep 2020 15:38:31 +0000
Bug 1667081 - Part 3: Remove windowLowered in nsIFocusManager; r=hsivonen And make nsFocusManager::WindowLowered just returning void given all caller doesn't actaully check the return value. Differential Revision: https://phabricator.services.mozilla.com/D91289