searching for reviewer(gw)
cb5768cec343978eeeccab5d65657e08dae04fe1: Bug 1695318 - Check if the parent node is perspective when considering back faces r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Mon, 17 Jan 2022 20:50:12 +0000 - rev 604728
Push 39157 by ctuns@mozilla.com at Tue, 18 Jan 2022 03:56:20 +0000
Bug 1695318 - Check if the parent node is perspective when considering back faces r=gw Differential Revision: https://phabricator.services.mozilla.com/D136163
eef9a8fd017bb2012275b9f06172aa86109032a1: Bug 1744842 - Use LayoutVector2D to set scroll offset (the off main-thread part). r=gw,botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 09 Dec 2021 04:39:10 +0000 - rev 601464
Push 39048 by nfay@mozilla.com at Thu, 09 Dec 2021 09:32:28 +0000
Bug 1744842 - Use LayoutVector2D to set scroll offset (the off main-thread part). r=gw,botond This includes some other changes; 1) Rename relevant functions scroll_node_with_id -> set_scroll_offset scroll_node -> set_scroll_offset set_scroll_origin -> set_scroll_offset 2) Drop ScrollClamping argument In Gecko we didn't use ScrollClamping::ToContentBounds at all 3) The order of arguments of scroll_node_with_id Differential Revision: https://phabricator.services.mozilla.com/D133145
9fd5635e49d2e19290a8076b3b3e50e7bc8af13a: Bug 1744842 - Use LayoutVector2D instead of LayoutPoint to set scroll offset (the main-thread part). r=gw,botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 09 Dec 2021 04:39:10 +0000 - rev 601463
Push 39048 by nfay@mozilla.com at Thu, 09 Dec 2021 09:32:28 +0000
Bug 1744842 - Use LayoutVector2D instead of LayoutPoint to set scroll offset (the main-thread part). r=gw,botond Differential Revision: https://phabricator.services.mozilla.com/D133144
d4248890a3db7d4ca74661e12d41624510fe03e4: Bug 1742749 - Mark PrimitiveInstanceData as repr(C). r=gfx-reviewers,gw
Mike Hommey <mh+mozilla@glandium.org> - Tue, 07 Dec 2021 00:29:35 +0000 - rev 601162
Push 39042 by apavel@mozilla.com at Tue, 07 Dec 2021 04:09:38 +0000
Bug 1742749 - Mark PrimitiveInstanceData as repr(C). r=gfx-reviewers,gw instead of marking it possibly dead-code. This has the same effect on the rust >= 1.57 warning, but is more correct, since without repr(C), it's not actually FFI-safe. Differential Revision: https://phabricator.services.mozilla.com/D132753
4623948ed21653d413a876dfc10477ceb9c5f5fb: Bug 1744117. Allow promoting x-flipped surfaces. r=gw
Jeff Muizelaar <jmuizelaar@mozilla.com> - Thu, 02 Dec 2021 22:31:45 +0000 - rev 600972
Push 39032 by mlaza@mozilla.com at Fri, 03 Dec 2021 09:48:16 +0000
Bug 1744117. Allow promoting x-flipped surfaces. r=gw I believe this restriction was just a historical limitation that never got removed. Differential Revision: https://phabricator.services.mozilla.com/D132738
41ebfc5cf5f27910237ea07814455993d0576484: Bug 1743304 - Semi-reduntantly propagate raster space inheritance in gecko r=gw
Doug Thayer <dothayer@mozilla.com> - Sun, 28 Nov 2021 21:47:04 +0000 - rev 600345
Push 39019 by nerli@mozilla.com at Mon, 29 Nov 2021 09:42:59 +0000
Bug 1743304 - Semi-reduntantly propagate raster space inheritance in gecko r=gw So, it turns out I didn't fully test the patch from bug 1740262 after I made my final changes to it. A change that I had in the patch which I thought was unnecessary, because it didn't fix the problem by itself, turns out to in fact be necessary. It turns out we still need to inherit the parent stacking context's `mRasterizeLocally` value inside gecko, or else we could have scale changes which get dropped on the WebRender side. I do think long term WebRender should handle all of this itself, because I believe there are still potential issues lurking here when we start to think of this across the process boundary, but I don't think I'm the right person right now to untangle everything to cleanly move everything necessary into WebRender, so I think the solution for right now is to have Gecko somewhat but not entirely reduntantly handle raster space inheritance itself, in addition to WebRender handling raster space inheritance in order to partially cover the process boundary case. This is not a pretty solution, but as far as I can tell it fixes the issues that bug 1730710 introduced without regressing the performance back to pre-1730710 levels. Differential Revision: https://phabricator.services.mozilla.com/D132308
77e540295ce542e22373507a92e52d70c9947f88: Bug 1740262 - Always respect requested local raster space r=gw
Doug Thayer <dothayer@mozilla.com> - Tue, 23 Nov 2021 22:49:33 +0000 - rev 599980
Push 39005 by apavel@mozilla.com at Wed, 24 Nov 2021 03:53:13 +0000
Bug 1740262 - Always respect requested local raster space r=gw Differential Revision: https://phabricator.services.mozilla.com/D131963
8d9c84a52b948a6a61d3b8844d2e5332f4c8cde6: Bug 1711477 - Add a way to get from atlas alloc ID to texture cache handle. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Thu, 21 Oct 2021 08:54:49 +0000 - rev 596546
Push 38901 by smolnar@mozilla.com at Thu, 21 Oct 2021 16:02:15 +0000
Bug 1711477 - Add a way to get from atlas alloc ID to texture cache handle. r=gfx-reviewers,gw This will be used in a followup patch to defragment the texture cache. Differential Revision: https://phabricator.services.mozilla.com/D128252
d82f3e1bc8bd100750afc81c05da35d156aec3b0: Bug 1736732. Fix fuzz caused by bug 1736672. r=gfx-reviewers,gw
Jeff Muizelaar <jmuizelaar@mozilla.com> - Tue, 19 Oct 2021 22:51:25 +0000 - rev 596425
Push 38898 by imoraru@mozilla.com at Thu, 21 Oct 2021 03:32:00 +0000
Bug 1736732. Fix fuzz caused by bug 1736672. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D128960
2c675190a51a8414cd8e4171c6e063755347ec7b: Bug 1730710 - Propagate raster spaces in GPU process r=gw
Doug Thayer <dothayer@mozilla.com> - Fri, 01 Oct 2021 15:12:37 +0000 - rev 593942
Push 38838 by imoraru@mozilla.com at Fri, 01 Oct 2021 21:46:01 +0000
Bug 1730710 - Propagate raster spaces in GPU process r=gw This actually does two things. One: it lets child stacking contexts inherit out of process raster spaces by checking the parent stacking context's raster space inside WR itself, and Two: it mirrors the logic in get_raster_space_for_prim which undoes the device_pixel_scale for pinch zooms in order to get a consistent glyph rasterization scale. This second thing won't affect the test page linked in the bug, but it will affect the performance of, say, animating a whole browser's scale, which is useful for reasons. Differential Revision: https://phabricator.services.mozilla.com/D125562
0ef9b28ae108513855b5e855f469cd64e278f6e4: Bug 1733154 - Dequeue all GL errors instead of just the last one. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Thu, 30 Sep 2021 10:28:34 +0000 - rev 593767
Push 38835 by ncsoregi@mozilla.com at Thu, 30 Sep 2021 21:50:26 +0000
Bug 1733154 - Dequeue all GL errors instead of just the last one. r=gfx-reviewers,gw According to https://www.khronos.org/opengl/wiki/OpenGL_Error glGetError pops from a queue of errors rather than only keeping track of the last error so we need to dequeue all errors when checking for them in the renderer. Differential Revision: https://phabricator.services.mozilla.com/D126956
a5cecdbf4d7db5804b87c1cc996a7ffe529413fe: Bug 1732109 - Use a simpler cache entry struct for picture tiles. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Wed, 29 Sep 2021 13:28:35 +0000 - rev 593663
Push 38831 by mlaza@mozilla.com at Thu, 30 Sep 2021 03:43:56 +0000
Bug 1732109 - Use a simpler cache entry struct for picture tiles. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D126688
bf39693fa5998329fdced6d055b3fd2e8540724e: Bug 1732109 - Move picture tiles out of TextureCache. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Wed, 29 Sep 2021 13:28:35 +0000 - rev 593662
Push 38831 by mlaza@mozilla.com at Thu, 30 Sep 2021 03:43:56 +0000
Bug 1732109 - Move picture tiles out of TextureCache. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D126687
8a362f24929f345ecaf3ba867d9e31c1b780e08e: Bug 1732109 - Request picture tiles explicitly and add PictureTextures::now. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Wed, 29 Sep 2021 13:28:35 +0000 - rev 593661
Push 38831 by mlaza@mozilla.com at Thu, 30 Sep 2021 03:43:56 +0000
Bug 1732109 - Request picture tiles explicitly and add PictureTextures::now. r=gfx-reviewers,gw Last step before PictureTextures can be used independently. Differential Revision: https://phabricator.services.mozilla.com/D126686
8de24748f9465c64ead1df4566a643e096ca2476: Bug 1732109 - Remove generic picture texture access via TextureCache::get_opt/get_opt_mut. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Wed, 29 Sep 2021 13:28:34 +0000 - rev 593660
Push 38831 by mlaza@mozilla.com at Thu, 30 Sep 2021 03:43:56 +0000
Bug 1732109 - Remove generic picture texture access via TextureCache::get_opt/get_opt_mut. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D126685
69d53e668d9aadab473791510e3178eb7c332156: Bug 1732109 - Move more picture-specific code out of texture_cache.rs. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Wed, 29 Sep 2021 13:28:34 +0000 - rev 593659
Push 38831 by mlaza@mozilla.com at Thu, 30 Sep 2021 03:43:56 +0000
Bug 1732109 - Move more picture-specific code out of texture_cache.rs. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D126684
8c8b31e7552249e5407a512b125de7440c51878d: Bug 1732109 - Move PictureTextures into its own file. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Wed, 29 Sep 2021 13:28:33 +0000 - rev 593658
Push 38831 by mlaza@mozilla.com at Thu, 30 Sep 2021 03:43:56 +0000
Bug 1732109 - Move PictureTextures into its own file. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D126683
ec364c6654f2a461760b56f650bba713aa4eaa10: Bug 1732109 - Remove the slab atlas allocator. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Wed, 29 Sep 2021 13:28:33 +0000 - rev 593657
Push 38831 by mlaza@mozilla.com at Thu, 30 Sep 2021 03:43:56 +0000
Bug 1732109 - Remove the slab atlas allocator. r=gfx-reviewers,gw The shelf allocator is better in all scenarios, we don't need to keep that code around. Differential Revision: https://phabricator.services.mozilla.com/D126682
a54ad4336b10da32b3c37cf77d653d375bcfa5e2: Bug 1732109 - Use a simpler cache entry struct for picture tiles. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 28 Sep 2021 14:33:51 +0000 - rev 593441
Push 38828 by abutkovits@mozilla.com at Tue, 28 Sep 2021 21:36:47 +0000
Bug 1732109 - Use a simpler cache entry struct for picture tiles. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D126688
316f4cedacc96dc20015f46dcc898b7b51796939: Bug 1732109 - Move picture tiles out of TextureCache. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 28 Sep 2021 14:33:50 +0000 - rev 593440
Push 38828 by abutkovits@mozilla.com at Tue, 28 Sep 2021 21:36:47 +0000
Bug 1732109 - Move picture tiles out of TextureCache. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D126687
b5ec92b8df13bd91bb8ccc5cc0b4e2a8314ccaaa: Bug 1732109 - Request picture tiles explicitly and add PictureTextures::now. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 28 Sep 2021 14:33:50 +0000 - rev 593439
Push 38828 by abutkovits@mozilla.com at Tue, 28 Sep 2021 21:36:47 +0000
Bug 1732109 - Request picture tiles explicitly and add PictureTextures::now. r=gfx-reviewers,gw Last step before PictureTextures can be used independently. Differential Revision: https://phabricator.services.mozilla.com/D126686
8f13a584fb299e3ca529652fba09815f3508e977: Bug 1732109 - Remove generic picture texture access via TextureCache::get_opt/get_opt_mut. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 28 Sep 2021 14:33:49 +0000 - rev 593438
Push 38828 by abutkovits@mozilla.com at Tue, 28 Sep 2021 21:36:47 +0000
Bug 1732109 - Remove generic picture texture access via TextureCache::get_opt/get_opt_mut. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D126685
afc30923cf87d62fc96f745ec34c590d215be8ad: Bug 1732109 - Move more picture-specific code out of texture_cache.rs. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 28 Sep 2021 14:33:49 +0000 - rev 593437
Push 38828 by abutkovits@mozilla.com at Tue, 28 Sep 2021 21:36:47 +0000
Bug 1732109 - Move more picture-specific code out of texture_cache.rs. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D126684
b625a94df2a77f28bb1e62065967ff0652d18708: Bug 1732109 - Move PictureTextures into its own file. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 28 Sep 2021 14:33:49 +0000 - rev 593436
Push 38828 by abutkovits@mozilla.com at Tue, 28 Sep 2021 21:36:47 +0000
Bug 1732109 - Move PictureTextures into its own file. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D126683
d647046143fc6e8b6ff504d38699a5d81990af1f: Bug 1732109 - Remove the slab atlas allocator. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 28 Sep 2021 14:33:48 +0000 - rev 593435
Push 38828 by abutkovits@mozilla.com at Tue, 28 Sep 2021 21:36:47 +0000
Bug 1732109 - Remove the slab atlas allocator. r=gfx-reviewers,gw The shelf allocator is better in all scenarios, we don't need to keep that code around. Differential Revision: https://phabricator.services.mozilla.com/D126682
fa3496e5bb766b0dd1ebeb22cae54bc485722a23: Bug 1732726 - Use PBO uploads on Windows. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 28 Sep 2021 09:57:47 +0000 - rev 593411
Push 38828 by abutkovits@mozilla.com at Tue, 28 Sep 2021 21:36:47 +0000
Bug 1732726 - Use PBO uploads on Windows. r=gfx-reviewers,gw A couple of years ago we had observed that the way ANGLE emulated PBOs was slower than using glTexSubImage2D. Since then ANGLE added a fast path which performs better, especially in frames with a large amount of pixels are uploaded. Switching to PBOs on windows gives us better performance overall and will let us remove some code paths. Differential Revision: https://phabricator.services.mozilla.com/D126697
d7c54ef537683f3862cd115b1ad63f5396a640cb: Bug 1732000 - use utf-8 when parsing the wrench logcat on android. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 28 Sep 2021 08:44:46 +0000 - rev 593404
Push 38828 by abutkovits@mozilla.com at Tue, 28 Sep 2021 21:36:47 +0000
Bug 1732000 - use utf-8 when parsing the wrench logcat on android. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D126681
610ae1bbeff8a415f55f6ec4e013faf0302e5b2e: Bug 1725304 - Fix tracking of late surfaces for debug overlays in SW-WR. r=gw
Lee Salzman <lsalzman@mozilla.com> - Thu, 12 Aug 2021 03:37:06 +0000 - rev 588622
Push 38698 by apavel@mozilla.com at Thu, 12 Aug 2021 09:26:07 +0000
Bug 1725304 - Fix tracking of late surfaces for debug overlays in SW-WR. r=gw Differential Revision: https://phabricator.services.mozilla.com/D122410
14a14a030d82d27c929eae686f5a93a9ffddf3e9: Bug 1719232 - Skip render tasks with empty valid rects. r=gw
Lee Salzman <lsalzman@mozilla.com> - Thu, 29 Jul 2021 20:48:10 +0000 - rev 587068
Push 38655 by nerli@mozilla.com at Fri, 30 Jul 2021 03:38:17 +0000
Bug 1719232 - Skip render tasks with empty valid rects. r=gw Some clang/rustc build setups seem to result in rounding scenarios where the valid rect, once converted to i32, is somehow empty. This can cause downwind problems if we actually try to render those tiles. Instead, just cull it before it becomes a problem. Differential Revision: https://phabricator.services.mozilla.com/D121144
2920d37e1da09e591d97bac138abb967f4a7f3f0: Bug 1721014 - Avoid use of rayon par_iter collect in WR glyph resolution. r=gw
Lee Salzman <lsalzman@mozilla.com> - Thu, 22 Jul 2021 15:48:30 +0000 - rev 586431
Push 38635 by dluca@mozilla.com at Thu, 22 Jul 2021 21:48:15 +0000
Bug 1721014 - Avoid use of rayon par_iter collect in WR glyph resolution. r=gw Rayon's collect primitive is somehow establishing recursive dependencies on waiting for task completion, such that if a lot of glyph jobs are submitted all at once, this can result in huge recursive stack chains. This simplifies the glyph job queuing to just send everything immediately over the result channel, rather than waiting for all jobs in the batch (via collect). We then rely upon sorting upon receipt to put everything back in a sane order. Differential Revision: https://phabricator.services.mozilla.com/D120520
16308825081d0f46d658c5b51224009b93dc8041: Bug 1720841 - Clamp loop condition variable to static value in cs_blur. r=gw
Jamie Nicol <jnicol@mozilla.com> - Mon, 19 Jul 2021 21:17:07 +0000 - rev 586072
Push 38625 by archaeopteryx@coole-files.de at Tue, 20 Jul 2021 09:46:04 +0000
Bug 1720841 - Clamp loop condition variable to static value in cs_blur. r=gw In the cs_blur fragment shader there is a for loop with a number of iterations determined by a flat varying. On some old Adreno drivers this causes severe issues including hangs and crashes. These can be avoided by clamping the number of iterations to a statically known value. Differential Revision: https://phabricator.services.mozilla.com/D120281
6801389075ebcaaa44e3217877bb041135b782f9: Bug 1717592 - Allow rendering tiles and segments with the opaque pass in more cases. r=gw
Nicolas Silva <nsilva@mozilla.com> - Mon, 05 Jul 2021 15:46:02 +0000 - rev 584780
Push 38585 by smolnar@mozilla.com at Mon, 05 Jul 2021 21:30:49 +0000
Bug 1717592 - Allow rendering tiles and segments with the opaque pass in more cases. r=gw Differential Revision: https://phabricator.services.mozilla.com/D114954
ab0835f9c26792583c502be43100222deae798ca: Bug 1459526 - Handle full-range video in Webrender. r=gw,lsalzman
Jeff Gilbert <jgilbert@mozilla.com> - Fri, 25 Jun 2021 19:16:22 +0000 - rev 584447
Push 38566 by dluca@mozilla.com at Sat, 26 Jun 2021 09:46:54 +0000
Bug 1459526 - Handle full-range video in Webrender. r=gw,lsalzman + Begin to add video tests to ensure we ratchet towards correctness. + Test rec709 x (yuv420p, yuv420p10, gbrp) x (tv, pc) x codecs. + Just mark fuzziness for now. Better would be e.g. 16_127_233 'bad references'. Differential Revision: https://phabricator.services.mozilla.com/D115298
10a229d128c0ff0c059abbcac250db8398a40004: Bug 1459526 - Handle full-range video in Webrender. r=gw,lsalzman
Jeff Gilbert <jgilbert@mozilla.com> - Thu, 24 Jun 2021 23:43:31 +0000 - rev 584321
Push 38563 by cbrindusan@mozilla.com at Fri, 25 Jun 2021 09:34:36 +0000
Bug 1459526 - Handle full-range video in Webrender. r=gw,lsalzman + Begin to add video tests to ensure we ratchet towards correctness. + Test rec709 x (yuv420p, yuv420p10, gbrp) x (tv, pc) x codecs. + Just mark fuzziness for now. Better would be e.g. 16_127_233 'bad references'. Differential Revision: https://phabricator.services.mozilla.com/D115298
1f8cbba9a51a930e1f81bd0f711faf057529e4d1: Bug 1717911. Block SW-WR + D3D11 on Intel with 8.15.10.2125-8.15.10.2141 r=gw,lsalzman
Jeff Muizelaar <jmuizelaar@mozilla.com> - Wed, 23 Jun 2021 20:34:12 +0000 - rev 584188
Push 38560 by dluca@mozilla.com at Wed, 23 Jun 2021 21:45:52 +0000
Bug 1717911. Block SW-WR + D3D11 on Intel with 8.15.10.2125-8.15.10.2141 r=gw,lsalzman We see weird crashes from bug 1717519 while trying to draw into the textures. Differential Revision: https://phabricator.services.mozilla.com/D118632
086a825124296adeaf48cc3d05975e82f55fcb85: Bug 1716006 - Clear pending callbacks when destroying a NativeSurfaceWayland, r=gfx-reviewers,gw
Robert Mader <robert.mader@posteo.de> - Sun, 20 Jun 2021 21:05:47 +0000 - rev 583823
Push 38555 by nbeleuzu@mozilla.com at Mon, 21 Jun 2021 09:42:23 +0000
Bug 1716006 - Clear pending callbacks when destroying a NativeSurfaceWayland, r=gfx-reviewers,gw Unlike buffer release callbacks, which can't happen after the corresponding buffer was destroyed, frame callbacks can apparently arrive even if the corresponding surface was destroyed. This kinda makes sense as frame callbacks have independent objects which actually can get destroyed manually. Also wait for the lock in the destructor to not unref the surface below our feet. Differential Revision: https://phabricator.services.mozilla.com/D118274
f7016db57a2e19b8f54897fee21426b4b7a07e9e: Bug 1459526 - Handle full-range video in Webrender. r=gw,lsalzman
Jeff Gilbert <jgilbert@mozilla.com> - Thu, 17 Jun 2021 23:43:34 +0000 - rev 583767
Push 38550 by mlaza@mozilla.com at Fri, 18 Jun 2021 09:20:56 +0000
Bug 1459526 - Handle full-range video in Webrender. r=gw,lsalzman + Begin to add video tests to ensure we ratchet towards correctness. + Test rec709 x (yuv420p, yuv420p10, gbrp) x (tv, pc) x codecs. + Just mark fuzziness for now. Better would be e.g. 16_127_233 'bad references'. Differential Revision: https://phabricator.services.mozilla.com/D115298
318f32313091bb3e184a8102aab8aaed671b56a7: Bug 1459526 - Handle full-range video in Webrender. r=gw,lsalzman
Jeff Gilbert <jgilbert@mozilla.com> - Thu, 17 Jun 2021 01:12:18 +0000 - rev 583611
Push 38544 by abutkovits@mozilla.com at Thu, 17 Jun 2021 04:27:31 +0000
Bug 1459526 - Handle full-range video in Webrender. r=gw,lsalzman + Begin to add video tests to ensure we ratchet towards correctness. + Test rec709 x (yuv420p, yuv420p10, gbrp) x (tv, pc) x codecs. + Just mark fuzziness for now. Better would be e.g. 16_127_233 'bad references'. Differential Revision: https://phabricator.services.mozilla.com/D115298
45e7c2ef38994e408a9b622bc0c83d1725538622: Bug 1716395 - Reorder the profile counters. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 15 Jun 2021 21:25:55 +0000 - rev 583362
Push 38541 by csabou@mozilla.com at Wed, 16 Jun 2021 03:36:43 +0000
Bug 1716395 - Reorder the profile counters. r=gfx-reviewers,gw Only a cosmetic change. There is a check during initialization that the constants match the sequential order so little room for getting it wrong. Differential Revision: https://phabricator.services.mozilla.com/D117702
2c22d2c47e1803b28bb53bb2f1850276e6bdd3c0: Bug 1716395 - Reorder the profile counters. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 15 Jun 2021 10:06:06 +0000 - rev 583237
Push 38540 by smolnar@mozilla.com at Tue, 15 Jun 2021 21:45:02 +0000
Bug 1716395 - Reorder the profile counters. r=gfx-reviewers,gw Only a cosmetic change. There is a check during initialization that the constants match the sequential order so little room for getting it wrong. Differential Revision: https://phabricator.services.mozilla.com/D117702
d0526849e7c37d124bc9aa03d1164ad0f2e22f30: Bug 1716317 - Reorder the profile counters. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Mon, 14 Jun 2021 21:30:01 +0000 - rev 583065
Push 38539 by mlaza@mozilla.com at Tue, 15 Jun 2021 13:44:18 +0000
Bug 1716317 - Reorder the profile counters. r=gfx-reviewers,gw Only a cosmetic change. There is a check during initialization that the constants match the sequential order so little room for getting it wrong. Differential Revision: https://phabricator.services.mozilla.com/D117702
1c8a69c5290166d92ce290136e560dd234493ec1: Bug 1715058 - Disable annotation of draw call crashes. r=gfx-reviewers,gw
Jamie Nicol <jnicol@mozilla.com> - Wed, 09 Jun 2021 07:36:51 +0000 - rev 582407
Push 38527 by ncsoregi@mozilla.com at Thu, 10 Jun 2021 03:46:06 +0000
Bug 1715058 - Disable annotation of draw call crashes. r=gfx-reviewers,gw These annotations were useful for fixing crashes without known steps to reproduce in the past, but the frequency of setting and unsetting the annotations has a measurable impact on performance. This patch therefore disables the annotations, but keeps the code behind a flag so that it can easily be enabled if required for a future bug. Differential Revision: https://phabricator.services.mozilla.com/D117152
254bc19a58d74880aeb421fc996ac9a9fc6d31a3: Bug 1695016 - Go back to 32 bits rendder task ids. r=gw
Nicolas Silva <nsilva@mozilla.com> - Mon, 31 May 2021 08:38:27 +0000 - rev 581459
Push 38508 by imoraru@mozilla.com at Tue, 01 Jun 2021 03:29:03 +0000
Bug 1695016 - Go back to 32 bits rendder task ids. r=gw This is to work around fuzzers repeatedly finding test cases with 2^16 clip masks or other type of render tasks. Not something we would see in real pages nor something that we would handle well at all even with 32 bits ids but at least it won't get in the way of fuzzing. Differential Revision: https://phabricator.services.mozilla.com/D116214
a4543484d194faf08f10aef845b50d8111bc4f72: Bug 1712472 - Reenable depth-buffer in EGL config if native compositor is used, r=jgilbert,gw
Robert Mader <robert.mader@posteo.de> - Tue, 25 May 2021 08:03:28 +0000 - rev 580575
Push 38490 by apavel@mozilla.com at Tue, 25 May 2021 15:34:49 +0000
Bug 1712472 - Reenable depth-buffer in EGL config if native compositor is used, r=jgilbert,gw After D113532, a depth-buffer is not needed any more for the draw compositor and it was subsequently removed from the EGL and GLX context providers in D115216. This, however, broke the experimental Wayland native compositor integration, which still needs it. `SurfacePoolCA` solves this by manually attaching a depth buffer in `CreateFramebufferForTexture`. `SurfacePoolWayland` will likely be able to do the same eventually, however until that is the case we need the GL context to provide it. While on it, move the hardcoded bits into a better place below the hard-coded values for ANGLE and remove now used code to make things less cluttered. Context: the `aDepth` argument was introduced in D76417 for EGL on X11 support, which used `RenderCompositorOGL`. This was changed in D108508, making X11/EGL use `RenderCompositorEGL` instead, which uses a shared GL singleton. This again required the color depth to be independent of the window, so 32bit color depth was hardcoded in D109737. Therefore, the `aDepth` and other things introduced in D76417 can be removed again. Finally, it was found that we only need 32bit depth when used with HW-WR, see also D114959. Differential Revision: https://phabricator.services.mozilla.com/D115760
b2aae9afa4a558c9e3a92efdaabc54bfcb024885: Bug 1706561 Part 5: Intern polygon data for image masks, and retrieve for hit tests. r=gw
Brad Werth <bwerth@mozilla.com> - Thu, 20 May 2021 17:26:23 +0000 - rev 580314
Push 38479 by malexandru@mozilla.com at Fri, 21 May 2021 09:57:54 +0000
Bug 1706561 Part 5: Intern polygon data for image masks, and retrieve for hit tests. r=gw This moves the polygon data out of the ClipItemKind and ClipItemKeyKind enums, which reduces bloat, which improves access times for scenes with lots of clips -- even if they don't use image mask clips. The SceneBuilder interns polygons when they arrive alongside image mask clips, and the HitTestingScene retrieves them when it's time to build the hit test nodes. Differential Revision: https://phabricator.services.mozilla.com/D114558
d6d0a9726fb83435126958fd8471dff8de3f98d9: Bug 1706561 Part 4: Passthrough SceneBuilder Interners to HitTestScene. r=gw
Brad Werth <bwerth@mozilla.com> - Thu, 20 May 2021 17:26:22 +0000 - rev 580313
Push 38479 by malexandru@mozilla.com at Fri, 21 May 2021 09:57:54 +0000
Bug 1706561 Part 4: Passthrough SceneBuilder Interners to HitTestScene. r=gw HitTestScene will need to access the SceneBuilder interners in order to pull polygon data when creating HitTestNodes. This patch isolates the function signature changes and the passthrough of the interners, without actually using the interners for anything yet. Differential Revision: https://phabricator.services.mozilla.com/D114557
62f10a2fceee997c573a197103d448227a614f05: Bug 1706561 Part 3: Make intern Handles hashable. r=gw
Brad Werth <bwerth@mozilla.com> - Thu, 20 May 2021 17:26:22 +0000 - rev 580312
Push 38479 by malexandru@mozilla.com at Fri, 21 May 2021 09:57:54 +0000
Bug 1706561 Part 3: Make intern Handles hashable. r=gw This is needed to support the use of intern::Handle structs in hashable enums. Differential Revision: https://phabricator.services.mozilla.com/D114556
0cadee5455a1a74621c8b0ebf9af38b05a580ae1: Bug 1706561 Part 2: Update profiler ids to also track interned polygons. r=gw
Brad Werth <bwerth@mozilla.com> - Thu, 20 May 2021 17:26:22 +0000 - rev 580311
Push 38479 by malexandru@mozilla.com at Fri, 21 May 2021 09:57:54 +0000
Bug 1706561 Part 2: Update profiler ids to also track interned polygons. r=gw Defining a new interner requires a new profiler tag. Adding a new tag requires that some ids need to be shifted to maintain continuity with the other interners. This patch isolates those changes without actually creating the new polygon interner in the hope that it makes the reviewing easier. Differential Revision: https://phabricator.services.mozilla.com/D114555
b9ebbb0e9db0005fa12db2c63d09e26c29c5402d: Bug 1706561 Part 1: Only push a SetPoints DisplayItem when points have been provided. r=gw
Brad Werth <bwerth@mozilla.com> - Thu, 20 May 2021 17:26:21 +0000 - rev 580310
Push 38479 by malexandru@mozilla.com at Fri, 21 May 2021 09:57:54 +0000
Bug 1706561 Part 1: Only push a SetPoints DisplayItem when points have been provided. r=gw This reduces the size of the display list in the common case of an image mask having no associated hit-test polygon. Differential Revision: https://phabricator.services.mozilla.com/D113000
8517832fbb9210d56d18636ae9bb61d87924a98b: Bug 1705024 - Evict unused cached render tasks after 10 frames. r=gfx-reviewers,gw
Nicolas Silva <nsilva@mozilla.com> - Wed, 19 May 2021 08:05:33 +0000 - rev 580003
Push 38475 by smolnar@mozilla.com at Wed, 19 May 2021 16:00:41 +0000
Bug 1705024 - Evict unused cached render tasks after 10 frames. r=gfx-reviewers,gw Cached render tasks are usually much cheaper to produce than texture uploads so it's good to make sure lingering unused render tasks don't create unnecessary pressure on the texture cache. It also avoids things like animated gradients from filling the texture cache in a second. Depends on D115206 Differential Revision: https://phabricator.services.mozilla.com/D115207