searching for reviewer(glandium)
7648560f810d7cdde45d5fa69f7f42eae7223002: Bug 1715282 - Bump minimum Rust version to 1.50. r=glandium
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 11 Jun 2021 19:27:22 +0000 - rev 582878
Push 38533 by nerli@mozilla.com at Sat, 12 Jun 2021 09:41:20 +0000
Bug 1715282 - Bump minimum Rust version to 1.50. r=glandium Various people want 1.50 and it's been out for a while so let's require it. Differential Revision: https://phabricator.services.mozilla.com/D117158
7780b7c82d2279ae8df88dd8dcfffad9bb5d306e: Bug 1524662 - Add --enable-path-remapping producing compiled objects with generic paths. r=glandium
Nick Alexander <nalexander@mozilla.com> - Thu, 10 Jun 2021 17:08:06 +0000 - rev 582714
Push 38531 by mlaza@mozilla.com at Fri, 11 Jun 2021 09:42:05 +0000
Bug 1524662 - Add --enable-path-remapping producing compiled objects with generic paths. r=glandium For "c" (i.e., gcc, clang, and clang-cl), this configures the `-f{debug,macro}-path-prefix` flags. We'd prefer to use `-ffile-path-prefix`, but it seems that `clang-cl` does not recognize that flag. For "rust" (i.e., rustc/cargo), this configures `--remap-path-prefix`. This is one step toward getting `sccache` hits across source and object directories. Differential Revision: https://phabricator.services.mozilla.com/D113065
49f8a4acd649d13294e1b9fbd947311527e6ed65: Bug 1712674 -- If RtlLookupFunctionEntry fails, attempt to unwind from BP - r=glandium
Gerald Squelart <gsquelart@mozilla.com> - Wed, 09 Jun 2021 00:28:03 +0000 - rev 582387
Push 38525 by abutkovits@mozilla.com at Wed, 09 Jun 2021 09:35:13 +0000
Bug 1712674 -- If RtlLookupFunctionEntry fails, attempt to unwind from BP - r=glandium BP may contain the stack address where the caller's BP was pushed after the function call, in which case it's possible to carefully unwind from it. This can get past JIT code, so there is no need to give up in this case. mozglue was already linked with ntdll, but now that we use it directly (for `NtQueryInformationThread`), ntdll needed to be added to some other users of MozStackWalkThread. Differential Revision: https://phabricator.services.mozilla.com/D115962
d7851e4d899178f6700785e6b7f18216df53c39f: Bug 1710358 - Update wasi-sdk to the version 12. r=tcampbell,glandium.
Dmitry Bezhetskov <dbezhetskov@igalia.com> - Tue, 08 Jun 2021 04:08:30 +0000 - rev 582174
Push 38522 by archaeopteryx@coole-files.de at Tue, 08 Jun 2021 09:18:19 +0000
Bug 1710358 - Update wasi-sdk to the version 12. r=tcampbell,glandium. Update wasi-sdk from version 11 to the version 12. This is primary needed to be able to build SM on wasi platform. Differential Revision: https://phabricator.services.mozilla.com/D116574
3a6a274dae0d0051763178b7048df60e4991bff7: Bug 1709640 - Add GeckoView Lite build variant. r=jmaher,aklotz,mhentges,glandium
Agi Sferro <agi@sferro.dev> - Mon, 07 Jun 2021 21:49:07 +0000 - rev 582152
Push 38522 by archaeopteryx@coole-files.de at Tue, 08 Jun 2021 09:18:19 +0000
Bug 1709640 - Add GeckoView Lite build variant. r=jmaher,aklotz,mhentges,glandium This patch adds a new GeckoView build variant dubbed "lite". We are in the process of adding some optional dependencies to GeckoView that are needed by Fenix (like Glean and Nimbus) which are likely not going to be used by anyone else at Mozilla. To avoid bloating third party consumers, we provide a geckoview-lite build that doesn't contain any optional dependency. The min SDK version of GeckoView (non-lite) is being increased to 21 to match Glean's min SDK. Given that Fenix's min SDK version is already 21 and that the lite version's min SDK is still at 16 this change is safe to do and will not incur in any loss of usability. Differential Revision: https://phabricator.services.mozilla.com/D114370
b5eb71cf51d58da1616bf50fd04fcaa860494df4: Bug 1709640 - Rename android-api-16 to android-arm. r=marionette-reviewers,firefox-build-system-reviewers,nalexander,whimboo,aklotz,releng-reviewers,mhentges,glandium,mtabara
Agi Sferro <agi@sferro.dev> - Fri, 04 Jun 2021 22:31:14 +0000 - rev 582004
Push 38516 by smolnar@mozilla.com at Sat, 05 Jun 2021 03:56:19 +0000
Bug 1709640 - Rename android-api-16 to android-arm. r=marionette-reviewers,firefox-build-system-reviewers,nalexander,whimboo,aklotz,releng-reviewers,mhentges,glandium,mtabara We don't offer API splits any more, and with the separation of GeckoView with the rest of the front-end it's increasingly unlikely that we will in the future. This change makes it so that the build name doesn't contain the API version so that we can update it without breaking all the automation that relies on the build name. Differential Revision: https://phabricator.services.mozilla.com/D114369
453cb34e4a4a56abaac6bc1fa976e19fb04004f7: Bug 1709640 - Rename android-api-16 to android-arm. r=marionette-reviewers,firefox-build-system-reviewers,nalexander,whimboo,aklotz,releng-reviewers,mhentges,glandium,mtabara
Agi Sferro <agi@sferro.dev> - Fri, 04 Jun 2021 21:20:56 +0000 - rev 581998
Push 38516 by smolnar@mozilla.com at Sat, 05 Jun 2021 03:56:19 +0000
Bug 1709640 - Rename android-api-16 to android-arm. r=marionette-reviewers,firefox-build-system-reviewers,nalexander,whimboo,aklotz,releng-reviewers,mhentges,glandium,mtabara We don't offer API splits any more, and with the separation of GeckoView with the rest of the front-end it's increasingly unlikely that we will in the future. This change makes it so that the build name doesn't contain the API version so that we can update it without breaking all the automation that relies on the build name. Differential Revision: https://phabricator.services.mozilla.com/D114369
fa1a8a489ee277cf1ae21f3ff735c577c1d79c7c: Bug 1713081 - Fix to use the default clang from upstream for SM WASI. r=glandium
Dmitry Bezhetskov <dbezhetskov@igalia.com> - Wed, 02 Jun 2021 06:00:10 +0000 - rev 581658
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1713081 - Fix to use the default clang from upstream for SM WASI. r=glandium To compile SM to .wasm we need to use clang from wasi-sdk, this patch allows us to use default clang-12 from mozilla's repo. We remove usage of rpath-link flag because wasm-ld doesn't support it, enable single thread model because wasi is single threaded and finally add <unistd.h> becase it is forbidden to use read/write/lseek without this header. Differential Revision: https://phabricator.services.mozilla.com/D116207
1c110c9d06c3f38dbee3d91d1ac30bad4f721cf2: Bug 1713564 - add missing ScopeExit header r=glandium
Petr Sumbera <petr.sumbera@oracle.com> - Tue, 01 Jun 2021 22:44:23 +0000 - rev 581638
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1713564 - add missing ScopeExit header r=glandium Differential Revision: https://phabricator.services.mozilla.com/D116354
7b34993b950f6945c671b38ca0f34c20ef0ddab6: Bug 1713174 - add missing ScopeExit header r=glandium
Petr Sumbera <petr.sumbera@oracle.com> - Sat, 29 May 2021 19:32:56 +0000 - rev 581415
Push 38501 by dluca@mozilla.com at Sat, 29 May 2021 21:44:00 +0000
Bug 1713174 - add missing ScopeExit header r=glandium Differential Revision: https://phabricator.services.mozilla.com/D116156
9494a0c6f129b31096f2f1725ef7d6a0bce3154a: Bug 1695817 - Part 5: Add std::equal_range equivalent in MFBT. r=glandium
Toshihito Kikuchi <tkikuchi@mozilla.com> - Fri, 28 May 2021 22:35:58 +0000 - rev 581387
Push 38500 by smolnar@mozilla.com at Sat, 29 May 2021 09:25:54 +0000
Bug 1695817 - Part 5: Add std::equal_range equivalent in MFBT. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D114598
4a9bcb38fddf022c3a2b276dc2d4a8a7a546a849: Bug 1695817 - Part 5: Add std::equal_range equivalent in MFBT. r=glandium
Toshihito Kikuchi <tkikuchi@mozilla.com> - Fri, 28 May 2021 15:32:31 +0000 - rev 581232
Push 38499 by nerli@mozilla.com at Sat, 29 May 2021 03:43:09 +0000
Bug 1695817 - Part 5: Add std::equal_range equivalent in MFBT. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D114598
812a6bbfbe0efc9c869fe3d2cb08d35cd84222a4: Bug 1695817 - Part 5: Add std::equal_range equivalent in MFBT. r=glandium
Toshihito Kikuchi <tkikuchi@mozilla.com> - Fri, 28 May 2021 04:19:07 +0000 - rev 581186
Push 38498 by malexandru@mozilla.com at Fri, 28 May 2021 21:48:03 +0000
Bug 1695817 - Part 5: Add std::equal_range equivalent in MFBT. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D114598
c73705233fc4c43198cac3da01c4d1b5b8c650c8: Bug 1695817 - Part 5: Add std::equal_range equivalent in MFBT. r=glandium
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 27 May 2021 21:14:14 +0000 - rev 581148
Push 38498 by malexandru@mozilla.com at Fri, 28 May 2021 21:48:03 +0000
Bug 1695817 - Part 5: Add std::equal_range equivalent in MFBT. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D114598
c1bda584266eb189c162dabcd3aff2655022b2ac: Bug 1712382: Includes virtualenvs when clobbering Python r=glandium
Mitchell Hentges <mhentges@mozilla.com> - Thu, 27 May 2021 18:04:32 +0000 - rev 581011
Push 38497 by apavel@mozilla.com at Thu, 27 May 2021 21:28:01 +0000
Bug 1712382: Includes virtualenvs when clobbering Python r=glandium No longer includes `python` in the `./mach clobber` defaults since python cache files should no longer be affecting `./mach artifact`. Removes `third_party/python` purging from `./mach clobber python` since we don't build native Python modules there. Moves virtualenv-purging from `./mach clobber objdir` to `./mach clobber python`. Differential Revision: https://phabricator.services.mozilla.com/D115728
2e37a3ce90c2e7e2ecc612d2499a9bf15edb0bf1: Bug 1712133: Remove build VIRTUALENV_NAME customization r=glandium
Mitchell Hentges <mhentges@mozilla.com> - Thu, 27 May 2021 15:18:35 +0000 - rev 580974
Push 38497 by apavel@mozilla.com at Thu, 27 May 2021 21:28:01 +0000
Bug 1712133: Remove build VIRTUALENV_NAME customization r=glandium This was originally set up so that tests wouldn't "create a new `virtualenv` for no reason." However, virtual environments now will have different packages installed, and therefore the separation is necessary. So, for the virtual environment used for builds (regular or for tests): * We want it to be able to reuse the build venv, if it already exists. * We don't want to pollute a `pytest` virtualenv with build-specific packages. Differential Revision: https://phabricator.services.mozilla.com/D115641
15f0e4e860b5beb10aa42965ffe94345b39087cb: Bug 1705783 - add configure option --js-package and stop clearing MOZ_AUTOMATION for SM(pkg) r=glandium,firefox-build-system-reviewers
Steve Fink <sfink@mozilla.com> - Wed, 26 May 2021 16:54:04 +0000 - rev 580770
Push 38493 by imoraru@mozilla.com at Wed, 26 May 2021 21:17:56 +0000
Bug 1705783 - add configure option --js-package and stop clearing MOZ_AUTOMATION for SM(pkg) r=glandium,firefox-build-system-reviewers Differential Revision: https://phabricator.services.mozilla.com/D112627
5a1efb6ae9b81a1f51ba9cf5182f92c1c5644fd0: Bug 1706949 part 13 - Fix icu and intl for wasi. r=anba,glandium
Chris Fallin <chris@cfallin.org> - Wed, 26 May 2021 06:44:09 +0000 - rev 580700
Push 38492 by cbrindusan@mozilla.com at Wed, 26 May 2021 16:02:53 +0000
Bug 1706949 part 13 - Fix icu and intl for wasi. r=anba,glandium Differential Revision: https://phabricator.services.mozilla.com/D113218
6f5d773533443594b860443184108ba5fe56bc1d: Bug 1712245 - Use x86_64 NDK on Apple Slicon if native NDK is missing. r=firefox-build-system-reviewers,glandium
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 26 May 2021 01:37:37 +0000 - rev 580691
Push 38491 by malexandru@mozilla.com at Wed, 26 May 2021 09:48:46 +0000
Bug 1712245 - Use x86_64 NDK on Apple Slicon if native NDK is missing. r=firefox-build-system-reviewers,glandium Actually, Google doesn't release native version of NDK for macOS/aarch64. So if missing, we use x86_64 NDK instead. Differential Revision: https://phabricator.services.mozilla.com/D115675
21b0c552bf0c7dd3bd57d31a41cd33f1742f4074: Bug 1695031 - Combine build flags --disable-marionette and --enable-cdp as --disable-webdriver. r=firefox-build-system-reviewers,Gijs,smaug,keeler,jdescottes,glandium
Henrik Skupin <mail@hskupin.info> - Tue, 25 May 2021 09:13:28 +0000 - rev 580583
Push 38490 by apavel@mozilla.com at Tue, 25 May 2021 15:34:49 +0000
Bug 1695031 - Combine build flags --disable-marionette and --enable-cdp as --disable-webdriver. r=firefox-build-system-reviewers,Gijs,smaug,keeler,jdescottes,glandium Differential Revision: https://phabricator.services.mozilla.com/D115583
b4c891b1a31eea7aa1923ac0bae2346bf7543883: Bug 1709352 - Allow QMResult errors to use existing stack id and to increase the frame id during error propagation; r=dom-storage-reviewers,asuth,glandium
Jan Varga <jvarga@mozilla.com> - Tue, 25 May 2021 07:28:20 +0000 - rev 580571
Push 38490 by apavel@mozilla.com at Tue, 25 May 2021 15:34:49 +0000
Bug 1709352 - Allow QMResult errors to use existing stack id and to increase the frame id during error propagation; r=dom-storage-reviewers,asuth,glandium Differential Revision: https://phabricator.services.mozilla.com/D114243
225d9db4ad361a098445ad69c80820554d843651: Bug 1709459 - make ASAN skip 32-bit ffi_call in addition to 64-bit ones (see bug 1279096) r=glandium
Steve Fink <sfink@mozilla.com> - Thu, 20 May 2021 21:21:52 +0000 - rev 580340
Push 38479 by malexandru@mozilla.com at Fri, 21 May 2021 09:57:54 +0000
Bug 1709459 - make ASAN skip 32-bit ffi_call in addition to 64-bit ones (see bug 1279096) r=glandium Differential Revision: https://phabricator.services.mozilla.com/D114904
9aff2b1ea30b20022c86bf13b2e02730750067fd: Bug 1710957 - Do not pass -RELEASE argument to lld-link. r=firefox-build-system-reviewers,mhentges,glandium
Rob Lemley <rob@thunderbird.net> - Thu, 20 May 2021 16:02:35 +0000 - rev 580294
Push 38479 by malexandru@mozilla.com at Fri, 21 May 2021 09:57:54 +0000
Bug 1710957 - Do not pass -RELEASE argument to lld-link. r=firefox-build-system-reviewers,mhentges,glandium This fixes several warnings from clang-cl/lld-link when building Firefox. -RELEASE is not supported by lld-link. Differential Revision: https://phabricator.services.mozilla.com/D115061
ff52343b2e529b32d3280f4a407f3d307df80da6: Bug 1709277 - Simplify gOOMAllocationSize via MFBT_DATA r=glandium
Alexandre Lissy <lissyx@lissyx.dyndns.org> - Thu, 20 May 2021 06:53:27 +0000 - rev 580188
Push 38478 by imoraru@mozilla.com at Thu, 20 May 2021 09:57:45 +0000
Bug 1709277 - Simplify gOOMAllocationSize via MFBT_DATA r=glandium Differential Revision: https://phabricator.services.mozilla.com/D115339
f6ebe9de807298c16618f317a813a62d9a1f0f40: Bug 1694531: Clarify try docs regarding signing and OS signatures r=glandium DONTBUILD
Mitchell Hentges <mhentges@mozilla.com> - Tue, 18 May 2021 15:00:45 +0000 - rev 579911
Push 38472 by imoraru@mozilla.com at Tue, 18 May 2021 21:36:28 +0000
Bug 1694531: Clarify try docs regarding signing and OS signatures r=glandium DONTBUILD * Don't use a separate heading level for the signature-resolution section, since RST thought it was more important than the others (the original goal was for it to be a lesser header). * Clarify that the "damaged" error is caused by the app being quarantined, and not because of the key used to sign the app. Differential Revision: https://phabricator.services.mozilla.com/D112249
21e6408f323ab5ecf05d5f0e115e07a865ea1c88: Bug 1706774: Adds required sources for the "memory" application r=firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 18 May 2021 15:00:39 +0000 - rev 579910
Push 38472 by imoraru@mozilla.com at Tue, 18 May 2021 21:36:28 +0000
Bug 1706774: Adds required sources for the "memory" application r=firefox-build-system-reviewers,glandium Replay, moajemalloc_info, phc, and memory needed additional pieces (mostly Printf.cpp and dependencies) to build successfully on Windows. Depends on D114651 Differential Revision: https://phabricator.services.mozilla.com/D114652
4002812791d3bc59a9d1d2aeb03dbf7598ae93db: Bug 1671114 - pt 7. Make an ambigious comment clearer r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 18 May 2021 06:33:49 +0000 - rev 579862
Push 38469 by ncsoregi@mozilla.com at Tue, 18 May 2021 09:45:31 +0000
Bug 1671114 - pt 7. Make an ambigious comment clearer r=glandium Differential Revision: https://phabricator.services.mozilla.com/D113946
5080af04619c99e5fd177830bc48809bdadcecd3: Bug 1671114 - pt 6. Use default values for Replay members r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 18 May 2021 06:33:49 +0000 - rev 579861
Push 38469 by ncsoregi@mozilla.com at Tue, 18 May 2021 09:45:31 +0000
Bug 1671114 - pt 6. Use default values for Replay members r=glandium Differential Revision: https://phabricator.services.mozilla.com/D104178
695befd03096e131963f4ef7219d8fdd8ae026c4: Bug 1671114 - pt 5. Optionally touch memory as its allocated r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 18 May 2021 06:33:48 +0000 - rev 579860
Push 38469 by ncsoregi@mozilla.com at Tue, 18 May 2021 09:45:31 +0000
Bug 1671114 - pt 5. Optionally touch memory as its allocated r=glandium By touching memory when we allocate it our RSS will more accurately represent Firefox's memory usage. Differential Revision: https://phabricator.services.mozilla.com/D98286
df6b79d1d16e975ff193870f3d413548a61a9029: Bug 1671114 - pt 4. Calculate and report RSS in jemalloc-replay r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 18 May 2021 06:33:48 +0000 - rev 579859
Push 38469 by ncsoregi@mozilla.com at Tue, 18 May 2021 09:45:31 +0000
Bug 1671114 - pt 4. Calculate and report RSS in jemalloc-replay r=glandium Differential Revision: https://phabricator.services.mozilla.com/D94259
059550178c6bf291fb3d6c40b3377fa5fb3cfeee: Bug 1671114 - pt 3. Allow open/close state for FdReader r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 18 May 2021 06:33:48 +0000 - rev 579858
Push 38469 by ncsoregi@mozilla.com at Tue, 18 May 2021 09:45:31 +0000
Bug 1671114 - pt 3. Allow open/close state for FdReader r=glandium Differential Revision: https://phabricator.services.mozilla.com/D104177
3e72253ce070d2156f993e1dce12fe5cb56a4eba: Bug 1671114 - pt 2. Speed up replay of jemalloc_stats calls r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 18 May 2021 06:33:47 +0000 - rev 579857
Push 38469 by ncsoregi@mozilla.com at Tue, 18 May 2021 09:45:31 +0000
Bug 1671114 - pt 2. Speed up replay of jemalloc_stats calls r=glandium Calculate the distributions of memory requests in a single pass. Differential Revision: https://phabricator.services.mozilla.com/D93724
d2757d932f49149067ddfcb7ae03dbbed1e410e8: Bug 1671114 - pt 1. Report committed memory in logalloc-replay r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 18 May 2021 06:33:47 +0000 - rev 579856
Push 38469 by ncsoregi@mozilla.com at Tue, 18 May 2021 09:45:31 +0000
Bug 1671114 - pt 1. Report committed memory in logalloc-replay r=glandium Differential Revision: https://phabricator.services.mozilla.com/D93473
57fa96d8d7089d1436c8b1c0a5be4eb996d8ced3: Bug 1706216 - Enable Remote Agent in Thunderbird. r=whimboo,remote-protocol-reviewers,firefox-build-system-reviewers,glandium
Geoff Lankow <geoff@darktrojan.net> - Thu, 13 May 2021 23:14:24 +0000 - rev 579615
Push 38462 by smolnar@mozilla.com at Fri, 14 May 2021 09:42:22 +0000
Bug 1706216 - Enable Remote Agent in Thunderbird. r=whimboo,remote-protocol-reviewers,firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D112677
640d8a87b172e06d4753e5e535900610d475d7c6: Bug 1708379 - Remove unnecessary line. r=glandium
Cosmin Sabou <csabou@mozilla.com> - Fri, 07 May 2021 04:08:30 +0300 - rev 578803
Push 38443 by nbeleuzu@mozilla.com at Fri, 07 May 2021 09:52:21 +0000
Bug 1708379 - Remove unnecessary line. r=glandium
27c129b20b9371eb03f1e4412ebb14dbaca80846: Bug 1708379 - Add suppression for valgrind failures. r=glandium
Cosmin Sabou <csabou@mozilla.com> - Fri, 07 May 2021 03:28:21 +0300 - rev 578800
Push 38443 by nbeleuzu@mozilla.com at Fri, 07 May 2021 09:52:21 +0000
Bug 1708379 - Add suppression for valgrind failures. r=glandium CLOSED TREE
8b11be10e7da66fc689cc4a4ece32cfd4063fae7: Bug 1709496 - Fix clippy mozlint failure. r=glandium
Cosmin Sabou <csabou@mozilla.com> - Fri, 07 May 2021 00:46:37 +0300 - rev 578790
Push 38443 by nbeleuzu@mozilla.com at Fri, 07 May 2021 09:52:21 +0000
Bug 1709496 - Fix clippy mozlint failure. r=glandium
148918c92a77821166f8947d3ed6de619b37fa7c: Bug 1709753 - remove workaround for llvm issue D100625. r=glandium
Andi-Bogdan Postelnicu <andi@mozilla.com> - Thu, 06 May 2021 05:20:18 +0000 - rev 578682
Push 38440 by malexandru@mozilla.com at Thu, 06 May 2021 15:49:21 +0000
Bug 1709753 - remove workaround for llvm issue D100625. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D114449
85ea0bb3c7cdd6a9dc1cbecd0fe0068ad666c5c7: Bug 1698616: Bump python dependencies r=firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 04 May 2021 20:43:26 +0000 - rev 578519
Push 38434 by nbeleuzu@mozilla.com at Wed, 05 May 2021 04:13:36 +0000
Bug 1698616: Bump python dependencies r=firefox-build-system-reviewers,glandium Did you know that our version of requests was from 2015? Phwoar! This bumps `jinja2`, `py`, `pyyaml`, `requests` and `urllib3`. There's significant risk for regressions due to breaking changes, though due to the dynamic nature of Python, they're tricky to track down. The potential breaking changes I'm expecting to potentially affect us are: * `requests@2.11.0`: No longer accepts non-strings as header values. * `requests@2.16.0`: `requests.packages` namespace was removed due to packages no longer being vendored. The namespace has been incrementally restored over future releases, but it's unclear to what degree. * `requests@2.24.0`: Redirect resolution now only happens when `allow_redirects` is `True`. * `requests` version of `urllib3` was bumped from `1.13.1` to `1.26`, unsure what repercussions that will have. This also added dependencies to `flake8_requirements`. This is because the vendored `importlib-metadata` update (and the new `typing-extensions` dependency) is found by `pip`, but the vendored `typing-extensions` is _not_ discovered (perhaps due to details around "eggs" and the way we add vendored code to the sys.path). So, `pip` tries to install it manually and fails when it finds no hash. By re-compiling `flake8_requirements`, the necessary hashes are made available. Differential Revision: https://phabricator.services.mozilla.com/D108526
36f12bac79f34c8553f9b808bc9083beb3e1c48e: Bug 1566090 - Use sha1 hashes in find-dupes.py. r=glandium
Rob Lemley <rob@thunderbird.net> - Tue, 04 May 2021 17:10:37 +0000 - rev 578493
Push 38433 by nbeleuzu@mozilla.com at Tue, 04 May 2021 21:49:50 +0000
Bug 1566090 - Use sha1 hashes in find-dupes.py. r=glandium As suggested in the review comments for bug 1526744 (D37758), sha1 is slightly faster. Variables with "md5" in their names have been renamed as well. Differential Revision: https://phabricator.services.mozilla.com/D113681
da1b92adb04aafe186bfbc5217534ab158430233: Bug 1707953: Remove macOS SDK maximum version check r=firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 04 May 2021 15:07:09 +0000 - rev 578468
Push 38433 by nbeleuzu@mozilla.com at Tue, 04 May 2021 21:49:50 +0000
Bug 1707953: Remove macOS SDK maximum version check r=firefox-build-system-reviewers,glandium The maximum version check has caused more unnecessary failed builds (for freshly up-to-date devs) than helpful guards against tough-to-diagnose issues. Differential Revision: https://phabricator.services.mozilla.com/D113675
97c7ef8a881cfaf3bd98c54db285b53d3df1d50b: Bug 1707546: Support git worktrees when finding ".arcconfig" r=firefox-build-system-reviewers,andi,tcampbell,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 04 May 2021 15:06:42 +0000 - rev 578466
Push 38433 by nbeleuzu@mozilla.com at Tue, 04 May 2021 21:49:50 +0000
Bug 1707546: Support git worktrees when finding ".arcconfig" r=firefox-build-system-reviewers,andi,tcampbell,glandium A `.arcconfig` may exist in the `.git` directory. Within worktrees, the `.git` folder isn't at `<topsrcdir>/.git`, so we have to resolve it. Differential Revision: https://phabricator.services.mozilla.com/D113320
82b000faa0258451f291977758151d8530eda924: Bug 1709274 - Update wrench-macos-build to clang-12. r=glandium
Andi-Bogdan Postelnicu <andi@mozilla.com> - Tue, 04 May 2021 09:08:44 +0000 - rev 578406
Push 38433 by nbeleuzu@mozilla.com at Tue, 04 May 2021 21:49:50 +0000
Bug 1709274 - Update wrench-macos-build to clang-12. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D114202
1b643530229de1d213434256e26e36319cf56964: Bug 1705376: Synchronize workspace-hack features and usage r=firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Thu, 29 Apr 2021 15:19:27 +0000 - rev 578007
Push 38419 by nbeleuzu@mozilla.com at Thu, 29 Apr 2021 21:42:31 +0000
Bug 1705376: Synchronize workspace-hack features and usage r=firefox-build-system-reviewers,glandium Not all in-tree Rust libraries were using workspace-hack. Additionally, some needed winapi features were missing from workspace-hack's configuration. Now, winapi is re-compiled less frequently on a full build. Differential Revision: https://phabricator.services.mozilla.com/D113564
d17d9b0eb0285f4aea92bf6aa3a3f4a2400140b5: Bug 1708005: Remove `target_dir` from `RustLibrary` r=firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Thu, 29 Apr 2021 15:19:09 +0000 - rev 578006
Push 38419 by nbeleuzu@mozilla.com at Thu, 29 Apr 2021 21:42:31 +0000
Bug 1708005: Remove `target_dir` from `RustLibrary` r=firefox-build-system-reviewers,glandium The `target_dir` is always the objdir, since we try to share compile output. Therefore, storing it in `RustLibrary` shouldn't be necessary. Removes the associated `RUST_LIBRARY_TARGET_DIR` moz.build option as well. Differential Revision: https://phabricator.services.mozilla.com/D113565
bd89c077a1e46dd084c56b41a83c109b916be3db: Bug 1697215 - Disable value profiling in Rust PGO until we move to to rust 1.52. r=firefox-build-system-reviewers,glandium
Andi-Bogdan Postelnicu <andi@mozilla.com> - Wed, 28 Apr 2021 09:56:12 +0000 - rev 577809
Push 38417 by imoraru@mozilla.com at Thu, 29 Apr 2021 09:26:05 +0000
Bug 1697215 - Disable value profiling in Rust PGO until we move to to rust 1.52. r=firefox-build-system-reviewers,glandium Credit goes to dmajor. Rust gets LLVM 12 - https://github.com/rust-lang/rust/pull/81451. The PGO format changed between 11 and 12, and builds will have poor optimization if we mix versions in xLTO. The above PR has landed on Rust nightly 1.52. Until we move to 1.52 nightly we should have this landed. In the meantime, for unblocking try builds, we can disable value-PGO in Rust. Differential Revision: https://phabricator.services.mozilla.com/D113327
255461fcffe4267649fc55ada20eeb3af24dd718: Bug 1704764: Don't warn about Defender exclusions if missing permissions r=firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 27 Apr 2021 20:16:15 +0000 - rev 577710
Push 38413 by abutkovits@mozilla.com at Wed, 28 Apr 2021 03:32:08 +0000
Bug 1704764: Don't warn about Defender exclusions if missing permissions r=firefox-build-system-reviewers,glandium Newer versions of Windows don't allow un-elevated processes to access the list of Windows Defender exclusions. Rather than incorrectly falling back to assuming that there's no exclusions, we now instead skip the exclusion check. Differential Revision: https://phabricator.services.mozilla.com/D112648
f499b74db63f398bcf4a0bfb2c6d7c1cbf56b242: Bug 1704775 part 10 - Disable unsupported c++ tests. r=glandium
Chris Fallin <chris@cfallin.org> - Tue, 27 Apr 2021 06:09:27 +0000 - rev 577573
Push 38409 by imoraru@mozilla.com at Tue, 27 Apr 2021 09:55:09 +0000
Bug 1704775 part 10 - Disable unsupported c++ tests. r=glandium WASI doesn't support some c++ tests for threads, so in this patch we just stubbed them out. Differential Revision: https://phabricator.services.mozilla.com/D111815
5f7a8e0f52661c9e568bddb1a1c0bbccdd0675f2: Bug 1676803 - [remote] Enable Remote Agent on Android. r=firefox-build-system-reviewers,mhentges,glandium
Henrik Skupin <mail@hskupin.info> - Mon, 26 Apr 2021 19:46:09 +0000 - rev 577533
Push 38409 by imoraru@mozilla.com at Tue, 27 Apr 2021 09:55:09 +0000
Bug 1676803 - [remote] Enable Remote Agent on Android. r=firefox-build-system-reviewers,mhentges,glandium Differential Revision: https://phabricator.services.mozilla.com/D112005
8cf80eeb4fee3baee292400f9793a704933ee410: Bug 1706197 - Avoid Python version dependent line number issues r=firefox-build-system-reviewers,glandium
Steve Fink <sfink@mozilla.com> - Thu, 22 Apr 2021 14:30:49 +0000 - rev 577091
Push 38399 by apavel@mozilla.com at Thu, 22 Apr 2021 21:31:57 +0000
Bug 1706197 - Avoid Python version dependent line number issues r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D112760