searching for reviewer(glandium)
e0f6a845537fc87aa0af65c50e38b92fbaff9e44: Bug 1759555 - Part 2: Partially configure rust-analyzer for ./mach ide vscode, r=glandium,andi
Nika Layzell <nika@thelayzells.com> - Tue, 09 Aug 2022 14:12:12 +0000 - rev 626548
Push 40105 by smolnar@mozilla.com at Tue, 09 Aug 2022 21:31:27 +0000
Bug 1759555 - Part 2: Partially configure rust-analyzer for ./mach ide vscode, r=glandium,andi In order to allow rust-analyzer to be able to use the build script in the mozbuild crate to discover the configuration information, this patch adds new flags to the vscode config to tell rust-analyzer to invoke cargo through `./mach cargo check`, and use the correct target directory within the objdir rather than `$(topsrcdir)/target`. Due to the virtual filesystem used by rust-analyzer not including files in the object directory, this is not sufficient to get suggestions for symbols from the included files, however it will accurately fetch diagnostics upon save and run things like proc macros. A new feature will likely need to be added to rust-analyzer to allow us to specify additional paths to add to the source root for packages to fix that issue. Due to this change using `./mach cargo check`, rather than running it independently, we don't run into issues caused by running `check` against crates in the workspace which aren't being used, making the diagnostics more useful. An additional feature needed to be added to `./mach cargo check` to allow specifying `--message-format=json`. I am open to suggestions for a more elegant way to communicate this flag into the makefile. Depends on D153269 Differential Revision: https://phabricator.services.mozilla.com/D153270
01d58d75edf514039d91f1e0511ee12ad3950b35: Bug 1759555 - Part 1: Avoid using env! for includes in the mozbuild crate, r=glandium
Nika Layzell <nika@thelayzells.com> - Tue, 09 Aug 2022 14:12:11 +0000 - rev 626547
Push 40105 by smolnar@mozilla.com at Tue, 09 Aug 2022 21:31:27 +0000
Bug 1759555 - Part 1: Avoid using env! for includes in the mozbuild crate, r=glandium This switches the code to instead use the generated source file, which is discovered based on `OUT_DIR` so is easier for rust-analyzer to understand. The configuration for rust-analyzer will be updated in the next part to make sure that rust-analyzer is able to take advantage of these changes, and produce better diagnostics. Differential Revision: https://phabricator.services.mozilla.com/D153269
82e3752a3dcd8f92d90c8ed1dd8f8021a2438ede: Bug 1749348 - Update double-conversion to version 3.2.1. r=glandium
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 09 Aug 2022 13:47:44 +0000 - rev 626545
Push 40105 by smolnar@mozilla.com at Tue, 09 Aug 2022 21:31:27 +0000
Bug 1749348 - Update double-conversion to version 3.2.1. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D153810
f7ce15ba86ff31ab7c8c4e82acd1014ce420f73a: Bug 1783073 - Update rust version for toolchains to 1.61. r=glandium
Markus Stange <mstange.moz@gmail.com> - Thu, 04 Aug 2022 15:34:38 +0000 - rev 626207
Push 40087 by nfay@mozilla.com at Fri, 05 Aug 2022 09:28:51 +0000
Bug 1783073 - Update rust version for toolchains to 1.61. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D153671
a0eced0bce86bfbda6a3ddb10c80f22563e041f8: Bug 1782604 - Make UniquePtr(nullptr) constexpr r=glandium
Emily McDonough <emcdonough@mozilla.com> - Wed, 03 Aug 2022 21:21:09 +0000 - rev 626071
Push 40080 by smolnar@mozilla.com at Thu, 04 Aug 2022 04:34:13 +0000
Bug 1782604 - Make UniquePtr(nullptr) constexpr r=glandium Differential Revision: https://phabricator.services.mozilla.com/D153405
9e28580c45056c8c70bcc2cc65d0018bb6a0bf3c: Bug 1766045 - Adding mach command to generate UniFFI files r=glandium
Ben Dean-Kawamura <bdk@mozilla.com> - Wed, 03 Aug 2022 18:59:36 +0000 - rev 626059
Push 40080 by smolnar@mozilla.com at Thu, 04 Aug 2022 04:34:13 +0000
Bug 1766045 - Adding mach command to generate UniFFI files r=glandium Added `mach uniffi generate` which executes `uniffi-bindgen-gecko-js` to generate UniFFI bindings. It's unfortunate that we need to check these files in, but I couldn't figure out a way to auto-generate them as part of the build process. Adding `#include "nsIContent.h"` to dom/base/nsINodeList.h. I think that should have been present before, but things built okay because of the way things got combined in the uniffied .cpp files. Adding these new webIDL files bumped `NodeListBinding.cpp` to a new uniffied .cpp file which caused the build to fail. Differential Revision: https://phabricator.services.mozilla.com/D144468
40c7a52560d2dcb0a77e477ae70f588a0d24adfe: Bug 1766045 - Vendoring in Rust code for uniffi-bindgen-gecko-js r=glandium,supply-chain-reviewers
Ben Dean-Kawamura <bdk@mozilla.com> - Wed, 03 Aug 2022 18:59:36 +0000 - rev 626058
Push 40080 by smolnar@mozilla.com at Thu, 04 Aug 2022 04:34:13 +0000
Bug 1766045 - Vendoring in Rust code for uniffi-bindgen-gecko-js r=glandium,supply-chain-reviewers - Added `--enable-uniffi-fixtures` flag. When set, we will compile in the UniFFI test fixtures into our shared Rust crate and eventually into `libxul`. - Vendoring in the Rust crates needed for `uniffi-bindgen-gecko-js` Differential Revision: https://phabricator.services.mozilla.com/D144467
84c998372e2fe77b250682628998917fd060dbf5: Bug 1761291: create wrapper to launch Firefox in Private Browsing mode r=rkraesig,glandium
Ben Hearsum <bhearsum@mozilla.com> - Wed, 03 Aug 2022 13:49:04 +0000 - rev 625989
Push 40079 by smolnar@mozilla.com at Wed, 03 Aug 2022 21:28:30 +0000
Bug 1761291: create wrapper to launch Firefox in Private Browsing mode r=rkraesig,glandium This allows us to fix a bug where when our current Private Browsing shortcuts are pinned to the Start Menu, they use the regular Firefox Visual Elements (which is the non-Private Browsing logo). I tried to make this as minimal and braindead as possible. Differential Revision: https://phabricator.services.mozilla.com/D151538
e8bc2ec40cffeaad069e25d8f257802ed5b46c4b: Bug 1766045 - Adding mach command to generate UniFFI files r=glandium
Ben Dean-Kawamura <bdk@mozilla.com> - Wed, 03 Aug 2022 13:48:28 +0000 - rev 625985
Push 40079 by smolnar@mozilla.com at Wed, 03 Aug 2022 21:28:30 +0000
Bug 1766045 - Adding mach command to generate UniFFI files r=glandium Added `mach uniffi generate` which executes `uniffi-bindgen-gecko-js` to generate UniFFI bindings. It's unfortunate that we need to check these files in, but I couldn't figure out a way to auto-generate them as part of the build process. Adding `#include "nsIContent.h"` to dom/base/nsINodeList.h. I think that should have been present before, but things built okay because of the way things got combined in the uniffied .cpp files. Adding these new webIDL files bumped `NodeListBinding.cpp` to a new uniffied .cpp file which caused the build to fail. Differential Revision: https://phabricator.services.mozilla.com/D144468
2d33e41ac507c29e3d328fdf03eb6d728393defa: Bug 1766045 - Vendoring in Rust code for uniffi-bindgen-gecko-js r=glandium,supply-chain-reviewers
Ben Dean-Kawamura <bdk@mozilla.com> - Wed, 03 Aug 2022 13:48:27 +0000 - rev 625984
Push 40079 by smolnar@mozilla.com at Wed, 03 Aug 2022 21:28:30 +0000
Bug 1766045 - Vendoring in Rust code for uniffi-bindgen-gecko-js r=glandium,supply-chain-reviewers - Added `--enable-uniffi-fixtures` flag. When set, we will compile in the UniFFI test fixtures into our shared Rust crate and eventually into `libxul`. - Vendoring in the Rust crates needed for `uniffi-bindgen-gecko-js` Differential Revision: https://phabricator.services.mozilla.com/D144467
c17cd594e84c5a945eb52a1126f75433410e1ffe: Bug 1782855 - Add MSVC to required list for Windows build docs. r=glandium DONTBUILD
Mathew Hodson <mathew.hodson@gmail.com> - Wed, 03 Aug 2022 09:43:32 +0000 - rev 625890
Push 40077 by abutkovits@mozilla.com at Wed, 03 Aug 2022 15:54:41 +0000
Bug 1782855 - Add MSVC to required list for Windows build docs. r=glandium DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D153545
839f7f52434489ff18172cbc8232731fe54f0ecc: Bug 1782523 - Update NodeJS to latest versions for the branches. r=firefox-build-system-reviewers,glandium
Mark Banner <standard8@mozilla.com> - Wed, 03 Aug 2022 07:29:08 +0000 - rev 625885
Push 40077 by abutkovits@mozilla.com at Wed, 03 Aug 2022 15:54:41 +0000
Bug 1782523 - Update NodeJS to latest versions for the branches. r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D153445
5708672d0e83c1421e683f2a37281d04cf83804f: Bug 1766045 - Vendoring in Rust code for uniffi-bindgen-gecko-js r=glandium,supply-chain-reviewers
Ben Dean-Kawamura <bdk@mozilla.com> - Tue, 02 Aug 2022 19:51:48 +0000 - rev 625793
Push 40074 by ccozmuta@mozilla.com at Wed, 03 Aug 2022 03:42:48 +0000
Bug 1766045 - Vendoring in Rust code for uniffi-bindgen-gecko-js r=glandium,supply-chain-reviewers - Added `--enable-uniffi-fixtures` flag. When set, we will compile in the UniFFI test fixtures into our shared Rust crate and eventually into `libxul`. - Vendoring in the Rust crates needed for `uniffi-bindgen-gecko-js` Differential Revision: https://phabricator.services.mozilla.com/D144467
08607f50a78ae6c5b93806be94017f7e4b5c66ce: Bug 1682520 p2: Register the WER Runtime Exception Module very early in process start up. r=gsvelto,glandium
Bob Owen <bobowencode@gmail.com> - Tue, 02 Aug 2022 10:41:14 +0000 - rev 625717
Push 40071 by smolnar@mozilla.com at Tue, 02 Aug 2022 16:02:54 +0000
Bug 1682520 p2: Register the WER Runtime Exception Module very early in process start up. r=gsvelto,glandium Depends on D152198 Differential Revision: https://phabricator.services.mozilla.com/D152199
9cd56f898487a1854a3acc981a632bdd1601fd7b: Bug 1682520 p1: Move GeckoProcessType and implementation of get and set into mozglue. r=glandium
Bob Owen <bobowencode@gmail.com> - Tue, 02 Aug 2022 10:41:14 +0000 - rev 625716
Push 40071 by smolnar@mozilla.com at Tue, 02 Aug 2022 16:02:54 +0000
Bug 1682520 p1: Move GeckoProcessType and implementation of get and set into mozglue. r=glandium This means we can set and use the process type earlier in process startup. Differential Revision: https://phabricator.services.mozilla.com/D152198
679e1933422500258e3ab61902d9b8329501feef: Bug 1682520 p2: Register the WER Runtime Exception Module very early in process start up. r=gsvelto,glandium
Bob Owen <bobowencode@gmail.com> - Fri, 29 Jul 2022 18:10:54 +0000 - rev 625510
Push 40058 by ccozmuta@mozilla.com at Sat, 30 Jul 2022 09:25:53 +0000
Bug 1682520 p2: Register the WER Runtime Exception Module very early in process start up. r=gsvelto,glandium Depends on D152198 Differential Revision: https://phabricator.services.mozilla.com/D152199
dad72c7e0d7b8a7248a85eacca7ec56df8011535: Bug 1682520 p1: Move GeckoProcessType and implementation of get and set into separate files. r=glandium
Bob Owen <bobowencode@gmail.com> - Fri, 29 Jul 2022 18:10:53 +0000 - rev 625509
Push 40058 by ccozmuta@mozilla.com at Sat, 30 Jul 2022 09:25:53 +0000
Bug 1682520 p1: Move GeckoProcessType and implementation of get and set into separate files. r=glandium This means we can include these files in other binaries when we need earlier access to the process type and use consistent code. Differential Revision: https://phabricator.services.mozilla.com/D152198
e410f86b09a5ebfc1d2587e98dc629602fe2973b: Bug 1777414 - Vendor standalone 'looseversion' at version 1.0.1 r=firefox-build-system-reviewers,glandium
ahochheiden <ahochheiden@mozilla.com> - Fri, 29 Jul 2022 02:03:37 +0000 - rev 625454
Push 40053 by abutkovits@mozilla.com at Fri, 29 Jul 2022 09:34:10 +0000
Bug 1777414 - Vendor standalone 'looseversion' at version 1.0.1 r=firefox-build-system-reviewers,glandium This will be used to replace the `LooseVersion` within `distutils`. `StrictVersion` from `distutils` will need something else, as swapping usages of `StrictVersion` with `LooseVersion` does not result in the desired behavior. Differential Revision: https://phabricator.services.mozilla.com/D151062
97f176456412feb794aa5ab132cba852e506191d: Bug 1774829 - wasm: Vendor latest wast crate. r=yury,glandium,supply-chain-reviewers
Ryan Hunt <rhunt@eqrion.net> - Thu, 28 Jul 2022 15:25:42 +0000 - rev 625395
Push 40050 by mlaza@mozilla.com at Thu, 28 Jul 2022 21:53:01 +0000
Bug 1774829 - wasm: Vendor latest wast crate. r=yury,glandium,supply-chain-reviewers Differential Revision: https://phabricator.services.mozilla.com/D151738
a8bc03d5f5230381402e1198cd95fa35b1eb92d4: Bug 1772090 - implement about:processes on OpenBSD r=glandium,jld,gerald
George Koehler <gkoehler@openbsd.org> - Thu, 28 Jul 2022 07:14:28 +0000 - rev 625357
Push 40048 by nfay@mozilla.com at Thu, 28 Jul 2022 16:09:13 +0000
Bug 1772090 - implement about:processes on OpenBSD r=glandium,jld,gerald Differential Revision: https://phabricator.services.mozilla.com/D150338
2cec83cd66fee11c8699cc5b75df490e66be3d31: Bug 1716727 - [3/3] make stalling behavior conditional on process type r=glandium
Ray Kraesig <rkraesig@mozilla.com> - Wed, 27 Jul 2022 19:54:36 +0000 - rev 625313
Push 40047 by bszekely@mozilla.com at Thu, 28 Jul 2022 09:32:33 +0000
Bug 1716727 - [3/3] make stalling behavior conditional on process type r=glandium For now, make Set_XREProcessType set a flag in mozjemalloc to avoid stalling repeatedly in auxiliary processes. Differential Revision: https://phabricator.services.mozilla.com/D151332
1623fcafb8be37400d4bf7ea19b82fc2e9124435: Bug 1716727 - [2/3] OOM handling: stall and retry r=glandium,gsvelto
Ray Kraesig <rkraesig@mozilla.com> - Wed, 27 Jul 2022 19:54:36 +0000 - rev 625312
Push 40047 by bszekely@mozilla.com at Thu, 28 Jul 2022 09:32:33 +0000
Bug 1716727 - [2/3] OOM handling: stall and retry r=glandium,gsvelto Implement a drop-in-replacement wrapper for `VirtualAlloc` which, rather than returning immediately on failure, instead `::Sleep()`s and retries. This will cause performance regressions in some (presumed-uncommon) circumstances; this wrapper is therefore only enabled in Nightly, to collect data on its efficacy and on the severity of those regressions. Differential Revision: https://phabricator.services.mozilla.com/D150619
e701e18d194421d9b4b32ea50e0b0228270228e1: Bug 1716727 - [1/3] Drive-by cleanup: clang-tidy nitpicks r=glandium
Ray Kraesig <rkraesig@mozilla.com> - Wed, 27 Jul 2022 19:54:35 +0000 - rev 625311
Push 40047 by bszekely@mozilla.com at Thu, 28 Jul 2022 09:32:33 +0000
Bug 1716727 - [1/3] Drive-by cleanup: clang-tidy nitpicks r=glandium Some trivially-resolvable nitpicks pointed out by clang-tidy. Differential Revision: https://phabricator.services.mozilla.com/D150618
c84108ada24c7ef4bfeacfd94339b00491021b69: Bug 1779312 - Replace uses of strerror in Linux sandbox code. r=glandium
Jed Davis <jld@mozilla.com> - Wed, 27 Jul 2022 19:41:05 +0000 - rev 625310
Push 40047 by bszekely@mozilla.com at Thu, 28 Jul 2022 09:32:33 +0000
Bug 1779312 - Replace uses of strerror in Linux sandbox code. r=glandium `strerror` is async signal unsafe, and we're using it in contexts where that's a problem: in particular in the child process after `clone()`ing, where it can deadlock if it takes locks the parents' other threads had held (or cause other undefined behavior), but also in the SIGSYS handler if it's nested inside an async signal. It's also thread-unsafe. This is mostly a mechanical replacement with the new `SANDBOX_LOG_ERRNO` or `SANDBOX_LOG_WITH_ERROR`; two messages had the error string in the middle and have been adjusted. Differential Revision: https://phabricator.services.mozilla.com/D152099
de2eccf44572f8d7f0a00abae8208646399b54d3: Bug 1779312 - Add macros for Linux sandbox logging with an error code. r=glandium
Jed Davis <jld@mozilla.com> - Wed, 27 Jul 2022 19:41:05 +0000 - rev 625309
Push 40047 by bszekely@mozilla.com at Thu, 28 Jul 2022 09:32:33 +0000
Bug 1779312 - Add macros for Linux sandbox logging with an error code. r=glandium This adds two new logging macros, which are intended to be async signal safe: * `SANDBOX_LOG_ERRNO`, which appends the error similarly to `perror` but uses the error identifier (e.g., `EINVAL` instead of `Invalid argument`). Unlike `perror`, formatting directives are available as for `SANDBOX_LOG`. * `SANDBOX_LOG_WITH_ERROR` is the same thing but the error number is the first argument instead of using `errno`; this is useful for newer POSIX APIs which return an error number. This will be used in the next patch to replace the existing use of `strerror`, which is not async signal safe (or thread-safe). Differential Revision: https://phabricator.services.mozilla.com/D152098
4ed8e078268a00775ccf0ff84f1b6a22b6df6274: Bug 1779312 - Rename `SANDBOX_LOG_ERROR` to just `SANDBOX_LOG`. r=glandium
Jed Davis <jld@mozilla.com> - Wed, 27 Jul 2022 19:41:04 +0000 - rev 625308
Push 40047 by bszekely@mozilla.com at Thu, 28 Jul 2022 09:32:33 +0000
Bug 1779312 - Rename `SANDBOX_LOG_ERROR` to just `SANDBOX_LOG`. r=glandium Originally this was written for B2G and used the Android logging facility, which (like syslog) includes a severity level. However, all current usage is on desktop where we just write to stderr, and there was never much demand to add support for any log levels besides "error". More importantly for the current situation, renaming the macro to `SANDBOX_LOG` avoids confusion between `SANDBOX_LOG_ERROR` and `SANDBOX_LOG_ERRNO` (or `SANDBOX_LOG_ERROR_ERRNO` or whatever). Differential Revision: https://phabricator.services.mozilla.com/D152097
2413d3f6d41cc5ab247699eb08a69e999f46f9bf: Bug 1779312 - Preliminary fixes to some misuses of SANDBOX_LOG_ERROR. r=glandium
Jed Davis <jld@mozilla.com> - Wed, 27 Jul 2022 19:41:04 +0000 - rev 625307
Push 40047 by bszekely@mozilla.com at Thu, 28 Jul 2022 09:32:33 +0000
Bug 1779312 - Preliminary fixes to some misuses of SANDBOX_LOG_ERROR. r=glandium Two minor things I noticed while converting the existing sandbox logging: 1. One call site was using %u, but that doesn't exist in this printf dialect, only %d; signedness is determined by the actual argument type via template magic. 2. POSIX functions that return an error number just return the number; there was one place that was negating it before use, as if it had come from the Linux syscall ABI. Differential Revision: https://phabricator.services.mozilla.com/D152096
b120c87b1de7021b2c5b568dcdb2f3cfa8d848bf: Bug 1779845 - Don't rewrite macos executables. r=glandium
Jesse Schwartzentruber <truber@mozilla.com> - Wed, 27 Jul 2022 15:09:27 +0000 - rev 625290
Push 40045 by imoraru@mozilla.com at Wed, 27 Jul 2022 21:44:05 +0000
Bug 1779845 - Don't rewrite macos executables. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D151961
11fb3262cccb69615f8f8d8fa0af0541dfa39af2: Bug 1716727 - [3/3] make stalling behavior conditional on process type r=glandium
Ray Kraesig <rkraesig@mozilla.com> - Wed, 27 Jul 2022 00:30:04 +0000 - rev 625259
Push 40042 by ctuns@mozilla.com at Wed, 27 Jul 2022 09:37:31 +0000
Bug 1716727 - [3/3] make stalling behavior conditional on process type r=glandium For now, make Set_XREProcessType set a flag in mozjemalloc to avoid stalling repeatedly in auxiliary processes. Differential Revision: https://phabricator.services.mozilla.com/D151332
895ad65452369f9ada4956ea29ddb535de0760ab: Bug 1716727 - [2/3] OOM handling: stall and retry r=glandium,gsvelto
Ray Kraesig <rkraesig@mozilla.com> - Wed, 27 Jul 2022 00:30:04 +0000 - rev 625258
Push 40042 by ctuns@mozilla.com at Wed, 27 Jul 2022 09:37:31 +0000
Bug 1716727 - [2/3] OOM handling: stall and retry r=glandium,gsvelto Implement a drop-in-replacement wrapper for `VirtualAlloc` which, rather than returning immediately on failure, instead `::Sleep()`s and retries. This will cause performance regressions in some (presumed-uncommon) circumstances; this wrapper is therefore only enabled in Nightly, to collect data on its efficacy and on the severity of those regressions. Differential Revision: https://phabricator.services.mozilla.com/D150619
c0fd4f429cd8f5ba45e3351d74fdac8561a1a2b2: Bug 1716727 - [1/3] Drive-by cleanup: clang-tidy nitpicks r=glandium
Ray Kraesig <rkraesig@mozilla.com> - Wed, 27 Jul 2022 00:30:03 +0000 - rev 625257
Push 40042 by ctuns@mozilla.com at Wed, 27 Jul 2022 09:37:31 +0000
Bug 1716727 - [1/3] Drive-by cleanup: clang-tidy nitpicks r=glandium Some trivially-resolvable nitpicks pointed out by clang-tidy. Differential Revision: https://phabricator.services.mozilla.com/D150618
c3ca80551fbab42fbb67be92bd7a724055b3e7f5: Bug 1742828 - Enable more aggressive allocation packing on MacOS r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 26 Jul 2022 23:54:17 +0000 - rev 625254
Push 40042 by ctuns@mozilla.com at Wed, 27 Jul 2022 09:37:31 +0000
Bug 1742828 - Enable more aggressive allocation packing on MacOS r=glandium Differential Revision: https://phabricator.services.mozilla.com/D139800
5be323098aaa9c2b0dde20d01f3af216b32210be: Bug 1565125 - Use TASKCLUSTER_PROXY_URL for mozharness secrets; r=glandium
Geoff Brown <gbrown@mozilla.com> - Wed, 20 Jul 2022 15:00:20 +0000 - rev 624527
Push 40007 by smolnar@mozilla.com at Wed, 20 Jul 2022 21:52:02 +0000
Bug 1565125 - Use TASKCLUSTER_PROXY_URL for mozharness secrets; r=glandium Differential Revision: https://phabricator.services.mozilla.com/D151399
3a19960fa87980a83421d2042421c6a20fcff283: Bug 1773520 - add vscode build backend by default if vscode is installed, r=firefox-build-system-reviewers,nalexander,glandium
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 18 Jul 2022 13:14:23 +0000 - rev 624261
Push 39998 by mlaza@mozilla.com at Mon, 18 Jul 2022 18:44:09 +0000
Bug 1773520 - add vscode build backend by default if vscode is installed, r=firefox-build-system-reviewers,nalexander,glandium Differential Revision: https://phabricator.services.mozilla.com/D150147
abaf9791876533b52bc3716911d227f0b3856d39: Bug 1207753 - add thread-safety annotations to memory/build's Mutex types r=glandium,jesup
Ray Kraesig <rkraesig@mozilla.com> - Fri, 08 Jul 2022 21:24:03 +0000 - rev 623392
Push 39958 by abutkovits@mozilla.com at Sat, 09 Jul 2022 09:37:14 +0000
Bug 1207753 - add thread-safety annotations to memory/build's Mutex types r=glandium,jesup Add the customary bevy of thread-safety annotations to the Mutex types in memory/build. Almost all existing instances of these Mutexes are already marked with MOZ_UNANNOTATED, but this turns out not to matter: MOZ_UNANNOTATED has no equivalent under clang's `-Wthread-safety` attributes. There are no variables declared to be guarded by these mutexes, but they must still be unlocked and relocked in principled ways -- or, alternatively, only have unverifiable actions taken in appropriately-annotated code. The primary offenders here are the `pthread_atfork` hooks; these can't all be annotated precisely (and couldn't be checked even if they were), so we simply mark them all as unanalyzable. The only other warning is from a highly unusual (but already well-commented) bit in PHC.cpp where we manually release an autolocked mutex before crashing. Differential Revision: https://phabricator.services.mozilla.com/D150519
ea1db7e224d5d13a76b791314c65cee703c254c7: Bug 1480331 - Compile and build JsonCpp without exception handling - r=glandium
Gerald Squelart <gsquelart@mozilla.com> - Fri, 08 Jul 2022 13:32:37 +0000 - rev 623334
Push 39956 by nbeleuzu@mozilla.com at Fri, 08 Jul 2022 21:42:04 +0000
Bug 1480331 - Compile and build JsonCpp without exception handling - r=glandium JsonCpp is used in different places around Firefox, which is normally built without exception handling, so we don't want JsonCpp to `throw`. Because we don't want to modify the JsonCpp files themselves (to ease future update from the source), and some of its headers are directly included around Firefox, we need to define `JSON_USE_EXCEPTION` to be 0 everywhere, which can be done through moz.configure. JsonCpp replaces its exception-triggering code with C asserts and aborts. Differential Revision: https://phabricator.services.mozilla.com/D151190
5b3d5876d849560cf9f25773116db7dcc53e7600: Bug 1762571 - Upgrade NodeJS to v12 for the build system and v16 for tests. r=firefox-build-system-reviewers,glandium
Mark Banner <standard8@mozilla.com> - Thu, 07 Jul 2022 22:08:59 +0000 - rev 623280
Push 39951 by imoraru@mozilla.com at Fri, 08 Jul 2022 04:09:57 +0000
Bug 1762571 - Upgrade NodeJS to v12 for the build system and v16 for tests. r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D147173
6d913c78ba7282f652055103ae49641cbc708d14: Bug 1207753 - add thread-safety annotations to memory/build's Mutex types r=glandium,jesup
Ray Kraesig <rkraesig@mozilla.com> - Thu, 30 Jun 2022 17:25:28 +0000 - rev 622726
Push 39921 by smolnar@mozilla.com at Fri, 01 Jul 2022 04:18:35 +0000
Bug 1207753 - add thread-safety annotations to memory/build's Mutex types r=glandium,jesup Add the customary bevy of thread-safety annotations to the Mutex types in memory/build. Almost all existing instances of these Mutexes are already marked with MOZ_UNANNOTATED, so there's not much else required for this patch. The sole exception is a highly unusual (but already well-commented) bit in PHC.cpp where we manually release an autolocked mutex before crashing. Differential Revision: https://phabricator.services.mozilla.com/D150519
59a5d52a3d71d6861892496cb2f4351a73bc012f: Bug 1774569 - Vendor `packaging` at version 21.3 to remove `distutils` dependency r=firefox-build-system-reviewers,glandium
Alex Hochheiden <ahochheiden@mozilla.com> - Thu, 30 Jun 2022 14:28:59 +0000 - rev 622704
Push 39920 by smolnar@mozilla.com at Thu, 30 Jun 2022 21:24:30 +0000
Bug 1774569 - Vendor `packaging` at version 21.3 to remove `distutils` dependency r=firefox-build-system-reviewers,glandium https://pypi.org/project/packaging/21.3/ Differential Revision: https://phabricator.services.mozilla.com/D149679
0ead2f6d0582ff7d9b3f65923b0ed9f520565f44: Bug 1762571 - Upgrade NodeJS to v12 for the build system and v16 for tests. r=firefox-build-system-reviewers,glandium
Mark Banner <standard8@mozilla.com> - Thu, 30 Jun 2022 13:23:24 +0000 - rev 622694
Push 39920 by smolnar@mozilla.com at Thu, 30 Jun 2022 21:24:30 +0000
Bug 1762571 - Upgrade NodeJS to v12 for the build system and v16 for tests. r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D147173
d9571dde686fab9e29c7a49b28dfe7ce1a3684f7: Bug 1773520 - add vscode build backend by default if vscode is installed, r=firefox-build-system-reviewers,nalexander,glandium
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 30 Jun 2022 08:38:02 +0000 - rev 622660
Push 39920 by smolnar@mozilla.com at Thu, 30 Jun 2022 21:24:30 +0000
Bug 1773520 - add vscode build backend by default if vscode is installed, r=firefox-build-system-reviewers,nalexander,glandium Differential Revision: https://phabricator.services.mozilla.com/D150147
767478fc10a756e324195ff75fbd80e986f07e35: Bug 1777220 - Remove memory map assertions r=glandium
Paul Bone <pbone@mozilla.com> - Thu, 30 Jun 2022 04:11:11 +0000 - rev 622640
Push 39918 by bszekely@mozilla.com at Thu, 30 Jun 2022 09:55:19 +0000
Bug 1777220 - Remove memory map assertions r=glandium Now that we know these assertions fire, we can remove them. Differential Revision: https://phabricator.services.mozilla.com/D150695
b60e9cff74dfdfc1cd08f93b4e2723fc426b1221: Bug 1163452 - Only register stderr if it differs from stdout. r=glandium
Nick Alexander <nalexander@mozilla.com> - Wed, 29 Jun 2022 17:15:45 +0000 - rev 622583
Push 39916 by ccozmuta@mozilla.com at Wed, 29 Jun 2022 21:58:21 +0000
Bug 1163452 - Only register stderr if it differs from stdout. r=glandium Under certain Windows shells, the handle for stderr may be the same as the handle for stdout. Avoid crashing in this case. Differential Revision: https://phabricator.services.mozilla.com/D150517
0560ec528cb4e269079d8ce26f65d291dc4a576e: Bug 1776455 - Don't define unused functions on Windows. r=glandium
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 29 Jun 2022 13:18:22 +0000 - rev 622559
Push 39916 by ccozmuta@mozilla.com at Wed, 29 Jun 2022 21:58:21 +0000
Bug 1776455 - Don't define unused functions on Windows. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D150444
467cc49519ff50c5cc6297a40602899e38cde0a9: Bug 1776429 - Compile and use ffvpx video decoder/fft code on Apple Silicon Macs. r=glandium
Paul Adenot <paul@paul.cx> - Wed, 29 Jun 2022 09:55:59 +0000 - rev 622439
Push 39916 by ccozmuta@mozilla.com at Wed, 29 Jun 2022 21:58:21 +0000
Bug 1776429 - Compile and use ffvpx video decoder/fft code on Apple Silicon Macs. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D150250
a23d45700fdb8bbaebb4bd3f764076f1db047e51: Bug 1743781 - The memory reporter will count jemalloc chunks as unique r=glandium
Paul Bone <pbone@mozilla.com> - Wed, 29 Jun 2022 06:47:04 +0000 - rev 622423
Push 39914 by nfay@mozilla.com at Wed, 29 Jun 2022 16:48:50 +0000
Bug 1743781 - The memory reporter will count jemalloc chunks as unique r=glandium Differential Revision: https://phabricator.services.mozilla.com/D144702
379adf8891920779c4194118b00cfc6eda682896: Bug 1776096 - Hack case-sensitivity for cargo-vet. r=glandium
Bobby Holley <bobbyholley@gmail.com> - Fri, 24 Jun 2022 04:11:27 +0000 - rev 621992
Push 39892 by nfay@mozilla.com at Fri, 24 Jun 2022 09:35:42 +0000
Bug 1776096 - Hack case-sensitivity for cargo-vet. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D150215
76020fbd478b53d468df4c02610a3c423fc0c591: Bug 1774594 - Don't add color flags to linker. r=glandium
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 Jun 2022 06:42:35 +0000 - rev 621550
Push 39878 by mlaza@mozilla.com at Tue, 21 Jun 2022 15:52:43 +0000
Bug 1774594 - Don't add color flags to linker. r=glandium This should work. I don't recall there being any linker honoring these but I might be wrong. Differential Revision: https://phabricator.services.mozilla.com/D149609
4c74b9cd212a95a76bbb95bc2248e062c346c927: Bug 1772856 - Add designated initializers to list of acceptable C++ features r=firefox-build-system-reviewers,bholley,glandium DONTBUILD
Ray Kraesig <rkraesig@mozilla.com> - Wed, 15 Jun 2022 07:12:02 +0000 - rev 620933
Push 39854 by imoraru@mozilla.com at Wed, 15 Jun 2022 15:46:59 +0000
Bug 1772856 - Add designated initializers to list of acceptable C++ features r=firefox-build-system-reviewers,bholley,glandium DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D148416
16420ba4d29132acf605833cd7c7a0cd280c38ea: Bug 1769405 - Part 4: Detect mismatch between the default mozconfig and the selected build target. r=firefox-build-system-reviewers,glandium
Tooru Fujisawa <arai_a@mac.com> - Tue, 14 Jun 2022 18:13:54 +0000 - rev 620901
Push 39851 by nerli@mozilla.com at Wed, 15 Jun 2022 03:55:43 +0000
Bug 1769405 - Part 4: Detect mismatch between the default mozconfig and the selected build target. r=firefox-build-system-reviewers,glandium When `./mach bootstrap` is called with the default mozconfig file, verify the content matches the selected build target, and if not, show a warning and ask whether to overwrite or not. Differential Revision: https://phabricator.services.mozilla.com/D146384