searching for reviewer(gl)
c0be3e87b8eb9fd67bcc03b010f146af805d7535: Bug 1676419 - [devtools] Remove the react based rule view r=rcaliman,gl
Julian Descottes <jdescottes@mozilla.com> - Mon, 15 Feb 2021 16:49:00 +0000 - rev 567551
Push 38206 by btara@mozilla.com at Tue, 16 Feb 2021 03:10:51 +0000
Bug 1676419 - [devtools] Remove the react based rule view r=rcaliman,gl This revision removes the react based rule view from the code base. In order to make it easier to add it back later on, the stack currently contains several patches to add it back. Those patches were made by splitting a single backout patch. The idea is to make it easier to rebase this series of "restore" patches as the code evolves. Each patch should be focused on an isolated part of the React RuleView: - part 1: adding all the files back (should not conflict, except for the moz.build potentially) - part 2: plug back the preference and the code to add the ruleview as a side panel - part 3: everything related to location change - part 4: everything related to stylesheet updates - part 5: small additional fixes While they won't land here, we should review them to make sure the descriptions are good enough. They will then be moved to a dedicated bug. Differential Revision: https://phabricator.services.mozilla.com/D96594
dabd16270a486c002cde29d03d9cb1fe37e63d34: Bug 1623906 - [devtools] Dispatch thunks from Grid panel React components to show/hide the Box Model Highlighter r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 29 Oct 2020 14:35:58 +0000 - rev 555219
Push 37906 by nbeleuzu@mozilla.com at Fri, 30 Oct 2020 21:38:50 +0000
Bug 1623906 - [devtools] Dispatch thunks from Grid panel React components to show/hide the Box Model Highlighter r=gl Depends on D95035 This patch is using the approach introduced in D79556 to dispatch thunks (functions) to the Redux store to show/hide the box model highlighter from individual React components instead of passing down the methods through deeply nested trees of components that don't use them. The Redux `dispatch()` method is passed down via the component tree instead. This enables further usage of dispatching thunks for other scenarios avoiding prop drilling. The `showBoxModelHighlighterForNode` and `hideBoxModelHighlighter` props and methods are removed in favor of the corresponding thunks. Differential Revision: https://phabricator.services.mozilla.com/D95036
f14a419b4c605e403685f40b81a482cb44e24cac: Bug 1623906 - [devtools] Dispatch thunks from Box Model panel React components to show/hide the Box Model Highlighter r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 29 Oct 2020 14:35:53 +0000 - rev 555216
Push 37906 by nbeleuzu@mozilla.com at Fri, 30 Oct 2020 21:38:50 +0000
Bug 1623906 - [devtools] Dispatch thunks from Box Model panel React components to show/hide the Box Model Highlighter r=gl Depends on D79556 This patch is using the approach introduced in D79556 to dispatch thunks (functions) to the Redux store to show/hide the box model highlighter from individual React components instead of passing down the methods through deeply nested trees of components that don't use them. The Redux `dispatch()` method is passed down via the component tree instead. This enables further usage of dispatching thunks for other scenarios avoiding prop drilling. The `showBoxModelHighlighterForNode`, `hideBoxModelHighlighter` and `showBoxModelHighlighter` props and methods are removed in favor of the corresponding thunks. Differential Revision: https://phabricator.services.mozilla.com/D95033
3fda2292a5f3940fbc53127f7539765b388586b5: Bug 1623906 - [devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe
Razvan Caliman <rcaliman@mozilla.com> - Thu, 29 Oct 2020 14:35:55 +0000 - rev 555215
Push 37906 by nbeleuzu@mozilla.com at Fri, 30 Oct 2020 21:38:50 +0000
Bug 1623906 - [devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe ### Problem There is a lot of [prop drilling](https://kentcdodds.com/blog/prop-drilling) in React components to pass down a callback that is invoked at the bottom of a long chain of components. [onShowBoxModelHighlighterForNode()](https://searchfox.org/mozilla-central/search?path=&q=onShowBoxModelHighlighterForNode) is one such example. It is created at the [Inspector client level](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/inspector/inspector.js#1885-1908) then passed to React components for panels, then drilled down to the consumer component which invokes it. There is also some [needless duplication](https://searchfox.org/mozilla-central/source/devtools/client/inspector/layout/layout.js#85-86) with [onShowBoxModelHighlighter](https://searchfox.org/mozilla-central/search?q=onShowBoxModelHighlighter%5CW&path=&case=false&regexp=true). ### Solution With this patch, we leverage thunks in Redux. In Redux, you can `dispatch()`: - actions -> an object with an action type string which is matched by reducers - thunks -> a function which can be async and can itself dispatch actions or other thunks Thunks are supported by middleware already set up in the DevTools Redux [createStore()](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104) helper. During store setup, we pass `thunkOptions` to the middleware, an object with arguments which will be available to all thunks when invoked. This is where we pass in the inspector client as a thunk option so we can invoke the highlighter. This is the replacement for prop drilling the `onShowBoxModelHighlighterForNode()` method. The same way they dispatch actions, components can now dispatch the thunk to show/hide the highlighter when they need it without direct knowledge of the `inspector`, thus satisfying the original intent of passing down the `onShowBoxModelHighlighterForNode()` callback while cleaning up the code. ### Prior art Thunks are not something new to DevTools. They are extensively used by the WebConsole, for example: - passing [thunk options to the store](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/webconsole/webconsole-wrapper.js#95-104) - making use of thunk options, [webConsoleUI and hud](https://searchfox.org/mozilla-central/source/devtools/client/webconsole/actions/autocomplete.js#14-91) in a thunk to handle autocomplete ###Useful context: DevTools helpers - [thunkWithOptions](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/middleware/thunk-with-options.js) - [shared Redux createStore helper with thunks middleware](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104) Redux docs - [Async Actions in Redux](https://redux.js.org/advanced/async-actions) - [dispatch() as default prop with redux-connect](https://react-redux.js.org/using-react-redux/connect-mapdispatch#default-dispatch-as-a-prop) Differential Revision: https://phabricator.services.mozilla.com/D79556
92d23f0ea155f5067c7aacb7e6d1b625c67a32e1: Bug 1623906 - [devtools] Dispatch thunks from Grid panel React components to show/hide the Box Model Highlighter r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 29 Oct 2020 14:06:01 +0000 - rev 555081
Push 37903 by apavel@mozilla.com at Fri, 30 Oct 2020 03:48:30 +0000
Bug 1623906 - [devtools] Dispatch thunks from Grid panel React components to show/hide the Box Model Highlighter r=gl Depends on D95035 This patch is using the approach introduced in D79556 to dispatch thunks (functions) to the Redux store to show/hide the box model highlighter from individual React components instead of passing down the methods through deeply nested trees of components that don't use them. The Redux `dispatch()` method is passed down via the component tree instead. This enables further usage of dispatching thunks for other scenarios avoiding prop drilling. The `showBoxModelHighlighterForNode` and `hideBoxModelHighlighter` props and methods are removed in favor of the corresponding thunks. Differential Revision: https://phabricator.services.mozilla.com/D95036
362bad2b7311d6d5dff5aeef9355f0d2254ebbd7: Bug 1623906 - [devtools] Dispatch thunks from Box Model panel React components to show/hide the Box Model Highlighter r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 29 Oct 2020 14:04:42 +0000 - rev 555078
Push 37903 by apavel@mozilla.com at Fri, 30 Oct 2020 03:48:30 +0000
Bug 1623906 - [devtools] Dispatch thunks from Box Model panel React components to show/hide the Box Model Highlighter r=gl Depends on D79556 This patch is using the approach introduced in D79556 to dispatch thunks (functions) to the Redux store to show/hide the box model highlighter from individual React components instead of passing down the methods through deeply nested trees of components that don't use them. The Redux `dispatch()` method is passed down via the component tree instead. This enables further usage of dispatching thunks for other scenarios avoiding prop drilling. The `showBoxModelHighlighterForNode`, `hideBoxModelHighlighter` and `showBoxModelHighlighter` props and methods are removed in favor of the corresponding thunks. Differential Revision: https://phabricator.services.mozilla.com/D95033
78d0de3437ab12e222d2ebdfcffbc1ac6a293d30: Bug 1623906 - [devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe
Razvan Caliman <rcaliman@mozilla.com> - Thu, 29 Oct 2020 14:04:25 +0000 - rev 555077
Push 37903 by apavel@mozilla.com at Fri, 30 Oct 2020 03:48:30 +0000
Bug 1623906 - [devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe ### Problem There is a lot of [prop drilling](https://kentcdodds.com/blog/prop-drilling) in React components to pass down a callback that is invoked at the bottom of a long chain of components. [onShowBoxModelHighlighterForNode()](https://searchfox.org/mozilla-central/search?path=&q=onShowBoxModelHighlighterForNode) is one such example. It is created at the [Inspector client level](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/inspector/inspector.js#1885-1908) then passed to React components for panels, then drilled down to the consumer component which invokes it. There is also some [needless duplication](https://searchfox.org/mozilla-central/source/devtools/client/inspector/layout/layout.js#85-86) with [onShowBoxModelHighlighter](https://searchfox.org/mozilla-central/search?q=onShowBoxModelHighlighter%5CW&path=&case=false&regexp=true). ### Solution With this patch, we leverage thunks in Redux. In Redux, you can `dispatch()`: - actions -> an object with an action type string which is matched by reducers - thunks -> a function which can be async and can itself dispatch actions or other thunks Thunks are supported by middleware already set up in the DevTools Redux [createStore()](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104) helper. During store setup, we pass `thunkOptions` to the middleware, an object with arguments which will be available to all thunks when invoked. This is where we pass in the inspector client as a thunk option so we can invoke the highlighter. This is the replacement for prop drilling the `onShowBoxModelHighlighterForNode()` method. The same way they dispatch actions, components can now dispatch the thunk to show/hide the highlighter when they need it without direct knowledge of the `inspector`, thus satisfying the original intent of passing down the `onShowBoxModelHighlighterForNode()` callback while cleaning up the code. ### Prior art Thunks are not something new to DevTools. They are extensively used by the WebConsole, for example: - passing [thunk options to the store](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/webconsole/webconsole-wrapper.js#95-104) - making use of thunk options, [webConsoleUI and hud](https://searchfox.org/mozilla-central/source/devtools/client/webconsole/actions/autocomplete.js#14-91) in a thunk to handle autocomplete ###Useful context: DevTools helpers - [thunkWithOptions](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/middleware/thunk-with-options.js) - [shared Redux createStore helper with thunks middleware](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104) Redux docs - [Async Actions in Redux](https://redux.js.org/advanced/async-actions) - [dispatch() as default prop with redux-connect](https://react-redux.js.org/using-react-redux/connect-mapdispatch#default-dispatch-as-a-prop) Differential Revision: https://phabricator.services.mozilla.com/D79556
33ba7de82d5268f3280e1ed4461d196047d92a11: Bug 1657567 - Prevent shifting focus within a markup container when already selected. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 28 Sep 2020 12:12:13 +0000 - rev 551670
Push 37839 by btara@mozilla.com at Tue, 06 Oct 2020 16:17:06 +0000
Bug 1657567 - Prevent shifting focus within a markup container when already selected. r=gl This is a speculative fix. Open to suggestions if there's a better approach. ## Context When clicking a node in the Markup view, the `MarkupContainer` for that node will shift focus to the [first editor](https://searchfox.org/mozilla-central/rev/d54210d490ef335b13fc1fcac817525120c8c46b/devtools/client/inspector/markup/views/markup-container.js#777-786) for that node's attributes. This is good for accessibility and for keyboard navigation. But when the Markup view is narrow, the effect is shifting the horizontal scroll in order to bring the editor into view. As a mouse user, if I want to double click a node attribute to edit it, the focus shifts as soon as I click first. This is particularly annoying for attributes at the far end of the node. I can't edit the attribute because it shifts away as the focus moves to the first editor. A workaround is to tab through the attribute editors until I get to the desired one Video of the effect and workaround: {F2424060} ## Proposed fix The proposed fix is to keep the original behavior on first click on a `MarkupContainer` (focus the first editor, shift scroll if the viewport is too narrow). But on second click, i.e. the `MarkupContainer` is already selected, skip moving focus and allow the user to edit node attributes. Video of the effect with the patch applied {F2424065} Differential Revision: https://phabricator.services.mozilla.com/D87869
7aa420d4ab544728797f5bdcdfacd46911e0bac9: Bug 1669113 - [devtools] Add a test for double click on scrollable badge r=gl
Julian Descottes <jdescottes@mozilla.com> - Mon, 05 Oct 2020 13:29:47 +0000 - rev 551509
Push 37837 by nbeleuzu@mozilla.com at Mon, 05 Oct 2020 21:58:09 +0000
Bug 1669113 - [devtools] Add a test for double click on scrollable badge r=gl Depends on D92356 Adding a test for the previous changeset Differential Revision: https://phabricator.services.mozilla.com/D92373
2d040d38476fdc1b50f4aa7dcd539fd162ac3f26: Bug 1661283 Part 6: Add a test of NodeActor.isScrollable on various elements. r=gl
Brad Werth <bwerth@mozilla.com> - Mon, 31 Aug 2020 17:56:24 +0000 - rev 547799
Push 37764 by abutkovits@mozilla.com at Tue, 08 Sep 2020 09:52:43 +0000
Bug 1661283 Part 6: Add a test of NodeActor.isScrollable on various elements. r=gl Differential Revision: https://phabricator.services.mozilla.com/D88683
62d68911ba9470741a298ffd1fa3ea610d2364bd: Bug 1661283 Part 5: Add a test of GetOverflowingChildrenOfElement on the body element. r=gl
Brad Werth <bwerth@mozilla.com> - Fri, 04 Sep 2020 13:15:08 +0000 - rev 547798
Push 37764 by abutkovits@mozilla.com at Tue, 08 Sep 2020 09:52:43 +0000
Bug 1661283 Part 5: Add a test of GetOverflowingChildrenOfElement on the body element. r=gl Differential Revision: https://phabricator.services.mozilla.com/D88682
236068f7e724663512490a9dcbd361084695b53c: Bug 1661283 Part 4: Make NodeActor.initialize respect overflow debugging pref. r=gl
Brad Werth <bwerth@mozilla.com> - Wed, 02 Sep 2020 23:52:37 +0000 - rev 547797
Push 37764 by abutkovits@mozilla.com at Tue, 08 Sep 2020 09:52:43 +0000
Bug 1661283 Part 4: Make NodeActor.initialize respect overflow debugging pref. r=gl This also reuses a cached result of isScrollable, to avoid a second call. Differential Revision: https://phabricator.services.mozilla.com/D88507
8b32a0860985987f24eb35d72c065cabc53b4579: Bug 1661283 Part 3: Make NodeActor.isScrollable use the new Element.hasVisibleScrollbars method. r=gl
Brad Werth <bwerth@mozilla.com> - Fri, 28 Aug 2020 22:18:34 +0000 - rev 547796
Push 37764 by abutkovits@mozilla.com at Tue, 08 Sep 2020 09:52:43 +0000
Bug 1661283 Part 3: Make NodeActor.isScrollable use the new Element.hasVisibleScrollbars method. r=gl This removes the need for the document/dom walk. Differential Revision: https://phabricator.services.mozilla.com/D88506
5c4bd81d55d7fb8b97b3dd2e7b2cd16faa067e66: Bug 1660818 - Add telemetry to track the number of times the scrollable badge is clicked. r=gl
manas <manas.khurana20@gmail.com> - Mon, 31 Aug 2020 21:21:29 +0000 - rev 547087
Push 37744 by cbrindusan@mozilla.com at Tue, 01 Sep 2020 03:20:54 +0000
Bug 1660818 - Add telemetry to track the number of times the scrollable badge is clicked. r=gl Differential Revision: https://phabricator.services.mozilla.com/D88049
c266ccdf73a0f3ed0905f15048131e4e497139a6: Bug 1660847 - Add test for scrollable badge click functionality. r=gl
manas <manas.khurana20@gmail.com> - Thu, 27 Aug 2020 21:38:00 +0000 - rev 546715
Push 37736 by apavel@mozilla.com at Fri, 28 Aug 2020 15:31:26 +0000
Bug 1660847 - Add test for scrollable badge click functionality. r=gl Differential Revision: https://phabricator.services.mozilla.com/D88099
294b450328a4ed6f4c456daca6ac114e8071cfc2: Bug 1660266 - Encapsulate the code for finding overflow causing elements inside the Overflow Debugging pref. r=gl
manas <manas.khurana20@gmail.com> - Sun, 23 Aug 2020 23:05:13 +0000 - rev 545811
Push 37727 by csabou@mozilla.com at Mon, 24 Aug 2020 21:50:21 +0000
Bug 1660266 - Encapsulate the code for finding overflow causing elements inside the Overflow Debugging pref. r=gl Differential Revision: https://phabricator.services.mozilla.com/D87926
11f769ec943d291e5c80493cbe7f8ef62d909caf: Bug 1660266 - Encapsulate the code for finding overflow causing elements inside the Overflow Debugging pref. r=gl
manas <manas.khurana20@gmail.com> - Sat, 22 Aug 2020 16:57:04 +0000 - rev 545723
Push 37722 by ccoroiu@mozilla.com at Sun, 23 Aug 2020 09:31:12 +0000
Bug 1660266 - Encapsulate the code for finding overflow causing elements inside the Overflow Debugging pref. r=gl Differential Revision: https://phabricator.services.mozilla.com/D87926
0fc6c987a4ba54316df080c65bcc5c4102cc6479: Bug 1657680 - Make the scrollable badge clickable and add click handler. r=gl,jdescottes,bradwerth
manas <manas.khurana20@gmail.com> - Sat, 22 Aug 2020 09:12:12 +0000 - rev 545717
Push 37721 by apavel@mozilla.com at Sat, 22 Aug 2020 21:38:08 +0000
Bug 1657680 - Make the scrollable badge clickable and add click handler. r=gl,jdescottes,bradwerth Differential Revision: https://phabricator.services.mozilla.com/D86245
ed74d4e4b273ce346a2419727ab24a4d92bcc4a0: Bug 1657680 - Make the scrollable badge clickable and add click handler. r=gl,jdescottes,bradwerth
manas <manas.khurana20@gmail.com> - Fri, 21 Aug 2020 22:27:18 +0000 - rev 545701
Push 37719 by btara@mozilla.com at Sat, 22 Aug 2020 09:46:59 +0000
Bug 1657680 - Make the scrollable badge clickable and add click handler. r=gl,jdescottes,bradwerth Differential Revision: https://phabricator.services.mozilla.com/D86245
cfaf034743998a1112575d7c64f5c8c675d9c8ea: Bug 1651033 - Prevent default for pointerup/down events with DevTools node picker r=gl
Julian Descottes <jdescottes@mozilla.com> - Mon, 10 Aug 2020 14:37:50 +0000 - rev 544098
Push 37687 by apavel@mozilla.com at Mon, 10 Aug 2020 21:36:34 +0000
Bug 1651033 - Prevent default for pointerup/down events with DevTools node picker r=gl Differential Revision: https://phabricator.services.mozilla.com/D86502
a99f92bd4815cf51bb606b523a191b3bf194ccd1: Bug 1652445 - Rename WalkerActor _ref method and _refMap property r=gl
Julian Descottes <jdescottes@mozilla.com> - Fri, 07 Aug 2020 12:14:37 +0000 - rev 543772
Push 37681 by abutkovits@mozilla.com at Fri, 07 Aug 2020 21:36:18 +0000
Bug 1652445 - Rename WalkerActor _ref method and _refMap property r=gl _ref is renamed to _getOrCreateNodeActor to better reflect the purpose of the method. _refMap is renamed to _nodeActorsMap The test helper inspector-helpers was also directly querying _refMap. This has been replaced by a call to the public API getNode. Differential Revision: https://phabricator.services.mozilla.com/D84972
541f7b1168b3cdfe3ae6e63ad4c2bf90b9ea4748: Bug 1653290 - Add overflow badge and show an overflow badge for every scroll causing element dynamically and a test to check its working. r=gl,devtools-backward-compat-reviewers,jdescottes
manas <manas.khurana20@gmail.com> - Thu, 06 Aug 2020 16:14:23 +0000 - rev 543611
Push 37676 by cbrindusan@mozilla.com at Thu, 06 Aug 2020 21:54:39 +0000
Bug 1653290 - Add overflow badge and show an overflow badge for every scroll causing element dynamically and a test to check its working. r=gl,devtools-backward-compat-reviewers,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D84333
2d126d9f7ef82aab3326fe13de211511a2e9d190: Bug 1653290 - Add overflow badge and show an overflow badge for every scroll causing element dynamically and a test to check its working. r=gl,devtools-backward-compat-reviewers,jdescottes
manas <manas.khurana20@gmail.com> - Tue, 04 Aug 2020 17:17:26 +0000 - rev 543239
Push 37668 by btara@mozilla.com at Wed, 05 Aug 2020 03:14:17 +0000
Bug 1653290 - Add overflow badge and show an overflow badge for every scroll causing element dynamically and a test to check its working. r=gl,devtools-backward-compat-reviewers,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D84333
56a2eda09fda337f853ed017956ea08c1741fa9f: Bug 1620264 - Fix browser_rules_media-queries_reload.js intermittent. r=gl.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 27 Jul 2020 16:58:01 +0000 - rev 542222
Push 37645 by ccoroiu@mozilla.com at Tue, 28 Jul 2020 09:47:25 +0000
Bug 1620264 - Fix browser_rules_media-queries_reload.js intermittent. r=gl. Instead of relying on events being fired, we wait until the rule view displays the properties we expect. Differential Revision: https://phabricator.services.mozilla.com/D85005
5698ddfe5e51cc48683c9964051f2d1a457c9214: Bug 1649250 - Add experimental features that were introduced in Firefox Nightly 70 and higher. r=jbauman,kvark,jwatt,mayhemer,emilio,masayuki,baku,gl,preferences-reviewers,jdescottes,Pike
Jared Wein <jwein@mozilla.com> - Mon, 20 Jul 2020 10:05:58 +0000 - rev 541202
Push 37619 by apavel@mozilla.com at Mon, 20 Jul 2020 21:42:26 +0000
Bug 1649250 - Add experimental features that were introduced in Firefox Nightly 70 and higher. r=jbauman,kvark,jwatt,mayhemer,emilio,masayuki,baku,gl,preferences-reviewers,jdescottes,Pike Differential Revision: https://phabricator.services.mozilla.com/D81623
48fd0d4340232b8e176653226fd69b3ce8dc8fb3: Bug 1649250 - Add experimental features that were introduced in Firefox Nightly 70 and higher. r=jbauman,kvark,jwatt,mayhemer,emilio,masayuki,baku,gl,preferences-reviewers,jdescottes,Pike
Jared Wein <jwein@mozilla.com> - Sun, 19 Jul 2020 17:10:46 +0000 - rev 541152
Push 37616 by ncsoregi@mozilla.com at Mon, 20 Jul 2020 03:12:07 +0000
Bug 1649250 - Add experimental features that were introduced in Firefox Nightly 70 and higher. r=jbauman,kvark,jwatt,mayhemer,emilio,masayuki,baku,gl,preferences-reviewers,jdescottes,Pike Differential Revision: https://phabricator.services.mozilla.com/D81623
6d0c5d0f97e27f2e5816e38138867233c95905fa: Bug 1650107 - Update MDN base link in Computed panel. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 16 Jul 2020 14:26:06 +0000 - rev 540731
Push 37608 by apavel@mozilla.com at Thu, 16 Jul 2020 21:27:37 +0000
Bug 1650107 - Update MDN base link in Computed panel. r=gl Differential Revision: https://phabricator.services.mozilla.com/D83781
5436dd9da7efb7a66097160e221177dfb9259a6e: Bug 1576459 - Set browser_styleeditor_bug_740541_iframes.js as passing with fission. r=gl DONTBUILD
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 15 Jul 2020 14:18:57 +0000 - rev 540529
Push 37604 by btara@mozilla.com at Wed, 15 Jul 2020 21:52:05 +0000
Bug 1576459 - Set browser_styleeditor_bug_740541_iframes.js as passing with fission. r=gl DONTBUILD Permanent passes got tracked in bug 1652659. Differential Revision: https://phabricator.services.mozilla.com/D83622
517957ca7a3c2892a4ae3c7491fb538a5d84aa12: Bug 1585092 - Remove `Browser` component r=gl
Micah Tigley <mtigley@mozilla.com> - Fri, 10 Jul 2020 18:32:15 +0000 - rev 540054
Push 37589 by apavel@mozilla.com at Sat, 11 Jul 2020 21:52:53 +0000
Bug 1585092 - Remove `Browser` component r=gl Depends on D83153 Differential Revision: https://phabricator.services.mozilla.com/D83154
73a4e9de4e36a91d027bb32146e6bc3e1b407160: Bug 1585094 - Remove `ResizableViewport` component r=gl
Micah Tigley <mtigley@mozilla.com> - Sat, 11 Jul 2020 01:35:25 +0000 - rev 540053
Push 37589 by apavel@mozilla.com at Sat, 11 Jul 2020 21:52:53 +0000
Bug 1585094 - Remove `ResizableViewport` component r=gl Depends on D83152 Differential Revision: https://phabricator.services.mozilla.com/D83153
dbdaffce4b1a3530c06243ae6c84c2f08134c03c: Bug 1585095 - Remove the `Viewports` component r=gl
Micah Tigley <mtigley@mozilla.com> - Fri, 10 Jul 2020 19:15:38 +0000 - rev 540052
Push 37589 by apavel@mozilla.com at Sat, 11 Jul 2020 21:52:53 +0000
Bug 1585095 - Remove the `Viewports` component r=gl Differential Revision: https://phabricator.services.mozilla.com/D83152
031bfc234ca9cd5e2b2253d04c9a34873a22a631: Bug 1585097 - Delete the devtools.responsive.browserUI.enabled pref. r=gl
Micah Tigley <mtigley@mozilla.com> - Thu, 09 Jul 2020 21:09:52 +0000 - rev 539883
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1585097 - Delete the devtools.responsive.browserUI.enabled pref. r=gl Depends on D82563 Differential Revision: https://phabricator.services.mozilla.com/D82565
ae2b33d8434a4543e8df628005540e12ba120220: Bug 1585084 - Remove browser frame scripts that were used by old-RDM. r=gl
Micah Tigley <mtigley@mozilla.com> - Thu, 09 Jul 2020 20:20:49 +0000 - rev 539882
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1585084 - Remove browser frame scripts that were used by old-RDM. r=gl Depends on D82559 Differential Revision: https://phabricator.services.mozilla.com/D82563
51c34a326c0030681ad1162ef19507f7b3ab2470: Bug 1585096 - Cleanup code path separation in RDM's screenshot action. r=gl
Micah Tigley <mtigley@mozilla.com> - Thu, 09 Jul 2020 20:20:41 +0000 - rev 539881
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1585096 - Cleanup code path separation in RDM's screenshot action. r=gl Depends on D82558 Differential Revision: https://phabricator.services.mozilla.com/D82559
eaacbe5e997acb5c57fc9db13b6dd8faa5ff8fc0: Bug 1585096 - Cleanup code path separation in RDM's React components. r=gl
Micah Tigley <mtigley@mozilla.com> - Thu, 09 Jul 2020 20:20:39 +0000 - rev 539880
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1585096 - Cleanup code path separation in RDM's React components. r=gl Depends on D82557 Differential Revision: https://phabricator.services.mozilla.com/D82558
6f2a450ccf5107af00807b2cec9e6d0072dfecb8: Bug 1585096 - Cleanup code path separation caused by browserUI pref in index.js, manager.js, and ui.js r=gl
Micah Tigley <mtigley@mozilla.com> - Fri, 10 Jul 2020 13:28:15 +0000 - rev 539879
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1585096 - Cleanup code path separation caused by browserUI pref in index.js, manager.js, and ui.js r=gl Differential Revision: https://phabricator.services.mozilla.com/D82557
a01cc4b8027f76bf680aac5da73045255a6ceacc: Bug 1648616 - Remove code path separation for old-RDM test helpers. r=gl
Micah Tigley <mtigley@mozilla.com> - Thu, 09 Jul 2020 20:20:25 +0000 - rev 539676
Push 37585 by nbeleuzu@mozilla.com at Fri, 10 Jul 2020 09:48:19 +0000
Bug 1648616 - Remove code path separation for old-RDM test helpers. r=gl Depends on D82428 Differential Revision: https://phabricator.services.mozilla.com/D82429
e01241049b4faadd29fef7d21e8a475ec5f9923b: Bug 1648616 - Remove all references to "usingBrowsingUI" option in RDM tests. r=gl
Micah Tigley <mtigley@mozilla.com> - Thu, 09 Jul 2020 20:20:17 +0000 - rev 539675
Push 37585 by nbeleuzu@mozilla.com at Fri, 10 Jul 2020 09:48:19 +0000
Bug 1648616 - Remove all references to "usingBrowsingUI" option in RDM tests. r=gl Depends on D82427 Differential Revision: https://phabricator.services.mozilla.com/D82428
44c2ee34c7aff2cbbefb7fbdea4a9f67c86a905d: Bug 1648616 - Remove tests for old RDM. r=gl
Micah Tigley <mtigley@mozilla.com> - Thu, 09 Jul 2020 20:19:57 +0000 - rev 539674
Push 37585 by nbeleuzu@mozilla.com at Fri, 10 Jul 2020 09:48:19 +0000
Bug 1648616 - Remove tests for old RDM. r=gl Differential Revision: https://phabricator.services.mozilla.com/D82427
5af40441df5aeeaee26d866894f78555b22f1e82: Bug 1644789 - Wait for Rule view to update before interacting with Flexbox toggle r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Jun 2020 16:36:44 +0000 - rev 537441
Push 37542 by abutkovits@mozilla.com at Thu, 25 Jun 2020 21:45:10 +0000
Bug 1644789 - Wait for Rule view to update before interacting with Flexbox toggle r=gl By the looks of the [screenshot of the failing test](https://firefoxci.taskcluster-artifacts.net/QIl2Xbs1T5CfvCoUtWkK5w/0/public/test_info//mozilla-test-fail-screenshot_g8P5sS.png), the Rules view isn't updated to reflect the styles for the flex container. Looks like a race condition. This patch ensures that the test waits for the [Rules view to update](https://searchfox.org/mozilla-central/rev/a87a1c3b543475276e6d57a7a80cb02f3e42b6ed/devtools/client/inspector/rules/rules.js#980) before attempting to click on the swatch to toggle the Flexbox highlighter. Differential Revision: https://phabricator.services.mozilla.com/D81035
09c213cd421f2c9a4f58d6cef467dd782e3023f9: Bug 1647989 - Add default reducer to avoid error when creating a Redux store with no reducers. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Jun 2020 14:20:41 +0000 - rev 537403
Push 37542 by abutkovits@mozilla.com at Thu, 25 Jun 2020 21:45:10 +0000
Bug 1647989 - Add default reducer to avoid error when creating a Redux store with no reducers. r=gl We can't create a Redux store without reducers. Redux throws an error. It's benign and doesn't impact anything (panels load reducers on-demand before accessing them), but it's annoying to see the error in the console and in tests. Differential Revision: https://phabricator.services.mozilla.com/D81047
635d182e24be72c50b537e3d9842851627235c82: Bug 1242856 - Add accessibility semantics to the computed styles view, r=gl
Marco Zehe <mzehe@mozilla.com> - Tue, 16 Jun 2020 16:07:13 +0000 - rev 535926
Push 37513 by rmaries@mozilla.com at Wed, 17 Jun 2020 03:41:56 +0000
Bug 1242856 - Add accessibility semantics to the computed styles view, r=gl This patch does the following: 1. Adds a semantic document role to the computed styles pane. This causes screen readers to treat it as something they can use their reading commands on for better navigation and efficiency. 2. Gives the expansion twisties a button role and a label. I am reusing the labels introduced in an earlier patch. 3. Turns the name portion of each property into a heading so screen reader users can quickly skip between them, regardless of their expanded status or not. 4. Explicitly displays the status for each rule match with visually hidden text because screen readers do not pick up text from titles on simple span elements. 5. Adjusts the visually-hidden class to be more modern and less intrusive. Differential Revision: https://phabricator.services.mozilla.com/D79673
46fd3bf97861398cae49d56e4c9542538b0ebe33: Bug 1645448 - Remove handling code for FlexItemHighlighter which is not implemented. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 15 Jun 2020 15:37:43 +0000 - rev 535693
Push 37508 by btara@mozilla.com at Mon, 15 Jun 2020 21:48:38 +0000
Bug 1645448 - Remove handling code for FlexItemHighlighter which is not implemented. r=gl While cleaning up and restructuring client-side code to manage highlighters, I discovered that FlexItemHighlighter is not implemented / landed ([Bug 1477614](https://bugzilla.mozilla.org/show_bug.cgi?id=1477614)). To ease clean-up and review of incoming changes, I am removing this orphaned code. It will be available with this revision if we need to revert it later. Differential Revision: https://phabricator.services.mozilla.com/D79517
88d5337be8e0687053897bc0d9e28e3eb5a8a94a: Bug 1242856 - Add accessibility semantics to the computed styles view, r=gl
Marco Zehe <mzehe@mozilla.com> - Mon, 15 Jun 2020 14:18:22 +0000 - rev 535683
Push 37508 by btara@mozilla.com at Mon, 15 Jun 2020 21:48:38 +0000
Bug 1242856 - Add accessibility semantics to the computed styles view, r=gl This patch does the following: 1. Adds a semantic document role to the computed styles pane. This causes screen readers to treat it as something they can use their reading commands on for better navigation and efficiency. 2. Gives the expansion twisties a button role and a label. I am reusing the labels introduced in an earlier patch. 3. Turns the name portion of each property into a heading so screen reader users can quickly skip between them, regardless of their expanded status or not. 4. Explicitly displays the status for each rule match with visually hidden text because screen readers do not pick up text from titles on simple span elements. Differential Revision: https://phabricator.services.mozilla.com/D79673
52126fd9ffdf8322286962810e68257e28b1df93: Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 14 Jun 2020 23:26:04 +0000 - rev 535624
Push 37506 by abutkovits@mozilla.com at Mon, 15 Jun 2020 09:26:24 +0000
Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo It was removed from the spec. Differential Revision: https://phabricator.services.mozilla.com/D78834
bca9f7459a161e1bb7b9b4482694513ff76fde62: Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Jun 2020 13:21:54 +0000 - rev 534668
Push 37493 by nerli@mozilla.com at Wed, 10 Jun 2020 04:36:07 +0000
Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo It was removed from the spec. Bug 1643934 updates the WPT tests. Differential Revision: https://phabricator.services.mozilla.com/D78834
aedc6555b50c435001891630aac021f3b6c7eedc: Bug 1602075 - display enabled Inspect Accessibility Properties menu item in inspector if devtools.accessibility.auto-init.enabled pref is set to true. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 06 May 2020 15:55:06 +0000 - rev 528463
Push 37387 by csabou@mozilla.com at Wed, 06 May 2020 21:51:14 +0000
Bug 1602075 - display enabled Inspect Accessibility Properties menu item in inspector if devtools.accessibility.auto-init.enabled pref is set to true. r=gl Differential Revision: https://phabricator.services.mozilla.com/D71587
5837c46b718c2e64e2aee00d8118091f64ae74e7: Bug 1635632 - ensure that the nodeFront exists before trying to inspect it or its accessibility properties. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 06 May 2020 02:19:22 +0000 - rev 528422
Push 37384 by nbeleuzu@mozilla.com at Wed, 06 May 2020 16:28:18 +0000
Bug 1635632 - ensure that the nodeFront exists before trying to inspect it or its accessibility properties. r=gl Differential Revision: https://phabricator.services.mozilla.com/D73987
2b11feb2473d9e50bc8549b22e7cce9c3647bcf3: Bug 1602075 - display enabled Inspect Accessibility Properties menu item in inspector if devtools.accessibility.auto-init.enabled pref is set to true. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Mon, 27 Apr 2020 14:16:03 +0000 - rev 526240
Push 37353 by shindli@mozilla.com at Mon, 27 Apr 2020 21:46:18 +0000
Bug 1602075 - display enabled Inspect Accessibility Properties menu item in inspector if devtools.accessibility.auto-init.enabled pref is set to true. r=gl Differential Revision: https://phabricator.services.mozilla.com/D71587
cf06e30be06862b9855a0fdb043856cf24d989ca: Bug 1602075 - display Inspect Accessibility Properties menu item in inspector if devtools.accessibility.auto-init.enabled pref is set to true. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Thu, 23 Apr 2020 14:40:25 +0000 - rev 525629
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1602075 - display Inspect Accessibility Properties menu item in inspector if devtools.accessibility.auto-init.enabled pref is set to true. r=gl Differential Revision: https://phabricator.services.mozilla.com/D71587