searching for reviewer(gerald)
06a1e5c71b52ca1bfaeae77de5e2a036610f44f7: Bug 1734262 - Stop registering the async process monitor thread with the profiler. r=gerald
Bobby Holley <bobbyholley@gmail.com> - Sat, 16 Oct 2021 16:29:31 +0000 - rev 596103
Push 38884 by mlaza@mozilla.com at Sat, 16 Oct 2021 21:43:37 +0000
Bug 1734262 - Stop registering the async process monitor thread with the profiler. r=gerald This thread waits on a syscall for the completion of an asynchronously-spawned process. Since there's no general guarantee that Gecko will outlive the proccesses it spawns, this thread can continue running all the way up until the process terminates. And while we generally endeavor to have teardown logic join any spawned threads, we don't have an easy way to interrupt the platform-specific routines that the thread might be waiting on. That leaves us with instrumenting the profiler code to handle APIs arbitrarily late during shutdown (i.e. after static destructors have run), or simply not registering the thread with the profiler. The latter is much simpler, and doesn't cost us much because these threads never do any interesting computation, and thus aren't likely to be relevant to the profiler. This registration was added in bug 1323100, which was just a grep-driven activity which didn't identify any particular need for profiling this thread. Differential Revision: https://phabricator.services.mozilla.com/D128532
87d6b8574dd8459f40d5833d62e8ed4ae25a0436: Bug 1732161 - Add the CC reason to CC profile markers r=gerald
Steve Fink <sfink@mozilla.com> - Thu, 14 Oct 2021 18:15:40 +0000 - rev 595936
Push 38880 by nerli@mozilla.com at Fri, 15 Oct 2021 09:50:04 +0000
Bug 1732161 - Add the CC reason to CC profile markers r=gerald Differential Revision: https://phabricator.services.mozilla.com/D127014
3bb43ee4a954fa5982cc7ff232e80c8c51e0b654: Bug 1732161 - Add profiler marker for core part of CC r=smaug,gerald
Steve Fink <sfink@mozilla.com> - Thu, 14 Oct 2021 18:15:38 +0000 - rev 595931
Push 38880 by nerli@mozilla.com at Fri, 15 Oct 2021 09:50:04 +0000
Bug 1732161 - Add profiler marker for core part of CC r=smaug,gerald Differential Revision: https://phabricator.services.mozilla.com/D126394
766a1bc74001333c2d0414cdc2a33925149e5a4c: Bug 1732161 - Add the CC reason to CC profile markers r=gerald
Steve Fink <sfink@mozilla.com> - Wed, 13 Oct 2021 22:32:59 +0000 - rev 595736
Push 38876 by ctuns@mozilla.com at Thu, 14 Oct 2021 09:34:15 +0000
Bug 1732161 - Add the CC reason to CC profile markers r=gerald Differential Revision: https://phabricator.services.mozilla.com/D127014
67d81f8f413e193d6985268fbd1024f53f94c005: Bug 1732161 - Add profiler marker for core part of CC r=smaug,gerald
Steve Fink <sfink@mozilla.com> - Wed, 13 Oct 2021 22:32:57 +0000 - rev 595731
Push 38876 by ctuns@mozilla.com at Thu, 14 Oct 2021 09:34:15 +0000
Bug 1732161 - Add profiler marker for core part of CC r=smaug,gerald Differential Revision: https://phabricator.services.mozilla.com/D126394
7271b938e71ac4ebaad30ef86548a2af8a65c0c5: Bug 1732161 - Add the CC reason to CC profile markers r=gerald
Steve Fink <sfink@mozilla.com> - Mon, 11 Oct 2021 21:39:08 +0000 - rev 595414
Push 38870 by ccozmuta@mozilla.com at Tue, 12 Oct 2021 09:32:00 +0000
Bug 1732161 - Add the CC reason to CC profile markers r=gerald Differential Revision: https://phabricator.services.mozilla.com/D127014
50d17b17218500792e905c6b0936f6037f060982: Bug 1732161 - Add profiler marker for core part of CC r=smaug,gerald
Steve Fink <sfink@mozilla.com> - Mon, 11 Oct 2021 21:39:06 +0000 - rev 595409
Push 38870 by ccozmuta@mozilla.com at Tue, 12 Oct 2021 09:32:00 +0000
Bug 1732161 - Add profiler marker for core part of CC r=smaug,gerald Differential Revision: https://phabricator.services.mozilla.com/D126394
93abc883209f24d11b2864ae09129b9abc17d0a2: Bug 1733335 - Add tracing marker type for the Rust side r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Mon, 11 Oct 2021 07:59:09 +0000 - rev 595300
Push 38867 by ctuns@mozilla.com at Mon, 11 Oct 2021 15:27:35 +0000
Bug 1733335 - Add tracing marker type for the Rust side r=gerald Differential Revision: https://phabricator.services.mozilla.com/D127112
c44e1bb6d9ffb00d8e8ac2a3cd4eb65971535698: Bug 1733335 - Add tracing marker type for the Rust side r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 06 Oct 2021 11:35:15 +0000 - rev 594884
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1733335 - Add tracing marker type for the Rust side r=gerald Differential Revision: https://phabricator.services.mozilla.com/D127112
c84fdec90b9f3536d381b6cee32e1b05bc16f3a3: Bug 1728539 - Add a documentation about profiler Rust API r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 06 Oct 2021 07:58:49 +0000 - rev 594809
Push 38853 by smolnar@mozilla.com at Wed, 06 Oct 2021 15:52:17 +0000
Bug 1728539 - Add a documentation about profiler Rust API r=gerald Differential Revision: https://phabricator.services.mozilla.com/D127430
cf3b6b6cc6c612be19db8231fcfee821982300b5: Bug 1733335 - Add tracing marker type for the Rust side r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 05 Oct 2021 11:34:27 +0000 - rev 594590
Push 38850 by imoraru@mozilla.com at Tue, 05 Oct 2021 21:54:18 +0000
Bug 1733335 - Add tracing marker type for the Rust side r=gerald Differential Revision: https://phabricator.services.mozilla.com/D127112
88dbe1a7478c82c0c93830cedb88d134c3392382: Bug 1732161 - Add the CC reason to CC profile markers r=gerald
Steve Fink <sfink@mozilla.com> - Mon, 04 Oct 2021 23:06:08 +0000 - rev 594529
Push 38847 by ctuns@mozilla.com at Tue, 05 Oct 2021 03:52:32 +0000
Bug 1732161 - Add the CC reason to CC profile markers r=gerald Differential Revision: https://phabricator.services.mozilla.com/D127014
b3e894d590d913dd524f7174732689aa7e4b214d: Bug 1732161 - Add profiler marker for core part of CC r=smaug,gerald
Steve Fink <sfink@mozilla.com> - Mon, 04 Oct 2021 23:06:06 +0000 - rev 594524
Push 38847 by ctuns@mozilla.com at Tue, 05 Oct 2021 03:52:32 +0000
Bug 1732161 - Add profiler marker for core part of CC r=smaug,gerald Differential Revision: https://phabricator.services.mozilla.com/D126394
bf67b9659820b0cc65419a478931835cb44f1336: Bug 1732208 - Silence the unused-but-set-variable warning in platform-linux-android.cpp. r=gerald
Mike Hommey <mh+mozilla@glandium.org> - Tue, 28 Sep 2021 00:02:47 +0000 - rev 593375
Push 38827 by ctuns@mozilla.com at Tue, 28 Sep 2021 09:54:33 +0000
Bug 1732208 - Silence the unused-but-set-variable warning in platform-linux-android.cpp. r=gerald platform-linux-android.cpp:199:9: error: variable 'r' set but not used [-Werror,-Wunused-but-set-variable] int r = sem_init(&mMessage2, /* pshared */ 0, 0); ^ platform-linux-android.cpp:206:9: error: variable 'r' set but not used [-Werror,-Wunused-but-set-variable] not used [-Werror,-Wunused-but-set-variable] int r = sem_destroy(&mMessage2); ^ Differential Revision: https://phabricator.services.mozilla.com/D126459
ee1acae97e9af039c212e030a1abed2e2fa4add0: Bug 1710408 - Do not record JSContext info if the js feature is disabled r=gerald
Steve Fink <sfink@mozilla.com> - Mon, 27 Sep 2021 16:40:56 +0000 - rev 593307
Push 38827 by ctuns@mozilla.com at Tue, 28 Sep 2021 09:54:33 +0000
Bug 1710408 - Do not record JSContext info if the js feature is disabled r=gerald Differential Revision: https://phabricator.services.mozilla.com/D126392
8d2ac26f5f6f717b29ec57a772d4b57c3eb8b52f: Bug 1654413 - Deserialize and stream the markers and marker schemas r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 21 Sep 2021 11:08:12 +0000 - rev 592620
Push 38811 by nbeleuzu@mozilla.com at Wed, 22 Sep 2021 04:09:13 +0000
Bug 1654413 - Deserialize and stream the markers and marker schemas r=emilio,gerald Now we can deserialize and stream everything to the JSON. Differential Revision: https://phabricator.services.mozilla.com/D124027
5ac58c00d75b30683c69e551dc56cb96bc8fe64f: Bug 1654413 - Add add_marker Rust profiler API and serialize the marker to the buffer r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 21 Sep 2021 11:08:11 +0000 - rev 592619
Push 38811 by nbeleuzu@mozilla.com at Wed, 22 Sep 2021 04:09:13 +0000
Bug 1654413 - Add add_marker Rust profiler API and serialize the marker to the buffer r=emilio,gerald This only adds the API and then adds the profiler payload to the buffer. The deserialization and streaming will happen in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D124026
65e0c7376519dc01d400a9d1b972ca581169fbd4: Bug 1654413 - Add MarkerSchema struct and its enums for marker API r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 21 Sep 2021 11:08:11 +0000 - rev 592618
Push 38811 by nbeleuzu@mozilla.com at Wed, 22 Sep 2021 04:09:13 +0000
Bug 1654413 - Add MarkerSchema struct and its enums for marker API r=emilio,gerald You can see the `mozilla::MarkerSchema` for the C++ counterpart. This Rust struct simply wraps the C++ object and keeps the reference of it as RAII. This heap allocates the inner C++ object but it's fine to do it here, because it's we only create a MarkerSchema object at the end of a profiling session and it happens once per marker type. It should be very rare. Differential Revision: https://phabricator.services.mozilla.com/D124025
680cd33b16422537fd6c0da7fb12ae53d06462f3: Bug 1654413 - Add JSONWriter struct for marker schema r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 21 Sep 2021 11:08:11 +0000 - rev 592617
Push 38811 by nbeleuzu@mozilla.com at Wed, 22 Sep 2021 04:09:13 +0000
Bug 1654413 - Add JSONWriter struct for marker schema r=emilio,gerald JSON writer will be used for the third and last marker API. This is needed because we need to describe a marker payload struct on how to serialize it. Differential Revision: https://phabricator.services.mozilla.com/D124024
fde7a635924e9a7e95d6c3f38daf8a4fb4452549: Bug 1654413 - Add add_text_marker Rust API r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 21 Sep 2021 11:08:10 +0000 - rev 592616
Push 38811 by nbeleuzu@mozilla.com at Wed, 22 Sep 2021 04:09:13 +0000
Bug 1654413 - Add add_text_marker Rust API r=emilio,gerald This is the second API for the markers. This allows one payload as a text for more information. See the PROFILER_MARKER_TEXT macro for the C++ counterpart. Differential Revision: https://phabricator.services.mozilla.com/D124023
c82aee76d44d6b748d9f5cf1dcc062bd94dd9d81: Bug 1654413 - Add add_untyped_marker Rust API r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 21 Sep 2021 11:08:10 +0000 - rev 592615
Push 38811 by nbeleuzu@mozilla.com at Wed, 22 Sep 2021 04:09:13 +0000
Bug 1654413 - Add add_untyped_marker Rust API r=emilio,gerald This is the first and simplest API for the markers. There will be two more APIs in the following patches (add_text_marker and add_marker). You can see the PROFILER_MARKER_UNTYPED macro for the C++ counterpart. Differential Revision: https://phabricator.services.mozilla.com/D124022
89debdc6aaaca1740b354ff00480e0254e726216: Bug 1654413 - Add a MarkerStack Rust enum for the marker API r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 21 Sep 2021 11:08:09 +0000 - rev 592614
Push 38811 by nbeleuzu@mozilla.com at Wed, 22 Sep 2021 04:09:13 +0000
Bug 1654413 - Add a MarkerStack Rust enum for the marker API r=emilio,gerald MarkerStack object is a bit more complex in the C++ side. But we don't need a complex object like that in here. A simple enum is enough to determine what type of marker stack we are capturing. C++ side will be handling the capturing of the stack. Differential Revision: https://phabricator.services.mozilla.com/D124021
36660c3995841d19276ffe49d6191e41b5c2c2da: Bug 1654413 - Add a MarkerTiming and MarkerOptions Rust structs for the marker API r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 21 Sep 2021 11:08:09 +0000 - rev 592613
Push 38811 by nbeleuzu@mozilla.com at Wed, 22 Sep 2021 04:09:13 +0000
Bug 1654413 - Add a MarkerTiming and MarkerOptions Rust structs for the marker API r=emilio,gerald These structs are needed for the marker APIs. We also have the same structs as the C++ classes. See `mozilla::MarkerTiming` and `mozilla::MarkerOptions`. Differential Revision: https://phabricator.services.mozilla.com/D124020
57fe3b6c0acfeb70fa492ef5e2b58ea85648ee9e: Bug 1654413 - Add ProfilerTime Rust struct for marker API r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 21 Sep 2021 11:08:08 +0000 - rev 592611
Push 38811 by nbeleuzu@mozilla.com at Wed, 22 Sep 2021 04:09:13 +0000
Bug 1654413 - Add ProfilerTime Rust struct for marker API r=emilio,gerald This will be used to get the time from profiler, so marker API can use it to understand the start or end time. Differential Revision: https://phabricator.services.mozilla.com/D124018
2f5b51cb3ec28aae46135483ac4d3f42ce599c92: Bug 1730030 - Replace some assembly with corresponding compiler builtins. r=gerald
Mike Hommey <mh+mozilla@glandium.org> - Fri, 10 Sep 2021 00:58:34 +0000 - rev 591574
Push 38777 by malexandru@mozilla.com at Fri, 10 Sep 2021 15:46:05 +0000
Bug 1730030 - Replace some assembly with corresponding compiler builtins. r=gerald This has the side-effect of adding the missing arm64 mac support for PHC. Differential Revision: https://phabricator.services.mozilla.com/D125139
61b3c7a14c5c8f2316fe9c0c313389e1f6beb14f: Bug 1728544 - Make the MarkerSchema::Searchable enum class values CamelCased r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 03 Sep 2021 14:30:10 +0000 - rev 590931
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1728544 - Make the MarkerSchema::Searchable enum class values CamelCased r=gerald Differential Revision: https://phabricator.services.mozilla.com/D124242
6b32d72ae3bdad279a077a706623985ce1ea56ff: Bug 1728544 - Make the MarkerSchema::Format enum class values CamelCased r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 03 Sep 2021 14:30:10 +0000 - rev 590930
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1728544 - Make the MarkerSchema::Format enum class values CamelCased r=gerald Differential Revision: https://phabricator.services.mozilla.com/D124241
d53d9b2f55929d32a985933a94e00446e2326a47: Bug 1728544 - Make the MarkerSchema::Location enum class values CamelCased r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 03 Sep 2021 14:30:09 +0000 - rev 590929
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1728544 - Make the MarkerSchema::Location enum class values CamelCased r=gerald Differential Revision: https://phabricator.services.mozilla.com/D124240
104128c85174789d4453a84f0a1db95a28472631: Bug 1728504 - Fix typo in tools/profiler/docs/index.rst. r=gerald DONTBUILD
Benjamin Peterson <benjamin@python.org> - Thu, 02 Sep 2021 05:04:13 +0000 - rev 590551
Push 38756 by ctuns@mozilla.com at Thu, 02 Sep 2021 09:24:50 +0000
Bug 1728504 - Fix typo in tools/profiler/docs/index.rst. r=gerald DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D124157
c2af1233193bb34d03e3b61c20a54d50e2c83dda: Bug 1728228 - Add profiler markers in the Timer thread to understand its activity, r=gerald,smaug,KrisWright.
Florian Quèze <florian@queze.net> - Tue, 31 Aug 2021 13:41:46 +0000 - rev 590311
Push 38751 by ccozmuta@mozilla.com at Tue, 31 Aug 2021 21:39:57 +0000
Bug 1728228 - Add profiler markers in the Timer thread to understand its activity, r=gerald,smaug,KrisWright. Differential Revision: https://phabricator.services.mozilla.com/D123989
f544eddd5fec51dbe41eb2229fd1645b429007e7: Bug 1604914 - Make ShouldProfileThread more efficient r=gerald
Christopher Winter <cwinter158@gmail.com> - Thu, 26 Aug 2021 01:31:25 +0000 - rev 589961
Push 38738 by ncsoregi@mozilla.com at Thu, 26 Aug 2021 16:22:11 +0000
Bug 1604914 - Make ShouldProfileThread more efficient r=gerald When starting the profiler, also make a copy of the filter strings converted to lower-case. This allows caseless comparisons to be made against thread names without repeatedly converting the filters to lower-case for each thread. Differential Revision: https://phabricator.services.mozilla.com/D123302
03ed0c120db46a84c7435ae89b4549b668ac7a7f: Bug 1727039 - Add two marker schema structs for Java markers to make them visible in the timeline r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 24 Aug 2021 13:24:06 +0000 - rev 589755
Push 38732 by smolnar@mozilla.com at Tue, 24 Aug 2021 21:59:48 +0000
Bug 1727039 - Add two marker schema structs for Java markers to make them visible in the timeline r=gerald Differential Revision: https://phabricator.services.mozilla.com/D123435
8e4d2f5bcea105d719b64f67f2a718f162aaa781: Bug 1697901 - [network markers] Bump the profile version to 24 r=gerald
Julien Wajsberg <felash@gmail.com> - Mon, 23 Aug 2021 08:56:53 +0000 - rev 589538
Push 38727 by apavel@mozilla.com at Mon, 23 Aug 2021 15:55:22 +0000
Bug 1697901 - [network markers] Bump the profile version to 24 r=gerald This ensures our users will use the latest version of the frontend when capturing 'cancel' network markers. Depends on D123254 Differential Revision: https://phabricator.services.mozilla.com/D123255
fddd1f768e106f66525f002c211df992da982caf: Bug 1697901 - [network markers] Support channel cancelation r=valentin,gerald,necko-reviewers
Julien Wajsberg <felash@gmail.com> - Mon, 23 Aug 2021 08:56:52 +0000 - rev 589536
Push 38727 by apavel@mozilla.com at Mon, 23 Aug 2021 15:55:22 +0000
Bug 1697901 - [network markers] Support channel cancelation r=valentin,gerald,necko-reviewers This patch supports channel cancelations with network markers. Because of all the possible ways to stop a channel and hence all possible end markers, it also introduces a new boolean to reduce the complexity. Indeed it happens that 2 "end functions" are called, but we need to insert only 1 end marker to have a well-formed result in the Profiler frontend. Differential Revision: https://phabricator.services.mozilla.com/D122111
e6a3830a56afa0cb7c901a82f89d7438dd6345ec: Bug 1724770 - Fix a format string for AppendPrintf in SharedLibraryInfo::GetInfoForSelf()". r=gerald
Toshihito Kikuchi <tkikuchi@mozilla.com> - Sat, 14 Aug 2021 06:27:38 +0000 - rev 588876
Push 38707 by imoraru@mozilla.com at Sat, 14 Aug 2021 21:11:32 +0000
Bug 1724770 - Fix a format string for AppendPrintf in SharedLibraryInfo::GetInfoForSelf()". r=gerald We passed 64-bit integer arguments, but `AppendPrintf` took them as 32-bit parameters. This generated a wrong version string in 32bit build. Differential Revision: https://phabricator.services.mozilla.com/D122623
306a7f49a334cff996f874ff56c318a71facc22b: Bug 1642516 - In the Lul stack walker, don't subtract 1 byte from the return address, for consistency with other stackwalkers. r=gerald
Markus Stange <mstange.moz@gmail.com> - Sat, 07 Aug 2021 00:34:41 +0000 - rev 588129
Push 38683 by dluca@mozilla.com at Sat, 07 Aug 2021 21:48:22 +0000
Bug 1642516 - In the Lul stack walker, don't subtract 1 byte from the return address, for consistency with other stackwalkers. r=gerald This makes all our stackwalkers in Firefox consistent with respect to return addresses: For non-leaf frames in stacks, the code address now always points to the instruction *after* the call instruction, i.e. to the instruction that will be executed once the function returns. For symbolication purposes, 1 byte will need to be subtracted in order to obtain correct line number + inline stack information for the call instruction. This subtraction will be the responsibility of the Firefox profiler front-end, not of the stackwalkers. Depends on D121930 Differential Revision: https://phabricator.services.mozilla.com/D121931
a33b980dc978173cca9f3e1fa34a003d15ee1160: Bug 1724187 - Change the category of the ChromeUtils.addProfilerMarker label frame to PROFILER so that this code is ignored in stacks captured for profiler markers, r=gerald.
Florian Quèze <florian@queze.net> - Fri, 06 Aug 2021 20:24:42 +0000 - rev 588115
Push 38682 by smolnar@mozilla.com at Sat, 07 Aug 2021 09:26:14 +0000
Bug 1724187 - Change the category of the ChromeUtils.addProfilerMarker label frame to PROFILER so that this code is ignored in stacks captured for profiler markers, r=gerald. Differential Revision: https://phabricator.services.mozilla.com/D121859
168c68c7f7e351970e3820a725feafb26d13d072: Bug 1723868 - Skip msvp9dec_store.dll in GetInfoForSelf(). r=gerald
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 05 Aug 2021 02:36:27 +0000 - rev 587848
Push 38675 by csabou@mozilla.com at Thu, 05 Aug 2021 09:27:24 +0000
Bug 1723868 - Skip msvp9dec_store.dll in GetInfoForSelf(). r=gerald When mfplat.dll loads msvp9dec_store.dll, it posts a task to unload the module to the work queue even if msvp9dec_store.dll is already loaded and mfplat.dll skips LoadLibrary. Therefore, we cannot safely lock msvp9dec_store.dll by loading it as data. The proposed fix is to skip processing the module. Differential Revision: https://phabricator.services.mozilla.com/D121777
fb900d90b4c90670b90e0b274c9d65507e201f0f: Bug 1723813 - Add a profiler marker in nsSocketTransportService::Poll to help understand excessive CPU use on the Socket Thread, r=mstange,necko-reviewers,valentin,gerald.
Florian Quèze <florian@queze.net> - Wed, 04 Aug 2021 12:16:26 +0000 - rev 587757
Push 38673 by nbeleuzu@mozilla.com at Wed, 04 Aug 2021 21:45:54 +0000
Bug 1723813 - Add a profiler marker in nsSocketTransportService::Poll to help understand excessive CPU use on the Socket Thread, r=mstange,necko-reviewers,valentin,gerald. Differential Revision: https://phabricator.services.mozilla.com/D121656
20eee591076806d07e765d73ec37e0cafe808a92: Bug 1723537 - Mention the MOZ_GECKO_PROFILER for macros/function that are no-op when it's not defined r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 04 Aug 2021 09:37:32 +0000 - rev 587748
Push 38672 by cbrindusan@mozilla.com at Wed, 04 Aug 2021 15:37:19 +0000
Bug 1723537 - Mention the MOZ_GECKO_PROFILER for macros/function that are no-op when it's not defined r=gerald Depends on D121535 Differential Revision: https://phabricator.services.mozilla.com/D121623
1dfa66d34102536d61928671f5dd92f1649cfe84: Bug 1723537 - Add can_accept_markers profiler API for Rust r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 04 Aug 2021 09:37:32 +0000 - rev 587747
Push 38672 by cbrindusan@mozilla.com at Wed, 04 Aug 2021 15:37:19 +0000
Bug 1723537 - Add can_accept_markers profiler API for Rust r=emilio,gerald This is a prerequisite for adding a marker API. There is the same API for C++ as `profiler_can_accept_markers`. This API can both be used as an external API before adding an expensive payload to the profile marker, and it can be used as an internal function to check it inside the new `add_marker` API that will be introduced soon. Differential Revision: https://phabricator.services.mozilla.com/D121535
62f4c0ffa4944094128a3f1e02adf18ad2c8df12: Bug 1723400 - Fix the build when the self-hosted JS code is being generated before ProfilingCategoryList.h r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Mon, 02 Aug 2021 10:00:07 +0000 - rev 587458
Push 38666 by dluca@mozilla.com at Mon, 02 Aug 2021 21:43:56 +0000
Bug 1723400 - Fix the build when the self-hosted JS code is being generated before ProfilingCategoryList.h r=gerald ProfilingCategoryList.h file was a static file before, but after the bug 1652560, we started to generate it. But now, because the self-hosted JS code generation depends on this file, it's creating a build error when it's being built sequentially with "-j1" flag. To fix this, we had to include the ProfilingCategoryList.h file as the input to the self-hosted JS code generation. That way, it's always going to generate the profiler header first, and then generate the JS files. Differential Revision: https://phabricator.services.mozilla.com/D121507
74250675f2f650c4271fcf08f1c094f40e868325: Bug 1652560 - Add gecko_profiler_label API for adding label frames from Rust code r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 30 Jul 2021 21:49:22 +0000 - rev 587291
Push 38660 by nerli@mozilla.com at Sat, 31 Jul 2021 09:47:32 +0000
Bug 1652560 - Add gecko_profiler_label API for adding label frames from Rust code r=emilio,gerald Differential Revision: https://phabricator.services.mozilla.com/D120793
771f07bccfc35468516dfa391d5913f554889bd8: Bug 1652560 - Autogenerate profiling_categories.rs with profiling_categories.yaml r=gerald,emilio
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 30 Jul 2021 21:49:21 +0000 - rev 587290
Push 38660 by nerli@mozilla.com at Sat, 31 Jul 2021 09:47:32 +0000
Bug 1652560 - Autogenerate profiling_categories.rs with profiling_categories.yaml r=gerald,emilio Generate the user friendly Rust enums and their impls for profiling categories. Differential Revision: https://phabricator.services.mozilla.com/D120792
1b2cf2dc3696cd1f07d3b6f16a4195f683f58723: Bug 1652560 - Autogenerate ProfilingCategoryList.h with profiling_categories.yaml r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 30 Jul 2021 21:49:21 +0000 - rev 587289
Push 38660 by nerli@mozilla.com at Sat, 31 Jul 2021 09:47:32 +0000
Bug 1652560 - Autogenerate ProfilingCategoryList.h with profiling_categories.yaml r=emilio,gerald Previously ProfilingCategoryList.h was a central place for profiling categories. But with this patch, profiling_categories.yaml becomes the canonical place for it and the macro header file is being generated automatically. This is needed to make the profiling categories in sync with Rust and C++. Differential Revision: https://phabricator.services.mozilla.com/D120791
02f1242c8d1c7ad9f8dca6d79836abf16f9080b6: Bug 1652560 - Add gecko_profiler::is_active API for Rust r=emilio,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 30 Jul 2021 21:49:20 +0000 - rev 587288
Push 38660 by nerli@mozilla.com at Sat, 31 Jul 2021 09:47:32 +0000
Bug 1652560 - Add gecko_profiler::is_active API for Rust r=emilio,gerald This is both an API on its own and a prerequisite for profiling label frame API. Differential Revision: https://phabricator.services.mozilla.com/D120790
2a8dcc6ebf6842384e158c9fce6d0fedd48882ca: Bug 1720853 - Move profiler_add_*_marker functions out of the public GeckoProfiler.h header, r=gerald.
Florian Quèze <florian@queze.net> - Fri, 16 Jul 2021 15:26:23 +0000 - rev 585700
Push 38618 by apavel@mozilla.com at Fri, 16 Jul 2021 21:43:02 +0000
Bug 1720853 - Move profiler_add_*_marker functions out of the public GeckoProfiler.h header, r=gerald. Differential Revision: https://phabricator.services.mozilla.com/D120066
6a36634f4998a7af01804935f3b61f4f319f6c9b: Bug 1720851 - fix includes in NetworkMarker.cpp, r=gerald,necko-reviewers,kershaw.
Florian Quèze <florian@queze.net> - Fri, 16 Jul 2021 15:26:23 +0000 - rev 585699
Push 38618 by apavel@mozilla.com at Fri, 16 Jul 2021 21:43:02 +0000
Bug 1720851 - fix includes in NetworkMarker.cpp, r=gerald,necko-reviewers,kershaw. Differential Revision: https://phabricator.services.mozilla.com/D120062
e18afeafabdb3e630c41fa6af55833d308dbfd15: Bug 1720374 - Remove MOZ_GECKO_PROFILER ifdefs that are not useful, r=gerald.
Florian Quèze <florian@queze.net> - Thu, 15 Jul 2021 22:04:23 +0000 - rev 585633
Push 38616 by smolnar@mozilla.com at Fri, 16 Jul 2021 03:37:24 +0000
Bug 1720374 - Remove MOZ_GECKO_PROFILER ifdefs that are not useful, r=gerald. Differential Revision: https://phabricator.services.mozilla.com/D119810
45fd93491b9f0a18eae32e16c6b9e93264e8134f: Bug 1720368 - Remove MOZ_GECKO_PROFILER ifdefs around profiler_init and profiler_shutdown calls, r=gerald.
Florian Quèze <florian@queze.net> - Thu, 15 Jul 2021 22:04:23 +0000 - rev 585632
Push 38616 by smolnar@mozilla.com at Fri, 16 Jul 2021 03:37:24 +0000
Bug 1720368 - Remove MOZ_GECKO_PROFILER ifdefs around profiler_init and profiler_shutdown calls, r=gerald. Differential Revision: https://phabricator.services.mozilla.com/D119809