searching for reviewer(froydnj)
9bcfda8f31f0: Bug 1530874 - Version the mozglue symbols on Android. r=froydnj
Geoff Brown <gbrown@mozilla.com> - Thu, 18 Apr 2019 21:39:10 +0000 - rev 470149
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1530874 - Version the mozglue symbols on Android. r=froydnj See comment 24 in the bug for details on what can go wrong without this change. This change ensures system libraries are not going to pick symbols from mozglue when running processes outside dalvik. As a side effect, this makes things kind of closer to what happens when dalvik is involved, exposing unit tests to possible allocator mismatches that could happen like bug 1531887. On the flip side, libraries that link against mozglue explicitly are going to get a reference to the versioned symbols, so everything is fine in that regard. The custom linker, however, will ignore the versions altogether, and its symbols resolution just ends up unchanged. So we're fine there too. We use something that is close to what using a SYMBOLS_FILE would generate as a version script, but we need to do so manually because SYMBOLS_FILE doesn't support exporting all the symbols. Differential Revision: https://phabricator.services.mozilla.com/D28030
f7a15eb24f3d: Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 05 Mar 2019 12:51:44 -0800 - rev 470056
Push 35887 by apavel@mozilla.com at Fri, 19 Apr 2019 03:54:33 +0000
Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod On startup we record the size and modified time of the profile lists. If changed we refuse to flush any new changes to disk. Also adds a getter to check if they've changed so the UI can do something sensible. All attempts to flush are now checked for success. In some cases in early startup the failure mode isn't great, we just quit startup. The assumption though is that it's extremely unlikely that the files will have changed on disk in the time between when they are read and when profile selection occurs, likely less than a second later. The profile reset flow is changed to only delete the old profile and flush once all the migration has completed, so if something fails the user gets back to their old profile. In testing I ended up having to fix bug 1522584 so background file deletions on a background thread are safer. I haven't implemented any UI tests right now since making modifications to the profiles means modifying the actual user's profiles which I'm not keen to do. See bug 1539868. Differential Revision: https://phabricator.services.mozilla.com/D25278
f4de96f2d275: Bug 1544400 - Update fuzzing builds to Clang 8 and use gold. r=froydnj
Christian Holler <choller@mozilla.com> - Thu, 18 Apr 2019 08:28:29 +0000 - rev 470001
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1544400 - Update fuzzing builds to Clang 8 and use gold. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D27701
081a659775d3: Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 18 Apr 2019 04:34:29 +0000 - rev 469976
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod On startup we record the size and modified time of the profile lists. If changed we refuse to flush any new changes to disk. Also adds a getter to check if they've changed so the UI can do something sensible. All attempts to flush are now checked for success. In some cases in early startup the failure mode isn't great, we just quit startup. The assumption though is that it's extremely unlikely that the files will have changed on disk in the time between when they are read and when profile selection occurs, likely less than a second later. The profile reset flow is changed to only delete the old profile and flush once all the migration has completed, so if something fails the user gets back to their old profile. In testing I ended up having to fix bug 1522584 so background file deletions on a background thread are safer. I haven't implemented any UI tests right now since making modifications to the profiles means modifying the actual user's profiles which I'm not keen to do. See bug 1539868. Differential Revision: https://phabricator.services.mozilla.com/D25278
4cf5365482ad: Bug 1542581 - Block child process termination until the handler is fully initialized r=froydnj
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 17 Apr 2019 18:55:14 +0000 - rev 469951
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1542581 - Block child process termination until the handler is fully initialized r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D27231
f0b7027aa979: Bug 1386760 - Remove the ExecutableName annotation r=froydnj
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 17 Apr 2019 14:05:42 +0000 - rev 469945
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1386760 - Remove the ExecutableName annotation r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D27885
77dbf6f2d6d4: Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 17 Apr 2019 20:06:20 +0000 - rev 469939
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod On startup we record the size and modified time of the profile lists. If changed we refuse to flush any new changes to disk. Also adds a getter to check if they've changed so the UI can do something sensible. All attempts to flush are now checked for success. In some cases in early startup the failure mode isn't great, we just quit startup. The assumption though is that it's extremely unlikely that the files will have changed on disk in the time between when they are read and when profile selection occurs, likely less than a second later. The profile reset flow is changed to only delete the old profile and flush once all the migration has completed, so if something fails the user gets back to their old profile. In testing I ended up having to fix bug 1522584 so background file deletions on a background thread are safer. I haven't implemented any UI tests right now since making modifications to the profiles means modifying the actual user's profiles which I'm not keen to do. See bug 1539868. Differential Revision: https://phabricator.services.mozilla.com/D25278
c4895d67effd: Bug 1545007 - Remove our pthread_atfork implementation for Android. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 17 Apr 2019 18:26:02 +0000 - rev 469921
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1545007 - Remove our pthread_atfork implementation for Android. r=froydnj Bug 884239 added a build-time Android version check around the pthread_atfork function definition at the same time as for timer_create, which was subsequently removed. But it turns out the version that documented was wrong: per the comment added in bug 680190, pthread_atfork might have been supported since Android 2.3 (gingerbread, API 9 or 10). That might not be entirely accurate, though, because the bionic repository seems to show it made it to Android 4.0 (ice cream sandwich, API 14 or 15). Either way, that is less than the minimum API version we currently support, which is 16. Differential Revision: https://phabricator.services.mozilla.com/D27848
30271e4881e7: Bug 1542878 - Check all the cbindgen executables before failing configure. r=froydnj
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Apr 2019 14:31:19 +0000 - rev 469893
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1542878 - Check all the cbindgen executables before failing configure. r=froydnj Before this patch, we first find an executable, then check the version. So if the first executable we find is outdated, we won't look for others. Instead, check each of them for different versions manually. This will also unblock bug 1540533, since at that point we know that we'll be able to find a cbindgen with the right version. Differential Revision: https://phabricator.services.mozilla.com/D27890
58a63a9525b8: bug 1517806 - make mozdebug's Visual Studio detection with vswhere more useful. r=ahal,froydnj
Ted Mielczarek <ted@mielczarek.org> - Mon, 01 Apr 2019 14:22:56 +0000 - rev 469852
Push 35883 by btara@mozilla.com at Wed, 17 Apr 2019 21:47:29 +0000
bug 1517806 - make mozdebug's Visual Studio detection with vswhere more useful. r=ahal,froydnj mozdebug has code to locate Visual Studio using vswhere.exe, but it only works if vswhere is in PATH. We have a copy vendored in the source tree, so this change adds support for using that binary when available. Additionally the code parsing the output of vswhere appeared to be using a key that does not exist in the JSON output, so this change fixes that to match the documentation: https://github.com/Microsoft/vswhere/wiki#examples . Differential Revision: https://phabricator.services.mozilla.com/D16542
722ad924491c: Bug 1544431 - Turn the fixes in bug 1539574 and bug 524410 into breakpad patches r=froydnj
Nathan Froyd <froydnj@mozilla.com> - Wed, 17 Apr 2019 09:29:55 +0000 - rev 469784
Push 35882 by cbrindusan@mozilla.com at Wed, 17 Apr 2019 15:54:01 +0000
Bug 1544431 - Turn the fixes in bug 1539574 and bug 524410 into breakpad patches r=froydnj Moved changes to the non-forked part of breakpad living under toolkit/crashreporter/google-breakpad into separate patches that are applied by update-breakpad.sh when synchronizing with upstream breakpad. Because we landed the commits directly to the sources every time we called update-breakpad.sh those changes would be reverted. Differential Revision: https://phabricator.services.mozilla.com/D27682
a33df20e8c10: Bug 1544139 - Un-set RUSTFLAGS for artifact builds. r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Fri, 12 Apr 2019 22:47:52 +0000 - rev 469542
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1544139 - Un-set RUSTFLAGS for artifact builds. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D27397
9f73549db05e: Bug 1538279 - Extract nsZipArchive's madvise and similar to a helper r=glandium,froydnj
Doug Thayer <dothayer@mozilla.com> - Sat, 13 Apr 2019 18:46:04 +0000 - rev 469415
Push 35865 by apavel@mozilla.com at Sat, 13 Apr 2019 21:44:49 +0000
Bug 1538279 - Extract nsZipArchive's madvise and similar to a helper r=glandium,froydnj This is just to make it simpler to use PrefetchVirtualMemory in subsequent patches. Differential Revision: https://phabricator.services.mozilla.com/D26016
7ba85ea07d28: Bug 1543693 - Add missing nsReadableUtils wrappers for conversions between UTF-8 and Latin1 XPCOM string. r=froydnj
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 12 Apr 2019 17:49:11 +0000 - rev 469413
Push 35865 by apavel@mozilla.com at Sat, 13 Apr 2019 21:44:49 +0000
Bug 1543693 - Add missing nsReadableUtils wrappers for conversions between UTF-8 and Latin1 XPCOM string. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D27234
12e5e835a768: Bug 1522931 - Vendor biplist; r=froydnj
Mike Shal <mshal@mozilla.com> - Fri, 12 Apr 2019 19:00:15 +0000 - rev 469313
Push 35861 by btara@mozilla.com at Fri, 12 Apr 2019 21:56:33 +0000
Bug 1522931 - Vendor biplist; r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D26390
c78a681b16f9: Bug 1543970 - give up removing the startup cache file from the previous profile location after 6 years, r=froydnj
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 12 Apr 2019 14:07:40 +0000 - rev 469287
Push 35861 by btara@mozilla.com at Fri, 12 Apr 2019 21:56:33 +0000
Bug 1543970 - give up removing the startup cache file from the previous profile location after 6 years, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D27280
5e05dde4f7cb: Bug 1538810 - Updated breakpad's curl and musl headers r=froydnj
Gabriele Svelto <gsvelto@mozilla.com> - Tue, 09 Apr 2019 16:04:25 +0000 - rev 469217
Push 35859 by shindli@mozilla.com at Fri, 12 Apr 2019 15:46:45 +0000
Bug 1538810 - Updated breakpad's curl and musl headers r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D26489
98bf8629efc6: Bug 1538810 - Update breakpad to upstream revision 4d550cceca107f36c4bc1ea1126b7d32cc50f424 r=froydnj
Gabriele Svelto <gsvelto@mozilla.com> - Tue, 09 Apr 2019 16:04:24 +0000 - rev 469216
Push 35859 by shindli@mozilla.com at Fri, 12 Apr 2019 15:46:45 +0000
Bug 1538810 - Update breakpad to upstream revision 4d550cceca107f36c4bc1ea1126b7d32cc50f424 r=froydnj This includes improvements to the Linux exception handler that will provide crash addresse for a number of signals by reading the NT_SIGINFO structure and quites warnings in a number of files. This also removes an unused header. Differential Revision: https://phabricator.services.mozilla.com/D26488
6f2e7c819c11: Bug 1538279 - Extract nsZipArchive's madvise and similar to a helper r=glandium,froydnj
Doug Thayer <dothayer@mozilla.com> - Fri, 12 Apr 2019 02:17:18 +0000 - rev 469206
Push 35858 by shindli@mozilla.com at Fri, 12 Apr 2019 09:34:00 +0000
Bug 1538279 - Extract nsZipArchive's madvise and similar to a helper r=glandium,froydnj This is just to make it simpler to use PrefetchVirtualMemory in subsequent patches. Differential Revision: https://phabricator.services.mozilla.com/D26016
d5ce9b28780d: Bug 1543555 - Stop using our linker to resolve libc/libm symbols when not strictly necessary. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 12 Apr 2019 02:12:31 +0000 - rev 469205
Push 35858 by shindli@mozilla.com at Fri, 12 Apr 2019 09:34:00 +0000
Bug 1543555 - Stop using our linker to resolve libc/libm symbols when not strictly necessary. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D27019
581a359135ad: Bug 1543582 - Only include quotes around XPCOM strings in MOZ_DBG, not operator<<. r=froydnj
Cameron McCormack <cam@mcc.id.au> - Thu, 11 Apr 2019 23:44:57 +0000 - rev 469189
Push 35858 by shindli@mozilla.com at Fri, 12 Apr 2019 09:34:00 +0000
Bug 1543582 - Only include quotes around XPCOM strings in MOZ_DBG, not operator<<. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D27031
c1f7767c6896: Bug 1536486 - Use plain cargo instead of rustup cargo on OSX. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 11 Apr 2019 22:25:51 +0000 - rev 469117
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1536486 - Use plain cargo instead of rustup cargo on OSX. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D27040
76d16b72c985: Bug 1543595 - Enable linux64-aarch64 builds. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 11 Apr 2019 14:35:25 +0000 - rev 469112
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1543595 - Enable linux64-aarch64 builds. r=froydnj While we don't have an actual need for those builds at the moment, there is work in progress to get fuzzing builds for aarch64, and as the previous change showed, the build were busted by other changes since they were put in place. So we might as well enable them, so as to be aware of bustage when it happens rather than while working on getting the fuzzing builds up. Depends on D27035 Differential Revision: https://phabricator.services.mozilla.com/D27036
d709880ef6dd: Bug 1543595 - Add missing aarch64 target to the rust 1.33 toolchain. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 11 Apr 2019 14:35:25 +0000 - rev 469111
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1543595 - Add missing aarch64 target to the rust 1.33 toolchain. r=froydnj I must have written the rust 1.33 patch before I landed the linux64-aarch64 patches, so when that landed, it lacked the aarch64 target. (it's still there on the rust 1.32 toolchain) Differential Revision: https://phabricator.services.mozilla.com/D27035
f12fa3688892: Bug 1542920 - Enable Marionette by default. r=froydnj
Nick Alexander <nalexander@mozilla.com> - Wed, 10 Apr 2019 14:11:17 +0000 - rev 468866
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1542920 - Enable Marionette by default. r=froydnj In particular, this enables Marionette in local Fennec builds, which were the only place it wasn't enabled by default. (Automation builds all enabled Marionette.) That default is getting in the way of the Performance Team (and others!) testing GeckoView-based products easily. Differential Revision: https://phabricator.services.mozilla.com/D26815
426c8e006341: Bug 1543246 - Suggest |./mach busted| when something breaks. r=froydnj
Bobby Holley <bobbyholley@gmail.com> - Wed, 10 Apr 2019 16:40:14 +0000 - rev 468803
Push 35850 by dvarga@mozilla.com at Wed, 10 Apr 2019 21:52:56 +0000
Bug 1543246 - Suggest |./mach busted| when something breaks. r=froydnj Depends on D26818 Differential Revision: https://phabricator.services.mozilla.com/D26930
c8dd1ef3daf2: Bug 1543246 - Implement |./mach busted|. r=froydnj
Bobby Holley <bobbyholley@gmail.com> - Wed, 10 Apr 2019 16:26:44 +0000 - rev 468802
Push 35850 by dvarga@mozilla.com at Wed, 10 Apr 2019 21:52:56 +0000
Bug 1543246 - Implement |./mach busted|. r=froydnj Depends on D26817 Differential Revision: https://phabricator.services.mozilla.com/D26818
7de34f2a331c: Bug 1543246 - Add searchfox support to mach. r=froydnj
Bobby Holley <bobbyholley@gmail.com> - Wed, 10 Apr 2019 16:26:42 +0000 - rev 468801
Push 35850 by dvarga@mozilla.com at Wed, 10 Apr 2019 21:52:56 +0000
Bug 1543246 - Add searchfox support to mach. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D26817
fd68ef11f142: Bug 1542214 - Prevent registering the same CID and contract IDs during component manager initialization. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 09 Apr 2019 18:39:00 +0000 - rev 468667
Push 35845 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 09:58:56 +0000
Bug 1542214 - Prevent registering the same CID and contract IDs during component manager initialization. r=froydnj Because not all static components are using the static registration yet, we can end up in situations where a same component is registered multiple times, which can have some unexpected consequences. Interestingly enough, this change revealed that we did have static registration in place for components that were kept under the old system after bug 1478124 and bug 1524687. There are also possibly some non-obvious things that can happen while migrating the remaining components, like what happened to me while I worked on @mozilla.org/widget/components;1 (see bug 1542214 comment 0). Differential Revision: https://phabricator.services.mozilla.com/D26698
95e2d2baec44: Bug 1539029 - pt 2 - add RDD process selector to prefs module. r=froydnj
Michael Froman <mfroman@mozilla.com> - Tue, 09 Apr 2019 21:07:40 +0000 - rev 468660
Push 35845 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 09:58:56 +0000
Bug 1539029 - pt 2 - add RDD process selector to prefs module. r=froydnj Depends on D26566 Differential Revision: https://phabricator.services.mozilla.com/D26567
8f70ba445346: Bug 1539029 - pt 1 - give RDD its own process selector. r=froydnj
Michael Froman <mfroman@mozilla.com> - Tue, 09 Apr 2019 21:13:16 +0000 - rev 468659
Push 35845 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 09:58:56 +0000
Bug 1539029 - pt 1 - give RDD its own process selector. r=froydnj Originally, RDD reused the GPU process selector since they were using all the same services, and it reduced the number of places that had to be touched. Now that RDD needs pref handling, it needs its own process selector to avoid GPU inheriting pref handling. Differential Revision: https://phabricator.services.mozilla.com/D26566
71191e5499a1: Bug 1522931 - Vendor biplist; r=froydnj
Mike Shal <mshal@mozilla.com> - Mon, 08 Apr 2019 16:29:55 +0000 - rev 468657
Push 35845 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 09:58:56 +0000
Bug 1522931 - Vendor biplist; r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D26390
c8c67ca7b3d9: Bug 1542735 - Don't try to build TestUCRTDepends if tests are disabled. r=froydnj
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 09 Apr 2019 18:46:49 +0000 - rev 468640
Push 35845 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 09:58:56 +0000
Bug 1542735 - Don't try to build TestUCRTDepends if tests are disabled. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D26501
a31032a16330: Bug 1542716: Allow overriding the update channel that is used when generating the default profile name. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 09 Apr 2019 18:38:17 +0000 - rev 468624
Push 35843 by nbeleuzu@mozilla.com at Tue, 09 Apr 2019 22:08:13 +0000
Bug 1542716: Allow overriding the update channel that is used when generating the default profile name. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D26632
de1c51fce80e: Bug 1539538 - Introduce UnsafePtr r=froydnj,janv
Yaron Tausky <ytausky@mozilla.com> - Tue, 09 Apr 2019 14:41:57 +0000 - rev 468576
Push 35843 by nbeleuzu@mozilla.com at Tue, 09 Apr 2019 22:08:13 +0000
Bug 1539538 - Introduce UnsafePtr r=froydnj,janv This commit adds a smart pointer class that verifies that no dangling pointers remain after the pointee went out of scope. This verification is opt-in and can be controlled both statically and dynamically by the pointee. Differential Revision: https://phabricator.services.mozilla.com/D25200
f09e9d011ba1: Bug 1542854 - Make [System Principal] into a static atom. r=froydnj
Andrew McCreight <continuation@gmail.com> - Tue, 09 Apr 2019 13:23:28 +0000 - rev 468568
Push 35843 by nbeleuzu@mozilla.com at Tue, 09 Apr 2019 22:08:13 +0000
Bug 1542854 - Make [System Principal] into a static atom. r=froydnj Whenever chrome JS code leaks, we leak the dynamic atom "[System Principal]". This causes an assertion, which hangs the browser in stack walking code for multiple minutes on OSX. As a bandaid, make this atom static so it won't leak. My first instinct is that it would make sense to use this new atom directly in SystemPrincipal, but atoms are represented internally as a kind of nsAString, but principal code uses nsACStrings, so you end up with an extra conversion from 16-bit to 8-bit. This atom is also going to be present in any process running chrome JS, so this will save a little bit of memory. Differential Revision: https://phabricator.services.mozilla.com/D26590
bbfe142d94f9: Bug 1405345 - ldflags as defined in gypi shouldn't be ignored at least on Solaris for now r=froydnj
Petr Sumbera <petr.sumbera@oracle.com> - Tue, 09 Apr 2019 13:22:16 +0000 - rev 468556
Push 35843 by nbeleuzu@mozilla.com at Tue, 09 Apr 2019 22:08:13 +0000
Bug 1405345 - ldflags as defined in gypi shouldn't be ignored at least on Solaris for now r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D26287
695340776de7: Bug 1516337 - Part 2: Revendor dependencies r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Mon, 08 Apr 2019 23:18:15 +0300 - rev 468485
Push 35839 by nerli@mozilla.com at Tue, 09 Apr 2019 09:56:52 +0000
Bug 1516337 - Part 2: Revendor dependencies r=froydnj
12bfe4f2aa08: Bug 1516337 - Part 1: Dedupe sha2 and related dependencies r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Mon, 08 Apr 2019 23:17:50 +0300 - rev 468484
Push 35839 by nerli@mozilla.com at Tue, 09 Apr 2019 09:56:52 +0000
Bug 1516337 - Part 1: Dedupe sha2 and related dependencies r=froydnj This also removes the lalrpop files from the .git/hgignore as that breaks the build since lalrpop now includes lrgrammar in the published crate and that file needs to be vendored
60669a841a87: Bug 1541792 - Replace linker magic with manual component registration. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 05 Apr 2019 02:30:56 +0000 - rev 468474
Push 35838 by nerli@mozilla.com at Tue, 09 Apr 2019 09:54:40 +0000
Bug 1541792 - Replace linker magic with manual component registration. r=froydnj Before bug 938437, we had a rather large and error-prone nsStaticXULComponents.cpp used to register all modules. That was replaced with clever use of the linker, which allowed to avoid the mess that maintaining that file was. Fast forward to now, where after bug 1524687 and other work that preceded it, we have a much smaller number of remaining static xpcom components, registered via this linker hack, and don't expect to add any new ones. The list should eventually go down to zero. Within that context, it seems to be the right time to get rid of the magic, and with it the problems it causes on its own. Some of those components could probably be trivially be converted to static registration via .conf files, but I didn't want to deal with the possible need to increase the number of dummy modules in XPCOMInit.cpp. They can still be converted as a followup. Differential Revision: https://phabricator.services.mozilla.com/D26076
e6d48028244b: Bug 1540907 - Bump MinGW version to pick up MFVideoTransferMatrix constants r=froydnj
Tom Ritter <tom@mozilla.com> - Mon, 08 Apr 2019 19:14:03 +0000 - rev 468443
Push 35838 by nerli@mozilla.com at Tue, 09 Apr 2019 09:54:40 +0000
Bug 1540907 - Bump MinGW version to pick up MFVideoTransferMatrix constants r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D26530
b34795658d23: Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld on a CLOSED TREE
Aaron Klotz <aklotz@mozilla.com> - Tue, 09 Apr 2019 00:45:24 +0300 - rev 468431
Push 35837 by rmaries@mozilla.com at Tue, 09 Apr 2019 03:43:40 +0000
Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld on a CLOSED TREE The binary path type of a particular content process is useful information outside of IPC. Given that `XRE_EnableSameExecutableForContentProc` already exists, and given that the binary path type is closely related to `GeckoProcessType`, I've added a new function, `XRE_GetContentProcBinPathType`. The mapping of process type to binary type has been moved to the `GeckoProcessTypes` definitions. This patch also modifies `ipc::GeckoChildProcessHost` to call into the new function. Differential Revision: https://phabricator.services.mozilla.com/D25816
7ecc024df5d4: Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 20:19:51 +0000 - rev 468426
Push 35837 by rmaries@mozilla.com at Tue, 09 Apr 2019 03:43:40 +0000
Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld The binary path type of a particular content process is useful information outside of IPC. Given that `XRE_EnableSameExecutableForContentProc` already exists, and given that the binary path type is closely related to `GeckoProcessType`, I've added a new function, `XRE_GetContentProcBinPathType`. The mapping of process type to binary type has been moved to the `GeckoProcessTypes` definitions. This patch also modifies `ipc::GeckoChildProcessHost` to call into the new function. Differential Revision: https://phabricator.services.mozilla.com/D25816
656108173cde: Bug 1541130: Follow-up: Add more missing parts that had been stripped during rebase; r=froydnj, jld on a CLOSED TREE
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 13:28:04 -0600 - rev 468406
Push 35837 by rmaries@mozilla.com at Tue, 09 Apr 2019 03:43:40 +0000
Bug 1541130: Follow-up: Add more missing parts that had been stripped during rebase; r=froydnj, jld on a CLOSED TREE
5914a425bc67: Bug 1541130: Follow-up: Add missing parts that had been stripped out during rebase; r=froydnj, jld on a CLOSED TREE
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 12:55:55 -0600 - rev 468405
Push 35837 by rmaries@mozilla.com at Tue, 09 Apr 2019 03:43:40 +0000
Bug 1541130: Follow-up: Add missing parts that had been stripped out during rebase; r=froydnj, jld on a CLOSED TREE
dfa27849ea1b: Bug 1542400 - Don't set LLVM_DEFAULT_TARGET_TRIPLE to possibly erroneous value when building clang runtimes. r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Mon, 08 Apr 2019 16:28:24 +0000 - rev 468400
Push 35835 by aciure@mozilla.com at Mon, 08 Apr 2019 19:00:29 +0000
Bug 1542400 - Don't set LLVM_DEFAULT_TARGET_TRIPLE to possibly erroneous value when building clang runtimes. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D26384
8ef30ebad16c: Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 18:19:06 +0000 - rev 468399
Push 35835 by aciure@mozilla.com at Mon, 08 Apr 2019 19:00:29 +0000
Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld The binary path type of a particular content process is useful information outside of IPC. Given that `XRE_EnableSameExecutableForContentProc` already exists, and given that the binary path type is closely related to `GeckoProcessType`, I've added a new function, `XRE_GetContentProcBinPathType`. The mapping of process type to binary type has been moved to the `GeckoProcessTypes` definitions. This patch also modifies `ipc::GeckoChildProcessHost` to call into the new function. Differential Revision: https://phabricator.services.mozilla.com/D25816
4b5b95e9afa0: Bug 1542528 - Add an `xpcom::c_str` macro for creating static C strings. r=froydnj
Lina Cambridge <lina@yakshaving.ninja> - Mon, 08 Apr 2019 14:43:35 +0000 - rev 468354
Push 35835 by aciure@mozilla.com at Mon, 08 Apr 2019 19:00:29 +0000
Bug 1542528 - Add an `xpcom::c_str` macro for creating static C strings. r=froydnj This is based on the `c_str` macro in `js/rust/src/heap.rs`, but returns a `NulTerminatedCStr` type that can be cast to a pointer. This commit also changes `ThreadPtrHolder::new` to take a `NulTerminatedCStr`, and removes an unnecessary `RefPtr` reference in `is_current_thread`. Differential Revision: https://phabricator.services.mozilla.com/D26429
6a0082ace56a: Bug 1517797 - Rewrite net_IsValidIPv6Addr in Rust r=valentin,froydnj
Jeremy Lempereur <jeremy.lempereur@gmail.com> - Mon, 08 Apr 2019 06:33:04 +0000 - rev 468306
Push 35831 by dluca@mozilla.com at Mon, 08 Apr 2019 10:33:51 +0000
Bug 1517797 - Rewrite net_IsValidIPv6Addr in Rust r=valentin,froydnj Differential Revision: https://phabricator.services.mozilla.com/D15737
50447a9c4347: Bug 1529774 - Upgrade builders to rust 1.33. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 05 Apr 2019 22:20:25 +0000 - rev 468253
Push 35824 by apavel@mozilla.com at Sat, 06 Apr 2019 10:57:50 +0000
Bug 1529774 - Upgrade builders to rust 1.33. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D24830