searching for reviewer(erahm)
ae917a0735c16cd524a204550c7f7e5dd33a0aed: Bug 1634290 - Bump RLBox library to the latest version r=erahm,froydnj
shravanrn@gmail.com <shravanrn@gmail.com> - Wed, 29 Jul 2020 05:35:47 +0000 - rev 542485
Push 37651 by malexandru@mozilla.com at Thu, 30 Jul 2020 09:39:56 +0000
Bug 1634290 - Bump RLBox library to the latest version r=erahm,froydnj Differential Revision: https://phabricator.services.mozilla.com/D73218
1e65b41655c44f3ccb0a8df7723244c2ceaed918: Bug 1628713 - Add `Tokenizer::CheckPhrase` to quickly check for compound strings, r=xpcom-reviewers,erahm
Honza Bambas <honzab.moz@firemni.cz> - Thu, 23 Jul 2020 12:57:50 +0000 - rev 541754
Push 37631 by btara@mozilla.com at Thu, 23 Jul 2020 16:21:22 +0000
Bug 1628713 - Add `Tokenizer::CheckPhrase` to quickly check for compound strings, r=xpcom-reviewers,erahm Differential Revision: https://phabricator.services.mozilla.com/D70373
e7e487fbbaf08e13d2825f29df822761b661dbd2: Bug 1632735 - Upgrade valgrind builds to the same rust version as other builds. r=erahm
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 Jun 2020 22:29:59 +0000 - rev 537503
Push 37543 by abutkovits@mozilla.com at Fri, 26 Jun 2020 03:24:35 +0000
Bug 1632735 - Upgrade valgrind builds to the same rust version as other builds. r=erahm And add suppressions for the new errors that this adds to the valgrind run. It's not clear if it's a legitimate thing that LLVM does that valgrind doesn't cope with, like many others, but the fact is running valgrind on a PGO/LTO build doesn't show these errors, so we're not actually shipping them anyways (but does show _different_ errors that we don't see on the build the valgrind jobs do) Differential Revision: https://phabricator.services.mozilla.com/D81016
0437ee3e3c8ba3467670be0d145f85193c10ef6b: Bug 1639785 - Update `rapl` for new processors. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 22 May 2020 02:29:54 +0000 - rev 532100
Push 37450 by cbrindusan@mozilla.com at Tue, 26 May 2020 15:44:42 +0000
Bug 1639785 - Update `rapl` for new processors. r=erahm Also change the processor IDs to hex, because that's what the Linux kernel source code uses. And reorder the cases a little. Differential Revision: https://phabricator.services.mozilla.com/D76272
972fcba11cb6e6ef865aa40cb881753d2059a4c2: Bug 1630655 - Actually advance lateWriteChecksStage to 3 r=erahm
Doug Thayer <dothayer@mozilla.com> - Mon, 11 May 2020 21:04:36 +0000 - rev 529472
Push 37409 by apavel@mozilla.com at Wed, 13 May 2020 03:44:05 +0000
Bug 1630655 - Actually advance lateWriteChecksStage to 3 r=erahm The preprocessor does not handle "# ifdef" like the C preprocessor, and I failed to test this appropriately after restructuring the #if... clauses. This also reverts fastShutdownStage back to 1, so we can be confident in the data we collect. Differential Revision: https://phabricator.services.mozilla.com/D71190
14706ef4800f6f0c9275e4c64bb44512afe4f76e: Bug 1632928 - Update `fix-stacks`. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 01 May 2020 19:22:47 +0000 - rev 527756
Push 37369 by malexandru@mozilla.com at Sat, 02 May 2020 09:48:55 +0000
Bug 1632928 - Update `fix-stacks`. r=erahm This pulls in: - https://github.com/mozilla/fix-stacks/pull/24, which removes some junk from Breakpad file names; - https://github.com/mozilla/fix-stacks/pull/25, which avoids having two different versions of the goblin crate. Differential Revision: https://phabricator.services.mozilla.com/D73407
034f61c238aada80295bcc822cc8ea286232f599: Bug 1629789 - Suppress `fix-stacks` errors on web platform tests. r=erahm,jgraham
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 29 Apr 2020 21:58:10 +0000 - rev 527390
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1629789 - Suppress `fix-stacks` errors on web platform tests. r=erahm,jgraham Because the web platform test harness doesn't recognize them and annotates them with `CRITICAL`, which is disconcerting, even though those errors are typically not harmful. Differential Revision: https://phabricator.services.mozilla.com/D71485
693d927ca2163a0975a7bc7f183e4fa9386d0251: Bug 1628033 - Add pid to the main process in about:memory. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 30 Apr 2020 21:20:23 +0000 - rev 527372
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1628033 - Add pid to the main process in about:memory. r=erahm In the tests we now explicitly use "Main Process" (or similar) for the process name in various places to avoid having to filter out a PID. Also in `test_aboutmemory[34].xhtml`, the main process entries now appear first, as they should, because the sorting code now looks for a "Main Process" prefix, rather than an exact match. Depends on D72995 Differential Revision: https://phabricator.services.mozilla.com/D73164
d0842e4533ada8aea196bc99ccf1215f083db1f0: Bug 1628692 - Prepare media/webrtc/signaling/src/peerconnection/ for making FallibleTArray uncopyable. r=jesup,bwc,erahm
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 29 Apr 2020 15:38:28 +0000 - rev 526730
Push 37363 by malexandru@mozilla.com at Thu, 30 Apr 2020 03:51:35 +0000
Bug 1628692 - Prepare media/webrtc/signaling/src/peerconnection/ for making FallibleTArray uncopyable. r=jesup,bwc,erahm Differential Revision: https://phabricator.services.mozilla.com/D72621
a2f5169fa81d846806b96d2eb32f8cd500f2eccf: Bug 1632770 - Document what linker is used across configurations. r=erahm
Mike Hommey <mh+mozilla@glandium.org> - Wed, 29 Apr 2020 00:13:56 +0000 - rev 526588
Push 37359 by csabou@mozilla.com at Wed, 29 Apr 2020 09:51:05 +0000
Bug 1632770 - Document what linker is used across configurations. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D72302
6bb8423186c1bb8c1229249454de46efb7d4d584: Bug 1633901 - Add support for hiding `fix-stacks` errors. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 28 Apr 2020 23:55:57 +0000 - rev 526587
Push 37358 by opoprus@mozilla.com at Wed, 29 Apr 2020 03:05:14 +0000
Bug 1633901 - Add support for hiding `fix-stacks` errors. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D72958
bad4d84f41cae3804de1b494172630bd661dde7f: Bug 1631304 - Reject AbstractThread dispatches after the main thread has ceased event proccessing. r=erahm
Bobby Holley <bobbyholley@gmail.com> - Tue, 28 Apr 2020 21:18:19 +0000 - rev 526567
Push 37358 by opoprus@mozilla.com at Wed, 29 Apr 2020 03:05:14 +0000
Bug 1631304 - Reject AbstractThread dispatches after the main thread has ceased event proccessing. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D72263
63aa05c6c9b02d377e188de636958e2ab5094d20: Bug 1631304 - Drill a fast path to accessing the main thread. r=erahm
Bobby Holley <bobbyholley@gmail.com> - Tue, 28 Apr 2020 21:18:10 +0000 - rev 526564
Push 37358 by opoprus@mozilla.com at Wed, 29 Apr 2020 03:05:14 +0000
Bug 1631304 - Drill a fast path to accessing the main thread. r=erahm I'm surprised we don't have this already. Differential Revision: https://phabricator.services.mozilla.com/D71486
9f796abfd8cabad7f13f952f79713c93ab29e46b: Bug 1629789 - Suppress `fix-stacks` errors on web platform tests. r=erahm,jgraham
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 28 Apr 2020 09:28:15 +0000 - rev 526448
Push 37356 by aiakab@mozilla.com at Tue, 28 Apr 2020 16:30:11 +0000
Bug 1629789 - Suppress `fix-stacks` errors on web platform tests. r=erahm,jgraham Because the web platform test harness doesn't recognize them and annotates them with `CRITICAL`, which is disconcerting, even though those errors are typically not harmful. Differential Revision: https://phabricator.services.mozilla.com/D71485
4ee10910e65958a741f837044e29ab9dfe5ae964: Bug 1632802 - Remove nsAgg.h. r=erahm
Peter Van der Beken <peterv@propagandism.org> - Mon, 27 Apr 2020 07:56:04 +0000 - rev 526176
Push 37353 by shindli@mozilla.com at Mon, 27 Apr 2020 21:46:18 +0000
Bug 1632802 - Remove nsAgg.h. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D72359
7805c1104fa57a74acd26f82bb33507bf76b1f0d: Bug 1632759 - Remove unnecessary kungFuDeathGrip. r=erahm
Peter Van der Beken <peterv@propagandism.org> - Mon, 27 Apr 2020 07:31:06 +0000 - rev 526174
Push 37353 by shindli@mozilla.com at Mon, 27 Apr 2020 21:46:18 +0000
Bug 1632759 - Remove unnecessary kungFuDeathGrip. r=erahm The problem in https://bugzilla.mozilla.org/show_bug.cgi?id=325392 was misdiagnosed and then a generic fix in https://bugzilla.mozilla.org/show_bug.cgi?id=485834 (the kungFuDeathGrip in nsObserverService::RemoveObserver) was based on the wrong diagnosis. The root problem in bug 325392 was not that we were calling nsObserverService::RemoveObserver from the destructor, and then reentering the destructor. The refcounting code stabilizes the refcount to 1 before calling the destructor to avoid reentering a destructor. The real problem was that we were deleting an XPCOM object manually after creation but without ever holding a strong reference to it, and so not going through the refcount stabilization (and then the destructor can reenter of course). The generic fix in bug 485834 was based on the spotfix in bug 325392, that was then backed out when the proper fix for that bug landed. I don't think we should keep this kungfuDeathGrip, I ran into it because it causes issues with refcount logging (refcount logging always had an issue with refcounting from a destructor). Differential Revision: https://phabricator.services.mozilla.com/D72300
bfb074351550ee1d886ce6feb236b10211421f8b: Bug 1630655 - Actually advance lateWriteChecksStage to 3 r=erahm
Doug Thayer <dothayer@mozilla.com> - Thu, 23 Apr 2020 16:43:17 +0000 - rev 526011
Push 37348 by rmaries@mozilla.com at Sat, 25 Apr 2020 09:49:23 +0000
Bug 1630655 - Actually advance lateWriteChecksStage to 3 r=erahm The preprocessor does not handle "# ifdef" like the C preprocessor, and I failed to test this appropriately after restructuring the #if... clauses. This also reverts fastShutdownStage back to 1, so we can be confident in the data we collect. Differential Revision: https://phabricator.services.mozilla.com/D71190
7b3f5e09731f0cc464dbe27c529b319609a31e8b: Bug 1628715 - Part 3: Make fallible nsTArray::Assign nodiscard. r=xpcom-reviewers,erahm
Simon Giesecke <sgiesecke@mozilla.com> - Fri, 24 Apr 2020 13:25:13 +0000 - rev 525920
Push 37348 by rmaries@mozilla.com at Sat, 25 Apr 2020 09:49:23 +0000
Bug 1628715 - Part 3: Make fallible nsTArray::Assign nodiscard. r=xpcom-reviewers,erahm Differential Revision: https://phabricator.services.mozilla.com/D70384
6bec0aa0bc3013409b82cc93e55c24cbc71e18ba: Bug 1628715 - Part 2: Disable copy assignment to FallibleTArray from infallible nsTArray. r=xpcom-reviewers,erahm
Simon Giesecke <sgiesecke@mozilla.com> - Fri, 24 Apr 2020 13:24:57 +0000 - rev 525919
Push 37348 by rmaries@mozilla.com at Sat, 25 Apr 2020 09:49:23 +0000
Bug 1628715 - Part 2: Disable copy assignment to FallibleTArray from infallible nsTArray. r=xpcom-reviewers,erahm Also prepare disabling copy construction and assignment in Bug 1628692. Differential Revision: https://phabricator.services.mozilla.com/D70383
6e6528dfcb64ae6ad4285a722cd5c7dc93975c5d: Bug 1628715 - Part 1: Add MOZ_NONNULL_RETURN attributes to some nsTArray functions. r=xpcom-reviewers,erahm
Simon Giesecke <sgiesecke@mozilla.com> - Fri, 24 Apr 2020 13:47:55 +0000 - rev 525918
Push 37348 by rmaries@mozilla.com at Sat, 25 Apr 2020 09:49:23 +0000
Bug 1628715 - Part 1: Add MOZ_NONNULL_RETURN attributes to some nsTArray functions. r=xpcom-reviewers,erahm Differential Revision: https://phabricator.services.mozilla.com/D70382
fe830aa941b047eed00343c3f7573105ce983dc5: Bug 1626174 - Enable use of wasm sandboxed libOgg in the OggDemuxer in linux, mac, try servers r=padenot,erahm,dmajor,firefox-build-system-reviewers
shravanrn@gmail.com <shravanrn@gmail.com> - Wed, 22 Apr 2020 11:16:10 +0000 - rev 525465
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1626174 - Enable use of wasm sandboxed libOgg in the OggDemuxer in linux, mac, try servers r=padenot,erahm,dmajor,firefox-build-system-reviewers Differential Revision: https://phabricator.services.mozilla.com/D70652
40fea0f3ab6ceee1e5651a5182d9d9b8594b64c4: Bug 1626174 - Enable use of wasm sandboxed libOgg in the OggDemuxer in linux, mac, try servers r=padenot,erahm,dmajor,firefox-build-system-reviewers
shravanrn@gmail.com <shravanrn@gmail.com> - Tue, 21 Apr 2020 15:30:37 +0000 - rev 525199
Push 37335 by aiakab@mozilla.com at Wed, 22 Apr 2020 04:10:25 +0000
Bug 1626174 - Enable use of wasm sandboxed libOgg in the OggDemuxer in linux, mac, try servers r=padenot,erahm,dmajor,firefox-build-system-reviewers Depends on D68764 Differential Revision: https://phabricator.services.mozilla.com/D70652
d9dfb643976168b0b522ac717c8067f2c7b83b83: Bug 1628527 - Introduce explicit initialization and finalization of `fix-stacks`. r=erahm,perftest-reviewers,sparky,gbrown
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 20 Apr 2020 22:43:25 +0000 - rev 524979
Push 37333 by cbrindusan@mozilla.com at Tue, 21 Apr 2020 09:42:20 +0000
Bug 1628527 - Introduce explicit initialization and finalization of `fix-stacks`. r=erahm,perftest-reviewers,sparky,gbrown Currently AWSY-with-DMD doesn't work on Windows. This is because `fix-stacks` is initialized lazily, and by the time the initialization happens some file descriptors for files are open, and that leads to some major Python2-on-Windows sadness as described in the big comment in the commit. To fix the problem, this commit adds an `init` function to `fix_stacks.py` so that `fix-stacks` can be initialized eagerly, hopefully before any file descriptors for files are open. For `dmd.py`, other than fixing the AWSY problems, this has little effect, because `fix-stacks` is always initialized. For `utils.py`, which is used to process the output of most tests, this has a more noticeable effect: the `fix-stacks` process is always spawned, rather than being spawned only when needed. If no stack traces appear in the test output, this means that `fix-stacks` is spawned unnecessarily. But it's cheap to spawn; the expensive part only happens when stack traces start getting fixed. So I think this change in behaviour is acceptable. Furthermore, the commit adds a `finish` function to `fix_stacks.py`, so that the `fix-stacks` process can be explicitly shut down. This has never been done for processes spawned for any of the stack fixing scripts. It's never caused problems on Linux/Mac, but it seems to be necessary on Windows to avoid similar "this file is locked" problems with the test_dmd.js test. The commit also renames some things to more standard Python style, e.g. `json_mode` instead of `jsonMode`. Finally, Android tests use `utils.py` from the repository but `fix_stacks.py` from the Android host utils. Because the two scripts must be updated in tandem, this commit also updates the Android host utils to a version that contains the updated `fix_stacks.py`. Thanks to aerickson for packaging up the new Android host utils and providing the change to the `hostutils.manifest` file. Differential Revision: https://phabricator.services.mozilla.com/D69478
8235287622a85bb6f95354bab8d7ec583e9a3b66: Bug 1628527 - Install `fix-stacks` on the `build-win64-fuzzing/debug` job. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 20 Apr 2020 22:43:25 +0000 - rev 524978
Push 37333 by cbrindusan@mozilla.com at Tue, 21 Apr 2020 09:42:20 +0000
Bug 1628527 - Install `fix-stacks` on the `build-win64-fuzzing/debug` job. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D70294
700adf5d377997448eb87cad3628200047d6180c: Bug 1631304 - Drill a fast path to accessing the main thread. r=erahm
Bobby Holley <bobbyholley@gmail.com> - Mon, 20 Apr 2020 22:49:39 +0000 - rev 524963
Push 37333 by cbrindusan@mozilla.com at Tue, 21 Apr 2020 09:42:20 +0000
Bug 1631304 - Drill a fast path to accessing the main thread. r=erahm I'm surprised we don't have this already. Differential Revision: https://phabricator.services.mozilla.com/D71486
f055b35804d7d6f8a5878f21583284708475cf32: Bug 1630655 - Actually advance lateWriteChecksStage to 3 r=erahm
Doug Thayer <dothayer@mozilla.com> - Thu, 16 Apr 2020 23:19:18 +0000 - rev 524533
Push 37321 by dluca@mozilla.com at Fri, 17 Apr 2020 09:38:52 +0000
Bug 1630655 - Actually advance lateWriteChecksStage to 3 r=erahm The preprocessor does not handle "# ifdef" like the C preprocessor, and I failed to test this appropriately after restructuring the #if... clauses. This also reverts fastShutdownStage back to 1, so we can be confident in the data we collect. Differential Revision: https://phabricator.services.mozilla.com/D71190
c5aea39987328d95f92b043680db4b0fdca841c3: Bug 1628494 - Add `fix-stacks` to `test-{verify,coverage}` jobs. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 14 Apr 2020 22:57:49 +0000 - rev 523999
Push 37314 by shindli@mozilla.com at Wed, 15 Apr 2020 09:25:24 +0000
Bug 1628494 - Add `fix-stacks` to `test-{verify,coverage}` jobs. r=erahm These configs now have the same `fetches`/`toolchain`/`by-test-platform` values as the `xpcshell` config in `xpcshell.yml`. Differential Revision: https://phabricator.services.mozilla.com/D70650
461171bd07fe935e37222d9ae1032f985ba0358a: Bug 1628697 - nsTArray::AppendElements(mozilla::Span<const Item> aSpan) should use ActualAlloc. r=xpcom-reviewers,erahm
Simon Giesecke <sgiesecke@mozilla.com> - Thu, 09 Apr 2020 17:31:08 +0000 - rev 523770
Push 37311 by aciure@mozilla.com at Tue, 14 Apr 2020 15:44:38 +0000
Bug 1628697 - nsTArray::AppendElements(mozilla::Span<const Item> aSpan) should use ActualAlloc. r=xpcom-reviewers,erahm Differential Revision: https://phabricator.services.mozilla.com/D70381
94eb0aee220a6d072e1617d98f6d358a24928ed7: Bug 1619840 - Remove `fix_{linux,macosx}_stack.py` and `fix_stack_using_bpsyms.py`. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 08 Apr 2020 06:55:54 +0000 - rev 523730
Push 37309 by opoprus@mozilla.com at Tue, 14 Apr 2020 04:09:24 +0000
Bug 1619840 - Remove `fix_{linux,macosx}_stack.py` and `fix_stack_using_bpsyms.py`. r=erahm This commit removes `test_fix_stack_using_bpsyms.py`. That test can't easily be modified to work with `fix_stacks.py` because it relies on internal implementation details of `fix_stack_using_bpsym.py`. The unit testing done in the `fix-stacks` repo provides test coverage that is as good or better. Differential Revision: https://phabricator.services.mozilla.com/D66924
e535377b84da6ada6c27dc77857a1607ff8adbf6: Bug 1629342 - Print string stats on process exit only if there is a leak. r=erahm,mccr8
Cameron McCormack <cam@mcc.id.au> - Sun, 12 Apr 2020 17:23:12 +0000 - rev 523511
Push 37306 by apavel@mozilla.com at Mon, 13 Apr 2020 03:45:42 +0000
Bug 1629342 - Print string stats on process exit only if there is a leak. r=erahm,mccr8 I don't think anyone particularly cares about these stats. Differential Revision: https://phabricator.services.mozilla.com/D70638
2aa65fbb4aee1d9576bf62f177a53fd0c251b32a: Bug 1622701 - install `fix-stacks` on `linux{,64}-gcp/debug` jobs. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 09 Apr 2020 20:54:07 +0000 - rev 523259
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1622701 - install `fix-stacks` on `linux{,64}-gcp/debug` jobs. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D70296
698a0b5420c6dbac37b5d53ed988dcfe0b843f22: Bug 1626272 - Disable stack fixing on Windows awsy-dmd jobs. r=erahm,perftest-reviewers,sparky
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 07 Apr 2020 21:19:52 +0000 - rev 522778
Push 37294 by apavel@mozilla.com at Wed, 08 Apr 2020 03:36:50 +0000
Bug 1626272 - Disable stack fixing on Windows awsy-dmd jobs. r=erahm,perftest-reviewers,sparky Unfortunate, but it gets us back to where we were before `fix_stacks.py` came along, and getting it working isn't worth the effort right now. Differential Revision: https://phabricator.services.mozilla.com/D69928
916894e8b8fcd020e215a1bdcf5f935944e27a8c: Bug 1626272 - Make `fix-stacks` initialization eager. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 06 Apr 2020 19:49:54 +0000 - rev 522490
Push 37290 by aciure@mozilla.com at Tue, 07 Apr 2020 03:53:09 +0000
Bug 1626272 - Make `fix-stacks` initialization eager. r=erahm Currently AWSY-with-DMD doesn't work on Windows. This is because `fix-stacks` is initialized lazily, and by the time the initialization happens some file descriptors for files are open, and that leads to some major Python2-on-Windows sadness as described in the big comment in the commit. To fix the problem, this commit adds an `init` function to `fix_stacks.py` so that `fix-stacks` can be initialized eagerly, hopefully before any file descriptors for files are open. For `dmd.py`, other than fixing the AWSY problems, this has little effect, because `fix-stacks` is always initialized. For `utils.py`, which is used to process the output of most tests, this has a more noticeable effect: the `fix-stacks` process is always spawned, rather than being spawned only when needed. If no stack traces appear in the test output, this means that `fix-stacks` is spawned unnecessarily. But it's cheap to spawn; the expensive part only happens when stack traces start getting fixed. So I think this change in behaviour is acceptable. The commit also renames some things to more standard Python style, e.g. `json_mode` instead of `jsonMode`. Differential Revision: https://phabricator.services.mozilla.com/D69478
a29e74d540d3a57598759eb03b46aa2322b819f5: Bug 1626272 - Reduce indentation in fixStackTraces. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 03 Apr 2020 20:59:01 +0000 - rev 522167
Push 37284 by nerli@mozilla.com at Sun, 05 Apr 2020 21:25:22 +0000
Bug 1626272 - Reduce indentation in fixStackTraces. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D69477
13930d078e015f09442d845d06a378a5bbf6122c: Bug 1626804 - Clarify about:memory's `explicit` description. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 02 Apr 2020 00:58:45 +0000 - rev 521711
Push 37274 by dvarga@mozilla.com at Thu, 02 Apr 2020 09:51:45 +0000
Bug 1626804 - Clarify about:memory's `explicit` description. r=erahm This commit clarifies that only some OS-level allocations are covered; the old wording made it sound like they all were. It also moves the allocator-level allocations first in the list, because they're more common. Depends on D43842 Differential Revision: https://phabricator.services.mozilla.com/D69287
f13d0ebd53f9c20936a96547697b83ac8b999c69: Bug 1625332 - Update `fix-stacks`. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 26 Mar 2020 23:28:54 +0000 - rev 520663
Push 37255 by cbrindusan@mozilla.com at Fri, 27 Mar 2020 09:48:05 +0000
Bug 1625332 - Update `fix-stacks`. r=erahm This gets two improvements: - Some useful notes on error messages that are likely to occur on automation, which should help sheriffs. - The update to `symbolic` v7.1.1. Differential Revision: https://phabricator.services.mozilla.com/D68479
9d6c366e7cde369c65ddb85b258dbacbf396e65e: Bug 1602717 - Re-enable stackwalking on local macOS builds. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 12 Mar 2020 22:03:19 +0000 - rev 518531
Push 37211 by malexandru@mozilla.com at Fri, 13 Mar 2020 09:53:22 +0000
Bug 1602717 - Re-enable stackwalking on local macOS builds. r=erahm Now that `fix_stacks.py` is being used instead of `fix_macosx_stack.py`, stack-fixing time has dropped from about 14 minutes to about 30 seconds on my new MacBook Pro. Also, print a warning about stacks not being fixed if `MOZ_DISABLE_STACK_FIX` is set. This warning shows up at the start of the test run. Also, print a warning about stack fixing slowness, because 30 seconds is long enough to possibly be surprising. This warning shows up just before the first stack frame is fixed, like this: ``` Assertion failure: false (BEEP BOOP), at /home/njn/moz/au3/dom/base/nsGlobalWindowOuter.cpp:1342 Initializing stack-fixing for the first stack frame, this may take a while... #01: nsGlobalWindowOuter::nsGlobalWindowOuter(unsigned long) (/home/njn/moz/au3/dom/base/nsGlobalWindowOuter.cpp:1342) #02: ... ``` Differential Revision: https://phabricator.services.mozilla.com/D65676
ffd615bf92ddb28a01b881d14126fc139ebf7880: Bug 1619837 - Add a missing `fix-stacks` dependency for the `py2(ref)` test job. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 12 Mar 2020 03:45:30 +0000 - rev 518295
Push 37207 by opoprus@mozilla.com at Thu, 12 Mar 2020 09:33:12 +0000
Bug 1619837 - Add a missing `fix-stacks` dependency for the `py2(ref)` test job. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D66522
e5cd778db960970ddccbca5e1f016eb18d815125: Bug 1619837 - Add a missing `fix-stacks` dependency for the `py2(mch)` test job. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 12 Mar 2020 01:39:15 +0000 - rev 518285
Push 37207 by opoprus@mozilla.com at Thu, 12 Mar 2020 09:33:12 +0000
Bug 1619837 - Add a missing `fix-stacks` dependency for the `py2(mch)` test job. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D66511
a6baed370a03bfd798a25e3601d01ba300f9823a: Bug 1619837 - Make `fix_stacks.py` more like `fix_linux_stacks.py`. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 10 Mar 2020 06:19:21 +0000 - rev 517965
Push 37203 by ccoroiu@mozilla.com at Wed, 11 Mar 2020 04:11:49 +0000
Bug 1619837 - Make `fix_stacks.py` more like `fix_linux_stacks.py`. r=erahm Specifically: - handle input that doesn't end in a newline; - only pass lines that match the regexp to `fix-stacks`. These changes are needed for `utils.py` to use `fix_stacks.py` without problems. Differential Revision: https://phabricator.services.mozilla.com/D65944
54e082ba0922011f61610fa470433cfef2181539: Bug 1620151 - Improve the imprecise stack matching used for `test_dmd.js`. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 05 Mar 2020 21:40:52 +0000 - rev 517148
Push 37186 by malexandru@mozilla.com at Fri, 06 Mar 2020 09:47:39 +0000
Bug 1620151 - Improve the imprecise stack matching used for `test_dmd.js`. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D65454
543b91f733211489d69d64d2de9adf87ae250191: Bug 1619230 - Use .get() in P::completedNamedCharacterReference(mViewSource). r=erahm
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 02 Mar 2020 17:45:31 +0000 - rev 516445
Push 37173 by btara@mozilla.com at Mon, 02 Mar 2020 21:27:32 +0000
Bug 1619230 - Use .get() in P::completedNamedCharacterReference(mViewSource). r=erahm Differential Revision: https://phabricator.services.mozilla.com/D64927
748266807263f116a56cc7eff89fd505b3323782: Bug 1618488 - Add .get() to mViewSource in calls to P::transition in the tokenizer. r=erahm
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 27 Feb 2020 19:28:46 +0000 - rev 516065
Push 37166 by malexandru@mozilla.com at Fri, 28 Feb 2020 16:19:40 +0000
Bug 1618488 - Add .get() to mViewSource in calls to P::transition in the tokenizer. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D64552
c55d7fe46e1f0ff8efb09f9e82da82ce85549574: Bug 1618720 - Generate the ThreadAllow list deterministically. r=erahm,dmajor
Mike Hommey <mh+mozilla@glandium.org> - Fri, 28 Feb 2020 00:41:47 +0000 - rev 516041
Push 37165 by aiakab@mozilla.com at Fri, 28 Feb 2020 09:24:28 +0000
Bug 1618720 - Generate the ThreadAllow list deterministically. r=erahm,dmajor Differential Revision: https://phabricator.services.mozilla.com/D64690
42d63c42c6a2ba2964ce2e53ea937a9b2e23e773: Bug 1604095 - Fix up `fix-stacks` toolchain on Mac. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 27 Feb 2020 20:07:10 +0000 - rev 515997
Push 37165 by aiakab@mozilla.com at Fri, 28 Feb 2020 09:24:28 +0000
Bug 1604095 - Fix up `fix-stacks` toolchain on Mac. r=erahm It currently is missing some cross-compilation stuff and so actually builds a Linux binary. The commit also avoids the unintentional installation of the `fix-stacks.d` file, by introducing the `EXE` variable. Differential Revision: https://phabricator.services.mozilla.com/D64528
4d34791140cb1e9a715b8c7e70cf7b4a99c36a24: Bug 1617213 - Allow dot characters in log module names. r=erahm
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 21 Feb 2020 17:37:42 +0000 - rev 515022
Push 37148 by btara@mozilla.com at Fri, 21 Feb 2020 21:49:11 +0000
Bug 1617213 - Allow dot characters in log module names. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D63693
9501c64d20b85d0de1da25fad0b91f003af78909: Bug 1604964 - Add fix-stacks toolchain. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 20 Feb 2020 20:57:32 +0000 - rev 514918
Push 37143 by aiakab@mozilla.com at Fri, 21 Feb 2020 05:56:31 +0000
Bug 1604964 - Add fix-stacks toolchain. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D57747
70fbd4edc68631d89c8d11abbc44e159544fb87f: Bug 1604964 - Remove an erroneous comment. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 18 Feb 2020 02:46:23 +0000 - rev 514917
Push 37143 by aiakab@mozilla.com at Fri, 21 Feb 2020 05:56:31 +0000
Bug 1604964 - Remove an erroneous comment. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D57746
ad6570e7d4140c077383d2e9b20cdf949adf6346: Bug 1610720 - Change moz_dispose_arena to allow to free empty arenas. r=erahm
Mike Hommey <mh+mozilla@glandium.org> - Fri, 24 Jan 2020 02:06:32 +0000 - rev 511629
Push 37053 by nbeleuzu@mozilla.com at Fri, 24 Jan 2020 21:46:30 +0000
Bug 1610720 - Change moz_dispose_arena to allow to free empty arenas. r=erahm Currently, it's expected to "lazily" dispose of the arena. That is, if the arena still has allocations, the arena is kept around. Using it for new allocations is an error, but otherwise, it's possible to free allocations from there. Once it's empty, the arena is freed too. Well, that's the idea, but that last part is not actually implemented, cf. bug 1364359. While that is still an (optionally) desirable disposal mode, other modes would be useful as well. So this bug is here to switch the current mode to something that can more easily be used for e.g. bug 1377999. The idea is to make moz_dispose_arena() free the arena immediately, and MOZ_CRASH if it's not already empty (on a besst effort basis). Differential Revision: https://phabricator.services.mozilla.com/D60635
f127766b5901650573ba1610771df460ef673c89: Bug 1610720 - Templatize the base allocator wrapper that uses a free-list. r=erahm
Mike Hommey <mh+mozilla@glandium.org> - Fri, 24 Jan 2020 02:03:37 +0000 - rev 511628
Push 37053 by nbeleuzu@mozilla.com at Fri, 24 Jan 2020 21:46:30 +0000
Bug 1610720 - Templatize the base allocator wrapper that uses a free-list. r=erahm The base_node_alloc and base_node_dealloc are wrappers for the base allocator that allow to free memory (the base allocator doesn't support freeing memory), using a free list. They are dedicated to extent_node_t objects (the only ones we currently ever need to free). We're going to need to free other types of objects, so make this more generic. Differential Revision: https://phabricator.services.mozilla.com/D60634