searching for reviewer(egao)
79349e1d98a64139c9ceaf73d6027003b5c309b2: Bug 1563860 - annotate wpt manifest to support both 10.14 and 10.14.5. r=egao
Joel Maher <jmaher@mozilla.com> - Thu, 11 Jul 2019 16:54:45 +0000 - rev 482401
Push 36280 by ncsoregi@mozilla.com at Thu, 11 Jul 2019 23:02:03 +0000
Bug 1563860 - annotate wpt manifest to support both 10.14 and 10.14.5. r=egao annotate wpt manifest to support both 10.14 and 10.14.5 Differential Revision: https://phabricator.services.mozilla.com/D37728
03b0baec965a4f6d84ed0bddfb7854d65635da43: Bug 1561119 - adjust test expectations for osx 10.14.5. r=egao
Joel Maher <jmaher@mozilla.com> - Mon, 24 Jun 2019 23:42:35 +0000 - rev 479984
Push 36197 by aciure@mozilla.com at Tue, 25 Jun 2019 09:39:03 +0000
Bug 1561119 - adjust test expectations for osx 10.14.5. r=egao adjust test expectations for osx 10.14.5 Differential Revision: https://phabricator.services.mozilla.com/D35729
1580e2e6a87bc558470a7d85f00d4b5a60e56e53: Bug 1557123 - migrate web-platform-tests and web-platform-tests-reftest to osx 10.14. r=egao
Joel Maher <jmaher@mozilla.com> - Fri, 07 Jun 2019 22:44:31 +0000 - rev 477917
Push 36127 by nbeleuzu@mozilla.com at Sat, 08 Jun 2019 09:39:25 +0000
Bug 1557123 - migrate web-platform-tests and web-platform-tests-reftest to osx 10.14. r=egao migrate web-platform-tests and web-platform-test-reftests to osx 10.14. Differential Revision: https://phabricator.services.mozilla.com/D33833
0cff8ca10f71d17849911991673fdd9db9edc17b: Bug 1557123 - migrate web-platform-tests and web-platform-test-reftests to osx 10.14. r=egao
Edwin Gao <egao@mozilla.com> - Thu, 06 Jun 2019 18:43:08 +0000 - rev 477683
Push 36121 by dvarga@mozilla.com at Fri, 07 Jun 2019 09:47:19 +0000
Bug 1557123 - migrate web-platform-tests and web-platform-test-reftests to osx 10.14. r=egao migrate web-platform-tests and web-platform-test-reftests to osx 10.14. Differential Revision: https://phabricator.services.mozilla.com/D33833
4ff8006a80f54f8d5f6aebcbd89867e53a30f709: Bug 1557123 - migrate web-platform-tests and web-platform-test-reftests to osx 10.14. r=egao
Joel Maher <jmaher@mozilla.com> - Wed, 05 Jun 2019 20:22:14 +0000 - rev 477019
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1557123 - migrate web-platform-tests and web-platform-test-reftests to osx 10.14. r=egao migrate web-platform-tests and web-platform-test-reftests to osx 10.14. Differential Revision: https://phabricator.services.mozilla.com/D33833
cd91fb6b59d935a301845493be323bb5f07c2e55: Bug 1556767 - Increase max-run-time for linux64 ccov jsreftest; r=egao
Geoff Brown <gbrown@mozilla.com> - Tue, 04 Jun 2019 15:53:28 +0000 - rev 476834
Push 36108 by nbeleuzu@mozilla.com at Tue, 04 Jun 2019 21:42:40 +0000
Bug 1556767 - Increase max-run-time for linux64 ccov jsreftest; r=egao These tasks normally run in 45 to 55 minutes; if they exceed 60 minutes, the task fails. Failures are not frequent, but I would like to avoid them. We could increase chunks, but it looks like we have handled the other ccov cases like this, by increasing the max-run-time. Differential Revision: https://phabricator.services.mozilla.com/D33656
4796f71f2be46c812583129640ccc599bae1a865: Bug 1555458 - Stop android-hw debug jittest/jsreftest on integration branches; r=egao
Geoff Brown <gbrown@mozilla.com> - Thu, 30 May 2019 17:29:24 +0000 - rev 476242
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1555458 - Stop android-hw debug jittest/jsreftest on integration branches; r=egao Incremental effort to improve android-hw device availability: Stop running android-hw debug jsreftest and jittest on integration branches. Also, remove the option for android-hw opt jittest on try. opt is a nice alternative to pgo on try in general, but the risk of accidental (unnecessary) inclusion in try pushes makes this a luxury we cannot afford on android-hw. Differential Revision: https://phabricator.services.mozilla.com/D33156
bb9ac8e8b8400b72f599e60d31c956168a0788d8: Bug 1552580 - Increase Android 4.3 debug xpcshell test chunks from 8 to 12; r=egao
Geoff Brown <gbrown@mozilla.com> - Fri, 17 May 2019 21:04:31 +0000 - rev 474387
Push 36032 by dluca@mozilla.com at Sat, 18 May 2019 10:23:48 +0000
Bug 1552580 - Increase Android 4.3 debug xpcshell test chunks from 8 to 12; r=egao These chunks are quite out of balance: Probably there are some very long running tests in xpcshell-7 with 8 chunks. Even so, I think the easiest way to avoid timeouts is to return to 12 chunks. Differential Revision: https://phabricator.services.mozilla.com/D31685
8214de6fc33eebc2ae4f665107c4f306d407993b: Bug 1549763 - Skip perma-failing jittest bug1161762.js on aarch64; r=egao
Geoff Brown <gbrown@mozilla.com> - Tue, 07 May 2019 20:35:08 +0000 - rev 472968
Push 35983 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:38:51 +0000
Bug 1549763 - Skip perma-failing jittest bug1161762.js on aarch64; r=egao Differential Revision: https://phabricator.services.mozilla.com/D30253
8cd6ecc6fc399dd83234f45dab2e9c9159a693c0: Bug 1548066 - Fix web-platform-tests on windows/aarch64. r=egao
Joel Maher <jmaher@mozilla.com> - Tue, 30 Apr 2019 19:12:19 +0000 - rev 472010
Push 35945 by ccoroiu@mozilla.com at Wed, 01 May 2019 04:21:12 +0000
Bug 1548066 - Fix web-platform-tests on windows/aarch64. r=egao Fix web-platform-tests on windows/aarch64 Differential Revision: https://phabricator.services.mozilla.com/D29386
ce6ffba148dab49f34c9ff2dd25a6864144499ae: Bug 1544062 - Run windows/aarch64 xpcshell in 3 chunks; r=egao
Geoff Brown <gbrown@mozilla.com> - Fri, 12 Apr 2019 18:08:23 +0000 - rev 469309
Push 35861 by btara@mozilla.com at Fri, 12 Apr 2019 21:56:33 +0000
Bug 1544062 - Run windows/aarch64 xpcshell in 3 chunks; r=egao Reduce chunks from 8 to 3. Each test task has at least a couple of minutes of overhead, so fewer chunks improves overall efficiency. At 3 chunks, each one still completes reasonably quickly (less than 20 minutes). Differential Revision: https://phabricator.services.mozilla.com/D27339
4624c850f711417ae3cc95f3e69ce4cb6c07f70b: Bug 1367092 - [flake8] Use a blacklist instead of a whitelist, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 22 Feb 2019 21:25:50 +0000 - rev 460907
Push 35613 by nerli@mozilla.com at Tue, 26 Feb 2019 03:52:35 +0000
Bug 1367092 - [flake8] Use a blacklist instead of a whitelist, r=egao This ensures that the default for new python files is to be linted by flake8. Depends on D20496 Differential Revision: https://phabricator.services.mozilla.com/D20497
41fdb372e22cf213eb76b966e357772f89a77710: Bug 1367092 - [flake8] Take exclusion handling away from flake8, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 22 Feb 2019 22:16:57 +0000 - rev 460906
Push 35613 by nerli@mozilla.com at Tue, 26 Feb 2019 03:52:35 +0000
Bug 1367092 - [flake8] Take exclusion handling away from flake8, r=egao The motivations for this are: 1) Apply global excludes. This merges the exclusion rules defined in tools/lint/mach_commands.py with the ones in .flake8. 2) Improve performance. Switching to a blacklist will result in a much longer runtime for linting the entire tree and flake8 handles exclusions incredibly slowly. Without this patch (and the blacklist change applied), I gave up waiting after 30 minutes. With this patch, it takes 30 seconds. Depends on D20495 Differential Revision: https://phabricator.services.mozilla.com/D20496
cd46126bc5924f041570d7adc889c394921930ba: Bug 1367092 - [flake8] Run flake8 programmatically instead of via a subprocess, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 22 Feb 2019 21:14:06 +0000 - rev 460905
Push 35613 by nerli@mozilla.com at Tue, 26 Feb 2019 03:52:35 +0000
Bug 1367092 - [flake8] Run flake8 programmatically instead of via a subprocess, r=egao This is required for a future commit which will monkeypatch flake8's configuration to fit our needs. But it has a couple nice benefits anyway: 1. Less process overhead. 2. Less complexity around handling SIGINT. 3. Less complexity in the code. Depends on D20494 Differential Revision: https://phabricator.services.mozilla.com/D20495
ba172b704def575675d1303eef8f0b1c8ca33491: Bug 1367092 - [lint] Move py2/py3 linter's exludes logic into mozlint, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 22 Feb 2019 21:18:22 +0000 - rev 460904
Push 35613 by nerli@mozilla.com at Tue, 26 Feb 2019 03:52:35 +0000
Bug 1367092 - [lint] Move py2/py3 linter's exludes logic into mozlint, r=egao This will be re-used by the flake8 linter, so moving it into mozlint for re-useability. Depends on D20493 Differential Revision: https://phabricator.services.mozilla.com/D20494
f96c1460ffc09ef61bf3e2c93bfda21cdb86fb2f: Bug 1515746 - [flake8] Unsupport subdir .flake8 files and use new 'per-file-ignores' config instead, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 07 Feb 2019 20:17:02 +0000 - rev 457681
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1515746 - [flake8] Unsupport subdir .flake8 files and use new 'per-file-ignores' config instead, r=egao This removes all .flake8 files except for the one at the root of the repo. Instead we use the new 'per-file-ignores' config introduced in 3.7. To ignore specific errors in a subdirectory, add a line like this to the root .flake8: [per-file-ignores] path/to/subdir/*: E100, F200, ... The reasons for this change are: 1. Unblock flake8 blacklist (bug 1367092). 2. Simplify configuration and code. 3. Encourage more consistent styling. 4. Improve performance. 5. Greater editor consistency. Differential Revision: https://phabricator.services.mozilla.com/D18354
3c7c50fba28399ae0d1a3812e5088cde55aacd8e: Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 07 Feb 2019 20:16:45 +0000 - rev 457680
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao This bumps flake8 to version 3.7.5. This also ignores the new lint rules that were added in the new versions. These rules are de-marked via comment so we know that they should be enabled at some point (as opposed to the other rules that are (presumably) ignored intentionally. Differential Revision: https://phabricator.services.mozilla.com/D18353
ba9e0f7f49a3b4844122676de241dc2ce6671e22: Bug 1515746 - [lint] Remove duplicate flake8 implementation, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 07 Feb 2019 20:16:36 +0000 - rev 457679
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1515746 - [lint] Remove duplicate flake8 implementation, r=egao Somehow we have two copies of the flake8 linter implementation: - tools/lint/python/__init__.py - tools/lint/python/flake8.py I'm not really sure how this happened, but the latter is the one that we use, so let's remove the former. It wasn't really affecting anything, though could have caused confusion to people looking to modify the lint integration. Differential Revision: https://phabricator.services.mozilla.com/D18352
86e072fc085e8b990d879feb95c6b62941028db5: Bug 1499510 - [mozlint] Fix regression to |mach lint --edit| when using vim, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 17 Oct 2018 20:19:37 +0000 - rev 441764
Push 34876 by ebalazs@mozilla.com at Thu, 18 Oct 2018 10:19:51 +0000
Bug 1499510 - [mozlint] Fix regression to |mach lint --edit| when using vim, r=egao Differential Revision: https://phabricator.services.mozilla.com/D8905
b7e586708ecccea803d5c4b77e3f9d7bbcb912f6: Bug 1494069 - [mozlint] Collapse exclude paths into their smallest possible set, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 12 Oct 2018 15:57:42 +0000 - rev 440909
Push 34841 by aciure@mozilla.com at Sat, 13 Oct 2018 09:35:03 +0000
Bug 1494069 - [mozlint] Collapse exclude paths into their smallest possible set, r=egao Often we specify globs in our exclude patterns, e.g: exclude: - **/node_modules - obj* However, these globs get expanded out to *every* file that matches them. This can sometimes be thousands or even tens of thousands of files. We then pass these paths on to the underlying linters and tell them to exclude them all. This causes a lot of overhead and slows down performance. This commit implements a "collapse" function. Given a set of paths, it'll collapse them into the smallest set of parent directories that contain the original set, and that don't contain any extra files. For example, given a directory structure like this: a -- foo.txt -- b -- bar.txt -- baz.txt -- c -- ham.txt -- d -- spam.txt Then the following will happen: >>> collapse(['a/foo.txt', 'a/b/bar.txt', 'a/c/ham.txt', 'a/c/d/spam.txt']) ['a/foo.txt', 'b/bar.txt', 'c'] Since all files under directory 'c' are specified by the original set (both 'c/ham.txt' and 'c/d/spam.txt'), we can collapse it down to just 'c'. However not all files under 'b' are specified (we're missing 'a/b/baz.txt'), so we can't collapse 'b' (and by extension also can't collapse 'a'). If we had included 'a/b/baz.txt': >>> collapse(['a/foo.txt', 'a/b/bar.txt', 'a/b/baz.txt', 'a/c/ham.txt', 'a/c/d/spam.txt']) ['a'] In both cases, the smallest set of paths that contains the original set (and only the original set) is computed. The collapse function has a little bit of overhead but it's not too bad. For example collapsing all files matched by '**/node_modules' takes ~0.015s. Collapsing two full objdirs, takes ~0.6s. But a follow up commit is planned to make sure we stop using 'obj*' to reduce that overhead. Depends on D7738 Differential Revision: https://phabricator.services.mozilla.com/D7739
fe0fb280dbfc24091da4fd2627c6d514fbbab13f: Bug 1494069 - [mozlint] Collapse exclude paths into their smallest possible set, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 09 Oct 2018 19:26:23 +0000 - rev 440601
Push 34827 by toros@mozilla.com at Thu, 11 Oct 2018 03:53:09 +0000
Bug 1494069 - [mozlint] Collapse exclude paths into their smallest possible set, r=egao Often we specify globs in our exclude patterns, e.g: exclude: - **/node_modules - obj* However, these globs get expanded out to *every* file that matches them. This can sometimes be thousands or even tens of thousands of files. We then pass these paths on to the underlying linters and tell them to exclude them all. This causes a lot of overhead and slows down performance. This commit implements a "collapse" function. Given a set of paths, it'll collapse them into the smallest set of parent directories that contain the original set, and that don't contain any extra files. For example, given a directory structure like this: a -- foo.txt -- b -- bar.txt -- baz.txt -- c -- ham.txt -- d -- spam.txt Then the following will happen: >>> collapse(['a/foo.txt', 'a/b/bar.txt', 'a/c/ham.txt', 'a/c/d/spam.txt']) ['a/foo.txt', 'b/bar.txt', 'c'] Since all files under directory 'c' are specified by the original set (both 'c/ham.txt' and 'c/d/spam.txt'), we can collapse it down to just 'c'. However not all files under 'b' are specified (we're missing 'a/b/baz.txt'), so we can't collapse 'b' (and by extension also can't collapse 'a'). If we had included 'a/b/baz.txt': >>> collapse(['a/foo.txt', 'a/b/bar.txt', 'a/b/baz.txt', 'a/c/ham.txt', 'a/c/d/spam.txt']) ['a'] In both cases, the smallest set of paths that contains the original set (and only the original set) is computed. The collapse function has a little bit of overhead but it's not too bad. For example collapsing all files matched by '**/node_modules' takes ~0.015s. Collapsing two full objdirs, takes ~0.6s. But a follow up commit is planned to make sure we stop using 'obj*' to reduce that overhead. Depends on D7738 Differential Revision: https://phabricator.services.mozilla.com/D7739
a80cb43e8d5ea8e5227ea335b65ab7b7ebae3ba8: Bug 1448417 - [mozlint] Remove ability to specify globs in an 'include' directive, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 25 Sep 2018 18:30:23 +0000 - rev 438194
Push 34712 by aiakab@mozilla.com at Wed, 26 Sep 2018 12:35:23 +0000
Bug 1448417 - [mozlint] Remove ability to specify globs in an 'include' directive, r=egao There is only a single linter (test-disable.yml) that uses a glob in any include path, and that usage is easily replaced by using the 'extensions' key instead. Since globs in include directives aren't very useful, let's disallow them. This will allow us to simplify the 'filterpaths' logic quite substantially and make future refactorings in this area easier. Differential Revision: https://phabricator.services.mozilla.com/D6798
a79ad75c22c8bb5a631f904f25ef81048a065a81: Bug 1492161 - Add raptor-gdocs test to inbound/autoland tier 2 r=egao
Rob Wood <rwood@mozilla.com> - Tue, 18 Sep 2018 19:24:23 +0000 - rev 437009
Push 34667 by aiakab@mozilla.com at Wed, 19 Sep 2018 02:13:23 +0000
Bug 1492161 - Add raptor-gdocs test to inbound/autoland tier 2 r=egao Differential Revision: https://phabricator.services.mozilla.com/D6185
0b14528bab1af20f96cfbb336d762ad645d83c5b: Bug 1486866 - [mozlint] Refactor test_include_exclude into parametrized test cases, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Mon, 17 Sep 2018 15:36:35 +0000 - rev 436760
Push 34659 by btara@mozilla.com at Mon, 17 Sep 2018 21:55:13 +0000
Bug 1486866 - [mozlint] Refactor test_include_exclude into parametrized test cases, r=egao This will make it easier to add new test cases in the future. It'll also make it easier to print debug, as only the output for each specific test case will be printed on failure. Differential Revision: https://phabricator.services.mozilla.com/D5862
5cd83e5b3ea002480c8a6a53f1706cff4808f8a9: Bug 1461422 - Remove raptor/setup.py r=egao
Rob Wood <rwood@mozilla.com> - Wed, 05 Sep 2018 20:19:43 +0000 - rev 434973
Push 34584 by apavel@mozilla.com at Thu, 06 Sep 2018 04:37:07 +0000
Bug 1461422 - Remove raptor/setup.py r=egao Differential Revision: https://phabricator.services.mozilla.com/D5076