searching for reviewer(eeejay)
36d571eb919891dda1c2a2c9f6ba11ce570b36f7: Bug 1554831: For out-of-process iframe documents on Windows, send the a11y emulated window (if any) to the content process. r=eeejay
James Teh <jteh@mozilla.com> - Wed, 29 May 2019 04:37:28 +0000 - rev 476724
Push 36106 by btara@mozilla.com at Tue, 04 Jun 2019 16:04:27 +0000
Bug 1554831: For out-of-process iframe documents on Windows, send the a11y emulated window (if any) to the content process. r=eeejay If window emulation is enabled, an out-of-process iframe document should use the same emulated window as its embedder. Previously, we were setting this on DocAccessibleParent, but we weren't sending it to content to make it available on DocAccessibleChild. This meant that accessibles in out-of-process iframe documents were reporting the wrong window handle. Differential Revision: https://phabricator.services.mozilla.com/D32788
38c2478a4825044a8c33bb72539b42fbdda833fc: Bug 1553706: Fix IAccessible::accChild in the parent process for out-of-process iframes. r=eeejay
James Teh <jteh@mozilla.com> - Mon, 03 Jun 2019 06:03:10 +0000 - rev 476692
Push 36104 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:45:41 +0000
Bug 1553706: Fix IAccessible::accChild in the parent process for out-of-process iframes. r=eeejay It must be possible to retrieve any accessible by calling IAccessible::accChild on the RootAccessible (in the parent process) with the unique id of the desired accessible. Among other things, this is the way accessibility events are targeted on Windows. Previously, this code only searched remote documents at the top level of the tree. In order to support out-of-process iframes, it must now also search embedded documents at the top level of their content process. As part of this, the MSAA id must be set for out-of-process iframe documents, just as it is for top level documents. This was already being sent from the content process, but previously, we didn't store this in the parent process. Differential Revision: https://phabricator.services.mozilla.com/D32417
379dc9cb2ae9fa7ceea647a35fcedb86fafb3bba: Bug 1543313 part 3: For out-of-process iframes on Windows, send the embedder accessible COM proxy to be used as the parent of the embedded document. r=eeejay,yzen
James Teh <jteh@mozilla.com> - Mon, 03 Jun 2019 14:29:37 +0000 - rev 476691
Push 36104 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:45:41 +0000
Bug 1543313 part 3: For out-of-process iframes on Windows, send the embedder accessible COM proxy to be used as the parent of the embedded document. r=eeejay,yzen Aside from the parent being needed by the client, this is also important because events from the embedded document are deferred until the parent COM proxy is received. As part of this, we no longer try to send the parent COM proxy during construction of an OuterDocAccessible in the parent process. This was previously a no-op anyway, as DocAccessibleParent::SendParentCOMProxy called DocAccessible::GetAccessible for the frame element, which would have returned null because the accessible isn't bound to the document until *after* it is constructed. Changing this to directly pass the OuterDocAccessible was causing assertions in content processes, since it sometimes meant the parent COM proxy was sent twice, which is precisely what the assertion is protecting against. Instead, the parent proxy is sent in Browserparent::RecvPDocAccessibleConstructor as it always was. Differential Revision: https://phabricator.services.mozilla.com/D32284
ef50240bdb1f11199b00f6cc30bd65ddea364a78: Bug 1543313 part 2: Support getting an IAccessible for a ProxyAccessible in an out-of-process iframe. r=eeejay
James Teh <jteh@mozilla.com> - Fri, 31 May 2019 03:27:18 +0000 - rev 476690
Push 36104 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:45:41 +0000
Bug 1543313 part 2: Support getting an IAccessible for a ProxyAccessible in an out-of-process iframe. r=eeejay Previously, a COM proxy was only sent from content for top level documents. Now, a COM proxy is also sent (and needed) for out-of-process iframe documents. This change adjusts GetProxiedAccessibleInSubtree accordingly. Differential Revision: https://phabricator.services.mozilla.com/D32283
3c619a698b9627c7cc6f072c2ec6c547df33f928: Bug 1543313 part 1: Allow identification and retrieval of DocAccessibleParents at the top level of their content process. r=eeejay
James Teh <jteh@mozilla.com> - Fri, 31 May 2019 03:27:26 +0000 - rev 476689
Push 36104 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:45:41 +0000
Bug 1543313 part 1: Allow identification and retrieval of DocAccessibleParents at the top level of their content process. r=eeejay DocAccessibleParent already has IsTopLevel(), which identifies a document at the top level of the hierarchy; i.e. it has no parents. Now that we have out-of-process iframes, we need to be able to identify and retrieve documents at the top level of their content process, even if they are embedded by another remote document. DocAccessibleParent::IsTopLevelInContentProcess() has been introduced to achieve this. BrowserParent::GetTopLevelDocAccessible() now uses this instead of IsTopLevel(), since we want to be able to get the top DocAccessibleParent even for a BrowserParent for an out-of-process iframe. Differential Revision: https://phabricator.services.mozilla.com/D32282
1a8bea02205d138e7881bcf63aff985ae1f2d64d: Bug 1553706: Fix IAccessible::accChild in the parent process for out-of-process iframes. r=eeejay
James Teh <jteh@mozilla.com> - Wed, 29 May 2019 00:59:53 +0000 - rev 476308
Push 36092 by archaeopteryx@coole-files.de at Fri, 31 May 2019 17:03:46 +0000
Bug 1553706: Fix IAccessible::accChild in the parent process for out-of-process iframes. r=eeejay It must be possible to retrieve any accessible by calling IAccessible::accChild on the RootAccessible (in the parent process) with the unique id of the desired accessible. Among other things, this is the way accessibility events are targeted on Windows. Previously, this code only searched remote documents at the top level of the tree. In order to support out-of-process iframes, it must now also search embedded documents at the top level of their content process. As part of this, the MSAA id must be set for out-of-process iframe documents, just as it is for top level documents. This was already being sent from the content process, but previously, we didn't store this in the parent process. Differential Revision: https://phabricator.services.mozilla.com/D32417
15f3e6bb3ba913aa9d67687edd59899873b671ae: Bug 1543313 part 3: For out-of-process iframes on Windows, send the embedder accessible COM proxy to be used as the parent of the embedded document. r=eeejay
James Teh <jteh@mozilla.com> - Fri, 24 May 2019 06:14:24 +0000 - rev 476307
Push 36092 by archaeopteryx@coole-files.de at Fri, 31 May 2019 17:03:46 +0000
Bug 1543313 part 3: For out-of-process iframes on Windows, send the embedder accessible COM proxy to be used as the parent of the embedded document. r=eeejay Aside from the parent being needed by the client, this is also important because events from the embedded document are deferred until the parent COM proxy is received. Differential Revision: https://phabricator.services.mozilla.com/D32284
30b106088985198cfdc755e09173bd663ca657c7: Bug 1543313 part 2: Support getting an IAccessible for a ProxyAccessible in an out-of-process iframe. r=eeejay
James Teh <jteh@mozilla.com> - Thu, 23 May 2019 20:13:00 +0000 - rev 476306
Push 36092 by archaeopteryx@coole-files.de at Fri, 31 May 2019 17:03:46 +0000
Bug 1543313 part 2: Support getting an IAccessible for a ProxyAccessible in an out-of-process iframe. r=eeejay Previously, a COM proxy was only sent from content for top level documents. Now, a COM proxy is also sent (and needed) for out-of-process iframe documents. This change adjusts GetProxiedAccessibleInSubtree accordingly. Differential Revision: https://phabricator.services.mozilla.com/D32283
85d11dab6b63d60a229f3dc42734bc7d0ab27fbd: Bug 1543313 part 1: Allow identification and retrieval of DocAccessibleParents at the top level of their content process. r=eeejay
James Teh <jteh@mozilla.com> - Thu, 23 May 2019 20:00:31 +0000 - rev 476305
Push 36092 by archaeopteryx@coole-files.de at Fri, 31 May 2019 17:03:46 +0000
Bug 1543313 part 1: Allow identification and retrieval of DocAccessibleParents at the top level of their content process. r=eeejay DocAccessibleParent already has IsTopLevel(), which identifies a document at the top level of the hierarchy; i.e. it has no parents. Now that we have out-of-process iframes, we need to be able to identify and retrieve documents at the top level of their content process, even if they are embedded by another remote document. DocAccessibleParent::IsTopLevelInContentProcess() has been introduced to achieve this. BrowserParent::GetTopLevelDocAccessible() now uses this instead of IsTopLevel(), since we want to be able to get the top DocAccessibleParent even for a BrowserParent for an out-of-process iframe. Differential Revision: https://phabricator.services.mozilla.com/D32282
bb49389d34ba661c503f8e5c3c88807c18fe2320: Bug 1543307: For out-of-process iframes on Windows, return the embedded document as a child of the OuterDocAccessible. r=eeejay
James Teh <jteh@mozilla.com> - Thu, 23 May 2019 19:54:37 +0000 - rev 476167
Push 36087 by malexandru@mozilla.com at Thu, 30 May 2019 09:44:16 +0000
Bug 1543307: For out-of-process iframes on Windows, return the embedded document as a child of the OuterDocAccessible. r=eeejay Windows accessibility clients talk directly to the content process via COM. In order to expose an OOP iframe document accessible as a child of the embedder iframe accessible via COM, the embedder process needs a COM proxy for the iframe document accessible. This is exposed on the embedder's BrowserBridgeChild, so we can use this when a client asks for the child of the OuterDocAccessible. Differential Revision: https://phabricator.services.mozilla.com/D32281
aa4c140e21929e3efcdfd69ad8aba2aacc508a62: Bug 1543298 part 3: For out-of-process iframes, send the embedded document accessible's COM proxy to the embedder. r=eeejay
James Teh <jteh@mozilla.com> - Fri, 24 May 2019 00:19:51 +0000 - rev 476166
Push 36087 by malexandru@mozilla.com at Thu, 30 May 2019 09:44:16 +0000
Bug 1543298 part 3: For out-of-process iframes, send the embedded document accessible's COM proxy to the embedder. r=eeejay This will be later exposed as a child of the embedder OuterDocAccessible. Differential Revision: https://phabricator.services.mozilla.com/D32280
02b71771b27b0e2955b1a4692ffa14834333135a: Bug 1543298 part 2: Add PBrowserBridge::SetEmbeddedDocAccessibleCOMProxy so the parent can send the child the COM proxy for the embedded document accessible. r=eeejay,nika
James Teh <jteh@mozilla.com> - Fri, 24 May 2019 18:49:31 +0000 - rev 476165
Push 36087 by malexandru@mozilla.com at Thu, 30 May 2019 09:44:16 +0000
Bug 1543298 part 2: Add PBrowserBridge::SetEmbeddedDocAccessibleCOMProxy so the parent can send the child the COM proxy for the embedded document accessible. r=eeejay,nika Differential Revision: https://phabricator.services.mozilla.com/D32279
eed17a01f44fd2477e6acf2f9ff7d17c1a6a2c6b: Bug 1543298 part 1: Add a stub AccessibleWrap used in a Windows content process for an embedded document residing in another content process. r=eeejay
James Teh <jteh@mozilla.com> - Thu, 23 May 2019 18:14:39 +0000 - rev 476164
Push 36087 by malexandru@mozilla.com at Thu, 30 May 2019 09:44:16 +0000
Bug 1543298 part 1: Add a stub AccessibleWrap used in a Windows content process for an embedded document residing in another content process. r=eeejay For an out-of-process iframe, we need to be able to return a remote embedder accessible as a child of an OuterDocAccessible. For parent process OuterDocAccessibles, we use the ProxyAccessible for the embedded document. In the case of out-of-process iframes, there is no ProxyAccessible for the embedded document, since the iframe is in a content process and ProxyAccessibles only exist in the parent process. Like ProxyAccessibleWrap, the only real method that gets called is GetNativeInterface, which returns a COM proxy for the document. Differential Revision: https://phabricator.services.mozilla.com/D32278
dd9b4c826f73c2d416e1342eac54fafcca5d9f4c: Bug 1543287: Add embedded out-of-process iframe DocAccessibleParent as a child of its embedder DocAccessibleParent. r=eeejay,nika
James Teh <jteh@mozilla.com> - Wed, 29 May 2019 04:36:18 +0000 - rev 476000
Push 36080 by nerli@mozilla.com at Wed, 29 May 2019 09:48:47 +0000
Bug 1543287: Add embedded out-of-process iframe DocAccessibleParent as a child of its embedder DocAccessibleParent. r=eeejay,nika For iframes in a different process to their embedder, when the embedded iframe content process tells the parent process about the iframe document, it does not have the actor for the parent document accessible, nor does it know the accessible id of the embedding iframe. However, the embedder will have previously sendt the actor and id for the embedder accessible to the parent via PBrowserBridge, so we can use that to identify the parent accessible. Differential Revision: https://phabricator.services.mozilla.com/D31395
60ecb1a2cb86d14a289a1aa71475cb1f45ff8ac5: Bug 1543282 part 3: For iframes rendered in other processes, tell the parent the embedder iframe accessible. r=eeejay
James Teh <jteh@mozilla.com> - Wed, 29 May 2019 04:42:55 +0000 - rev 475999
Push 36080 by nerli@mozilla.com at Wed, 29 May 2019 09:48:47 +0000
Bug 1543282 part 3: For iframes rendered in other processes, tell the parent the embedder iframe accessible. r=eeejay We do this when the OuterDocAccessible is constructed. This will be used later in the parent process to link the trees together when the iframe's embedded document accessible is added. Differential Revision: https://phabricator.services.mozilla.com/D31394
ac2d3dd7d7043dde4c0609e4a7947e21c7d4bd1e: Bug 1543282 part 2: Add PBrowserBridge::SetEmbedderAccessible so the child can tell the parent the embedder iframe accessible. r=nika,eeejay
James Teh <jteh@mozilla.com> - Fri, 24 May 2019 19:23:18 +0000 - rev 475998
Push 36080 by nerli@mozilla.com at Wed, 29 May 2019 09:48:47 +0000
Bug 1543282 part 2: Add PBrowserBridge::SetEmbedderAccessible so the child can tell the parent the embedder iframe accessible. r=nika,eeejay Differential Revision: https://phabricator.services.mozilla.com/D31393
094829c443f30c614689eac605e243afb7720a45: Bug 1543282 part 1: Reference counting for DocAccessibleParent. r=eeejay,nika
James Teh <jteh@mozilla.com> - Tue, 28 May 2019 17:42:59 +0000 - rev 475997
Push 36080 by nerli@mozilla.com at Wed, 29 May 2019 09:48:47 +0000
Bug 1543282 part 1: Reference counting for DocAccessibleParent. r=eeejay,nika Supporting out-of-process iframes requires us to hold onto a DocAccessibleParent in BrowserBridgeParent. However, we can't guarantee the order of cleanup between the two content processes. Therefore, we need reference counting to kee the object alive. Differential Revision: https://phabricator.services.mozilla.com/D32277
139abe6b4223b612cde09672f384f5f7fad7e53b: Bug 1549855 - remove references to e10s force-enable pref that is no longer used, r=ato,eeejay
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 17 May 2019 09:25:14 +0000 - rev 474307
Push 36027 by shindli@mozilla.com at Fri, 17 May 2019 16:24:38 +0000
Bug 1549855 - remove references to e10s force-enable pref that is no longer used, r=ato,eeejay Differential Revision: https://phabricator.services.mozilla.com/D31417
928038c23227504c1cd7dff5f5e214501bb4b688: Bug 1549855 - remove references to e10s force-enable pref that is no longer used, r=ato,snorp,eeejay
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 16 May 2019 16:21:56 +0000 - rev 474202
Push 36027 by shindli@mozilla.com at Fri, 17 May 2019 16:24:38 +0000
Bug 1549855 - remove references to e10s force-enable pref that is no longer used, r=ato,snorp,eeejay Differential Revision: https://phabricator.services.mozilla.com/D31417
97c7af33ac1db2daa8b55c9f4f7e14e342010ab7: Bug 1544584 - Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay
Imanol Fernandez <imanol@mozilla.com> - Thu, 16 May 2019 01:05:01 +0000 - rev 474026
Push 36020 by dvarga@mozilla.com at Thu, 16 May 2019 04:15:07 +0000
Bug 1544584 - Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay Some minor refactor to make it possible to remove android.speech dependencies using Proguard Differential Revision: https://phabricator.services.mozilla.com/D27612
b60e7b3407b3aa6a2110f7e09a41e1ea10a04213: Bug 1544584 - Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay
Imanol Fernandez <mortimergoro@gmail.com> - Wed, 15 May 2019 19:56:43 +0000 - rev 473995
Push 36020 by dvarga@mozilla.com at Thu, 16 May 2019 04:15:07 +0000
Bug 1544584 - Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay Some minor refactor to make it possible to remove android.speech dependencies using Proguard Differential Revision: https://phabricator.services.mozilla.com/D27612
28b9af9efee6a0317e21fa3a1971f039f53a25ed: Bug 1190882: If the focused accessible is removed from the tree, fire a11y focus on the document. r=eeejay
James Teh <jteh@mozilla.com> - Wed, 15 May 2019 00:31:16 +0000 - rev 473879
Push 36017 by rgurzau@mozilla.com at Wed, 15 May 2019 09:25:56 +0000
Bug 1190882: If the focused accessible is removed from the tree, fire a11y focus on the document. r=eeejay If the DOM focus is removed before something else is focused, the document gets DOM focus, but no blur event is fired (bug 559561). This means that no a11y focus event is fired, so clients aren't notified. This is particularly problematic for screen readers when dismissing some ARIA dialogs, as the screen reader doesn't know that focus has returned to the top level document. Differential Revision: https://phabricator.services.mozilla.com/D31024
f348b1ddb6c6aff4b1cb72dd519768c213de8b9a: Bug 1546744 - Ensure we are testing for the correct things when validating screenshots r=eeejay
Emily Toop <etoop@mozilla.com> - Fri, 26 Apr 2019 20:49:00 +0000 - rev 471778
Push 35934 by shindli@mozilla.com at Mon, 29 Apr 2019 21:53:38 +0000
Bug 1546744 - Ensure we are testing for the correct things when validating screenshots r=eeejay Differential Revision: https://phabricator.services.mozilla.com/D28983
50c1ff58c6824782afdc10e65ee28cccdb60f7b2: Bug 1543561: Expose the focusable state on a node focused by aria-activedescendant, even if that node isn't a descendant. r=eeejay
James Teh <jteh@mozilla.com> - Wed, 17 Apr 2019 23:13:10 +0000 - rev 469962
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1543561: Expose the focusable state on a node focused by aria-activedescendant, even if that node isn't a descendant. r=eeejay Sometimes, we use aria-activedescendant targeting something which isn't actually a descendant. This is technically a spec violation, but it's a useful hack which makes certain things much easier. For example, we use this for "fake focus" for multi select browser tabs and Quantumbar autocomplete suggestions. This already worked previously; the accessible received a focus event and the focused state. However, it did *not* receive the focusable state. This is because the code which applies the focusable state for potential active descendants only works for descendants. It really doesn't make sense for something to be focused when it isn't focusable. In fact, this is an a11y test failure when it occurs. So, if the active item has the focused state, ensure we expose the focusable state too. Differential Revision: https://phabricator.services.mozilla.com/D27021
8ea3101cfbad67458ee23e560ce4c873e129d307: Bug 1544065 - fix clicking on <span> tags inside voice selector in reader mode, r=eeejay
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 15 Apr 2019 16:34:28 +0000 - rev 469527
Push 35873 by ccoroiu@mozilla.com at Mon, 15 Apr 2019 21:36:26 +0000
Bug 1544065 - fix clicking on <span> tags inside voice selector in reader mode, r=eeejay Differential Revision: https://phabricator.services.mozilla.com/D27510
b5298ae1354231d13c9e59a46dc2984493169541: Bug 1540180 - The role of a broken input[type="image"] doesn't depend on its display value. r=surkov,eeejay
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 01 Apr 2019 18:51:14 +0000 - rev 467426
Push 35799 by cbrindusan@mozilla.com at Tue, 02 Apr 2019 08:35:12 +0000
Bug 1540180 - The role of a broken input[type="image"] doesn't depend on its display value. r=surkov,eeejay Differential Revision: https://phabricator.services.mozilla.com/D25517
5697e0aa6e26882f0bca8216687c642f458c7e91: Bug 1473234: make a11y listen to DOM events from iframes and shadow DOM. r=eeejay
James Teh <jteh@mozilla.com> - Mon, 25 Mar 2019 05:04:36 +0000 - rev 466033
Push 35758 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:51:47 +0000
Bug 1473234: make a11y listen to DOM events from iframes and shadow DOM. r=eeejay 1. Register with the root document window's parent target, since this receives events for iframes and shadow DOM. (The root document itself doesn't.) 2. Hold onto the target node when scheduling processing of the DOM event, as GetOriginalTarget returns null when we process shadow DOM events async. Depends on D21349 Differential Revision: https://phabricator.services.mozilla.com/D21350
1b6bf93953727decb8481cb58937ec3eefa5821a: Bug 1530931: Correctly handle retrieving a container accessible for a shadow root. r=eeejay
James Teh <jteh@mozilla.com> - Mon, 25 Mar 2019 05:04:29 +0000 - rev 465878
Push 35753 by aiakab@mozilla.com at Mon, 25 Mar 2019 15:52:30 +0000
Bug 1530931: Correctly handle retrieving a container accessible for a shadow root. r=eeejay This can happen, for example, when GetAccessibleOrContainer is called within SelectionManager::ProcessSelectionChanged due to focusing a direct child of a shadow root. In this case, the common ancestor is the shadow root itself. Previously, we returned null in this case because GetFlattenedTreeParent doesn't work on the shadow root itself. Now, we check if the given node is the shadow root, and if so, we use the shadow host instead. This prevents the "We must reach document accessible implementing text interface!" assertion in SelectionManager::ProcessSelectionChanged when a direct child of a shadow root gets focus. Differential Revision: https://phabricator.services.mozilla.com/D21349
54057e1121b5459ec697bf480a46676d8fc1bff9: Bug 1473234: make a11y listen to DOM events from iframes and shadow DOM. r=eeejay
James Teh <jteh@mozilla.com> - Fri, 01 Mar 2019 02:48:47 +0000 - rev 465318
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1473234: make a11y listen to DOM events from iframes and shadow DOM. r=eeejay 1. Register with the root document window's parent target, since this receives events for iframes and shadow DOM. (The root document itself doesn't.) 2. Hold onto the target node when scheduling processing of the DOM event, as GetOriginalTarget returns null when we process shadow DOM events async. Differential Revision: https://phabricator.services.mozilla.com/D21350
faa43bdd3347883954aed46fcad10d9a459b97fd: Bug 1530931: Correctly handle retrieving a container accessible for a shadow root. r=eeejay
James Teh <jteh@mozilla.com> - Wed, 20 Mar 2019 15:19:44 +0000 - rev 465317
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1530931: Correctly handle retrieving a container accessible for a shadow root. r=eeejay This can happen, for example, when GetAccessibleOrContainer is called within SelectionManager::ProcessSelectionChanged due to focusing a direct child of a shadow root. In this case, the common ancestor is the shadow root itself. Previously, we returned null in this case because GetFlattenedTreeParent doesn't work on the shadow root itself. Now, we check if the given node is the shadow root, and if so, we use the shadow host instead. This prevents the "We must reach document accessible implementing text interface!" assertion in SelectionManager::ProcessSelectionChanged when a direct child of a shadow root gets focus. Differential Revision: https://phabricator.services.mozilla.com/D21349
17a1195583aadff908496e3a1448f4cd6e57089f: Bug 1510214 - Set initial-scale=1 to avoid the content elements are placed at unexpected positions. r=eeejay
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 30 Nov 2018 17:21:09 +0000 - rev 449019
Push 35139 by ccoroiu@mozilla.com at Sat, 01 Dec 2018 02:30:08 +0000
Bug 1510214 - Set initial-scale=1 to avoid the content elements are placed at unexpected positions. r=eeejay Depends on D13172 Differential Revision: https://phabricator.services.mozilla.com/D13375
1b95e3c16503363c58cd64cffb03b0eb4d038a55: Bug 1502118 - Call assertOnUiThread in SessionAccessibility. r=eeejay.
Agi Sferro <agi@mozilla.com> - Tue, 30 Oct 2018 16:36:20 +0000 - rev 443544
Push 34961 by aciure@mozilla.com at Tue, 30 Oct 2018 22:06:02 +0000
Bug 1502118 - Call assertOnUiThread in SessionAccessibility. r=eeejay. Depends on D10242 Differential Revision: https://phabricator.services.mozilla.com/D10243
0648f196a589a3ced8f8b9a8509cb7b0211180f1: Bug 1493403: AccGroupInfo::TotalItemCount: Don't assume a container has children. r=eeejay
James Teh <jteh@mozilla.com> - Mon, 24 Sep 2018 05:02:13 +0000 - rev 437836
Push 34702 by ccoroiu@mozilla.com at Mon, 24 Sep 2018 09:46:39 +0000
Bug 1493403: AccGroupInfo::TotalItemCount: Don't assume a container has children. r=eeejay The code does check for the case where a container has no children. However, before it does so, it tries to check whether it needs to skip a text leaf child. This check previously assumed there was a child to check, which crashed for a container with no children. Differential Revision: https://phabricator.services.mozilla.com/D6588
8a0494308f1fe2fd010072711fa6a40e5170cd96: Bug 1489250 - Don't send window changed event if a11y is off; r=eeejay
Jim Chen <nchen@mozilla.com> - Thu, 06 Sep 2018 19:05:13 +0000 - rev 435129
Push 34594 by btara@mozilla.com at Fri, 07 Sep 2018 03:35:52 +0000
Bug 1489250 - Don't send window changed event if a11y is off; r=eeejay Don't send window changed event if a11y has been turned off in the mean time. Differential Revision: https://phabricator.services.mozilla.com/D5192
351b9c51222159656a05739ed463975451d04604: Bug 1486329 - Fix some clang-cl warnings in accessible. r=eeejay
Xidorn Quan <me@upsuper.org> - Mon, 27 Aug 2018 15:49:01 +0000 - rev 433488
Push 34517 by aciure@mozilla.com at Tue, 28 Aug 2018 21:56:57 +0000
Bug 1486329 - Fix some clang-cl warnings in accessible. r=eeejay Specifically this fixes pessimizing-move warnings and some others. Differential Revision: https://phabricator.services.mozilla.com/D4302
d91afaee03b064e482e1efc63f5651ff1b61ef34: Bug 1330257 - 6. Add tests for auto-fill accessibility frontend; r=eeejay
Jim Chen <nchen@mozilla.com> - Tue, 21 Aug 2018 15:23:29 -0400 - rev 432640
Push 34482 by toros@mozilla.com at Tue, 21 Aug 2018 21:56:56 +0000
Bug 1330257 - 6. Add tests for auto-fill accessibility frontend; r=eeejay Add some tests to AccessibilityTest to make sure we can perform auto-fill through the accessibility API. Differential Revision: https://phabricator.services.mozilla.com/D3255
6541f81c8e25558cc8a72773aea2247c6cdef5e5: Bug 1330257 - 5. Add auto-fill accessibility frontend; r=eeejay
Jim Chen <nchen@mozilla.com> - Tue, 21 Aug 2018 15:23:28 -0400 - rev 432639
Push 34482 by toros@mozilla.com at Tue, 21 Aug 2018 21:56:56 +0000
Bug 1330257 - 5. Add auto-fill accessibility frontend; r=eeejay Add an auto-fill frontend that listens to events from Gecko. It populates accessibility nodes for input fields and sends accessibility events, in order to support auto-fill clients that use accessibility services to perform auto-fill. Differential Revision: https://phabricator.services.mozilla.com/D3254
c8789a613477be022d74179f8cc385b410fe315d: Bug 1330257 - 1. Refactor SessionAccessibility; r=eeejay
Jim Chen <nchen@mozilla.com> - Tue, 21 Aug 2018 15:23:27 -0400 - rev 432635
Push 34482 by toros@mozilla.com at Tue, 21 Aug 2018 21:56:56 +0000
Bug 1330257 - 1. Refactor SessionAccessibility; r=eeejay Move the AccessibilityNodeProvider implementation under SessionAccessibility, to reduce the indent of the code. Also make all methods in SessionAccessibility.Settings static to make the code easier to follow. Differential Revision: https://phabricator.services.mozilla.com/D3250
62e53fa35d5bb177f50b7e5ee3fd23a0b282a2b8: Bug 1330257 - 6. Add tests for auto-fill accessibility frontend; r=eeejay
Jim Chen <nchen@mozilla.com> - Mon, 20 Aug 2018 22:28:21 -0400 - rev 432527
Push 34478 by dluca@mozilla.com at Tue, 21 Aug 2018 09:54:49 +0000
Bug 1330257 - 6. Add tests for auto-fill accessibility frontend; r=eeejay Add some tests to AccessibilityTest to make sure we can perform auto-fill through the accessibility API. Differential Revision: https://phabricator.services.mozilla.com/D3255
7c589fc8621bef8c56954284e2a3dd9d3c96eb3d: Bug 1330257 - 5. Add auto-fill accessibility frontend; r=eeejay
Jim Chen <nchen@mozilla.com> - Mon, 20 Aug 2018 22:28:20 -0400 - rev 432526
Push 34478 by dluca@mozilla.com at Tue, 21 Aug 2018 09:54:49 +0000
Bug 1330257 - 5. Add auto-fill accessibility frontend; r=eeejay Add an auto-fill frontend that listens to events from Gecko. It populates accessibility nodes for input fields and sends accessibility events, in order to support auto-fill clients that use accessibility services to perform auto-fill. Differential Revision: https://phabricator.services.mozilla.com/D3254
7186e64192f742776dc089d62a27a078c97c860a: Bug 1330257 - 1. Refactor SessionAccessibility; r=eeejay
Jim Chen <nchen@mozilla.com> - Mon, 20 Aug 2018 22:28:19 -0400 - rev 432522
Push 34478 by dluca@mozilla.com at Tue, 21 Aug 2018 09:54:49 +0000
Bug 1330257 - 1. Refactor SessionAccessibility; r=eeejay Move the AccessibilityNodeProvider implementation under SessionAccessibility, to reduce the indent of the code. Also make all methods in SessionAccessibility.Settings static to make the code easier to follow. Differential Revision: https://phabricator.services.mozilla.com/D3250
d9466b483cb5de5fb7682315947c5c0cd2e64996: Bug 1481924 - use WINDOW_CONTENT_CHANGED instead of WINDOW_STATE_CHANGED when viewport changes to ensure accessible bounds are re-drawn correctly. r=eeejay, jchen
Yura Zenevich <yura.zenevich@gmail.com> - Thu, 16 Aug 2018 16:36:08 -0400 - rev 432148
Push 34461 by dvarga@mozilla.com at Fri, 17 Aug 2018 21:53:31 +0000
Bug 1481924 - use WINDOW_CONTENT_CHANGED instead of WINDOW_STATE_CHANGED when viewport changes to ensure accessible bounds are re-drawn correctly. r=eeejay, jchen MozReview-Commit-ID: 92bKGZMwJkP
6f0f8668fb8198364c4b59b0a818d2405b6349dc: Bug 1481924 - added GevkoView accessibility tests for scrolling. r=eeejay, jchen
Yura Zenevich <yura.zenevich@gmail.com> - Thu, 09 Aug 2018 11:08:52 -0400 - rev 431031
Push 34419 by btara@mozilla.com at Sat, 11 Aug 2018 03:43:33 +0000
Bug 1481924 - added GevkoView accessibility tests for scrolling. r=eeejay, jchen MozReview-Commit-ID: ATGNFruDGAI
8720a95a99917395f69be6ea8a1d6c58dfd34290: Bug 1481922 - add support for select action and view selected event. r=eeejay, jchen
Yura Zenevich <yura.zenevich@gmail.com> - Thu, 09 Aug 2018 11:08:41 -0400 - rev 431030
Push 34419 by btara@mozilla.com at Sat, 11 Aug 2018 03:43:33 +0000
Bug 1481922 - add support for select action and view selected event. r=eeejay, jchen MozReview-Commit-ID: FaLz7majPhz
e53dac3a93f5ac9c1c5cf985244c971cccb6ea03: Bug 1473690 - add selectable ingegration tests. r=eeejay, jchen
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 18 Jul 2018 15:58:01 -0400 - rev 427808
Push 34318 by ccoroiu@mozilla.com at Mon, 23 Jul 2018 21:44:05 +0000
Bug 1473690 - add selectable ingegration tests. r=eeejay, jchen MozReview-Commit-ID: 9ka7CjOJcew
9f30ad8f38e2df4a134c367862e0b65916d0e177: Bug 1473690 - add integration tests for checkboxes and associated events/states. r=eeejay, jchen
Yura Zenevich <yura.zenevich@gmail.com> - Fri, 06 Jul 2018 14:10:35 -0400 - rev 427807
Push 34318 by ccoroiu@mozilla.com at Mon, 23 Jul 2018 21:44:05 +0000
Bug 1473690 - add integration tests for checkboxes and associated events/states. r=eeejay, jchen MozReview-Commit-ID: DIPa582EyTr
b41a71c9e2e065ffdbaccd959409bd64c36538f7: Bug 1473690 - add selectable ingegration tests. r=eeejay, jchen
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 18 Jul 2018 15:58:01 -0400 - rev 427688
Push 34310 by rgurzau@mozilla.com at Sun, 22 Jul 2018 09:46:49 +0000
Bug 1473690 - add selectable ingegration tests. r=eeejay, jchen MozReview-Commit-ID: 9ka7CjOJcew
6ca2392ff3f9db4ce6df3925606d7bb676b7dbbb: Bug 1473690 - add integration tests for checkboxes and associated events/states. r=eeejay, jchen
Yura Zenevich <yura.zenevich@gmail.com> - Fri, 06 Jul 2018 14:10:35 -0400 - rev 427687
Push 34310 by rgurzau@mozilla.com at Sun, 22 Jul 2018 09:46:49 +0000
Bug 1473690 - add integration tests for checkboxes and associated events/states. r=eeejay, jchen MozReview-Commit-ID: DIPa582EyTr
b444a5c91bd9e3975e3a60053e8382f5d705cf39: Bug 1464858 - make visually hidden / screenreader content not display:none, r=eeejay
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 19 Jun 2018 16:33:19 +0100 - rev 423339
Push 34173 by apavel@mozilla.com at Fri, 22 Jun 2018 21:49:08 +0000
Bug 1464858 - make visually hidden / screenreader content not display:none, r=eeejay MozReview-Commit-ID: JzO7tyO4wv3
68bfd841265f54fdd4a214214e9ccc8297c64672: Bug 1424505: Don't try to retrieve the accessible focus from remote documents on Windows 7. r=eeejay
James Teh <jteh@mozilla.com> - Tue, 01 May 2018 15:48:43 +1000 - rev 416458
Push 33928 by csabou@mozilla.com at Wed, 02 May 2018 09:26:14 +0000
Bug 1424505: Don't try to retrieve the accessible focus from remote documents on Windows 7. r=eeejay Bug 1421144 fixed IAccessible::accFocus to work when focus is within a remote document. Unfortunately, this causes mysterious intermittent crashes when called from a UIA client in Windows 7. Ideally, we'd deal with the actual cause of the crashes, but they seem to be deep in Windows RPC code and all attempts at tracking this down have failed. Clients don't seem to need this too often anyway (and it's a minor annoyance if it doesn't work when they do). MozReview-Commit-ID: IxvbBGJ2wxA