searching for reviewer(dholbert)
4af3a83487c70770875d39ba7df3e766aa15ecbe: Bug 1804772 - Make nsIFrame::GetStartPageValue/nsIFrame::GetEndPageValue constant complexity by copying over the PageValuesProperty value when creating frame continuations. r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 08 Dec 2022 22:04:14 +0000 - rev 645154
Push 40467 by ctuns@mozilla.com at Fri, 09 Dec 2022 16:00:25 +0000
Bug 1804772 - Make nsIFrame::GetStartPageValue/nsIFrame::GetEndPageValue constant complexity by copying over the PageValuesProperty value when creating frame continuations. r=dholbert This was causing layout/generic/crashtests/1683126.html to timeout with named pages enabled. It is possible for a frame's PageValues struct to have both the start and end values be set to null as further children are added. In that case, we can avoid doing an extra allocation for each of that frame's continuations, as a small optimization. Differential Revision: https://phabricator.services.mozilla.com/D164266
9370cb272df65e50c5125c48984897e9c0ee83d5: Bug 1804750 - Track page name when constructing column set wrapper frames r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 08 Dec 2022 21:47:05 +0000 - rev 645153
Push 40467 by ctuns@mozilla.com at Fri, 09 Dec 2022 16:00:25 +0000
Bug 1804750 - Track page name when constructing column set wrapper frames r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D164258
b276c24696ee9bd643a90dd3470c4798b696be18: Bug 1787947 - pref on CSS named pages in Nightly r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Wed, 07 Dec 2022 23:20:35 +0000 - rev 645057
Push 40462 by smolnar@mozilla.com at Thu, 08 Dec 2022 03:58:54 +0000
Bug 1787947 - pref on CSS named pages in Nightly r=dholbert Also standardize having named pages enabled for css-page WPT Differential Revision: https://phabricator.services.mozilla.com/D163638
a2fc2b611fe7f251053806a832bb09f76a8efc7a: Bug 1804551 - Add page-name tracker when constructing table elements r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Wed, 07 Dec 2022 22:48:11 +0000 - rev 645052
Push 40462 by smolnar@mozilla.com at Thu, 08 Dec 2022 03:58:54 +0000
Bug 1804551 - Add page-name tracker when constructing table elements r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D164148
6fb5de003d4ae0b6eb190192a6ae585fbbbca0f6: Bug 1787947 - pref on CSS named pages in Nightly r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Wed, 07 Dec 2022 21:14:52 +0000 - rev 645040
Push 40462 by smolnar@mozilla.com at Thu, 08 Dec 2022 03:58:54 +0000
Bug 1787947 - pref on CSS named pages in Nightly r=dholbert Also standardize having named pages enabled for css-page WPT Differential Revision: https://phabricator.services.mozilla.com/D163638
6ad0553e3073aa72ca9ef7a8c2755421b29b3b32: Bug 1804160 for clang-tidy checker readability-simplify-boolean-expr do not activate SimplifyDeMorgan. r=dholbert
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 07 Dec 2022 07:15:33 +0000 - rev 644920
Push 40461 by imoraru@mozilla.com at Wed, 07 Dec 2022 16:54:36 +0000
Bug 1804160 for clang-tidy checker readability-simplify-boolean-expr do not activate SimplifyDeMorgan. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D163909
8f8235b1bc2ddb84d45dcc650994f525b3b64ea7: Bug 1802238 - Don't allow using mixed page sizes when printing unless layout.css.allow-mixed-page-sizes is set r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Tue, 06 Dec 2022 21:24:29 +0000 - rev 644885
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1802238 - Don't allow using mixed page sizes when printing unless layout.css.allow-mixed-page-sizes is set r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D162920
08a17448a470834b9161d08d9e6492c3da1025fb: Bug 1803861 - Implement nsPageFrame::FirstContinuation and nsPageContentFrame::FirstContinuation with constant complexity r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Tue, 06 Dec 2022 00:07:09 +0000 - rev 644721
Push 40457 by mlaza@mozilla.com at Tue, 06 Dec 2022 03:46:09 +0000
Bug 1803861 - Implement nsPageFrame::FirstContinuation and nsPageContentFrame::FirstContinuation with constant complexity r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D163759
63b85eeb214b1166b26019c73d5e1dd67d6a43bf: Bug 1803643 - Speed up dom iteration in querySelector. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 03 Dec 2022 11:25:10 +0000 - rev 644612
Push 40451 by abutkovits@mozilla.com at Sat, 03 Dec 2022 21:37:36 +0000
Bug 1803643 - Speed up dom iteration in querySelector. r=dholbert This removes a few branches and null-checks that I found in profiles. Depends on D163627 Differential Revision: https://phabricator.services.mozilla.com/D163628
7a8e8890780f410f86e9b68e4895e0d5f2371d66: Bug 1803643 - Speed up selector matching with already-lowercase local name selectors. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 03 Dec 2022 11:25:09 +0000 - rev 644611
Push 40451 by abutkovits@mozilla.com at Sat, 03 Dec 2022 21:37:36 +0000
Bug 1803643 - Speed up selector matching with already-lowercase local name selectors. r=dholbert This makes relatively simple changes so that we check lowercase-ness of local-name selectors first. If so, we don't need to check whether we're an HTML element in an HTML document, which requires a fair bit of pointer-chasing. Differential Revision: https://phabricator.services.mozilla.com/D163627
4fd3e010b177384e88a2dbb208b11ae5b40beedf: Bug 1638052 - Implement Buttonborder/mark/marktext. r=geckoview-reviewers,calu,dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 03 Dec 2022 11:19:56 +0000 - rev 644610
Push 40451 by abutkovits@mozilla.com at Sat, 03 Dec 2022 21:37:36 +0000
Bug 1638052 - Implement Buttonborder/mark/marktext. r=geckoview-reviewers,calu,dholbert Needs some extra test expectation updates. Differential Revision: https://phabricator.services.mozilla.com/D157748
bb3383a659ac0f6110942baa86746ea8ad174d90: Bug 1800546 Part 2 - Add print preview tests for named page orientation setting. r=mstriemer,dholbert
Emily McDonough <emcdonough@mozilla.com> - Fri, 02 Dec 2022 23:22:51 +0000 - rev 644594
Push 40450 by ctuns@mozilla.com at Sat, 03 Dec 2022 09:24:59 +0000
Bug 1800546 Part 2 - Add print preview tests for named page orientation setting. r=mstriemer,dholbert Layout reftests don't support page-size properly yet, so this is unfortunately probably the best we can do at the moment for testing this. Also remove outdated pref settings from the existing orientation tests while I'm here. Differential Revision: https://phabricator.services.mozilla.com/D163397
5f89b0e8bdb56164737d4e0c86c997c8771a268c: Bug 1638052 - Implement Buttonborder/mark/marktext. r=geckoview-reviewers,calu,dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 02 Dec 2022 19:12:22 +0000 - rev 644574
Push 40450 by ctuns@mozilla.com at Sat, 03 Dec 2022 09:24:59 +0000
Bug 1638052 - Implement Buttonborder/mark/marktext. r=geckoview-reviewers,calu,dholbert Needs some extra test expectation updates. Differential Revision: https://phabricator.services.mozilla.com/D157748
9370e929428b19267a4e09d48ee5581f77465ea1: Bug 1803486 Part 4 - Remove arguments for CheckForMinSizeAuto() and rename it. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 01 Dec 2022 22:29:56 +0000 - rev 644428
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1803486 Part 4 - Remove arguments for CheckForMinSizeAuto() and rename it. r=dholbert The arguments are removed for the following reasons: 1) We might need to call it in future patches when ReflowInput is not available. Although getting the cached style struct pointers from ReflowInput is cheaper, but getting them from the frame directly is not expensive nowadays. 2) We can initialize mNeedsMinSizeAutoResolution directly in the member initializer list. Also, simplify its implementation and comments. Differential Revision: https://phabricator.services.mozilla.com/D163548
94d2dd381aaaa2b04b9afc2714de3acd28c7873f: Bug 1803486 Part 3 - Add SharedFlexData::Update(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 01 Dec 2022 22:29:55 +0000 - rev 644427
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1803486 Part 3 - Add SharedFlexData::Update(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D163547
04e34f384702433246bcc3d80c46506c1ad2f933: Bug 1803486 Part 2 - Move prevInFlow definition up in nsFlexContainerFrame::Reflow(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 01 Dec 2022 22:29:55 +0000 - rev 644426
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1803486 Part 2 - Move prevInFlow definition up in nsFlexContainerFrame::Reflow(). r=dholbert Depends on D163545 Differential Revision: https://phabricator.services.mozilla.com/D163546
a0dbe91979ec31e45a75d00db0148ed737d406fd: Bug 1803486 Part 1 - Guard logic required only by fragmentation for flex container. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 01 Dec 2022 22:29:54 +0000 - rev 644425
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1803486 Part 1 - Guard logic required only by fragmentation for flex container. r=dholbert This separation makes hacking fragmentation code easier, and readers who are not interested in flex container fragmentation can skip it. Differential Revision: https://phabricator.services.mozilla.com/D163545
b5b515b2a2591c52674154384525e58b99d96a57: Bug 1802238 - Don't allow using mixed page sizes when printing unless layout.css.allow-mixed-page-sizes is set r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 01 Dec 2022 20:20:09 +0000 - rev 644405
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1802238 - Don't allow using mixed page sizes when printing unless layout.css.allow-mixed-page-sizes is set r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D162920
4dcf1336bf2b54ba3a47eed40b78c5da46af7884: Bug 1673677: Ensure nested orthogonal table's baseline is equivalent to `contain: layout`. r=dholbert
David Shin <dshin@mozilla.com> - Thu, 17 Nov 2022 15:01:16 +0000 - rev 642660
Push 40412 by csabou@mozilla.com at Thu, 17 Nov 2022 21:41:29 +0000
Bug 1673677: Ensure nested orthogonal table's baseline is equivalent to `contain: layout`. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D155615
1bae7461a4eca52ca0f80ca08d29b5e620de1b76: Bug 1403656 - Ensure that the observation target for `SVGFilterObserver` is an actual SVG filter element. r=dholbert,emilio
David Shin <dshin@mozilla.com> - Tue, 15 Nov 2022 13:30:37 +0000 - rev 642443
Push 40406 by abutkovits@mozilla.com at Tue, 15 Nov 2022 16:44:51 +0000
Bug 1403656 - Ensure that the observation target for `SVGFilterObserver` is an actual SVG filter element. r=dholbert,emilio Previously, specifying `filter: url(#element)` could trigger a reflow of the observing element when the observed element repaints, even when the observed element is not a SVG filter element (i.e. no filter effect is applied). Differential Revision: https://phabricator.services.mozilla.com/D161830
49bdff2fc36ef3ba693fac07c447f837e33d98c9: Bug 1740365 Part 2 - Add tests for named page styling r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 10 Nov 2022 23:43:48 +0000 - rev 641021
Push 40394 by sstanca@mozilla.com at Fri, 11 Nov 2022 09:37:17 +0000
Bug 1740365 Part 2 - Add tests for named page styling r=dholbert Also alphabetize layout/reftests/css-page/reftest.list while I'm here. Differential Revision: https://phabricator.services.mozilla.com/D161208
2a3f6af5c2eb9cb49df3c6b4fe4c7bd15315cb7e: Bug 1740365 Part 1 - Use CSS page name when constructing nsPageContentFrames and computed page content style r=dholbert,emilio
Emily McDonough <emcdonough@mozilla.com> - Thu, 10 Nov 2022 23:43:48 +0000 - rev 641020
Push 40394 by sstanca@mozilla.com at Fri, 11 Nov 2022 09:37:17 +0000
Bug 1740365 Part 1 - Use CSS page name when constructing nsPageContentFrames and computed page content style r=dholbert,emilio This works with margin and page-size, though we can't properly test mixed page-size yet due to limitations in both print preview testing (which does not handle multiple pages) and paged reftests (which ignore page-size). It may be appropriate to remove the @page { margin } propagation from Servo after this change. Differential Revision: https://phabricator.services.mozilla.com/D158227
b52bc7d5cf65f89586a9065757de90b2450e996c: Bug 1740365 Part 2 - Add tests for named page styling r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 10 Nov 2022 15:30:40 +0000 - rev 640967
Push 40394 by sstanca@mozilla.com at Fri, 11 Nov 2022 09:37:17 +0000
Bug 1740365 Part 2 - Add tests for named page styling r=dholbert Also alphabetize layout/reftests/css-page/reftest.list while I'm here. Differential Revision: https://phabricator.services.mozilla.com/D161208
5ba5fdd07fe07418fb4fb8d35da7d093bfdeb348: Bug 1740365 Part 1 - Use CSS page name when constructing nsPageContentFrames and computed page content style r=dholbert,emilio
Emily McDonough <emcdonough@mozilla.com> - Thu, 10 Nov 2022 15:30:39 +0000 - rev 640966
Push 40394 by sstanca@mozilla.com at Fri, 11 Nov 2022 09:37:17 +0000
Bug 1740365 Part 1 - Use CSS page name when constructing nsPageContentFrames and computed page content style r=dholbert,emilio This works with margin and page-size, though we can't properly test mixed page-size yet due to limitations in both print preview testing (which does not handle multiple pages) and paged reftests (which ignore page-size). It may be appropriate to remove the @page { margin } propagation from Servo after this change. Differential Revision: https://phabricator.services.mozilla.com/D158227
f96787e6139fecc7c9784af16cb392df14f3e5d9: Bug 1799749 - Ensure `UnionChildOverflow` on `<canvas>` does not consider its children. r=dholbert
David Shin <dshin@mozilla.com> - Thu, 10 Nov 2022 13:59:59 +0000 - rev 640951
Push 40393 by csabou@mozilla.com at Thu, 10 Nov 2022 16:37:12 +0000
Bug 1799749 - Ensure `UnionChildOverflow` on `<canvas>` does not consider its children. r=dholbert This matches the overflow calculation in its reflow code. Differential Revision: https://phabricator.services.mozilla.com/D161626
73dd9b390b9a0712ea44b2345966c54ebc83c492: Bug 1799925 - Make XUL popups contain: paint. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 09 Nov 2022 20:38:05 +0000 - rev 640891
Push 40392 by sstanca@mozilla.com at Thu, 10 Nov 2022 09:23:09 +0000
Bug 1799925 - Make XUL popups contain: paint. r=dholbert Since they can't paint outside of the widget, it makes sense. Now that popups are not so special and they just use the top layer we can enforce it using contain: paint. This should save some work when adding / removing transforms to popups (since they won't change the containing block). Now popups can become dynamic reflow roots, and that caught some issues with the reflow requests. We need to hit nsMenuPopupFrame::LayoutPopup(), so the right thing to do is to use NS_FRAME_IS_DIRTY. Differential Revision: https://phabricator.services.mozilla.com/D161708
7ebb8d3b0fdfff5b1a00bef1852fe02ac8c4e461: Bug 1798830 - Clean up DisplayFlagForFlexOrGridItem. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 03 Nov 2022 02:32:47 +0000 - rev 640112
Push 40372 by nbeleuzu@mozilla.com at Thu, 03 Nov 2022 09:53:49 +0000
Bug 1798830 - Clean up DisplayFlagForFlexOrGridItem. r=dholbert No need to be an out of band member function given the only callers are in flex / grid code. I was looking at this in the context of bug 1798396. This probably doesn't matter for PGO, but it being a static method helps reason about the flags being the same for all items. Differential Revision: https://phabricator.services.mozilla.com/D161102
1911a7d6dcbb6634d85060cb8d6feeb71ef6d31f: Bug 1798297 - Add reftest for the Yu Gothic UI kerning special-case. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Tue, 01 Nov 2022 19:41:47 +0000 - rev 639922
Push 40369 by sstanca@mozilla.com at Wed, 02 Nov 2022 09:45:37 +0000
Bug 1798297 - Add reftest for the Yu Gothic UI kerning special-case. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D160888
99e2e426103b16eaa9331b269fb38be0eae943df: Bug 1798297 - For the Yu Gothic UI font, disable the automatic application of 'palt' when kerning is enabled, because the font's 'palt' feature is bad. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Tue, 01 Nov 2022 19:34:14 +0000 - rev 639921
Push 40368 by ctuns@mozilla.com at Wed, 02 Nov 2022 04:41:32 +0000
Bug 1798297 - For the Yu Gothic UI font, disable the automatic application of 'palt' when kerning is enabled, because the font's 'palt' feature is bad. r=dholbert It feels really ugly to do this, as the problem is a badly-designed font, not a bug in Gecko's behavior. But given that it's a standard Windows font, I think it's probably worth having the workaround. Differential Revision: https://phabricator.services.mozilla.com/D160820
ee014b202046f874453bfad6ce071ffff33af799: Bug 1794164 - Fix C++20 -Wenum-float-conversion warnings in layout-related code. r=dholbert
Chris Peterson <cpeterson@mozilla.com> - Fri, 28 Oct 2022 00:45:25 +0000 - rev 639565
Push 40354 by sstanca@mozilla.com at Fri, 28 Oct 2022 09:44:53 +0000
Bug 1794164 - Fix C++20 -Wenum-float-conversion warnings in layout-related code. r=dholbert C++20 deprecates some operations between enums and floating point types: https://clang.llvm.org/docs/DiagnosticsReference.html#wenum-float-conversion dom/canvas/CanvasRenderingContext2D.cpp:4743:58 [-Wenum-float-conversion] arithmetic between enumeration type 'VideoInfo::Rotation' and floating-point type 'double' dom/events/EventStateManager.cpp:6656:35 [-Wenum-float-conversion] comparison of floating-point type 'double' with enumeration type 'mozilla::EventStateManager::(unnamed enum at dom/events/EventStateManager.h:342:3)' dom/events/EventStateManager.cpp:6664:35 [-Wenum-float-conversion] comparison of floating-point type 'double' with enumeration type 'mozilla::EventStateManager::(unnamed enum at dom/events/EventStateManager.h:342:3)' gfx/thebes/gfxTextRun.cpp:2992:24 [-Wenum-float-conversion] comparison of floating-point type 'gfxFloat' (aka 'double') with enumeration type 'gfxFontGroup::(unnamed enum at gfx/thebes/gfxTextRun.h:1035:3)' layout/generic/nsVideoFrame.cpp:59:58 [-Wenum-float-conversion] arithmetic between enumeration type 'VideoInfo::Rotation' and floating-point type 'double' layout/painting/nsCSSRenderingBorders.cpp:2752:27 [-Wenum-float-conversion] arithmetic between enumeration type 'mozilla::Corner' and floating-point type 'double' Differential Revision: https://phabricator.services.mozilla.com/D158867
8bff394e9702fbabb7d4cbc5150aab2dce83b5cd: Bug 1794164 - Change nsViewportInfo enums to constexprs and add 'k' prefix. r=dholbert
Chris Peterson <cpeterson@mozilla.com> - Fri, 28 Oct 2022 00:45:11 +0000 - rev 639564
Push 40354 by sstanca@mozilla.com at Fri, 28 Oct 2022 09:44:53 +0000
Bug 1794164 - Change nsViewportInfo enums to constexprs and add 'k' prefix. r=dholbert C++20 deprecates some operations between enums and floating point types: https://clang.llvm.org/docs/DiagnosticsReference.html#wenum-float-conversion dom/base/Document.cpp:10408:22 [-Wenum-float-conversion] comparison of floating-point type 'float' with enumeration type 'nsViewportInfo::(unnamed enum at dom/base/nsViewportInfo.h:108:3)' dom/base/nsViewportInfo.cpp:33:10 [-Wenum-float-conversion] comparison of floating-point type 'float' with enumeration type 'nsViewportInfo::(unnamed enum at dom/base/nsViewportInfo.h:108:3)' dom/base/nsViewportInfo.cpp:33:48 [-Wenum-float-conversion] comparison of floating-point type 'float' with enumeration type 'nsViewportInfo::(unnamed enum at dom/base/nsViewportInfo.h:108:3)' dom/base/nsViewportInfo.cpp:34:10 [-Wenum-float-conversion] comparison of floating-point type 'float' with enumeration type 'nsViewportInfo::(unnamed enum at dom/base/nsViewportInfo.h:108:3)' dom/base/nsViewportInfo.cpp:34:48 [-Wenum-float-conversion] comparison of floating-point type 'float' with enumeration type 'nsViewportInfo::(unnamed enum at dom/base/nsViewportInfo.h:108:3)' dom/base/nsViewportInfo.cpp:35:10 [-Wenum-float-conversion] comparison of floating-point type 'float' with enumeration type 'nsViewportInfo::(unnamed enum at dom/base/nsViewportInfo.h:108:3)' dom/base/nsViewportInfo.cpp:38:10 [-Wenum-float-conversion] comparison of floating-point type 'float' with enumeration type 'nsViewportInfo::(unnamed enum at dom/base/nsViewportInfo.h:108:3)' Differential Revision: https://phabricator.services.mozilla.com/D159918
28c4845674ad58495474b35e648157b140ca307c: Bug 1743878 - Avoid opening caret browsing dialogs when already open. r=dholbert
Shane Hughes <shughes@mozilla.com> - Wed, 26 Oct 2022 19:27:34 +0000 - rev 639416
Push 40350 by mlaza@mozilla.com at Thu, 27 Oct 2022 03:52:40 +0000
Bug 1743878 - Avoid opening caret browsing dialogs when already open. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D160166
35fe1522cb09e174918a1c2496ca1971d757a530: Bug 1797139 - Don't null out l10n from destructor(). r=dholbert,Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Oct 2022 11:10:38 +0000 - rev 639348
Push 40348 by smolnar@mozilla.com at Wed, 26 Oct 2022 16:23:36 +0000
Bug 1797139 - Don't null out l10n from destructor(). r=dholbert,Gijs destructor() should really clean-up after setup(), not the constructor(), since setup() can be called multiple times. Differential Revision: https://phabricator.services.mozilla.com/D160332
d076c8363b145d3f17a73353fc832d9930ba1c74: Bug 1743878 - Avoid opening caret browsing dialogs when already open. r=dholbert
Shane Hughes <shughes@mozilla.com> - Wed, 26 Oct 2022 05:42:05 +0000 - rev 639297
Push 40348 by smolnar@mozilla.com at Wed, 26 Oct 2022 16:23:36 +0000
Bug 1743878 - Avoid opening caret browsing dialogs when already open. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D160166
ce7bd39cd8f854a7fe67ce8a8350ba9e94f6a4e3: Bug 1679797 - The containing block of a subgridded item is the root grid container. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 20 Oct 2022 23:02:25 +0000 - rev 638524
Push 40336 by sstanca@mozilla.com at Fri, 21 Oct 2022 08:39:18 +0000
Bug 1679797 - The containing block of a subgridded item is the root grid container. r=dholbert We reflow subgrid items with a ParentReflowInput from the grid container. Note I'm not the most familiar with subgrid, though this does fix the crash. Maybe we should just build the right reflow input here for subgrid items (by building a stack of them or so on)? https://searchfox.org/mozilla-central/rev/c5c002f81f08a73e04868e0c2bf0eb113f200b03/layout/generic/nsGridContainerFrame.cpp#4981,5018-5026,5053-5054 Differential Revision: https://phabricator.services.mozilla.com/D159901
9b0d2ce9f5e0dd4a66782b464310bc14701f22a3: Bug 1794897 - Add fuzzy-if for 8 reftests to run on Pixel5. r=dholbert
Joel Maher <jmaher@mozilla.com> - Thu, 13 Oct 2022 12:41:08 +0000 - rev 637785
Push 40314 by smolnar@mozilla.com at Thu, 13 Oct 2022 21:27:00 +0000
Bug 1794897 - Add fuzzy-if for 8 reftests to run on Pixel5. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D159241
8613dae8d38b29b2449966bd9be2f8a014765348: Bug 1794265 - Remove untested, Netscape-era editor hack. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 10 Oct 2022 19:02:48 +0000 - rev 637362
Push 40306 by ncsoregi@mozilla.com at Tue, 11 Oct 2022 03:54:04 +0000
Bug 1794265 - Remove untested, Netscape-era editor hack. r=dholbert Behavior of an editor with only a table seems the same before and after this patch when positioning the caret with keyboard or mouse, which seems what this was about (see bug 34356). Nobody reads the magic return value either, so remove it as well. If we wanted to tweak this, there's no reason to special-case tables (we'd want to allow positioning in any arbitrary line-iterable frame). Differential Revision: https://phabricator.services.mozilla.com/D158927
d7103c5e7e0ca1c0b9d3e3194044040ba8e1f906: Bug 1794265 - Fix infinite loop in PeekOffsetFromLine. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 10 Oct 2022 17:01:06 +0000 - rev 637352
Push 40306 by ncsoregi@mozilla.com at Tue, 11 Oct 2022 03:54:04 +0000
Bug 1794265 - Fix infinite loop in PeekOffsetFromLine. r=dholbert This effectively restores the blockFrame != aPos->mResultFrame check here: https://hg.mozilla.org/integration/autoland/rev/66a061bd76fc63ce67845e4f848a3bd8cd9b703d#l1.260 This is hitting this rather odd code-path from the netscape era, which is clearly not well tested: https://searchfox.org/mozilla-central/rev/ffa4d00965c5281def6d3ddcbcdf6259d38c9b9a/layout/generic/nsIFrame.cpp#8451-8482 I'd happily write a test, but I think I'd need some assistance as I haven't been able to reproduce this with regular selection APIs / line movement. Differential Revision: https://phabricator.services.mozilla.com/D158926
cd492741a06153c2b37061b4535bdacb2f0a8b73: Bug 1776296 - Remove nsPrintJob::mIsForModalWindow. r=dholbert
Jonathan Watt <jwatt@jwatt.org> - Fri, 07 Oct 2022 17:24:17 +0000 - rev 637238
Push 40298 by ctuns@mozilla.com at Fri, 07 Oct 2022 21:38:10 +0000
Bug 1776296 - Remove nsPrintJob::mIsForModalWindow. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D158777
27e7a85b0ca62977ce0d63f9d6160054a475f4c0: Bug 1782597 Part 2 - Use null to indicate page value equal to the auto value for CSS named pages r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Wed, 05 Oct 2022 22:07:47 +0000 - rev 637017
Push 40291 by ncsoregi@mozilla.com at Thu, 06 Oct 2022 04:13:55 +0000
Bug 1782597 Part 2 - Use null to indicate page value equal to the auto value for CSS named pages r=dholbert This applies both to the individual mStartPageValue and mEndPageValue fields of the nsIFrame::PageValues struct, and for the nsIFrame::PageValuesProperty being null to indicate both mStartPageValue and mEndPageValue are auto. Fetching this is handled by nsIFrame::GetStartPageValue and nsIFrame::GetEndPageValue, which also ensure the use of first-in-flow frames. Differential Revision: https://phabricator.services.mozilla.com/D157873
cbed1d1d6714dcb1cbd8d11db513c3a16237644c: Bug 1782597 Part 1 - Store auto page value on each frame when in a paginated context. r=dholbert,emilio
Emily McDonough <emcdonough@mozilla.com> - Wed, 05 Oct 2022 22:07:46 +0000 - rev 637016
Push 40291 by ncsoregi@mozilla.com at Thu, 06 Oct 2022 04:13:55 +0000
Bug 1782597 Part 1 - Store auto page value on each frame when in a paginated context. r=dholbert,emilio Differential Revision: https://phabricator.services.mozilla.com/D157872
f36d9e78e41726fe8cd299e04b7fad07d208ec79: Bug 1793375 - Rename nsILineIterator::GetDirection to IsLineIteratorFlowRTL. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Oct 2022 11:00:39 +0000 - rev 636783
Push 40283 by smolnar@mozilla.com at Mon, 03 Oct 2022 21:20:25 +0000
Bug 1793375 - Rename nsILineIterator::GetDirection to IsLineIteratorFlowRTL. r=dholbert bool GetDirection() is rather meaningless. Differential Revision: https://phabricator.services.mozilla.com/D158474
f4529232e0a8d05f52c629b24dfafcc4da0349e3: Bug 1792333 - Implement nsILineIterator in nsFlex/GridContainerFrame. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 02 Oct 2022 07:49:46 +0000 - rev 636769
Push 40281 by ctuns@mozilla.com at Sun, 02 Oct 2022 21:22:26 +0000
Bug 1792333 - Implement nsILineIterator in nsFlex/GridContainerFrame. r=dholbert Instead of digging into the first line-iterable frame. Digging into the first line-iterable frame is bogus, because if there are multiple flex items we might prevent moving through them properly (see test-case). The flex implementation is nice and fairly complete, IMO. The grid one is not, but the resulting behavior is nicer than the behavior before this patch, seems reasonable, and matches Chrome in my testing. In Searchfox, the behavior is even funnier because user-select: none is involved, but that predates the regression. Differential Revision: https://phabricator.services.mozilla.com/D158086
502f1e7d287e8082d59b1b84dcc5a3738c87f504: Bug 1792333 - Factor out the "find closest frame in the line" checks. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 02 Oct 2022 07:06:46 +0000 - rev 636768
Push 40281 by ctuns@mozilla.com at Sun, 02 Oct 2022 21:22:26 +0000
Bug 1792333 - Factor out the "find closest frame in the line" checks. r=dholbert Depends on D158085 Differential Revision: https://phabricator.services.mozilla.com/D158437
c949d841e3e9f4f1b9a34c1e7ebb958fd8e04585: Bug 1790299 - Make test more similar between xul/non-xul. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 02 Oct 2022 06:08:54 +0000 - rev 636766
Push 40280 by nfay@mozilla.com at Sun, 02 Oct 2022 09:32:40 +0000
Bug 1790299 - Make test more similar between xul/non-xul. r=dholbert This doesn't have any behavior change, test-only. I wrote this while debugging the previous patches. Modern flexbox respects width/height over flex, which is not true for legacy flexbox, so this makes the box sizes match, effectively, which makes it easier to compare to figure out regressions. Differential Revision: https://phabricator.services.mozilla.com/D157913
66a061bd76fc63ce67845e4f848a3bd8cd9b703d: Bug 1792333 - Various clean-ups to nsIFrame line-movement APIs. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 02 Oct 2022 01:16:47 +0000 - rev 636764
Push 40280 by nfay@mozilla.com at Sun, 02 Oct 2022 09:32:40 +0000
Bug 1792333 - Various clean-ups to nsIFrame line-movement APIs. r=dholbert This shouldn't change behavior but makes the code easier to follow. Differential Revision: https://phabricator.services.mozilla.com/D158085
97e0c3328eeeaace9265d331ad85aee1bbd13f26: Bug 1792277 - Fix sidebar resizing with flexbox emulation. r=Gijs,dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Sep 2022 19:55:22 +0000 - rev 636490
Push 40270 by ncsoregi@mozilla.com at Wed, 28 Sep 2022 09:43:53 +0000
Bug 1792277 - Fix sidebar resizing with flexbox emulation. r=Gijs,dholbert Add some basic min/max size support in splitters, and make the width part of the element we're splitting rather than the <browser> child. I don't _think_ the nsSplitterFrame changes are needed for this in particular, since we're only distributing across two items (min and max are useful only if we can distribute the space that one item can't fill with another), but it doesn't hurt. Differential Revision: https://phabricator.services.mozilla.com/D158074
15d13eb291b4c2d8fe2e358b89fdfb8d7506f18a: Bug 1790299 - Make nsSplitterFrame work with regular flex boxes. r=dholbert,layout-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 21 Sep 2022 10:12:48 +0000 - rev 635967
Push 40254 by mlaza@mozilla.com at Wed, 21 Sep 2022 21:43:38 +0000
Bug 1790299 - Make nsSplitterFrame work with regular flex boxes. r=dholbert,layout-reviewers This allows DevTools to be resized with emulated flexbox. Differential Revision: https://phabricator.services.mozilla.com/D157250
bf86de479585e0889df38ae2e01761e33d64dc9e: Bug 1790299 - Make nsSplitterFrame work with regular flex boxes. r=dholbert,layout-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 21 Sep 2022 02:04:45 +0000 - rev 635938
Push 40253 by abutkovits@mozilla.com at Wed, 21 Sep 2022 09:52:11 +0000
Bug 1790299 - Make nsSplitterFrame work with regular flex boxes. r=dholbert,layout-reviewers This allows DevTools to be resized with emulated flexbox. Differential Revision: https://phabricator.services.mozilla.com/D157250
c7d1db6d321f0e46cac8a53e7a40e53ff176a1de: Bug 1764437 - Check for prev/next sibling when propagating start/end page values for frames r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Tue, 20 Sep 2022 21:42:34 +0000 - rev 635925
Push 40252 by imoraru@mozilla.com at Wed, 21 Sep 2022 03:56:08 +0000
Bug 1764437 - Check for prev/next sibling when propagating start/end page values for frames r=dholbert This also properly handles placeholder frames, and ensures that when checking next/prev sibling we ignore placeholder frames. To properly test this for multiple levels of page value propagation, we also need to use FirstInFlow to get page values when checking for breaks in block frames. Differential Revision: https://phabricator.services.mozilla.com/D157175