searching for reviewer(dholbert)
f12c5ebd0bfce0915e7979bc95e7e8781c2f3a4f: Bug 1553824 - [css-grid-2] Invalidate any stored used track sizes on subgrids too. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 23 May 2019 21:11:48 +0200 - rev 475399
Push 36061 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:49:59 +0000
Bug 1553824 - [css-grid-2] Invalidate any stored used track sizes on subgrids too. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D32372
81136d6972e80a961b2d4f0c4eb0d36e7d9e179f: Bug 1547560 - [css-grid-2] Add subgrid gaps to its items contributions in track sizing and recompute the subgrid tracks size/position to center the subgrid gaps. r=dholbert
Mats Palmgren <mats@mozilla.com> - Fri, 17 May 2019 16:50:42 +0200 - rev 474938
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1547560 - [css-grid-2] Add subgrid gaps to its items contributions in track sizing and recompute the subgrid tracks size/position to center the subgrid gaps. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D31630
8a0c6e30d738160e81990c286040472d4e3aa92b: Bug 1471758 - [css-grid-2][css-contain] Make 'contain:paint' and 'contain:layout' inhibit a grid container from being a subgrid. r=dholbert
Mats Palmgren <mats@mozilla.com> - Fri, 03 May 2019 05:35:18 +0200 - rev 474937
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1471758 - [css-grid-2][css-contain] Make 'contain:paint' and 'contain:layout' inhibit a grid container from being a subgrid. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29793
e0b2740b3b7de6da0dc01403c0526a99e61b17b7: Bug 1548421 - [css-grid-2] Ensure subgrids are never reflow roots. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 02 May 2019 03:37:51 +0200 - rev 474936
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1548421 - [css-grid-2] Ensure subgrids are never reflow roots. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29609
f21f62a36c120907415a69f04ccce310dbf7fff6: Bug 1466358 part 11 - [css-grid-2] Update the frame's subgrid state when the style changes. r=dholbert
Mats Palmgren <mats@mozilla.com> - Wed, 01 May 2019 23:53:47 +0200 - rev 474935
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1466358 part 11 - [css-grid-2] Update the frame's subgrid state when the style changes. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29578
1e1d198ffd3e5b26de468b9444d39b8c2519834f: Bug 1496502 - [css-grid-2] Enable subgrid by default in Nightly. r=dholbert
Mats Palmgren <mats@mozilla.com> - Mon, 29 Apr 2019 20:50:23 +0200 - rev 474934
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1496502 - [css-grid-2] Enable subgrid by default in Nightly. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29254
bfc4f4f153ebb39d149595625d90da0bf7fdb86f: Bug 1466358 part 10 - [css-grid-2] Intrinsic sizing tweaks for subgrid. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 18:05:54 +0100 - rev 474933
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1466358 part 10 - [css-grid-2] Intrinsic sizing tweaks for subgrid. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29242
6e90ed77e9109d98910965bc99c93a539203f363: Bug 1466358 part 9 - [css-grid-2] Percentage basis calculation for subgrid items. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 18:05:54 +0100 - rev 474932
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1466358 part 9 - [css-grid-2] Percentage basis calculation for subgrid items. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29241
003d3db59a1fa50348b771497c0a502c62b5d53d: Bug 1466358 part 8 - [css-grid-2] Implement subgrid track sizing. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 18:05:53 +0100 - rev 474931
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1466358 part 8 - [css-grid-2] Implement subgrid track sizing. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29767
4e4f1fb1ffdd5720801f0c494c52235b4de2c17a: Bug 1466358 part 7 - [css-grid-2] Report the right number of tracks for subgrids in ComputedGridTrackInfo. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 18:05:54 +0100 - rev 474930
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1466358 part 7 - [css-grid-2] Report the right number of tracks for subgrids in ComputedGridTrackInfo. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29150
85788d6cb290c51e64934746c5a7e1356f1b4d20: Bug 1466358 part 6 - [css-grid-2] Always normalize child lists before a child list iterator is used. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 18:05:54 +0100 - rev 474929
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1466358 part 6 - [css-grid-2] Always normalize child lists before a child list iterator is used. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29149
bf5027913782ec774496550cedc51fd6e7c6a892: Bug 1466358 part 5 - [css-grid-2] Add the accumulated margin+border+padding of subgrid ancestors to a subgrid item's content contribution if it spans the relevant edge track(s). r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 18:05:53 +0100 - rev 474928
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1466358 part 5 - [css-grid-2] Add the accumulated margin+border+padding of subgrid ancestors to a subgrid item's content contribution if it spans the relevant edge track(s). r=dholbert
c619ca5a135b0422d64dd7d1d4e8430f3d22a897: Bug 1466358 part 4 - [css-grid-2] Make a subgrid contribute its accumulated margin+border+padding to its edge tracks for intrinsically sized tracks. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 18:05:53 +0100 - rev 474927
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1466358 part 4 - [css-grid-2] Make a subgrid contribute its accumulated margin+border+padding to its edge tracks for intrinsically sized tracks. r=dholbert
1a6bf3c650d7901486f83e524e3cc839f85be534: Bug 1466358 part 3 - [css-grid-2] Add methods to calculate a subgrid's margin+border+padding. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 18:05:40 +0100 - rev 474926
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1466358 part 3 - [css-grid-2] Add methods to calculate a subgrid's margin+border+padding. r=dholbert
9abb8c91398c4a898c67ba3a0da05f62cd31008f: Bug 1466358 part 2 - [css-grid-2] Add a method to recursively collect relevant items for track sizing from subgrids with their lines and state translated into the caller's coordinates (idempotent patch). r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 00:18:10 +0100 - rev 474925
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1466358 part 2 - [css-grid-2] Add a method to recursively collect relevant items for track sizing from subgrids with their lines and state translated into the caller's coordinates (idempotent patch). r=dholbert
92d9b8b245c4f87667c96752ef3c10595fe7db58: Bug 1466358 part 1 - [css-grid-2] Add grid item state bits for subgrids and items in a subgrid and set them when the item occupies the corresponding edge track (idempotent patch). r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 00:18:10 +0100 - rev 474924
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1466358 part 1 - [css-grid-2] Add grid item state bits for subgrids and items in a subgrid and set them when the item occupies the corresponding edge track (idempotent patch). r=dholbert
1f82446806faafc52c1fcc7ff57b3b5b115703c0: Bug 1465296 part 5 - [css-grid-2] Implement nested area name lookups for subgrids. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 00:18:09 +0100 - rev 474923
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1465296 part 5 - [css-grid-2] Implement nested area name lookups for subgrids. r=dholbert
67fb1683b89c252ff2a4d0e99e9b3180feb454ce: Bug 1465296 part 4 - [css-grid-2] Implement nested line name lookups for subgrids. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 00:18:09 +0100 - rev 474922
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1465296 part 4 - [css-grid-2] Implement nested line name lookups for subgrids. r=dholbert This adds a pointer to the parent grid's LineNameMap in the relevant axis and traverses that recursively when looking up line names.
6b249a6ae76aff5da8ba9ab8311fa596491b58e6: Bug 1465296 part 3 - [css-grid-2] Add a convenience method to get the parent GridContainerFrame for a subgrid. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 00:18:09 +0100 - rev 474921
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1465296 part 3 - [css-grid-2] Add a convenience method to get the parent GridContainerFrame for a subgrid. r=dholbert
386b8a935d2b83a50566ae26619b7e3bafbf672e: Bug 1465296 part 2 - [css-grid-2] Clamp lines in a subgrid to its extent. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 00:18:09 +0100 - rev 474920
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1465296 part 2 - [css-grid-2] Clamp lines in a subgrid to its extent. r=dholbert Per https://drafts.csswg.org/css-grid-2/#subgrid-implicit
6e44c9fcc9a4bced00da7c6d520e645bfbfea490: Bug 1465296 part 1 - [css-grid-2] Implement subgrid item placement. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 29 Nov 2018 00:18:09 +0100 - rev 474919
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
Bug 1465296 part 1 - [css-grid-2] Implement subgrid item placement. r=dholbert
aa35720a213212373e03effdd8f7c406a3dcb0c9: Bug 1552911 - Tweak the internal C++ constructor of ResizeObserverEntry to require aBorderBoxSize and aContentBoxSize. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Tue, 21 May 2019 19:28:21 +0000 - rev 474849
Push 36047 by nerli@mozilla.com at Wed, 22 May 2019 03:40:58 +0000
Bug 1552911 - Tweak the internal C++ constructor of ResizeObserverEntry to require aBorderBoxSize and aContentBoxSize. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D32031
b9ce11f1880ab7650c4ed80b097a6a440a9d5453: Bug 1552911 - Drop the constructor of ResizeObserverEntry. r=dholbert,smaug
Boris Chiou <boris.chiou@gmail.com> - Tue, 21 May 2019 18:17:16 +0000 - rev 474848
Push 36047 by nerli@mozilla.com at Wed, 22 May 2019 03:40:58 +0000
Bug 1552911 - Drop the constructor of ResizeObserverEntry. r=dholbert,smaug There is a spec issue about should we expose this API: https://github.com/w3c/csswg-drafts/issues/3946 It's no clear that should we really need this API, so let's match Chromium for now. Differential Revision: https://phabricator.services.mozilla.com/D31891
cb4e5f7609686f3255646b9a3904e4737e7bcebf: Bug 1550729 - Enable column-span pref for contain-size-multicol-{002,003}.html individually. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 10 May 2019 19:48:53 +0000 - rev 473469
Push 35998 by rmaries@mozilla.com at Sat, 11 May 2019 09:44:50 +0000
Bug 1550729 - Enable column-span pref for contain-size-multicol-{002,003}.html individually. r=dholbert CSS containment is enabled on early beta or earlier. Using "default-preferences" to flip column-span pref overrides CSS containment's pref at the first line in the reftest.list, which make the two test fail on late beta. Differential Revision: https://phabricator.services.mozilla.com/D30674
41a34b64ca1798f76f0781978d0d1c9d764d9a1a: Bug 1550629 - Fix comments mentioning GetAvailableSpace. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 10 May 2019 21:06:48 +0000 - rev 473466
Push 35998 by rmaries@mozilla.com at Sat, 11 May 2019 09:44:50 +0000
Bug 1550629 - Fix comments mentioning GetAvailableSpace. r=dholbert GetAvailableSpace was renamed to GetFloatAvailableSpace in bug 25888. DONTBUILD because this is a comment-only change. Differential Revision: https://phabricator.services.mozilla.com/D30581
2c165cc039113c935d13a630528173f2e34cdfe2: Bug 1545309 - Run ResizeObserver eventloop test after loading successfully. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Mon, 06 May 2019 22:53:09 +0000 - rev 473176
Push 35990 by nerli@mozilla.com at Thu, 09 May 2019 15:34:57 +0000
Bug 1545309 - Run ResizeObserver eventloop test after loading successfully. r=dholbert In test0(), we use the callback of `requestAnimationFrame` to know in which eventloop (i.e. `Tick()`) we are. However, we may not trigger the callback of `requestAnimationFrame` if we are not visible. This is an optimization in Bug 1145439. Detail: We use `Document::ShouldThrottleFrameRequests()` to check if we should throttle the frame requests in the current `Tick()`. This function returns true if we didn't get painted during the last paint, so we are not visible, so throttle the frame requests. Note that because we have to paint this document at least once to unthrottle it, we will drop one `requestAnimationFrame` frame when a document that previously wasn't visible scrolls into view. Therefore, we should make sure we got the first paint before running test0(). Using onload is not perfect, but we don't have other better choose for now. Differential Revision: https://phabricator.services.mozilla.com/D29772
57b5cbfc0d7a0857e896d0a41c366fc7a4d77da0: Bug 1545309 - Make test function independent from others in eventloop.html. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Mon, 06 May 2019 22:52:54 +0000 - rev 473175
Push 35990 by nerli@mozilla.com at Thu, 09 May 2019 15:34:57 +0000
Bug 1545309 - Make test function independent from others in eventloop.html. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29904
6cc70607d8afbe3a56fc6a3f3bc6544da4c8dba5: Bug 1494100 Part 3 - Implement "contain:size" for ColumnSetWrapperFrame. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 22:58:39 +0000 - rev 473174
Push 35990 by nerli@mozilla.com at Thu, 09 May 2019 15:34:57 +0000
Bug 1494100 Part 3 - Implement "contain:size" for ColumnSetWrapperFrame. r=dholbert Add multicol-width-004.html and multicol-width-005.html to test "width: min-content" and "width: max-content" with column-span:all children. There's no size containment in these tests. Note it may be worth to reuse nsBlockFrame's mCachedMinISize and mCachedPrefISize to cache intrinsic size for ColumnSetWrapperFrame, but this can be done separately. Differential Revision: https://phabricator.services.mozilla.com/D29616
93fd1b5a5a025a54f109c8ab76d17ee1e6f860d1: Bug 1494100 Part 2 - Check column-span pref before checking the size containment in nsColumnSetFrame. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 22:49:40 +0000 - rev 473173
Push 35990 by nerli@mozilla.com at Thu, 09 May 2019 15:34:57 +0000
Bug 1494100 Part 2 - Check column-span pref before checking the size containment in nsColumnSetFrame. r=dholbert If column-span is enabled, nsColumnSetFrame becomes an inner frame under ColumnSetWrapperFrame, and that outer frame is then where we should be handling size containment. This patch doesn't change the logic but make the logic easier to simplify once we start eliminating column-span pref. Differential Revision: https://phabricator.services.mozilla.com/D29615
e77c2a2c5d8238d23de731605789269873ecd97e: Bug 1494100 Part 1 - Create ColumnUtils, and extract utility functions in nsColumnSetFrame into it. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 22:49:31 +0000 - rev 473172
Push 35990 by nerli@mozilla.com at Thu, 09 May 2019 15:34:57 +0000
Bug 1494100 Part 1 - Create ColumnUtils, and extract utility functions in nsColumnSetFrame into it. r=dholbert The functions move to ColumnUtils will be used by ColumnSetWrapperFrame to implement GetPrefISize() and GetMinISize(). Also, I verify locally that non-unified build is still working by s/UNIFIED_SOURCES/SOURCES/ in layout/generic/moz.build. Differential Revision: https://phabricator.services.mozilla.com/D29614
c2250a23fd66e3c812cb023c2d12f6f5e8d5a2f2: Bug 866102 - Implement -webkit-line-clamp. r=mats,emilio,dholbert
Cameron McCormack <cam@mcc.id.au> - Thu, 09 May 2019 02:32:30 +0000 - rev 473164
Push 35990 by nerli@mozilla.com at Thu, 09 May 2019 15:34:57 +0000
Bug 866102 - Implement -webkit-line-clamp. r=mats,emilio,dholbert Differential Revision: https://phabricator.services.mozilla.com/D20115
a0c91ab4d3477cdb041c00dee13354cafafb83fd: Bug 1545239 - Unobserve the target if using a different observed box. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Wed, 08 May 2019 20:54:43 +0000 - rev 473154
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1545239 - Unobserve the target if using a different observed box. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D30129
b34ea6abce97b002de66d2d0376b84e347f3151a: Bug 1545239 - Add tests for border-box and different writing modes. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Wed, 08 May 2019 21:27:55 +0000 - rev 473153
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1545239 - Add tests for border-box and different writing modes. r=dholbert 1. Add new tests with an extra argument of "content-box"/"border-box" in observe(), and test contectBoxSize and borderBoxSize. 2. Add a new test for changing the writing mode. Changing writing mode makes the element change the orientation, but the logical box size is still the same, so we shouldn't fire the event. Differential Revision: https://phabricator.services.mozilla.com/D28739
01338a1e26b7d838ddd591fca9a7495e338c6c96: Bug 1545239 - Make each test cases independent in resize-observer/observe.html. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Wed, 08 May 2019 20:54:39 +0000 - rev 473152
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1545239 - Make each test cases independent in resize-observer/observe.html. r=dholbert I think it's better to make sure each test is independent from others, so we create elements inside each test function. (Only change observe.html because I touch only this file in this bug.) Differential Revision: https://phabricator.services.mozilla.com/D29889
dc3570e93c4150f913a20baa6ee42c109ab85d60: Bug 1545239 - Update ResizeObserver and ResizeObserverEntry. r=smaug,dholbert
Boris Chiou <boris.chiou@gmail.com> - Wed, 08 May 2019 20:54:36 +0000 - rev 473151
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1545239 - Update ResizeObserver and ResizeObserverEntry. r=smaug,dholbert In this patch, we support 1. content-box (default) 2. border-box And let ResizeObserverEntry expose these box sizes. Besides, we store the mLastReportedSize as the logical size. Differential Revision: https://phabricator.services.mozilla.com/D28737
2e3522f77b0f686663145bdce20ffceef3909896: Bug 1545239 - Move GetNodeDepth into ResizeObserver.cpp r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Wed, 08 May 2019 20:52:51 +0000 - rev 473150
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1545239 - Move GetNodeDepth into ResizeObserver.cpp r=dholbert GetNodeDepth() is a special version for ResizeObserver to get the depth of node (across Shadow DOM). Based on the comment in D27615, it's better to move it into ResizeObserver.cpp. Differential Revision: https://phabricator.services.mozilla.com/D28736
e99ec6c4418fd17cba92ea8a8b7d5160f4cf3285: Bug 1548341 - Convert NS_STYLE_BORDER to an enum class in nsStyleConsts.h. r=dholbert
Jeremy Ir <jir.opensource@gmail.com> - Sun, 05 May 2019 23:39:27 +0000 - rev 472637
Push 35970 by malexandru@mozilla.com at Mon, 06 May 2019 09:47:52 +0000
Bug 1548341 - Convert NS_STYLE_BORDER to an enum class in nsStyleConsts.h. r=dholbert Converting the NS_STYLE_BORDER definitions in to enumerated classes as per bug 1277133. The original constants broke the convention used by the rest of the definitions as the CSS property being described is `border-collapse`, so corrections were made with the migration to the enumerated class. Differential Revision: https://phabricator.services.mozilla.com/D29951
451701e88d92935b77385235832865dabe8c2942: Bug 1547792 - AspectRatio should be a single ratio, not a size. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 02 May 2019 23:28:21 +0000 - rev 472436
Push 35956 by dluca@mozilla.com at Fri, 03 May 2019 12:59:14 +0000
Bug 1547792 - AspectRatio should be a single ratio, not a size. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29244
d077a01ccd637475a32bfe4ae92ea25f2cc84e14: Bug 1548126 - Mark known existing reftests failures with column-span enabled. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 02 May 2019 21:41:33 +0000 - rev 472420
Push 35956 by dluca@mozilla.com at Fri, 03 May 2019 12:59:14 +0000
Bug 1548126 - Mark known existing reftests failures with column-span enabled. r=dholbert Due to the syntax limitation in failures.list, I cannot mark multicol-rule-004.xht as fails with column-span enabled and success with column-span disabled simultaneously. Luckily, we had another copy of it in testing/web-platform/tests/css/css-multicol/multicol-rule-004.xht, We can use it to test with column-span disabled for now. Differential Revision: https://phabricator.services.mozilla.com/D29419
704947d53e4c48d1b6f208eb551bb35207fb10ca: Bug 1521253 - Request longer timeouts in two tests that frequently time out in the Android emulator. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 02 May 2019 15:19:10 +0000 - rev 472365
Push 35954 by rgurzau@mozilla.com at Fri, 03 May 2019 04:14:31 +0000
Bug 1521253 - Request longer timeouts in two tests that frequently time out in the Android emulator. r=dholbert Bug 1547939 added a bunch of extra tests for three properties (background, mask, and -webkit-mask). This made them time out more frequently in the Android emulator. Request a longer timeout to address this. Alternative is maybe just removing the tests or such, I don't think they're of particularly great value. Differential Revision: https://phabricator.services.mozilla.com/D29650
7187fa20af85cdba63c2c7ea2925df74faadf549: Bug 1548057 - Properly unregister the resize observer helpers when the shell goes away. r=dholbert,boris
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 30 Apr 2019 19:44:55 +0000 - rev 472118
Push 35948 by nerli@mozilla.com at Wed, 01 May 2019 21:55:33 +0000
Bug 1548057 - Properly unregister the resize observer helpers when the shell goes away. r=dholbert,boris Need to write a test for this. Also, as a matter of preventive measure, null out mOwner when it dies. That may matter in the case where the controller dies while the observer is getting notified. In that case, somebody still keeps a reference to the controller. Right now is fine because nothing will touch it again (the destructor doesn't), but that's not great, and it's better to just clear the pointer. Differential Revision: https://phabricator.services.mozilla.com/D29395
a5c14dc63aa6449d97c1a73918b7b6fbf33735c0: Bug 1547922 part 2 - Add some grid layout tests. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 30 Apr 2019 10:21:30 +0200 - rev 472092
Push 35947 by apavel@mozilla.com at Wed, 01 May 2019 15:57:23 +0000
Bug 1547922 part 2 - Add some grid layout tests. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29325
3de2f935e2d2658dda91deba799149ee29ce3837: Bug 1547922 part 1 - Fix broken flex layout tests. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 30 Apr 2019 10:03:29 +0200 - rev 472091
Push 35947 by apavel@mozilla.com at Wed, 01 May 2019 15:57:23 +0000
Bug 1547922 part 1 - Fix broken flex layout tests. r=dholbert The flex item tests in this file are completely broken... First, there's a typo in the flex container style when concatenating: "... teal" + containerSizeDecl since you end up with "... tealinline-size:..." etc. Second, none of the tests actaully test anything at all, which you can see by removing the "+ subtest.candStyle" part on the reflow root candidate -- the test still pass! The reason for that is that its child (inner) has a solid purple border so when changing its size it will render differently and make the test pass regardless of any change that we intended to test. After fixing those two bugs it turns out that two of the subtests don't produce a rendering change at all, so those tests are bogus and needs to be rewritten. (I'm commenting them out for now.) Differential Revision: https://phabricator.services.mozilla.com/D29324
a484a2625d18c038723fad2c4032f7859fc51bc3: Bug 1547939 - Add a pref for a simpler -moz- gradient parsing. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 30 Apr 2019 19:48:27 +0000 - rev 472013
Push 35945 by ccoroiu@mozilla.com at Wed, 01 May 2019 04:21:12 +0000
Bug 1547939 - Add a pref for a simpler -moz- gradient parsing. r=dholbert This won't reintroduce any of the regressions that were triggered by our previous attempts to turn off -moz prefixed gradients, and lets us massively simplify the gradient code, if it sticks. Differential Revision: https://phabricator.services.mozilla.com/D29346
1181d18ea08c28012dea5243f24ca38df9d88dab: Bug 1542646 Part 13 - Make function declaration and definition parameter names match r=dholbert
longsonr <longsonr@gmail.com> - Sat, 27 Apr 2019 08:57:50 +0100 - rev 471656
Push 35924 by rmaries@mozilla.com at Sat, 27 Apr 2019 21:40:42 +0000
Bug 1542646 Part 13 - Make function declaration and definition parameter names match r=dholbert
b86894409b1b4481691a82b33f3107254511591c: Bug 1272409 - Part 5: Update test meta. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Fri, 26 Apr 2019 20:29:20 +0000 - rev 471594
Push 35921 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:45:52 +0000
Bug 1272409 - Part 5: Update test meta. r=dholbert In idlharness.window.js, ResizeObservation is not an public interface in the current spec, so the test should be updated. In eventloop.html, unfortunately, there are two issues: 1. The test framework will be timeout if there is any `assert_equals()` failed. We should rewrite it. 2. Actually, we only have one failure in this test file: `assert_equals(helper.rafCount, 1, "new loop");` in test0. We fire this event in the next Tick(), but we call the callback of `requestAnimationFrame()` after several Tick()s, so `helper.rafCount` is still 0 in this case. This may be a bug of the test because using `requestAnimationFrame()` cannot reflect the next event loop, or our scheduling of ResizeObserver is not correct. Note: this assert_equal() was added by Google, not by Fariskhi. Differential Revision: https://phabricator.services.mozilla.com/D27619
87c7a189cbe0d917f6579f796e43a8e5c29e7681: Bug 1272409 - Part 4: Integrate ResizeObserver with Document and reflow. r=dholbert,smaug
Fariskhi Vidyan <farislab@gmail.com> - Fri, 26 Apr 2019 20:29:18 +0000 - rev 471593
Push 35921 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:45:52 +0000
Bug 1272409 - Part 4: Integrate ResizeObserver with Document and reflow. r=dholbert,smaug Depends on D27617 Differential Revision: https://phabricator.services.mozilla.com/D27618
0b7728e6fcda89443d3d580fe108f74a193c3b1c: Bug 1272409 - Part 3: Add ResizeObserverController. r=dholbert,smaug
Fariskhi Vidyan <farislab@gmail.com> - Fri, 26 Apr 2019 20:29:16 +0000 - rev 471592
Push 35921 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:45:52 +0000
Bug 1272409 - Part 3: Add ResizeObserverController. r=dholbert,smaug Use ResizeObserverController to schedule the observers and manage them. Document will hold this controller in the later patch. Depends on D27616 Differential Revision: https://phabricator.services.mozilla.com/D27617
b634a26d0c2ed0efe2e7739b24aafcbf5820c058: Bug 1272409 - Part 2: Add ResizeObserver webidl and implementation. r=dholbert,smaug
Fariskhi Vidyan <farislab@gmail.com> - Fri, 26 Apr 2019 20:29:14 +0000 - rev 471591
Push 35921 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:45:52 +0000
Bug 1272409 - Part 2: Add ResizeObserver webidl and implementation. r=dholbert,smaug This implements the first version of spec, so the webidl file doesn't match the current spec and we will fix them in the follow-up bugs. i.e. 1. The default observer box is content-box. 2. `ResizeObserverBoxOptions`, `ResizeObserverOptions`, and `ResizeObserverSize` are not included in `ResizeObserver.webidl`. 3. `ResizeObserverEntry` doesn't have `borderBoxSize` and `contentBoxSize` attributes. Depends on D27615 Differential Revision: https://phabricator.services.mozilla.com/D27616
7b8695f2ca823fd8fa6e89d7327c7a2652a7ac51: Bug 1272409 - Fix fuzzy unified build failed after adding new files into dom/base. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Fri, 26 Apr 2019 20:29:30 +0000 - rev 471589
Push 35921 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:45:52 +0000
Bug 1272409 - Fix fuzzy unified build failed after adding new files into dom/base. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D28934