searching for reviewer(dholbert)
02aeefba2bce0e142979ec9f8aa8c37b55778306: Bug 1709491 Part 3 - Fix Subgrid::mMarginBorderPadding when the subgrid is a scroll frame. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 12 May 2021 06:32:41 +0000 - rev 579447
Push 38456 by nbeleuzu@mozilla.com at Wed, 12 May 2021 09:42:13 +0000
Bug 1709491 Part 3 - Fix Subgrid::mMarginBorderPadding when the subgrid is a scroll frame. r=dholbert When `aGridFrame.mFrame` is a scroll frame, the inner scrolled frame `subgridFrame` only has padding, but no margin nor border. We should add margin and border from the outer scroll frame to `mMarginBorderPadding` so that the grid area of the subgrid is computed correctly. Differential Revision: https://phabricator.services.mozilla.com/D114546
d90d530ebb5d4fd2a494f0a7a79ecbfdbf1cedce: Bug 1709491 Part 2 - Simplify Subgrid::mMarginBorderPadding computation. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 12 May 2021 06:32:40 +0000 - rev 579446
Push 38456 by nbeleuzu@mozilla.com at Wed, 12 May 2021 09:42:13 +0000
Bug 1709491 Part 2 - Simplify Subgrid::mMarginBorderPadding computation. r=dholbert SizeComputationInput's logical margin and border&padding getters accept arbitrary writing mode, so we can operate on `cbWM` directly without using physical coordinates. This patch is a preparation of the next part, and it shouldn't change the behavior. Differential Revision: https://phabricator.services.mozilla.com/D114545
4c5d0ee7fbe47b41d3dcbd667b2b69262da505e7: Bug 1709491 Part 1 - Add SizeComputationInput::ComputedLogicalBorder(), and adapt callers. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 12 May 2021 06:32:40 +0000 - rev 579445
Push 38456 by nbeleuzu@mozilla.com at Wed, 12 May 2021 09:42:13 +0000
Bug 1709491 Part 1 - Add SizeComputationInput::ComputedLogicalBorder(), and adapt callers. r=dholbert The helper is going to be used in a later part. I don't add the physical version ComputedPhysicalBorder() deliberately because I don't want to promote the usage of physical coordinate. Differential Revision: https://phabricator.services.mozilla.com/D114544
b110e23dbb1a8114923d9c56ec0e73b92d6aa439: Bug 1709062 - Minor cleanups to nsDOMWindowUtils::CompareCanvases. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 May 2021 17:48:19 +0000 - rev 578325
Push 38430 by cbrindusan@mozilla.com at Mon, 03 May 2021 21:42:10 +0000
Bug 1709062 - Minor cleanups to nsDOMWindowUtils::CompareCanvases. r=dholbert Warn when some of the pre-conditions fail and such, so that it's easy to see what's going wrong without having to use a debugger. Remove some useless null-checks (we were dealing with null arguments anyways, and the return value is never null). Depends on D114078 Differential Revision: https://phabricator.services.mozilla.com/D114079
f3e98d3f836c5224d9a9590d00f96149c8425e8a: Bug 1709062 - Make printpreview_helper use a fixed viewport width. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 May 2021 17:48:18 +0000 - rev 578324
Push 38430 by cbrindusan@mozilla.com at Mon, 03 May 2021 21:42:10 +0000
Bug 1709062 - Make printpreview_helper use a fixed viewport width. r=dholbert Recently (due to probably a system upgrade) this test fails locally for me with an exception in compareCanvases(), because the two preview windows aren't always the same size. This is more reliable, faster, more similar to what we actually do in print preview, and more easily debuggable. Differential Revision: https://phabricator.services.mozilla.com/D114078
fb14e6d29a44a79efc296cc727f92aa58ea4dacc: Bug 1703304 - Compute transferred size suggestion only if a flex item is a replaced element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 30 Apr 2021 20:49:19 +0000 - rev 578234
Push 38423 by cbrindusan@mozilla.com at Sat, 01 May 2021 09:32:51 +0000
Bug 1703304 - Compute transferred size suggestion only if a flex item is a replaced element. r=dholbert If the flex item is a non-replaced element and its min-width/min-height is 'auto', the spec has changed so that it has no transferred size suggestion now. https://drafts.csswg.org/css-flexbox-1/#min-size-auto This patch also updates WPT tests to fix https://github.com/web-platform-tests/wpt/issues/27878 Differential Revision: https://phabricator.services.mozilla.com/D112830
0e6e8633e49e9f9dd192e33502b965983ebb093d: Bug 1707977 - Null-check print data in nsPrintJob::DoPrint. r=layout-reviewers,dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 29 Apr 2021 17:03:00 +0000 - rev 578020
Push 38419 by nbeleuzu@mozilla.com at Thu, 29 Apr 2021 21:42:31 +0000
Bug 1707977 - Null-check print data in nsPrintJob::DoPrint. r=layout-reviewers,dholbert It's unclear how this can happen (the caller also null-checks, but then again it also reconstructs a bunch of stuff, so...). Differential Revision: https://phabricator.services.mozilla.com/D113815
a2e246a3805c2021f4eb2ebf0c5e634029d5976f: Bug 1707070 - Tweak text/number/search control anonymous tree DOM / paint order. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 26 Apr 2021 16:55:32 +0000 - rev 577514
Push 38408 by csabou@mozilla.com at Mon, 26 Apr 2021 21:31:58 +0000
Bug 1707070 - Tweak text/number/search control anonymous tree DOM / paint order. r=dholbert So that we hit-test the spinners even if they overlap with the editor root's padding. Differential Revision: https://phabricator.services.mozilla.com/D113251
86a3067d7a44cae4b2ab2bdf030821c8c351aa89: Bug 1706200 - Rename childrenInflowBounds to flexItemMarginBoxBounds in nsFlexContainerFrame::Reflow(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 20 Apr 2021 21:40:07 +0000 - rev 576848
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1706200 - Rename childrenInflowBounds to flexItemMarginBoxBounds in nsFlexContainerFrame::Reflow(). r=dholbert Also, change the loop so that it iterates over flex items because mFrames can contain out-of-flow placeholders which are not flex items. This doesn't change the behavior because the out-of-flow placeholders doesn't have any overflow areas (unless we fixed bug 1460484). Differential Revision: https://phabricator.services.mozilla.com/D112672
aecf24e96348c578da7a19f539de35951d3b7288: Bug 1705877 - Apply image-set resolution for cursors on Windows and Mac. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 20 Apr 2021 14:21:25 +0000 - rev 576772
Push 38391 by ncsoregi@mozilla.com at Tue, 20 Apr 2021 21:39:49 +0000
Bug 1705877 - Apply image-set resolution for cursors on Windows and Mac. r=dholbert This required more refactoring so it seemed sensible to split it out. GTK doesn't seem to provide an API for scaled cursors so we get pixelated cursors instead. Differential Revision: https://phabricator.services.mozilla.com/D112676
9141b021cbeda90952fe2fffd11b0b7383ac696e: Bug 1705877 - Introduce nsIWidget::Cursor. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 20 Apr 2021 09:47:32 +0000 - rev 576741
Push 38391 by ncsoregi@mozilla.com at Tue, 20 Apr 2021 21:39:49 +0000
Bug 1705877 - Introduce nsIWidget::Cursor. r=dholbert This removes some sketchy non-caching of cursors on windows while at it, now that plugins are gone, but otherwise shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D112475
652bf5d7540d91c0265b63c234d069253b81e522: Bug 1705877 - image-set() should influence intrinsic size of the image. r=dholbert,layout-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Apr 2021 19:55:27 +0000 - rev 576641
Push 38390 by imoraru@mozilla.com at Tue, 20 Apr 2021 09:51:22 +0000
Bug 1705877 - image-set() should influence intrinsic size of the image. r=dholbert,layout-reviewers https://drafts.csswg.org/css-images-4/#image-set-notation has: > [...] it also specifies the image’s natural resolution, overriding any other > source of data that might supply a natural resolution. Astounding that there was literally no WPT for this at all. I added three: one for backgrounds, one for list-style-image, and one for `content`. Cursor is not handled on this patch because that one requires a fair amount of extra work. Differential Revision: https://phabricator.services.mozilla.com/D112474
52a2586bc322ece5ebb877f5ac67697c54037e6a: Bug 1704155 - Remove dead prefers-color-scheme: no preference code. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Apr 2021 18:02:49 +0000 - rev 575284
Push 38359 by nbeleuzu@mozilla.com at Sat, 10 Apr 2021 03:36:58 +0000
Bug 1704155 - Remove dead prefers-color-scheme: no preference code. r=dholbert It was removed in bug 1643656. Differential Revision: https://phabricator.services.mozilla.com/D111461
0a7c8dffbf58e4d76396c3f24cb57f8e4410b040: Bug 1703987 - Measure percentage stroke-widths on text/non-text svg content. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Apr 2021 13:07:07 +0000 - rev 575209
Push 38359 by nbeleuzu@mozilla.com at Sat, 10 Apr 2021 03:36:58 +0000
Bug 1703987 - Measure percentage stroke-widths on text/non-text svg content. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D111353
bbce2c52a8860e66f57a7d06b14598c85d36c1be: Bug 1699892 - Allow the Firefox Accounts avatar server to use SVG context properties. r=dholbert
Mike Conley <mconley@mozilla.com> - Thu, 08 Apr 2021 01:48:07 +0000 - rev 574913
Push 38356 by archaeopteryx@coole-files.de at Thu, 08 Apr 2021 09:51:11 +0000
Bug 1699892 - Allow the Firefox Accounts avatar server to use SVG context properties. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D111169
55914d0004bbb8e39f0e468d42db5afdf672dd9a: Bug 1701645 - adjust Windows max different in test_printpreview.xhtml to pass with proton, r=dholbert
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 29 Mar 2021 20:41:52 +0000 - rev 573622
Push 38332 by malexandru@mozilla.com at Tue, 30 Mar 2021 03:50:59 +0000
Bug 1701645 - adjust Windows max different in test_printpreview.xhtml to pass with proton, r=dholbert Proton changes the vertical size of the browser chrome which changes the size of the content area, which in turn affects the fuzz/difference factor required for this test on Windows. Differential Revision: https://phabricator.services.mozilla.com/D110112
73d7981be8797dcb59e2c097c16f5b3d07b5b1da: Bug 1700472 - Remove -moz-scrolled-page-sequence. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 24 Mar 2021 11:21:14 +0000 - rev 572834
Push 38318 by cbrindusan@mozilla.com at Thu, 25 Mar 2021 03:42:26 +0000
Bug 1700472 - Remove -moz-scrolled-page-sequence. r=dholbert This is needed for bug 1700379, because otherwise we create a reference frame with the root's scrolled content (the ::-moz-scrolled-page-sequence), and that breaks some display list invariants. Always create a canvas frame instead, (doesn't matter when printing since we print off the page sequence frame directly), and create a single ::-moz-page-sequence box. We have to add width: 100% to the UA sheet because we don't get it automatically set to the scrollport size to by the scrollport anymore. Otherwise this would regress vertical writing-modes. Differential Revision: https://phabricator.services.mozilla.com/D109512
8986f83f55e90ffa72e1f1fb06f7d7d3b7aaa17a: Bug 1700472 - Add braces to SetPaginatedScrolling. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 24 Mar 2021 10:13:26 +0000 - rev 572828
Push 38318 by cbrindusan@mozilla.com at Thu, 25 Mar 2021 03:42:26 +0000
Bug 1700472 - Add braces to SetPaginatedScrolling. r=dholbert Drive-by fixup while I was reading related code. Depends on D109545 Differential Revision: https://phabricator.services.mozilla.com/D109546
5b0c17b9e247c79bf8c38acc78aebee32e62d767: Bug 1700472 - Minor cleanup in ConstructDocElementFrame. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 24 Mar 2021 10:13:25 +0000 - rev 572827
Push 38318 by cbrindusan@mozilla.com at Thu, 25 Mar 2021 03:42:26 +0000
Bug 1700472 - Minor cleanup in ConstructDocElementFrame. r=dholbert No behavior change, just compute the different things we need upfront. At first I was going to use this in the following patch but it ended up not being needed. Differential Revision: https://phabricator.services.mozilla.com/D109545
df4d74e9669fb82a66746ea58f2216e88c7dbbf3: Bug 1700472 - Remove -moz-scrolled-page-sequence. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 23 Mar 2021 22:31:08 +0000 - rev 572778
Push 38314 by abutkovits@mozilla.com at Wed, 24 Mar 2021 04:07:32 +0000
Bug 1700472 - Remove -moz-scrolled-page-sequence. r=dholbert This is needed for bug 1700379, because otherwise we create a reference frame with the root's scrolled content (the ::-moz-scrolled-page-sequence), and that breaks some display list invariants. Always create a canvas frame instead, (doesn't matter when printing since we print off the page sequence frame directly), and create a single ::-moz-page-sequence box. Differential Revision: https://phabricator.services.mozilla.com/D109512
ec476bf43984e5890b7a67647bfcbe09fe192ae8: Bug 1700472 - Add braces to SetPaginatedScrolling. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 23 Mar 2021 22:31:07 +0000 - rev 572777
Push 38314 by abutkovits@mozilla.com at Wed, 24 Mar 2021 04:07:32 +0000
Bug 1700472 - Add braces to SetPaginatedScrolling. r=dholbert Drive-by fixup while I was reading related code. Depends on D109545 Differential Revision: https://phabricator.services.mozilla.com/D109546
168b31448423d31ac4ac20ad9469fba0df9bf599: Bug 1700472 - Minor cleanup in ConstructDocElementFrame. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 23 Mar 2021 22:31:07 +0000 - rev 572776
Push 38314 by abutkovits@mozilla.com at Wed, 24 Mar 2021 04:07:32 +0000
Bug 1700472 - Minor cleanup in ConstructDocElementFrame. r=dholbert No behavior change, just compute the different things we need upfront. At first I was going to use this in the following patch but it ended up not being needed. Differential Revision: https://phabricator.services.mozilla.com/D109545
1245e772d2de6ac472460e2d74cd76eef430f975: Bug 1696721 part 3 - Fix intrinsic isize calculation for ruby frame. r=dholbert
Xidorn Quan <me@upsuper.org> - Tue, 23 Mar 2021 10:26:17 +0000 - rev 572569
Push 38313 by apavel@mozilla.com at Tue, 23 Mar 2021 21:43:59 +0000
Bug 1696721 part 3 - Fix intrinsic isize calculation for ruby frame. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D109228
00afc841497293ea739793df69e7db1ddb577f57: Bug 1696721 part 2 - Refactor DoIntrinsicInlineISize to make it accept a function for handling children. r=dholbert
Xidorn Quan <me@upsuper.org> - Tue, 23 Mar 2021 10:26:17 +0000 - rev 572568
Push 38313 by apavel@mozilla.com at Tue, 23 Mar 2021 21:43:59 +0000
Bug 1696721 part 2 - Refactor DoIntrinsicInlineISize to make it accept a function for handling children. r=dholbert While nsInlineFrame and nsFirstLetterFrame are going to continue sharing the same code, nsRubyFrame will use the refactored version to compute its intrinsic sizes. This way we can also eliminate the need for checking the intrinsic type inside the function. This patch shouldn't change behavior. It's just a refactoring of existing code. Differential Revision: https://phabricator.services.mozilla.com/D109227
43ae915dc91a222a7eda8916b7982f2749a223bd: Bug 1696721 part 1 - Fix incorrect span sizing on ruby with border / padding. r=dholbert
Xidorn Quan <me@upsuper.org> - Tue, 23 Mar 2021 10:26:16 +0000 - rev 572567
Push 38313 by apavel@mozilla.com at Tue, 23 Mar 2021 21:43:59 +0000
Bug 1696721 part 1 - Fix incorrect span sizing on ruby with border / padding. r=dholbert This issue is revealed by the test for this bug in a later part, so it's also covered by that test. Differential Revision: https://phabricator.services.mozilla.com/D109226
94323c03b3da46afb965744af83cb6acfa92fc63: Bug 1697349 - Incorporate flex item's margin and flex container's padding when computing flex container's overflow area. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 22 Mar 2021 18:24:46 +0000 - rev 572439
Push 38311 by btara@mozilla.com at Tue, 23 Mar 2021 05:39:48 +0000
Bug 1697349 - Incorporate flex item's margin and flex container's padding when computing flex container's overflow area. r=dholbert This patch incorporates flex item's margin and flex container's padding when computing flex container's overflow area in both the inline axis and block axis. overflow-top-left.html starts to fail because the test has flex items with margin contributing to the overflow area now. We leave the test unchanged for now until the webcompat situation is clear (Bug1698428). flexbox-overflow-padding-002.html is based on flexbox-overflow-padding-001.html with `writing-mode: vertical-rl` and `direction: rtl` added to `.flexContainer`. Differential Revision: https://phabricator.services.mozilla.com/D107936
a836a820c2507c499e57fcddc1be4f451a63f151: Bug 1694887 - adjust reftest fuzzy annotations r=dholbert DONTBUILD
Andreea Pavel <apavel@mozilla.com> - Sun, 21 Mar 2021 16:14:46 +0000 - rev 572300
Push 38305 by abutkovits@mozilla.com at Sun, 21 Mar 2021 21:37:36 +0000
Bug 1694887 - adjust reftest fuzzy annotations r=dholbert DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D109236
973d2593ee6bac646928b3d33a82abc9672dfc5e: Bug 1699327 - Add nsIFrame::GetMarginRect(), and comparison operators for LogicalMargin. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 18 Mar 2021 01:06:03 +0000 - rev 571715
Push 38295 by btara@mozilla.com at Thu, 18 Mar 2021 04:15:43 +0000
Bug 1699327 - Add nsIFrame::GetMarginRect(), and comparison operators for LogicalMargin. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D107935
ee2d5307eb49b95bb8ebce0363620188bd1a6292: Bug 1699240 - Add print.css stylesheet to print reftest to suppress default footer text (because the timestamp is potentially problematic). r=dholbert
Jonathan Kew <jkew@mozilla.com> - Wed, 17 Mar 2021 20:01:05 +0000 - rev 571675
Push 38295 by btara@mozilla.com at Thu, 18 Mar 2021 04:15:43 +0000
Bug 1699240 - Add print.css stylesheet to print reftest to suppress default footer text (because the timestamp is potentially problematic). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D108839
cd2de0b19fcd8b97527a048af1093e0dcd88a744: Bug 1698477 - Prevent spin buttons from creating overflow. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 16 Mar 2021 22:08:48 +0000 - rev 571509
Push 38293 by malexandru@mozilla.com at Wed, 17 Mar 2021 09:53:31 +0000
Bug 1698477 - Prevent spin buttons from creating overflow. r=dholbert This matches pre-existing behavior. Differential Revision: https://phabricator.services.mozilla.com/D108608
349d5ef73d06c4c2268fc03b2510abc6b79d9a4c: Bug 1698821 - Remove dead GetNumberControlFrameForTextField. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 16 Mar 2021 21:53:20 +0000 - rev 571508
Push 38293 by malexandru@mozilla.com at Wed, 17 Mar 2021 09:53:31 +0000
Bug 1698821 - Remove dead GetNumberControlFrameForTextField. r=dholbert There's no anonymous textfield since a long time ago. Differential Revision: https://phabricator.services.mozilla.com/D108655
c89f4fbacc3ad7098cb3c919fee77a8c869b4c1a: Bug 1698821 - Fix GetNumberControlFrameForSpinButton. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 16 Mar 2021 21:53:20 +0000 - rev 571507
Push 38293 by malexandru@mozilla.com at Wed, 17 Mar 2021 09:53:31 +0000
Bug 1698821 - Fix GetNumberControlFrameForSpinButton. r=dholbert It broke with bug 1698043 because we removed one wrapper. Differential Revision: https://phabricator.services.mozilla.com/D108654
79889167c88ec89414e2ab997fab20e261195033: Bug 1698821 - Simplify native-appearance-disabling for number spinners. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 16 Mar 2021 21:53:20 +0000 - rev 571506
Push 38293 by malexandru@mozilla.com at Wed, 17 Mar 2021 09:53:31 +0000
Bug 1698821 - Simplify native-appearance-disabling for number spinners. r=dholbert The root cause of this bug is that we're now accidentally using the native theme for the spinners because GetNumberControlFrameForSpinButton broke with my changes. These pseudos are not exposed to content, and there's just one user of this pseudo-class (the print.css one). So just disable native appearance explicitly and remove that check. Differential Revision: https://phabricator.services.mozilla.com/D108653
f1ae93d282f6eed8537eedf87afea7aeff696971: Bug 1698680 - Add nsLayoutUtils::GetCrossDocParentFrameInProcess(). r=dholbert
Botond Ballo <botond@mozilla.com> - Tue, 16 Mar 2021 21:52:23 +0000 - rev 571503
Push 38293 by malexandru@mozilla.com at Wed, 17 Mar 2021 09:53:31 +0000
Bug 1698680 - Add nsLayoutUtils::GetCrossDocParentFrameInProcess(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D108533
8083eaa5d4326cc497a114d819a2644da41a9360: Bug 1669734 - For abspos frames, resolve intrinsic BSize keywords to the actual intrinsic BSize, instead of stretching to fill the available space r=emilio,dholbert
Sean Feng <sefeng@mozilla.com> - Mon, 15 Mar 2021 15:45:18 +0000 - rev 571276
Push 38287 by dluca@mozilla.com at Mon, 15 Mar 2021 21:48:53 +0000
Bug 1669734 - For abspos frames, resolve intrinsic BSize keywords to the actual intrinsic BSize, instead of stretching to fill the available space r=emilio,dholbert This patch creates a new behavior for absolute positioned frames such that if they have intrinsic size keywords (-moz-fit-content, min-content, max-content) for their BSize and the margins are auto, instead of taking as much space as possible, use the actual intrinsic BSize as the BSize. Users can still use `auto` keyword to make it to fill the available space. This change is to align with the spec text for these intrinsic sizing keywords at https://drafts.csswg.org/css-sizing/#valdef-width-min-content, per the changes resolved on in https://github.com/w3c/csswg-drafts/issues/3973 This patch modifies the centering.html WPT, to expand the test cases to test the centering functionalities for not only explicitly specified height and width, but also the default size and width, in this case the intrinsic sizing keywords. Differential Revision: https://phabricator.services.mozilla.com/D106497
e52d4430804079eaaba4f2aefd721b8c636aec26: Bug 1669734 - Factor out the logic of computing auto margins for abspos frames to its own method r=dholbert,emilio
Sean Feng <sefeng@mozilla.com> - Mon, 15 Mar 2021 15:45:17 +0000 - rev 571275
Push 38287 by dluca@mozilla.com at Mon, 15 Mar 2021 21:48:53 +0000
Bug 1669734 - Factor out the logic of computing auto margins for abspos frames to its own method r=dholbert,emilio Differential Revision: https://phabricator.services.mozilla.com/D107872
44eddd702c0af628c34187a9f99b85b941e843eb: Bug 1698043 - Simplify <input type=number/search> layout to fix this bug and make ::-moz-complex-control-wrapper unnecessary. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 14 Mar 2021 07:53:13 +0000 - rev 571006
Push 38285 by malexandru@mozilla.com at Sun, 14 Mar 2021 21:37:52 +0000
Bug 1698043 - Simplify <input type=number/search> layout to fix this bug and make ::-moz-complex-control-wrapper unnecessary. r=dholbert This should be a simpler setup. We keep every element being a direct anon child of the text control, and special case the reflow of the spinners / clear button, to subtract that size from the other elements. This fixes the bug by ensuring that the editor and placeholder are sized and positioned in exactly the same way. Differential Revision: https://phabricator.services.mozilla.com/D108305
2bc9ef937528bf31cebe9d98ef63152a93051c34: Bug 1698043 - Simplify <input type=number/search> layout to fix this bug and make ::-moz-complex-control-wrapper unnecessary. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 14 Mar 2021 02:35:49 +0000 - rev 571003
Push 38285 by malexandru@mozilla.com at Sun, 14 Mar 2021 21:37:52 +0000
Bug 1698043 - Simplify <input type=number/search> layout to fix this bug and make ::-moz-complex-control-wrapper unnecessary. r=dholbert This should be a simpler setup. We keep every element being a direct anon child of the text control, and special case the reflow of the spinners / clear button, to subtract that size from the other elements. This fixes the bug by ensuring that the editor and placeholder are sized and positioned in exactly the same way. Differential Revision: https://phabricator.services.mozilla.com/D108305
42516933bcaf4dc4d99259b82445cab9673bb2a6: Bug 1697529 - Implement visibility: collapse support for ruby text. r=dholbert
Xidorn Quan <me@upsuper.org> - Fri, 12 Mar 2021 09:28:00 +0000 - rev 570803
Push 38280 by cbrindusan@mozilla.com at Fri, 12 Mar 2021 15:32:35 +0000
Bug 1697529 - Implement visibility: collapse support for ruby text. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D107990
ad40c13d6a3dc2f1a4817bd5f0d655c5ca5a81ab: Bug 1696176 - Fix nsIFrame::PeekBackwardAndForward so that selectAtPoint correctly selects a single character or cluster rather than two adjacent characters. r=dholbert,emilio
Jonathan Kew <jkew@mozilla.com> - Thu, 11 Mar 2021 16:34:23 +0000 - rev 570694
Push 38280 by cbrindusan@mozilla.com at Fri, 12 Mar 2021 15:32:35 +0000
Bug 1696176 - Fix nsIFrame::PeekBackwardAndForward so that selectAtPoint correctly selects a single character or cluster rather than two adjacent characters. r=dholbert,emilio This also prevents incorrectly selecting two words when double-clicking at the end of the first word (before the inter-word space). We also update the selectAtPoint testcase to target more widely-spread glyphs, to check that it is behaving accurately across a larger distance. Differential Revision: https://phabricator.services.mozilla.com/D107309
d7e50a94db5b6dc772167bec411805aa7d937318: Bug 1696176 - Fix nsIFrame::PeekBackwardAndForward so that selectAtPoint correctly selects a single character or cluster rather than two adjacent characters. r=dholbert,emilio
Jonathan Kew <jkew@mozilla.com> - Wed, 10 Mar 2021 22:48:16 +0000 - rev 570595
Push 38277 by smolnar@mozilla.com at Thu, 11 Mar 2021 09:30:01 +0000
Bug 1696176 - Fix nsIFrame::PeekBackwardAndForward so that selectAtPoint correctly selects a single character or cluster rather than two adjacent characters. r=dholbert,emilio This also prevents incorrectly selecting two words when double-clicking at the end of the first word (before the inter-word space). We also update the selectAtPoint testcase to target more widely-spread glyphs, to check that it is behaving accurately across a larger distance. Differential Revision: https://phabricator.services.mozilla.com/D107309
a7ceef946175bbb95a4ddbcb80011484477ad65d: Bug 1696176 - Fix nsIFrame::PeekBackwardAndForward so that selectAtPoint correctly selects a single character or cluster rather than two adjacent characters. r=dholbert,emilio
Jonathan Kew <jkew@mozilla.com> - Wed, 10 Mar 2021 13:48:46 +0000 - rev 570477
Push 38276 by dluca@mozilla.com at Wed, 10 Mar 2021 21:58:46 +0000
Bug 1696176 - Fix nsIFrame::PeekBackwardAndForward so that selectAtPoint correctly selects a single character or cluster rather than two adjacent characters. r=dholbert,emilio This also prevents incorrectly selecting two words when double-clicking at the end of the first word (before the inter-word space). We also update the selectAtPoint testcase to target more widely-spread glyphs, to check that it is behaving accurately across a larger distance. Differential Revision: https://phabricator.services.mozilla.com/D107309
52d3ed0204f902d6ba53a1b9f7de7e5bca2b6759: Bug 1694748 part 3 - Enable ruby-position: alternate by default. r=dholbert
Xidorn Quan <me@upsuper.org> - Wed, 10 Mar 2021 10:46:15 +0000 - rev 570450
Push 38276 by dluca@mozilla.com at Wed, 10 Mar 2021 21:58:46 +0000
Bug 1694748 part 3 - Enable ruby-position: alternate by default. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D107384
6bd20d977ec1f322674acfa460e8cc4155513b2a: Bug 1694748 part 2 - Implement layout of ruby-position: alternate. r=dholbert
Xidorn Quan <me@upsuper.org> - Wed, 10 Mar 2021 10:46:14 +0000 - rev 570449
Push 38276 by dluca@mozilla.com at Wed, 10 Mar 2021 21:58:46 +0000
Bug 1694748 part 2 - Implement layout of ruby-position: alternate. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D107383
0036bd0a605655eb7ac5141aeb646b1362621997: Bug 799725 Part 2 - Use StyleSizeOverrides to stretch flex item's inline-size. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 25 Feb 2021 20:06:12 +0000 - rev 568825
Push 38240 by btara@mozilla.com at Fri, 26 Feb 2021 03:55:47 +0000
Bug 799725 Part 2 - Use StyleSizeOverrides to stretch flex item's inline-size. r=dholbert Also, suppress a flex item's aspect-ratio by using StyleSizeOverrides::mAspectRatio added in Part 1. Otherwise, testing/web-platform/tests/css/css-flexbox/flex-minimum-height-flex-items-023.html is going to break. table-as-item-stretch-cross-size-3 is adapted from the testcase in bug 799725 comment 1. Note: stretching in the cross axis that is a block axis has been fixed by bug 1674302. Differential Revision: https://phabricator.services.mozilla.com/D106195
8cad4644254f0b754659e984054f3187c260e616: Bug 799725 Part 1 - Support AspectRatio in StyleSizeOverrides. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 25 Feb 2021 20:06:11 +0000 - rev 568824
Push 38240 by btara@mozilla.com at Fri, 26 Feb 2021 03:55:47 +0000
Bug 799725 Part 1 - Support AspectRatio in StyleSizeOverrides. r=dholbert This is a preparation patch for Part 2 -- We need a way to ignore aspect-ratio when measuring a flex item's content block-size, because we don't want the stretched inline-size transferring through aspect-ratio to set block-size. This patch hasn't changed the behavior yet. Part 2 is going to utilize mAspectRatio. Differential Revision: https://phabricator.services.mozilla.com/D106383
415a2c4c73b35d5766e48249e7e38b508224ea5d: Bug 1692116 Part 4 - Add WPT reftests, and adjust test expectations. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 25 Feb 2021 20:06:11 +0000 - rev 568823
Push 38240 by btara@mozilla.com at Fri, 26 Feb 2021 03:55:47 +0000
Bug 1692116 Part 4 - Add WPT reftests, and adjust test expectations. r=dholbert Part 2 fixed table-as-item-inflexible-in-column-{1,2}.html. table-as-item-inflexible-in-row-{1,2}.html are already pass on Nightly, and are added for robustness and symmetry. Part 3 fixed table-as-item-specified-height.html Part 2 and Part 3 are both needed to not break layout/reftests/flexbox/flexbox-table-flex-items-3.html. Differential Revision: https://phabricator.services.mozilla.com/D106158
a07fe77b2108f8ddff88ec04aa30101a76b046d2: Bug 1692116 Part 3 - Fix table flex item's content block-size measurement by removing mIsFlexContainerMeasuringBSize flag. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 25 Feb 2021 20:06:11 +0000 - rev 568822
Push 38240 by btara@mozilla.com at Fri, 26 Feb 2021 03:55:47 +0000
Bug 1692116 Part 3 - Fix table flex item's content block-size measurement by removing mIsFlexContainerMeasuringBSize flag. r=dholbert The mIsFlexContainerMeasuringBSize flag serves two purposes: (1) Tell ReflowInput::ComputeMinMaxValues() to treat min-block-size and max-block-size like the initial value. We can just set both sizes after creating the ReflowInput, like this patch does. (2) Add `ComputeSizeFlag::UseAutoBSize` to mComputeSizeFlags. Similar to the reasoning in Bug 1674302 Part 2 https://hg.mozilla.org/mozilla-central/rev/23aff0f21a1d, the UseAutoBSize flag is buggy when used on table flex items because it never propagates to inner table frame. We can fix it by providing an 'auto' mStyleBSize in StyleSizeOverrides. This fixed table flex item's content block-size measurement. As described in table-as-item-specified-height.html, the specified height on <table> now won't count as another min-height anymore. Differential Revision: https://phabricator.services.mozilla.com/D106157
2f75ec7fe055e8966bd2fcafee9f2f3279d1d546: Bug 1692116 Part 2 - Fix table flex item's flex base size & hypothetical main size in a column flex container. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 25 Feb 2021 20:06:10 +0000 - rev 568821
Push 38240 by btara@mozilla.com at Fri, 26 Feb 2021 03:55:47 +0000
Bug 1692116 Part 2 - Fix table flex item's flex base size & hypothetical main size in a column flex container. r=dholbert Bug 1674302 made table flex item to be able to grow or shrink towards another size. However, for an inflexible table flex item, its hypothetical main size is the final main size. We have to compute the flex base size correctly when generating FlexItem. With Part 1, it's easy to change nsTableWrapperFrame::ComputeSize() to return the correct block-size. Differential Revision: https://phabricator.services.mozilla.com/D106156
0e35951d5ea3439dfacd687a1ecabdabbafcfe29: Bug 1692116 Part 1 - Let nsTableWrapperFrame::ComputeAutoSize() return a resolved block-size. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 25 Feb 2021 20:06:10 +0000 - rev 568820
Push 38240 by btara@mozilla.com at Fri, 26 Feb 2021 03:55:47 +0000
Bug 1692116 Part 1 - Let nsTableWrapperFrame::ComputeAutoSize() return a resolved block-size. r=dholbert We already compute both the inner table frame and the caption frame's block-sizes in InnerTableShrinkWrapSize() and CaptionShrinkWrapSize(), respectively. Rather than throwing them away, popping them up to ComputeAutoSize(). This is a preparation patch for Part 2, and it hasn't changed the behavior yet. Differential Revision: https://phabricator.services.mozilla.com/D106155