searching for reviewer(dholbert)
2dd4b6b2f0d7519721b674ea31b7e5c609aab51f: Bug 1641139 - Reflow absolute frames in ruby container and ruby base container. r=dholbert
Xidorn Quan <me@upsuper.org> - Sat, 06 Jun 2020 05:38:12 +0000 - rev 534249
Push 37485 by rmaries@mozilla.com at Sat, 06 Jun 2020 21:47:44 +0000
Bug 1641139 - Reflow absolute frames in ruby container and ruby base container. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D77584
382c1d654e2612cb21e4a27a3743be308f47f87e: Bug 1643173 Part 2 - Unify GetDisplayFlag helpers for flex and grid items. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 05 Jun 2020 02:52:58 +0000 - rev 534059
Push 37482 by nbeleuzu@mozilla.com at Fri, 05 Jun 2020 14:35:19 +0000
Bug 1643173 Part 2 - Unify GetDisplayFlag helpers for flex and grid items. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D78167
9bea5add0bcdae7bf4f5c47f82c61634e93fc623: Bug 1643173 Part 1 - Convert enum nsIFrame::DISPLAY_CHILD_* to enum class. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 05 Jun 2020 02:52:05 +0000 - rev 534058
Push 37482 by nbeleuzu@mozilla.com at Fri, 05 Jun 2020 14:35:19 +0000
Bug 1643173 Part 1 - Convert enum nsIFrame::DISPLAY_CHILD_* to enum class. r=dholbert The modifications are all straightforward conversion except the one in nsMathMLContainerFrame, where it is simplified by calling the equivalent BuildDisplayListForInline() helper. Differential Revision: https://phabricator.services.mozilla.com/D78166
6bb6a5cdc941eaa15c0e36dcaf8e4ad8509d4e90: Bug 1641139 - Reflow absolute frames in ruby container and ruby base container. r=dholbert
Xidorn Quan <me@upsuper.org> - Thu, 04 Jun 2020 06:08:40 +0000 - rev 533835
Push 37479 by apavel@mozilla.com at Thu, 04 Jun 2020 15:32:20 +0000
Bug 1641139 - Reflow absolute frames in ruby container and ruby base container. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D77584
65c8548cb97d3bb26fab48ebec7625883ec9b04d: Bug 1640028 - Add a crashtest. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 03 Jun 2020 22:20:41 +0000 - rev 533831
Push 37478 by abutkovits@mozilla.com at Thu, 04 Jun 2020 09:29:07 +0000
Bug 1640028 - Add a crashtest. r=dholbert Fixed by bug 1640275 and bug 1343948. Differential Revision: https://phabricator.services.mozilla.com/D78161
d39b5b23b9e7fc06f33ff4511a48fee3e117ea83: Bug 1640028 - Add a crashtest. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 03 Jun 2020 22:20:41 +0000 - rev 533816
Push 37478 by abutkovits@mozilla.com at Thu, 04 Jun 2020 09:29:07 +0000
Bug 1640028 - Add a crashtest. r=dholbert Fixed by bug 1640275 and bug 1343948. Differential Revision: https://phabricator.services.mozilla.com/D78161
ec3b786afe744aed08d454a180dfb5a1a70aba5a: Bug 1642430 - Improve SVGTests implementation r=dholbert
longsonr <longsonr@gmail.com> - Wed, 03 Jun 2020 15:34:21 +0000 - rev 533780
Push 37477 by dluca@mozilla.com at Thu, 04 Jun 2020 04:19:27 +0000
Bug 1642430 - Improve SVGTests implementation r=dholbert This is should not be a functional change, just making the methods in SVGTests easier to use/understand. There's a little dead code removal since we can go through the same code path for empty intl.accept_languages as we do when it has a value, and we'd almost always expect it to have a value. Differential Revision: https://phabricator.services.mozilla.com/D77694
5f82782c37e0ef0bd514f0b0c0259dfb26f23ab6: Bug 1608515: Update the SVG IsContainingWindowElementOfType impl for Fission r=barret,dholbert
Keefer Rourke <krourke@mozilla.com> - Wed, 03 Jun 2020 15:24:54 +0000 - rev 533770
Push 37477 by dluca@mozilla.com at Thu, 04 Jun 2020 04:19:27 +0000
Bug 1608515: Update the SVG IsContainingWindowElementOfType impl for Fission r=barret,dholbert In nsSVGOuterSVGFrame::IsContainingWindowElementOfType, we now inspect the embedder by asking the window for its browsing context, instead of asking it directly for its frame element. Differential Revision: https://phabricator.services.mozilla.com/D77518
528fc992a6fa63d1c0b05d23896c91349d564293: Bug 1642694 - Build display list for frames in flex container's overflow container list. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 03 Jun 2020 03:52:29 +0000 - rev 533657
Push 37475 by btara@mozilla.com at Wed, 03 Jun 2020 16:12:12 +0000
Bug 1642694 - Build display list for frames in flex container's overflow container list. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D77855
bffa16d830c11999086fa5a0a6e09cb75b9cdb02: Bug 1642302 - mark wpt tests that depend on device-pixel-content-box as backlog (tier-2). r=dholbert
Joel Maher <jmaher@mozilla.com> - Tue, 02 Jun 2020 02:36:45 +0000 - rev 533434
Push 37473 by cbrindusan@mozilla.com at Wed, 03 Jun 2020 04:20:58 +0000
Bug 1642302 - mark wpt tests that depend on device-pixel-content-box as backlog (tier-2). r=dholbert Mark wpt tests that depend on device-pixel-content-box as backlog (tier-2) Differential Revision: https://phabricator.services.mozilla.com/D77723
c50afc8ccccbe1d08bc4cc2c7976a656ca3747b9: Bug 1641803 - Remove old metadata for vendor-imports directory, r=dholbert
James Graham <james@hoppipolla.co.uk> - Mon, 01 Jun 2020 22:28:29 +0000 - rev 533428
Push 37473 by cbrindusan@mozilla.com at Wed, 03 Jun 2020 04:20:58 +0000
Bug 1641803 - Remove old metadata for vendor-imports directory, r=dholbert This mostly refers to configurations that no longer exist Differential Revision: https://phabricator.services.mozilla.com/D77427
f3a829091fef65cf49209ed374688cdd6d5753ed: Bug 1581622 - Make blend-exclusion reftest a slightly fuzzier match on geckoview webrender r=dholbert
longsonr <longsonr@gmail.com> - Tue, 02 Jun 2020 02:53:22 +0000 - rev 533426
Push 37472 by cbrindusan@mozilla.com at Tue, 02 Jun 2020 21:53:59 +0000
Bug 1581622 - Make blend-exclusion reftest a slightly fuzzier match on geckoview webrender r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D77577
a00f71376ad18b3cde3d92b338b5304c7ffd7334: Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 21 May 2020 21:54:57 +0000 - rev 531686
Push 37442 by ncsoregi@mozilla.com at Sat, 23 May 2020 09:21:24 +0000
Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D76206
19b910256abfe62d1fcb177e48ed1c1a28f5b2ab: Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 21 May 2020 23:11:07 +0000 - rev 531685
Push 37442 by ncsoregi@mozilla.com at Sat, 23 May 2020 09:21:24 +0000
Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert If `contentFrame` is out-of-flow, nsFrameConstructorState::AddChild() can construct a placeholder frame for `contentFrame` and put the placeholder in `frameList`. Also, we need to use nsFrameConstructorState::GetGeometricParent() to get the correct parent when calling InitAndRestoreFrame() for an out-of-flow `contentFrame`. For example, if `contentFrame` has position:fixed, its parent should be ViewportFrame, not CanvasFrame (which is mDocElementContainingBlock). This patch also adds reftests for position:absolute flex & grid root element. Reftests for position:fixed root element are in the next part. Differential Revision: https://phabricator.services.mozilla.com/D76205
3265c120177ff5e7cfe35fd9ab165c7d74284106: Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 21 May 2020 01:14:09 +0000 - rev 531498
Push 37440 by abutkovits@mozilla.com at Fri, 22 May 2020 09:43:16 +0000
Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D76206
057922187f3daa2396c04828dee2baeb895865bc: Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 21 May 2020 18:38:59 +0000 - rev 531497
Push 37440 by abutkovits@mozilla.com at Fri, 22 May 2020 09:43:16 +0000
Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert If `contentFrame` is out-of-flow, nsFrameConstructorState::AddChild() can construct a placeholder frame for `contentFrame` and put the placeholder in `frameList`. Also, we need to use nsFrameConstructorState::GetGeometricParent() to get the correct parent when calling InitAndRestoreFrame() for an out-of-flow `contentFrame`. For example, if `contentFrame` has position:fixed, its parent should be ViewportFrame, not CanvasFrame (which is mDocElementContainingBlock). This patch also adds reftests for position:absolute flex & grid root element. Reftests for position:fixed root element are in the next part. Disable crashtest 1608851.html on Android because it causes OOM crash after landing this patch. Differential Revision: https://phabricator.services.mozilla.com/D76205
1da2faea06e80d252561993b9976a7777d911bbe: Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 20 May 2020 22:32:24 +0000 - rev 531348
Push 37438 by abutkovits@mozilla.com at Thu, 21 May 2020 09:36:57 +0000
Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D76206
84d138356c7699456abf8dc6483b1d49aab86771: Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 20 May 2020 22:32:06 +0000 - rev 531347
Push 37438 by abutkovits@mozilla.com at Thu, 21 May 2020 09:36:57 +0000
Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert If `contentFrame` is out-of-flow, nsFrameConstructorState::AddChild() can construct a placeholder frame for `contentFrame` and put the placeholder in `frameList`. Also, we need to use nsFrameConstructorState::GetGeometricParent() to get the correct parent when calling InitAndRestoreFrame() for an out-of-flow `contentFrame`. For example, if `contentFrame` has position:fixed, its parent should be ViewportFrame, not CanvasFrame (which is mDocElementContainingBlock). This patch also adds reftests for position:absolute flex & grid root element. Reftests for position:fixed root element are in the next part. Differential Revision: https://phabricator.services.mozilla.com/D76205
2924b52f3b3f620863d49f521b4a17d5b49be56b: Bug 1637145 Part 3 - Setup NS_STATE_FLEX_NORMAL_FLOW_CHILDREN_IN_CSS_ORDER for flex container's next-in-flows. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 19 May 2020 03:46:52 +0000 - rev 530932
Push 37434 by abutkovits@mozilla.com at Wed, 20 May 2020 10:05:10 +0000
Bug 1637145 Part 3 - Setup NS_STATE_FLEX_NORMAL_FLOW_CHILDREN_IN_CSS_ORDER for flex container's next-in-flows. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D75156
dfd3e63d3371eac20a4217369677c1cbe16cce35: Bug 1637145 Part 2 - Use FlexItemIterator to improve the performance when generating FlexLines and FlexItems for flex container's next-in-flows. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 19 May 2020 22:49:22 +0000 - rev 530931
Push 37434 by abutkovits@mozilla.com at Wed, 20 May 2020 10:05:10 +0000
Bug 1637145 Part 2 - Use FlexItemIterator to improve the performance when generating FlexLines and FlexItems for flex container's next-in-flows. r=dholbert By changing the FlexLines and FlexItems generated in flex container's first-in-flow in CSS "order" aware order (i.e. reverse them again if the flex container's internal axes are reversed), we can construct FlexItems for flex container's next-in-flows in linear time because once we find a FlexItem in the stored FlexLines via FlexItemIterator to construct a new FlexItem for a child frame, the FlexItem for the next child frame can only be found in a later entry (either in a later item in the same line, or an item in a later line). Differential Revision: https://phabricator.services.mozilla.com/D75155
ad89f466d991715dba86eb61630eee7f9761369c: Bug 1637145 Part 1 - Create a helper method for the code that generates FlexLines and FlexItems for a flex container's next-in-flows. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 19 May 2020 03:46:46 +0000 - rev 530930
Push 37434 by abutkovits@mozilla.com at Wed, 20 May 2020 10:05:10 +0000
Bug 1637145 Part 1 - Create a helper method for the code that generates FlexLines and FlexItems for a flex container's next-in-flows. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D75154
bd3a170fc984a92ff6478480b16e3d8ce9cb2f68: Bug 1538537 - When suppressing anchoring on an scrollframe, forward to the frame that actually maintains the anchor as needed. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 19 May 2020 23:57:23 +0000 - rev 530929
Push 37434 by abutkovits@mozilla.com at Wed, 20 May 2020 10:05:10 +0000
Bug 1538537 - When suppressing anchoring on an scrollframe, forward to the frame that actually maintains the anchor as needed. r=dholbert The test-case is position-change-heuristic.html but with body and #space having overflow: hidden, which makes it fail on Nightly. Differential Revision: https://phabricator.services.mozilla.com/D75825
1ce1f7104af927a1c044bfe28fdbdd7f1dd5d59a: Bug 1639053 - Remove the ability to reverse axes internally for nsFlexContainerFrame. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 19 May 2020 21:13:35 +0000 - rev 530888
Push 37433 by dluca@mozilla.com at Wed, 20 May 2020 03:39:31 +0000
Bug 1639053 - Remove the ability to reverse axes internally for nsFlexContainerFrame. r=dholbert The ability to reverse axes internally was added in bug 983427, but it turns out not to be used. test_flex_lines.html needs to be modified because those expected cross values are written as if the flex lines are physically in top-to-bottom order (due to we reversed the axes internally). Now we don't reverse the internal axes, the order of the flex lines becomes bottom-to-top due to "flex-wrap: wrap-reverse". The crossStart coordinate begins from the flex container's bottom end edge, and it increases from bottom to the top to the flex container's top end edge. (Note the flex container has 42px height.) Differential Revision: https://phabricator.services.mozilla.com/D75887
83b4973bb9d30a6c43b0b3ee4a259751dc275c6a: Bug 1637511 - Keep suppressing scrollbars than don't fit in the scrollport for overflow: auto. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 May 2020 21:24:15 +0000 - rev 530393
Push 37421 by cbrindusan@mozilla.com at Sat, 16 May 2020 09:34:57 +0000
Bug 1637511 - Keep suppressing scrollbars than don't fit in the scrollport for overflow: auto. r=dholbert Given there's content depending on it. This brings back the check from before the regression. I had to tweak percent-height-overflowing-image-1.html so that it doesn't hit scrollbar size limits on GTK (which are a bit ridiculous IMHO, but oh well). Differential Revision: https://phabricator.services.mozilla.com/D75171
76aa4bf4eabd44912cc33a4ccd4d5474fc0e2ca7: Bug 1622935 Part 4d - Add more reftests for single-line flex container in zero height multicols. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 11 May 2020 17:08:45 +0000 - rev 529420
Push 37409 by apavel@mozilla.com at Wed, 13 May 2020 03:44:05 +0000
Bug 1622935 Part 4d - Add more reftests for single-line flex container in zero height multicols. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D74497
1035de8a28ce9fa3758f4ce92ec705f4b852baed: Bug 1622935 Part 4c - Add additional single-line flex container fragmentation reftests. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 08 May 2020 22:33:52 +0000 - rev 529419
Push 37409 by apavel@mozilla.com at Wed, 13 May 2020 03:44:05 +0000
Bug 1622935 Part 4c - Add additional single-line flex container fragmentation reftests. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D73170
988074d5ce545f8cbc9d784a3d4c6e9ad14a51a7: Bug 1622935 Part 4b - Add base single-line column-reverse/row-reverse flex container fragmentation reftests. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 04 May 2020 23:28:57 +0000 - rev 529418
Push 37409 by apavel@mozilla.com at Wed, 13 May 2020 03:44:05 +0000
Bug 1622935 Part 4b - Add base single-line column-reverse/row-reverse flex container fragmentation reftests. r=dholbert The reftests added in this commit are "base" versions in the sense that they'll be copied with edits in a later commit. Differential Revision: https://phabricator.services.mozilla.com/D73169
6a21028d21a841c5cf8922e5e02d63301b8098f0: Bug 1622935 Part 4a - Add base single-line column/row flex container fragmentation reftests. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 04 May 2020 23:28:49 +0000 - rev 529417
Push 37409 by apavel@mozilla.com at Wed, 13 May 2020 03:44:05 +0000
Bug 1622935 Part 4a - Add base single-line column/row flex container fragmentation reftests. r=dholbert The reftests added in this commit are "base" versions in the sense that they'll be copied with edits in a later commit. Differential Revision: https://phabricator.services.mozilla.com/D73168
5c6cc9d819b9302f512c7bdd7003316bc2d85bd3: Bug 1622935 Part 3 - Implement fragmentation for single-line flex container. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 12 May 2020 16:55:00 +0000 - rev 529416
Push 37409 by apavel@mozilla.com at Wed, 13 May 2020 03:44:05 +0000
Bug 1622935 Part 3 - Implement fragmentation for single-line flex container. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D73167
78d4dfbda06a0912abeba7f3541c528608c50b3e: Bug 1622935 Part 1 - Reverse the meaning of the children completeness returned by ReflowChildren(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 12 May 2020 17:20:12 +0000 - rev 529414
Push 37409 by apavel@mozilla.com at Wed, 13 May 2020 03:44:05 +0000
Bug 1622935 Part 1 - Reverse the meaning of the children completeness returned by ReflowChildren(). r=dholbert This makes the logic easier to read and reason about, because the scenario where we need to do extra work is *when some child is incomplete* (not when all children are complete). Also, this change makes us consistent with the semantics of the return value for nsContainerFrame::PushIncompleteChildren() (and we'll add a call to that function in part 3). Differential Revision: https://phabricator.services.mozilla.com/D73165
594d2cecc8cf535bdedad317f925e2a7c4bc628a: Bug 1633504 - Disable showing pixel difference numbers in the reftest analyzer. r=dholbert
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 12 May 2020 06:21:23 +0000 - rev 529307
Push 37409 by apavel@mozilla.com at Wed, 13 May 2020 03:44:05 +0000
Bug 1633504 - Disable showing pixel difference numbers in the reftest analyzer. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D74791
012f25fede5cc41dc810b21e27c3393b382bf9eb: Bug 1365806 - Make scrollbars not impose a minimum size on the scroller. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 May 2020 20:44:25 +0000 - rev 528682
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1365806 - Make scrollbars not impose a minimum size on the scroller. r=dholbert Also, don't suppress scrollbars if the scrollport is less than their length, as that can happen after this patch :) Differential Revision: https://phabricator.services.mozilla.com/D73395
842955b61f01c2d859484ae9aa155e4ea59561b5: Bug 1365806 - Make scrollbars not impose a minimum size on the scroller. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 May 2020 09:46:20 +0000 - rev 528368
Push 37384 by nbeleuzu@mozilla.com at Wed, 06 May 2020 16:28:18 +0000
Bug 1365806 - Make scrollbars not impose a minimum size on the scroller. r=dholbert Also, don't suppress scrollbars if the scrollport is less than their length, as that can happen after this patch :) Differential Revision: https://phabricator.services.mozilla.com/D73395
dffeae069fdf23bf545287dbd7e3e1cd1944c928: Bug 1633720 - [css-grid-2] Adjust the grid area stored in the Subgrid property as well for removed 'auto-fit' tracks in the parent. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 30 Apr 2020 11:34:20 +0000 - rev 527358
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1633720 - [css-grid-2] Adjust the grid area stored in the Subgrid property as well for removed 'auto-fit' tracks in the parent. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D73007
7de5317decf341d1fd59467cf56a38210aba8e77: Bug 1633434 - Ensure inverting a valid aspect ratio generates a valid aspect ratio. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 30 Apr 2020 14:04:24 +0000 - rev 526974
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1633434 - Ensure inverting a valid aspect ratio generates a valid aspect ratio. r=dholbert It seems like a reasonable expectation, but it may not hold with massive ratios. Make it hold by returning the floating point epsilon in that case. Differential Revision: https://phabricator.services.mozilla.com/D73029
84d37ea90966593e29dfc330720713a7913a2c21: Bug 1607954 part 3 - [css-grid][css-align] Add tentative tests and update devtools support files for Masonry layout. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 28 Apr 2020 01:24:37 +0000 - rev 526367
Push 37354 by shindli@mozilla.com at Tue, 28 Apr 2020 03:54:55 +0000
Bug 1607954 part 3 - [css-grid][css-align] Add tentative tests and update devtools support files for Masonry layout. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D67063
3216ec9f1999875aa9c73f973c307a4c48982b7c: Bug 1607954 part 2 - [css-grid][css-align] Implement Masonry layout. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 28 Apr 2020 01:18:47 +0000 - rev 526366
Push 37354 by shindli@mozilla.com at Tue, 28 Apr 2020 03:54:55 +0000
Bug 1607954 part 2 - [css-grid][css-align] Implement Masonry layout. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D67062
28da49962f2adbf5a56fdfa0b06c3398b3d993d8: Bug 1630457 - Rename ComputeFinalSize to PopulateReflowOutput along with some minor improvements. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Apr 2020 20:43:29 +0000 - rev 524950
Push 37333 by cbrindusan@mozilla.com at Tue, 21 Apr 2020 09:42:20 +0000
Bug 1630457 - Rename ComputeFinalSize to PopulateReflowOutput along with some minor improvements. r=dholbert 1. Move `FinishReflowWithAbsoluteFrames` and `NS_FRAME_SET_TRUNCATION` to Reflow(). 2. Improve documentation for `PopulateReflowOutput`. Differential Revision: https://phabricator.services.mozilla.com/D71614
2796692264cd4e2f9db9d21224d168f828a5a440: Bug 1629650 - Rename flex container's desired size back to desiredSizeInFlexWM. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Apr 2020 20:29:07 +0000 - rev 524949
Push 37333 by cbrindusan@mozilla.com at Tue, 21 Apr 2020 09:42:20 +0000
Bug 1629650 - Rename flex container's desired size back to desiredSizeInFlexWM. r=dholbert This was mis-renamed in bug 1621989 Part 1. Differential Revision: https://phabricator.services.mozilla.com/D71613
eb275e9ef6d491a2913ac4d2d5bb0ac63d76f577: Bug 1627125 Part 8 - Make nsFlexContainerFrame static-analysis warning free. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Apr 2020 05:38:12 +0000 - rev 524476
Push 37321 by dluca@mozilla.com at Fri, 17 Apr 2020 09:38:52 +0000
Bug 1627125 Part 8 - Make nsFlexContainerFrame static-analysis warning free. r=dholbert 1. Fixed "warning: use 'using' instead of 'typedef'" for OrderState. 2. Removed `FlexItem* item` to fix the "warning: Value stored to 'item' is never read". Differential Revision: https://phabricator.services.mozilla.com/D69486
c1e6d0ce349e5092af2aa45e98048e6f3d298a7b: Bug 1627125 Part 7 - Add reftests for flex containers with "box-decoration-break: clone" and unbreakable children. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Apr 2020 19:24:03 +0000 - rev 524475
Push 37321 by dluca@mozilla.com at Fri, 17 Apr 2020 09:38:52 +0000
Bug 1627125 Part 7 - Add reftests for flex containers with "box-decoration-break: clone" and unbreakable children. r=dholbert These reftests are copied from flexbox-unbreakable-child-1-*.html and flexbox-unbreakable-child-1-*-wrap.html with "box-decoration-break: clone" added to the flex container. Note that flexbox-unbreakable-child-3-ref.html is redesigned. It is not copied from flexbox-unbreakable-child-1-ref.html with "box-decoration-break: clone" added because the bottom border doesn't show up in sub-test 3 & 4. (bug 1564726 perhaps?) Differential Revision: https://phabricator.services.mozilla.com/D69475
c473fe50e3fa1d0d8327eb7b715406a13317988b: Bug 1627125 Part 6 - Redesign the logic that computes flex container's final size with "box-decoration-break: clone" considered. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Apr 2020 19:10:32 +0000 - rev 524474
Push 37321 by dluca@mozilla.com at Fri, 17 Apr 2020 09:38:52 +0000
Bug 1627125 Part 6 - Redesign the logic that computes flex container's final size with "box-decoration-break: clone" considered. r=dholbert By passing unconstrained aAvailableBSizeForContent to DoFlexLayout, we can get the flex container's desired content-box size as if there's no pagination. We could then use this content-box size and maxBlockEndEdgeOfChildren to rewrite the logic to determine flex container's final size. I still maintain the compatibility with block frame that if the flex container is running out of block-size, it can still become incomplete and request an zero block-size continuation. One comment in block frame feels this is wrong, but fixing it is not in the scope of this bug. https://searchfox.org/mozilla-central/rev/4ccefc3181f9d237ef4ca8bd17b4e7c101ddf7b5/layout/generic/nsBlockFrame.cpp#7715-7718 Differential Revision: https://phabricator.services.mozilla.com/D69474
994770def1fc70c276a93137027f46690c620240: Bug 1627125 Part 5 - Make ReflowChildren() output children's max block-end edge and completeness. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Apr 2020 05:37:59 +0000 - rev 524473
Push 37321 by dluca@mozilla.com at Fri, 17 Apr 2020 09:38:52 +0000
Bug 1627125 Part 5 - Make ReflowChildren() output children's max block-end edge and completeness. r=dholbert The two variable will be used in ComputeFinalSize in a later part. I follow the C++ Core Guidelines to return multiple value via std::tuple. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f21-to-return-multiple-out-values-prefer-returning-a-struct-or-tuple Differential Revision: https://phabricator.services.mozilla.com/D69473
bd29ea94d3bd4625778f238de6fd7b2e5ee78339: Bug 1627125 Part 4 - Run DoFlexLayout only in first-in-flow, and store SharedFlexData in it. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Apr 2020 05:37:57 +0000 - rev 524472
Push 37321 by dluca@mozilla.com at Fri, 17 Apr 2020 09:38:52 +0000
Bug 1627125 Part 4 - Run DoFlexLayout only in first-in-flow, and store SharedFlexData in it. r=dholbert We want mContentBoxMainSize and mContentBoxCrossSize in SharedFlexData to be the final content-box without regards to pagination, but it is not correct yet. A later part will pass NS_UNCONSTRAINEDSIZE as availableBSizeForContent so that DoFlexLayout can calculate the correct size. Differential Revision: https://phabricator.services.mozilla.com/D69472
c15c24dcc029e28ba1294da3a574439698bc373e: Bug 1627125 Part 3 - Add aColumnWrapThreshold to DoFlexLayout. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Apr 2020 05:37:55 +0000 - rev 524471
Push 37321 by dluca@mozilla.com at Fri, 17 Apr 2020 09:38:52 +0000
Bug 1627125 Part 3 - Add aColumnWrapThreshold to DoFlexLayout. r=dholbert In a later part, we want to use NS_UNCONSTRAINEDSIZE for aAvailableBSizeForContent. Differential Revision: https://phabricator.services.mozilla.com/D69471
a8e29df7db26ff1b8c7f0dfca8e944e0bfaf4ad9: Bug 1627125 Part 2 - Add a helper to compute available size for flex items, and pass the information to ReflowChildren. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Apr 2020 05:37:47 +0000 - rev 524470
Push 37321 by dluca@mozilla.com at Fri, 17 Apr 2020 09:38:52 +0000
Bug 1627125 Part 2 - Add a helper to compute available size for flex items, and pass the information to ReflowChildren. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D69470
36907dee3e51d41337bc7d4e7dc27c28178dfdfe: Bug 1627125 Part 1 - Allow ReflowFlexItem to take available size as an input, and output reflow status. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Apr 2020 05:37:45 +0000 - rev 524469
Push 37321 by dluca@mozilla.com at Fri, 17 Apr 2020 09:38:52 +0000
Bug 1627125 Part 1 - Allow ReflowFlexItem to take available size as an input, and output reflow status. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D69469
9022d327e0bd4b19ce43684701eececc9459a4ef: Bug 1630385 - Don't descend into scroll frames with a pre-existing anchor. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 15 Apr 2020 23:13:00 +0000 - rev 524280
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1630385 - Don't descend into scroll frames with a pre-existing anchor. r=dholbert We can modify the scroll position without invalidating the anchor (that's kind of the point, actually). So it's possible (and ok) to end up with a frame which is already maintaining an anchor but for which CanMaintainAnchor now returns false. So if you have a scrollframe with a non-zero scroll position and select an anchor for that scrollframe, and then try to select an anchor for an ancestor, you don't want to dig into there. Differential Revision: https://phabricator.services.mozilla.com/D71103
ace4bfaec6861e9d6b4a3cebc07b96194acf9ed7: Bug 1520581 - Allow to select scroll anchors inside nested scroll frames. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 13 Apr 2020 20:58:14 +0000 - rev 523717
Push 37309 by opoprus@mozilla.com at Tue, 14 Apr 2020 04:09:24 +0000
Bug 1520581 - Allow to select scroll anchors inside nested scroll frames. r=dholbert As long as the nested scrollframe doesn't maintain an anchor itself. This is important for pages which use overflow: hidden to contain large parts of their scrollable content, see bug 1629237 for an example. When calling InvalidateAnchor(), we may invalidate an ancestor anchor itself, if we're not maintaining an anchor and our scrolled frame is part of the anchor chain. This is important to maintain our state properly. I was going to add some assertion to this effect but it can fail when fragmenting inlines already, so for now I've commented it out and filed bug 1629280 for that. It's not great, but it cannot lead to a security issue so we probably can fix it with time. Differential Revision: https://phabricator.services.mozilla.com/D70609
452a284c8d8afab3f43dd2e28ef2126fd0bf6ecc: Bug 1628804 - Ensure nsIFrame::ContentSize() returning non-negative sizes. r=dholbert,AlaskanEmily
Ting-Yu Lin <tlin@mozilla.com> - Fri, 10 Apr 2020 22:51:13 +0000 - rev 523472
Push 37302 by cbrindusan@mozilla.com at Sat, 11 Apr 2020 09:34:41 +0000
Bug 1628804 - Ensure nsIFrame::ContentSize() returning non-negative sizes. r=dholbert,AlaskanEmily Differential Revision: https://phabricator.services.mozilla.com/D70558