searching for reviewer(dbaron)
dbd8cf9a9c829672446f1b98e529d5c5d53ab8e7: Bug 1637130 - Update the comment for overflow areas in nsLineBox. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Jul 2020 22:07:09 +0000 - rev 541351
Push 37621 by rmaries@mozilla.com at Tue, 21 Jul 2020 09:42:41 +0000
Bug 1637130 - Update the comment for overflow areas in nsLineBox. r=dbaron The combined overflow area has been split into ink and scrollable overflow areas in bug 542595. Drop the sentence related to it, and update the old comment. Differential Revision: https://phabricator.services.mozilla.com/D84232
887e986df7b33be85b4eee792a6f5776b1bae664: Bug 1637130 - Rename visual overflow to ink overflow. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Jul 2020 20:17:36 +0000 - rev 541350
Push 37621 by rmaries@mozilla.com at Tue, 21 Jul 2020 09:42:41 +0000
Bug 1637130 - Rename visual overflow to ink overflow. r=dbaron This patch is generated by: ``` # Rename the nsOverflowType enum. rg -l "eVisualOverflow" layout/ gfx/ | xargs sed -i "s/eVisualOverflow/eInkOverflow/g" # Rename and drop the "Get" prefix from various functions. rg -l "GetVisualOverflowRect" layout/ gfx/ | xargs sed -i "s/GetVisualOverflowRect/InkOverflowRect/g" rg -l "GetPreEffectsVisualOverflowRect" layout/ gfx/ | xargs sed -i "s/GetPreEffectsVisualOverflowRect/PreEffectsInkOverflowRect/g" rg -l "GetVisualOverflowFromDeltas" layout/ gfx/ | xargs sed -i "s/GetVisualOverflowFromDeltas/InkOverflowFromDeltas/g" rg -l "GetScrollableOverflowRect" layout/ gfx/ | xargs sed -i "s/GetScrollableOverflowRect/ScrollableOverflowRect/g" # Rename, drop the "Get" prefix, and change the suffix "Area" to "Rect" # (because they return nsRect) for the two methods in nsLineBox. rg -l "GetVisualOverflowArea" layout/ gfx/ | xargs sed -i "s/GetVisualOverflowArea/InkOverflowRect/g" rg -l "GetScrollableOverflowArea" layout/ gfx/ | xargs sed -i "s/GetScrollableOverflowArea/ScrollableOverflowRect/g" # Rename rest of the functions and variables. rg -l "VisualOverflow" layout/ gfx/ | xargs sed -i "s/VisualOverflow/InkOverflow/g" rg -l "visual overflow" layout/ gfx/ | xargs sed -i "s/visual overflow/ink overflow/g" rg -l "visualOverflow" layout/ gfx/ | xargs sed -i "s/visualOverflow/inkOverflow/g" rg -l "visOverflow" layout/ gfx/ | xargs sed -i "s/visOverflow/inkOverflow/g" rg -l "vis-overflow" layout/ gfx/ python/ | xargs sed -i "s/vis-overflow/ink-overflow/g" ./mach clang-format ``` Differential Revision: https://phabricator.services.mozilla.com/D84231
1a8cae9bb8a9747f42bee40d66415ece3f56e97d: Bug 1634102 - Always balance columns before column-spans (regardless the column-fill property). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 17 Jun 2020 03:35:42 +0000 - rev 535986
Push 37515 by nerli@mozilla.com at Wed, 17 Jun 2020 14:49:45 +0000
Bug 1634102 - Always balance columns before column-spans (regardless the column-fill property). r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D77570
e1232e2aeacf7f85a4556947eec61dfa5418aab2: Bug 1574046 Part 5 - Prevent BlockReflowInput::ClearFloat from returning nscoord_MAX. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 16 Jun 2020 18:33:02 +0000 - rev 535985
Push 37515 by nerli@mozilla.com at Wed, 17 Jun 2020 14:49:45 +0000
Bug 1574046 Part 5 - Prevent BlockReflowInput::ClearFloat from returning nscoord_MAX. r=dbaron This effectively makes ClearFloat() act like it always has DONT_CLEAR_PUSHED_FLOATS. Thus, the flag is no longer needed. We need to add an early return condition when the block cannot fit in ReflowBlockFrame(). Because we now don't return nscoord_MAX when floats are pushed or split, the `availSpace.BSize(wm)` might equal to zero rather than negative in this case. It's needed by testing/web-platform/tests/css/CSS2/floats-clear/floats-clear-multicol-003.html and layout/reftests/pagination/float-clear-003-print.html Differential Revision: https://phabricator.services.mozilla.com/D74540
2490a3ca2481334d32efb292eaffa81aa61aeddf: Bug 1574046 Part 4 - Use BlockReflowInput::ClearFloatsResult to replace coordinate comparison. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 03 Jun 2020 00:11:13 +0000 - rev 535984
Push 37515 by nerli@mozilla.com at Wed, 17 Jun 2020 14:49:45 +0000
Bug 1574046 Part 4 - Use BlockReflowInput::ClearFloatsResult to replace coordinate comparison. r=dbaron The rules I used when replacing the block-dir coordinates comparison between the one passing to ClearFloats() and the one returned by ClearFloats(). - If they are equal, check the ClearFloatsResult is equal to `BCoordNoChange`. - If they are not equal, check the ClearFloatsResult is not equal to `BCoordNoChange`. We want to do this conversion because in the next patch, I want to stop ClearFloats() from returning nscoord_MAX, which is equivalent to checking `FloatsPushedOrSplit`. Differential Revision: https://phabricator.services.mozilla.com/D74539
b217eaadc9d95c656d4f7cf53ca92d979765503d: Bug 1574046 Part 3 - Make BlockReflowInput::ClearFloats() return ClearFloatsResults. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 03 Jun 2020 00:14:55 +0000 - rev 535983
Push 37515 by nerli@mozilla.com at Wed, 17 Jun 2020 14:49:45 +0000
Bug 1574046 Part 3 - Make BlockReflowInput::ClearFloats() return ClearFloatsResults. r=dbaron This change doesn't change the behavior yet. It just changes all the callers by having them catch the ClearFloatsResults. Some of the callers will be revised in next patch by utilizing the returned results. Some of the return values are not being used, and may produce warnings, they will be suppressed in the next patch, too. Differential Revision: https://phabricator.services.mozilla.com/D74538
4140c68594e37736cad363e832d76ba22b7db8e9: Bug 1574046 Part 2 - Move calling nsFloatManager::ClearContinues to BlockReflowInput::ClearFloats(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 27 May 2020 04:44:42 +0000 - rev 535982
Push 37515 by nerli@mozilla.com at Wed, 17 Jun 2020 14:49:45 +0000
Bug 1574046 Part 2 - Move calling nsFloatManager::ClearContinues to BlockReflowInput::ClearFloats(). r=dbaron All the callers in nsBlockFrame call BlockReflowInput::ClearFloats(), I don't feel we need to pass the DONT_CLEAR_PUSHED_FLOATS down to nsFloatManager. Besides, I'll remove the flag in a later patch. Differential Revision: https://phabricator.services.mozilla.com/D74537
aa23badb0824457636bde2db432e1637a9d3b382: Bug 1574046 Part 1 - Upstream float clear reftests to wpt, and add column-fill:auto counterparts. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 26 May 2020 22:12:15 +0000 - rev 535981
Push 37515 by nerli@mozilla.com at Wed, 17 Jun 2020 14:49:45 +0000
Bug 1574046 Part 1 - Upstream float clear reftests to wpt, and add column-fill:auto counterparts. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D74536
5df17ecbcaa13a0f5bb09d4b197d58804eb10112: Bug 477157 - Ceil border and outline widths to 1 dev px at computed value time, but don't floor others to dev pixels until paint time. r=mats,dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Jun 2020 10:44:32 +0000 - rev 534840
Push 37495 by btara@mozilla.com at Wed, 10 Jun 2020 21:40:41 +0000
Bug 477157 - Ceil border and outline widths to 1 dev px at computed value time, but don't floor others to dev pixels until paint time. r=mats,dbaron This seems to match what other browsers do, and seems saner layout-wise, at least. I only annotated outline-width-interpolation.html because it's already fixed upstream in: https://github.com/web-platform-tests/wpt/commit/8a489657bc8f0b4a8aac012e3bd2f968080da4a5 Differential Revision: https://phabricator.services.mozilla.com/D75360
751209e30850a9f45b27a60d112b5a99f6a999e6: Bug 1626129 - Add more reftests for breaking a table cell. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Sat, 16 May 2020 06:14:02 +0000 - rev 530519
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1626129 - Add more reftests for breaking a table cell. r=dbaron 2a and 2b are copied from 1a and 1b with "box-decoration-break: clone" added. 3a and 3b are copied from 1a and 1b. They test that the content fit but the table cell's bottom border and padding cannot fit. As of this bug, their rendering matches the block frame's, but 3a can now trigger a "data loss" warning and 3b an assertion in nsTableRowGroupFrame::SplitRowGroup. That might need a deeper look into table's pagination to have a proper fix. Differential Revision: https://phabricator.services.mozilla.com/D72051
1cdfd91b0a4f22ab14f48e3520313a3d940132f0: Bug 1626129 - Apply skip sides for nsTableCellFrame's border and padding, and use it to calculate available space to reflow children. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 18 May 2020 00:47:05 +0000 - rev 530518
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1626129 - Apply skip sides for nsTableCellFrame's border and padding, and use it to calculate available space to reflow children. r=dbaron Before this patch, nsTableCellFrame never skips border and padding. If it needs to be broken into multiple fragments, its children don't have a correct available space to reflow. (A side effect of this is that nsTableCellFrame renders correctly if it has box-decoration-break:clone.) table-nested-1308876-1-ref.html is modified to reflect the rendering after applying this patch, which isn't necessarily correct (based on the file's comment). Differential Revision: https://phabricator.services.mozilla.com/D71096
f0e5f7503048733d676a587628328ce1c7734859: Bug 1626129 - Add more reftests for breaking a table cell. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Sat, 16 May 2020 00:51:55 +0000 - rev 530441
Push 37421 by cbrindusan@mozilla.com at Sat, 16 May 2020 09:34:57 +0000
Bug 1626129 - Add more reftests for breaking a table cell. r=dbaron 2a and 2b are copied from 1a and 1b with "box-decoration-break: clone" added. 3a and 3b are copied from 1a and 1b. They test that the content fit but the table cell's bottom border and padding cannot fit. As of this bug, their rendering matches the block frame's, but 3a can now trigger a "data loss" warning and 3b an assertion in nsTableRowGroupFrame::SplitRowGroup. That might need a deeper look into table's pagination to have a proper fix. Differential Revision: https://phabricator.services.mozilla.com/D72051
3fdea5ae7d2adc43fa865d3a063c5da577f52d58: Bug 1626129 - Apply skip sides for nsTableCellFrame's border and padding, and use it to calculate available space to reflow children. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Sat, 16 May 2020 00:39:58 +0000 - rev 530440
Push 37421 by cbrindusan@mozilla.com at Sat, 16 May 2020 09:34:57 +0000
Bug 1626129 - Apply skip sides for nsTableCellFrame's border and padding, and use it to calculate available space to reflow children. r=dbaron Before this patch, nsTableCellFrame never skips border and padding. If it needs to be broken into multiple fragments, its children don't have a correct available space to reflow. (A side effect of this is that nsTableCellFrame renders correctly if it has box-decoration-break:clone.) table-nested-1308876-1-ref.html is modified to reflect the rendering after applying this patch, which isn't necessarily correct (based on the file's comment). Differential Revision: https://phabricator.services.mozilla.com/D71096
74d50028caec9d5856a173c98a6172700f1ccc29: Bug 1634840 - Remove warning about inlines in XUL. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 May 2020 23:57:55 +0000 - rev 528314
Push 37383 by rgurzau@mozilla.com at Wed, 06 May 2020 09:37:16 +0000
Bug 1634840 - Remove warning about inlines in XUL. r=dbaron It's not like we're going to change behavior here anytime soon anymore (other than removing XUL usage), and the helpfulness of the warning has probably decreased with time. But maybe I'm missing a reason why it should be kept around? Differential Revision: https://phabricator.services.mozilla.com/D73544
64f8f93b3f810b5bb151c387bd073296b5989955: Bug 1630928 - Remove dead code in nsSprocketLayout r=dbaron
Kagami Sascha Rosylight <saschanaz@outlook.com> - Fri, 17 Apr 2020 17:29:23 +0000 - rev 524637
Push 37324 by shindli@mozilla.com at Fri, 17 Apr 2020 21:46:50 +0000
Bug 1630928 - Remove dead code in nsSprocketLayout r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D71310
68b5bfbd0a89adb33810ed9139abae4f28de6f33: Bug 1622673 - Converting integer literal to bool literal. r=dbaron
Atharva Raykar <raykar.ath@gmail.com> - Mon, 16 Mar 2020 21:48:12 +0000 - rev 519059
Push 37220 by aiakab@mozilla.com at Tue, 17 Mar 2020 05:13:41 +0000
Bug 1622673 - Converting integer literal to bool literal. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D66960
b6affc2813062a8e5a227a3ecf679e13c0c7a853: Bug 1614101 - Add a crashtest. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 04 Mar 2020 17:47:33 +0000 - rev 516885
Push 37183 by nerli@mozilla.com at Thu, 05 Mar 2020 04:16:49 +0000
Bug 1614101 - Add a crashtest. r=dbaron Depends on D63385 Differential Revision: https://phabricator.services.mozilla.com/D63386
25126aa01673794de76a9562501a5b7cdbdfa409: Bug 1614101 - Make sure ColumnSet does not split in the last reflow if ColumnSetWrapper's available block-size is unconstrained. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 04 Mar 2020 18:21:01 +0000 - rev 516884
Push 37183 by nerli@mozilla.com at Thu, 05 Mar 2020 04:16:49 +0000
Bug 1614101 - Make sure ColumnSet does not split in the last reflow if ColumnSetWrapper's available block-size is unconstrained. r=dbaron Checking ColumnSet's available block-size [1] makes no sense nowadays because ColumnSet is an inner frame under ColumnSetWrapper. We should check ColumnSetWrapper's available block-size instead. Also, bump assertions count for 1015844.html on Android, which is a crashtest having multicols. [1] The comment was also misleading, which said it was checking ColumnSet's "block-size", but it actually was checking available block-size. Differential Revision: https://phabricator.services.mozilla.com/D63385
5ecd70faa23fbf5e7fe4e4b1168a62f9a068acd6: Bug 1614101 - Make sure ColumnSet does not split in the last reflow if ColumnSetWrapper's available block-size is unconstrained. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 03 Mar 2020 13:07:40 +0000 - rev 516874
Push 37183 by nerli@mozilla.com at Thu, 05 Mar 2020 04:16:49 +0000
Bug 1614101 - Make sure ColumnSet does not split in the last reflow if ColumnSetWrapper's available block-size is unconstrained. r=dbaron Checking ColumnSet's available block-size [1] makes no sense nowadays because ColumnSet is an inner frame under ColumnSetWrapper. We should check ColumnSetWrapper's available block-size instead. [1] The comment was also misleading, which said it was checking ColumnSet's "block-size", but it actually was checking available block-size. Differential Revision: https://phabricator.services.mozilla.com/D63385
d9a3e282d399da777348d316594905aefffae505: Bug 1598754 Part 2 - Remove the infrastructure that imports wpt tests. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 02 Mar 2020 00:40:13 +0000 - rev 516292
Push 37173 by btara@mozilla.com at Mon, 02 Mar 2020 21:27:32 +0000
Bug 1598754 Part 2 - Remove the infrastructure that imports wpt tests. r=dbaron The last css suite (css-writing-modes) is removed in Part 1. We can remove the infrastructure. Differential Revision: https://phabricator.services.mozilla.com/D62985
b066d8667720492ad5018f840ddc3a1287ed53a6: Bug 1598754 Part 1 - Remove w3c-css/received/css-writing-modes reftests. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 02 Mar 2020 00:40:07 +0000 - rev 516291
Push 37173 by btara@mozilla.com at Mon, 02 Mar 2020 21:27:32 +0000
Bug 1598754 Part 1 - Remove w3c-css/received/css-writing-modes reftests. r=dbaron See bug 1598754 comment 1 for an analysis and observation after aligning the pass/fail state with wpt. This patch is generated by 1. removing `os.path.join("css-writing-modes"),` in import-tests.py. 2. removing the relevent annotations of css-writing-modes in failures.list. 3. running import-tests.py on a wpt repository at commit 15f199c91a72b0d51bf0a12b3b77827ecb5051ff. Differential Revision: https://phabricator.services.mozilla.com/D62984
33e4b5e3f51bb2c92fbf1a7801edd233cdd1ca25: Bug 1598754 Part 0 - Migrate test annotations from the received CSS reftests to wpt ini files. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 02 Mar 2020 00:08:37 +0000 - rev 516290
Push 37173 by btara@mozilla.com at Mon, 02 Mar 2020 21:27:32 +0000
Bug 1598754 Part 0 - Migrate test annotations from the received CSS reftests to wpt ini files. r=dbaron In this patch, we migrate the fuzzy annotations and bug numbers from layout/reftests/w3c-css/failures.list to corresponding wpt ini files. That is, some of the failures on macOS in wpt ini files are actually successes with some fuzzy. Differential Revision: https://phabricator.services.mozilla.com/D63614
812f473fa40baa223475bb9d49f9b0a9830569bd: Bug 1619041 - Avoid unnecessary operations in nsCellMap::HasMoreThanOneCell. r=dbaron
Alex Henrie <alexhenrie24@gmail.com> - Sat, 29 Feb 2020 19:42:16 +0000 - rev 516263
Push 37170 by shindli@mozilla.com at Sun, 01 Mar 2020 09:48:02 +0000
Bug 1619041 - Avoid unnecessary operations in nsCellMap::HasMoreThanOneCell. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D64856
b7887ba587ecead299c9bc5457ad6bbd97cf42b8: Bug 1618085 - Avoid calling Get(Row|Col)Span unnecessarily in nsCellMap::RemoveCell. r=dbaron
Alex Henrie <alexhenrie24@gmail.com> - Thu, 27 Feb 2020 20:26:30 +0000 - rev 516030
Push 37165 by aiakab@mozilla.com at Fri, 28 Feb 2020 09:24:28 +0000
Bug 1618085 - Avoid calling Get(Row|Col)Span unnecessarily in nsCellMap::RemoveCell. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D64280
10d9d01b505f8b6b6cf1446a9d94331e0fd3ef31: Bug 1616879 - [reftest] Add some selftests for invalid manifests, r=dbaron
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 26 Feb 2020 14:15:14 +0000 - rev 515671
Push 37161 by aciure@mozilla.com at Thu, 27 Feb 2020 03:39:37 +0000
Bug 1616879 - [reftest] Add some selftests for invalid manifests, r=dbaron Adds some tests to cover error cases in reftest manifests. This is far from comprehensive, but gives us an easy place to add more in the future. Differential Revision: https://phabricator.services.mozilla.com/D63718
70d1596f7beb256a92cfa4e67aa9c1538568b67f: Bug 1616879 - [reftest] Exit gracefully when there is an error parsing the manifests, r=dbaron
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 26 Feb 2020 14:25:46 +0000 - rev 515670
Push 37161 by aciure@mozilla.com at Thu, 27 Feb 2020 03:39:37 +0000
Bug 1616879 - [reftest] Exit gracefully when there is an error parsing the manifests, r=dbaron Currently a parsing error causes reftest.jsm to hang, leaving the browser open. Once the browser is manually closed, the Python side then emits an unrelated traceback (since it assumes that parsing was succesful). This ensures we both quit Firefox and check that parsing was successful (and exit gracefully if not). Differential Revision: https://phabricator.services.mozilla.com/D63728
983029a110b2f33a66c8dc3ef9dbfc0d79bde615: Bug 1496147 - part 2: Remove nsAutoPtr usages from layout/inspector/. r=dbaron
Tetsuharu OHZEKI <tetsuharu.ohzeki@gmail.com> - Wed, 26 Feb 2020 04:14:14 +0000 - rev 515606
Push 37158 by opoprus@mozilla.com at Wed, 26 Feb 2020 09:27:57 +0000
Bug 1496147 - part 2: Remove nsAutoPtr usages from layout/inspector/. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D64058
a183c3e2eacf965b4d910a205d417dfe9a88b0c6: Bug 1616368 - [reftest] Replace 'default-preferences' with 'defaults' r=dbaron
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 20 Feb 2020 18:47:54 +0000 - rev 514844
Push 37143 by aiakab@mozilla.com at Fri, 21 Feb 2020 05:56:31 +0000
Bug 1616368 - [reftest] Replace 'default-preferences' with 'defaults' r=dbaron With the new 'defaults' key being added, 'default-preferences' is now redundant. This commit converts all existing uses of 'default-preferences' to use 'defaults' instead. Differential Revision: https://phabricator.services.mozilla.com/D63247
3eb51d4d849995a9c70f235dd335d923e0220f14: Bug 1616368 - [reftest] Implement ability to set manifest-level defaults r=dbaron
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 20 Feb 2020 16:04:18 +0000 - rev 514843
Push 37143 by aiakab@mozilla.com at Fri, 21 Feb 2020 05:56:31 +0000
Bug 1616368 - [reftest] Implement ability to set manifest-level defaults r=dbaron This introduces a new 'defaults' key to reftest manifests. It works similarly to the existing 'default-preferences' key except it can be used for any test modifier (e.g, skip-if, fail-if, pref, etc.). See the changes to README.txt in this commit for an explanation on how to use it. Differential Revision: https://phabricator.services.mozilla.com/D63246
d3f05d3ccabb9ec2e3de1a3e060d3bc17e39c5d6: Bug 1614904 - Add difference summary to reftest analyzer, r=dbaron
James Graham <james@hoppipolla.co.uk> - Fri, 14 Feb 2020 19:19:32 +0000 - rev 514292
Push 37130 by ccoroiu@mozilla.com at Mon, 17 Feb 2020 16:08:11 +0000
Bug 1614904 - Add difference summary to reftest analyzer, r=dbaron Add text with the total number of pixels that differ and the maximum difference per channel, since this is useful when generating fuzzy annotations for e.g. antialiasing differences. Differential Revision: https://phabricator.services.mozilla.com/D62566
8c82c4edaf85a9fc269b7b7f02e060776f67f848: Bug 1598753 - Remove w3c-css/received/css-values reftests. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 11 Feb 2020 23:33:23 +0000 - rev 513456
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1598753 - Remove w3c-css/received/css-values reftests. r=dbaron See bug 1598753 comment 1 for the analysis. This patch is generated by 1. removing `os.path.join("css-values"),` in import-tests.py 2. removing the relevent annotations of css-values 3. running import-tests.py on a wpt repository at commit 15f199c91a72b0d51bf0a12b3b77827ecb5051ff. Differential Revision: https://phabricator.services.mozilla.com/D62142
3e2d9328d59b6af9ad780030437a629cb8ccdb12: Bug 1381938: Add native theme for Windows that avoids native system calls. r=mstange,dbaron
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Mon, 10 Feb 2020 19:26:01 +0000 - rev 513435
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1381938: Add native theme for Windows that avoids native system calls. r=mstange,dbaron Differential Revision: https://phabricator.services.mozilla.com/D33310
164ee9eaa19e1418e0c6bac9e0fe7580629baa74: Bug 1613834 - Remove redundant check from nsTableCellMap::RemoveColsAtEnd. r=dbaron
Alex Henrie <alexhenrie24@gmail.com> - Sat, 08 Feb 2020 06:29:28 +0000 - rev 512962
Push 37102 by opoprus@mozilla.com at Sat, 08 Feb 2020 21:46:08 +0000
Bug 1613834 - Remove redundant check from nsTableCellMap::RemoveColsAtEnd. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D61962
76ee012b6099f1b2d4095d9d57c2e41f7a7c5a2c: Bug 1598751 - Remove w3c-css/received/css-conditional reftests. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 05 Feb 2020 02:59:07 +0000 - rev 512535
Push 37092 by apavel@mozilla.com at Wed, 05 Feb 2020 16:27:17 +0000
Bug 1598751 - Remove w3c-css/received/css-conditional reftests. r=dbaron No test in css-conditional reftests are failures, which matches testing/web-platform/meta/css/css-conditional. This patch is generated by 1. manually removing `os.path.join("css-conditional"),` in import-tests.py, and 2. running import-tests.py on a wpt repository at commit 15f199c91a72b0d51bf0a12b3b77827ecb5051ff. Differential Revision: https://phabricator.services.mozilla.com/D61594
b1f4b2a1a2da115c49c72e5189497bf6b5f8088c: Bug 1610387 - Remove nsAutoPtr usage from layout/. r=dbaron
Eric Rahm <erahm@mozilla.com> - Sat, 01 Feb 2020 09:40:36 +0000 - rev 512307
Push 37079 by btara@mozilla.com at Sat, 01 Feb 2020 21:36:42 +0000
Bug 1610387 - Remove nsAutoPtr usage from layout/. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D60455
b7913d9672618a733d4f19bf27ba04b2956c132a: Bug 1308636 Part 3 - Remove moz-prefixed aliases for column-gap and CSS multi-column properties. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Jan 2020 21:45:19 +0000 - rev 510541
Push 37025 by opoprus@mozilla.com at Fri, 17 Jan 2020 09:44:53 +0000
Bug 1308636 Part 3 - Remove moz-prefixed aliases for column-gap and CSS multi-column properties. r=dbaron Introduce a new pref "layout.css.prefixes.columns" to guard the prefixed aliases. The modification to `properties-db.js` was generated by `./mach devtools-css-db`. Differential Revision: https://phabricator.services.mozilla.com/D59564
08e88920caa4631645d93bad0f9ca9ed5d8ba630: Bug 1308636 Part 2 - Convert CSSOM usages of moz-prefixed column properties in tests. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Jan 2020 21:45:17 +0000 - rev 510540
Push 37025 by opoprus@mozilla.com at Fri, 17 Jan 2020 09:44:53 +0000
Bug 1308636 Part 2 - Convert CSSOM usages of moz-prefixed column properties in tests. r=dbaron This patch was generated by the following shell script. ``` function remove_column_prefix() { echo "Renaming $1 to $2" find .\ -type f\ ! -path "./obj*"\ ! -path "./.git"\ ! -path "./.hg"\ \( -name "*.html" -or\ -name "*.xhtml" -or\ -name "*.xht" -or\ -name "*.xul" -or\ -name "*.xml" -or\ -name "*.svg" \)\ -exec sed -i -e "s/$1/$2/g" "{}" \; } remove_column_prefix "MozColumn" "column" ``` Differential Revision: https://phabricator.services.mozilla.com/D59563
21f9476a9588ac2958ce93e3975db9d2112cd39d: Bug 1308636 Part 1 - Convert -moz-column-span to column-span in a crashtest. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Jan 2020 21:45:15 +0000 - rev 510539
Push 37025 by opoprus@mozilla.com at Fri, 17 Jan 2020 09:44:53 +0000
Bug 1308636 Part 1 - Convert -moz-column-span to column-span in a crashtest. r=dbaron -moz-column-span missed the conversion in Bug 1308587 Part 2. https://hg.mozilla.org/mozilla-central/rev/bb59a0c37162 Differential Revision: https://phabricator.services.mozilla.com/D59562
fce0d0696080c4e6e52d5860b4f8875a3072d19c: Bug 1603088 Part 2 - Delete NS_FRAME_CONTAINS_RELATIVE_BSIZE manipulation in nsColumnSetFrame::Reflow(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 Jan 2020 02:48:14 +0000 - rev 509291
Push 36993 by dluca@mozilla.com at Wed, 08 Jan 2020 09:41:58 +0000
Bug 1603088 Part 2 - Delete NS_FRAME_CONTAINS_RELATIVE_BSIZE manipulation in nsColumnSetFrame::Reflow(). r=dbaron Nowadays, ColumnSetFrame is an inner frame under ColumnSetWrapperFrame. It always has "block-size: auto", so `aReflowInput.ComputedBSize()` always equals to NS_UNCONSTRAINEDSIZE. Also, -moz-column-content no longer has "max-block-size: 100%", so NS_FRAME_CONTAINS_RELATIVE_BSIZE can never be set on ColumnSetFrame when constructing ReflowInputs for ColumnSetFrame's children in `ReflowInput::InitResizeFlags`. Removing the bit is not needed, either. Differential Revision: https://phabricator.services.mozilla.com/D58732
969b70e2596026eb043064f93e86c1c899dc4dfd: Bug 1603088 Part 1 - Remove "max-block-size: 100%" for -moz-column-set and -moz-column-content. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 Jan 2020 02:48:12 +0000 - rev 509290
Push 36993 by dluca@mozilla.com at Wed, 08 Jan 2020 09:41:58 +0000
Bug 1603088 Part 1 - Remove "max-block-size: 100%" for -moz-column-set and -moz-column-content. r=dbaron Simply remove "max-block-size: 100%" for -moz-column-set and -moz-column-content breaks abspos-breaking-dynamic-{001,002,003}.html. We need to reflow ColumnSetWrapper's children whenever ColumnSetWrapper's block-size or max-block-size is changed because both size affect the available block-size for ColumnSetWrapper's children. We set `NS_FRAME_CONTAINS_RELATIVE_BSIZE` for ColumnSetWrapperFrame so that it will set itself dirty in `selfDirty` in `nsBlockFrame::ReflowDirtyLines`, and mark its lines dirty if `aState.mReflowInput.IsBResize()` is true. Differential Revision: https://phabricator.services.mozilla.com/D58731
2bd2d03f3c45dfbe63d553021749116f76e2b9d3: Bug 1603088 Part 2 - Delete NS_FRAME_CONTAINS_RELATIVE_BSIZE manipulation in nsColumnSetFrame::Reflow(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 07 Jan 2020 20:19:27 +0000 - rev 509170
Push 36993 by dluca@mozilla.com at Wed, 08 Jan 2020 09:41:58 +0000
Bug 1603088 Part 2 - Delete NS_FRAME_CONTAINS_RELATIVE_BSIZE manipulation in nsColumnSetFrame::Reflow(). r=dbaron Nowadays, ColumnSetFrame is an inner frame under ColumnSetWrapperFrame. It always has "block-size: auto", so `aReflowInput.ComputedBSize()` always equals to NS_UNCONSTRAINEDSIZE. Also, -moz-column-content no longer has "max-block-size: 100%", so NS_FRAME_CONTAINS_RELATIVE_BSIZE can never be set on ColumnSetFrame when constructing ReflowInputs for ColumnSetFrame's children in `ReflowInput::InitResizeFlags`. Removing the bit is not needed, either. Differential Revision: https://phabricator.services.mozilla.com/D58732
d4cc66fb7593c2ca68b4e2507e04ceae8e38cd9d: Bug 1603088 Part 1 - Remove "max-block-size: 100%" for -moz-column-set and -moz-column-content. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 07 Jan 2020 19:17:27 +0000 - rev 509169
Push 36993 by dluca@mozilla.com at Wed, 08 Jan 2020 09:41:58 +0000
Bug 1603088 Part 1 - Remove "max-block-size: 100%" for -moz-column-set and -moz-column-content. r=dbaron Simply remove "max-block-size: 100%" for -moz-column-set and -moz-column-content breaks abspos-breaking-dynamic-{001,002,003}.html. We need to reflow ColumnSetWrapper's children whenever ColumnSetWrapper's block-size or max-block-size is changed because both size affect the available block-size for ColumnSetWrapper's children. We set `NS_FRAME_CONTAINS_RELATIVE_BSIZE` for ColumnSetWrapperFrame so that it will set itself dirty in `selfDirty` in `nsBlockFrame::ReflowDirtyLines`, and mark its lines dirty if `aState.mReflowInput.IsBResize()` is true. Differential Revision: https://phabricator.services.mozilla.com/D58731
6acdb1c2177c8567a0dc1ff8e40f81371f0d22b8: Bug 1499281 - Remove column-span pref in StaticPrefList.yaml (finale). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 31 Dec 2019 16:26:31 +0000 - rev 508548
Push 36969 by opoprus@mozilla.com at Wed, 01 Jan 2020 09:29:38 +0000
Bug 1499281 - Remove column-span pref in StaticPrefList.yaml (finale). r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D58403
b463feb2d14f15513b7b5510e1b49ba0af419f78: Bug 1499281 - Remove column-span pref in mochitests and property databases. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 31 Dec 2019 19:33:15 +0000 - rev 508547
Push 36969 by opoprus@mozilla.com at Wed, 01 Jan 2020 09:29:38 +0000
Bug 1499281 - Remove column-span pref in mochitests and property databases. r=dbaron Move the content of bug1503420.html to test_frame_reconstruction_for_column_span.html because we don't need to flip the pref and load the test in an iframe. The modification to devtools's properties-db.js is generated via `./mach devtools-css-db`. Differential Revision: https://phabricator.services.mozilla.com/D58402
f33481e1f091b4ac4224f32153c7b3d41184b51c: Bug 1499281 - Remove column-span pref in reftest.list/crashtest.list, and remove duplicate reftest runs. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 31 Dec 2019 16:23:30 +0000 - rev 508546
Push 36969 by opoprus@mozilla.com at Wed, 01 Jan 2020 09:29:38 +0000
Bug 1499281 - Remove column-span pref in reftest.list/crashtest.list, and remove duplicate reftest runs. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D58401
a9f7a8549f238d0487f8733e968ae03f516d5cbe: Bug 1499281 - Delete column-span pref in wpt meta files. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 31 Dec 2019 19:35:51 +0000 - rev 508545
Push 36969 by opoprus@mozilla.com at Wed, 01 Jan 2020 09:29:38 +0000
Bug 1499281 - Delete column-span pref in wpt meta files. r=dbaron If the files contain only column-span pref, they are deleted. Differential Revision: https://phabricator.services.mozilla.com/D58400
bd4c3d5143875a0499f7b1e3d4bcc3d9be7125ca: Bug 1499281 - Remove column-span pref in column.mako.rs. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 31 Dec 2019 16:15:12 +0000 - rev 508544
Push 36969 by opoprus@mozilla.com at Wed, 01 Jan 2020 09:29:38 +0000
Bug 1499281 - Remove column-span pref in column.mako.rs. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D58399
a761a31f55f7d32297067b2ffe1860e544282988: Bug 1499281 - Remove column-span pref in nsCSSFrameConstructor. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 31 Dec 2019 16:13:41 +0000 - rev 508543
Push 36969 by opoprus@mozilla.com at Wed, 01 Jan 2020 09:29:38 +0000
Bug 1499281 - Remove column-span pref in nsCSSFrameConstructor. r=dbaron For BeginBuildingColumns, returning nsBlockFrame, i.e. the original NS_NewColumnSetWrapperFrame's return type, should be sufficient since no other caller in frame constructor needs to call ColumnSetWrapper's methods. Differential Revision: https://phabricator.services.mozilla.com/D58398
d1e2cdfd4b57b3d470732ecfd4641ce515a4216c: Bug 1499281 - Remove column-span pref in nsBlockFrame. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 31 Dec 2019 16:11:07 +0000 - rev 508542
Push 36969 by opoprus@mozilla.com at Wed, 01 Jan 2020 09:29:38 +0000
Bug 1499281 - Remove column-span pref in nsBlockFrame. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D58397
62a41cc1264ebceedd1458b60f1c1500f0565794: Bug 1499281 - Remove column-span pref in nsColumnSetFrame. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 31 Dec 2019 16:10:21 +0000 - rev 508541
Push 36969 by opoprus@mozilla.com at Wed, 01 Jan 2020 09:29:38 +0000
Bug 1499281 - Remove column-span pref in nsColumnSetFrame. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D58396