searching for reviewer(dbaron)
156a12d60812b8278be43327f70e2bd76640799a: Bug 1348839 - Add a web platform test which tests max-height imposes constraint on column boxes' height. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 May 2019 22:05:09 +0000 - rev 474660
Push 36043 by rmaries@mozilla.com at Tue, 21 May 2019 09:44:47 +0000
Bug 1348839 - Add a web platform test which tests max-height imposes constraint on column boxes' height. r=dbaron This reftest renders correctly since bug 1411422 is landed. Differential Revision: https://phabricator.services.mozilla.com/D31690
d1c992257a76532251141ab763fb7c2ac8eb5376: Bug 1544995 - Always update overflow areas up to the preserve-3d root. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Sun, 19 May 2019 22:39:58 +0000 - rev 474659
Push 36043 by rmaries@mozilla.com at Tue, 21 May 2019 09:44:47 +0000
Bug 1544995 - Always update overflow areas up to the preserve-3d root. r=dbaron We don't store post-transform overflow areas for frames within preserve-3d, but we do store pre-transform overflow areas. Rather than just recomputing the changed overflow for the root, we should recompute overflows for all ancestors up to the 3d root. Differential Revision: https://phabricator.services.mozilla.com/D31213
1ca7d32474c635ae947a747fdc3eae8e22e3050b: Bug 1409114 - Part 10: Make sure we build display items for table parts where only the normal position is visible, since we may need to create background items for ancestors at that position. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:16:39 +0000 - rev 474636
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1409114 - Part 10: Make sure we build display items for table parts where only the normal position is visible, since we may need to create background items for ancestors at that position. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29447
69b049f546226b6bcc288986bbf60d792f01bf8f: Bug 1409114 - Part 8: Create column and column group background display items as part of the cell's BuildDisplayList. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:16:09 +0000 - rev 474634
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1409114 - Part 8: Create column and column group background display items as part of the cell's BuildDisplayList. r=dbaron This is the main performance improvement, and means that we no longer have to iterate all the cells for each column. It has a couple of behaviour changes: The first is that we no longer apply stacking context effects (like opacity) to column and column group backgrounds. I believe this is correct as per both CSS2.1 Appendix E, and css-tables-3 (quoted in nsTableColFrame::BuildDisplayList). This matches the behaviour of blink and WebKit. We also previously created items in column,row ordering, whereas now they will be in row,column. In cases where two cells overlap (using rowspan and colspan to extend multiple neighbours in to the same place) this can render backgrounds in a different order, but the new behaviour matches blink and WebKit. Differential Revision: https://phabricator.services.mozilla.com/D29280
e88eae3b48a71d611ae395582d170548caf9bd28: Bug 1409114 - Part 6: Store column and column group backgrounds separately, and then append then before the rest of the table contents. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:15:39 +0000 - rev 474632
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1409114 - Part 6: Store column and column group backgrounds separately, and then append then before the rest of the table contents. r=dbaron This also changes behaviour a bit, previously we interleaved column and column group backgrounds. where we now put all the column group backgrounds behind all columns. I believe this is the correct ordering as per CSS2.2 Appendix E. Column backgrounds can overlap when using 'span', and we now render this in a different order, but this matches what other browsers do. Differential Revision: https://phabricator.services.mozilla.com/D29278
34651ebcbaf4c94329b367e1752ba15dc0d25604: Bug 1409114 - Part 5: Skip box-shadow for table column and column groups. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:15:19 +0000 - rev 474631
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1409114 - Part 5: Skip box-shadow for table column and column groups. r=dbaron This is a behaviour change, but I believe it matches the quoted spec text, and neither blink nor WebKit render these. Differential Revision: https://phabricator.services.mozilla.com/D29276
5137a23cfbba44349e31649fb11e57b7fd3eeeba: Bug 1409114 - Part 4: Hoist outline skipping into col(group) frame code. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:14:59 +0000 - rev 474630
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1409114 - Part 4: Hoist outline skipping into col(group) frame code. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29275
c0aa0d405e3c38c2b63b57eac0843ec7e3a0f0b3: Bug 1409114 - Part 2: Get rid of generic table painting code, and handle each class separately. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 20 May 2019 23:14:45 +0000 - rev 474628
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1409114 - Part 2: Get rid of generic table painting code, and handle each class separately. r=dbaron Most of the code in DisplayGenericTablePart was all within a per-class if statement, so it doesn't add much value, and makes the control flow harder to understand. Differential Revision: https://phabricator.services.mozilla.com/D29273
09ef16b1c51fa6917986aea632e61a3f153b7ce8: Bug 1550535: Mark outer svg frames as reflow roots. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 15 May 2019 04:04:38 +0000 - rev 474571
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1550535: Mark outer svg frames as reflow roots. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D30671
9c5a51b331c230990ffe63f9f73b57d46c2ac20e: Bug 1547162 Part 3 - Strip "-moz" prefix for all column properties in the received tests, and mark multicol-span-000-ref.xht pass. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 09 May 2019 23:32:50 +0000 - rev 473344
Push 35995 by apavel@mozilla.com at Fri, 10 May 2019 09:50:15 +0000
Bug 1547162 Part 3 - Strip "-moz" prefix for all column properties in the received tests, and mark multicol-span-000-ref.xht pass. r=dbaron multicol-span-000.xht passes because the id in <div id="column-span">123456</div> was incorrect replaced by "-moz-column-span". Strip the "-moz" prefix fixed it. Except failures.list, other files were modified mechanically by running import-tests.py against https://github.com/web-platform-tests/wpt commit 15f199c91a72b0d51bf0a12b3b77827ecb5051ff (the same commit in received/import.log). Differential Revision: https://phabricator.services.mozilla.com/D30406
108d96d047cd3ee2ec1750a802276c14141804c6: Bug 1547162 Part 2 - Remove all the column properties from gPrefixedProperties in import-tests.py. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 09 May 2019 23:32:00 +0000 - rev 473343
Push 35995 by apavel@mozilla.com at Fri, 10 May 2019 09:50:15 +0000
Bug 1547162 Part 2 - Remove all the column properties from gPrefixedProperties in import-tests.py. r=dbaron Also, build gPrefixRegexp and replace lines only if gPrefixedProperties is non-empty. Otherwise, the import tests are messed up due to bogus gPrefixRegexp. Differential Revision: https://phabricator.services.mozilla.com/D30405
82c216e530eaaa56d5b59f95542f6835465241ff: Bug 1547162 Part 1 - Remove unused variables and imports in import-test.py. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 09 May 2019 23:30:17 +0000 - rev 473342
Push 35995 by apavel@mozilla.com at Fri, 10 May 2019 09:50:15 +0000
Bug 1547162 Part 1 - Remove unused variables and imports in import-test.py. r=dbaron This is discovered by running "flake8 import-tests.py" locally. Differential Revision: https://phabricator.services.mozilla.com/D30404
cef0cd7882055d20b8db85c0d717fdd52122f577: Bug 1548118 Part 4 - Always mark inner ColumnSetWrapper's children dirty before reflowing it if the outer ColumnSetWrapper is balancing. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 03:12:18 +0000 - rev 472999
Push 35985 by dvarga@mozilla.com at Wed, 08 May 2019 11:13:21 +0000
Bug 1548118 Part 4 - Always mark inner ColumnSetWrapper's children dirty before reflowing it if the outer ColumnSetWrapper is balancing. r=dbaron ColumnSetFrame always tries to reflow column content regardless of it's dirtiness. Making ColumnSetWrapperFrame's children dirty can have the same effect. Differential Revision: https://phabricator.services.mozilla.com/D29435
970a59a74aed7c06d25e9da071d527c86d829f9a: Bug 1548118 Part 3 - Remove margin-bottom from column-balancing-nested-001.html and its reference. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 03:12:18 +0000 - rev 472998
Push 35985 by dvarga@mozilla.com at Wed, 08 May 2019 11:13:21 +0000
Bug 1548118 Part 3 - Remove margin-bottom from column-balancing-nested-001.html and its reference. r=dbaron Per bug 1487927, margin-bottom value is not always rendered as expected with our column balancing algorithm. I'd like to remove it from column-balancing-nested-001.html, and add <br> to separate each cases. Differential Revision: https://phabricator.services.mozilla.com/D30287
152fb420ffc57e19cd0015c5ca57421c535d1268: Bug 1548118 Part 2 - Extract computing column balancing depth logic to a function. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 03:12:05 +0000 - rev 472997
Push 35985 by dvarga@mozilla.com at Wed, 08 May 2019 11:13:21 +0000
Bug 1548118 Part 2 - Extract computing column balancing depth logic to a function. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29434
3db2c18f995048c3c7f2dc494ce7e582e9f374c1: Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 03:09:19 +0000 - rev 472996
Push 35985 by dvarga@mozilla.com at Wed, 08 May 2019 11:13:21 +0000
Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron We use `columnCount == aConfig.mBalanceColCount - 1` in other places to determine if we are at the last column. Advancing the column count at the end of the loop make the condition consistent. Differential Revision: https://phabricator.services.mozilla.com/D29433
516cc2c504f5650083dddd563fa27c6a9cec615a: Bug 1548118 Part 3 - Always mark inner ColumnSetWrapper's children dirty before reflowing it if the outer ColumnSetWrapper is balancing. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 06 May 2019 23:09:35 +0000 - rev 472802
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1548118 Part 3 - Always mark inner ColumnSetWrapper's children dirty before reflowing it if the outer ColumnSetWrapper is balancing. r=dbaron ColumnSetFrame always tries to reflow column content regardless of it's dirtiness. Making ColumnSetWrapperFrame's children dirty can have the same effect. Differential Revision: https://phabricator.services.mozilla.com/D29435
40a074be8bf08c2f8e3ca3da13ccad5328bac624: Bug 1548118 Part 2 - Extract computing column balancing depth logic to a function. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 03 May 2019 19:25:57 +0000 - rev 472801
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1548118 Part 2 - Extract computing column balancing depth logic to a function. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29434
f3821529e27617e69d4d4c2547c275a03f6a731a: Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 03 May 2019 19:24:03 +0000 - rev 472800
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron We use `columnCount == aConfig.mBalanceColCount - 1` in other places to determine if we are at the last column. Advancing the column count at the end of the loop make the condition consistent. Differential Revision: https://phabricator.services.mozilla.com/D29433
acac503a73616055e6c27786640ad8dd81a5cd96: Bug 1547852: Only enable dynamic reflow roots up through early beta. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 29 Apr 2019 23:10:55 +0000 - rev 471835
Push 35935 by shindli@mozilla.com at Tue, 30 Apr 2019 03:46:04 +0000
Bug 1547852: Only enable dynamic reflow roots up through early beta. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29288
4442722c78cd11e811a6830ea5a2da48507e8f40: Bug 1547606 - Mark multicol-span-all-margin-bottom-001.xht fail for Android x86 non-e10s. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 29 Apr 2019 18:43:08 +0000 - rev 471807
Push 35935 by shindli@mozilla.com at Tue, 30 Apr 2019 03:46:04 +0000
Bug 1547606 - Mark multicol-span-all-margin-bottom-001.xht fail for Android x86 non-e10s. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D29234
09a1e16dfaf1ec52411572132ec73ba444f2288d: Bug 1547086 Part 2 - Enable column-span preference to fix existing test failures. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Sat, 27 Apr 2019 22:03:54 +0000 - rev 471670
Push 35925 by dluca@mozilla.com at Sun, 28 Apr 2019 09:38:09 +0000
Bug 1547086 Part 2 - Enable column-span preference to fix existing test failures. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D28893
145b3692b5935a43e3789c448b521f06e778f1c1: Bug 1547086 Part 1 - Improve import-test.py, and regenerate received/reftest.list. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Sat, 27 Apr 2019 22:03:54 +0000 - rev 471669
Push 35925 by dluca@mozilla.com at Sun, 28 Apr 2019 09:38:09 +0000
Bug 1547086 Part 1 - Improve import-test.py, and regenerate received/reftest.list. r=dbaron import.log and reftest.list are generated automatically. I run import-test.py on Linux, and the filenames in import.log are not sorted properly, so I make them sort case-insensitively to reproduce the exact same order in import.log. Differential Revision: https://phabricator.services.mozilla.com/D29064
c4f25a740b967189ab6b42c9434c984ab143dd8d: Bug 1411422 - Make percentage block size children work without "height:100%" in ::-moz-column-set and ::-moz-column-content. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 19 Apr 2019 22:02:45 +0000 - rev 470274
Push 35891 by rgurzau@mozilla.com at Sat, 20 Apr 2019 09:35:22 +0000
Bug 1411422 - Make percentage block size children work without "height:100%" in ::-moz-column-set and ::-moz-column-content. r=dbaron After introducing column-span, the ColumnSetWrapperFrame can have more than one ColumnSetFrame children if there's any column-span:all child. Thus we cannot use "height:100%" to pass block size information down to the -moz-column-content's children. Skip column span wrapper in nsIFrame::IsBlockWrapper() so that the percentage column-span:all works. Before this patch, the height of column contents are set to 100% of the multicol container, so if the previous in-flows of column content anonymous boxes consume all the height, later in-flows's height are all 0. In this patch, we don't restrict column-content's height, so their height are calculated based on their children's height. column-contain-1a.html passes because it can now correctly calculate the union of all the column content's rect to find the correct sticky positioning. Differential Revision: https://phabricator.services.mozilla.com/D27627
331387fa113c0e34e5405a558161f7f0512a9973: Bug 1544285 - tools/ automated ESLint no-throw-literal fixes. r=dbaron
Ian Moody <moz-ian@perix.co.uk> - Tue, 16 Apr 2019 15:02:05 +0000 - rev 469812
Push 35883 by btara@mozilla.com at Wed, 17 Apr 2019 21:47:29 +0000
Bug 1544285 - tools/ automated ESLint no-throw-literal fixes. r=dbaron Result of running: $ mach eslint -funix tools/ | sed -Ee 's/:.+//' - | xargs sed -E \ -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \ -e 's/throw \(/throw new Error(/g' -i Differential Revision: https://phabricator.services.mozilla.com/D27450
a77e9a735527f210aaa6e99d995b13512dbb533e: Bug 1118168 - Always call GetColFrame on the nsTableFrame's first-in-flow. r=dbaron
Mats Palmgren <mats@mozilla.com> - Tue, 09 Apr 2019 18:16:23 +0200 - rev 468635
Push 35844 by nbeleuzu@mozilla.com at Tue, 09 Apr 2019 22:10:47 +0000
Bug 1118168 - Always call GetColFrame on the nsTableFrame's first-in-flow. r=dbaron
989c26cee55799444632810744affc2f8228252b: Bug 1489295 Part 4 - Remove InitAndWrapInColumnSetFrameIfNeeded(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 22 Mar 2019 02:47:32 +0000 - rev 465738
Push 35746 by shindli@mozilla.com at Sat, 23 Mar 2019 09:46:24 +0000
Bug 1489295 Part 4 - Remove InitAndWrapInColumnSetFrameIfNeeded(). r=dbaron The last consumer of the method is removed in Part 3. Depends on D24396 Differential Revision: https://phabricator.services.mozilla.com/D24470
804b15f4d2299995b7c212ddc50c54ac8bd1f58f: Bug 1489295 Part 3 - Implement column-span:all for <button>. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 22 Mar 2019 02:50:34 +0000 - rev 465737
Push 35746 by shindli@mozilla.com at Sat, 23 Mar 2019 09:46:24 +0000
Bug 1489295 Part 3 - Implement column-span:all for <button>. r=dbaron We need to pull outerFrame one level up to the outer scope because it's needed when calling FinishBuildingColumns(). The patch is very similar to implementing column-span:all for <fieldset> in bug 1535200. Differential Revision: https://phabricator.services.mozilla.com/D24396
d53a78255fdb06dc17d7944b9ae6cf05aeeb8c38: Bug 1489295 Part 2 - Clean up the naming of a 'nsStyleContext' variable in ConstructFrameFromItemInternal(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 21 Mar 2019 18:27:39 +0000 - rev 465736
Push 35746 by shindli@mozilla.com at Sat, 23 Mar 2019 09:46:24 +0000
Bug 1489295 Part 2 - Clean up the naming of a 'nsStyleContext' variable in ConstructFrameFromItemInternal(). r=dbaron Rename outerSC to outerStyle because nsStyleContext was gone. Depends on D24394 Differential Revision: https://phabricator.services.mozilla.com/D24395
c6d13b9a5c5c2e2028cc1307fba9e6a5f1ae9b9f: Bug 1489295 Part 1 - Rename frame construction data bit that creates flex/grid/column. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 22 Mar 2019 02:39:16 +0000 - rev 465735
Push 35746 by shindli@mozilla.com at Sat, 23 Mar 2019 09:46:24 +0000
Bug 1489295 Part 1 - Rename frame construction data bit that creates flex/grid/column. r=dbaron After supporting column-span, the top-level container for multicol layout is no longer the ColumnSetFrame, so remove the "SET" suffix from FCDATA_ALLOW_GRID_FLEX_COLUMNSET bit to make it sound more general. Also, update the document and add an assertion. Differential Revision: https://phabricator.services.mozilla.com/D24394
803ea92e7423cc609b736b2b596debd3565cab15: Bug 1535200 Part 2 - Implement column-span:all for fieldset elements. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 21 Mar 2019 06:02:02 +0000 - rev 465355
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1535200 Part 2 - Implement column-span:all for fieldset elements. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D23618
7b5a7b0be77d02b1a1ad6866125486176c4681db: Bug 1533885 - Bail out from MaybeRecreateForColumnSpan if aFrameList is empty. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 20 Mar 2019 21:17:38 +0000 - rev 465307
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1533885 - Bail out from MaybeRecreateForColumnSpan if aFrameList is empty. r=dbaron The test case triggers MOZ_ASSERT(!IsFramePartOfIBSplit(aParentFrame)) in MaybeRecreateForColumnSpan() because WipeContainingBlock() returns early when the FrameConstructionItemList is empty. Thus, it doesn't wipe the aParentFrame even if it's part of an IB split. An empty FrameConstructionItemList constructs no frames. Therefore, MaybeRecreateForColumnSpan() doesn't need to do anything if aFrameList is empty since an empty frame list cannot contain any column-span. Differential Revision: https://phabricator.services.mozilla.com/D23820
4f88eb70887ac247a2daef2c1f0675a6de89d012: Bug 1501665 - No bug: Add comment with rationale behind choice of default viewport. r=dbaron DONTBUILD CLOSED TREE
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 05 Mar 2019 18:01:07 +0000 - rev 462481
Push 35652 by shindli@mozilla.com at Wed, 06 Mar 2019 04:36:55 +0000
Bug 1501665 - No bug: Add comment with rationale behind choice of default viewport. r=dbaron DONTBUILD CLOSED TREE Especially in view of the patches for bug 1501665, which seem to have some- what misunderstood the reason for the choice of viewport width here. Differential Revision: https://phabricator.services.mozilla.com/D20950
159753062cfa8b9a00885b4879bd5f22157c5280: Bug 1501665 - No bug: Add comment with rationale behind choice of default viewport. r=dbaron
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 05 Mar 2019 18:01:07 +0000 - rev 462427
Push 35652 by shindli@mozilla.com at Wed, 06 Mar 2019 04:36:55 +0000
Bug 1501665 - No bug: Add comment with rationale behind choice of default viewport. r=dbaron Especially in view of the patches for bug 1501665, which seem to have some- what misunderstood the reason for the choice of viewport width here. Differential Revision: https://phabricator.services.mozilla.com/D20950
72127702116cd18973ab501edfcb04bdc4cbe68a: Bug 1530048 part 2: Add test to verify that table, td, and th draw borders using 'currentColor'. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 05 Mar 2019 00:52:20 +0000 - rev 462385
Push 35650 by shindli@mozilla.com at Tue, 05 Mar 2019 21:40:07 +0000
Bug 1530048 part 2: Add test to verify that table, td, and th draw borders using 'currentColor'. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D21249
8ff9537201ef4849f867d490a8686fa408ce24fd: Bug 1530048 part 1: Remove quirks-mode-only UA stylesheet rule that made table borders gray. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 04 Mar 2019 23:33:50 +0000 - rev 462384
Push 35650 by shindli@mozilla.com at Tue, 05 Mar 2019 21:40:07 +0000
Bug 1530048 part 1: Remove quirks-mode-only UA stylesheet rule that made table borders gray. r=dbaron This quirk was originally for compatibility with IE, but IE doesn't have this special behavior anymore (in quirks-mode or in standards-mode). And Blink/WebKit have yet another set of behaviors, which are also not quirks-mode-dependent, and vary depending on the part of the table: https://bugs.chromium.org/p/chromium/issues/detail?id=935708 https://bugs.chromium.org/p/chromium/issues/detail?id=935729 Differential Revision: https://phabricator.services.mozilla.com/D21175
4bb1dd0270b6cf251823b865184d1dc0f3250eb6: Bug 1531740 - make reftest-analyzer.xhtml stricter finding images r=dbaron
Sam Sneddon <me@gsnedders.com> - Tue, 05 Mar 2019 00:23:49 +0000 - rev 462352
Push 35650 by shindli@mozilla.com at Tue, 05 Mar 2019 21:40:07 +0000
Bug 1531740 - make reftest-analyzer.xhtml stricter finding images r=dbaron Depends on D21688 Differential Revision: https://phabricator.services.mozilla.com/D21689
a351f6e4fb9ca04267ef9e5e15d4d7a0e682ac9e: Bug 1530008 - make reftest-analyzer.xhtml work with local WPT output r=dbaron
Sam Sneddon <me@gsnedders.com> - Tue, 05 Mar 2019 10:03:52 +0000 - rev 462351
Push 35650 by shindli@mozilla.com at Tue, 05 Mar 2019 21:40:07 +0000
Bug 1530008 - make reftest-analyzer.xhtml work with local WPT output r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D21688
ed020882a3184d96905bae0100d16a96b9cbcf8f: Bug 1465457 - Load osx theme reftests over chrome r=dbaron
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 26 Feb 2019 17:13:46 +0000 - rev 461232
Push 35621 by ncsoregi@mozilla.com at Wed, 27 Feb 2019 04:29:56 +0000
Bug 1465457 - Load osx theme reftests over chrome r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D20586
ec6c7dcf2f315c17d913553bbf0654c091d2622f: Bug 1465457 - Add support for chrome reftests r=dbaron
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 26 Feb 2019 17:13:44 +0000 - rev 461231
Push 35621 by ncsoregi@mozilla.com at Wed, 27 Feb 2019 04:29:56 +0000
Bug 1465457 - Add support for chrome reftests r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D20585
52e867c4246a204db6f5b50c14bc11b9e9844711: Bug 1468021 - Handle anonymous content when comparing using DoCompareTreePosition. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 25 Feb 2019 05:22:43 +0000 - rev 460856
Push 35610 by opoprus@mozilla.com at Mon, 25 Feb 2019 16:35:27 +0000
Bug 1468021 - Handle anonymous content when comparing using DoCompareTreePosition. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D20596
dea9d4611ffb99fcd3cb30d6a5d9fc6e67cb80ff: Bug 1527725 - Exclude ColumnSetWrapperFrame from the first letter style consistency check in nsBlockFrame. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 22 Feb 2019 01:14:45 +0000 - rev 460495
Push 35593 by ccoroiu@mozilla.com at Fri, 22 Feb 2019 16:25:14 +0000
Bug 1527725 - Exclude ColumnSetWrapperFrame from the first letter style consistency check in nsBlockFrame. r=dbaron If there's ::first-letter pseudo element on the multicol container, ColumnSetWrapperFrame will have the first letter style, but it won't get the NS_BLOCK_HAS_FIRST_LETTER_STYLE bit during frame construction. The actual first-letter frame construction happens under -moz-column-content anonymous block. This patch excludes ColumnSetWrapperFrame from the debug check to meet the expectation. Add a reftest to make sure ::first-letter and ::first-line still work after introducing ColumnSetWrapperFrame, and no assertion is fired. Differential Revision: https://phabricator.services.mozilla.com/D20757
1634e9d3517804437fe866192d141a6277fb6eba: Bug 1524382 - Flush all out-of-flow frames before destroying the frame list when reframing multicol container. r=dbaron
Ting-Yu Lin <aethanyc@gmail.com> - Tue, 19 Feb 2019 22:37:24 +0000 - rev 460031
Push 35582 by csabou@mozilla.com at Thu, 21 Feb 2019 03:41:50 +0000
Bug 1524382 - Flush all out-of-flow frames before destroying the frame list when reframing multicol container. r=dbaron aFrameList can contain placeholder frames. If we decide to nuke aFrameList, we need to destroy the out-of-flow frames gracefully. In this case, out-of-flow frames are still in nsFrameConstructorState's absolute item lists. To rely on nsPlaceholderFrame::DestroyFrom() to remove its out-of-flow frame properly, we manually flush all the frame insertions for all the lists in aState before destroying aFrameList. Differential Revision: https://phabricator.services.mozilla.com/D19460
b99e716549211d24dcf69e9b4969b88765afdb56: Bug 1508420: Add mochitest for conditions that disqualify a frame from becoming a dynamic reflow root. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 15 Feb 2019 22:00:23 +0000 - rev 459607
Push 35563 by ccoroiu@mozilla.com at Sat, 16 Feb 2019 09:36:04 +0000
Bug 1508420: Add mochitest for conditions that disqualify a frame from becoming a dynamic reflow root. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D14669
1617ad03a14ef357d9e68c103f9291ea8982759a: Bug 1520722 Part 2 - When removing bidi continuations, go no further than the block which needs resolution. r=dbaron
Ting-Yu Lin <aethanyc@gmail.com> - Fri, 01 Feb 2019 06:14:27 +0000 - rev 456362
Push 35481 by opoprus@mozilla.com at Fri, 01 Feb 2019 09:32:11 +0000
Bug 1520722 Part 2 - When removing bidi continuations, go no further than the block which needs resolution. r=dbaron When doing bidi resolution for column-content blocks, we may still traverse the parent chain up in RemoveBidiContinuation, reach nsColumnSetFrame, and accidentally convert nsColumnSetFrame's continuation into fluid ones. Differential Revision: https://phabricator.services.mozilla.com/D17551
506261cc5d79c01c770fcb2e9d450ba8e92c98b1: Bug 1520722 Part 1 - Remove NS_BLOCK_NEEDS_BIDI_RESOLUTION flag from ColumnSpanWrapperFrame. r=dbaron
Ting-Yu Lin <aethanyc@gmail.com> - Thu, 31 Jan 2019 20:19:19 +0000 - rev 456361
Push 35481 by opoprus@mozilla.com at Fri, 01 Feb 2019 09:32:11 +0000
Bug 1520722 Part 1 - Remove NS_BLOCK_NEEDS_BIDI_RESOLUTION flag from ColumnSpanWrapperFrame. r=dbaron Calling nsBlockFrame::ResolveBidi() on ColumnSpanWrapperFrame may cause nsColumnSetFrame's non-fluid continuations being converted into fluid ones in JoinInlineAncestors(). Since ColumnSpanWrapperFrame can only have nsColumnSetFrame and column-span wrappers kids, no need to perform bidi resolution. This doesn't affect column contents because they'll inherit "unicode-bidi" from ColumnSetWrapperFrame in ua.css. Differential Revision: https://phabricator.services.mozilla.com/D17550
efda4de34c171f6acbb19ea1fd07872745df2760: Bug 1504053 - Reframe multi-column container if inserting a subtree with a column-span child. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 31 Jan 2019 02:22:49 +0000 - rev 456173
Push 35473 by opoprus@mozilla.com at Thu, 31 Jan 2019 09:33:17 +0000
Bug 1504053 - Reframe multi-column container if inserting a subtree with a column-span child. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D16077
fd129c882b775e821dea55747d35fc232f58b888: Bug 1517264 - Add support for wrench reftest parsing in the reftest-analyzer. r=dbaron
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 31 Jan 2019 00:30:49 +0000 - rev 456164
Push 35473 by opoprus@mozilla.com at Thu, 31 Jan 2019 09:33:17 +0000
Bug 1517264 - Add support for wrench reftest parsing in the reftest-analyzer. r=dbaron The wrench reftest suite runs reftests on the standalone webrender project, and emits output that is compatible with the reftest analyzer. However, the output takes a slightly different path through taskcluster (the job runs via generic-worker rather than mozharness) and so doesn't have the "(INFO|ERROR) -" prefix that the analyzer expects. This patch loosens that restriction so that these logs can be parsed properly. Differential Revision: https://phabricator.services.mozilla.com/D15577
2c549bcb88d4d940e8442752e095fb47bf5fd081: Bug 1517264 - Add a mechanism to regression-test the reftest parsing code. r=dbaron
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 Jan 2019 21:18:04 +0000 - rev 456163
Push 35473 by opoprus@mozilla.com at Thu, 31 Jan 2019 09:33:17 +0000
Bug 1517264 - Add a mechanism to regression-test the reftest parsing code. r=dbaron This code has gotten tweaked a number of times over the years to support new log formats, but there's always the risk that a tweak will break old log formats. So this patch adds a small test function that can be run by anybody making changes to ensure old logs still parse fine. A few current log samples are tested thusly. Differential Revision: https://phabricator.services.mozilla.com/D15576
56db0b66845e860f59aa8487ef2f2401a9b30460: Bug 1516739 - Stop reparenting absolute/fixed positioned blocks when constructing multicol container. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 25 Jan 2019 07:09:17 +0000 - rev 455752
Push 35457 by csabou@mozilla.com at Tue, 29 Jan 2019 09:20:40 +0000
Bug 1516739 - Stop reparenting absolute/fixed positioned blocks when constructing multicol container. r=dbaron The crash happens when we try to reparent the absolute/fixed positioned children to the non-column-span wrapper's absolute list. When constructing the multicol container, we want it to be the absolute/fixed position container, not the moz-column-content anonymous blocks. Hence the modification in AppendFramesToParent() and ConstructBlock(). Delete AdjustAbsoluteContainingBlock() because we'd like to reparent absolute/fixed children to non-first continuation of block descendant of multicol. And it doesn't crash anymore today. Differential Revision: https://phabricator.services.mozilla.com/D16728