searching for reviewer(dao)
549ce0549c2e6edc4570e12a1e3fdf2a5878fa79: Bug 1800417 - Fix the use of both `toolbarbutton-1` and `subviewbutton` CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
William Durand <will+git@drnd.me> - Wed, 08 Feb 2023 10:25:02 +0000 - rev 652151
Push 40614 by chorotan@mozilla.com at Wed, 08 Feb 2023 15:10:41 +0000
Bug 1800417 - Fix the use of both `toolbarbutton-1` and `subviewbutton` CSS classes in extension widgets. r=Itiel,mconley,dao,rpl Depends on D169088 Differential Revision: https://phabricator.services.mozilla.com/D162712
6dbcf3dd30c4081d5ed69f808cf06c3082259faa: Bug 1800417 - Fix the use of both `toolbarbutton-1` and `subviewbutton` CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
William Durand <will+git@drnd.me> - Wed, 08 Feb 2023 10:25:02 +0000 - rev 652146
Push 40614 by chorotan@mozilla.com at Wed, 08 Feb 2023 15:10:41 +0000
Bug 1800417 - Fix the use of both `toolbarbutton-1` and `subviewbutton` CSS classes in extension widgets. r=Itiel,mconley,dao,rpl Depends on D169088 Differential Revision: https://phabricator.services.mozilla.com/D162712
eb90020763a6287cb3b6a8aa0c137ad241affc63: Bug 1815251 - Make search-textbox work better with flexbox emulation. r=dao
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 06 Feb 2023 19:40:28 +0000 - rev 651908
Push 40610 by abutkovits@mozilla.com at Tue, 07 Feb 2023 04:35:34 +0000
Bug 1815251 - Make search-textbox work better with flexbox emulation. r=dao This makes the history sidebar textbox actually shrink to accommodate the view menu, with flex emulation enabled. Depends on D168968 Differential Revision: https://phabricator.services.mozilla.com/D168969
dda42f47924690c4497d100d00d90f0b1bb4501f: Bug 1815251 - Unify search-textbox.css across platforms. r=Gijs,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 06 Feb 2023 17:30:20 +0000 - rev 651887
Push 40610 by abutkovits@mozilla.com at Tue, 07 Feb 2023 04:35:34 +0000
Bug 1815251 - Unify search-textbox.css across platforms. r=Gijs,dao Easier to see what's going on this way, IMHO. The only intentional behavior change here is that icons are now mirrored in rtl on Linux (they were on Windows already). That seems more of a bugfix than anything else, but lmk if you disagree and I can wrap that in a `@media (-moz-platform)` query. Differential Revision: https://phabricator.services.mozilla.com/D168968
d653e62009bb549bfea127b454a0f55fd07d653f: Bug 1808589 - Enable colorway builtin themes migration on all channels. r=dao
Luca Greco <lgreco@mozilla.com> - Mon, 06 Feb 2023 14:59:41 +0000 - rev 651870
Push 40609 by nfay@mozilla.com at Mon, 06 Feb 2023 21:36:23 +0000
Bug 1808589 - Enable colorway builtin themes migration on all channels. r=dao Differential Revision: https://phabricator.services.mozilla.com/D168572
5d39f3ee0b78927de04d31764b31b058d704e31a: Bug 1781829 - Update contentTheme.js to set attributes and CSS variables on :root instead of body r=dao,extension-reviewers,robwu
Kelly Cochrane <kcochrane@mozilla.com> - Mon, 06 Feb 2023 14:25:39 +0000 - rev 651867
Push 40609 by nfay@mozilla.com at Mon, 06 Feb 2023 21:36:23 +0000
Bug 1781829 - Update contentTheme.js to set attributes and CSS variables on :root instead of body r=dao,extension-reviewers,robwu Differential Revision: https://phabricator.services.mozilla.com/D167869
6155babbad647a311bf52a9354aa55a96db64f60: Bug 1813592 - Implement proper background colors for the current-conditions box in weather suggestions. r=dao,mcheang
Drew Willcoxon <adw@mozilla.com> - Sun, 05 Feb 2023 03:08:28 +0000 - rev 651793
Push 40606 by smolnar@mozilla.com at Sun, 05 Feb 2023 21:12:44 +0000
Bug 1813592 - Implement proper background colors for the current-conditions box in weather suggestions. r=dao,mcheang Differential Revision: https://phabricator.services.mozilla.com/D168190
8393822a099011897ff2be13d52ae7e95e0d2a3d: Bug 1813140 - Don't animate findbar with reduced motion preference r=NeilDeakin,desktop-theme-reviewers,dao
Cieara Meador <cmeador@mozilla.com> - Thu, 02 Feb 2023 22:54:29 +0000 - rev 651611
Push 40600 by smolnar@mozilla.com at Fri, 03 Feb 2023 09:16:39 +0000
Bug 1813140 - Don't animate findbar with reduced motion preference r=NeilDeakin,desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D168622
6bc7d03059ade62c0b8c13dbe681f49ad45f6cf7: Bug 1814318 - Make L10nCache.ensure() re-cache strings when excludeArgsFromCacheKey is set. r=dao
Drew Willcoxon <adw@mozilla.com> - Wed, 01 Feb 2023 17:20:00 +0000 - rev 651407
Push 40596 by abutkovits@mozilla.com at Thu, 02 Feb 2023 04:11:18 +0000
Bug 1814318 - Make L10nCache.ensure() re-cache strings when excludeArgsFromCacheKey is set. r=dao This is an error in how I implemented the `excludeArgsFromCacheKey` mechanism in D167318. It can be fixed by always re-caching strings when `excludeArgsFromCacheKey` is passed to `ensure()`. We could instead store the argument values of currently cached strings and then re-cache only when different argument values are passed to `ensure()`, but that would require a deeper change and I don't think it's worth it. Differential Revision: https://phabricator.services.mozilla.com/D168509
406eefb89345ac2f26eff88e1cc15ed170ebdc5b: Bug 1813302 - Add missing blockL10n property to UrlbarProviderOmnibox payload r=dao,adw
Gregory Pappas <gp3033@protonmail.com> - Tue, 31 Jan 2023 18:50:23 +0000 - rev 651105
Push 40593 by nfay@mozilla.com at Wed, 01 Feb 2023 03:47:20 +0000
Bug 1813302 - Add missing blockL10n property to UrlbarProviderOmnibox payload r=dao,adw Differential Revision: https://phabricator.services.mozilla.com/D168191
7a723f60b5673716f3407d6519a7d30cdbe4344e: Bug 1812445 - Remove declaration that didn't use to have an effect before flexbox emulation. r=dao
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 Jan 2023 12:29:19 +0000 - rev 651036
Push 40592 by nfay@mozilla.com at Tue, 31 Jan 2023 21:03:46 +0000
Bug 1812445 - Remove declaration that didn't use to have an effect before flexbox emulation. r=dao Why was it there? Who knows? Differential Revision: https://phabricator.services.mozilla.com/D167877
08f5c59b7ba44a7d109a5b725682c0c75ed46291: Bug 1812321 - Preserve shrinking behavior of webrtc device selector. r=dao
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 Jan 2023 12:28:23 +0000 - rev 651035
Push 40592 by nfay@mozilla.com at Tue, 31 Jan 2023 21:03:46 +0000
Bug 1812321 - Preserve shrinking behavior of webrtc device selector. r=dao This was mixing old and new flexbox in a way that it happened to work before my patch, but really should've always needed min-width to work. Differential Revision: https://phabricator.services.mozilla.com/D167887
ab00cf793f293710cbd216cd5c0c62fed1d6040e: Bug 1800417 - Fix the use of both `toolbarbutton-1` and `subviewbutton` CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
William Durand <will+git@drnd.me> - Mon, 30 Jan 2023 13:36:07 +0000 - rev 650947
Push 40590 by ctuns@mozilla.com at Tue, 31 Jan 2023 04:25:26 +0000
Bug 1800417 - Fix the use of both `toolbarbutton-1` and `subviewbutton` CSS classes in extension widgets. r=Itiel,mconley,dao,rpl Differential Revision: https://phabricator.services.mozilla.com/D162712
0bd6e56348ffe735e8bc2220b822d5be4bf256fb: Bug 1813302 - Add missing blockL10n property to UrlbarProviderOmnibox payload r=dao,adw
Gregory Pappas <gp3033@protonmail.com> - Mon, 30 Jan 2023 12:55:37 +0000 - rev 650944
Push 40590 by ctuns@mozilla.com at Tue, 31 Jan 2023 04:25:26 +0000
Bug 1813302 - Add missing blockL10n property to UrlbarProviderOmnibox payload r=dao,adw Differential Revision: https://phabricator.services.mozilla.com/D168191
dc4679a2f1a62a5d6f1841787e5177e5cc7332a3: Bug 1813393 - Remove redundant rule in panelUI-shared.css from the Australis era r=dao
Itiel <itiel_yn8@walla.com> - Mon, 30 Jan 2023 11:41:52 +0000 - rev 650934
Push 40589 by ctuns@mozilla.com at Mon, 30 Jan 2023 21:44:13 +0000
Bug 1813393 - Remove redundant rule in panelUI-shared.css from the Australis era r=dao Differential Revision: https://phabricator.services.mozilla.com/D168216
11266428de1b189d7c69d9ac3800acff09cafcbf: Bug 1811128 - Use 16/32px extension icons in toolbars. r=rpl,dao
William Durand <will+git@drnd.me> - Mon, 30 Jan 2023 10:46:12 +0000 - rev 650932
Push 40589 by ctuns@mozilla.com at Mon, 30 Jan 2023 21:44:13 +0000
Bug 1811128 - Use 16/32px extension icons in toolbars. r=rpl,dao Differential Revision: https://phabricator.services.mozilla.com/D167573
c4c6d58c9a4c901fa370916cb8a1d9377eb7b6d4: Bug 1812387 - Remove some styles that didn't use to have an effect before bug 1805414. r=dao
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 27 Jan 2023 12:37:12 +0000 - rev 650788
Push 40584 by smolnar@mozilla.com at Sat, 28 Jan 2023 21:11:06 +0000
Bug 1812387 - Remove some styles that didn't use to have an effect before bug 1805414. r=dao This is the easy, upliftable patch. I'll make a patch to make sure we don't choke on scrollers in the future. Differential Revision: https://phabricator.services.mozilla.com/D167885
a544e102fa0e1c47af2f165f2fdedb715a0ac458: Bug 1781829 - Update contentTheme.js to set attributes and CSS variables on :root instead of body r=dao
Kelly Cochrane <kcochrane@mozilla.com> - Thu, 26 Jan 2023 16:14:31 +0000 - rev 650663
Push 40583 by nbeleuzu@mozilla.com at Fri, 27 Jan 2023 09:46:52 +0000
Bug 1781829 - Update contentTheme.js to set attributes and CSS variables on :root instead of body r=dao Differential Revision: https://phabricator.services.mozilla.com/D167869
dbbe0fa9a1168994e8644f45e2e170528434b87e: Bug 1811373 - Cache weather suggestion l10n strings and allow L10nCache to cache strings only by ID. r=dao
Drew Willcoxon <adw@mozilla.com> - Mon, 23 Jan 2023 17:49:55 +0000 - rev 650233
Push 40574 by smolnar@mozilla.com at Tue, 24 Jan 2023 09:30:00 +0000
Bug 1811373 - Cache weather suggestion l10n strings and allow L10nCache to cache strings only by ID. r=dao This caches weather suggestion l10n strings by adding `cacheable: true` to the view update object returned by the provider. Doing so hooks into UrlbarView's dynamic result type functionality [here](https://searchfox.org/mozilla-central/rev/738b761bb2847f609f9cacc550680071cdc53637/browser/components/urlbar/UrlbarView.sys.mjs#1737-1739). w/r/t l10n strings and caching, weather suggestions are a bit of a new case because most of these strings take arguments that can't be known in advance and that will change over time. For a string with arguments, L10nCache creates a cache key by concating the string's ID and the values of its arguments. That makes sense for strings whose values are things like search engine names, where the set of possible argument values is small and where we may need to show different translated strings when for example the search engine changes. For those strings, we want to cache the translated strings separately using different keys. Weather suggestion strings like "20°C" are a different story. The ideal UX for these strings is: While the UI is waiting for the string to be re-localized with new argument values, it should show the previous localized string with the old argument values. If the argument values have changed, there will still be some flicker as the old values are replaced with the new ones, but it's the best we can do, and at least there won't be empty space in the UI. This isn't possible with L10nCache right now due to how it creates cache keys, as mentioned earlier. So I added a new option that tells it to cache strings by ID only, excluding argument values. That way only one translated string is cached regardless of whatever argument values it was cached with. Differential Revision: https://phabricator.services.mozilla.com/D167318
3c28e34398fe43fa6cdfd9c6a4fe761f8a531fb3: Bug 1811387 - Set width and height on weather suggestion icons. r=dao
Drew Willcoxon <adw@mozilla.com> - Mon, 23 Jan 2023 17:07:01 +0000 - rev 650230
Push 40574 by smolnar@mozilla.com at Tue, 24 Jan 2023 09:30:00 +0000
Bug 1811387 - Set width and height on weather suggestion icons. r=dao I didn't realize before now that most of these SVGs have a height of 23 but six of them have a height of 22. Differential Revision: https://phabricator.services.mozilla.com/D167323
9888716023604d5a07bd9e5988bd83b789ffefe6: Bug 1798335 - replace aboutaddons toggles with moz-toggle r=mstriemer,desktop-theme-reviewers,dao,sfoster
Hanna Jones <hjones@mozilla.com> - Thu, 19 Jan 2023 20:56:02 +0000 - rev 649644
Push 40563 by mlaza@mozilla.com at Fri, 20 Jan 2023 03:46:23 +0000
Bug 1798335 - replace aboutaddons toggles with moz-toggle r=mstriemer,desktop-theme-reviewers,dao,sfoster * replaced the toggle in the addons card that controls enabling/disabling the addon * replaced the toggle that controls optional permissions * fixed tests, added overrides for fx-toggle styles Depends on D160971 Differential Revision: https://phabricator.services.mozilla.com/D160815
fab977235136dd84c1bc71d77a9bc52602f93a32: Bug 1798335 - replace aboutaddons toggles with moz-toggle r=mstriemer,desktop-theme-reviewers,dao,sfoster
Hanna Jones <hjones@mozilla.com> - Thu, 19 Jan 2023 16:52:56 +0000 - rev 649608
Push 40563 by mlaza@mozilla.com at Fri, 20 Jan 2023 03:46:23 +0000
Bug 1798335 - replace aboutaddons toggles with moz-toggle r=mstriemer,desktop-theme-reviewers,dao,sfoster * replaced the toggle in the addons card that controls enabling/disabling the addon * replaced the toggle that controls optional permissions * fixed tests, added overrides for fx-toggle styles Depends on D160971 Differential Revision: https://phabricator.services.mozilla.com/D160815
834df4e872e23a9253d2fff67f6319898a91e4cc: Bug 1810231 - Add an additional mochitest-browser test to cover the colorway builtin themes migration. r=dao,willdurand
Luca Greco <lgreco@mozilla.com> - Wed, 18 Jan 2023 17:00:36 +0000 - rev 649424
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1810231 - Add an additional mochitest-browser test to cover the colorway builtin themes migration. r=dao,willdurand Differential Revision: https://phabricator.services.mozilla.com/D166918
5fd77b37a5d001e4e19b7e4f15816dc5269443e3: Bug 1810231 - Do not add back into retained expired theme pref the active theme if not a colorway builtin. r=dao
Luca Greco <lgreco@mozilla.com> - Wed, 18 Jan 2023 17:00:35 +0000 - rev 649422
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1810231 - Do not add back into retained expired theme pref the active theme if not a colorway builtin. r=dao Differential Revision: https://phabricator.services.mozilla.com/D166917
b92cb2804063d96f6ad3ec8a7c0aadad820e3d8f: Bug 1810231 - Ensure that non-builtin colorways themes are not hidden in about:addons as if they are expired builtin themes. r=willdurand,dao
Luca Greco <lgreco@mozilla.com> - Wed, 18 Jan 2023 17:00:35 +0000 - rev 649421
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1810231 - Ensure that non-builtin colorways themes are not hidden in about:addons as if they are expired builtin themes. r=willdurand,dao Differential Revision: https://phabricator.services.mozilla.com/D166835
bef2fcf4c3a21a9433c00f7875897dfd3f9e9cc3: Bug 1810231 - Prevent BuiltInThemes._uninstallExpiredThemes to uninstall non-builtin colorways themes as expired and not retained. r=dao
Luca Greco <lgreco@mozilla.com> - Wed, 18 Jan 2023 17:00:34 +0000 - rev 649420
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1810231 - Prevent BuiltInThemes._uninstallExpiredThemes to uninstall non-builtin colorways themes as expired and not retained. r=dao Differential Revision: https://phabricator.services.mozilla.com/D166834
37f1909532389c07a2bb0698a2e36792e8e636ca: Bug 1810025 - ensure long data URIs are never fully present in the tab label, r=dao
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 18 Jan 2023 12:17:00 +0000 - rev 649373
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1810025 - ensure long data URIs are never fully present in the tab label, r=dao Differential Revision: https://phabricator.services.mozilla.com/D166737
25e2cd2ef53f28d56325cebe8adc1d0f8126e7fd: Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw,desktop-theme-reviewers,dao
mcheang <mcheang@mozilla.com> - Tue, 17 Jan 2023 15:11:23 +0000 - rev 649124
Push 40559 by nerli@mozilla.com at Wed, 18 Jan 2023 09:51:31 +0000
Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw,desktop-theme-reviewers,dao This patch receives a weather icon id from our merino server. We then use that icon id and map it to a specific weather icon svg file within urlbar-dyanmic-result.css. The icons colors are specified for light, dark, and high contrast mode. Differential Revision: https://phabricator.services.mozilla.com/D166848
89e55040446300268022bb91ac1f57e60e79c357: Bug 1810730 - Use `browser_specific_settings` instead of `applications` in built-in theme manifests.r=dao,rpl
William Durand <will+git@drnd.me> - Tue, 17 Jan 2023 14:40:28 +0000 - rev 649116
Push 40559 by nerli@mozilla.com at Wed, 18 Jan 2023 09:51:31 +0000
Bug 1810730 - Use `browser_specific_settings` instead of `applications` in built-in theme manifests.r=dao,rpl Differential Revision: https://phabricator.services.mozilla.com/D167016
dfce1bce524cf47e098a8f4a7a41425d73362c66: Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw,desktop-theme-reviewers,dao DONTBUILD
mcheang <mcheang@mozilla.com> - Mon, 16 Jan 2023 19:59:19 +0000 - rev 648993
Push 40558 by mlaza@mozilla.com at Tue, 17 Jan 2023 16:13:02 +0000
Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw,desktop-theme-reviewers,dao DONTBUILD This patch receives a weather icon id from our merino server. We then use that icon id and map it to a specific weather icon svg file within urlbar-dyanmic-result.css. The icons colors are specified for light, dark, and high contrast mode. Differential Revision: https://phabricator.services.mozilla.com/D166848
136439e2444d2785cf33df31752adbd62e1900d8: Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao.
Florian Quèze <florian@queze.net> - Mon, 16 Jan 2023 14:55:22 +0000 - rev 648943
Push 40558 by mlaza@mozilla.com at Tue, 17 Jan 2023 16:13:02 +0000
Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao. Differential Revision: https://phabricator.services.mozilla.com/D166099
c6ec3664e1f596c3126be42d9eb30f7e126f6bfa: Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao.
Florian Quèze <florian@queze.net> - Tue, 10 Jan 2023 08:26:07 +0000 - rev 648524
Push 40540 by ctuns@mozilla.com at Tue, 10 Jan 2023 21:45:26 +0000
Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao. Differential Revision: https://phabricator.services.mozilla.com/D166099
4be513bf4ccb7a42498900ac186639cbae6ebe4b: Bug 1808965 - Stop calling _mouseleave and _mouseenter from _setPositionalAttributes. r=dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Mon, 09 Jan 2023 18:29:38 +0000 - rev 648473
Push 40539 by sstanca@mozilla.com at Tue, 10 Jan 2023 09:36:39 +0000
Bug 1808965 - Stop calling _mouseleave and _mouseenter from _setPositionalAttributes. r=dao Calling _mouseleave and _mouseenter from _setPositionalAttributes used to be needed to update the beforehovered and afterhovered attributes, as the tabs these attributes were set on might have changed. However, bug 1808661 removed these attributes, so mouseenter/mouseleave events should be sufficient for updating _hoveredTab itself. _setPositionalAttributes is a hot code-path, so avoiding the expensive querySelector("tab:hover") will improve performance when having lots of tabs. Depends on D166094 Differential Revision: https://phabricator.services.mozilla.com/D166225
b27dac0ce1b6147a511fc61d6a7ecc26512e2a2e: Bug 1806701 - Lock colorways migration behind a pref, disable by default on all channels. r=dao,zombie
Luca Greco <lgreco@mozilla.com> - Mon, 09 Jan 2023 12:31:17 +0000 - rev 648411
Push 40538 by mlaza@mozilla.com at Mon, 09 Jan 2023 21:21:01 +0000
Bug 1806701 - Lock colorways migration behind a pref, disable by default on all channels. r=dao,zombie Depends on D165293 Differential Revision: https://phabricator.services.mozilla.com/D165455
ccfa3cf9a6bdd5f518c33f5c385f35e650eab962: Bug 1806701 - Remove migrated colorways themes from the list of the retained themes. r=zombie,dao
Luca Greco <lgreco@mozilla.com> - Mon, 09 Jan 2023 12:31:17 +0000 - rev 648410
Push 40538 by mlaza@mozilla.com at Mon, 09 Jan 2023 21:21:01 +0000
Bug 1806701 - Remove migrated colorways themes from the list of the retained themes. r=zombie,dao Depends on D165196 Differential Revision: https://phabricator.services.mozilla.com/D165293
0bb92d5fb953846585dff41b018251263570674f: Bug 1806701 - Allow builtin colorway themes to be updated to AMO hosted themes with the same addon ids. r=zombie,dao
Luca Greco <lgreco@mozilla.com> - Mon, 09 Jan 2023 12:31:15 +0000 - rev 648407
Push 40538 by mlaza@mozilla.com at Mon, 09 Jan 2023 21:21:01 +0000
Bug 1806701 - Allow builtin colorway themes to be updated to AMO hosted themes with the same addon ids. r=zombie,dao Differential Revision: https://phabricator.services.mozilla.com/D165194
1a38da4f6de9be57a0c305176990964cac1ac7e3: Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao.
Florian Quèze <florian@queze.net> - Mon, 09 Jan 2023 11:31:28 +0000 - rev 648403
Push 40538 by mlaza@mozilla.com at Mon, 09 Jan 2023 21:21:01 +0000
Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao. Differential Revision: https://phabricator.services.mozilla.com/D166099
bb55d68d351b9ac109cb74265c159883317c0fdc: Bug 1806765 - Implement zero-prefix telemetry and add weather suggestion exposure telemetry. r=dao
Drew Willcoxon <adw@mozilla.com> - Fri, 06 Jan 2023 23:44:19 +0000 - rev 648288
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1806765 - Implement zero-prefix telemetry and add weather suggestion exposure telemetry. r=dao This adds telemetry to UrlbarView that records the following things related to the zero-prefix view (i.e., the topsites view): * Exposures: How many times the ZP view was shown * Engagements: How many times a result was picked in the ZP view * Abandonments: How many times the user abandoned the ZP view * Dwell time: How long the user was shown the ZP view I considered adding telemetry specifically for topsites instead of the ZP view as a whole, but since we have plans to start showing other types of results in the ZP view, I don't think it's a good idea to rely on one specific type of result as a proxy for the view itself. What DS and Product want to know about is the view itself: how many times it was shown, for how long, etc. This also adds one related scalar related to weather suggestions that counts the number of times it's shown. This is the same scalar I added in D164778 using a different, more complex approach. Depends on D164615 Differential Revision: https://phabricator.services.mozilla.com/D165253
1af752ee7a9d1fdf51d57a4c87378e1ba3e2e044: Bug 1808661 - Remove beforehovered and afterhovered. r=dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:02 +0000 - rev 648287
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1808661 - Remove beforehovered and afterhovered. r=dao Differential Revision: https://phabricator.services.mozilla.com/D166094
ef929be929e54e74c1f9bfc7a67668d0031ea340: Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:01 +0000 - rev 648286
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao Depends on D166026 Differential Revision: https://phabricator.services.mozilla.com/D166027
f7ba804ea8ec6284e075d10a233f22306b40a4e3: Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:01 +0000 - rev 648285
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166026
7b073cd0f4d7ff866929a504c30fe730eb496116: Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:01 +0000 - rev 648284
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166025
b9aaf8c0af510f07d6ce137f16bacfb196f70e73: Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:00 +0000 - rev 648283
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166024
16871d37b8592175f4c443c2c4efa6ac745c6e1a: Bug 1808661 - Remove beforehovered and afterhovered. r=dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:54 +0000 - rev 648266
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1808661 - Remove beforehovered and afterhovered. r=dao Differential Revision: https://phabricator.services.mozilla.com/D166094
607a282e25f540e03bd140e2475269b538c512ff: Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:54 +0000 - rev 648265
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao Depends on D166026 Differential Revision: https://phabricator.services.mozilla.com/D166027
c2ad604be36106e5ceea7b2fd761d93abf01b54f: Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:53 +0000 - rev 648264
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166026
b22c7589a7bbf5ffa272632e03439af8ccc03dbd: Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:53 +0000 - rev 648263
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166025
b0c1ee751b7aadebaa0fff0356560b36ac83bc87: Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:53 +0000 - rev 648262
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166024
62e68f9b6f862590e90a30dddabfa99206fec504: Bug 1806985 - Use focus-visible instead of focus for PiP buttons. r=pip-reviewers,desktop-theme-reviewers,dao
Niklas Baumgardner <nbaumgardner@mozilla.com> - Thu, 05 Jan 2023 23:36:44 +0000 - rev 648198
Push 40529 by imoraru@mozilla.com at Fri, 06 Jan 2023 09:51:23 +0000
Bug 1806985 - Use focus-visible instead of focus for PiP buttons. r=pip-reviewers,desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D165909
ee61be99fb13bb08b94aaa3a50903a3a471cf0f6: Bug 1806903 - More from Mozilla - inline flow for description links. r=pdahiya,settings-reviewers,amy,dao
Shane Hughes <shughes@mozilla.com> - Thu, 05 Jan 2023 20:08:58 +0000 - rev 648179
Push 40528 by ctuns@mozilla.com at Fri, 06 Jan 2023 04:14:44 +0000
Bug 1806903 - More from Mozilla - inline flow for description links. r=pdahiya,settings-reviewers,amy,dao Differential Revision: https://phabricator.services.mozilla.com/D165346