searching for reviewer(cviecco)
4f90b7fb1918462222c557100342cdd627e2f3f3: bug 1071308 - (2/2) remove libpkix-style chain validation callback from CertVerifier r=cviecco
David Keeler <dkeeler@mozilla.com> - Thu, 25 Sep 2014 11:18:56 -0700 - rev 207509
Push 27556 by ryanvm@gmail.com at Fri, 26 Sep 2014 20:54:36 +0000
bug 1071308 - (2/2) remove libpkix-style chain validation callback from CertVerifier r=cviecco
9dc5491eb546b9d334fd305488d50891e2749773: bug 1071308 - (1/2) rename pinning_enforcement_level to PinningMode for brevity r=cviecco
David Keeler <dkeeler@mozilla.com> - Thu, 25 Sep 2014 11:08:36 -0700 - rev 207508
Push 27556 by ryanvm@gmail.com at Fri, 26 Sep 2014 20:54:36 +0000
bug 1071308 - (1/2) rename pinning_enforcement_level to PinningMode for brevity r=cviecco
4b99d99e7d914561800b8c1c7b758c0f0e07b0cc: Bug 1061483: Remove dependency on NSPR's PR_smprintf, r=cviecco
Brian Smith <brian@briansmith.org> - Sun, 31 Aug 2014 22:03:22 -0700 - rev 203713
Push 27435 by ryanvm@gmail.com at Fri, 05 Sep 2014 15:34:32 +0000
Bug 1061483: Remove dependency on NSPR's PR_smprintf, r=cviecco
27305d251dd61e4d99465a46fb107287ddf47e2f: Bug 1004781: Enable pinning in test mode for facebook (r=cviecco)
Monica Chew <mmc@mozilla.com> - Wed, 27 Aug 2014 14:18:25 -0700 - rev 202074
Push 27390 by cbook@mozilla.com at Thu, 28 Aug 2014 11:07:34 +0000
Bug 1004781: Enable pinning in test mode for facebook (r=cviecco)
c4d1c00413479524bbd1f9ef4ba1f0809099af65: bug 1049095 - re-verify joinee certificate with joining hostname when joining connections r=briansmith r=mcmanus r=cviecco r=mmc r=rbarnes
David Keeler <dkeeler@mozilla.com> - Thu, 21 Aug 2014 10:37:23 -0700 - rev 200922
Push 27358 by kwierso@gmail.com at Fri, 22 Aug 2014 01:22:28 +0000
bug 1049095 - re-verify joinee certificate with joining hostname when joining connections r=briansmith r=mcmanus r=cviecco r=mmc r=rbarnes
55c9c730bbab3719a5fbd9c5621b267128dd3576: Bug 1048642, Part 3: Remove SECStatus GTest utilities, r=cviecco
Brian Smith <brian@briansmith.org> - Sun, 03 Aug 2014 22:45:05 -0700 - rev 199404
Push 27305 by emorley@mozilla.com at Thu, 14 Aug 2014 07:35:52 +0000
Bug 1048642, Part 3: Remove SECStatus GTest utilities, r=cviecco
0c81a8f483a9dc6fc873ebe69ba2c9841edc7bb5: Bug 1048642, Part 2: Change GenerateKeyPair return type from SECStatus to Result, r=cviecco
Brian Smith <brian@briansmith.org> - Mon, 04 Aug 2014 10:59:21 -0700 - rev 199403
Push 27305 by emorley@mozilla.com at Thu, 14 Aug 2014 07:35:52 +0000
Bug 1048642, Part 2: Change GenerateKeyPair return type from SECStatus to Result, r=cviecco
177cced2d9dec0eeb16517b6072ba72054a4eee3: Bug 1048642, Part 1: Change TamperOnce return type from SECStatus to Result, r=cviecco
Brian Smith <brian@briansmith.org> - Sun, 03 Aug 2014 22:49:10 -0700 - rev 199402
Push 27305 by emorley@mozilla.com at Thu, 14 Aug 2014 07:35:52 +0000
Bug 1048642, Part 1: Change TamperOnce return type from SECStatus to Result, r=cviecco
039dd305c56744b09adb910e07cc406df72712ac: Bug 1041344: Refactor mozilla::pkix::CheckCertificatePolicies, r=cviecco
Brian Smith <brian@briansmith.org> - Sat, 19 Jul 2014 18:51:10 -0700 - rev 197617
Push 27249 by ryanvm@gmail.com at Mon, 04 Aug 2014 20:14:35 +0000
Bug 1041344: Refactor mozilla::pkix::CheckCertificatePolicies, r=cviecco
a6147f19dc56aecfcce19a019d8f966db8a32492: Bug 1041343: Use references instead of pointers for TrustLevel output parameters, r=cviecco
Brian Smith <brian@briansmith.org> - Sun, 20 Jul 2014 11:06:26 -0700 - rev 197204
Push 27236 by emorley@mozilla.com at Fri, 01 Aug 2014 15:52:48 +0000
Bug 1041343: Use references instead of pointers for TrustLevel output parameters, r=cviecco
68fe3e5c7181331a5bf13e865cb3c559bfe81400: Bug 1039601: Use bounds-checked DERArray instead of plain arrays in pkixocsp.cpp, r=cviecco
Brian Smith <brian@briansmith.org> - Wed, 16 Jul 2014 09:54:10 -0700 - rev 197203
Push 27236 by emorley@mozilla.com at Fri, 01 Aug 2014 15:52:48 +0000
Bug 1039601: Use bounds-checked DERArray instead of plain arrays in pkixocsp.cpp, r=cviecco
1ed822e820d355e4fae79631f6f888e0b7389fd1: bug 1040889 - don't re-cache OCSP server failures if no fetch was attempted r=briansmith r=cviecco
David Keeler <dkeeler@mozilla.com> - Fri, 25 Jul 2014 16:59:22 -0700 - rev 196235
Push 27208 by cbook@mozilla.com at Mon, 28 Jul 2014 13:33:20 +0000
bug 1040889 - don't re-cache OCSP server failures if no fetch was attempted r=briansmith r=cviecco
9c212e1705f7d31e32e0519c01681abee816b3f2: Bug 1041730: Remove unused parameters from PublicKeyPinningService, r=cviecco
Brian Smith <brian@briansmith.org> - Mon, 21 Jul 2014 19:18:31 -0700 - rev 195752
Push 27193 by kwierso@gmail.com at Thu, 24 Jul 2014 01:16:10 +0000
Bug 1041730: Remove unused parameters from PublicKeyPinningService, r=cviecco
743e4bec5d463de1b5c2d3bca937bc670bcc689a: Bug 1039031: Print name of server in TLS/OCSP tests, r=cviecco
Brian Smith <brian@briansmith.org> - Tue, 15 Jul 2014 16:58:31 -0700 - rev 195751
Push 27193 by kwierso@gmail.com at Thu, 24 Jul 2014 01:16:10 +0000
Bug 1039031: Print name of server in TLS/OCSP tests, r=cviecco
7c53c5e9bd3a2e7b3e4253047825ac9d257d2db1: Bug 360126 - Main tests. r=cviecco
Cykesiopka <cykesiopka.bmo@gmail.com> - Tue, 15 Jul 2014 19:50:00 -0400 - rev 194388
Push 27145 by kwierso@gmail.com at Thu, 17 Jul 2014 00:08:55 +0000
Bug 360126 - Main tests. r=cviecco
440f68cba022b72dd87c1c84de1579cb8295d4eb: Bug 1037324: Delegate additional name constraint selection to the TrustDomain in mozilla::pkix, r=cviecco
Brian Smith <brian@briansmith.org> - Thu, 10 Jul 2014 22:38:59 -0700 - rev 193696
Push 27128 by cbook@mozilla.com at Mon, 14 Jul 2014 12:35:14 +0000
Bug 1037324: Delegate additional name constraint selection to the TrustDomain in mozilla::pkix, r=cviecco
3a4d57c7ffdf74dae7e1c3e1cdadba44750dab15: Bug 1035942: Decide whether to consider end-entity CN as a dnsName in CheckNameConstraints instead of in BuildCertChain, r=cviecco
Brian Smith <brian@briansmith.org> - Tue, 08 Jul 2014 13:04:17 -0700 - rev 193196
Push 27112 by cbook@mozilla.com at Thu, 10 Jul 2014 12:47:23 +0000
Bug 1035942: Decide whether to consider end-entity CN as a dnsName in CheckNameConstraints instead of in BuildCertChain, r=cviecco
2fd971f1a91bba2739ecde89be1d851f60903691: Bug 1035470: Use signature algorithm OID instead of digest algorithm OID in the signature field of certificates in mozilla::pkix tests, r=cviecco
Brian Smith <brian@briansmith.org> - Mon, 07 Jul 2014 00:46:10 -0700 - rev 192759
Push 27096 by cbook@mozilla.com at Tue, 08 Jul 2014 12:41:54 +0000
Bug 1035470: Use signature algorithm OID instead of digest algorithm OID in the signature field of certificates in mozilla::pkix tests, r=cviecco
5d696c6fe0a7d44afa8955d08fc0e7dc1d80cb3c: Bug 1035034: Fix typo in CertVerifier, r=cviecco
Brian Smith <brian@briansmith.org> - Sun, 06 Jul 2014 19:15:13 -0700 - rev 192737
Push 27096 by cbook@mozilla.com at Tue, 08 Jul 2014 12:41:54 +0000
Bug 1035034: Fix typo in CertVerifier, r=cviecco
d2e9bbf6fa8ff44f3ab62b3e0a09d46d80f2d979: Bug 1019770: Add tests for checking of notAfter and notBefore, r=cviecco
Brian Smith <brian@briansmith.org> - Mon, 30 Jun 2014 19:12:35 -0700 - rev 192324
Push 27081 by cbook@mozilla.com at Fri, 04 Jul 2014 11:44:24 +0000
Bug 1019770: Add tests for checking of notAfter and notBefore, r=cviecco
a83d5a927c90e662120a4fc89d1a1753a9f96ae1: Bug 1019770: Add more tests for parsing GeneralizedTime and TimeChoice, r=cviecco
Brian Smith <brian@briansmith.org> - Tue, 01 Jul 2014 18:01:28 -0700 - rev 191822
Push 27063 by cbook@mozilla.com at Wed, 02 Jul 2014 12:51:47 +0000
Bug 1019770: Add more tests for parsing GeneralizedTime and TimeChoice, r=cviecco
278f163756bdca4670846a9c28998d7d4b85bb6a: Bug 1019770, Part 2: modify existing GeneralizedTime tests to test TimeChoice too, r=cviecco
Brian Smith <brian@briansmith.org> - Tue, 24 Jun 2014 10:51:53 -0700 - rev 191821
Push 27063 by cbook@mozilla.com at Wed, 02 Jul 2014 12:51:47 +0000
Bug 1019770, Part 2: modify existing GeneralizedTime tests to test TimeChoice too, r=cviecco
d2ed7720fc40367f88482b370b706980c6ef9989: Bug 1019770: Use mozilla::pkix::der to decode times and certificate validity period, r=cviecco
Brian Smith <brian@briansmith.org> - Tue, 24 Jun 2014 21:48:12 -0700 - rev 191820
Push 27063 by cbook@mozilla.com at Wed, 02 Jul 2014 12:51:47 +0000
Bug 1019770: Use mozilla::pkix::der to decode times and certificate validity period, r=cviecco
91b03a644dbe417d1b6eadb4deea0962380574ba: Bug 1019770: Add more tests for parsing GeneralizedTime and TimeChoice, r=cviecco
Brian Smith <brian@briansmith.org> - Mon, 30 Jun 2014 17:11:56 -0700 - rev 191809
Push 27063 by cbook@mozilla.com at Wed, 02 Jul 2014 12:51:47 +0000
Bug 1019770: Add more tests for parsing GeneralizedTime and TimeChoice, r=cviecco
981f8345edd872edad4117c99f4fa4d184386f4f: Bug 1019770, Part 2: modify existing GeneralizedTime tests to test TimeChoice too, r=cviecco
Brian Smith <brian@briansmith.org> - Tue, 24 Jun 2014 10:51:53 -0700 - rev 191808
Push 27063 by cbook@mozilla.com at Wed, 02 Jul 2014 12:51:47 +0000
Bug 1019770, Part 2: modify existing GeneralizedTime tests to test TimeChoice too, r=cviecco
5ea9b7bd2db54f89aa4413d17f77b02b5298f4ea: Bug 1019770: Use mozilla::pkix::der to decode times and certificate validity period, r=cviecco
Brian Smith <brian@briansmith.org> - Tue, 24 Jun 2014 21:48:12 -0700 - rev 191807
Push 27063 by cbook@mozilla.com at Wed, 02 Jul 2014 12:51:47 +0000
Bug 1019770: Use mozilla::pkix::der to decode times and certificate validity period, r=cviecco
c6b2136514f265399c05419fc1794f32e9561037: Bug 1031022: Go back to accepting explicit encoding of v1 for certificates and OCSP responses, r=cviecco
Brian Smith <brian@briansmith.org> - Thu, 26 Jun 2014 17:03:48 -0700 - rev 191132
Push 27031 by cbook@mozilla.com at Fri, 27 Jun 2014 13:34:56 +0000
Bug 1031022: Go back to accepting explicit encoding of v1 for certificates and OCSP responses, r=cviecco
bfd435db3f9e084c038792100511691581ccdbc6: Bug 1029364: Centralize version parsing in BackCert::Init, r=cviecco
Brian Smith <brian@briansmith.org> - Wed, 25 Jun 2014 01:32:06 -0700 - rev 190895
Push 27018 by cbook@mozilla.com at Thu, 26 Jun 2014 12:15:07 +0000
Bug 1029364: Centralize version parsing in BackCert::Init, r=cviecco
93bc682527b4f3a0888d9877d6c79bef1d3be58c: Bug 1029992, Improve AlgorithmIdentifier decoding in mozilla::pkix, r=cviecco
Brian Smith <brian@briansmith.org> - Tue, 24 Jun 2014 21:47:50 -0700 - rev 190894
Push 27018 by cbook@mozilla.com at Thu, 26 Jun 2014 12:15:07 +0000
Bug 1029992, Improve AlgorithmIdentifier decoding in mozilla::pkix, r=cviecco
4f21e9bc729ae7de280391690af0e5fe77efe912: Bug 1029364: Centralize version parsing in BackCert::Init, r=cviecco
Brian Smith <brian@briansmith.org> - Thu, 19 Jun 2014 16:17:28 -0700 - rev 190632
Push 27011 by cbook@mozilla.com at Wed, 25 Jun 2014 13:30:09 +0000
Bug 1029364: Centralize version parsing in BackCert::Init, r=cviecco
fefe4c4ffe939468dad5203c470046c8a9839073: bug 1027711 - remove some unused const variables in PSM r=cviecco
David Keeler <dkeeler@mozilla.com> - Thu, 19 Jun 2014 10:31:06 -0700 - rev 189626
Push 26992 by kwierso@gmail.com at Fri, 20 Jun 2014 01:07:53 +0000
bug 1027711 - remove some unused const variables in PSM r=cviecco
9bd1ca5794122f2c705f1cdd969bdf19264095a1: Bug 1027311, Part 3: Remove irrelevant & problematic extensions from test_cert_signatures test certificates, r=cviecco
Brian Smith <brian@briansmith.org> - Wed, 18 Jun 2014 13:40:18 -0700 - rev 189540
Push 26988 by emorley@mozilla.com at Thu, 19 Jun 2014 14:39:10 +0000
Bug 1027311, Part 3: Remove irrelevant & problematic extensions from test_cert_signatures test certificates, r=cviecco
a14256377beaba99bcf30874d93ec136d66e2d42: Bug 1027311, Part 2: Remove irrelevant & problematic extensions from test_ev_certs test certificates, r=cviecco
Brian Smith <brian@briansmith.org> - Wed, 18 Jun 2014 15:05:45 -0700 - rev 189539
Push 26988 by emorley@mozilla.com at Thu, 19 Jun 2014 14:39:10 +0000
Bug 1027311, Part 2: Remove irrelevant & problematic extensions from test_ev_certs test certificates, r=cviecco
bff8515586c2b78248c50386263568a173e8dba8: Bug 1027311, Part 1: Remove irrelevant & problematic extensions from test_certificate_usages test certificates, r=cviecco
Brian Smith <brian@briansmith.org> - Wed, 18 Jun 2014 13:56:36 -0700 - rev 189538
Push 26988 by emorley@mozilla.com at Thu, 19 Jun 2014 14:39:10 +0000
Bug 1027311, Part 1: Remove irrelevant & problematic extensions from test_certificate_usages test certificates, r=cviecco
bd1a3bb1b916fb44bb17339c6305fea4f02a6d35: Bug 1026371: Remove useless comments in CertVerifier.cpp, r=cviecco
Brian Smith <brian@briansmith.org> - Mon, 16 Jun 2014 23:37:53 -0700 - rev 189534
Push 26988 by emorley@mozilla.com at Thu, 19 Jun 2014 14:39:10 +0000
Bug 1026371: Remove useless comments in CertVerifier.cpp, r=cviecco
fdd7d059ac9e6173b62b9af1de3e85a03ddafd57: bug 1017160 - remove nsINSSCertErrorDialog and implementation r=cviecco
David Keeler <dkeeler@mozilla.com> - Mon, 09 Jun 2014 16:35:35 -0700 - rev 187921
Push 26939 by kwierso@gmail.com at Wed, 11 Jun 2014 01:28:04 +0000
bug 1017160 - remove nsINSSCertErrorDialog and implementation r=cviecco
4f9febf724b0fed7efda067a6a981f480115f208: Bug 997370 - Update comment in nsIX509Cert.idl to reflect certificate fingerprint instead of public key. r=cviecco
Harsh Pathak <hpathak@mozilla.com> - Mon, 09 Jun 2014 10:58:00 -0400 - rev 187806
Push 26934 by ryanvm@gmail.com at Tue, 10 Jun 2014 04:45:09 +0000
Bug 997370 - Update comment in nsIX509Cert.idl to reflect certificate fingerprint instead of public key. r=cviecco
77f2f8f2c506459e82a1d0cc34dccb605fddc214: Bug 1020682: Simplify mozilla::pkix results cert chain construction and make it more efficient, r=cviecco
Brian Smith <brian@briansmith.org> - Wed, 04 Jun 2014 01:28:44 -0700 - rev 187312
Push 26917 by ryanvm@gmail.com at Sat, 07 Jun 2014 18:13:47 +0000
Bug 1020682: Simplify mozilla::pkix results cert chain construction and make it more efficient, r=cviecco
5c901d7e88bc651bdcbc9d1427a2ba5342166d7a: bug 1003566 - part 2/2: prevent OCSP requests from being upgraded to HTTPS by HSTS r=cviecco
David Keeler <dkeeler@mozilla.com> - Wed, 04 Jun 2014 09:58:28 -0700 - rev 186660
Push 26898 by cbook@mozilla.com at Thu, 05 Jun 2014 12:20:57 +0000
bug 1003566 - part 2/2: prevent OCSP requests from being upgraded to HTTPS by HSTS r=cviecco
e79c9dba2792a39706178dea722ddfdca38508b2: Bug 1009988 - OCSP tests: Precompute responses to prevent timeouts. r=cviecco
David Keeler <dkeeler@mozilla.com> - Mon, 02 Jun 2014 11:35:27 -0700 - rev 186450
Push 26891 by cbook@mozilla.com at Wed, 04 Jun 2014 13:32:40 +0000
Bug 1009988 - OCSP tests: Precompute responses to prevent timeouts. r=cviecco
9b0804cee835153ae33bb01d22bff8a0a107f107: Bug 1018633: Simplify the max cert chain length check code in mozilla::pkix and make it more efficient, r=cviecco
Brian Smith <brian@briansmith.org> - Sat, 31 May 2014 16:32:58 -0700 - rev 186233
Push 26884 by cbook@mozilla.com at Tue, 03 Jun 2014 12:40:39 +0000
Bug 1018633: Simplify the max cert chain length check code in mozilla::pkix and make it more efficient, r=cviecco
a24472ea29d4554271b97075031f7b5bc131557e: Bug 1001188: Set the error code when the max cert chain length limit is exceeded, r=cviecco
Brian Smith <brian@briansmith.org> - Sat, 31 May 2014 16:55:54 -0700 - rev 186232
Push 26884 by cbook@mozilla.com at Tue, 03 Jun 2014 12:40:39 +0000
Bug 1001188: Set the error code when the max cert chain length limit is exceeded, r=cviecco
d03cc4b6832c1dd5a2a7703d98e600b582796b21: Bug 1018642: Factor out reusable NSS GTest infrastructure into a new NSSTest class, r=cviecco
Brian Smith <brian@briansmith.org> - Fri, 30 May 2014 16:46:49 -0700 - rev 186231
Push 26884 by cbook@mozilla.com at Tue, 03 Jun 2014 12:40:39 +0000
Bug 1018642: Factor out reusable NSS GTest infrastructure into a new NSSTest class, r=cviecco
1b779285c164d8a3e34d2d3e4e824197b03300db: Bug 1018018: Remove support/mention of proprietary Netscape certificate extensions from PSM, r=cviecco
Brian Smith <brian@briansmith.org> - Thu, 29 May 2014 20:38:25 -0700 - rev 185935
Push 26871 by philringnalda@gmail.com at Sun, 01 Jun 2014 03:29:42 +0000
Bug 1018018: Remove support/mention of proprietary Netscape certificate extensions from PSM, r=cviecco
e307284f7fa0f46ef9622293e959d10b4a17455a: Bug 1010634, Part 6: Enable -Wall with a few exceptions for certverifier, r=cviecco
Brian Smith <brian@briansmith.org> - Thu, 15 May 2014 21:56:23 -0700 - rev 185934
Push 26871 by philringnalda@gmail.com at Sun, 01 Jun 2014 03:29:42 +0000
Bug 1010634, Part 6: Enable -Wall with a few exceptions for certverifier, r=cviecco
9809ef17342caa595cc28960816f274a41197b43: Bug 1010634, Part 5: Add private destructor to NSSErrorService in line with the XPCOM recommendations, r=cviecco
Brian Smith <brian@briansmith.org> - Thu, 29 May 2014 20:18:17 -0700 - rev 185933
Push 26871 by philringnalda@gmail.com at Sun, 01 Jun 2014 03:29:42 +0000
Bug 1010634, Part 5: Add private destructor to NSSErrorService in line with the XPCOM recommendations, r=cviecco
e1f531152b770898d133e606d1ff746600393a72: Bug 1010634, Part 3: Fix more warnings in CertVerifier, r=cviecco
Brian Smith <brian@briansmith.org> - Thu, 29 May 2014 20:17:53 -0700 - rev 185931
Push 26871 by philringnalda@gmail.com at Sun, 01 Jun 2014 03:29:42 +0000
Bug 1010634, Part 3: Fix more warnings in CertVerifier, r=cviecco
739a582c405c67c1b1a176708eb542af8cd144f8: Bug 998804 - Add support for SHA-1 and SHA-2 digests to WebCrypto API. r=bz, r=cviecco, r=dkeeler
Richard Barnes <rbarnes@mozilla.com> - Sun, 04 May 2014 21:25:00 -0400 - rev 184205
Push 26814 by ryanvm@gmail.com at Wed, 21 May 2014 19:50:12 +0000
Bug 998804 - Add support for SHA-1 and SHA-2 digests to WebCrypto API. r=bz, r=cviecco, r=dkeeler
7ea38414bb31b01471b1beebf149c3cb99023fb7: Bug 995385 - Add WebCrypto WebIDL interfaces. r=bz, r=cviecco, r=dkeeler
Richard Barnes <rbarnes@mozilla.com> - Thu, 15 May 2014 06:20:00 -0400 - rev 184203
Push 26814 by ryanvm@gmail.com at Wed, 21 May 2014 19:50:12 +0000
Bug 995385 - Add WebCrypto WebIDL interfaces. r=bz, r=cviecco, r=dkeeler
6deed68c2358d584d0988b200adc23fc88aa4113: Bug 1010634, Part 1: Fix compiler warnings in certverifier, r=cviecco
Brian Smith <brian@briansmith.org> - Wed, 14 May 2014 17:46:32 -0700 - rev 183491
Push 26793 by ryanvm@gmail.com at Fri, 16 May 2014 18:53:54 +0000
Bug 1010634, Part 1: Fix compiler warnings in certverifier, r=cviecco