searching for reviewer(chmanchester)
2f065070254a3ceb8e15d07aa566898a4ea8030d: Bug 1617794 - Properly set the target flag for bindgen when cross compiling for Windows. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 26 Feb 2020 20:52:09 +0000 - rev 515743
Push 37161 by aciure@mozilla.com at Thu, 27 Feb 2020 03:39:37 +0000
Bug 1617794 - Properly set the target flag for bindgen when cross compiling for Windows. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D64292
b7a8b4961e01b8a38be141bb89cc93f1ad404e4e: Bug 1606922 - Move MOZ_AUTOMATION_PACKAGE_TESTS from mozconfigs to taskcluster; r=tomprince,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 25 Feb 2020 20:13:12 +0000 - rev 515520
Push 37158 by opoprus@mozilla.com at Wed, 26 Feb 2020 09:27:57 +0000
Bug 1606922 - Move MOZ_AUTOMATION_PACKAGE_TESTS from mozconfigs to taskcluster; r=tomprince,chmanchester We don't need to package tests for builds that we don't actually run tests from, but it is tricky to align this correctly by setting MOZ_AUTOMATION_PACKAGE_TESTS=0 in relevant mozconfigs. Instead we can set the environment variable in the task definition, and use a full taskgraph verification check to ensure that the flag is only set on builds that have tests. The one tricky area is the win64-aarch64 builds, which have a workaround by specifying the new skip-verify-test-packaging attribute. In one case, win64-aarch64-shippable has tests that run against it, but it copies those tests from a win64-aarch64-shippable-no-eme task, which itself has no tests. Both of those tasks need to skip the verify check as a result. In another case, the win64-aarch64-eme task is an artifact build that grabs test packages from the win64-aarch64 build. Since the win64-aarch64 build doesn't have tests, it needs to skip the verify check. Differential Revision: https://phabricator.services.mozilla.com/D59426
bc9bf388d476205c4bc7afe402cf5c71e99cb7cc: Bug 1606922 - Move MOZ_AUTOMATION_PACKAGE_TESTS from mozconfigs to taskcluster; r=tomprince,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 24 Feb 2020 19:08:23 +0000 - rev 515481
Push 37158 by opoprus@mozilla.com at Wed, 26 Feb 2020 09:27:57 +0000
Bug 1606922 - Move MOZ_AUTOMATION_PACKAGE_TESTS from mozconfigs to taskcluster; r=tomprince,chmanchester We don't need to package tests for builds that we don't actually run tests from, but it is tricky to align this correctly by setting MOZ_AUTOMATION_PACKAGE_TESTS=0 in relevant mozconfigs. Instead we can set the environment variable in the task definition, and use a full taskgraph verification check to ensure that the flag is only set on builds that have tests. The one tricky area is the win64-aarch64 builds, which have a workaround by specifying the new skip-verify-test-packaging attribute. In one case, win64-aarch64-shippable has tests that run against it, but it copies those tests from a win64-aarch64-shippable-no-eme task, which itself has no tests. Both of those tasks need to skip the verify check as a result. In another case, the win64-aarch64-eme task is an artifact build that grabs test packages from the win64-aarch64 build. Since the win64-aarch64 build doesn't have tests, it needs to skip the verify check. Differential Revision: https://phabricator.services.mozilla.com/D59426
562749d5a8dc5d5ba14e1730704b310458c6cbbc: Bug 1617207 - Enable LTO on Android PGO builds. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 21 Feb 2020 22:22:28 +0000 - rev 515078
Push 37149 by dvarga@mozilla.com at Sat, 22 Feb 2020 09:52:08 +0000
Bug 1617207 - Enable LTO on Android PGO builds. r=chmanchester Turns out we have one more copy of the PGO-initializing mozconfig code for Android, and that one was not enabling LTO. Differential Revision: https://phabricator.services.mozilla.com/D63721
3aa73fde9a37be2bba354aa071df5a50098d8b07: Bug 1495394 - add `mach install-moz-phab` command; r=firefox-build-system-reviewers,chmanchester
byron jones <glob@mozilla.com> - Wed, 19 Feb 2020 05:28:32 +0000 - rev 514549
Push 37137 by csabou@mozilla.com at Wed, 19 Feb 2020 09:53:52 +0000
Bug 1495394 - add `mach install-moz-phab` command; r=firefox-build-system-reviewers,chmanchester Install moz-phab using the correct command for the current operating system as per moz-phab's documentation. Differential Revision: https://phabricator.services.mozilla.com/D59139
ea0c8ca487f6e68e19495036d945b398059a6885: Bug 1613958 - set correct treeherder platform names for macOS webrender and condprof tasks. r=chmanchester
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 07 Feb 2020 20:48:13 +0000 - rev 512979
Push 37105 by apavel@mozilla.com at Mon, 10 Feb 2020 09:39:12 +0000
Bug 1613958 - set correct treeherder platform names for macOS webrender and condprof tasks. r=chmanchester Some webrender and condprof tasks on macOS had raw/'ugly' platform names and were listed at the top of a treeherder push due to that and not together with the other OS X tasks. With this patch applied, they are shown together with the other tasks on that platform. The platform name should reference either cross compile or the platform version it is running on. Differential Revision: https://phabricator.services.mozilla.com/D62051
0081ffb08a1178900bbdb41296e732bd6c81a608: Bug 1613649 - Explicitly opt-out of Rust's local ThinLTO for DEVELOPER_OPTIONS builds. r=firefox-build-system-reviewers,chmanchester
Michael Woerister <mwoerister@mozilla.com> - Fri, 07 Feb 2020 08:55:04 +0000 - rev 512854
Push 37100 by apavel@mozilla.com at Fri, 07 Feb 2020 21:53:54 +0000
Bug 1613649 - Explicitly opt-out of Rust's local ThinLTO for DEVELOPER_OPTIONS builds. r=firefox-build-system-reviewers,chmanchester By default the Rust compiler will perform a limited kind of ThinLTO on each crate. For local builds this additional optimization is not worth the increase in compile time. Differential Revision: https://phabricator.services.mozilla.com/D61821
c02a7a545a87e7d519dc8d36113ee05afcd8bde3: Bug 1613247: Simplify sccache config; r=firefox-build-system-reviewers,chmanchester
Tom Prince <mozilla@hocat.ca> - Thu, 06 Feb 2020 00:52:05 +0000 - rev 512682
Push 37096 by cbrindusan@mozilla.com at Thu, 06 Feb 2020 16:00:29 +0000
Bug 1613247: Simplify sccache config; r=firefox-build-system-reviewers,chmanchester The logic for finding the sccache configuration to use has gone through several iterations. At this point, all the build workers set `TASKCLUSTER_WORKER_LOCATION`, so remove the code for dealing with other configurations. Also don't set sccache configuration if it is disabled, even if the bucket somehow gets set. Differential Revision: https://phabricator.services.mozilla.com/D61635
56c80f46fbe2036d339728811d683adb8a8b2b64: Bug 1613247: Use calculated GCS bucket in mozconfig.cacche; r=firefox-build-system-reviewers,chmanchester
Tom Prince <mozilla@hocat.ca> - Thu, 06 Feb 2020 00:56:00 +0000 - rev 512681
Push 37096 by cbrindusan@mozilla.com at Thu, 06 Feb 2020 16:00:29 +0000
Bug 1613247: Use calculated GCS bucket in mozconfig.cacche; r=firefox-build-system-reviewers,chmanchester The code goes to some length to calculate the bucket to use, but then hard-codes the bucket in the credential URL it uses. Differential Revision: https://phabricator.services.mozilla.com/D61634
4277d047f5b7b05a1a7e12a0067fc91b0b0e3183: Bug 1611990 - Firefox omits Rust log messages of less than WARN level unless compiled in debug mode r=chmanchester
Andy Grover <agrover@mozilla.com> - Thu, 30 Jan 2020 04:51:51 +0000 - rev 512087
Push 37071 by csabou@mozilla.com at Thu, 30 Jan 2020 09:53:03 +0000
Bug 1611990 - Firefox omits Rust log messages of less than WARN level unless compiled in debug mode r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D61254
cf7b92d229abc93af5d85a58317e20859864a511: Bug 1604621 - Remove HAS_MISC_RULE; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Thu, 16 Jan 2020 20:27:09 +0000 - rev 510527
Push 37025 by opoprus@mozilla.com at Fri, 17 Jan 2020 09:44:53 +0000
Bug 1604621 - Remove HAS_MISC_RULE; r=firefox-build-system-reviewers,chmanchester Two of these no longer have any misc:: rules associated with them, and can be removed outright. The remaining misc:: rule in toolkit/components/telemetry is already traversed because it contains EXTRA_COMPONENTS, which are processed during misc in the RecursiveMake backend. So we can remove HAS_MISC_RULE entirely even though we still have a custom misc rule to process addons (until bug 988938 is fixed). Differential Revision: https://phabricator.services.mozilla.com/D59425
f55ac343844fd7fc7be1499527fbbab5ff4508b4: Bug 1603557: Sanitize the environment before running xpcshell tests. r=firefox-build-system-reviewers,chmanchester
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 15 Jan 2020 23:23:46 +0000 - rev 510406
Push 37021 by rmaries@mozilla.com at Thu, 16 Jan 2020 09:46:51 +0000
Bug 1603557: Sanitize the environment before running xpcshell tests. r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D60062
db79a6fe17ca995a61a8deb2df63c487e093b078: Bug 1609422 - Clean up an old rustc version check for pgo r=firefox-build-system-reviewers,chmanchester
David Major <dmajor@mozilla.com> - Wed, 15 Jan 2020 17:14:10 +0000 - rev 510377
Push 37021 by rmaries@mozilla.com at Thu, 16 Jan 2020 09:46:51 +0000
Bug 1609422 - Clean up an old rustc version check for pgo r=firefox-build-system-reviewers,chmanchester We require rustc 1.39 nowadays. Differential Revision: https://phabricator.services.mozilla.com/D60008
dd2f16711abad9c23d42645954d8a6205f1ec14f: Bug 1606922 - Move MOZ_AUTOMATION_PACKAGE_TESTS from mozconfigs to taskcluster; r=firefox-build-system-reviewers,tomprince,chmanchester
Mike Shal <mshal@mozilla.com> - Fri, 10 Jan 2020 22:46:11 +0000 - rev 509827
Push 37004 by shindli@mozilla.com at Sat, 11 Jan 2020 09:48:29 +0000
Bug 1606922 - Move MOZ_AUTOMATION_PACKAGE_TESTS from mozconfigs to taskcluster; r=firefox-build-system-reviewers,tomprince,chmanchester We don't need to package tests for builds that we don't actually run tests from, but it is tricky to align this correctly by setting MOZ_AUTOMATION_PACKAGE_TESTS=0 in relevant mozconfigs. Instead we can set the environment variable in the task definition, and use a full taskgraph verification check to ensure that the flag is only set on builds that have tests. The one tricky task is win64-aarch64-shippable/opt, which copies tests from another build rather than building them itself. For this reason, it explicitly sets MOZ_AUTOMATION_PACKAGE_TESTS: '0' in the environment even though that is now the default. This is why the exception is only raised if MOZ_AUTOMATION_PACKAGE_TESTS is not set at all, rather than checking that it is set to 1. Differential Revision: https://phabricator.services.mozilla.com/D59426
e25eecf3b9f311a224c07e6bedbc50b5b9cfdb84: Bug 1608326 - don't unset WASM_SANDBOXED_LIBRARIES for Linux artifact builds; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 10 Jan 2020 19:56:56 +0000 - rev 509813
Push 37004 by shindli@mozilla.com at Sat, 11 Jan 2020 09:48:29 +0000
Bug 1608326 - don't unset WASM_SANDBOXED_LIBRARIES for Linux artifact builds; r=firefox-build-system-reviewers,chmanchester Otherwise we won't package the necessary libraries, which leads to peculiar runtime failures. Depends on D59555 Differential Revision: https://phabricator.services.mozilla.com/D59556
4e0a4979a559cc08235c940454d715f9e97880fa: Bug 1608326 - only check for wasm tools when compiling; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 10 Jan 2020 19:56:17 +0000 - rev 509812
Push 37004 by shindli@mozilla.com at Sat, 11 Jan 2020 09:48:29 +0000
Bug 1608326 - only check for wasm tools when compiling; r=firefox-build-system-reviewers,chmanchester ...so that we can correctly declare that we are using sandboxed library(ies) from our "parent" build, but not check for all the tools to compile code. Depends on D59554 Differential Revision: https://phabricator.services.mozilla.com/D59555
b3fb961f881e16b57558e0f39d66048796939fca: Bug 1608326 - move most wasm sandboxing configury under an only_when; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 10 Jan 2020 19:56:05 +0000 - rev 509811
Push 37004 by shindli@mozilla.com at Sat, 11 Jan 2020 09:48:29 +0000
Bug 1608326 - move most wasm sandboxing configury under an only_when; r=firefox-build-system-reviewers,chmanchester This change eliminates a lot of repetition, and paves the way for the next change. Differential Revision: https://phabricator.services.mozilla.com/D59554
5b80b9815113b6c9f1b1b2ac8cf765420db77a39: Bug 1601691 - Remove FIXMEs for strict-alias which is WONTFIX r=firefox-build-system-reviewers,chmanchester
Tom Ritter <tom@mozilla.com> - Sat, 07 Dec 2019 03:35:28 +0000 - rev 509184
Push 36993 by dluca@mozilla.com at Wed, 08 Jan 2020 09:41:58 +0000
Bug 1601691 - Remove FIXMEs for strict-alias which is WONTFIX r=firefox-build-system-reviewers,chmanchester Bug 414641 was marked WONTFIX, so let's remove these comments from configure Differential Revision: https://phabricator.services.mozilla.com/D55993
58f20c97d78f59fcd81f78de698a9a912e74b76e: Bug 1607278 - specify memory and guard page sizes for lucetc; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 07 Jan 2020 19:29:24 +0000 - rev 509168
Push 36993 by dluca@mozilla.com at Wed, 08 Jan 2020 09:41:58 +0000
Bug 1607278 - specify memory and guard page sizes for lucetc; r=firefox-build-system-reviewers,chmanchester ...and pull lucetc options out into a separate variable for readability. Differential Revision: https://phabricator.services.mozilla.com/D58830
b5b9d0ead3c37231aeee4d58269fe6e013cbfaf3: Bug 1605189 - update in-tree robustcheckout with latest version r=firefox-build-system-reviewers,chmanchester
Connor Sheehan <sheehan@mozilla.com> - Fri, 20 Dec 2019 16:07:40 +0000 - rev 508111
Push 36938 by btara@mozilla.com at Sat, 21 Dec 2019 09:45:32 +0000
Bug 1605189 - update in-tree robustcheckout with latest version r=firefox-build-system-reviewers,chmanchester This commit vendors `robustcheckout` from commit ff8a7c9c843a9c in version-control-tools. Updates include the removal of some dead code, compatibility with the latest Mercurial, and Python 3 compatibility. Differential Revision: https://phabricator.services.mozilla.com/D57836
94edb5d8488724b414452f7cca193d59609fb6a6: Bug 1605189 - update in-tree robustcheckout with latest version r=firefox-build-system-reviewers,chmanchester
Connor Sheehan <sheehan@mozilla.com> - Fri, 20 Dec 2019 15:17:28 +0000 - rev 508025
Push 36936 by cbrindusan@mozilla.com at Fri, 20 Dec 2019 21:54:48 +0000
Bug 1605189 - update in-tree robustcheckout with latest version r=firefox-build-system-reviewers,chmanchester This commit vendors `robustcheckout` from commit ff8a7c9c843a9c in version-control-tools. Updates include the removal of some dead code, compatibility with the latest Mercurial, and Python 3 compatibility. Differential Revision: https://phabricator.services.mozilla.com/D57836
19faafe628bdf0fdbfa2e8b963c8f804c6c42eb9: Bug 1604881 - fail if user attempts to set CC or CXX with "mk_add_options" in .mozconfig r=firefox-build-system-reviewers,chmanchester
Ricky Stewart <rstewart@mozilla.com> - Thu, 19 Dec 2019 21:00:43 +0000 - rev 507918
Push 36933 by aciure@mozilla.com at Fri, 20 Dec 2019 04:15:17 +0000
Bug 1604881 - fail if user attempts to set CC or CXX with "mk_add_options" in .mozconfig r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D57656
1b761079366e755b61eb6080f0210ad9c443c036: Bug 1601578 - mach - doc environment with python 3 r=ahal,firefox-build-system-reviewers,chmanchester
Sylvestre Ledru <sledru@mozilla.com> - Tue, 17 Dec 2019 19:17:43 +0000 - rev 507445
Push 36927 by aiakab@mozilla.com at Wed, 18 Dec 2019 00:51:03 +0000
Bug 1601578 - mach - doc environment with python 3 r=ahal,firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D55937
45277ab0d6399c7cbaa2c0ffdd023c24ac0accaf: Bug 1601578 - mach - doc environment with python 3 r=ahal,firefox-build-system-reviewers,chmanchester
Sylvestre Ledru <sledru@mozilla.com> - Tue, 17 Dec 2019 01:30:41 +0000 - rev 507347
Push 36926 by aciure@mozilla.com at Tue, 17 Dec 2019 16:17:53 +0000
Bug 1601578 - mach - doc environment with python 3 r=ahal,firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D55937
00ed15d902df9ec15926f9812568518cd49a5f2b: Bug 1603561 - [mozbuild] Ignore all potential objdirs in BuildReader._relevant_mozbuild_finder, r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 17 Dec 2019 01:35:05 +0000 - rev 507328
Push 36925 by apavel@mozilla.com at Tue, 17 Dec 2019 10:44:40 +0000
Bug 1603561 - [mozbuild] Ignore all potential objdirs in BuildReader._relevant_mozbuild_finder, r=firefox-build-system-reviewers,chmanchester Currently BuildReader._relevant_mozbuild_finder attempted to exclude objdirs by ignoring the pattern 'obj*'. However this can cause problems for developers who don't prefix their objdirs with the string 'obj'. This attempts to ignore all objdirs by looking for 'config.status' files in the topsrcdir. This wasn't a huge issue before because BuildReader._relevant_mozbuild_finder was only used in a handful of obscure edge cases. But now it's being invoked by the taskgraph and consequently |mach try|. So we'll see this issue pop up for people more frequently. Differential Revision: https://phabricator.services.mozilla.com/D57113
8514ded81b7734b025db53ce98e9ad7df67dc35c: Bug 1594344 - Part 2: Fetch dump_syms toolchain on Windows builds. r=firefox-build-system-reviewers,chmanchester
Eric Rahm <erahm@mozilla.com> - Fri, 13 Dec 2019 10:27:30 +0000 - rev 506855
Push 36913 by opoprus@mozilla.com at Fri, 13 Dec 2019 16:53:24 +0000
Bug 1594344 - Part 2: Fetch dump_syms toolchain on Windows builds. r=firefox-build-system-reviewers,chmanchester This installs the rust-based `dump_syms` toolchain on Windows builds. Differential Revision: https://phabricator.services.mozilla.com/D53319
21ea137ee89c0d57d28be41185128f0af8b4632e: Bug 1601704 - Work around sccache/rust confusion about mozglue-static. libxul part. r=firefox-build-system-reviewers,chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Sat, 07 Dec 2019 00:03:52 +0000 - rev 506598
Push 36908 by malexandru@mozilla.com at Thu, 12 Dec 2019 09:53:26 +0000
Bug 1601704 - Work around sccache/rust confusion about mozglue-static. libxul part. r=firefox-build-system-reviewers,chmanchester While it doesn't seem to be happening (yet), the same problem that happened with jsrust can just as well happen with other leaf staticlib crates that indirectly use mozglue-static. Differential Revision: https://phabricator.services.mozilla.com/D56159
65d69ba8d88ab562557bb61139fca09381ac25d3: Bug 1602568 - Enable Rust PGO on linux32 and Windows r=firefox-build-system-reviewers,chmanchester
David Major <dmajor@mozilla.com> - Tue, 10 Dec 2019 19:48:04 +0000 - rev 506324
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1602568 - Enable Rust PGO on linux32 and Windows r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D56584
57b641bb4d4b16d55ea64d1140a8b0a2b889393d: Bug 1594344 - Part 2: Fetch dump_syms toolchain on Windows builds. r=firefox-build-system-reviewers,chmanchester
Eric Rahm <erahm@mozilla.com> - Tue, 10 Dec 2019 13:37:09 +0000 - rev 506235
Push 36901 by aciure@mozilla.com at Tue, 10 Dec 2019 21:29:05 +0000
Bug 1594344 - Part 2: Fetch dump_syms toolchain on Windows builds. r=firefox-build-system-reviewers,chmanchester This installs the rust-based `dump_syms` toolchain on Windows builds. Differential Revision: https://phabricator.services.mozilla.com/D53319
c369fd660c237870f1b62dc146920e6ceb22cf08: Bug 1557788 - Remove unused mozharness build variant; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 09 Dec 2019 18:04:02 +0000 - rev 506159
Push 36897 by nbeleuzu@mozilla.com at Tue, 10 Dec 2019 05:01:13 +0000
Bug 1557788 - Remove unused mozharness build variant; r=firefox-build-system-reviewers,chmanchester This is no longer used as of bug 1553065. Differential Revision: https://phabricator.services.mozilla.com/D56118
fd2851b8f09c0b26a6c33f0dfc2857dd5c44e775: Bug 1557788 - Rename MOZ_PGO_PROFILE_USE to TASKCLUSTER_PGO_PROFILE_USE; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 09 Dec 2019 18:03:57 +0000 - rev 506158
Push 36897 by nbeleuzu@mozilla.com at Tue, 10 Dec 2019 05:01:13 +0000
Bug 1557788 - Rename MOZ_PGO_PROFILE_USE to TASKCLUSTER_PGO_PROFILE_USE; r=firefox-build-system-reviewers,chmanchester MOZ_PGO_PROFILE_USE is used to enable certain features in the automation mozconfigs for profile-use builds, including the MOZ_PROFILE_USE configure option. They aren't easily combined into one flag due to the extra settings that are enabled only in automation mozconfigs. Renaming the former variable to TASKCLUSTER_PGO_PROFILE_USE makes it slightly more obvious where it comes from and avoids confusion. Differential Revision: https://phabricator.services.mozilla.com/D56117
c41a9af98fbe8b6ca6ce7f5b0e8a01cd627695af: Bug 1557788 - Remove spurious MOZ_PROFILE_USE ifndefs; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 09 Dec 2019 18:03:53 +0000 - rev 506157
Push 36897 by nbeleuzu@mozilla.com at Tue, 10 Dec 2019 05:01:13 +0000
Bug 1557788 - Remove spurious MOZ_PROFILE_USE ifndefs; r=firefox-build-system-reviewers,chmanchester One of these appears to be mistakenly leftover from bug 861178 which was intended to avoid purging dist/, but the code inside the ifndef no longer does that. The other is from bug 1246881 to avoid re-writing the buildid.h file during the profile-use build, but now that there are two separate builds, they will each have their own buildid.h / source-repo.h files. Differential Revision: https://phabricator.services.mozilla.com/D56116
7dea0dd6a868653e53d8749f467ffd66d38e4f0d: Bug 1557788 - Remove OBJS_VAR_SUFFIX & .i_o suffix for instrumented builds; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 09 Dec 2019 18:03:49 +0000 - rev 506156
Push 36897 by nbeleuzu@mozilla.com at Tue, 10 Dec 2019 05:01:13 +0000
Bug 1557788 - Remove OBJS_VAR_SUFFIX & .i_o suffix for instrumented builds; r=firefox-build-system-reviewers,chmanchester In 1-tier PGO builds that shared the objdir between the instrumented and profile-use builds, the instrumented build objects used a different suffix (.i_o) to separate them from the profile-use build (which uses the default .o suffix). These builds are now always in separate objdirs, and don't need special suffix rules anymore. As a bonus, this helps fix an issue with buildid.cpp continually rebuilding because libxul_so.list always lists the inputs as *.o, which don't exist if we're using a .i_o suffix. Make would always re-create buildid.cpp and therefore libxul.so in the instrumented build even when nothing has changed. Differential Revision: https://phabricator.services.mozilla.com/D56115
3650f8bc5e2af24b0da260436089b62995f47d80: Bug 1557788 - Remove pgo.relink touches; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 09 Dec 2019 18:03:44 +0000 - rev 506155
Push 36897 by nbeleuzu@mozilla.com at Tue, 10 Dec 2019 05:01:13 +0000
Bug 1557788 - Remove pgo.relink touches; r=firefox-build-system-reviewers,chmanchester This was used for Windows MSVC PGO builds that re-used the objdir. We don't use MSVC for PGO anymore, and we don't re-use the objdir. Differential Revision: https://phabricator.services.mozilla.com/D56114
9f837b4fe26464e1d9193f52be895282deeef96c: Bug 1557788 - Remove pgomerge.py; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 09 Dec 2019 18:03:40 +0000 - rev 506154
Push 36897 by nbeleuzu@mozilla.com at Tue, 10 Dec 2019 05:01:13 +0000
Bug 1557788 - Remove pgomerge.py; r=firefox-build-system-reviewers,chmanchester pgomerge.py was needed for Windows MSVC PGO builds. Now that we use clang for these builds, it's no longer used. Differential Revision: https://phabricator.services.mozilla.com/D56113
15921c0ba6c83025284c42e5407b73d0df3d7e39: Bug 1557788 - Remove MOZ_1TIER_PGO; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 09 Dec 2019 18:03:36 +0000 - rev 506153
Push 36897 by nbeleuzu@mozilla.com at Tue, 10 Dec 2019 05:01:13 +0000
Bug 1557788 - Remove MOZ_1TIER_PGO; r=firefox-build-system-reviewers,chmanchester MOZ_1TIER_PGO was a temporary hack to support 1-tier PGO builds while they were being ported to 3-tier. Now that all builds are 3-tier, it can be removed. Differential Revision: https://phabricator.services.mozilla.com/D56112
95d72170f969fb2bd481480d3f4f66bdacb63980: Bug 1557788 - Remove NEED_XVFB from Linux instrumented and rusttest builds; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 09 Dec 2019 18:02:34 +0000 - rev 506152
Push 36897 by nbeleuzu@mozilla.com at Tue, 10 Dec 2019 05:01:13 +0000
Bug 1557788 - Remove NEED_XVFB from Linux instrumented and rusttest builds; r=firefox-build-system-reviewers,chmanchester xvfb was used to create a virtual framebuffer for running Firefox during build jobs to support PGO profile generation. That now runs in a separate task, so we don't need this flag for builds anymore. Note that other Linux builds still need xvfb in order to run xpcshell in 'make check'. Differential Revision: https://phabricator.services.mozilla.com/D56111
0bd674c3129589974b4c86ea9486f0fa1ff2ca5f: Bug 1601872 - Handle the case when the mozconfig has no configure_args r=firefox-build-system-reviewers,chmanchester
David Major <dmajor@mozilla.com> - Fri, 06 Dec 2019 17:41:10 +0000 - rev 505837
Push 36889 by dluca@mozilla.com at Fri, 06 Dec 2019 21:48:33 +0000
Bug 1601872 - Handle the case when the mozconfig has no configure_args r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D56207
b515b0637e5eaf851af4a5aa1f8668c02d1a38ab: Bug 1601704 - Work around sccache/rust confusion about mozglue-static. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 06 Dec 2019 05:08:40 +0000 - rev 505771
Push 36887 by opoprus@mozilla.com at Fri, 06 Dec 2019 09:39:47 +0000
Bug 1601704 - Work around sccache/rust confusion about mozglue-static. r=chmanchester See https://github.com/rust-lang/rust/issues/58393#issuecomment-562410696 Differential Revision: https://phabricator.services.mozilla.com/D56129
ad679d570e5283c1375791dc8b1f84f43e535ad4: Bug 1563403 - Use 3-tier PGO for local MOZ_PGO=1 builds; r=firefox-build-system-reviewers,dmajor,chmanchester
Mike Shal <mshal@mozilla.com> - Fri, 06 Dec 2019 01:07:32 +0000 - rev 505760
Push 36886 by nbeleuzu@mozilla.com at Fri, 06 Dec 2019 04:43:57 +0000
Bug 1563403 - Use 3-tier PGO for local MOZ_PGO=1 builds; r=firefox-build-system-reviewers,dmajor,chmanchester Local PGO builds now use 3-tier machinery under the hood. Instead of a single object directory that gets cleaned in between the instrumented and profile-use builds, now the instrumented build uses a separate '${objdir}/instrumented' directory. This makes it easier to handle within mach since we can drive the two builds with environment variables and keep all build artifacts separate, without needing to do manual cleanup in between. Differential Revision: https://phabricator.services.mozilla.com/D50098
17c3d10bb8dd90b59f7a93099449856ac0ffd23a: Bug 1563403 - disable LTO on --enable-profile-generate; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Fri, 06 Dec 2019 01:03:25 +0000 - rev 505759
Push 36886 by nbeleuzu@mozilla.com at Fri, 06 Dec 2019 04:43:57 +0000
Bug 1563403 - disable LTO on --enable-profile-generate; r=firefox-build-system-reviewers,chmanchester In automation this is normally handled by mozconfigs, but we should disable it automatically during the profile-generate stage for users if they have LTO enabled in their mozconfig while doing a 3-tier PGO build. Differential Revision: https://phabricator.services.mozilla.com/D50097
841428eaea4380aa3152f5107605513791277516: Bug 1563925 - Update crates that have new versions that use rand 0.7. r=firefox-build-system-reviewers,chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 06 Dec 2019 00:22:01 +0000 - rev 505751
Push 36886 by nbeleuzu@mozilla.com at Fri, 06 Dec 2019 04:43:57 +0000
Bug 1563925 - Update crates that have new versions that use rand 0.7. r=firefox-build-system-reviewers,chmanchester As well as a in-tree crate. Differential Revision: https://phabricator.services.mozilla.com/D55916
4a7905b19956b0e3cfe0ac0214c45b87e019a19f: Bug 1601150 - Update cargo workspace hack. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 05 Dec 2019 04:32:15 +0000 - rev 505582
Push 36885 by nbeleuzu@mozilla.com at Thu, 05 Dec 2019 21:53:30 +0000
Bug 1601150 - Update cargo workspace hack. r=chmanchester Bug 1601233 made cranelift bump its syn dependency to 1.0, breaking the workspace hack. Some of the features were also stale from presumably other updates. Differential Revision: https://phabricator.services.mozilla.com/D55897
d2f8a8875708e694346e9ec7b5d5d0761e3662ca: Bug 1600664 - Download the wasi sysroot during bootstrap for Linux r=firefox-build-system-reviewers,chmanchester
Ricky Stewart <rstewart@mozilla.com> - Tue, 03 Dec 2019 20:38:35 +0000 - rev 505168
Push 36880 by malexandru@mozilla.com at Wed, 04 Dec 2019 09:56:40 +0000
Bug 1600664 - Download the wasi sysroot during bootstrap for Linux r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D55481
3fc9e18fc545eb095a98652a9fd95da674ec9e92: Bug 1593465 - Upload minidumps from PGO-run task crashes; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Thu, 21 Nov 2019 18:44:10 +0000 - rev 503274
Push 36831 by apavel@mozilla.com at Fri, 22 Nov 2019 09:15:12 +0000
Bug 1593465 - Upload minidumps from PGO-run task crashes; r=firefox-build-system-reviewers,chmanchester The minidumps are stored in the temporary profile directory used by profileserver.py. Before the temporary directory goes away, we use mozcrash & minidump_stackwalk to process any crashreports and copy them to the artifacts directory. Differential Revision: https://phabricator.services.mozilla.com/D52394
ee2997888f54ee12b6505d0af8a216076a351643: Bug 1593465 - Dump symbols during instrumented builds for crashlogs in the run task; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Thu, 21 Nov 2019 18:44:10 +0000 - rev 503273
Push 36831 by apavel@mozilla.com at Fri, 22 Nov 2019 09:15:12 +0000
Bug 1593465 - Dump symbols during instrumented builds for crashlogs in the run task; r=firefox-build-system-reviewers,chmanchester To get an accurate backtrace if the run task crashes, we need the symbols from the instrumented build. Depends on D53716 Differential Revision: https://phabricator.services.mozilla.com/D53717
307146c7af6afc6042db8c934b8df26854b66569: Bug 1593465 - Add minidump_stackwalk dependencies to generate-profile tasks; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 19 Nov 2019 21:00:16 +0000 - rev 503272
Push 36831 by apavel@mozilla.com at Fri, 22 Nov 2019 09:15:12 +0000
Bug 1593465 - Add minidump_stackwalk dependencies to generate-profile tasks; r=firefox-build-system-reviewers,chmanchester minidump_stackwalk is used to process any crash reports generated by the PGO run task. Depends on D52393 Differential Revision: https://phabricator.services.mozilla.com/D53716
55d7f113d4aebeb4c605496049608277fe65e336: Bug 1448349 - Warn about autoconf $PATH problems on win32 r=firefox-build-system-reviewers,chmanchester
Māris Fogels <mars@mozilla.com> - Thu, 21 Nov 2019 00:20:56 +0000 - rev 503124
Push 36828 by ccoroiu@mozilla.com at Thu, 21 Nov 2019 21:44:22 +0000
Bug 1448349 - Warn about autoconf $PATH problems on win32 r=firefox-build-system-reviewers,chmanchester Detect if Unix utilities on win32 are being picked up from a foreign installation of MinGW, such as the tools packaged with Git for Windows. If autoconf dies during `./mach configure` and foreign tools are found in $PATH then warn the user that their $PATH may need to change to fix the problem. Differential Revision: https://phabricator.services.mozilla.com/D52960
75ddc4b87f7920944e217144a891add6e0d42b30: Bug 1595696 - Shift artifact namespace transformation to the job class definition. r=chmanchester
Geoff Lankow <geoff@darktrojan.net> - Wed, 20 Nov 2019 19:01:26 +0000 - rev 503090
Push 36828 by ccoroiu@mozilla.com at Thu, 21 Nov 2019 21:44:22 +0000
Bug 1595696 - Shift artifact namespace transformation to the job class definition. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D52631
c15950d4e7f0c8541f27f684df46d98e70f5fd2f: Bug 1596431 - [python] Add an --ipython flag to |mach python|, r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 19 Nov 2019 20:54:40 +0000 - rev 503012
Push 36825 by cbrindusan@mozilla.com at Wed, 20 Nov 2019 21:52:17 +0000
Bug 1596431 - [python] Add an --ipython flag to |mach python|, r=firefox-build-system-reviewers,chmanchester This will install ipython into the default virtualenv if it doesn't exist. Unless --no-virtualenv is specified in which case an error will be printed. Differential Revision: https://phabricator.services.mozilla.com/D53030