searching for reviewer(botond)
8bb82b8edbf78382b5ed3f70a859acc5735f3166: Bug 1666065 - Make ZoomToFocusedInput() handle fixed-pos subframes of the RCD. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 Sep 2020 17:20:59 +0000 - rev 550368
Push 37813 by apavel@mozilla.com at Sat, 26 Sep 2020 09:25:04 +0000
Bug 1666065 - Make ZoomToFocusedInput() handle fixed-pos subframes of the RCD. r=botond I haven't been able to repro the issue so I'm not quite sure how to test this... Differential Revision: https://phabricator.services.mozilla.com/D91307
43e3a7215f9b6ff33227a2f6750db7d866be994e: Bug 1667176 - Follow-up to allow apz_test_utils to parse the new stringified rect format. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 25 Sep 2020 15:23:16 +0000 - rev 550344
Push 37812 by cbrindusan@mozilla.com at Fri, 25 Sep 2020 21:47:43 +0000
Bug 1667176 - Follow-up to allow apz_test_utils to parse the new stringified rect format. r=botond CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D91449
0a92348ed33532d65fffbfd9a8028220c2e5fc06: Bug 1659227 - Jank if the partial pre-render area is outside of the clip rect regardless of whether the entire element is also outside of the clip rect or not. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 23 Sep 2020 06:36:27 +0000 - rev 549749
Push 37806 by btara@mozilla.com at Wed, 23 Sep 2020 21:23:16 +0000
Bug 1659227 - Jank if the partial pre-render area is outside of the clip rect regardless of whether the entire element is also outside of the clip rect or not. r=botond This change regresses partial-prerender-translate-1.html which is a test case that we don't consider transforms making the entire element outside of the clip rect as jank (i.e. there is nothign to be composited). That said, it won't be a big problem since even if the jank happened on the compositor, then there is nothing to be painted on the main-thread, moreover with step timing functions most of animation restyling are going to be skipped on the main-thread. So the layout.animation.prerender.partial pref for the test case is dropped. Differential Revision: https://phabricator.services.mozilla.com/D90649
2ca45c433eb7bea61ca663776ca31adf514dfb60: Bug 1659227 - Change the partial pre-render rect unit to LayoutDeviceRect. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 23 Sep 2020 06:33:17 +0000 - rev 549748
Push 37806 by btara@mozilla.com at Wed, 23 Sep 2020 21:23:16 +0000
Bug 1659227 - Change the partial pre-render rect unit to LayoutDeviceRect. r=botond In SVG coordinates the rect size might be fractional. Differential Revision: https://phabricator.services.mozilla.com/D90648
9bcb053caba37dd041391dbeea2020f0638956df: Bug 1659227 - Handle SVG{Inner,Outer}Frame as the clip frame for partial pre-render. r=heycam,botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 23 Sep 2020 06:37:31 +0000 - rev 549747
Push 37806 by btara@mozilla.com at Wed, 23 Sep 2020 21:23:16 +0000
Bug 1659227 - Handle SVG{Inner,Outer}Frame as the clip frame for partial pre-render. r=heycam,botond In SVG frame tree SVG{Inner,Outer}Frame is normally not scrollable but clips descendants, thus nsLayoutUtils::GetNearestScrollableFrame is not able to find the clip/scroll frame. So in this change, we introduce GetNearestOverflowClipFrame which is a similar function to GetNearestScrollableFrame but it also checks whether the frame is SVGInnerFrame or SVGOuterFrame which is clipping the given nsIFrame during walking up the frame tree. In this change we also change the logic to get the clip/scroll frame and the scroll id as follows; 1) Get the nearest overflow clip frame in the same document 2) Use the root frame if there is no clip frame 3) Then try to find the scroll id if the clip frame is asynchronously scrollable so that it becomes clearer before. It's still messy though. Differential Revision: https://phabricator.services.mozilla.com/D90647
8e6ae60865c8399e8d0632733ca216a363b280bf: Bug 1666297 - Migrate some APZ event helpers to use promises natively, with the callback variants delegating to them. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 22 Sep 2020 08:32:25 +0000 - rev 549573
Push 37805 by abutkovits@mozilla.com at Wed, 23 Sep 2020 09:59:09 +0000
Bug 1666297 - Migrate some APZ event helpers to use promises natively, with the callback variants delegating to them. r=botond Differential Revision: https://phabricator.services.mozilla.com/D90898
54a6d40a17576ac5f01acf13f830ebacd80108da: Bug 1666297 - Convert helper_basic_doubletap_zoom into an async/await test. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 21 Sep 2020 22:35:29 +0000 - rev 549572
Push 37805 by abutkovits@mozilla.com at Wed, 23 Sep 2020 09:59:09 +0000
Bug 1666297 - Convert helper_basic_doubletap_zoom into an async/await test. r=botond Depends on D90896 Differential Revision: https://phabricator.services.mozilla.com/D90897
d33008351bf2792e06f4384f413b6441f05a48ec: Bug 1666297 - Convert helper_basic_pan to an async/await test. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 22 Sep 2020 08:31:31 +0000 - rev 549571
Push 37805 by abutkovits@mozilla.com at Wed, 23 Sep 2020 09:59:09 +0000
Bug 1666297 - Convert helper_basic_pan to an async/await test. r=botond Differential Revision: https://phabricator.services.mozilla.com/D90896
af03b8d3febf3178697184dbe73932c4f8647e0a: Bug 1666297 - Convert helper_basic_onetouchpinch into an async/await test. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 22 Sep 2020 07:02:35 +0000 - rev 549570
Push 37805 by abutkovits@mozilla.com at Wed, 23 Sep 2020 09:59:09 +0000
Bug 1666297 - Convert helper_basic_onetouchpinch into an async/await test. r=botond Differential Revision: https://phabricator.services.mozilla.com/D90895
8fc8685f06908a7d6e810383fdf4a7b2583e0ff2: Bug 1664626 - Delete now-unused code. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 19 Sep 2020 00:36:20 +0000 - rev 549359
Push 37795 by ccoroiu@mozilla.com at Sat, 19 Sep 2020 09:34:53 +0000
Bug 1664626 - Delete now-unused code. r=botond Differential Revision: https://phabricator.services.mozilla.com/D90724
2435b1b4a55d09e1bc035850932d609133fb2808: Bug 1664626 - Remove last usage of FrameMetrics::mScrollUpdateType. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 18 Sep 2020 20:31:49 +0000 - rev 549358
Push 37795 by ccoroiu@mozilla.com at Sat, 19 Sep 2020 09:34:53 +0000
Bug 1664626 - Remove last usage of FrameMetrics::mScrollUpdateType. r=botond The only remaining use site only cares about whether or not the transaction was a paint-skip transaction or not, so this patch adds a dedicated bool for that, which unlocks some cleanup. Depends on D90722 Differential Revision: https://phabricator.services.mozilla.com/D90723
b4ee0000fe6a96851b5832f38914f5e018ef3585: Bug 1664626 - Rearrange code for clarity. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 18 Sep 2020 20:23:44 +0000 - rev 549357
Push 37795 by ccoroiu@mozilla.com at Sat, 19 Sep 2020 09:34:53 +0000
Bug 1664626 - Rearrange code for clarity. r=botond This introduces an ignoreVisualUpdate variable to make things a bit clearer. Depends on D90721 Differential Revision: https://phabricator.services.mozilla.com/D90722
56ef52f179cbc136b9bb134b638b23f192bbe01e: Bug 1664626 - Move one of the conditions for ignoring a visual scroll update. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 18 Sep 2020 21:10:45 +0000 - rev 549356
Push 37795 by ccoroiu@mozilla.com at Sat, 19 Sep 2020 09:34:53 +0000
Bug 1664626 - Move one of the conditions for ignoring a visual scroll update. r=botond This should be equivalent but a little easier to reason about. Differential Revision: https://phabricator.services.mozilla.com/D90721
ba172dcd1f2fb5609e08f5f1e3e41f94bf97897b: Bug 1664838 - Ensure APZ updates its scroll generation even when there are no scroll position updates. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 15 Sep 2020 15:53:20 +0000 - rev 548772
Push 37787 by malexandru@mozilla.com at Wed, 16 Sep 2020 09:56:56 +0000
Bug 1664838 - Ensure APZ updates its scroll generation even when there are no scroll position updates. r=botond Differential Revision: https://phabricator.services.mozilla.com/D90279
9dd986a71b7171ce2b27b6c8c27e4b3e4c6dcdc6: Bug 1664419. Need to suppress scrollbar repaint when seting visual viewport offset. r=kats,botond
Timothy Nikkel <tnikkel@gmail.com> - Mon, 14 Sep 2020 21:38:25 +0000 - rev 548669
Push 37786 by nerli@mozilla.com at Tue, 15 Sep 2020 15:47:19 +0000
Bug 1664419. Need to suppress scrollbar repaint when seting visual viewport offset. r=kats,botond In ScrollFrameHelper::ScrollToImpl we suppress repainting scrollbars when calling UpdateScrollbarPosition if we've decided not to schedule a paint (because we are sending a pending scroll update instead). Otherwise we repaint which is what we are trying to avoid. The desktop zooming scrollbars code added a call to UpdateScrollbarPosition in SetVisualViewportOffset because the vv offset is what determines the scrollbar position, no longer the layout scroll position. This means that we can trigger a repaint via that path, and there is a test that checks that we don't. This patch moves the SetVisualViewportOffset call to just after the code that determines if we need to schedule a paint (it was just before it), and then add the AutoScrollbarRepaintSuppression class. Differential Revision: https://phabricator.services.mozilla.com/D89902
25760b432ecba7769b70f90349a931b8c727b84f: Bug 1663562. Don't call MaybeReflowForInflationScreenSizeChange with webrender when running mochitests in dom/base/test to work around webrender bug for now. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Tue, 15 Sep 2020 04:33:49 +0000 - rev 548636
Push 37786 by nerli@mozilla.com at Tue, 15 Sep 2020 15:47:19 +0000
Bug 1663562. Don't call MaybeReflowForInflationScreenSizeChange with webrender when running mochitests in dom/base/test to work around webrender bug for now. r=botond This is sad, but seems like the least bad option to enable desktop zooming scrollbars reasonable soon. Differential Revision: https://phabricator.services.mozilla.com/D90181
67cbb5422dbc6f20b55dc8b45dc8be114b828e5c: Bug 1663562. Don't call MaybeReflowForInflationScreenSizeChange with webrender when running mochitests in dom/base/test to work around webrender bug for now. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Tue, 15 Sep 2020 04:07:21 +0000 - rev 548630
Push 37786 by nerli@mozilla.com at Tue, 15 Sep 2020 15:47:19 +0000
Bug 1663562. Don't call MaybeReflowForInflationScreenSizeChange with webrender when running mochitests in dom/base/test to work around webrender bug for now. r=botond This is sad, but seems like the least bad option to enable desktop zooming scrollbars reasonable soon. Depends on D89409 Differential Revision: https://phabricator.services.mozilla.com/D90181
4ee2a5b8810119847a6a94ede50959c3ca8bf602: Bug 1660212 Disable XINPUT2 by default (revert Bug 1207700), r=botond
stransky <stransky@redhat.com> - Mon, 14 Sep 2020 05:29:58 +0000 - rev 548476
Push 37782 by ccoroiu@mozilla.com at Mon, 14 Sep 2020 16:07:13 +0000
Bug 1660212 Disable XINPUT2 by default (revert Bug 1207700), r=botond Differential Revision: https://phabricator.services.mozilla.com/D90058
afe9bfd9f1ab06f4b4acb6cdd7ce44d638258e98: Bug 1662014 - Drop mRelativeOffset and mLastSmoothScrollOrigin. r=tnikkel,botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:41 +0000 - rev 548436
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662014 - Drop mRelativeOffset and mLastSmoothScrollOrigin. r=tnikkel,botond The only place these fields are still read are for detecting if an APZ animation is pending (not yet submitted in a transaction) and we can replace that code with something slightly simpler. And then delete the unused fields. Differential Revision: https://phabricator.services.mozilla.com/D88751
c8c89974599350ada75a3fa653e2c18ed6424338: Bug 1662014 - Remove unused fields/APIs. r=botond,tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:39 +0000 - rev 548435
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662014 - Remove unused fields/APIs. r=botond,tnikkel These things are all unused now. Differential Revision: https://phabricator.services.mozilla.com/D88750
d13968a06d1f88c6fdecdfa770fdbe705b79afab: Bug 1662014 - Update some TiledContentClient code to use the ScrollPositionUpdate array. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:32 +0000 - rev 548434
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662014 - Update some TiledContentClient code to use the ScrollPositionUpdate array. r=botond This should be mostly equivalent to the old code, and unblocks deletion of some fields in FrameMetrics. Differential Revision: https://phabricator.services.mozilla.com/D88749
67d2d087ca1c9b4090594c90ed2c2deb23b66227: Bug 1662014 - Stop using the mSmoothScrollOffset field. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:30 +0000 - rev 548433
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662014 - Stop using the mSmoothScrollOffset field. r=botond This is the only place that uses the mSmoothScrollOffset any more, and it doesn't really need to as a local variable suffices. Differential Revision: https://phabricator.services.mozilla.com/D88748
c5e33b0506d49d3287ca460c05330f4382d3b807: Bug 1662013 - Move some function bodies into .cpp files. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:20 +0000 - rev 548431
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662013 - Move some function bodies into .cpp files. r=botond Differential Revision: https://phabricator.services.mozilla.com/D88746
b78646d59e32d680001a8d85322b5a16b514d190: Bug 1662013 - Update NotifyLayersUpdated to use the ScrollPositionUpdates. r=tnikkel,botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:10 +0000 - rev 548429
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662013 - Update NotifyLayersUpdated to use the ScrollPositionUpdates. r=tnikkel,botond This rewrites a big chunk of the NotifyLayersUpdated code (most of the code that deals with incoming scroll requests from the main-thread) to instead iterate through the list of ScrollPositionUpdates on the metadata and apply them in order. A bunch of the ApplyXXXUpdateFrom functions on FrameMetrics have their innards deduplicated and boil down to a single line, which is then inlined, so those functions get removed entirely. Note that this rewrite doesn't yet handle all the possible types of ScrollPositionUpdate instances, just the ones that the old code handled. In the future this support will be fleshed out with tests to exercise the relevant codepaths. There is also a change to nsGfxScrollFrame which slightly modifies the semantics of mApzScrollPos to handle the case where multiple relative scrolls happen in a single transaction. As the implementation now requires multiple relative ScrollPositionUpdates rather than a single "unified" relative scroll in the FrameMetrics, we need to update mApzScrollPos for each relative ScrollPositionUpdate we generate. Differential Revision: https://phabricator.services.mozilla.com/D88744
5682d31ad83539c7a0d06f20265acf0a701a6828: Bug 1662013 - Replace ScrollUpdateInfo with ScrollPositionUpdate. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:02 +0000 - rev 548428
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662013 - Replace ScrollUpdateInfo with ScrollPositionUpdate. r=botond The existing ScrollUpdateInfo that is used to store a "paint-skipped scroll" for empty transactions is very similar to the new ScrollPositionUpdate class, so we can delete the former and use the latter instead. The important part of this change is that when applying the pending info to a FrameMetrics, we now also append the ScrollUpdateInfo to the mScrollUpdates list on the ScrollMetadata. This aligns the code with the previous few patches, where we duplicate the scroll information in both the regular FrameMetrics fields and the ScrollMetadata::mScrollUpdates array. Note that the existing code may have a defect when multiple paint-skip scrolls occur in a single transaction; only the newest one is kept. In the case where the last paint-skip is an absolute scroll, this is fine, but a relative scroll may end up clobbering a previous absolute scroll. This patch explicitly detects the scenario with multiple paint-skip scrolls and bails out to a full paint transaction. As a followup it should be possible to relax this restriction by storing an array of pending ScrollPositionUpdate instances. Differential Revision: https://phabricator.services.mozilla.com/D88743
17318ecbf2897533077b0ab7deddee9096d4d4cf: Bug 1662013 - Update gtests to also attach ScrollPositionUpdates to metadata. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:05:55 +0000 - rev 548427
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662013 - Update gtests to also attach ScrollPositionUpdates to metadata. r=botond Every time the scroll generation is incremented, we now also attach the equivalent ScrollPositionUpdate instances to the metadata. Differential Revision: https://phabricator.services.mozilla.com/D88742
98fb30c331e23e9f2435229f57a62e918e407da0: Bug 1662013 - Introduce a ScrollPositionUpdate and plumb it in. r=tnikkel,botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:05:53 +0000 - rev 548426
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662013 - Introduce a ScrollPositionUpdate and plumb it in. r=tnikkel,botond This adds a ScrollPositionUpdate class. Code in nsGfxScrollFrame creates instances of these classes every time the scroll generation is incremented, and saves them to an array. The array is sent in the scroll metadata to the compositor as part of a paint transaction. Currently this data is not used at all on the APZ side, and exists alongside (independently of) the existing scroll fields, so this patch should not have any functional effects. Differential Revision: https://phabricator.services.mozilla.com/D88741
872db70a11229fdf8a3ed8c6b750f0be14b99251: Bug 1663537. Use scrollbar-width: none on some reftests that are not trying to test scrollbars. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Sat, 12 Sep 2020 06:59:53 +0000 - rev 548422
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1663537. Use scrollbar-width: none on some reftests that are not trying to test scrollbars. r=botond These tests only failed on android, probably because the visual viewport size is different so we get a different result from the scrollbar calculation. These tests seem to have an inconsistent mix of overflow: hidden and scrollbar-width: none. The desktop zooming scrollbars sometimes create scrollbars for overflow hidden now, so overflow hidden isn't enough, we need scrollbar-width: none. layout/reftests/transform/compound-1-fail.html is the only file modified here that doesn't have overflow hidden or scrollbar-width: none already. Looking at the test it does not seem to be wanting to be anti-ref because of scrollbars (the transformed item looks different), so this seems to be an improvement (ie we won't pass because only the scrollbar differed). Differential Revision: https://phabricator.services.mozilla.com/D90008
5b92fb2d3bc54cc58ab538320bbe119a0a5f5496: Bug 1664446. Disable zoom to focus input for mochitests in editor/libeditor/tests/. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Fri, 11 Sep 2020 23:30:26 +0000 - rev 548413
Push 37778 by ccoroiu@mozilla.com at Sat, 12 Sep 2020 09:26:23 +0000
Bug 1664446. Disable zoom to focus input for mochitests in editor/libeditor/tests/. r=botond I think the scrolls that zoom to focus input causes are giving us scroll events that we don't expect. I don't think there is a better way around this. Differential Revision: https://phabricator.services.mozilla.com/D89993
dfbb0aa0971873c6410eb6c212eeaf1f6ad10901: Bug 1664446. Increase fuzz in editor/libeditor/tests/test_selection_move_commands.html slightly. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Sat, 12 Sep 2020 01:24:23 +0000 - rev 548412
Push 37778 by ccoroiu@mozilla.com at Sat, 12 Sep 2020 09:26:23 +0000
Bug 1664446. Increase fuzz in editor/libeditor/tests/test_selection_move_commands.html slightly. r=botond Disabling zoom to focused input seems to have slightly changed how much fuzz we get when comparing scroll position. Differential Revision: https://phabricator.services.mozilla.com/D90005
27f5e77cd9bbba7a402c358808b0f7baa0db4588: Bug 1648491 - Add a test. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 09 Sep 2020 20:38:02 +0000 - rev 548037
Push 37770 by apavel@mozilla.com at Thu, 10 Sep 2020 04:03:55 +0000
Bug 1648491 - Add a test. r=botond Depends on D89303 Differential Revision: https://phabricator.services.mozilla.com/D89304
ca7ab0e42f54fc527ed266c155a2a3724da17490: Bug 1648491 - Have the main thread double-check APZ's consumable state. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 09 Sep 2020 19:57:36 +0000 - rev 548036
Push 37770 by apavel@mozilla.com at Thu, 10 Sep 2020 04:03:55 +0000
Bug 1648491 - Have the main thread double-check APZ's consumable state. r=botond APZ can sometimes indicate that it will be consuming touch events, even though the touch-action properties prohibit it. This can happen if, for example, APZ is waiting on the main-thread for accurate touch-action information. In such cases, the main thread has enough information to filter out these false positives. This patch makes it do that, by plumbing the allowed touch behaviors into the APZEventState code that triggers the pointercancel event. Differential Revision: https://phabricator.services.mozilla.com/D89303
0e6484c306af81dffef0987332ff114ec6263b00: Bug 1661219 [Linux/KDE] Disable XINPUT2 by default on KDE, r=botond
stransky <stransky@redhat.com> - Fri, 04 Sep 2020 16:08:53 +0000 - rev 547685
Push 37756 by apavel@mozilla.com at Fri, 04 Sep 2020 21:31:27 +0000
Bug 1661219 [Linux/KDE] Disable XINPUT2 by default on KDE, r=botond Differential Revision: https://phabricator.services.mozilla.com/D89194
4380b619b4b0b53ec2a8f0131436a2f475679f3c: Bug 1661897 - Add a test. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 01 Sep 2020 18:18:09 +0000 - rev 547304
Push 37748 by apavel@mozilla.com at Wed, 02 Sep 2020 03:31:14 +0000
Bug 1661897 - Add a test. r=botond The new promiseMouseDragEvent function is an async promise-returning copy of the code in dragVerticalScrollbar. Eventually we should just make all this code using async/promise but that's for another day. Differential Revision: https://phabricator.services.mozilla.com/D88894
3e764a5d3f97ce707c4d69c81ee211b4fc20dced: Bug 1661897 - Acknowledge pending visual scroll updates for any RSF. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 01 Sep 2020 18:18:01 +0000 - rev 547303
Push 37748 by apavel@mozilla.com at Wed, 02 Sep 2020 03:31:14 +0000
Bug 1661897 - Acknowledge pending visual scroll updates for any RSF. r=botond We set pending visual scroll updates even for RSFs that are on subdocuments, so we should ensure they get acknowledged and cleared on paints. Otherwise the pending visual scroll update can get "stuck" and it affects things that depend on it, such as the drag-selection code. Differential Revision: https://phabricator.services.mozilla.com/D88893
34ee0403ab1e8dbf3b7cc943a867113f0cefc69e: Bug 1661897 - Add a test. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 01 Sep 2020 00:05:31 +0000 - rev 547120
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1661897 - Add a test. r=botond The new promiseMouseDragEvent function is an async promise-returning copy of the code in dragVerticalScrollbar. Eventually we should just make all this code using async/promise but that's for another day. Differential Revision: https://phabricator.services.mozilla.com/D88894
f83db4b41bf63803df556db29598734457c798ad: Bug 1661897 - Acknowledge pending visual scroll updates for any RSF. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 31 Aug 2020 20:34:34 +0000 - rev 547119
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1661897 - Acknowledge pending visual scroll updates for any RSF. r=botond We set pending visual scroll updates even for RSFs that are on subdocuments, so we should ensure they get acknowledged and cleared on paints. Otherwise the pending visual scroll update can get "stuck" and it affects things that depend on it, such as the drag-selection code. Differential Revision: https://phabricator.services.mozilla.com/D88893
c449b3b295fcb3cc58baf0bd4213955a5f683493: Bug 1661492 - Auto-advance migration in the absence of further action. r=jaws,botond
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 28 Aug 2020 18:01:33 +0000 - rev 546867
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1661492 - Auto-advance migration in the absence of further action. r=jaws,botond This advances the migration by 25% each release, starting in release 83 and completing in 86. The migration code can be removed in the 86 nightly cycle (or anytime after that). Differential Revision: https://phabricator.services.mozilla.com/D88453
01a6b233e68e8ce8c024c69174b8352e59167f5c: Bug 1652851 - Add some gtests to exercise the fixes. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 27 Aug 2020 01:32:12 +0000 - rev 546386
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1652851 - Add some gtests to exercise the fixes. r=botond Differential Revision: https://phabricator.services.mozilla.com/D88011
faee29a2448b3ce50a23bae2c9ca194511dc6efd: Bug 1652851 - Force touch blocks in slop to be processed after the long-tap delay. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 27 Aug 2020 01:30:03 +0000 - rev 546385
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1652851 - Force touch blocks in slop to be processed after the long-tap delay. r=botond If the content response timeout is longer than the long-tap delay (which is true given the current default pref values), and a touch block waits for the entire content response timeout period, then the long-tap gesture gets delayed by the difference in the timeouts. This can happen if the input block remains in the slop state (and therefore never dispatches a touchmove to content, thereby preventing the content from producing a content response). This patch catches this scenario and installs a long-tap timeout in the InputQueue to force the input block along. Differential Revision: https://phabricator.services.mozilla.com/D88010
abba926fb2a5a401b74c0d43bdb31d54b4f815f3: Bug 1652851 - Shorten GestureEventListener delayed tasks by the content response wait. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 27 Aug 2020 01:29:59 +0000 - rev 546384
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1652851 - Shorten GestureEventListener delayed tasks by the content response wait. r=botond Touch inputs that go to the GestureEventListener often have to wait in the InputQueue for some time as well, until the content response arrives. However, that delay is not accounted for in the GestureEventListener delays. This can result in the gesture being artificially delayed from a user's perspective. This patch computes the amount of time the input event already waited in the input queue, and shortens the delays used in the GestureEventListener accordingly. Differential Revision: https://phabricator.services.mozilla.com/D88009
20d40fcc3f751c7a7517fb691dc4e611872f2d76: Bug 1660089 - Use the nearest scrollable frame as the clip frame if the scrollable frame is overflow:hidden. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 27 Aug 2020 00:09:59 +0000 - rev 546377
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1660089 - Use the nearest scrollable frame as the clip frame if the scrollable frame is overflow:hidden. r=botond Without this change, the transition in the reftest in this commit has never been composited because it's misrecognized as __jank__. (Note that a tricky part to understand the jank is that we expand the pre-render region based on the transformed frame size [1], in this case it's 400px width, so that the expanded area will be smaller than the size based on 800px.) [1] https://searchfox.org/mozilla-central/rev/73a14f1b367948faa571ed2fe5d7eb29460787c1/layout/base/nsLayoutUtils.cpp#10043,10045 Differential Revision: https://phabricator.services.mozilla.com/D88199
ff12ca4b41aabafc791fcf3b3d25a9831066a43b: Bug 1657627 - Add a test. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 26 Aug 2020 19:41:36 +0000 - rev 546362
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1657627 - Add a test. r=botond Differential Revision: https://phabricator.services.mozilla.com/D88037
dcfb243788f7dd1b23680fc099a0e52f663dd27a: Bug 1660933 - Respect wheel migration value. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 26 Aug 2020 20:31:20 +0000 - rev 546358
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1660933 - Respect wheel migration value. r=botond This introduces a linear interpolation when computing the wheel animation durations, based on the migration percentage of the user. Initially the migration percentage defaults to 100 (fully migrated) for new users and for existing users who have customized these prefs. The migration percentage defaults to zero for existing users without customizations, so they will still get the old default values of min=200,max=400. Over time we can adjust the migration pref clamping to move that percentage up and migrate those users to get the new values. Differential Revision: https://phabricator.services.mozilla.com/D88163
c68f4dba15c4d57986a427702f4f8167e025cc0e: Bug 1660808 - Clear the mApzcMap when clearing the APZCTM. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 26 Aug 2020 19:05:17 +0000 - rev 546328
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1660808 - Clear the mApzcMap when clearing the APZCTM. r=botond Differential Revision: https://phabricator.services.mozilla.com/D88047
90c5fe0c7b06422ad1416429ecf7877c909ff596: Bug 1661301 - Remove obsolete comment. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 26 Aug 2020 19:01:19 +0000 - rev 546327
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1661301 - Remove obsolete comment. r=botond This comment has been obsolete since https://hg.mozilla.org/mozilla-central/rev/e122d0043843 when APZ started handling wheel events even with the pref enabled. Depends on D88307 Differential Revision: https://phabricator.services.mozilla.com/D88308
17364d304206696efadcd8a1421ae594564609de: Bug 1661301 - Move comment to go with the code it refers to. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 26 Aug 2020 19:01:15 +0000 - rev 546326
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1661301 - Move comment to go with the code it refers to. r=botond Differential Revision: https://phabricator.services.mozilla.com/D88307
5e062811dd8f97f631b08beba3f6dcde177a8b48: Bug 1661301 - Remove bits leftover from bug 1259301. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 26 Aug 2020 19:01:09 +0000 - rev 546325
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1661301 - Remove bits leftover from bug 1259301. r=botond Depends on D88305 Differential Revision: https://phabricator.services.mozilla.com/D88306
b50a82b454cf6395ea67244699babd2485ac4198: Bug 1661301 - Remove bits leftover from bug 1248078. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 26 Aug 2020 19:00:59 +0000 - rev 546324
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1661301 - Remove bits leftover from bug 1248078. r=botond Differential Revision: https://phabricator.services.mozilla.com/D88305
29e16ac5d3deeb0029370cf3e881aa8e78f5387d: Bug 1633322 - Consider content handling for `onTouchEventForResult` r=geckoview-reviewers,botond,agi,esawin
James Willcox <snorp@snorp.net> - Thu, 20 Aug 2020 20:40:51 +0000 - rev 545574
Push 37716 by apavel@mozilla.com at Fri, 21 Aug 2020 03:37:46 +0000
Bug 1633322 - Consider content handling for `onTouchEventForResult` r=geckoview-reviewers,botond,agi,esawin Differential Revision: https://phabricator.services.mozilla.com/D86384