searching for reviewer(botond)
0b0a2b12bd05: Bug 1528052 - Suppress resize events until the initial paint has finished on mobile. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 04:14:55 +0000 - rev 470440
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1528052 - Suppress resize events until the initial paint has finished on mobile. r=botond Differential Revision: https://phabricator.services.mozilla.com/D28172
6f0320a85555: Bug 1546038 - Include scroll-margin areas into snap area. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 03:58:57 +0000 - rev 470436
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1546038 - Include scroll-margin areas into snap area. r=botond This patch also renames `targetRect` to `snapArea` to represent it more accurately. Differential Revision: https://phabricator.services.mozilla.com/D28307
52410914b543: Bug 1544198 - Use the proper frame to get scroll-snap-type value on the root element. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:16:02 +0000 - rev 470431
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Use the proper frame to get scroll-snap-type value on the root element. r=botond Now scroll-snap-type property on body element doesn't affect scroll position so that scrollTo-scrollBy-snaps.html is needed to be modified to specify scroll-snap-type on html. Differential Revision: https://phabricator.services.mozilla.com/D27987
5b413410d2c5: Bug 1544198 - Split ScrolLFrameHelper::ComputeScrollSnapInto into two functions. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:12:38 +0000 - rev 470430
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Split ScrolLFrameHelper::ComputeScrollSnapInto into two functions. r=botond The one is for the scroll snap module v1 implementation, the other is for the old scroll snap implementation. Now both functions have the same pieces of code to get scroll-snap-type values, but for v1 implemention in the next commit we will use GetFrameForScrollSnap() to get the value instead. Differential Revision: https://phabricator.services.mozilla.com/D27986
530a3f39ecbd: Bug 1544198 - Factor out the function to get the frame for scroll-snap-type and scroll-padding. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:12:24 +0000 - rev 470429
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Factor out the function to get the frame for scroll-snap-type and scroll-padding. r=botond Differential Revision: https://phabricator.services.mozilla.com/D27985
bd2261f74658: Bug 1544136 - Ship the scroll snap snap on betas and releases. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 22 Apr 2019 22:38:18 +0000 - rev 470419
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544136 - Ship the scroll snap snap on betas and releases. r=botond Differential Revision: https://phabricator.services.mozilla.com/D27989
325527265543: Bug 1544325 - Clamp the app units' scroll position to the current position if the given scroll position is the same as the current scroll position in CSS pixels. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 17 Apr 2019 16:41:11 +0000 - rev 469952
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1544325 - Clamp the app units' scroll position to the current position if the given scroll position is the same as the current scroll position in CSS pixels. r=botond There are conditions that the given scroll position in app units differs from the current position in app units even if those values are the same in CSS pixels. Setting Element.scrollTop with Element.scrollTop in a callback of scroll event is one of such cases. The change here looks messy, but I am totally unsure that we can clamp the values before initializing the range for the DISABLE_SNAP case, so I'd like to preserve the behavior there. Once we ship the new scroll snap, we can drop the DISABLE_SNAP case there so that it could be less messy at the time. Differential Revision: https://phabricator.services.mozilla.com/D27638
2df4f2b12f9a: Bug 1535140 - Slow down a bit if injecting touch inputs too fast for Windows to digest. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 17 Apr 2019 16:53:29 +0000 - rev 469916
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1535140 - Slow down a bit if injecting touch inputs too fast for Windows to digest. r=botond Differential Revision: https://phabricator.services.mozilla.com/D27598
a7c8897aea6f: Bug 1544060 - Bail out from ScrollFrameHelper::GetScrollPadding in the case where no corresponding frame exists. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 15 Apr 2019 21:15:53 +0000 - rev 469572
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1544060 - Bail out from ScrollFrameHelper::GetScrollPadding in the case where no corresponding frame exists. r=botond Differential Revision: https://phabricator.services.mozilla.com/D27423
9bf188c86f9c: Bug 1544060 - Use the root element's primary frame to get scroll-padding value. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 15 Apr 2019 21:15:58 +0000 - rev 469571
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1544060 - Use the root element's primary frame to get scroll-padding value. r=botond Now the spec cleary says that we don't need to propagate body's scroll-padding value to the document viewport since https://github.com/w3c/csswg-drafts/issues/3740, so we don't need to care about GetViewportScrollStylesOverrideElement() at all. This change fixes the crash test case in this commit, but it's not sufficient. In the next patch, we will fix another crash case. Differential Revision: https://phabricator.services.mozilla.com/D27422
7d6cd4e20705: Bug 1543482 - Add the irregular-area flag for frames with masks and clip paths. r=mattwoodrow,botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 15 Apr 2019 16:02:02 +0000 - rev 469520
Push 35873 by ccoroiu@mozilla.com at Mon, 15 Apr 2019 21:36:26 +0000
Bug 1543482 - Add the irregular-area flag for frames with masks and clip paths. r=mattwoodrow,botond This will force APZ to do a main-thread hit-test for the cases where the shapes are too complex to easily send to the compositor. Differential Revision: https://phabricator.services.mozilla.com/D27455
a5fe792348ed: Bug 1542019 - Split the dispatch-to-content flag into three. r=botond,hsivonen
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 11 Apr 2019 13:31:53 +0000 - rev 469001
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1542019 - Split the dispatch-to-content flag into three. r=botond,hsivonen This patch extracts two additional CompositorHitTestInfo flags from the eDispatchToContent flag; eApzAwareListeners for elements that have APZ-aware listeners, and eInactiveScrollframe for inactive scrollframe or unlayerized scrollthumbs. The eDispatchToContent is then renamed to eIrregularArea to reflect the fact that it is used for irregular-shaped areas that require main-thread hit-testing. Additionally, it is important to note that when using the non-WebRender codepath, all three of these flags still end up gettings squashed into the "dispatch to content" region on the EventRegions; when APZ reconstructs a CompositorHitTestInfo it will turn anything in this region back into an eIrregularArea. So this is a lossy round-trip conversion for the non-WebRender case. However it should still result in correct behaviour because the semantics of eIrregularArea result in APZ relying on the main-thread to do hit-testing and so any APZ-aware listeners and inactive scrollframes are also handled by the main-thread. Differential Revision: https://phabricator.services.mozilla.com/D26440
c5898e18dedf: Bug 1535232 - Take account the scroll-snap-margin and scroll-snap-padding into the position where we scroll to on Element.focus() call. r=masayuki,botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:22:38 +0000 - rev 468954
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1535232 - Take account the scroll-snap-margin and scroll-snap-padding into the position where we scroll to on Element.focus() call. r=masayuki,botond We also take account those values in the case of `Find in page`. The corresponding web platform tests will be coming from this PR. https://github.com/web-platform-tests/wpt/pull/8575 Though some of them will not be passed, the failure reason is not related to this change, I will take a look when the PR gets merged into mozilla-central. Differential Revision: https://phabricator.services.mozilla.com/D25915
fb721c0cbc98: Bug 1534070 - Factor scroll-margin into the position calculation where nsIPresShell::ScrollFrameRectIntoView() is going to scroll. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:22:31 +0000 - rev 468953
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1534070 - Factor scroll-margin into the position calculation where nsIPresShell::ScrollFrameRectIntoView() is going to scroll. r=botond Depends on D23084 Differential Revision: https://phabricator.services.mozilla.com/D23085
b723c3a2cae2: Bug 1534070 - Factor scroll-padding into the position calculation where nsIPresShell::ScrollContentIntoView() is going to scroll if necessary. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:22:14 +0000 - rev 468952
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1534070 - Factor scroll-padding into the position calculation where nsIPresShell::ScrollContentIntoView() is going to scroll if necessary. r=botond In the case where scroll-snap-type is specified for the scroll container, the scroll-padding is also factored into in ScrollFrameHelper::ComputeScrollSnapInfo which is called via ScrollFrameHelper::ScrollToWithOrigin. It doesn't double the scroll-padding value, but it's actually redundant, we should avoid it. We could separate the functionality of ScrollToWithOrigin, one is to scroll to a given element, the other is to scroll to a given position. The former will be used for Element.scrollIntoElement and relevant stuff, the latter will be used for Element.scrollTo and relevant stuff. That's being said, as of now, we have still the old scroll snap implementation, so the separation will introduce complexity, the separation should be done once after the old implementation removed. There are 9 call sites of nsIPresShell::ScrollContentIntoView: nsIPresShell::GoToAnchor nsIPresShell::ScrollToAnchor Element::ScrollIntoView We definitely needs scroll-padding and scroll-margin for these functions. nsCoreUtils::ScrollTo This is used for Accesible::ScrollTo which scrolls to a given accesible node, probably we should behave as what Element::ScrollIntoView does. Accessible::DispatchClickEvent Similar to the above, similated various mouse events on a given target node. PresShell::EventHandler::PrepareToUseCaretPosition PresShell::EventHandler::GetCurrentItemAndPositionForElement Both are for context menu, we shouldn't consider scroll-padding and scroll-margin. nsFormFillController::SetPopupOpen This is used for autocompletion popup, we shouldn't consider scroll-padding and scroll-margin. nsFocusManager::ScrollIntoView This is bit unfortunate, we should use scroll-padding and scroll-margin depending on call site of this function. Bug 1535232 is for this case. cssom-view/scrollIntoView-scrollPadding.html which has some tests that is actually testing scroll-padding with scrollIntoView passes with this change. The reftest in this change is a test case that the browser navigates to an element with specifying the anchor to the element. Differential Revision: https://phabricator.services.mozilla.com/D23084
2b8493e37c62: Bug 1531228 - Enable the new scroll snap and disable the old scroll snap on nightly. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:22:01 +0000 - rev 468951
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1531228 - Enable the new scroll snap and disable the old scroll snap on nightly. r=botond Differential Revision: https://phabricator.services.mozilla.com/D22804
b500d17a3bf5: Bug 1373832 - Deflate the snapport by scroll-padding and adjust the snap positions by the padding value. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:21:48 +0000 - rev 468950
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373832 - Deflate the snapport by scroll-padding and adjust the snap positions by the padding value. r=botond https://drafts.csswg.org/css-scroll-snap-1/#scroll-padding Differential Revision: https://phabricator.services.mozilla.com/D21635
acbcbc1dc6e0: Bug 1373833 - Factor scroll-margin values into scroll snap position calculation. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:21:36 +0000 - rev 468949
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373833 - Factor scroll-margin values into scroll snap position calculation. r=botond scroll-margin is for each elements in the scroll container and snap positions are shifted by the value. https://drafts.csswg.org/css-scroll-snap-1/#scroll-margin https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-area Differential Revision: https://phabricator.services.mozilla.com/D21634
11ce2cf9d66c: Bug 1373835 - Cull out elements which will be invisible in the snapport for programatic scrolls. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:21:23 +0000 - rev 468948
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373835 - Cull out elements which will be invisible in the snapport for programatic scrolls. r=botond As for scrolling on the compositor we don't cull out them since we don't know the final snapport rect at the time when we send the information about snapping to the compositor. And we will handle it for APZ in bug 1531589. https://drafts.csswg.org/css-scroll-snap-1/#snap-scope Depends on D21632 Differential Revision: https://phabricator.services.mozilla.com/D21633
335307e3cca3: Bug 1373835 - Make positions in the range that the element covers the snapport valid snap positions. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:21:11 +0000 - rev 468947
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373835 - Make positions in the range that the element covers the snapport valid snap positions. r=botond https://drafts.csswg.org/css-scroll-snap-1/#snap-overflow Depends on D21631 Differential Revision: https://phabricator.services.mozilla.com/D21632
29466eb6ee25: Bug 1373835 - Add a test case for unreachable snap positions. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:20:58 +0000 - rev 468946
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373835 - Add a test case for unreachable snap positions. r=botond The snap alignment position of the target element is the top left of the target and the position is located out of scroll port (top: -100px, left: -100px). Even so we try to snap a position as much as possible. From the spec [1]; If a snap position is unreachable as specified, such that aligning to it would require scrolling the scroll container’s viewport past the edge of its scrollable overflow region, the used snap position for this snap area is the position resulting from scrolling as much as possible in each relevant axis toward the desired snap position. [1] https://drafts.csswg.org/css-scroll-snap-1/#unreachabLe Depends on D21630 Differential Revision: https://phabricator.services.mozilla.com/D21631
d4682a804eba: Bug 1373835 - Add a test case that the snap target element is transformed. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:22:21 +0000 - rev 468945
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373835 - Add a test case that the snap target element is transformed. r=botond Depends on D21629 Differential Revision: https://phabricator.services.mozilla.com/D21630
bd7f3fa1efbd: Bug 1373835 - Implement scroll-snap-align. r=botond,jfkthame
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:20:36 +0000 - rev 468944
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373835 - Implement scroll-snap-align. r=botond,jfkthame https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-align The main logic here is basically same as the old scroll snap implementation, just iterating over all descendant elements in the scroll container and collect snap positions. The differences are; 1) the snap positions are specified based on descendant elements instead of points 2) the snap positions are able to be specified by `block` or `inline` keywords so that we also need to care the element flow. more test cases for this are coming in the next commit 3) the target rect is calculated by nsLayoutUtils::TransformFrameRectToAncestor which means transform is already taken account into it (we have a bug for the old scroll snap, it's bug 1218745) some of web platform tests will be added in a subsequent commit Some of test cases in overflowing-snap-areas.html that accidentally have passed start failing with this change, all of them will be passed with subsequent changes in these commit series. Depends on D21627 Differential Revision: https://phabricator.services.mozilla.com/D21628
15f5d6a74247: Bug 1373835 - Make ComputeScrollSnapInfo a private method of ScrollFrameHelper. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:20:24 +0000 - rev 468943
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373835 - Make ComputeScrollSnapInfo a private method of ScrollFrameHelper. r=botond Depends on D21626 Differential Revision: https://phabricator.services.mozilla.com/D21627
2e7cebd9ed56: Bug 1373835 - Enable scroll snap for Element.scrollIntoView. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:20:11 +0000 - rev 468942
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373835 - Enable scroll snap for Element.scrollIntoView. r=botond Depends on D21625 Differential Revision: https://phabricator.services.mozilla.com/D21626
ab5811341092: Bug 1373835 - Enable scroll snap for programatic scrolls. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:20:04 +0000 - rev 468941
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373835 - Enable scroll snap for programatic scrolls. r=botond From the spec [1]; Using the scroll-snap-type property on the relevant scroll container, the author can request a particular bias for the scrollport to land on a snap position after scrolling operations (including programmatic scrolls such as the scrollTo() method). The target here are functions exposed in web contents other than Element.scrollIntoView which will be changed in the next commit. [1] https://drafts.csswg.org/css-scroll-snap-1/#overview Depends on D21624 Differential Revision: https://phabricator.services.mozilla.com/D21625
9d201f2c3279: Bug 1373835 - Use scrollBy instead of scrollTo in a test in scrollTo-scrollBy-snaps.html. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:19:51 +0000 - rev 468940
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373835 - Use scrollBy instead of scrollTo in a test in scrollTo-scrollBy-snaps.html. r=botond Given the test description is mentioning scrollBy, scrollBy should be used there. Depends on D21623 Differential Revision: https://phabricator.services.mozilla.com/D21624
a85948af4c36: Bug 1373835 - Make the largest element wider. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:19:39 +0000 - rev 468939
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1373835 - Make the largest element wider. r=botond The right top element is positioned at left:1000px and its width is 600px and the width of the largest element in the content is 2100px. So if the browser window width (precisely documentElement clientWidth) is greater than 1100px, the right top element is not suitable for scroll-snap-align:start, thus some test cases fail. Differential Revision: https://phabricator.services.mozilla.com/D21623
7d29466fd0c1: Bug 1541644 - Allow immediate handoff if APZC's displacement is not a user visible amount. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 10 Apr 2019 20:48:29 +0000 - rev 468881
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1541644 - Allow immediate handoff if APZC's displacement is not a user visible amount. r=botond Differential Revision: https://phabricator.services.mozilla.com/D26925
581ae96f555e: Bug 1541644 - Add some more logging statements. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 10 Apr 2019 20:47:14 +0000 - rev 468880
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1541644 - Add some more logging statements. r=botond Differential Revision: https://phabricator.services.mozilla.com/D26924
1ef7a84a9533: Bug 1543224 - Don't fling-accelerate a zero velocity to a nonzero velocity. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 10 Apr 2019 18:59:07 +0000 - rev 468847
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1543224 - Don't fling-accelerate a zero velocity to a nonzero velocity. r=botond Differential Revision: https://phabricator.services.mozilla.com/D26799
4d0388ce7f1a: Bug 1537958 - Discard and reschedule visual viewport events if the prescontext changes. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 10 Apr 2019 18:36:42 +0000 - rev 468846
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1537958 - Discard and reschedule visual viewport events if the prescontext changes. r=botond It seems that in some scenarios, the lifetime of the visual viewport object exceeds the lifetime of the prescontext. In particular, the prescontext produced by GetPresContext() can be torn down and a new one installed. This can leave the visual viewport in a wedged state where it has scheduled events to be dispatched, but they will never actually be dispatched, and then subsequent events will not get scheduled. This patch checks to see if the prescontext has changed, and if so, discards the old events and reschedules new ones. Differential Revision: https://phabricator.services.mozilla.com/D26578
9f1bd0017205: Bug 1526928 - Check for TabParent destruction before trying to send a message on it. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 10 Apr 2019 18:40:42 +0000 - rev 468844
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1526928 - Check for TabParent destruction before trying to send a message on it. r=botond Differential Revision: https://phabricator.services.mozilla.com/D26830
4884adc18491: Bug 1526928 - Don't trigger the testDriver continuation on a mousemove we didn't synthesize. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 10 Apr 2019 18:41:12 +0000 - rev 468843
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1526928 - Don't trigger the testDriver continuation on a mousemove we didn't synthesize. r=botond We seem to get a spurious mousemove event generated after the mousedown from somewhere in Gecko. This causes us to trigger the testDriver continuation an extra time right at the start of the drag, which causes the test to end before it's supposed to. This patch makes it so we drop the spurious mousemove. Differential Revision: https://phabricator.services.mozilla.com/D26829
e845b9f92654: Bug 1526928 - Override window.dump to report the subtest; also add some extra dumps. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 10 Apr 2019 18:40:18 +0000 - rev 468842
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1526928 - Override window.dump to report the subtest; also add some extra dumps. r=botond Differential Revision: https://phabricator.services.mozilla.com/D26828
f7514ce0ff13: Bug 1542800 - Clear out any leftover updater tasks after the ClearTree task is run. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 08 Apr 2019 20:04:14 +0000 - rev 468418
Push 35837 by rmaries@mozilla.com at Tue, 09 Apr 2019 03:43:40 +0000
Bug 1542800 - Clear out any leftover updater tasks after the ClearTree task is run. r=botond This patch ensures that once the ClearTree task is run on the updater thread, we throw away any other remaining tasks in the queue, as they will never get run. (Note that the ClearTree task removes the APZUpdater instance from the global map, and so it becomes "unfindable", meaning the ProcessQueue will never run again on that instance). Differential Revision: https://phabricator.services.mozilla.com/D26541
75d1ab7e1346: Bug 1531531 - Update GeckoView API implementation to use scrollToVisual() in place of window.scrollTo() r=geckoview-reviewers,botond,esawin,droeh
Randall E. Barker <rbarker@mozilla.com> - Fri, 05 Apr 2019 20:09:55 +0000 - rev 468233
Push 35824 by apavel@mozilla.com at Sat, 06 Apr 2019 10:57:50 +0000
Bug 1531531 - Update GeckoView API implementation to use scrollToVisual() in place of window.scrollTo() r=geckoview-reviewers,botond,esawin,droeh Differential Revision: https://phabricator.services.mozilla.com/D25491
9f64986f5b36: Bug 1541223 - Print the layers id as a hex value in apz.printtree output. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 02 Apr 2019 21:18:56 +0000 - rev 467705
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1541223 - Print the layers id as a hex value in apz.printtree output. r=botond Differential Revision: https://phabricator.services.mozilla.com/D25860
e71106760932: Bug 1539684 - Don't let scrollPercent become NaN if maxThumbPos is zero. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 29 Mar 2019 15:39:35 +0000 - rev 466782
Push 35780 by opoprus@mozilla.com at Fri, 29 Mar 2019 21:53:01 +0000
Bug 1539684 - Don't let scrollPercent become NaN if maxThumbPos is zero. r=botond Differential Revision: https://phabricator.services.mozilla.com/D25405
3054d8c5618f: Bug 1500314 Part 2: Update test expectations. r=botond
Brad Werth <bwerth@mozilla.com> - Wed, 27 Mar 2019 23:44:09 +0000 - rev 466594
Push 35773 by ncsoregi@mozilla.com at Fri, 29 Mar 2019 04:11:36 +0000
Bug 1500314 Part 2: Update test expectations. r=botond Differential Revision: https://phabricator.services.mozilla.com/D24268
55b2341d41d3: Bug 1500314 Part 1: Only apply mobile viewport stretching for documents with no meta viewport tag. r=botond
Brad Werth <bwerth@mozilla.com> - Wed, 27 Mar 2019 23:43:44 +0000 - rev 466593
Push 35773 by ncsoregi@mozilla.com at Fri, 29 Mar 2019 04:11:36 +0000
Bug 1500314 Part 1: Only apply mobile viewport stretching for documents with no meta viewport tag. r=botond Differential Revision: https://phabricator.services.mozilla.com/D23531
17f0796b0f6e: Bug 1519013 - Shrink the content to display size if user has never changed the site resolution. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 28 Mar 2019 03:04:59 +0000 - rev 466512
Push 35768 by opoprus@mozilla.com at Thu, 28 Mar 2019 09:55:54 +0000
Bug 1519013 - Shrink the content to display size if user has never changed the site resolution. r=botond elementFromPoint-002.html, elementFromPoint-003.html and dialog-showModal.html use document.elementFromPoint with a given point which is calculated from the value returned by getBoundingClientRect() for a 100% width element. Before this change, the given point is outside of view because there is no viewport meta tag in the documents so that elementFromPoint fails. After this change, the documents fit to the visual viewport so that elementFromPoint works as expected. Differential Revision: https://phabricator.services.mozilla.com/D16155
7f3a85a7e45a: Bug 1519013 - Add initial-scale=1 in scrollintoview.html. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 28 Mar 2019 03:04:28 +0000 - rev 466511
Push 35768 by opoprus@mozilla.com at Thu, 28 Mar 2019 09:55:54 +0000
Bug 1519013 - Add initial-scale=1 in scrollintoview.html. r=botond `initial-scale=1` prevents from scaling down the content so that scrollIntoView works as expected. Differential Revision: https://phabricator.services.mozilla.com/D19248
a99248b3ec38: Bug 1519013 - Introduce nsIPresShell::IsResolutionUpdatedByApz to tell whether the resolution has never been changed by APZ. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 28 Mar 2019 03:04:59 +0000 - rev 466510
Push 35768 by opoprus@mozilla.com at Thu, 28 Mar 2019 09:55:54 +0000
Bug 1519013 - Introduce nsIPresShell::IsResolutionUpdatedByApz to tell whether the resolution has never been changed by APZ. r=botond Differential Revision: https://phabricator.services.mozilla.com/D16154
c3931d5145ef: Bug 1527182 - With WR enabled, we can async scroll even inside SVG filters. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 27 Mar 2019 16:22:15 +0000 - rev 466405
Push 35768 by opoprus@mozilla.com at Thu, 28 Mar 2019 09:55:54 +0000
Bug 1527182 - With WR enabled, we can async scroll even inside SVG filters. r=botond Differential Revision: https://phabricator.services.mozilla.com/D24877
0ebb51472ce4: Bug 1500719 - Ensure toolbar is hidden when going fullscreen r=botond
Randall Barker <rbarker@mozilla.com> - Thu, 21 Mar 2019 23:39:59 +0000 - rev 465970
Push 35758 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:51:47 +0000
Bug 1500719 - Ensure toolbar is hidden when going fullscreen r=botond Differential Revision: https://phabricator.services.mozilla.com/D24348
04fb1566c7c1: Bug 1536755 Part 2: Add a test of meta viewport fixed width and zoom. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 22 Mar 2019 21:01:48 +0000 - rev 465866
Push 35752 by opoprus@mozilla.com at Mon, 25 Mar 2019 09:51:53 +0000
Bug 1536755 Part 2: Add a test of meta viewport fixed width and zoom. r=botond Differential Revision: https://phabricator.services.mozilla.com/D24456
d3065199857a: Bug 1536755 Part 1: Enforce viewport zoom constraints when the content size changes. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 22 Mar 2019 21:01:26 +0000 - rev 465865
Push 35752 by opoprus@mozilla.com at Mon, 25 Mar 2019 09:51:53 +0000
Bug 1536755 Part 1: Enforce viewport zoom constraints when the content size changes. r=botond Differential Revision: https://phabricator.services.mozilla.com/D24424
38349ca764d7: Bug 1500314 Part 2: Update test expectations. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 22 Mar 2019 16:46:30 +0000 - rev 465749
Push 35746 by shindli@mozilla.com at Sat, 23 Mar 2019 09:46:24 +0000
Bug 1500314 Part 2: Update test expectations. r=botond Depends on D23531 Differential Revision: https://phabricator.services.mozilla.com/D24268
77cafd05c85c: Bug 1500314 Part 1: Only apply mobile viewport stretching for documents with no meta viewport tag. r=botond
Brad Werth <bwerth@mozilla.com> - Fri, 22 Mar 2019 16:46:23 +0000 - rev 465748
Push 35746 by shindli@mozilla.com at Sat, 23 Mar 2019 09:46:24 +0000
Bug 1500314 Part 1: Only apply mobile viewport stretching for documents with no meta viewport tag. r=botond Differential Revision: https://phabricator.services.mozilla.com/D23531