searching for reviewer(botond)
75f4fbe4941ec9c770973844d77db44be21c86e0: Bug 1812396 - Make BasePoint::X() and Y() return Coord. r=botond
Razvan Cojocaru <rzvncj@gmail.com> - Fri, 27 Jan 2023 00:22:28 +0000 - rev 650742
Push 40583 by nbeleuzu@mozilla.com at Fri, 27 Jan 2023 09:46:52 +0000
Bug 1812396 - Make BasePoint::X() and Y() return Coord. r=botond Differential Revision: https://phabricator.services.mozilla.com/D167950
c996a95c0bf75502d4a07c0a345679f79db12233: Bug 1809430 - Make some tests account for smaller default window size on macOS. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Jan 2023 11:19:16 +0000 - rev 650632
Push 40582 by smolnar@mozilla.com at Thu, 26 Jan 2023 21:26:06 +0000
Bug 1809430 - Make some tests account for smaller default window size on macOS. r=botond Before these patches we were adding the titlebar height even though we were not rendering it. This made an apz mochitest with hardcoded heights to fail on macOS. It also perturbed browser_html_scroll_restoration.js in a way such as the scroll position after a resize is rounded in a different direction, but that is harmless. Depends on D166431 Differential Revision: https://phabricator.services.mozilla.com/D167027
c6bc2ad84f28cf056fbd15282bf801f7d4b2050f: Bug 1746126 - Allow controlling zoom-to-focused-input behaviour using `touch-action`. r=botond
Razvan Cojocaru <rzvncj@gmail.com> - Thu, 26 Jan 2023 01:07:58 +0000 - rev 650607
Push 40580 by ctuns@mozilla.com at Thu, 26 Jan 2023 04:53:27 +0000
Bug 1746126 - Allow controlling zoom-to-focused-input behaviour using `touch-action`. r=botond Rename AllowedTouchBehavior::DOUBLE_TAP_ZOOM to ANIMATING_ZOOM, and CompositorHitTestFlags::eTouchActionDoubleTapZoomDisabled to eTouchActionAnimatingZoomDisabled while at it. Differential Revision: https://phabricator.services.mozilla.com/D167522
1147d63e7ca4c161ee87ba1e8a98d05d4df5c895: Bug 1810662. Make "item should have finite clip with respect to aASR" asserts non-fatal. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Wed, 25 Jan 2023 12:50:51 +0000 - rev 650494
Push 40578 by abutkovits@mozilla.com at Wed, 25 Jan 2023 16:29:55 +0000
Bug 1810662. Make "item should have finite clip with respect to aASR" asserts non-fatal. r=botond Differential Revision: https://phabricator.services.mozilla.com/D166984
16b94d4482a2ea87cb5f124481e1562b2f03474f: Bug 1810662. Make "item should have finite clip with respect to aASR" asserts non-fatal. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Tue, 24 Jan 2023 01:43:25 +0000 - rev 650322
Push 40574 by smolnar@mozilla.com at Tue, 24 Jan 2023 09:30:00 +0000
Bug 1810662. Make "item should have finite clip with respect to aASR" asserts non-fatal. r=botond Differential Revision: https://phabricator.services.mozilla.com/D166984
7cc18b0e3ce6a375ead9d744ed961ceaecad6f81: No bug - Remove superfluous semicolon. r=botond
Razvan Cojocaru <rzvncj@gmail.com> - Mon, 23 Jan 2023 19:56:01 +0000 - rev 650268
Push 40574 by smolnar@mozilla.com at Tue, 24 Jan 2023 09:30:00 +0000
No bug - Remove superfluous semicolon. r=botond Differential Revision: https://phabricator.services.mozilla.com/D167587
1af6fa02884e3559bd69a0a6e6a2c5249cea667a: Bug 1811403 - Respect "apz.disable_for_scroll_linked_effects" pref whether to set HasScrollLinkedEffect flag. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Sun, 22 Jan 2023 21:09:40 +0000 - rev 650171
Push 40571 by abutkovits@mozilla.com at Mon, 23 Jan 2023 09:44:44 +0000
Bug 1811403 - Respect "apz.disable_for_scroll_linked_effects" pref whether to set HasScrollLinkedEffect flag. r=botond Differential Revision: https://phabricator.services.mozilla.com/D167337
62b561873472e355678450bbd7e0448885fd309b: Bug 1810819 - Add NativePanHandlerForHeadless. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 19 Jan 2023 21:07:44 +0000 - rev 649645
Push 40563 by mlaza@mozilla.com at Fri, 20 Jan 2023 03:46:23 +0000
Bug 1810819 - Add NativePanHandlerForHeadless. r=botond Differential Revision: https://phabricator.services.mozilla.com/D167111
8043d0f12d30532e209980dd89b61d42122459e3: Bug 1808833 - Fix overscroll handoff warning condition. r=botond
Dan Robertson <drobertson@mozilla.com> - Thu, 19 Jan 2023 13:36:45 +0000 - rev 649571
Push 40562 by csabou@mozilla.com at Thu, 19 Jan 2023 16:36:52 +0000
Bug 1808833 - Fix overscroll handoff warning condition. r=botond Now that fixed position content will have the mScrollParentId set to the null scroll parent id, the warning posted for non-root APZC's overscrolled with a null scroll parent id should not fire for APZCs with a fixed position parent. Differential Revision: https://phabricator.services.mozilla.com/D166445
f5cade40880acfcdaca6bc46923a62116c09a4a1: Bug 1809574 - Use hit-testing tree to determine fixed position handoff. r=botond
Dan Robertson <drobertson@mozilla.com> - Thu, 19 Jan 2023 13:36:44 +0000 - rev 649570
Push 40562 by csabou@mozilla.com at Thu, 19 Jan 2023 16:36:52 +0000
Bug 1809574 - Use hit-testing tree to determine fixed position handoff. r=botond Use the hit-testing tree to determine the APZC to handoff overscroll to if the current APZC is in a fixed position subtree. Differential Revision: https://phabricator.services.mozilla.com/D166787
3e6f9965b3f10e0400225580b9988a0fc8a49660: Bug 1796942 - Restore overscrolling gutters on the previous target APZC when we change it to the new target. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 17 Jan 2023 02:29:45 +0000 - rev 649050
Push 40558 by mlaza@mozilla.com at Tue, 17 Jan 2023 16:13:02 +0000
Bug 1796942 - Restore overscrolling gutters on the previous target APZC when we change it to the new target. r=botond Differential Revision: https://phabricator.services.mozilla.com/D166398
1d4f355a9db6f1349385846c290c3878801b3c67: Bug 1746126 - Add zoom-to-focused-input mochitests for user-scalable={yes,no}. r=botond
Razvan Cojocaru <rzvncj@gmail.com> - Sat, 14 Jan 2023 19:27:58 +0000 - rev 648893
Push 40553 by sstanca@mozilla.com at Sun, 15 Jan 2023 09:41:28 +0000
Bug 1746126 - Add zoom-to-focused-input mochitests for user-scalable={yes,no}. r=botond Also rename helper_zoomToFocusedInput_nozoom.html to helper_zoomToFocusedInput_nozoom_bug1738696.html, since it appears to test behaviour specific to bug 1738696. Differential Revision: https://phabricator.services.mozilla.com/D166837
3f7a6c650a857ccf7f1db7fb42101d4167fb7e1b: Bug 1807659. Wait for a refresh driver tick in gfx/layers/apz/test/mochitest/helper_zoom_keyboardscroll.html after all actions. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Wed, 28 Dec 2022 01:19:37 +0000 - rev 647490
Push 40511 by smolnar@mozilla.com at Wed, 28 Dec 2022 21:37:47 +0000
Bug 1807659. Wait for a refresh driver tick in gfx/layers/apz/test/mochitest/helper_zoom_keyboardscroll.html after all actions. r=botond Didn't investigate why this was failing exactly, but promiseApzFlushedRepaints does not wait for a refresh driver tick and I remember from fixing some other scrolling tests a while back that sometimes you need to wait for a refresh driver tick for things to be completed (don't remember the details). Differential Revision: https://phabricator.services.mozilla.com/D165546
4681951d59b71a67951f1cd42ac0881e0ae92206: Bug 1379458 - Remove the unused SCROLLABLE flag. r=botond
Dan Robertson <drobertson@mozilla.com> - Tue, 27 Dec 2022 14:08:51 +0000 - rev 647453
Push 40509 by abutkovits@mozilla.com at Tue, 27 Dec 2022 21:13:21 +0000
Bug 1379458 - Remove the unused SCROLLABLE flag. r=botond Remove the unused SCROLLABLE_FOLLOW_OOF_TO_PLACEHOLDER flag now that ASRs should match the mScrollParentId. Depends on D149925 Differential Revision: https://phabricator.services.mozilla.com/D153104
58f50284310bc3792ec995dcb422c9e19f67b0c0: Bug 1379458 - The ScrollParentId should match the ASR tree. r=botond,tnikkel,mstange
Dan Robertson <drobertson@mozilla.com> - Tue, 27 Dec 2022 14:08:51 +0000 - rev 647452
Push 40509 by abutkovits@mozilla.com at Tue, 27 Dec 2022 21:13:21 +0000
Bug 1379458 - The ScrollParentId should match the ASR tree. r=botond,tnikkel,mstange Make the ScrollMetadata's mScrollParentId match what is found in the active scroll root tree. Depends on D148662 Differential Revision: https://phabricator.services.mozilla.com/D149925
f94a03948385bfaf6a76a7d4883de174206bd22a: Bug 1379458 - Add test group for overscroll handoff. r=botond
Dan Robertson <drobertson@mozilla.com> - Tue, 27 Dec 2022 14:08:50 +0000 - rev 647451
Push 40509 by abutkovits@mozilla.com at Tue, 27 Dec 2022 21:13:21 +0000
Bug 1379458 - Add test group for overscroll handoff. r=botond - Add tests for overscroll handoff from a fixed position element - Add test for overscroll handoff from a sticky position element Differential Revision: https://phabricator.services.mozilla.com/D148662
7a6e266359600cdbecaf950ba996fab86bc75115: Bug 1803992 - Call BrowserTestUtils.waitForContentEvent before awaiting "apz-repaints-flushed" in content. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 21 Dec 2022 22:43:19 +0000 - rev 647192
Push 40499 by imoraru@mozilla.com at Thu, 22 Dec 2022 17:00:32 +0000
Bug 1803992 - Call BrowserTestUtils.waitForContentEvent before awaiting "apz-repaints-flushed" in content. r=botond It will ensure that the BrowserTestUtils.waitForContentEvent has finished setting up the event listener in content before sending native pan events. Differential Revision: https://phabricator.services.mozilla.com/D165344
81da50971081075695f75485328d36f126d9cd49: Bug 1702504 - Fix crash in [@ mozilla::widget::TouchResampler::NotifyFrame]. r=botond,geckoview-reviewers,m_kato
Razvan Cojocaru <rzvncj@gmail.com> - Mon, 19 Dec 2022 21:05:44 +0000 - rev 646780
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1702504 - Fix crash in [@ mozilla::widget::TouchResampler::NotifyFrame]. r=botond,geckoview-reviewers,m_kato Give Observer a virtual destructor while at it. Differential Revision: https://phabricator.services.mozilla.com/D164550
6644ae3e7c9bc1cd4f45104de4ded074f4bc67b8: Bug 1790253: Check whether elements having 'display: contents' style is apz aware. r=botond,smaug,emilio
Daisuke Akatsuka <daisuke@birchill.co.jp> - Mon, 19 Dec 2022 08:41:20 +0000 - rev 646684
Push 40493 by ctuns@mozilla.com at Mon, 19 Dec 2022 16:25:26 +0000
Bug 1790253: Check whether elements having 'display: contents' style is apz aware. r=botond,smaug,emilio Differential Revision: https://phabricator.services.mozilla.com/D159378
00fb6658b130058d5f54ed8850092c29f806f2a0: Bug 1488886 - AllocPAPZCTreeManager should gracefully fail if APZ is not enabled. r=botond
Dan Robertson <drobertson@mozilla.com> - Sun, 18 Dec 2022 02:57:00 +0000 - rev 646660
Push 40492 by ctuns@mozilla.com at Mon, 19 Dec 2022 09:38:06 +0000
Bug 1488886 - AllocPAPZCTreeManager should gracefully fail if APZ is not enabled. r=botond Depends on D164682 Differential Revision: https://phabricator.services.mozilla.com/D164683
c220d03cfb7fee7b7c7c16ae0c872d869603462d: Bug 1488886 - Fix static-analysis warnings. r=botond
Dan Robertson <drobertson@mozilla.com> - Sun, 18 Dec 2022 02:57:00 +0000 - rev 646659
Push 40492 by ctuns@mozilla.com at Mon, 19 Dec 2022 09:38:06 +0000
Bug 1488886 - Fix static-analysis warnings. r=botond Fix static-analysis warnings in ContentCompositorBridgeParent. Differential Revision: https://phabricator.services.mozilla.com/D164682
8cdb673361ab1acd23b6ff1e905fac72ab0e578d: Bug 1488886 - AllocPAPZCTreeManager should gracefully fail if APZ is not enabled. r=botond
Dan Robertson <drobertson@mozilla.com> - Fri, 16 Dec 2022 19:07:07 +0000 - rev 646604
Push 40489 by smolnar@mozilla.com at Sat, 17 Dec 2022 21:17:45 +0000
Bug 1488886 - AllocPAPZCTreeManager should gracefully fail if APZ is not enabled. r=botond Depends on D164682 Differential Revision: https://phabricator.services.mozilla.com/D164683
7fc8e79f2ff06e0d921faea70a61137695f19476: Bug 1488886 - Fix static-analysis warnings. r=botond
Dan Robertson <drobertson@mozilla.com> - Fri, 16 Dec 2022 19:07:07 +0000 - rev 646603
Push 40489 by smolnar@mozilla.com at Sat, 17 Dec 2022 21:17:45 +0000
Bug 1488886 - Fix static-analysis warnings. r=botond Fix static-analysis warnings in ContentCompositorBridgeParent. Differential Revision: https://phabricator.services.mozilla.com/D164682
31b12711c229a421bf2ea022414dfd0696753612: Bug 1790253: Check whether elements having 'display: contents' style is apz aware. r=botond,smaug,emilio
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 16 Dec 2022 07:04:31 +0000 - rev 646534
Push 40489 by smolnar@mozilla.com at Sat, 17 Dec 2022 21:17:45 +0000
Bug 1790253: Check whether elements having 'display: contents' style is apz aware. r=botond,smaug,emilio Differential Revision: https://phabricator.services.mozilla.com/D159378
a4a0e5f0e1d9e9705ec3bc228e8c0549b06eaaf5: Bug 1685648 - Prevent a fast fling when trying to pinch-zoom on a non-zoomable page. r=botond
Razvan Cojocaru <rzvncj@gmail.com> - Sun, 11 Dec 2022 05:29:12 +0000 - rev 645227
Push 40472 by nfay@mozilla.com at Sun, 11 Dec 2022 09:22:51 +0000
Bug 1685648 - Prevent a fast fling when trying to pinch-zoom on a non-zoomable page. r=botond This now enables two-finger fling gestures on zoomable pages too, which helps with consistency. Differential Revision: https://phabricator.services.mozilla.com/D164134
848de6ab7ca949ac58daf6cc488c5e6584c622af: Bug 1803435 - Enable scrollend for content by default. r=hiro,botond,emilio
Dan Robertson <drobertson@mozilla.com> - Wed, 07 Dec 2022 18:49:16 +0000 - rev 645022
Push 40462 by smolnar@mozilla.com at Thu, 08 Dec 2022 03:58:54 +0000
Bug 1803435 - Enable scrollend for content by default. r=hiro,botond,emilio Enable firing the scrollend event to content by default. Differential Revision: https://phabricator.services.mozilla.com/D163801
b8a8ca798d9fcf38f2574c85c6cf7680a59b52a5: Bug 1803435 - Enable scrollend for content by default. r=hiro,botond,emilio
Dan Robertson <drobertson@mozilla.com> - Tue, 06 Dec 2022 19:20:41 +0000 - rev 644867
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1803435 - Enable scrollend for content by default. r=hiro,botond,emilio Enable firing the scrollend event to content by default. Differential Revision: https://phabricator.services.mozilla.com/D163801
358b19b50fb8d8751458a1385641d530ca5071e8: Bug 1801782 - Add a browser mochitest to cause content response timeout. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Sun, 04 Dec 2022 23:41:42 +0000 - rev 644655
Push 40453 by sstanca@mozilla.com at Mon, 05 Dec 2022 09:35:46 +0000
Bug 1801782 - Add a browser mochitest to cause content response timeout. r=botond Differential Revision: https://phabricator.services.mozilla.com/D162951
5470deb9263ae2b7aea6ee9a963d9e89d23d2e4f: Bug 1801782 - Drop a redundant pan update phase in panRightToLeft. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Sun, 04 Dec 2022 23:41:42 +0000 - rev 644654
Push 40453 by sstanca@mozilla.com at Mon, 05 Dec 2022 09:35:46 +0000
Bug 1801782 - Drop a redundant pan update phase in panRightToLeft. r=botond Differential Revision: https://phabricator.services.mozilla.com/D163181
4fbb4c54c4f26ea710a7279109741786e309fc2b: Bug 1801782 - Rename deltaOnRTL to delta. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Sun, 04 Dec 2022 23:41:42 +0000 - rev 644653
Push 40453 by sstanca@mozilla.com at Mon, 05 Dec 2022 09:35:46 +0000
Bug 1801782 - Rename deltaOnRTL to delta. r=botond On Windows it's also opposite vertically. Differential Revision: https://phabricator.services.mozilla.com/D163053
daac3f6a1fdf524aeab961c87543231ee27b94ae: Bug 1801782 - Move utility functions for sending pan events into apz_test_native_event_utils.js. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Sun, 04 Dec 2022 23:41:41 +0000 - rev 644652
Push 40453 by sstanca@mozilla.com at Mon, 05 Dec 2022 09:35:46 +0000
Bug 1801782 - Move utility functions for sending pan events into apz_test_native_event_utils.js. r=botond Differential Revision: https://phabricator.services.mozilla.com/D162950
2f63497a420037112075058194f04d63cb998f9f: Bug 1803455 - Fire scrollend for a main thread smooth scroll. r=botond
Dan Robertson <drobertson@mozilla.com> - Fri, 02 Dec 2022 22:26:55 +0000 - rev 644587
Push 40450 by ctuns@mozilla.com at Sat, 03 Dec 2022 09:24:59 +0000
Bug 1803455 - Fire scrollend for a main thread smooth scroll. r=botond Use the original start position of main thread smooth scrolls to determine if the scroll position changed on scroll complete, and fire a scrollend event if it did. Differential Revision: https://phabricator.services.mozilla.com/D163550
a671af6f0028d12450326afab367aaa976f92954: Bug 1793119 [Linux] Inhibit screensaver during autoscroll r=botond,emilio
stransky <stransky@redhat.com> - Fri, 02 Dec 2022 11:58:43 +0000 - rev 644495
Push 40449 by csabou@mozilla.com at Fri, 02 Dec 2022 21:26:33 +0000
Bug 1793119 [Linux] Inhibit screensaver during autoscroll r=botond,emilio Depends on D162978 Differential Revision: https://phabricator.services.mozilla.com/D163224
e653ba7dc7498a0d176e80ee6a8c762280640948: Bug 1801782 - Add a browser mochitest to cause content response timeout. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 30 Nov 2022 22:15:07 +0000 - rev 644223
Push 40446 by nfay@mozilla.com at Thu, 01 Dec 2022 16:18:29 +0000
Bug 1801782 - Add a browser mochitest to cause content response timeout. r=botond Differential Revision: https://phabricator.services.mozilla.com/D162951
e7e0e08c03f2f9e427023789314d88f7d5ece3bb: Bug 1801782 - Drop a redundant pan update phase in panRightToLeft. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 30 Nov 2022 22:15:07 +0000 - rev 644222
Push 40446 by nfay@mozilla.com at Thu, 01 Dec 2022 16:18:29 +0000
Bug 1801782 - Drop a redundant pan update phase in panRightToLeft. r=botond Differential Revision: https://phabricator.services.mozilla.com/D163181
d5f972c202fadfacc9e98a170128d044e772a612: Bug 1801782 - Rename deltaOnRTL to delta. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 30 Nov 2022 22:15:06 +0000 - rev 644221
Push 40446 by nfay@mozilla.com at Thu, 01 Dec 2022 16:18:29 +0000
Bug 1801782 - Rename deltaOnRTL to delta. r=botond On Windows it's also opposite vertically. Differential Revision: https://phabricator.services.mozilla.com/D163053
d76f0c0d4d94f77e8d28dfafe0b0c0b620398aa7: Bug 1801782 - Move utility functions for sending pan events into apz_test_native_event_utils.js. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 30 Nov 2022 22:15:06 +0000 - rev 644220
Push 40446 by nfay@mozilla.com at Thu, 01 Dec 2022 16:18:29 +0000
Bug 1801782 - Move utility functions for sending pan events into apz_test_native_event_utils.js. r=botond Differential Revision: https://phabricator.services.mozilla.com/D162950
f4a229ed50c766c61e9a25cc4fb81d43702a09fb: Bug 1802605 - Use SpecialPowers.Services.env in gfx tests r=botond
Barret Rennie <barret@brennie.ca> - Mon, 28 Nov 2022 20:39:38 +0000 - rev 643893
Push 40440 by ctuns@mozilla.com at Tue, 29 Nov 2022 08:40:32 +0000
Bug 1802605 - Use SpecialPowers.Services.env in gfx tests r=botond Differential Revision: https://phabricator.services.mozilla.com/D163249
c52ce5a1b79d8580e6fbc937e16dba4e28095873: Bug 1541508 - Use Services.env in gfx/ r=botond
Barret Rennie <barret@brennie.ca> - Fri, 25 Nov 2022 19:09:07 +0000 - rev 643671
Push 40433 by ncsoregi@mozilla.com at Sat, 26 Nov 2022 21:27:35 +0000
Bug 1541508 - Use Services.env in gfx/ r=botond Differential Revision: https://phabricator.services.mozilla.com/D160153
e53c165db9ed6eb518da7b658bec5d1b1fa19d6a: Bug 1794070 - Make a pan start event wait for the browser gesture code response. r=botond,dlrobertson
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 22 Nov 2022 06:52:53 +0000 - rev 643144
Push 40423 by csabou@mozilla.com at Tue, 22 Nov 2022 21:43:24 +0000
Bug 1794070 - Make a pan start event wait for the browser gesture code response. r=botond,dlrobertson So that APZ can wait to handle the event to do overscrolling until the browser responds that the event wasn't used for gestures. Differential Revision: https://phabricator.services.mozilla.com/D160438
176117d42d0d2ac88fa0a94494988c5c8d716876: Bug 1794070 - Ignore overscrollable check in CanScrollTargetHorizontally. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 22 Nov 2022 06:52:52 +0000 - rev 643143
Push 40423 by csabou@mozilla.com at Tue, 22 Nov 2022 21:43:24 +0000
Bug 1794070 - Ignore overscrollable check in CanScrollTargetHorizontally. r=botond Differential Revision: https://phabricator.services.mozilla.com/D162362
bd372222500345caaed0a31fe57ca56343bd9d72: Bug 1794070 - Introduce PanGestureInput::AllowsSwipe(). r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 22 Nov 2022 06:52:52 +0000 - rev 643142
Push 40423 by csabou@mozilla.com at Tue, 22 Nov 2022 21:43:24 +0000
Bug 1794070 - Introduce PanGestureInput::AllowsSwipe(). r=botond Differential Revision: https://phabricator.services.mozilla.com/D160437
24470c7b080a9365371db5671c857ab2a9f36120: Bug 1794070 - Refer mRequiresContentResponseIfCannotScrollHorizontallyInStartDirection flag instead of calling SwipeTrackker::CanTriggerSwipe(). r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 22 Nov 2022 06:52:52 +0000 - rev 643141
Push 40423 by csabou@mozilla.com at Tue, 22 Nov 2022 21:43:24 +0000
Bug 1794070 - Refer mRequiresContentResponseIfCannotScrollHorizontallyInStartDirection flag instead of calling SwipeTrackker::CanTriggerSwipe(). r=botond And rename mRequiresContentResponseIfCannotScrollHorizontallyInStartDirection to mMayTriggerSwipe. So basically once after the flag is set, we should use it. Differential Revision: https://phabricator.services.mozilla.com/D160436
ab09208efd580b6a5f9d26607580c8df32e0c151: Bug 1794070 - Make mRequiresContentResponseIfCannotScrollHorizontallyInStartDirection private. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 22 Nov 2022 06:52:51 +0000 - rev 643140
Push 40423 by csabou@mozilla.com at Tue, 22 Nov 2022 21:43:24 +0000
Bug 1794070 - Make mRequiresContentResponseIfCannotScrollHorizontallyInStartDirection private. r=botond And initialized it only in ctors so that in the next change we can use it to tell whether this pan event may trigger swipe or not without calling SwipeTracker::CanTriggerSwipe every time. There's an unintuitive change in a GTest sending a horizontal pan-start event. With this changeset, all incomming pan-start events on desktop platforms basically set mRequiresContentResponseIfCannotScrollHorizontallyInStartDirection to true even if the event is generated in GTests. So the pan start event runs into the short circuit path for swipe-to-navigation. This is a good thing because it means the GTest replicates what our browser does properly. Differential Revision: https://phabricator.services.mozilla.com/D160435
b39f0f65a91f993662842c760559ab9dde1420ae: Bug 1794070 - Check mOverscrollBehaviorAllowsSwipe whether we do the short circuit for swipe. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 22 Nov 2022 06:52:51 +0000 - rev 643139
Push 40423 by csabou@mozilla.com at Tue, 22 Nov 2022 21:43:24 +0000
Bug 1794070 - Check mOverscrollBehaviorAllowsSwipe whether we do the short circuit for swipe. r=botond Though this isn't a real bug at all since later we check the flag in nsBaseWidget::MayStartSwipeForAPZ [1], this change includes a browser mochitest to make sure `overscroll-behavior: contain` prevents swipe navigations. [1] https://searchfox.org/mozilla-central/rev/c5c002f81f08a73e04868e0c2bf0eb113f200b03/widget/nsBaseWidget.cpp#2294 Differential Revision: https://phabricator.services.mozilla.com/D160434
dce3beafe216d6b4674c313c97e7a6f180048700: Bug 1794070 - Run the test case listening "wheel" event at the last in browser_test_swipe_gesture.js. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 22 Nov 2022 06:52:50 +0000 - rev 643138
Push 40423 by csabou@mozilla.com at Tue, 22 Nov 2022 21:43:24 +0000
Bug 1794070 - Run the test case listening "wheel" event at the last in browser_test_swipe_gesture.js. r=botond There's a bug (bug 1800022) that wheel event listeners in the browser process badly interact with overscroll even so we'd avoid the bug here. Differential Revision: https://phabricator.services.mozilla.com/D161752
a39067f76b9cb7777de562d120474aacba52a732: Bug 1794070 - Add "overscrolled" state in APZTestData.additionalData. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 22 Nov 2022 06:52:49 +0000 - rev 643135
Push 40423 by csabou@mozilla.com at Tue, 22 Nov 2022 21:43:24 +0000
Bug 1794070 - Add "overscrolled" state in APZTestData.additionalData. r=botond We'd like to use this for testing overscroll state in mochitests. Differential Revision: https://phabricator.services.mozilla.com/D160433
44fc2210f66e2f076c7cb4a8ea84a2f18ea22c5e: Bug 1794070 - Do the stuff for short circuit of swipe-to-navigation after calling MaybeRequestContentResponse. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 22 Nov 2022 06:52:49 +0000 - rev 643134
Push 40423 by csabou@mozilla.com at Tue, 22 Nov 2022 21:43:24 +0000
Bug 1794070 - Do the stuff for short circuit of swipe-to-navigation after calling MaybeRequestContentResponse. r=botond The stuff calls PanGestureBlockState::SetNeedsToWaitForContentResponse which sets mWaitingForContentResponse flag, but the flag will clobbered in MaybeRequestContentResponse(). Differential Revision: https://phabricator.services.mozilla.com/D160432
ae92abf5688a04885853d31d9c032f593ef5583c: Bug 1794070 - Remove APZEventStat::ProcessClusterHit declaration. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 22 Nov 2022 06:52:48 +0000 - rev 643133
Push 40423 by csabou@mozilla.com at Tue, 22 Nov 2022 21:43:24 +0000
Bug 1794070 - Remove APZEventStat::ProcessClusterHit declaration. r=botond The implementation got removed in bug 1618545. https://hg.mozilla.org/mozilla-central/rev/3de8fd99080d63f47da911afe39f489de5864e9e Differential Revision: https://phabricator.services.mozilla.com/D160431
afe487b23e1c8e2f1e37d9b0b6af714f63899c43: Bug 1794070 - Make a pan start event wait for the browser gesture code response. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Mon, 21 Nov 2022 03:10:08 +0000 - rev 642969
Push 40420 by abutkovits@mozilla.com at Mon, 21 Nov 2022 09:36:40 +0000
Bug 1794070 - Make a pan start event wait for the browser gesture code response. r=botond So that APZ can wait to handle the event to do overscrolling until the browser responds that the event wasn't used for gestures. Differential Revision: https://phabricator.services.mozilla.com/D160438