searching for reviewer(bomsy)
32ccf7c896a3f09299b6af90dc6633af16a06f0e: Bug 1811429 - [devtools] Enable assertion in browser_dbg-pretty-print-paused-anonymous.js. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 25 Jan 2023 11:32:11 +0000 - rev 650485
Push 40578 by abutkovits@mozilla.com at Wed, 25 Jan 2023 16:29:55 +0000
Bug 1811429 - [devtools] Enable assertion in browser_dbg-pretty-print-paused-anonymous.js. r=bomsy. Differential Revision: https://phabricator.services.mozilla.com/D167775
e884e288ddac8a888f8d49fef2e62f7a33f62649: Bug 1811233 - [devtools] Add test for pretty-printing eval source. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 20 Jan 2023 16:58:58 +0000 - rev 649824
Push 40565 by ctuns@mozilla.com at Fri, 20 Jan 2023 21:21:03 +0000
Bug 1811233 - [devtools] Add test for pretty-printing eval source. r=bomsy. Differential Revision: https://phabricator.services.mozilla.com/D167273
9bfa7dbb54e7020951ad0c73a2018b80f7cbc433: Bug 1811250 - [devtools] Don't use mask-image for source tree file icons. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 20 Jan 2023 16:26:34 +0000 - rev 649815
Push 40565 by ctuns@mozilla.com at Fri, 20 Jan 2023 21:21:03 +0000
Bug 1811250 - [devtools] Don't use mask-image for source tree file icons. r=bomsy. Differential Revision: https://phabricator.services.mozilla.com/D167258
f07a22692ff0a25c5177a671dfe78a96b27eefd2: Bug 1811233 - [devtools] Add test for pretty-printing eval source. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 20 Jan 2023 14:59:11 +0000 - rev 649753
Push 40565 by ctuns@mozilla.com at Fri, 20 Jan 2023 21:21:03 +0000
Bug 1811233 - [devtools] Add test for pretty-printing eval source. r=bomsy. Differential Revision: https://phabricator.services.mozilla.com/D167273
88acd0f49283ad371e3192617ce03375dcb8e945: Bug 1687166 - [devtools] Fetch whole source text for "new Function()" sources. r=arai,bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 20 Jan 2023 09:45:02 +0000 - rev 649714
Push 40565 by ctuns@mozilla.com at Fri, 20 Jan 2023 21:21:03 +0000
Bug 1687166 - [devtools] Fetch whole source text for "new Function()" sources. r=arai,bomsy But keep unwrapping sources for DOM event handlers like: <div onclick="foo()" /> Whose source should be: foo() and not: function onclick() { foo() } Differential Revision: https://phabricator.services.mozilla.com/D165721
741101fd3914e96dc430418cd81da9ac70d35db4: Bug 1757161 - Add a check to make sure channel.loadInfo.loadingPrincipal is not null. r=bomsy
kernp25 <kernp25@yahoo.com> - Wed, 18 Jan 2023 11:49:45 +0000 - rev 649372
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1757161 - Add a check to make sure channel.loadInfo.loadingPrincipal is not null. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D165523
8ddfebd080fb2c3d9ce930a4977a5cc97235514c: Bug 1807896 - [devtools] Move manager destruction from toolbox-unload to destroyed. r=devtools-reviewers,bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 18 Jan 2023 09:27:30 +0000 - rev 649351
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1807896 - [devtools] Move manager destruction from toolbox-unload to destroyed. r=devtools-reviewers,bomsy This toolbox-unload was only fired for ToolboxHostManager own usage. On top of that, ToolBoxHostManager was delaying its destruction by an additional event loop. It indicates that this toolbox-unload event was too early. So it rather makes sense to use the latest event in the destruction codepath. i.e. toolbox's "destroyed" event. I kept the event loop tick as toolbox-destroyed is still slightly too early. The debugger is still going through pending async work in browser_dbg-breakpoints-in-evaled-sources.js. This relates to the promise middleware which delay each promise action by an event loop tick using setTimeout. setTimeout throws once we remove the host iframe. I first tried to remove this event loop tick. It highlighted two possible intermittents in two tests involving viewSourceInDebugger. These tests weren't waiting for the full processing of opened sources by the Debugger frontend. Using debugger shared-head helpers ensure waiting for full source selection. Differential Revision: https://phabricator.services.mozilla.com/D165714
9ff83ce24806f8ae18d24c04c8800c86162ee696: Bug 1006785 - [devtools] Add DAMP test for debugger pretty-printing. r=jdescottes,bomsy,perftest-reviewers,sparky.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 16 Jan 2023 06:50:38 +0000 - rev 648901
Push 40554 by imoraru@mozilla.com at Mon, 16 Jan 2023 09:53:16 +0000
Bug 1006785 - [devtools] Add DAMP test for debugger pretty-printing. r=jdescottes,bomsy,perftest-reviewers,sparky. Differential Revision: https://phabricator.services.mozilla.com/D166772
9272c5d75533cc821b9888b8206b3848ca069a90: Bug 1805378 - [devtools] Make the SourceMapLoader be instantiated per toolbox. r=bomsy,perftest-reviewers,kshampur
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 20 Dec 2022 19:09:57 +0000 - rev 646892
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1805378 - [devtools] Make the SourceMapLoader be instantiated per toolbox. r=bomsy,perftest-reviewers,kshampur This complexify the existing tests a bit, but will make the management from the Toolbox more obvious. The metrics test highlights that we allow to prevent loading the sourcemap modules unless it is strictly necessary! (Also I forgot to remove the source-map-loader from the list of browser loader module...) Differential Revision: https://phabricator.services.mozilla.com/D164694
f7b7152487d0935d4af53b4772fdf353d5e1a007: Bug 1805378 - [devtools] Make all debugger worker use the same pattern an inherit from WorkerDispatcher. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 20 Dec 2022 19:09:56 +0000 - rev 646891
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1805378 - [devtools] Make all debugger worker use the same pattern an inherit from WorkerDispatcher. r=bomsy Also align the one worker in netmonitor. Differential Revision: https://phabricator.services.mozilla.com/D164692
2a0d24f91df3110a425edb84bb1fa97b0827eb67: Bug 1805378 - [devtools] Automatically start the worker on first WorkerDispatcher invoke/task call. r=bomsy,perftest-reviewers,kshampur
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 20 Dec 2022 19:09:56 +0000 - rev 646890
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1805378 - [devtools] Automatically start the worker on first WorkerDispatcher invoke/task call. r=bomsy,perftest-reviewers,kshampur Because of this, we have to now pass the worker URL via WorkerDispatcher constructor. Doing this should help then extend WorkerDispatcher instead of manually instantiating it. About browser_jsterm_hide_when_devtools_chrome_enabled_false.js, as the SourceMapLoader is now started lazily, the worker is no longer started during this test and so we no longer have to wait for it. And browser_jsterm_await_paused.js was failing because we resumed too quickly. I added some code to better wait for awaitExpression full evaluation. Differential Revision: https://phabricator.services.mozilla.com/D164547
af8bee46fcd6a93e7314db59f00e9194136e8385: Bug 1805378 - [devtools] Convert WorkerDispatcher to ES Class. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 20 Dec 2022 19:09:55 +0000 - rev 646889
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1805378 - [devtools] Convert WorkerDispatcher to ES Class. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D164546
1fb0d941f15bdbe8df49dc3cab14d6317c797867: Bug 1805378 - [devtools] Reuse toolbox parser worker from the webconsole. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 20 Dec 2022 19:09:55 +0000 - rev 646888
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1805378 - [devtools] Reuse toolbox parser worker from the webconsole. r=bomsy Note that we still have to instantiate a Webconsole dedicated one in case of Browser Console, which won't have any toolbox offhand. Differential Revision: https://phabricator.services.mozilla.com/D164545
784c086d097518ecbf4711afd9158928b0b8e70e: Bug 1805378 - [devtools] Remove unused getNextStep method from the parser worker. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 20 Dec 2022 19:09:54 +0000 - rev 646887
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1805378 - [devtools] Remove unused getNextStep method from the parser worker. r=bomsy As well as its leftover dependencies. Differential Revision: https://phabricator.services.mozilla.com/D164544
6890460281625eb3e24621a9341b5e9292c82777: Bug 1805378 - [devtools] Use WorkerDispatcher.task in Parser worker. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 20 Dec 2022 19:09:54 +0000 - rev 646886
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1805378 - [devtools] Use WorkerDispatcher.task in Parser worker. r=bomsy This prevents recreating a complex method each time we call WorkerDispatcher.invoke. Differential Revision: https://phabricator.services.mozilla.com/D164543
4dd1ad43572897845fefd5db259947fff90a6573: Bug 1805378 - [devtools] Make the SourceMapLoader be instantiated per toolbox. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 19 Dec 2022 17:00:37 +0000 - rev 646752
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1805378 - [devtools] Make the SourceMapLoader be instantiated per toolbox. r=bomsy This complexify the existing tests a bit, but will make the management from the Toolbox more obvious. The metrics test highlights that we allow to prevent loading the sourcemap modules unless it is strictly necessary! (Also I forgot to remove the source-map-loader from the list of browser loader module...) Differential Revision: https://phabricator.services.mozilla.com/D164694
5479ff3a475f50e83696a9da61b2fa0eacca97da: Bug 1805378 - [devtools] Make all debugger worker use the same pattern an inherit from WorkerDispatcher. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 19 Dec 2022 17:00:37 +0000 - rev 646751
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1805378 - [devtools] Make all debugger worker use the same pattern an inherit from WorkerDispatcher. r=bomsy Also align the one worker in netmonitor. Differential Revision: https://phabricator.services.mozilla.com/D164692
bd89280bde1a4519640fe2294912aa5fc072f1cd: Bug 1805378 - [devtools] Automatically start the worker on first WorkerDispatcher invoke/task call. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 19 Dec 2022 17:00:36 +0000 - rev 646750
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1805378 - [devtools] Automatically start the worker on first WorkerDispatcher invoke/task call. r=bomsy Because of this, we have to now pass the worker URL via WorkerDispatcher constructor. Doing this should help then extend WorkerDispatcher instead of manually instantiating it. About browser_jsterm_hide_when_devtools_chrome_enabled_false.js, as the SourceMapLoader is now started lazily, the worker is no longer started during this test and so we no longer have to wait for it. And browser_jsterm_await_paused.js was failing because we resumed too quickly. I added some code to better wait for awaitExpression full evaluation. Differential Revision: https://phabricator.services.mozilla.com/D164547
1bd4fec4b9647a843152589bddae4d1a261e52d4: Bug 1805378 - [devtools] Convert WorkerDispatcher to ES Class. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 19 Dec 2022 17:00:36 +0000 - rev 646749
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1805378 - [devtools] Convert WorkerDispatcher to ES Class. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D164546
975bd01106d783c63c22587a4126ff5d18f5ac4b: Bug 1805378 - [devtools] Reuse toolbox parser worker from the webconsole. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 19 Dec 2022 17:00:36 +0000 - rev 646748
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1805378 - [devtools] Reuse toolbox parser worker from the webconsole. r=bomsy Note that we still have to instantiate a Webconsole dedicated one in case of Browser Console, which won't have any toolbox offhand. Differential Revision: https://phabricator.services.mozilla.com/D164545
9a1e0541748a32426ee3ba0d41549a0bb5c74881: Bug 1805378 - [devtools] Remove unused getNextStep method from the parser worker. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 19 Dec 2022 17:00:35 +0000 - rev 646747
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1805378 - [devtools] Remove unused getNextStep method from the parser worker. r=bomsy As well as its leftover dependencies. Differential Revision: https://phabricator.services.mozilla.com/D164544
926ce2f2d51fd80d070af3fe18969874d53612fd: Bug 1805378 - [devtools] Use WorkerDispatcher.task in Parser worker. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 19 Dec 2022 17:00:35 +0000 - rev 646746
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1805378 - [devtools] Use WorkerDispatcher.task in Parser worker. r=bomsy This prevents recreating a complex method each time we call WorkerDispatcher.invoke. Differential Revision: https://phabricator.services.mozilla.com/D164543
b09d7f107f31d64baaf493afe29dd70d7b0af7d6: Bug 1805289 - [devtools] Update source-map libary to latest git changeset. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 19 Dec 2022 16:26:42 +0000 - rev 646738
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1805289 - [devtools] Update source-map libary to latest git changeset. r=bomsy The main take away are: * lint fixes * upgrade of wasm binary built with latest toolchain, bringing perf improvements This also bundle a script to easily update the vendored files and update the GITHUB_CHANGESET file accordingly. Differential Revision: https://phabricator.services.mozilla.com/D164501
245ca37205bb8f8f3c0a69143ae5a6bc1e786d53: Bug 1790368 - [devtools] Expose the nsIChannel in NetworkObserver's onNetworkEvent r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Fri, 16 Dec 2022 10:53:49 +0000 - rev 646560
Push 40489 by smolnar@mozilla.com at Sat, 17 Dec 2022 21:17:45 +0000
Bug 1790368 - [devtools] Expose the nsIChannel in NetworkObserver's onNetworkEvent r=bomsy We need to expose the nsIChannel in order to retrieve all the information needed by BiDi Differential Revision: https://phabricator.services.mozilla.com/D164147
6df64c2927f15094d50e8eaa8a31669498698a8d: Bug 1790368 - [devtools] Expose the nsIChannel in NetworkObserver's onNetworkEvent r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Fri, 16 Dec 2022 09:30:38 +0000 - rev 646544
Push 40489 by smolnar@mozilla.com at Sat, 17 Dec 2022 21:17:45 +0000
Bug 1790368 - [devtools] Expose the nsIChannel in NetworkObserver's onNetworkEvent r=bomsy We need to expose the nsIChannel in order to retrieve all the information needed by BiDi Differential Revision: https://phabricator.services.mozilla.com/D164147
5bf498dbfba05e06e2e3fce738185fb238223904: Bug 1784847 - Disable the breakpoint tests of composition events until bug 1466596 or bug 1690827 is fixed r=bomsy
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 14 Dec 2022 04:47:48 +0000 - rev 645976
Push 40481 by ctuns@mozilla.com at Wed, 14 Dec 2022 16:24:11 +0000
Bug 1784847 - Disable the breakpoint tests of composition events until bug 1466596 or bug 1690827 is fixed r=bomsy I think that fixing the crash bug requires a big design change to manage delayed composition commit requests from a remote process and I don't have much time to work on it but the intermittent failure frequency has spiked up. Therefore, we need temporarily to comment out the block for now. Differential Revision: https://phabricator.services.mozilla.com/D164532
4aec581162263fc8e52282a65af2b0877598ccf4: Bug 1804232 - [devtools] Add test for network request HTML preview in webconsole. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 13 Dec 2022 07:32:50 +0000 - rev 645813
Push 40479 by nbeleuzu@mozilla.com at Tue, 13 Dec 2022 16:50:20 +0000
Bug 1804232 - [devtools] Add test for network request HTML preview in webconsole. r=bomsy. Differential Revision: https://phabricator.services.mozilla.com/D164104
136a6746e5db75bc7e78e9fc126d5cb29e9f1de4: Bug 1801695 - [devtools] Rename SourceMapService to SourceMapLoader. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 12 Dec 2022 13:15:53 +0000 - rev 645639
Push 40477 by smolnar@mozilla.com at Mon, 12 Dec 2022 21:52:29 +0000
Bug 1801695 - [devtools] Rename SourceMapService to SourceMapLoader. r=bomsy Also rename a few symbols to better identify SourceMapURLService. Differential Revision: https://phabricator.services.mozilla.com/D162969
208656a729becd8a513cd5ae61d463aad4b3f1eb: Bug 1801695 - [devtools] Remove Proxy on top of SourceMapLoader. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 12 Dec 2022 13:15:52 +0000 - rev 645638
Push 40477 by smolnar@mozilla.com at Mon, 12 Dec 2022 21:52:29 +0000
Bug 1801695 - [devtools] Remove Proxy on top of SourceMapLoader. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D162968
8435c181b8b9fa50e49229774ee1d61b940fe99d: Bug 1801695 - [devtools] Remove applySourceMap proxy in favor of an event. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 12 Dec 2022 13:15:52 +0000 - rev 645637
Push 40477 by smolnar@mozilla.com at Mon, 12 Dec 2022 21:52:29 +0000
Bug 1801695 - [devtools] Remove applySourceMap proxy in favor of an event. r=bomsy This will help get rid of the proxy entirely. Differential Revision: https://phabricator.services.mozilla.com/D162967
4d081dac3e319e5f202bc3a9f90514941a705a8c: Bug 1801695 - [devtools] Use regular devtools loader to load SourceMap modules. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 12 Dec 2022 13:15:52 +0000 - rev 645636
Push 40477 by smolnar@mozilla.com at Mon, 12 Dec 2022 21:52:29 +0000
Bug 1801695 - [devtools] Use regular devtools loader to load SourceMap modules. r=bomsy Now that source-map-loader uses ChromeLoader, it doesn't need to be loaded via the Browser Loader. It was mostly used to be able to access window.Worker symbol. It was also exposing `fetch` global symbol. DevTools Loader wasn't exposing it. I fixed that as this symbol is available in JSM/ESM. Differential Revision: https://phabricator.services.mozilla.com/D162966
03a9f2939f6343fdeee93af7588827dd001bd9e2: Bug 1801695 - [devtools] Store worker URL in their index.js module instead of callsite. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 12 Dec 2022 13:15:51 +0000 - rev 645635
Push 40477 by smolnar@mozilla.com at Mon, 12 Dec 2022 21:52:29 +0000
Bug 1801695 - [devtools] Store worker URL in their index.js module instead of callsite. r=bomsy This simplify the frontend code/callsites by not having to know where the worker file is. Differential Revision: https://phabricator.services.mozilla.com/D162965
b8008524891297d74c676e3fd2bc89cd4c7766e7: Bug 1801695 - [devtools] Use ChromeWorker for devtools frontend workers. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 12 Dec 2022 13:15:51 +0000 - rev 645634
Push 40477 by smolnar@mozilla.com at Mon, 12 Dec 2022 21:52:29 +0000
Bug 1801695 - [devtools] Use ChromeWorker for devtools frontend workers. r=bomsy This allows using a regular worker and no longer have to be related to any particular document. Differential Revision: https://phabricator.services.mozilla.com/D162964
ede7c4b9d0a611f924195535eeb993389c730e70: Bug 1804384 - [devtools] Fix indent of messages in warning group. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 09 Dec 2022 07:08:47 +0000 - rev 645170
Push 40467 by ctuns@mozilla.com at Fri, 09 Dec 2022 16:00:25 +0000
Bug 1804384 - [devtools] Fix indent of messages in warning group. r=bomsy. Differential Revision: https://phabricator.services.mozilla.com/D164044
2e7a46447741c83424c68a96d5c9de6deed6246f: Bug 1803538 - [devtools] Add scrollend in debugger event breakpoint panel. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 07 Dec 2022 06:38:40 +0000 - rev 644917
Push 40461 by imoraru@mozilla.com at Wed, 07 Dec 2022 16:54:36 +0000
Bug 1803538 - [devtools] Add scrollend in debugger event breakpoint panel. r=bomsy. The event is only supported when `apz.scrollend-event.content.enabled` is set to true, so we only show it in the debugger when it's supported. A test is added to ensure the event breakpoint does work as expected. Differential Revision: https://phabricator.services.mozilla.com/D163910
4da1d585bdd4fcb786f6cf3a7863b4eeb13ddc1f: Bug 1801621 - [devtools] Document source map requests module. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 24 Nov 2022 14:57:49 +0000 - rev 643494
Push 40429 by ncsoregi@mozilla.com at Thu, 24 Nov 2022 21:26:38 +0000
Bug 1801621 - [devtools] Document source map requests module. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D162566
8f14e58a69ef3188fc4ab141a01f9b176315e019: Bug 1801621 - [devtools] Remove useless createConsumer intermediate module. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 24 Nov 2022 14:57:49 +0000 - rev 643493
Push 40429 by ncsoregi@mozilla.com at Thu, 24 Nov 2022 21:26:38 +0000
Bug 1801621 - [devtools] Remove useless createConsumer intermediate module. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D162565
f4404985a73f3d86fafef4078667ffea10b2ada9: Bug 1801621 - [devtools] Avoid creating WorkerDispatch task on each worker method call. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 24 Nov 2022 14:57:48 +0000 - rev 643492
Push 40429 by ncsoregi@mozilla.com at Thu, 24 Nov 2022 21:26:38 +0000
Bug 1801621 - [devtools] Avoid creating WorkerDispatch task on each worker method call. r=bomsy WorkerDispatcher.invoke will instantiate a new "Task" method on each call. Ideally, we should only use WorkerDispatch.task(), unless the related method is called once. Differential Revision: https://phabricator.services.mozilla.com/D162564
5fd0a87551494ac1045ac84dafd4c5c64ef75be8: Bug 1801621 - [devtools] Remove unused getAllGeneratedLocations. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 24 Nov 2022 14:57:48 +0000 - rev 643491
Push 40429 by ncsoregi@mozilla.com at Thu, 24 Nov 2022 21:26:38 +0000
Bug 1801621 - [devtools] Remove unused getAllGeneratedLocations. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D162563
fc0821b249478b15de40c822b73115d6abcbcb41: Bug 1801621 - [devtools] Remove asset root setters. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 24 Nov 2022 14:57:48 +0000 - rev 643490
Push 40429 by ncsoregi@mozilla.com at Thu, 24 Nov 2022 21:26:38 +0000
Bug 1801621 - [devtools] Remove asset root setters. r=bomsy Instead we could always load the wasm file when the modules are loaded. Differential Revision: https://phabricator.services.mozilla.com/D162562
0f8489cd6fbed45cfafec4166622e2ccf21986a0: Bug 1800836 - [devtools] Stop passing the NetworkEvent owner to NetworkUtils.sys.mjs r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Tue, 22 Nov 2022 20:02:15 +0000 - rev 643241
Push 40424 by sstanca@mozilla.com at Wed, 23 Nov 2022 04:45:53 +0000
Bug 1800836 - [devtools] Stop passing the NetworkEvent owner to NetworkUtils.sys.mjs r=bomsy Depends on D162207 Differential Revision: https://phabricator.services.mozilla.com/D162208
a548d0e361049cbd298f8ec1154b64cd54c6c4f5: Bug 1800833 - [devtools] Notify about response cookies and headers from NetworkObserver directly r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Tue, 22 Nov 2022 20:02:15 +0000 - rev 643240
Push 40424 by sstanca@mozilla.com at Wed, 23 Nov 2022 04:45:53 +0000
Bug 1800833 - [devtools] Notify about response cookies and headers from NetworkObserver directly r=bomsy Depends on D162206 Differential Revision: https://phabricator.services.mozilla.com/D162207
05df30e6f7e940ce7fc138e0e3d27acf292a2e91: Bug 1800833 - [devtools] Clarify the content of networkObserver's openResponses r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Tue, 22 Nov 2022 20:02:15 +0000 - rev 643239
Push 40424 by sstanca@mozilla.com at Wed, 23 Nov 2022 04:45:53 +0000
Bug 1800833 - [devtools] Clarify the content of networkObserver's openResponses r=bomsy Depends on D162205 Differential Revision: https://phabricator.services.mozilla.com/D162206
b048606f56cd2850840c6e9c64130e1986c2dc37: Bug 1800838 - [devtools] Do not create new request blocking regexp for each and every channel r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Tue, 22 Nov 2022 20:02:14 +0000 - rev 643238
Push 40424 by sstanca@mozilla.com at Wed, 23 Nov 2022 04:45:53 +0000
Bug 1800838 - [devtools] Do not create new request blocking regexp for each and every channel r=bomsy Depends on D162204 Differential Revision: https://phabricator.services.mozilla.com/D162205
317936ce53cef665e40d44c57977292b2988a608: Bug 1800838 - [devtools] Request blocking should not be handled in the middle of NetworkEvent payload creation r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Tue, 22 Nov 2022 20:02:14 +0000 - rev 643237
Push 40424 by sstanca@mozilla.com at Wed, 23 Nov 2022 04:45:53 +0000
Bug 1800838 - [devtools] Request blocking should not be handled in the middle of NetworkEvent payload creation r=bomsy Depends on D162604 Differential Revision: https://phabricator.services.mozilla.com/D162204
d9a7d7c2d92dbc4f62d1b4cbc5c89252515fa686: Bug 1800838 - [devtools] Add shared helper for typing in netmonitor r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Tue, 22 Nov 2022 20:02:13 +0000 - rev 643236
Push 40424 by sstanca@mozilla.com at Wed, 23 Nov 2022 04:45:53 +0000
Bug 1800838 - [devtools] Add shared helper for typing in netmonitor r=bomsy This helper was duplicated in many tests. Differential Revision: https://phabricator.services.mozilla.com/D162604
a7400b45e2e4e6c9191b21e682f42812c7502904: Bug 1797785 - [devtools] Add tests for Network Observer r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Fri, 18 Nov 2022 15:52:05 +0000 - rev 642770
Push 40416 by ctuns@mozilla.com at Sat, 19 Nov 2022 08:58:28 +0000
Bug 1797785 - [devtools] Add tests for Network Observer r=bomsy Depends on D162193 This adds only very basic tests for the observer, but I would like to discuss about switching the API to a fully event-based solution. I initially decided against it because I didn't want to create unnecessary changes for DevTools, but in the end, the owner pattern is quite verbose if we want to use it for testing. Having events instead would make it more flexible, we could test only what we are interested in, with minimal overhead. If we agree on this, we can land those very simple tests and I can move on to change the API to use events and update the tests, before we add more tests. Differential Revision: https://phabricator.services.mozilla.com/D162195
6fe1a36f4c06c8b87274349dd892745ec6dd391f: Bug 1797785 - [devtools] Switch NetworkObserver constructor to named arguments r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Fri, 18 Nov 2022 15:52:04 +0000 - rev 642769
Push 40416 by ctuns@mozilla.com at Sat, 19 Nov 2022 08:58:28 +0000
Bug 1797785 - [devtools] Switch NetworkObserver constructor to named arguments r=bomsy While writing a test, I forgot that the filter function was an "ignore" function. Using named arguments should avoid this. Maybe we should consider using a regular filter approach (ie return true if we want to keep the request)? Differential Revision: https://phabricator.services.mozilla.com/D162193
df0eeb3b188811876a968a0ff78993aeeb22f619: Bug 1799831 - [devtools] Add test for netmonitor/src/components/request-details/CachePanel.js r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Tue, 15 Nov 2022 17:08:53 +0000 - rev 642469
Push 40408 by nfay@mozilla.com at Wed, 16 Nov 2022 09:31:06 +0000
Bug 1799831 - [devtools] Add test for netmonitor/src/components/request-details/CachePanel.js r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D161732
b0cc36adf93f693073378539cf723d3983b58f80: Bug 1653077 - Update top-padding of welcomebox so it looks more vertically centered in dock-to-bottom r=bomsy
htmlHxcker <clintonadeleke@gmail.com> - Tue, 15 Nov 2022 13:42:52 +0000 - rev 642444
Push 40406 by abutkovits@mozilla.com at Tue, 15 Nov 2022 16:44:51 +0000
Bug 1653077 - Update top-padding of welcomebox so it looks more vertically centered in dock-to-bottom r=bomsy Depends on D128204 Differential Revision: https://phabricator.services.mozilla.com/D128269