searching for reviewer(bomsy)
35f57736301fed1b7450a5919a6b474485f59802: Bug 1729553 - [devtools] Fallback on x86_64 adb binaries on Darwin + arm64 r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Wed, 22 Sep 2021 19:52:52 +0000 - rev 592972
Push 38816 by ccozmuta@mozilla.com at Thu, 23 Sep 2021 03:42:47 +0000
Bug 1729553 - [devtools] Fallback on x86_64 adb binaries on Darwin + arm64 r=bomsy We already fallback on x86 for aarch64 for adb binaries. Update this logic to also fallback on x86_64 for arm64. This will allow to support m1 apple machines. Differential Revision: https://phabricator.services.mozilla.com/D126314
8b2517d6c55f443ebcd5d3c8a1fb96acdd5cd257: Bug 1731954 - [devtools] Remove multiFrameQuerySelectorAll RDP method. r=bomsy,devtools-backward-compat-reviewers.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 22 Sep 2021 11:37:01 +0000 - rev 592926
Push 38814 by ctuns@mozilla.com at Wed, 22 Sep 2021 15:53:06 +0000
Bug 1731954 - [devtools] Remove multiFrameQuerySelectorAll RDP method. r=bomsy,devtools-backward-compat-reviewers. With Fission/EFT work, we shouldn't call this function, but rely on the different targets instead. It was only used in the client from a test, which could be migrated easily. (the test is still failing with EFT enabled, this will be taken care of in Bug 1730170) Differential Revision: https://phabricator.services.mozilla.com/D126315
7b38889adbb6beb41a0a6f1a96d0f256dccb60e7: Bug 1730159 - [devtools] Only match console messages of exact same window. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 21 Sep 2021 13:59:40 +0000 - rev 592647
Push 38811 by nbeleuzu@mozilla.com at Wed, 22 Sep 2021 04:09:13 +0000
Bug 1730159 - [devtools] Only match console messages of exact same window. r=bomsy. With dedicated targets for each window, we can now only check that the message originates from the target window, and not from its window tree Some tests that were assuming the iframe had the same target as the top level document are updated. Differential Revision: https://phabricator.services.mozilla.com/D125935
f2fc83728a24e8f3e1eede9ee621563ecaa22b04: Bug 1729255 - [devtools] Store JSON preferences as String instead of Char in PrefsHelper r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Fri, 17 Sep 2021 14:24:50 +0000 - rev 592317
Push 38798 by mlaza@mozilla.com at Fri, 17 Sep 2021 21:50:08 +0000
Bug 1729255 - [devtools] Store JSON preferences as String instead of Char in PrefsHelper r=bomsy JSON preferences used to be stored in string preferences, which is compatible with special characters. There should not be any data loss, char prefs seem to gracefully transition to string prefs. Differential Revision: https://phabricator.services.mozilla.com/D125877
af80802b2175be79c31c72bfcee813ebc4d46b1f: Bug 1730160 - [devtools] Filter content network event against exact target browsingContext/window when EFT is enabled. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 17 Sep 2021 13:15:44 +0000 - rev 592300
Push 38798 by mlaza@mozilla.com at Fri, 17 Sep 2021 21:50:08 +0000
Bug 1730160 - [devtools] Filter content network event against exact target browsingContext/window when EFT is enabled. r=bomsy. When we create targets for every frame, we need to tighten our different filters so requests/resources are duplicated (we would get them from both the top-level target as well as from their iframe). Differential Revision: https://phabricator.services.mozilla.com/D125810
f050e5cd7e81d415da53ca8179c447ecc0a9e932: Bug 1728974 - [devtools] Avoid exceptions when processing requests of tabs being closed. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 10 Sep 2021 11:40:17 +0000 - rev 591608
Push 38778 by imoraru@mozilla.com at Fri, 10 Sep 2021 21:18:00 +0000
Bug 1728974 - [devtools] Avoid exceptions when processing requests of tabs being closed. r=bomsy This doesn't reproduce easily. But you may see that while closing a youtube page while having the browser console opened. Differential Revision: https://phabricator.services.mozilla.com/D125124
c1ba43b65415d33eeb716a191c2bb8395aed6224: Bug 1439509 - [devtools] Clear network events when their related WindowGlobal is destroyed. r=bomsy,devtools-backward-compat-reviewers,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 07 Sep 2021 17:51:52 +0000 - rev 591220
Push 38771 by csabou@mozilla.com at Wed, 08 Sep 2021 03:24:17 +0000
Bug 1439509 - [devtools] Clear network events when their related WindowGlobal is destroyed. r=bomsy,devtools-backward-compat-reviewers,jdescottes The main challenge here is to still support persist-logs feature of the netmonitor. When this feature is enabled we have to keep around all the Network Events as before this patch. Fission refactoring and the migration to server side NETWORK_EVENT watchers made this fix significantly easier as we can now more easily reach out the parent process code which is keeping things allocated. Differential Revision: https://phabricator.services.mozilla.com/D124318
0581e2bb02c517ab36cdd6216ecb6688b4790863: Bug 1726037 - [devtools] Fix browser_jsterm_autocomplete_race_on_enter . r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 06 Sep 2021 12:48:40 +0000 - rev 591106
Push 38767 by ccozmuta@mozilla.com at Mon, 06 Sep 2021 21:42:43 +0000
Bug 1726037 - [devtools] Fix browser_jsterm_autocomplete_race_on_enter . r=bomsy. The test had a weird syntax which was preventing a Promise.all call to be actually completed. Fixing the syntax error showed a flaw in the test so it had to be fixed. Differential Revision: https://phabricator.services.mozilla.com/D124602
2e687cd1957e170c403fbd1f71b934eb802549e5: Bug 1725976 - [devtools] Wait for spawnViewportTask to resolve in browser_target_blank.js r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Mon, 06 Sep 2021 09:45:43 +0000 - rev 591080
Push 38767 by ccozmuta@mozilla.com at Mon, 06 Sep 2021 21:42:43 +0000
Bug 1725976 - [devtools] Wait for spawnViewportTask to resolve in browser_target_blank.js r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D124439
5efed90d556a7e468454a2b92d5729de670599c8: Bug 1358383 - [devtools] Adds a command history list. r=bomsy
Claudia <contatodaclau@gmail.com> - Thu, 02 Sep 2021 15:22:19 +0000 - rev 590822
Push 38757 by malexandru@mozilla.com at Fri, 03 Sep 2021 03:51:58 +0000
Bug 1358383 - [devtools] Adds a command history list. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D122264
a8c44ae830226d77c6a9d277d4e133cf276b8cd7: Bug 1728092 - [devtools] Use shared browserReload helper in most tests using browser.reload r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Thu, 02 Sep 2021 11:38:55 +0000 - rev 590799
Push 38757 by malexandru@mozilla.com at Fri, 03 Sep 2021 03:51:58 +0000
Bug 1728092 - [devtools] Use shared browserReload helper in most tests using browser.reload r=bomsy Depends on D124188 A few tests outside of the netmonitor also used tab.linkedBrowser.reload, let's migrate them at the same time. Differential Revision: https://phabricator.services.mozilla.com/D124190
98a89c0b759fe703efad5e9b2d2bfbf0dc4673cb: Bug 1728092 - [devtools] Wait properly for toolbox to completely load after a reload in netmonitor tests r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Thu, 02 Sep 2021 11:38:54 +0000 - rev 590798
Push 38757 by malexandru@mozilla.com at Fri, 03 Sep 2021 03:51:58 +0000
Bug 1728092 - [devtools] Wait properly for toolbox to completely load after a reload in netmonitor tests r=bomsy Depends on D124169 Differential Revision: https://phabricator.services.mozilla.com/D124188
0ef6e31f7f3541730be0c5ad7e275a4819c04c3b: Bug 1726238 - [devtools] Fix browser_toolbox_backward_forward_navigation.js intermittent failure. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 01 Sep 2021 08:30:23 +0000 - rev 590429
Push 38754 by smolnar@mozilla.com at Wed, 01 Sep 2021 15:51:13 +0000
Bug 1726238 - [devtools] Fix browser_toolbox_backward_forward_navigation.js intermittent failure. r=bomsy Inspector fronts initialization is still pending while we navigate away to another top target. Leading to various possible exception in protocol.js. I'm adding a set of new explicit exception in order to help debugging all these cases. Differential Revision: https://phabricator.services.mozilla.com/D123441
142afd30347981da51659456b4075f943380bc99: Bug 1727177 - [devtools] Fix devtools.netmonitor.saveRequestAndResponseBodies preference with new fission codepath. r=bomsy,devtools-backward-compat-reviewers
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 01 Sep 2021 08:30:22 +0000 - rev 590428
Push 38754 by smolnar@mozilla.com at Wed, 01 Sep 2021 15:51:13 +0000
Bug 1727177 - [devtools] Fix devtools.netmonitor.saveRequestAndResponseBodies preference with new fission codepath. r=bomsy,devtools-backward-compat-reviewers We weren't applying the preference to the parent process NetworkEventWatcher because we were only trying to update this via the WebConsole actor. In addition, this was introducing intermittent failures in browser_toolbox_frames_list.js because of the pending request made to the console actor. Doing only one unique request to NetworkEventParent helps reducing the number of requests and intermittents. Differential Revision: https://phabricator.services.mozilla.com/D123379
91a74d477f4c286d829385375ffbfb3804adba69: Bug 1728280 - [devtools] try preset is no longer running windows jobs r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Tue, 31 Aug 2021 15:22:54 +0000 - rev 590327
Push 38752 by malexandru@mozilla.com at Wed, 01 Sep 2021 03:48:05 +0000
Bug 1728280 - [devtools] try preset is no longer running windows jobs r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D124030
34d027f752eedfaa8b508d0a787b5f42a4cf7bbb: Bug 1503199 - [devtools] Increase min width for side panels in Inspector and Accessibility panels r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Mon, 30 Aug 2021 15:14:05 +0000 - rev 590205
Push 38748 by mlaza@mozilla.com at Tue, 31 Aug 2021 03:18:05 +0000
Bug 1503199 - [devtools] Increase min width for side panels in Inspector and Accessibility panels r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D123927
6f1a4e1b20b1f9a4a52d0863477393a28487c9ef: Bug 1727323 - [devtools] Enable bfcache in parent in tests that have been fixed thanks to server targets. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 25 Aug 2021 17:16:27 +0000 - rev 589920
Push 38736 by abutkovits@mozilla.com at Wed, 25 Aug 2021 21:49:19 +0000
Bug 1727323 - [devtools] Enable bfcache in parent in tests that have been fixed thanks to server targets. r=bomsy All these tests most likely have been fixed with the enabling of server targets. Because bfcache in parent was introducing more cross process navigations, being initiated from the server, having the support of server targets was uterly important to support bfcacheInParent. Differential Revision: https://phabricator.services.mozilla.com/D123448
319018ed0e22bb75569317c1d6aa41aaa4b60e1f: Bug 1727325 - [devtools] Enable all DevTools tests which now pass on Fission. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 25 Aug 2021 15:48:34 +0000 - rev 589915
Push 38736 by abutkovits@mozilla.com at Wed, 25 Aug 2021 21:49:19 +0000
Bug 1727325 - [devtools] Enable all DevTools tests which now pass on Fission. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D123452
c84a9cf277138e8bbd2496a497a9cf07478a2d81: Bug 1724002 - [devtools] Fix browser_toolbox_frames_list.js intermittent. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 25 Aug 2021 14:30:05 +0000 - rev 589903
Push 38736 by abutkovits@mozilla.com at Wed, 25 Aug 2021 21:49:19 +0000
Bug 1724002 - [devtools] Fix browser_toolbox_frames_list.js intermittent. r=bomsy We were having some race condition between calls using debounce and the other not using it. The check verify if the state changed prevented from updating the component correctly. So better always debounce and avoid doing any state check. Differential Revision: https://phabricator.services.mozilla.com/D123362
a2ddceb4895bbb56add6ceceacb1358b99c9b074: Bug 1726004 - [devtools] Remove backward compatibility code for descriptor reload r=bomsy,devtools-backward-compat-reviewers
Julian Descottes <jdescottes@mozilla.com> - Mon, 23 Aug 2021 07:59:09 +0000 - rev 589535
Push 38727 by apavel@mozilla.com at Mon, 23 Aug 2021 15:55:22 +0000
Bug 1726004 - [devtools] Remove backward compatibility code for descriptor reload r=bomsy,devtools-backward-compat-reviewers Depends on D122761 Differential Revision: https://phabricator.services.mozilla.com/D122762
0322c520d7c650475d68399bc9136d3c50f23e5f: Bug 1726002 - [devtools] Remove backward compatibility code about hasNativeConsoleAPI in dom-complete DOCUMENT_EVENT r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Mon, 23 Aug 2021 07:59:08 +0000 - rev 589534
Push 38727 by apavel@mozilla.com at Mon, 23 Aug 2021 15:55:22 +0000
Bug 1726002 - [devtools] Remove backward compatibility code about hasNativeConsoleAPI in dom-complete DOCUMENT_EVENT r=bomsy Depends on D122760 Differential Revision: https://phabricator.services.mozilla.com/D122761
c42ba64a2e6596bc109e409de83f9d4e8624567c: Bug 1726001 - [devtools] Remove backward compatibility code supportsDocumentEventWillNavigate r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Mon, 23 Aug 2021 07:59:08 +0000 - rev 589533
Push 38727 by apavel@mozilla.com at Mon, 23 Aug 2021 15:55:22 +0000
Bug 1726001 - [devtools] Remove backward compatibility code supportsDocumentEventWillNavigate r=bomsy Depends on D122759 Differential Revision: https://phabricator.services.mozilla.com/D122760
2d0bf65979467018d0677145d0f7f0287fbfca4b: Bug 1725999 - [devtools] Remove backward compatibility code for trait supportsThreadActorIsAttached r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Mon, 23 Aug 2021 07:59:08 +0000 - rev 589532
Push 38727 by apavel@mozilla.com at Mon, 23 Aug 2021 15:55:22 +0000
Bug 1725999 - [devtools] Remove backward compatibility code for trait supportsThreadActorIsAttached r=bomsy Depends on D122758 Differential Revision: https://phabricator.services.mozilla.com/D122759
3a76b7aa8eb541e504f49e01fdb6695bfca98f80: Bug 1725999 - [devtools] Remove backward compatibility code for ThreadConfigurationOptions r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Mon, 23 Aug 2021 07:59:07 +0000 - rev 589531
Push 38727 by apavel@mozilla.com at Mon, 23 Aug 2021 15:55:22 +0000
Bug 1725999 - [devtools] Remove backward compatibility code for ThreadConfigurationOptions r=bomsy Depends on D122751 Differential Revision: https://phabricator.services.mozilla.com/D122758
ceb98f750028bc18d9e9a3253b62e30d970b7f39: Bug 1725994 - [devtools] Remove backward compatibility code about javascriptEnabledHandledInParent r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Mon, 23 Aug 2021 07:59:07 +0000 - rev 589530
Push 38727 by apavel@mozilla.com at Mon, 23 Aug 2021 15:55:22 +0000
Bug 1725994 - [devtools] Remove backward compatibility code about javascriptEnabledHandledInParent r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D122751
c6a89e600c76c623e9ce84665666174859c6da26: Bug 1726248 - [devtools] Wait for source before reloading in browser_dbg-inline-cache.js. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 21 Aug 2021 09:44:04 +0000 - rev 589488
Push 38724 by apavel@mozilla.com at Sat, 21 Aug 2021 21:21:31 +0000
Bug 1726248 - [devtools] Wait for source before reloading in browser_dbg-inline-cache.js. r=bomsy Also use `refreshTab`, which better waits for full target switching. Differential Revision: https://phabricator.services.mozilla.com/D123051
ba789be08c4e596f7d615ddc6290afcebd0f7ca3: Bug 1726463 - [devtools] Avoid error in NodeFront remoteFrame() if devtools.browsertoolbox.fission=false r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Fri, 20 Aug 2021 08:33:59 +0000 - rev 589411
Push 38722 by mlaza@mozilla.com at Fri, 20 Aug 2021 21:33:13 +0000
Bug 1726463 - [devtools] Avoid error in NodeFront remoteFrame() if devtools.browsertoolbox.fission=false r=bomsy As explained in the bug, the test test_inspector-dead-nodes.html exercises an edge case which is probably irrelevant now. It aimed to check that you could call APIs on target scoped fronts during target reload. Eg, get the children of a node, while you reload a page. However with SSTS, we now destroy the target, so all fronts are destroyed. This test should probably be migrated to a commands test, and we should define what should be the behavior of such a command during reload. However in its current shape the test is doing the following: - get walkerFront1 and nodeFront1 for target1 - reload the page - wait for the new target target2 and get walkerFront2 - call walkerFront2.children(nodeFront1) - check there are no errors This call doesn't really make sense however. walkerFront2 and nodeFront1 are fronts from different targets and nodeFront1 is already destroyed. Here it happens to crash when trying to use a getter on nodeFront1 and it would be nicer to not throw anyway, hence the proposed fix. But the test should still be reviewed. Differential Revision: https://phabricator.services.mozilla.com/D123138
1a7dcc46bfc766c7ce3cda8b9b337f8db73670a8: Bug 1681892 - Remove defer usage in devtools/client/shared/test/shared-head.js r=bomsy
Sonia Singla <soniasingla.1812@gmail.com> - Wed, 18 Aug 2021 08:01:24 +0000 - rev 589191
Push 38716 by abutkovits@mozilla.com at Wed, 18 Aug 2021 15:53:06 +0000
Bug 1681892 - Remove defer usage in devtools/client/shared/test/shared-head.js r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D100475
659f053820bfb61ffef053723a9ead96fb3ac7ec: Bug 1724207 - [devtools] Skip browser_enable_devtools_popup_new_user.js on test-verify r=devtools-reviewers,bomsy
Julian Descottes <jdescottes@mozilla.com> - Tue, 17 Aug 2021 18:47:01 +0000 - rev 589136
Push 38714 by nbeleuzu@mozilla.com at Tue, 17 Aug 2021 21:49:10 +0000
Bug 1724207 - [devtools] Skip browser_enable_devtools_popup_new_user.js on test-verify r=devtools-reviewers,bomsy Differential Revision: https://phabricator.services.mozilla.com/D122855
62ee94c26f8f0e526f2d381b6c5ef50effef20ff: Bug 1702715 - [devtools] Enable server side target switching. r=bomsy,Honza,jdescottes,ladybenko.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 17 Aug 2021 18:15:15 +0000 - rev 589129
Push 38714 by nbeleuzu@mozilla.com at Tue, 17 Aug 2021 21:49:10 +0000
Bug 1702715 - [devtools] Enable server side target switching. r=bomsy,Honza,jdescottes,ladybenko. Differential Revision: https://phabricator.services.mozilla.com/D122327
c734901eec31cab5cff79a272e9e2f266232f58d: Bug 1702715 - [devtools] Enable server side target switching. r=bomsy,Honza,jdescottes,ladybenko.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 13 Aug 2021 16:43:02 +0000 - rev 588845
Push 38704 by nerli@mozilla.com at Fri, 13 Aug 2021 21:52:47 +0000
Bug 1702715 - [devtools] Enable server side target switching. r=bomsy,Honza,jdescottes,ladybenko. Differential Revision: https://phabricator.services.mozilla.com/D122327
1476f1e6d32c5c8811931a9709d0e2dde95c43f7: Bug 1725313 - [devtools] Fix browser_dbg-continue-to-here-click.js intermittent. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 12 Aug 2021 09:53:29 +0000 - rev 588642
Push 38699 by apavel@mozilla.com at Thu, 12 Aug 2021 16:01:16 +0000
Bug 1725313 - [devtools] Fix browser_dbg-continue-to-here-click.js intermittent. r=bomsy. Properly wait for paused (which includes waiting for the scopes panel to be fully loaded. Differential Revision: https://phabricator.services.mozilla.com/D122416
930d51b021dfc25b2d35b71d56f148d3c7e36a34: Bug 1710123 - [devtools] Fix browser_accessibility_reload.js intermittent. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 12 Aug 2021 05:34:25 +0000 - rev 588624
Push 38699 by apavel@mozilla.com at Thu, 12 Aug 2021 16:01:16 +0000
Bug 1710123 - [devtools] Fix browser_accessibility_reload.js intermittent. r=bomsy. The test wasn't waiting for the panel to be properly reloaded. Differential Revision: https://phabricator.services.mozilla.com/D122363
1e63ee8a68cc7b2261aaa37283125d69a57e1115: Bug 1479876 - [devtools] Fix browser_console_clear_cache.js intermittent. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 10 Aug 2021 05:16:01 +0000 - rev 588306
Push 38692 by apavel@mozilla.com at Tue, 10 Aug 2021 21:33:16 +0000
Bug 1479876 - [devtools] Fix browser_console_clear_cache.js intermittent. r=bomsy. Filter out buildin-modules.js messages. Differential Revision: https://phabricator.services.mozilla.com/D122095
84d67c4d9666b65158f4d98336bbba2e2fc63780: Bug 1722479 - [devtools] Fix browser_resources_thread_states.js with server targets. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 27 Jul 2021 15:10:34 +0000 - rev 586734
Push 38646 by malexandru@mozilla.com at Tue, 27 Jul 2021 21:40:00 +0000
Bug 1722479 - [devtools] Fix browser_resources_thread_states.js with server targets. r=bomsy We should now set breakpoints with thread configuration command, especially when any navigation/reload happen. Also, we should acknowledge that the threadFront may change on each navigation/reload. Differential Revision: https://phabricator.services.mozilla.com/D120948
c0ff235df051250281ac3e2baac56ea6662f1168: Bug 1721375 - [devtools] Remove WebConsoleFront getString method. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 21 Jul 2021 05:13:16 +0000 - rev 586277
Push 38631 by apavel@mozilla.com at Wed, 21 Jul 2021 21:26:17 +0000
Bug 1721375 - [devtools] Remove WebConsoleFront getString method. r=bomsy. The method isn't related to the webconsole actor, so we can remove it, and alongside with it, the longString method and _longStrings property which are no longer useful. The only customer of this switches to the shared `getLongStringFullText` method instead. Differential Revision: https://phabricator.services.mozilla.com/D120354
e30b2a84440d054b994292a4d59bab934c847867: Bug 1691575 - [devtools] Don't rely on webconsole fronts to fetch longStrings fullText. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 20 Jul 2021 15:20:11 +0000 - rev 586176
Push 38627 by smolnar@mozilla.com at Tue, 20 Jul 2021 21:56:01 +0000
Bug 1691575 - [devtools] Don't rely on webconsole fronts to fetch longStrings fullText. r=bomsy. The Netmonitor used to call the WebConsoleFront `getString` method to get the full text of a long string. This could make some test to fail with Fission and target switching. Since the webconsole actor is not even involved in the webconsole method, there's no reason to keep using it. A similar function is added into a util file; the only difference is that it doesn't cache the front it creates, which does not matter as the netmonitor only calls this once and then put the full text in its redux store. This allows us to re-enable `browser_ext_devtools_network.js` with Fission. Differential Revision: https://phabricator.services.mozilla.com/D120333
74727280ae7c83e0348a0a73cd349b7e9ea5c685: Bug 1689351 - [devtools] Fix browser_console_chrome_context_message.js intermittent. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 20 Jul 2021 14:35:33 +0000 - rev 586160
Push 38627 by smolnar@mozilla.com at Tue, 20 Jul 2021 21:56:01 +0000
Bug 1689351 - [devtools] Fix browser_console_chrome_context_message.js intermittent. r=bomsy. Focus the browser console before evaluating the expression. Differential Revision: https://phabricator.services.mozilla.com/D120213
9c579e2ce174b063bdba7b0a7d43896949c19822: Bug 1720512 - [devtools] Avoid storing and restoring broken breakpoints. r=jdescottes,bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 19 Jul 2021 15:30:34 +0000 - rev 585934
Push 38624 by nerli@mozilla.com at Mon, 19 Jul 2021 21:50:29 +0000
Bug 1720512 - [devtools] Avoid storing and restoring broken breakpoints. r=jdescottes,bomsy This is a bit surprising that broken breakpoints are stored as the frontend seems to try to do a couple of assertions: https://searchfox.org/mozilla-central/rev/c0fc8c4852e927b0ae75d893d35772b8c60ee06b/devtools/client/debugger/src/utils/breakpoint/index.js#84-106 But at least, now, we start using same assertions in both sides. Differential Revision: https://phabricator.services.mozilla.com/D120002
ba59a9897fba8a4396bbf32651e89dc913c069dd: Bug 1721126 - [devtools] Add Code Mirror HTTP mode in SourceEditor. r=bomsy,nchevobbe.
Fabien CASTERS <fabien@vaga.io> - Mon, 19 Jul 2021 07:25:02 +0000 - rev 585903
Push 38623 by abutkovits@mozilla.com at Mon, 19 Jul 2021 15:46:04 +0000
Bug 1721126 - [devtools] Add Code Mirror HTTP mode in SourceEditor. r=bomsy,nchevobbe. Differential Revision: https://phabricator.services.mozilla.com/D119904
1901ae10c819ac95f07508aaebb03e1f624089ac: Bug 1717893 - [devtools] Avoid blank inspector if iframe selector matches non-iframe element r=bomsy
Julian Descottes <jdescottes@mozilla.com> - Fri, 16 Jul 2021 15:04:58 +0000 - rev 585697
Push 38618 by apavel@mozilla.com at Fri, 16 Jul 2021 21:43:02 +0000
Bug 1717893 - [devtools] Avoid blank inspector if iframe selector matches non-iframe element r=bomsy Fix an edge case which can lead to an empty markup view after reload. Differential Revision: https://phabricator.services.mozilla.com/D119983
7bb80026b59983067ac1e4062f947c63980f85b2: Bug 1717005 - [devtools] Simplify nested event loop management. r=jdescottes,bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 12 Jul 2021 21:04:56 +0000 - rev 585332
Push 38609 by mlaza@mozilla.com at Tue, 13 Jul 2021 03:25:26 +0000
Bug 1717005 - [devtools] Simplify nested event loop management. r=jdescottes,bomsy Differential Revision: https://phabricator.services.mozilla.com/D118174
efab6db45952d7fd61fbf408f46387109f8c5e60: Bug 1717005 - [devtools] Stop using unsafeSynchronize. r=jdescottes,bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 12 Jul 2021 21:04:55 +0000 - rev 585331
Push 38609 by mlaza@mozilla.com at Tue, 13 Jul 2021 03:25:26 +0000
Bug 1717005 - [devtools] Stop using unsafeSynchronize. r=jdescottes,bomsy I don't think it was any useful to block synchronously on the call to `doResume`. In the past it used to send an event to the client synchronously, it may have been important back then. test_nesting-03.js is still covering nested event loop by using two clients. Differential Revision: https://phabricator.services.mozilla.com/D118173
69872e47dc732c8ba8008e1d3eb3d64a2b3acb91: Bug 1719835 - [devtools] Fix beta simulation perma fail on browser_webconsole_stubs_page_error.js. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 09 Jul 2021 15:13:07 +0000 - rev 585222
Push 38598 by ncsoregi@mozilla.com at Fri, 09 Jul 2021 21:40:06 +0000
Bug 1719835 - [devtools] Fix beta simulation perma fail on browser_webconsole_stubs_page_error.js. r=bomsy. The error message seems to be different in Nighly and Beta, but I wasn't able to find any pref that is driving this. Since the error message itself isn't super relevant, and given that we're at the end of the cycle, this patch is only modifying the expression so we get a different error. Differential Revision: https://phabricator.services.mozilla.com/D119520
654dd6f2e70c52b91ca64bc2ea9993453392e338: Bug 1710306 - [devtools] Fix missing scrollbar in webconsole network message response tab. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 09 Jul 2021 14:45:47 +0000 - rev 585218
Push 38598 by ncsoregi@mozilla.com at Fri, 09 Jul 2021 21:40:06 +0000
Bug 1710306 - [devtools] Fix missing scrollbar in webconsole network message response tab. r=bomsy. The selector that was used to not show toolbars in the console input was also matching the codeMirror instance in the network detail response tab. This is fixed by making the selector more specific. Differential Revision: https://phabricator.services.mozilla.com/D119192
acb06e9a8d78c587994862eb0484c8d91671898f: Bug 1712284 - [devtools] Display Error cause in Error rep. r=bomsy
nchevobbe <nchevobbe@mozilla.com> - Thu, 08 Jul 2021 06:56:40 +0000 - rev 585053
Push 38594 by smolnar@mozilla.com at Thu, 08 Jul 2021 15:46:14 +0000
Bug 1712284 - [devtools] Display Error cause in Error rep. r=bomsy Depends on D119055 Differential Revision: https://phabricator.services.mozilla.com/D119056
08175e3ac4ca00808f77dd4f7a7e4136b2ffce9a: Bug 1712284 - [devtools] Include cause property in Error preview grip. r=bomsy.
nchevobbe <nchevobbe@mozilla.com> - Thu, 08 Jul 2021 06:56:39 +0000 - rev 585052
Push 38594 by smolnar@mozilla.com at Thu, 08 Jul 2021 15:46:14 +0000
Bug 1712284 - [devtools] Include cause property in Error preview grip. r=bomsy. Differential Revision: https://phabricator.services.mozilla.com/D119055
8ca067484bdf7e34af02b1479db69d99a7376173: Bug 1719248 - [devtools] Better handle actorIDs in webconsole stubs. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 07 Jul 2021 15:28:51 +0000 - rev 584993
Push 38591 by mlaza@mozilla.com at Wed, 07 Jul 2021 21:52:19 +0000
Bug 1719248 - [devtools] Better handle actorIDs in webconsole stubs. r=bomsy. Instead of manually replacing actorIDs in `getCleanedPacket`, we're introducing a `replaceActorIds` option to `getSerializedPacket` that will replace all actorIDs occurences with a fake one. That way, we won't have to modify `getCleanedPacket` each time a new property is added on a grip. Depends on D119096 Differential Revision: https://phabricator.services.mozilla.com/D119167
351eb799541ab17d179f8e483ddce3e233af36e4: Bug 1718038 - [devtools] Pass the correct target to scriptCommand#execute when a specific thread is selected in the debugger. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 06 Jul 2021 14:08:33 +0000 - rev 584841
Push 38588 by apavel@mozilla.com at Tue, 06 Jul 2021 21:42:42 +0000
Bug 1718038 - [devtools] Pass the correct target to scriptCommand#execute when a specific thread is selected in the debugger. r=bomsy. A test is added to ensure this works as expected. We take this opportunity to create a `getWatchExpressionValue` test helper and use it in the different test that were having a similar function. Differential Revision: https://phabricator.services.mozilla.com/D119060
e555b9256f7f42631208f83a912882cc186e8447: Bug 1717052 - [devtools] Instantiate FirefoxDataProvider only once. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 23 Jun 2021 13:01:09 +0000 - rev 584137
Push 38560 by dluca@mozilla.com at Wed, 23 Jun 2021 21:45:52 +0000
Bug 1717052 - [devtools] Instantiate FirefoxDataProvider only once. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D118196