searching for reviewer(bomsy)
9a188205b2cb5706e118493bcf2ac91c951e03f4: Bug 1783813 - [devtools] Unify debugger initialization and thread selection. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 17 Aug 2022 16:13:35 +0000 - rev 627508
Push 40142 by mlaza@mozilla.com at Thu, 18 Aug 2022 03:53:41 +0000
Bug 1783813 - [devtools] Unify debugger initialization and thread selection. r=bomsy We are updating more things when selecting a thread than when opening the debugger. Let's use a unique codepath when it comes to handle a new top level target. Differential Revision: https://phabricator.services.mozilla.com/D151552
febe00b2cc21be2dd6a7c825b2d09edfdb087e4a: Bug 1784520 - Mark browser_accessibility_relation_navigation.js as passing on a11y-checks after being fixed in bug 1688007. r=jdescottes,bomsy DONTBUILD
Cosmin Sabou <csabou@mozilla.com> - Wed, 17 Aug 2022 02:36:02 +0000 - rev 627445
Push 40139 by csabou@mozilla.com at Wed, 17 Aug 2022 09:10:29 +0000
Bug 1784520 - Mark browser_accessibility_relation_navigation.js as passing on a11y-checks after being fixed in bug 1688007. r=jdescottes,bomsy DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D154598
6371eafaa8a220363d8c86bb31222e5495e37a58: Bug 1764248 - Add composition event-listener breakpoints r=bomsy
Luke Swiderski <luke.swiderski@gmail.com> - Mon, 15 Aug 2022 06:42:00 +0000 - rev 627128
Push 40129 by mlaza@mozilla.com at Mon, 15 Aug 2022 09:42:32 +0000
Bug 1764248 - Add composition event-listener breakpoints r=bomsy Add compositionstart, compositionupdate and compositionend to keyboard event-listener-breakpoints. Add mochitests for each. Add comment to mochitest. Differential Revision: https://phabricator.services.mozilla.com/D153627
0fc253d09aabe1988c971eaf8aa35b65d14122c8: Bug 1784073 - [devtools] Fix ESLint consistent-return failures in devtools/client/debugger/src/utils/. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 12 Aug 2022 07:00:36 +0000 - rev 626938
Push 40117 by csabou@mozilla.com at Fri, 12 Aug 2022 15:41:54 +0000
Bug 1784073 - [devtools] Fix ESLint consistent-return failures in devtools/client/debugger/src/utils/. r=bomsy. Depends on D154244 Differential Revision: https://phabricator.services.mozilla.com/D154245
67800bf848d1738f07e2025d24aa05d04cafda10: Bug 1784071 - [devtools] Remove debugger specific eslint override for consistent-return rule. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 12 Aug 2022 07:00:36 +0000 - rev 626937
Push 40117 by csabou@mozilla.com at Fri, 12 Aug 2022 15:41:54 +0000
Bug 1784071 - [devtools] Remove debugger specific eslint override for consistent-return rule. r=bomsy. Instead, we put all the failing file into devtools eslintrc.js. Differential Revision: https://phabricator.services.mozilla.com/D154244
7fbc69cd1c9f7761d9643e88833f3a36b6532f5c: Bug 1779284 - [devtools] Stop maintaining a duplicate of the target list in the debugger frontend. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 11 Aug 2022 15:05:41 +0000 - rev 626863
Push 40116 by smolnar@mozilla.com at Fri, 12 Aug 2022 09:37:14 +0000
Bug 1779284 - [devtools] Stop maintaining a duplicate of the target list in the debugger frontend. r=bomsy Instead we can fully rely on TargetCommand. This fixes duplicated calls made to top level thread actor. This was only happening with toolbox not using the Watcher Actor. i.e. the non-multiprocess Browser Toolbox, Browser Content Toolbox and may be worker toolboxes from about:debugging. Differential Revision: https://phabricator.services.mozilla.com/D151643
e9bd0a704230ddc9da6cded3f4ec607b3ecadced: Bug 1782364 - [devtools] Test files with encoded characters in the debugger. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 11 Aug 2022 15:01:49 +0000 - rev 626862
Push 40116 by smolnar@mozilla.com at Fri, 12 Aug 2022 09:37:14 +0000
Bug 1782364 - [devtools] Test files with encoded characters in the debugger. r=bomsy This at least ensure that the sources display with the right display in the Source Tree. Differential Revision: https://phabricator.services.mozilla.com/D154082
42d1bbb01a6223e4d0d56b363ccb9c6d3b2f7d91: Bug 1775503 - [devtools] Prevent showing content process request when the browser toolbox focuses on the parent process. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 10 Aug 2022 20:18:02 +0000 - rev 626777
Push 40113 by ctuns@mozilla.com at Thu, 11 Aug 2022 09:40:15 +0000
Bug 1775503 - [devtools] Prevent showing content process request when the browser toolbox focuses on the parent process. r=bomsy This is still one blind spot with privileged request done by content processes. They aren't related to any BrowsingContext/WindowGlobal and there isn't any attribute on channel/loadInfo which helps knowing they originates from a content process. Differential Revision: https://phabricator.services.mozilla.com/D150014
e10a322d193af4afd8bbca4a263cf0ec3dcbb796: Bug 1782904 - [devtools] Fix browser_resources_console_messages with --verify. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 04 Aug 2022 09:57:09 +0000 - rev 626168
Push 40083 by ncsoregi@mozilla.com at Thu, 04 Aug 2022 15:43:32 +0000
Bug 1782904 - [devtools] Fix browser_resources_console_messages with --verify. r=bomsy. The test is failing when running multiple times, as we get cached messages from previous test run. We suffix the message with a timestamp to avoid this. Differential Revision: https://phabricator.services.mozilla.com/D153719
aa3c49b93ea295088d1a7dcc79e6a63eb64ee045: Bug 1782916 - [devtools] Remove backward-compatibility code for clearResource. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 04 Aug 2022 09:31:26 +0000 - rev 626165
Push 40083 by ncsoregi@mozilla.com at Thu, 04 Aug 2022 15:43:32 +0000
Bug 1782916 - [devtools] Remove backward-compatibility code for clearResource. r=bomsy. Differential Revision: https://phabricator.services.mozilla.com/D153598
3f3a9b9e332ef147cf4e527d8374270049af773f: Bug 1777203 - [devtools] Migrate SourceTree to be based on source actors. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 26 Jul 2022 08:53:07 +0000 - rev 625137
Push 40037 by nfay@mozilla.com at Tue, 26 Jul 2022 15:39:15 +0000
Bug 1777203 - [devtools] Migrate SourceTree to be based on source actors. r=bomsy This doesn't change anything. It actually complexify things a bit. But this will be an helpful change we can do right away in order to help create a unique Source object per URL (instead of per URL and target). Differential Revision: https://phabricator.services.mozilla.com/D151553
0aef155c8e555f6857a1b8468f853a91efd7363e: Bug 1777203 - [devtools] Generate SourceTree data directly from the selectors. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 26 Jul 2022 08:53:07 +0000 - rev 625136
Push 40037 by nfay@mozilla.com at Tue, 26 Jul 2022 15:39:15 +0000
Bug 1777203 - [devtools] Generate SourceTree data directly from the selectors. r=bomsy This introduces a new reducer in order to maintain a Source Tree data structure. A Source Tree is composed of: * Thread Items To designate targets/threads. These are the roots of the Tree if no project directory is selected. * Group Items To designates the different domains used in the website. These are direct children of threads and may contain directory or source items. * Directory Items To designate all the folders. Note that each every folder has an items. The Source Tree React component is doing the magic to coallesce folders made of only one sub folder. * Source Items To designate sources. They are the leaves of the Tree. (we should not have empty directories.) See the creation methods in the reducer to see the various attributes available on each Item type. Project root implementation has been simplified, but there is still subtantial complexity around it. Also, there is a behavior change. Now the project root is thread specific, whereas before it could be per domain/URL across threads. The complexity of it is around preserving the `uniquePath` across reloads. Because uniquePath starts with the thread actor ID, it can't be preserved across reload. Instead, we replace the thread actor ID with "top-level" string. This means that project root isn't preserved across reload for non-top-level targets. About `uniquePath` attribute available on all items, this will be the Path in ManagedTree and Key in Tree components. i.e. a unique identifier for any item in the Tree. The isWebExtension check is simplified to fetch it from the thread object, instead of having to involve the "CONNECT" action. Depends on D151467 Differential Revision: https://phabricator.services.mozilla.com/D150548
7249cbd736d79181c84b42f8099c866cae22feec: Bug 1590653 - Fixed/improved alignment of "Learn more about performance" button with cache headers r=bomsy
Daniel Q <danielqeli1@gmail.com> - Mon, 25 Jul 2022 07:07:12 +0000 - rev 625003
Push 40033 by smolnar@mozilla.com at Mon, 25 Jul 2022 21:32:09 +0000
Bug 1590653 - Fixed/improved alignment of "Learn more about performance" button with cache headers r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D150919
37303c893916a4e098192331d700e2715f28f58e: Bug 1770361 - [devtools] Resume when the currently paused thread is destroyed. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 21 Jul 2022 21:46:03 +0000 - rev 624819
Push 40014 by abutkovits@mozilla.com at Fri, 22 Jul 2022 03:25:11 +0000
Bug 1770361 - [devtools] Resume when the currently paused thread is destroyed. r=bomsy Depends on D149361 Differential Revision: https://phabricator.services.mozilla.com/D146890
fb3ef8a93a1a393ba3de69643af1a23d6424d297: Bug 1777249 - [devtools] Create CSS variable for alternate element background instead of abusing --theme-selection-background-hover. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 21 Jul 2022 05:36:40 +0000 - rev 624715
Push 40011 by mlaza@mozilla.com at Thu, 21 Jul 2022 15:47:47 +0000
Bug 1777249 - [devtools] Create CSS variable for alternate element background instead of abusing --theme-selection-background-hover. r=bomsy. In a few places we were using the variable to have a different background than the ones we have everywhere (blueish on light theme, dark-grey blue in dark mode). In order to avoid any confusion, this patch adds a dedicated variable with a name that should be more explicit. Differential Revision: https://phabricator.services.mozilla.com/D150574
3c37b03ac903ececb8c18258acd33a159a7aeede: Bug 1778947 - [devtools] Compute source file extension once in its displayURL. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 20 Jul 2022 14:25:02 +0000 - rev 624517
Push 40007 by smolnar@mozilla.com at Wed, 20 Jul 2022 21:52:02 +0000
Bug 1778947 - [devtools] Compute source file extension once in its displayURL. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D151467
2d6c5856e64c6659640a4e50ca4a64f939c89706: Bug 1779847 - [devtools] Add chromeContext property to logPoint messages. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 20 Jul 2022 05:26:57 +0000 - rev 624455
Push 40007 by smolnar@mozilla.com at Wed, 20 Jul 2022 21:52:02 +0000
Bug 1779847 - [devtools] Add chromeContext property to logPoint messages. r=bomsy. We only set it to true if the target the breakpoint was hit in is a parent process target, which should be enough. Differential Revision: https://phabricator.services.mozilla.com/D152018
f76c19fdf908ba201540548c92e28edc50769837: Bug 1779966 - [devtools] Fix showing sources in quick open modal when we reach the max results limit. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 19 Jul 2022 20:35:24 +0000 - rev 624414
Push 40005 by ncsoregi@mozilla.com at Wed, 20 Jul 2022 09:59:35 +0000
Bug 1779966 - [devtools] Fix showing sources in quick open modal when we reach the max results limit. r=bomsy Unfortunately, we filter out sources *after* having formated them. So we can avoid formatting all the sources here. I haven't investigated, but it would be nice to be able to filter out the sources before formating them. Differential Revision: https://phabricator.services.mozilla.com/D152014
6040e53370dce5879930402475b818d0589bb53a: Bug 1777249 - [devtools] Create CSS variable for alternate element background instead of abusing --theme-selection-background-hover. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 19 Jul 2022 14:02:59 +0000 - rev 624367
Push 40003 by ctuns@mozilla.com at Tue, 19 Jul 2022 21:35:33 +0000
Bug 1777249 - [devtools] Create CSS variable for alternate element background instead of abusing --theme-selection-background-hover. r=bomsy. In a few places we were using the variable to have a different background than the ones we have everywhere (blueish on light theme, dark-grey blue in dark mode). In order to avoid any confusion, this patch adds a dedicated variable with a name that should be more explicit. Differential Revision: https://phabricator.services.mozilla.com/D150574
8e28cece988b96515c629a38d55b3523ef74d14e: Bug 1779972 - [devtools] Force edit and resend panel lines on a single line when not editing r=bomsy,nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Mon, 18 Jul 2022 15:12:29 +0000 - rev 624281
Push 40001 by abutkovits@mozilla.com at Tue, 19 Jul 2022 09:34:24 +0000
Bug 1779972 - [devtools] Force edit and resend panel lines on a single line when not editing r=bomsy,nchevobbe Each line of the edit and resend panel should no longer grow when resizing the panel But when editing, we fallback to multiline Differential Revision: https://phabricator.services.mozilla.com/D152006
445cd004a4228df0a33898514edb3be98038b2fb: Bug 1779164 - [devtools] Don't override CodeMirror search UI in netmonitor response panel. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 13 Jul 2022 08:09:23 +0000 - rev 623716
Push 39976 by csabou@mozilla.com at Wed, 13 Jul 2022 15:12:33 +0000
Bug 1779164 - [devtools] Don't override CodeMirror search UI in netmonitor response panel. r=bomsy. Differential Revision: https://phabricator.services.mozilla.com/D151577
ac6b6390147e4728ed0282c185730aa574145f29: Bug 1779164 - [devtools] Don't override CodeMirror search UI in netmonitor response panel. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 12 Jul 2022 13:32:46 +0000 - rev 623657
Push 39973 by ncsoregi@mozilla.com at Wed, 13 Jul 2022 03:48:16 +0000
Bug 1779164 - [devtools] Don't override CodeMirror search UI in netmonitor response panel. r=bomsy. Differential Revision: https://phabricator.services.mozilla.com/D151577
da2dde196383b491d169657bc98a645f61f18dd6: Bug 1778647 - [devtools] Store source's framework only once, in symbols. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 12 Jul 2022 11:55:43 +0000 - rev 623642
Push 39973 by ncsoregi@mozilla.com at Wed, 13 Jul 2022 03:48:16 +0000
Bug 1778647 - [devtools] Store source's framework only once, in symbols. r=bomsy We are currently duplicated source's framework in symbols and tabs reducers. This is uncessary and confusing. And this possibly lead to more state/component updates. This is mostly used to computed the source icon. I extented test coverage to better cover the behavior of SourceIcon, while simplifying a few things around this component by unifying the various places where we compute the final icon, so that now it is only done by getSourceClassnames and modifier. Differential Revision: https://phabricator.services.mozilla.com/D151358
cb5dc073b7e467e0f9df66154af84b5b76e87e9a: Bug 1778514 - [devtools] Avoid mutating source objects because of relative url computation. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 12 Jul 2022 11:55:43 +0000 - rev 623641
Push 39973 by ncsoregi@mozilla.com at Wed, 13 Jul 2022 03:48:16 +0000
Bug 1778514 - [devtools] Avoid mutating source objects because of relative url computation. r=bomsy While I'm around QuickOpen modal, I also cleanup a few things around formatSources and avoid computing more formatting than what the modal will display. Differential Revision: https://phabricator.services.mozilla.com/D151285
989493a956be106e5baeb6d27286000cbc474422: Bug 1778078 - [devtools] Move blackbox state to a dedicated reducer and selectors. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 12 Jul 2022 11:55:42 +0000 - rev 623640
Push 39973 by ncsoregi@mozilla.com at Wed, 13 Jul 2022 03:48:16 +0000
Bug 1778078 - [devtools] Move blackbox state to a dedicated reducer and selectors. r=bomsy This allows to make the reducer Source object fully immutable. `isBlackBoxed` was the last mutable attribute of it. Doing this help pass along source object without having to care if it will ever update. This should also help reduce the number of unecessary update to components which manipulate sources but ignore their blackbox state. Differential Revision: https://phabricator.services.mozilla.com/D151005
3ea5307a81e2298135b5cc681fc52f8504494d40: Bug 1772124 - [devtools] Remove extra console.log in devtools/server/actors/network-monitor/network-observer.js r=devtools-reviewers,bomsy
Julian Descottes <jdescottes@mozilla.com> - Tue, 12 Jul 2022 10:57:15 +0000 - rev 623633
Push 39972 by imoraru@mozilla.com at Tue, 12 Jul 2022 21:56:41 +0000
Bug 1772124 - [devtools] Remove extra console.log in devtools/server/actors/network-monitor/network-observer.js r=devtools-reviewers,bomsy Differential Revision: https://phabricator.services.mozilla.com/D151589
fe74688963bb19ad21e39df90c432ff7da0a80a0: Bug 1759458 - [devtools] Make Netmonitor Clear/Send buttons always visible. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 08 Jul 2022 09:47:14 +0000 - rev 623311
Push 39954 by smolnar@mozilla.com at Fri, 08 Jul 2022 16:06:06 +0000
Bug 1759458 - [devtools] Make Netmonitor Clear/Send buttons always visible. r=bomsy. The container is turned into a footer and moved outside of its current parent so it always stick to the bottom. CSS was tweaked to keep it nice. Differential Revision: https://phabricator.services.mozilla.com/D151284
31339d0d49f14b5b3d205e5435ac495644218536: Bug 1775295 - Fix browser_browser_toolbox_netmonitor.js intermittent. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 06 Jul 2022 09:16:26 +0000 - rev 623106
Push 39943 by nbeleuzu@mozilla.com at Wed, 06 Jul 2022 15:15:42 +0000
Bug 1775295 - Fix browser_browser_toolbox_netmonitor.js intermittent. r=bomsy. The test seemed to fail because the browsers was firing requests we weren't expecting. To fix this, we set a few preferences that should prevent such requests to be made. Differential Revision: https://phabricator.services.mozilla.com/D150953
5aafa37a32dfc5e079e38069c91c8bfbb448b4d8: Bug 1777459 - [devtools] Set final group name for Webpack and Angular sources. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 05 Jul 2022 12:26:10 +0000 - rev 623044
Push 39940 by nfay@mozilla.com at Tue, 05 Jul 2022 21:28:56 +0000
Bug 1777459 - [devtools] Set final group name for Webpack and Angular sources. r=bomsy See previous changeset. This applies the same simplification for Webpack and Angular groups. Differential Revision: https://phabricator.services.mozilla.com/D150746
45d819e92f32691e279c5993cc1d2652f063b457: Bug 1777459 - [devtools] Simplify code to show extension name in SourceTree groups. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 05 Jul 2022 12:26:10 +0000 - rev 623043
Push 39940 by nfay@mozilla.com at Tue, 05 Jul 2022 21:28:56 +0000
Bug 1777459 - [devtools] Simplify code to show extension name in SourceTree groups. r=bomsy The "group" is defined by getDisplayURL method. Instead of modifying late in the UI, we should rather set it to the right value upfront. Also avoid computing `extensionName` from the actor when the URL isn't an extension one. Differential Revision: https://phabricator.services.mozilla.com/D150745
0e4a2312afb782ef7f472d8f5109fb03eee16b39: Bug 1775295 - Fix browser_browser_toolbox_netmonitor.js intermittent. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 05 Jul 2022 07:22:36 +0000 - rev 622971
Push 39938 by imoraru@mozilla.com at Tue, 05 Jul 2022 15:54:46 +0000
Bug 1775295 - Fix browser_browser_toolbox_netmonitor.js intermittent. r=bomsy. The test seemed to fail because the browsers was firing requests we weren't expecting. To fix this, we set a few preferences that should prevent such requests to be made. Differential Revision: https://phabricator.services.mozilla.com/D150953
528a8b3f69829ff241c5e9f30c2b3624c9f13a90: Bug 1777790 - Fixed typo "PATH" to "PATCH" in http custom request panel drop down list. r=bomsy
Daniel Q <danielqeli1@gmail.com> - Mon, 04 Jul 2022 08:07:59 +0000 - rev 622876
Push 39935 by ctuns@mozilla.com at Mon, 04 Jul 2022 21:42:52 +0000
Bug 1777790 - Fixed typo "PATH" to "PATCH" in http custom request panel drop down list. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D150886
559f72945cbdaf1e9bbb4671baa4391801fd9652: Bug 1777215 - [devtools] Avoid expanding the tree manually in browser_browser_toolbox_debugger.js r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 30 Jun 2022 18:31:40 +0000 - rev 622761
Push 39921 by smolnar@mozilla.com at Fri, 01 Jul 2022 04:18:35 +0000
Bug 1777215 - [devtools] Avoid expanding the tree manually in browser_browser_toolbox_debugger.js r=bomsy In the following patches, this test started failing because of some race condition between the test trying to expand the tree and selectSource also trying to expand the tree. We ended up we the tree being collapsed. We no longer have to manually expand the tree as selectSource will now do it. Differential Revision: https://phabricator.services.mozilla.com/D150547
3de877e45389f1d7f55767eed65624e12a2f09ec: Bug 1777215 - [devtools] Avoid changing expanded state if it didn't change. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 30 Jun 2022 18:31:39 +0000 - rev 622760
Push 39921 by smolnar@mozilla.com at Fri, 01 Jul 2022 04:18:35 +0000
Bug 1777215 - [devtools] Avoid changing expanded state if it didn't change. r=bomsy This was causing infinite look in my following patches. I don't get why this wasn't an issue before, but it sounds good doing to avoid unecessary component updates. Differential Revision: https://phabricator.services.mozilla.com/D150546
3423a6a1b26ae575f6ee1a35a39e3042c429aa2d: Bug 1777211 - [devtools] Fix alignement of sub folders when picking a project root. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 30 Jun 2022 18:31:39 +0000 - rev 622759
Push 39921 by smolnar@mozilla.com at Fri, 01 Jul 2022 04:18:35 +0000
Bug 1777211 - [devtools] Fix alignement of sub folders when picking a project root. r=bomsy This css rules comes from ancient time and couldn't find the reason why this was added. This is actually the immediate children of the project root which are misaligned. That get an extra padding that make them look like they are in a sub folder. I do not see the value of adding an extra padding. We still have some margin even after removing it. Differential Revision: https://phabricator.services.mozilla.com/D150545
cc98e1453316606c9b21328e5e1c44f714999a56: Bug 1777280 - [devtools] Compute displayURL for each source only once. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 30 Jun 2022 18:31:38 +0000 - rev 622758
Push 39921 by smolnar@mozilla.com at Fri, 01 Jul 2022 04:18:35 +0000
Bug 1777280 - [devtools] Compute displayURL for each source only once. r=bomsy By moving the computation of displayURL from the SourceTree selector to the sources reducer, we ensure computing it only once. We could also get rid of all the redundant getURL usages. Note that we were never defaulting to mainThreadHost in getDisplayURL, nor were we having any source with a false "group". So we could simplify the logic a bit. Differential Revision: https://phabricator.services.mozilla.com/D150608
1261b8b41f963cd6b7b775cd1b2ff9eec2bb9513: Bug 1775302 - [devtools] Avoid unnecessary updates to DebugLine when the source text is loading. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 27 Jun 2022 14:03:21 +0000 - rev 622151
Push 39908 by imoraru@mozilla.com at Mon, 27 Jun 2022 21:50:36 +0000
Bug 1775302 - [devtools] Avoid unnecessary updates to DebugLine when the source text is loading. r=bomsy We get some intermediate state update when sourceTextContent is loading. The goal is to reduce the calls to any CodeMirror API. Differential Revision: https://phabricator.services.mozilla.com/D149896
097f2369f88eec47e8f3ee55faf373e24b53df56: Bug 1775302 - [devtools] Remove WebReplay leftover "preview paused location". r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 27 Jun 2022 14:03:21 +0000 - rev 622150
Push 39908 by imoraru@mozilla.com at Mon, 27 Jun 2022 21:50:36 +0000
Bug 1775302 - [devtools] Remove WebReplay leftover "preview paused location". r=bomsy Also stop passing `frame` to DebugLine which wasn't using this attribute. This might prevent unnecessary component updates. Differential Revision: https://phabricator.services.mozilla.com/D149895
2513e734d3b5cce2d851f7c30e5a6d8025054e9d: Bug 1775252 - [devtools] Avoid uncessary frame update on FETCH_FRAMES action. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 27 Jun 2022 14:03:20 +0000 - rev 622149
Push 39908 by imoraru@mozilla.com at Mon, 27 Jun 2022 21:50:36 +0000
Bug 1775252 - [devtools] Avoid uncessary frame update on FETCH_FRAMES action. r=bomsy We typically dispatch a PAUSED actions, with only the first frames, and later dispatch FETCHED_FRAMES, with the full list of frames. Avoid modifying the first one, which is typically the selected one in order to avoid uncessary state changes. Differential Revision: https://phabricator.services.mozilla.com/D149879
485c98c274d31a9f7965cc01e8a4f22bddef9a22: Bug 1775203 - [devtools] Unify code around getSymbols method. r=bomsy,perftest-reviewers,davehunt
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 27 Jun 2022 14:03:20 +0000 - rev 622148
Push 39908 by imoraru@mozilla.com at Mon, 27 Jun 2022 21:50:36 +0000
Bug 1775203 - [devtools] Unify code around getSymbols method. r=bomsy,perftest-reviewers,davehunt Now that we no longer have the intermediate "loading" object, we can simplify the code checking for loading symbols by checking if symbols are defined. Differential Revision: https://phabricator.services.mozilla.com/D149856
1574d614ce48493f3cfa7f13344f47fc0d0c92c2: Bug 1775203 - [devtools] Remove "loading" state of symbols state object. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 27 Jun 2022 14:03:20 +0000 - rev 622147
Push 39908 by imoraru@mozilla.com at Mon, 27 Jun 2022 21:50:36 +0000
Bug 1775203 - [devtools] Remove "loading" state of symbols state object. r=bomsy This helps reduce the number of state changes and the number of renders. We now switch from null symbols which means they are loading, to an object with the loaded symbols. Differential Revision: https://phabricator.services.mozilla.com/D149855
5c1bb0a12baadf9241e770ccf431c98c25120748: Bug 1775200 - [devtools] Avoid updating CodeMirror unless it is strictly necessary. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 27 Jun 2022 14:03:19 +0000 - rev 622146
Push 39908 by imoraru@mozilla.com at Mon, 27 Jun 2022 21:50:36 +0000
Bug 1775200 - [devtools] Avoid updating CodeMirror unless it is strictly necessary. r=bomsy There is many props that are only relevant to the children components, and we were calling expensive CodeMirror method on any prop change. Differential Revision: https://phabricator.services.mozilla.com/D149853
95732dfc89398262dccc6cf9054f19a0785cf525: Bug 1774583 - [devtools] Prevent clearing tab list when a target is destroyed. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Jun 2022 20:12:43 +0000 - rev 621806
Push 39885 by nfay@mozilla.com at Thu, 23 Jun 2022 03:54:50 +0000
Bug 1774583 - [devtools] Prevent clearing tab list when a target is destroyed. r=bomsy persistTabs should only be used when we want to clear the tabs list and have the persisted tab to be re-created (made visible, with a sourceId) when a new source matching the same url is created. Also cleanup a few things and avoid returning new state objects unless we really changed something. Differential Revision: https://phabricator.services.mozilla.com/D149523
42d656b1fdf09418599167aa562cd6c74ae86b80: Bug 1767702 - [devtools] Split browser_dbg-features-source-tree.js and re-enable it. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Jun 2022 16:54:29 +0000 - rev 621779
Push 39885 by nfay@mozilla.com at Thu, 23 Jun 2022 03:54:50 +0000
Bug 1767702 - [devtools] Split browser_dbg-features-source-tree.js and re-enable it. r=bomsy Let move Browser Toolbox checks in a distinct file as it can get flaky. Differential Revision: https://phabricator.services.mozilla.com/D149417
b142d6884a329303f3866724bdc28c0d890eca4d: Bug 1774601 - [devtools] Remove plain url computation. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Jun 2022 07:08:12 +0000 - rev 621652
Push 39883 by ctuns@mozilla.com at Wed, 22 Jun 2022 16:10:22 +0000
Bug 1774601 - [devtools] Remove plain url computation. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D149533
4d0fd79de60ea2acb77f17f3f60f9164b40b31d3: Bug 1774601 - [devtools] Stop hiding query parameters in Tab components. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Jun 2022 07:08:12 +0000 - rev 621651
Push 39883 by ctuns@mozilla.com at Wed, 22 Jun 2022 16:10:22 +0000
Bug 1774601 - [devtools] Stop hiding query parameters in Tab components. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D149532
2e547daa8555b4b9419857b8453679ff29a3be8a: Bug 1774601 - [devtools] Stop hiding query parameters in the SourceTree. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Jun 2022 07:08:11 +0000 - rev 621650
Push 39883 by ctuns@mozilla.com at Wed, 22 Jun 2022 16:10:22 +0000
Bug 1774601 - [devtools] Stop hiding query parameters in the SourceTree. r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D149531
111f88d43ea58ddc3d8e5a758ef0c100ad90c319: Bug 1771095 - Remove size property from SearchBar component r=bomsy
manekenpix <manekenpix@fastmail.com> - Wed, 22 Jun 2022 07:04:09 +0000 - rev 621649
Push 39883 by ctuns@mozilla.com at Wed, 22 Jun 2022 16:10:22 +0000
Bug 1771095 - Remove size property from SearchBar component r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D149348
d6f3b6db1b75c421c65654ed759f31fbe158554c: Bug 1764346 - [devtools] Add Network Monitor Browser Toolbox test. r=bomsy.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 21 Jun 2022 11:45:52 +0000 - rev 621568
Push 39880 by ccozmuta@mozilla.com at Wed, 22 Jun 2022 03:32:25 +0000
Bug 1764346 - [devtools] Add Network Monitor Browser Toolbox test. r=bomsy. Differential Revision: https://phabricator.services.mozilla.com/D149513
110c06ad7ca778edf66a9402d87feedaf3a08b9e: Bug 1773276 - [devtools] Better support <iframe srcdoc> in the debugger. r=bomsy
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 20 Jun 2022 17:03:36 +0000 - rev 621454
Push 39874 by csabou@mozilla.com at Mon, 20 Jun 2022 21:49:56 +0000
Bug 1773276 - [devtools] Better support <iframe srcdoc> in the debugger. r=bomsy These sources are reported as inline source, which they are, but the URL of the srcdoc document is always about:srcdoc. We were trying to fetch sources content from this URL, but this is actually a fake URL that fails loading. So, fallback to load the source from Debugger.Source object. Also, consider these sources as non inline source and have a unique URL for each, so that we can load each of their source content independently and set breakpoint on each of them individually. We could have them all under about:srcdoc source, otherwise we could only display the first source actor's text content. Differential Revision: https://phabricator.services.mozilla.com/D148798