searching for reviewer(birtles)
58335f848eed6d7211e8383b5960e1f87ef2d58a: Bug 1778510: Cut over AnimationEffect to new fine-grained TimerPrecision calls r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 29 Nov 2022 13:34:18 +0000 - rev 643972
Push 40441 by imoraru@mozilla.com at Tue, 29 Nov 2022 21:47:49 +0000
Bug 1778510: Cut over AnimationEffect to new fine-grained TimerPrecision calls r=birtles Depends on D151303 Differential Revision: https://phabricator.services.mozilla.com/D151304
5c5f879f5a0fa0eac358f0ab6994e1fd4b5d6910: Bug 1778510: Add Timer Caller Type to AnimationTimeline r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 29 Nov 2022 13:34:17 +0000 - rev 643971
Push 40441 by imoraru@mozilla.com at Tue, 29 Nov 2022 21:47:49 +0000
Bug 1778510: Add Timer Caller Type to AnimationTimeline r=birtles Depends on D151301 Differential Revision: https://phabricator.services.mozilla.com/D151302
61a0ae3e24bd47d8e565e3e3f7d52a1bd7d53c74: Bug 1778510: Use the Timer Caller Type in Animation's timestamp code r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 29 Nov 2022 13:34:17 +0000 - rev 643970
Push 40441 by imoraru@mozilla.com at Tue, 29 Nov 2022 21:47:49 +0000
Bug 1778510: Use the Timer Caller Type in Animation's timestamp code r=birtles Depends on D151300 Differential Revision: https://phabricator.services.mozilla.com/D151301
8aff2d2c67eb9b0c120867f3657d55cdba9674d6: Bug 1778510: Add a Timer Caller Type to Animation r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 29 Nov 2022 13:34:17 +0000 - rev 643969
Push 40441 by imoraru@mozilla.com at Tue, 29 Nov 2022 21:47:49 +0000
Bug 1778510: Add a Timer Caller Type to Animation r=birtles This will be needed for the various Timestamp related members of Animations. Depends on D151299 Differential Revision: https://phabricator.services.mozilla.com/D151300
4ceffd409eaed3f60a7397a41b521a46b5ba55a1: Bug 1778510: Cut over AnimationEffect to new fine-grained TimerPrecision calls r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 28 Nov 2022 18:04:10 +0000 - rev 643852
Push 40440 by ctuns@mozilla.com at Tue, 29 Nov 2022 08:40:32 +0000
Bug 1778510: Cut over AnimationEffect to new fine-grained TimerPrecision calls r=birtles Depends on D151303 Differential Revision: https://phabricator.services.mozilla.com/D151304
47db43142c62a333297c8ca58de57523b0ae8b4f: Bug 1778510: Add Timer Caller Type to AnimationTimeline r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 28 Nov 2022 18:04:09 +0000 - rev 643851
Push 40440 by ctuns@mozilla.com at Tue, 29 Nov 2022 08:40:32 +0000
Bug 1778510: Add Timer Caller Type to AnimationTimeline r=birtles Depends on D151301 Differential Revision: https://phabricator.services.mozilla.com/D151302
ebb21153aaace3da0cd0e8d6c261f896eb79851e: Bug 1778510: Use the Timer Caller Type in Animation's timestamp code r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 28 Nov 2022 18:04:09 +0000 - rev 643850
Push 40440 by ctuns@mozilla.com at Tue, 29 Nov 2022 08:40:32 +0000
Bug 1778510: Use the Timer Caller Type in Animation's timestamp code r=birtles Depends on D151300 Differential Revision: https://phabricator.services.mozilla.com/D151301
a87eaaec3f9cf4cebac4da24b609b6787151e986: Bug 1778510: Add a Timer Caller Type to Animation r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 28 Nov 2022 18:04:08 +0000 - rev 643849
Push 40440 by ctuns@mozilla.com at Tue, 29 Nov 2022 08:40:32 +0000
Bug 1778510: Add a Timer Caller Type to Animation r=birtles This will be needed for the various Timestamp related members of Animations. Depends on D151299 Differential Revision: https://phabricator.services.mozilla.com/D151300
35b7c7df62ce0a68c86afa3fd5e78f6dcdc1530b: Bug 1778510: Cut over AnimationEffect to new fine-grained TimerPrecision calls r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 28 Nov 2022 04:21:29 +0000 - rev 643765
Push 40438 by sstanca@mozilla.com at Mon, 28 Nov 2022 15:41:50 +0000
Bug 1778510: Cut over AnimationEffect to new fine-grained TimerPrecision calls r=birtles Depends on D151303 Differential Revision: https://phabricator.services.mozilla.com/D151304
187d71f425930213aa4c2b55cea61d082aae8547: Bug 1778510: Add Timer Caller Type to AnimationTimeline r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 28 Nov 2022 04:21:29 +0000 - rev 643764
Push 40438 by sstanca@mozilla.com at Mon, 28 Nov 2022 15:41:50 +0000
Bug 1778510: Add Timer Caller Type to AnimationTimeline r=birtles Depends on D151301 Differential Revision: https://phabricator.services.mozilla.com/D151302
450f4ccd6cd092cdeb954575db65e8b3eacb3bf3: Bug 1778510: Use the Timer Caller Type in Animation's timestamp code r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 28 Nov 2022 04:21:28 +0000 - rev 643763
Push 40438 by sstanca@mozilla.com at Mon, 28 Nov 2022 15:41:50 +0000
Bug 1778510: Use the Timer Caller Type in Animation's timestamp code r=birtles Depends on D151300 Differential Revision: https://phabricator.services.mozilla.com/D151301
915149e27da01bda5b3975350073a607fd81c5b5: Bug 1778510: Add a Timer Caller Type to Animation r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 28 Nov 2022 04:21:28 +0000 - rev 643762
Push 40438 by sstanca@mozilla.com at Mon, 28 Nov 2022 15:41:50 +0000
Bug 1778510: Add a Timer Caller Type to Animation r=birtles This will be needed for the various Timestamp related members of Animations. Depends on D151299 Differential Revision: https://phabricator.services.mozilla.com/D151300
041ab07327252c3ab352a0d68c1386f35555f18f: Bug 1134538 - Avoid the computation of inf - inf for the interval end time. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 08 Aug 2022 23:34:05 +0000 - rev 626477
Push 40101 by nerli@mozilla.com at Tue, 09 Aug 2022 03:57:17 +0000
Bug 1134538 - Avoid the computation of inf - inf for the interval end time. r=birtles If both end time and start delay are Infinity, the result of interval end time is undefined, so now we return zero duration to avoid the assertion in StickyTimeDuration. Differential Revision: https://phabricator.services.mozilla.com/D153818
71bbfaecf629a3d73c72600d35c0ac2965516d60: Bug 1775327 - Part 3: Do normalization for NormalizedTiming(). r=firefox-animation-reviewers,birtles
Boris Chiou <boris.chiou@gmail.com> - Thu, 07 Jul 2022 18:33:42 +0000 - rev 623252
Push 39951 by imoraru@mozilla.com at Fri, 08 Jul 2022 04:09:57 +0000
Bug 1775327 - Part 3: Do normalization for NormalizedTiming(). r=firefox-animation-reviewers,birtles This implements the normalization of the specified time, defined in [web-animations-2]: https://drafts.csswg.org/web-animations-2/#normalize-specified-timing. However, it is possible to update this, based on the spec issue: https://github.com/w3c/csswg-drafts/issues/4862. For now, we just do normalization for delay, end delay, and iteration duration based on the end time. And make sure the end time is equal to the timeline duration. Differential Revision: https://phabricator.services.mozilla.com/D149685
91aa64979565ca89477f2cbdac98cb7344fe8bb6: Bug 1775327 - Part 2: Fix playing finished scroll animation on reversing scrolling. r=firefox-animation-reviewers,birtles
Boris Chiou <boris.chiou@gmail.com> - Thu, 07 Jul 2022 18:33:41 +0000 - rev 623251
Push 39951 by imoraru@mozilla.com at Fri, 08 Jul 2022 04:09:57 +0000
Bug 1775327 - Part 2: Fix playing finished scroll animation on reversing scrolling. r=firefox-animation-reviewers,birtles We have to make sure the scroll animations is still responsive at boundaries even if it's playstate is finished. This patch includes the update of UpdateFinishedState() to match the spec, and make sure we still tick scroll animations at finished play state. Getting a finished state might be strange for scroll animations, and this might be a spec issue. However, for consistency with JS-generated animations, we'd like to align the behaviors with other browsers, and make sure we are still match the definition of finished state in the spec. Besides, we have to use EndTime() on the compositor so animation-iteration-count works properly. Tests are in the last patch. Differential Revision: https://phabricator.services.mozilla.com/D149940
6426182f2b9e2ca3b5b67203ad907bc9b4b7cdcc: Bug 1775327 - Part 1: Make sure the scroll animation is still in active phase at boundaries. r=firefox-animation-reviewers,birtles
Boris Chiou <boris.chiou@gmail.com> - Thu, 07 Jul 2022 18:33:41 +0000 - rev 623250
Push 39951 by imoraru@mozilla.com at Fri, 08 Jul 2022 04:09:57 +0000
Bug 1775327 - Part 1: Make sure the scroll animation is still in active phase at boundaries. r=firefox-animation-reviewers,birtles We have to introduce "at progress timeline boundary" which is defined in web-animations-2 [1]. We need this to make sure the scroll animations do not go into before phase or after phase. The test of fill-mode should be together with delay, so I'd like to add the tests in the last patch. [1] https://drafts.csswg.org/web-animations-2/#at-progress-timeline-boundary Differential Revision: https://phabricator.services.mozilla.com/D149684
25912d464306042b0c284e37335cf823c71f6a0c: Bug 1744850 - Drop ScrollTimeline:sTiming and introduce a normalized timing. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Wed, 22 Jun 2022 21:19:30 +0000 - rev 621827
Push 39885 by nfay@mozilla.com at Thu, 23 Jun 2022 03:54:50 +0000
Bug 1744850 - Drop ScrollTimeline:sTiming and introduce a normalized timing. r=birtles `sTiming` is a hack and I believe animation-delay, animation-iteration-count, animation-direction, and animation-fill-mode should be meaningful for scroll-linked animations. (I will add the tentative wpt in Bug 1775327.) So we need to introduce a normalized timing when resolving the specified timing. Also, this patch makes the bug of printing scroll animations detectable. No behavior is changed and I'd like to remove the magic values and do normalization in Bug 1775327. Note: Based on https://github.com/w3c/csswg-drafts/issues/4862 and web-animations-2, we will introudce CSSNumberish for duration, current time, and delay. That is, we will accept percentage for animation-duration, animation-delay. However, Gecko doesn't support CSSNumberish for those values, so we'd like to normalize these time values in Bug 1775327. This patch is the 1st step: split the normalized timing from the specified timing, and use it when resolving the timing, for progress-based timeline. Differential Revision: https://phabricator.services.mozilla.com/D149683
eb45c4f28c176d5e61b4c7af27a1b4d7c012a0c8: Bug 1343919 - Fix base URI in KeyframeEffect. r=birtles
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 04 Jun 2022 12:49:12 +0000 - rev 619710
Push 39797 by ccozmuta@mozilla.com at Sat, 04 Jun 2022 21:39:03 +0000
Bug 1343919 - Fix base URI in KeyframeEffect. r=birtles This is the only meaningful consumer of ServoCSSParser::GetParsingEnvironment right now, but seems worth fixing before other folks add more. Differential Revision: https://phabricator.services.mozilla.com/D148145
2ab6da577ec5ffd53401ab530974e6a80d0d51e7: Bug 1680896 - Try to make test_pending_animation_tracker more reliable. r=birtles
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 May 2022 10:51:59 +0000 - rev 619289
Push 39775 by imoraru@mozilla.com at Tue, 31 May 2022 15:29:54 +0000
Bug 1680896 - Try to make test_pending_animation_tracker more reliable. r=birtles I couldn't reproduce this intermittent, but this test is prone to throttling decisions. In fact, without this check: https://searchfox.org/mozilla-central/rev/7751fef9eeb3db0a07ae4680daa2a62bd8f49882/dom/base/Document.cpp#7055 I did see consistent failures. Ensure the window is fully loaded so that the refresh driver doesn't get throttled unexpectedly. Try to enable the test across platforms. Differential Revision: https://phabricator.services.mozilla.com/D147633
7d6f346527fd13bcd708d8df9f9498df43ee44f4: Bug 1768275 - Use SetAnyPromiseIsHandled instead of SetSettledPromiseIsHandled for promise that's not guaranteed to be not-yet-resolved. r=birtles
Tooru Fujisawa <arai_a@mac.com> - Wed, 11 May 2022 16:51:52 +0000 - rev 617000
Push 39683 by ccozmuta@mozilla.com at Wed, 11 May 2022 21:49:30 +0000
Bug 1768275 - Use SetAnyPromiseIsHandled instead of SetSettledPromiseIsHandled for promise that's not guaranteed to be not-yet-resolved. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D146032
20e8a5b10f184def8baa202c543bc52af405b3cd: Bug 1768275 - Use SetAnyPromiseIsHandled instead of SetSettledPromiseIsHandled for promise that's not guaranteed to be not-yet-resolved. r=birtles
Tooru Fujisawa <arai_a@mac.com> - Wed, 11 May 2022 13:32:52 +0000 - rev 616983
Push 39683 by ccozmuta@mozilla.com at Wed, 11 May 2022 21:49:30 +0000
Bug 1768275 - Use SetAnyPromiseIsHandled instead of SetSettledPromiseIsHandled for promise that's not guaranteed to be not-yet-resolved. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D146032
de3ae6e428b56776175b0f01e8a28d20fd333b4a: Bug 1767357 - Enable Animation.timeline setter in release channels. r=birtles,emilio
Boris Chiou <boris.chiou@gmail.com> - Thu, 05 May 2022 21:09:33 +0000 - rev 616350
Push 39657 by imoraru@mozilla.com at Fri, 06 May 2022 09:50:52 +0000
Bug 1767357 - Enable Animation.timeline setter in release channels. r=birtles,emilio Basically, this patch reverts Bug 1612106 [1]. Webkit just turns this on by default [2], so it's worth to enable this in our release channels. [1] https://phabricator.services.mozilla.com/D63432 [2] https://trac.webkit.org/changeset/291868/webkit/ Differential Revision: https://phabricator.services.mozilla.com/D145356
0a46bb2d3a65740009d2da0b1352df9098046c08: Bug 1761001 - Update wpt expectation because we use Animation.timeline setter in seamlessly-updating-the-playback-rate-of-an-animation.html. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Wed, 23 Mar 2022 23:53:39 +0000 - rev 611734
Push 39465 by ccozmuta@mozilla.com at Thu, 24 Mar 2022 09:36:15 +0000
Bug 1761001 - Update wpt expectation because we use Animation.timeline setter in seamlessly-updating-the-playback-rate-of-an-animation.html. r=birtles Animation.timeline setter is only supported on Nightly, so we have to update the wpt expectation for this file. Differential Revision: https://phabricator.services.mozilla.com/D141889
e34abd14507f5deb4f3e110a9c07156b5ccc54ea: Bug 1758527 - Adjust the logic of handing the unresolved current time in PlayNoUpdate() and UpdatePlaybackRate(). r=birtles
Boris Chiou <boris.chiou@gmail.com> - Wed, 23 Mar 2022 01:30:51 +0000 - rev 611559
Push 39458 by smolnar@mozilla.com at Wed, 23 Mar 2022 04:09:13 +0000
Bug 1758527 - Adjust the logic of handing the unresolved current time in PlayNoUpdate() and UpdatePlaybackRate(). r=birtles Based on the spec [1], the unresolved current time should be checked only if the auto-rewind flag is ture. Otherwise, the null timeline with the false auto-rewind flag may get an InvalidStateError DOMException if its effect end is positive infinity. Note: If the animation has no associated timeline, it's current time is unresolved [2]. Besides, we also tweak the handle for unresolved current time based on the spec PR: https://github.com/w3c/csswg-drafts/pull/7148, in UpdatePlaybackRate() and PlayNoUpdate(). Note: CSS animations and CSS transitions set auto-rewind flag to false [3], and the current time is unresolved (because the start time and the hold time are all unresolved), and so the seek time is unresolved as well, especially when we build a new CSS animation or CSS transition. Therefore we have to avoid the unresolved seek time to let PlayNoUpdate() early return. [1] https://drafts.csswg.org/web-animations-1/#playing-an-animation-section [2] https://drafts.csswg.org/web-animations-1/#animation-current-time [3] https://drafts.csswg.org/css-animations-2/#animation-play-state See the spec issue: https://github.com/w3c/csswg-drafts/issues/7145 for more details. Differential Revision: https://phabricator.services.mozilla.com/D140682
41911701ed42d4d5873974c2c64aa563ba8eb512: Bug 1732211 - Use a large animation-duration instead of 1e10s. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 28 Sep 2021 21:30:42 +0000 - rev 593508
Push 38829 by ctuns@mozilla.com at Wed, 29 Sep 2021 09:46:07 +0000
Bug 1732211 - Use a large animation-duration instead of 1e10s. r=birtles In Gecko debug build, Using the infinite duration (larger than INT64_MAX) together with requestAnimationFrame may cause an assertion because we may multiply infinity and zero. This is an undefined behavior, so we intent to not fix this in Gecko now. Just do a workaround to avoid false alarms because these assertions are not related to scroll-animations. Differential Revision: https://phabricator.services.mozilla.com/D126728
c71df025183f539b6398125980ac2934062be974: Bug 708901 - Migrate to nsTHashSet in dom/animation. r=birtles
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 23 Mar 2021 10:36:32 +0000 - rev 572576
Push 38313 by apavel@mozilla.com at Tue, 23 Mar 2021 21:43:59 +0000
Bug 708901 - Migrate to nsTHashSet in dom/animation. r=birtles Depends on D108591 Differential Revision: https://phabricator.services.mozilla.com/D108592
7f18ac417ddb4a93014f8aba3621ca59cbea132b: Bug 1698600 - CSS animation profiler markers should also be added for animations that run to completion, r=birtles.
Florian Quèze <florian@queze.net> - Tue, 16 Mar 2021 12:04:01 +0000 - rev 571394
Push 38290 by abutkovits@mozilla.com at Tue, 16 Mar 2021 16:29:54 +0000
Bug 1698600 - CSS animation profiler markers should also be added for animations that run to completion, r=birtles. Differential Revision: https://phabricator.services.mozilla.com/D108493
37df35e82902bccd9c0afff8a8df0eb48f2e52a9: Bug 1676608 - correct wpt tests for invalid values r=birtles
longsonr <longsonr@gmail.com> - Wed, 11 Nov 2020 23:47:04 +0000 - rev 556885
Push 37943 by btara@mozilla.com at Thu, 12 Nov 2020 21:28:42 +0000
Bug 1676608 - correct wpt tests for invalid values r=birtles Differential Revision: https://phabricator.services.mozilla.com/D96695
9c9602e64e194e376d9849828ce71616ef659272: Bug 1667629 - support mpath pointing to shapes r=birtles,emilio
longsonr <longsonr@gmail.com> - Thu, 01 Oct 2020 16:19:37 +0000 - rev 551142
Push 37825 by abutkovits@mozilla.com at Fri, 02 Oct 2020 04:10:47 +0000
Bug 1667629 - support mpath pointing to shapes r=birtles,emilio Differential Revision: https://phabricator.services.mozilla.com/D91510
508b69014dd808b227c4b15d45483d4119432ff7: Bug 1661315 - Set [Animation interface: attribute timeline] to fail on non-nightly builds. r=birtles DONTBUILD
Cosmin Sabou <csabou@mozilla.com> - Sat, 29 Aug 2020 08:50:24 +0000 - rev 546923
Push 37738 by btara@mozilla.com at Sat, 29 Aug 2020 21:23:02 +0000
Bug 1661315 - Set [Animation interface: attribute timeline] to fail on non-nightly builds. r=birtles DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D88710
c0fed15df545ed4bb6c8ce99db466a3815d52604: Bug 1642157 - mark 2 svg animation tests as backlog (tier-2) due to not supported. r=birtles
Joel Maher <jmaher@mozilla.com> - Wed, 17 Jun 2020 23:39:23 +0000 - rev 536266
Push 37519 by ccoroiu@mozilla.com at Thu, 18 Jun 2020 21:28:28 +0000
Bug 1642157 - mark 2 svg animation tests as backlog (tier-2) due to not supported. r=birtles mark 2 svg animation tests as backlog (tier-2) due to not supported Differential Revision: https://phabricator.services.mozilla.com/D79824
1d033efd9ea6b0a2c4fed687695d2501f817f426: Bug 1626532 - Make `dom/animation` buildable outside of `unified-build` environment. r=birtles
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 02 Jun 2020 10:31:46 +0000 - rev 533843
Push 37479 by apavel@mozilla.com at Thu, 04 Jun 2020 15:32:20 +0000
Bug 1626532 - Make `dom/animation` buildable outside of `unified-build` environment. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D69161
7a510d21948fc0d331527534ca188bfed0f9aa3a: Bug 1626570 - Improve handling of copying arrays in dom/smil/. r=birtles
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 05 May 2020 13:00:31 +0000 - rev 528125
Push 37382 by malexandru@mozilla.com at Tue, 05 May 2020 21:38:25 +0000
Bug 1626570 - Improve handling of copying arrays in dom/smil/. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D73630
404f1295f4bc2e9ce2641efb33032a3cbcf77d82: Bug 1626133 - Separate the portion of Element::GetAnimation which needs script from the part that doesn't. r=birtles
Emily McDonough <emcdonough@mozilla.com> - Tue, 31 Mar 2020 01:45:08 +0000 - rev 521196
Push 37268 by apavel@mozilla.com at Tue, 31 Mar 2020 09:35:27 +0000
Bug 1626133 - Separate the portion of Element::GetAnimation which needs script from the part that doesn't. r=birtles Also update the existing caller which doesn't need the flush that was causing the script requirement. Differential Revision: https://phabricator.services.mozilla.com/D68944
3163f1561bc060b89452ee44956266efe29b8c98: Bug 1625608 - Improve some web-animations error messages. r=birtles
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 30 Mar 2020 09:48:06 +0000 - rev 521021
Push 37264 by aciure@mozilla.com at Mon, 30 Mar 2020 15:54:08 +0000
Bug 1625608 - Improve some web-animations error messages. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D68695
254999e1d7614bfcc52a572b1364c6be31a3b09b: Bug 1622369 - Await the async function to make sure any async steps inside the function will be blocked. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Fri, 27 Mar 2020 19:00:02 +0000 - rev 520796
Push 37259 by dluca@mozilla.com at Sat, 28 Mar 2020 09:32:56 +0000
Bug 1622369 - Await the async function to make sure any async steps inside the function will be blocked. r=birtles It's easy to get time out on mac if we don't await the async function. The async functions return an implicit Promise. If the caller doesn't await it, any async steps inside the function will not be blocked. Differential Revision: https://phabricator.services.mozilla.com/D68448
bdf66b9a75e61aa0d529b8d9813db33be9b76fea: Bug 1621174 - Fix error handling for setting KeyframeEffect.pseudoElement. r=birtles,smaug
Boris Chiou <boris.chiou@gmail.com> - Thu, 12 Mar 2020 00:34:46 +0000 - rev 518296
Push 37208 by opoprus@mozilla.com at Thu, 12 Mar 2020 15:42:22 +0000
Bug 1621174 - Fix error handling for setting KeyframeEffect.pseudoElement. r=birtles,smaug We should throw a DOMException SyntaxError when setting pseudoElement a syntactically invalid string or an unsupported pseudo. Differential Revision: https://phabricator.services.mozilla.com/D66321
5811bf461e5e0c3a7ca0ba198da83d145b28bc36: Bug 1619276 - Fix the order of the setting of Keyframe options. r=smaug,birtles
Boris Chiou <boris.chiou@gmail.com> - Thu, 05 Mar 2020 09:42:55 +0000 - rev 517093
Push 37186 by malexandru@mozilla.com at Fri, 06 Mar 2020 09:47:39 +0000
Bug 1619276 - Fix the order of the setting of Keyframe options. r=smaug,birtles Besides, we add the pref setup in the webidl, so if we turn it off, iterationComposite and composite will always be the default values. Differential Revision: https://phabricator.services.mozilla.com/D65437
9aad6bdfb58c6e4306349ca5a16d024652678d0f: Bug 1612891 - Suppress parsing easing error in early returns of ConvertKeyframeSequence. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Wed, 04 Mar 2020 01:03:16 +0000 - rev 516892
Push 37183 by nerli@mozilla.com at Thu, 05 Mar 2020 04:16:49 +0000
Bug 1612891 - Suppress parsing easing error in early returns of ConvertKeyframeSequence. r=birtles We add a stack based class and supress the exception of parsing easing in the destructor, to avoid hitting the potential assertions. Differential Revision: https://phabricator.services.mozilla.com/D64268
096dfc972a04277ee4f5ed8426e207e2c9c0f9de: Bug 1611847 - Update relevance and its effect set in the early return of UpdatePlaybackRate(). r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 25 Feb 2020 19:41:14 +0000 - rev 515506
Push 37158 by opoprus@mozilla.com at Wed, 26 Feb 2020 09:27:57 +0000
Bug 1611847 - Update relevance and its effect set in the early return of UpdatePlaybackRate(). r=birtles To avoid hitting the assertion because of out-of-dated relevance. Differential Revision: https://phabricator.services.mozilla.com/D63582
922d1a0e30901695cfc6efff2d47ff1d787e3b84: Bug 1612106 - Use NIGHTLY build flag to distinguish the writable/readonly Animation.timeline. r=birtles,bzbarsky
Boris Chiou <boris.chiou@gmail.com> - Mon, 24 Feb 2020 23:07:09 +0000 - rev 515501
Push 37158 by opoprus@mozilla.com at Wed, 26 Feb 2020 09:27:57 +0000
Bug 1612106 - Use NIGHTLY build flag to distinguish the writable/readonly Animation.timeline. r=birtles,bzbarsky We only support writable Animation.timeline attribute on nightly build, so use nightly build flag in WebIDL and Animation.h/cpp. For the test expectations, we also use this build flag to skip them or mark them as expected fail if necessary. Differential Revision: https://phabricator.services.mozilla.com/D63432
4f19c1102c42b884a5a301d489cbccd96ee02dcb: Bug 1616443 - Hide composite memeber from the result of getKeyframes(). r=birtles,bzbarsky
Boris Chiou <boris.chiou@gmail.com> - Thu, 20 Feb 2020 19:09:34 +0000 - rev 514872
Push 37143 by aiakab@mozilla.com at Fri, 21 Feb 2020 05:56:31 +0000
Bug 1616443 - Hide composite memeber from the result of getKeyframes(). r=birtles,bzbarsky If dom.animations-api.compositing.enabled is false, we have to hide composite member from getKeyframes. Differential Revision: https://phabricator.services.mozilla.com/D63388
ebfed5eb1869b1bdcb566ae805e6ee742e0a4323: Bug 1610981 - Eliminate usage of CSSPseudoElement from KeyframeEffect. r=birtles,smaug
Boris Chiou <boris.chiou@gmail.com> - Tue, 18 Feb 2020 20:44:14 +0000 - rev 514533
Push 37136 by opoprus@mozilla.com at Wed, 19 Feb 2020 04:34:03 +0000
Bug 1610981 - Eliminate usage of CSSPseudoElement from KeyframeEffect. r=birtles,smaug Replace ElementOrCSSPseudoElement with Element and add PseudoElement (which is a DOMString) into KeyframeAnimationOptions and KeyframeEffect. Differential Revision: https://phabricator.services.mozilla.com/D62667
0544d8d971067235d3a1da242cd88000f666464a: Bug 1610981 - Drop Maybe<> from KeyframeEffect::mTarget. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 18 Feb 2020 20:44:12 +0000 - rev 514532
Push 37136 by opoprus@mozilla.com at Wed, 19 Feb 2020 04:34:03 +0000
Bug 1610981 - Drop Maybe<> from KeyframeEffect::mTarget. r=birtles In order to store the different combinations of (Element, PsuedoStyleType) pairs, including (nullptr, ::before/::after), we drop Maybe<> and use OwningAnimationTarget directly. Differential Revision: https://phabricator.services.mozilla.com/D62666
dff38d5e834ad654a3109a6512ead06b95ba9ad6: Use %g, not %f, for our error reporting so unnecessary trailing zeros are not output. No bug. r=birtles
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 10 Feb 2020 01:35:00 +0000 - rev 512981
Push 37105 by apavel@mozilla.com at Mon, 10 Feb 2020 09:39:12 +0000
Use %g, not %f, for our error reporting so unnecessary trailing zeros are not output. No bug. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D62062
5e39f4f870b079fa23fbed1fb5f4352f2e79b965: Bug 1601322 - Updated animations/reverse-running-animation.html expectations r=birtles
Andreea Pavel <apavel@mozilla.com> - Thu, 26 Dec 2019 00:34:54 +0000 - rev 508375
Push 36953 by ncsoregi@mozilla.com at Thu, 26 Dec 2019 16:51:39 +0000
Bug 1601322 - Updated animations/reverse-running-animation.html expectations r=birtles Differential Revision: https://phabricator.services.mozilla.com/D58088
9d653dc355d3fec5c9870edd49f739d21be734e9: Bug 1601609: Set dom.animations-api.implicit-keyframes.enabled pref in __dir__.ini file. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Mon, 16 Dec 2019 01:05:20 +0000 - rev 507039
Push 36921 by nerli@mozilla.com at Mon, 16 Dec 2019 09:50:52 +0000
Bug 1601609: Set dom.animations-api.implicit-keyframes.enabled pref in __dir__.ini file. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D56846
3779e7b766fd91688914046f1efee1a3812f69b0: Bug 1506746 - Update expectation for rotate property for extrapolation in wpt. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Nov 2019 22:56:43 +0000 - rev 502508
Push 36817 by ncsoregi@mozilla.com at Tue, 19 Nov 2019 04:39:02 +0000
Bug 1506746 - Update expectation for rotate property for extrapolation in wpt. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D52945
3c5118f00c7caf321cfbee83e3abe5aa9b75e80c: Bug 1506746 - Update the expected direction vector of rotate property in wpt. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Nov 2019 20:47:01 +0000 - rev 502507
Push 36817 by ncsoregi@mozilla.com at Tue, 19 Nov 2019 04:39:02 +0000
Bug 1506746 - Update the expected direction vector of rotate property in wpt. r=birtles For interpolations with the primitive rotate3d(), the direction vectors of the transform functions get normalized first. This should also be applied to rotate property. https://drafts.csswg.org/css-transforms-2/#interpolation-of-transform-functions Differential Revision: https://phabricator.services.mozilla.com/D52944
dfb29951d8b0be208d83f5c3e81b5cff84549cc6: Bug 1506746 - Update the expected value at 0% and 100% for individual transforms. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Nov 2019 20:46:59 +0000 - rev 502506
Push 36817 by ncsoregi@mozilla.com at Tue, 19 Nov 2019 04:39:02 +0000
Bug 1506746 - Update the expected value at 0% and 100% for individual transforms. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D52943