searching for reviewer(birtles)
1d9715fd32fc3757e7d37d578f9581901c0c6e24: Bug 1571038 - Copy test logic for scrolled out element to out of view element r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 05 Aug 2019 23:16:14 +0000 - rev 486453
Push 36394 by dluca@mozilla.com at Tue, 06 Aug 2019 09:35:30 +0000
Bug 1571038 - Copy test logic for scrolled out element to out of view element r=birtles Differential Revision: https://phabricator.services.mozilla.com/D40664
1c82a9581ad6708dce653bcbe4857b095b64f02a: Bug 1571227 - Fix test_restyles to account for double imprecision r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 05 Aug 2019 22:45:48 +0000 - rev 486452
Push 36394 by dluca@mozilla.com at Tue, 06 Aug 2019 09:35:30 +0000
Bug 1571227 - Fix test_restyles to account for double imprecision r=birtles Differential Revision: https://phabricator.services.mozilla.com/D40663
7c6c3ac5f8fd987fd47e473e4457266498e48f1f: Bug 1559231 - Make offset-anchor animatable. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Fri, 02 Aug 2019 20:12:40 +0000 - rev 486039
Push 36380 by btara@mozilla.com at Sat, 03 Aug 2019 09:46:28 +0000
Bug 1559231 - Make offset-anchor animatable. r=birtles Per the spec issue, https://github.com/w3c/csswg-drafts/issues/3482, we update the wpt to keep the percentage in `calc()` for `offset-anchor`. Differential Revision: https://phabricator.services.mozilla.com/D39552
d47d9f4bf9a9ea8b816534916292ca446c7543ce: Bug 1559231 - Make offset-anchor animatable. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Fri, 02 Aug 2019 00:47:09 +0000 - rev 485991
Push 36379 by opoprus@mozilla.com at Fri, 02 Aug 2019 21:52:41 +0000
Bug 1559231 - Make offset-anchor animatable. r=birtles Per the spec issue, https://github.com/w3c/csswg-drafts/issues/3482, we update the wpt to keep the percentage in `calc()` for `offset-anchor`. Differential Revision: https://phabricator.services.mozilla.com/D39552
38e17f634ce4e77bfbf665fe920094012c349bb6: Bug 1387894 - Disable unconditional clamping for two CSS tests. r=birtles
Tom Ritter <tom@mozilla.com> - Fri, 02 Aug 2019 07:36:59 +0200 - rev 485906
Push 36377 by csabou@mozilla.com at Fri, 02 Aug 2019 15:59:52 +0000
Bug 1387894 - Disable unconditional clamping for two CSS tests. r=birtles We're hitting double imprecision here. Example: Given 86.68392200000000 and 86.67999999999999 we want to see if they're equal with two significant digits. (They are, they're 86.68) However, when we reduce them, 86.68 (which is represented as an epislon lower) gets reduced to 86.66 and they no longer match. We disable unconditional clamping on these tests to confirm they behave the way they shoud... excepting the clamping which may introduce imprecision. Differential Revision: https://phabricator.services.mozilla.com/D38812 Depends on D38811
2c84f4806f91fa54f1580e2bf83e848cf51a85cc: Bug 1387894 - Fix animation WPTs. r=birtles,jgraham
Tom Ritter <tom@mozilla.com> - Fri, 02 Aug 2019 07:36:38 +0200 - rev 485904
Push 36377 by csabou@mozilla.com at Fri, 02 Aug 2019 15:59:52 +0000
Bug 1387894 - Fix animation WPTs. r=birtles,jgraham I believe these intermittents are caused by double imprecision. When unconditional clamping is enabled it gets multiplied out and causes animation.currentTime to occasionally go to 50000.02 which causes the test to fail. We can reduce the precision back down to ignore that. We do so using some WPT overrides. Differential Revision: https://phabricator.services.mozilla.com/D38810 Depends on D38809
f07ba3e1ae0d98af129619c5f211b795375ac0ba: Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping. r=birtles
Tom Ritter <tom@mozilla.com> - Fri, 02 Aug 2019 07:36:29 +0200 - rev 485903
Push 36377 by csabou@mozilla.com at Fri, 02 Aug 2019 15:59:52 +0000
Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping. r=birtles This has to do with double imprecision. The test originally had toPrecision(6) to account for this imprecision. It'd round up 499.9999 into 500. When we send double(500) (which is an epsilon below 500) into ReduceTimePrecision we wind up coming out with 499.98. By reducing our precision requirement in this test we can handle that and round 499.98 back up to 500 Differential Revision: https://phabricator.services.mozilla.com/D38809 Depends on D38808
e73d900b1dcf01da7c7023d7d6ee70043be5d9cf: Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping. r=birtles,hiro
Tom Ritter <tom@mozilla.com> - Fri, 02 Aug 2019 07:36:19 +0200 - rev 485902
Push 36377 by csabou@mozilla.com at Fri, 02 Aug 2019 15:59:52 +0000
Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping. r=birtles,hiro This refactors things to run until the animation is unthrottled. It confirms the proper amount of time has passed; and then awaits another styling to ensure that markers.length = 0 (unless it took very long (over 200ms) that it should be 1. Differential Revision: https://phabricator.services.mozilla.com/D38808 Depends on D38807
cae99e27ccdd2a8b86f8d054237e318f9add63c0: Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping. r=birtles
Tom Ritter <tom@mozilla.com> - Fri, 02 Aug 2019 07:36:09 +0200 - rev 485901
Push 36377 by csabou@mozilla.com at Fri, 02 Aug 2019 15:59:52 +0000
Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping. r=birtles We fix this by clamping the requestAnimationFrame timestamp in the test before comparing it. We don't clamp the requestAnimationFrame timestamp normally because it would be meaningless: rAF fires on a regular frequency and someone perfoming a fine-grained timing attack will be able to determine the timestamp from when it fires. We need to use parseFloat to knock off any extra epislon we gain. This shouldn't cause any major blow-ups because timelines are disabled in release and beta, so at least any potential fallout would be constrained. Differential Revision: https://phabricator.services.mozilla.com/D38807 Depends on D38806
cd58aae7d47bede2f5699c07855676fa6fc26a09: Bug 1387894 - Disable unconditional clamping for two CSS tests r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:12:39 +0000 - rev 485346
Push 36364 by dvarga@mozilla.com at Tue, 30 Jul 2019 21:50:30 +0000
Bug 1387894 - Disable unconditional clamping for two CSS tests r=birtles We're hitting double imprecision here. Example: Given 86.68392200000000 and 86.67999999999999 we want to see if they're equal with two significant digits. (They are, they're 86.68) However, when we reduce them, 86.68 (which is represented as an epislon lower) gets reduced to 86.66 and they no longer match. We disable unconditional clamping on these tests to confirm they behave the way they shoud... excepting the clamping which may introduce imprecision. Differential Revision: https://phabricator.services.mozilla.com/D38812
ef7b589d751b8fd2882d2740439395010715fd4f: Bug 1387894 - Fix animation WPTs r=birtles,jgraham
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:12:17 +0000 - rev 485344
Push 36364 by dvarga@mozilla.com at Tue, 30 Jul 2019 21:50:30 +0000
Bug 1387894 - Fix animation WPTs r=birtles,jgraham I believe these intermittents are caused by double imprecision. When unconditional clamping is enabled it gets multiplied out and causes animation.currentTime to occasionally go to 50000.02 which causes the test to fail. We can reduce the precision back down to ignore that. We do so using some WPT overrides. Differential Revision: https://phabricator.services.mozilla.com/D38810
75c0249b594a371d250dca81d1f3c60aaad944a3: Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:12:08 +0000 - rev 485343
Push 36364 by dvarga@mozilla.com at Tue, 30 Jul 2019 21:50:30 +0000
Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping r=birtles This has to do with double imprecision. The test originally had toPrecision(6) to account for this imprecision. It'd round up 499.9999 into 500. When we send double(500) (which is an epsilon below 500) into ReduceTimePrecision we wind up coming out with 499.98. By reducing our precision requirement in this test we can handle that and round 499.98 back up to 500 Differential Revision: https://phabricator.services.mozilla.com/D38809
4a75f2556242a972fd49c0ef447df7f26de7344e: Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping r=birtles,hiro
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:11:59 +0000 - rev 485342
Push 36364 by dvarga@mozilla.com at Tue, 30 Jul 2019 21:50:30 +0000
Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping r=birtles,hiro This refactors things to run until the animation is unthrottled. It confirms the proper amount of time has passed; and then awaits another styling to ensure that markers.length = 0 (unless it took very long (over 200ms) that it should be 1. Differential Revision: https://phabricator.services.mozilla.com/D38808
0bff9ba4237cec4f0fc3a66a6f60a1b588b4ce85: Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:11:50 +0000 - rev 485341
Push 36364 by dvarga@mozilla.com at Tue, 30 Jul 2019 21:50:30 +0000
Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping r=birtles We fix this by clamping the requestAnimationFrame timestamp in the test before comparing it. We don't clamp the requestAnimationFrame timestamp normally because it would be meaningless: rAF fires on a regular frequency and someone perfoming a fine-grained timing attack will be able to determine the timestamp from when it fires. We need to use parseFloat to knock off any extra epislon we gain. This shouldn't cause any major blow-ups because timelines are disabled in release and beta, so at least any potential fallout would be constrained. Differential Revision: https://phabricator.services.mozilla.com/D38807
09785dc4c5aa58ddb33531831f60a77371381b1e: Bug 1387894 - Disable unconditional clamping for two CSS tests r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 13:19:15 +0000 - rev 485309
Push 36364 by dvarga@mozilla.com at Tue, 30 Jul 2019 21:50:30 +0000
Bug 1387894 - Disable unconditional clamping for two CSS tests r=birtles We're hitting double imprecision here. Example: Given 86.68392200000000 and 86.67999999999999 we want to see if they're equal with two significant digits. (They are, they're 86.68) However, when we reduce them, 86.68 (which is represented as an epislon lower) gets reduced to 86.66 and they no longer match. We disable unconditional clamping on these tests to confirm they behave the way they shoud... excepting the clamping which may introduce imprecision. Differential Revision: https://phabricator.services.mozilla.com/D38812
01e5b31bcc179b30b4c9d98d64108860467f4726: Bug 1387894 - Fix animation WPTs r=birtles,jgraham
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 13:19:06 +0000 - rev 485307
Push 36364 by dvarga@mozilla.com at Tue, 30 Jul 2019 21:50:30 +0000
Bug 1387894 - Fix animation WPTs r=birtles,jgraham I believe these intermittents are caused by double imprecision. When unconditional clamping is enabled it gets multiplied out and causes animation.currentTime to occasionally go to 50000.02 which causes the test to fail. We can reduce the precision back down to ignore that. We do so using some WPT overrides. Differential Revision: https://phabricator.services.mozilla.com/D38810
c5e16646ddb1166345658a0fbdd6925e568caabc: Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 13:19:05 +0000 - rev 485306
Push 36364 by dvarga@mozilla.com at Tue, 30 Jul 2019 21:50:30 +0000
Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping r=birtles This has to do with double imprecision. The test originally had toPrecision(6) to account for this imprecision. It'd round up 499.9999 into 500. When we send double(500) (which is an epsilon below 500) into ReduceTimePrecision we wind up coming out with 499.98. By reducing our precision requirement in this test we can handle that and round 499.98 back up to 500 Differential Revision: https://phabricator.services.mozilla.com/D38809
d1f09b772baca9dad66477f785bb606a7e83c1bd: Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping r=birtles,hiro
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 13:19:05 +0000 - rev 485305
Push 36364 by dvarga@mozilla.com at Tue, 30 Jul 2019 21:50:30 +0000
Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping r=birtles,hiro This refactors things to run until the animation is unthrottled. It confirms the proper amount of time has passed; and then awaits another styling to ensure that markers.length = 0 (unless it took very long (over 200ms) that it should be 1. Differential Revision: https://phabricator.services.mozilla.com/D38808
de538a48f45583c6da759fe01760773580b6aada: Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 13:19:05 +0000 - rev 485304
Push 36364 by dvarga@mozilla.com at Tue, 30 Jul 2019 21:50:30 +0000
Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping r=birtles We fix this by clamping the requestAnimationFrame timestamp in the test before comparing it. We don't clamp the requestAnimationFrame timestamp normally because it would be meaningless: rAF fires on a regular frequency and someone perfoming a fine-grained timing attack will be able to determine the timestamp from when it fires. We need to use parseFloat to knock off any extra epislon we gain. This shouldn't cause any major blow-ups because timelines are disabled in release and beta, so at least any potential fallout would be constrained. Differential Revision: https://phabricator.services.mozilla.com/D38807
654ddf428c9033b9b7f3ce74182efb8c5516faf5: Bug 1564366 - Update animations when a pseudo-element had animations but no longer has, and has been re-framed in the meantime. r=birtles
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 16 Jul 2019 15:42:08 +0000 - rev 482948
Push 36303 by dvarga@mozilla.com at Wed, 17 Jul 2019 09:36:40 +0000
Bug 1564366 - Update animations when a pseudo-element had animations but no longer has, and has been re-framed in the meantime. r=birtles This is the easy fix. The hard fix (outlined in the comment) would be nice, but I don't think this bug alone justifies it. Differential Revision: https://phabricator.services.mozilla.com/D38184
9f687685a13cb1b0015cfb2f98821e624b42754a: Bug 1534884 - Add new animation warning for animations overridden by important rules. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Fri, 28 Jun 2019 18:18:08 +0000 - rev 480601
Push 36216 by ncsoregi@mozilla.com at Sat, 29 Jun 2019 09:58:05 +0000
Bug 1534884 - Add new animation warning for animations overridden by important rules. r=birtles We move the check of important rule and animation level into KeyframeEffect::ShouldBlockAsyncTransformAnimations(), and add a new warning for it. Note: 1. ShouldBlockAsyncTransformAnimations() only cares about transforms. And for other compositor animation properties, we count on HasEffectiveAnimationOfPropertySet() (in IsMatchForCompositor()). 2. If we check the important rules in both EffectCompositor::HasAnimationsForCompositor() and ActiveLayerTracker::IsTransformMaybeAnimated(), we may get the incorrect animation warnings (i.e. TransformFrameInactive). In most cases, we check these two functions together, so perhaps move the check of important rules outside HasEffectiveAnimationOfPropertySet() is fine. Besides, ActiveLayerTracker just tracks if there is a style change on this property (or display item) on the active layers, so should be OK to not check important rules in it. So IsMatchForCompositor() should check all transform-like properties, instead of each one, to get the correct result. (That's why we have to refactor KeyframeEffect::GetPropertiesForCompositor() as well.) Differential Revision: https://phabricator.services.mozilla.com/D34432
25ed16786ef943e467c94bff2189a5dc25b0b38e: Bug 1560704 - Revert the change `transform-style: inherit` added to ::-moz-table-wrapper in ua.css. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 26 Jun 2019 10:29:37 +0000 - rev 480147
Push 36205 by rgurzau@mozilla.com at Wed, 26 Jun 2019 21:52:21 +0000
Bug 1560704 - Revert the change `transform-style: inherit` added to ::-moz-table-wrapper in ua.css. r=birtles It caused rendering issues just like a reftest in this commit. We don't know the reason but fixing it will be some amount of work which couldn't be uplifted to 68. So we just revert the change here now. Probably we should revisit the problem once we got a bug report that the lack of the `transform-style: inherit` causes rendering issues. Differential Revision: https://phabricator.services.mozilla.com/D35946
0e84cf2872e7002304a700246ae709a8a3a6d9da: Bug 1557563 - Add computed value ZeroToOneNumber r=emilio,birtles
violet <violet.bugreport@gmail.com> - Sun, 23 Jun 2019 23:01:47 +0000 - rev 479904
Push 36192 by ncsoregi@mozilla.com at Mon, 24 Jun 2019 15:24:02 +0000
Bug 1557563 - Add computed value ZeroToOneNumber r=emilio,birtles Correctly handle clamping to 1 behavior of grayscale(), invert(), opacity() and sepia(). Differential Revision: https://phabricator.services.mozilla.com/D35509
17869bc540e5fde8961a19497c3cbb4a4de631f3: Bug 1557793 part 1. Fix incorrect template arguments in AnimationPerformanceWarning. r=birtles
Boris Zbarsky <bzbarsky@mit.edu> - Sun, 09 Jun 2019 22:00:41 +0000 - rev 478253
Push 36138 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:33:19 +0000
Bug 1557793 part 1. Fix incorrect template arguments in AnimationPerformanceWarning. r=birtles It looks like bug 1321412 changed the number of params but didn't update the template parameter, and then bug 1364221 followed its example of not matching the template parameter to the actual number of params. As a result we're passing an array with one garbage pointer to the callee, and it just happens that the callee doesn't examine that pointer. But that's about to change. Differential Revision: https://phabricator.services.mozilla.com/D34234
3fe6750f57d7492bcc3620e4976d19b71d98f872: Bug 1554488 - Add WPT test for baseVal behavior inside symbol/display:none r=birtles
violet <violet.bugreport@gmail.com> - Tue, 04 Jun 2019 11:59:55 +0000 - rev 476761
Push 36106 by btara@mozilla.com at Tue, 04 Jun 2019 16:04:27 +0000
Bug 1554488 - Add WPT test for baseVal behavior inside symbol/display:none r=birtles This test is for baseVal behavior interacting with <symbol>, display:none and font-size. Differential Revision: https://phabricator.services.mozilla.com/D32624
eb7d78fdd5d86d713b8ae88f50413d8c23e9d8f9: Bug 1429303 - Add a missing reftest for offset-distance interpolation. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 28 May 2019 18:31:50 +0000 - rev 475969
Push 36080 by nerli@mozilla.com at Wed, 29 May 2019 09:48:47 +0000
Bug 1429303 - Add a missing reftest for offset-distance interpolation. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D32537
c62c252bb59dac33a79883bc2fcd3e052e713637: Bug 1429303 - Animate offset-rotate. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 28 May 2019 18:31:48 +0000 - rev 475968
Push 36080 by nerli@mozilla.com at Wed, 29 May 2019 09:48:47 +0000
Bug 1429303 - Animate offset-rotate. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D32237
33a7cec553b2b79b4067416fab3191d19243c3bf: Bug 1554457 - Obtain style from frame rather than GetComputedStyleNoFlush r=emilio,longsonr,birtles
violet <violet.bugreport@gmail.com> - Mon, 27 May 2019 05:06:47 +0000 - rev 475692
Push 36072 by dluca@mozilla.com at Tue, 28 May 2019 09:38:00 +0000
Bug 1554457 - Obtain style from frame rather than GetComputedStyleNoFlush r=emilio,longsonr,birtles These usecases are almost the same as the geometry property stuff. It'd be better to use `GetPrimaryFrame()->Style()` consistently rather than using `GetComputedStyleNoFlush()` here. Differential Revision: https://phabricator.services.mozilla.com/D32613
f4260d7b6296c069b410d7a85decfb58cdf9c0eb: Bug 1552345 - Should not assume en is always an accepted language r=birtles
violet <violet.bugreport@gmail.com> - Mon, 27 May 2019 00:17:13 +0000 - rev 475649
Push 36069 by opoprus@mozilla.com at Mon, 27 May 2019 09:54:41 +0000
Bug 1552345 - Should not assume en is always an accepted language r=birtles The test assumes "en" is always an accepted language, it's not correct. This assumption isn't what is being tested here anyway. We should set language preference at the beginning before testing to avoid irrelevant failure. Differential Revision: https://phabricator.services.mozilla.com/D32628
7d73f17d3c58fcadca4d41674973f254ba5f6a6b: Bug 1553154 - enable animation preferences for test_animation_observers_async.html. r=birtles
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 22 May 2019 23:51:19 +0000 - rev 475287
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1553154 - enable animation preferences for test_animation_observers_async.html. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D32035
5514f80c4f48f8dca61cdfc88e2225244c236d19: Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:20 +0000 - rev 474704
Push 36044 by rmaries@mozilla.com at Tue, 21 May 2019 15:45:34 +0000
Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr When animating geometry attribute, we need to notify style system about the change of SMIL override style. Differential Revision: https://phabricator.services.mozilla.com/D30361
e6343b742e91be084079764c242a4cca569423d1: Bug 1429299 - Part 3: Layout update for offset-distance. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 20 May 2019 23:42:54 +0000 - rev 474642
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1429299 - Part 3: Layout update for offset-distance. r=birtles Just need to take offset-distance into account to get the final matrix. Differential Revision: https://phabricator.services.mozilla.com/D30583
a7b8e6460fb8b1245507e9e15deadc1e62674102: Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:58:56 +0000 - rev 474021
Push 36020 by dvarga@mozilla.com at Thu, 16 May 2019 04:15:07 +0000
Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr When animating geometry attribute, we need to notify style system about the change of SMIL override style. Differential Revision: https://phabricator.services.mozilla.com/D30361
2a2a6da7e8990127f5dfa5a2e12d30bb627357a9: Bug 1544216 Part 6 - Make function declaration and definition parameter names match r=birtles
longsonr <longsonr@gmail.com> - Sat, 27 Apr 2019 08:57:46 +0100 - rev 471655
Push 35924 by rmaries@mozilla.com at Sat, 27 Apr 2019 21:40:42 +0000
Bug 1544216 Part 6 - Make function declaration and definition parameter names match r=birtles
2d2c69004a2958bb798a558fe86b3afc07a69e73: Bug 1544216 Part 5 - add noexcept to move constructors and reassignment operators r=birtles
longsonr <longsonr@gmail.com> - Wed, 24 Apr 2019 21:39:47 +0100 - rev 471271
Push 35914 by rgurzau@mozilla.com at Thu, 25 Apr 2019 16:20:57 +0000
Bug 1544216 Part 5 - add noexcept to move constructors and reassignment operators r=birtles
9d57a72036d3ce614762bdb48bdcd1311bc72f12: Bug 1544216 Part 5 - add noexcept to move constructors and reassignment operators r=birtles
longsonr <longsonr@gmail.com> - Wed, 24 Apr 2019 21:39:47 +0100 - rev 471267
Push 35914 by rgurzau@mozilla.com at Thu, 25 Apr 2019 16:20:57 +0000
Bug 1544216 Part 5 - add noexcept to move constructors and reassignment operators r=birtles
fb417cb3679079f3b0b64a26b36a8313991f6752: Bug 1544216 Part 4 - use modern looping r=birtles
longsonr <longsonr@gmail.com> - Wed, 17 Apr 2019 23:32:46 +0100 - rev 470037
Push 35885 by apavel@mozilla.com at Thu, 18 Apr 2019 21:36:48 +0000
Bug 1544216 Part 4 - use modern looping r=birtles
6c81fd084c4f8f6c25539cbca70fb911859218cb: Bug 1544216 Part 3 - simplify boolean logic r=birtles
longsonr <longsonr@gmail.com> - Wed, 17 Apr 2019 23:32:42 +0100 - rev 470036
Push 35885 by apavel@mozilla.com at Thu, 18 Apr 2019 21:36:48 +0000
Bug 1544216 Part 3 - simplify boolean logic r=birtles
d886995a0251f42c2ae25b1ee4d341e217f3fdbe: Bug 1544216 Part 2 - no else after return r=birtles
longsonr <longsonr@gmail.com> - Wed, 17 Apr 2019 23:32:38 +0100 - rev 470035
Push 35885 by apavel@mozilla.com at Thu, 18 Apr 2019 21:36:48 +0000
Bug 1544216 Part 2 - no else after return r=birtles
18169336baefc8485fd3536d91f82c0c9615708b: Bug 1544216 Part 1 - use default keyword instead of empty constructors and destructors r=birtles
longsonr <longsonr@gmail.com> - Wed, 17 Apr 2019 23:04:53 +0100 - rev 470034
Push 35885 by apavel@mozilla.com at Thu, 18 Apr 2019 21:36:48 +0000
Bug 1544216 Part 1 - use default keyword instead of empty constructors and destructors r=birtles
9fe743aa6c94f49346902934f40f8f55663bc54d: Bug 1425837 - Part 8: Test that individual transforms run on the compositor thread. r=hiro,birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Mar 2019 18:05:04 +0000 - rev 464930
Push 35729 by opoprus@mozilla.com at Tue, 19 Mar 2019 16:30:13 +0000
Bug 1425837 - Part 8: Test that individual transforms run on the compositor thread. r=hiro,birtles This also adds the missing preference in test_transition_per_property.html. Depends on D22567 Differential Revision: https://phabricator.services.mozilla.com/D22568
af39dc228d19a34892e32faab8fb105352708099: Bug 1425837 - Part 7: Drop the hard-code disabling compositor animations on individual transforms. r=hiro,birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Mar 2019 18:05:02 +0000 - rev 464929
Push 35729 by opoprus@mozilla.com at Tue, 19 Mar 2019 16:30:13 +0000
Bug 1425837 - Part 7: Drop the hard-code disabling compositor animations on individual transforms. r=hiro,birtles Drop the hack which prevents individual transform running on the compositor thread. Depends on D22566 Differential Revision: https://phabricator.services.mozilla.com/D22567
b27d18cccc623d49dfcd89aa07890ab940d859f5: Bug 1425837 - Part 4: Implement compositor animations on translate/rotate/scale. r=hiro,birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Mar 2019 18:04:50 +0000 - rev 464926
Push 35729 by opoprus@mozilla.com at Tue, 19 Mar 2019 16:30:13 +0000
Bug 1425837 - Part 4: Implement compositor animations on translate/rotate/scale. r=hiro,birtles On the sender side of transactions, we have to convert the individual transforms to the proper types in layers::Animations, and this includes SetAnimatable and the definition in LayersMessages. On the compositor side (i.e. received side of transactions). Basically, we convert the list of layers::Animation into a list of `PropertyAnimationGroup`, which is an intermediate value. And then use this list to do interpolation for each property in `SampleAnimationForEachNode`, which will return a list of `RefPtr<RawServoAnimationValue>`. Depends on D23062 Differential Revision: https://phabricator.services.mozilla.com/D22565
6c55b82deb9ba9b5924ef6bfdecdffaf9f42307a: Bug 1425837 - Part 3: Don't store AnimationArray (a.k.a. AnimationInfo::mAnimations) on the compositor thread. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Mar 2019 18:04:48 +0000 - rev 464925
Push 35729 by opoprus@mozilla.com at Tue, 19 Mar 2019 16:30:13 +0000
Bug 1425837 - Part 3: Don't store AnimationArray (a.k.a. AnimationInfo::mAnimations) on the compositor thread. r=birtles The original implementation about "setting animations" is a little bit hard to read. In `SetAnimations()`, we create a new intermediate data, `AnimData`, and we mutate the original animations. And then iterate this mutated animations & intermediate data for sampling. In this bug, we are planning to group the AnimData as a useful data structure for supporting multiple properties transform-like animations, so it seems the structure of original animations may be hard to use after that. Therefore, we decide to do some reworks on this: First, we do renames, 1. InfalliableTArray to nsTArray. (They are the same.) 2. AnimData to PropertyAnimation. 3. SetAnimations() to ExtractAnimations(), which returns nsTArray<PropertyAnimationGroup>. Each entry in the array is for one property. In this patch, there is only one entry. We will extend this to multiple entries in the next patch. And then rework `ExtractAnimations()`, which stores all the necessary data in `PropertyAnimationGroup`. For WR, we store this in `CompositorAnimationStorage`. For non-WR, we store it in `AnimationInfo`. So we can just use this organized data structure for supporting multiple properties animations. (See the next patch.) Depends on D22563 Differential Revision: https://phabricator.services.mozilla.com/D23062
a9a91a32262e099d6366cb2c7500db10f551bf13: Bug 1413319 - Correctly check a double is within long's limit r=birtles
violet <violet.bugreport@gmail.com> - Sun, 17 Mar 2019 23:34:02 +0000 - rev 464718
Push 35720 by opoprus@mozilla.com at Mon, 18 Mar 2019 09:50:40 +0000
Bug 1413319 - Correctly check a double is within long's limit r=birtles When close to int64_t's limit, the int64 can't be precisely converted to double because of rounding error, rounding-up is also allowed. To ensure a double `d` is within int64's limit, we should check `d < std::numeric_limits<int64_t>::max()`, instead of `<=`. Because `std::numeric_limits<int64_t>::max()` might be converted to a larger double, when they are equal, we can't be sure if `d` is indeed within the actual int64 limit. Differential Revision: https://phabricator.services.mozilla.com/D23680
a7d81b7bc493094223744d4010c87789cdf2977e: Bug 1532205 - Intermittent TEST-UNEXPECTED-TIMEOUT in Event-dispatch-on-disabled-elements.html r=birtles
Marcos Cáceres <mcaceres@mozilla.com> - Fri, 15 Mar 2019 05:49:25 +0000 - rev 464122
Push 35711 by opoprus@mozilla.com at Fri, 15 Mar 2019 16:31:56 +0000
Bug 1532205 - Intermittent TEST-UNEXPECTED-TIMEOUT in Event-dispatch-on-disabled-elements.html r=birtles try to extend the animation time. I tested this locally on repeat 50 times. Differential Revision: https://phabricator.services.mozilla.com/D23498
5849b867ecf7c485b71ca694167f5a63b2d6c6ca: Bug 1322770: Remove bogus assertion from SMIL motion code. r=birtles
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 14 Mar 2019 00:55:31 +0000 - rev 463922
Push 35702 by dvarga@mozilla.com at Thu, 14 Mar 2019 09:44:20 +0000
Bug 1322770: Remove bogus assertion from SMIL motion code. r=birtles We had an assertion here that assumed progression along a motion path must be positive, but that's not the case when we have decreasing values of the `keyPoints` attribute. The assertion wasn't justified and nothing depended on it being valid, so let's just remove it. Differential Revision: https://phabricator.services.mozilla.com/D23354
1ae26ce1cf090db6b0b19ea7d7eccd42373dd5fa: Bug 1215878 - Implement CSS revert keyword. r=heycam,birtles
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Mar 2019 11:59:36 +0000 - rev 462868
Push 35661 by aiakab@mozilla.com at Thu, 07 Mar 2019 21:56:20 +0000
Bug 1215878 - Implement CSS revert keyword. r=heycam,birtles The only fishy bit is the animation stuff. In particular, there are two places where we just mint the revert behavior: * When serializing web-animations keyframes (the custom properties stuff in declaration_block.rs). That codepath is already not sound and I wanted to get rid of it in bug 1501530, but what do I know. * When getting an animation value from a property declaration. At that point we no longer have the CSS rules that apply to the element to compute the right revert value handy. It'd also use the wrong style anyway, I think, given the way StyleBuilder::for_animation works. We _could_ probably get them out of somewhere, but it seems like a whole lot of code reinventing the wheel which is probably not useful, and that Blink and WebKit just cannot implement either since they don't have a rule tree, so it just doesn't seem worth the churn. The custom properties code looks a bit different in order to minimize hash lookups in the common case. FWIW, `revert` for custom properties doesn't seem very useful either, but oh well. Differential Revision: https://phabricator.services.mozilla.com/D21877
1d56a0d3a3236253b297d9928083175c2d1b403e: Bug 1531567 - fix intermittent in Event-dispatch-on-disabled-elements.html r=birtles
Marcos Cáceres <mcaceres@mozilla.com> - Thu, 07 Mar 2019 05:18:46 +0000 - rev 462824
Push 35661 by aiakab@mozilla.com at Thu, 07 Mar 2019 21:56:20 +0000
Bug 1531567 - fix intermittent in Event-dispatch-on-disabled-elements.html r=birtles change how transitions are triggered and extend the animation/transition time. Differential Revision: https://phabricator.services.mozilla.com/D22251
dcabcaa944f5130b4ddb5bccc6076ec50d46f2ca: Bug 1443320 - Drop |aNotify| argument from Element::SetSMILOverrideStyleDeclaration. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 13 Feb 2019 04:44:34 +0000 - rev 458842
Push 35548 by opoprus@mozilla.com at Wed, 13 Feb 2019 09:48:26 +0000
Bug 1443320 - Drop |aNotify| argument from Element::SetSMILOverrideStyleDeclaration. r=birtles The other call site was removed in https://hg.mozilla.org/mozilla-central/rev/e8c0ffefb34f Depends on D19570 Differential Revision: https://phabricator.services.mozilla.com/D19571