searching for reviewer(bhackett)
c9ee59766684: Bug 1467496 - Simplify JSOP_LOOPENTRY handling in IonBuilder. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 11 Jun 2018 10:17:58 -0700 - rev 422298
Push 34124 by aciure@mozilla.com at 2018-06-11 21:55 +0000
Bug 1467496 - Simplify JSOP_LOOPENTRY handling in IonBuilder. r=bhackett
6c222e89103d: Bug 1451198 part 2 - Annotate maybeUninitialized reads in GetUnboxedValue. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Sun, 22 Apr 2018 12:13:48 +0200 - rev 414996
Push 33885 by toros@mozilla.com at 2018-04-22 22:12 +0000
Bug 1451198 part 2 - Annotate maybeUninitialized reads in GetUnboxedValue. r=bhackett
5f017a1dc4a9: Bug 1451198 part 1 - Move GetUnboxedValue and SetUnboxedValue to cpp file. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Sun, 22 Apr 2018 12:11:53 +0200 - rev 414995
Push 33885 by toros@mozilla.com at 2018-04-22 22:12 +0000
Bug 1451198 part 1 - Move GetUnboxedValue and SetUnboxedValue to cpp file. r=bhackett
78d53646681e: Update sixgill to ab06fc42cf0f for bug 1450379, r=bhackett
Steve Fink <sfink@mozilla.com> - Fri, 30 Mar 2018 15:33:15 -0700 - rev 410849
Push 33743 by ncsoregi@mozilla.com at 2018-03-31 10:06 +0000
Update sixgill to ab06fc42cf0f for bug 1450379, r=bhackett
26dacf2a27a7: Bug 1443233 - Update sixgill to use same qualification settings for all type printing, r=bhackett
Steve Fink <sfink@mozilla.com> - Tue, 06 Mar 2018 08:37:02 -0800 - rev 408091
Push 33626 by aiakab@mozilla.com at 2018-03-14 10:01 +0000
Bug 1443233 - Update sixgill to use same qualification settings for all type printing, r=bhackett
99f75fa495ae: Bug 1441587 part 2 - Remove AddObjectsForPropertyRead optimization. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 28 Feb 2018 11:49:12 +0100 - rev 405750
Push 33531 by csabou@mozilla.com at 2018-02-28 21:49 +0000
Bug 1441587 part 2 - Remove AddObjectsForPropertyRead optimization. r=bhackett
ffc903ba2f04: Bug 1441587 part 1 - Track polymorphic call targets better in IonBuilder. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 28 Feb 2018 11:48:03 +0100 - rev 405749
Push 33531 by csabou@mozilla.com at 2018-02-28 21:49 +0000
Bug 1441587 part 1 - Track polymorphic call targets better in IonBuilder. r=bhackett
e7519d21db96: Bug 1437471 - Use singleton type only for big typed arrays created with an existing buffer. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Feb 2018 12:39:59 +0100 - rev 403678
Push 33443 by dluca@mozilla.com at 2018-02-14 22:23 +0000
Bug 1437471 - Use singleton type only for big typed arrays created with an existing buffer. r=bhackett
6be5a45a855e: Bug 1427126 - Use setElementWithType instead of setElement in AppendToList. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 09 Jan 2018 16:37:12 -0500 - rev 398507
Push 33221 by rgurzau@mozilla.com at 2018-01-10 09:58 +0000
Bug 1427126 - Use setElementWithType instead of setElement in AppendToList. r=bhackett
bba4a6269557: Bug 1404636 part 2 - Add test, asserts. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Fri, 05 Jan 2018 15:15:10 +0100 - rev 398000
Push 33197 by archaeopteryx@coole-files.de at 2018-01-05 22:34 +0000
Bug 1404636 part 2 - Add test, asserts. r=bhackett
f5ea86116d56: Bug 1418966 - Pin TypeScripts better when doing Baseline debug mode OSR. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 13 Dec 2017 14:13:43 -0600 - rev 396288
Push 33087 by dluca@mozilla.com at 2017-12-14 09:54 +0000
Bug 1418966 - Pin TypeScripts better when doing Baseline debug mode OSR. r=bhackett
fd5e1a313cfb: Bug 1412289 - Add a shell function to enable NativeObject::checkShapeConsistency. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 12 Dec 2017 15:40:13 -0600 - rev 396161
Push 33081 by csabou@mozilla.com at 2017-12-13 10:14 +0000
Bug 1412289 - Add a shell function to enable NativeObject::checkShapeConsistency. r=bhackett
e1f3dfd40107: Bug 1423231 - Remove redundant BaseShape::getUnowned calls from putAccessorProperty/putDataProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Thu, 07 Dec 2017 13:24:02 +0100 - rev 395476
Push 33045 by shindli@mozilla.com at 2017-12-07 22:12 +0000
Bug 1423231 - Remove redundant BaseShape::getUnowned calls from putAccessorProperty/putDataProperty. r=bhackett
10aa5c0593fa: Bug 1422726 - Optimize addEnumerableDataProperty by adding a fast path for the most common case. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 04 Dec 2017 14:56:06 +0100 - rev 394878
Push 33020 by btara@mozilla.com at 2017-12-04 20:21 +0000
Bug 1422726 - Optimize addEnumerableDataProperty by adding a fast path for the most common case. r=bhackett
cb39c30dc214: Bug 1394831 part 19 - Factor out maybeToDictionaryModeForPut. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:54:12 +0100 - rev 391566
Push 32893 by ncsoregi@mozilla.com at 2017-11-13 22:58 +0000
Bug 1394831 part 19 - Factor out maybeToDictionaryModeForPut. r=bhackett
53a3033449d3: Bug 1394831 part 18 - Factor out updateDictionaryTable. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:53:14 +0100 - rev 391565
Push 32893 by ncsoregi@mozilla.com at 2017-11-13 22:58 +0000
Bug 1394831 part 18 - Factor out updateDictionaryTable. r=bhackett
f1b13194212c: Bug 1394831 part 17 - Factor out maybeConvertToOrGrowDictionaryForAdd. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:52:38 +0100 - rev 391564
Push 32893 by ncsoregi@mozilla.com at 2017-11-13 22:58 +0000
Bug 1394831 part 17 - Factor out maybeConvertToOrGrowDictionaryForAdd. r=bhackett
ce448d8a91b3: Bug 1394831 part 16 - Scope table/entry better in putDataProperty/putAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:52:04 +0100 - rev 391563
Push 32893 by ncsoregi@mozilla.com at 2017-11-13 22:58 +0000
Bug 1394831 part 16 - Scope table/entry better in putDataProperty/putAccessorProperty. r=bhackett
ef44b38b852a: Bug 1394831 part 15 - Pass ShapeTable* to add*Property. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:51:10 +0100 - rev 391562
Push 32893 by ncsoregi@mozilla.com at 2017-11-13 22:58 +0000
Bug 1394831 part 15 - Pass ShapeTable* to add*Property. r=bhackett
9b5afe75d13f: Bug 1415489 - Use SingletonObject for Array.prototype[@@unscopables]. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Sat, 11 Nov 2017 13:32:56 +0100 - rev 391417
Push 32878 by ccoroiu@mozilla.com at 2017-11-11 22:05 +0000
Bug 1415489 - Use SingletonObject for Array.prototype[@@unscopables]. r=bhackett
18f007118b1c: Bug 1394831 part 14 - Fix comments. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Nov 2017 15:59:40 +0100 - rev 390815
Push 32845 by archaeopteryx@coole-files.de at 2017-11-08 22:08 +0000
Bug 1394831 part 14 - Fix comments. r=bhackett
fb4629b12e96: Bug 1394831 part 13 - Remove flags argument from StackShape constructor. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Nov 2017 15:59:22 +0100 - rev 390814
Push 32845 by archaeopteryx@coole-files.de at 2017-11-08 22:08 +0000
Bug 1394831 part 13 - Remove flags argument from StackShape constructor. r=bhackett
aba68ef3a080: Bug 1394831 part 12 - Remove unused flags argument from matchesParamsAfterId. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Nov 2017 15:58:57 +0100 - rev 390813
Push 32845 by archaeopteryx@coole-files.de at 2017-11-08 22:08 +0000
Bug 1394831 part 12 - Remove unused flags argument from matchesParamsAfterId. r=bhackett
b44bda5764ca: Bug 1394831 part 11 - Split getChildProperty in data vs accessor versions. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Nov 2017 15:58:31 +0100 - rev 390812
Push 32845 by archaeopteryx@coole-files.de at 2017-11-08 22:08 +0000
Bug 1394831 part 11 - Split getChildProperty in data vs accessor versions. r=bhackett
9d8e2a8c4c03: Bug 1394831 part 10 - Simplify addDataProperty's slot argument. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Nov 2017 15:57:12 +0100 - rev 390811
Push 32845 by archaeopteryx@coole-files.de at 2017-11-08 22:08 +0000
Bug 1394831 part 10 - Simplify addDataProperty's slot argument. r=bhackett
19d68ad55452: Bug 1394831 part 9 - Remove allowDictionary argument from addAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:40:17 +0100 - rev 389627
Push 32789 by archaeopteryx@coole-files.de at 2017-11-01 21:55 +0000
Bug 1394831 part 9 - Remove allowDictionary argument from addAccessorProperty. r=bhackett
444453765199: Bug 1394831 part 8 - Remove flags argument from addAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:39:52 +0100 - rev 389626
Push 32789 by archaeopteryx@coole-files.de at 2017-11-01 21:55 +0000
Bug 1394831 part 8 - Remove flags argument from addAccessorProperty. r=bhackett
706c6d389111: Bug 1394831 part 7 - Remove flags and allowDictionary arguments from addDataProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:39:22 +0100 - rev 389625
Push 32789 by archaeopteryx@coole-files.de at 2017-11-01 21:55 +0000
Bug 1394831 part 7 - Remove flags and allowDictionary arguments from addDataProperty. r=bhackett
88bfd12dc099: Bug 1394831 part 6 - Remove flags argument from putAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:38:58 +0100 - rev 389624
Push 32789 by archaeopteryx@coole-files.de at 2017-11-01 21:55 +0000
Bug 1394831 part 6 - Remove flags argument from putAccessorProperty. r=bhackett
4fece077634f: Bug 1394831 part 5 - Remove slot and flags arguments from putDataProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 31 Oct 2017 15:19:45 +0100 - rev 389439
Push 32787 by ncsoregi@mozilla.com at 2017-11-01 10:14 +0000
Bug 1394831 part 5 - Remove slot and flags arguments from putDataProperty. r=bhackett
d1489f9302ca: Bug 1394831 part 4 - Add an AutoCheckShapeConsistency RAII class. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 31 Oct 2017 15:19:45 +0100 - rev 389438
Push 32787 by ncsoregi@mozilla.com at 2017-11-01 10:14 +0000
Bug 1394831 part 4 - Add an AutoCheckShapeConsistency RAII class. r=bhackett
ec639f2d7888: Bug 1394831 part 3 - Add an early return, unindent some code. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 31 Oct 2017 15:19:44 +0100 - rev 389437
Push 32787 by ncsoregi@mozilla.com at 2017-11-01 10:14 +0000
Bug 1394831 part 3 - Add an early return, unindent some code. r=bhackett
1fccf231f26c: Bug 1394831 part 2 - Split putProperty in separate accessor vs data property overloads. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 31 Oct 2017 15:19:39 +0100 - rev 389436
Push 32787 by ncsoregi@mozilla.com at 2017-11-01 10:14 +0000
Bug 1394831 part 2 - Split putProperty in separate accessor vs data property overloads. r=bhackett
b7cfc0c69ca7: Bug 1394831 part 1 - Split addProperty(Internal) in separate accessor vs data property overloads. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 31 Oct 2017 15:17:07 +0100 - rev 389435
Push 32787 by ncsoregi@mozilla.com at 2017-11-01 10:14 +0000
Bug 1394831 part 1 - Split addProperty(Internal) in separate accessor vs data property overloads. r=bhackett
74d76655c919: Bug 1404636 - Special-case typed arrays in PropertyReadNeedsTypeBarrier. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Thu, 26 Oct 2017 16:15:35 +0200 - rev 388582
Push 32754 by archaeopteryx@coole-files.de at 2017-10-27 09:46 +0000
Bug 1404636 - Special-case typed arrays in PropertyReadNeedsTypeBarrier. r=bhackett
9408d9199042: Bug 1402582 - Make shell's EnvironmentPreparer grab cx from TLS. r=bhackett
Steve Fink <sfink@mozilla.com> - Tue, 10 Oct 2017 16:16:21 -0700 - rev 386164
Push 32676 by archaeopteryx@coole-files.de at 2017-10-13 21:38 +0000
Bug 1402582 - Make shell's EnvironmentPreparer grab cx from TLS. r=bhackett
0e603ab6e960: Bug 1404395 - Remove unnecessary shape() null checks in PreliminaryObjectArrayWithTemplate::maybeAnalyze. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 03 Oct 2017 10:07:33 +0200 - rev 384182
Push 32624 by kwierso@gmail.com at 2017-10-03 21:37 +0000
Bug 1404395 - Remove unnecessary shape() null checks in PreliminaryObjectArrayWithTemplate::maybeAnalyze. r=bhackett
d7209c7f31af: Bug 1400442 - Special-case annotation for a->b->emplace(); a->b->Init(), r=bhackett
Steve Fink <sfink@mozilla.com> - Fri, 15 Sep 2017 17:17:49 -0700 - rev 381743
Push 32536 by kwierso@gmail.com at 2017-09-19 21:49 +0000
Bug 1400442 - Special-case annotation for a->b->emplace(); a->b->Init(), r=bhackett
eb2b0c8fa756: Bug 1400442 - Annotate border colors array as being thread-owned by container, r=bhackett
Steve Fink <sfink@mozilla.com> - Fri, 15 Sep 2017 17:18:08 -0700 - rev 381738
Push 32536 by kwierso@gmail.com at 2017-09-19 21:49 +0000
Bug 1400442 - Annotate border colors array as being thread-owned by container, r=bhackett nsStyleStruct has the field: nsBorderColors** mBorderColors; It starts out nullptr, and when it is needed, it allocates an array of 4 nsBorderColors pointers. But the nsStyleStruct exclusively owns the array; nothing else can get at it. This change teaches the analysis that if 'this' is a safe nsStyleStruct*, then it should treat mBorderColors as if it were an inline length-4 array.
4ff3e372de3d: Bug 1400442 - analyzeHeapWrites: getter_Copies preserves safety (similar to getter_AddRefs), r=bhackett
Steve Fink <sfink@mozilla.com> - Fri, 08 Sep 2017 15:03:06 -0700 - rev 381736
Push 32536 by kwierso@gmail.com at 2017-09-19 21:49 +0000
Bug 1400442 - analyzeHeapWrites: getter_Copies preserves safety (similar to getter_AddRefs), r=bhackett
c5239fd503f2: Bug 1400442 - Targeted annotation for static local array of member pointers in LangGroupFontPrefs::Initialize, r=bhackett
Steve Fink <sfink@mozilla.com> - Fri, 08 Sep 2017 15:03:22 -0700 - rev 381730
Push 32536 by kwierso@gmail.com at 2017-09-19 21:49 +0000
Bug 1400442 - Targeted annotation for static local array of member pointers in LangGroupFontPrefs::Initialize, r=bhackett The code is void LangGroupFontPrefs::Initialize(nsIAtom* aLangGroupAtom) { nsFont* fontTypes[] = { &mDefaultVariableFont, &mDefaultFixedFont, &mDefaultSerifFont, &mDefaultSansSerifFont, &mDefaultMonospaceFont, &mDefaultCursiveFont, &mDefaultFantasyFont }; nsFont* font = fontTypes[3]; font->size = 42; } 'this' is known to be a safe pointer (exclusively owned by the current thread), so a pointer to one of its members is also safe. But the analysis can't track safety across all that, so I have a special-case annotation here that says that fontTypes[3] returns a safe pointer if and only if 'this' is safe. Note that all of those fields (eg mDefaultVariableFont) are nsFont structs, not pointers, so although you'd expect this to be one dereference away from a safe pointer's memory, it is not; assigning to font->size ends up being a write to some offset within the 'this' pointer, which is known to be safe here.
6696c7a9ed71: Bug 1400442 - Propagate safety through RefPtr, r=bhackett
Steve Fink <sfink@mozilla.com> - Thu, 31 Aug 2017 09:47:53 -0700 - rev 381728
Push 32536 by kwierso@gmail.com at 2017-09-19 21:49 +0000
Bug 1400442 - Propagate safety through RefPtr, r=bhackett
05f6da3339b3: Bug 1384121 part 1 - Don't sweep ObjectGroups under IC helper functions. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 18 Sep 2017 15:08:44 +0200 - rev 381485
Push 32531 by kwierso@gmail.com at 2017-09-18 23:21 +0000
Bug 1384121 part 1 - Don't sweep ObjectGroups under IC helper functions. r=bhackett
2b18295208be: Bug 1389974 - Remove the implication that killing a value overrides using it, r=bhackett
Steve Fink <sfink@mozilla.com> - Fri, 01 Sep 2017 09:56:15 -0700 - rev 380103
Push 32477 by kwierso@gmail.com at 2017-09-11 21:41 +0000
Bug 1389974 - Remove the implication that killing a value overrides using it, r=bhackett
66023b60b9aa: Bug 1395919 - Don't copy the unknown-properties flag in AddPropertyTypesAfterProtoChange. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Thu, 07 Sep 2017 12:51:45 +0200 - rev 379527
Push 32456 by archaeopteryx@coole-files.de at 2017-09-07 22:00 +0000
Bug 1395919 - Don't copy the unknown-properties flag in AddPropertyTypesAfterProtoChange. r=bhackett
df79199f9f0f: Bug 1385165 - Calculate spill weight of a range's uses when add to or remove from it. r=bhackett
Ting-Yu Chou <janus926@gmail.com> - Mon, 14 Aug 2017 15:24:58 +0800 - rev 374987
Push 32343 by cbook@mozilla.com at 2017-08-16 09:20 +0000
Bug 1385165 - Calculate spill weight of a range's uses when add to or remove from it. r=bhackett Iterating a LiveRange's uses in BacktrackingAllocator::computeSpillWeight() to access UsePosition.uses_ isn't cache friendly, because it is a linked list and each node is allocated separately. Changing the data strcture to a vector is worse because of the overhead from frequent insertion/removing. However, UsePostion.uses_ can't be changed after initialization, so we can pre-calculate the spill weight when it is added to or remove from a LiveRange. MozReview-Commit-ID: BJEvI7KBVAJ
487266e0b378: Bug 1382449 - irregexp: Do not assert for stack overflow exceptions. r=bhackett
Nicolas B. Pierron <nicolas.b.pierron@mozilla.com> - Tue, 08 Aug 2017 13:50:08 +0000 - rev 373406
Push 32302 by kwierso@gmail.com at 2017-08-08 22:14 +0000
Bug 1382449 - irregexp: Do not assert for stack overflow exceptions. r=bhackett
085a687a81d9: Bug 1387394 - irregexp::InterpretCode: don't heap-allocate |registers|. r=bhackett.
Julian Seward <jseward@acm.org> - Tue, 08 Aug 2017 09:29:06 +0200 - rev 373394
Push 32302 by kwierso@gmail.com at 2017-08-08 22:14 +0000
Bug 1387394 - irregexp::InterpretCode: don't heap-allocate |registers|. r=bhackett.
afcf2e48a28e: Bug 1387535 part 3 - Rewrite Label implementation to hopefully fix PGO regression. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 08 Aug 2017 13:56:06 +0200 - rev 373393
Push 32302 by kwierso@gmail.com at 2017-08-08 22:14 +0000
Bug 1387535 part 3 - Rewrite Label implementation to hopefully fix PGO regression. r=bhackett
45d45d3e658f: Bug 1387535 part 2 - Encapsulate Label fields better. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 08 Aug 2017 13:55:08 +0200 - rev 373392
Push 32302 by kwierso@gmail.com at 2017-08-08 22:14 +0000
Bug 1387535 part 2 - Encapsulate Label fields better. r=bhackett