searching for reviewer(bhackett)
2599b449d317: Bug 1505181 - Use canonical function in TypeNewScript::rollbackPartiallyInitializedObjects. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 07 Nov 2018 21:12:45 +0100 - rev 446022
Push 35032 by nerli@mozilla.com at Tue, 13 Nov 2018 16:27:59 +0000
Bug 1505181 - Use canonical function in TypeNewScript::rollbackPartiallyInitializedObjects. r=bhackett Differential Revision: https://phabricator.services.mozilla.com/D11224
ae382e944ea8: Bug 1506554 part 4 - Remove an unnecessary ensureHasTypes call in DebugEnvironmentProxyHandler::handleUnaliasedAccess. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 12 Nov 2018 13:03:53 +0100 - rev 446021
Push 35032 by nerli@mozilla.com at Tue, 13 Nov 2018 16:27:59 +0000
Bug 1506554 part 4 - Remove an unnecessary ensureHasTypes call in DebugEnvironmentProxyHandler::handleUnaliasedAccess. r=bhackett Differential Revision: https://phabricator.services.mozilla.com/D11627
9018814d9671: Bug 1506479 - Discard TypeScripts in Zone::discardJitCode instead of during type sweeping. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 12 Nov 2018 02:30:15 +0000 - rev 445842
Push 35025 by rmaries@mozilla.com at Mon, 12 Nov 2018 09:52:04 +0000
Bug 1506479 - Discard TypeScripts in Zone::discardJitCode instead of during type sweeping. r=bhackett I also had to make some small changes to relazification for XDR tests for that to pass. Differential Revision: https://phabricator.services.mozilla.com/D11587
2b1b4f5f678d: Bug 1496600 - Restyle the tab. r=bhackett
Jason Laster <jlaster@mozilla.com> - Thu, 08 Nov 2018 11:45:04 -0500 - rev 445264
Push 35014 by dvarga@mozilla.com at Fri, 09 Nov 2018 10:01:40 +0000
Bug 1496600 - Restyle the tab. r=bhackett Reviewers: bhackett Tags: Bug #: 1496600 Differential Revision: https://phabricator.services.mozilla.com/D11342
6439938f550c: Bug 1504057 - The timeline should show console messages. r=bhackett
Jason Laster <jlaster@mozilla.com> - Wed, 07 Nov 2018 20:14:30 -0500 - rev 445259
Push 35014 by dvarga@mozilla.com at Fri, 09 Nov 2018 10:01:40 +0000
Bug 1504057 - The timeline should show console messages. r=bhackett Tags: Differential Revision: https://phabricator.services.mozilla.com/D11274
33f8860558aa: Bug 1504213 - Migrate the timeline to the toolbox. r=bhackett
Jason Laster <jlaster@mozilla.com> - Fri, 02 Nov 2018 10:17:56 -0400 - rev 444274
Push 34986 by shindli@mozilla.com at Sat, 03 Nov 2018 09:44:53 +0000
Bug 1504213 - Migrate the timeline to the toolbox. r=bhackett Reviewers: bhackett Tags: Bug #: 1504213 Differential Revision: https://phabricator.services.mozilla.com/D10719
d0a0ec48e0dd: Bug 1503853 - Add progress overlay command buttons. r=bhackett
Jason Laster <jlaster@mozilla.com> - Thu, 01 Nov 2018 09:12:29 -0400 - rev 443989
Push 34977 by dvarga@mozilla.com at Thu, 01 Nov 2018 22:29:07 +0000
Bug 1503853 - Add progress overlay command buttons. r=bhackett Reviewers: bhackett Tags: Bug #: 1503853 Differential Revision: https://phabricator.services.mozilla.com/D10551
bb810bff5427: Bug 1503703 - Style progress overlay. r=bhackett
Jason Laster <jlaster@mozilla.com> - Wed, 31 Oct 2018 17:30:18 -0400 - rev 443964
Push 34977 by dvarga@mozilla.com at Thu, 01 Nov 2018 22:29:07 +0000
Bug 1503703 - Style progress overlay. r=bhackett Differential Revision: https://phabricator.services.mozilla.com/D10425
33454859eab6: Bug 1493900. r=bhackett,sunfish
Jan de Mooij <jdemooij@mozilla.com> - Tue, 25 Sep 2018 12:14:11 +0200 - rev 438964
Push 34749 by nerli@mozilla.com at Mon, 01 Oct 2018 16:21:48 +0000
Bug 1493900. r=bhackett,sunfish
d7298a19ae43: Bug 1479429 - Add a range check for the argument to Debugger.Script.prototype.get{Predecessor,Successor}Offsets. r=bhackett
Jason Orendorff <jorendorff@mozilla.com> - Thu, 09 Aug 2018 15:29:37 -0500 - rev 432917
Push 34490 by cbrindusan@mozilla.com at Wed, 22 Aug 2018 22:00:40 +0000
Bug 1479429 - Add a range check for the argument to Debugger.Script.prototype.get{Predecessor,Successor}Offsets. r=bhackett
cd0422cab7e8: Bug 1483166 - refactor evalWithDebugger into its own file; r=nchevobbe,bhackett
yulia <ystartsev@mozilla.com> - Tue, 21 Aug 2018 14:01:02 +0000 - rev 432661
Push 34483 by apavel@mozilla.com at Wed, 22 Aug 2018 03:34:42 +0000
Bug 1483166 - refactor evalWithDebugger into its own file; r=nchevobbe,bhackett this combines the changes that I made in bug 1464461 (https://reviewboard.mozilla.org/r/253132/diff/1#index_header) with the changes for web replay made by Brian Hackett, along with some clean up that was done by Honza with regards to helpers being executed. This change should not have any functional impact on the code base, but it should make it easier to work with the evalWithDebugger functionality than it has been so far. Differential Revision: https://phabricator.services.mozilla.com/D3311
fda28e376a50: Bug 1483166 - refactor evalWithDebugger into its own file; r=nchevobbe,bhackett
yulia <ystartsev@mozilla.com> - Mon, 20 Aug 2018 14:16:35 +0000 - rev 432354
Push 34475 by ncsoregi@mozilla.com at Mon, 20 Aug 2018 21:59:24 +0000
Bug 1483166 - refactor evalWithDebugger into its own file; r=nchevobbe,bhackett this combines the changes that I made in bug 1464461 (https://reviewboard.mozilla.org/r/253132/diff/1#index_header) with the changes for web replay made by Brian Hackett, along with some clean up that was done by Honza with regards to helpers being executed. This change should not have any functional impact on the code base, but it should make it easier to work with the evalWithDebugger functionality than it has been so far. Differential Revision: https://phabricator.services.mozilla.com/D3311
28d1ff679d50: Bug 1481184 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in toolkit/recordreplay. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Aug 2018 12:51:13 +0200 - rev 430609
Push 34410 by toros@mozilla.com at Thu, 09 Aug 2018 10:02:47 +0000
Bug 1481184 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in toolkit/recordreplay. r=bhackett
4e35974cdc14: Bug 1479363 part 11 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in toolkit/recordreplay/ipc. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 31 Jul 2018 08:37:58 +0200 - rev 429330
Push 34359 by shindli@mozilla.com at Tue, 31 Jul 2018 09:53:19 +0000
Bug 1479363 part 11 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in toolkit/recordreplay/ipc. r=bhackett
061213ccc62a: Bug 1477540 - Use RemoveLastElement instead of PopLastElement r=bhackett
Sylvestre Ledru <sledru@mozilla.com> - Sun, 22 Jul 2018 16:23:57 +0200 - rev 427709
Push 34313 by csabou@mozilla.com at Mon, 23 Jul 2018 09:29:32 +0000
Bug 1477540 - Use RemoveLastElement instead of PopLastElement r=bhackett The later is only interesting when the returned value is used MozReview-Commit-ID: 8CF5HSkcttf
c9ee59766684: Bug 1467496 - Simplify JSOP_LOOPENTRY handling in IonBuilder. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 11 Jun 2018 10:17:58 -0700 - rev 422298
Push 34124 by aciure@mozilla.com at Mon, 11 Jun 2018 21:55:18 +0000
Bug 1467496 - Simplify JSOP_LOOPENTRY handling in IonBuilder. r=bhackett
6c222e89103d: Bug 1451198 part 2 - Annotate maybeUninitialized reads in GetUnboxedValue. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Sun, 22 Apr 2018 12:13:48 +0200 - rev 414996
Push 33885 by toros@mozilla.com at Sun, 22 Apr 2018 22:12:17 +0000
Bug 1451198 part 2 - Annotate maybeUninitialized reads in GetUnboxedValue. r=bhackett
5f017a1dc4a9: Bug 1451198 part 1 - Move GetUnboxedValue and SetUnboxedValue to cpp file. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Sun, 22 Apr 2018 12:11:53 +0200 - rev 414995
Push 33885 by toros@mozilla.com at Sun, 22 Apr 2018 22:12:17 +0000
Bug 1451198 part 1 - Move GetUnboxedValue and SetUnboxedValue to cpp file. r=bhackett
78d53646681e: Update sixgill to ab06fc42cf0f for bug 1450379, r=bhackett
Steve Fink <sfink@mozilla.com> - Fri, 30 Mar 2018 15:33:15 -0700 - rev 410849
Push 33743 by ncsoregi@mozilla.com at Sat, 31 Mar 2018 10:06:30 +0000
Update sixgill to ab06fc42cf0f for bug 1450379, r=bhackett
26dacf2a27a7: Bug 1443233 - Update sixgill to use same qualification settings for all type printing, r=bhackett
Steve Fink <sfink@mozilla.com> - Tue, 06 Mar 2018 08:37:02 -0800 - rev 408091
Push 33626 by aiakab@mozilla.com at Wed, 14 Mar 2018 10:01:05 +0000
Bug 1443233 - Update sixgill to use same qualification settings for all type printing, r=bhackett
99f75fa495ae: Bug 1441587 part 2 - Remove AddObjectsForPropertyRead optimization. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 28 Feb 2018 11:49:12 +0100 - rev 405750
Push 33531 by csabou@mozilla.com at Wed, 28 Feb 2018 21:49:08 +0000
Bug 1441587 part 2 - Remove AddObjectsForPropertyRead optimization. r=bhackett
ffc903ba2f04: Bug 1441587 part 1 - Track polymorphic call targets better in IonBuilder. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 28 Feb 2018 11:48:03 +0100 - rev 405749
Push 33531 by csabou@mozilla.com at Wed, 28 Feb 2018 21:49:08 +0000
Bug 1441587 part 1 - Track polymorphic call targets better in IonBuilder. r=bhackett
e7519d21db96: Bug 1437471 - Use singleton type only for big typed arrays created with an existing buffer. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Feb 2018 12:39:59 +0100 - rev 403678
Push 33443 by dluca@mozilla.com at Wed, 14 Feb 2018 22:23:22 +0000
Bug 1437471 - Use singleton type only for big typed arrays created with an existing buffer. r=bhackett
6be5a45a855e: Bug 1427126 - Use setElementWithType instead of setElement in AppendToList. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 09 Jan 2018 16:37:12 -0500 - rev 398507
Push 33221 by rgurzau@mozilla.com at Wed, 10 Jan 2018 09:58:44 +0000
Bug 1427126 - Use setElementWithType instead of setElement in AppendToList. r=bhackett
bba4a6269557: Bug 1404636 part 2 - Add test, asserts. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Fri, 05 Jan 2018 15:15:10 +0100 - rev 398000
Push 33197 by archaeopteryx@coole-files.de at Fri, 05 Jan 2018 22:34:03 +0000
Bug 1404636 part 2 - Add test, asserts. r=bhackett
f5ea86116d56: Bug 1418966 - Pin TypeScripts better when doing Baseline debug mode OSR. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 13 Dec 2017 14:13:43 -0600 - rev 396288
Push 33087 by dluca@mozilla.com at Thu, 14 Dec 2017 09:54:55 +0000
Bug 1418966 - Pin TypeScripts better when doing Baseline debug mode OSR. r=bhackett
fd5e1a313cfb: Bug 1412289 - Add a shell function to enable NativeObject::checkShapeConsistency. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 12 Dec 2017 15:40:13 -0600 - rev 396161
Push 33081 by csabou@mozilla.com at Wed, 13 Dec 2017 10:14:59 +0000
Bug 1412289 - Add a shell function to enable NativeObject::checkShapeConsistency. r=bhackett
e1f3dfd40107: Bug 1423231 - Remove redundant BaseShape::getUnowned calls from putAccessorProperty/putDataProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Thu, 07 Dec 2017 13:24:02 +0100 - rev 395476
Push 33045 by shindli@mozilla.com at Thu, 07 Dec 2017 22:12:36 +0000
Bug 1423231 - Remove redundant BaseShape::getUnowned calls from putAccessorProperty/putDataProperty. r=bhackett
10aa5c0593fa: Bug 1422726 - Optimize addEnumerableDataProperty by adding a fast path for the most common case. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 04 Dec 2017 14:56:06 +0100 - rev 394878
Push 33020 by btara@mozilla.com at Mon, 04 Dec 2017 20:21:20 +0000
Bug 1422726 - Optimize addEnumerableDataProperty by adding a fast path for the most common case. r=bhackett
cb39c30dc214: Bug 1394831 part 19 - Factor out maybeToDictionaryModeForPut. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:54:12 +0100 - rev 391566
Push 32893 by ncsoregi@mozilla.com at Mon, 13 Nov 2017 22:58:13 +0000
Bug 1394831 part 19 - Factor out maybeToDictionaryModeForPut. r=bhackett
53a3033449d3: Bug 1394831 part 18 - Factor out updateDictionaryTable. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:53:14 +0100 - rev 391565
Push 32893 by ncsoregi@mozilla.com at Mon, 13 Nov 2017 22:58:13 +0000
Bug 1394831 part 18 - Factor out updateDictionaryTable. r=bhackett
f1b13194212c: Bug 1394831 part 17 - Factor out maybeConvertToOrGrowDictionaryForAdd. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:52:38 +0100 - rev 391564
Push 32893 by ncsoregi@mozilla.com at Mon, 13 Nov 2017 22:58:13 +0000
Bug 1394831 part 17 - Factor out maybeConvertToOrGrowDictionaryForAdd. r=bhackett
ce448d8a91b3: Bug 1394831 part 16 - Scope table/entry better in putDataProperty/putAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:52:04 +0100 - rev 391563
Push 32893 by ncsoregi@mozilla.com at Mon, 13 Nov 2017 22:58:13 +0000
Bug 1394831 part 16 - Scope table/entry better in putDataProperty/putAccessorProperty. r=bhackett
ef44b38b852a: Bug 1394831 part 15 - Pass ShapeTable* to add*Property. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:51:10 +0100 - rev 391562
Push 32893 by ncsoregi@mozilla.com at Mon, 13 Nov 2017 22:58:13 +0000
Bug 1394831 part 15 - Pass ShapeTable* to add*Property. r=bhackett
9b5afe75d13f: Bug 1415489 - Use SingletonObject for Array.prototype[@@unscopables]. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Sat, 11 Nov 2017 13:32:56 +0100 - rev 391417
Push 32878 by ccoroiu@mozilla.com at Sat, 11 Nov 2017 22:05:38 +0000
Bug 1415489 - Use SingletonObject for Array.prototype[@@unscopables]. r=bhackett
18f007118b1c: Bug 1394831 part 14 - Fix comments. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Nov 2017 15:59:40 +0100 - rev 390815
Push 32845 by archaeopteryx@coole-files.de at Wed, 08 Nov 2017 22:08:47 +0000
Bug 1394831 part 14 - Fix comments. r=bhackett
fb4629b12e96: Bug 1394831 part 13 - Remove flags argument from StackShape constructor. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Nov 2017 15:59:22 +0100 - rev 390814
Push 32845 by archaeopteryx@coole-files.de at Wed, 08 Nov 2017 22:08:47 +0000
Bug 1394831 part 13 - Remove flags argument from StackShape constructor. r=bhackett
aba68ef3a080: Bug 1394831 part 12 - Remove unused flags argument from matchesParamsAfterId. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Nov 2017 15:58:57 +0100 - rev 390813
Push 32845 by archaeopteryx@coole-files.de at Wed, 08 Nov 2017 22:08:47 +0000
Bug 1394831 part 12 - Remove unused flags argument from matchesParamsAfterId. r=bhackett
b44bda5764ca: Bug 1394831 part 11 - Split getChildProperty in data vs accessor versions. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Nov 2017 15:58:31 +0100 - rev 390812
Push 32845 by archaeopteryx@coole-files.de at Wed, 08 Nov 2017 22:08:47 +0000
Bug 1394831 part 11 - Split getChildProperty in data vs accessor versions. r=bhackett
9d8e2a8c4c03: Bug 1394831 part 10 - Simplify addDataProperty's slot argument. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Nov 2017 15:57:12 +0100 - rev 390811
Push 32845 by archaeopteryx@coole-files.de at Wed, 08 Nov 2017 22:08:47 +0000
Bug 1394831 part 10 - Simplify addDataProperty's slot argument. r=bhackett
19d68ad55452: Bug 1394831 part 9 - Remove allowDictionary argument from addAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:40:17 +0100 - rev 389627
Push 32789 by archaeopteryx@coole-files.de at Wed, 01 Nov 2017 21:55:42 +0000
Bug 1394831 part 9 - Remove allowDictionary argument from addAccessorProperty. r=bhackett
444453765199: Bug 1394831 part 8 - Remove flags argument from addAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:39:52 +0100 - rev 389626
Push 32789 by archaeopteryx@coole-files.de at Wed, 01 Nov 2017 21:55:42 +0000
Bug 1394831 part 8 - Remove flags argument from addAccessorProperty. r=bhackett
706c6d389111: Bug 1394831 part 7 - Remove flags and allowDictionary arguments from addDataProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:39:22 +0100 - rev 389625
Push 32789 by archaeopteryx@coole-files.de at Wed, 01 Nov 2017 21:55:42 +0000
Bug 1394831 part 7 - Remove flags and allowDictionary arguments from addDataProperty. r=bhackett
88bfd12dc099: Bug 1394831 part 6 - Remove flags argument from putAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:38:58 +0100 - rev 389624
Push 32789 by archaeopteryx@coole-files.de at Wed, 01 Nov 2017 21:55:42 +0000
Bug 1394831 part 6 - Remove flags argument from putAccessorProperty. r=bhackett
4fece077634f: Bug 1394831 part 5 - Remove slot and flags arguments from putDataProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 31 Oct 2017 15:19:45 +0100 - rev 389439
Push 32787 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:14:54 +0000
Bug 1394831 part 5 - Remove slot and flags arguments from putDataProperty. r=bhackett
d1489f9302ca: Bug 1394831 part 4 - Add an AutoCheckShapeConsistency RAII class. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 31 Oct 2017 15:19:45 +0100 - rev 389438
Push 32787 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:14:54 +0000
Bug 1394831 part 4 - Add an AutoCheckShapeConsistency RAII class. r=bhackett
ec639f2d7888: Bug 1394831 part 3 - Add an early return, unindent some code. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 31 Oct 2017 15:19:44 +0100 - rev 389437
Push 32787 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:14:54 +0000
Bug 1394831 part 3 - Add an early return, unindent some code. r=bhackett
1fccf231f26c: Bug 1394831 part 2 - Split putProperty in separate accessor vs data property overloads. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 31 Oct 2017 15:19:39 +0100 - rev 389436
Push 32787 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:14:54 +0000
Bug 1394831 part 2 - Split putProperty in separate accessor vs data property overloads. r=bhackett
b7cfc0c69ca7: Bug 1394831 part 1 - Split addProperty(Internal) in separate accessor vs data property overloads. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Tue, 31 Oct 2017 15:17:07 +0100 - rev 389435
Push 32787 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:14:54 +0000
Bug 1394831 part 1 - Split addProperty(Internal) in separate accessor vs data property overloads. r=bhackett
74d76655c919: Bug 1404636 - Special-case typed arrays in PropertyReadNeedsTypeBarrier. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Thu, 26 Oct 2017 16:15:35 +0200 - rev 388582
Push 32754 by archaeopteryx@coole-files.de at Fri, 27 Oct 2017 09:46:43 +0000
Bug 1404636 - Special-case typed arrays in PropertyReadNeedsTypeBarrier. r=bhackett