searching for reviewer(baku)
12ac36bd13de1f3e5614440b89a26ed1b775f281: Bug 1796797 - Convert toolkit/components/contextualidentity JSM modules to ESMs r=baku,webdriver-reviewers,extension-reviewers,settings-reviewers,robwu
Danny Colin <contact@dannycolin.com> - Wed, 21 Dec 2022 08:14:05 +0000 - rev 646962
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1796797 - Convert toolkit/components/contextualidentity JSM modules to ESMs r=baku,webdriver-reviewers,extension-reviewers,settings-reviewers,robwu Differential Revision: https://phabricator.services.mozilla.com/D159945
6aeee37c70c24383195a6d15ac8df968c790e861: Bug 1580495 - Changed function parameter mCredentialsMode to aCredentialsMode in InternalHeaders::CORSHeaders. r=baku
Shrey Gupta <shrey2809@gmail.com> - Fri, 16 Dec 2022 17:37:30 +0000 - rev 646597
Push 40489 by smolnar@mozilla.com at Sat, 17 Dec 2022 21:17:45 +0000
Bug 1580495 - Changed function parameter mCredentialsMode to aCredentialsMode in InternalHeaders::CORSHeaders. r=baku Depends on D60368 Differential Revision: https://phabricator.services.mozilla.com/D60369
3f2a6e9bf80ec0a7e81988b39420a541a111d033: Bug 1796797 - Convert toolkit/components/contextualidentity JSM modules to ESMs r=baku
Danny Colin <contact@dannycolin.com> - Wed, 09 Nov 2022 18:54:20 +0000 - rev 640875
Push 40392 by sstanca@mozilla.com at Thu, 10 Nov 2022 09:23:09 +0000
Bug 1796797 - Convert toolkit/components/contextualidentity JSM modules to ESMs r=baku Differential Revision: https://phabricator.services.mozilla.com/D159945
4efc7cc1853401686c61a07043876f799694e873: Bug 1762462 - Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku
Thomas Wisniewski <twisniewski@mozilla.com> - Fri, 15 Jul 2022 13:26:23 +0000 - rev 624153
Push 39989 by apavel@mozilla.com at Fri, 15 Jul 2022 21:29:53 +0000
Bug 1762462 - Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku Depends on D144731 Differential Revision: https://phabricator.services.mozilla.com/D151393
00c0c6314640ac687d2ae9ed25476c293eaf3d0a: Bug 1762462 - Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku
Thomas Wisniewski <twisniewski@mozilla.com> - Thu, 14 Jul 2022 19:26:32 +0000 - rev 624065
Push 39985 by ctuns@mozilla.com at Fri, 15 Jul 2022 03:58:18 +0000
Bug 1762462 - Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku Depends on D144731 Differential Revision: https://phabricator.services.mozilla.com/D151393
b7d979a36324ff8d0de43f25811ceda380ac904c: Bug 1762462 - Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku
Thomas Wisniewski <twisniewski@mozilla.com> - Wed, 13 Jul 2022 22:45:04 +0000 - rev 623876
Push 39980 by nfay@mozilla.com at Thu, 14 Jul 2022 03:48:49 +0000
Bug 1762462 - Make tests in dom/websocket/tests/ reflect Always Partitioning Storage; r=baku Depends on D144731 Differential Revision: https://phabricator.services.mozilla.com/D151393
3c5f033ebc3b481bd64304e20dfc1b174d93023d: Bug 1750161 - ExtensionListenerCallWorkerRunnable::WorkerRun should explicitly check for uncatchale exception. r=baku
Luca Greco <lgreco@mozilla.com> - Tue, 05 Jul 2022 15:15:55 +0000 - rev 623056
Push 39940 by nfay@mozilla.com at Tue, 05 Jul 2022 21:28:56 +0000
Bug 1750161 - ExtensionListenerCallWorkerRunnable::WorkerRun should explicitly check for uncatchale exception. r=baku Differential Revision: https://phabricator.services.mozilla.com/D148950
f7b85c679074c2e82a4f471df45ce92d8bbb25e8: Bug 1718228 - Make CollectedClientData follow the spec r=dveditz,baku
R. Martinho Fernandes <bugs@rmf.io> - Thu, 30 Jun 2022 12:28:45 +0000 - rev 622687
Push 39920 by smolnar@mozilla.com at Thu, 30 Jun 2022 21:24:30 +0000
Bug 1718228 - Make CollectedClientData follow the spec r=dveditz,baku Differential Revision: https://phabricator.services.mozilla.com/D136881
6807a13afdd9df440cd5ff4f1cbf1d28009b4abd: Bug 1718228 - Make CollectedClientData follow the spec r=dveditz,baku
R. Martinho Fernandes <bugs@rmf.io> - Mon, 16 May 2022 11:23:38 +0000 - rev 617720
Push 39704 by csabou@mozilla.com at Mon, 16 May 2022 21:54:06 +0000
Bug 1718228 - Make CollectedClientData follow the spec r=dveditz,baku Differential Revision: https://phabricator.services.mozilla.com/D136881
e2908f3e5373d6b0e544d5277da9775f9138651d: Bug 1718228 - Make CollectedClientData follow the spec r=dveditz,baku
R. Martinho Fernandes <bugs@rmf.io> - Tue, 03 May 2022 15:52:36 +0000 - rev 615972
Push 39645 by imoraru@mozilla.com at Wed, 04 May 2022 03:39:47 +0000
Bug 1718228 - Make CollectedClientData follow the spec r=dveditz,baku Differential Revision: https://phabricator.services.mozilla.com/D136881
d45b16f97f9f0cb6714729a3efe74620b8986ec8: Bug 1718228 - Make CollectedClientData follow the spec r=dveditz,baku
R. Martinho Fernandes <bugs@rmf.io> - Wed, 27 Apr 2022 16:49:13 +0000 - rev 615487
Push 39622 by apavel@mozilla.com at Wed, 27 Apr 2022 21:34:31 +0000
Bug 1718228 - Make CollectedClientData follow the spec r=dveditz,baku Differential Revision: https://phabricator.services.mozilla.com/D136881
69576547e4097ef1a619344d1f2a34cd68463ee9: Bug 1765112. Silence spammy warnings in netwerk/url-classifier/AsyncUrlChannelClassifier.cpp. r=baku,dimi
Timothy Nikkel <tnikkel@gmail.com> - Fri, 22 Apr 2022 00:13:09 +0000 - rev 615044
Push 39600 by nbeleuzu@mozilla.com at Fri, 22 Apr 2022 10:03:51 +0000
Bug 1765112. Silence spammy warnings in netwerk/url-classifier/AsyncUrlChannelClassifier.cpp. r=baku,dimi Depends on D143890 Differential Revision: https://phabricator.services.mozilla.com/D143891
115f947f4f66558f5f76bc2facc0f8ccc4a05d60: Bug 1609100 - Remove devtools.enabled check from Console.cpp r=baku,nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Mon, 28 Mar 2022 11:12:07 +0000 - rev 612577
Push 39484 by mlaza@mozilla.com at Mon, 28 Mar 2022 15:48:10 +0000
Bug 1609100 - Remove devtools.enabled check from Console.cpp r=baku,nchevobbe Depends on D141467 The devtools.enabled preference was never really used in the end. The devtools add-on plans were cancelled, as well as the devtools onboarding flows. So I think this was essentially dead code. Differential Revision: https://phabricator.services.mozilla.com/D141468
e5c4afe5dd667d9a29c2c3a7445ee470d71d7613: Bug 1609100 - Remove devtools.enabled check from Console.cpp r=baku,nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Mon, 28 Mar 2022 08:57:37 +0000 - rev 612563
Push 39484 by mlaza@mozilla.com at Mon, 28 Mar 2022 15:48:10 +0000
Bug 1609100 - Remove devtools.enabled check from Console.cpp r=baku,nchevobbe Depends on D141467 The devtools.enabled preference was never really used in the end. The devtools add-on plans were cancelled, as well as the devtools onboarding flows. So I think this was essentially dead code. Differential Revision: https://phabricator.services.mozilla.com/D141468
09bb73dac836efc23e0a7dfa9d8304fbd9d3cb11: Bug 1675829 - Allow disabling the cookie database in the profile with `network.cookie.noPersistentStorage`. r=baku
Nick Alexander <nalexander@mozilla.com> - Fri, 18 Mar 2022 04:20:02 +0000 - rev 610931
Push 39438 by mlaza@mozilla.com at Fri, 18 Mar 2022 09:48:22 +0000
Bug 1675829 - Allow disabling the cookie database in the profile with `network.cookie.noPersistentStorage`. r=baku Firefox background tasks use a new temporary profile directory for every invocation. We would like to write as little data as possible into the temporary profile directory in this mode. This patch allows to make the persistent cookie storage discard cookies just like private cookie storage. This approach simply uses that the base `CookieStorage` class is close to sufficient already. There may be a performance impact with more virtual invocations, but none of these functions seem likely to be hot. Differential Revision: https://phabricator.services.mozilla.com/D139910
5dcf89f3ae51c4177f8c88999cf2b7be79ac4a0c: Bug 1759629 - Remove unused dom/base/test/file_record_orientation.html. r=baku
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 17 Mar 2022 06:38:40 +0000 - rev 610833
Push 39433 by imoraru@mozilla.com at Thu, 17 Mar 2022 16:48:24 +0000
Bug 1759629 - Remove unused dom/base/test/file_record_orientation.html. r=baku This file had to be remove by Bug 1312417. Differential Revision: https://phabricator.services.mozilla.com/D141183
e7d6e1641a9491d8fb3c400af4b3c99133f760f1: Bug 1753948 - Support MOZ_FUZZ_DEBUG in nsJSUtils. r=baku
Christian Holler <choller@mozilla.com> - Mon, 07 Feb 2022 14:08:27 +0000 - rev 606872
Push 39256 by imoraru@mozilla.com at Mon, 07 Feb 2022 21:56:03 +0000
Bug 1753948 - Support MOZ_FUZZ_DEBUG in nsJSUtils. r=baku Differential Revision: https://phabricator.services.mozilla.com/D137989
199796d1623becd174b2317bdb39871c58a8e20e: Bug 1728327 - Track ExtensionEventListener a background service worker registered by the time it is fully loaded. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 15 Dec 2021 18:29:37 +0000 - rev 602155
Push 39069 by apavel@mozilla.com at Thu, 16 Dec 2021 09:41:42 +0000
Bug 1728327 - Track ExtensionEventListener a background service worker registered by the time it is fully loaded. r=baku This patch includes a proposed approach to keep track of the WebExtensions API event listeners subscribed synchronously while the background service worker script was being loaded and executed, because this are the listeners that we can assume to be available right after we spawn a worker and be able to handle the API event that triggered the worker to be spawned. The information about the "listeners subscribed synchronously while the worker script is being loaded and executed" is then used by the ExtensionBrowser::HasWakeupEventListener method, which will be called as part of handling the nsIServiceWorkerManager.wakeForExtensionAPIEvent call. Differential Revision: https://phabricator.services.mozilla.com/D130758
a2943d14c1ab21c30919ef59b056b84a812be565: Bug 1590068 - Add fuzzing target for StructuredCloneData. r=baku,sfink
Christian Holler <choller@mozilla.com> - Wed, 08 Dec 2021 18:59:02 +0000 - rev 601425
Push 39048 by nfay@mozilla.com at Thu, 09 Dec 2021 09:32:28 +0000
Bug 1590068 - Add fuzzing target for StructuredCloneData. r=baku,sfink Differential Revision: https://phabricator.services.mozilla.com/D128513
1ea35be32e03e8b737744f20ab97ca1d0995d770: Bug 1742588 - Rewrite test_fileconstructor.xhtml to correctly run its tests. r=baku
Mark Banner <standard8@mozilla.com> - Wed, 24 Nov 2021 11:26:36 +0000 - rev 600017
Push 39007 by imoraru@mozilla.com at Thu, 25 Nov 2021 04:37:56 +0000
Bug 1742588 - Rewrite test_fileconstructor.xhtml to correctly run its tests. r=baku Depends on D131910 Differential Revision: https://phabricator.services.mozilla.com/D131911
135c60fca4f1a4ce8f481e287f1c88bff28a18f3: Bug 1742588 - Rewrite test_fileconstructor.xhtml with unix line endings. r=baku
Mark Banner <standard8@mozilla.com> - Wed, 24 Nov 2021 11:26:36 +0000 - rev 600016
Push 39007 by imoraru@mozilla.com at Thu, 25 Nov 2021 04:37:56 +0000
Bug 1742588 - Rewrite test_fileconstructor.xhtml with unix line endings. r=baku Differential Revision: https://phabricator.services.mozilla.com/D131910
707e4d920d25fe5dd249c9cdca400c241a8fa0c8: Bug 1736046 - Validate length of nested structured serialization data r=baku
Steve Fink <sfink@mozilla.com> - Mon, 22 Nov 2021 16:03:11 +0000 - rev 599796
Push 39000 by csabou@mozilla.com at Mon, 22 Nov 2021 21:05:14 +0000
Bug 1736046 - Validate length of nested structured serialization data r=baku Differential Revision: https://phabricator.services.mozilla.com/D130127
afb346a9eb0a0ba5c3820e3b44cf24cfea0741bb: Bug 1728326 - Add a new RequestInitWorkerRunnable to call mozIExtensionAPIRequestHandler initExtensionWorker. r=baku
Luca Greco <lgreco@mozilla.com> - Fri, 05 Nov 2021 21:27:02 +0000 - rev 598426
Push 38954 by ccozmuta@mozilla.com at Sat, 06 Nov 2021 09:32:08 +0000
Bug 1728326 - Add a new RequestInitWorkerRunnable to call mozIExtensionAPIRequestHandler initExtensionWorker. r=baku This patch introduce a new RequestInitWorkerRunnable that calls a new mozIExtensionAPIRequestHandler.initExtensionWorker method, and a CreateAndDispatchInitWorkerRunnable helper function which will be used to send this mozIExtensionAPIRequest from the worker thread to the main thread when the background service worker is ready for being executed (but before its main scripts has been evaluated in the newly created service worker global scope). Differential Revision: https://phabricator.services.mozilla.com/D124699
cc488a5fabadfb44005fb8cba18fd19615de6bc4: Bug 1728326 - Add ServiceWorkerInfo descriptor id to mozIExtensionServiceWorkerInfo. r=baku
Luca Greco <lgreco@mozilla.com> - Fri, 05 Nov 2021 21:27:02 +0000 - rev 598425
Push 38954 by ccozmuta@mozilla.com at Sat, 06 Nov 2021 09:32:08 +0000
Bug 1728326 - Add ServiceWorkerInfo descriptor id to mozIExtensionServiceWorkerInfo. r=baku This patch adds the ServiceWorkerInfo descriptor id to the property available in the mozIExtensionServiceWorkerInfo. The descriptor ID is an integer assigned on the main process to each ServiceWorkerPrivate instance, which will allow us to verify in the main process that the worker running in the child process is part of the expected service worker registration, and it is also still available when the worker is already being destroyed, which makes it useful as the key used in the map of the extension service worker context that we keep in the child extension process. Differential Revision: https://phabricator.services.mozilla.com/D124698
247504b7ea84f28681615e7f6508a57cbfbd5531: Bug 1728326 - Add a new RequestInitWorkerRunnable to call mozIExtensionAPIRequestHandler initExtensionWorker. r=baku
Luca Greco <lgreco@mozilla.com> - Fri, 05 Nov 2021 20:27:00 +0000 - rev 598410
Push 38954 by ccozmuta@mozilla.com at Sat, 06 Nov 2021 09:32:08 +0000
Bug 1728326 - Add a new RequestInitWorkerRunnable to call mozIExtensionAPIRequestHandler initExtensionWorker. r=baku This patch introduce a new RequestInitWorkerRunnable that calls a new mozIExtensionAPIRequestHandler.initExtensionWorker method, and a CreateAndDispatchInitWorkerRunnable helper function which will be used to send this mozIExtensionAPIRequest from the worker thread to the main thread when the background service worker is ready for being executed (but before its main scripts has been evaluated in the newly created service worker global scope). Differential Revision: https://phabricator.services.mozilla.com/D124699
de8879fc812660e1215565ab7e0e070b66c5cfef: Bug 1728326 - Add ServiceWorkerInfo descriptor id to mozIExtensionServiceWorkerInfo. r=baku
Luca Greco <lgreco@mozilla.com> - Fri, 05 Nov 2021 20:26:59 +0000 - rev 598409
Push 38954 by ccozmuta@mozilla.com at Sat, 06 Nov 2021 09:32:08 +0000
Bug 1728326 - Add ServiceWorkerInfo descriptor id to mozIExtensionServiceWorkerInfo. r=baku This patch adds the ServiceWorkerInfo descriptor id to the property available in the mozIExtensionServiceWorkerInfo. The descriptor ID is an integer assigned on the main process to each ServiceWorkerPrivate instance, which will allow us to verify in the main process that the worker running in the child process is part of the expected service worker registration, and it is also still available when the worker is already being destroyed, which makes it useful as the key used in the map of the extension service worker context that we keep in the child extension process. Differential Revision: https://phabricator.services.mozilla.com/D124698
82469751741a9cc127e92d6a6ae3ad4779349bc0: Bug 1724183 - Add test.assertRejects WebExtensions API implementation to ExtensionTest webidl bindings. r=baku
Luca Greco <lgreco@mozilla.com> - Tue, 12 Oct 2021 18:32:28 +0000 - rev 595560
Push 38872 by malexandru@mozilla.com at Wed, 13 Oct 2021 03:44:20 +0000
Bug 1724183 - Add test.assertRejects WebExtensions API implementation to ExtensionTest webidl bindings. r=baku Differential Revision: https://phabricator.services.mozilla.com/D122035
e573ec34a4b467378ccf448b4d6387076a8a098b: Bug 1724183 - Add test.assertThrows WebExtensions API implementation to ExtensionTest webidl bindings. r=baku
Luca Greco <lgreco@mozilla.com> - Tue, 12 Oct 2021 18:32:27 +0000 - rev 595559
Push 38872 by malexandru@mozilla.com at Wed, 13 Oct 2021 03:44:20 +0000
Bug 1724183 - Add test.assertThrows WebExtensions API implementation to ExtensionTest webidl bindings. r=baku Differential Revision: https://phabricator.services.mozilla.com/D122034
1db9a2d4ac46e10ea2e91b75c307288116d034ea: Bug 1724183 - Add ExtensionTest::AssertMatchInternal to provide the logic to be shared between AssertThrows and AssertRejects. r=baku,sfink
Luca Greco <lgreco@mozilla.com> - Tue, 12 Oct 2021 18:32:27 +0000 - rev 595558
Push 38872 by malexandru@mozilla.com at Wed, 13 Oct 2021 03:44:20 +0000
Bug 1724183 - Add ExtensionTest::AssertMatchInternal to provide the logic to be shared between AssertThrows and AssertRejects. r=baku,sfink This patch introduce a new AssertMatchInternal to ExtensionTest, this method isn't exposed to js callers through the webidl definition, it is meant to be used internally by the AssertThrows and AssertRejects methods (which are instead both methods part of the ExtensionTest webidl). This patch also introduces small changes to ExtensionAPIRequestForwarder and RequestWorkerRunnable, to allow AssertMatchInternal to accept as an optional parameter a serialized caller stack trace (to be sent as part of the APIRequest forwarded from the worker thread to the main thread), which is needed for AssertRejects (to include the strack trace retrieved when AssertRejects is called, and then after the promise parameter has been rejected or resolved to send it as part of the forwarded aPI request). Differential Revision: https://phabricator.services.mozilla.com/D122033
211c00af6c724814c5028dd2dab509c3ece50d05: Bug 1724183 - Add test.assertEq WebExtensions API implementation to ExtensionTest webidl bindings. r=baku,mixedpuppy
Luca Greco <lgreco@mozilla.com> - Tue, 12 Oct 2021 18:32:27 +0000 - rev 595557
Push 38872 by malexandru@mozilla.com at Wed, 13 Oct 2021 03:44:20 +0000
Bug 1724183 - Add test.assertEq WebExtensions API implementation to ExtensionTest webidl bindings. r=baku,mixedpuppy This patch introduce a new method to ExtensionTest.h/.cpp that implements the parts of browser.test.assertEq that needs to happen on the background service worker thread (because the first two parameters are expected to not be always of types that can be structure cloned). The C++ method is meant to follow closely enough what the current implementation is doing in privileged JS code (See https://searchfox.org/mozilla-central/rev/00977c4e37865a92f1c15572ae4aea90e934b25b/toolkit/components/extensions/child/ext-test.js#169-186) after that the C++ method calls the existing assertEq implementation, which will be actually be getting the first 2 parameters already converted as strings (which will be already different if `expected` and `actual` js values were different despite their stringified value may be looking the same, because the method will add " (different)" to the stringified `actual` value if the two parameter were not strictly equal). The existing test.assertEq implementation will also take care to send the result of the assertion to the parent process (which will make sure that the test case being executed will fail as expected), as it happens for all other test API methods that are just forwarding their parameters to the main thread through the pre-existing stub methods. Differential Revision: https://phabricator.services.mozilla.com/D121890
84ae8311ae622ac3074f5799dd0a98d753d54df5: Bug 1729964 - Fix linker error. r=baku
Andreas Pehrson <apehrson@mozilla.com> - Wed, 06 Oct 2021 14:33:40 +0000 - rev 594923
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1729964 - Fix linker error. r=baku Differential Revision: https://phabricator.services.mozilla.com/D126918
bed7b8df0aa7924772f04b5a948a67077848a99e: Bug 1688040 - part11: Fix dom::Promise leaked by RequestWorkerRunnable::ProcessHandlerResult when handling the result of an async method call. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:25 +0000 - rev 594916
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part11: Fix dom::Promise leaked by RequestWorkerRunnable::ProcessHandlerResult when handling the result of an async method call. r=baku This patch fixes a leak that I spotted while investigating a separate shutdown leak triggered by D121683 (This one is not strictly related to D121683, but apparently none of the xpcshell tests part of this stack of patches reported it at a shutdown leak, nevertheless it was detected as a shutdown leak while running the test_ext_identity.html mochitest on the background service worker, after the other leak specific to D121683 was fixed, and after investigating it using cc logs and heapgraph's find_roots.py I confirmed that it's a shutdown leak introduced here in RequestWorkerRunnable::ProcessHandlerResult). Differential Revision: https://phabricator.services.mozilla.com/D122968
a78b64d966b2c24bb79fb4653bea51e3c2c9881b: Bug 1688040 - part10.3: Store weakptr in the ports lookup map and clear the entry when released. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:24 +0000 - rev 594914
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part10.3: Store weakptr in the ports lookup map and clear the entry when released. r=baku Differential Revision: https://phabricator.services.mozilla.com/D107555
e02c88dd86f5b16fddd5bce8a696ff166683c24a: Bug 1688040 - part10.2: Return existing ExtensionPort instance based on the ExtensionPortDescriptor portId. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:24 +0000 - rev 594913
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part10.2: Return existing ExtensionPort instance based on the ExtensionPortDescriptor portId. r=baku The extensions expect that ExtensionPort instances they get in the calls to the port event listeners to always be the same, and to be also strictly equal to the object port got from browser.runtime.connect or browser.runtime.onConnect: ``` const port = browser.runtime.connect(); port.onDisconnect.addListener(disconnectedPort => { // port === disconnectedPort => true }); ``` This patch does add an extension port lookup map in the ExtensionBrowser class and a new ExtensionBrowser::GetPort method which is responsible of providing the expected behavior (returning an existing istance if one is found in the lookup map). Differential Revision: https://phabricator.services.mozilla.com/D107554
9215397dc155a57c159509d9e3296b7d72fabe3d: Bug 1688040 - part10.1: Support prepending or appending api object instance to the listener call arguments. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:24 +0000 - rev 594912
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part10.1: Support prepending or appending api object instance to the listener call arguments. r=baku Differential Revision: https://phabricator.services.mozilla.com/D107553
bd8300f5245e05f9f87f8c10c50beadf3eb966fc: Bug 1688040 - part9: Implement setting/clearing and reporting browser.runtime.lastError from ChromeCompatCallbackHandler::RejectedCallback. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:23 +0000 - rev 594911
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part9: Implement setting/clearing and reporting browser.runtime.lastError from ChromeCompatCallbackHandler::RejectedCallback. r=baku This patch does: - add to ExtensionBrowser two new data members to keep track of value for the browser.runtime.lastError and if it was checked while the chrome compatible callback was being executed - add to ExtensionBrowser 3 new methods to set, get and clear the lastError value - add a reference to the ExtensionBrowser to all API namespaces and API objects classes, because it has to be then propagated to the ChromeCompatCallbackHandler instances that are being attached to the promise result of the async API methods calls if the caller did pass the optional callback parameter - tweak the ChromeCompatCallbackHandler class to set the lastError value before calling the callback in ChromeCompatCallbackHAndler::RejectedCallback and then clear it after the call has been completed and report it to the console if it wasn't checked - change the ExtensionRuntime::GetLastError methhod to restrieve and return the value from the ExtensionBrowser instance Differential Revision: https://phabricator.services.mozilla.com/D107327
921f4f47a654e9829e7cc56ef8a580cb8beaaa57: Bug 1688040 - part8.1: Add stub method for string and jsvalue properties. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:22 +0000 - rev 594908
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part8.1: Add stub method for string and jsvalue properties. r=baku Differential Revision: https://phabricator.services.mozilla.com/D106704
5679e7ef5e59805254e3809b646f7b2f9ac2cf36: Bug 1688040 - part7.1: Added WebIDL-based binding for the browser.runtime WebExtensions API. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:21 +0000 - rev 594904
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part7.1: Added WebIDL-based binding for the browser.runtime WebExtensions API. r=baku Differential Revision: https://phabricator.services.mozilla.com/D106700
049e4405cf1ca899a3705b596e1be072241c5308: Bug 1688040 - part6: Added chrome global as a BindingAlias of the browser global. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:20 +0000 - rev 594903
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part6: Added chrome global as a BindingAlias of the browser global. r=baku Differential Revision: https://phabricator.services.mozilla.com/D103351
7591f72b60c4d01429dd578343da31e06d06e915: Bug 1688040 - part5: Added WebIDL-based binding for the browser.alarms WebExtensions API. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:20 +0000 - rev 594902
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part5: Added WebIDL-based binding for the browser.alarms WebExtensions API. r=baku Differential Revision: https://phabricator.services.mozilla.com/D102928
f7465c8d4504ec232a0d7aed8b68cf12c80fa34b: Bug 1688040 - part4.2: Hook up browser.test API webidl binding to ExtensionBrowser. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:19 +0000 - rev 594900
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part4.2: Hook up browser.test API webidl binding to ExtensionBrowser. r=baku Differential Revision: https://phabricator.services.mozilla.com/D102643
78b1fcc32a94c8657395cbc5334a2773e8f67ed6: Bug 1688040 - part4.1: Initial WebIDL-based bindings for browser.test API namespace r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:19 +0000 - rev 594899
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part4.1: Initial WebIDL-based bindings for browser.test API namespace r=baku Differential Revision: https://phabricator.services.mozilla.com/D102642
8c38fb6bb94cac8e12a5b6d45cf6894bc83ec546: Bug 1688040 - part2.1: Allow storing normalized arguments in the mozIExtensionAPIRequest object. r=baku
Luca Greco <lgreco@mozilla.com> - Wed, 06 Oct 2021 12:28:17 +0000 - rev 594896
Push 38854 by mlaza@mozilla.com at Wed, 06 Oct 2021 21:38:19 +0000
Bug 1688040 - part2.1: Allow storing normalized arguments in the mozIExtensionAPIRequest object. r=baku Differential Revision: https://phabricator.services.mozilla.com/D102641
85ba163b642310734bdb777938403e5abf3ac914: Bug 1688040 - part11: Fix dom::Promise leaked by RequestWorkerRunnable::ProcessHandlerResult when handling the result of an async method call. r=baku
Luca Greco <lgreco@mozilla.com> - Tue, 05 Oct 2021 17:05:46 +0000 - rev 594743
Push 38851 by ncsoregi@mozilla.com at Wed, 06 Oct 2021 04:09:04 +0000
Bug 1688040 - part11: Fix dom::Promise leaked by RequestWorkerRunnable::ProcessHandlerResult when handling the result of an async method call. r=baku This patch fixes a leak that I spotted while investigating a separate shutdown leak triggered by D121683 (This one is not strictly related to D121683, but apparently none of the xpcshell tests part of this stack of patches reported it at a shutdown leak, nevertheless it was detected as a shutdown leak while running the test_ext_identity.html mochitest on the background service worker, after the other leak specific to D121683 was fixed, and after investigating it using cc logs and heapgraph's find_roots.py I confirmed that it's a shutdown leak introduced here in RequestWorkerRunnable::ProcessHandlerResult). Differential Revision: https://phabricator.services.mozilla.com/D122968
88395ab5a5b594c539aece51c8d47756282ee9b0: Bug 1688040 - part10.3: Store weakptr in the ports lookup map and clear the entry when released. r=baku
Luca Greco <lgreco@mozilla.com> - Tue, 05 Oct 2021 17:05:45 +0000 - rev 594741
Push 38851 by ncsoregi@mozilla.com at Wed, 06 Oct 2021 04:09:04 +0000
Bug 1688040 - part10.3: Store weakptr in the ports lookup map and clear the entry when released. r=baku Differential Revision: https://phabricator.services.mozilla.com/D107555
8d33bdd8d0b89c4aef8592dbf29fa732d71a5acc: Bug 1688040 - part10.2: Return existing ExtensionPort instance based on the ExtensionPortDescriptor portId. r=baku
Luca Greco <lgreco@mozilla.com> - Tue, 05 Oct 2021 17:05:44 +0000 - rev 594740
Push 38851 by ncsoregi@mozilla.com at Wed, 06 Oct 2021 04:09:04 +0000
Bug 1688040 - part10.2: Return existing ExtensionPort instance based on the ExtensionPortDescriptor portId. r=baku The extensions expect that ExtensionPort instances they get in the calls to the port event listeners to always be the same, and to be also strictly equal to the object port got from browser.runtime.connect or browser.runtime.onConnect: ``` const port = browser.runtime.connect(); port.onDisconnect.addListener(disconnectedPort => { // port === disconnectedPort => true }); ``` This patch does add an extension port lookup map in the ExtensionBrowser class and a new ExtensionBrowser::GetPort method which is responsible of providing the expected behavior (returning an existing istance if one is found in the lookup map). Differential Revision: https://phabricator.services.mozilla.com/D107554
fdbced7a94f32bf52401c1b9ab273dced7da5ea7: Bug 1688040 - part10.1: Support prepending or appending api object instance to the listener call arguments. r=baku
Luca Greco <lgreco@mozilla.com> - Tue, 05 Oct 2021 17:05:44 +0000 - rev 594739
Push 38851 by ncsoregi@mozilla.com at Wed, 06 Oct 2021 04:09:04 +0000
Bug 1688040 - part10.1: Support prepending or appending api object instance to the listener call arguments. r=baku Differential Revision: https://phabricator.services.mozilla.com/D107553
922ca2f20fa1a993babea15cdd8f524316a66cf4: Bug 1688040 - part9: Implement setting/clearing and reporting browser.runtime.lastError from ChromeCompatCallbackHandler::RejectedCallback. r=baku
Luca Greco <lgreco@mozilla.com> - Tue, 05 Oct 2021 17:05:44 +0000 - rev 594738
Push 38851 by ncsoregi@mozilla.com at Wed, 06 Oct 2021 04:09:04 +0000
Bug 1688040 - part9: Implement setting/clearing and reporting browser.runtime.lastError from ChromeCompatCallbackHandler::RejectedCallback. r=baku This patch does: - add to ExtensionBrowser two new data members to keep track of value for the browser.runtime.lastError and if it was checked while the chrome compatible callback was being executed - add to ExtensionBrowser 3 new methods to set, get and clear the lastError value - add a reference to the ExtensionBrowser to all API namespaces and API objects classes, because it has to be then propagated to the ChromeCompatCallbackHandler instances that are being attached to the promise result of the async API methods calls if the caller did pass the optional callback parameter - tweak the ChromeCompatCallbackHandler class to set the lastError value before calling the callback in ChromeCompatCallbackHAndler::RejectedCallback and then clear it after the call has been completed and report it to the console if it wasn't checked - change the ExtensionRuntime::GetLastError methhod to restrieve and return the value from the ExtensionBrowser instance Differential Revision: https://phabricator.services.mozilla.com/D107327
4d9b2a9dd247190193eec132ab065bdadc2ce733: Bug 1688040 - part8.1: Add stub method for string and jsvalue properties. r=baku
Luca Greco <lgreco@mozilla.com> - Tue, 05 Oct 2021 17:05:42 +0000 - rev 594735
Push 38851 by ncsoregi@mozilla.com at Wed, 06 Oct 2021 04:09:04 +0000
Bug 1688040 - part8.1: Add stub method for string and jsvalue properties. r=baku Differential Revision: https://phabricator.services.mozilla.com/D106704
20e38838aa8976d51e5ce40f04d6596062d0ab0f: Bug 1688040 - part7.1: Added WebIDL-based binding for the browser.runtime WebExtensions API. r=baku
Luca Greco <lgreco@mozilla.com> - Tue, 05 Oct 2021 17:05:41 +0000 - rev 594731
Push 38851 by ncsoregi@mozilla.com at Wed, 06 Oct 2021 04:09:04 +0000
Bug 1688040 - part7.1: Added WebIDL-based binding for the browser.runtime WebExtensions API. r=baku Differential Revision: https://phabricator.services.mozilla.com/D106700