searching for reviewer(aswan)
c9e14c54335a: Bug 1545765 - Fix attribute inheritance for empty attribute values r=aswan
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 19 Apr 2019 21:07:40 +0000 - rev 470260
Push 35891 by rgurzau@mozilla.com at Sat, 20 Apr 2019 09:35:22 +0000
Bug 1545765 - Fix attribute inheritance for empty attribute values r=aswan This accidentally got dropped in Bug 1528268. Differential Revision: https://phabricator.services.mozilla.com/D28251
c9ffb38259ec: Bug 1528268 - Make initializeAttributeInheritance and incremental attribute changes do less work r=aswan
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 18 Apr 2019 16:41:39 +0000 - rev 470128
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1528268 - Make initializeAttributeInheritance and incremental attribute changes do less work r=aswan This provides a flipped data structure based on the provided inheritedAttributes, which looks like: Object<selector, attrs_to_inherit_comma_separated> To one that looks like: Object<attr, Array<Array<selector, attr_to_inherit>> This should improve performance because: 1) We only fetch element at connectedCallback that actually will have attributes inherited. 2) When an attribute changes we can quickly inherit only that one. Differential Revision: https://phabricator.services.mozilla.com/D27801
f4a2547c2384: Bug 1545390 - Fix a couple of reference to undefined properties in AddonTestUtils.jsm and ExtensionCommon.jsm. r=aswan
Mark Banner <standard8@mozilla.com> - Thu, 18 Apr 2019 14:58:37 +0000 - rev 470089
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1545390 - Fix a couple of reference to undefined properties in AddonTestUtils.jsm and ExtensionCommon.jsm. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D28043
f8770d7eebd1: Bug 1528268 - Make initializeAttributeInheritance and incremental attribute changes do less work r=aswan
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 17 Apr 2019 18:48:46 +0000 - rev 469909
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1528268 - Make initializeAttributeInheritance and incremental attribute changes do less work r=aswan This provides a flipped data structure based on the provided inheritedAttributes, which looks like: Object<selector, attrs_to_inherit_comma_separated> To one that looks like: Object<attr, Array<Array<selector, attr_to_inherit>> This should improve performance because: 1) We only fetch element at connectedCallback that actually will have attributes inherited. 2) When an attribute changes we can quickly inherit only that one. Differential Revision: https://phabricator.services.mozilla.com/D27801
635a123b100e: Bug 1545124 - Disable add-on manager logging for some tests. r=aswan
Mark Banner <standard8@mozilla.com> - Wed, 17 Apr 2019 15:48:07 +0000 - rev 469896
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1545124 - Disable add-on manager logging for some tests. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D27917
753a06be639a: Bug 1544924 - Support filtering individual classes with MOZ_INSTRUMENT_CUSTOM_ELEMENTS;r=aswan
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 17 Apr 2019 01:12:41 +0000 - rev 469839
Push 35883 by btara@mozilla.com at Wed, 17 Apr 2019 21:47:29 +0000
Bug 1544924 - Support filtering individual classes with MOZ_INSTRUMENT_CUSTOM_ELEMENTS;r=aswan For example, you can do MOZ_INSTRUMENT_CUSTOM_ELEMENTS=MozXULElement,Button to limit output to classes containing those strings in their name Differential Revision: https://phabricator.services.mozilla.com/D27800
e56cd039fd94: Bug 628041 refresh the install blocked panel text r=flod,aswan
Shane Caraveo <scaraveo@mozilla.com> - Thu, 11 Apr 2019 18:56:47 +0000 - rev 469073
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 628041 refresh the install blocked panel text r=flod,aswan Differential Revision: https://phabricator.services.mozilla.com/D25881
539ae4c2bd53: Bug 628041 refresh the install blocked panel text r=flod,aswan
Shane Caraveo <scaraveo@mozilla.com> - Wed, 10 Apr 2019 20:50:13 +0000 - rev 468892
Push 35854 by aciure@mozilla.com at Thu, 11 Apr 2019 09:50:57 +0000
Bug 628041 refresh the install blocked panel text r=flod,aswan Differential Revision: https://phabricator.services.mozilla.com/D25881
08bc1a0052f3: Bug 1543204 allow builtin addons to be hidden r=aswan
Shane Caraveo <scaraveo@mozilla.com> - Wed, 10 Apr 2019 18:07:52 +0000 - rev 468848
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1543204 allow builtin addons to be hidden r=aswan Differential Revision: https://phabricator.services.mozilla.com/D26787
a8c9a03ec27d: Bug 1541516 - Instrument base custom element class and print call information in the console r=aswan
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 10 Apr 2019 17:34:43 +0000 - rev 468833
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1541516 - Instrument base custom element class and print call information in the console r=aswan If MOZ_INSTRUMENT_CUSTOM_ELEMENTS is set in the environment, then modify Custom Elements to wrap each function and property lookup to keep a count and running time. Then print out tables for each element at startup. Tables can be re-printed with `MozElements.printInstrumentation()`. Differential Revision: https://phabricator.services.mozilla.com/D24953
5f27889c8461: Bug 1531650 - remove addons.mozilla.org Screenshots exception r=aswan
Ian Bicking <ibicking@mozilla.com> - Thu, 04 Apr 2019 18:27:16 +0000 - rev 468032
Push 35816 by ccoroiu@mozilla.com at Fri, 05 Apr 2019 03:22:21 +0000
Bug 1531650 - remove addons.mozilla.org Screenshots exception r=aswan In the past Screenshots was not permitted to work on addons.mozilla.org, but now with the mozillaAddons permission this restriction has been removed, and so the onboarding exception for addons.mozilla.org no longer needs to exist. Differential Revision: https://phabricator.services.mozilla.com/D25997
50d64901b71f: Bug 1541706 - fix linux intermittent xpinstall/browser_privatebrowsing.js, r=aswan
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 04 Apr 2019 16:30:13 +0000 - rev 468017
Push 35815 by ccoroiu@mozilla.com at Thu, 04 Apr 2019 21:55:21 +0000
Bug 1541706 - fix linux intermittent xpinstall/browser_privatebrowsing.js, r=aswan Differential Revision: https://phabricator.services.mozilla.com/D26186
a9aed50dd3eb: Bug 1522227 - Prevent assigning a shortcut that is already assigned r=mstriemer,aswan,flod
Trishul <trishul.goel@gmail.com> - Thu, 04 Apr 2019 05:22:28 +0000 - rev 467947
Push 35813 by aiakab@mozilla.com at Thu, 04 Apr 2019 16:07:30 +0000
Bug 1522227 - Prevent assigning a shortcut that is already assigned r=mstriemer,aswan,flod Prevent assigning a shortcut that is already assigned Differential Revision: https://phabricator.services.mozilla.com/D21327
52a59d6e04a0: Bug 1540856: Part 4 - Enable correct default theme on dev edition in xpcshell tests. r=aswan
Kris Maglione <maglione.k@gmail.com> - Mon, 01 Apr 2019 15:49:49 -0700 - rev 467894
Push 35811 by aciure@mozilla.com at Thu, 04 Apr 2019 04:34:36 +0000
Bug 1540856: Part 4 - Enable correct default theme on dev edition in xpcshell tests. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D25680
4ca1adcdd3f8: Bug 1540856: Part 3 - Ensure the default theme is enabled for browser mochitests. r=aswan
Kris Maglione <maglione.k@gmail.com> - Mon, 01 Apr 2019 15:37:12 -0700 - rev 467893
Push 35811 by aciure@mozilla.com at Thu, 04 Apr 2019 04:34:36 +0000
Bug 1540856: Part 3 - Ensure the default theme is enabled for browser mochitests. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D25679
17eb36dc4f27: Bug 1540856: Part 2 - Fix broken default theme check. r=aswan
Kris Maglione <maglione.k@gmail.com> - Mon, 01 Apr 2019 15:55:34 -0700 - rev 467892
Push 35811 by aciure@mozilla.com at Thu, 04 Apr 2019 04:34:36 +0000
Bug 1540856: Part 2 - Fix broken default theme check. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D25678
d7044f20a13f: Bug 1540856: Part 1 - Remove useless references to lightweightThemes preferences. r=aswan,dao
Kris Maglione <maglione.k@gmail.com> - Mon, 01 Apr 2019 15:22:20 -0700 - rev 467891
Push 35811 by aciure@mozilla.com at Thu, 04 Apr 2019 04:34:36 +0000
Bug 1540856: Part 1 - Remove useless references to lightweightThemes preferences. r=aswan,dao Differential Revision: https://phabricator.services.mozilla.com/D25677
2ea6eb1b66ae: Bug 1540435: Stop using LWTPersister for Android themes. r=aswan f=JanH
Kris Maglione <maglione.k@gmail.com> - Sat, 30 Mar 2019 14:32:54 -0700 - rev 467890
Push 35811 by aciure@mozilla.com at Thu, 04 Apr 2019 04:34:36 +0000
Bug 1540435: Stop using LWTPersister for Android themes. r=aswan f=JanH The Android front-end cannot directly load moz-extension: URIs, which means that theme resources ordinarily loaded via extension URIs need to be handled some other way. Prior to this patch, we used the antiquated LightweightThemePersister logic to copy those resources to external files and load them as file: URIs. This is unideal for a number of reasons, not least that it requires that we keep around over-complicated logic which was initially designed to persist theme images from web URLs. This patch instead just resolves any substituting protocol handler URI to the underlying resource URI, which will be either a file: or jar: URI which Java can handle directly. Differential Revision: https://phabricator.services.mozilla.com/D25524
c032b60a872e: Bug 1528335, r=aswan
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 03 Apr 2019 21:01:19 +0000 - rev 467855
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1528335, r=aswan Differential Revision: https://phabricator.services.mozilla.com/D25775
ee208901e86a: Bug 1528335 - tests, r=aswan
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 03 Apr 2019 21:01:06 +0000 - rev 467854
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1528335 - tests, r=aswan Differential Revision: https://phabricator.services.mozilla.com/D25774
1e40ddd945d1: Bug 1540112 - Enable addonsManager telemetry event category before the AddonManager/XPIProvider have been started. r=aswan,chutten
Luca Greco <lgreco@mozilla.com> - Wed, 03 Apr 2019 17:56:52 +0000 - rev 467812
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1540112 - Enable addonsManager telemetry event category before the AddonManager/XPIProvider have been started. r=aswan,chutten Differential Revision: https://phabricator.services.mozilla.com/D25380
fd9468269591: Bug 1528335, r=aswan
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 02 Apr 2019 19:37:59 +0000 - rev 467694
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1528335, r=aswan Differential Revision: https://phabricator.services.mozilla.com/D25775
acce10271d62: Bug 1528335 - tests, r=aswan
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 02 Apr 2019 19:37:36 +0000 - rev 467693
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1528335 - tests, r=aswan Differential Revision: https://phabricator.services.mozilla.com/D25774
58dd38390b06: Bug 1539925: Part 4 - Remove stray mochitest install.rdf file. r=aswan
Kris Maglione <maglione.k@gmail.com> - Thu, 28 Mar 2019 12:56:17 -0700 - rev 466989
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1539925: Part 4 - Remove stray mochitest install.rdf file. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D25292
be14a403cc0b: Bug 1539925: Part 3 - Remove stray bootstrapped extension test in test_cache_certdb.js. r=aswan
Kris Maglione <maglione.k@gmail.com> - Thu, 28 Mar 2019 12:38:21 -0700 - rev 466988
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1539925: Part 3 - Remove stray bootstrapped extension test in test_cache_certdb.js. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D25286
6c26d2387025: Bug 1539925: Part 2 - Remove stray install.rdf reference in test_proxies.js. r=aswan
Kris Maglione <maglione.k@gmail.com> - Thu, 28 Mar 2019 12:37:37 -0700 - rev 466987
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1539925: Part 2 - Remove stray install.rdf reference in test_proxies.js. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D25285
24258c725699: Bug 1539925: Part 1 - Remove stray install.rdf reference in AddonManagerStartup. r=aswan
Kris Maglione <maglione.k@gmail.com> - Thu, 28 Mar 2019 12:33:58 -0700 - rev 466986
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1539925: Part 1 - Remove stray install.rdf reference in AddonManagerStartup. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D25284
e69d39b3ac8d: Bug 1538343: Replace prepare_test() with something moderately less awful. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 22 Mar 2019 14:03:31 -0700 - rev 466985
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1538343: Replace prepare_test() with something moderately less awful. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D24560
ba1529f7fd78: Bug 1525762: Part 7 - Remove defunct LightweightThemeOptimizer. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 29 Mar 2019 11:37:08 -0700 - rev 466984
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 7 - Remove defunct LightweightThemeOptimizer. r=aswan It only works with "persisted" theme images, which no longer exist. Differential Revision: https://phabricator.services.mozilla.com/D25451
5d5860192199: Bug 1525762: Part 6 - Stop dispatching theme change observers using JSON strings. r=aswan
Kris Maglione <maglione.k@gmail.com> - Mon, 25 Mar 2019 13:52:01 -0700 - rev 466983
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 6 - Stop dispatching theme change observers using JSON strings. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D24795
1b30a2c10d99: Bug 1525762: Part 5 - Fix FOUC at startup when non-default theme is used. r=aswan
Kris Maglione <maglione.k@gmail.com> - Thu, 21 Mar 2019 13:31:59 -0700 - rev 466982
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 5 - Fix FOUC at startup when non-default theme is used. r=aswan The static theme startup code is both super asynchronous and super inefficient. It currently takes a noticeable amount of time after startup to finish its work and apply its theme, which results in the user seeing a flash of the default theme before their selected them is applied. This is particularly noticeable when dark mode themes are enabled. This patch caches the fully-processed theme data in the addonStartup cache, and applies it immediately after extension startup begins, if it's available.
238bd73cdf0b: Bug 1525762: Part 4 - Support automatic dark mode fallback for default theme again. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 08 Feb 2019 15:36:04 -0800 - rev 466981
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 4 - Support automatic dark mode fallback for default theme again. r=aswan
b9f524da2a61: Bug 1525762: Part 3f - Get rid of LWTPersister. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 08 Feb 2019 14:57:27 -0800 - rev 466980
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 3f - Get rid of LWTPersister. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D24633
b7481329e0b7: Bug 1525762: Part 3e - Get rid of LWTManager theme management code. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 08 Feb 2019 14:48:54 -0800 - rev 466979
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 3e - Get rid of LWTManager theme management code. r=aswan
9ad35a4e4717: Bug 1525762: Part 3d - Get rid of built-in LWT code. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 08 Feb 2019 14:31:34 -0800 - rev 466978
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 3d - Get rid of built-in LWT code. r=aswan
9b72a80ec78c: Bug 1525762: Part 3c - Get rid of LWT preview code. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 08 Feb 2019 14:30:20 -0800 - rev 466977
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 3c - Get rid of LWT preview code. r=aswan
eb90dbf5abc8: Bug 1525762: Part 3b - Get rid of LWT update code. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 08 Feb 2019 14:28:37 -0800 - rev 466976
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 3b - Get rid of LWT update code. r=aswan
2c10bcdc3d96: Bug 1525762: Part 3a - Get rid of LWTManager/AddonManager integration. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 08 Feb 2019 14:26:30 -0800 - rev 466975
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 3a - Get rid of LWTManager/AddonManager integration. r=aswan
5cbbb63ea73d: Bug 1525762: Part 2c - Use compact dark as default theme for dev edition builds. r=aswan
Kris Maglione <maglione.k@gmail.com> - Tue, 26 Mar 2019 13:01:56 -0700 - rev 466974
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 2c - Use compact dark as default theme for dev edition builds. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D24962
83612982ab33: Bug 1525762: Part 2b - Migrate selected lightweight theme when installing built-in themes. r=aswan
Kris Maglione <maglione.k@gmail.com> - Tue, 26 Mar 2019 12:57:30 -0700 - rev 466973
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 2b - Migrate selected lightweight theme when installing built-in themes. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D24961
b62c3bde4bc3: Bug 1525762: Part 2a - Migrate built-in LWTs to static WebExtension themes. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 08 Feb 2019 14:18:52 -0800 - rev 466972
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 2a - Migrate built-in LWTs to static WebExtension themes. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D24627
f31ce378439a: Bug 1525762: Part 1l - Don't delay serving image resources until extensions are ready. r=aswan
Kris Maglione <maglione.k@gmail.com> - Sat, 23 Mar 2019 15:26:03 -0700 - rev 466971
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 1l - Don't delay serving image resources until extensions are ready. r=aswan Since we want themes to be loaded before the main browser window is loaded, we really need their resources to be ready as soon as possible. We typically delay serving moz-extension: requests until the extension is ready, since extension page and CSS loads rely on the extension being fully initialized. Image loads, though, are perfectly safe to load as early as we need, so this patch whitelists them to bypass the delayed load logic.
7c7df3ee8aaa: Bug 1525762: Part 1i - Allow overriding some localized properties for built-in add-ons. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 08 Feb 2019 12:34:18 -0800 - rev 466969
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 1i - Allow overriding some localized properties for built-in add-ons. r=aswan We still don't have a great way to bundle localizations for built-in add-ons, since our localization tools are not compatible with the WebExtension localization format, and there's no way to fetch locales from language packs. We used to have a fairly complicated mechanism for this which used localized preference values, pointing to localized string bundle URLs, based on the add-on ID and the property we wanted to localized. That seems needlessly complicated at this point, so this patch just allows overrides in two specific string bundles, one for toolkit, and one for app-specific extensions. Differential Revision: https://phabricator.services.mozilla.com/D24623
f9e0f5aa1c6d: Bug 1525762: Part 1h - Use SCOPE_APPLICATION consistently for built-in add-ons. r=aswan
Kris Maglione <maglione.k@gmail.com> - Thu, 21 Mar 2019 19:33:26 -0700 - rev 466968
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 1h - Use SCOPE_APPLICATION consistently for built-in add-ons. r=aswan Most of our tests disable SCOPE_SYSTEM add-ons, which are meant to have been registered externally, but still rely on SCOPE_APPLICATION addons (i.e., the default theme), which are meant to be part of the application. We currently flag the built-in location as SCOPE_SYSTEM in some places and SCOPE_APPLICATION in others, which leads to those add-ons not being available to some tests that need them.
d7e4177fca6f: Bug 1525762: Part 1g - Fix issues with add-on sourceBundle and rootURI properties. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 22 Mar 2019 09:38:11 -0700 - rev 466967
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 1g - Fix issues with add-on sourceBundle and rootURI properties. r=aswan There are all sorts of random issues with rootURI sometimes not being set for sourceBundle add-ons, or callers expecting sourceBundle to never be null. This patch fixes all of those issues that I came across.
e8e9739ac28b: Bug 1525762: Part 1f - Fix dodgy error message. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 22 Mar 2019 09:37:38 -0700 - rev 466966
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 1f - Fix dodgy error message. r=aswan The filePath property is used in error messages, and is expected to be a string. Setting it to a nsIFile object makes those error messages inscrutable.
cc45935ed2c2: Bug 1525762: Part 1e - Don't hide add-ons in the built-in location. r=aswan
Kris Maglione <maglione.k@gmail.com> - Thu, 28 Mar 2019 14:50:40 -0700 - rev 466965
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 1e - Don't hide add-ons in the built-in location. r=aswan We want add-ons in the built-in location, particularly the built-in themes, to appear in the add-on manager so that users can enable and disable them. We don't want them to be able to uninstall them, though, so this also prevents users from uninstalling them. Differential Revision: https://phabricator.services.mozilla.com/D24619
f595c6ccb68a: Bug 1525762: Part 1d - Don't throw from hasResource for resources that don't exist. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 22 Mar 2019 09:35:22 -0700 - rev 466964
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 1d - Don't throw from hasResource for resources that don't exist. r=aswan When attempting to fetch a local resource which doesn't exist, the fetch promise rejects, causing the hasResource promise to reject. Since we don't want hasResource to reject for nonexistent resources, we need to catch this rejection and treat it as a nonexistent resource.
935a2cd834c2: Bug 1525762: Part 1c - Resolve built-in add-on resource: URIs at startup, not install. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 22 Mar 2019 09:34:29 -0700 - rev 466963
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 1c - Resolve built-in add-on resource: URIs at startup, not install. r=aswan It's possible for the application install location to vary from session to session, particularly when the same profile is used with multiple app versions, or with both packed and unpacked builds. Resolving resource: URIs at install time causes problems in those instances, since it will always point to the inital app location. Resolving the resource URIs at runtime solves this. Differential Revision: https://phabricator.services.mozilla.com/D24617
40936b75fd32: Bug 1525762: Part 1b - Add databaseReady promise to replace xpi-database-loaded observer. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 22 Mar 2019 09:26:33 -0700 - rev 466962
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Bug 1525762: Part 1b - Add databaseReady promise to replace xpi-database-loaded observer. r=aswan All of the consumers of this observer really want it to behave like a promise. And, for the cases where the DB may or may not already be loaded when those callers run, getting the logic correct is difficult. This patch replaces the observer with a promise, and also delays the resolution of that promise until any built-in add-ons registered during XPIProvider startup have finished installing. This latter feature is currently unused, but will be necessary after subsequent patches for code that relies querying the default theme immediately after provider startup.