searching for reviewer(andi)
4b4988e99e7687fbd8a5d5b2d6391cf2e42d3421: Bug 1568771 - Output paths relative to repository in ./mach static-analysis check-coverity, r=andi
Bastien Abadie <bastien@mozilla.com> - Tue, 30 Jul 2019 06:44:52 +0000 - rev 485244
Push 36363 by rmaries@mozilla.com at Tue, 30 Jul 2019 15:38:07 +0000
Bug 1568771 - Output paths relative to repository in ./mach static-analysis check-coverity, r=andi Differential Revision: https://phabricator.services.mozilla.com/D39306
3717ce1a6d03eac33e0f4b533b354a3a9d38b6a6: Bug 1568535 - Output relative paths in mach static-analysis check, r=andi
Bastien Abadie <bastien@mozilla.com> - Thu, 25 Jul 2019 08:50:50 +0000 - rev 484668
Push 36342 by aciure@mozilla.com at Thu, 25 Jul 2019 16:18:40 +0000
Bug 1568535 - Output relative paths in mach static-analysis check, r=andi Differential Revision: https://phabricator.services.mozilla.com/D39197
dded2f82e555e5c3b1ba7893ab6d61fde76df046: Bug 1568558 - Output paths relative to repository in ./mach clang-format, r=andi
Bastien Abadie <bastien@mozilla.com> - Thu, 25 Jul 2019 08:50:33 +0000 - rev 484667
Push 36342 by aciure@mozilla.com at Thu, 25 Jul 2019 16:18:40 +0000
Bug 1568558 - Output paths relative to repository in ./mach clang-format, r=andi Differential Revision: https://phabricator.services.mozilla.com/D39211
ec2818ee17f73621d39f6e52a4cbaaef76ce2b54: Bug 1564824 - Format source fails with Prettier on patches with moved files where the original directory also does not exist, r=andi
Victor Porof <vporof@mozilla.com> - Wed, 10 Jul 2019 11:15:18 +0000 - rev 482139
Push 36271 by aiakab@mozilla.com at Wed, 10 Jul 2019 21:50:49 +0000
Bug 1564824 - Format source fails with Prettier on patches with moved files where the original directory also does not exist, r=andi Differential Revision: https://phabricator.services.mozilla.com/D37537
3dc9d0ab9eeae14b6a5b369c3235d69249cad37d: Bug 1519636 - Ride along - remove useless ';' r=andi
Sylvestre Ledru <sledru@mozilla.com> - Sat, 06 Jul 2019 12:36:03 +0000 - rev 481539
Push 36249 by rmaries@mozilla.com at Sat, 06 Jul 2019 21:46:28 +0000
Bug 1519636 - Ride along - remove useless ';' r=andi Depends on D35622 Differential Revision: https://phabricator.services.mozilla.com/D37147
4544e7e71ba01f4415986f781b88040af90127d5: Bug 1563718 - Add Zydis to the list of third party code r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 05 Jul 2019 13:03:13 +0000 - rev 481462
Push 36246 by malexandru@mozilla.com at Sat, 06 Jul 2019 03:34:49 +0000
Bug 1563718 - Add Zydis to the list of third party code r=andi Differential Revision: https://phabricator.services.mozilla.com/D37052
fa87fa78124ecf6d59ab20e7ad3a957605d91bed: Bug 1556393 - Pre 1 (m-c): Update .hg-format-source to use Prettier when running format-source, r=andi, CLOSED TREE
Victor Porof <vporof@mozilla.com> - Wed, 03 Jul 2019 20:48:37 +0200 - rev 481352
Push 36241 by vporof@mozilla.com at Fri, 05 Jul 2019 13:11:20 +0000
Bug 1556393 - Pre 1 (m-c): Update .hg-format-source to use Prettier when running format-source, r=andi, CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D36719
60169d9efd0d99bd6c9d891288c0b740f65a4571: Bug 1556393 - Pre 0 (m-c): Create a simple Prettier command for running format-source, r=andi
Victor Porof <vporof@mozilla.com> - Thu, 04 Jul 2019 14:50:20 +0200 - rev 481351
Push 36241 by vporof@mozilla.com at Fri, 05 Jul 2019 13:11:20 +0000
Bug 1556393 - Pre 0 (m-c): Create a simple Prettier command for running format-source, r=andi Differential Revision: https://phabricator.services.mozilla.com/D36720
98eb0b753429a9da45154a18c3779e7840c72619: Bug 1519636 - Mark the entire media/libdav1d directory as third-party; r=andi
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 28 Jun 2019 07:37:58 +0000 - rev 481135
Push 36234 by opoprus@mozilla.com at Thu, 04 Jul 2019 03:31:17 +0000
Bug 1519636 - Mark the entire media/libdav1d directory as third-party; r=andi Differential Revision: https://phabricator.services.mozilla.com/D35474
f0ac391dd02a4296a724462cdfa3c89cc8e39a00: Bug 1557338 - Fix up TestSprintfLiteral.cpp for warnings on clang trunk r=andi
David Major <dmajor@mozilla.com> - Mon, 01 Jul 2019 21:37:44 +0000 - rev 480826
Push 36225 by dluca@mozilla.com at Tue, 02 Jul 2019 09:35:50 +0000
Bug 1557338 - Fix up TestSprintfLiteral.cpp for warnings on clang trunk r=andi LLVM r356397 added some new warnings to the compiler that in this file complain about `size argument is too large; destination buffer has size 100, but size argument is 101`. The easiest path is to just remove those lines; doing so doesn't really weaken the test coverage of the SprintfLiteral checker. Differential Revision: https://phabricator.services.mozilla.com/D36515
23973e3a5e9503919dbf529d531ac1212cf4641a: Bug 1557338 - Fix up TestSprintfLiteral.cpp for warnings on clang trunk r=andi
David Major <dmajor@mozilla.com> - Mon, 01 Jul 2019 18:32:34 +0000 - rev 480812
Push 36225 by dluca@mozilla.com at Tue, 02 Jul 2019 09:35:50 +0000
Bug 1557338 - Fix up TestSprintfLiteral.cpp for warnings on clang trunk r=andi LLVM r356397 added some new warnings to the compiler that in this file complain about `size argument is too large; destination buffer has size 100, but size argument is 101`. The easiest path is to just remove those lines; doing so doesn't really weaken the test coverage of the SprintfLiteral checker. Differential Revision: https://phabricator.services.mozilla.com/D36515
7b596892f7b0a10d15933e8bf15f491017afa121: Bug 1559740 - Move the clang-{format,tidy} and infer declarations into a separate directory r=andi
Sylvestre Ledru <sledru@mozilla.com> - Mon, 01 Jul 2019 13:57:18 +0000 - rev 480783
Push 36224 by rgurzau@mozilla.com at Mon, 01 Jul 2019 21:52:17 +0000
Bug 1559740 - Move the clang-{format,tidy} and infer declarations into a separate directory r=andi Differential Revision: https://phabricator.services.mozilla.com/D35187
df14ac0c2421c552ea7d80b8ded1d52b1a656254: Bug 1559740 - Ride along - flake8+black+codespell on python/mozbuild/mozbuild/code-analysis/mach_commands.py r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 28 Jun 2019 07:40:18 +0000 - rev 480551
Push 36215 by shindli@mozilla.com at Fri, 28 Jun 2019 23:19:25 +0000
Bug 1559740 - Ride along - flake8+black+codespell on python/mozbuild/mozbuild/code-analysis/mach_commands.py r=andi Depends on D35187 Differential Revision: https://phabricator.services.mozilla.com/D35188
089e04f53971dfd39dd9074b1a60847aa4359b18: Bug 1559740 - Move the clang-{format,tidy} and infer declarations into a separate directory r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 28 Jun 2019 07:39:48 +0000 - rev 480550
Push 36215 by shindli@mozilla.com at Fri, 28 Jun 2019 23:19:25 +0000
Bug 1559740 - Move the clang-{format,tidy} and infer declarations into a separate directory r=andi Differential Revision: https://phabricator.services.mozilla.com/D35187
201f4f4fe86e48f9d6b2ce27b728e3bbe11c89c0: Bug 1557313 - Update ExplicitOperatorBoolChecker.cpp for clang trunk changes r=andi
David Major <dmajor@mozilla.com> - Thu, 06 Jun 2019 15:42:25 +0000 - rev 477640
Push 36119 by ncsoregi@mozilla.com at Thu, 06 Jun 2019 21:52:09 +0000
Bug 1557313 - Update ExplicitOperatorBoolChecker.cpp for clang trunk changes r=andi https://reviews.llvm.org/rL360311 reworked the handling of `explicit` in `CXXConversionDecl`, and the `isExplicitSpecified()` method no longer exists. We can instead use `isExplicit()` which conveniently works on both old and new clangs. (Before 360311, `isExplicit()` just forwarded to `isExplicitSpecified()`.) Differential Revision: https://phabricator.services.mozilla.com/D33958
f99b54a6da932c5e88a6932d5d6f27629ba89a4e: Bug 1554989 - Fix implicit checker on inheriting constructors r=andi
Yaron Tausky <ytausky@mozilla.com> - Tue, 04 Jun 2019 11:36:46 +0000 - rev 476758
Push 36106 by btara@mozilla.com at Tue, 04 Jun 2019 16:04:27 +0000
Bug 1554989 - Fix implicit checker on inheriting constructors r=andi Inheriting constructors are implicitly introduced via a using-declaration. Since the C++ grammar doesn't allow attributes on using-declarations, it is currently impossible to add MOZ_IMPLICIT to implicit inheriting constructors. This commit changes the AST matcher such that it ignores inheriting constructors altogether. If they are inheriting from an implicit inherited constructor, that constructor's check should be enough to ensure that no constructors are unintentionally implicit. Differential Revision: https://phabricator.services.mozilla.com/D33281
030c742c25d5e3aab01c2e020345a7cd5506b207: Bug 1551083 - Enable bugprone-move-forwarding-reference r=andi
Sylvestre Ledru <sledru@mozilla.com> - Tue, 14 May 2019 07:12:37 +0000 - rev 473736
Push 36013 by csabou@mozilla.com at Tue, 14 May 2019 16:01:08 +0000
Bug 1551083 - Enable bugprone-move-forwarding-reference r=andi Differential Revision: https://phabricator.services.mozilla.com/D30816
ebcc8dd9c2bc63bc4e82ce15a87aa66c0f73e932: Bug 1544797 - clang-format: Use the topsrcdir to generate the paths instead of the pwd r=andi
Sylvestre Ledru <sledru@mozilla.com> - Tue, 16 Apr 2019 17:38:24 +0000 - rev 469778
Push 35882 by cbrindusan@mozilla.com at Wed, 17 Apr 2019 15:54:01 +0000
Bug 1544797 - clang-format: Use the topsrcdir to generate the paths instead of the pwd r=andi If the user runs mach clang-format from the builddir, it was finding and using unified files. Differential Revision: https://phabricator.services.mozilla.com/D27750
323eef8fd5ff8d4968c77fb6c77d65b010b31ad6: Bug 1541412 - Add static-analysis check-java to source-test tasks, r=ahal,andi
Bastien Abadie <bastien@mozilla.com> - Mon, 08 Apr 2019 15:41:30 +0000 - rev 468772
Push 35850 by dvarga@mozilla.com at Wed, 10 Apr 2019 21:52:56 +0000
Bug 1541412 - Add static-analysis check-java to source-test tasks, r=ahal,andi Differential Revision: https://phabricator.services.mozilla.com/D25929
6f723cac81ddf18954af5c5b3d430864e849930b: Bug 1542146 - Apply the change with the option StatementMacros from clang-format-8 r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 05 Apr 2019 21:42:17 +0000 - rev 468250
Push 35824 by apavel@mozilla.com at Sat, 06 Apr 2019 10:57:50 +0000
Bug 1542146 - Apply the change with the option StatementMacros from clang-format-8 r=andi # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D26280
55ed5f885d52c347f6ef98bb86d2eb71f2a729c3: Bug 1542146 - Use the new option StatementMacros from clang-format-8 r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 05 Apr 2019 21:41:57 +0000 - rev 468249
Push 35824 by apavel@mozilla.com at Sat, 06 Apr 2019 10:57:50 +0000
Bug 1542146 - Use the new option StatementMacros from clang-format-8 r=andi Differential Revision: https://phabricator.services.mozilla.com/D26279
6a4df15647dc5bafc27baac34635c3d0e18ecb16: Bug 1540643 - Add testing/web-platform/tests/tools/third_party/ to the thirdparty list r=andi DONTBUILD
Sylvestre Ledru <sledru@mozilla.com> - Mon, 01 Apr 2019 10:25:29 +0000 - rev 467712
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1540643 - Add testing/web-platform/tests/tools/third_party/ to the thirdparty list r=andi DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D25567
299b8a36da73c52e9a6f39c3ee292f6986ca1429: Bug 1540769 - Enable readability-redundant-preprocessor r=andi
Sylvestre Ledru <sledru@mozilla.com> - Tue, 02 Apr 2019 06:07:39 +0000 - rev 467545
Push 35802 by cbrindusan@mozilla.com at Tue, 02 Apr 2019 15:46:39 +0000
Bug 1540769 - Enable readability-redundant-preprocessor r=andi Differential Revision: https://phabricator.services.mozilla.com/D25630
20b1524329bb89a5fd944d46aa15183dc0caf6ce: Bug 1536790 - Also import clangTidyMPIModule when building the clang-plugin r=andi
Sylvestre Ledru <sledru@mozilla.com> - Mon, 01 Apr 2019 12:24:37 +0000 - rev 467495
Push 35799 by cbrindusan@mozilla.com at Tue, 02 Apr 2019 08:35:12 +0000
Bug 1536790 - Also import clangTidyMPIModule when building the clang-plugin r=andi Depends on D24175 Differential Revision: https://phabricator.services.mozilla.com/D25026
f5395d54a7d10df951f10edebe4d593436f85d50: Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
Sylvestre Ledru <sledru@mozilla.com> - Mon, 01 Apr 2019 12:24:35 +0000 - rev 467493
Push 35799 by cbrindusan@mozilla.com at Tue, 02 Apr 2019 08:35:12 +0000
Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi Differential Revision: https://phabricator.services.mozilla.com/D24175
9eb7867c1dd431f6effdd99bfea5c8a003ebb730: Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
Sylvestre Ledru <sledru@mozilla.com> - Sat, 30 Mar 2019 01:23:21 +0200 - rev 466872
Push 35784 by nerli@mozilla.com at Sat, 30 Mar 2019 09:32:04 +0000
Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi Reviewers: andi Reviewed By: andi Bug #: 1536790 Differential Revision: https://phabricator.services.mozilla.com/D24175
20d5cdaa08e33da406709986f812c23404f33a96: Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 28 Mar 2019 17:49:41 +0000 - rev 466720
Push 35780 by opoprus@mozilla.com at Fri, 29 Mar 2019 21:53:01 +0000
Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi Patch wrote by Sylvestre Ledru (sylvestre@mozilla.com) Differential Revision: https://phabricator.services.mozilla.com/D24175
fa3daa92292dde4bf9405c56e43a464e53c349a2: Bug 1519636 - Ride along: Add media/libdav1d/version.h to the ignore list r=andi
Sylvestre Ledru <sledru@mozilla.com> - Wed, 27 Mar 2019 07:33:24 +0000 - rev 466310
Push 35764 by aciure@mozilla.com at Wed, 27 Mar 2019 16:35:35 +0000
Bug 1519636 - Ride along: Add media/libdav1d/version.h to the ignore list r=andi Differential Revision: https://phabricator.services.mozilla.com/D24558
45e9712fb50e6abdc26ad0b311289fe50540c735: Bug 1539013. Teach MOZ_CAN_RUN_SCRIPT about taking pointers to live references. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 26 Mar 2019 20:55:41 +0000 - rev 466221
Push 35762 by csabou@mozilla.com at Wed, 27 Mar 2019 04:44:00 +0000
Bug 1539013. Teach MOZ_CAN_RUN_SCRIPT about taking pointers to live references. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24840
4e4f6c86795203a8255bed21a17e2d5cfce12520: Bug 1539016 part 2. Teach MOZ_CAN_RUN_SCRIPT analysis about conditional operators. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 26 Mar 2019 20:56:36 +0000 - rev 466220
Push 35762 by csabou@mozilla.com at Wed, 27 Mar 2019 04:44:00 +0000
Bug 1539016 part 2. Teach MOZ_CAN_RUN_SCRIPT analysis about conditional operators. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24839
48e6a07862e0c79ecac3aa7dc826a2f3e42bb98f: Bug 1539016 part 1. Refactor the MOZ_CAN_RUN_SCRIPT analysis a bit to make new live things easier to add. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 26 Mar 2019 20:56:16 +0000 - rev 466219
Push 35762 by csabou@mozilla.com at Wed, 27 Mar 2019 04:44:00 +0000
Bug 1539016 part 1. Refactor the MOZ_CAN_RUN_SCRIPT analysis a bit to make new live things easier to add. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24838
eeff570a825a7370902317ae5dc53862d4f82c7e: Bug 1537537. Improve the MOZ_CAN_RUN_SCRIPT analysis reporting around invalid args. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:52:50 +0000 - rev 465428
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1537537. Improve the MOZ_CAN_RUN_SCRIPT analysis reporting around invalid args. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24258
664d49ea52757224083e93a9742e676bb8689ef4: Bug 1536736. Allow constexpr things in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:52:33 +0000 - rev 465427
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536736. Allow constexpr things in the MOZ_CAN_RUN_SCRIPT analysis. r=andi Since these are compile-time constants, they can't exactly go away on us due to running script, right? Differential Revision: https://phabricator.services.mozilla.com/D24195
1133a148d29c657567b6985e08af96adab3328f7: Bug 1536825. Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:50:55 +0000 - rev 465426
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536825. Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis. r=andi We need to typecheck the trivials too, not just the final thing after trivials are stripped, because casts are trivials. Differential Revision: https://phabricator.services.mozilla.com/D24186
15a5f72d591f9af00b5379495e8d7258e5840226: Bug 1536724. Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:49:11 +0000 - rev 465425
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536724. Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24120
9acf9a003aa388a9d7efd11fb2a9031b6a7ed7df: Bug 1536719. Fix handling of member method calls in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:48:33 +0000 - rev 465424
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536719. Fix handling of member method calls in the MOZ_CAN_RUN_SCRIPT analysis. r=andi The old code for member method calls did the following: 1) Find the member method calls. 2) Look at their "this" expression. 3) If the "this" is an operator call, check for any of the arguments of the operator call being invalid. 4) Otherwise (if not an operator call) check for the "this" value being invalid. This wasn't right, because the "is invalid" check checks the type and only considers refcounted things. So if the code looked something like "foo[i]->call_method()", we would look at the types of "foo" and "i" and determine that none of those are refcounted types so there is nothing invalid here (since "foo" is some sort of array type and "i" is an integer). The new setup just checks whether the "this" value is invalid, which does the type check on the "this" value itself; in the "foo[i]->call_method()" case on "foo[i]". We then adjust the exclusions in InvalidArg to consider operator-> on known-live things valid, to allow the thing that we were really trying to accomplish with the "check for an operator call" bits: "stackRefPtr->some_method()". The test coverage being added for the made-up TArray type is meant to catch things like the geolocation issue that was being hidden by the buggy behavior. I'm not using nsTArray itself because some header included by nsTArray.h tries to define operator new/delete bits inline and that triggers warnings that then cause a clang-plugin test failure, because they're unexpected. Differential Revision: https://phabricator.services.mozilla.com/D24117
6365c8d87a5c8811f5dda4e4417450515e1f6bc3: Bug 1536336. Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:47:22 +0000 - rev 465423
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536336. Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs. r=andi "this" is guaranteed to stay alive as long as other MOZ_CAN_RUN_SCRIPT conditions hold, and its const members can't change value and drop their refs. Differential Revision: https://phabricator.services.mozilla.com/D23997
f754116e738e64751d2aad9ac0aa295aabd939ce: Bug 1537537. Improve the MOZ_CAN_RUN_SCRIPT analysis reporting around invalid args. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 20:04:13 +0000 - rev 465352
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1537537. Improve the MOZ_CAN_RUN_SCRIPT analysis reporting around invalid args. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24258
f9df48cfea437be34e3935f44d48c00c13b33f7f: Bug 1536736. Allow constexpr things in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 20:04:11 +0000 - rev 465351
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1536736. Allow constexpr things in the MOZ_CAN_RUN_SCRIPT analysis. r=andi Since these are compile-time constants, they can't exactly go away on us due to running script, right? Differential Revision: https://phabricator.services.mozilla.com/D24195
7a9888e700cf54d199d2b373ef14cab07ce78609: Bug 1536825. Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 15:25:55 +0000 - rev 465350
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1536825. Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis. r=andi We need to typecheck the trivials too, not just the final thing after trivials are stripped, because casts are trivials. Differential Revision: https://phabricator.services.mozilla.com/D24186
e2551303c5cfeb97bc874cb750240dc10b413aaf: Bug 1536724. Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 14:40:34 +0000 - rev 465349
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1536724. Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24120
f497ce3b74193fdbc272e68719f3bc603e62571b: Bug 1536719. Fix handling of member method calls in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 18:08:16 +0000 - rev 465348
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1536719. Fix handling of member method calls in the MOZ_CAN_RUN_SCRIPT analysis. r=andi The old code for member method calls did the following: 1) Find the member method calls. 2) Look at their "this" expression. 3) If the "this" is an operator call, check for any of the arguments of the operator call being invalid. 4) Otherwise (if not an operator call) check for the "this" value being invalid. This wasn't right, because the "is invalid" check checks the type and only considers refcounted things. So if the code looked something like "foo[i]->call_method()", we would look at the types of "foo" and "i" and determine that none of those are refcounted types so there is nothing invalid here (since "foo" is some sort of array type and "i" is an integer). The new setup just checks whether the "this" value is invalid, which does the type check on the "this" value itself; in the "foo[i]->call_method()" case on "foo[i]". We then adjust the exclusions in InvalidArg to consider operator-> on known-live things valid, to allow the thing that we were really trying to accomplish with the "check for an operator call" bits: "stackRefPtr->some_method()". The test coverage being added for the made-up TArray type is meant to catch things like the geolocation issue that was being hidden by the buggy behavior. I'm not using nsTArray itself because some header included by nsTArray.h tries to define operator new/delete bits inline and that triggers warnings that then cause a clang-plugin test failure, because they're unexpected. Differential Revision: https://phabricator.services.mozilla.com/D24117
fd59264c47c1bfe373888d234ededf056c1112fa: Bug 1536336. Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 04:19:24 +0000 - rev 465347
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1536336. Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs. r=andi "this" is guaranteed to stay alive as long as other MOZ_CAN_RUN_SCRIPT conditions hold, and its const members can't change value and drop their refs. Differential Revision: https://phabricator.services.mozilla.com/D23997
2a807fde4c47339f48e548127d215880183fbcae: Bug 1536763 - Support more than 100 files in ./mach static-analysis check, r=andi
Bastien Abadie <bastien@mozilla.com> - Wed, 20 Mar 2019 13:03:13 +0000 - rev 465214
Push 35735 by shindli@mozilla.com at Thu, 21 Mar 2019 04:34:45 +0000
Bug 1536763 - Support more than 100 files in ./mach static-analysis check, r=andi Differential Revision: https://phabricator.services.mozilla.com/D24151
f65aaa2a97bb8bc7ab61a4fb650db6b356911767: Bug 1534421. Fix the CAN_RUN_SCRIPT analysis to treat a deref of an arg as live if it would treat the arg as live. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 13 Mar 2019 12:13:08 +0000 - rev 463815
Push 35698 by ncsoregi@mozilla.com at Wed, 13 Mar 2019 21:52:48 +0000
Bug 1534421. Fix the CAN_RUN_SCRIPT analysis to treat a deref of an arg as live if it would treat the arg as live. r=andi Differential Revision: https://phabricator.services.mozilla.com/D23071
b6d239de820fce497fc6e7d5f6a10ad2a1a4122b: Bug 1534518. Change CanRunScriptChecker caller function note to point to the declaration, not the definition. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 13 Mar 2019 12:11:34 +0000 - rev 463814
Push 35698 by ncsoregi@mozilla.com at Wed, 13 Mar 2019 21:52:48 +0000
Bug 1534518. Change CanRunScriptChecker caller function note to point to the declaration, not the definition. r=andi Differential Revision: https://phabricator.services.mozilla.com/D23082
bad1df2f11e3962bea1ec567845e50399cf87357: Bug 1534630: Slightly optimize scheduling of clang-format jobs; r=andi
Benjamin Bouvier <benj@benj.me> - Tue, 12 Mar 2019 16:30:12 +0000 - rev 463792
Push 35697 by opoprus@mozilla.com at Wed, 13 Mar 2019 16:13:53 +0000
Bug 1534630: Slightly optimize scheduling of clang-format jobs; r=andi Instead of over-estimating the number of items in a batch, do the opposite: slightly under-estimate the number of items, then dispatch outstanding items (by just adding one item to each batch). Differential Revision: https://phabricator.services.mozilla.com/D23141
9b6190dc000dd50c2a971bb795c8df29099eb864: Bug 1506439 part 1. Fix CanRunScript analysis handling of arguments that default to null. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 13 Mar 2019 02:33:57 +0000 - rev 463751
Push 35695 by opoprus@mozilla.com at Wed, 13 Mar 2019 09:57:07 +0000
Bug 1506439 part 1. Fix CanRunScript analysis handling of arguments that default to null. r=andi Differential Revision: https://phabricator.services.mozilla.com/D23064
aaf573c47a9c2edf5eba678974d9745e21260acd: Bug 1533152 - [flake8] Make sure glob patterns are honoured when passing files directly, r=andi
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 12 Mar 2019 15:08:41 +0000 - rev 463674
Push 35691 by nbeleuzu@mozilla.com at Tue, 12 Mar 2019 21:43:52 +0000
Bug 1533152 - [flake8] Make sure glob patterns are honoured when passing files directly, r=andi Flake8 ignores the 'exclude' section of the .flake8.yml if you pass in a direct path to a file. To get around this we have some custom logic to handle these exclusions for us, but this custom logic didn't account for globs. Differential Revision: https://phabricator.services.mozilla.com/D23145
94ae30387e57697e0044cad778459f751319fe11: Bug 1533617 part 5. Disallow virtual MOZ_CAN_RUN_SCRIPT methods overriding a non-MOZ_CAN_RUN_SCRIPT superclass method. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 11 Mar 2019 14:20:27 +0000 - rev 463497
Push 35686 by btara@mozilla.com at Tue, 12 Mar 2019 09:50:48 +0000
Bug 1533617 part 5. Disallow virtual MOZ_CAN_RUN_SCRIPT methods overriding a non-MOZ_CAN_RUN_SCRIPT superclass method. r=andi This way if a caller calls a method that has a MOZ_CAN_RUN_SCRIPT override, it can detect that it's possibly calling a MOZ_CAN_RUN_SCRIPT thing without having to know about the override. Differential Revision: https://phabricator.services.mozilla.com/D22839