searching for reviewer(alwu)
669ca27af67f297133783f30c87b709470b0d3fa: Bug 1698778 - Allow using VA-API in the RDD process. r=alwu,stransky
Jed Davis <jld@mozilla.com> - Tue, 23 Nov 2021 01:14:41 +0000 - rev 599845
Push 39002 by nfay@mozilla.com at Tue, 23 Nov 2021 09:42:49 +0000
Bug 1698778 - Allow using VA-API in the RDD process. r=alwu,stransky The previous patches mean that VA-API shouldn't cause sandbox violations in the RDD process, so there's no need to lock it out. This patch does **not** change the prefs to enable it (`media.rdd-ffmpeg.enabled` and `media.ffmpeg.vaapi.enabled`), but now those prefs will be honored if they are flipped, to allow testing. Differential Revision: https://phabricator.services.mozilla.com/D131681
20663c1b363cabaf29a1e355841c24fa73c9f2c4: Bug 1741677 - Make media.flac.enabled pref into a RelaxedAtomicBool. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Thu, 18 Nov 2021 14:05:23 +0000 - rev 599553
Push 38988 by nbeleuzu@mozilla.com at Thu, 18 Nov 2021 16:26:28 +0000
Bug 1741677 - Make media.flac.enabled pref into a RelaxedAtomicBool. r=alwu Depends on D131431 Differential Revision: https://phabricator.services.mozilla.com/D131432
dc467fca82335312fbb5daa4c3a2edf5d88483be: Bug 1741677 - Add crash test. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Thu, 18 Nov 2021 14:05:22 +0000 - rev 599552
Push 38988 by nbeleuzu@mozilla.com at Thu, 18 Nov 2021 16:26:28 +0000
Bug 1741677 - Add crash test. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D131431
af9895bca33c5e4fcda06347f21b825d672f91b6: Bug 1741257 - Report info in MediaShutdownManager::GetState. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Tue, 16 Nov 2021 19:09:11 +0000 - rev 599368
Push 38984 by malexandru@mozilla.com at Wed, 17 Nov 2021 03:41:08 +0000
Bug 1741257 - Report info in MediaShutdownManager::GetState. r=alwu Add reporting to MediaShutdownManager::GetState to help diagnose issues with shutdown blockers. This method wasn't reporting anything before, but will now report - The init phase the manager is in. - The extened mime types that the decoder was created with. My hope is these will be enough to help better diagnose issues with shutdown blockers, but we can always expand the info being reported if these aren't enough. Differential Revision: https://phabricator.services.mozilla.com/D131169
ce2fff273989eced27b1aac65b52409e5f2242a0: Bug 1726617 - p2: fallback to SW when failing to init platform encoder. r=alwu
John Lin <jolin@mozilla.com> - Thu, 04 Nov 2021 16:30:52 +0000 - rev 598263
Push 38950 by ctuns@mozilla.com at Fri, 05 Nov 2021 09:34:21 +0000
Bug 1726617 - p2: fallback to SW when failing to init platform encoder. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D126976
4f5ac04b4f82befe9fe1ca2b9f6e9035db8e4134: Bug 1654112 - Add a MediaEventForwarder for aggregating multiple MediaEventSources into one. r=alwu
Andreas Pehrson <apehrson@mozilla.com> - Wed, 10 Feb 2021 15:01:48 +0100 - rev 597566
Push 38934 by archaeopteryx@coole-files.de at Mon, 01 Nov 2021 18:17:33 +0000
Bug 1654112 - Add a MediaEventForwarder for aggregating multiple MediaEventSources into one. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D104723
e27da301b07a35afc193ab2b38e29118baaef783: Bug 1684876 - Separate Play and Mute tab menu icons and functionality r=Gijs,alwu,flod
kz04px <kz04px@gmail.com> - Tue, 26 Oct 2021 16:33:10 +0000 - rev 596968
Push 38915 by mlaza@mozilla.com at Tue, 26 Oct 2021 21:44:17 +0000
Bug 1684876 - Separate Play and Mute tab menu icons and functionality r=Gijs,alwu,flod Differential Revision: https://phabricator.services.mozilla.com/D128280
d220324764f68f5651bba6119a67337dba4b3a32: Bug 1678373 - Remove mAudibleState. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:57 +0000 - rev 595474
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Remove mAudibleState. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D127559
7f576213cb8ec3d164ddb988b25388d756c7af82: Bug 1678373 - Don't count muted time without an audio track, but start counting time as soon as an audio track is added. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:57 +0000 - rev 595473
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Don't count muted time without an audio track, but start counting time as soon as an audio track is added. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D126912
6434fda3a84d5f2aa67e9d57d1b66e3641ff89f3: Bug 1678373 - Adjust media telemetry attributes. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:57 +0000 - rev 595472
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Adjust media telemetry attributes. r=alwu 2h is a bit short for video. Percentage need to be linear and between 0 and 100. 50 buckets are good enough, having 100 buckets doesn't work, it needs to be lower than the `high` value. Differential Revision: https://phabricator.services.mozilla.com/D125846
b68c9fd767e64ef2dbcd11b32514bae2cd38b8cc: Bug 1678373 - Count muted time correct when seeking while muted. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:56 +0000 - rev 595471
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Count muted time correct when seeking while muted. r=alwu The counter was paused, but `mIsMuted` was getting desynchronized. It's best to reset the media element muted state, visibility and media content when paused, they are set again properly in ::Play, preventing any issue. It is necessary to reset the media content after reporting telemetry, because a media content of MEDIA_HAS_NOTHING isn't reported. Differential Revision: https://phabricator.services.mozilla.com/D125845
3af6fc476e78a057a3ae2e6b27aa1484eea732e8: Bug 1678373 - Update description for media playback telemetry probes. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:56 +0000 - rev 595470
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Update description for media playback telemetry probes. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125695
72587fa85b9f28ef0de6b3b1653a78bd00773e40: Bug 1678373 - Add telemetry probes for audible and muted media. r=alwu data-review=chutten
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:56 +0000 - rev 595469
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Add telemetry probes for audible and muted media. r=alwu data-review=chutten Differential Revision: https://phabricator.services.mozilla.com/D125694
3b28a24f5cee3bb913e72fbdc8a9cbf3c4653940: Bug 1678373 - Add a testcase for MEDIA_PLAY_TIME_MS. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:55 +0000 - rev 595468
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Add a testcase for MEDIA_PLAY_TIME_MS. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125693
b29bb48534fe879b294ff05e396a69108b64bca0: Bug 1678373 - Prepare tests for test-cases without video. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:55 +0000 - rev 595467
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Prepare tests for test-cases without video. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125692
7cfce2fd5760279dadaabba61343c0cadffdfac7: Bug 1678373 - Fix displaying the media element by using display: block. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:54 +0000 - rev 595466
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Fix displaying the media element by using display: block. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125691
94c3443434716b7ae9ea2c65f2206216c4a64104: Bug 1678373 - Put the new and old value in the assert to diagnose failures better. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:54 +0000 - rev 595465
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Put the new and old value in the assert to diagnose failures better. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125690
3a7f9097dea35037c2c553565a6fa7add57d4285: Bug 1678373 - Add tests for muted and audible audio. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:54 +0000 - rev 595464
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Add tests for muted and audible audio. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125689
c844b582583e846efe471c3426ebbc8b69a96334: Bug 1678373 - Add a telemetry probe for understanding how media content with audio content is played back. r=alwu data-review=chutten
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:53 +0000 - rev 595463
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Add a telemetry probe for understanding how media content with audio content is played back. r=alwu data-review=chutten Differential Revision: https://phabricator.services.mozilla.com/D125089
c1601bb10cc726d0af59c0081c0c6c4b4eb84468: Bug 1678373 - Add a way to measure the duration a media was muted. r=alwu,webidl,emilio
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:53 +0000 - rev 595462
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Add a way to measure the duration a media was muted. r=alwu,webidl,emilio Differential Revision: https://phabricator.services.mozilla.com/D125088
cfea10d0a52bb0dfb95ffb1c1f7c9ac885238cac: Bug 1678373 - Fix a typo in the accumulator names. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:52 +0000 - rev 595461
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Fix a typo in the accumulator names. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125087
7876b5a472e959d461fab68ff838223ac41a1d88: Bug 1678373 - Expose audio telemetry counters as chrome-only attributes like their video counterparts. r=alwu,webidl,emilio
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:52 +0000 - rev 595460
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Expose audio telemetry counters as chrome-only attributes like their video counterparts. r=alwu,webidl,emilio Differential Revision: https://phabricator.services.mozilla.com/D125084
614c48a8c245c32189a1dcc228f6fef43b4555e2: Bug 1678373 - Rename chrome-only telemetry counter attributes to distinguish audio and video. r=alwu,webidl,emilio
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:52 +0000 - rev 595459
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Rename chrome-only telemetry counter attributes to distinguish audio and video. r=alwu,webidl,emilio Differential Revision: https://phabricator.services.mozilla.com/D125083
f249b2c8625ce3c497ada9da1ebb75fdad295204: Bug 1678373 - Make the test more robust, and check constant/increasing accumulators a bit more. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:51 +0000 - rev 595458
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Make the test more robust, and check constant/increasing accumulators a bit more. r=alwu This was failing locally sometimes. Resolving a Promise is not very deterministic: it can take some time, or be almost instantaneous. It's simpler to block the main thread for a time duration longer than the clock resolution of the OS. Generally, the worst clock resolution is on Windows, it's by default 16ms, and resolving a Promise is often a lot faster than 16ms, so we could have had the same value here, but the code was correct. The reason that it passed was because of this code. This is currently changing a lot in Windows, but 30ms is a good middle ground I thought. The clock resolution on macOS/Linux desktop/Android/anything else such as BSDs is a lot better than 16ms (in the microsecond/nanosecond range depending on the kernel), so we're good there. Differential Revision: https://phabricator.services.mozilla.com/D125082
9e743b0eae69ded4075b2f8293de2032784b1af4: Bug 1678373 - The test was failing because the video ended early. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:51 +0000 - rev 595457
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - The test was failing because the video ended early. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125081
2dc41092bed46ff5070b7a75ae9aac8fdf899538: Bug 1678373 - Don't detach the media element from the tree for checking play time probes: it pauses the media element per spec. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:50 +0000 - rev 595456
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Don't detach the media element from the tree for checking play time probes: it pauses the media element per spec. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125080
a7d1e3def1ac1016334c37936b11583c6cce2ef9: Bug 1678373 - Add initial accumulator for audio. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:50 +0000 - rev 595455
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Add initial accumulator for audio. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125079
201148a194bed830c2941747d7fdc407cbb69533: Bug 1678373 - Add a way to specify the type of content (audio/video/both) in the TelemetryProbesReporter, change a bit visibility event handling. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:50 +0000 - rev 595454
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Add a way to specify the type of content (audio/video/both) in the TelemetryProbesReporter, change a bit visibility event handling. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125078
59f8a4249e6487dc9804dd7ba5354c75955bbbba: Bug 1678373 - Move the call to report that media telemetry has been reported. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:49 +0000 - rev 595453
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Move the call to report that media telemetry has been reported. r=alwu Needed for report audio telemetry in a later patch. Differential Revision: https://phabricator.services.mozilla.com/D125077
4c58119543adfa98da0fd0c7cf8fef7cf57f30bc: Bug 1678373 - Only call into the telemetry state change code when the state changes. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:49 +0000 - rev 595452
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Only call into the telemetry state change code when the state changes. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125076
c49895e7683f765b05bf7e2da1a7e02015c723aa: Bug 1678373 - Rename mTotalPlayTime and friends to mention it's about video. r=alwu
Paul Adenot <paul@paul.cx> - Tue, 12 Oct 2021 09:03:48 +0000 - rev 595451
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1678373 - Rename mTotalPlayTime and friends to mention it's about video. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125075
1886dbd81c46d93bd5ae3f85135b2137f0b0aad0: Bug 1678373 - Remove mAudibleState. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:59 +0000 - rev 595096
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Remove mAudibleState. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D127559
aeff26b5b1ae76b66feb4d04ac7cdbe6f26c5684: Bug 1678373 - Don't count muted time without an audio track, but start counting time as soon as an audio track is added. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:58 +0000 - rev 595095
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Don't count muted time without an audio track, but start counting time as soon as an audio track is added. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D126912
261d8e4483d493db51077ecc31a1b1f80fcb75e6: Bug 1678373 - Adjust media telemetry attributes. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:58 +0000 - rev 595094
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Adjust media telemetry attributes. r=alwu 2h is a bit short for video. Percentage need to be linear and between 0 and 100. 50 buckets are good enough, having 100 buckets doesn't work, it needs to be lower than the `high` value. Differential Revision: https://phabricator.services.mozilla.com/D125846
89cb5ae23632eb4fdfd472e3b3ecfe422e1d8e54: Bug 1678373 - Count muted time correct when seeking while muted. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:58 +0000 - rev 595093
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Count muted time correct when seeking while muted. r=alwu The counter was paused, but `mIsMuted` was getting desynchronized. It's best to reset the media element muted state, visibility and media content when paused, they are set again properly in ::Play, preventing any issue. It is necessary to reset the media content after reporting telemetry, because a media content of MEDIA_HAS_NOTHING isn't reported. Differential Revision: https://phabricator.services.mozilla.com/D125845
b1eaedd192ab54dfa785061791d8ed4d06175e6f: Bug 1678373 - Update description for media playback telemetry probes. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:57 +0000 - rev 595092
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Update description for media playback telemetry probes. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125695
58a3eb19c8182bdfe8b97a5adb5ccf1bf9a78299: Bug 1678373 - Add telemetry probes for audible and muted media. r=alwu data-review=chutten
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:57 +0000 - rev 595091
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Add telemetry probes for audible and muted media. r=alwu data-review=chutten Differential Revision: https://phabricator.services.mozilla.com/D125694
b027ec789cbecf5e7e7ee3d165ffd5cfcce93ea4: Bug 1678373 - Add a testcase for MEDIA_PLAY_TIME_MS. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:56 +0000 - rev 595090
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Add a testcase for MEDIA_PLAY_TIME_MS. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125693
fd596a84feb96f54ca8fbfad59d54cceb4832e2d: Bug 1678373 - Prepare tests for test-cases without video. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:56 +0000 - rev 595089
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Prepare tests for test-cases without video. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125692
1f0ed0392ae23d7a03983ee5d9af6b509dc03f94: Bug 1678373 - Fix displaying the media element by using display: block. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:56 +0000 - rev 595088
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Fix displaying the media element by using display: block. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125691
ac2be1df81af2eed2a39d1971963d888123811ea: Bug 1678373 - Put the new and old value in the assert to diagnose failures better. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:55 +0000 - rev 595087
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Put the new and old value in the assert to diagnose failures better. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125690
bf6d47905d78ffa711edbdb73c41a6339a5971ac: Bug 1678373 - Add tests for muted and audible audio. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:55 +0000 - rev 595086
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Add tests for muted and audible audio. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125689
a9fe4f3109620c4e2d49b8d666654639ce819d46: Bug 1678373 - Add a telemetry probe for understanding how media content with audio content is played back. r=alwu data-review=chutten
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:54 +0000 - rev 595085
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Add a telemetry probe for understanding how media content with audio content is played back. r=alwu data-review=chutten Differential Revision: https://phabricator.services.mozilla.com/D125089
a153160589687bdf30b4ca4b07cba10428847dbf: Bug 1678373 - Add a way to measure the duration a media was muted. r=alwu,webidl,emilio
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:54 +0000 - rev 595084
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Add a way to measure the duration a media was muted. r=alwu,webidl,emilio Differential Revision: https://phabricator.services.mozilla.com/D125088
217cdfd461202a0a366a42369c6d63624204a9bf: Bug 1678373 - Fix a typo in the accumulator names. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:54 +0000 - rev 595083
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Fix a typo in the accumulator names. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125087
c33c8411129b3ebc2240eed9fdfce55ef71b4b65: Bug 1678373 - Expose audio telemetry counters as chrome-only attributes like their video counterparts. r=alwu,webidl,emilio
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:53 +0000 - rev 595082
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Expose audio telemetry counters as chrome-only attributes like their video counterparts. r=alwu,webidl,emilio Differential Revision: https://phabricator.services.mozilla.com/D125084
3b854fc36abf0c9b85ab8214d5dce2292c820693: Bug 1678373 - Rename chrome-only telemetry counter attributes to distinguish audio and video. r=alwu,webidl,emilio
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:53 +0000 - rev 595081
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Rename chrome-only telemetry counter attributes to distinguish audio and video. r=alwu,webidl,emilio Differential Revision: https://phabricator.services.mozilla.com/D125083
e47c82bcb49a72a4f0e98f0bdb37dda1e4d34f2b: Bug 1678373 - Make the test more robust, and check constant/increasing accumulators a bit more. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:53 +0000 - rev 595080
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Make the test more robust, and check constant/increasing accumulators a bit more. r=alwu This was failing locally sometimes. Resolving a Promise is not very deterministic: it can take some time, or be almost instantaneous. It's simpler to block the main thread for a time duration longer than the clock resolution of the OS. Generally, the worst clock resolution is on Windows, it's by default 16ms, and resolving a Promise is often a lot faster than 16ms, so we could have had the same value here, but the code was correct. The reason that it passed was because of this code. This is currently changing a lot in Windows, but 30ms is a good middle ground I thought. The clock resolution on macOS/Linux desktop/Android/anything else such as BSDs is a lot better than 16ms (in the microsecond/nanosecond range depending on the kernel), so we're good there. Differential Revision: https://phabricator.services.mozilla.com/D125082
2a77cbba1c9fa094cdd11518295805790a02ac19: Bug 1678373 - The test was failing because the video ended early. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:52 +0000 - rev 595079
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - The test was failing because the video ended early. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125081
65206afede36e30ba9f95b485e98afaba982902b: Bug 1678373 - Don't detach the media element from the tree for checking play time probes: it pauses the media element per spec. r=alwu
Paul Adenot <paul@paul.cx> - Thu, 07 Oct 2021 15:44:52 +0000 - rev 595078
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1678373 - Don't detach the media element from the tree for checking play time probes: it pauses the media element per spec. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D125080