searching for reviewer(ahal)
a62ade4ecb3c739e1cd830a7c63268f39febbce5: Bug 1731024: Associate `./mach ide` with build venv r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 16 Sep 2021 18:00:47 +0000 - rev 592204
Push 38794 by ccozmuta@mozilla.com at Thu, 16 Sep 2021 21:45:06 +0000
Bug 1731024: Associate `./mach ide` with build venv r=ahal The command is doing build-related work, so it should use the `build` virtualenv. The exception in the bug will no longer be encountered because the virtualenv is created when `configure` runs. Differential Revision: https://phabricator.services.mozilla.com/D125844
3ad99bae35e262bc1338d4ba5274225acce1374f: Bug 1730619: Associate build commands with "build" venv r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 16 Sep 2021 14:15:04 +0000 - rev 592164
Push 38794 by ccozmuta@mozilla.com at Thu, 16 Sep 2021 21:45:06 +0000
Bug 1730619: Associate build commands with "build" venv r=ahal The `build-backend` command uses `command_context.virtualenv_manager`, which by default is associated with the "common" virtualenv. This patch aligns `virtualenv_manager` with the "build" virtualenv as set up within `init.configure`. Differential Revision: https://phabricator.services.mozilla.com/D125592
6fe52af7f4af406b38500f234bf88bd1fc504f82: Bug 1730407 - Update dependency Sphinx to v4.2.0 r=firefox-source-docs-reviewers,ahal DONTBUILD
Sylvestre Ledru <sylvestre@mozilla.com> - Tue, 14 Sep 2021 06:57:30 +0000 - rev 591853
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
Bug 1730407 - Update dependency Sphinx to v4.2.0 r=firefox-source-docs-reviewers,ahal DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D125339
54ef706bf9caf0f52345f4eac1637d99a8b8896c: Bug 1726814: Rebuild virtualenv if it is incomplete r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Mon, 13 Sep 2021 15:42:55 +0000 - rev 591762
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
Bug 1726814: Rebuild virtualenv if it is incomplete r=ahal Write "metadata" at the end of virtualenv-construction so that we detect incompletely-built venvs. Differential Revision: https://phabricator.services.mozilla.com/D123243
a6200969a92af23faac75331486f5effcef561ca: Bug 1724274: Simplify VirtualenvManager r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Mon, 13 Sep 2021 15:42:55 +0000 - rev 591761
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
Bug 1724274: Simplify VirtualenvManager r=ahal * Removes the unused `call_setup()` function * Inlines functions that were internally called only once Differential Revision: https://phabricator.services.mozilla.com/D124518
abdc8408e9e6ee5092bbed366a3406954d7d17e5: Bug 1717104: Encode `virtualenv_name` into venv's directory r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Mon, 13 Sep 2021 15:42:54 +0000 - rev 591760
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
Bug 1717104: Encode `virtualenv_name` into venv's directory r=ahal Adds a `MozVirtualenvMetadata` file abstraction that allows us to: * Statically determine if a virtualenv is managed by Mach. * Determine the virtualenv's name. Note: I called this file `moz_virtualenv_metadata.json` instead of `mach_virtualenv_metadata.json` because I didn't want to be ambiguous between "the Mach virtualenv" and "a Mach-managed virtualenv". Differential Revision: https://phabricator.services.mozilla.com/D124517
66d5610bfb64be3cc45ae0180d56b0ee16004099: Bug 1717104: `VirtualenvManager` should not allow mixing pythons r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Mon, 13 Sep 2021 15:42:54 +0000 - rev 591759
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
Bug 1717104: `VirtualenvManager` should not allow mixing pythons r=ahal Tweak the `VirtualenvManager` API to accept a single base "python" executable during initialization, then to consistently use it for up-to-date checking, construction, etc. This constraint allows future simplification for behaviour involving the "base" python. Differential Revision: https://phabricator.services.mozilla.com/D124516
118c4908bfaa2ddf60a0ca79d6f3b2326ba1ebe8: Bug 1723237: Warn if virtualenv req definition is missing r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Mon, 13 Sep 2021 15:42:54 +0000 - rev 591758
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
Bug 1723237: Warn if virtualenv req definition is missing r=ahal When porting commands to have their own virtualenv, it's useful to have helpful warnings when the associated requirements definition file is missing. Differential Revision: https://phabricator.services.mozilla.com/D122893
9ec8241c2e1a008adffe0c5e1fd30b2e47601e78: Bug 1717104: Align virtualenv_name with requirements definition r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Mon, 13 Sep 2021 15:42:53 +0000 - rev 591757
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
Bug 1717104: Align virtualenv_name with requirements definition r=ahal Maps virtualenvs one-to-one with their associated requirements definition. For example: ``` Name: "docs" Virtualenv location: <snip>/_virtualenvs/docs Requirements location: $topsrcdir/build/docs_virtualenv_packages.txt ``` An issue to be resolved in the future is that it's tricky to know that, when you define a new virtualenv, you have to *know* that a requirements definition needs to exist in `build/`. As part of this change, the default virtualenv ("common") was split from the build virtualenv ("build"). This required changes to the python-test virtualenv since python-tests depend on `glean_parser`, but were getting it implicitly from the "build" virtualenv's requirements. This addition to the `python-test` virtualenv is temporary and will be removed when bug 1724273 is resolved. Differential Revision: https://phabricator.services.mozilla.com/D122891
bfd986800e40be497b6cbd3f6f8892c2f3a20c17: Bug 1724274: Don't allow Thunderbird requirements to include PyPI pkgs r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Mon, 13 Sep 2021 15:42:52 +0000 - rev 591756
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
Bug 1724274: Don't allow Thunderbird requirements to include PyPI pkgs r=ahal Thunderbird can't currently define its own Mach commands, which means that it doesn't define its own virtualenvs. However, it does add some tweaks to the `common` virtualenv requirements (for build scripts, I believe). So, we should allow it to continue making those tweaks, but we should remove the capability of specifying PyPI packages. This is needed for lockfile-generation, since lockfiles are created and placed in the Mozilla repo, and we don't want "conditional lockfiles" based on the existence of a "comm" repo. This will not regress existing Thunderbird expectations. Differential Revision: https://phabricator.services.mozilla.com/D124515
6c4c17f436fb0d53e1ffbaa144a5dafe35e788c0: Bug 1724274: Add missing "pypi-optional" docs r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Mon, 13 Sep 2021 15:42:52 +0000 - rev 591755
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
Bug 1724274: Add missing "pypi-optional" docs r=ahal These were missed when `pypi-optional` support was added. Differential Revision: https://phabricator.services.mozilla.com/D124514
cf6f22db3a0fd08a09f2f6e22d4d28c3d83d8b51: No bug: sync taskgraph registry changes from out-of-tree taskgraph (D124492) into gecko taskgraph. r=ahal
Ben Hearsum <bhearsum@mozilla.com> - Mon, 13 Sep 2021 15:33:16 +0000 - rev 591754
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
No bug: sync taskgraph registry changes from out-of-tree taskgraph (D124492) into gecko taskgraph. r=ahal Differential Revision: https://phabricator.services.mozilla.com/D125212
cfbf53c78245c80d6e3b6d75801eb37d79647d02: Bug 1730213 - Explicitly skip tests under browser/ on android; r=ahal
Geoff Brown <gbrown@mozilla.com> - Mon, 13 Sep 2021 15:22:27 +0000 - rev 591750
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
Bug 1730213 - Explicitly skip tests under browser/ on android; r=ahal These tests are excluded from android test runs in moz.build. Including an explicit annotation in each manifest avoids scheduling confusion. browser-chrome and plain-chrome tests in browser/ are of no concern, since those test types are never scheduled on android. Differential Revision: https://phabricator.services.mozilla.com/D125266
bfba5586794c8abc405648679c58f203f3e8cd13: Bug 1729224 - Update dependency sphinxcontrib-mermaid to v0.7.1 r=firefox-source-docs-reviewers,ahal DONTBUILD
Renovate Bot <bot@renovateapp.com> - Sun, 12 Sep 2021 14:54:41 +0000 - rev 591697
Push 38784 by ctuns@mozilla.com at Mon, 13 Sep 2021 09:50:54 +0000
Bug 1729224 - Update dependency sphinxcontrib-mermaid to v0.7.1 r=firefox-source-docs-reviewers,ahal DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D124578
542f73d940425b110b63122f43d1d8fd1c27e0da: no bug - fx doc: update to python-dateutil 2.8.2 r=firefox-source-docs-reviewers,ahal DONTBUILD
Sylvestre Ledru <sledru@mozilla.com> - Sun, 12 Sep 2021 14:54:30 +0000 - rev 591696
Push 38784 by ctuns@mozilla.com at Mon, 13 Sep 2021 09:50:54 +0000
no bug - fx doc: update to python-dateutil 2.8.2 r=firefox-source-docs-reviewers,ahal DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D124573
9dfae3ab2c96c2745915a7e3e738997b03c11bd6: Bug 1729224 - Update dependency Markdown to v3.3.4 r=firefox-source-docs-reviewers,ahal DONTBUILD
Renovate Bot <bot@renovateapp.com> - Sun, 12 Sep 2021 14:54:02 +0000 - rev 591695
Push 38784 by ctuns@mozilla.com at Mon, 13 Sep 2021 09:50:54 +0000
Bug 1729224 - Update dependency Markdown to v3.3.4 r=firefox-source-docs-reviewers,ahal DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D124583
dd841f22c83ede589a1fdc8fc0643ee34d2d0d48: Bug 1725708: `./mach vendor python` should populate from a clean state r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 09 Sep 2021 18:18:52 +0000 - rev 591549
Push 38776 by apavel@mozilla.com at Fri, 10 Sep 2021 03:38:56 +0000
Bug 1725708: `./mach vendor python` should populate from a clean state r=ahal Rather than deleting the expected target directory of each package that's being vendored, clear the whole `third_party/python` directory and re-populate it from scratch. As part of this, there's an "exclusion" list for packages that can't be vendored from PyPI. This has some benefits: * It'll be harder to forget scraps of files and directories and leave them in `third_party/python`. * The exclusion list makes it more clear which packages are managed manually, and the friction it adds to the workflow will guide developers to use "requirements.in" instead. The `test_up_to_date_vendor` test will verify that the vendor directory is always clean. Differential Revision: https://phabricator.services.mozilla.com/D123124
06115f01c86f5dfa6cef0725a89c8f05cbe3c362: Bug 1725708: Move all possible vendored deps to centralized system r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 09 Sep 2021 18:18:51 +0000 - rev 591548
Push 38776 by apavel@mozilla.com at Fri, 10 Sep 2021 03:38:56 +0000
Bug 1725708: Move all possible vendored deps to centralized system r=ahal Note that, as part of adding this packages to the automated vendoring system, some dependencies were automatically added - most notably, dependencies of `taskcluster` that become visible with Python 3.6+. Also, adds `**/.git` to the exclusions because: * `.git` is part of our `.hgignore`, but * `.git` is part of the `aiohttp` `tar.gz` file. Since the file isn't needed for `pip install`-ing `aiohttp`, and since we want `./mach vendor python` to be a no-op when there's no requirement changes, we exclude it. Differential Revision: https://phabricator.services.mozilla.com/D123122
b1c67ffd6bbdfc5f5162d665a245e7deaaa71e1f: Bug 1724465: Upgrade `virtualenv` to 20.7.2 r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 09 Sep 2021 18:18:46 +0000 - rev 591547
Push 38776 by apavel@mozilla.com at Fri, 10 Sep 2021 03:38:56 +0000
Bug 1724465: Upgrade `virtualenv` to 20.7.2 r=ahal Note that this patch makes modifications to the vendored `virtualenv` package by removing the modern `setuptools` packages, replacing them with `51.2.0`. This is because `51.3.0` somehow causes xpcshell failures with the following Python bug: https://bugs.python.org/issue37380 This upgrades: * `pip` 20.3.1 => 21.2.3 * `setuptools` 51.0.0 => 51.2.0 * `wheel` 0.36.1 => 0.37.0 Differential Revision: https://phabricator.services.mozilla.com/D123120
746509f3a640f67ba852918b2589f0bf70f96f95: Bug 1725708: Remove unused "pep487" vendored package r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 09 Sep 2021 18:18:45 +0000 - rev 591546
Push 38776 by apavel@mozilla.com at Fri, 10 Sep 2021 03:38:56 +0000
Bug 1725708: Remove unused "pep487" vendored package r=ahal There's no usages of the `pep487` module. Differential Revision: https://phabricator.services.mozilla.com/D123121
089c1a0d9ec82ea66998a3485e31fcd1997066a7: Bug 1712151: Vendor pystache automatically r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 09 Sep 2021 18:18:45 +0000 - rev 591545
Push 38776 by apavel@mozilla.com at Fri, 10 Sep 2021 03:38:56 +0000
Bug 1712151: Vendor pystache automatically r=ahal Add pystache to vendor `requirements.in` so that it's vendored according to `./mach vendor python` "ignore" rules. This ensures that sufficient files are vendored such that installing the package from it's `setup.py` file is possible. Differential Revision: https://phabricator.services.mozilla.com/D122898
c196c1ecdff779997f358be7817d909077bfcd1f: Bug 1712151: Use compatible version of pyasn1-modules r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 09 Sep 2021 18:18:44 +0000 - rev 591544
Push 38776 by apavel@mozilla.com at Fri, 10 Sep 2021 03:38:56 +0000
Bug 1712151: Use compatible version of pyasn1-modules r=ahal The existing version of `pyasn1-modules` (`0.1.5`) is incompatible with our version of `pyasn1` (`0.4.8`). By bumping `pyasn1-modules` to `0.2.8`, we now meet its compatibility requirements. Differential Revision: https://phabricator.services.mozilla.com/D122897
025b07e02501f143dcc175041b30b137d785d767: Bug 1729732: Undefined `make_extra` shouldn't cause build failures r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Wed, 08 Sep 2021 17:30:09 +0000 - rev 591349
Push 38773 by smolnar@mozilla.com at Wed, 08 Sep 2021 21:39:05 +0000
Bug 1729732: Undefined `make_extra` shouldn't cause build failures r=ahal This was an existing bug that was hidden behind this code path only being executed for non-make backends. Differential Revision: https://phabricator.services.mozilla.com/D124937
6d971483a819e2498a74017b57554a19a5df022d: Bug 1728739 - Fix unicode error on when logging browsertime results on windows. r=ahal,perftest-reviewers,kimberlythegeek
Joel Maher <jmaher@mozilla.com> - Tue, 07 Sep 2021 20:48:37 +0000 - rev 591224
Push 38771 by csabou@mozilla.com at Wed, 08 Sep 2021 03:24:17 +0000
Bug 1728739 - Fix unicode error on when logging browsertime results on windows. r=ahal,perftest-reviewers,kimberlythegeek Differential Revision: https://phabricator.services.mozilla.com/D124506
3df9bc9d1f4fda24c080f1837194bb7755feda82: Bug 1723237: Allow empty lines in python requirements files r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 20:46:24 +0000 - rev 590994
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1723237: Allow empty lines in python requirements files r=ahal This allows strategic grouping of dependencies, which can be convenient. Differential Revision: https://phabricator.services.mozilla.com/D122895
f49440e40bfdc549401968587b6fe73c36ec2f94: Bug 1712133: Add missing space to pypi-optional error message r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 20:46:24 +0000 - rev 590993
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1712133: Add missing space to pypi-optional error message r=ahal Differential Revision: https://phabricator.services.mozilla.com/D122894
d42dd3032386e40a31cf8ed23168586f6c11fb54: Bug 1717051: Remove obsolete virtualenv code r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 20:46:23 +0000 - rev 590992
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1717051: Remove obsolete virtualenv code r=ahal The "six"-related comment is no longer relevant, and `here` isn't used. Differential Revision: https://phabricator.services.mozilla.com/D122885
312e5766e25d76f1a64233a8a9b5aa8bf54ab8b4: Bug 1717051: Validate if optional dependencies are out-of-date r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 20:46:22 +0000 - rev 590989
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1717051: Validate if optional dependencies are out-of-date r=ahal Though it's acceptable for an optional dependency to not be installed, it *is* a problem if it's installed to the wrong version. Differential Revision: https://phabricator.services.mozilla.com/D122886
3fd3c2745def8d2197f11b76c07f330c1bcf18b2: Bug 1727802 - skip invalid character in log handling. r=ahal
Joel Maher <jmaher@mozilla.com> - Fri, 03 Sep 2021 19:54:40 +0000 - rev 590981
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1727802 - skip invalid character in log handling. r=ahal Differential Revision: https://phabricator.services.mozilla.com/D123788
90b9ff20b311609163c786cdee830ff9a132d575: Bug 1725708: `./mach vendor python` should populate from a clean state r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 17:31:58 +0000 - rev 590962
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1725708: `./mach vendor python` should populate from a clean state r=ahal Rather than deleting the expected target directory of each package that's being vendored, clear the whole `third_party/python` directory and re-populate it from scratch. As part of this, there's an "exclusion" list for packages that can't be vendored from PyPI. This has some benefits: * It'll be harder to forget scraps of files and directories and leave them in `third_party/python`. * The exclusion list makes it more clear which packages are managed manually, and the friction it adds to the workflow will guide developers to use "requirements.in" instead. The `test_up_to_date_vendor` test will verify that the vendor directory is always clean. Differential Revision: https://phabricator.services.mozilla.com/D123124
75336eb100637306a604008ef29cbab6d63fe3ac: Bug 1725708: Move all possible vendored deps to centralized system r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 17:31:57 +0000 - rev 590961
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1725708: Move all possible vendored deps to centralized system r=ahal Note that, as part of adding this packages to the automated vendoring system, some dependencies were automatically added - most notably, dependencies of `taskcluster` that become visible with Python 3.6+. Also, adds `**/.git` to the exclusions because: * `.git` is part of our `.hgignore`, but * `.git` is part of the `aiohttp` `tar.gz` file. Since the file isn't needed for `pip install`-ing `aiohttp`, and since we want `./mach vendor python` to be a no-op when there's no requirement changes, we exclude it. Differential Revision: https://phabricator.services.mozilla.com/D123122
f438e13f89865876f1b7c1dca9cd4b731c7ae593: Bug 1724465: Upgrade `virtualenv` to 20.7.0 r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 17:31:52 +0000 - rev 590960
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1724465: Upgrade `virtualenv` to 20.7.0 r=ahal This upgrades: * `pip` 20.3.1 => 21.2.2 * `setuptools` 51.0.0 => 57.4.0 * `wheel` 0.36.1 => 0.36.2 Differential Revision: https://phabricator.services.mozilla.com/D123120
11de3a4312bd90374647551033f811174c978910: Bug 1725708: Remove unused "pep487" vendored package r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 17:31:52 +0000 - rev 590959
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1725708: Remove unused "pep487" vendored package r=ahal There's no usages of the `pep487` module. Differential Revision: https://phabricator.services.mozilla.com/D123121
2c6edefd8417eec2c1cdb9fe83ff4ece2f832843: Bug 1712151: Vendor pystache automatically r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 17:31:51 +0000 - rev 590958
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1712151: Vendor pystache automatically r=ahal Add pystache to vendor `requirements.in` so that it's vendored according to `./mach vendor python` "ignore" rules. This ensures that sufficient files are vendored such that installing the package from it's `setup.py` file is possible. Differential Revision: https://phabricator.services.mozilla.com/D122898
9ccf99dae3c7bdd541c3c0907c03e4226819c3d7: Bug 1712151: Use compatible version of pyasn1-modules r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 17:31:50 +0000 - rev 590957
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1712151: Use compatible version of pyasn1-modules r=ahal The existing version of `pyasn1-modules` (`0.1.5`) is incompatible with our version of `pyasn1` (`0.4.8`). By bumping `pyasn1-modules` to `0.2.8`, we now meet its compatibility requirements. Differential Revision: https://phabricator.services.mozilla.com/D122897
792f5edc953436bc2c430cdf9bbdeff7e58d6865: Bug 1723237: Remove `vendor` argument from `install_pip_package()` r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 17:06:05 +0000 - rev 590950
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1723237: Remove `vendor` argument from `install_pip_package()` r=ahal Now that `piptools` is no longer installed from the vendored location, there are no remaining cases where we are doing `install_pip_package()` with a vendored package. Differential Revision: https://phabricator.services.mozilla.com/D123241
bcd2acfba0e75ca60a3ff770fd53a77225b830bb: Bug 1723237: Use pip-compile directly from vendored location r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 17:06:05 +0000 - rev 590949
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1723237: Use pip-compile directly from vendored location r=ahal We've been installing `piptools` so that we can use the `pip-compile` binary. However, we can just as easily do `python -m piptools compile ...` instead, which also allows us to skip a redundant install. Differential Revision: https://phabricator.services.mozilla.com/D123240
3f85c601e434331a3b06eac39c216bfadc39cf7f: Bug 1712151: Bump glean-sdk version to 40.0.0 r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 03 Sep 2021 15:22:21 +0000 - rev 590935
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1712151: Bump glean-sdk version to 40.0.0 r=ahal We vendor `glean_parser==3.6.0`, and that was incompatible with `glean-sdk==36.0.0`'s requirement of `glean_parser==2.5.0`. `glean-sdk==40.0.0` expects `glean_parser==3.6.0`, which is perfect. Differential Revision: https://phabricator.services.mozilla.com/D122899
c1aa00bd2722c66f3986c6cbcbfc955645d10383: Bug 1660870 - ignore non-wpt test paths in wpt. r=releng-reviewers,ahal
Aki Sasaki <asasaki@mozilla.com> - Thu, 02 Sep 2021 20:55:01 +0000 - rev 590860
Push 38757 by malexandru@mozilla.com at Fri, 03 Sep 2021 03:51:58 +0000
Bug 1660870 - ignore non-wpt test paths in wpt. r=releng-reviewers,ahal Differential Revision: https://phabricator.services.mozilla.com/D124129
69bd8bc9c5111eb06e38baf16f78bd06e2206e53: Bug 1660870 - ignore non-wpt test paths in wpt. r=releng-reviewers,ahal
Aki Sasaki <asasaki@mozilla.com> - Thu, 02 Sep 2021 18:54:30 +0000 - rev 590853
Push 38757 by malexandru@mozilla.com at Fri, 03 Sep 2021 03:51:58 +0000
Bug 1660870 - ignore non-wpt test paths in wpt. r=releng-reviewers,ahal Differential Revision: https://phabricator.services.mozilla.com/D124129
2000fe6ec3bcb8b7f01129af05a884e1a414daae: Bug 1660870 - ignore non-wpt test paths in wpt. r=releng-reviewers,ahal DONTBUILD
Aki Sasaki <asasaki@mozilla.com> - Thu, 02 Sep 2021 16:03:00 +0000 - rev 590834
Push 38757 by malexandru@mozilla.com at Fri, 03 Sep 2021 03:51:58 +0000
Bug 1660870 - ignore non-wpt test paths in wpt. r=releng-reviewers,ahal DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D124129
5d72777ab5abcd1a00443789f4070ba98b6db246: Bug 1717051: Spell `glean-sdk` with a dash, not an underscore r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Fri, 13 Aug 2021 17:50:13 +0000 - rev 588849
Push 38704 by nerli@mozilla.com at Fri, 13 Aug 2021 21:52:47 +0000
Bug 1717051: Spell `glean-sdk` with a dash, not an underscore r=ahal The Glean SDK was traditionally represented in-tree as `glean_sdk`. However, on PyPI and in `pip list`, it appears as `glean-sdk` (`pip` was doing the translation implicitly and internally). This is breaking our virtualenv state-checking code, since it thinks that `glean_sdk` isn't installed. Since `glean_sdk` was marked as `pypi-optional`, this hasn't affected us yet, but it will when we bump the Glean SDK version, because developers' virtualenvs won't be detected as out-of-date. Differential Revision: https://phabricator.services.mozilla.com/D122500
808e0f497f366ff4e77976210b4296d2fe04300c: Bug 1724766: Resolve Python 2->3 issue with Windows and Mochitest r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Wed, 11 Aug 2021 14:12:05 +0000 - rev 588567
Push 38696 by malexandru@mozilla.com at Wed, 11 Aug 2021 21:37:39 +0000
Bug 1724766: Resolve Python 2->3 issue with Windows and Mochitest r=ahal Environment variables should use their local `str` type. The existing code was ensuring env vars were `bytes`, which is only correct with Python 2. I could've opted to simplify this and ensure environment variables were always `text`, but I'm not confident that this code doesn't ever run with Python 2 just yet. It is the `BaseRunner` after all. Differential Revision: https://phabricator.services.mozilla.com/D122303
cb770866fd3daf9854ac08dbc04d66e5a35499cb: Bug 1717051: Move global mach dependencies to requirements definition r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 05 Aug 2021 15:14:20 +0000 - rev 587928
Push 38677 by imoraru@mozilla.com at Fri, 06 Aug 2021 03:36:13 +0000
Bug 1717051: Move global mach dependencies to requirements definition r=ahal After removing `optional` in Bug 1712804, we need to add a variant back here because there's fallible dependencies. However, I've tweaked the re-introduction of the feature to require a specific repercussion message as well. This seemed like a decent tradeoff - the developer becomes aware that the failure is bad, it has repercussions, but it's not a blocking issue. Additionally, since we're printing pip's output, the developer will be able to see the underlying error causing the warning. I also added comment functionality to requirements definitions to allow adjacent documentation of why some requirements are fallible. (Related: I'm looking forward to `mach_bootstrap` not needing to parse requirements definitions. Almost there!) Note that we'll temporarily lose the "pinned" nature of the three moved dependencies until dependency locking is implemented for Mach requirements definitions. Also note that the pinned `zstandard_requirements.txt` can't be removed like the other files because it still has a dangling usage. Finally, in preparation for review: I didn't make `PypiOptionalSpecifier` extend `PypiSpecifier` because I figured that the benefit of flexibility (easier to allow implementations to diverge without needing to untangle an inheritance relationship) was larger than the cost of needing to add properties to both specifiers. If we wanted re-use, I'd probably have `PypiOptionalSpecifier` _contain_ a `PypiSpecifier`, but then you have to reach deeper into the object to get data, so *shrug*. Differential Revision: https://phabricator.services.mozilla.com/D119835
1a328c15cdc0eedad8f8e1e13cc6076af2deb80b: Bug 1717051: Only use stdlib for installing pip packages r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 05 Aug 2021 15:14:19 +0000 - rev 587927
Push 38677 by imoraru@mozilla.com at Fri, 06 Aug 2021 03:36:13 +0000
Bug 1717051: Only use stdlib for installing pip packages r=ahal `_install_pip_package()` may be run from `populate()`, which is invoked from a child Python process that doesn't have in-tree Python modules in its sys.path. An alternate solution would be to add in-tree modules to the sys.path, but that seemed more costly than simply using `tempfile` and `shutil`. Differential Revision: https://phabricator.services.mozilla.com/D119834
ae118a8af44446ccfb68b55c81e012f73abd8420: Bug 1717051: Remove obsolete python module paths r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 05 Aug 2021 15:14:19 +0000 - rev 587926
Push 38677 by imoraru@mozilla.com at Fri, 06 Aug 2021 03:36:13 +0000
Bug 1717051: Remove obsolete python module paths r=ahal The three removed paths don't exist in-repo, and after a cursory glance they don't appear to be populated dynamically. Note that the removal of the `six` path for WPT is different: it's technically just incorrect, and should amended to point to `$WPT/tools/third_party/six`. However, Python only allows a single instance of a library to exist in import scope, and we're already consuming `six` from the Firefox-wide vendored 3rd-party libs. Differential Revision: https://phabricator.services.mozilla.com/D119825
3a844a148590581c9b75c5bae8c8829fea24fc7d: Bug 1717645: Fix up_to_date for Python 3.6 r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 05 Aug 2021 15:14:18 +0000 - rev 587924
Push 38677 by imoraru@mozilla.com at Fri, 06 Aug 2021 03:36:13 +0000
Bug 1717645: Fix up_to_date for Python 3.6 r=ahal Python 3.6 doesn't support the `capture_output` option, so use `stdout=subprocess.PIPE` instead. Differential Revision: https://phabricator.services.mozilla.com/D120027
719348d541d8d45ad507232aafdc32c4b64b0362: Bug 1717645: Check virtualenv pths are up-to-date r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 05 Aug 2021 15:14:17 +0000 - rev 587923
Push 38677 by imoraru@mozilla.com at Fri, 06 Aug 2021 03:36:13 +0000
Bug 1717645: Check virtualenv pths are up-to-date r=ahal It's possible for a virtualenv to have an incorrect list of directories to add to the sys.path, such as the following cases: * Its creation got cancelled halfway through * The list of pths changed in a new revision * It got modified by an external tool By validating the list of provided pths against the list of required pths, we can ensure that the virtualenv is more dependably up-to-date. Differential Revision: https://phabricator.services.mozilla.com/D119686
13d016bcc12c88f99dbd2a974a6011dbe94d09cc: Bug 1717645: Resolve nested virtualenv requirements up-front r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Thu, 05 Aug 2021 15:14:17 +0000 - rev 587922
Push 38677 by imoraru@mozilla.com at Fri, 06 Aug 2021 03:36:13 +0000
Bug 1717645: Resolve nested virtualenv requirements up-front r=ahal This simplifies consumer logic, since they get the parsed list of pypi and pth requirements, as well as the list of input files that were parsed. One benefit of this simplification is that we no longer recursively create VirtualenvManagers. Note that mach_bootstrap cannot (yet) take advantage of `ParseMachEnvRequirements` because of a dependency cycle: * `mach_bootstrap` must set up the `sys.path` to import `ParseMachEnvRequirements`. * `mach_bootstrap` would want `ParseMachEnvRequirements` to determine which paths to add to the `sys.path`. Differential Revision: https://phabricator.services.mozilla.com/D119685
7061a6b8d768b68c358924d55413e4e6f02f89e6: Bug 1715643 - Run fxrecord task on all m-c pushes r=ahal
Barret Rennie <barret@brennie.ca> - Fri, 30 Jul 2021 17:28:58 +0000 - rev 587257
Push 38659 by smolnar@mozilla.com at Fri, 30 Jul 2021 21:56:33 +0000
Bug 1715643 - Run fxrecord task on all m-c pushes r=ahal Differential Revision: https://phabricator.services.mozilla.com/D117368