searching for reviewer(NeilDeakin)
dcbd261bc72b516b97cc9141c89dab9daf4df16d: Bug 1743058 - Set the default notification message telemetry scalar to null. r=NeilDeakin
Geoff Lankow <geoff@darktrojan.net> - Fri, 26 Nov 2021 02:54:09 +0000 - rev 600198
Push 39013 by abutkovits@mozilla.com at Fri, 26 Nov 2021 16:04:49 +0000
Bug 1743058 - Set the default notification message telemetry scalar to null. r=NeilDeakin If the .telemetry property is truthy, which it currently is by default, the message tries to add to telemetry scalars, even though the value makes no sense. Differential Revision: https://phabricator.services.mozilla.com/D132207
a2c91530a996e7ac1745777e236dca815be70465: Bug 1738265 - Teach some popup tests to deal with popups having margins by default. r=NeilDeakin
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 Oct 2021 19:26:37 +0000 - rev 597476
Push 38926 by malexandru@mozilla.com at Sat, 30 Oct 2021 09:22:34 +0000
Bug 1738265 - Teach some popup tests to deal with popups having margins by default. r=NeilDeakin For tests that actually test margin handling I've just removed the default margin by adding: <?xml-stylesheet href="data:text/css,menupopup{margin: 0}" type="text/css"?> The other tests I've just fixed by accounting for the margins. Differential Revision: https://phabricator.services.mozilla.com/D129866
102ff2b893eae983fa501339255c68c3bcfeebff: Bug 1738265 - Improve some popup tests. r=NeilDeakin
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 Oct 2021 19:26:37 +0000 - rev 597475
Push 38926 by malexandru@mozilla.com at Sat, 30 Oct 2021 09:22:34 +0000
Bug 1738265 - Improve some popup tests. r=NeilDeakin This doesn't change behavior but I did it while debugging and I think it's probably worth landing, as it shows the expected values rather than just the fail message. Differential Revision: https://phabricator.services.mozilla.com/D129865
3738556dd3402fa124af3b12825f2b2b2a828c4f: Bug 1736536 - make the 'show me how' button in the session store notification bar use the primary color, r=NeilDeakin
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 20 Oct 2021 23:25:53 +0000 - rev 596518
Push 38900 by nfay@mozilla.com at Thu, 21 Oct 2021 09:36:31 +0000
Bug 1736536 - make the 'show me how' button in the session store notification bar use the primary color, r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D129093
8979a86f150db8a87f0a3596478eea2e6dedf47e: Bug 1729911 - Define minInactiveDurationInMS not to unload fresh tabs. r=NeilDeakin
Toshihito Kikuchi <tkikuchi@mozilla.com> - Wed, 20 Oct 2021 23:22:57 +0000 - rev 596517
Push 38900 by nfay@mozilla.com at Thu, 21 Oct 2021 09:36:31 +0000
Bug 1729911 - Define minInactiveDurationInMS not to unload fresh tabs. r=NeilDeakin Tab unloading should not unload "fresh" tabs i.e. tabs that were accessed very recently, even though one of them was the least recently used tab. To achieve it, this patch introduces the minimum inactive duration and we prevent tabs that were accessed in the last period of that duration from being unloaded. This patch sets the default value to 10 minutes based on the historgram `TAB_UNLOAD_TO_RELOAD` where the median was 60sec and the 75th percentile was 1040sec. This value can be overriden by the parameter of the TabUnloader's APIs so that about:unloads and the tests can unload those fresh tabs. Differential Revision: https://phabricator.services.mozilla.com/D125824
6b14118c372d4b357e775c68ded1c6a8b905ee86: Bug 1735414 - Protocol handlers should be set to always ask before handling. r=mhowell,NeilDeakin
Micah Tigley <mtigley@mozilla.com> - Thu, 14 Oct 2021 17:05:18 +0000 - rev 595916
Push 38880 by nerli@mozilla.com at Fri, 15 Oct 2021 09:50:04 +0000
Bug 1735414 - Protocol handlers should be set to always ask before handling. r=mhowell,NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D128495
c63ee153751f243193d3dee1d119ca7382593495: Bug 1730750 - Exit fullscreen when the inner window is no longer active; r=NeilDeakin
Edgar Chen <echen@mozilla.com> - Fri, 08 Oct 2021 13:03:09 +0000 - rev 595210
Push 38862 by ctuns@mozilla.com at Fri, 08 Oct 2021 21:42:24 +0000
Bug 1730750 - Exit fullscreen when the inner window is no longer active; r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D127528
238bfe328eebda52f6629cde62f2d7644855bec1: Bug 1734516 - Exit if popup frame is destroyed while showing it r=NeilDeakin
Doug Thayer <dothayer@mozilla.com> - Thu, 07 Oct 2021 18:07:51 +0000 - rev 595121
Push 38857 by nerli@mozilla.com at Thu, 07 Oct 2021 21:51:52 +0000
Bug 1734516 - Exit if popup frame is destroyed while showing it r=NeilDeakin I'm not sure this is the appropriate fix for this, honestly. This hits a crash in some urlbar work on a different branch, and this change avoids that. If we don't do this, then we end up with a popup in mPopups which never actually opened, which seems to create problems. Alternatively, we could try to fix the frame's state so that it can be opened? I don't know if that's sane or not. It presently doesn't open because of the check on mPopupState inside nsMenuPopupFrame::ShowPopup. I don't know if there's more state than that to get it to appropriately open. Differential Revision: https://phabricator.services.mozilla.com/D127758
c137494e2a6d50b1fe3deeed6dc62c416ffd942d: Bug 1724962 - add focus styling option to UI Tour and use it for the session restore infobar r=NeilDeakin
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Sat, 02 Oct 2021 12:20:08 +0000 - rev 593988
Push 38840 by nerli@mozilla.com at Sat, 02 Oct 2021 21:36:29 +0000
Bug 1724962 - add focus styling option to UI Tour and use it for the session restore infobar r=NeilDeakin Depends on D126730 Differential Revision: https://phabricator.services.mozilla.com/D127197
afe05f311e80001efb773c96b81834fdc15544cb: Bug 1732446 - fix multiple tab warning for quit shortcut usage on Windows, r=NeilDeakin,mhowell
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 28 Sep 2021 10:44:37 +0000 - rev 593415
Push 38828 by abutkovits@mozilla.com at Tue, 28 Sep 2021 21:36:47 +0000
Bug 1732446 - fix multiple tab warning for quit shortcut usage on Windows, r=NeilDeakin,mhowell Differential Revision: https://phabricator.services.mozilla.com/D126677
0ebc4402a7cb4826e0ee4299e354dcbedb418baf: Bug 1731665 - tests, r=NeilDeakin
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 27 Sep 2021 14:00:16 +0000 - rev 593287
Push 38827 by ctuns@mozilla.com at Tue, 28 Sep 2021 09:54:33 +0000
Bug 1731665 - tests, r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D124269
ccb6051234799b83d138e2b5b679381152460327: Bug 1726621 - ensure form validation popup always hides on tabswitches, navigations, etc., r=NeilDeakin
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 22 Sep 2021 10:12:24 +0000 - rev 592917
Push 38814 by ctuns@mozilla.com at Wed, 22 Sep 2021 15:53:06 +0000
Bug 1726621 - ensure form validation popup always hides on tabswitches, navigations, etc., r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D124268
724917f8288f0f3ed6d752886f5f806b10750d5b: Bug 1726621 - ensure form validation popup always hides on tabswitches, navigations, etc., r=NeilDeakin
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 20 Sep 2021 19:46:23 +0000 - rev 592528
Push 38808 by csabou@mozilla.com at Tue, 21 Sep 2021 09:46:42 +0000
Bug 1726621 - ensure form validation popup always hides on tabswitches, navigations, etc., r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D124268
b21557eeb0e557a61e187ade957377349916d8f3: Bug 1727829 - Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 08 Sep 2021 21:29:53 +0000 - rev 591375
Push 38774 by nbeleuzu@mozilla.com at Thu, 09 Sep 2021 15:22:41 +0000
Bug 1727829 - Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D123827
4e62d5d8f501c61fae78a8499a6d9b8391e521bb: Bug 1725257 - Part 3. Implement about:unloads. r=NeilDeakin,fluent-reviewers,flod
Toshihito Kikuchi <tkikuchi@mozilla.com> - Tue, 07 Sep 2021 00:46:59 +0000 - rev 591153
Push 38768 by ctuns@mozilla.com at Tue, 07 Sep 2021 09:48:49 +0000
Bug 1725257 - Part 3. Implement about:unloads. r=NeilDeakin,fluent-reviewers,flod The page contains - a table to show the tabs and their attributes that `TabUnloader` considers - a button to trigger `TabUnloader.unloadLeastRecentlyUsedTab()` to visualize the behavior of `TabUnloader` and manually trigger it. Differential Revision: https://phabricator.services.mozilla.com/D123988
061cbd7639c4b9d0e6cba01b3f54a06f7f6303bf: Bug 1725257 - Part 2. Add a blank about:unloads. r=NeilDeakin,flod
Toshihito Kikuchi <tkikuchi@mozilla.com> - Tue, 07 Sep 2021 00:46:59 +0000 - rev 591152
Push 38768 by ctuns@mozilla.com at Tue, 07 Sep 2021 09:48:49 +0000
Bug 1725257 - Part 2. Add a blank about:unloads. r=NeilDeakin,flod Differential Revision: https://phabricator.services.mozilla.com/D123987
98586fa85ecff2c433a1f6007d9bd77ab2e72636: Bug 1725257 - Part 1. Optimize TabUnloader for about:discards. r=NeilDeakin
Toshihito Kikuchi <tkikuchi@mozilla.com> - Tue, 07 Sep 2021 00:46:59 +0000 - rev 591151
Push 38768 by ctuns@mozilla.com at Tue, 07 Sep 2021 09:48:49 +0000
Bug 1725257 - Part 1. Optimize TabUnloader for about:discards. r=NeilDeakin The patch includes the following updates: - getAllProcesses() adds a per-tab map to hold the processes backed by the process to a tab so that we don't need to iterateprocesses twice. - Consider a process that hosts multiple frames in a single tab as a unique process because such processes are terminated when that single tab is unloaded. - Add `TabUnloader.isDiscardable()` Differential Revision: https://phabricator.services.mozilla.com/D123986
91cd14a397227ba7a5c21b53aded123d09928d4e: Bug 1727829 - Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 31 Aug 2021 18:09:59 +0000 - rev 590350
Push 38752 by malexandru@mozilla.com at Wed, 01 Sep 2021 03:48:05 +0000
Bug 1727829 - Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D123827
4195038b8549a4f7d3c59df6c1c4b717792c39f1: Bug 1727829 - Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin
Olli Pettay <Olli.Pettay@helsinki.fi> - Sun, 29 Aug 2021 21:55:50 +0000 - rev 590166
Push 38747 by nbeleuzu@mozilla.com at Mon, 30 Aug 2021 16:27:01 +0000
Bug 1727829 - Consider to not initialize AboutReaderChild actor for initial about:blank documents when pagehide fires, r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D123827
ccf38b42b39b8ef1e1d4d9b5d019d5936807d793: Bug 1721454 - Insert bookmarks before bottom Manage Bookmarks in Bookmarks Menu button. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Wed, 04 Aug 2021 18:53:45 +0000 - rev 587814
Push 38674 by smolnar@mozilla.com at Thu, 05 Aug 2021 04:08:01 +0000
Bug 1721454 - Insert bookmarks before bottom Manage Bookmarks in Bookmarks Menu button. r=NeilDeakin The CSS class panel-subview-footer-button was removed from the BMB_bookmarksShowAll element in the Bookmarks Menu toolbar button, but this class is used by browser-places.js to know where to insert the user's bookmarks in the structure of the menu. Since this is the only menu that attachPlacesView attaches to, we can supply the ID of the bottom Manage Bookmarks element, which will cause browserPlacesView.js to insert the user's bookmarks above it. Differential Revision: https://phabricator.services.mozilla.com/D121759
e44a25753c4e42d467e38c06ed46d1c60c143fc2: Bug 1715858 - Part2. Add telemetry scalars to count the tab unload and reload events. r=NeilDeakin
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 22 Jul 2021 21:15:00 +0000 - rev 586482
Push 38636 by cbrindusan@mozilla.com at Fri, 23 Jul 2021 03:42:39 +0000
Bug 1715858 - Part2. Add telemetry scalars to count the tab unload and reload events. r=NeilDeakin This patch adds two scalars: * `browser.engagement.tab_unload_count`: Incremented by 1 when TabUnloader successfully unloaded a tab. * `browser.engagement.tab_reload_count`: Incremented by 1 when an unloaded tab was reloaded. The value of `browser.engagement.tab_reload_count` will be the same as the count of the histogram `TAB_UNLOAD_TO_RELOAD` data, but we still need this scalar to compare it to `browser.engagement.tab_unload_count`, which tells us the ratio of reload-after-unload tabs to all unloaded tabs. Depends on D120019 Differential Revision: https://phabricator.services.mozilla.com/D120020
6a6b0113e4b09a0fbeb1f5a7f8fc47fed183e616: Bug 1715858 - Part1. Add a new telemetry histogram TAB_UNLOAD_TO_RELOAD. r=NeilDeakin
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 22 Jul 2021 21:15:00 +0000 - rev 586481
Push 38636 by cbrindusan@mozilla.com at Fri, 23 Jul 2021 03:42:39 +0000
Bug 1715858 - Part1. Add a new telemetry histogram TAB_UNLOAD_TO_RELOAD. r=NeilDeakin The new histogram `TAB_UNLOAD_TO_RELOAD` records how long a tab had been unloaded until it was reload by a user. With this data, we can evaluate the selection logic to choose a tab to unload. For example, if many of unloaded tabs are reloaded within 30 seconds or so, we unload a wrong tab. Differential Revision: https://phabricator.services.mozilla.com/D120019
22f3a68b356ba5ef7e918bf59cdcd05557214f04: Bug 1716409 - Enable test_reftests_with_caret.html on fis-xorig runs. r=NeilDeakin
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 25 Jun 2021 00:48:25 +0000 - rev 584335
Push 38563 by cbrindusan@mozilla.com at Fri, 25 Jun 2021 09:34:36 +0000
Bug 1716409 - Enable test_reftests_with_caret.html on fis-xorig runs. r=NeilDeakin It should have been working on fis-xorig runs since bug 1714594. Note that the try run used for filing bug 1716409 was pushed on June 7th, whereas bug 1714594 landed on June 11th. Differential Revision: https://phabricator.services.mozilla.com/D118767
4562a5404ff30a30e29ab72c9036329030c330ca: Bug 1713624 - Null out mFocusedWindow when receiving OOP focused BrowsingContext. r=NeilDeakin
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 09 Jun 2021 15:08:36 +0000 - rev 582469
Push 38527 by ncsoregi@mozilla.com at Thu, 10 Jun 2021 03:46:06 +0000
Bug 1713624 - Null out mFocusedWindow when receiving OOP focused BrowsingContext. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D117156
8e65f5fd433b5512eac073636510bc2d15abd064: Bug 1681983 - Adjust a comment in nsFocusManager for Fission. r=NeilDeakin DONTBUILD
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 09 Jun 2021 14:45:05 +0000 - rev 582464
Push 38527 by ncsoregi@mozilla.com at Thu, 10 Jun 2021 03:46:06 +0000
Bug 1681983 - Adjust a comment in nsFocusManager for Fission. r=NeilDeakin DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D116215
5d7dec65acedaad1e4c4adff061536ca85403231: Bug 1681983 - Make SetFocusedWindowWithCallerType not call ClearFocus. r=NeilDeakin
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 07 Jun 2021 17:42:21 +0000 - rev 582112
Push 38521 by cbrindusan@mozilla.com at Tue, 08 Jun 2021 04:08:33 +0000
Bug 1681983 - Make SetFocusedWindowWithCallerType not call ClearFocus. r=NeilDeakin No test, because the expectation is that this code is not actually exercised anyway. Differential Revision: https://phabricator.services.mozilla.com/D116215
a385ad897612d34ff944c31cbd76db97050d868b: Bug 1681983 - Make SetFocusedWindowWithCallerType speculatively more Fission-aware. r=NeilDeakin
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 03 Jun 2021 13:40:09 +0000 - rev 581831
Push 38513 by abutkovits@mozilla.com at Fri, 04 Jun 2021 10:21:11 +0000
Bug 1681983 - Make SetFocusedWindowWithCallerType speculatively more Fission-aware. r=NeilDeakin No test, because the expectation is that this code is not actually exercised anyway. Differential Revision: https://phabricator.services.mozilla.com/D116215
a24798b1a45abc4d8fa45ea41da6d5e3897feeea: Bug 1707789 - Make browser_bug1163304.js retry to open the popup of search bar if failed r=NeilDeakin
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 26 May 2021 22:31:49 +0000 - rev 580810
Push 38495 by archaeopteryx@coole-files.de at Thu, 27 May 2021 09:27:58 +0000
Bug 1707789 - Make browser_bug1163304.js retry to open the popup of search bar if failed r=NeilDeakin In my investigation, `F4` key in the search bar may not be handled as expected because if it happens, the popup's state stays "closed" and "popupshowing", "popuphiding" nor "popuphidden" event is fired. The scope of the test is checking IME enabled state in searchbar in some situations. Therefore, failing to open the popup with `F4` key is out of scope of the test. So, let's make it retry to open the popup in the case. Differential Revision: https://phabricator.services.mozilla.com/D114571
a906e31c7accf6dcc4471f49d56acdef9ff62d0f: Bug 1491797 - Make browser_bug1163304.js wait for focus event before checking IME state r=NeilDeakin
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 06 May 2021 05:38:34 +0000 - rev 578684
Push 38440 by malexandru@mozilla.com at Thu, 06 May 2021 15:49:21 +0000
Bug 1491797 - Make browser_bug1163304.js wait for focus event before checking IME state r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D113618
5a607f51940fd8013e5f7f25b8859f2c02090a9b: Bug 1709113 - Add null check in DefaultTabUnloaderMethods.iterateProcesses. r=NeilDeakin
Toshihito Kikuchi <tkikuchi@mozilla.com> - Mon, 03 May 2021 15:42:25 +0000 - rev 578317
Push 38430 by cbrindusan@mozilla.com at Mon, 03 May 2021 21:42:10 +0000
Bug 1709113 - Add null check in DefaultTabUnloaderMethods.iterateProcesses. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D114118
fce297568d0215bb4c8b0d10ac9ee002c2a3c0cc: Bug 1708822 - Handle a case where processMap did not have a corresponding entry. r=NeilDeakin
Toshihito Kikuchi <tkikuchi@mozilla.com> - Fri, 30 Apr 2021 21:23:38 +0000 - rev 578242
Push 38423 by cbrindusan@mozilla.com at Sat, 01 May 2021 09:32:51 +0000
Bug 1708822 - Handle a case where processMap did not have a corresponding entry. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D114020
a74febc3cc235bea3baa5c9bfbcb745848622e7e: Bug 1701843: Set menupopup.triggerNode to document.popupNode to show context menu correctly. r=NeilDeakin
Daisuke Akatsuka <daisuke@birchill.co.jp> - Wed, 21 Apr 2021 22:44:04 +0000 - rev 577015
Push 38397 by btara@mozilla.com at Thu, 22 Apr 2021 03:04:50 +0000
Bug 1701843: Set menupopup.triggerNode to document.popupNode to show context menu correctly. r=NeilDeakin The reason why the context menu is not shown is that `getViewForNode(document.popupNode)` returns null if the `document.popupNode` points to a content element, at below place. https://searchfox.org/mozilla-central/rev/a5bf5d0720f9454687f500513ac82b0c8abce5a4/browser/components/places/PlacesUIUtils.jsm#1347-1353 So, we try to take the view from `menupopup.triggerNode` instead of `document.popupNode`. However, replacing with `menupopup.triggerNode` here is not enough to show the context menu correctly since we are refferring document.popupNode while building the context menu. e.g. https://searchfox.org/mozilla-central/rev/a8b75e4ba3f8ddf0e76b42681d0a7b7e78e67730/browser/components/places/content/browserPlacesViews.js#219 Thus, for now, we set `menupopup.triggerNode` to `document.popupNode` to resolve for short term. In future, we may replace places refferring `document.popupNode` with other elements in Places in bug 1706004. Differential Revision: https://phabricator.services.mozilla.com/D112890
c4790a9f73771c3e81a69474c409363e12576d4f: Bug 1704975 - Make test_arrowpanel.xhtml ignore em-unit browser padding styles to avoid rounding issues and re-enable for macOS. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Tue, 20 Apr 2021 21:07:58 +0000 - rev 576838
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1704975 - Make test_arrowpanel.xhtml ignore em-unit browser padding styles to avoid rounding issues and re-enable for macOS. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D112088
206a10c2fae7cb3e5ba5ae8e59ce2e2b7ee0d709: Bug 1702810 - Remove double shadow from the bookmarks menu panel. r=NeilDeakin
Marco Bonardo <mbonardo@mozilla.com> - Thu, 08 Apr 2021 11:30:27 +0000 - rev 575037
Push 38357 by malexandru@mozilla.com at Thu, 08 Apr 2021 21:54:39 +0000
Bug 1702810 - Remove double shadow from the bookmarks menu panel. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D111110
ae0f3f0e993a5fd012a845f06c8a4ce3f48c0164: Bug 1702474 - Search bar panel is missing shadow or border. r=harry,NeilDeakin,desktop-theme-reviewers
Marco Bonardo <mbonardo@mozilla.com> - Wed, 07 Apr 2021 15:15:17 +0000 - rev 574830
Push 38355 by abutkovits@mozilla.com at Wed, 07 Apr 2021 21:25:27 +0000
Bug 1702474 - Search bar panel is missing shadow or border. r=harry,NeilDeakin,desktop-theme-reviewers Differential Revision: https://phabricator.services.mozilla.com/D110704
74f97ab4c1d39a8e72291ba66a85cfc7e740b8e2: Bug 1677334 - Part 2: Remove Mac-specific check for click event on xul frame; r=NeilDeakin
Edgar Chen <echen@mozilla.com> - Wed, 07 Apr 2021 11:23:45 +0000 - rev 574805
Push 38353 by dluca@mozilla.com at Wed, 07 Apr 2021 15:47:02 +0000
Bug 1677334 - Part 2: Remove Mac-specific check for click event on xul frame; r=NeilDeakin Now we won't dispatch click event at all when ctrl key is pressed on Mac, so we don't need those Mac-specific checks. This patch reverts part of https://hg.mozilla.org/mozilla-central/rev/d8726d18021e and revise the tests accordingly. Differential Revision: https://phabricator.services.mozilla.com/D110608
bfe855d4d7b959e3ebdbb80e142965069b2aa7fa: Bug 1696450 - fix pocket-disabling-induced issues with separators in the context menus, r=NeilDeakin
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 04 Mar 2021 21:14:41 +0000 - rev 569725
Push 38265 by csabou@mozilla.com at Fri, 05 Mar 2021 08:56:04 +0000
Bug 1696450 - fix pocket-disabling-induced issues with separators in the context menus, r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D107260
bb160ca0dda6d96090bc43a95e0e452077aeb76f: Bug 1695734 - Remove Learn More link from content script hang infobars r=NeilDeakin
Doug Thayer <dothayer@mozilla.com> - Mon, 01 Mar 2021 21:18:03 +0000 - rev 569138
Push 38256 by btara@mozilla.com at Wed, 03 Mar 2021 04:16:49 +0000
Bug 1695734 - Remove Learn More link from content script hang infobars r=NeilDeakin Depends on D106816 Differential Revision: https://phabricator.services.mozilla.com/D106821
0a3da2090e4859473f52b585bcb39baae2876b28: Bug 1665390 - Style bookmarks toolbar and tabs toolbar tooltips. r=NeilDeakin,ntim
Jared Wein <jwein@mozilla.com> - Thu, 25 Feb 2021 20:47:54 +0000 - rev 568836
Push 38240 by btara@mozilla.com at Fri, 26 Feb 2021 03:55:47 +0000
Bug 1665390 - Style bookmarks toolbar and tabs toolbar tooltips. r=NeilDeakin,ntim Differential Revision: https://phabricator.services.mozilla.com/D104257
ed6dc41378b3917ea4f1576c1231d8aadb291e03: Bug 1689327 - Resizers for non-themed scrollable content shouldn't be themed. r=NeilDeakin
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 20 Feb 2021 00:15:42 +0000 - rev 568152
Push 38221 by cbrindusan@mozilla.com at Sat, 20 Feb 2021 09:33:16 +0000
Bug 1689327 - Resizers for non-themed scrollable content shouldn't be themed. r=NeilDeakin Right now the resizer inside a random <div style="overflow: hidden"> is the themed one, and that seems unintended. I'm not sure how to best test this since resizers are sized to a scrollbar width, so I can't just position an <img src=resizer.svg>. I noticed this while looking at bug 1689253. Differential Revision: https://phabricator.services.mozilla.com/D103304
f4af0087a1b49c221f54143a10b7bebca35db49c: Bug 1683188 - CrossProcessPaint code shouldn't mess with tab state from the content process. r=mattwoodrow,NeilDeakin
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 11 Jan 2021 19:52:10 +0000 - rev 562683
Push 38095 by csabou@mozilla.com at Tue, 12 Jan 2021 04:33:40 +0000
Bug 1683188 - CrossProcessPaint code shouldn't mess with tab state from the content process. r=mattwoodrow,NeilDeakin There's JS running since we save the active status till we restore it, so arbitrary things can happen, including receiving an IPC message from the child saying that we're now really active. If then we restore the wrong (old) status, stuff gets confused and sadness ensues. Screenshotting background tabs seems to work without this so it's not clear to me why messing with the activeness state was necessary to begin with. Differential Revision: https://phabricator.services.mozilla.com/D101060
070b0dc9139d9b493c17b377d08b184491b12793: Bug 1681992 - Add tests for some multiple about:tabcrashed tabs behaviours. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Fri, 08 Jan 2021 22:53:20 +0000 - rev 562535
Push 38090 by btara@mozilla.com at Sat, 09 Jan 2021 09:24:57 +0000
Bug 1681992 - Add tests for some multiple about:tabcrashed tabs behaviours. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D99490
68f4e91366a93524a53bca4f384f77ca0156d889: Bug 1681992 - Add tests for some multiple about:tabcrashed tabs behaviours. r=NeilDeakin
Mike Conley <mconley@mozilla.com> - Fri, 08 Jan 2021 16:42:48 +0000 - rev 562452
Push 38089 by malexandru@mozilla.com at Fri, 08 Jan 2021 21:57:36 +0000
Bug 1681992 - Add tests for some multiple about:tabcrashed tabs behaviours. r=NeilDeakin Depends on D99480 Differential Revision: https://phabricator.services.mozilla.com/D99490
dff2fd52da6c98f5f92c08cf5c172a8dd44b0d87: Bug 582459 - Reset the focused element when a frame loses document focus; r=mikedeboer,NeilDeakin,hsivonen,jaws
Edgar Chen <echen@mozilla.com> - Mon, 21 Dec 2020 21:35:49 +0000 - rev 561517
Push 38050 by malexandru@mozilla.com at Tue, 22 Dec 2020 09:35:33 +0000
Bug 582459 - Reset the focused element when a frame loses document focus; r=mikedeboer,NeilDeakin,hsivonen,jaws Resetting focus would also clear selection on editable element, so get current selected text before moving focus to findbar to make prefill-with-selection work if the content is loaded in chrome process. Differential Revision: https://phabricator.services.mozilla.com/D89557
47e600a37e250c3f8f27803673d15ce4aa9b5698: Bug 1465513: Call IDropTargetHelper::DragLeave before IDropTargetHelper::DragEnter. r=dmajor,NeilDeakin
Bob Owen <bobowencode@gmail.com> - Mon, 21 Dec 2020 18:49:40 +0000 - rev 561471
Push 38050 by malexandru@mozilla.com at Tue, 22 Dec 2020 09:35:33 +0000
Bug 1465513: Call IDropTargetHelper::DragLeave before IDropTargetHelper::DragEnter. r=dmajor,NeilDeakin This is an attempt clean up any stale information to try and solve crashes later in the drag in nsNativeDragTarget::DragOver. Differential Revision: https://phabricator.services.mozilla.com/D100124
2ac614e69ecbe34e95776a2bd77f2917c9f696a6: Bug 582459 - Reset the focused element when a frame loses document focus; r=mikedeboer,NeilDeakin,hsivonen,jaws
Edgar Chen <echen@mozilla.com> - Tue, 15 Dec 2020 19:55:35 +0000 - rev 560855
Push 38035 by ccoroiu@mozilla.com at Wed, 16 Dec 2020 09:36:04 +0000
Bug 582459 - Reset the focused element when a frame loses document focus; r=mikedeboer,NeilDeakin,hsivonen,jaws Resetting focus would also clear selection on editable element, so get current selected text before moving focus to findbar to make prefill-with-selection work if the content is loaded in chrome process. Differential Revision: https://phabricator.services.mozilla.com/D89557
ee4beb10381bc89e45b775750e13b9643e8dab5e: Bug 1654437 - Fix failing password manager tests for Fission, r=NeilDeakin
Anny Gakhokidze <agakhokidze@mozilla.com> - Thu, 10 Dec 2020 20:24:23 +0000 - rev 560234
Push 38020 by nbeleuzu@mozilla.com at Fri, 11 Dec 2020 04:47:32 +0000
Bug 1654437 - Fix failing password manager tests for Fission, r=NeilDeakin The tests submit a form, which leads to a URL change, and then assert correct location.pathname, and all of this takes place inside of SpecialPowers.spawn. The test fails becase the SpecialPowers JS actor gets destroyed after the form gets submitted, while there is still pending code to execute and this throws an error. We need to submit a form, wait for the browser to load, and then check location.pathname. Differential Revision: https://phabricator.services.mozilla.com/D98229
9ce2bd0dce3297f53520dfb11cf559ef201619fd: Bug 1588503: Don't load AutoCompleteChild.jsm before necessary. r=NeilDeakin
Kris Maglione <maglione.k@gmail.com> - Thu, 22 Oct 2020 19:26:58 +0000 - rev 554088
Push 37888 by smolnar@mozilla.com at Fri, 23 Oct 2020 09:46:15 +0000
Bug 1588503: Don't load AutoCompleteChild.jsm before necessary. r=NeilDeakin Differential Revision: https://phabricator.services.mozilla.com/D93834
6db4fe3478a614d8c355c495d99f61b70c9936c8: Bug 1670452 - Make sure to reposition the popups if the preferred size changes, as that can further resize us. r=NeilDeakin
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 12 Oct 2020 17:10:55 +0000 - rev 552727
Push 37856 by ncsoregi@mozilla.com at Tue, 13 Oct 2020 03:29:28 +0000
Bug 1670452 - Make sure to reposition the popups if the preferred size changes, as that can further resize us. r=NeilDeakin When the pref size changes, we set the bounds of the popup to the pref size, which is the size of all the contents, usually. It's SetPopupPosition what takes care of flipping / constraining / etc, so make sure that happens. Differential Revision: https://phabricator.services.mozilla.com/D93226
73e1bc905663894b98bdb4d719c270adff7b5ab2: Bug 1666575 - Keep pdfjs classes always enabled. r=NeilDeakin,jaws
mcccs <mcccs@gmx.com> - Sat, 10 Oct 2020 09:29:41 +0000 - rev 552572
Push 37851 by nbeleuzu@mozilla.com at Sat, 10 Oct 2020 21:35:37 +0000
Bug 1666575 - Keep pdfjs classes always enabled. r=NeilDeakin,jaws Differential Revision: https://phabricator.services.mozilla.com/D91441