searching for reviewer(MarcoZ)
f14bfae6f0402d1503d5cfbbd7a47c7715fdd5f9: Bug 1587791 - remove XBL backed accessible relations support r=MarcoZ
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 10 Oct 2019 14:08:17 +0000 - rev 497109
Push 36677 by rmaries@mozilla.com at Thu, 10 Oct 2019 21:40:19 +0000
Bug 1587791 - remove XBL backed accessible relations support r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D48840
119e4808983044dd1b29fa7da03724ae4354d418: Bug 1586836 - remove <xul:textbox> from a11y tests r=MarcoZ
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 08 Oct 2019 17:29:16 +0000 - rev 496791
Push 36668 by aiakab@mozilla.com at Wed, 09 Oct 2019 04:06:09 +0000
Bug 1586836 - remove <xul:textbox> from a11y tests r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D48576
aa7f20ae769925c032b117c1b4cc7c3db1f16780: Bug 1581956 - Make search-textbox not use the <textbox> tag. r=surkov,MarcoZ
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 25 Sep 2019 19:12:48 +0000 - rev 494959
Push 36620 by apavel@mozilla.com at Thu, 26 Sep 2019 04:07:05 +0000
Bug 1581956 - Make search-textbox not use the <textbox> tag. r=surkov,MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D46219
606bb262818f1e14d24480ed48b13876d36e0680: Bug 1316965: Give file inputs an a11y role of GROUPING so screen readers report their label when focus enters them. r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 19 Sep 2019 04:39:21 +0000 - rev 494051
Push 36593 by opoprus@mozilla.com at Thu, 19 Sep 2019 09:46:54 +0000
Bug 1316965: Give file inputs an a11y role of GROUPING so screen readers report their label when focus enters them. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D46375
768b6818e6662500aa3d77b32f4549c393abb691: Bug 1582323: When a file input has DOM focus, focus the browse button inside it for a11y. r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 19 Sep 2019 04:34:29 +0000 - rev 494050
Push 36593 by opoprus@mozilla.com at Thu, 19 Sep 2019 09:46:54 +0000
Bug 1582323: When a file input has DOM focus, focus the browse button inside it for a11y. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D46386
38459b4f9d63f583a89a618cf73a62cc7e777d31: Bug 1574428: IAccessible2_2::relationTargetsOfType: Support 0 for all targets and fix off-by-one error. r=MarcoZ
James Teh <jteh@mozilla.com> - Mon, 19 Aug 2019 05:58:49 +0000 - rev 488641
Push 36450 by malexandru@mozilla.com at Mon, 19 Aug 2019 09:50:44 +0000
Bug 1574428: IAccessible2_2::relationTargetsOfType: Support 0 for all targets and fix off-by-one error. r=MarcoZ 1. As per the spec, if maxTargets is 0, return all targets. 2. Where maxTargets > 0, fix the loop condition so it doesn't incorrectly fetch one more target than requested. Differential Revision: https://phabricator.services.mozilla.com/D42446
37af412cc9f13bba568ba42a621528f735fdcc7c: Bug 1570308 - make legend understandable to screen readers r=fluent-reviewers,mtigley,flod,MarcoZ
Micah Tigley <mtigley@mozilla.com> - Mon, 12 Aug 2019 20:44:30 +0000 - rev 487542
Push 36425 by btara@mozilla.com at Tue, 13 Aug 2019 09:54:32 +0000
Bug 1570308 - make legend understandable to screen readers r=fluent-reviewers,mtigley,flod,MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D41437
f980c4db1343283ffae1c018b12a604a199ffed2: Bug 1570848: When an OuterDocAccessible is constructed, send it as the parent COM proxy for its remote document (if any). r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 02 Aug 2019 04:24:54 +0000 - rev 485866
Push 36376 by malexandru@mozilla.com at Fri, 02 Aug 2019 09:48:35 +0000
Bug 1570848: When an OuterDocAccessible is constructed, send it as the parent COM proxy for its remote document (if any). r=MarcoZ Normally, the OuterDocAccessible is created first and the DocAccessibleParent for a remote document is created after that. So, we get the OuterDocAccessible and call DocAccessibleParent::SendParentCOMProxy when the DocAccessibleParent is constructed (BrowserParent::RecvPDocAccessibleConstructor). However, sometimes, the OuterDocAccessible is created *after* the DocAccessibleParent. This sometimes happens for extension popups, for example. In that case, we previously never sent the parent COM proxy. Aside from leaving the remote document with a null parent, this also meant we never sent any events for the document, since events are buffered for remote documents until the parent COM proxy is received. This effectively left the remote document (e.g. extension popup) inaccessible. Now, we also call SendParentCOMProxy in the OuterDocAccessible constructor. Note that this doesn't result in duplicates because if the OuterDocAccessible was created first, there won't be a DocAccessibleParent for the remote document yet, so this code won't run. That said, if the OuterDocAccessible is recreated (e.g. due to frame reconstruction), we may call SendParentCOMProxy again. This should be okay, but it required an assertion in DocAccessibleChild::RecvParentCOMProxy to be tweaked. Differential Revision: https://phabricator.services.mozilla.com/D40358
4bf4bab555b897567ad4fc98dec632f8efd0c114: Bug 1569712: Block Conexant Flow instantiating a11y to prevent performance issues. r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 01 Aug 2019 05:07:31 +0000 - rev 485742
Push 36373 by rmaries@mozilla.com at Fri, 02 Aug 2019 03:50:33 +0000
Bug 1569712: Block Conexant Flow instantiating a11y to prevent performance issues. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D40149
a423e8a5526660b0b84c79d9c7b13a0d1987eaff: Bug 1429442 - Buttons in "type control" popup in reader mode should have tooltips r=Gijs,MarcoZ
monikamaheshwari <monikamaheshwari1996@gmail.com> - Mon, 11 Mar 2019 11:47:49 +0000 - rev 463446
Push 35682 by rgurzau@mozilla.com at Mon, 11 Mar 2019 16:49:48 +0000
Bug 1429442 - Buttons in "type control" popup in reader mode should have tooltips r=Gijs,MarcoZ Added tooltips in type control for accessibility Differential Revision: https://phabricator.services.mozilla.com/D22679
546397372dd75a335d91268a5b5b539f17f266d9: Bug 1531346 - Check for cyclical relationship with aria-activedescendant. r=MarcoZ
Eitan Isaacson <eitan@monotonous.org> - Fri, 08 Mar 2019 07:55:13 +0000 - rev 463123
Push 35668 by btara@mozilla.com at Fri, 08 Mar 2019 21:50:53 +0000
Bug 1531346 - Check for cyclical relationship with aria-activedescendant. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D22633
618b155f9f0ced0837981acecc19ff3514235263: Bug 1529407: Correct MSAA accValue and accRole for role="document". r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 21 Feb 2019 06:48:02 +0000 - rev 460219
Push 35588 by nbeleuzu@mozilla.com at Thu, 21 Feb 2019 15:59:59 +0000
Bug 1529407: Correct MSAA accValue and accRole for role="document". r=MarcoZ 1. When role="document" is (redundantly) used on the body element, still expose the URL via accValue, just like we do for role="application". 2. Expose ROLE_SYSTEM_DOCUMENT for role="document" (rather than the string "document") as per the spec. (Chrome already does this, so I don't expect backwards compat problems with clients.) Differential Revision: https://phabricator.services.mozilla.com/D20582
01bc5a0dc801885894b7ce17e0bdbaf73b87c020: Bug 1527254 - Don't rely on tabpanels xul element in Android for offcreen state. r=MarcoZ
Eitan Isaacson <eitan@monotonous.org> - Thu, 14 Feb 2019 08:01:36 +0000 - rev 459008
Push 35554 by rgurzau@mozilla.com at Thu, 14 Feb 2019 17:00:27 +0000
Bug 1527254 - Don't rely on tabpanels xul element in Android for offcreen state. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D19710
af2e994137272f66289200e776063da970c7b3e3: Bug 1511398 - Don't append null proxies to batch list. r=MarcoZ
Eitan Isaacson <eitan@monotonous.org> - Tue, 29 Jan 2019 04:30:41 +0000 - rev 455780
Push 35457 by csabou@mozilla.com at Tue, 29 Jan 2019 09:20:40 +0000
Bug 1511398 - Don't append null proxies to batch list. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D17845
311d09aeb1ab0e1ee583123634a4b28975172969: Bug 1521438: Correct IAccessible::get_accSelection implementation for no selection and single selection. r=MarcoZ
James Teh <jteh@mozilla.com> - Mon, 21 Jan 2019 07:21:01 +0000 - rev 454652
Push 35409 by rmaries@mozilla.com at Mon, 21 Jan 2019 17:48:45 +0000
Bug 1521438: Correct IAccessible::get_accSelection implementation for no selection and single selection. r=MarcoZ Previously, we were always returning VT_UNKNOWN and an IEnumVARIANT. According to the IAccessible documentation, this should only be done for multiple selection. Change this to correctly return VT_EMPTY for no selection and VT_DISPATCH (with an accessible) for single selection. Differential Revision: https://phabricator.services.mozilla.com/D17091
ce47b0935c9f67b00787f450ff226fbc64f7ee04: Bug 1514093 part 2: Marshal the result from IAccessible::get_accSelection as IEnumVARIANT. r=MarcoZ
James Teh <jteh@mozilla.com> - Wed, 16 Jan 2019 08:13:20 +0000 - rev 454064
Push 35385 by rmaries@mozilla.com at Wed, 16 Jan 2019 16:58:22 +0000
Bug 1514093 part 2: Marshal the result from IAccessible::get_accSelection as IEnumVARIANT. r=MarcoZ Our accSelection implementation always returns an IUnknown which clients QI to IEnumVARIANT. Marshaling as IUnknown works fine in this case, but it's more efficient and correct to marshal the correct interface. Also, without this, we'd hit an assertion. Depends on D16662 Differential Revision: https://phabricator.services.mozilla.com/D16663
346851347c909e92ed68dc3f104c63ff3e0eaa70: Bug 1514687 - Allow accessibility code to focus XUL radio buttons without selecting them. r=bgrins,smaug,MarcoZ,paolo
James Teh <jteh@mozilla.com> - Fri, 11 Jan 2019 04:52:50 +0000 - rev 453681
Push 35369 by ncsoregi@mozilla.com at Mon, 14 Jan 2019 10:42:48 +0000
Bug 1514687 - Allow accessibility code to focus XUL radio buttons without selecting them. r=bgrins,smaug,MarcoZ,paolo 1. This requires exposing radiogroup's focusedItem property to C++. Unfortunately, there's no existing equivalent in nsIDOMXULSelectControlItemElement. radiogroup is the only element that needs this, so a new interface has been created for it. 2. Accessibility uses focusedItem instead of selectedItem when setting focus. 3. When an item is focused, accessibility needs to be notified. This is done using a DOMMenuItemActive event. Differential Revision: https://phabricator.services.mozilla.com/D15295
460f0359741bd0026b7da0426836e1c0084a5be3: Bug 1518805 - Don't update bounds on gone or defunct accessibles. r=MarcoZ
Eitan Isaacson <eitan@monotonous.org> - Thu, 10 Jan 2019 06:59:16 +0000 - rev 453209
Push 35349 by btara@mozilla.com at Thu, 10 Jan 2019 17:19:27 +0000
Bug 1518805 - Don't update bounds on gone or defunct accessibles. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D16064
01d64b7442cd23657d1135c9da9b254ba5317116: Bug 1518253 - Add accessibles to focus path hash table in non-e10s. r=MarcoZ
Eitan Isaacson <eitan@monotonous.org> - Tue, 08 Jan 2019 06:08:43 +0000 - rev 452933
Push 35334 by rmaries@mozilla.com at Tue, 08 Jan 2019 21:58:40 +0000
Bug 1518253 - Add accessibles to focus path hash table in non-e10s. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D15858
db7ef78c063b2d0532056aa768f80493c8d0b739: Bug 1515294: Only use SendSyncTextChangeEvent for live regions. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 21 Dec 2018 09:16:38 +0000 - rev 452261
Push 35299 by btara@mozilla.com at Wed, 02 Jan 2019 21:34:59 +0000
Bug 1515294: Only use SendSyncTextChangeEvent for live regions. r=MarcoZ In order to support IA2 live regions with e10s (bug 1322532), text change events sent from the child process to the parent process use sync IPC. That comes at a slight performance cost: the content process is blocked until the parent returns from sending and handling the event. However, there is no reason to do this if the event is not for an accessible inside a live region; current clients don't need the sync behaviour outside of live regions. Differential Revision: https://phabricator.services.mozilla.com/D15183
415f827cb9ce211c48b0c6625e917582bc81fd3a: Bug 1515294: Only use SendSyncTextChangeEvent for live regions. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 21 Dec 2018 09:16:38 +0000 - rev 451650
Push 35249 by rgurzau@mozilla.com at Fri, 21 Dec 2018 16:34:09 +0000
Bug 1515294: Only use SendSyncTextChangeEvent for live regions. r=MarcoZ In order to support IA2 live regions with e10s (bug 1322532), text change events sent from the child process to the parent process use sync IPC. That comes at a slight performance cost: the content process is blocked until the parent returns from sending and handling the event. However, there is no reason to do this if the event is not for an accessible inside a live region; current clients don't need the sync behaviour outside of live regions. Differential Revision: https://phabricator.services.mozilla.com/D15183
5e4074b128f944119f2f224391453db85e2406cb: Bug 1513332, add some null-pointer checks on elements in XULListboxAccessible, r=marcoz
Neil Deakin <neil@mozilla.com> - Mon, 17 Dec 2018 20:02:11 -0500 - rev 451126
Push 35227 by cbrindusan@mozilla.com at Tue, 18 Dec 2018 17:34:45 +0000
Bug 1513332, add some null-pointer checks on elements in XULListboxAccessible, r=marcoz
003adae62f33b0425e68c6aafa3c255fc8611c06: Bug 1513332, add some null-pointer checks on elements in XULListboxAccessible, r=marcoz
Neil Deakin <neil@mozilla.com> - Mon, 17 Dec 2018 15:43:51 -0500 - rev 451049
Push 35225 by cbrindusan@mozilla.com at Tue, 18 Dec 2018 09:51:20 +0000
Bug 1513332, add some null-pointer checks on elements in XULListboxAccessible, r=marcoz
004331df8823ee887cc787e29ef7efe4fa4e596f: Bug 1429940 - Part 2 - Use HTML headings inside the "label" element for labeling "groupbox" elements in Preferences, instead of the "caption" element. r=MarcoZ,dao,jaws,flod
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 20 Nov 2018 15:14:18 +0000 - rev 447404
Push 35076 by shindli@mozilla.com at Wed, 21 Nov 2018 04:05:31 +0000
Bug 1429940 - Part 2 - Use HTML headings inside the "label" element for labeling "groupbox" elements in Preferences, instead of the "caption" element. r=MarcoZ,dao,jaws,flod This makes it possible to navigate by headings when using accessibility technology. Information labels displayed when removing the master password are also restored. Differential Revision: https://phabricator.services.mozilla.com/D11792
7ceb485a00ccd366cb25bedba008dcaf63a355d9: Bug 1052866 part 2: Handle QI to IAccessibleText for tables. r=MarcoZ
James Teh <jteh@mozilla.com> - Mon, 29 Oct 2018 06:36:51 +0000 - rev 443286
Push 34953 by ebalazs@mozilla.com at Mon, 29 Oct 2018 09:26:00 +0000
Bug 1052866 part 2: Handle QI to IAccessibleText for tables. r=MarcoZ The first patch inherits from the right classes, but because tables have additional interfaces, QueryInterface is overridden. It had to be updated to also include HyperTextAccessibleWrap. Rows worked correctly because they don't have any specific interfaces and thus don't override QI. They just inherit their QI implementation from their base class. Differential Revision: https://phabricator.services.mozilla.com/D10022
4c11d8d96c247b0057a30e1521ac56ce90283f5e: Bug 1498274 - Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins,MarcoZ
Paolo Amadini <paolo.mozmail@amadzone.org> - Fri, 12 Oct 2018 15:07:17 +0100 - rev 441081
Push 34842 by aciure@mozilla.com at Sat, 13 Oct 2018 09:36:47 +0000
Bug 1498274 - Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins,MarcoZ These are two other cases where grouping is not really necessary. For accessibility, the checkbox at the end of the download interstitial dialog does not need to be in the same group as the radio button, and the question text can more simply just label the radiogroup. The vbox is still necessary to hide the section, but is not related to accessibility or dialog structure. Differential Revision: https://phabricator.services.mozilla.com/D8421
ba07c543cc935aed4a56a495a031dc8cd970290b: Bug 1496850 - add label to volume slider, r=MarcoZ
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 10 Oct 2018 17:40:42 +0000 - rev 440635
Push 34827 by toros@mozilla.com at Thu, 11 Oct 2018 03:53:09 +0000
Bug 1496850 - add label to volume slider, r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D8202
c25dbd88a42d643e4a23fb27daeebe17da92199f: Bug 1331755: Refactor handling of accessibility focus in the URL bar so focus never moves to suggestions while the user is editing. r=Gijs,MarcoZ
James Teh <jteh@mozilla.com> - Tue, 18 Sep 2018 05:10:35 +0000 - rev 436921
Push 34665 by ebalazs@mozilla.com at Tue, 18 Sep 2018 14:32:15 +0000
Bug 1331755: Refactor handling of accessibility focus in the URL bar so focus never moves to suggestions while the user is editing. r=Gijs,MarcoZ When the user is editing the text in the URL bar (typing, backspace, etc.), the first suggestion is always selected. Because accessibility clients require autocomplete items to be "focused", the code needs to differentiate between explicit selection (e.g. via down/up arrow) and auto selection (e.g. when typing). Otherwise, the focus continually moves away from the text box while the user is typing, as was previously occurring. This makes it very difficult for the user to edit text, particularly backspace/delete. There was a previous attempt to handle this, but it was somewhat fragile and broke completely some time ago. Now, rather than trying to handle this based on autocomplete events, it is handled in the input and key press events. For input events, accessibility focus is forced back to the text box and further accessibility focus events are suppressed. For down arrow, up arrow, etc. key presses, accessibility focus events for suggestions are enabled. This makes it easier to understand and predict the user experience, rather than relying on underlying autocomplete implementation details. This is tested using an accessibility browser test, which makes it easier to make assertions about accessibility focus. This also means that if the underlying implementation details change (e.g. HTML + aria-activedescendant instead of XUL + DOMMenuItemActive events), this test should still be valid and allow us to catch regressions. Differential Revision: https://phabricator.services.mozilla.com/D5987
e67f28fac303774e424dee53737744f3fb2bf77e: Bug 1487304: Add more labels/descriptions in Privacy preferences for accessibility. r=johannh,MarcoZ
James Teh <jteh@mozilla.com> - Fri, 31 Aug 2018 07:57:57 +0000 - rev 434207
Push 34545 by ccoroiu@mozilla.com at Fri, 31 Aug 2018 16:13:06 +0000
Bug 1487304: Add more labels/descriptions in Privacy preferences for accessibility. r=johannh,MarcoZ This allows screen reader users to determine the context of various controls when tabbing through them. Specific changes: 1. Describe the "Cookies and Site Data" group using the disk space indicator; e.g. "Your stored cookies, site data and cache are currently using 315 MB of disk space." 2. Associate the description for the "Content Blocking" group; i.e. "Block third-party content, like ads or code..." 3. Correct association of the label for the "Do Not Track" setting; i.e. 'Send websites a “Do Not Track” signal that you don’t want to be tracked' 4. Associate the label for the "Permissions" group. 5. Make each permission a labelled group so the user knows what the various "Settings…" buttons are for. 6. Associate the label for the "Data Collection and Use" group. Differential Revision: https://phabricator.services.mozilla.com/D4638
179fc264c8643d1f8770ef2b2e861abf56a5287e: Bug 1480060: Support aria-multiselectable on role tablist. r=MarcoZ
James Teh <jteh@mozilla.com> - Mon, 13 Aug 2018 06:28:35 +0000 - rev 431173
Push 34430 by btara@mozilla.com at Mon, 13 Aug 2018 09:55:43 +0000
Bug 1480060: Support aria-multiselectable on role tablist. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D3076
b6c8ed7e23e393ac9dc6873ba0efecd52cf9cad0: Bug 903187: Map HTML ins/del to accessible roles. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 27 Jul 2018 16:40:50 +1000 - rev 428908
Push 34351 by apavel@mozilla.com at Mon, 30 Jul 2018 09:51:16 +0000
Bug 903187: Map HTML ins/del to accessible roles. r=MarcoZ IA2 now has IA2_ROLE_CONTENT_INSERTION/DELETION. Mac has AXInsert/DeleteStyleGroup subroles. We now create accessibles for these elements and expose the appropriate role. For ATK, there is no specific role for these, so we just use the generic ATK_ROLE_SECTION. MozReview-Commit-ID: 2khzRa7BQ6z
84450fef88b2fa9c6696bf26cc5c211a0ce98b97: Bug 1478568 part 2: Map BLOCKQUOTE role to IA2_ROLE_BLOCK_QUOTE. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 27 Jul 2018 10:30:25 +1000 - rev 428654
Push 34338 by dluca@mozilla.com at Fri, 27 Jul 2018 09:54:52 +0000
Bug 1478568 part 2: Map BLOCKQUOTE role to IA2_ROLE_BLOCK_QUOTE. r=MarcoZ MozReview-Commit-ID: KxGnO0R1dRJ
08dc38b9377252d2b10caea1c10971f6fbe25908: Bug 1478568 part 1: Update IAccessible2 so we can use new roles (IA2_ROLE_BLOCK_QUOTE, etc.). r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 27 Jul 2018 10:27:44 +1000 - rev 428653
Push 34338 by dluca@mozilla.com at Fri, 27 Jul 2018 09:54:52 +0000
Bug 1478568 part 1: Update IAccessible2 so we can use new roles (IA2_ROLE_BLOCK_QUOTE, etc.). r=MarcoZ MozReview-Commit-ID: GctgcmwrzMc
ab79c47390b5f8e508353093ed77b90b7e6fcce3: Bug 1476347: Fix accessibility for HTML dt/dd with a div as its parent. r=MarcoZ
James Teh <jteh@mozilla.com> - Wed, 18 Jul 2018 20:13:01 +1000 - rev 427402
Push 34303 by toros@mozilla.com at Fri, 20 Jul 2018 09:55:38 +0000
Bug 1476347: Fix accessibility for HTML dt/dd with a div as its parent. r=MarcoZ It is conforming in HTML to use a div to group dt/dd elements. Previously, we didn't create an accessible for dt/dd elements in this case. MozReview-Commit-ID: 8GDDxU3RbLd
254564563107faac0f16dd48fa6927ddbfac955c: Bug 1475376: Support aria-valuetext for implicit ARIA roles. r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 12 Jul 2018 20:22:09 -0400 - rev 426443
Push 34272 by ebalazs@mozilla.com at Fri, 13 Jul 2018 08:51:04 +0000
Bug 1475376: Support aria-valuetext for implicit ARIA roles. r=MarcoZ For example, <input type="range"> maps to role="slider", so aria-valuetext should be supported. MozReview-Commit-ID: IYBVTHP3ZLo
cbf89941ccff2dde578bb11be34aec1a1b902b1f: Bug 1474814: Invalidate the AccessibleHandler cache on focus events. r=MarcoZ
James Teh <jteh@mozilla.com> - Wed, 11 Jul 2018 16:26:19 +1000 - rev 425784
Push 34266 by rgurzau@mozilla.com at Wed, 11 Jul 2018 22:03:10 +0000
Bug 1474814: Invalidate the AccessibleHandler cache on focus events. r=MarcoZ We don't fire a state change for the focused state, since that would be redundant given that we fire a focus event. However, that also means the handler cache previously didn't get invalidated when there was a focus change without any other update. That resulted in stale focused states, which could mean an object was exposed as focused when it wasn't. Invalidating the cache for focus events ensures the focused state is always up to date. MozReview-Commit-ID: DZTJMbiTwgt
7f496f2f11ef8fccba876b2a307bbf8f4f6e77e1: Bug 1473453 - Part 1: a11y: assert `hitregion` property is always null or true. r=MarcoZ
Chris Peterson <cpeterson@mozilla.com> - Wed, 04 Jul 2018 14:39:57 -0700 - rev 425741
Push 34264 by shindli@mozilla.com at Wed, 11 Jul 2018 09:41:50 +0000
Bug 1473453 - Part 1: a11y: assert `hitregion` property is always null or true. r=MarcoZ Fix clang-tidy warning about bool pointers: [misc-bool-pointer-implicit-conversion] accessible/generic/Accessible.cpp:644:9: warning: dubious check of 'bool *' against 'nullptr', did you mean to dereference it? The `hitregion` property is always null or points to a true bool, set here: https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/dom/canvas/CanvasRenderingContext2D.cpp#3936-3937 The `hitregion` property used to be an nsRect pointer: https://searchfox.org/mozilla-central/diff/c797577640f306df87e8c32313c5b826d1e58a9b/accessible/src/generic/Accessible.cpp#928 MozReview-Commit-ID: HYlAnMyaitB
4fd60abd9726046598d302b473106f7df33e66f1: Bug 468497: Inform the accessibility FocusManager when a XUL tree's view changes. r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 05 Jul 2018 16:33:24 +1000 - rev 425260
Push 34241 by ebalazs@mozilla.com at Fri, 06 Jul 2018 09:45:16 +0000
Bug 468497: Inform the accessibility FocusManager when a XUL tree's view changes. r=MarcoZ Without this, accessibility clients don't get notified about the newly focused item. For example, this meant that nothing was reported by screen readers when switching tabs in Thunderbird with control+tab. MozReview-Commit-ID: F7vqvLXzeJR
50a6c79860000396a9d1378687e150310ae96eb4: Bug 1460244 - Tables with CSS display properties no longer participate in layout table calculation, r=marcoz
Alexander Surkov <surkov.alexander@gmail.com> - Fri, 25 May 2018 10:55:52 -0400 - rev 419895
Push 34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1460244 - Tables with CSS display properties no longer participate in layout table calculation, r=marcoz
cb4152d2175e9ada6736224067b322a785e106c8: Bug 1462238: Extend/clarify expiry of accessibility instantiator/consumers telemetry. r=MarcoZ data-review=francois
James Teh <jteh@mozilla.com> - Thu, 17 May 2018 16:55:03 +1000 - rev 418776
Push 34012 by dluca@mozilla.com at Fri, 18 May 2018 09:54:59 +0000
Bug 1462238: Extend/clarify expiry of accessibility instantiator/consumers telemetry. r=MarcoZ data-review=francois 1. Set A11Y_INSTANTIATORS to never expire. 2. A11Y_CONSUMERS was already set to never expire, but only because expiry was never explicitly declared (when this was allowed). Explicitly set it as never expiring now. This also means it can be removed from the associated whitelist. 3. Change the email for both so it gets to the team and me (since policy requires a responsible person and that's me now for these). MozReview-Commit-ID: BgjMoVnVp6U
c199ef8f320762d7fcbec18bd68f0aecc5c22c1b: Bug 1455357 - Setting grid item to display:contents resets its accessible role, patch=surkov,jamie, r=marcoz
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 15 May 2018 09:44:21 -0400 - rev 418366
Push 33999 by dluca@mozilla.com at Tue, 15 May 2018 21:54:51 +0000
Bug 1455357 - Setting grid item to display:contents resets its accessible role, patch=surkov,jamie, r=marcoz
1abaa57e467e72e566b4f74485ba10322bde6921: Bug 1005271 - HTML table with display:block should expose table semantics, r=marcoz
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 08 May 2018 13:13:38 -0400 - rev 417428
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1005271 - HTML table with display:block should expose table semantics, r=marcoz
c3296237754d22e87755b3f9c4d75bb0e18eb95f: Bug 1453979 - use ContiguousEnumSerializerInclusive for serializing enums in a11y IPC code; r=MarcoZ
Alex Gaynor <agaynor@mozilla.com> - Fri, 13 Apr 2018 10:51:43 -0400 - rev 413971
Push 33853 by cbrindusan@mozilla.com at Tue, 17 Apr 2018 09:51:13 +0000
Bug 1453979 - use ContiguousEnumSerializerInclusive for serializing enums in a11y IPC code; r=MarcoZ MozReview-Commit-ID: 92S42SkSEEP
99c2396a4c8767d152e437299664d0e15c3d8e35: Bug 1453979 - use ContiguousEnumSerializerInclusive for serializing enums in a11y IPC code; r=MarcoZ
Alex Gaynor <agaynor@mozilla.com> - Fri, 13 Apr 2018 10:51:43 -0400 - rev 413915
Push 33853 by cbrindusan@mozilla.com at Tue, 17 Apr 2018 09:51:13 +0000
Bug 1453979 - use ContiguousEnumSerializerInclusive for serializing enums in a11y IPC code; r=MarcoZ MozReview-Commit-ID: 92S42SkSEEP
ad1a87f7ffa532f18f6ced9f93a2f51c790f1b35: Bug 1453873: Stop firing accessible focus events for JAWS when combo box options are selected. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 13 Apr 2018 14:14:50 +1000 - rev 413116
Push 33833 by aiakab@mozilla.com at Fri, 13 Apr 2018 09:41:15 +0000
Bug 1453873: Stop firing accessible focus events for JAWS when combo box options are selected. r=MarcoZ These events were a hack implemented in bug 703198. At that time, JAWS required focus events for selection changes in a collapsed combo box. However, these events also fire for expanded combo boxes. This is problematic with e10s because now, for an expanded combo box, the real focus events come from the XUL dropdown implemented in the parent process, which is not associated with the document a11y tree in any way. JAWS seems to cope just fine with value changes for Firefox combo boxes now and VFO have agreed that this is the correct path forward. MozReview-Commit-ID: Iefop25bFe0
5a6db1121fcede3d0844ec1be195ab7858cd1e19: Bug 1451673 - "Crash in mozilla::a11y::HTMLTableAccessible::IsProbablyLayoutTable" r=MarcoZ
alexander :surkov <surkov.alexander@gmail.com> - Thu, 05 Apr 2018 10:24:00 +0300 - rev 412154
Push 33785 by nerli@mozilla.com at Fri, 06 Apr 2018 21:55:43 +0000
Bug 1451673 - "Crash in mozilla::a11y::HTMLTableAccessible::IsProbablyLayoutTable" r=MarcoZ
a61e917f9406110b7d84ccc01416fda61c8bf4d0: Bug 1448091 part 2: AccessibleHandler: Don't repeatedly and unnecessarily refresh the cache after the first change. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 23 Mar 2018 11:53:01 -0400 - rev 409682
Push 33696 by rgurzau@mozilla.com at Fri, 23 Mar 2018 21:59:15 +0000
Bug 1448091 part 2: AccessibleHandler: Don't repeatedly and unnecessarily refresh the cache after the first change. r=MarcoZ The singleton AccessibleHandlerControl maintains a global cache generation counter which is incremented whenever any node is changed. The handler for each node tracks the cache generation at the time its cache was initialized. To check whether the cache needs to be updated, the handler compares its generation against the global generation from AccessibleHandlerControl. If they differ, it refreshes the cache. Previously, the handler didn't update its cache generation after refreshing. This meant that every single query after the first change would refresh the whole cache, even if there wasn't a second change. This resulted in a huge number of wasted cache updates for clients such as JAWS which hold onto accessibles, rather than releasing them and fetching them again for each update. MozReview-Commit-ID: 80d4n1cIjzQ
702ffbc7ccd54d86913b43becf7a559da8b3f189: Bug 1448091 part 1: Accessible HandlerProvider: Return an error if refreshing the cache fails. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 23 Mar 2018 11:44:05 -0400 - rev 409681
Push 33696 by rgurzau@mozilla.com at Fri, 23 Mar 2018 21:59:15 +0000
Bug 1448091 part 1: Accessible HandlerProvider: Return an error if refreshing the cache fails. r=MarcoZ BuildDynamicIA2Data can't return an HRESULT; failure is communicated by the fact that the unique id in the data is set to 0. However, IGeckoBackChannel::Refresh returned S_OK even if BuildDynamicIA2Data failed. We now check the unique id and return an appropriate error code if it's 0. Among other things, this means that the handler will return an error when querying dead objects instead of returning stale cache data. MozReview-Commit-ID: IorDRHCItD8
aa06fb8316c272ecf735aecb59673544d6423631: Bug 1431256 correction: AccessibleHandler: Really return E_NOINTERFACE for IEnumVARIANT if there are no children. r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 22 Mar 2018 17:57:34 -0400 - rev 409637
Push 33693 by nbeleuzu@mozilla.com at Fri, 23 Mar 2018 09:52:16 +0000
Bug 1431256 correction: AccessibleHandler: Really return E_NOINTERFACE for IEnumVARIANT if there are no children. r=MarcoZ A typo meant we were checking the address of mChildCount, not the value. MozReview-Commit-ID: 7Hit3FBy9pr
8f68422b3307dc910732da8f07ceb9accbc74873: Bug 1431256 part 4: Remove IEnumVARIANT from the AccessibleHandler payload. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 19 Jan 2018 11:40:42 +1000 - rev 409511
Push 33689 by nerli@mozilla.com at Thu, 22 Mar 2018 22:52:18 +0000
Bug 1431256 part 4: Remove IEnumVARIANT from the AccessibleHandler payload. r=MarcoZ Now that the handler implements IEnumVARIANT itself (and uses our own internal method to retrieve the children), caching this remote interface is pointless. MozReview-Commit-ID: FyagiEcHMP2