searching for reviewer(Manishearth)
fa644e5bcf772acdf5e120a8234c54f3247fc1b4: Bug 1572738 - Don't clamp font-size calc() factors too early. r=manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Aug 2019 19:59:48 +0000 - rev 488793
Push 36456 by ccoroiu@mozilla.com at Tue, 20 Aug 2019 03:45:31 +0000
Bug 1572738 - Don't clamp font-size calc() factors too early. r=manishearth These two bugs (bug 1572738 and bug 1572451) are stylo regressions. When font-family changes, we try to recompute the font-size with a length / percentage combinations in case the generic family changes, so the user preferences are kept. When calc() is involved, we clamp to non-negative too early, via NonNegativeLength::scale_by. I think we should generally dump this "try to track font-size across calc()" thingie, as as various comments note it is not quite perfect, and it's not clear how it should work in presence of min()/max(). This patch fixes the issue and simplifies code a bit, I may consider removing this altogether in a follow-up. Differential Revision: https://phabricator.services.mozilla.com/D41776
d25cc097d600ac2423c9b3f13aba671f201376d1: Bug 1536718 - Honor browser.display.use_document_fonts again. r=manishearth,jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 26 Mar 2019 18:42:27 +0000 - rev 466166
Push 35762 by csabou@mozilla.com at Wed, 27 Mar 2019 04:44:00 +0000
Bug 1536718 - Honor browser.display.use_document_fonts again. r=manishearth,jwatt Differential Revision: https://phabricator.services.mozilla.com/D24218
e05dc78eb4272fff00d1aee1b1d629c0163ca343: Bug 1534494 - Try to bring some more sanity into our font code. r=manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Mar 2019 15:37:03 +0000 - rev 464830
Push 35727 by dvarga@mozilla.com at Tue, 19 Mar 2019 09:48:59 +0000
Bug 1534494 - Try to bring some more sanity into our font code. r=manishearth It's not very easy to understand on its current state, and it causes subtle bugs like bug 1533654. It could be simpler if we centralized where the interactions between properties are handled. This patch does this. This patch also changes how MathML script sizes are tracked when scriptlevel changes and they have relative fonts in between. With this patch, any explicitly specified font-size is treated the same (being a scriptlevel boundary), regardless of whether it's either an absolute size, a relative size, or a wide keyword. Relative lengths always resolve relative to the constrained size, which allows us to avoid the double font-size computation, and not give up on sanity with keyword font-sizes. I think given no other browser supports scriptlevel it seems like the right trade-off. Differential Revision: https://phabricator.services.mozilla.com/D23070
0b11e726fe9c5a1c347a870464b04587743f9d0d: Bug 1493181 - Use rounding instead of ceiling when computing 'ch' width; update test expectations accordingly. r=manishearth
Jonathan Kew <jkew@mozilla.com> - Sat, 22 Sep 2018 23:26:55 +0100 - rev 437814
Push 34699 by ncsoregi@mozilla.com at Sun, 23 Sep 2018 09:23:14 +0000
Bug 1493181 - Use rounding instead of ceiling when computing 'ch' width; update test expectations accordingly. r=manishearth
70160e10c6047e49c7d2cc0d7b11dfa531a0b8d3: Bug 1493181 - Test for expected width of CSS 'ch' unit. r=manishearth
Jonathan Kew <jkew@mozilla.com> - Sat, 22 Sep 2018 23:26:31 +0100 - rev 437813
Push 34699 by ncsoregi@mozilla.com at Sun, 23 Sep 2018 09:23:14 +0000
Bug 1493181 - Test for expected width of CSS 'ch' unit. r=manishearth
8ed2557771a8cab161267b48ad662da0e4284597: Bug 1476445 - Use an acquire load for is_unique in servo_arc. r=manishearth
Bobby Holley <bobbyholley@gmail.com> - Tue, 17 Jul 2018 22:23:26 +0000 - rev 426992
Push 34290 by ebalazs@mozilla.com at Wed, 18 Jul 2018 09:32:32 +0000
Bug 1476445 - Use an acquire load for is_unique in servo_arc. r=manishearth MozReview-Commit-ID: Dv7Rql4KUgr Differential Revision: https://phabricator.services.mozilla.com/D2205
00dd151d33d3f6d7f21c7dd450ca3b81ec061249: Bug 1459367 - Convert NS_STYLE_IMAGELAYER_ATTACHMENT_* to enum class. r=manishearth
Kristen Wright <kwright@mozilla.com> - Tue, 08 May 2018 15:05:33 -0700 - rev 417858
Push 33981 by ebalazs@mozilla.com at Fri, 11 May 2018 09:36:34 +0000
Bug 1459367 - Convert NS_STYLE_IMAGELAYER_ATTACHMENT_* to enum class. r=manishearth Converted NS_STYLE_IMAGELAYER_ATTATCHMENT_* vals to enum class, StyleImageLayerAttachment.
af621dc793aaeb4a787748981cde5ca2bd0709b8: Bug 1455784 - Update StyleSource to use ArcUnion. r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Fri, 20 Apr 2018 16:28:33 -0700 - rev 415543
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1455784 - Update StyleSource to use ArcUnion. r=Manishearth MozReview-Commit-ID: AT4sud9goGV
5a517a7c8cf23646603c65da037cd6b979c84682: Bug 1455784 - ArcUnion. r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Fri, 20 Apr 2018 15:48:18 -0700 - rev 415542
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1455784 - ArcUnion. r=Manishearth MozReview-Commit-ID: Jxp2A7cj6CV
29905fcd0df973c678d12b82173b514115d6e075: servo: Merge #20603 - Run rustfmt on selectors, servo_arc, and style (from bholley:rustfmt_style); r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Tue, 10 Apr 2018 21:00:11 -0400 - rev 412685
Push 33816 by aciure@mozilla.com at Wed, 11 Apr 2018 08:57:12 +0000
servo: Merge #20603 - Run rustfmt on selectors, servo_arc, and style (from bholley:rustfmt_style); r=Manishearth Now that rustfmt is getting close to stable, and work on the style system has died down a bit, it seemed like an opportune time to auto-format the style crates. The first commit disables import reordering, since tidy and rustfmt don't currently agree on the correct ordering. The second commit does a bunch of manual fixups such that the output of rustfmt passes tidy. The third commit runs rustfmt on the three aforementioned crate. There are a few dozen warnings in the style crate about lines longer than 100 characters. It would be good to fix these, but I don't have time for that now. Source-Repo: https://github.com/servo/servo Source-Revision: 9a900ef019cd643bff961d7b20db6da69f3edb29
0182516b26d30a006319595eaf16ac3da6832a2f: servo: Merge #20598 - Four nondescript WebGL improvements (from servo:webgl); r=Manishearth
Anthony Ramine <n.oxyde@gmail.com> - Tue, 10 Apr 2018 04:28:40 -0400 - rev 412554
Push 33808 by rgurzau@mozilla.com at Tue, 10 Apr 2018 16:53:55 +0000
servo: Merge #20598 - Four nondescript WebGL improvements (from servo:webgl); r=Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: ce72e526566de70ed71684ebc39a531f59c92aa5
cdf8e9c396b9d8a3a1fb77d8c72dfde43e978c3e: servo: Merge #20247 - Stop unconditionally collecting traversal statistics in nightly builds (from bholley:fix_stat_collection); r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Thu, 08 Mar 2018 15:53:11 -0500 - rev 407245
Push 33597 by dluca@mozilla.com at Fri, 09 Mar 2018 09:59:33 +0000
servo: Merge #20247 - Stop unconditionally collecting traversal statistics in nightly builds (from bholley:fix_stat_collection); r=Manishearth The current code also makes us panic when DUMP_STYLE_STATISTICS=1 is set. :-( Source-Repo: https://github.com/servo/servo Source-Revision: 4c797dfb5239c5e9a4014e91ed121ef9cf641ad0
0ca4ef640c8b7d1a25e0dcaf80d0410b807b64d5: servo: Merge #20210 - style: Add a comment about the weird setup for justify-items (from emilio:justify-items-kinda-sucks); r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 06 Mar 2018 05:29:17 -0500 - rev 406723
Push 33576 by dluca@mozilla.com at Tue, 06 Mar 2018 18:34:13 +0000
servo: Merge #20210 - style: Add a comment about the weird setup for justify-items (from emilio:justify-items-kinda-sucks); r=Manishearth And derive ToCss while at it. Source-Repo: https://github.com/servo/servo Source-Revision: 226d9a5b0e69185b95c62e79b81044beba477654
06145412275073cce5e30b4f187f305d22e9dbff: servo: Merge #20135 - Clean up after some disk-space intensive builds (from servo:jdm-patch-13); r=Manishearth
Josh Matthews <josh@joshmatthews.net> - Tue, 27 Feb 2018 13:15:02 -0500 - rev 405598
Push 33525 by nerli@mozilla.com at Wed, 28 Feb 2018 10:11:03 +0000
servo: Merge #20135 - Clean up after some disk-space intensive builds (from servo:jdm-patch-13); r=Manishearth This should help the ongoing disk usage problems. Source-Repo: https://github.com/servo/servo Source-Revision: 068c1eb9fbff43bcf089c7c27101c72ef205b0c8
51d774eb06aea89b69127555fbea3008398ef376: Bug 1438811: Remove the remaining bits of the traversal telemetry stuff. r=manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 16 Feb 2018 13:14:13 +0100 - rev 404225
Push 33458 by dluca@mozilla.com at Sat, 17 Feb 2018 09:54:31 +0000
Bug 1438811: Remove the remaining bits of the traversal telemetry stuff. r=manishearth MozReview-Commit-ID: 2dA5usbGQRt
c1ea84b7d9b22460de822d7ef24c0e137bb02e43: servo: Merge #20011 - style: Tidy Stylist::compute_for_declarations (from emilio:cleanup-for-declarations-stuff); r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 10 Feb 2018 06:45:52 -0500 - rev 403284
Push 33420 by ebalazs@mozilla.com at Sat, 10 Feb 2018 21:46:17 +0000
servo: Merge #20011 - style: Tidy Stylist::compute_for_declarations (from emilio:cleanup-for-declarations-stuff); r=Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: 0098d519030f395f94f3f82fc04b93227fdff4ec
4e655361be5a1971300c15f58ec65c81f82ba826: Bug 1423840 (attempt 2) - Rewrite the prefs parser. r=glandium,Manishearth
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 01 Feb 2018 16:21:47 +1100 - rev 402042
Push 33360 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:06:21 +0000
Bug 1423840 (attempt 2) - Rewrite the prefs parser. r=glandium,Manishearth The prefs parser has two significant problems. - It doesn't separate tokenizing from parsing. - It is implemented as a loop around a big switch on a "current state" variable. As a result, it is hard to understand and modify, slower than it could be, and in obscure cases (involving comments and whitespace) it fails to parse what should be valid input. This patch replaces it with a recursive descent parser (albeit one without any recursion!) that has separate tokenization. The new parser is easier to understand and modify, more correct, and has better error messages. It doesn't do error recovery, but that would be much easier to add than in the old parser. The new parser also runs about 1.9x faster than the existing parser. (As measured by parsing greprefs.js's contents from memory 1000 times in succession, omitting the prefs hash table construction. If the table construction is included, it's about 1.6x faster.) The new parser is slightly stricter than the old parser in a few ways. - Disconcertingly, the old parser allowed arbitrary junk between prefs (including at the start and end of the prefs file) so long as that junk didn't include any of the following chars: '/', '#', 'u', 's', 'p'. I.e. lines like these: !foo@bar&pref("prefname", true); ticky_pref("prefname", true); // missing 's' at start User_pref("prefname", true); // should be 'u' at start would all be treated the same as this: pref("prefname", true); The new parser disallows such junk because it isn't necessary and seems like an unintentional botch by the old parser. - The old parser allowed character 0x1a (SUB) between tokens and treated it like '\n'. The new parser does not allow this character. SUB was used to indicate end-of-file (*not* end-of-line) in some old operating systems such as MS-DOS, but this doesn't seem necessary today. - The old parser tolerated (with a warning) invalid escape sequences within string literals -- such as "\q" (not a valid escape) and "\x1" and "\u12" (both of which have insufficient hex digits) -- accepting them literally. The new parser does not tolerate invalid escape sequences because it doesn't seem necessary and would complicate things. - The old parser tolerated character 0x00 (NUL) within string literals; this is dangerous because C++ code that manipulates string values with embedded NULs will almost certainly consider those chars as end-of-string markers. The new parser treats NUL chars as end-of-file, to avoid this danger and because it facilitates a significant optimization (described within the code). - The old parser allowed integer literals to overflow, silently wrapping them. The new parser treats integer overflow as a parse error. This seems better, and it caught existing overflows of places.database.lastMaintenance, in testing/profiles/prefs_general.js (bug 1424030) and testing/talos/talos/config.py (bug 1434813). The first of these changes meant that a couple of existing prefs with ";;" at the end had to be changed (done in the preceding patch). The minor increase in strictness shouldn't be a problem for default pref files such as greprefs.js within the application (which we can modify), nor for app-written prefs files such as prefs.js. It could affect user-written prefs files such as user.js; the experience above suggests that integer overflow and ";;" are the most likely problems in practice. In my opinion, the risk here is acceptable. The new parser also does a better job of tracking line numbers because it (a) treats "\r\n" sequences as a single end-of-line marker, and (a) pays attention to end-of-line sequences within string literals. Finally, the patch adds thorough tests of both valid and invalid syntax. MozReview-Commit-ID: JD3beOQl4AJ
e8b798a5205ad27d067b91210efb46df7ddab45d: Bug 1423840 - Rewrite the prefs parser. r=glandium,Manishearth
Nicholas Nethercote <nnethercote@mozilla.com> - Sun, 03 Dec 2017 00:26:36 +1100 - rev 402025
Push 33360 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:06:21 +0000
Bug 1423840 - Rewrite the prefs parser. r=glandium,Manishearth The prefs parser has two significant problems. - It doesn't separate tokenizing from parsing. - It is implemented as a loop around a big switch on a "current state" variable. As a result, it is hard to understand and modify, slower than it could be, and in obscure cases (involving comments and whitespace) it fails to parse what should be valid input. This patch replaces it with a recursive descent parser (albeit one without any recursion!) that has separate tokenization. The new parser is easier to understand and modify, more correct, and has better error messages. It doesn't do error recovery, but that would be much easier to add than in the old parser. The new parser also runs about 1.9x faster than the existing parser. (As measured by parsing greprefs.js's contents from memory 1000 times in succession, omitting the prefs hash table construction. If the table construction is included, it's about 1.6x faster.) The new parser is slightly stricter than the old parser in a few ways. - Disconcertingly, the old parser allowed arbitrary junk between prefs (including at the start and end of the prefs file) so long as that junk didn't include any of the following chars: '/', '#', 'u', 's', 'p'. I.e. lines like these: !foo@bar&pref("prefname", true); ticky_pref("prefname", true); // missing 's' at start User_pref("prefname", true); // should be 'u' at start would all be treated the same as this: pref("prefname", true); The new parser disallows such junk because it isn't necessary and seems like an unintentional botch by the old parser. - The old parser allowed character 0x1a (SUB) between tokens and treated it like '\n'. The new parser does not allow this character. SUB was used to indicate end-of-file (*not* end-of-line) in some old operating systems such as MS-DOS, but this doesn't seem necessary today. - The old parser tolerated (with a warning) invalid escape sequences within string literals -- such as "\q" (not a valid escape) and "\x1" and "\u12" (both of which have insufficient hex digits) -- accepting them literally. The new parser does not tolerate invalid escape sequences because it doesn't seem necessary and would complicate things. - The old parser tolerated character 0x00 (NUL) within string literals; this is dangerous because C++ code that manipulates string values with embedded NULs will almost certainly consider those chars as end-of-string markers. The new parser treats NUL chars as end-of-file, to avoid this danger and because it facilitates a significant optimization (described within the code). - The old parser allowed integer literals to overflow, silently wrapping them. The new parser treats integer overflow as a parse error. This seems better, and it caught an existing overflow in testing/profiles/prefs_general.js, for places.database.lastMaintenance (see bug 1424030). The first of these changes meant that a couple of existing prefs with ";;" at the end had to be changed (done in the preceding patch). The minor increase in strictness shouldn't be a problem for default pref files such as greprefs.js within the application (which we can modify), nor for app-written prefs files such as prefs.js. It could affect user-written prefs files such as user.js; the experience above suggests that ";;" is the most likely problem in practice. In my opinion, the risk here is acceptable. The new parser also does a better job of tracking line numbers because it (a) treats "\r\n" sequences as a single end-of-line marker, and (a) pays attention to end-of-line sequences within string literals. Finally, the patch adds thorough tests of both valid and invalid syntax. MozReview-Commit-ID: 8EYWH7KxGG * * * [mq]: win-fix MozReview-Commit-ID: 91Bxjfghqfw
593fe6b692c74531899bf721c1e73868f56a6c8a: servo: Merge #19912 - style: Temporarily use OrderMap on Gecko (from emilio:ordermap); r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 31 Jan 2018 21:33:36 -0600 - rev 402012
Push 33359 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:01:45 +0000
servo: Merge #19912 - style: Temporarily use OrderMap on Gecko (from emilio:ordermap); r=Manishearth This will allow us to discard std hash map as a source of crashes. Source-Repo: https://github.com/servo/servo Source-Revision: e6d9c251d1b9770aa520bf358b79d906a00d71bb
bc141b951a1b1aac8fefe67cb5488091cf5de43a: servo: Merge #19864 - Make some callback-related code unsafe (from nox:callbacks); r=Manishearth
Anthony Ramine <n.oxyde@gmail.com> - Thu, 25 Jan 2018 16:21:10 -0600 - rev 400886
Push 33320 by dluca@mozilla.com at Fri, 26 Jan 2018 01:54:08 +0000
servo: Merge #19864 - Make some callback-related code unsafe (from nox:callbacks); r=Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: e9ab91d257a983a7c19cb5fada21a0359cfae95d
a984a3218ffe8ebaad26bff890bc25f00612d859: Bug 1431031: Tests for calc() on font-size on various situations. r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Jan 2018 17:20:20 +0100 - rev 399918
Push 33281 by nerli@mozilla.com at Fri, 19 Jan 2018 10:08:27 +0000
Bug 1431031: Tests for calc() on font-size on various situations. r=Manishearth It makes no sense to pass a custom base size of zero in presence of rem, ex, or ch units. MozReview-Commit-ID: 7ZZwRzQKREX
110b50e49ca4064fbe78deaf0bf9fd72a45e45af: servo: Merge #19807 - style: Make the Gecko font-size calc() code do what it means to do (from emilio:calc-font-size); r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 18 Jan 2018 09:36:51 -0600 - rev 399824
Push 33278 by aciure@mozilla.com at Thu, 18 Jan 2018 21:46:52 +0000
servo: Merge #19807 - style: Make the Gecko font-size calc() code do what it means to do (from emilio:calc-font-size); r=Manishearth It makes no sense to pass a custom base size of zero in presence of rem, ex, or ch units. Bug: 1431031 Reviewed-by: Manishearth MozReview-Commit-ID: 7ZZwRzQKREX Source-Repo: https://github.com/servo/servo Source-Revision: 671b69c0b77f9a4bd0c098cb2a2f73c95dacb954
391fd88ff3e51cedfbc65b2b0345d48ab53cad06: servo: Merge #19665 - style_derive: Support parse-time aliases (from emilio:derive-parse-alias); r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 31 Dec 2017 03:46:22 -0600 - rev 397542
Push 33175 by csabou@mozilla.com at Tue, 02 Jan 2018 09:35:28 +0000
servo: Merge #19665 - style_derive: Support parse-time aliases (from emilio:derive-parse-alias); r=Manishearth This will allow #19659 to use derive on display using: #[parse(aliases = "-webkit-flex")] Flex, #[parse(aliases = "-webkit-inline-flex")] InlineFlex, And such. Source-Repo: https://github.com/servo/servo Source-Revision: 4ba795081cd1efa42ce03c996d574cfe96f68ece
2941b6b2bcece74cce8bfbcad359ad7538a278a3: servo: Merge #19576 - style: Move text-align outside of the mako file (from canaltinova:text-align); r=Manishearth,emilio
Nazım Can Altınova <canaltinova@gmail.com> - Mon, 18 Dec 2017 12:12:52 -0600 - rev 396744
Push 33111 by dluca@mozilla.com at Tue, 19 Dec 2017 10:06:26 +0000
servo: Merge #19576 - style: Move text-align outside of the mako file (from canaltinova:text-align); r=Manishearth,emilio I will need this refactoring before my next job. I didn't actually fix the FIXME's along the way. My other PR probably will cover these. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors Source-Repo: https://github.com/servo/servo Source-Revision: a9c17970c19a993920ce1ba2ff9faebd033c52b4
c4cf8f4683114454167cc8db9fc352f0b634306b: servo: Merge #19578 - Allow deriving Parse on keywords (from emilio:parse-keyword); r=Manishearth,canaltinova
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Dec 2017 14:55:49 -0600 - rev 396577
Push 33098 by ncsoregi@mozilla.com at Sat, 16 Dec 2017 09:35:50 +0000
servo: Merge #19578 - Allow deriving Parse on keywords (from emilio:parse-keyword); r=Manishearth,canaltinova This makes patches like #19576 much easier. Source-Repo: https://github.com/servo/servo Source-Revision: e631d167bf28676e45e37f418b4282fcfba98c1e
06852d04e07028e2e09ea389ad97eba7dd8047d8: Bug 1422641: Inline Gecko_GetSMILOverrideDeclarationBlock. r=Manishearth,xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 04 Dec 2017 01:05:25 +0100 - rev 395033
Push 33029 by csabou@mozilla.com at Tue, 05 Dec 2017 22:05:52 +0000
Bug 1422641: Inline Gecko_GetSMILOverrideDeclarationBlock. r=Manishearth,xidorn MozReview-Commit-ID: E8cM7zRZHn1
cee16defbc8e99ed887b120de00a319b758a4c72: servo: Merge #19493 - style: Some stylo-chrome perf tweaks (from emilio:chrome-perf); r=xidorn,Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Dec 2017 06:05:25 -0600 - rev 395029
Push 33029 by csabou@mozilla.com at Tue, 05 Dec 2017 22:05:52 +0000
servo: Merge #19493 - style: Some stylo-chrome perf tweaks (from emilio:chrome-perf); r=xidorn,Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: 8f30880d362ef54a2c6881c4927b96303ff763ef
78d7ac2ce842c4c889ed781517f66dbcc9698e4f: Bug 1408308: Integrate Servo SourceSizeList in ResponsiveImageSelector. r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 13 Nov 2017 06:44:12 +0100 - rev 391523
Push 32892 by ncsoregi@mozilla.com at Mon, 13 Nov 2017 22:56:04 +0000
Bug 1408308: Integrate Servo SourceSizeList in ResponsiveImageSelector. r=Manishearth MozReview-Commit-ID: DMVfE56DyYm
b59ffea83e0abe345853fa76dba4bca551464858: Bug 1408308: Integrate Servo SourceSizeList in ResponsiveImageSelector. r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 09 Nov 2017 15:18:08 +0100 - rev 391502
Push 32892 by ncsoregi@mozilla.com at Mon, 13 Nov 2017 22:56:04 +0000
Bug 1408308: Integrate Servo SourceSizeList in ResponsiveImageSelector. r=Manishearth This needs to dumb down the parsing in order to match what we do in Gecko and pass more tests. The remaining tests are just because of calc() in media queries and "or" media expressions. MozReview-Commit-ID: CXGdYVbojBL
6f321c024fc4e82363e9b1215891a37d8abde5de: servo: Merge #19197 - stylo: Integrate Servo SourceSizeList in ResponsiveImageSelector (from emilio:source-size-list-integration); r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 12 Nov 2017 21:01:34 -0600 - rev 391501
Push 32892 by ncsoregi@mozilla.com at Mon, 13 Nov 2017 22:56:04 +0000
servo: Merge #19197 - stylo: Integrate Servo SourceSizeList in ResponsiveImageSelector (from emilio:source-size-list-integration); r=Manishearth Bug: 1408308 Reviewed-by: Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: 5d3a90ecce766f3dfba35e08101a74a5d73dba79
6bed71583aa9a40f73db1d8cf7d386ca793c08f5: Bug 1396057: Change tests of calc in media-queries so that the root element style has been resolved first. r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 10 Nov 2017 16:48:44 +0100 - rev 391466
Push 32887 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 09:51:23 +0000
Bug 1396057: Change tests of calc in media-queries so that the root element style has been resolved first. r=Manishearth This modify the tests so that the media query evaluation they're testing happens after style resolution, which would've caught a bug in rem unit evaluation inside media queries in stylo. MozReview-Commit-ID: ByaR4ZA995l
b7ebbb451e5a493673f89edb06307caefed0833a: servo: Merge #19194 - stylo: Bring back support for calc() in media-queries (from emilio:media-query-calc); r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 12 Nov 2017 20:06:12 -0600 - rev 391465
Push 32887 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 09:51:23 +0000
servo: Merge #19194 - stylo: Bring back support for calc() in media-queries (from emilio:media-query-calc); r=Manishearth Bug: 1396057 Reviewed-by: Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: 4970b5d1544fe8f33287b01540e972a639baa689
26a70922efd74a004f2f2c5f0d1e2d35481ae554: servo: Merge #16946 - Add intermittent failure reporting to filter-intermittents (from jdm:report); r=Manishearth
Josh Matthews <josh@joshmatthews.net> - Tue, 07 Nov 2017 13:05:12 -0600 - rev 390597
Push 32838 by nbeleuzu@mozilla.com at Wed, 08 Nov 2017 10:46:55 +0000
servo: Merge #16946 - Add intermittent failure reporting to filter-intermittents (from jdm:report); r=Manishearth We need to address https://github.com/servo/saltfs/issues/671 before this can be enabled by default on the builders, but I got the pieces working locally. This collects relevant information about each recorded intermittent failure encountered during a test run and posts them to a webapp which stores them in a database for later investigation. This will allow us to track over time which intermittent test failures are the most frequent, as well as whether they only happen on a particular builder or operating system. Source-Repo: https://github.com/servo/servo Source-Revision: 693c3dcfb29ecc2aa4610aabc68ce7381bfd5d87
95e8712dbf3baa0bb59d676aec75df3fbccd6240: servo: Merge #19074 - style: Avoid double-applying text-zoom for keywords (from emilio:font-size-woes); r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 Oct 2017 15:08:24 -0500 - rev 389379
Push 32786 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:10:44 +0000
servo: Merge #19074 - style: Avoid double-applying text-zoom for keywords (from emilio:font-size-woes); r=Manishearth Bug: 1412743 Reviewed-by: Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: c882266c8915b9f424cc4efbc860a9e417bf1326
da6b544b9891b2998db542fc881e5a9e133dd554: Bug 1412868: Remove Gecko_GetLookAndFeelSystemColor from the static analysis whitelist. r=manishearth
Brad Werth <bwerth@mozilla.com> - Mon, 30 Oct 2017 08:47:01 -0700 - rev 389069
Push 32777 by archaeopteryx@coole-files.de at Mon, 30 Oct 2017 22:44:45 +0000
Bug 1412868: Remove Gecko_GetLookAndFeelSystemColor from the static analysis whitelist. r=manishearth MozReview-Commit-ID: 7gf3CZM3ypv
38f363ae6e486df376200b402902b380c1934820: servo: Merge #19055 - Add support for -moz-window-opacity to stylo (from upsuper:window-opacity); r=Manishearth
Xidorn Quan <me@upsuper.org> - Mon, 30 Oct 2017 00:42:45 -0500 - rev 388997
Push 32777 by archaeopteryx@coole-files.de at Mon, 30 Oct 2017 22:44:45 +0000
servo: Merge #19055 - Add support for -moz-window-opacity to stylo (from upsuper:window-opacity); r=Manishearth Fixes [bug 1374177](https://bugzilla.mozilla.org/show_bug.cgi?id=1374177). Source-Repo: https://github.com/servo/servo Source-Revision: 17bfe5c12013a47c09e0198d029f3ded2ccbc42c
8b8017ae9cc103830e28e9209a063756059b4a18: Bug 1403690 Part 1: Adjust heap write analysis whitelist to include Gecko_GetLookAndFeelSystemColor. r=manishearth
Brad Werth <bwerth@mozilla.com> - Mon, 02 Oct 2017 15:00:33 -0700 - rev 388780
Push 32760 by archaeopteryx@coole-files.de at Sat, 28 Oct 2017 08:30:40 +0000
Bug 1403690 Part 1: Adjust heap write analysis whitelist to include Gecko_GetLookAndFeelSystemColor. r=manishearth MozReview-Commit-ID: 1PjN0ZTpw10
34accef71609223bba5738d726082d8b79525389: Bug 1403690 Part 1: Adjust heap write analysis whitelist to include Gecko_GetLookAndFeelSystemColor. r=manishearth
Brad Werth <bwerth@mozilla.com> - Mon, 02 Oct 2017 15:00:33 -0700 - rev 387695
Push 32734 by archaeopteryx@coole-files.de at Tue, 24 Oct 2017 09:50:45 +0000
Bug 1403690 Part 1: Adjust heap write analysis whitelist to include Gecko_GetLookAndFeelSystemColor. r=manishearth MozReview-Commit-ID: 1PjN0ZTpw10
5e820fb50295a7e7237bd48e05a606dd908a4707: Bug 1403690 Part 1: Adjust heap write analysis whitelist to include Gecko_GetLookAndFeelSystemColor. r=manishearth
Brad Werth <bwerth@mozilla.com> - Mon, 02 Oct 2017 15:00:33 -0700 - rev 387677
Push 32734 by archaeopteryx@coole-files.de at Tue, 24 Oct 2017 09:50:45 +0000
Bug 1403690 Part 1: Adjust heap write analysis whitelist to include Gecko_GetLookAndFeelSystemColor. r=manishearth MozReview-Commit-ID: 1PjN0ZTpw10
2dce277776e93197e04738a54f4fdadba067f38d: Bug 1409444 - Update rand to 0.3.17. r=manishearth
Xidorn Quan <me@upsuper.org> - Mon, 23 Oct 2017 15:52:44 +1100 - rev 387611
Push 32732 by archaeopteryx@coole-files.de at Mon, 23 Oct 2017 21:48:58 +0000
Bug 1409444 - Update rand to 0.3.17. r=manishearth MozReview-Commit-ID: DjCEQV9t2hi
1fe7b56a29c6a2cac69fc986c5fb4b99a92d7781: Bug 1409277 - Ignore non-URLs for background pres attr. r=manishearth
J. Ryan Stinnett <jryans@gmail.com> - Fri, 20 Oct 2017 15:24:51 -0500 - rev 387502
Push 32723 by archaeopteryx@coole-files.de at Sun, 22 Oct 2017 09:33:30 +0000
Bug 1409277 - Ignore non-URLs for background pres attr. r=manishearth Check background attribute values for the same types (URL, image) in Stylo mode as we do in Gecko mode. In particular, this ignores the edge case of the empty attribute, which comes through as a string value type, and leads Stylo to trigger a load of the page itself as the background image (since the empty URL is interpreted as relative to the page). MozReview-Commit-ID: CUhq5nS8kVw
27bc43d5d11ced40c6014d9055825993935d185e: servo: Merge #18924 - Fix commonmark Markdown warnings in docs, part 1 (from mbrubeck:doc); r=Manishearth
Matt Brubeck <mbrubeck@limpet.net> - Tue, 17 Oct 2017 16:04:10 -0500 - rev 386771
Push 32701 by archaeopteryx@coole-files.de at Wed, 18 Oct 2017 09:44:15 +0000
servo: Merge #18924 - Fix commonmark Markdown warnings in docs, part 1 (from mbrubeck:doc); r=Manishearth Fixes warnings from rust-lang/rust#44229 when `--enable-commonmark` is passed to rustdoc. This is mostly a global find-and-replace for bare URIs on lines by themselves in doc comments. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they are doc formatting changes only Source-Repo: https://github.com/servo/servo Source-Revision: 0e62a5829b7c29ae2667a21a439aff1e89201bf3
50557e43a2086a7ac6950edb15c7ba53bb4b3bd8: servo: Merge #18861 - Some fixes to diagnostic hashmap (from upsuper:diagnose-fix); r=Manishearth
Xidorn Quan <me@upsuper.org> - Fri, 13 Oct 2017 02:11:55 -0500 - rev 386078
Push 32675 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:36:21 +0000
servo: Merge #18861 - Some fixes to diagnostic hashmap (from upsuper:diagnose-fix); r=Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: ec00c660f0a1892033ca89a31d393427d3c6a2d3
28a041a33fece4b42d3984cca4698334d656c99e: servo: Merge #18829 - Verify in DiagnosticHashMap::drop (from bholley:verify_in_drop); r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Wed, 11 Oct 2017 13:53:01 -0500 - rev 385707
Push 32664 by archaeopteryx@coole-files.de at Thu, 12 Oct 2017 09:34:55 +0000
servo: Merge #18829 - Verify in DiagnosticHashMap::drop (from bholley:verify_in_drop); r=Manishearth This will let us reason better about the drop_in_place crashes. Source-Repo: https://github.com/servo/servo Source-Revision: 882b22b6068826f49e8279910784db8b3ebb61f0
a7a0a2f1c89d38fb92f9f77a00b8196d0b608c28: servo: Merge #18822 - More hashmap diagnostics (from bholley:more_hashmap_diagnostics); r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Tue, 10 Oct 2017 16:17:20 -0500 - rev 385410
Push 32655 by archaeopteryx@coole-files.de at Wed, 11 Oct 2017 09:38:36 +0000
servo: Merge #18822 - More hashmap diagnostics (from bholley:more_hashmap_diagnostics); r=Manishearth https://bugzilla.mozilla.org/show_bug.cgi?id=1407080 Source-Repo: https://github.com/servo/servo Source-Revision: be5839fae6444c5134faa67e43c44d4d277a778a
6a17fec908553eecc3b928cbf6812b3cecae66ca: Bug 1407080 - Add an API to annotate crash reports from stylo. r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Tue, 10 Oct 2017 13:30:57 -0700 - rev 385394
Push 32655 by archaeopteryx@coole-files.de at Wed, 11 Oct 2017 09:38:36 +0000
Bug 1407080 - Add an API to annotate crash reports from stylo. r=Manishearth MozReview-Commit-ID: KuD4SbVrdYH
1636e8da864cf9ca99c11ff0d3aabad20d43b045: servo: Merge #18789 - Assert more things in hashtables (from bholley:more_hashmap_asserts); r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Mon, 09 Oct 2017 02:04:17 -0500 - rev 385087
Push 32646 by archaeopteryx@coole-files.de at Mon, 09 Oct 2017 21:47:29 +0000
servo: Merge #18789 - Assert more things in hashtables (from bholley:more_hashmap_asserts); r=Manishearth https://bugzilla.mozilla.org/show_bug.cgi?id=1406815 Source-Repo: https://github.com/servo/servo Source-Revision: 49376c9e544c6b3f0d340dff0450ad3267219428
4a709213909809044588f6cf679d624891833d51: servo: Merge #18779 - DiagnosticHashMap (from bholley:canary_and_journal); r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Sat, 07 Oct 2017 14:55:03 -0500 - rev 385015
Push 32639 by archaeopteryx@coole-files.de at Sun, 08 Oct 2017 09:43:04 +0000
servo: Merge #18779 - DiagnosticHashMap (from bholley:canary_and_journal); r=Manishearth https://bugzilla.mozilla.org/show_bug.cgi?id=1405879 Source-Repo: https://github.com/servo/servo Source-Revision: 3f4afbafab7c0a8bfcf596ea444269bb01af3955
7b16f542139d0d12722cb8dd51568ddedf81bf1e: Bug 1406220 - Add canary and journaling. r=Manishearth,r=dmajor
Bobby Holley <bobbyholley@gmail.com> - Thu, 05 Oct 2017 14:51:33 -0700 - rev 385013
Push 32639 by archaeopteryx@coole-files.de at Sun, 08 Oct 2017 09:43:04 +0000
Bug 1406220 - Add canary and journaling. r=Manishearth,r=dmajor MozReview-Commit-ID: 582ZiTmcvgs
2cd9b59aef83a067162ac31177fcdfc1175490b4: servo: Merge #18751 - Poison hashtable buffers (from bholley:poison_hashtable); r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Wed, 04 Oct 2017 23:54:56 -0500 - rev 384776
Push 32635 by archaeopteryx@coole-files.de at Sat, 07 Oct 2017 08:38:45 +0000
servo: Merge #18751 - Poison hashtable buffers (from bholley:poison_hashtable); r=Manishearth This gives us extra defense in depth. Source-Repo: https://github.com/servo/servo Source-Revision: 2bbc458c5b2ad44d008cfa57415fe41d1a7ada5e