searching for reviewer(KiChjang)
c3a67f9780c223aea846db8771018272e5072b3e: servo: Merge #19865 - Use more specific assertions for http tests (from servo:jdm-patch-6); r=KiChjang
Josh Matthews <josh@joshmatthews.net> - Thu, 25 Jan 2018 17:11:42 -0600 - rev 400898
Push 33320 by dluca@mozilla.com at Fri, 26 Jan 2018 01:54:08 +0000
servo: Merge #19865 - Use more specific assertions for http tests (from servo:jdm-patch-6); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: fc3b1789318afc8f10e160d40b592234fbdb5cf4
70f34fc856152bba268f2078c7d096d692abb7c5: servo: Merge #19822 - style: More tiny selector-matching cleanup (from emilio:less-match-public); r=KiChjang
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Jan 2018 23:05:18 -0600 - rev 400084
Push 33291 by btara@mozilla.com at Sun, 21 Jan 2018 09:49:24 +0000
servo: Merge #19822 - style: More tiny selector-matching cleanup (from emilio:less-match-public); r=KiChjang See each commit individually. Source-Repo: https://github.com/servo/servo Source-Revision: 6fc71a7644bd7afcccf83f67cfdaf01897e1a3bc
2028080562ac6e5594f4900ca9bb554e7b404421: servo: Merge #19761 - implement range input sanitization (from tigercosmos:m1); r=KiChjang
tigercosmos <phy.tiger@gmail.com> - Wed, 17 Jan 2018 04:30:58 -0600 - rev 399621
Push 33271 by toros@mozilla.com at Wed, 17 Jan 2018 21:46:52 +0000
servo: Merge #19761 - implement range input sanitization (from tigercosmos:m1); r=KiChjang <!-- Please describe your changes on the following line: --> implement range input sanitation. Since there is no `min`, `max`, `step` implementation currently, this should be continued in the future. r? KiChjang --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19172 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 4f099876116c91173a104e32dfcfc32a6d644155
ee41bdf184488801449e71d15dcd400ee7f2a752: servo: Merge #19730 - number input type validations (from NLincoln:19172-number-input-type-validations); r=KiChjang
Nathan <nlincoln@intellifarms.com> - Tue, 09 Jan 2018 22:15:12 -0600 - rev 398547
Push 33224 by dluca@mozilla.com at Wed, 10 Jan 2018 21:59:28 +0000
servo: Merge #19730 - number input type validations (from NLincoln:19172-number-input-type-validations); r=KiChjang I used rust's builtin float parser to implement this. Rust's parser is more permissive than what browsers support (in this case), so I added some code to handle those edge cases. This passes all the prewritten test cases locally, but I fell asleep last night before updating the manifests :sweat_smile: --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes are part of #19172 <!-- Either: --> - [X] There are tests for these changes Source-Repo: https://github.com/servo/servo Source-Revision: afe298b53d91226d61a2ca7955b9c1d3d233a194
1101506cfa8a55c712d999ad1afeb367e5f8f941: servo: Merge #19602 - implement valid DatetimeLocal input (from tigercosmos:r1); r=KiChjang
tigercosmos <phy.tiger@gmail.com> - Sun, 07 Jan 2018 05:10:47 -0600 - rev 398154
Push 33209 by dluca@mozilla.com at Mon, 08 Jan 2018 09:54:02 +0000
servo: Merge #19602 - implement valid DatetimeLocal input (from tigercosmos:r1); r=KiChjang <!-- Please describe your changes on the following line: --> implement valid Date time Local input part of #19172 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19587 fix #19603(github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7f36b59762864731279fb249dd50faca5078b751
834cde6951eed5b427245699f63219a073d1724d: servo: Merge #19628 - add note on readme (from tigercosmos:x3); r=KiChjang
tigercosmos <phy.tiger@gmail.com> - Mon, 25 Dec 2017 15:08:39 -0600 - rev 397446
Push 33152 by aiakab@mozilla.com at Tue, 26 Dec 2017 21:26:53 +0000
servo: Merge #19628 - add note on readme (from tigercosmos:x3); r=KiChjang <!-- Please describe your changes on the following line: --> Add note about how to use command while running servo origin `readme` is not clear. I think ./mach run [url] [arguments] is more clear than ./mach run [url] --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 97bba5fdc16b4902df4280ec27682a0fa160bc41
905ff56ee2e6745e5e5580eb490e65fa1ecbe91f: servo: Merge #19615 - style: Remove needless and bogus bounds-check (from emilio:useless-check); r=KiChjang
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 20 Dec 2017 21:23:29 -0600 - rev 397078
Push 33123 by ncsoregi@mozilla.com at Thu, 21 Dec 2017 10:00:47 +0000
servo: Merge #19615 - style: Remove needless and bogus bounds-check (from emilio:useless-check); r=KiChjang The check should read index >= self.len(). But it doesn't matter anyway since we're covered by Rust's bound checks by default anyway. Source-Repo: https://github.com/servo/servo Source-Revision: 6524d2281453da816c532dc83a522331df8ce9c0
e1d9d7b0ac15977706d17821c542f274fd2e026f: servo: Merge #19559 - implement valid week string (from tigercosmos:t1); r=KiChjang
tigercosmos <phy.tiger@gmail.com> - Sun, 17 Dec 2017 03:50:33 -0600 - rev 396645
Push 33104 by nerli@mozilla.com at Sun, 17 Dec 2017 21:43:51 +0000
servo: Merge #19559 - implement valid week string (from tigercosmos:t1); r=KiChjang <!-- Please describe your changes on the following line: --> implement valid week string part of #19172 r? @KiChjang --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 8798e498892524ebb42ab8d7613c68033fdd1db8
9d5863c947f9fa0a3dd6b2a890172152a6cbebff: servo: Merge #19585 - remove unused `self` in canvas_paint_thread (from tigercosmos:b1); r=KiChjang
tigercosmos <phy.tiger@gmail.com> - Sun, 17 Dec 2017 02:47:09 -0600 - rev 396644
Push 33104 by nerli@mozilla.com at Sun, 17 Dec 2017 21:43:51 +0000
servo: Merge #19585 - remove unused `self` in canvas_paint_thread (from tigercosmos:b1); r=KiChjang <!-- Please describe your changes on the following line: --> ``` Compiling canvas v0.0.1 (file:///Users/tigercosmos/servo/components/canvas) warning: unused import: `self` --> components/canvas/canvas_paint_thread.rs:14:24 | 14 | use ipc_channel::ipc::{self, IpcSender, IpcReceiver}; | ^^^^ | = note: #[warn(unused_imports)] on by default ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: f8c09abece5c4952d786ae843900b0135468f7c5
6d431fb67f3a76e20da22d11782d7fc9a65b1a75: servo: Merge #19461 - Handle cases where selection API doesn't apply (from jonleighton:issue-19171-4); r=KiChjang
Jon Leighton <j@jonathanleighton.com> - Sun, 10 Dec 2017 18:37:58 -0600 - rev 396001
Push 33067 by toros@mozilla.com at Mon, 11 Dec 2017 09:54:39 +0000
servo: Merge #19461 - Handle cases where selection API doesn't apply (from jonleighton:issue-19171-4); r=KiChjang The selection API only applies to certain <input> types: https://html.spec.whatwg.org/multipage/#do-not-apply This commit ensures that we handle that correctly. Some notes: 1. TextControl::set_dom_selection_direction now calls set_selection_range(), which means that setting selectionDirection will now fire a selection event, as it should per the spec. 2. There is a test for the firing of the select event in tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/select-event.html, however the test did not run due to this syntax error: (pid:26017) "ERROR:script::dom::bindings::error: Error at http://web-platform.test:8000/html/semantics/forms/textfieldselection/select-event.html:50:11 missing = in const declaration" This happens due to the us of the "for (const foo of ...)" construct. Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of this should actually work, so it's somewhat unsatisfying to have to change the test. 3. I removed tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-textarea.html because it doesn't seem to add any extra value - the selection API always applies to textarea elements, and the API is tested elsewhere. 4. If an `<input>`'s type is unset, it defaults to a text, and the selection API applies. Also, if an `<input>`'s type is set to an invalid value, it defaults to a text too. This second case doesn't currently work, and I'll need to do more restructuring of the code in a future commit. See discussion with nox in IRC: https://mozilla.logbot.info/servo/20171201#c13946454-c13946594 Source-Repo: https://github.com/servo/servo Source-Revision: db41cc00be93523114092125859534b107ec772a
acc06e9d007f7dd879729a5daff6a4bb087315b4: servo: Merge #19518 - style: Remove useless type parameter (from emilio:useless-code-is-useless); r=KiChjang
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Dec 2017 20:32:11 -0600 - rev 395620
Push 33048 by csabou@mozilla.com at Fri, 08 Dec 2017 09:54:43 +0000
servo: Merge #19518 - style: Remove useless type parameter (from emilio:useless-code-is-useless); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: 22472b4db4564f7bc274eb01447e4f04fd7e7205
ce32d481dd08abaadfbe2712aef9b828d5ec7eb2: servo: Merge #19385 - implement "Date type inputs", "Month type inputs" (from tigercosmos:b1); r=KiChjang
tigercosmos <phy.tiger@gmail.com> - Mon, 04 Dec 2017 19:58:08 -0600 - rev 394951
Push 33025 by shindli@mozilla.com at Tue, 05 Dec 2017 09:57:50 +0000
servo: Merge #19385 - implement "Date type inputs", "Month type inputs" (from tigercosmos:b1); r=KiChjang <!-- Please describe your changes on the following line: --> implement "Date type inputs", "Month type inputs" --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] `./mach test-unit` does not report any errors Source-Repo: https://github.com/servo/servo Source-Revision: 68cefb1b0031c05c7f2f4aa433eb1a21e7863f8f
950dc8896010c8465d5a9075f015d12bf8880b9d: servo: Merge #19379 - Implemented sanitize_value for time input (from SWW13:htmlinput_sanitize_time); r=KiChjang
Simon Wörner <git@simon-woerner.de> - Mon, 04 Dec 2017 15:44:58 -0600 - rev 394936
Push 33025 by shindli@mozilla.com at Tue, 05 Dec 2017 09:57:50 +0000
servo: Merge #19379 - Implemented sanitize_value for time input (from SWW13:htmlinput_sanitize_time); r=KiChjang Implemented value sanitization for `<input type=time/>`. The value has the be valid time string (https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#valid-time-string) or set to empty string. --- The following test results look expected to me, but I'm not sure: ``` ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/type-change-state.html: │ FAIL [expected PASS] change state from time to text │ → assert_equals: input.value should be foobar after change of state expected " foobar " but got "" │ FAIL [expected PASS] change state from time to search │ → assert_equals: input.value should be foobar after change of state expected " foobar " but got "" │ FAIL [expected PASS] change state from time to tel │ → assert_equals: input.value should be foobar after change of state expected " foobar " but got "" │ FAIL [expected PASS] change state from time to url │ → assert_equals: input.value should be foobar after change of state expected "foobar" but got "" │ FAIL [expected PASS] change state from time to password │ → assert_equals: input.value should be foobar after change of state expected " foobar " but got "" │ │ @http://web-platform.test:8000/html/semantics/forms/the-input-element/type-change-state.html:53:15 │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20 │ test@http://web-platform.test:8000/resources/testharness.js:511:9 └ @http://web-platform.test:8000/html/semantics/forms/the-input-element/type-change-state.html:37:9 ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/type-change-state.html: │ FAIL [expected PASS] change state from color to time │ → assert_equals: input.value should be #000000 after change of state expected "#000000" but got "" │ │ @http://web-platform.test:8000/html/semantics/forms/the-input-element/type-change-state.html:55:15 │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20 │ test@http://web-platform.test:8000/resources/testharness.js:511:9 └ @http://web-platform.test:8000/html/semantics/forms/the-input-element/type-change-state.html:37:9 ``` All other tests do now `PASS` instead of `FAIL`. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix *part of* #19172 - [x] There are tests for these changes - [x] All tests `PASS` Source-Repo: https://github.com/servo/servo Source-Revision: eed3adc957fb3c52de24c560112533963572f525
f9be9bd0f9e255bcb698654505ce42a10511e5d9: servo: Merge #19353 - Add clang packages for non-debian linuxes (from servo:jdm-patch-7); r=KiChjang
Josh Matthews <josh@joshmatthews.net> - Mon, 27 Nov 2017 13:48:51 -0500 - rev 393808
Push 32982 by ebalazs@mozilla.com at Mon, 27 Nov 2017 21:55:57 +0000
servo: Merge #19353 - Add clang packages for non-debian linuxes (from servo:jdm-patch-7); r=KiChjang Per https://github.com/servo/gecko-media/issues/71#issuecomment-346606660. Source-Repo: https://github.com/servo/servo Source-Revision: 10e5ae2c65575aeea4681a89da8ba6aead23af54
1703d6692c1389d170859438ab58c54b84b65b82: servo: Merge #19358 - Move selection to end when textarea value is assigned (from jonleighton:issue-19171-3); r=KiChjang
Jon Leighton <j@jonathanleighton.com> - Sat, 25 Nov 2017 16:10:41 -0600 - rev 393708
Push 32975 by toros@mozilla.com at Sun, 26 Nov 2017 10:03:20 +0000
servo: Merge #19358 - Move selection to end when textarea value is assigned (from jonleighton:issue-19171-3); r=KiChjang Issue #19171 Source-Repo: https://github.com/servo/servo Source-Revision: 3f0ccd0fef1ad108a22c731e399aa815d0af5441
118d1c52c6b8159b8c4e46fdb020b761a9250e14: servo: Merge #19364 - Update cookie to 0.10 (from nox:cookie); r=KiChjang
Anthony Ramine <n.oxyde@gmail.com> - Fri, 24 Nov 2017 03:50:37 -0600 - rev 393577
Push 32966 by aciure@mozilla.com at Fri, 24 Nov 2017 22:02:06 +0000
servo: Merge #19364 - Update cookie to 0.10 (from nox:cookie); r=KiChjang Except in webdriver, which source is in m-c. Source-Repo: https://github.com/servo/servo Source-Revision: 56b5a4d8cb3a6feecf4df45f9b54f87fa0cb48cb
4b371af47c94ed1c272ce16c0204c1b07f24f093: servo: Merge #19330 - Add a sanitize_value implementation for the color input (from Eijebong:sanitize_color); r=KiChjang
Bastien Orivel <eijebong@bananium.fr> - Wed, 22 Nov 2017 19:42:58 -0600 - rev 393245
Push 32955 by csabou@mozilla.com at Thu, 23 Nov 2017 09:42:21 +0000
servo: Merge #19330 - Add a sanitize_value implementation for the color input (from Eijebong:sanitize_color); r=KiChjang I had to change the test a little bit to avoid some failures due to color and text both having a sanitizedValue which was making the test use the first assertion instead of the second one in some cases. The sanitize_value implementation is pretty simple, we iterate over the content and checks that the content is 7 characters long, that the first character is a `#` and then that all the following characters are hexadecimal. If all those requirements are met, we lowercase the content, otherwise we put `#000000` in it. Source-Repo: https://github.com/servo/servo Source-Revision: 72e7f6095e56ca6230651fc73bced8b460487569
2976031cb5fc916e858c879aea814f330209dd9d: servo: Merge #19328 - Remove cancellation map and ResourceId from the net* components (from Eijebong:remove_old_cancellation_code); r=KiChjang
Bastien Orivel <eijebong@bananium.fr> - Tue, 21 Nov 2017 21:01:35 -0600 - rev 393026
Push 32947 by aciure@mozilla.com at Wed, 22 Nov 2017 09:57:59 +0000
servo: Merge #19328 - Remove cancellation map and ResourceId from the net* components (from Eijebong:remove_old_cancellation_code); r=KiChjang Fixes #19327 Source-Repo: https://github.com/servo/servo Source-Revision: 78fb3c206d30da8e7b16ea941268b733b21059ed
04e148f1aa7ba5725c27d954fa1cdf6e181f59e9: servo: Merge #19310 - Update clap to 2.27.1 (from servo:bumps); r=KiChjang
Anthony Ramine <n.oxyde@gmail.com> - Mon, 20 Nov 2017 22:04:35 -0600 - rev 392800
Push 32941 by toros@mozilla.com at Tue, 21 Nov 2017 09:53:04 +0000
servo: Merge #19310 - Update clap to 2.27.1 (from servo:bumps); r=KiChjang This brings bitflags 0.9.1 to clap, which removes bitflags 0.7.0. Source-Repo: https://github.com/servo/servo Source-Revision: 4d5ff42751ed25ebdc3f298d89acb7eaf58572e5
1fd906fa110de6ef48d0fbeb9a3f40bdd31e76aa: servo: Merge #19292 - style: Add comment about -moz-control-character-visibility initial value (from heycam:moz-cc-comment); r=KiChjang
Cameron McCormack <cam@mcc.id.au> - Sun, 19 Nov 2017 20:18:57 -0600 - rev 392636
Push 32935 by ebalazs@mozilla.com at Mon, 20 Nov 2017 09:39:39 +0000
servo: Merge #19292 - style: Add comment about -moz-control-character-visibility initial value (from heycam:moz-cc-comment); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: cea3fd62297e5e61fb6676ff53b2988d378d3c86
0ff4a36cce94d0b9cb64c3ee7204e72749707e5c: servo: Merge #19288 - Implement EventTarget constructor (from m-novikov:impl-eventtarget-constructor); r=KiChjang
Maxim Novikov <mnovikov.work@gmail.com> - Sun, 19 Nov 2017 18:18:48 -0600 - rev 392629
Push 32935 by ebalazs@mozilla.com at Mon, 20 Nov 2017 09:39:39 +0000
servo: Merge #19288 - Implement EventTarget constructor (from m-novikov:impl-eventtarget-constructor); r=KiChjang Resolves #19283 Do "Wrap" functions only created for elements that aren't marked Abstract in .webidl file? How can I see code that was generated from webidls? <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19283 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they are covered by webplatform tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: db5fb74a4d3ff4c354edac8e116ed4f5665d61a5
d05856e2b8e8156fa2503b8e413a9790d5f42b40: servo: Merge #19182 - Treat application/xml like text/xml in ParserContext::process_response (from cgati:parse-xml); r=KiChjang
Christian Gati <christian.gati@gmail.com> - Sat, 18 Nov 2017 15:09:15 -0600 - rev 392598
Push 32928 by aiakab@mozilla.com at Sun, 19 Nov 2017 09:56:42 +0000
servo: Merge #19182 - Treat application/xml like text/xml in ParserContext::process_response (from cgati:parse-xml); r=KiChjang <!-- Please describe your changes on the following line: --> * components/script/dom/servoparser/mod.rs updated to handle application/xml as text/xml, along with hoisting application/xhtml+xml from the unknown mime types match arm. * tests updated via mach --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15850 (github issue number if applicable). <!-- Either: --> - [X] These changes modify results in test files via the automated: `./mach test-wpt tests/wpt/web-platform-tests/dom/nodes --log-raw /tmp/servo && ./mach update-wpt /tmp/servo` - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 60dca9cc4418b1cd0c21bee89d7b0d0bf657a7ff
af09e61303becc70ffa083f3610ba78c3a62feca: servo: Merge #19202 - Fire 'select' event in SetSelection{Start,End} (from jonleighton:issue-19171); r=KiChjang
Jon Leighton <j@jonathanleighton.com> - Wed, 15 Nov 2017 04:08:24 -0600 - rev 391894
Push 32908 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:22:51 +0000
servo: Merge #19202 - Fire 'select' event in SetSelection{Start,End} (from jonleighton:issue-19171); r=KiChjang See #19171. Source-Repo: https://github.com/servo/servo Source-Revision: 2efbf2230a61a2fda1ecc4cd12618177d4ca50cd
2ee4a30d1ea7b08a38ff5108ee6055a337046e68: servo: Merge #19130 - Update WR (blur and subpixel text optimizations, recording fix) (from glennw:update-wr-blur-subpx); r=KiChjang
Glenn Watson <github@intuitionlibrary.com> - Mon, 06 Nov 2017 23:04:20 -0600 - rev 390442
Push 32829 by apavel@mozilla.com at Tue, 07 Nov 2017 10:28:12 +0000
servo: Merge #19130 - Update WR (blur and subpixel text optimizations, recording fix) (from glennw:update-wr-blur-subpx); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: 8b892ee0ee1ee55ed189347e0ef528edfaa74f61
40a86fa71825a4ff615d604b10914ec27b9695cd: servo: Merge #18657 - script: Remove HTMLAppletElement (from emilio:bye-applet); r=KiChjang
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 06 Nov 2017 10:46:44 -0600 - rev 390358
Push 32827 by ccoroiu@mozilla.com at Mon, 06 Nov 2017 23:02:00 +0000
servo: Merge #18657 - script: Remove HTMLAppletElement (from emilio:bye-applet); r=KiChjang It was removed from the spec, there's no reason to keep it in tree. Source-Repo: https://github.com/servo/servo Source-Revision: a509ebf90ccd24ef80b27737faefa340a5af8916
72ee35bd086791e08bc0ee2d046f2ddda81edea4: servo: Merge #19116 - Fix dead link in COMMAND_LINE_ARGS.md (from servo:cla-doc-link); r=KiChjang
Alex Touchet <alextouchet@outlook.com> - Sat, 04 Nov 2017 15:58:27 -0500 - rev 390210
Push 32813 by archaeopteryx@coole-files.de at Sun, 05 Nov 2017 10:32:36 +0000
servo: Merge #19116 - Fix dead link in COMMAND_LINE_ARGS.md (from servo:cla-doc-link); r=KiChjang <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 8035679858eaf50ba68ac134efa02a969ec93de5
aef4d407bf7be0b1c617c27fed7d5630b07ee945: servo: Merge #19078 - Fixes #19063 (from outkaj:master); r=KiChjang
Jacqueline Outka <jacqueline@outka.xyz> - Tue, 31 Oct 2017 22:48:18 -0500 - rev 389544
Push 32788 by archaeopteryx@coole-files.de at Wed, 01 Nov 2017 21:53:16 +0000
servo: Merge #19078 - Fixes #19063 (from outkaj:master); r=KiChjang This PR renames the unused variables mentioned in issue #19063. - [X] `./mach build --release` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #19063 - [X] This change does not require a test because it is a relatively minimal change (? happy to make a test if it's helpful) "Allow edits from maintainers" is checked. Source-Repo: https://github.com/servo/servo Source-Revision: dbaa5b22e652a87717d77e0960917b20d878bc43
74d04abedbb608855a89c6631274ac19f404b764: servo: Merge #19079 - Update WR (scroll fixes, text gamma fixes) (from glennw:update-wr-scroll-fixes); r=KiChjang
Glenn Watson <github@intuitionlibrary.com> - Tue, 31 Oct 2017 21:25:14 -0500 - rev 389538
Push 32788 by archaeopteryx@coole-files.de at Wed, 01 Nov 2017 21:53:16 +0000
servo: Merge #19079 - Update WR (scroll fixes, text gamma fixes) (from glennw:update-wr-scroll-fixes); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: 894957a837ad01554a068a883a354e0ed4a949d3
d1911024899305c9273abf5f92d14fbb9ce386a9: servo: Merge #19024 - Introduce style::dom::TDocument (from emilio:document); r=KiChjang
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Oct 2017 07:51:21 -0500 - rev 388435
Push 32750 by archaeopteryx@coole-files.de at Thu, 26 Oct 2017 21:56:27 +0000
servo: Merge #19024 - Introduce style::dom::TDocument (from emilio:document); r=KiChjang The secret plan is introducing a `get_elements_with_id` for use by `querySelector` / `querySelectorAll`. But this allows also to make some code look a bit nicer. Source-Repo: https://github.com/servo/servo Source-Revision: ee4e371c73b265946146947bb16042360cb2fa41
b99354d99d8b1320416c9ad0959f5d829584e12e: servo: Merge #19023 - style: Remove PresentationalHintsSynthesizer (from emilio:remove-pres-hints-trait); r=KiChjang
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Oct 2017 05:17:39 -0500 - rev 388418
Push 32750 by archaeopteryx@coole-files.de at Thu, 26 Oct 2017 21:56:27 +0000
servo: Merge #19023 - style: Remove PresentationalHintsSynthesizer (from emilio:remove-pres-hints-trait); r=KiChjang This is not really an useful abstraction, and I never knew how to spell it. Source-Repo: https://github.com/servo/servo Source-Revision: b2867c0afa8bc728c13ddfd56678170dfba98967
d6963f0478b05c1da431215d2c79f6fdff03fa94: servo: Merge #19013 - Update Browser.html (from atouchet:bhtmlup); r=KiChjang
Alex Touchet <alextouchet@outlook.com> - Tue, 24 Oct 2017 23:12:39 -0500 - rev 388086
Push 32741 by archaeopteryx@coole-files.de at Wed, 25 Oct 2017 11:02:03 +0000
servo: Merge #19013 - Update Browser.html (from atouchet:bhtmlup); r=KiChjang There have been some interface improvements since this was last updated. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 5da0a8d8725edde1aab0e802b1381bb379fd6638
53167b796184d8c064d99c51fb62901c0b49cd5d: servo: Merge #18994 - Update fontsan (from servo:jdm-patch-2); r=KiChjang
Josh Matthews <josh@joshmatthews.net> - Mon, 23 Oct 2017 15:39:22 -0500 - rev 387985
Push 32739 by acraciun@mozilla.com at Wed, 25 Oct 2017 09:29:21 +0000
servo: Merge #18994 - Update fontsan (from servo:jdm-patch-2); r=KiChjang We're a couple years behind master at this point. Source-Repo: https://github.com/servo/servo Source-Revision: 00784fe5e1f6410a928655d606ccaf73f37984b7
138a9b0c043b7abbc721a804017d9c57a929387a: servo: Merge #18990 - Fixed FireMouseEventType mixup (from mhaessig:mouse-event-fixup); r=KiChjang
Manuel Hässig <mhaessig@users.noreply.github.com> - Mon, 23 Oct 2017 10:18:42 -0500 - rev 387984
Push 32739 by acraciun@mozilla.com at Wed, 25 Oct 2017 09:29:21 +0000
servo: Merge #18990 - Fixed FireMouseEventType mixup (from mhaessig:mouse-event-fixup); r=KiChjang Fix for a bug I didn't catch in #18957. Thanks to @rharel for pointing it out. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix issue #18943 and bug in PR #18957 - [X] These changes do not require tests as specified in #18943 r?@jdm Source-Repo: https://github.com/servo/servo Source-Revision: d9ede4dc054ba2da322bd21af1cfa75b85e1dc65
1eec1b16929e8f50b55d770b4b986cbc73b89e22: servo: Merge #18914 - Update WR (hit test relative point, query feature) (from glennw:update-wr-hit-test); r=KiChjang
Glenn Watson <github@intuitionlibrary.com> - Mon, 16 Oct 2017 23:42:12 -0500 - rev 386516
Push 32694 by archaeopteryx@coole-files.de at Tue, 17 Oct 2017 09:43:13 +0000
servo: Merge #18914 - Update WR (hit test relative point, query feature) (from glennw:update-wr-hit-test); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: 1715329eb1037cb4f0c723d3db2e22d722c7290d
d81448427e936f9af2639f90f1bc246dbbd3948d: servo: Merge #18870 - Use pointer casts instead of tramsutes to raw::TraitObject (from servo:cast); r=KiChjang
Simon Sapin <simon.sapin@exyr.org> - Fri, 13 Oct 2017 21:43:09 -0500 - rev 386253
Push 32683 by archaeopteryx@coole-files.de at Sat, 14 Oct 2017 21:54:57 +0000
servo: Merge #18870 - Use pointer casts instead of tramsutes to raw::TraitObject (from servo:cast); r=KiChjang Casting `*const T` to `*const U` with `U: Sized` is allowed even if `T: ?Sized`. This safely extracts the data pointer out of a trait object, without relying on the memory representation of trait objects. Source-Repo: https://github.com/servo/servo Source-Revision: 86a5135ffaa60d4743b6f6950fc395c2615e85ba
7ea4e2167179a2d54c479793091be3e5eca2b26f: servo: Merge #18859 - Update WR (mac gamma + alpha fix, 3d transform bug fixes) (from glennw:update-wr-3d-gamma); r=KiChjang
Glenn Watson <github@intuitionlibrary.com> - Thu, 12 Oct 2017 23:07:40 -0500 - rev 386070
Push 32675 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:36:21 +0000
servo: Merge #18859 - Update WR (mac gamma + alpha fix, 3d transform bug fixes) (from glennw:update-wr-3d-gamma); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: 1d0df04695f289015e6336e3caea8046a018fa06
9be45ed176f499fb999b9882d3e1a3e29c449722: servo: Merge #18581 - Update mp3-metatada and thus audio-video-metadata (from GuillaumeGomez:update-mp3); r=KiChjang
Guillaume Gomez <guillaume1.gomez@gmail.com> - Wed, 27 Sep 2017 07:06:07 -0500 - rev 383213
Push 32587 by archaeopteryx@coole-files.de at Wed, 27 Sep 2017 21:55:32 +0000
servo: Merge #18581 - Update mp3-metatada and thus audio-video-metadata (from GuillaumeGomez:update-mp3); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: aff99ef30b455cf81945511805de6fb2de31a750
61dd2fbd336768c9e6dd2c474bdc73638965ef47: servo: Merge #18645 - Update WR (support color emoji on mac, also sub-primitive clips) (from glennw:update-wr-emoji); r=KiChjang
Glenn Watson <github@intuitionlibrary.com> - Wed, 27 Sep 2017 02:43:45 -0500 - rev 383186
Push 32587 by archaeopteryx@coole-files.de at Wed, 27 Sep 2017 21:55:32 +0000
servo: Merge #18645 - Update WR (support color emoji on mac, also sub-primitive clips) (from glennw:update-wr-emoji); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: 1162aed4e5a4bf80b622ab5fd26b25538385541c
6be6a2554828bdcff82092ae8de1e2426b6e9632: servo: Merge #18617 - Removed integrity check and test for no-cors requests (from TheDan64:master); r=KiChjang
Daniel Kolsoi <dkolsoi@pixability.com> - Mon, 25 Sep 2017 19:15:26 -0500 - rev 382827
Push 32576 by archaeopteryx@coole-files.de at Tue, 26 Sep 2017 09:52:21 +0000
servo: Merge #18617 - Removed integrity check and test for no-cors requests (from TheDan64:master); r=KiChjang Removed Step 30.2 which raised a JS TypeError if the integrity metadata was not empty. I manually ran `new Request("", {"mode" : "no-cors", "integrity" : "not an empty string"});` in servo to validate that the exception no longer arose. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #18345 - [x] These changes do not require tests because according to the ticket "Unfortunately, there's no automated test available for this yet because we are having trouble updating our copy of the upstream tests. " Source-Repo: https://github.com/servo/servo Source-Revision: e6099b43646520a4d0076bfc50dcc65b1aa8eb6b
83b7698668b9c39af6010cdec511bbe2b94bf6b6: servo: Merge #18603 - fix #18594: Unnecessarily allocating an error string (from tigercosmos:allocating); r=KiChjang
tigercosmos <b04209032@ntu.edu.tw> - Sat, 23 Sep 2017 17:11:51 -0500 - rev 382617
Push 32568 by archaeopteryx@coole-files.de at Sun, 24 Sep 2017 21:51:15 +0000
servo: Merge #18603 - fix #18594: Unnecessarily allocating an error string (from tigercosmos:allocating); r=KiChjang <!-- Please describe your changes on the following line: --> r? @asajeffrey --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18594 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 35aad086191c7c4561067a1f774b3ae2d69bc375
9d5c9ff64cfb4ab3838166141c0ab46a0fd32051: servo: Merge #18601 - Remove unused 'untagged_unions' feature gate (from mbrubeck:features); r=KiChjang
Matt Brubeck <mbrubeck@limpet.net> - Fri, 22 Sep 2017 14:39:25 -0500 - rev 382522
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
servo: Merge #18601 - Remove unused 'untagged_unions' feature gate (from mbrubeck:features); r=KiChjang CC #5286 - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because _____ Source-Repo: https://github.com/servo/servo Source-Revision: 352b129dc5b237757ade67448cc42f327780417e
87f57d513b3723d6ff023d4f6d7319b95e25013a: servo: Merge #18579 - Remove unused feature gates (from mbrubeck:features); r=KiChjang
Matt Brubeck <mbrubeck@limpet.net> - Thu, 21 Sep 2017 15:08:04 -0500 - rev 382305
Push 32553 by philringnalda@gmail.com at Fri, 22 Sep 2017 03:40:16 +0000
servo: Merge #18579 - Remove unused feature gates (from mbrubeck:features); r=KiChjang CC #5286. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because no code changes Source-Repo: https://github.com/servo/servo Source-Revision: 29517d553e6c2fddc7e3cf0c0abef58c6d0f34aa
6a151f43cb3f70917bde1ace58a9d118776e70b9: servo: Merge #18578 - Window should own Location, Document shouldn't (from asajeffrey:script-window-owns-location); r=KiChjang
Alan Jeffrey <ajeffrey@mozilla.com> - Wed, 20 Sep 2017 14:38:31 -0500 - rev 382044
Push 32546 by archaeopteryx@coole-files.de at Thu, 21 Sep 2017 13:14:27 +0000
servo: Merge #18578 - Window should own Location, Document shouldn't (from asajeffrey:script-window-owns-location); r=KiChjang <!-- Please describe your changes on the following line: --> Document shouldn't own location, Window should. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18438 - [X] These changes do not require tests because it's an intermittent <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 6a791cd7f26b42a6688099bea203c21fb3c9cc12
5062ee0a6174aaf097fac02f811193b0ae0aa2b5: servo: Merge #18511 - Update to smallbitvec 1.0.6 (from mbrubeck:always-be-updating); r=KiChjang
Matt Brubeck <mbrubeck@limpet.net> - Fri, 15 Sep 2017 21:22:37 -0500 - rev 381251
Push 32514 by archaeopteryx@coole-files.de at Sat, 16 Sep 2017 09:30:32 +0000
servo: Merge #18511 - Update to smallbitvec 1.0.6 (from mbrubeck:always-be-updating); r=KiChjang Includes servo/smallbitvec#2, a performance fix that is useful for Stylo. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they update external code only Source-Repo: https://github.com/servo/servo Source-Revision: fac923395e6785dc89a0b9982506476c43d7d175
3fb9146be6af389b8886b16b9aa0dce924c24021: servo: Merge #18264 - Update WR (debugger, renderer API changes) (from glennw:update-wr-api); r=KiChjang
Glenn Watson <github@intuitionlibrary.com> - Sun, 27 Aug 2017 23:14:05 -0500 - rev 377172
Push 32402 by archaeopteryx@coole-files.de at Mon, 28 Aug 2017 14:47:04 +0000
servo: Merge #18264 - Update WR (debugger, renderer API changes) (from glennw:update-wr-api); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: e53bf5d675e195b6bf69e1c78fbb552b3daa80f6
66fb4ab16802bf01b98e2d970c341e02d939c69c: servo: Merge #17872 - Warning patrol (from servo:jdm-patch-1); r=KiChjang
Josh Matthews <josh@joshmatthews.net> - Thu, 27 Jul 2017 00:10:49 -0500 - rev 371265
Push 32240 by cbook@mozilla.com at Thu, 27 Jul 2017 08:56:05 +0000
servo: Merge #17872 - Warning patrol (from servo:jdm-patch-1); r=KiChjang This greens up every build except the android one. Source-Repo: https://github.com/servo/servo Source-Revision: ad38516a71f04b7271d1572f03a9412b1c2b2f58
9081664a8b86cd6bb3f188a78d3c70f076ef9ccd: servo: Merge #17790 - Update WR (text-shadow optimizations) (from glennw:update-wr-shadows-agan); r=KiChjang
Glenn Watson <github@intuitionlibrary.com> - Thu, 20 Jul 2017 00:55:45 -0700 - rev 369844
Push 32208 by archaeopteryx@coole-files.de at Fri, 21 Jul 2017 09:12:51 +0000
servo: Merge #17790 - Update WR (text-shadow optimizations) (from glennw:update-wr-shadows-agan); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: 069243a474eedb2c914db71c45d121fc4d954f5e
99a0ffe4985d202ea9dd30606f1c60b7cdcd114e: servo: Merge #17665 - Avoid panic when postMessage targets closed window (from jdm:postmessage-panic); r=KiChjang
Josh Matthews <josh@joshmatthews.net> - Tue, 11 Jul 2017 12:28:33 -0700 - rev 368302
Push 32161 by cbook@mozilla.com at Wed, 12 Jul 2017 09:06:33 +0000
servo: Merge #17665 - Avoid panic when postMessage targets closed window (from jdm:postmessage-panic); r=KiChjang - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17664 - [X] There are tests for these changes Source-Repo: https://github.com/servo/servo Source-Revision: 2a575acabe50446803005db52b750405b7b7080c
acc79db449e4d6c0b49d38be97718612e0e56634: servo: Merge #17515 - Merge explicit node iterator structures into single generic structure (from frewsxcv:frewsxcv-simple-node-iterator); r=KiChjang
Corey Farwell <coreyf@rwell.org> - Sun, 25 Jun 2017 00:38:23 -0700 - rev 365970
Push 32089 by cbook@mozilla.com at Mon, 26 Jun 2017 11:24:06 +0000
servo: Merge #17515 - Merge explicit node iterator structures into single generic structure (from frewsxcv:frewsxcv-simple-node-iterator); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: f740366c611d375f0bb259ae0f4d846c05ec276e
b51d99b05136f678a44b5a893cec44592140e467: servo: Merge #17441 - Update WR (z-buffer fix, border-image fill support) (from glennw:update-wr-fill-z); r=KiChjang
Glenn Watson <github@intuitionlibrary.com> - Wed, 21 Jun 2017 05:41:08 -0700 - rev 365184
Push 32066 by kwierso@gmail.com at Wed, 21 Jun 2017 23:54:49 +0000
servo: Merge #17441 - Update WR (z-buffer fix, border-image fill support) (from glennw:update-wr-fill-z); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: 7543acc257d91c2dbbf2d430e071dc71a3a0573c