searching for reviewer(Honza)
c239c5218b5beb7712243663a833384cd9ca8718: Bug 1555625 - Basic skeleton of side panel for WS frames. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Wed, 19 Jun 2019 20:00:30 +0000 - rev 479247
Push 36177 by rmaries@mozilla.com at Thu, 20 Jun 2019 09:46:31 +0000
Bug 1555625 - Basic skeleton of side panel for WS frames. r=Honza Implement basic skeleton of side panel for WS frames. Differential Revision: https://phabricator.services.mozilla.com/D34704
1b06448abd9346a6a3a0161e94a9f3f3bec6a8ef: Bug 1554881 - Simplify RequestListItem render r=Honza
Gregor Weber <gweber@mozilla.com> - Fri, 14 Jun 2019 13:38:55 +0000 - rev 478855
Push 36154 by dvarga@mozilla.com at Fri, 14 Jun 2019 21:50:40 +0000
Bug 1554881 - Simplify RequestListItem render r=Honza Differential Revision: https://phabricator.services.mozilla.com/D35010
b4f0ee392b9771796370b8f2b3194abba3599ff6: Bug 1174100 - Cache information is not exposed to HAR. r=Honza
lloan <lloanalas@outlook.com> - Fri, 14 Jun 2019 12:12:44 +0000 - rev 478848
Push 36154 by dvarga@mozilla.com at Fri, 14 Jun 2019 21:50:40 +0000
Bug 1174100 - Cache information is not exposed to HAR. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33570
7428c765611785fbd85b41aea1069d671bfc259d: Bug 1557632 - Don't check if input is compilable unit on Ctrl+Enter. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 13 Jun 2019 12:35:04 +0000 - rev 478663
Push 36148 by shindli@mozilla.com at Thu, 13 Jun 2019 21:50:57 +0000
Bug 1557632 - Don't check if input is compilable unit on Ctrl+Enter. r=Honza. In the regular webconsole input, on Enter, we check that the input is a compilable unit, so the user don't accidentally execute an incomplete snippet. In the editor mode, the user will have to use Ctrl/Cmd + Enter to execute, so we don't have to worry about Enter (it will simply append a new line). And since the user might deal with a large number of characters, we don't want to prevent them to execute. If it's malformed, they will get an error in the output and can fix their input easily, since it wasn't cleared. The patch adds a test to ensure this work as expected. Differential Revision: https://phabricator.services.mozilla.com/D34522
3a9e09d5a4d7663c9016b011b4f15d9a34364071: Bug 1494796 - fix netmonitor test to ensure elements exist on the dom before testing; r=Honza
yulia <ystartsev@mozilla.com> - Wed, 12 Jun 2019 23:34:59 +0000 - rev 478607
Push 36146 by opoprus@mozilla.com at Thu, 13 Jun 2019 09:54:24 +0000
Bug 1494796 - fix netmonitor test to ensure elements exist on the dom before testing; r=Honza the test `browser_net_params_sorted` may not have been functioning for some time. While investigating this, I discovered that we were getting an empty array for `actualKeys`. Iterating over this array returned immediately. As a result the test always passed, even though the shape of the data changed. I updated this code so that it waits for the dom to be populated with the number of keys expected. I also updated the test to reflect the data the front end has today. Differential Revision: https://phabricator.services.mozilla.com/D32713
ee33e076cbcbe786125f83079bd8e5b43bb73a99: Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza,jdescottes
tanhengyeow <E0032242@u.nus.edu> - Tue, 11 Jun 2019 15:27:08 +0000 - rev 478258
Push 36138 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:33:19 +0000
Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza,jdescottes Implement backend actor for WebSocket inspection Differential Revision: https://phabricator.services.mozilla.com/D33278
eb9868016897672165b4a95e9adf41c3883b6ec0: Bug 1558237 - Prevent unwanted background for event listener breakpoints toggles r=Honza
David Walsh <dwalsh@mozilla.com> - Tue, 11 Jun 2019 08:49:38 +0000 - rev 478245
Push 36138 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:33:19 +0000
Bug 1558237 - Prevent unwanted background for event listener breakpoints toggles r=Honza Differential Revision: https://phabricator.services.mozilla.com/D34381
d218c415396f9188c5d19ac09c50b6db82730016: Bug 1545888 - Use template-styled message with placeholders as warning group labels. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 11 Jun 2019 13:47:37 +0000 - rev 478233
Push 36138 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:33:19 +0000
Bug 1545888 - Use template-styled message with placeholders as warning group labels. r=Honza. This allows to have more meaningful warning group messages, i.e. "Content Blocking" is turned into something like "The resource at '<URL>' was blocked because content blocking is enabled". This is done by parsing the message of the first warning to put in the group, and replacing the URL with a generic placeholder. We take this as an opportunity to decouple content blocked messages and storage access blocked ones, as they have slightly different meanings and consequences. Tests are updated to match the new labels, and a new test is added to make sure that we can have multiple warning group in a single "page navigation" session. Differential Revision: https://phabricator.services.mozilla.com/D34339
be1ba46ab9fd608f8fb61882d0e23ffe01f8739e: Bug 1557324 - Fix JSTerm keyboard navigation in old input. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 11 Jun 2019 08:26:22 +0000 - rev 478189
Push 36138 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:33:19 +0000
Bug 1557324 - Fix JSTerm keyboard navigation in old input. r=Honza. Hitting Ctrl+ArrowRight didn't have any effect on windows/linux. The patch fixes this and add a test to make sure a user can navigate from word to word using Ctrl (or Alt on OSX) and Arrow Left/Right keys. Differential Revision: https://phabricator.services.mozilla.com/D34312
de1dc8a5ce5403163d5b2d4215795ca429358433: Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Tue, 11 Jun 2019 08:16:31 +0000 - rev 478188
Push 36138 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:33:19 +0000
Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza Implement backend actor for WebSocket inspection Differential Revision: https://phabricator.services.mozilla.com/D33278
e69430c126d73a919b73ed81002d690dea888358: Bug 1556308 - Prevent nemonitor errors for failed requests r=Honza
David Walsh <dwalsh@mozilla.com> - Mon, 10 Jun 2019 16:16:08 +0000 - rev 478087
Push 36136 by nerli@mozilla.com at Tue, 11 Jun 2019 03:18:15 +0000
Bug 1556308 - Prevent nemonitor errors for failed requests r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33988
b596d98d59fd5aea938f1b1391d4e208c5bb01fb: Bug 1556454 - Use consistent red color and show blocked badge for blocked requests r=Honza
David Walsh <dwalsh@mozilla.com> - Fri, 07 Jun 2019 08:21:24 +0000 - rev 477921
Push 36127 by nbeleuzu@mozilla.com at Sat, 08 Jun 2019 09:39:25 +0000
Bug 1556454 - Use consistent red color and show blocked badge for blocked requests r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33862
89b7f73b270126eea62ee77f6873805976fd8abe: Bug 1523864 - Move filter bar layout change to the App level. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 07 Jun 2019 14:23:35 +0000 - rev 477855
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1523864 - Move filter bar layout change to the App level. r=Honza. This makes the console code more consistent, and adds the nice benefit of being able to check if the layout should be modified when performing non-window-resize events that might still impact the layout (sidebar toggle, sidebar resizing, ...). Differential Revision: https://phabricator.services.mozilla.com/D27668
4c8aa3c1d1234d5c7c4ff5c8da26ff307e4e0a92: Bug 1523864 Display filter buttons next to filter input if there is enough space. r=Honza
Kelly <kelly.bell@mail.utoronto.ca> - Fri, 07 Jun 2019 14:23:16 +0000 - rev 477854
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1523864 Display filter buttons next to filter input if there is enough space. r=Honza Set a minimum width on the filter bar of the Devtools Console window. When there is enough empty space to the right of the filterbar, allow the filter buttons to be desplaying inline, rather than on their own separate row. Differential Revision: https://phabricator.services.mozilla.com/D20188
0a7fc2e413adbcb44d40e2a9f559fbe7a2b6c985: Bug 1556068 - Track JsPropertyProvider's analyzeInput string and bail if it's taking too long. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 06 Jun 2019 13:08:21 +0000 - rev 477603
Push 36119 by ncsoregi@mozilla.com at Thu, 06 Jun 2019 21:52:09 +0000
Bug 1556068 - Track JsPropertyProvider's analyzeInput string and bail if it's taking too long. r=Honza. It can happen that the string we receive is quite large and as a result takes a long time to analyze, freezing the process. This patch simply tracks for how long the for loop is running, and bail out if it's greater than a given time (set to 2500 ms for now). This is mostly a safeguard, a future patch should try to improve the performance of the function itself. Differential Revision: https://phabricator.services.mozilla.com/D33791
e6dd869ef4841de8c3628e173525c376aafce585: Bug 1551870 - Reintroduce netmonitor-toolbar-container in single-toolbar mode so React doesn't re-render the toolbar when switching panels. r=Honza
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 04 Jun 2019 15:06:06 +0000 - rev 476825
Push 36108 by nbeleuzu@mozilla.com at Tue, 04 Jun 2019 21:42:40 +0000
Bug 1551870 - Reintroduce netmonitor-toolbar-container in single-toolbar mode so React doesn't re-render the toolbar when switching panels. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33616
37918f3c49dfa66c3fb8c5a12ee3e11a9e35d088: Bug 1551870 - Reintroduce netmonitor-toolbar-container in single-toolbar mode so React doesn't re-render the toolbar when switching panels. r=Honza
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 04 Jun 2019 12:53:16 +0000 - rev 476797
Push 36108 by nbeleuzu@mozilla.com at Tue, 04 Jun 2019 21:42:40 +0000
Bug 1551870 - Reintroduce netmonitor-toolbar-container in single-toolbar mode so React doesn't re-render the toolbar when switching panels. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33616
41ead3af829120a34c76a1f01472dca7c004e0e1: Bug 1525618 - Add an option in the settings panel to toggle warning groups. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 03 Jun 2019 15:10:45 +0000 - rev 476626
Push 36104 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:45:41 +0000
Bug 1525618 - Add an option in the settings panel to toggle warning groups. r=Honza. We also listen for the warningGroup preference change to toggle warningGroups in the console output. If warningGroups were disabled, we need to loop through the state messages to create warningGroups when needed. A test is added to ensure this works as expected. Differential Revision: https://phabricator.services.mozilla.com/D32716
abf29aea4d1edd7cc377f18d1b25149b020bcabf: Bug 1555909 - Remove workaround for cleanup the list on destroy. r=Honza
lloan <lloanalas@outlook.com> - Mon, 03 Jun 2019 07:35:04 +0000 - rev 476570
Push 36102 by csabou@mozilla.com at Mon, 03 Jun 2019 16:03:01 +0000
Bug 1555909 - Remove workaround for cleanup the list on destroy. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33444
b067a5b108dd7d396453500caf047c41fc678ad2: Bug 1157817 - Show blocked requests in the Network Monitor r=Honza,Harald
David Walsh <dwalsh@mozilla.com> - Tue, 28 May 2019 12:13:08 +0000 - rev 475816
Push 36076 by opoprus@mozilla.com at Tue, 28 May 2019 21:44:47 +0000
Bug 1157817 - Show blocked requests in the Network Monitor r=Honza,Harald Displays blocked requests in the Network monitor request listing, providing a reason for why the request was blocked based on response codes provided b nsILoadInfo.idl Differential Revision: https://phabricator.services.mozilla.com/D31907
9341602d655c3baf915ad49624e71815aa0bfb94: Bug 1552629 - Fix misaligned "Edit and Resend" button in the netmonitor Headers panel;r=Honza
Vincent Lequertier <vi.le@autistici.org> - Mon, 27 May 2019 07:23:44 +0000 - rev 475674
Push 36072 by dluca@mozilla.com at Tue, 28 May 2019 09:38:00 +0000
Bug 1552629 - Fix misaligned "Edit and Resend" button in the netmonitor Headers panel;r=Honza If the "Referrer Policy" header is missing, summaryReferrerPolicy is null, so summaryEditAndResendBtn contains only the "Edit and Resend" button, making it misaligned. We fix this by making sure summaryEditAndResendBtn always contains the last non-null header. Differential Revision: https://phabricator.services.mozilla.com/D32322
8e80b2082da53556d32efa82121b2391899ab543: Bug 1554095 - Fix Block URL action. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Mon, 27 May 2019 06:47:10 +0000 - rev 475655
Push 36069 by opoprus@mozilla.com at Mon, 27 May 2019 09:54:41 +0000
Bug 1554095 - Fix Block URL action. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D32522
c1d2feb784e02c9ed085d1faed370e85edcb3032: Bug 1341155 - Show full path in File column in developer tools. r=Honza
lloan <lloanalas@outlook.com> - Thu, 23 May 2019 12:24:57 +0000 - rev 475187
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1341155 - Show full path in File column in developer tools. r=Honza New column, defaulted to hidden, to show full URL for resource in netMonitor panel. Differential Revision: https://phabricator.services.mozilla.com/D31348
53132931ba91cbd4a394734e32abbf387d6c6162: Bug 1553473 - Fix PropTypes. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 23 May 2019 09:26:44 +0000 - rev 475186
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1553473 - Fix PropTypes. r=Honza. The FilterBar propType was a leftover from a previous patch where the prop was removed. The SearchBox one was added in a recent patch, but shouldn't have been required (as we have a default in the render function for it). Differential Revision: https://phabricator.services.mozilla.com/D32150
baf86b77635c22a5739fcef15e0a9172fd5cbd6b: Bug 1541355 - Don't display DevTools internal frames in Netmonitor stacktrace. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 22 May 2019 08:57:36 +0000 - rev 474887
Push 36050 by shindli@mozilla.com at Wed, 22 May 2019 15:25:01 +0000
Bug 1541355 - Don't display DevTools internal frames in Netmonitor stacktrace. r=Honza. Before sending back the stacktrace, we remove all the devtools internal frames using removeFramesAboveDebuggerEval. A test (that was failing without the fix) is added to ensure this works as expected. The test revealed some issues in webconsole-connection-proxy (mostly trying to access webConsoleUI while closing the toolbox), which we fix in the patch as well. Differential Revision: https://phabricator.services.mozilla.com/D31249
78571bb1f20e643cdab9791f61b0aa7b6a8bdf90: Bug 1534932 - Ensure filtering works with warningGroups. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 21 May 2019 12:43:04 +0000 - rev 474716
Push 36044 by rmaries@mozilla.com at Tue, 21 May 2019 15:45:34 +0000
Bug 1534932 - Ensure filtering works with warningGroups. r=Honza. We want the warningGroup to be displayed if at least one of its children will be visible. We also want all the children if the warningGroup should be visible. This requires a few changes in the message reducers, mainly in the getVisibility function. But we also modify maybeSortVisibleMessages to place the messages in warningGroups at the expected positions. A complete mochitest is added to ensure the output always has the expected messages in the expected order. Differential Revision: https://phabricator.services.mozilla.com/D31220
be01ec66f386d44d59fc56ab904a84c299521177: Bug 1419358 - Never filter-out navigation markers message. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 21 May 2019 12:42:34 +0000 - rev 474715
Push 36044 by rmaries@mozilla.com at Tue, 21 May 2019 15:45:34 +0000
Bug 1419358 - Never filter-out navigation markers message. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D31219
36ada63cb9fb9ff56e7556cfc1db8cfad2c46a2d: Bug 1541355 - Don't display DevTools internal frames in Netmonitor stacktrace. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 20 May 2019 12:33:06 +0000 - rev 474533
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1541355 - Don't display DevTools internal frames in Netmonitor stacktrace. r=Honza. Before sending back the stacktrace, we remove all the devtools internal frames using removeFramesAboveDebuggerEval. A test (that was failing without the fix) is added to ensure this works as expected. The test revealed some issues in webconsole-connection-proxy (mostly trying to access webConsoleUI while closing the toolbox), which we fix in the patch as well. Differential Revision: https://phabricator.services.mozilla.com/D31249
d5a1f414d631aa02482f1c650387bc14c5e31b62: Bug 1466598 - [Network-Monitor] Right click on method enables request details tab. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Fri, 17 May 2019 07:01:05 +0000 - rev 474301
Push 36027 by shindli@mozilla.com at Fri, 17 May 2019 16:24:38 +0000
Bug 1466598 - [Network-Monitor] Right click on method enables request details tab. r=Honza Show context menu properly Differential Revision: https://phabricator.services.mozilla.com/D29126
7fdd2abe918b6ba220dd097d27d1a2cda6cfa8e6: Bug 1530914 - Highlighted resource information is difficult to read when blocked. r=Honza
lloan <lloanalas@outlook.com> - Fri, 17 May 2019 06:50:40 +0000 - rev 474300
Push 36027 by shindli@mozilla.com at Fri, 17 May 2019 16:24:38 +0000
Bug 1530914 - Highlighted resource information is difficult to read when blocked. r=Honza When looking at the resource listing, and there's a blocked item, it is difficult to read the pink text. Before: https://bug1530914.bmoattachments.org/attachment.cgi?id=9063611 Now: https://i.imgur.com/znNx8aQ.png Differential Revision: https://phabricator.services.mozilla.com/D31354
11ea9feda2a39cd013315ed5afcb5e8abbdd099f: Bug 1500915 - Properly decode urls. r=Honza
Mrigank Krishan <mrigankkrishan@gmail.com> - Wed, 15 May 2019 08:47:51 +0000 - rev 473903
Push 36018 by rgurzau@mozilla.com at Wed, 15 May 2019 15:58:16 +0000
Bug 1500915 - Properly decode urls. r=Honza Used decodeURI insted of decodeURLComponent and replace `+` with ` `(space). I've not tackled the line break issue yet. Differential Revision: https://phabricator.services.mozilla.com/D23014
9cca1de0aa3969e0f3e5e05a99455a343ab9e5a5: Bug 1479365 - Invert selection colors in selected rows; r=Honza,yzen,nchevobbe
Florens Verschelde <florens@fvsch.com> - Wed, 15 May 2019 07:36:04 +0000 - rev 473901
Push 36018 by rgurzau@mozilla.com at Wed, 15 May 2019 15:58:16 +0000
Bug 1479365 - Invert selection colors in selected rows; r=Honza,yzen,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D30794
dc20a50efcf1d6343019ab8cabe882698f2823fd: Bug 1530138 - Added resend option in WebConsole r=nchevobbe,Honza
Christoph Walcher <christoph-wa@gmx.de> - Tue, 14 May 2019 12:47:08 +0000 - rev 473797
Push 36015 by cbrindusan@mozilla.com at Tue, 14 May 2019 21:40:04 +0000
Bug 1530138 - Added resend option in WebConsole r=nchevobbe,Honza Added resend option in WebConsole Differential Revision: https://phabricator.services.mozilla.com/D30779
b87cdb4550833374f77f1bc5163e554552fb35f9: Bug 1493361 - Use StringRep to render PageError message. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 13 May 2019 12:58:33 +0000 - rev 473600
Push 36007 by apavel@mozilla.com at Mon, 13 May 2019 21:45:52 +0000
Bug 1493361 - Use StringRep to render PageError message. r=Honza. This allows us to benefit from the linkification that is done there. We crop the URL at 120 chars for now. We might consider bumping this up depending on the feedback we get. We add both a mocha and a mochitest to make sure this work as expected. Differential Revision: https://phabricator.services.mozilla.com/D29007
395e27a912b3b6aea3c27ccdb8a0028c23abf223: Bug 1493361 - Add a `urlCropLimit` prop in StringRep. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 13 May 2019 12:58:24 +0000 - rev 473599
Push 36007 by apavel@mozilla.com at Mon, 13 May 2019 21:45:52 +0000
Bug 1493361 - Add a `urlCropLimit` prop in StringRep. r=Honza. This new prop allow us to define a maximum length for indivual URLs (as opposed to `cropLimit`, which sets it for the whole text). The URL regex is also modified to be able to linkify messages wrapped in curly quotes. Some tests are added to ensure we handle this prop as expected. Differential Revision: https://phabricator.services.mozilla.com/D29006
b7145dad7ce17f1f8f72c8974b7472ffd1c84e17: Bug 1549375 - Update try syntax for running damp tests in devtools documentation r=Honza
Julian Descottes <jdescottes@mozilla.com> - Mon, 13 May 2019 07:28:16 +0000 - rev 473587
Push 36007 by apavel@mozilla.com at Mon, 13 May 2019 21:45:52 +0000
Bug 1549375 - Update try syntax for running damp tests in devtools documentation r=Honza Differential Revision: https://phabricator.services.mozilla.com/D30350
784c0c4b688bde6491539ad89a5f44b939c4fd7e: Bug 1223368 - Refactor searchbox style to be consistent across tools. r=fvsch,gl,Honza,nchevobbe
Tim Nguyen <ntim.bugs@gmail.com> - Sat, 11 May 2019 17:54:16 +0000 - rev 473521
Push 36000 by nerli@mozilla.com at Sat, 11 May 2019 22:09:02 +0000
Bug 1223368 - Refactor searchbox style to be consistent across tools. r=fvsch,gl,Honza,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D28334
c8a2cbf18f3c8434aa69b21db050fe7af1f19251: Bug 1223368 - Refactor searchbox style to be consistent across tools. r=fvsch,gl,Honza,nchevobbe
Tim Nguyen <ntim.bugs@gmail.com> - Sat, 11 May 2019 16:08:13 +0000 - rev 473517
Push 36000 by nerli@mozilla.com at Sat, 11 May 2019 22:09:02 +0000
Bug 1223368 - Refactor searchbox style to be consistent across tools. r=fvsch,gl,Honza,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D28334
9ee20b0dcecdfc7a111bf04f743110503b359936: Bug 1549185 - Tweak the 12px Console icons; r=Honza
Florens Verschelde <florens@fvsch.com> - Mon, 06 May 2019 11:32:38 +0000 - rev 472708
Push 35976 by opoprus@mozilla.com at Mon, 06 May 2019 21:44:12 +0000
Bug 1549185 - Tweak the 12px Console icons; r=Honza - Use an explicit 12x12 size in the SVG code - Add a 12x12 variant of the globe icon, with a 1px stroke similar to the info icon - Tweak the inner shapes of the info icon so that it looks a bit more clearly like a lowercase "i" Differential Revision: https://phabricator.services.mozilla.com/D29961
40f352e2d6b863c7b7040db9098d9421802709df: Bug 1549324 - Fix red background color of Params and Response error; r=Honza
Florens Verschelde <florens@fvsch.com> - Mon, 06 May 2019 11:24:28 +0000 - rev 472679
Push 35976 by opoprus@mozilla.com at Mon, 06 May 2019 21:44:12 +0000
Bug 1549324 - Fix red background color of Params and Response error; r=Honza Differential Revision: https://phabricator.services.mozilla.com/D29995
3499107fb6fed729654a8e6d719f7bbaff9c5ca1: Bug 1548317 - Fix twisty color in selected TreeView rows; r=Honza,yzen
Florens Verschelde <florens@fvsch.com> - Sun, 05 May 2019 13:39:41 +0000 - rev 472624
Push 35969 by ccoroiu@mozilla.com at Mon, 06 May 2019 04:24:23 +0000
Bug 1548317 - Fix twisty color in selected TreeView rows; r=Honza,yzen Changes impact theme-twisty icons in the TreeView component: - Make sure theme-twisty uses the selection color (white) in selected rows; but override that style for Network details accordion headers. - Improve the vertical alignment and pixel-perfect icon rendering by making sure the icon element takes the full available height (16px) and avoiding assymetrical padding (affects the rendering of centered background-image, making them blurry on 1x displays). - Tweak the horizontal spacing of theme-twisty icons so that they take up a total of 20px width (similar to what is used in Debugger and Inspector), versus 17px previously. Differential Revision: https://phabricator.services.mozilla.com/D29550
85a694fb6093e78954c92029dc0152f75358d1f1: Bug 1548589: Fix a code-comment in devtools to reference the new name of a renamed file. r=Honza
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 03 May 2019 08:21:25 +0000 - rev 472513
Push 35958 by malexandru@mozilla.com at Fri, 03 May 2019 21:56:39 +0000
Bug 1548589: Fix a code-comment in devtools to reference the new name of a renamed file. r=Honza DONTBUILD because this is just a comment tweak. Differential Revision: https://phabricator.services.mozilla.com/D29691
26a53be19f261e246e1e2ef372395b2c81d772aa: Bug 1093953 - (Part 2) Update test fixtures and add new test for CSS warnings in console. r=Honza
Razvan Caliman <rcaliman@mozilla.com> - Fri, 03 May 2019 11:21:09 +0000 - rev 472471
Push 35958 by malexandru@mozilla.com at Fri, 03 May 2019 21:56:39 +0000
Bug 1093953 - (Part 2) Update test fixtures and add new test for CSS warnings in console. r=Honza Depends on D28457 This commit separates the test-related changes from part one in D28457. It updates the test fixtures to include the newly introduced `cssSelectors` field for messages used in tests. It adds a test file for the newly introduced `CSSWarning` React component which is mostly a trimmed-down clone of the test for `PageError` component from which the component was forked. For now, just the basic toggle behavior of the component is tested. The test for calling the server to query DOM elements is not yet instrumented. Differential Revision: https://phabricator.services.mozilla.com/D29345
835c16acd375943236bcac8d6d2ac6ff0925725b: Bug 1093953 - (Part 1) Make CSS warnings expandable to show affected DOM elements. r=Honza
Razvan Caliman <rcaliman@mozilla.com> - Fri, 03 May 2019 13:01:27 +0000 - rev 472470
Push 35958 by malexandru@mozilla.com at Fri, 03 May 2019 21:56:39 +0000
Bug 1093953 - (Part 1) Make CSS warnings expandable to show affected DOM elements. r=Honza This patch builds on [Bug 1537876](https://bugzilla.mozilla.org/show_bug.cgi?id=1537876) which associates CSS selectors with error messages where applicable. This patch introduces a new React component, `CSSWarning`, for messages of type CSS. It forks the`PageError` component which was shared for `LOG` messages of type `JAVASCRIPT` and type `CSS`. The `CSSWarning` component is expandable when the message has an associated CSS selector. When expanded, it runs a `document.querySelectorAll()` command to list all elements matching the selector. Clicking on any of the elements in the result jumps to the Inspector and select the corresponding node in the markup view. Not all errors have associated CSS selectors. Not all selectors match elements. The errors/warnings are a result of the CSS Parser; there is no guarantee that the CSS rule is used anywhere on the document. The query may return an empty `NodeList`. Differential Revision: https://phabricator.services.mozilla.com/D28457
c9f246ee7d19697e6492f490cad7e340812301c5: Bug 1236509 -Fixes inconsistency in network panel: connection is secure but displayed icon is the globe instead of the lock r=Honza
neha <ns19041997@gmail.com> - Wed, 01 May 2019 15:16:11 +0000 - rev 472121
Push 35948 by nerli@mozilla.com at Wed, 01 May 2019 21:55:33 +0000
Bug 1236509 -Fixes inconsistency in network panel: connection is secure but displayed icon is the globe instead of the lock r=Honza Differential Revision: https://phabricator.services.mozilla.com/D24320
0afabdb9bf0445c54b50f3fe03b548c51b2017ba: Bug 1533144 - Include hostname from parent/window in HAR save default filename. r=Honza
lloan <lloanalas@outlook.com> - Mon, 29 Apr 2019 06:35:02 +0000 - rev 471715
Push 35932 by csabou@mozilla.com at Mon, 29 Apr 2019 15:59:55 +0000
Bug 1533144 - Include hostname from parent/window in HAR save default filename. r=Honza Include the name of the window/parent hostname in the save HAR filename, e.g. if on mozilla.org, would download as "mozilla.org_Archive [time].har" Differential Revision: https://phabricator.services.mozilla.com/D28732
8f9398c8c37d81bd0c3816ac852c475ac802cabf: Bug 1493599 - Expose reason of security blocking on nsILoadInfo and add new http observer notification for failed asyncOpens, r=Honza,dragana
Honza Bambas <honzab.moz@firemni.cz> - Fri, 26 Apr 2019 10:59:41 +0000 - rev 471469
Push 35918 by rmaries@mozilla.com at Fri, 26 Apr 2019 15:44:19 +0000
Bug 1493599 - Expose reason of security blocking on nsILoadInfo and add new http observer notification for failed asyncOpens, r=Honza,dragana Differential Revision: https://phabricator.services.mozilla.com/D23150
f0905966b59554c33154560667bf39891e79ed61: Bug 1542312 - Add telemetry to track persist option usage in the Netmonitor panel. r=Honza
lloan <lloanalas@outlook.com> - Thu, 25 Apr 2019 07:56:06 +0000 - rev 471255
Push 35913 by rgurzau@mozilla.com at Thu, 25 Apr 2019 16:18:07 +0000
Bug 1542312 - Add telemetry to track persist option usage in the Netmonitor panel. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D27999
137ccf02eefc0049a4887b2541db7355ce00205c: Bug 1545054 - Define a new preset for netmonitor-tests r=Honza,ahal,jdescottes
neha <ns19041997@gmail.com> - Tue, 23 Apr 2019 18:31:19 +0000 - rev 470601
Push 35910 by cbrindusan@mozilla.com at Wed, 24 Apr 2019 21:51:39 +0000
Bug 1545054 - Define a new preset for netmonitor-tests r=Honza,ahal,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D28031
8e100a978832b8844097b54976456a008ff7805c: Bug 1542172 - Firefox freezes when inspecting large POST data. r=Honza
Hemakshi Sachdev <sachdev.hemakshi@gmail.com> - Tue, 23 Apr 2019 13:30:42 +0000 - rev 470485
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1542172 - Firefox freezes when inspecting large POST data. r=Honza Truncate the Request Payload if it exceeds the `devtools.netmonitor.requestBodyLimit` pref and show `Request has been truncated` error in the Params Tab Differential Revision: https://phabricator.services.mozilla.com/D27898