searching for reviewer(Grisha)
d374e582afbc0c9b8b7a1916a08440dff94a9049: Bug 1570690 - Synchronously extract system addons before Gecko startup in Fennec. r=VladBaicu,Grisha
Nick Alexander <nalexander@mozilla.com> - Wed, 14 Aug 2019 18:10:55 +0000 - rev 487996
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1570690 - Synchronously extract system addons before Gecko startup in Fennec. r=VladBaicu,Grisha Right now, there are a lot of things that race to complete before Gecko creates or first reads the profile. One of those things is extracting system addons (the `assets/features/` directory of the APK) to disk, ready for the Gecko profile code to enumerate them. Bug 1534451 added a non-trivial amount of background computation during `onCreate`. This tickled the existing race conditions such that system addon extraction frequently loses the race, making system addons unreliable. In addition, for reasons unknown, `PostUpdateHandler` did its work during `onStart`. But the Gecko profile was created/first read earlier, in `onCreate`. This widened the race window. This commit pulls the update handler into `onCreate`, which is at least early enough for it to have a chance of winning the race; and it makes the work synchronous, which is the simplest way to ensure that it is actually in place before Gecko startup (and profile creation/first read). Since system addons are our "get out of jail" card in many situations, the cost of extracting earlier seems like a good trade-off. That is, I'm sure the early disk access will appear in profiles, and it may even regress Raptor -- but it's a good trade-off. Differential Revision: https://phabricator.services.mozilla.com/D41687
65104032313d24e445cca317abf0749a7fb1b698: Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in mobile/. r=Grisha
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 05 Jun 2019 04:00:09 +0000 - rev 476927
Push 36112 by malexandru@mozilla.com at Wed, 05 Jun 2019 15:52:48 +0000
Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in mobile/. r=Grisha Differential Revision: https://phabricator.services.mozilla.com/D33349
dfdec6abcc4d52fbb7ab10617209c13fd29f78bd: Bug 1505720 crash [@ java.lang.NullPointerException: at org.mozilla.gecko.fxa.authenticator.AndroidFxAccount.renameAccountIfNecessary(AndroidFxAccount.java)] r=Grisha
Andrei Lazar <andrei.a.lazar@softvision.ro> - Tue, 08 Jan 2019 10:28:20 +0000 - rev 452880
Push 35332 by dvarga@mozilla.com at Tue, 08 Jan 2019 16:21:43 +0000
Bug 1505720 crash [@ java.lang.NullPointerException: at org.mozilla.gecko.fxa.authenticator.AndroidFxAccount.renameAccountIfNecessary(AndroidFxAccount.java)] r=Grisha Refreshing account (triggered by signing in) can cause a NullPointerException after quickly signing out. This defect consists in bad sync between the signing in state and signing out state. Differential Revision: https://phabricator.services.mozilla.com/D14269
0ca6e1f583f4444e415f375d8cd5ff88e3a2be9b: Bug 1464003 - Refresh sync preference after rebuilding the list. r=Grisha
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 04 Jan 2019 10:17:03 +0000 - rev 452524
Push 35312 by nerli@mozilla.com at Fri, 04 Jan 2019 16:11:25 +0000
Bug 1464003 - Refresh sync preference after rebuilding the list. r=Grisha Differential Revision: https://phabricator.services.mozilla.com/D15209
8bc5f3cdc25cb9754817ad75d9fa4e158f94042a: Bug 1414084 - Part 17 - Fix setting of private browsing theme state. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 02 Mar 2018 18:01:28 +0100 - rev 431933
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 17 - Fix setting of private browsing theme state. r=Grisha Previously, this wasn't noticeable since adding/removing a PageAction would call refreshPageActionIcons(), which would do the correct thing, but now a newly created PageActionLayout can start with an already pre-populated mPageAction- List, which means that the subsequently arriving call to setPrivateMode() will erroneously activate the private mode tinting for all PageActions that support it. MozReview-Commit-ID: EvNx1Q9vwZ5
f565a28721bf3a0ea5af7ce5ced737d82c7e8803: Bug 1414084 - Part 16 - Add some tests for the handling of PageActions. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 19 Mar 2018 20:27:01 +0100 - rev 431932
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 16 - Add some tests for the handling of PageActions. r=Grisha MozReview-Commit-ID: EUl19vyK3Ra
c2580679282dae363a4ad1ce6f0c477ce00fc212: Bug 1414084 - Part 15 - Correctly remove already resolved PageActions, too. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 03 Mar 2018 18:11:57 +0100 - rev 431931
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 15 - Correctly remove already resolved PageActions, too. r=Grisha When a PageActions:Remove message arrives and we cannot simply forward it, we need to remove not just pending PageActions:Add messages, but also any already present PageActions objects that a former PageActionLayout had handed to us. MozReview-Commit-ID: 3jnGsmMuVfa
e8d7b4fd98387380219b879f8a8b211bb87095c7: Bug 1414084 - Part 14 - Rename isPwaAdded for more clarity. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 20:39:00 +0100 - rev 431930
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 14 - Rename isPwaAdded for more clarity. r=Grisha Despite its name and the original purpose for which it was added, that function generically checks for duplicates among all PageActions, not just the PWA badge. MozReview-Commit-ID: Ae6FsLb9F3S
a40e70bbfe1a544d577c10248251628c134f6b80: Bug 1414084 - Part 13 - Cache PageActions. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 26 Feb 2018 21:50:50 +0100 - rev 431929
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 13 - Cache PageActions. r=Grisha Since converting a PageAction message into an actual PageAction object also en- tails parsing the image data URL into a drawable, we leave that task to the PageActionLayout. This means that the PageAction cache needs to operate slightly differently than the MenuItem cache. First, we store all PageAction BundleEvent messages that arrive while no PageActionLayout is ready and then forward them en masse when one becomes available. Secondly, if the PageActionLayout is going away again, we then also take a list of already parsed PageAction objects for safekeeping. MozReview-Commit-ID: AcPPONXqe46
3dcf1f67d7e476803f0d1daacdf7e1999f7e8724: Bug 1414084 - Part 12 - Add some tests for the processing of Menu messages. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 19 Mar 2018 20:06:32 +0100 - rev 431928
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 12 - Add some tests for the processing of Menu messages. r=Grisha MozReview-Commit-ID: D8Aujo1PgIk
39819b958e01a5112566c760e888ea6f5521c8e3: Bug 1414084 - Part 11 - Use a Map for the MenuItemInfo list. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 18:07:16 +0100 - rev 431927
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 11 - Use a Map for the MenuItemInfo list. r=Grisha Since all related EventDispatcher messages use UUIDs, it makes sense to store our MenuItemInfos in a Map, so we can access them directly by UUID instead of having to iterate over them until we've found the desired one. Since we want to preserve the order in which MenuItemInfos were added, we use a LinkedHashMap. MozReview-Commit-ID: BEtJ59tX59m
47963c0890519069e98cdc89330929b45d7cc79f: Bug 1414084 - Part 10 - Init MenuItemInfo list right from the start. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 17:47:33 +0100 - rev 431926
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 10 - Init MenuItemInfo list right from the start. r=Grisha The small savings in initialising this on demand the first time a menu item is added, are not worth the additional complexity in null checks and the like. MozReview-Commit-ID: Lcz09Ds8NxJ
eb1ac381e2fb7b750482b48557ace56ef6c026f3: Bug 1414084 - Part 9 - Move add-on menu item cache out of BrowserApp. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 25 Feb 2018 22:22:37 +0100 - rev 431925
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 9 - Move add-on menu item cache out of BrowserApp. r=Grisha Bug 832990 solved the issue of us losing the menu item cache if BrowserApp was destroyed, however the issue remains that we'll miss any Menu:... messages that are sent while BrowserApp doesn't exist, e.g. if Gecko is initially loaded through a GeckoView-based activity. Therefore we now move the menu item cache and the listener for those messages into a separate class, whose lifetime better matches that of Gecko. Apart from any necessary changes, we move the existing code as is. The only additional change is that we make addAddonMenuItemToMenu() static, because we can. MozReview-Commit-ID: BJleonLnjmo
84bac01f3a351b774a556dbc47c3305a62e54153: Bug 1414084 - Part 8 - Unify menu item EventDispatcher messages. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 16:42:57 +0100 - rev 431924
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 8 - Unify menu item EventDispatcher messages. r=Grisha As a final step, these can be merged as well. The same reasoning as in the previous patch applies with regards to additional functionality that isn't (yet) used by webextensions. MozReview-Commit-ID: Ezx2mQY0s85
98ed7d6f8a7ab6b35f7ee73e6f0f7db4393ecf2f: Bug 1414084 - Part 7 - Use one set of functions for managing MenuItems in the UI. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 14:17:03 +0100 - rev 431923
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 7 - Use one set of functions for managing MenuItems in the UI. r=Grisha The original add-on functions have some additional capabilities regarding e.g. checkboxes, disabling the menu, etc. that right now aren't required for Webextensions (yet?), but in that case they will simply not be used - in any case BrowserActions.jsm controls what functionality is actually exposed to add-ons. MozReview-Commit-ID: DPT8gV2gb6q
261e4bb6efd87af390d0575f2623e379f979341b: Bug 1414084 - Part 6 - Use only one list to store menu items added from Gecko. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 23 Mar 2018 19:58:18 +0100 - rev 431922
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 6 - Use only one list to store menu items added from Gecko. r=Grisha Now that the UI code for handling both the old NativeWindow API and Web- extensions is more or less the same and both are using the same MenuItemInfo class, there's no longer any real need to keep items added through the two APIs in separate lists - in fact doing so makes it harder to preserve the ordering of menu items if the activity and its menu are destroyed and need to be re- created later on from the stored lists of MenuItemInfos. MozReview-Commit-ID: KlJdvO9WhhY
b6e63d47b9bbafb1bb58571d8abb8906d7a6977a: Bug 1414084 - Part 5 - Unify menu click event handling. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 14:24:15 +0100 - rev 431921
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 5 - Unify menu click event handling. r=Grisha Now that both Webextensions and the NativeWindow API manage their onClick call- back handling by UUID, we can start using the same EventDispatcher message for both. MozReview-Commit-ID: J3RRXrwPdTI
c82c7117206fc5310f9a05b41e80c8d3d58b5542: Bug 1414084 - Part 4 - Move menu item ID generation into the UI. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 15:43:27 +0100 - rev 431920
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 4 - Move menu item ID generation into the UI. r=Grisha Since the NativeWindow API now only uses UUIDs as well when dealing with its consumers, we can leave generation of the menu to the Android UI code of Firefox. MozReview-Commit-ID: 1qDLDnePfFE
d2aa38b39fa086df117be768e0b8f57ea361ffdc: Bug 1414084 - Part 3 - Store NativeWindow menu callbacks by UUID. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:33:42 +0100 - rev 431919
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 3 - Store NativeWindow menu callbacks by UUID. r=Grisha MozReview-Commit-ID: 7nEhAUxOIsW
9fc1c87f952f325a19ee5f41849381aaa534b500: Bug 1414084 - Part 2 - Use UUIDs for the NativeWindow menu API, too. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:26:16 +0100 - rev 431918
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 2 - Use UUIDs for the NativeWindow menu API, too. r=Grisha At the moment, the code for handling of JS-created main menu items is more or less duplicated between the old NativeWindow API and Webextensions, with the only real difference being that the former communicates directly via menu item IDs, while the latter uses UUIDs for messaging between Gecko and the UI. By switching the NativeWindow API to using UUIDs as well, we will be able to start unifying this code again. As for backward compatibility - the return value of NativeWindow.menu.add is valid for the current session only, so no migration is necessary - the return value of NativeWindow.menu add was already effectively only an opaque value which only had real meaning for subsequent calls to menu.add, menu.update and menu.remove, so it shouldn't really matter whether we return a plain numeric ID or an UUID in string form - old-style add-ons are now unsupported for better or for worse and our one in- tree caller won't have any problems with this change MozReview-Commit-ID: HdRNhrx1pu7
65a6e2ffdbaefb0356bad502edfe03df52f102cd: Bug 1414084 - Part 1 - No longer track MenuItemInfo "added" data. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:49:31 +0100 - rev 431917
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 1 - No longer track MenuItemInfo "added" data. r=Grisha We no longer use that value anywhere, so we can just stop keeping track of it. MozReview-Commit-ID: D1IgX1t8SKI
74feab038c3375df282b291682e0b1244c202f00: Bug 1414084 - Part 0 - Cleanups. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 25 Feb 2018 20:53:01 +0100 - rev 431916
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 0 - Cleanups. r=Grisha MozReview-Commit-ID: B3ZGN2X8JXH
a558bb4b9be52659f0be4dc49cea0c96b27cde49: Bug 1363924 p3 - Record commands telemetry events. r=Grisha,tcsc
Edouard Oger <eoger@fastmail.com> - Fri, 02 Feb 2018 13:58:43 -0500 - rev 405373
Push 33519 by aiakab@mozilla.com at Tue, 27 Feb 2018 09:56:16 +0000
Bug 1363924 p3 - Record commands telemetry events. r=Grisha,tcsc MozReview-Commit-ID: 2IRAYdN7BI4
26f6e01a6c2c9af0f8e6e898ed6f9b7b43cf7418: Bug 1363924 p2 - Move deviceID and uid to payload level in sync ping. r=Grisha
Edouard Oger <eoger@fastmail.com> - Tue, 20 Feb 2018 15:01:24 +0800 - rev 405372
Push 33519 by aiakab@mozilla.com at Tue, 27 Feb 2018 09:56:16 +0000
Bug 1363924 p2 - Move deviceID and uid to payload level in sync ping. r=Grisha In the next commit, we will send telemetry events in the sync ping. The "event" JSON object doesn't have "uid"/"deviceID" fields (actually, the "sync" objects shouldn't have them either!). Let's do the right thing and send deviceID and UID as part of the top-level "payload" object. MozReview-Commit-ID: 3D3X3PcJAsW
1187a3b7d4e474f7717780702bde2a24e15dec63: Bug 1363924 p1 - Add flowID to Client commands. r=Grisha
Edouard Oger <eoger@fastmail.com> - Fri, 02 Feb 2018 13:57:17 -0500 - rev 405371
Push 33519 by aiakab@mozilla.com at Tue, 27 Feb 2018 09:56:16 +0000
Bug 1363924 p1 - Add flowID to Client commands. r=Grisha MozReview-Commit-ID: 58rumpyfQy6
08747734c0fde411e95880d8349dd24e73452e46: Bug 1363924 p3 - Record commands telemetry events. r=Grisha,tcsc
Edouard Oger <eoger@fastmail.com> - Fri, 02 Feb 2018 13:58:43 -0500 - rev 405361
Push 33519 by aiakab@mozilla.com at Tue, 27 Feb 2018 09:56:16 +0000
Bug 1363924 p3 - Record commands telemetry events. r=Grisha,tcsc MozReview-Commit-ID: 2IRAYdN7BI4
fbba0f58423783452a90f254dc261f2fe37d3e55: Bug 1363924 p2 - Move deviceID and uid to payload level in sync ping. r=Grisha
Edouard Oger <eoger@fastmail.com> - Tue, 20 Feb 2018 15:01:24 +0800 - rev 405360
Push 33519 by aiakab@mozilla.com at Tue, 27 Feb 2018 09:56:16 +0000
Bug 1363924 p2 - Move deviceID and uid to payload level in sync ping. r=Grisha In the next commit, we will send telemetry events in the sync ping. The "event" JSON object doesn't have "uid"/"deviceID" fields (actually, the "sync" objects shouldn't have them either!). Let's do the right thing and send deviceID and UID as part of the top-level "payload" object. MozReview-Commit-ID: 3D3X3PcJAsW
d30f27293117c2b67fa139aa296bca4337980012: Bug 1363924 p1 - Add flowID to Client commands. r=Grisha
Edouard Oger <eoger@fastmail.com> - Fri, 02 Feb 2018 13:57:17 -0500 - rev 405359
Push 33519 by aiakab@mozilla.com at Tue, 27 Feb 2018 09:56:16 +0000
Bug 1363924 p1 - Add flowID to Client commands. r=Grisha MozReview-Commit-ID: 58rumpyfQy6
ed39e473b31e17d58e828427668eea626cdac6a1: Bug 1439459 - Expose MOZ_ANDROID_GOOGLE_PLAY_SERVICES to AndroidManifest.xml. r=Grisha
Nick Alexander <nalexander@mozilla.com> - Tue, 20 Feb 2018 10:06:13 -0800 - rev 404549
Push 33482 by rgurzau@mozilla.com at Wed, 21 Feb 2018 10:00:30 +0000
Bug 1439459 - Expose MOZ_ANDROID_GOOGLE_PLAY_SERVICES to AndroidManifest.xml. r=Grisha This was oversight when landing Bug 1419581, coupled with dedicated testing by Grisha. We don't expose all CONFIG values as DEFINES by default, and I forgot to add the relevant value to the exposure list. MozReview-Commit-ID: GUYNWampBAJ
0de748c25f49eb1076867cd99c98ddf0673c045b: Bug 1234008 - Recompress some png images with zopflipng r=Dolske,Grisha,jryans
Timothy Guan-tin Chien <timdream@gmail.com> - Sat, 27 Jan 2018 15:57:42 +0800 - rev 404162
Push 33456 by rgurzau@mozilla.com at Fri, 16 Feb 2018 22:08:24 +0000
Bug 1234008 - Recompress some png images with zopflipng r=Dolske,Grisha,jryans MozReview-Commit-ID: Cr2iMSB04uu
e5209339907d39f210e06e21e7b797b2605e3f9e: Bug 1389233 - Record outgoing batches in the android sync ping r=Grisha
Thom Chiovoloni <tchiovoloni@mozilla.com> - Wed, 31 Jan 2018 16:13:19 -0500 - rev 402972
Push 33408 by csabou@mozilla.com at Fri, 09 Feb 2018 00:28:58 +0000
Bug 1389233 - Record outgoing batches in the android sync ping r=Grisha MozReview-Commit-ID: JUHSMluUE8q
fd684a8d5206360d5a001d1391906be3b19d2fd9: Bug 832990 - Part 2 - Save and restore menu item caches via savedInstanceState. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 25 Jan 2018 20:47:16 +0100 - rev 401972
Push 33359 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:01:45 +0000
Bug 832990 - Part 2 - Save and restore menu item caches via savedInstanceState. r=Grisha MozReview-Commit-ID: 6x5BDqhwabS
3f03169f58a9f14e99da105ace4482b5abae56a2: Bug 832990 - Part 1 - Make MenuItemInfo classes parcelable. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 25 Jan 2018 20:20:35 +0100 - rev 401971
Push 33359 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:01:45 +0000
Bug 832990 - Part 1 - Make MenuItemInfo classes parcelable. r=Grisha Longer term, the MenuItemInfo handling needs to be moved out of BrowserApp in order to solve bug 1414084 [1], but the easier short term solution is to just save the cached menu data via the savedInstanceState. This means that MenuItemInfo and friends have to be made parcelable. [1] Because of GeckoView, add-ons may load (and attempt to add menu items) while BrowserApp isn't even alive. MozReview-Commit-ID: HzPe7ZKbJOj
8dee38a1aeecef6ab7546c1307f2366590cf6744: Bug 832990 - Part 0 - Improve comment wording. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 25 Jan 2018 20:46:27 +0100 - rev 401970
Push 33359 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:01:45 +0000
Bug 832990 - Part 0 - Improve comment wording. r=Grisha Since custom tabs and PWAs were moved to GeckoView, we're down to one GeckoApp-based activity again. MozReview-Commit-ID: 1zO6JTDptpp
b965504fcb8171d2779bd3fcc57541539b8bfdad: Bug 1427260 - Skip deleted items when getting Activity Stream highlights. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 05 Jan 2018 20:43:06 +0100 - rev 400259
Push 33300 by dluca@mozilla.com at Tue, 23 Jan 2018 10:00:03 +0000
Bug 1427260 - Skip deleted items when getting Activity Stream highlights. r=Grisha All they do is clutter up the log with "HighlightsRanking: Skipping invalid highlight item." entries, so we should just skip them in the query already. MozReview-Commit-ID: 1ra7LcYxp4m
3b128657b9ebfd6da03de527f3484e144645e9fd: Bug 888784 - Make sure Fennec's Sanitizer.jsm resolves a clearing Promise only after a data clearing attempt has finished. r=Grisha
Mike Conley <mconley@mozilla.com> - Tue, 09 Jan 2018 15:48:33 -0500 - rev 400208
Push 33298 by rgurzau@mozilla.com at Tue, 23 Jan 2018 00:20:46 +0000
Bug 888784 - Make sure Fennec's Sanitizer.jsm resolves a clearing Promise only after a data clearing attempt has finished. r=Grisha MozReview-Commit-ID: 62JjwgozS5b
5044e2244d17f8f8245a6f4f2a24746266ea83c9: Bug 888784 - Make sure Fennec's Sanitizer.jsm resolves a clearing Promise only after a data clearing attempt has finished. r=Grisha
Mike Conley <mconley@mozilla.com> - Tue, 09 Jan 2018 15:48:33 -0500 - rev 400186
Push 33298 by rgurzau@mozilla.com at Tue, 23 Jan 2018 00:20:46 +0000
Bug 888784 - Make sure Fennec's Sanitizer.jsm resolves a clearing Promise only after a data clearing attempt has finished. r=Grisha MozReview-Commit-ID: 62JjwgozS5b
65f08f1b6fb2b3ed566d153f4d2aa1bad0c525a8: Bug 1415656 - Fix android serializing dateAdded as a string in sync bookmark records r=Grisha
Thom Chiovoloni <tchiovoloni@mozilla.com> - Tue, 14 Nov 2017 15:14:08 -0500 - rev 392050
Push 32910 by rgurzau@mozilla.com at Thu, 16 Nov 2017 10:02:59 +0000
Bug 1415656 - Fix android serializing dateAdded as a string in sync bookmark records r=Grisha MozReview-Commit-ID: 1u9DeVvYwjY
7f0357dd1f97971d73f24bdba24850a51491b958: Bug 1409087 - Part 4: Remove browser JUnit 3 tests and build apparatus for {browser,background}.apk. r=Grisha,ted.mielczarek
Nick Alexander <nalexander@mozilla.com> - Thu, 02 Nov 2017 16:03:00 -0700 - rev 390604
Push 32838 by nbeleuzu@mozilla.com at Wed, 08 Nov 2017 10:46:55 +0000
Bug 1409087 - Part 4: Remove browser JUnit 3 tests and build apparatus for {browser,background}.apk. r=Grisha,ted.mielczarek The browser JUnit 3 test suite has never run in automation, and no test has been added or updated since 2016. Half of the existing "tests" are broken on my local device. This allows to clean several Makefile's related to this undeveloped testing approach, which won't be pursued post-Gradle. MozReview-Commit-ID: 1EbGMLntuyR
02cd8929225a35bb59f5de8fe3c84497151a0e68: Bug 1409087 - Part 3: Move services integration tests into standard Gradle location. r=Grisha
Nick Alexander <nalexander@mozilla.com> - Thu, 02 Nov 2017 15:55:03 -0700 - rev 390603
Push 32838 by nbeleuzu@mozilla.com at Wed, 08 Nov 2017 10:46:55 +0000
Bug 1409087 - Part 3: Move services integration tests into standard Gradle location. r=Grisha This is the result of `hg mv mobile/android/tests/background/junit3/src mobile/android/services/src/androidTest/java` MozReview-Commit-ID: AdoNfDDthku
6565cf9eed28dcf180231d0fd8c8de245e0c816d: Bug 1409087 - Part 2: Move Fennec unit tests into standard Gradle locations. r=Grisha
Nick Alexander <nalexander@mozilla.com> - Thu, 02 Nov 2017 16:06:57 -0700 - rev 390602
Push 32838 by nbeleuzu@mozilla.com at Wed, 08 Nov 2017 10:46:55 +0000
Bug 1409087 - Part 2: Move Fennec unit tests into standard Gradle locations. r=Grisha These crept into the services/ hierarchy because there was no alternative, way back when. This both normalizes the (unit) tests and splits the services tests away from the Fennec tests. The Fennec tests grew in the same location as the services (nee background) tests, simply because there was no other location moons ago. It is the result of the following bash script: ``` #!/bin/bash set -x -e -v hg revert mobile/android hg purge mobile/android mkdir -p mobile/android/services/src/test/java/org/mozilla hg mv mobile/android/tests/background/junit4/src/org/mozilla/android mobile/android/services/src/test/java/org/mozilla/ mkdir -p mobile/android/services/src/test/java/org/mozilla/gecko hg mv mobile/android/tests/background/junit4/src/org/mozilla/gecko/background mobile/android/services/src/test/java/org/mozilla/gecko/ hg mv mobile/android/tests/background/junit4/src/org/mozilla/gecko/browserid mobile/android/services/src/test/java/org/mozilla/gecko/ hg mv mobile/android/tests/background/junit4/src/org/mozilla/gecko/db mobile/android/services/src/test/java/org/mozilla/gecko/ hg mv mobile/android/tests/background/junit4/src/org/mozilla/gecko/fxa mobile/android/services/src/test/java/org/mozilla/gecko/ hg mv mobile/android/tests/background/junit4/src/org/mozilla/gecko/sync mobile/android/services/src/test/java/org/mozilla/gecko/ hg mv mobile/android/tests/background/junit4/src/org/mozilla/gecko/tokenserver mobile/android/services/src/test/java/org/mozilla/gecko/ mkdir -p mobile/android/app/src/test hg mv mobile/android/tests/background/junit4/src/* mobile/android/app/src/test/java/ ``` MozReview-Commit-ID: 15AHXZilqFQ
0e29a3d47257519794b39c4a6182da4553cfd8ec: Bug 1409087 - Part 1: Purge typoed javaddons directory. r=Grisha
Nick Alexander <nalexander@mozilla.com> - Thu, 02 Nov 2017 15:13:37 -0700 - rev 390601
Push 32838 by nbeleuzu@mozilla.com at Wed, 08 Nov 2017 10:46:55 +0000
Bug 1409087 - Part 1: Purge typoed javaddons directory. r=Grisha MozReview-Commit-ID: Cu3yTi6zUQK
38d2f90e0bc5c0ab9d15457ae0b5c491be2ba075: Bug 1404044 - Prevent android sync from failing on overlarge timestamps in password sync r=Grisha
Thom Chiovoloni <tchiovoloni@mozilla.com> - Fri, 20 Oct 2017 15:46:05 -0400 - rev 387630
Push 32732 by archaeopteryx@coole-files.de at Mon, 23 Oct 2017 21:48:58 +0000
Bug 1404044 - Prevent android sync from failing on overlarge timestamps in password sync r=Grisha This was done by way of hacking our vendored version of org.simple.json. MozReview-Commit-ID: GpTFpmeevVN
b2cb1033ae1119af28a4c91aa92cef11c4838180: Bug 1409860 - Move os to correct place in android sync ping r=Grisha
Thom Chiovoloni <tchiovoloni@mozilla.com> - Thu, 19 Oct 2017 13:35:16 -0400 - rev 387476
Push 32720 by archaeopteryx@coole-files.de at Sat, 21 Oct 2017 08:58:11 +0000
Bug 1409860 - Move os to correct place in android sync ping r=Grisha MozReview-Commit-ID: DBn8MMVgKPM
5934eecb4afc3650da52044346124cb2979937d6: Bug 1410145 - Fix wrong version field in android sync ping. r=Grisha
Thom Chiovoloni <tchiovoloni@mozilla.com> - Thu, 19 Oct 2017 12:56:56 -0400 - rev 387475
Push 32720 by archaeopteryx@coole-files.de at Sat, 21 Oct 2017 08:58:11 +0000
Bug 1410145 - Fix wrong version field in android sync ping. r=Grisha MozReview-Commit-ID: 1Q4Dz7g5QPA
f6d36649e0d129145a8968658d0d3c62475c141e: Bug 1407743 - Show display name or "Firefox Accounts" in sync preference button. r=Grisha
Edouard Oger <eoger@fastmail.com> - Fri, 13 Oct 2017 15:41:57 -0400 - rev 387304
Push 32716 by archaeopteryx@coole-files.de at Fri, 20 Oct 2017 09:38:32 +0000
Bug 1407743 - Show display name or "Firefox Accounts" in sync preference button. r=Grisha MozReview-Commit-ID: HO7sOGrGNks
00fd9db200d651e41f458ba02c7f1bf2074e9084: Bug 1409472 - Replace always-wrong instanceof check with an explicit boolean in BatchingUploader. r=Grisha
Thom Chiovoloni <tchiovoloni@mozilla.com> - Tue, 17 Oct 2017 15:33:34 -0400 - rev 387264
Push 32716 by archaeopteryx@coole-files.de at Fri, 20 Oct 2017 09:38:32 +0000
Bug 1409472 - Replace always-wrong instanceof check with an explicit boolean in BatchingUploader. r=Grisha MozReview-Commit-ID: JmJmMwseH3m
2ad9ea63f3cc4413097e3fa2ab978b25836954f1: Bug 1362206 - Have android abort bookmark syncs if a record is too large to upload to the server r=Grisha
Thom Chiovoloni <tchiovoloni@mozilla.com> - Wed, 06 Sep 2017 17:48:18 -0400 - rev 385952
Push 32672 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 09:00:05 +0000
Bug 1362206 - Have android abort bookmark syncs if a record is too large to upload to the server r=Grisha MozReview-Commit-ID: JBggAu9Ajbu
ff0c7c7b107438f6c3619b64577be85fc5135f05: Bug 1407728 - Add reason field to messages sent with /notify. r=Grisha
Edouard Oger <eoger@fastmail.com> - Wed, 11 Oct 2017 15:45:25 -0400 - rev 385949
Push 32672 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 09:00:05 +0000
Bug 1407728 - Add reason field to messages sent with /notify. r=Grisha MozReview-Commit-ID: EZbXl2ZoMxK
e1f5954a89e9708dc6cb3601a6731d8c39b38087: Bug 1401749 - Remove fallback int->boolean conversion in FxAccountsDevice. r=Grisha
Edouard Oger <eoger@fastmail.com> - Tue, 10 Oct 2017 12:53:09 -0400 - rev 385885
Push 32672 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 09:00:05 +0000
Bug 1401749 - Remove fallback int->boolean conversion in FxAccountsDevice. r=Grisha MozReview-Commit-ID: miGvypXH1C