searching for reviewer(Gijs)
60f027a372e5baff03aa1463aeed366e2a26d468: Bug 1770137 - Make notification code use Object.create. r=Gijs,freddyb
Peter Van der Beken <peterv@propagandism.org> - Thu, 19 May 2022 14:31:53 +0000 - rev 618247
Push 39720 by nbeleuzu@mozilla.com at Thu, 19 May 2022 18:03:18 +0000
Bug 1770137 - Make notification code use Object.create. r=Gijs,freddyb Differential Revision: https://phabricator.services.mozilla.com/D146798
9fe7e79e2e01283e1de3b4df674ec6b5578d8e0e: Bug 1722228 - Fix backspace triggers clearing of site data on macOS. r=pbz,preferences-reviewers,Gijs
Hannah Peuckmann <hpeuckmann@mozilla.com> - Thu, 19 May 2022 06:37:41 +0000 - rev 618206
Push 39719 by smolnar@mozilla.com at Thu, 19 May 2022 16:03:14 +0000
Bug 1722228 - Fix backspace triggers clearing of site data on macOS. r=pbz,preferences-reviewers,Gijs Differential Revision: https://phabricator.services.mozilla.com/D145540
c2221e86cb617fa2947a9a82c47207569f171823: Bug 1769804 - Only draw separator next to Fx View entrypoint if button is in the tabstrip to the left of tabs. r=Gijs
Dão Gottwald <dao@mozilla.com> - Thu, 19 May 2022 04:10:24 +0000 - rev 618191
Push 39718 by ccozmuta@mozilla.com at Thu, 19 May 2022 09:37:29 +0000
Bug 1769804 - Only draw separator next to Fx View entrypoint if button is in the tabstrip to the left of tabs. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146701
75ea4a45632b6e414863c2463d6963e1ad909713: Bug 1766714 - Advance fxview sync setup to next state when services.sync.engine.tabs is enabled. r=Gijs
Sam Foster <sfoster@mozilla.com> - Thu, 19 May 2022 02:15:38 +0000 - rev 618190
Push 39718 by ccozmuta@mozilla.com at Thu, 19 May 2022 09:37:29 +0000
Bug 1766714 - Advance fxview sync setup to next state when services.sync.engine.tabs is enabled. r=Gijs * Observe the 'services.sync.engine.tabs' pref and skip the tab sync step when it is enabled * Hook up the primary button on that step to enable the pref * Add tests for both paths through this setup Differential Revision: https://phabricator.services.mozilla.com/D146003
c460b3e1bbd03c39ecf16d0eb05ffec26e50acc0: Bug 1769569 - Fix remaining ESLint no-undef and no-unused-vars issues in sjs files. r=Gijs
Mark Banner <standard8@mozilla.com> - Wed, 18 May 2022 08:13:19 +0000 - rev 618083
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769569 - Fix remaining ESLint no-undef and no-unused-vars issues in sjs files. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146452
0323be8b513282415340f97285835abf0a85eff7: Bug 1769569 - Automatically replace Components.* with C* in sjs files. r=Gijs
Mark Banner <standard8@mozilla.com> - Wed, 18 May 2022 08:13:19 +0000 - rev 618082
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769569 - Automatically replace Components.* with C* in sjs files. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146451
47265cc6e8200ce0cd6480525b4ab7ba42ae79d8: Bug 1769569 - Disable reject-importGlobalProperties for sjs files via the ESLint rule. r=Gijs
Mark Banner <standard8@mozilla.com> - Wed, 18 May 2022 08:13:18 +0000 - rev 618081
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769569 - Disable reject-importGlobalProperties for sjs files via the ESLint rule. r=Gijs Depends on D146450 Differential Revision: https://phabricator.services.mozilla.com/D146598
fd92487387bd3f5ea94a036bca3ae35b7fbcb574: Bug 1769569 - Make use-cc-etc auto-fixable. r=Gijs
Mark Banner <standard8@mozilla.com> - Wed, 18 May 2022 08:13:18 +0000 - rev 618080
Push 39716 by ncsoregi@mozilla.com at Wed, 18 May 2022 21:42:45 +0000
Bug 1769569 - Make use-cc-etc auto-fixable. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146450
b80ed974bdccae464a66a32256b995f4f65eb95d: Bug 1514936, part 1 - Remove the outer argument to nsIFactory::createInstance. r=xpcom-reviewers,preferences-reviewers,nika,Gijs
Andrew McCreight <continuation@gmail.com> - Tue, 17 May 2022 20:24:19 +0000 - rev 618033
Push 39712 by abutkovits@mozilla.com at Wed, 18 May 2022 03:14:37 +0000
Bug 1514936, part 1 - Remove the outer argument to nsIFactory::createInstance. r=xpcom-reviewers,preferences-reviewers,nika,Gijs This patch won't actually build, because a few bits of code are used for both nsIFactory::createInstance and static components, and static components are not fixed until the next patch. The first place is nsLoadGroupConstructor, which uses an nsIFactory macro to create a static component constructor. (This could be worked around by expanding the macro to the state before this patch.) The other issue is that nsAppShellConstructor is used in an nsIFactory on OSX, but as a static component on all other platforms. This could be worked around by wrapping nsAppShellConstructor in an adaptor that passes in the extra null argument to nsAppShellConstructor. Differential Revision: https://phabricator.services.mozilla.com/D146456
66a42eb3a3664fef1798920a2915f525f0cf9747: Bug 1769569 - Fix remaining ESLint no-undef and no-unused-vars issues in sjs files. r=Gijs
Mark Banner <standard8@mozilla.com> - Tue, 17 May 2022 16:50:33 +0000 - rev 618018
Push 39712 by abutkovits@mozilla.com at Wed, 18 May 2022 03:14:37 +0000
Bug 1769569 - Fix remaining ESLint no-undef and no-unused-vars issues in sjs files. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146452
d3cc9629cd9a9c00b09b72add9f57d30b8af130c: Bug 1769569 - Automatically replace Components.* with C* in sjs files. r=Gijs
Mark Banner <standard8@mozilla.com> - Tue, 17 May 2022 16:50:33 +0000 - rev 618017
Push 39712 by abutkovits@mozilla.com at Wed, 18 May 2022 03:14:37 +0000
Bug 1769569 - Automatically replace Components.* with C* in sjs files. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146451
edcd3dade079ee3fccf9693779bf28c3d9c5a4af: Bug 1769569 - Disable reject-importGlobalProperties for sjs files via the ESLint rule. r=Gijs
Mark Banner <standard8@mozilla.com> - Tue, 17 May 2022 16:50:32 +0000 - rev 618016
Push 39712 by abutkovits@mozilla.com at Wed, 18 May 2022 03:14:37 +0000
Bug 1769569 - Disable reject-importGlobalProperties for sjs files via the ESLint rule. r=Gijs Depends on D146450 Differential Revision: https://phabricator.services.mozilla.com/D146598
29d8dd058b7a126a3ab0656527297928e5997dc4: Bug 1769569 - Make use-cc-etc auto-fixable. r=Gijs
Mark Banner <standard8@mozilla.com> - Tue, 17 May 2022 16:50:32 +0000 - rev 618015
Push 39712 by abutkovits@mozilla.com at Wed, 18 May 2022 03:14:37 +0000
Bug 1769569 - Make use-cc-etc auto-fixable. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146450
b8f9005aa268f8452cfbc17cca807c7d5a61ff8e: Bug 1766087 - Clean up test_blocklistchange.js r=Gijs
Rob Wu <rob@robwu.nl> - Tue, 17 May 2022 15:42:25 +0000 - rev 617892
Push 39712 by abutkovits@mozilla.com at Wed, 18 May 2022 03:14:37 +0000
Bug 1766087 - Clean up test_blocklistchange.js r=Gijs blocklistchange/addon_update*.json contained incorrect values in "version". There is a pattern in the way that these tests are constructed, so test_blocklistchange.json was updated to generate the update manifests, along with extra comments that explain the relation between the various test files. With this change, blocklistchange/ has become fully obsolete and has been removed from the test. As noted in the bug, "softblock5" is not used anywhere, so its references have been removed too. Differential Revision: https://phabricator.services.mozilla.com/D144497
d17f69e5fda2ca977101e134bde8886887530d99: Bug 1766087 - Fix test_blocklistchange.js to use correct versions r=Gijs
Rob Wu <rob@robwu.nl> - Tue, 17 May 2022 15:42:24 +0000 - rev 617891
Push 39712 by abutkovits@mozilla.com at Wed, 18 May 2022 03:14:37 +0000
Bug 1766087 - Fix test_blocklistchange.js to use correct versions r=Gijs The "succesful" update part of the test referenced a XPI where the version differed from the update manifest. This is not supported, the update manifest's version should match the version from the XPI. As noted in the bug, addon_update1.json and addon_update2.json also specify incorrect versions, but as the XPIs are not actually fetched that doesn't matter in the test. (I will address that in the next patch.) Differential Revision: https://phabricator.services.mozilla.com/D144496
f8b149335cd2b8ee8e8a8ca2fa7b59ebca890067: Bug 1768278 - Draw menupopup shadows ourselves on Windows. r=dao,Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 17 May 2022 14:37:24 +0000 - rev 617879
Push 39711 by apavel@mozilla.com at Tue, 17 May 2022 21:26:38 +0000
Bug 1768278 - Draw menupopup shadows ourselves on Windows. r=dao,Gijs This prevents long-standing artifacts on HiDPI screens on context menus and so on. This is much simpler than tooltips because menupopups and panels already have the whole set-up ready. The searchbar.css changes are kind of annoying, but they improve the rendering a lot (see attached screenshots). Let me know if you want me to draw shadows on all panels on Windows like we do on Linux, it's probably doable and cleaner over-all. Differential Revision: https://phabricator.services.mozilla.com/D145818
5a4bdda558ce2f987591132349ab7caad7d3f28d: Bug 1769156 - Use content sig checks for GMP updates if controlling pref is missing. r=Gijs
Bryce Seager van Dyk <bvandyk@mozilla.com> - Mon, 16 May 2022 20:21:27 +0000 - rev 617767
Push 39706 by csabou@mozilla.com at Tue, 17 May 2022 04:09:27 +0000
Bug 1769156 - Use content sig checks for GMP updates if controlling pref is missing. r=Gijs Currently if the pref for using content sig checks with GMP updates is missing we will use cert pinning. I.e. the default behaviour in the absence of a pref value is cert pinning. This changes that so that we use content sig by default. This is done as we're moving to content signatures as default behaviour, so it makes sense to have it be the default if the pref is missing. Differential Revision: https://phabricator.services.mozilla.com/D146260
7bdabd03250fefe6c2cd3886651d607b223792bd: Bug 1769481 - Fix PanelMultiView console warnings. r=Gijs
Shane Hughes <shmediaproductions@gmail.com> - Mon, 16 May 2022 15:23:30 +0000 - rev 617742
Push 39704 by csabou@mozilla.com at Mon, 16 May 2022 21:54:06 +0000
Bug 1769481 - Fix PanelMultiView console warnings. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146393
8de99049f3e37cf18c67f8db28764df73a019b74: Bug 1765319 - Part 5: Stop using global this to access global variable in toolkit/. r=Gijs
Tooru Fujisawa <arai_a@mac.com> - Fri, 13 May 2022 20:12:27 +0000 - rev 617273
Push 39692 by imoraru@mozilla.com at Sat, 14 May 2022 04:09:48 +0000
Bug 1765319 - Part 5: Stop using global this to access global variable in toolkit/. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D144135
976005722087f8b237dd2276d4e0c976547a2125: Bug 1765319 - Part 4: Stop using global this to access global variable in services/. r=Gijs
Tooru Fujisawa <arai_a@mac.com> - Fri, 13 May 2022 20:12:27 +0000 - rev 617272
Push 39692 by imoraru@mozilla.com at Sat, 14 May 2022 04:09:48 +0000
Bug 1765319 - Part 4: Stop using global this to access global variable in services/. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D144134
56baea71b99410466d453ad0e60177906543c646: Bug 1765319 - Part 1: Do not use global this in CustomizableUI.jsm. r=Gijs
Tooru Fujisawa <arai_a@mac.com> - Fri, 13 May 2022 20:12:25 +0000 - rev 617269
Push 39692 by imoraru@mozilla.com at Sat, 14 May 2022 04:09:48 +0000
Bug 1765319 - Part 1: Do not use global this in CustomizableUI.jsm. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D144130
4c13c478fcadd993f3eb2bc07e9c4bc206247091: Bug 1766503 - Add the Firefox View button to the tab bar in customized profiles. r=Gijs
Dão Gottwald <dao@mozilla.com> - Fri, 13 May 2022 12:03:07 +0000 - rev 617183
Push 39692 by imoraru@mozilla.com at Sat, 14 May 2022 04:09:48 +0000
Bug 1766503 - Add the Firefox View button to the tab bar in customized profiles. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146215
43d2e2a15bad84addc66587315975bd88aadeb88: Bug 1722050 - Add policy for opening executable files based on domain/extension pairs. r=Gijs,fluent-reviewers
Mike Kaply <mozilla@kaply.com> - Thu, 12 May 2022 15:22:38 +0000 - rev 617100
Push 39687 by apavel@mozilla.com at Thu, 12 May 2022 21:30:51 +0000
Bug 1722050 - Add policy for opening executable files based on domain/extension pairs. r=Gijs,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D144214
0a74e9a67faa9e61479312740f18ff96873e3349: Bug 1722050 - Add policy for opening executable files based on domain/extension pairs. r=Gijs,fluent-reviewers
Mike Kaply <mozilla@kaply.com> - Thu, 12 May 2022 13:17:30 +0000 - rev 617089
Push 39687 by apavel@mozilla.com at Thu, 12 May 2022 21:30:51 +0000
Bug 1722050 - Add policy for opening executable files based on domain/extension pairs. r=Gijs,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D144214
06ae12479bf260d7b2b5b50caafc70b9593e7ba4: Bug 1767807 - Add rudimentary tests for the hidden Firefox View tab. r=Gijs
Dão Gottwald <dao@mozilla.com> - Wed, 11 May 2022 20:08:22 +0000 - rev 617044
Push 39685 by bszekely@mozilla.com at Thu, 12 May 2022 09:49:57 +0000
Bug 1767807 - Add rudimentary tests for the hidden Firefox View tab. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146105
c4f14febcca52596ea1ab6f5074dbed40c8d9d31: Bug 1768031 - Reject top-level await in modules via an ESLint rule. r=Gijs
Mark Banner <standard8@mozilla.com> - Wed, 11 May 2022 14:08:15 +0000 - rev 616988
Push 39683 by ccozmuta@mozilla.com at Wed, 11 May 2022 21:49:30 +0000
Bug 1768031 - Reject top-level await in modules via an ESLint rule. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D145892
173f25552da9f2d55d61335e7297c658bf38ff82: Bug 1768031 - Add .mjs to ESLint rules. r=Gijs
Mark Banner <standard8@mozilla.com> - Wed, 11 May 2022 14:08:14 +0000 - rev 616987
Push 39683 by ccozmuta@mozilla.com at Wed, 11 May 2022 21:49:30 +0000
Bug 1768031 - Add .mjs to ESLint rules. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D145700
b74f2671fb3b0845493d7e43e0559c26233c9480: Bug 1768845 - Stop changing the Firefox View tab's text color when selected so that the separator doesn't change its color. r=Gijs
Dão Gottwald <dao@mozilla.com> - Wed, 11 May 2022 11:53:01 +0000 - rev 616976
Push 39681 by imoraru@mozilla.com at Wed, 11 May 2022 16:02:29 +0000
Bug 1768845 - Stop changing the Firefox View tab's text color when selected so that the separator doesn't change its color. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D146068
a883941db333e0405279a649c155768e7ab17f85: Bug 1766896 - Redirect attempts to load something else in the Firefox View tab to new tabs. r=Gijs
Dão Gottwald <dao@mozilla.com> - Tue, 10 May 2022 22:16:45 +0000 - rev 616908
Push 39680 by bszekely@mozilla.com at Wed, 11 May 2022 09:42:52 +0000
Bug 1766896 - Redirect attempts to load something else in the Firefox View tab to new tabs. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D145613
2eceb51d31bfb11348c0eb1eb7a6c64254b27ac9: Bug 1767200 - Fix Delete File on history downloads. r=Gijs
Shane Hughes <shmediaproductions@gmail.com> - Tue, 10 May 2022 20:46:42 +0000 - rev 616898
Push 39680 by bszekely@mozilla.com at Wed, 11 May 2022 09:42:52 +0000
Bug 1767200 - Fix Delete File on history downloads. r=Gijs My previous patch for bug 1755570 contained an oversight that caused problems when deleting history downloads' target files. This patch just adds a minimal data removal method to the history download prototype, so the DownloadElementShell methods can execute without exceptions. Differential Revision: https://phabricator.services.mozilla.com/D145279
0c981e973da9776bf6d2dea7625a8179d979c41d: Bug 1568275 - Disable deceptive content prefs when locked. r=preferences-reviewers,Gijs
Mike Kaply <mozilla@kaply.com> - Tue, 10 May 2022 20:13:35 +0000 - rev 616892
Push 39680 by bszekely@mozilla.com at Wed, 11 May 2022 09:42:52 +0000
Bug 1568275 - Disable deceptive content prefs when locked. r=preferences-reviewers,Gijs Differential Revision: https://phabricator.services.mozilla.com/D144476
b122952b2f5b1a3b9955a0c61837dc0bab14795e: Bug 1766533 - Enable ESLint rule no-constant-binary-expression. r=Gijs
Mark Banner <standard8@mozilla.com> - Tue, 10 May 2022 20:04:04 +0000 - rev 616891
Push 39680 by bszekely@mozilla.com at Wed, 11 May 2022 09:42:52 +0000
Bug 1766533 - Enable ESLint rule no-constant-binary-expression. r=Gijs Depends on D145654 Differential Revision: https://phabricator.services.mozilla.com/D145655
e38004bd79c03284f7813f55bb9af7479405ae7a: Bug 1767200 - Fix Delete File on history downloads. r=Gijs
Shane Hughes <shmediaproductions@gmail.com> - Tue, 10 May 2022 10:31:53 +0000 - rev 616822
Push 39676 by abutkovits@mozilla.com at Tue, 10 May 2022 15:51:43 +0000
Bug 1767200 - Fix Delete File on history downloads. r=Gijs My previous patch for bug 1755570 contained an oversight that caused problems when deleting history downloads' target files. This patch just adds a minimal data removal method to the history download prototype, so the DownloadElementShell methods can execute without exceptions. Differential Revision: https://phabricator.services.mozilla.com/D145279
7ee8a12265b13c65e5b093df141d9e4889e5b409: Bug 1759510 - Fix menubar in high contrast mode on Windows r=Gijs
Sarah Clements <sclements@mozilla.com> - Tue, 10 May 2022 09:40:59 +0000 - rev 616818
Push 39676 by abutkovits@mozilla.com at Tue, 10 May 2022 15:51:43 +0000
Bug 1759510 - Fix menubar in high contrast mode on Windows r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D142946
5f7167a8686ef3c397b9df72eca7528fdd8acadb: Bug 1765049 - Filter out illegal paths. r=Gijs
Molly Howell <mhowell@mozilla.com> - Mon, 09 May 2022 19:27:08 +0000 - rev 616716
Push 39673 by nbeleuzu@mozilla.com at Tue, 10 May 2022 03:50:31 +0000
Bug 1765049 - Filter out illegal paths. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D145518
c5bb436ae1c964dddf0f13ffc13b5145d906fa18: Bug 1767200 - Fix Delete File on history downloads. r=Gijs
Shane Hughes <shmediaproductions@gmail.com> - Mon, 09 May 2022 16:23:22 +0000 - rev 616705
Push 39673 by nbeleuzu@mozilla.com at Tue, 10 May 2022 03:50:31 +0000
Bug 1767200 - Fix Delete File on history downloads. r=Gijs My previous patch for bug 1755570 contained an oversight that caused problems when deleting history downloads' target files. This patch just adds a minimal data removal method to the history download prototype, so the DownloadElementShell methods can execute without exceptions. Differential Revision: https://phabricator.services.mozilla.com/D145279
86c81c12b4deda1cc8e7ca16c0ce396b5863ca96: Bug 1637295 - Fix the narrate voice dropdown control to not shift a few pixels when open r=Gijs
Itiel <itiel_yn8@walla.com> - Mon, 09 May 2022 10:35:15 +0000 - rev 616644
Push 39671 by nfay@mozilla.com at Mon, 09 May 2022 15:57:28 +0000
Bug 1637295 - Fix the narrate voice dropdown control to not shift a few pixels when open r=Gijs Also restore the missing bottom border of the whole popup in HCM. Differential Revision: https://phabricator.services.mozilla.com/D145724
247c55ef102e2aafca74f5e82966f0ba3d9a34f9: Bug 1768175 - Clean up some unnecessary global definitions (location, sizeToContent) for ESLint. r=Gijs
Mark Banner <standard8@mozilla.com> - Mon, 09 May 2022 10:15:34 +0000 - rev 616640
Push 39671 by nfay@mozilla.com at Mon, 09 May 2022 15:57:28 +0000
Bug 1768175 - Clean up some unnecessary global definitions (location, sizeToContent) for ESLint. r=Gijs The 'location: true' addition has filtered down to ESLint a while ago, so we no longer need to define it ourselves. sizeToContent can be used from the window object directly. Differential Revision: https://phabricator.services.mozilla.com/D145720
b74624e1b486d6a6586acf57dac099fee2b60dd1: Bug 1768079 - only load myFirefox.ftl in Nightly. r=Gijs
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 07 May 2022 14:57:37 +0000 - rev 616597
Push 39665 by nfay@mozilla.com at Sat, 07 May 2022 21:38:41 +0000
Bug 1768079 - only load myFirefox.ftl in Nightly. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D145676
1d257da28b25843bbd397c1a1d1ba8a900371189: Bug 1768216 - Remove about:firefoxview from gPageIcons. r=Gijs
Dão Gottwald <dao@mozilla.com> - Fri, 06 May 2022 15:51:22 +0000 - rev 616515
Push 39662 by nbeleuzu@mozilla.com at Sat, 07 May 2022 09:54:14 +0000
Bug 1768216 - Remove about:firefoxview from gPageIcons. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D145793
256cc209b60a82d376bb90cd8a1456341efda51c: Bug 1749525 - Download fails because it doesn't contain an auth header. r=Gijs,freddyb
lyavor <lyavor@mozilla.com> - Fri, 06 May 2022 11:56:52 +0000 - rev 616488
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1749525 - Download fails because it doesn't contain an auth header. r=Gijs,freddyb Differential Revision: https://phabricator.services.mozilla.com/D137997
50f76362438c97f3ca98d1bded471dd41fa3cc0b: Bug 1763139 - Add tests for the mobile-client-connected step in the Firefox View sync setup flow. r=Gijs
Sam Foster <sfoster@mozilla.com> - Fri, 06 May 2022 10:31:47 +0000 - rev 616477
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1763139 - Add tests for the mobile-client-connected step in the Firefox View sync setup flow. r=Gijs * High level tests that check we display the correct step in the flow Differential Revision: https://phabricator.services.mozilla.com/D145697
b91422aa4ba10c7068a0b941f382d4c2ff423400: Bug 1746052, on Mac, set the always ask flag for the macbinary type as well, r=Gijs
Neil Deakin <neil@mozilla.com> - Fri, 06 May 2022 10:00:57 +0000 - rev 616473
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1746052, on Mac, set the always ask flag for the macbinary type as well, r=Gijs This test involves clicking on a link to a .bin file. In the Mac test environment, this is given the macbinary content type. This test assumes that it will be octet-stream (another valid content type for the bin extension) and sets the alwaysAskBeforeHandling flag for that, so the dialog never shows up. However, another subtest needs octet-stream to prompt as well, so set the always ask for both. Differential Revision: https://phabricator.services.mozilla.com/D145547
c5206784e1a6ce358093206393525e7b300fee82: Bug 1746052, use validateFileNameForSaving to get and validate the default filename when a document or image is chosen to be saved, r=Gijs
Neil Deakin <neil@mozilla.com> - Fri, 06 May 2022 10:00:55 +0000 - rev 616470
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1746052, use validateFileNameForSaving to get and validate the default filename when a document or image is chosen to be saved, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D135958
45b3ecacb36417d9cd88a7c3155793291448740b: Bug 1746052, don't allow Windows reserved filenames when sanitizing filenames. Move MangleTextToValidFileName to nsLocalFileWin and rename it to CheckForReservedFileName, r=Gijs
Neil Deakin <neil@mozilla.com> - Fri, 06 May 2022 10:00:55 +0000 - rev 616469
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1746052, don't allow Windows reserved filenames when sanitizing filenames. Move MangleTextToValidFileName to nsLocalFileWin and rename it to CheckForReservedFileName, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D138737
ad582bc5019ff4058f42f79fba7125d15da64eed: Bug 1746052, select a default filename for saving if the filename ends up being empty, r=Gijs
Neil Deakin <neil@mozilla.com> - Fri, 06 May 2022 10:00:55 +0000 - rev 616468
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1746052, select a default filename for saving if the filename ends up being empty, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D135957
f47ddc358e1a45996faee7da8161ad1373433012: Bug 1746052, don't modify the extension for text and binary types, as this is the behaviour that save as had, r=Gijs
Neil Deakin <neil@mozilla.com> - Fri, 06 May 2022 10:00:54 +0000 - rev 616466
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1746052, don't modify the extension for text and binary types, as this is the behaviour that save as had, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D135955
f95c284ca227b55e66c79c3726e96d01812103fd: Bug 1746052, use GetValidFileName to determine the filename from the channel when saving a resource, r=Gijs
Neil Deakin <neil@mozilla.com> - Fri, 06 May 2022 10:00:54 +0000 - rev 616465
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1746052, use GetValidFileName to determine the filename from the channel when saving a resource, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D135954
e8245a15c3c9a4be2fa4f8e9ae97dd81290bc63c: Bug 1746052, add methods to the mime service that compute and validate a filename for a given content type, r=Gijs
Neil Deakin <neil@mozilla.com> - Fri, 06 May 2022 10:00:52 +0000 - rev 616461
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1746052, add methods to the mime service that compute and validate a filename for a given content type, r=Gijs The code in SanitizeFilename will be expanded upon in the following patch. Differential Revision: https://phabricator.services.mozilla.com/D135951
d65e39e825687f80e7a676ba7f8faddb403b99f2: Bug 1749998 - Expose alwaysOpenPanel in context menu. r=mak,Gijs,fluent-reviewers,flod
Shane Hughes <shmediaproductions@gmail.com> - Fri, 06 May 2022 08:21:41 +0000 - rev 616443
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1749998 - Expose alwaysOpenPanel in context menu. r=mak,Gijs,fluent-reviewers,flod This patch adds a new menuitem to the toolbar context menu that functions analogously to the downloads button auto-hide menuitem. It's visible when the context menu is opened on the downloads button, and hidden otherwise. It toggles browser.download.alwaysOpenPanel. Also add some tests to make sure it's showing in the correct conditions and having the correct effect in practice. While we're at it, make some slight simplifications of related tests. Differential Revision: https://phabricator.services.mozilla.com/D145284