searching for reviewer(Gijs)
dfabf5135cf1b219f4ea809d4b066ffe5d8a3cef: Bug 1553387 - Use createXULElement for 'window' menuitems on osx r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 23 May 2019 15:12:21 +0000 - rev 475208
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1553387 - Use createXULElement for 'window' menuitems on osx r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D32166
595c3065e9ac64ed1d4ada38c3a83c6ba2a0ff91: Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs
Andrew Swan <aswan@mozilla.com> - Tue, 14 May 2019 20:39:38 -0700 - rev 475142
Push 36055 by dvarga@mozilla.com at Thu, 23 May 2019 15:55:11 +0000
Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs The "add search engine" page action wants to use badged toolbarbuttons, but it does this by adding the "badged-button" class (which changes the XBL binding) after the button has already been created and added to the DOM. To avoid having to switch between non-badged and badged buttons when toolbarbutton is converted to custom elements, add a property to page actions so that the badged status can be determined when the element is created. Differential Revision: https://phabricator.services.mozilla.com/D31940
dd05a7d4bd38f2d9911e355ac1fdd9ec80a75829: Bug 1553387 - Use createXULElement for 'window' menuitems on osx r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 22 May 2019 21:09:52 +0000 - rev 475095
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1553387 - Use createXULElement for 'window' menuitems on osx r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D32166
0ea1bd2302b2713271b60d799b872669835ed880: Bug 1551334 - Migrate OSX hidden window from XUL to XHTML r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 22 May 2019 18:00:13 +0000 - rev 475035
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1551334 - Migrate OSX hidden window from XUL to XHTML r=Gijs Also take the oppurtunity to include "mac" in the filename to clarify where it's used. Differential Revision: https://phabricator.services.mozilla.com/D32058
b70f5f87bd30732d05d1f663b7b8c933ed242eef: Bug 1552302 - Link policy message to about:policies. r=Gijs
Michael Kaply <mozilla@kaply.com> - Wed, 22 May 2019 14:34:44 +0000 - rev 474971
Push 36052 by btara@mozilla.com at Thu, 23 May 2019 04:37:46 +0000
Bug 1552302 - Link policy message to about:policies. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D32061
ee7e04b12dd34b89aff8a4e0ba5ae3dc5be7d9f9: Bug 1548542 - Remove notions of Kinto in blocklists unit tests r=keeler,Gijs
Mathieu Leplatre <mathieu@mozilla.com> - Wed, 22 May 2019 11:25:04 +0000 - rev 474900
Push 36050 by shindli@mozilla.com at Wed, 22 May 2019 15:25:01 +0000
Bug 1548542 - Remove notions of Kinto in blocklists unit tests r=keeler,Gijs Differential Revision: https://phabricator.services.mozilla.com/D31221
134250706ea6c5988546c73f808815acfc80688e: Bug 1526018 - Initialize PSM clients in their own service r=Gijs,jcj
Mathieu Leplatre <mathieu@mozilla.com> - Tue, 21 May 2019 21:14:11 +0000 - rev 474898
Push 36050 by shindli@mozilla.com at Wed, 22 May 2019 15:25:01 +0000
Bug 1526018 - Initialize PSM clients in their own service r=Gijs,jcj Differential Revision: https://phabricator.services.mozilla.com/D31603
63587b402c35ba828007cf7b8b4c9a23fcf97e85: Bug 965637: Move CSP from Principal into Client, part 3: frontend changes. r=Gijs
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Tue, 21 May 2019 23:15:08 +0000 - rev 474864
Push 36047 by nerli@mozilla.com at Wed, 22 May 2019 03:40:58 +0000
Bug 965637: Move CSP from Principal into Client, part 3: frontend changes. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27656
bcedf1e9b09c487430362a5cfb0e8e96fb09246e: Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs
Andrew Swan <aswan@mozilla.com> - Tue, 21 May 2019 19:26:23 +0000 - rev 474837
Push 36047 by nerli@mozilla.com at Wed, 22 May 2019 03:40:58 +0000
Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs The "add search engine" page action wants to use badged toolbarbuttons, but it does this by adding the "badged-button" class (which changes the XBL binding) after the button has already been created and added to the DOM. To avoid having to switch between non-badged and badged buttons when toolbarbutton is converted to custom elements, add a property to page actions so that the badged status can be determined when the element is created. Differential Revision: https://phabricator.services.mozilla.com/D31940
350f7249407d5156f831562b38807111790e8e74: Bug 1442271 - Cookie imports fail on newer versions of Chrome r=Gijs
Trishul <trishul.goel@gmail.com> - Tue, 21 May 2019 12:40:22 +0000 - rev 474805
Push 36046 by aiakab@mozilla.com at Tue, 21 May 2019 21:45:52 +0000
Bug 1442271 - Cookie imports fail on newer versions of Chrome r=Gijs DB field name is changed in chrome, so matching that. Cookie imports fail on newer versions of Chrome Differential Revision: https://phabricator.services.mozilla.com/D31976
a7d63c14adadefdef9dd811da3362416acfb8bf0: Bug 1552907 - Remove unused remote action methods from NormandyApi.jsm r=Gijs
Michael Cooper <mcooper@mozilla.com> - Tue, 21 May 2019 09:39:35 +0000 - rev 474766
Push 36046 by aiakab@mozilla.com at Tue, 21 May 2019 21:45:52 +0000
Bug 1552907 - Remove unused remote action methods from NormandyApi.jsm r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D31814
62321377e204a921c6cf4282565756267fbea2dc: Bug 1552219. Get rid of unnecessary variables that clutter PrintUtils.printWindow. r=Gijs
Jonathan Watt <jwatt@jwatt.org> - Fri, 03 May 2019 07:34:07 +0100 - rev 474356
Push 36031 by rgurzau@mozilla.com at Fri, 17 May 2019 21:43:13 +0000
Bug 1552219. Get rid of unnecessary variables that clutter PrintUtils.printWindow. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D31488
b8de4598780a6e000e3cd3b8fbde5ba3b972c492: Bug 1456725 - Tabs.jsm: Update documentURI in waitForCondition to handle not yet loaded tabs. r=Gijs
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 16 May 2019 00:29:14 +0000 - rev 474012
Push 36020 by dvarga@mozilla.com at Thu, 16 May 2019 04:15:07 +0000
Bug 1456725 - Tabs.jsm: Update documentURI in waitForCondition to handle not yet loaded tabs. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D31340
bf04bcac450c62314cd6d4deed2b3629651c54e4: Bug 1471522 - Move blocklist target app filter to Blocklist module r=Gijs
Mathieu Leplatre <mathieu@mozilla.com> - Wed, 15 May 2019 22:22:50 +0000 - rev 474002
Push 36020 by dvarga@mozilla.com at Thu, 16 May 2019 04:15:07 +0000
Bug 1471522 - Move blocklist target app filter to Blocklist module r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D31222
255211227da24911c8ce2112de7f9d26d2a13bbf: Bug 1501214 - Reusable helper to download Remote Settings attachments r=nanj,glasserc,Gijs
Mathieu Leplatre <mathieu@mozilla.com> - Fri, 10 May 2019 22:57:40 +0000 - rev 473486
Push 35998 by rmaries@mozilla.com at Sat, 11 May 2019 09:44:50 +0000
Bug 1501214 - Reusable helper to download Remote Settings attachments r=nanj,glasserc,Gijs Reusable helper to download Remote Settings attachments Differential Revision: https://phabricator.services.mozilla.com/D28707
7e1942ace2b27c0905642f3c2ea83c848ba947b1: Bug 1501214 - Reusable helper to download Remote Settings attachments r=nanj,glasserc,Gijs
Mathieu Leplatre <mathieu@mozilla.com> - Wed, 08 May 2019 16:18:07 +0000 - rev 473088
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1501214 - Reusable helper to download Remote Settings attachments r=nanj,glasserc,Gijs Reusable helper to download Remote Settings attachments Differential Revision: https://phabricator.services.mozilla.com/D28707
9518f9e5ecf9e34e618e728dc8725534bd7a0b70: Bug 1547635: PanelMultiView: Don't override keyboard navigation in context menus. r=Gijs
James Teh <jteh@mozilla.com> - Wed, 08 May 2019 05:18:17 +0000 - rev 473001
Push 35985 by dvarga@mozilla.com at Wed, 08 May 2019 11:13:21 +0000
Bug 1547635: PanelMultiView: Don't override keyboard navigation in context menus. r=Gijs Normally, context menu keyboard handling takes precedence. However, because we have a capturing window keydown listener, our listener takes precedence. Therefore, we need to check for an open context menu and suppress our keyboard handling in this case. Differential Revision: https://phabricator.services.mozilla.com/D29791
6ad2b2b28addd2d74dd85e21caac7e2cb631e776: Bug 1549543 Make search initialization failures more obvious r=Gijs
Andrew Swan <aswan@mozilla.com> - Tue, 07 May 2019 13:46:17 +0000 - rev 472925
Push 35983 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:38:51 +0000
Bug 1549543 Make search initialization failures more obvious r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D30094
4d11e2cf33f3513dcd7072a7f6ea2124366054f1: Bug 1395824 Add css for table borders in aboutReader.css r=Gijs
Sonali9 <sonali18317@iiitd.ac.in> - Mon, 06 May 2019 19:00:03 +0000 - rev 472761
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1395824 Add css for table borders in aboutReader.css r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D29957
59dc2743695d817f095bf76acce8de6073b26598: Bug 1532318 - Part 3 : update js code related to the change of nsIHttpChannel r=Gijs
Thomas Nguyen <tnguyen@mozilla.com> - Thu, 02 May 2019 12:34:06 +0000 - rev 472274
Push 35952 by rgurzau@mozilla.com at Thu, 02 May 2019 22:00:13 +0000
Bug 1532318 - Part 3 : update js code related to the change of nsIHttpChannel r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D22787
f6903c331545b2aa793ea72f4a59c39ff2b0a13c: Bug 1546633: PanelMultiView: Send mousedown event when activating a button via the keyboard. r=Gijs
James Teh <jteh@mozilla.com> - Thu, 02 May 2019 10:35:57 +0000 - rev 472254
Push 35951 by cbrindusan@mozilla.com at Thu, 02 May 2019 15:30:19 +0000
Bug 1546633: PanelMultiView: Send mousedown event when activating a button via the keyboard. r=Gijs Previously, we sent a command event and a click event. Normally, the command event executes the action, then the click event closes the menu. However, in some cases (e.g. the Library button), there is no command event handler and the mousedown event executes the action instead. Differential Revision: https://phabricator.services.mozilla.com/D29151
216b689c8984878e48ab5aa879510032da0f0a1f: Bug 1545766: PanelMultiView: Don't override keyboard navigation in embedded documents. r=Gijs
James Teh <jteh@mozilla.com> - Thu, 02 May 2019 10:35:49 +0000 - rev 472253
Push 35951 by cbrindusan@mozilla.com at Thu, 02 May 2019 15:30:19 +0000
Bug 1545766: PanelMultiView: Don't override keyboard navigation in embedded documents. r=Gijs Extension panels contain embedded documents; i.e. a <browser> element. We want users to be able to tab to these and we want them to be focused automatically if a subview is opened from the keyboard, so treat them as tabbable. However, once an embedded document is focused, we can't manage keyboard navigation inside it, so don't try. Previously, we tried, which meant keys were overridden even though they didn't do anything, breaking keyboard navigation in extensions altogether. Differential Revision: https://phabricator.services.mozilla.com/D28442
041741ce164674137968c39aab0a9c80e84c99db: Bug 1546633: PanelMultiView: Send mousedown event when activating a button via the keyboard. r=Gijs
James Teh <jteh@mozilla.com> - Wed, 01 May 2019 04:01:35 +0000 - rev 472048
Push 35946 by apavel@mozilla.com at Wed, 01 May 2019 15:54:31 +0000
Bug 1546633: PanelMultiView: Send mousedown event when activating a button via the keyboard. r=Gijs Previously, we sent a command event and a click event. Normally, the command event executes the action, then the click event closes the menu. However, in some cases (e.g. the Library button), there is no command event handler and the mousedown event executes the action instead. Differential Revision: https://phabricator.services.mozilla.com/D29151
fbc294a6fe785b56a5ef52b5b1ea61d511bebc52: Bug 1545766: PanelMultiView: Don't override keyboard navigation in embedded documents. r=Gijs
James Teh <jteh@mozilla.com> - Wed, 01 May 2019 04:01:35 +0000 - rev 472047
Push 35946 by apavel@mozilla.com at Wed, 01 May 2019 15:54:31 +0000
Bug 1545766: PanelMultiView: Don't override keyboard navigation in embedded documents. r=Gijs Extension panels contain embedded documents; i.e. a <browser> element. We want users to be able to tab to these and we want them to be focused automatically if a subview is opened from the keyboard, so treat them as tabbable. However, once an embedded document is focused, we can't manage keyboard navigation inside it, so don't try. Previously, we tried, which meant keys were overridden even though they didn't do anything, breaking keyboard navigation in extensions altogether. Differential Revision: https://phabricator.services.mozilla.com/D28442
542aa98191211b92dec7bb0eae8e8c1cd6f69cd7: Bug 1546599 - Reset FxA avatar menu title on logout r=Gijs
Vijay Budhram <vbudhram@mozilla.com> - Wed, 24 Apr 2019 22:41:27 +0000 - rev 471221
Push 35912 by btara@mozilla.com at Thu, 25 Apr 2019 09:46:25 +0000
Bug 1546599 - Reset FxA avatar menu title on logout r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28712
23fa85727bd08cecb31c0bd43f27d9507a6189a6: Bug 1546093 - Fixing typo of about-telemetry-time-stamp-header leading to missing translation in en-US r=Gijs
Christian Frey <christianhfrey@gmail.com> - Wed, 24 Apr 2019 22:35:15 +0000 - rev 471220
Push 35912 by btara@mozilla.com at Thu, 25 Apr 2019 09:46:25 +0000
Bug 1546093 - Fixing typo of about-telemetry-time-stamp-header leading to missing translation in en-US r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28734
4e06efa9d48ede0a40fdbb321c870986e72a0cae: Bug 1546737 - Don't use the hidden window in browser_xhr_sandbox.js. r=Gijs
Felipe Gomes <felipc@gmail.com> - Wed, 24 Apr 2019 22:43:04 +0000 - rev 471218
Push 35912 by btara@mozilla.com at Thu, 25 Apr 2019 09:46:25 +0000
Bug 1546737 - Don't use the hidden window in browser_xhr_sandbox.js. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28710
f9ccfa09fb6d69c35ddeeaf8984c044e8731ca2a: Bug 1546101 - Fixing argument paramater passed to about-telemetry-settings-explanation to fix release vs pre-release info in about:telemetry r=Gijs
Christian Frey <christianhfrey@gmail.com> - Wed, 24 Apr 2019 22:38:10 +0000 - rev 471217
Push 35912 by btara@mozilla.com at Thu, 25 Apr 2019 09:46:25 +0000
Bug 1546101 - Fixing argument paramater passed to about-telemetry-settings-explanation to fix release vs pre-release info in about:telemetry r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28730
92e638c435da77351cd0d9900d9e0d9bf85a610f: Bug 1543080 - Show more options menu on first click r=Gijs
Mark Striemer <mstriemer@mozilla.com> - Wed, 24 Apr 2019 15:10:31 +0000 - rev 471193
Push 35912 by btara@mozilla.com at Thu, 25 Apr 2019 09:46:25 +0000
Bug 1543080 - Show more options menu on first click r=Gijs There was a bug where the panel would be hidden on the first click on Windows (and I think Linux, too). This was happening because the focusin event would trigger after mousedown and hide the panel on the first click. Then the button would have focus and we wouldn't get a focusin on the second click. This updates the focusin handler to check if this is the first focusin event, and ignore it if the event target matches our triggering event's target. Differential Revision: https://phabricator.services.mozilla.com/D28587
0e2ecd6b6f11a52d15f88c16506a9edc5e4e4e15: Bug 1546378: Write cross process CSP inheritance tests. r=Gijs
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Wed, 24 Apr 2019 15:21:37 +0000 - rev 470674
Push 35910 by cbrindusan@mozilla.com at Wed, 24 Apr 2019 21:51:39 +0000
Bug 1546378: Write cross process CSP inheritance tests. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28599
57df9b1a703372161d01f4d5633707e5344c8d3c: Bug 1546378: Write cross process CSP inheritance tests. r=Gijs
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Wed, 24 Apr 2019 11:45:26 +0000 - rev 470640
Push 35910 by cbrindusan@mozilla.com at Wed, 24 Apr 2019 21:51:39 +0000
Bug 1546378: Write cross process CSP inheritance tests. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28599
f40a3485926cadae4bb326767a3ff5268a1814ec: Bug 1513646 - Remove Normandy remote-action infrastructure r=Gijs
Michael Cooper <mcooper@mozilla.com> - Tue, 23 Apr 2019 13:23:07 +0000 - rev 470541
Push 35908 by aciure@mozilla.com at Wed, 24 Apr 2019 04:28:40 +0000
Bug 1513646 - Remove Normandy remote-action infrastructure r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28227
9bc2f8e17d8062bd98fef67460ef0e74d5e0df17: Bug 1546326: Correctly detect missing directories on Windows. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 23 Apr 2019 17:23:35 +0000 - rev 470516
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1546326: Correctly detect missing directories on Windows. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28514
6569e4cca483da6fb943a60e3e60ed4c052f7fc6: Bug 1541167 Stop doing synchronous main-thread I/O to validate the blocklist r=Gijs
Andrew Swan <aswan@mozilla.com> - Tue, 23 Apr 2019 16:11:13 +0000 - rev 470511
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1541167 Stop doing synchronous main-thread I/O to validate the blocklist r=Gijs The main change here is moving the old AddonManager.validateBlocklist() into Blocklist.jsm and getting rid of any main-thread I/O. This patch also includes a small functional change: previously we would always copy the application-supplied blocklist.xml into the profile directory. With this change, blocklist.xml is not copied from the application into the profile. This entails an extra open() when we're falling back to the application-supplied blocklist file but saves all the I/O required to actually copy the file. Differential Revision: https://phabricator.services.mozilla.com/D27829
8ab68eea15b8e9585d0dd3ffd7f499b39a808dcb: Bug 1187696 - Toolbar too bright in Reader dark mode r=Gijs
akshitha <akshithashetty84@gmail.com> - Tue, 23 Apr 2019 16:13:27 +0000 - rev 470509
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1187696 - Toolbar too bright in Reader dark mode r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D26331
8015d85e20f5a3721db7998d7cc3234786eed958: Bug 1544863: Explicitly pass csp to createContentWindow(). r=Gijs,baku
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Tue, 23 Apr 2019 14:37:40 +0000 - rev 470495
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1544863: Explicitly pass csp to createContentWindow(). r=Gijs,baku Differential Revision: https://phabricator.services.mozilla.com/D27871
7d3f2f4c53beb19d3ccd4873a731cf15062170fc: Bug 1544863: Explicitly pass csp to createContentWindow(). r=Gijs,baku
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Tue, 23 Apr 2019 13:02:40 +0000 - rev 470484
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1544863: Explicitly pass csp to createContentWindow(). r=Gijs,baku Differential Revision: https://phabricator.services.mozilla.com/D27871
8ce092764f601dc1d02c2f7a779ff405796b1b03: Bug 1545962 - Use <template> instead of CDATA for about:preferences r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 22 Apr 2019 22:38:57 +0000 - rev 470421
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1545962 - Use <template> instead of CDATA for about:preferences r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28280
fc479e4e17f208520ccfa4fd29bacc1a90ba4bfa: Bug 1519514 - make sure document.l10n is initialized before triggering conext menu over a tab in browser_ext_menus_activeTab.js test r=Gijs
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 22 Apr 2019 20:18:02 +0000 - rev 470417
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1519514 - make sure document.l10n is initialized before triggering conext menu over a tab in browser_ext_menus_activeTab.js test r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28366
7d6de1b4d5f980454e8a924390812743917596f0: Bug 1545052 - Fix broken about:preferences link (Android), r=Gijs
Avery Berninger <berning5@msu.edu> - Mon, 22 Apr 2019 20:37:17 +0000 - rev 470409
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1545052 - Fix broken about:preferences link (Android), r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28169
61587f94c1729e446879c995386ba60fc31f39ba: Bug 1545983 - Update "Recent Closed Tabs" and "Recent Closed Windows" menus to reference their menupopup correctly r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 22 Apr 2019 10:14:44 +0000 - rev 470340
Push 35901 by shindli@mozilla.com at Mon, 22 Apr 2019 15:47:10 +0000
Bug 1545983 - Update "Recent Closed Tabs" and "Recent Closed Windows" menus to reference their menupopup correctly r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28298
9e242ede9b1c647366d60fc2bad3b2c78539c31e: Bug 1542334 - Add FxA toolbar menu to app menu r=Gijs
Vijay Budhram <vbudhram@mozilla.com> - Fri, 19 Apr 2019 14:05:24 +0000 - rev 470205
Push 35890 by dluca@mozilla.com at Fri, 19 Apr 2019 21:44:39 +0000
Bug 1542334 - Add FxA toolbar menu to app menu r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D26377
f0c2b4af4d6dd3d69455e184bbbd635a3de48e42: Bug 1539414 - checkboxes are not redrawn on Win7 classic theme r=Gijs
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 16 Apr 2019 16:01:33 +0000 - rev 470201
Push 35890 by dluca@mozilla.com at Fri, 19 Apr 2019 21:44:39 +0000
Bug 1539414 - checkboxes are not redrawn on Win7 classic theme r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27727
ac2351ce41ef7644f399db4d926e499bbb0db711: Bug 1543828 - Use <bdi> inside video controls content r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 18 Apr 2019 17:45:22 +0000 - rev 470126
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1543828 - Use <bdi> inside video controls content r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27757
f7a15eb24f3de849d7b42dca8b827ade5354df0e: Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 05 Mar 2019 12:51:44 -0800 - rev 470056
Push 35887 by apavel@mozilla.com at Fri, 19 Apr 2019 03:54:33 +0000
Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod On startup we record the size and modified time of the profile lists. If changed we refuse to flush any new changes to disk. Also adds a getter to check if they've changed so the UI can do something sensible. All attempts to flush are now checked for success. In some cases in early startup the failure mode isn't great, we just quit startup. The assumption though is that it's extremely unlikely that the files will have changed on disk in the time between when they are read and when profile selection occurs, likely less than a second later. The profile reset flow is changed to only delete the old profile and flush once all the migration has completed, so if something fails the user gets back to their old profile. In testing I ended up having to fix bug 1522584 so background file deletions on a background thread are safer. I haven't implemented any UI tests right now since making modifications to the profiles means modifying the actual user's profiles which I'm not keen to do. See bug 1539868. Differential Revision: https://phabricator.services.mozilla.com/D25278
081a659775d32b167cb0e74b7fb0e7ab1aee7a62: Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 18 Apr 2019 04:34:29 +0000 - rev 469976
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod On startup we record the size and modified time of the profile lists. If changed we refuse to flush any new changes to disk. Also adds a getter to check if they've changed so the UI can do something sensible. All attempts to flush are now checked for success. In some cases in early startup the failure mode isn't great, we just quit startup. The assumption though is that it's extremely unlikely that the files will have changed on disk in the time between when they are read and when profile selection occurs, likely less than a second later. The profile reset flow is changed to only delete the old profile and flush once all the migration has completed, so if something fails the user gets back to their old profile. In testing I ended up having to fix bug 1522584 so background file deletions on a background thread are safer. I haven't implemented any UI tests right now since making modifications to the profiles means modifying the actual user's profiles which I'm not keen to do. See bug 1539868. Differential Revision: https://phabricator.services.mozilla.com/D25278
77dbf6f2d6d4f9825e9041946f4cb78c75f5a8dd: Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 17 Apr 2019 20:06:20 +0000 - rev 469939
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod On startup we record the size and modified time of the profile lists. If changed we refuse to flush any new changes to disk. Also adds a getter to check if they've changed so the UI can do something sensible. All attempts to flush are now checked for success. In some cases in early startup the failure mode isn't great, we just quit startup. The assumption though is that it's extremely unlikely that the files will have changed on disk in the time between when they are read and when profile selection occurs, likely less than a second later. The profile reset flow is changed to only delete the old profile and flush once all the migration has completed, so if something fails the user gets back to their old profile. In testing I ended up having to fix bug 1522584 so background file deletions on a background thread are safer. I haven't implemented any UI tests right now since making modifications to the profiles means modifying the actual user's profiles which I'm not keen to do. See bug 1539868. Differential Revision: https://phabricator.services.mozilla.com/D25278
f3cde072814736f2e8c533f03b136641b368d51a: Bug 1544909 - Fix appearance of about:telemetry current ping dialog. r=Gijs
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 17 Apr 2019 08:40:12 +0000 - rev 469845
Push 35883 by btara@mozilla.com at Wed, 17 Apr 2019 21:47:29 +0000
Bug 1544909 - Fix appearance of about:telemetry current ping dialog. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27851
c4bdde9df1118e74c3922884677ee769697dc987: Bug 1532701 - Disabled checkboxes should not accept label@control being clicked to toggle their checked state. r=Gijs
Jared Wein <jwein@mozilla.com> - Tue, 16 Apr 2019 21:55:48 +0000 - rev 469799
Push 35882 by cbrindusan@mozilla.com at Wed, 17 Apr 2019 15:54:01 +0000
Bug 1532701 - Disabled checkboxes should not accept label@control being clicked to toggle their checked state. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27825
2a745d4407f448ff7d6d020d7dd4aeb32f4fb139: Bug 1540879 - Stop using deprecated Array generics in tabbox.xml. r=Gijs
Dão Gottwald <dao@mozilla.com> - Wed, 17 Apr 2019 08:38:46 +0000 - rev 469787
Push 35882 by cbrindusan@mozilla.com at Wed, 17 Apr 2019 15:54:01 +0000
Bug 1540879 - Stop using deprecated Array generics in tabbox.xml. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D27754