searching for reviewer(Gijs)
a58c99b9307bd575ce241b8fd4dff29b14b5e0b4: Bug 1792457 - Revert workarounds for weak references to XPCWJS crashes. r=Gijs default tip
Andrew McCreight <continuation@gmail.com> - Thu, 29 Sep 2022 11:40:19 +0000 - rev 636609
Push 40275 by abutkovits@mozilla.com at Thu, 29 Sep 2022 21:45:56 +0000
Bug 1792457 - Revert workarounds for weak references to XPCWJS crashes. r=Gijs I have fixed the underlying XPConnect issue, so these workarounds should no longer be needed. There are also two more in browser/base/content/browser-siteProtections.js that I have not fixed. Differential Revision: https://phabricator.services.mozilla.com/D158158
b7d632209868634d750a201c607b7b20bf6b755f: Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Mark Banner <standard8@mozilla.com> - Thu, 29 Sep 2022 06:52:34 +0000 - rev 636602
Push 40274 by apavel@mozilla.com at Thu, 29 Sep 2022 09:39:14 +0000
Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato Differential Revision: https://phabricator.services.mozilla.com/D158094
53898a90758d93214a404340255c6b6cc98931fe: Bug 1792365 - Convert various toolkit/modules files to system ES modules. r=Gijs
Mark Banner <standard8@mozilla.com> - Thu, 29 Sep 2022 06:52:33 +0000 - rev 636601
Push 40274 by apavel@mozilla.com at Thu, 29 Sep 2022 09:39:14 +0000
Bug 1792365 - Convert various toolkit/modules files to system ES modules. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D158093
10e5e32bd1cb71c7232240eb8b54ee41a02a51c1: Bug 1792365 - Fix some toolkit/modules to pass rejected-words linter. r=Gijs
Mark Banner <standard8@mozilla.com> - Thu, 29 Sep 2022 06:52:33 +0000 - rev 636600
Push 40274 by apavel@mozilla.com at Thu, 29 Sep 2022 09:39:14 +0000
Bug 1792365 - Fix some toolkit/modules to pass rejected-words linter. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D158092
c91bf964f30fd57e7d9c8aede78ac152ae0cd6d1: Bug 1792441 - Keep window open when restoring with hidden tabs. r=Gijs
Niklas Baumgardner <nbaumgardner@mozilla.com> - Thu, 29 Sep 2022 03:08:06 +0000 - rev 636592
Push 40274 by apavel@mozilla.com at Thu, 29 Sep 2022 09:39:14 +0000
Bug 1792441 - Keep window open when restoring with hidden tabs. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D158233
f82d191c31a25593cb663cb2d5fa1f167153d016: Bug 1792730 - Allow resizable dialog frames to stretch. r=Gijs,preferences-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 28 Sep 2022 20:36:32 +0000 - rev 636584
Push 40274 by apavel@mozilla.com at Thu, 29 Sep 2022 09:39:14 +0000
Bug 1792730 - Allow resizable dialog frames to stretch. r=Gijs,preferences-reviewers XUL honored the flex over explicit width. Differential Revision: https://phabricator.services.mozilla.com/D158283
db3340ee7c7c9bf0b6c4bf32cb68f0c8ad624318: Bug 1792719 - Allow collapsing main deck in page info window. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 28 Sep 2022 20:30:10 +0000 - rev 636583
Push 40274 by apavel@mozilla.com at Thu, 29 Sep 2022 09:39:14 +0000
Bug 1792719 - Allow collapsing main deck in page info window. r=Gijs The grid min size is different to the xul min size. Differential Revision: https://phabricator.services.mozilla.com/D158272
cbab9be9312e15a909b276b88f7f589ebe9b0ffc: Bug 1792337 - Make about dialog use modern flexbox emulation, and size to a smaller width. r=Gijs,bytesized,application-update-reviewers,preferences-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 28 Sep 2022 20:27:57 +0000 - rev 636582
Push 40274 by apavel@mozilla.com at Thu, 29 Sep 2022 09:39:14 +0000
Bug 1792337 - Make about dialog use modern flexbox emulation, and size to a smaller width. r=Gijs,bytesized,application-update-reviewers,preferences-reviewers That was presumably the intention of the explicit width in the CSS but that wasn't working. While at it, use a proper deck rather than a hand-rolled one. Differential Revision: https://phabricator.services.mozilla.com/D158223
bb9421c2629c9d33c85ba257ad70507ef82aab89: Bug 1792337 - Make about dialog use modern flexbox emulation, and size to a smaller width. r=Gijs,bytesized,application-update-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 28 Sep 2022 02:37:03 +0000 - rev 636508
Push 40271 by ncsoregi@mozilla.com at Wed, 28 Sep 2022 15:34:27 +0000
Bug 1792337 - Make about dialog use modern flexbox emulation, and size to a smaller width. r=Gijs,bytesized,application-update-reviewers That was presumably the intention of the explicit width in the CSS but that wasn't working. While at it, use a proper deck rather than a hand-rolled one. Differential Revision: https://phabricator.services.mozilla.com/D158223
97e0c3328eeeaace9265d331ad85aee1bbd13f26: Bug 1792277 - Fix sidebar resizing with flexbox emulation. r=Gijs,dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Sep 2022 19:55:22 +0000 - rev 636490
Push 40270 by ncsoregi@mozilla.com at Wed, 28 Sep 2022 09:43:53 +0000
Bug 1792277 - Fix sidebar resizing with flexbox emulation. r=Gijs,dholbert Add some basic min/max size support in splitters, and make the width part of the element we're splitting rather than the <browser> child. I don't _think_ the nsSplitterFrame changes are needed for this in particular, since we're only distributing across two items (min and max are useful only if we can distribute the space that one item can't fill with another), but it doesn't hurt. Differential Revision: https://phabricator.services.mozilla.com/D158074
a0f86ac41bc75782d3f5fe649bf6a503df282c7d: Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Sep 2022 04:18:16 +0000 - rev 636454
Push 40268 by abutkovits@mozilla.com at Tue, 27 Sep 2022 09:38:22 +0000
Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin Gijs for front-end bits, layout for the new CSS properties and the removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y changes. As discussed in the bug, the main tricky part here is handling a11y correctly. For <deck>, that's trivial (just use `visibility: hidden` to hide the panels visually, while removing the unselected panels from the a11y tree). For <tabpanels> however we need to do something special. We do want to hide stuff visually, but we want to preserve the contents in the a11y tree. For that, the easiest fix is introducing a new privileged CSS property (-moz-subtree-hidden-only-visually), which takes care of not painting the frame, but marks stuff offscreen in the accessibility tree. This is not intended to be a property used widely. Other than that, the changes are relatively straight-forward, though some of the accessible/mac changes I could get a sanity-check on. Differential Revision: https://phabricator.services.mozilla.com/D157875
00caaabc663eaf40cb3fd2af803b5fd5f6d7afa7: Bug 1791770 - Prevent add-ons from showing Fx View tab. r=Gijs
Shane Hughes <shughes@mozilla.com> - Mon, 26 Sep 2022 19:33:52 +0000 - rev 636447
Push 40267 by mlaza@mozilla.com at Tue, 27 Sep 2022 04:15:20 +0000
Bug 1791770 - Prevent add-ons from showing Fx View tab. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D158009
424b1b1c65665ed4d38d0b03d5ee0e85abfaa231: Bug 1791873 - fix FxView sync-setup-container kbd access,r=Gijs
Dan Mosedale <dmosedale@mozillla.com> - Mon, 26 Sep 2022 18:43:31 +0000 - rev 636444
Push 40267 by mlaza@mozilla.com at Tue, 27 Sep 2022 04:15:20 +0000
Bug 1791873 - fix FxView sync-setup-container kbd access,r=Gijs Backout tabIndex changes that caused the problem and add an integration test. Differential Revision: https://phabricator.services.mozilla.com/D157988
2f74f8f2ed199bd76849ba091b8a70b5418707cb: Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 26 Sep 2022 17:40:30 +0000 - rev 636442
Push 40267 by mlaza@mozilla.com at Tue, 27 Sep 2022 04:15:20 +0000
Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin Gijs for front-end bits, layout for the new CSS properties and the removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y changes. As discussed in the bug, the main tricky part here is handling a11y correctly. For <deck>, that's trivial (just use `visibility: hidden` to hide the panels visually, while removing the unselected panels from the a11y tree). For <tabpanels> however we need to do something special. We do want to hide stuff visually, but we want to preserve the contents in the a11y tree. For that, the easiest fix is introducing a new privileged CSS property (-moz-subtree-hidden-only-visually), which takes care of not painting the frame, but marks stuff offscreen in the accessibility tree. This is not intended to be a property used widely. Other than that, the changes are relatively straight-forward, though some of the accessible/mac changes I could get a sanity-check on. Differential Revision: https://phabricator.services.mozilla.com/D157875
fcfa744811794944c06c9e3890a4e17edf9d04bb: Bug 1791972 - Simplify dialog stack and rdm styles. r=Gijs,devtools-reviewers,jdescottes
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 23 Sep 2022 22:23:37 +0000 - rev 636188
Push 40262 by mlaza@mozilla.com at Sat, 24 Sep 2022 09:33:46 +0000
Bug 1791972 - Simplify dialog stack and rdm styles. r=Gijs,devtools-reviewers,jdescottes .browserContainer is relatively positioned, so we can position the tab-modal dialogs absolutely inside it instead of making them part of the browser stack. While at it, make the rdm toolbar part of the regular browserContainer, just like the regular devtools toolbox is. That way there's no need to do ResizeObserver shenanigans to be able to let it grow. Keep it also absolutely positioned tho, because we need to overlay the whole container when the device modal is opened. That's somewhat gross. This should in general be simpler to understand than the current set-up, and more performant to since it avoids the dialog stack from forming part of the browser element's flow. Differential Revision: https://phabricator.services.mozilla.com/D157912
479d9b67b09baf15fc2de7dc3695ff8a1546e67c: Bug 1788925 - Convert AboutReader from JSM to ESM. r=Gijs.
Brian <brianpt1106@gmail.com> - Fri, 23 Sep 2022 21:19:12 +0000 - rev 636186
Push 40262 by mlaza@mozilla.com at Sat, 24 Sep 2022 09:33:46 +0000
Bug 1788925 - Convert AboutReader from JSM to ESM. r=Gijs. Differential Revision: https://phabricator.services.mozilla.com/D157034
61cde6b6f2737eee00c49fb75390aff3d814f677: Bug 1789168 - Use modern flexbox emulation in the main browser area. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 23 Sep 2022 16:16:49 +0000 - rev 636169
Push 40261 by smolnar@mozilla.com at Fri, 23 Sep 2022 21:21:51 +0000
Bug 1789168 - Use modern flexbox emulation in the main browser area. r=Gijs Now that DevTools splitters work this should be doable. Differential Revision: https://phabricator.services.mozilla.com/D156385
b290a56391fe5e6e84eb854e2722e1e5494e5376: Bug 1789168 - Use modern flexbox emulation in the main browser area. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 22 Sep 2022 20:24:37 +0000 - rev 636130
Push 40259 by ctuns@mozilla.com at Fri, 23 Sep 2022 04:38:22 +0000
Bug 1789168 - Use modern flexbox emulation in the main browser area. r=Gijs Now that DevTools splitters work this should be doable. Differential Revision: https://phabricator.services.mozilla.com/D156385
f16cd526cef2ee33827a6b8dbdca0c2f9a5a474a: Bug 1791707 - Check for tablets when showing Fx View mobile promo r=Gijs
Kelly Cochrane <kcochrane@mozilla.com> - Thu, 22 Sep 2022 18:45:53 +0000 - rev 636119
Push 40258 by ctuns@mozilla.com at Thu, 22 Sep 2022 21:44:29 +0000
Bug 1791707 - Check for tablets when showing Fx View mobile promo r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D157936
a8e4168c161a02b90bce6607d198b8e5e6742acf: Bug 1792028 - Apply the lazy defineLazyPreferenceGetter workaround to browser-sidebar.js. r=Gijs
Andrew McCreight <continuation@gmail.com> - Thu, 22 Sep 2022 15:07:57 +0000 - rev 636099
Push 40258 by ctuns@mozilla.com at Thu, 22 Sep 2022 21:44:29 +0000
Bug 1792028 - Apply the lazy defineLazyPreferenceGetter workaround to browser-sidebar.js. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D157932
ea05dc209b5481998215f5ad36225c6957158074: Bug 1790888 - Add some HCM styles for Firefox View. r=Gijs
Shane Hughes <shughes@mozilla.com> - Wed, 21 Sep 2022 23:22:30 +0000 - rev 636025
Push 40255 by mlaza@mozilla.com at Thu, 22 Sep 2022 03:45:33 +0000
Bug 1790888 - Add some HCM styles for Firefox View. r=Gijs Apply the usual HCM hover style to buttons in Firefox View, but also override some of the custom properties for HCM so that Emily's patch for bug 1790396 can use the same custom properties for feature callout hover styles that we use in system content generally. Differential Revision: https://phabricator.services.mozilla.com/D157364
5d997b61af9665c57189081a9cb92c64aaa4f0f7: Bug 1791652 - Wait for setup to be hidden before checking for tabs container properties in test. r=Gijs
Sam Foster <sfoster@mozilla.com> - Wed, 21 Sep 2022 22:59:24 +0000 - rev 636023
Push 40255 by mlaza@mozilla.com at Thu, 22 Sep 2022 03:45:33 +0000
Bug 1791652 - Wait for setup to be hidden before checking for tabs container properties in test. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D157859
e231687609e3639101b442ff14380e858480c004: Bug 1778450 - Fix tab navigation in toolbar when Firefox View button is not present. r=Gijs
Tim Giles <tgiles@mozilla.com> - Wed, 21 Sep 2022 13:41:25 +0000 - rev 635982
Push 40254 by mlaza@mozilla.com at Wed, 21 Sep 2022 21:43:38 +0000
Bug 1778450 - Fix tab navigation in toolbar when Firefox View button is not present. r=Gijs With the addition of the Firefox View button/tabstrip, there is a new tabstop that is present at the start of the TabsToolbar. When the Firefox View button is not present, this new tabstop causes tab navigation to skip over the selected tab and instead focus the new-tab button. Then, when trying to navigate backwards from the selected tab, this tabstop at the front of the TabsToolbar forces us to re-focus the new-tab button. This is because the tabbrowser-arrowscrollbox-periphery container has zero width/height which causes the tabstop inside of this container to be skipped over, which then focuses the new-tab button instead of the selected tab. This patch allows zero width nodes to be skipped instead of rejected. This allows the tabstop within the zero width periphery container to be the first valid element when navigating forward from the tabstrip, instead of the new-tab-button that is outside of the <tabs> element. This restores the previous behavior of a selected tab being the first focusable item when navigating forward from the end of web content, if there are no items in the tabstrip. Differential Revision: https://phabricator.services.mozilla.com/D157351
3efb96da3cb82338580218f7b5743aeb689a3437: Bug 1791067 - Allow inputs to shrink under their intrinsic size with flexbox emulation enabled. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 20 Sep 2022 20:24:06 +0000 - rev 635919
Push 40252 by imoraru@mozilla.com at Wed, 21 Sep 2022 03:56:08 +0000
Bug 1791067 - Allow inputs to shrink under their intrinsic size with flexbox emulation enabled. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D157513
9254adef5dc42e36ac4553d29fb03f7131b48b62: Bug 1787619 - Handle primary password and sync login errors. r=Gijs,markh
Sam Foster <sfoster@mozilla.com> - Tue, 20 Sep 2022 17:58:08 +0000 - rev 635909
Push 40252 by imoraru@mozilla.com at Wed, 21 Sep 2022 03:56:08 +0000
Bug 1787619 - Handle primary password and sync login errors. r=Gijs,markh * Show the error state when the Primary Password is locked and the user is signed-in * Trigger a tab sync when the user clicks the "try again" button from the setup error step. This will also result in an unlock prompt if the primary password is locked. Differential Revision: https://phabricator.services.mozilla.com/D156360
9239a20afb93cb8ef1aac08724a94d753880715d: Bug 1787619 - Handle primary password and sync login errors. r=Gijs,markh
Sam Foster <sfoster@mozilla.com> - Tue, 20 Sep 2022 15:49:45 +0000 - rev 635894
Push 40252 by imoraru@mozilla.com at Wed, 21 Sep 2022 03:56:08 +0000
Bug 1787619 - Handle primary password and sync login errors. r=Gijs,markh * Show the error state when the Primary Password is locked and the user is signed-in * Trigger a tab sync when the user clicks the "try again" button from the setup error step. This will also result in an unlock prompt if the primary password is locked. Differential Revision: https://phabricator.services.mozilla.com/D156360
ef4ef09cd2e49e969f949cf5fd4394dcf10d9544: Bug 1789022 - Insert tabs opened from Firefox View at the beginning of the tab strip. r=Gijs
Dão Gottwald <dao@mozilla.com> - Tue, 20 Sep 2022 13:50:34 +0000 - rev 635881
Push 40252 by imoraru@mozilla.com at Wed, 21 Sep 2022 03:56:08 +0000
Bug 1789022 - Insert tabs opened from Firefox View at the beginning of the tab strip. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D157724
2ec569867b48dc6db1cdcf5fdfd6d24c4dd221b6: Bug 1781434 - Clean-up dialog initial focus code. r=pbz,Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 20 Sep 2022 03:02:18 +0000 - rev 635815
Push 40251 by apavel@mozilla.com at Tue, 20 Sep 2022 09:25:42 +0000
Bug 1781434 - Clean-up dialog initial focus code. r=pbz,Gijs Make it a bit easier to read and less prone to race conditions. Remove a setTimeout referencing bug 103197 which I'm pretty sure it's not an issue. Differential Revision: https://phabricator.services.mozilla.com/D156543
149d45b6a85b6394a8f6936e54333c6addc4cdc0: Bug 1781434 - Clean-up dialog initial focus code. r=pbz,Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Sep 2022 21:57:12 +0000 - rev 635807
Push 40250 by abutkovits@mozilla.com at Tue, 20 Sep 2022 03:38:59 +0000
Bug 1781434 - Clean-up dialog initial focus code. r=pbz,Gijs Make it a bit easier to read and less prone to race conditions. Remove a setTimeout referencing bug 103197 which I'm pretty sure it's not an issue. Differential Revision: https://phabricator.services.mozilla.com/D156543
d43a9bd44619d8b122caa97a64cabf5c185b8623: Bug 1790920 - Minor fixes to toolbar key navigation. r=Gijs,extension-reviewers,willdurand
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Sep 2022 17:02:38 +0000 - rev 635776
Push 40250 by abutkovits@mozilla.com at Tue, 20 Sep 2022 03:38:59 +0000
Bug 1790920 - Minor fixes to toolbar key navigation. r=Gijs,extension-reviewers,willdurand This is the last fix needed for this. The issue is that command events now are triggered by synthetic click events (which was not the case before pretty much by chance, a side effect of how these events were implemented). If we open a panel by a command event triggered by the synthetic click event, rather than the real keypress event, we end up not detecting that it is really a keyboard activation, and not focusing the first navigable element in the panel for example, which is unfortunate. This was caught by browser_toolbarButtonKeyPress.js. We could keep the old behavior of not triggering commands from dispatchEvent()-ed clicks, but honestly that's kind of bizarre. Differential Revision: https://phabricator.services.mozilla.com/D157596
1bb0cca45dadec6937b09eaf206714452698ac68: Bug 1790920 - Propagate modifiers properly in PanelMultiView's key event handling. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Sep 2022 17:02:38 +0000 - rev 635775
Push 40250 by abutkovits@mozilla.com at Tue, 20 Sep 2022 03:38:59 +0000
Bug 1790920 - Propagate modifiers properly in PanelMultiView's key event handling. r=Gijs This is needed to fix browser_ext_browserAction_click_types.js. Before the first patch in this bug, the order of the built-in command event and the synthetic event here was slightly different, so it was papered over. Also, the click event will trigger a command event if needed, so there's no need to do it explicitly. Differential Revision: https://phabricator.services.mozilla.com/D157591
c152a51ae80ca00ec7355f05d324e0b5b1d7df9f: Bug 1790920 - Don't check defaultPrevented for click events closing panels. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Sep 2022 17:02:37 +0000 - rev 635774
Push 40250 by abutkovits@mozilla.com at Tue, 20 Sep 2022 03:38:59 +0000
Bug 1790920 - Don't check defaultPrevented for click events closing panels. r=Gijs (To be landed right after the soft freeze is over) One interesting consequence of my previous patch in this bug, is that the time at which the XUL element processes the click event is different (earlier, at bubbling phase rather than after everything). This caused some test failures caused by the panel autohide, since now it goes after than the native handling and the native handling default-prevents to dispatch the XUL command. Given we don't check key events for defaultPrevented either, it makes sense to be consistent. This uncovered an interesting failure, where the "show more tabs" button in the sync menu starts closing the panel unexpectedly on click. The right fix is to use closemenu="none" in that button, since otherwise that button is not keyboard accessible (this is an issue on current nightly that this patch fixes). Differential Revision: https://phabricator.services.mozilla.com/D157584
0bd09bf30151a8adf162df98669cd1b6d015b17d: Bug 1790307 - Use modern flexbox in preferences. r=preferences-reviewers,Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Sep 2022 09:39:33 +0000 - rev 635739
Push 40249 by mlaza@mozilla.com at Mon, 19 Sep 2022 15:58:06 +0000
Bug 1790307 - Use modern flexbox in preferences. r=preferences-reviewers,Gijs This shouldn't have any observable behavior change, but this is the first page that uses modern flexbox layout instead of XUL layout. In practice, this means that various interesting bugs that arise from poor interaction between xul and block / flex / grid should disappear / no longer be an issue for front-end developers. Differential Revision: https://phabricator.services.mozilla.com/D157074
fa16221c24fe98c2ffbccd37a8be0d5e5b27378b: Bug 1790307 - Remove equalsize="always" usage from preferences. r=Gijs,preferences-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Sep 2022 09:39:33 +0000 - rev 635738
Push 40249 by mlaza@mozilla.com at Mon, 19 Sep 2022 15:58:06 +0000
Bug 1790307 - Remove equalsize="always" usage from preferences. r=Gijs,preferences-reviewers Emulated flexbox doesn't support this, but allows you to specify widths in percentages instead, so do that. Differential Revision: https://phabricator.services.mozilla.com/D157073
6e74478f6f3720f4693e99c06130af509cfca71e: Bug 1790903 - Remove useless selectors in custom ETP section. r=Itiel,preferences-reviewers,desktop-theme-reviewers,Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Sep 2022 22:33:01 +0000 - rev 635676
Push 40242 by mlaza@mozilla.com at Fri, 16 Sep 2022 21:39:56 +0000
Bug 1790903 - Remove useless selectors in custom ETP section. r=Itiel,preferences-reviewers,desktop-theme-reviewers,Gijs These didn't use to have an effect on the checkbox, but it has an effect now. Remove some other content-blocking-icon leftovers. Differential Revision: https://phabricator.services.mozilla.com/D157382
a8ad0273ce50e759f7406f6e0739fc74cba0bfcf: Bug 1791097 - update default bugzilla component for Firefox View files. r=Gijs DONTBUILD
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 15 Sep 2022 22:32:09 +0000 - rev 635675
Push 40242 by mlaza@mozilla.com at Fri, 16 Sep 2022 21:39:56 +0000
Bug 1791097 - update default bugzilla component for Firefox View files. r=Gijs DONTBUILD Component got added to Bugzilla in bug 1780070. Differential Revision: https://phabricator.services.mozilla.com/D157527
6af5e9e9d203176a73a1f75f799fc82d9628cb55: Bug 1789885 - Show the loading message only when we have no recent synced tabs data and no tab sync has completed yet r=Gijs,markh
Sam Foster <sfoster@mozilla.com> - Thu, 15 Sep 2022 21:58:43 +0000 - rev 635670
Push 40242 by mlaza@mozilla.com at Fri, 16 Sep 2022 21:39:56 +0000
Bug 1789885 - Show the loading message only when we have no recent synced tabs data and no tab sync has completed yet r=Gijs,markh * Remove the synced-tabs-not-ready state and instead make a waitingForTabs boolean the container can check when updating * Refactor around the maybeUpdateUI so we either pass in a force-update param, or conditionally send the notification if the state changes * Observe 'services.sync.tabs.changed' instead of the pref which gets updated as a side-effect of a tab sync * Check recent tabs via SyncedTabs.jsm in TabsSetupFlowManager and queue up SyncedTabs.syncTabs() and refreshDevices() calls when the user signs in. Differential Revision: https://phabricator.services.mozilla.com/D156997
dc01248b58a81fa6b10e8a308829fafd7c453cbe: Bug 1790902 - Fix userContext icon creation to use css rather than XUL attributes. r=Itiel,preferences-reviewers,desktop-theme-reviewers,Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Sep 2022 21:56:39 +0000 - rev 635668
Push 40241 by nfay@mozilla.com at Fri, 16 Sep 2022 03:36:28 +0000
Bug 1790902 - Fix userContext icon creation to use css rather than XUL attributes. r=Itiel,preferences-reviewers,desktop-theme-reviewers,Gijs Differential Revision: https://phabricator.services.mozilla.com/D157383
b8aafd1ec4ed11fad9dbcd6451b77c3371fe6b2a: Bug 1790593 - Exclude hidden tabs from tab multiselection. r=Gijs
Dão Gottwald <dao@mozilla.com> - Thu, 15 Sep 2022 14:59:12 +0000 - rev 635636
Push 40241 by nfay@mozilla.com at Fri, 16 Sep 2022 03:36:28 +0000
Bug 1790593 - Exclude hidden tabs from tab multiselection. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D157466
ef63c5cae6ba83ceb7971e0746ce15bef3ef0951: Bug 1785736 - Progress bar HCM palette changes r=Gijs
Cieara Meador <cmeador@mozilla.com> - Thu, 15 Sep 2022 14:30:35 +0000 - rev 635627
Push 40241 by nfay@mozilla.com at Fri, 16 Sep 2022 03:36:28 +0000
Bug 1785736 - Progress bar HCM palette changes r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D157370
03f88676f2a26a0dca742b61c85be0cf217fca86: Bug 1790152 - avoid serializing nsITransportSecurityInfo in the certificate error page r=Gijs
Dana Keeler <dkeeler@mozilla.com> - Wed, 14 Sep 2022 21:49:53 +0000 - rev 635563
Push 40237 by apavel@mozilla.com at Thu, 15 Sep 2022 04:09:47 +0000
Bug 1790152 - avoid serializing nsITransportSecurityInfo in the certificate error page r=Gijs Only the bytes of the failed certificate chain are used, so that's all we need to send across, rather than the entire nsITransportSecurityInfo. Differential Revision: https://phabricator.services.mozilla.com/D157007
7b84aa87b1576295ab53876e341b34f6775fae2d: Bug 1790753 - [devtools] Track all devtools sockets in DevToolsSocketStatus r=ochameau,Gijs
Julian Descottes <jdescottes@mozilla.com> - Wed, 14 Sep 2022 19:11:22 +0000 - rev 635546
Push 40237 by apavel@mozilla.com at Thu, 15 Sep 2022 04:09:47 +0000
Bug 1790753 - [devtools] Track all devtools sockets in DevToolsSocketStatus r=ochameau,Gijs The DevToolsSocketStatus could be misleading for any usage other than the current one from browser.js since it misses browser toolbox sockets This patch allows the singleton to track all sockets but changes the API to allow consumers to exclude browser toolbox sockets. Differential Revision: https://phabricator.services.mozilla.com/D157300
4a17392e12c8d25a57b2085d647fad57a7fc82af: Bug 1789652 - Overwrite closedIDs when restoring sessions r=Gijs
Sarah Clements <sclements@mozilla.com> - Wed, 14 Sep 2022 14:58:07 +0000 - rev 635516
Push 40236 by abutkovits@mozilla.com at Wed, 14 Sep 2022 21:36:49 +0000
Bug 1789652 - Overwrite closedIDs when restoring sessions r=Gijs * Add a helper in sessionstore to rewrite closedId's for all restored tabs * Add test coverage Differential Revision: https://phabricator.services.mozilla.com/D157235
d057e8cf08cf67264d820083d11e5b64824b23cc: Bug 1789652 - Overwrite closedIDs when restoring sessions r=Gijs
Sarah Clements <sclements@mozilla.com> - Wed, 14 Sep 2022 13:08:25 +0000 - rev 635506
Push 40236 by abutkovits@mozilla.com at Wed, 14 Sep 2022 21:36:49 +0000
Bug 1789652 - Overwrite closedIDs when restoring sessions r=Gijs * Add a helper in sessionstore to rewrite closedId's for all restored tabs * Add test coverage Differential Revision: https://phabricator.services.mozilla.com/D157235
93caeb584fddeac455c614ac735f2d64ad0ac993: Bug 1784439 - Stop setting appmenu_update_icon_color in Activist/Dreamer/Playmaker Balanced, adopt Visionary Soft color in Visionary Balanced. r=Gijs
Dão Gottwald <dao@mozilla.com> - Wed, 14 Sep 2022 12:01:55 +0000 - rev 635500
Push 40236 by abutkovits@mozilla.com at Wed, 14 Sep 2022 21:36:49 +0000
Bug 1784439 - Stop setting appmenu_update_icon_color in Activist/Dreamer/Playmaker Balanced, adopt Visionary Soft color in Visionary Balanced. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D157296
cff96f7264301854fff8b0e41cb241585d0000c0: Bug 1790592 - Add test for hidden tabs' context menu. r=Gijs
Dão Gottwald <dao@mozilla.com> - Tue, 13 Sep 2022 13:10:47 +0000 - rev 635352
Push 40233 by smolnar@mozilla.com at Tue, 13 Sep 2022 21:30:20 +0000
Bug 1790592 - Add test for hidden tabs' context menu. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D157203
3f57fa73b632a165cc2f7a20b7e67370f8743317: Bug 1790409 - Fix zap gradient border scaling. r=Gijs
Dão Gottwald <dao@mozilla.com> - Tue, 13 Sep 2022 12:50:30 +0000 - rev 635350
Push 40233 by smolnar@mozilla.com at Tue, 13 Sep 2022 21:30:20 +0000
Bug 1790409 - Fix zap gradient border scaling. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D157205
fd57a3ea2b88fd2969fc1cf7e2c41cffff0d084d: Bug 1790307 - Use modern flexbox in preferences. r=preferences-reviewers,Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 13 Sep 2022 12:17:13 +0000 - rev 635348
Push 40233 by smolnar@mozilla.com at Tue, 13 Sep 2022 21:30:20 +0000
Bug 1790307 - Use modern flexbox in preferences. r=preferences-reviewers,Gijs This shouldn't have any observable behavior change, but this is the first page that uses modern flexbox layout instead of XUL layout. In practice, this means that various interesting bugs that arise from poor interaction between xul and block / flex / grid should disappear / no longer be an issue for front-end developers. Differential Revision: https://phabricator.services.mozilla.com/D157074
646ae1f6d62c9c4384ea5dd1bbb64f044097217a: Bug 1790307 - Remove equalsize="always" usage from preferences. r=Gijs,preferences-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 13 Sep 2022 12:17:12 +0000 - rev 635347
Push 40233 by smolnar@mozilla.com at Tue, 13 Sep 2022 21:30:20 +0000
Bug 1790307 - Remove equalsize="always" usage from preferences. r=Gijs,preferences-reviewers Emulated flexbox doesn't support this, but allows you to specify widths in percentages instead, so do that. Differential Revision: https://phabricator.services.mozilla.com/D157073
9c9951c88959f89859803b81e01628caf30e99ef: Bug 1790407 - Close button for mobile pick up card should be clickable. r=Gijs
Niklas Baumgardner <nbaumgardner@mozilla.com> - Tue, 13 Sep 2022 09:11:46 +0000 - rev 635340
Push 40232 by nfay@mozilla.com at Tue, 13 Sep 2022 15:42:21 +0000
Bug 1790407 - Close button for mobile pick up card should be clickable. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D157156