searching for memory leak
6c7b81bf956a: Bug 1532580 - [wpt-sync] Update web-platform-tests to 0f1c6e9b1f63e523eb241e8c0eba1cdc764fd180, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Wed, 06 Mar 2019 16:53:40 +0000 - rev 464693
Push 35717 by aciure@mozilla.com at Sun, 17 Mar 2019 09:45:26 +0000
Bug 1532580 - [wpt-sync] Update web-platform-tests to 0f1c6e9b1f63e523eb241e8c0eba1cdc764fd180, a=testonly wpt-head: 0f1c6e9b1f63e523eb241e8c0eba1cdc764fd180 wpt-type: landing
8f2a6dbf221c: Backed out 3 changesets (bug 1512838) for memory leaks. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Sat, 16 Mar 2019 12:20:45 +0200 - rev 464483
Push 35716 by aciure@mozilla.com at Sun, 17 Mar 2019 09:42:17 +0000
Backed out 3 changesets (bug 1512838) for memory leaks. CLOSED TREE Backed out changeset 589f41b2e253 (bug 1512838) Backed out changeset 6bd80d61cee8 (bug 1512838) Backed out changeset 754f833aaa41 (bug 1512838)
66b1aba3fb43: Backed out 201 changesets (bug 1530837, bug 1529206, bug 1528232, bug 1530834, bug 1528032, bug 1530831, bug 1528237, bug 1529242, bug 1529821, bug 1530839, bug 1509034, bug 1527222, bug 1528705, bug 1530812, bug 1528266, bug 1528274, bug 1529038, bug 1464538, bug 1531331, bug 1531337, bug 1529734, bug 1528888, bug 1528887, bug 1527719, bug 1528711, bug 1527514, bug 1527981, bug 1528927, bug 1528949, bug 1531007, bug 1528736, bug 1531372, bug 1528732, bug 1530825, bug 1529061, bug 1528204, bug 1527487, bug 1528741, bug 1527961, bug 1527353, bug 1529208, bug 1527643, bug 1529244, bug 1526836, bug 1529740, bug 1527540, bug 1486514, bug 1526863, bug 1528719, bug 1529749, bug 1528954, bug 1528721, bug 1527560, bug 1526275, bug 1528894, bug 1527212, bug 1531341, bug 1529756, bug 1527584, bug 1527634, bug 1528728, bug 1527474, bug 1529438, bug 1528919, bug 1531365, bug 1528853, bug 1528726, bug 1529430, bug 1529341, bug 1529263, bug 1529459, bug 1528058, bug 1528722, bug 1528746, bug 1528211, bug 1529092, bug 1528152, bug 1529059, bug 1529229, bug 1529752, bug 1529052, bug 1529712, bug 1529055, bug 1529717, bug 1528700, bug 1528862, bug 1526647, bug 1529814, bug 1528868, bug 1529810, bug 1531069, bug 1527478, bug 1529462, bug 1528716, bug 1528828, bug 1531256, bug 1529426, bug 1531357, bug 1531064, bug 1529156, bug 1529724, bug 1529726, bug 1527483, bug 1527638, bug 1526801, bug 1528229, bug 1530852, bug 1529080, bug 1528109, bug 1528029, bug 1529435, bug 1527669, bug 1526881, bug 1529315, bug 1528023, bug 1527661, bug 1529046, bug 1526260, bug 1527640, bug 1531345, bug 1531229, bug 1527331, bug 1529807, bug 1532580, bug 1529806, bug 1529818, bug 1529800, bug 1530855, bug 1527506, bug 1528702, bug 1527548, bug 1493024, bug 1530850, bug 1529796, bug 1529797, bug 1528709, bug 1526693, bug 1526694, bug 1530858, bug 1528830, bug 1513857) for spidermonkey bustages. CLOSED TREE
Brindusan Cristian <cbrindusan@mozilla.com> - Fri, 15 Mar 2019 21:17:36 +0200 - rev 464361
Push 35713 by cbrindusan@mozilla.com at Fri, 15 Mar 2019 21:55:43 +0000
Backed out 201 changesets (bug 1530837, bug 1529206, bug 1528232, bug 1530834, bug 1528032, bug 1530831, bug 1528237, bug 1529242, bug 1529821, bug 1530839, bug 1509034, bug 1527222, bug 1528705, bug 1530812, bug 1528266, bug 1528274, bug 1529038, bug 1464538, bug 1531331, bug 1531337, bug 1529734, bug 1528888, bug 1528887, bug 1527719, bug 1528711, bug 1527514, bug 1527981, bug 1528927, bug 1528949, bug 1531007, bug 1528736, bug 1531372, bug 1528732, bug 1530825, bug 1529061, bug 1528204, bug 1527487, bug 1528741, bug 1527961, bug 1527353, bug 1529208, bug 1527643, bug 1529244, bug 1526836, bug 1529740, bug 1527540, bug 1486514, bug 1526863, bug 1528719, bug 1529749, bug 1528954, bug 1528721, bug 1527560, bug 1526275, bug 1528894, bug 1527212, bug 1531341, bug 1529756, bug 1527584, bug 1527634, bug 1528728, bug 1527474, bug 1529438, bug 1528919, bug 1531365, bug 1528853, bug 1528726, bug 1529430, bug 1529341, bug 1529263, bug 1529459, bug 1528058, bug 1528722, bug 1528746, bug 1528211, bug 1529092, bug 1528152, bug 1529059, bug 1529229, bug 1529752, bug 1529052, bug 1529712, bug 1529055, bug 1529717, bug 1528700, bug 1528862, bug 1526647, bug 1529814, bug 1528868, bug 1529810, bug 1531069, bug 1527478, bug 1529462, bug 1528716, bug 1528828, bug 1531256, bug 1529426, bug 1531357, bug 1531064, bug 1529156, bug 1529724, bug 1529726, bug 1527483, bug 1527638, bug 1526801, bug 1528229, bug 1530852, bug 1529080, bug 1528109, bug 1528029, bug 1529435, bug 1527669, bug 1526881, bug 1529315, bug 1528023, bug 1527661, bug 1529046, bug 1526260, bug 1527640, bug 1531345, bug 1531229, bug 1527331, bug 1529807, bug 1532580, bug 1529806, bug 1529818, bug 1529800, bug 1530855, bug 1527506, bug 1528702, bug 1527548, bug 1493024, bug 1530850, bug 1529796, bug 1529797, bug 1528709, bug 1526693, bug 1526694, bug 1530858, bug 1528830, bug 1513857) for spidermonkey bustages. CLOSED TREE Backed out changeset 95f1a7ff5760 (bug 1532580) Backed out changeset ad53fdccd298 (bug 1532580) Backed out changeset 8e485b71ccc1 (bug 1531372) Backed out changeset a05f7a542606 (bug 1531365) Backed out changeset e28093d1fc65 (bug 1527584) Backed out changeset 5c6bfad36ca0 (bug 1527584) Backed out changeset 0d8c97a32de3 (bug 1531229) Backed out changeset bdbfea412122 (bug 1531256) Backed out changeset 91b75e0e8324 (bug 1531256) Backed out changeset 7b01e9d570db (bug 1531357) Backed out changeset 3f555f93c070 (bug 1531357) Backed out changeset ca9d69428070 (bug 1531069) Backed out changeset 4c96cc5997e6 (bug 1531064) Backed out changeset 899598b6d7ff (bug 1529462) Backed out changeset 5eca1c95182a (bug 1529462) Backed out changeset 467ad65e9ecf (bug 1531007) Backed out changeset bd1da129790f (bug 1531007) Backed out changeset cb8f38a459ab (bug 1531345) Backed out changeset 1d08bdabd996 (bug 1531341) Backed out changeset 61c94b97adf1 (bug 1531337) Backed out changeset d8bf259eaff2 (bug 1531331) Backed out changeset b8250121c2bc (bug 1530858) Backed out changeset 1f293875c401 (bug 1529438) Backed out changeset 9d1af899260a (bug 1530855) Backed out changeset 6b60020595e0 (bug 1493024) Backed out changeset fe1a2cb779e0 (bug 1530852) Backed out changeset bd463e2be011 (bug 1530850) Backed out changeset 83c0823bb8e1 (bug 1528888) Backed out changeset d6548d68aad4 (bug 1530839) Backed out changeset f1a2f7d7615b (bug 1530837) Backed out changeset 975fbec5a080 (bug 1530834) Backed out changeset 869bf8eca7ef (bug 1530831) Backed out changeset 375113eacb17 (bug 1529080) Backed out changeset 17b00ba4a020 (bug 1529080) Backed out changeset 219767918106 (bug 1530825) Backed out changeset 71e7983951a6 (bug 1526801) Backed out changeset fff147f5ba18 (bug 1526801) Backed out changeset 2f41234f6509 (bug 1528954) Backed out changeset 4e667891d308 (bug 1528949) Backed out changeset 5ca434eafe2f (bug 1530812) Backed out changeset d23a9f7c490e (bug 1530812) Backed out changeset ed42aeed054b (bug 1529263) Backed out changeset 899099cb0784 (bug 1529263) Backed out changeset 164f6bebaebc (bug 1529208) Backed out changeset 573fa1dbbb4d (bug 1529821) Backed out changeset c6ad6c137153 (bug 1529459) Backed out changeset 6caf4fe5691d (bug 1529459) Backed out changeset ee028b57d613 (bug 1529818) Backed out changeset 33633cf10c0d (bug 1529814) Backed out changeset 869b8f43a793 (bug 1529092) Backed out changeset 51f209d730ca (bug 1529092) Backed out changeset 8209d757949e (bug 1527961) Backed out changeset f7ad412343b9 (bug 1527961) Backed out changeset 2c7bf50257af (bug 1529810) Backed out changeset 62fe727988a6 (bug 1529810) Backed out changeset 8592c05fe031 (bug 1526275) Backed out changeset 1a3fb0f644ae (bug 1529807) Backed out changeset 32f87ee369cb (bug 1529806) Backed out changeset 1c117fbc850f (bug 1529800) Backed out changeset f5582e70c239 (bug 1526693) Backed out changeset 421b2d615568 (bug 1526693) Backed out changeset 6b7cb75d72aa (bug 1529797) Backed out changeset 2f7275c284b1 (bug 1529797) Backed out changeset d6a61db63718 (bug 1529796) Backed out changeset b9c6ed34a214 (bug 1529796) Backed out changeset 7a38369a17d3 (bug 1529435) Backed out changeset 88bd6cc607e2 (bug 1529435) Backed out changeset d700b6928f43 (bug 1529430) Backed out changeset 81d0e91ab507 (bug 1529430) Backed out changeset d252a7037801 (bug 1529229) Backed out changeset 253adcb96f41 (bug 1529229) Backed out changeset 719455274599 (bug 1529206) Backed out changeset 37d25235012d (bug 1529206) Backed out changeset 373ccecf93ea (bug 1528274) Backed out changeset fa55f010bd71 (bug 1528274) Backed out changeset 9de615ccb5c5 (bug 1529156) Backed out changeset b871b38ec2b3 (bug 1529156) Backed out changeset f419b8ba3747 (bug 1529426) Backed out changeset 1d2059a2cf36 (bug 1529244) Backed out changeset 5de598a7923d (bug 1529315) Backed out changeset 629ad93a6738 (bug 1529315) Backed out changeset cf68befd3506 (bug 1529341) Backed out changeset 3f9c54ed7d2c (bug 1526881) Backed out changeset c9867062b58d (bug 1526863) Backed out changeset d3dcbaa53bac (bug 1526863) Backed out changeset 05ff2e535c6e (bug 1528919) Backed out changeset df087069273b (bug 1528919) Backed out changeset 43debb14a004 (bug 1529242) Backed out changeset 71768e55e777 (bug 1528828) Backed out changeset 7d54ecab8dc1 (bug 1528828) Backed out changeset 263580f65aea (bug 1528830) Backed out changeset 65f41dd56207 (bug 1528927) Backed out changeset 8080b1f6eef2 (bug 1528894) Backed out changeset e7d92d3120c4 (bug 1528894) Backed out changeset f7d636225ed1 (bug 1528887) Backed out changeset 577ea54d1b0c (bug 1528868) Backed out changeset b3bae9f26b98 (bug 1528862) Backed out changeset 3e265c28d845 (bug 1528853) Backed out changeset 6dee1f08de48 (bug 1528853) Backed out changeset 0ce1a5521d6f (bug 1526694) Backed out changeset 64cc60d52a04 (bug 1526694) Backed out changeset a5181637d09e (bug 1486514) Backed out changeset 2cabd13e237f (bug 1486514) Backed out changeset 9fd49ca281f0 (bug 1528152) Backed out changeset 24a07018f8a8 (bug 1529756) Backed out changeset fbf69465f685 (bug 1529752) Backed out changeset 0b5d77924a13 (bug 1529752) Backed out changeset b2ffdd7ebfe7 (bug 1529749) Backed out changeset d4188fabe555 (bug 1529740) Backed out changeset 99fe9246e9a3 (bug 1529734) Backed out changeset e860533a4743 (bug 1529734) Backed out changeset 3d06a920925d (bug 1529726) Backed out changeset 22f687c325e8 (bug 1529724) Backed out changeset 105008f9f601 (bug 1529717) Backed out changeset 5724299ed798 (bug 1529717) Backed out changeset 788727cccd4f (bug 1529712) Backed out changeset 348216552124 (bug 1529712) Backed out changeset 106ac73457aa (bug 1529061) Backed out changeset 05a81cf22d1e (bug 1529061) Backed out changeset 07c3ea987b01 (bug 1529059) Backed out changeset ceb6af0d7338 (bug 1529055) Backed out changeset 40338ef0c5ae (bug 1529055) Backed out changeset 97385559862c (bug 1529052) Backed out changeset 4fe6634c3cea (bug 1529046) Backed out changeset da708ab85cc6 (bug 1529038) Backed out changeset 18139e69e3c5 (bug 1528266) Backed out changeset e5f7bd9d93a4 (bug 1527719) Backed out changeset 1fb1b5a75a79 (bug 1527719) Backed out changeset 58ff2725e6a5 (bug 1527661) Backed out changeset 16b6e709d409 (bug 1527661) Backed out changeset e23c3c3fe9cd (bug 1528746) Backed out changeset e8fd59f2739a (bug 1528746) Backed out changeset 5cbc3a522b49 (bug 1528741) Backed out changeset 66fb4cc72692 (bug 1464538) Backed out changeset 2e1f864ca504 (bug 1464538) Backed out changeset ed2e428a7fb7 (bug 1528211) Backed out changeset 32c8219664b6 (bug 1528736) Backed out changeset d6a7755ddcbb (bug 1528732) Backed out changeset 056f30752f2d (bug 1528728) Backed out changeset ac00cd4c7abc (bug 1528726) Backed out changeset bcd8267fa113 (bug 1528726) Backed out changeset 51f0cd0c1621 (bug 1528722) Backed out changeset 165c390054b2 (bug 1528721) Backed out changeset 772109738241 (bug 1528719) Backed out changeset a73350397302 (bug 1528716) Backed out changeset 84b7e38be0cc (bug 1513857) Backed out changeset e63c62898033 (bug 1528711) Backed out changeset a7ee2a24d898 (bug 1527353) Backed out changeset 5fb707e280c1 (bug 1509034) Backed out changeset be42c83c6e97 (bug 1509034) Backed out changeset 2eb522ceb6e1 (bug 1528709) Backed out changeset 822ff0ac5f39 (bug 1527981) Backed out changeset 3fb86165ce50 (bug 1527981) Backed out changeset 7f5ce8587ad9 (bug 1528705) Backed out changeset b571112619c2 (bug 1528702) Backed out changeset 8b3668ee0579 (bug 1528702) Backed out changeset 0562ba7637c2 (bug 1528058) Backed out changeset 9e73b2eb508f (bug 1528700) Backed out changeset d3e10f10f4c2 (bug 1528032) Backed out changeset 629c2a5b9013 (bug 1528029) Backed out changeset 78d3aefc4418 (bug 1528023) Backed out changeset 48f705e0ae7e (bug 1528237) Backed out changeset f6690a972633 (bug 1528237) Backed out changeset f62003f22992 (bug 1528232) Backed out changeset a8be7c66cb41 (bug 1528229) Backed out changeset f4fa3dd608c7 (bug 1528229) Backed out changeset 181a97408a30 (bug 1528204) Backed out changeset f60df1fe019b (bug 1528204) Backed out changeset e45e2443ffae (bug 1526260) Backed out changeset 013ad346966b (bug 1526260) Backed out changeset 1c5a3f8b212a (bug 1527222) Backed out changeset ec1f4ffa35d1 (bug 1527222) Backed out changeset 89dc1513582b (bug 1527669) Backed out changeset 3bd6059a1b64 (bug 1528109) Backed out changeset c3299b5db5d8 (bug 1527560) Backed out changeset 01df42e8dca9 (bug 1527560) Backed out changeset 9a1e1d9bc686 (bug 1526836) Backed out changeset c08164922aaf (bug 1526836) Backed out changeset 1a78f6d88afa (bug 1527540) Backed out changeset b781b88b53d1 (bug 1527643) Backed out changeset 793206aecd5e (bug 1527643) Backed out changeset 6b5a45ed3837 (bug 1527548) Backed out changeset 5d939be0e4cd (bug 1527640) Backed out changeset aef452a8ebca (bug 1527640) Backed out changeset 52755e035f39 (bug 1527638) Backed out changeset b9735af59094 (bug 1527638) Backed out changeset 0883b91b6367 (bug 1527634) Backed out changeset 98dd738ff942 (bug 1527514) Backed out changeset aa57afa41078 (bug 1527506) Backed out changeset 61dabecba34c (bug 1527506) Backed out changeset feaa22c216e3 (bug 1526647) Backed out changeset c746aaf82c65 (bug 1527487) Backed out changeset 07cdbdb2c608 (bug 1527487) Backed out changeset 8b006c4103ff (bug 1527483) Backed out changeset d781f4856028 (bug 1527483) Backed out changeset 9ef5380f4ea9 (bug 1527478) Backed out changeset ede03586f13b (bug 1527478) Backed out changeset 9ca222b6a740 (bug 1527331) Backed out changeset 3b96582a3422 (bug 1527474) Backed out changeset 403d814ff267 (bug 1527474) Backed out changeset 353a9e562d20 (bug 1527212)
e9f1a449031d: Bug 1525729 - Avoid memory leak via AddonTestUtils.initMochiTest r=aswan
Rob Wu <rob@robwu.nl> - Thu, 14 Mar 2019 16:28:20 +0000 - rev 464014
Push 35705 by rmaries@mozilla.com at Thu, 14 Mar 2019 21:39:47 +0000
Bug 1525729 - Avoid memory leak via AddonTestUtils.initMochiTest r=aswan When I added AddonTestUtils.initMochiTest to an existing test at browser/components/preferences/in-content/tests/browser_extension_controlled.js , the test started to fail often on debug builds, with errors like "leaked 2 window(s) until shutdown". Fix this by clearing the global that was saved by initMochiTest. Differential Revision: https://phabricator.services.mozilla.com/D23502
e9677c67b094: Bug 1523613: Fix memory leaks during updates. r=rstrong
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Mon, 25 Feb 2019 10:16:15 -0500 - rev 460883
Push 35612 by nerli@mozilla.com at Mon, 25 Feb 2019 21:58:23 +0000
Bug 1523613: Fix memory leaks during updates. r=rstrong
fccf09f7463c: Bug 1523562 [wpt PR 15049] - Revert "[animation-worklet] Basic pause implementation", a=testonly
Findit <findit-for-me@appspot.gserviceaccount.com> - Fri, 01 Feb 2019 11:39:35 +0000 - rev 458146
Push 35518 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:55:14 +0000
Bug 1523562 [wpt PR 15049] - Revert "[animation-worklet] Basic pause implementation", a=testonly Automatic update from web-platform-tests Revert "[animation-worklet] Basic pause implementation" This reverts commit 94b5b84b058609ccf1d58f5175c0931b63b9f0f2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 625711 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTRiNWI4NGIwNTg2MDljY2YxZDU4ZjUxNzVjMDkzMWI2M2I5ZjBmMgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20Leak/29257 Sample Failed Step: webkit_layout_tests Sample Flaky Test: external/wpt/animation-worklet/worklet-animation-pause.https.html Original change's description: > [animation-worklet] Basic pause implementation > > Pausing worklet animation now holds the time. This works as expected for > main thread animations. Implementing this for composited worklet > animations will be done in a follow up patch. > > Major changes: > - Add and expose pause() method pausing the animation. > - Introduce hold_time that is used when animation is paused. > - Rework how current time is computed, it is now closer to > regular animations i.e., we either compute it based on > "start time and timeline.currentTime" or use "hold time". > - Instead of setting start time we now set the current time > which then works backward to compute either the start time > or the hold time based on the animation state. > - When transitioning animation play state, we now always set > the current time. Previously this was adhoc and inconsistent. > - Introduce has_started_ to differentiate when playing an > animation for the first time vs playing it from pause. > > > TEST: > * wpt/animation-worklet/worklet-animation-pause.https.html: js test for basic current time calculations > * wpt/animation-worklet/worklet-animation-pause-immediately.https.html: reftest for basic pause > * wpt/animation-worklet/worklet-animation-pause-result.https.html: reftest for pause/resume. > * WorkletAnimationTest.PausePlay: unit test for basic state transition and time calc > > Bug: 821910 > > Change-Id: Ie4b00129398159b3b5b83212bb63c43f2ce8bf4e > Reviewed-on: https://chromium-review.googlesource.com/c/1383298 > Commit-Queue: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625711} Change-Id: Ibb3c50f772493f1761cee657aaa618f357348188 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821910 Reviewed-on: https://chromium-review.googlesource.com/c/1434815 Cr-Commit-Position: refs/heads/master@{#625747} -- wpt-commits: 584401124395d4017e235710dacc70bd61e93e13 wpt-pr: 15049
4f3d1575c5a7: Bug 1523562 [wpt PR 14951] - Revert "Portals: Expose portalHost to portal's browsing context", a=testonly
Findit <findit-for-me@appspot.gserviceaccount.com> - Thu, 31 Jan 2019 18:58:01 +0000 - rev 458057
Push 35518 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:55:14 +0000
Bug 1523562 [wpt PR 14951] - Revert "Portals: Expose portalHost to portal's browsing context", a=testonly Automatic update from web-platform-tests Revert "Portals: Expose portalHost to portal's browsing context" This reverts commit 9d4738420905a6b28407a8282512d8307d413780. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 624316 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOWQ0NzM4NDIwOTA1YTZiMjg0MDdhODI4MjUxMmQ4MzA3ZDQxMzc4MAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20Leak/29014 Sample Failed Step: webkit_layout_tests Sample Flaky Test: external/wpt/portals/portals-host-exposure.sub.html Original change's description: > Portals: Expose portalHost to portal's browsing context > > window.portalHost returns a PortalHost to script running inside the main > frame within a portal. > > Bug: 914117 > Change-Id: I26fb4ae9676261bee4446bfbc6ee34b28dc618b1 > Reviewed-on: https://chromium-review.googlesource.com/c/1399569 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624316} Change-Id: I38d4e208daafc8381495a4249c02928757bbdfc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914117, 923610 Reviewed-on: https://chromium-review.googlesource.com/c/1423660 Cr-Commit-Position: refs/heads/master@{#624405} -- wpt-commits: 1fc2d6a452e7a59abc257cb111bcad75df4b9995 wpt-pr: 14951
225d68a4143b: Bug 1516427 [wpt PR 14672] - v8binding: Implement timers with IDL callback function of type Function, a=testonly
Yuki Shiino <yukishiino@chromium.org> - Thu, 31 Jan 2019 15:17:17 +0000 - rev 457827
Push 35518 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:55:14 +0000
Bug 1516427 [wpt PR 14672] - v8binding: Implement timers with IDL callback function of type Function, a=testonly Automatic update from web-platform-tests v8binding: Implement timers with IDL callback function of type Function This is mostly a reland of Iee5c1d6917ad7770383e06a425f96000835a663a. This patch implements setTimeout/setInterval Web APIs with IDL callback function of type Function (i.e. V8Function in Blink). Also ensure eager finalization of ScheduledAction in DOMTimer to prevent a memory leak. Bug: 866610 Change-Id: I3f460247f27069e4054a984efd3f98a2ce0ceac7 Reviewed-on: https://chromium-review.googlesource.com/c/1391248 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#619125} -- wpt-commits: 941e8206cee200360d29bdc09ff643bbe1bf61ce wpt-pr: 14672
281107eb1e67: Bug 1523562 [wpt PR 15049] - Revert "[animation-worklet] Basic pause implementation", a=testonly
Findit <findit-for-me@appspot.gserviceaccount.com> - Fri, 01 Feb 2019 11:39:35 +0000 - rev 457244
Push 35505 by csabou@mozilla.com at Tue, 05 Feb 2019 21:59:22 +0000
Bug 1523562 [wpt PR 15049] - Revert "[animation-worklet] Basic pause implementation", a=testonly Automatic update from web-platform-tests Revert "[animation-worklet] Basic pause implementation" This reverts commit 94b5b84b058609ccf1d58f5175c0931b63b9f0f2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 625711 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTRiNWI4NGIwNTg2MDljY2YxZDU4ZjUxNzVjMDkzMWI2M2I5ZjBmMgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20Leak/29257 Sample Failed Step: webkit_layout_tests Sample Flaky Test: external/wpt/animation-worklet/worklet-animation-pause.https.html Original change's description: > [animation-worklet] Basic pause implementation > > Pausing worklet animation now holds the time. This works as expected for > main thread animations. Implementing this for composited worklet > animations will be done in a follow up patch. > > Major changes: > - Add and expose pause() method pausing the animation. > - Introduce hold_time that is used when animation is paused. > - Rework how current time is computed, it is now closer to > regular animations i.e., we either compute it based on > "start time and timeline.currentTime" or use "hold time". > - Instead of setting start time we now set the current time > which then works backward to compute either the start time > or the hold time based on the animation state. > - When transitioning animation play state, we now always set > the current time. Previously this was adhoc and inconsistent. > - Introduce has_started_ to differentiate when playing an > animation for the first time vs playing it from pause. > > > TEST: > * wpt/animation-worklet/worklet-animation-pause.https.html: js test for basic current time calculations > * wpt/animation-worklet/worklet-animation-pause-immediately.https.html: reftest for basic pause > * wpt/animation-worklet/worklet-animation-pause-result.https.html: reftest for pause/resume. > * WorkletAnimationTest.PausePlay: unit test for basic state transition and time calc > > Bug: 821910 > > Change-Id: Ie4b00129398159b3b5b83212bb63c43f2ce8bf4e > Reviewed-on: https://chromium-review.googlesource.com/c/1383298 > Commit-Queue: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625711} Change-Id: Ibb3c50f772493f1761cee657aaa618f357348188 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821910 Reviewed-on: https://chromium-review.googlesource.com/c/1434815 Cr-Commit-Position: refs/heads/master@{#625747} -- wpt-commits: 584401124395d4017e235710dacc70bd61e93e13 wpt-pr: 15049
53d3926514ef: Bug 1523562 [wpt PR 14951] - Revert "Portals: Expose portalHost to portal's browsing context", a=testonly
Findit <findit-for-me@appspot.gserviceaccount.com> - Thu, 31 Jan 2019 18:58:01 +0000 - rev 457155
Push 35505 by csabou@mozilla.com at Tue, 05 Feb 2019 21:59:22 +0000
Bug 1523562 [wpt PR 14951] - Revert "Portals: Expose portalHost to portal's browsing context", a=testonly Automatic update from web-platform-tests Revert "Portals: Expose portalHost to portal's browsing context" This reverts commit 9d4738420905a6b28407a8282512d8307d413780. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 624316 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOWQ0NzM4NDIwOTA1YTZiMjg0MDdhODI4MjUxMmQ4MzA3ZDQxMzc4MAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20Leak/29014 Sample Failed Step: webkit_layout_tests Sample Flaky Test: external/wpt/portals/portals-host-exposure.sub.html Original change's description: > Portals: Expose portalHost to portal's browsing context > > window.portalHost returns a PortalHost to script running inside the main > frame within a portal. > > Bug: 914117 > Change-Id: I26fb4ae9676261bee4446bfbc6ee34b28dc618b1 > Reviewed-on: https://chromium-review.googlesource.com/c/1399569 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624316} Change-Id: I38d4e208daafc8381495a4249c02928757bbdfc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914117, 923610 Reviewed-on: https://chromium-review.googlesource.com/c/1423660 Cr-Commit-Position: refs/heads/master@{#624405} -- wpt-commits: 1fc2d6a452e7a59abc257cb111bcad75df4b9995 wpt-pr: 14951
49a2648199d5: Bug 1516427 [wpt PR 14672] - v8binding: Implement timers with IDL callback function of type Function, a=testonly
Yuki Shiino <yukishiino@chromium.org> - Thu, 31 Jan 2019 15:17:17 +0000 - rev 456925
Push 35505 by csabou@mozilla.com at Tue, 05 Feb 2019 21:59:22 +0000
Bug 1516427 [wpt PR 14672] - v8binding: Implement timers with IDL callback function of type Function, a=testonly Automatic update from web-platform-tests v8binding: Implement timers with IDL callback function of type Function This is mostly a reland of Iee5c1d6917ad7770383e06a425f96000835a663a. This patch implements setTimeout/setInterval Web APIs with IDL callback function of type Function (i.e. V8Function in Blink). Also ensure eager finalization of ScheduledAction in DOMTimer to prevent a memory leak. Bug: 866610 Change-Id: I3f460247f27069e4054a984efd3f98a2ce0ceac7 Reviewed-on: https://chromium-review.googlesource.com/c/1391248 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#619125} -- wpt-commits: 941e8206cee200360d29bdc09ff643bbe1bf61ce wpt-pr: 14672
56840efb59f1: Bug 1524290: Fix a potential memory leak in updater.cpp. r=rstrong
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Thu, 31 Jan 2019 17:39:15 -0500 - rev 456343
Push 35479 by shindli@mozilla.com at Fri, 01 Feb 2019 03:57:26 +0000
Bug 1524290: Fix a potential memory leak in updater.cpp. r=rstrong
6b56696d713a: Bug 1514594: Part 3 - Change ChromeUtils.import API.
Kris Maglione <maglione.k@gmail.com> - Thu, 17 Jan 2019 10:18:31 -0800 - rev 455795
Push 35458 by csabou@mozilla.com at Tue, 29 Jan 2019 10:03:06 +0000
Bug 1514594: Part 3 - Change ChromeUtils.import API. *** Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8 This changes the behavior of ChromeUtils.import() to return an exports object, rather than a module global, in all cases except when `null` is passed as a second argument, and changes the default behavior not to pollute the global scope with the module's exports. Thus, the following code written for the old model: ChromeUtils.import("resource://gre/modules/Services.jsm"); is approximately the same as the following, in the new model: var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm"); Since the two behaviors are mutually incompatible, this patch will land with a scripted rewrite to update all existing callers to use the new model rather than the old. *** Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs This was done using the followng script: https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm *** Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D16747 *** Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16748 *** Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16749 *** Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs *** Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16750
10b57d0ee380: Bug 1520047 - Fix memory leak in places trees r=mak
Rob Wu <rob@robwu.nl> - Wed, 23 Jan 2019 09:54:36 +0000 - rev 454951
Push 35419 by dluca@mozilla.com at Wed, 23 Jan 2019 16:31:25 +0000
Bug 1520047 - Fix memory leak in places trees r=mak The places-tree destructor lacks a `result.removeObserver(this.view);` call before the assignment to `result.root.containerOpen`, which is causing a memory leak. This patch fixes the leak by removing the `result.root.containerOpen` assignment, since the correct logic already exists in the `setTree` method of `PlacesTreeView`, which is called upon `this.view = null;` (XULTreeElement::SetView -> nsTreeBodyFrame::SetView -> setTree). Differential Revision: https://phabricator.services.mozilla.com/D17241
5f4630838d46: Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 18 Jan 2019 10:16:18 +0100 - rev 454520
Push 35400 by csabou@mozilla.com at Sat, 19 Jan 2019 09:59:33 +0000
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre # ignore-this-changeset
625005dcd0b3: Bug 1516554 - Part 3: Fix VRGPUParent memory leak in the destructor. r=kip
Daosheng Mu <daoshengmu@gmail.com> - Mon, 14 Jan 2019 21:58:51 +0000 - rev 453837
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1516554 - Part 3: Fix VRGPUParent memory leak in the destructor. r=kip Differential Revision: https://phabricator.services.mozilla.com/D16257
33784a7ae90b: Bug 1518726 - Apply https://reviews.llvm.org/D56475 to clang. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 10 Jan 2019 00:18:28 +0000 - rev 453204
Push 35348 by opoprus@mozilla.com at Thu, 10 Jan 2019 09:38:54 +0000
Bug 1518726 - Apply https://reviews.llvm.org/D56475 to clang. r=froydnj Firefox uses multiple processes. It has intentional leaks, and when running with ASAN, we have suppressions to eliminate those. When running ASAN builds through CI tests, when Firefox exits, each of the processes (parent and child) exits and goes through its leaks and when there are (which is a given), the ASAN runtime runs llvm-symbolizer to symbolicate and match against suppressions. So each process runs llvm-symbolizer. At the same time. Some of the addresses to symbolicate are in libxul. Which contains all DWARF info, making it a ~1GB monster. Oh, and because you're lucky, things align perfectly such that libxul size is a multiple of the page size. That makes llvm-symbolizer pread() the file instead of mmap()ing it. Did I say there are multiple processes? So suddenly you have n processes simultaneously allocating and filling 1GB of memory each, on CI machines that have enough memory for the job they usually run, but not enough for a sudden rush of n GB. And things go awry. When you're lucky and the OOM killer didn't take care of killing the CI entirely, symbolication couldn't happen and the suppressions are not matched, and leaks are reported. This all turns out it originates in how llvm-symbolicate chooses between pread() and mmap(), which turns out is just defaults not being made for binary files. Differential Revision: https://phabricator.services.mozilla.com/D16010
d02e6cc785a9: Bug 1510663 - Address WifiManager Potential Leak warning. r=geckoview-reviewers,snorp
Emily Toop <etoop@mozilla.com> - Wed, 19 Dec 2018 15:50:05 +0000 - rev 452260
Push 35299 by btara@mozilla.com at Wed, 02 Jan 2019 21:34:59 +0000
Bug 1510663 - Address WifiManager Potential Leak warning. r=geckoview-reviewers,snorp On versions prior to Android N (24), initializing the WifiManager via Context#getSystemService can cause a memory leak if the context is not the application context. Differential Revision: https://phabricator.services.mozilla.com/D14721
c85e2fe3af3b: Bug 1501024 WifiScanner should use ApplicationContext r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 10 Dec 2018 09:33:18 +0000 - rev 449686
Push 35182 by cbrindusan@mozilla.com at Mon, 10 Dec 2018 22:02:24 +0000
Bug 1501024 WifiScanner should use ApplicationContext r=JanH Fixed lint warning regarding memory leak inside WifiManager constructor. Differential Revision: https://phabricator.services.mozilla.com/D13930
6f37c64ae423: Bug 1501024 WifiScanner should use ApplicationContext r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Fri, 07 Dec 2018 18:54:56 +0000 - rev 449615
Push 35175 by dvarga@mozilla.com at Sat, 08 Dec 2018 09:48:04 +0000
Bug 1501024 WifiScanner should use ApplicationContext r=JanH Fixed lint warning regarding memory leak inside WifiManager constructor. Differential Revision: https://phabricator.services.mozilla.com/D13930