searching for i.milind.luthra@gmail.com
4b1ce6bf8518: Bug 1421664 - 2 - Change SelectAsTag to use place: tag queries. r=mak
milindl <i.milind.luthra@gmail.com> - Tue, 20 Mar 2018 17:27:44 +0100 - rev 410769
Push 33739 by nbeleuzu@mozilla.com at Fri, 30 Mar 2018 21:47:45 +0000
Bug 1421664 - 2 - Change SelectAsTag to use place: tag queries. r=mak MozReview-Commit-ID: JauduB7A5TZ
7f8bb8f9998e: Bug 1421664 - 1 - Force any tag queries to have query result type bookmarks. r=mak
milindl <i.milind.luthra@gmail.com> - Tue, 20 Mar 2018 16:42:04 +0100 - rev 410768
Push 33739 by nbeleuzu@mozilla.com at Fri, 30 Mar 2018 21:47:45 +0000
Bug 1421664 - 1 - Force any tag queries to have query result type bookmarks. r=mak MozReview-Commit-ID: KG1mGZD5PNy
39cddac4216f: Bug 1421654: Make tag queries case insensitive and associated tests. r=mak
MilindL <i.milind.luthra@gmail.com> - Fri, 17 Nov 2017 23:29:03 +0530 - rev 394358
Push 33002 by cbrindusan@mozilla.com at Thu, 30 Nov 2017 21:52:33 +0000
Bug 1421654: Make tag queries case insensitive and associated tests. r=mak Additional tests added include testing for queries where tags have special characters. MozReview-Commit-ID: 7Hrcw6lTfMz
09157e44e113: Bug 1063635 Part 3 - Fix tests for native writeAtomic. r=Yoric
MilindL <i.milind.luthra@gmail.com> - Tue, 29 Aug 2017 20:20:26 +0530 - rev 386280
Push 32686 by archaeopteryx@coole-files.de at Sun, 15 Oct 2017 09:40:59 +0000
Bug 1063635 Part 3 - Fix tests for native writeAtomic. r=Yoric MozReview-Commit-ID: 94lNCMUEg7c
71f8ad3208d9: Bug 1063635 Part 2 - Call native writeAtomic code instead of JS backend when applicable. r=Yoric
MilindL <i.milind.luthra@gmail.com> - Thu, 27 Jul 2017 19:41:00 +0530 - rev 386279
Push 32686 by archaeopteryx@coole-files.de at Sun, 15 Oct 2017 09:40:59 +0000
Bug 1063635 Part 2 - Call native writeAtomic code instead of JS backend when applicable. r=Yoric MozReview-Commit-ID: fiIS2xPc2r
2a9fc9a1825b: Bug 1063635 Part 1 - Add native code for OS.File.writeAtomic. r=smaug,Yoric
MilindL <i.milind.luthra@gmail.com> - Tue, 27 Jun 2017 13:10:11 +0530 - rev 386278
Push 32686 by archaeopteryx@coole-files.de at Sun, 15 Oct 2017 09:40:59 +0000
Bug 1063635 Part 1 - Add native code for OS.File.writeAtomic. r=smaug,Yoric MozReview-Commit-ID: 2TKZh6jCsq5
61a23e8fbf54: Bug 1063635 Part 3 - Fix tests for native writeAtomic. r=Yoric
MilindL <i.milind.luthra@gmail.com> - Tue, 29 Aug 2017 20:20:26 +0530 - rev 378198
Push 32426 by kwierso@gmail.com at Fri, 01 Sep 2017 21:59:36 +0000
Bug 1063635 Part 3 - Fix tests for native writeAtomic. r=Yoric MozReview-Commit-ID: 94lNCMUEg7c
0d9eb13ac53e: Bug 1063635 Part 2 - Call native writeAtomic code instead of JS backend when applicable. r=Yoric
MilindL <i.milind.luthra@gmail.com> - Thu, 27 Jul 2017 19:41:00 +0530 - rev 378197
Push 32426 by kwierso@gmail.com at Fri, 01 Sep 2017 21:59:36 +0000
Bug 1063635 Part 2 - Call native writeAtomic code instead of JS backend when applicable. r=Yoric MozReview-Commit-ID: fiIS2xPc2r
44ff3bc7bee5: Bug 1063635 Part 1 - Add native code for OS.File.writeAtomic. r=smaug,Yoric
MilindL <i.milind.luthra@gmail.com> - Tue, 27 Jun 2017 13:10:11 +0530 - rev 378196
Push 32426 by kwierso@gmail.com at Fri, 01 Sep 2017 21:59:36 +0000
Bug 1063635 Part 1 - Add native code for OS.File.writeAtomic. r=smaug,Yoric MozReview-Commit-ID: 2TKZh6jCsq5
87b2b354ed01: Bug 1107364 - remove findNodeByDetails and maintain a map to fetch a node by details speedily, r=mak
MilindL <i.milind.luthra@gmail.com> - Thu, 08 Jun 2017 20:51:51 +0530 - rev 365783
Push 32089 by cbook@mozilla.com at Mon, 26 Jun 2017 11:24:06 +0000
Bug 1107364 - remove findNodeByDetails and maintain a map to fetch a node by details speedily, r=mak This patch removes the interface/header/implementation. This adds a Map to PlacesTreeView to maintain the relation between node details and the nodes, based on changes in `this._rows` or on node details changed events. The Map exists from node details to nodes (not rows). MozReview-Commit-ID: EUNiXNIB5rN
68f8468766e7: Bug 850636 - add an option `outSerializationDuration` to measure the time for message serialization,r=Yoric
milindl <i.milind.luthra@gmail.com> - Sat, 03 Jun 2017 21:44:37 +0530 - rev 364446
Push 32042 by archaeopteryx@coole-files.de at Sat, 17 Jun 2017 19:33:32 +0000
Bug 850636 - add an option `outSerializationDuration` to measure the time for message serialization,r=Yoric This changes the `Scheduler.post` method to check for options in the `args`, and accordingly update it with the time it takes for running `Scheduler.worker.post`. This also changes the `test_duration.js` to add another duration (serialization duration) for the operations where `Scheduler.post` is called. MozReview-Commit-ID: EGPeHfMYI1U
aa36ffe32ddc: Bug 1368754 - fix consumers which wait for `NodeHistoryDetailsChanged`/`NodeURIChanged` to be called to use node for new values, r=mak
milindl <i.milind.luthra@gmail.com> - Tue, 30 May 2017 23:51:09 +0530 - rev 362609
Push 31984 by cbook@mozilla.com at Wed, 07 Jun 2017 11:33:07 +0000
Bug 1368754 - fix consumers which wait for `NodeHistoryDetailsChanged`/`NodeURIChanged` to be called to use node for new values, r=mak Updated time, access count and uri can be accessed using the node passed to the method. There is no need to access the other arguments, which contain the old values of the quantities changed. MozReview-Commit-ID: 3WEwAs8gQ0w
9cab45e72b30: Bug 1368754 - Change `NodeHistoryDetailsChanged` and `NodeURIChanged` to be called with old time,access count and uri, r=mak
milindl <i.milind.luthra@gmail.com> - Tue, 30 May 2017 23:46:59 +0530 - rev 362608
Push 31984 by cbook@mozilla.com at Wed, 07 Jun 2017 11:33:07 +0000
Bug 1368754 - Change `NodeHistoryDetailsChanged` and `NodeURIChanged` to be called with old time,access count and uri, r=mak Update interface and all instances where the method is called to be called with the old values, since the new values are already there as a part of the node, and thus redundant. MozReview-Commit-ID: 5pcfJbg9tej
291fe1a6a375: Bug 653816 - returning only nontags for GetBookmarkIdsForURI and fixing consumers, r=mak
milindl <i.milind.luthra@gmail.com> - Tue, 30 May 2017 19:48:17 +0530 - rev 361918
Push 31952 by cbook@mozilla.com at Fri, 02 Jun 2017 12:17:25 +0000
Bug 653816 - returning only nontags for GetBookmarkIdsForURI and fixing consumers, r=mak Most consumers of `GetBookmarkIdsForURI` already don't need tags, the only consumer which does (`TaggingService`) has been changed to use a separate database query. MozReview-Commit-ID: LabjaA6Q0GF
534b3577bb9a: Bug 1036440 - Fix tests and consumers for rewritten `PlacesDBUtils`, r=mak
milindl <i.milind.luthra@gmail.com> - Wed, 24 May 2017 11:00:47 +0530 - rev 360898
Push 31904 by archaeopteryx@coole-files.de at Sat, 27 May 2017 07:50:57 +0000
Bug 1036440 - Fix tests and consumers for rewritten `PlacesDBUtils`, r=mak This includes 2 things: 1. Replacing the parts which test the logs for the presence of prefixes by testing the returned map for `suceeded`. 2. We don't need to wait to observe the topic anymore, we can simply await methods from `PlacesDBUtils` to know when they are done. MozReview-Commit-ID: Ct9l9pzUW5x
8bc2a9f1ecd9: Bug 1036440 - Refactor and use async/await and withConnectionWrapper/promiseDBConnection in PlacesDBUtils, r=mak
milindl <i.milind.luthra@gmail.com> - Fri, 19 May 2017 23:45:40 +0530 - rev 360897
Push 31904 by archaeopteryx@coole-files.de at Sat, 27 May 2017 07:50:57 +0000
Bug 1036440 - Refactor and use async/await and withConnectionWrapper/promiseDBConnection in PlacesDBUtils, r=mak Convert functions to async/await, and all DBConns to withConnectionWrapper to make PlacesDBUtils as asynchronous as possible. Replaces the `Tasks` object and `_executeTasks` method with a simpler mechanism of waiting on the various (async) functions. The entire system of text based logging using the prefixes ">", "+", "-" has been revamped so that `runTasks`, 'maintenanceOnIdle`and `checkAndFixDatabase` return a Map. A method `getLegacyLog` is provided to convert this Map to the legacy logs. The logs are structured slightly differently from the legacy logs, but the prefix system is essentially the same. The current consumers of do not suffer due to this change, while any new consumers should not use the method at all. MozReview-Commit-ID: 9Fm7cFyFID3
74a3dc70ad7d: Bug 1350377 - Remove `getPlacesInfo` and change associated files and tests, r=mak
milindl <i.milind.luthra@gmail.com> - Wed, 17 May 2017 16:02:21 +0530 - rev 359189
Push 31849 by ryanvm@gmail.com at Fri, 19 May 2017 15:38:10 +0000
Bug 1350377 - Remove `getPlacesInfo` and change associated files and tests, r=mak Files which make use of `getPlacesInfo` have been replaced with `History.fetch`. The code for `GetPlacesInfo` has been deleted from the cpp and idl files. The test for `getPlacesInfo` has been suitably rewritten and moved alongside the other History.jsm tests. There were 2 places where the fact that `getPlacesInfo` takes an array as opposed to a single uri mattered, in `test_getPlacesInfo.js` and `test_refresh_firefox.py`. MozReview-Commit-ID: KQSMHCvvlrQ
1eac66ddfb73: Bug 1350377 - Implement `History.fetch` and accordingly change `promisePlaceInfo`, r=mak
milindl <i.milind.luthra@gmail.com> - Mon, 15 May 2017 19:37:19 +0530 - rev 359188
Push 31849 by ryanvm@gmail.com at Fri, 19 May 2017 15:38:10 +0000
Bug 1350377 - Implement `History.fetch` and accordingly change `promisePlaceInfo`, r=mak `fetch` was written from scratch to query the database and get information for a single page to replace `getPlacesInfo`. A parameter for visits was also added to the signature (default by false) since it's feasible to get the visits for a single page. `promisePlaceInfo` was marked deprecated and turned into a wrapper for fetch. MozReview-Commit-ID: 9ZYHOmrpCHg
8840f2afc5f9: Bug 1249263 - add a `removeByFilter` method to filter by host and time,r=mak
i.milind.luthra+590334 <i.milind.luthra@gmail.com> - Thu, 11 May 2017 17:22:27 +0200 - rev 357847
Push 31804 by kwierso@gmail.com at Fri, 12 May 2017 00:33:03 +0000
Bug 1249263 - add a `removeByFilter` method to filter by host and time,r=mak Added a method in History to filter by host and timeframe, which is designed to act as a replacement for `RemovePagesByTimeFrame` and `RemovePagesFromHost` in the old API. The `filter` object accepts both a host argument, as well as a timeframe, and filters as per one or both of them. This also moves certain code (the method `validatePageInfo` and methods it uses) from History to PlacesUtils such that we can use it for testing as well, and modifies the method to take another parameter which decides whether the visits inside the pageInfo need to be validated as well (since the pageInfo returned from History.jsm::`remove` and History.jsm::`removeByFilter` do not pass a visits array in their callback functions. Shifts `ensureDate` and `isValidTransitionType`(now renamed to `isValidTransition`) inside the history object. MozReview-Commit-ID: EQAHmjf7131
860cafd805c8: Bug 1247201 - yield on tests using removeDataFromDomain,r=mak
milindl <i.milind.luthra@gmail.com> - Fri, 17 Mar 2017 14:29:48 +0530 - rev 350041
Push 31567 by kwierso@gmail.com at Tue, 28 Mar 2017 20:16:07 +0000
Bug 1247201 - yield on tests using removeDataFromDomain,r=mak This changeset changes tests using ForgetAboutSite.removeDataFromDomain to yield on it, since now it is a Task MozReview-Commit-ID: 72OEYoO1avd