ff6c67a5c98680051727e4e9aac42fd28ca59119: Backed out changeset 61a277705d59 (bug 1400438) for heap write hazard. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 20 Sep 2017 16:52:02 +0200 - rev 381918
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Backed out changeset 61a277705d59 (bug 1400438) for heap write hazard. r=backout
f9e527aa4ba5d497880de2a677c51b8ee6e27e63: Bug 1401366. P2 - bail out Observe() if not subcribed per comment 2. r=kaku
JW Wang <jwwang@mozilla.com> - Wed, 20 Sep 2017 17:51:10 +0800 - rev 381917
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1401366. P2 - bail out Observe() if not subcribed per comment 2. r=kaku MozReview-Commit-ID: 4LEBD3g0OwX
0848279b2b72c10e8ae6b3cfcdff2e97355dc593: Bug 1401366. P1 - format HTMLMediaElement::ShutdownObserver. r=kaku
JW Wang <jwwang@mozilla.com> - Wed, 20 Sep 2017 17:46:34 +0800 - rev 381916
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1401366. P1 - format HTMLMediaElement::ShutdownObserver. r=kaku MozReview-Commit-ID: K9ZYTedgUjC
648e06c8b1b557c199d7c0ea0cf153cc1ad1bfe2: Bug 1396419 - adding null checks to avoid intermittent crash. r=drno
Michael Froman <mfroman@mozilla.com> - Mon, 18 Sep 2017 21:36:33 -0500 - rev 381915
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1396419 - adding null checks to avoid intermittent crash. r=drno MozReview-Commit-ID: 3ywGT90q1NQ
c2de01dc7c105214ffa0f75b61a7e5e0df2b98a5: Bug 1401242 - Fix removing bookmarks from tag groups - when getting the tagGuid from the node, we must get it async, rather than using the concrete guid. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 19 Sep 2017 20:47:26 +0100 - rev 381914
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1401242 - Fix removing bookmarks from tag groups - when getting the tagGuid from the node, we must get it async, rather than using the concrete guid. r=mak MozReview-Commit-ID: 7fGS6jFNVPl
39b1badf8930068d09478b89a21621c17244f06e: Bug 1401232 - ensure sidebar persists correctly on update, r=bgrins
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 20 Sep 2017 13:05:48 +0100 - rev 381913
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1401232 - ensure sidebar persists correctly on update, r=bgrins MozReview-Commit-ID: 84x9ys2inJz
7cd3e6b51b63e8af01c728674726eeebd22e9dbc: Bug 1401550 - Move talos tp6 OSX jobs from central to autoland; r=jmaher
Rob Wood <rwood@mozilla.com> - Wed, 20 Sep 2017 10:08:41 -0400 - rev 381912
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1401550 - Move talos tp6 OSX jobs from central to autoland; r=jmaher MozReview-Commit-ID: 6MuyU4WHW3o
76ba215c8f256d9f518c1107c89ec037fedc29b7: Bug 1388789 - clean up \0 emission in nsTextFormatter; r=froydnj
Tom Tromey <tom@tromey.com> - Wed, 06 Sep 2017 09:38:58 -0600 - rev 381911
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388789 - clean up \0 emission in nsTextFormatter; r=froydnj nsTextFormatter unconditionally emitted a trailing \0, leading some code elsewhere to have to work around this. This changes the code to only emit it in snprintf. MozReview-Commit-ID: G3CBpAPp9Tn
2409839d34ba36791e3910083afb6d364a85d0bc: Bug 1388789 - normalize null string handling in nsTextFormatter; r=froydnj
Tom Tromey <tom@tromey.com> - Wed, 06 Sep 2017 08:38:44 -0600 - rev 381910
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388789 - normalize null string handling in nsTextFormatter; r=froydnj The char* and char16_t* cases handled null strings differently; normalize them to both emit "(null)". MozReview-Commit-ID: IzRkc3pSSjl
e261f147b65f0871223d21bcb170b05da79c4d8c: Bug 1388789 - use nsTextFormatter::ssprintf in more places; r=froydnj
Tom Tromey <tom@tromey.com> - Wed, 06 Sep 2017 08:19:05 -0600 - rev 381909
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388789 - use nsTextFormatter::ssprintf in more places; r=froydnj A few places were using snprintf where ssprintf would be more appropriate. MozReview-Commit-ID: LnBy3IcG98C
5a294c3eff7cad30386079148ed7ba6872283584: Bug 1388789 - make nsTextFormatter runtime type-safe; r=froydnj
Tom Tromey <tom@tromey.com> - Fri, 01 Sep 2017 14:03:56 -0600 - rev 381908
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388789 - make nsTextFormatter runtime type-safe; r=froydnj Change nsTextFormatter functions to template functions, box their arguments, and then make the formatter mostly impervious to type mismatches. Most formatting is done according to the type of the actual argument. MozReview-Commit-ID: H8WmyxFCb7s
2c6474a8bc311bd18f71d9a19d568a3a69210bd3: Bug 1388789 - change return values of nsTextFormatter::vs{s,v}printf; r=froydnj
Tom Tromey <tom@tromey.com> - Tue, 05 Sep 2017 13:17:49 -0600 - rev 381907
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388789 - change return values of nsTextFormatter::vs{s,v}printf; r=froydnj nsTextFormatter::vsnprintf is defined to return uint32_t(-1) on error. However, it was not doing this. nsTextFormatter::vssprintf is defined as infallible; enforce this by having it return void. MozReview-Commit-ID: LdOhIHzRvAT
2aa6bbd7fca8687c08e107863baef93918f91788: Bug 1388789 - handle unrecognized escapes in nsTextFormatter; r=froydnj
Tom Tromey <tom@tromey.com> - Fri, 01 Sep 2017 08:31:49 -0600 - rev 381906
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388789 - handle unrecognized escapes in nsTextFormatter; r=froydnj nsTextFormatter tried to pass unrecognized escapes in the format string through to the output. However, if the format held a width or precision, that text was not output. It seems better to me to try to preserve the format text as-is. MozReview-Commit-ID: HoBykpfzK7C
ed7a9616664877b2a543deb84090201a0543b2d5: Bug 1388789 - fix invalid format in appcacheutils.properties; r=flod,pbro
Tom Tromey <tom@tromey.com> - Tue, 19 Sep 2017 09:59:19 -0600 - rev 381905
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388789 - fix invalid format in appcacheutils.properties; r=flod,pbro MozReview-Commit-ID: KvteeshxD9R
c118b2a8f1b12e7354b8fe284b489310bc717d99: Bug 1388789 - replace hex strings with static arrays; r=froydnj
Tom Tromey <tom@tromey.com> - Fri, 01 Sep 2017 06:25:11 -0600 - rev 381904
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388789 - replace hex strings with static arrays; r=froydnj nsTextFormatter used nsAutoString for arrays of hex digits; but this didn't seem to provide any benefit. MozReview-Commit-ID: EYHtnAzJL8h
ec3f626df9d1fde0095c0df104a7f4e7863ca5ff: Bug 1388789 - remove prio.h include from nsTextFormatter.h; r=froydnj
Tom Tromey <tom@tromey.com> - Thu, 31 Aug 2017 15:22:36 -0600 - rev 381903
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388789 - remove prio.h include from nsTextFormatter.h; r=froydnj This header is not needed here. MozReview-Commit-ID: 1msozRXsHXR
e9844f691218261440035e835748826b64c7ca38: Bug 1388789 - make va_list nsTextFormatter private; r=froydnj
Tom Tromey <tom@tromey.com> - Thu, 31 Aug 2017 15:21:37 -0600 - rev 381902
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388789 - make va_list nsTextFormatter private; r=froydnj The runtime type-checking rewrite of nsTextFormatter will not support va_list uses. So, make these functions private and fix the sole user. MozReview-Commit-ID: IBWALVzIcHC
81457c20869561533141c80aaf762a39ecfedbda: Bug 1398531 - Toolbarbuttons are standardized with a min-height of 24px, but the zoom percentage button is text-only, thus needs a different treatment. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Wed, 20 Sep 2017 15:19:44 +0200 - rev 381901
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1398531 - Toolbarbuttons are standardized with a min-height of 24px, but the zoom percentage button is text-only, thus needs a different treatment. r=Gijs MozReview-Commit-ID: 3PEESkH7J7T
5a1251678a2c07b94c82a10b72975b306989215d: Bug 1388422 - Remove all traces of the Customize Mode tip panel that no longer applies. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Wed, 20 Sep 2017 14:37:53 +0200 - rev 381900
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388422 - Remove all traces of the Customize Mode tip panel that no longer applies. r=Gijs MozReview-Commit-ID: IffDnXEqooR
3440f3e480ebac94ca6abe87e4c427930d50eef6: Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Wed, 20 Sep 2017 14:25:58 +0200 - rev 381899
Push 32542 by kwierso@gmail.com at Wed, 20 Sep 2017 21:07:55 +0000
Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs MozReview-Commit-ID: 44Q9NbKEJeC
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip