fdabfde164e98448cd76dc229e204b1749f0a00c: Bug 1646456 - Remove unused noCleanup argument from removeActorPool r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Mon, 22 Jun 2020 12:54:26 +0000 - rev 536863
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646456 - Remove unused noCleanup argument from removeActorPool r=nchevobbe
Depends on D80059
removeActorPool is only called from one spot, which always passes the second optional argument as true.
Differential Revision:
https://phabricator.services.mozilla.com/D80060
8704e81643c67e889a76479065d3ba7900a2f672: Bug 1646456 - Add xpcshell test to check pool destruction when connection closes r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Tue, 23 Jun 2020 10:13:59 +0000 - rev 536862
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646456 - Add xpcshell test to check pool destruction when connection closes r=nchevobbe
Differential Revision:
https://phabricator.services.mozilla.com/D80059
7ca3d4bada7371ff782a50f74a29126ad050a38a: Bug 1647235 - [wpt-sync] Update web-platform-tests to e00ec6eab3f3596cd28e8a70d24a6ef3a65e3508, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Mon, 22 Jun 2020 10:46:00 +0000 - rev 536861
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1647235 - [wpt-sync] Update web-platform-tests to e00ec6eab3f3596cd28e8a70d24a6ef3a65e3508, a=testonly
MANUAL PUSH: wpt sync bot
wpt-head: e00ec6eab3f3596cd28e8a70d24a6ef3a65e3508
wpt-type: landing
0e973f98258515a9640d3bd9569d7e672c7120ff: Bug 1647086 [wpt PR 24265] - Initialize text_offset for layout-generated text items, a=testonly
Koji Ishii <kojii@chromium.org> - Mon, 22 Jun 2020 10:45:39 +0000 - rev 536860
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1647086 [wpt PR 24265] - Initialize text_offset for layout-generated text items, a=testonly
Automatic update from web-platform-tests
Initialize text_offset for layout-generated text items
|NGLogicalLineItem::text_offset| is not used for layout-
generated text items, but |NGLineTruncator| may try to
truncate it in some edge cases since r779756
<crrev.com/c/2230583>.
This patch initializes |text_offset| for such items to
avoid accidental reads. Trying to truncate hyphens is not
correct, but this will be in future patches.
Bug: 1097042
Change-Id: Ife1f4def3568e387a17422c547e676dd2d88dac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256100
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780609}
--
wpt-commits: 40724da33edf9653287985ff4f7b226ce60a0097
wpt-pr: 24265
1e94519c3c73dc46f61080e6f93bcccbd3fc5ec1: Bug 1646978 [wpt PR 24251] - [Portals] Disallow activation during unload, a=testonly
David Bokan <bokan@chromium.org> - Mon, 22 Jun 2020 10:45:34 +0000 - rev 536859
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646978 [wpt PR 24251] - [Portals] Disallow activation during unload, a=testonly
Automatic update from web-platform-tests
[Portals] Disallow activation during unload
This CL makes it so that portal activation is blocked when the document
enters a beforeunload handler. If the unload proceeds, portal activation
will continue to be blocked
This must be implemented inside the renderer as the renderer can
initiate navigations which the browser won't hear about until after
beforeunload is confirmed. We do this by looking at the Document's
LoadEventProgress state.
Unfortunately, the current behavior is that, following a beforeunload,
this state would progress unconditionally to
kBeforeUnloadEventCompleted. This prevents us from distinguishing the
case where the navigation is canceled, which should once again allow
portal activation. This CL updates this state to only progress to the
(renamed for consistency and clarity) kBeforeUnloadEventCompleted state
only after we confirm the unload will proceed.
Bug: 1043764
Change-Id: I80363ccf2228e3dc5434486c95c62c17e00743aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251104
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780470}
--
wpt-commits: 4877e40ba4bc993de5ccbd206845b63ceb07a892
wpt-pr: 24251
2beded47c0dcc3ca69cdc16bfa970aa0c61cb8d3: Bug 1646614 [wpt PR 24224] - [FlexNG] Multiplying by aspect ratio should ignore border/padding, a=testonly
David Grogan <dgrogan@chromium.org> - Mon, 22 Jun 2020 10:45:29 +0000 - rev 536858
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646614 [wpt PR 24224] - [FlexNG] Multiplying by aspect ratio should ignore border/padding, a=testonly
Automatic update from web-platform-tests
[FlexNG] Multiplying by aspect ratio should ignore border/padding
Only the content box should be multiplied by the aspect ratio to derive
the size of a side given the other side and the aspect ratio.
So, subtract the border/padding from the side you have, then multiply to
get the content size, then add that side's border/padding.
Bug: 1094311
Change-Id: Ib69a224cdb369c3fa46f5d432af73eb131781673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251202
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780401}
--
wpt-commits: ee0367139c6b8c56d7ce9b0b182a28cd43de4d66
wpt-pr: 24224
45c811855f6b398eac193c225a86c221e7cc63af: Bug 1646782 [wpt PR 24239] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 19 Jun 2020 18:34:34 +0000 - rev 536857
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646782 [wpt PR 24239] - Update wpt metadata, a=testonly
wpt-pr: 24239
wpt-type: metadata
c65c4192193552d6057f41ec657d468fae1ce7fe: Bug 1646782 [wpt PR 24239] - COOP access reporting. Update the test suite., a=testonly
arthursonzogni <arthursonzogni@chromium.org> - Mon, 22 Jun 2020 10:45:09 +0000 - rev 536856
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646782 [wpt PR 24239] - COOP access reporting. Update the test suite., a=testonly
Automatic update from web-platform-tests
COOP access reporting. Update the test suite.
It has been decided to monitor only the attributes marked as CrossOrigin
instead of every attributes. Updating the tests accordingly.
Along the way some improvements.
Bug: chromium:1090273
Change-Id: Iecd0bd478ab348f75f3835105db5bdca9edcc39b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252339
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780247}
--
wpt-commits: ae56420c66a0f04b2ea72d0852536d3540c73c07
wpt-pr: 24239
ffe6dcb7c6460f0e573a38ec758321493c79d8e4: Bug 1642961 [wpt PR 23941] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 19 Jun 2020 18:09:27 +0000 - rev 536855
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1642961 [wpt PR 23941] - Update wpt metadata, a=testonly
wpt-pr: 23941
wpt-type: metadata
d66ae07454fffe60e879b1b66fd7afdf03f27eca: Bug 1642961 [wpt PR 23941] - [nativeio] NativeIO: Add Rename., a=testonly
Richard Stotz <rstz@chromium.org> - Mon, 22 Jun 2020 10:45:01 +0000 - rev 536854
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1642961 [wpt PR 23941] - [nativeio] NativeIO: Add Rename., a=testonly
Automatic update from web-platform-tests
[nativeio] NativeIO: Add Rename.
Bug: 914488
Change-Id: I81a96bc4f395d82d7a0c1d804eef25a861eb1fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228152
Commit-Queue: Richard Stotz <rstz@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780220}
--
wpt-commits: 81785c7e2e7c6ba72fc3996066d4d11761ff0eda
wpt-pr: 23941
88fa5bd17cde18067f9ef26b10636a333e119e51: Bug 1646108 [wpt PR 24168] - Fix handling of remote frames and URLs in performance.measureMemory, a=testonly
Ulan Degenbaev <ulan@chromium.org> - Mon, 22 Jun 2020 10:44:55 +0000 - rev 536853
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646108 [wpt PR 24168] - Fix handling of remote frames and URLs in performance.measureMemory, a=testonly
Automatic update from web-platform-tests
Fix handling of remote frames and URLs in performance.measureMemory
The existing implementation measures memory usage of the main JS agent
and reports URLs of the JS realms in the agent. The algorithm for
mapping a JS realm to its reported URL walks the frame tree upwards to
find the top-most cross-origin frame. The algorithm incorrectly assumed
that all frames the path are local frames since the realms are local.
This does not hold in the ABA case, where the main origin A embeds
an iframe from origin B that in turn embeds an iframe from origin A.
In such a case, the main JS realm and the grandchild realm are in the
same JS agent and their frames are local. However, the child frame B
is a remote frame.
This CL fixes the algorithm to work both with local and remote frames.
The URL of a remote frame can no longer be fetched from its document.
Instead, it is fetched from the src attribute of the owner iframe
element. This aligns with the upcoming spec and fixes the leak of
post-server-redirect URLs.
The CL also removes LocalFrame::FirstUrlCrossOriginToParent that is
no longer needed.
Bug: 1093880,1084999
Change-Id: I7a57a17701448d0fe210a66c7bdb8c0229fa5149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246175
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780319}
--
wpt-commits: 6221819cb0d18cee78ea5d011a8170b20a4fb5df
wpt-pr: 24168
406df6d65cc57594968a45a1fe5ec067979ae53f: Bug 1646929 [wpt PR 24248] - [FragmentItem] Skip already added children in CreateBoxFragment, a=testonly
Koji Ishii <kojii@chromium.org> - Mon, 22 Jun 2020 10:44:50 +0000 - rev 536852
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646929 [wpt PR 24248] - [FragmentItem] Skip already added children in CreateBoxFragment, a=testonly
Automatic update from web-platform-tests
[FragmentItem] Skip already added children in CreateBoxFragment
FragmentItem keeps all inline items in a flat list. When
inline box fragments are nested, |CreateBoxFragment| handles
the same item twice; once for its parent and another for its
grand parent.
This patch fixes this by skipping non-direct children.
Bug: 1096957
Change-Id: If5acba0c5bd687d156cc4530fbe6123bca9840ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251643
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780231}
--
wpt-commits: 7fa40bc15a3af48dd0b6dd6d8cd16b109ac5d61e
wpt-pr: 24248
28cfa6865c05bc6e48070f45e4c1ce0d9f8c46c3: Bug 1646907 [wpt PR 24247] - SELECT element: Fix a regression on adding multiple selected OPTIONs to a single-selection SELECT, a=testonly
Kent Tamura <tkent@chromium.org> - Mon, 22 Jun 2020 10:44:45 +0000 - rev 536851
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646907 [wpt PR 24247] - SELECT element: Fix a regression on adding multiple selected OPTIONs to a single-selection SELECT, a=testonly
Automatic update from web-platform-tests
SELECT element: Fix a regression on adding multiple selected OPTIONs to a single-selection SELECT
This CL fixes a regression caused by crrev.com/745230.
Bug details:
Suppose that |select.innerHTML = '<option selected>Option1' +
'<option selected>Option2'| runs.
Before crrev.com/745230,
1. Option1 is appended to the SELECT.
2. HTMLOptionElement::InsertedInto() and |HTMLSelectElement::
OptionInserted()| are called for Option1.
3. SelectOption(Option1) is called.
4. DeselectItemsWithoutValidation(Option1) is called
5. Option2 is appended to the SELECT.
6. HTMLOptionElement::InsertedInto() and |HTMLSelectElement::
OptionInserted()| are called for Option2.
7. SelectOption(Option2) is called.
8. DeselectItemsWithoutValidation(Option2) is called. Option1's
selected state is cleared.
Since crrev.com/745230,
1. Option1 is appended to the SELECT.
2. Option2 is appended to the SELECT.
3. HTMLSelectElement::ChildrenChanged() and |HTMLSelectElement::
OptionInserted()| are called for Option1.
4. SelectOption(Option1) is called.
5. DeselectItemsWithoutValidation(Option1) is called. Option2's
selected state is cleared.
6. HTMLSelectElement::ChildrenChanged() and |HTMLSelectElement::
OptionInserted()| are called for Option2.
7. SelectOption(Option2) is NOT called because Option2's selected
state was cleared.
Fix:
DeselectItemsWithoutValidation() should not update 'selected' state of
OPTIONs for which OptionInserted() is not called yet. This CL adds a
boolean flag to HTMLOptionElement, it represents whether
OptionInserted() is called or not, and DeselectItemsWithoutValidation()
checks the flag before updating 'selected' state.
Bug: 1095725
Change-Id: If19b28c3edb877549ca498b661647466d03e6d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253260
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780174}
--
wpt-commits: e75a8342e588e36a6ab387846a50d077621143b4
wpt-pr: 24247
7bdb48de0eaee90fe970078b5c28f4fe413f7297: Bug 1646879 [wpt PR 24244] - [FileAPI] Properly set charset when loading blob URL., a=testonly
Marijn Kruisselbrink <mek@chromium.org> - Mon, 22 Jun 2020 10:44:38 +0000 - rev 536850
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646879 [wpt PR 24244] - [FileAPI] Properly set charset when loading blob URL., a=testonly
Automatic update from web-platform-tests
[FileAPI] Properly set charset when loading blob URL.
Bug: 1086845
Change-Id: I1630dcff89198ea968ff49ff353d793ae19c10b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253242
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780118}
--
wpt-commits: 80a7c1baefc0eacfb045a0d6cb35befbc7b54c66
wpt-pr: 24244
f4c08ad7631b1da1a7315e05e371ee975c374ba1: Bug 1646239 [wpt PR 24177] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 19 Jun 2020 03:50:37 +0000 - rev 536849
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646239 [wpt PR 24177] - Update wpt metadata, a=testonly
wpt-pr: 24177
wpt-type: metadata
f468703d8535544aa322cf833519cb2f7eec8003: Bug 1646239 [wpt PR 24177] - Add getWindowSegments JavaScript API, a=testonly
Daniel Libby <dlibby@microsoft.com> - Mon, 22 Jun 2020 10:44:30 +0000 - rev 536848
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646239 [wpt PR 24177] - Add getWindowSegments JavaScript API, a=testonly
Automatic update from web-platform-tests
Add getWindowSegments JavaScript API
This change builds on crrev.com/c/2229668 to plumb the window segment
information from the content layer into Blink, where it is exposed via
a JavaScript API.
From RenderWidget, the root window segments are stored on the
local WebFrameWidgetBase root, and returned via script through the
FrameWidget interface.
i2p: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/_1_ljYsaqrU/qOoHJ7MhAgAJ
Explainer: https://github.com/webscreens/window-segments/blob/master/EXPLAINER.md
Change-Id: I9b80f189e41160fc490bd09191722cb20b7115e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246988
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780102}
--
wpt-commits: 565dbc0bd35f3c4d34ad8c3fac0593d64d85bae9
wpt-pr: 24177
eae3eced148f41177408b1949e9f7c4707f26271: Bug 1646422 [wpt PR 24198] - blink: make LayoutBlock::RemovePositionedObject remove other objects, a=testonly
Scott Violet <sky@chromium.org> - Mon, 22 Jun 2020 10:44:25 +0000 - rev 536847
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646422 [wpt PR 24198] - blink: make LayoutBlock::RemovePositionedObject remove other objects, a=testonly
Automatic update from web-platform-tests
blink: make LayoutBlock::RemovePositionedObject remove other objects
This changes RemovePositionedObjects to remove any fixed-pos descendants.
This ensures that if the removed object is added back, it doesn't end up
after any descendants, which would cause out of order layout.
BUG=1092887
TEST=webkit-box-fixed-position-child.html
Change-Id: I41f01bad74048cf4983f0dda5fe0f073b3eb38f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248136
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779840}
--
wpt-commits: 5756870d039495439b8512c26db05f25aaa3a0d7
wpt-pr: 24198
fb8880027ccc3461bfc050029fc16353b47c5c6d: Bug 1646679 [wpt PR 24233] - Fix timeout on RTCRtpTransceiver test., a=testonly
Harald Alvestrand <hta@chromium.org> - Mon, 22 Jun 2020 10:44:16 +0000 - rev 536846
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646679 [wpt PR 24233] - Fix timeout on RTCRtpTransceiver test., a=testonly
Automatic update from web-platform-tests
Fix timeout on RTCRtpTransceiver test.
This CL should make the test run consistently and always finish; we break
out early from the test that was failing rather than waiting forever.
Bug: chromium:869126
Change-Id: Ic52fbf0dea69a03645165a073354f61a3d28ad81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250065
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779810}
--
wpt-commits: e3b772cdc0498672231311012995a6a1c7d9fbff
wpt-pr: 24233
d55974431473f1bb534fbd4d20dc4e3c8004c39b: Bug 1646147 [wpt PR 24171] - wpt: fix webrtc simulcast rids, a=testonly
Philipp Hancke <philipp.hancke@googlemail.com> - Mon, 22 Jun 2020 10:44:11 +0000 - rev 536845
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1646147 [wpt PR 24171] - wpt: fix webrtc simulcast rids, a=testonly
Automatic update from web-platform-tests
wpt: fix webrtc simulcast rids
which need an extra parenthesis since this should be an object
as shown in
https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example*
Noticed in
https://github.com/fippo/simulcast-playground/pull/7
BUG=None
Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247035
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779785}
--
wpt-commits: 52a9f1c847e094e7925ae69bcc5bf4ff40826e45
wpt-pr: 24171
66944f0e6639faca7de7b6df84da977b82abece0: Bug 1643477 [wpt PR 23998] - Check for first frame in CreateImageBitmap, a=testonly
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> - Mon, 22 Jun 2020 10:44:06 +0000 - rev 536844
Push
37533 by dluca@mozilla.com at Tue, 23 Jun 2020 21:38:40 +0000
Bug 1643477 [wpt PR 23998] - Check for first frame in CreateImageBitmap, a=testonly
Automatic update from web-platform-tests
Check for first frame in CreateImageBitmap (#23998)
HTMLVideoElement::CreateImageBitmap is currently rejecting valid calls,
when we have an available first frame, but the ready state hasn't been
updated.
This CL updates CreateImageBitmap to check for a valid frame, which
amounts to having a first frame available.
This CL also updates some WPTs to use preload=auto, to allow video
elements to load without being visible, and yield expected results when
calling CreateImageBitmap.
Bug: 1090960
Change-Id: I21302a9c3433bf8218a75c3f6918bc20f4d36ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231453
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775670}
Co-authored-by: Thomas Guilbert <tguilbert@chromium.org>
--
wpt-commits: 55999f0667e5ae85e3bd80e6a1d2c6ff8eb6d988
wpt-pr: 23998