fd42da5a8e1a571a356f5a18d7417116dcb63389: Bug 550559 - also show close warnings when session restore is active, r=jaws,flod
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 02 Nov 2018 20:03:50 +0000 - rev 444489
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 550559 - also show close warnings when session restore is active, r=jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D10217
f6f47d5b05b68597739e059cc707573a3d1cea01: Bug 1499169 - Split MIME type of nsObjectLoadingContent when retreived from tag; r=bzbarsky
Kyle Machulis <kyle@nonpolynomial.com> - Mon, 05 Nov 2018 22:06:23 +0000 - rev 444488
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499169 - Split MIME type of nsObjectLoadingContent when retreived from tag; r=bzbarsky MIME type should be trimmed of parameters whenever it is retreived from the tag it relates to, otherwise other checks may fail. Differential Revision: https://phabricator.services.mozilla.com/D10803
e36fa00c208967777b85d23194bc1900ca654cb1: Bug 1502385 - Filter matches and providers in the Quantum Bar manager. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Mon, 05 Nov 2018 21:54:09 +0000 - rev 444487
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1502385 - Filter matches and providers in the Quantum Bar manager. r=adw Differential Revision: https://phabricator.services.mozilla.com/D10348
10d5db1fc33fa0ef81202e9a6fdd1771a85c1af9: Bug 1462499 - changed priority of harmful. r=francois
matthias <matthias@kammueller.eu> - Mon, 24 Sep 2018 15:51:50 +0000 - rev 444486
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1462499 - changed priority of harmful. r=francois Differential Revision: https://phabricator.services.mozilla.com/D6570
14f6d3d137ac8edab4cec6254693e42db59ab31b: Bug 1504833 - Remove vestigial TitlebarAndBackgroundColor definition. r=spohl
Markus Stange <mstange@themasta.com> - Mon, 05 Nov 2018 21:17:12 +0000 - rev 444485
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1504833 - Remove vestigial TitlebarAndBackgroundColor definition. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D10962
65c79ddf98f0fd8c9bf88244fce40e2b1c7b2c4b: Bug 1498625 - Part 2: Switch VR process to TYPE_MOZILLA_CHILD message loop type. r=froydnj,handyman
Daosheng Mu <daoshengmu@gmail.com> - Mon, 05 Nov 2018 21:28:38 +0000 - rev 444484
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1498625 - Part 2: Switch VR process to TYPE_MOZILLA_CHILD message loop type. r=froydnj,handyman Differential Revision: https://phabricator.services.mozilla.com/D10643
604c2334df1d25f4abc1c5a8a2cad89e1ecfce5a: Bug 1498625 - Part 1: Move VRHapticThread start/end to the main thread. r=kip,froydnj
Daosheng Mu <daoshengmu@gmail.com> - Fri, 02 Nov 2018 21:54:12 +0000 - rev 444483
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1498625 - Part 1: Move VRHapticThread start/end to the main thread. r=kip,froydnj Differential Revision: https://phabricator.services.mozilla.com/D10642
ccf46ccf351988116723f6a78c887757941c5348: Backed out 9 changesets (bug 1499507) for build bustages on /profiler/core/platform.cpp. CLOSED TREE
Brindusan Cristian <cbrindusan@mozilla.com> - Mon, 05 Nov 2018 23:24:49 +0200 - rev 444482
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Backed out 9 changesets (bug 1499507) for build bustages on /profiler/core/platform.cpp. CLOSED TREE Backed out changeset 4c79a5557d7b (bug 1499507) Backed out changeset 35d05a53e0a9 (bug 1499507) Backed out changeset 9254e6c721b3 (bug 1499507) Backed out changeset cf40b044af3f (bug 1499507) Backed out changeset 76dd85b9aaf7 (bug 1499507) Backed out changeset 6256446f16c4 (bug 1499507) Backed out changeset 41cede6bc7d2 (bug 1499507) Backed out changeset 30476b824eb4 (bug 1499507) Backed out changeset 24a9494155fe (bug 1499507)
d0a2f61e2d9916a5888a1798833e0439d9deea5e: Bug 1500119 - Allow for retrigger adjustment when backfilling perf jobs and remove old geckoProfile support. r=ahal
Joel Maher <jmaher@mozilla.com> - Mon, 05 Nov 2018 21:17:03 +0000 - rev 444481
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1500119 - Allow for retrigger adjustment when backfilling perf jobs and remove old geckoProfile support. r=ahal Allow for retrigger adjustments when backfilling perf jobs and remove the now outdated geckoProfile support in this custom job action. Differential Revision: https://phabricator.services.mozilla.com/D10742
ca875dd78b3c1d9999fa7f6704f975d0dbbc2d3d: Bug 1503950 insert new timeline events after existing events at the same time even when of the same type r=padenot
Karl Tomlinson <karlt+@karlt.net> - Mon, 05 Nov 2018 12:25:04 +0000 - rev 444480
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1503950 insert new timeline events after existing events at the same time even when of the same type r=padenot Depends on D10861 Differential Revision: https://phabricator.services.mozilla.com/D10862
bf705d04c328085c490e5a9f111b9143123b3cc9: Bug 1503950 test 3 events of the same type at the same time r=padenot
Karl Tomlinson <karlt+@karlt.net> - Mon, 05 Nov 2018 12:25:11 +0000 - rev 444479
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1503950 test 3 events of the same type at the same time r=padenot Depends on D10860 Differential Revision: https://phabricator.services.mozilla.com/D10861
de1d24ff32ae3bd5cb658a144784d0932e5d0ab3: Bug 1503950 remove obsolete expected subtest failures r=padenot
Karl Tomlinson <karlt+@karlt.net> - Mon, 05 Nov 2018 12:25:18 +0000 - rev 444478
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1503950 remove obsolete expected subtest failures r=padenot These have been lingering due to bug 1474463. Differential Revision: https://phabricator.services.mozilla.com/D10860
4c79a5557d7b48f90dc46206d798b277ff8f1606: Bug 1499507 - Allow the compiler to generate a non-atomic increment instruction for the stack pointer increment. r=njn
Markus Stange <mstange@themasta.com> - Mon, 05 Nov 2018 20:58:39 +0000 - rev 444477
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499507 - Allow the compiler to generate a non-atomic increment instruction for the stack pointer increment. r=njn This change reduces the binary size on macOS x64 by around 50KB. Here's a diff of the impact on the code generated for Attr_Binding::get_specified in the Mac build. It's a bit hard to read because %r12 and %rbx swap their function, but what happens in this method is that "movq %r12, %rcx" goes away, and the two instructions "leal 0x1(%r12) %eax" and "movl %eax, 0x10(%rbx)" turn into an "incl 0x10(%r12)". So the old code was preserving the original value of profilingStack->stackPointer in a register, and then using it later to compute the incremented stackPointer. The new code uses an "incl" instruction for the stackPointer increment and doesn't worry that the stackPointer value might have changed since the stack size check at the start of the function. (It can't have changed.) before: %rbx has the ProfilingStack*, %r12 has profilingStack->stackPointer after: %r12 has the ProfilingStack*, %rbx has profilingStack->stackPointer @@ -3,37 +3,35 @@ movq %rsp, %rbp pushq %r15 pushq %r14 pushq %r12 pushq %rbx subq $0x10, %rsp movq %rcx, %r14 movq %rdx, %r15 - movq 0x80(%rdi), %rbx - movq %rbx, -40(%rbp) - testq %rbx, %rbx + movq 0x80(%rdi), %r12 + movq %r12, -40(%rbp) + testq %r12, %r12 je loc_xxxxx - movl 0x10(%rbx), %r12d - cmpl (%rbx), %r12d + movl 0x10(%r12), %ebx + cmpl (%r12), %ebx jae loc_xxxxx - movq 0x8(%rbx), %rax - movq %r12, %rcx - shlq $0x5, %rcx - leaq aAttr, %rdx ; "Attr" - movq %rdx, (%rax,%rcx) - leaq aSpecified, %rdx ; "specified" - movq %rdx, 0x8(%rax,%rcx) - leaq -40(%rbp), %rdx - movq %rdx, 0x10(%rax,%rcx) - movl $0x3a1, 0x1c(%rax,%rcx) - leal 0x1(%r12), %eax - movl %eax, 0x10(%rbx) + movq 0x8(%r12), %rax + shlq $0x5, %rbx + leaq aAttr, %rcx ; "Attr" + movq %rcx, (%rax,%rbx) + leaq aSpecified, %rcx ; "specified" + movq %rcx, 0x8(%rax,%rbx) + leaq -40(%rbp), %rcx + movq %rcx, 0x10(%rax,%rbx) + movl $0x3a1, 0x1c(%rax,%rbx) + incl 0x10(%r12) movq %r15, %rdi call __ZNK7mozilla3dom4Attr9SpecifiedEv ; mozilla::dom::Attr::Specified() const movzxl %al, %eax movabsq $0xfff9000000000000, %rcx orq %rax, %rcx movq %rcx, (%r14) movq -40(%rbp), %rax @@ -47,11 +45,11 @@ popq %rbx popq %r12 popq %r14 popq %r15 popq %rbp ret ; endp - movq %rbx, %rdi + movq %r12, %rdi call __ZN14ProfilingStack18ensureCapacitySlowEv ; ProfilingStack::ensureCapacitySlow() jmp loc_xxxxx Depends on D9205 Differential Revision: https://phabricator.services.mozilla.com/D9206
35d05a53e0a988dbfba29bd3b56918010b5f20a4: Bug 1499507 - Use AUTO_PROFILER_LABEL_DYNAMIC_FAST for WebIDL APIs. r=bzbarsky
Markus Stange <mstange@themasta.com> - Mon, 05 Nov 2018 21:00:01 +0000 - rev 444476
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499507 - Use AUTO_PROFILER_LABEL_DYNAMIC_FAST for WebIDL APIs. r=bzbarsky This means that our binary does not need to include concatenated strings such as "set CanvasRenderingContext2D.fillStyle". It only needs to contain the individual strings "CanvasRenderingContext2D" and "fillStyle" which are most likely already present in the binary. This change reduces the binary size on macOS x64 by around 200KB. Here's a diff of the impact on the code generated for Attr_Binding::get_specified in the Mac build. This change makes us generate slightly more code, which is very much offset by the reduction in the amount of strings we ship. @@ -15,22 +15,23 @@ movl 0x10(%rbx), %r12d cmpl (%rbx), %r12d jae loc_xxxxx movq 0x8(%rbx), %rax movq %r12, %rcx shlq $0x5, %rcx - leaq aGetAttrspecifi, %rdx ; "get Attr.specified" + leaq aAttr, %rdx ; "Attr" movq %rdx, (%rax,%rcx) - movq $0x0, 0x8(%rax,%rcx) + leaq aSpecified, %rdx ; "specified" + movq %rdx, 0x8(%rax,%rcx) leaq -40(%rbp), %rdx movq %rdx, 0x10(%rax,%rcx) - movl $0x71, 0x1c(%rax,%rcx) + movl $0x3a1, 0x1c(%rax,%rcx) leal 0x1(%r12), %eax movl %eax, 0x10(%rbx) movq %r15, %rdi call __ZNK7mozilla3dom4Attr9SpecifiedEv ; mozilla::dom::Attr::Specified() const movzxl %al, %eax movabsq $0xfff9000000000000, %rcx orq %rax, %rcx Depends on D9204 Differential Revision: https://phabricator.services.mozilla.com/D9205
9254e6c721b32580fea698c20c8cb262770c85ac: Bug 1499507 - Add AUTO_PROFILER_LABEL_DYNAMIC_FAST which allows specifying flags. r=njn
Markus Stange <mstange@themasta.com> - Mon, 05 Nov 2018 20:57:30 +0000 - rev 444475
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499507 - Add AUTO_PROFILER_LABEL_DYNAMIC_FAST which allows specifying flags. r=njn Depends on D9203 Differential Revision: https://phabricator.services.mozilla.com/D9204
cf40b044af3f441382a691ad3afa92d9b963e029: Bug 1499507 - Add ProfilingStackFrame flags for to choose the string template that is used to combine the label with the dynamic string. r=njn
Markus Stange <mstange@themasta.com> - Mon, 05 Nov 2018 20:56:50 +0000 - rev 444474
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499507 - Add ProfilingStackFrame flags for to choose the string template that is used to combine the label with the dynamic string. r=njn These flags will be used by WebIDL APIs in an upcoming patch. Depends on D9199 Differential Revision: https://phabricator.services.mozilla.com/D9203
76dd85b9aaf7d550b23585b4be898b03e4811e27: Bug 1499507 - Convert the ProfilingStackFrame kind into a set of flags. r=njn
Markus Stange <mstange@themasta.com> - Mon, 05 Nov 2018 20:56:17 +0000 - rev 444473
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499507 - Convert the ProfilingStackFrame kind into a set of flags. r=njn This makes it easier to add more flags. Depends on D9197 Differential Revision: https://phabricator.services.mozilla.com/D9199
6256446f16c4e3b4c871504e7bbeca69871f2c3d: Bug 1499507 - Use AppendPrintf to concatenate the label with the dynamic string. r=njn
Markus Stange <mstange@themasta.com> - Mon, 05 Nov 2018 20:55:38 +0000 - rev 444472
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499507 - Use AppendPrintf to concatenate the label with the dynamic string. r=njn This code is run during JSON serialization so performance is not a big concern. Depends on D9195 Differential Revision: https://phabricator.services.mozilla.com/D9197
41cede6bc7d219f05c984acc95649283c81d8287: Bug 1499507 - Don't collect line numbers for profiling stack frames. r=njn
Markus Stange <mstange@themasta.com> - Mon, 05 Nov 2018 20:55:10 +0000 - rev 444471
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499507 - Don't collect line numbers for profiling stack frames. r=njn They were not displayed in the UI, and the instructions to initialize the line field of a stack frame increased code size unnecessarily. This change reduces the binary size on Linux x64 by around 100KB. Here's a diff of the impact on the code generated for Attr_Binding::get_specified in the Mac build: @@ -20,17 +20,16 @@ movq 0x8(%rbx), %rax movq %r12, %rcx shlq $0x5, %rcx leaq aGetAttrspecifi, %rdx ; "get Attr.specified" movq %rdx, (%rax,%rcx) movq $0x0, 0x8(%rax,%rcx) leaq -40(%rbp), %rdx movq %rdx, 0x10(%rax,%rcx) - movl $0x106, 0x18(%rax,%rcx) movl $0x1c, 0x1c(%rax,%rcx) leal 0x1(%r12), %eax movl %eax, 0x10(%rbx) movq %r15, %rdi call __ZNK7mozilla3dom4Attr9SpecifiedEv ; mozilla::dom::Attr::Specified() const movzxl %al, %eax movabsq $0xfff9000000000000, %rcx Depends on D9193 Differential Revision: https://phabricator.services.mozilla.com/D9195
30476b824eb400ec1ad0f3493d97df15f337a87e: Bug 1499507 - Make ensureCapacitySlow infallible. r=emilio
Markus Stange <mstange@themasta.com> - Mon, 05 Nov 2018 20:55:03 +0000 - rev 444470
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499507 - Make ensureCapacitySlow infallible. r=emilio This eliminates a few instructions from each inlined instance of AutoProfilerLabel because we no longer need to handle allocation failure in the inlined code. I think this allocation should be fine to make infallible: The allocation size is limited by the thread's stack depth, and we only hit this code path when the stack is the deepest it's ever been during the thread's life time. This change reduces the binary size on Linux x64 by around 100KB. Here's a diff of the impact on the code generated for Attr_Binding::get_specified in the Mac build, it really just eliminates one test and one jump at the very end of the method: @@ -9,30 +9,29 @@ movq %rcx, %r14 movq %rdx, %r15 movq 0x80(%rdi), %rbx movq %rbx, -40(%rbp) testq %rbx, %rbx je loc_xxxxx movl 0x10(%rbx), %r12d - cmpl %r12d, (%rbx) - jbe loc_xxxxx + cmpl (%rbx), %r12d + jae loc_xxxxx movq 0x8(%rbx), %rax movq %r12, %rcx shlq $0x5, %rcx leaq aGetAttrspecifi, %rdx ; "get Attr.specified" movq %rdx, (%rax,%rcx) movq $0x0, 0x8(%rax,%rcx) leaq -40(%rbp), %rdx movq %rdx, 0x10(%rax,%rcx) movl $0x106, 0x18(%rax,%rcx) movl $0x1c, 0x1c(%rax,%rcx) - leal 0x1(%r12), %eax movl %eax, 0x10(%rbx) movq %r15, %rdi call __ZNK7mozilla3dom4Attr9SpecifiedEv ; mozilla::dom::Attr::Specified() const movzxl %al, %eax movabsq $0xfff9000000000000, %rcx orq %rax, %rcx @@ -50,12 +49,9 @@ popq %r14 popq %r15 popq %rbp ret ; endp movq %rbx, %rdi call __ZN14ProfilingStack18ensureCapacitySlowEv ; ProfilingStack::ensureCapacitySlow() - testb %al, %al - jne loc_xxxxx - jmp loc_xxxxx Depends on D9192 Differential Revision: https://phabricator.services.mozilla.com/D9193
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip