fbc127829141099ee56f6363ef89c6597c013530: Bug 1723860 - Add event telemetry for Firefox Suggest onboarding modal prompt. r=dao
Dão Gottwald <dao@mozilla.com> - Sat, 11 Sep 2021 11:00:58 +0000 - rev 591682
Push 38780 by nbeleuzu@mozilla.com at Sat, 11 Sep 2021 21:22:43 +0000
Bug 1723860 - Add event telemetry for Firefox Suggest onboarding modal prompt. r=dao Differential Revision: https://phabricator.services.mozilla.com/D125244
b8e8fed16b1ee4b5f90918553e7ff834b7f591a2: Bug 1672900 - part 3: Make `ExtendOrShrinkRangeToDelete()` selects all contents in all list items if a list element is selected or all list items in a list element is selected r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 11 Sep 2021 07:17:38 +0000 - rev 591681
Push 38780 by nbeleuzu@mozilla.com at Sat, 11 Sep 2021 21:22:43 +0000
Bug 1672900 - part 3: Make `ExtendOrShrinkRangeToDelete()` selects all contents in all list items if a list element is selected or all list items in a list element is selected r=m_kato When a list element has non-empty list item element, even if the list element is selected, deleting operation should make the list element empty first (i.e., making the list element has only one empty list item element). Then, another deleting operation/command can delete it completely. This is Blink compat behavior in most cases except when the list has non-editable list item element as first and/or last child of it. Note that the new failures of the browserscpe are not compatible with the new behavior, that is, it wants a list element is deleted when the last list item is deleted. https://searchfox.org/mozilla-central/rev/08c493902519265d570250c8e7ce575c8cd6f5b5/editor/libeditor/tests/browserscope/lib/richtext2/richtext2/tests/delete.py#161-164 https://searchfox.org/mozilla-central/rev/08c493902519265d570250c8e7ce575c8cd6f5b5/editor/libeditor/tests/browserscope/lib/richtext2/richtext2/tests/forwarddelete.py#146-149 Here is same test in the WPT: https://searchfox.org/mozilla-central/rev/08c493902519265d570250c8e7ce575c8cd6f5b5/testing/web-platform/tests/input-events/input-events-get-target-ranges-deleting-in-list-items.tentative.html#386-402 And only Gecko failed in this case: https://searchfox.org/mozilla-central/rev/08c493902519265d570250c8e7ce575c8cd6f5b5/testing/web-platform/meta/input-events/input-events-get-target-ranges-deleting-in-list-items.tentative.html.ini#1449-1450 https://searchfox.org/mozilla-central/rev/08c493902519265d570250c8e7ce575c8cd6f5b5/testing/web-platform/meta/input-events/input-events-get-target-ranges-deleting-in-list-items.tentative.html.ini#1937-1938 https://searchfox.org/mozilla-central/rev/08c493902519265d570250c8e7ce575c8cd6f5b5/testing/web-platform/meta/input-events/input-events-get-target-ranges-deleting-in-list-items.tentative.html.ini#425-426 https://searchfox.org/mozilla-central/rev/08c493902519265d570250c8e7ce575c8cd6f5b5/testing/web-platform/meta/input-events/input-events-get-target-ranges-deleting-in-list-items.tentative.html.ini#787-788 https://wpt.fyi/results/input-events/input-events-get-target-ranges-deleting-in-list-items.tentative.html%3FDelete,ol?run_id=5734231113203712&run_id=6263979761467392&run_id=5750388243300352&run_id=5090688355008512 https://wpt.fyi/results/input-events/input-events-get-target-ranges-deleting-in-list-items.tentative.html%3FDelete,ul?run_id=5734231113203712&run_id=6263979761467392&run_id=5750388243300352&run_id=5090688355008512 https://wpt.fyi/results/input-events/input-events-get-target-ranges-deleting-in-list-items.tentative.html%3FBackspace,ol?run_id=5734231113203712&run_id=6263979761467392&run_id=5750388243300352&run_id=5090688355008512 https://wpt.fyi/results/input-events/input-events-get-target-ranges-deleting-in-list-items.tentative.html%3FBackspace,ul?run_id=5734231113203712&run_id=6263979761467392&run_id=5750388243300352&run_id=5090688355008512 Therefore, the new failures are expected result. Depends on D125029 Differential Revision: https://phabricator.services.mozilla.com/D125030
14625acf6197a3b2146457251c4c20f7d1487163: Bug 1672900 - part 2: Rewrite `HTMLEditor::AutoDeleteRangesHandler::ExtendRangeToIncludeInvisibleNodes()` with modern helper classes r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 11 Sep 2021 07:17:37 +0000 - rev 591680
Push 38780 by nbeleuzu@mozilla.com at Sat, 11 Sep 2021 21:22:43 +0000
Bug 1672900 - part 2: Rewrite `HTMLEditor::AutoDeleteRangesHandler::ExtendRangeToIncludeInvisibleNodes()` with modern helper classes r=m_kato And this renames the method to `ExtendOrShrinkRangeToDelete` for alining to new behavior changed by the following patch. Depends on D125028 Differential Revision: https://phabricator.services.mozilla.com/D125029
e88bc0e4b9d4c2f3fa5df2bb04253183b85ce561: Bug 1672900 - part 1: Add some edge cases into input-events-get-target-ranges-deleting-in-list-items.tentative.html r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 11 Sep 2021 07:17:36 +0000 - rev 591679
Push 38780 by nbeleuzu@mozilla.com at Sat, 11 Sep 2021 21:22:43 +0000
Bug 1672900 - part 1: Add some edge cases into input-events-get-target-ranges-deleting-in-list-items.tentative.html r=m_kato Some `contenteditable="false"` inclusing cases do not pass on Blink too, though. Differential Revision: https://phabricator.services.mozilla.com/D125028
9cbf4fe3f852cede86354eb884cd33d305026b17: Bug 1716291 - stop migrating xulstore/kvstore from LMDB- to safe mode backing stores; r=jstutte
Myk Melez <myk@mykzilla.org> - Sat, 11 Sep 2021 06:54:06 +0000 - rev 591678
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1716291 - stop migrating xulstore/kvstore from LMDB- to safe mode backing stores; r=jstutte Differential Revision: https://phabricator.services.mozilla.com/D124875
2437b6208eb429c26cc269a8eb1c68e43c3e3b21: Bug 1729587 - Tweaks to the Firefox Suggest preferences UI. r=mak,preferences-reviewers,jaws,fluent-reviewers
Drew Willcoxon <adw@mozilla.com> - Sat, 11 Sep 2021 02:27:38 +0000 - rev 591677
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1729587 - Tweaks to the Firefox Suggest preferences UI. r=mak,preferences-reviewers,jaws,fluent-reviewers Per spec, the informational description about data collection under the main Firefox Suggest checkbox should be hidden except for the "online" scenario, since only the online scenario sends data to Mozilla. We're also changing the two checkbox labels and adding another description under the sponsored checkbox. Depends on D125024 Differential Revision: https://phabricator.services.mozilla.com/D125031
04a89fcd740094b3cfcf8bad71c3195fd730a663: Bug 1729776 - Enable the Firefox Suggest "offline" scenario by default for users in the US region with en-* locales. r=mythmon,daleharvey,mak
Drew Willcoxon <adw@mozilla.com> - Sat, 11 Sep 2021 02:27:38 +0000 - rev 591676
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1729776 - Enable the Firefox Suggest "offline" scenario by default for users in the US region with en-* locales. r=mythmon,daleharvey,mak Enable the Firefox Suggest "offline" scenario by default for users in the US region with en-* locales. Previously we relied on Nimbus to enable the offline scenario, and the goal here is to make it permanent for all users in the US `home` region using en-* locales so that we don't need Nimbus for it anymore. With Nimbus, there were two essential mechanisms that restricted the scenario to the desired population: the `browser.urlbar.quicksuggest.enabled` pref, which is a global toggle for Firefox Suggest suggestions regardless of region and locale, and a Nimbus recipe that enabled the pref for US en-* users only. Without Nimbus, we have only the `browser.urlbar.quicksuggest.enabled` pref. We can't rely on a server-side solution to target a specific population, so we need to do it in the client. This patch keeps the default `false` value of `browser.urlbar.quicksuggest.enabled` in firefox.js, and then it sets a new default-branch value for the pref for the US en-* population on app startup. There's actually a set of prefs related to the offline scenario that need to be set, not only `browser.urlbar.quicksuggest.enabled`. Depends on D124943 Differential Revision: https://phabricator.services.mozilla.com/D125024
aa1e0da893034d02fbcee39cc63428a238982b9f: Bug 1688888: decrease ui.*.radius.topmm on Android. r=botond
Michael Comella <michael.l.comella@gmail.com> - Sat, 11 Sep 2021 02:14:57 +0000 - rev 591675
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1688888: decrease ui.*.radius.topmm on Android. r=botond On one website, the touch input fluffing made an audio scrubber so large that it covered other playback controls, making them inaccessible. This patch addresses this problem by changing the top fluffing radius so it more closely matches the bottom radius. In our investigation, we found the top radius was added asymmetrically to the bottom radius without an explanation. We speculate the bottom bias was added because when you touch the screen, you tend to aim with the top part of your finger, near your fingernail, and sometimes the bottom part of your finger will also touch the screen, fat fingering it: if true, we would fluff the event less below the touch point (which is what the code was). I vaguely remember this fat fingering problem in the early 2010's but I haven't thought about it in recent years and I didn't notice this problem in my testing for this patch – perhaps device touch handling has just gotten better. Therefore, we feel safe to remove the bias. Differential Revision: https://phabricator.services.mozilla.com/D124267
96b6c532cb1f39b3669a3627b019627eb63c2c7c: Bug 1730282 - Cleanup IPC WebGL code. r=gfx-reviewers,lsalzman
Jeff Gilbert <jgilbert@mozilla.com> - Sat, 11 Sep 2021 02:11:11 +0000 - rev 591674
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1730282 - Cleanup IPC WebGL code. r=gfx-reviewers,lsalzman * Replace QueueStatus with bool * Remove unused structs and code * Add some MOZ_LIKELY to (de)serialization branches Differential Revision: https://phabricator.services.mozilla.com/D125295
2443547c9fa2a49c86ea5d8e7930d1389a388b7b: Backed out 2 changesets (bug 1728187) for causing reftest failures on backplate-select-001.html. CLOSED TREE
Iulian Moraru <imoraru@mozilla.com> - Sat, 11 Sep 2021 04:08:21 +0300 - rev 591673
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Backed out 2 changesets (bug 1728187) for causing reftest failures on backplate-select-001.html. CLOSED TREE Backed out changeset 3a8197599a5c (bug 1728187) Backed out changeset d26328903485 (bug 1728187)
e61d7417c053ae14b36b80b9ffc344368a456fda: Backed out changeset 282b96702ce9 (bug 1687682) for causing multiple mochitest failures.
Iulian Moraru <imoraru@mozilla.com> - Sat, 11 Sep 2021 04:07:28 +0300 - rev 591672
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Backed out changeset 282b96702ce9 (bug 1687682) for causing multiple mochitest failures.
9cae8bc3809324e77b46019aab0fc3b235a0e9e9: Bug 1730123 - Fix anonymous name handling in presence of stylesheet sharing. r=firefox-style-system-reviewers,boris
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 11 Sep 2021 00:04:18 +0000 - rev 591671
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1730123 - Fix anonymous name handling in presence of stylesheet sharing. r=firefox-style-system-reviewers,boris We need to compute the anonymous name on the fly while building the CascadeData, otherwise we may see the same layer rule in two places due to stylehseet sharing and make them incorrectly share a name. Differential Revision: https://phabricator.services.mozilla.com/D125175
c978efe3f3956df60ea923ce0a1e59235f01c66b: Bug 1730287. Fix startup.first_run_is_from_dmg telemetry to report first-run-not-from-dmg stats. r=mstange
Jonathan Watt <jwatt@jwatt.org> - Fri, 10 Sep 2021 23:42:06 +0000 - rev 591670
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1730287. Fix startup.first_run_is_from_dmg telemetry to report first-run-not-from-dmg stats. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D125301
a5bf87dffba3cc8c42a76ca72ad913f80478d23b: Bug 1729847 - Fixing Pocket panel auto closing on enter r=mconley
Scott <scott.downe@gmail.com> - Fri, 10 Sep 2021 23:38:34 +0000 - rev 591669
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1729847 - Fixing Pocket panel auto closing on enter r=mconley Differential Revision: https://phabricator.services.mozilla.com/D125278
4552079b15e3af1465aae32dbd88087ff3e2981f: Bug 1730134 - Add some parsing and serialization tests for @layer. r=boris
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 10 Sep 2021 23:16:02 +0000 - rev 591668
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1730134 - Add some parsing and serialization tests for @layer. r=boris This uncovers some serialization bugs, and some missing null-checks given the statement layer doesn't have a rule list. Differential Revision: https://phabricator.services.mozilla.com/D125176
3a8197599a5c1392b883940ac6662e5780dc3d76: Bug 1728187 - Make the non-native theme not use standins for system colors if forcing colors. r=morgan
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 10 Sep 2021 23:10:52 +0000 - rev 591667
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1728187 - Make the non-native theme not use standins for system colors if forcing colors. r=morgan We allow using system colors when forcing colors so it makes sense to do this. Differential Revision: https://phabricator.services.mozilla.com/D125271
d26328903485d5ee923d37598eba2ae22da772f8: Bug 1728187 - Make prefers-contrast match when forcing colors. r=morgan
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 10 Sep 2021 23:10:51 +0000 - rev 591666
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1728187 - Make prefers-contrast match when forcing colors. r=morgan This seems to match the expectation of ~all our stylesheets, which have nice things for HCM / forced-colors which only happen when actually using OS HCM. Differential Revision: https://phabricator.services.mozilla.com/D125269
282b96702ce97216a4bd5a50dfcec5d7db91fcd2: Bug 1687682 - Make autofill use a semi-transparent background-image rather than filter. r=mstange,tgiles
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 10 Sep 2021 22:44:44 +0000 - rev 591665
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1687682 - Make autofill use a semi-transparent background-image rather than filter. r=mstange,tgiles With the non-native theme we don't need filter for this to affect "native" inputs, we can just implement the logic in nsNativeBasicTheme instead. A bit unfortunate that we need that special-case, but it seems better than using filter, which can break websites due to it creating an stacking context. I _think_ there are tests that I need to adjust for this change, but if not I'll write some. Keep the current behavior behind a pref just in case. Differential Revision: https://phabricator.services.mozilla.com/D125232
49bf466c3f24a48410e81d4e8ba29c9fd39ed96b: Bug 1725828 - Preload dependencies for the Widevine CDM when sandboxing it on Linux. r=bryce
Jed Davis <jld@mozilla.com> - Fri, 10 Sep 2021 22:11:19 +0000 - rev 591664
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1725828 - Preload dependencies for the Widevine CDM when sandboxing it on Linux. r=bryce Differential Revision: https://phabricator.services.mozilla.com/D123542
792f25f1405d53a0a3e707a850e67c8714989327: Bug 1730265: Add includes to SandboxTestingChild.cpp and SandboxTestingParent.cpp to fix build errors with --disable-unified-build. r=handyman
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 10 Sep 2021 22:07:52 +0000 - rev 591663
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1730265: Add includes to SandboxTestingChild.cpp and SandboxTestingParent.cpp to fix build errors with --disable-unified-build. r=handyman These includes provide some types and functionality that these files need. In the default build environment, there's no issue because they pick up these includes via piggybacking on neighboring files that they're unified with; but in a non-unified build, the files need to directly have these includes, to avoid build errors. See https://bugzilla.mozilla.org/show_bug.cgi?id=1730265#c0 for the specific build errors being addressed here. Differential Revision: https://phabricator.services.mozilla.com/D125285
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip