fa9e8fe352a17e023f4dd0f272bda98967763882: Bug 1115812 patch 11 - Move the beginning part of the rebuild-all process to StartRebuildAllStyleData. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:12 -0800 - rev 223696
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1115812 patch 11 - Move the beginning part of the rebuild-all process to StartRebuildAllStyleData. r=heycam Here we call StartRebuildAllStyleData from BeginProcessingRestyles (much like patch 9 and EndProcessingRestyles). But we will later also call it from the code that handles a root element font size change when we have 'rem' units. That's because it's fine to *start* the rebuild process in the middle of processing the queue of pending restyles. (We have to end after the whole process is done, though, in order to avoid wanting to destroy the old rule tree while we still have style contexts referencing it.) We only call StartRebuildAllStyleData in this case when we're processing our primary restyle queue (mPendingRestyles), not the animation restyles (to be removed in bug 960465) or the animation-only restyles, since a rebuild-all should be processed (in terms of animation phases, or in terms of having an animation-only update before it) like a normal restyle. (This isn't true for the 'rem' unit restyle, which could happen during any sort of update.)
ea9a26670eb9fbbf174d4ad5cee8ad808832dbd4: Bug 1115812 patch 10 - Add RestyleTracker parameter to BeginProcessingRestyles. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:12 -0800 - rev 223695
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1115812 patch 10 - Add RestyleTracker parameter to BeginProcessingRestyles. r=heycam This is needed in patch 11.
3758de260ac378e35844d00d58301f99855a544c: Bug 1115812 patch 9 - Move the end part of the rebuild-all process to RestyleManager::EndProcessingRestyles. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:12 -0800 - rev 223694
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1115812 patch 9 - Move the end part of the rebuild-all process to RestyleManager::EndProcessingRestyles. r=heycam This moves the code that finishes the rebuild-all process into EndProcessingRestyles(), which is part of the main restyling codepath. Patch 7 ensures that we'll always get to EndProcessingRestyles in this case, when we're going through the normal ProcessPendingRestyles() codepath rather than the special DoRebuildAllStyleData() codepath (which will be removed later in this patch series).
396a1fdfd686b2479c6476215d89f1d5e8c596fd: Bug 1115812 patch 8 - Call BeginProcessingRestyles and EndProcessingRestyles from DoRebuildAllStyleData. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:12 -0800 - rev 223693
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1115812 patch 8 - Call BeginProcessingRestyles and EndProcessingRestyles from DoRebuildAllStyleData. r=heycam This fixes one of the omissions in the rebuild-all codepaths (where it incorrectly differs from the regular ProcessPendingRestyles codepath). Note that the explicit FlushOverflowChangedTracker() is no longer needed because that's part of EndProcessingRestyles. (This will all get refactored more substantially in the following patches.)
716fab262b56c21a04cfb915189a2fff23e81f8c: Bug 1115812 patch 7 - Always call DoProcessRestyles if mInRebuildAllStyleData. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:12 -0800 - rev 223692
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1115812 patch 7 - Always call DoProcessRestyles if mInRebuildAllStyleData. r=heycam This is needed for patch 9 (once patch 9 is used via the ProcessPendingRestyles() codepath in patch 13); it ensures that when we use the new way of rebuilding, we don't bail out early because we think we have nothing to do.
ce19dc161a0b5a65eaa0c2c9a0659f3079900146: Bug 1115812 patch 6 - Move ProcessRestyles from RestyleTracker to RestyleManager. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:12 -0800 - rev 223691
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1115812 patch 6 - Move ProcessRestyles from RestyleTracker to RestyleManager. r=heycam This is needed for the following patch, so that it can access a member variable of RestyleManager.
722bcd3bcbbc3b3ede754045441ac4d3d4f64789: Bug 1115812 patch 5 - Store the state of whether we're currently rebuilding all style data in a member variable, to prepare for future merging of the rebuild into other code. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:12 -0800 - rev 223690
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1115812 patch 5 - Store the state of whether we're currently rebuilding all style data in a member variable, to prepare for future merging of the rebuild into other code. r=heycam This adds a member variable that is currently only used within a single function, but that function will be split apart so that different parts of it can be called from different places within ProcessPendingRestyles.
5f64ba26810f9b63dcfcb5a815dd157384159393: Bug 1115812 patch 4 - Rename mRebuildAllStyleData to mDoRebuildAllStyleData. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:11 -0800 - rev 223689
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1115812 patch 4 - Rename mRebuildAllStyleData to mDoRebuildAllStyleData. r=heycam This is the variable that says we *need to* rebuild style data. Since the next patch will introduce a variable that says we're *currently* rebuilding all style data, renaming this one makes things clearer.
4d145190cf56bfd03ec2e801557852b7f91efe1c: Bug 1115812 patch 3 - Pass the hints to DoRebuildAllStyleData via the member variables, in preparation for future refactoring. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:11 -0800 - rev 223688
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1115812 patch 3 - Pass the hints to DoRebuildAllStyleData via the member variables, in preparation for future refactoring. r=heycam Part of this refactoring involves the ability to start the rebuild-all process within the processing of restyles. This means we can't pass parameters directly from RebuildAllStyleData into DoRebuildAllStyleData. So this continues storing the hints as member variables a little bit deeper into the process. (I tried to move in a different direction in this patch queue, and store these hints in mPendingRestyles, for the root element. But that broke layout/style/test/test_counter_style.html and layout/style/test/test_font_loading_api.html, and I didn't want to figure out why. It would be somewhat better in the long run, since currently these hints will get processed if we do a rebuild-all on a RestyleTracker other than mPendingRestyles, which can happen if we have 'rem' units and have a root element font size change in the animation-only update or in mPendingAnimationRestyles.)
8927072cd0fb0216ce2205c8652c217c0af91eef: Bug 1115812 patch 2 - Move the eRestyle_ChangeAnimationPhaseDescendants hint in DoRebuildAllStyleData so that the new rebuild-all codepaths will keep it. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:11 -0800 - rev 223687
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1115812 patch 2 - Move the eRestyle_ChangeAnimationPhaseDescendants hint in DoRebuildAllStyleData so that the new rebuild-all codepaths will keep it. r=heycam The patches in this series refactor the process of rebuilding all style data (RestyleManager::RebuildAllStyleData and RestyleManager::DoRebuildAllStyleData) so that the process of rebuilding all style data uses the existing restyle processing loops in ProcessPendingRestyles. (Rebuilding all style data is what we do when we need to throw away the rule tree because something has invalidated the cached data in it.) This removes (increasing, especially with bug 960465 coming) code duplicated between the two codepaths, fixes some omissions from the separate rebuild-all codepath, and (more immediately) allows fixing lifetime issues of ReframingStyleContexts objects in bug 1110277 so that we can have a single ReframingStyleContexts for all of the restyle processing in each restyle processing operation. In other words, the goal is to change the rebuild-all process from a separate codepath to a few variables that modify the way ProcessPendingRestyles works (and make it do the extra work). This is just a small first step in that process, which moves one piece of code from a chunk of duplicated and to-be-removed code into a chunk of code that will be preserved.
8b5e114c159c7d148603bd790883f3dce106e65c: Bug 1115812 patch 1 - Remove obsolete comment that was fixed by bug 1047928. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:11 -0800 - rev 223686
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1115812 patch 1 - Remove obsolete comment that was fixed by bug 1047928. r=heycam
7d3ef4f3fa8fc5509203c0290fa7941bdbaad07b: Bug 908987 - Honor mIsActive more aggressively to avoid calling IsVisibleConsideringAncestors. r=roc
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:11 -0800 - rev 223685
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 908987 - Honor mIsActive more aggressively to avoid calling IsVisibleConsideringAncestors. r=roc This means that we avoid an O(N^2) calling pattern of IsVisible when we call IsVisible for all tabs of a tabbrowser, since in a tabbrowser (which uses an nsDeckFrame), IsVisibleConsideringAncestors is O(N) in number of earlier tabs.
2896167fae141cf518577a9d9e1d18161cd2bf72: Bug 1116056 - Change MOZ_ASSERT() to NS_WARNING() in Box::Read(); r=jya
Anthony Jones <ajones@mozilla.com> - Wed, 14 Jan 2015 16:57:14 +1300 - rev 223684
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1116056 - Change MOZ_ASSERT() to NS_WARNING() in Box::Read(); r=jya
0c9c9c240b070bfbbc953d2d5584b3f04f0ae052: Bug 1121065 - Ensure Software Vsync TimeStamp is never in the future. r=kats
Mason Chang <mchang@mozilla.com> - Tue, 13 Jan 2015 19:30:29 -0800 - rev 223683
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1121065 - Ensure Software Vsync TimeStamp is never in the future. r=kats
f867a45b806867e036c57c4054464a54fb6a6a62: Bug 1120257 (part 2) - Remove some duplicated inline string methods. r=jandem.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 13 Jan 2015 14:25:37 -0800 - rev 223682
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1120257 (part 2) - Remove some duplicated inline string methods. r=jandem. Some of the inline string methods have a templated and a non-templated version, e.g. lengthFits() and init(). Others don't, e.g. NewInlineString(). Having both seems unnecessary, so this patch removes the non-templated versions.
270cd86a7e4cdad49099407bd24f276221bfb0df: Bug 1120257 (part 1) - Clarify inline string naming by adding JSThinInline. r=jandem.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 13 Jan 2015 14:25:36 -0800 - rev 223681
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1120257 (part 1) - Clarify inline string naming by adding JSThinInline. r=jandem. This patch introduces a new sub-class of JSInlineString called JSThinInlineString, and moves the operations specific to thin inline strings into it. JSInlineString now clearly subsumes both of JS{Thin,Fat}InlineString, and "inling string" now clearly subsumes both of "thin inline string" and "fat inline string". Despite adding yet another JSString subclass, I think it makes things clearer :) The patch also renames a bunch of things accordingly, and removes the dead resetLength() declaration.
e3b9dcef0c711050db12338fa848fea859e5221a: Bug 1120630 - Skip tests failing with e10s enabled.;r=jgriffin
Chris Manchester <cmanchester@mozilla.com> - Tue, 13 Jan 2015 21:27:26 -0500 - rev 223680
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1120630 - Skip tests failing with e10s enabled.;r=jgriffin
340b2907b368f195d5bbfc3a081e4cfe9eb9959a: Bug 1120630 - Add --e10s to turn on electrolysis for marionette tests.;r=jgriffin
Chris Manchester <cmanchester@mozilla.com> - Tue, 13 Jan 2015 21:27:25 -0500 - rev 223679
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1120630 - Add --e10s to turn on electrolysis for marionette tests.;r=jgriffin
906a97d224d6ec663c39e8e7192647f5dd80e732: Merge m-c to inbound a=merge
Wes Kocher <wkocher@mozilla.com> - Tue, 13 Jan 2015 17:45:46 -0800 - rev 223678
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Merge m-c to inbound a=merge
111218ebc70b2ff3170d16ff40ce6153c6c64115: Bug 1116187 - Add in-tree config for B2G mochitest-chrome, r=gbrown
Jonathan Griffin <jgriffin@mozilla.com> - Tue, 13 Jan 2015 16:31:41 -0800 - rev 223677
Push 28101 by cbook@mozilla.com at Wed, 14 Jan 2015 13:18:38 +0000
Bug 1116187 - Add in-tree config for B2G mochitest-chrome, r=gbrown
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip