f950a2310e26ec1f9e91423e9e0041b6d512213c: Bug 1340498 - Update onVisits tests to use 'page-visited' r=mak
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:17:41 -0800 - rev 423774
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1340498 - Update onVisits tests to use 'page-visited' r=mak MozReview-Commit-ID: FxC3gcUF9hl
5fcd31c65fe0f854b3a82e15c9becfa21db0ac92: Bug 1340498 - Update onVisits uses to 'page-visited' r=mak
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:11:49 -0800 - rev 423773
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1340498 - Update onVisits uses to 'page-visited' r=mak Consuming the new 'page-visited' notification was fairly trivial, since it was already brought over to onVisits. There's not much to say about this other than that I'm a little bit uncertain about all the hoops we have to jump through to get a JSContext and GlobalObject from History.cpp (which is discussed in the earlier commit in the series). MozReview-Commit-ID: LHaBWSylyLI
515bb5e24dd7e135f46cc14e596cf0af5c480a1c: Bug 1340498 - Implement new Places Observers interface r=mrbkap
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:06:15 -0800 - rev 423772
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1340498 - Implement new Places Observers interface r=mrbkap See the design doc[1] for further info. We would like to redesign the places observer system to be more performant and more friendly to consume. WebIDL was recommended as it simplifies creating simple dictionary payloads while allowing dynamic typing with `any`. There were some difficulties with WebIDL though, most of which revolved around allowing consumers to be weakly referenced, from both C++ and JS. The simplest solution I could come up with was to create a simple native interface for the C++ case, and a WebIDL wrapper for a JS callback in the JS case. Suggestions for simpler alternatives are very welcome though. [1] https://docs.google.com/document/d/1G45vfd6RXFXwNz7i4FV40lDCU0ao-JX_bZdgJV4tLjk/edit?usp=sharing MozReview-Commit-ID: ACnAEfa5WxO
79a8619bd3e2de41afbbe901ce3e9c0bdb79bfa9: Bug 1340498 - Add new globals to lint config r=standard8
Doug Thayer <dothayer@mozilla.com> - Mon, 29 Jan 2018 11:07:28 -0800 - rev 423771
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1340498 - Add new globals to lint config r=standard8 MozReview-Commit-ID: 360gup8cWvi
0c8c7b025aeed7de7a6303aa3ea1c07da020f450: Bug 1447116 - Require rust 1.26. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 18:05:23 +0900 - rev 423770
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1447116 - Require rust 1.26. r=froydnj We're well overdue for an upgrade of the rust compiler requirements. Now that we're building with 1.28 (albeit a beta, due to be bumped when it's released), we can bump the requirement away from 1.24 which is now old. 1.27 is too new, though, so settle for the older 1.26.
82dc9159f28d7d3c08ab2c3b6a725aa45c49edd1: Bug 1447116 - Update builders to rust 1.28. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 17:34:28 +0900 - rev 423769
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1447116 - Update builders to rust 1.28. r=froydnj
b7873993686ffeb10a68d7a7bcedae6ec9b21040: Bug 1471132 - Make building a binary component a compile-time error. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 16:18:14 +0900 - rev 423768
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1471132 - Make building a binary component a compile-time error. r=froydnj Loading binary components is not supported since bug 1314955.
32d574a02a2eb31ccee9259a210d67edaab0fb03: Bug 1471132 - Change how static xpcom components are initialized. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 16:10:30 +0900 - rev 423767
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1471132 - Change how static xpcom components are initialized. r=froydnj The sStaticModules list is, practically speaking, a copy of the list of components we already have in libxul, augmented at runtime with a few other components for tests (for gtest and xpcshell). We don't actually need to keep that copy in memory. We can instead just use the pointers in libxul directly to register them to the component manager, and use a separate list, only for those extra components when they need to be registered.
7839040f0d428201a5d9afed324b7763ed555024: Bug 1471132 - Change how static xpcom components are linked. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 14:40:51 +0900 - rev 423766
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1471132 - Change how static xpcom components are linked. r=froydnj Overall, this makes the whole setup less fragile, and make it work with LTO in more situations.
dfd0afd7b60fe420b67ebee82634915efaaf48b0: Bug 1471132 - Avoid ASAN padding between NSModules. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 14:39:49 +0900 - rev 423765
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1471132 - Avoid ASAN padding between NSModules. r=froydnj
9f4d1a4296ba62cc65296bb2770ef617925554fd: Bug 1470127 - Move binary checks to a standalone script. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Jun 2018 18:13:03 +0900 - rev 423764
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1470127 - Move binary checks to a standalone script. r=froydnj We perform, on the binaries we build, a series of check, that are implemented as half-baked make commands, invoked after linking them. - check libstdc++ symbol versions to ensure binary compatibility with a baseline. - check glibc symbol versions to ensure binary compatibility with a baseline. - check that target binaries don't contain text relocations. - check that libmozglue is linked before libc on android. - on libxul, check that NSModules are laid out correctly. - on libxul, check that there is more than one PT_LOAD segment. Those checks happen to work where they matter, but their setup is unreliable. For example, the checks for symbol versions are supposed to work for libclang-plugin on cross osx builds, but in fact, don't, because the readelf path doesn't exist, and the command doesn't fail in that case. So move them all to a standalone script, performing the checks more thoroughly (especially the NSModules one, where we now also check that they are all adjacent), and more verbosely.
52125f300616f9995a712aedae7dfbc6185f7e75: Bug 1471215 - Remove now unnecessary classInfo definition in PlacesTreeView. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 26 Jun 2018 20:45:41 +0000 - rev 423763
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1471215 - Remove now unnecessary classInfo definition in PlacesTreeView. r=mak MozReview-Commit-ID: 2BJGohgrA2l Differential Revision: https://phabricator.services.mozilla.com/D1828
b1342f2deeec2ae5ce47ded5f5de9237412312de: Bug 733530: Support tar.gz test archives for artifact builds r=gps
Chris AtLee <catlee@mozilla.com> - Tue, 26 Jun 2018 20:30:24 +0000 - rev 423762
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 733530: Support tar.gz test archives for artifact builds r=gps Differential Revision: https://phabricator.services.mozilla.com/D1841
23fb443b22143c059267eb254ddd4b2e9fcc4e41: Bug 1471177 - Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++. r=froydnj
Jacek Caban <jacek@codeweavers.com> - Tue, 26 Jun 2018 13:06:17 +0200 - rev 423761
Push 34192 by dluca@mozilla.com at Wed, 27 Jun 2018 10:24:39 +0000
Bug 1471177 - Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++. r=froydnj MozReview-Commit-ID: 6aKGtK7B74z
1c235a552c32ba6c97e6030c497c49f72c7d48a8: Bug 1454378 - chunk blocklist processing so it doesn't hang the main thread continuously, r=florian
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 13 Jun 2018 17:16:59 -0700 - rev 423760
Push 34191 by rgurzau@mozilla.com at Tue, 26 Jun 2018 21:53:37 +0000
Bug 1454378 - chunk blocklist processing so it doesn't hang the main thread continuously, r=florian MozReview-Commit-ID: 70cIeuVdy3D
155961fbe92c60eb0176cbb93c67cc4969d1aa79: Bug 1454378 - cache and inline things, avoid duplicate attribute or property requests, to make blocklist faster, r=florian
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 13 Jun 2018 17:06:49 -0700 - rev 423759
Push 34191 by rgurzau@mozilla.com at Tue, 26 Jun 2018 21:53:37 +0000
Bug 1454378 - cache and inline things, avoid duplicate attribute or property requests, to make blocklist faster, r=florian MozReview-Commit-ID: BwBhZr6sqx2
48f065cc3a348100793f72decc1fed3a58d47911: Bug 1454378 - make gfx blocklist processing faster, r=florian
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 13 Jun 2018 15:39:05 -0700 - rev 423758
Push 34191 by rgurzau@mozilla.com at Tue, 26 Jun 2018 21:53:37 +0000
Bug 1454378 - make gfx blocklist processing faster, r=florian MozReview-Commit-ID: A7Ydf6gUu3U
118b2b50e94a1acc2c866b8fdc00b7bb34b81d54: Bug 1454378 - switch to for...of loops and .children instead of manual .item() calls, r=florian
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 13 Jun 2018 11:53:33 -0700 - rev 423757
Push 34191 by rgurzau@mozilla.com at Tue, 26 Jun 2018 21:53:37 +0000
Bug 1454378 - switch to for...of loops and .children instead of manual .item() calls, r=florian MozReview-Commit-ID: 5nPrMVTz09m
6b8476e1423a11c5bc0e57131f930f51bee6a1c8: Bug 1454378 - remove last sync XML blocklist reading code, r=florian
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 13 Jun 2018 11:51:45 -0700 - rev 423756
Push 34191 by rgurzau@mozilla.com at Tue, 26 Jun 2018 21:53:37 +0000
Bug 1454378 - remove last sync XML blocklist reading code, r=florian MozReview-Commit-ID: 3YYVy0ubdj8
d26f85971b0a14884ea88114b89e0622ab317cee: Bug 1470587: Uninitialize reporter created during test. r=mossop
Michael Kelly <mkelly@mozilla.com> - Tue, 26 Jun 2018 18:31:06 +0000 - rev 423755
Push 34191 by rgurzau@mozilla.com at Tue, 26 Jun 2018 21:53:37 +0000
Bug 1470587: Uninitialize reporter created during test. r=mossop At some point, the matching call to reporter.uninit got removed from this test. The result is that the reporter still exists and is still collecting errors during the rest of the tasks in the file. In most tasks, this isn't an issue since we use reporter.handleMessage to test message handling at a per-reporter level. But the telemetry measures are shared between multiple reporters, thus they are susceptible to interference from other running reporter instances. The error that is being logged when this test fails is from the test add-on created in testAddonIDMangle. My best guess is that the error logged by the add-on is being processed during an idle moment in another task, since we schedule processing to be delayed until the browser is idle. It seems this scheduling is pretty consistent on certain Linux platforms. Differential Revision: https://phabricator.services.mozilla.com/D1836
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip