f832deb400b15ef2192600608f354177c12402ef: Bug 1209551 - Don't read past the end of a buffer in libmar
Matt Howell <mhowell@mozilla.com> - Tue, 06 Oct 2015 09:11:43 -0700 - rev 266938
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1209551 - Don't read past the end of a buffer in libmar The index section of a MAR archive file contains several fixed-length fields and also variable-length names for each file in the archive, terminated by a null byte. Since that makes the length of the index variable, the length of the entire index is also provided in the file. When libmar opens a file, it allocates a buffer with the length given in the file and reads the index from the file into that buffer. mar_consume_index() then parses the entire index from that copy, trying to make sure it doesn't read past the buffer it was given. The length of the buffer is given to mar_consume_index() by providing it a pointer to one byte past the end of the buffer. However, mar_consume_index() treats this pointer as pointing *to* the end. Therefore, it is possible for a malformed MAR file (one where the stated length is less than the real length) to trigger a read of one byte beyond the allocated memory. Fix this by failing the parse when we reach the buffer end pointer minus one, instead of when we reach that address itself.
ba28fd929617d3673936f8a31ef40e3e6017f3c8: Bug 1194692 - fix some cookie parsing issues in the IE/Edge cookie importer code, r=MattN
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 28 Sep 2015 22:30:20 +0100 - rev 266937
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1194692 - fix some cookie parsing issues in the IE/Edge cookie importer code, r=MattN
eb5a0b994ea9b98962b91b5116b07d7ce5c2dcf0: Bug 1212297 - improve error handling in Chrome bookmarks migration code, r=MattN
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 07 Oct 2015 13:24:50 +0100 - rev 266936
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1212297 - improve error handling in Chrome bookmarks migration code, r=MattN
65738b3a3f9df0d07970687e5646a6a62f3327db: Merge m-c to fx-team, a=merge
Wes Kocher <wkocher@mozilla.com> - Thu, 08 Oct 2015 14:36:57 -0700 - rev 266935
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Merge m-c to fx-team, a=merge
4a9f3479467877818de59a00b6e43856fdfc5c14: Bug 1212787 - Revert Loop's conversation toolbar button sizes due to bug 1209632 causing a visual regression. r=dmose
Mark Banner <standard8@mozilla.com> - Thu, 08 Oct 2015 21:25:19 +0100 - rev 266934
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1212787 - Revert Loop's conversation toolbar button sizes due to bug 1209632 causing a visual regression. r=dmose
e5dd1d0bae2cad5d19571f779c1a97875e6eaee7: Follow-up to bug 1212272 - use the correct cp command. r=dmose
Mark Banner <standard8@mozilla.com> - Thu, 08 Oct 2015 21:25:19 +0100 - rev 266933
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Follow-up to bug 1212272 - use the correct cp command. r=dmose
e63ba8ad3c02cd6d28e3f8f260b110f5da40929a: Bug 1212153 - Clean up Cu.isModuleLoaded after migration. r=bgrins
J. Ryan Stinnett <jryans@gmail.com> - Wed, 07 Oct 2015 14:40:04 -0500 - rev 266932
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1212153 - Clean up Cu.isModuleLoaded after migration. r=bgrins
9d8432afaf64be727575053534e35bffbcc41f54: Backed out 5 changesets (bug 1173147) because bug 1201206 got backed out CLOSED TREE
Wes Kocher <wkocher@mozilla.com> - Thu, 08 Oct 2015 12:37:17 -0700 - rev 266931
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Backed out 5 changesets (bug 1173147) because bug 1201206 got backed out CLOSED TREE Backed out changeset e0db94364c19 (bug 1173147) Backed out changeset afd881fc08a2 (bug 1173147) Backed out changeset 5a4df2457628 (bug 1173147) Backed out changeset a43a907c02fe (bug 1173147) Backed out changeset 494ff0d7f3bb (bug 1173147)
1ffccf0304f33598ce82a7587c8fc4d2d60a8903: Backed out 4 changesets (bug 1201206) for android x86 bustage CLOSED TREE
Wes Kocher <wkocher@mozilla.com> - Thu, 08 Oct 2015 12:36:15 -0700 - rev 266930
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Backed out 4 changesets (bug 1201206) for android x86 bustage CLOSED TREE Backed out changeset c01f712e3d98 (bug 1201206) Backed out changeset 2d7962287928 (bug 1201206) Backed out changeset bfc7e7f997eb (bug 1201206) Backed out changeset ebc006342c9e (bug 1201206)
e2b9c2dc31cd832749c6cf86953e0754379e568c: Bug 1212059: Don't require shipped system add-ons to be signed, always require updated system add-ons to be signed. r=rhelmer
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 07 Oct 2015 10:29:18 -0700 - rev 266929
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1212059: Don't require shipped system add-ons to be signed, always require updated system add-ons to be signed. r=rhelmer
b830ba785dfe4c6bdf7ee6fb2a83f19497163fe2: Bug 1210956 - Clean up missed theme references after migration. r=bgrins
J. Ryan Stinnett <jryans@gmail.com> - Wed, 07 Oct 2015 14:18:42 -0500 - rev 266928
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1210956 - Clean up missed theme references after migration. r=bgrins
e0db94364c19e09a6bb8ac8a8b2c3ca49c97e0c0: Bug 1173147 - Explicitly show Android chooser when there is more than one intent URI match in pb. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Wed, 23 Sep 2015 14:48:28 -0700 - rev 266927
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1173147 - Explicitly show Android chooser when there is more than one intent URI match in pb. r=sebastian After this changeset series, the expected flow for web links is: * If not pb, open the Intent URI * If pb and no matching applications, open about:neterror * If pb and one matching application, show this dialog * If pb and > 1 matching application, show the Android system chooser When the user explicitly chooses to share (and thus should infer they're exiting Private Browsing), we don't show the dialog. Custom URIs sort of work: I tested `mailto` and it worked as expected but `tel` does not work as expected (i.e. it doesn't show the dialog). Perhaps there's an explicit "Open dialer" code path. To figure this out, I tested this patch against my Intent URI test page [1]. Decisions around explicitly showing the Android chooser: When there are multiple application matches to an Intent URI, we want to show the Android Intent Chooser. However, we have no way of distinguishing regular tabs from private tabs to the chooser. Thus, if a user chooses "Always" in regular browsing mode, the chooser will not be shown and the URL will be opened. Therefore we explicitly show the chooser (which notably does not have an "Always" option). [1]: https://people.mozilla.org/~mcomella/test/uri.html
afd881fc08a25c38a57343434ba58becb836ffa0: Bug 1173147 - Show prompt for GeckoAppShell.openUriExternal. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Fri, 18 Sep 2015 17:21:07 -0700 - rev 266926
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1173147 - Show prompt for GeckoAppShell.openUriExternal. r=sebastian
5a4df2457628c2fc41385dcca653e05eb8f5caa1: Bug 1173147 - Prompt user when opening market intent. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Thu, 17 Sep 2015 18:42:07 -0700 - rev 266925
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1173147 - Prompt user when opening market intent. r=sebastian
a43a907c02fe32724322bf907e4ff4136e364ea4: Bug 1173147 - Add DialogFragment to prompt user when clicking Intent link in private browsing. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Thu, 17 Sep 2015 18:41:53 -0700 - rev 266924
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1173147 - Add DialogFragment to prompt user when clicking Intent link in private browsing. r=sebastian Note that the DialogFragment is currently unused and will be used in the followup changesets.
494ff0d7f3bbd4573372864b9f2c70c6cf8d22e8: Bug 1173147 - Add Intent in private browsing prompt string. r=sebastian
Michael Comella <michael.l.comella@gmail.com> - Wed, 16 Sep 2015 15:57:48 -0700 - rev 266923
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1173147 - Add Intent in private browsing prompt string. r=sebastian
c01f712e3d98c74a03f1dcf9c5133c0c8982d32d: Bug 1201206 - Correct menu button background on 2.3. r=mhaigh
Michael Comella <michael.l.comella@gmail.com> - Tue, 15 Sep 2015 16:46:58 -0700 - rev 266922
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1201206 - Correct menu button background on 2.3. r=mhaigh One fear is that different devices set different menu colors and text colors. Since we're using the default text color and set an explicit menu color, the text color may not look good on these devices. I was unable to find a way to override the menu text color. It seems the best way to find out if this is a problem is to land it and test though!
2d7962287928829803e68fe5cd1aeabd69003837: Bug 1201206 - Inherit from appCompat on v21 prefs and restore action bar style. r=mhaigh
Michael Comella <michael.l.comella@gmail.com> - Tue, 15 Sep 2015 15:07:05 -0700 - rev 266921
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1201206 - Inherit from appCompat on v21 prefs and restore action bar style. r=mhaigh
bfc7e7f997eb2a4f5bbfea4e817aa4e738900d5b: Bug 1201206 - Inherit from version specific styles for prefs. r=mhaigh
Michael Comella <michael.l.comella@gmail.com> - Tue, 22 Sep 2015 16:26:29 -0700 - rev 266920
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1201206 - Inherit from version specific styles for prefs. r=mhaigh This excludes Material design in v21+, which will be overridden with AppCompat in the following changeset.
ebc006342c9e0654a2900e952299341251f01ad7: Bug 1201206 - Inherit from Theme.AppCompat style at all API levels. r=mhaigh
Michael Comella <michael.l.comella@gmail.com> - Tue, 15 Sep 2015 14:33:45 -0700 - rev 266919
Push 29503 by cbook@mozilla.com at Fri, 09 Oct 2015 09:36:47 +0000
Bug 1201206 - Inherit from Theme.AppCompat style at all API levels. r=mhaigh
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip