f63a19d7effa285d05013488a3ed32bd3e71be81: Bug 1634819 - Existence check element.parentElement and element.previousElementSibling in new password heuristics; r=MattN
Bianca Danforth <bdanforth@mozilla.com> - Thu, 07 May 2020 23:12:47 +0000 - rev 528714
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1634819 - Existence check element.parentElement and element.previousElementSibling in new password heuristics; r=MattN The element.parentNode.nodeName approach also handled the error, but when I ran the updated model through the training, validation and testing samples, our false positive rate (FPR) went up from 2.2% to 4.5% (referencing the most recent update to NewPasswordModel.jsm in bug 1629132) with a confidence threshold of 0.75. Unfortunately, that is well above our target FPR of 2-3%. * I am not surprised by this difference: the diff I had tested with `parentNode.nodeName` replaced `parentElement` with `parentNode` and `tagName` with `nodeName` everywhere in this rule. Since `Node.ELEMENT_NODE` is only one of [several other `Node.nodeType`](https://developer.mozilla.org/en-US/docs/Web/API/Node/nodeType)'s, I can imagine that for some of the sites in the corpus, `element.parentElement` was not the same node as `element.parentNode`. Therefore the downstream return value could also be different; i.e. the modified rule may then return `false` instead of `true` or vice versa for some or all of these affected pages, and the model would consequently reach a different (and potentially worse) optimization. Returning `false` for this rule in these cases will leave the model's performance unchanged on pages that don't use the Shadow DOM at all or in this specific way. Also add some existence checks further downstream in the same rule where the values could also be `null`. Differential Revision: https://phabricator.services.mozilla.com/D74164
65fc0df9b6fa24e16b29620a67b15ebeddbec508: Bug 1636304. Fix and improve the Mermaid documentation. r=sylvestre
Jonathan Watt <jwatt@jwatt.org> - Thu, 07 May 2020 23:16:00 +0000 - rev 528713
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1636304. Fix and improve the Mermaid documentation. r=sylvestre The second example, when copied and pasted, is completely borked since it is not preceeded by the line that declares what follows to be a Mermaid diagram. This change fixes that. It also fixes the prose to read slightly less awkwardly in places. Finally, this change also adds a link to the Mermaid Live Editor to make readers aware of this useful tool. Differential Revision: https://phabricator.services.mozilla.com/D74338
5719d49dccd6902630224f8c0dfec131fa849616: Bug 1636142 - Make DOM Arena is only enabled in early beta r=smaug
sefeng <sefeng@mozilla.com> - Thu, 07 May 2020 23:14:42 +0000 - rev 528712
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1636142 - Make DOM Arena is only enabled in early beta r=smaug Differential Revision: https://phabricator.services.mozilla.com/D74245
d543b6ceacd49b099d4b80014e59592109a979da: Bug 1636012 - Remove TYPES_OF_USER_CLICKS probe r=smaug
sefeng <sefeng@mozilla.com> - Thu, 07 May 2020 22:12:52 +0000 - rev 528711
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1636012 - Remove TYPES_OF_USER_CLICKS probe r=smaug Differential Revision: https://phabricator.services.mozilla.com/D74250
8acd05d1233734b4e42339ed4dddcf3f989e7883: Bug 1636285: Add a descriptive message to EnsureJNIObject; r=geckoview-reviewers,droeh
Aaron Klotz <aklotz@mozilla.com> - Thu, 07 May 2020 22:18:48 +0000 - rev 528710
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1636285: Add a descriptive message to EnsureJNIObject; r=geckoview-reviewers,droeh Differential Revision: https://phabricator.services.mozilla.com/D74328
be3aa8f30db0246ecee9ba1ed146a5969e8fbd3d: Bug 1635852: Include minidump_stackwalk files in taskgraph sparse-profile; r=glandium
Tom Prince <mozilla@hocat.ca> - Thu, 07 May 2020 22:20:52 +0000 - rev 528709
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1635852: Include minidump_stackwalk files in taskgraph sparse-profile; r=glandium Without this, taskgraph calculates the digest based on just the files in these directories that are in the sparse profile (I suspect this is just the moz.build files), and will rebuild it when those files change. This changes ensures that all files in those directories are used to calculate the digest. Additionally, this will cause the same digest to be generted by developers locally, since the files *are* present in the non-sparse checkout that most developers have. Differential Revision: https://phabricator.services.mozilla.com/D74113
9c3bf20554fdb4740a2467a85663b941661746e0: Backed out 5 changesets (bug 1633820) for build bustages at TabContext.cpp. CLOSED TREE
Razvan Maries <rmaries@mozilla.com> - Fri, 08 May 2020 00:59:20 +0300 - rev 528708
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Backed out 5 changesets (bug 1633820) for build bustages at TabContext.cpp. CLOSED TREE Backed out changeset 0a20dd1935d7 (bug 1633820) Backed out changeset 626e834293ed (bug 1633820) Backed out changeset 14cc454a8cbc (bug 1633820) Backed out changeset 7bbcb9266b87 (bug 1633820) Backed out changeset ef99672bd2af (bug 1633820)
3321fb5c6334aca53775c97991b5b772db6316e4: Bug 1635922: Add bug link to ini file. r=jib
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 07 May 2020 19:28:59 +0000 - rev 528707
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1635922: Add bug link to ini file. r=jib Differential Revision: https://phabricator.services.mozilla.com/D74247
e614cbba042d330c5e615634923b7f4403a675da: Bug 1636227 - Don't reset _sameProcessAsFrameLoader on first browser initialization. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 May 2020 21:52:24 +0000 - rev 528706
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1636227 - Don't reset _sameProcessAsFrameLoader on first browser initialization. r=Gijs LazyFC changes the way we initialize browsers in a subtle way which is important for print preview and PiP. When creating a print preview browser / PiP, we rely on getting the right process via _sameProcessAsFrameLoader. This is set very early on the lifetime of the browser element, after it's upgraded but before its connectedCallback() calls. What happens with LazyFC is that we append the browser to the document, then set its sameProcessAsFrameLoader, then initialize the browser from connectedCallback(). That calls resetFields() _after_ setting the _sameProcessAsFrameLoader, which clears it out, not good. Without LazyFC we initialize it via frame construction, as soon as the browser is attached to the document, so all ends up working out. Explicitly avoid clearing this field out if not initialized yet, instead of the hasOwnProperty check which was for the very same thing, just about XBL initialization. Differential Revision: https://phabricator.services.mozilla.com/D74282
447472273028df52058c04a3072eb22579f9b98e: Backed out 2 changesets (bug 1635584) for build bustages. CLOSED TREE
Razvan Maries <rmaries@mozilla.com> - Fri, 08 May 2020 00:47:31 +0300 - rev 528705
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Backed out 2 changesets (bug 1635584) for build bustages. CLOSED TREE Backed out changeset 059ed60f23bf (bug 1635584) Backed out changeset 876b8f443cca (bug 1635584)
9881a50bded4db9decab11b0127e79b7eb39157c: Bug 1434601 - Do screen wakelock even without audio if video element is sourced by a media stream. r=alwu
Jan-Ivar Bruaroey <jib@mozilla.com> - Thu, 07 May 2020 21:35:37 +0000 - rev 528704
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1434601 - Do screen wakelock even without audio if video element is sourced by a media stream. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D74129
c353fa62a27b965c34c7c8008a22d1d42ecaa3dc: Bug 1633740 - Add test for BigInt/I64 conversion crash on inlined Ion to Wasm calls r=lth,wingo
Asumu Takikawa <asumu@igalia.com> - Thu, 07 May 2020 21:11:37 +0000 - rev 528703
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1633740 - Add test for BigInt/I64 conversion crash on inlined Ion to Wasm calls r=lth,wingo This diff adds a test using gczeal to trigger a GC crash caused by the BigInt/I64 conversion path in inlined Ion To Wasm calls. The actual fixes for the crash are in bug 1633714. Differential Revision: https://phabricator.services.mozilla.com/D73111
1f11ec544f47a503d67a0048a736a1e77489130c: Bug 1620646 - Changes fixed for test failure. r=jorendorff
Sonia Singla <soniasingla.1812@gmail.com> - Thu, 07 May 2020 21:31:12 +0000 - rev 528702
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1620646 - Changes fixed for test failure. r=jorendorff Differential Revision: https://phabricator.services.mozilla.com/D73436
0a20dd1935d76508b35f7c875eceecb93aad8a9c: Bug 1633820 - Part 5: Get rid of UnsafeIPCTabContext, r=kmag
Nika Layzell <nika@thelayzells.com> - Thu, 07 May 2020 17:18:58 +0000 - rev 528701
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1633820 - Part 5: Get rid of UnsafeIPCTabContext, r=kmag This variant was only used for service workers' openWindow method, which has been changed to no longer behave in this way, meaning that the type can be removed. The follow-up simplification of removing 'ContentChild::ProvideWindowCommon', and moving the logic directly into 'BrowserChild' is not done in this bug, and will be done in a follow-up instead. Differential Revision: https://phabricator.services.mozilla.com/D72935
626e834293edd2b1740ff47d03e5149d25487a8d: Bug 1633820 - Part 4: Remove OriginAttributes from TabContext, r=kmag
Nika Layzell <nika@thelayzells.com> - Thu, 07 May 2020 17:18:48 +0000 - rev 528700
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1633820 - Part 4: Remove OriginAttributes from TabContext, r=kmag This information is now redundant with 'BrowsingContext', meaning that it can be omitted from the 'TabContext'. Differential Revision: https://phabricator.services.mozilla.com/D72934
14cc454a8cbc4357851113eabfb03c575eea0780: Bug 1633820 - Part 3: Get rid of PBrowserOrId, r=mattwoodrow,necko-reviewers,dragana
Nika Layzell <nika@thelayzells.com> - Thu, 07 May 2020 17:45:12 +0000 - rev 528699
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1633820 - Part 3: Get rid of PBrowserOrId, r=mattwoodrow,necko-reviewers,dragana The 'Id' variant was only used with b2g for remote `mozbrowser`s, and is no longer relevant. The new code instead uses `PBrowser` directly in all cases. Differential Revision: https://phabricator.services.mozilla.com/D72933
7bbcb9266b8715af3f9470ce2a935f0431cc2c7c: Bug 1633820 - Part 2: Avoid creating an extra LoadContext when we already have a BrowsingContext, r=mattwoodrow
Nika Layzell <nika@thelayzells.com> - Thu, 07 May 2020 17:18:44 +0000 - rev 528698
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1633820 - Part 2: Avoid creating an extra LoadContext when we already have a BrowsingContext, r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D72932
ef99672bd2af952f9af8fde7708a41e64695e1c1: Bug 1633820 - Part 1: Assert Coherent Load Context, r=mattwoodrow
Nika Layzell <nika@thelayzells.com> - Thu, 07 May 2020 17:18:42 +0000 - rev 528697
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1633820 - Part 1: Assert Coherent Load Context, r=mattwoodrow This patch asserts in various places that our LoadContext value on BrowsingContext is consistent. This is done in order to get better diagnostics for crashes such as those in bug 1629527. Differential Revision: https://phabricator.services.mozilla.com/D72931
648ab7aa47d348fa4abb277d04587a2846b46b1d: Bug 1608771 - Part 5, BigInt<>I64 conversion for inlined calls r=lth
Asumu Takikawa <asumu@igalia.com> - Thu, 07 May 2020 21:11:06 +0000 - rev 528696
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1608771 - Part 5, BigInt<>I64 conversion for inlined calls r=lth This is part 5 of implementing the Wasm BigInt<>I64 conversion proposal for inlined Ion to Wasm calls. This part adds additional Wasm BigInt tests that are aimed specifically to test limits of the inlined calls and to test more conversion cases that should be covered (e.g., to test ToBigInt instruction cases). Differential Revision: https://phabricator.services.mozilla.com/D65238
f036cb46d18f81e51ed3e7584d2a4eb5b2449447: Bug 1608771 - Part 4, BigInt<>I64 conversion for inlined calls r=lth,wingo
Asumu Takikawa <asumu@igalia.com> - Thu, 07 May 2020 21:10:56 +0000 - rev 528695
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1608771 - Part 4, BigInt<>I64 conversion for inlined calls r=lth,wingo This is part 4 of implementing the Wasm BigInt<>I64 conversion proposal for inlined Ion to Wasm calls. This part adds the support for I64/BigInt arguments for inlined calls in the MCallOptimize.cpp part of the IonBuilder. With this commit, the I64 arguments will work on 64-bit platforms, except where arguments are required to be spilled to the stack due to the ABI (this case is more complicated to support). On 32-bit platforms, this commit disables the BigInt/I64 support for the inlined call as it does not work without further changes. Differential Revision: https://phabricator.services.mozilla.com/D65237
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip