f39008382451ae45616ff3263421c2affc716cbc: Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:25:07 +0000 - rev 456513
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17886
a0b9977daa361c63bae40a7caf6dbfd2130558fa: Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:24:45 +0000 - rev 456512
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv I am not a huge fan of the UnwrapReflectorToISupports setup here. Maybe we should introduce two differently-named methods that make it somewhat clear what the limitations of not taking a JSContext are? I couldn't think of sane naming... Differential Revision: https://phabricator.services.mozilla.com/D17885
f41215bdded6614b78f6b371a23f842a07c20bfa: Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:24:22 +0000 - rev 456511
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17884
64af12d24e9defd3823252921ea0d51cbf2bfef1: Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:23:49 +0000 - rev 456510
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv The basic idea for the changes around UnwrapObjectInternal and its callers (UnwrapObject, UNWRAP_OBJECT, etc) is to add a parameter to the guts of the object-unwrapping code in bindings which can be either a JSContext* or nullptr (statically typed). Then we test which type it is and do either a CheckedUnwrapDynamic or CheckedUnwrapStatic. Since the type is known at compile time, there is no actual runtime check; the compiler just emits a call to the right thing directly (verified by examining the assembly output on Linux). The rest of the changes are mostly propagating through that template parameter, adding static asserts to make sure people don't accidentally pass nullptr while trying to unwrap to a type that might be a WindowProxy or Location, etc. There are also some changes to places that were calling CheckedUnwrap directly to use either the static or dynamic version, as needed. Differential Revision: https://phabricator.services.mozilla.com/D17883
46854f5097bbe5c3ab485667753d3e368f152193: Bug 1521907 part 2. Add dynamic CheckedUnwrap support to CrossOriginObjectWrapper. r=peterv,sfink
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:23:16 +0000 - rev 456509
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 2. Add dynamic CheckedUnwrap support to CrossOriginObjectWrapper. r=peterv,sfink This will allow us to correctly handle CheckedUnwrapDynamic on wrappers around WindowProxy and Location. Differential Revision: https://phabricator.services.mozilla.com/D17882
026c691e29c66aa0c3f01c8198b331e9afc26405: Bug 1521907 part 1. Add a version of CheckedUnwrap that can do a dynamic security check. r=jandem,sfink
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:22:29 +0000 - rev 456508
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 1. Add a version of CheckedUnwrap that can do a dynamic security check. r=jandem,sfink We're going to need this because we will have multiple Realms in the same compartment which want different CheckedUnwrap behavior in some cases. So we need to be able to check which Realm we're in. Differential Revision: https://phabricator.services.mozilla.com/D17881
e53f607940cb5e1db1bb7eeb3c5c0bc6f4b0d608: Bug 1524214 - Grab caching capturing content with local variable r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Feb 2019 20:44:28 +0000 - rev 456507
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1524214 - Grab caching capturing content with local variable r=smaug Differential Revision: https://phabricator.services.mozilla.com/D18209
e2780a098404114db5aea796c87e577ce2c54f05: Backed out changeset b7597732606e (bug 1501623)for failing at browser_autocomplete_edit_completed.js on a CLOSED TREE.
Gurzau Raul <rgurzau@mozilla.com> - Sat, 02 Feb 2019 02:43:33 +0200 - rev 456506
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Backed out changeset b7597732606e (bug 1501623)for failing at browser_autocomplete_edit_completed.js on a CLOSED TREE.
43d250c96e71928eb14dbd6dde03595959b36f89: Bug 1523882 - Rework snapping logic in clip mask generate to fix uneven box shadows. r=kvark,nical
Glenn Watson <github@intuitionlibrary.com> - Fri, 01 Feb 2019 23:24:53 +0000 - rev 456505
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1523882 - Rework snapping logic in clip mask generate to fix uneven box shadows. r=kvark,nical Differential Revision: https://phabricator.services.mozilla.com/D18060
ac3ba5d1c7a53bbd205e421db2e422492aa422fb: Backed out changeset 52f541c1147e (bug 1523926) for xpcshell test crash mozilla::gfx::VR on a CLOSED TREE.
Gurzau Raul <rgurzau@mozilla.com> - Sat, 02 Feb 2019 01:47:26 +0200 - rev 456504
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Backed out changeset 52f541c1147e (bug 1523926) for xpcshell test crash mozilla::gfx::VR on a CLOSED TREE.
e3670e52a459cee02337afc70bbeb3d1dc68821b: Merge mozilla-central to autoland. a=merge CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Sat, 02 Feb 2019 01:38:27 +0200 - rev 456503
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
b828ed311a01c2977f3c78251cb231bc0f7cfbd1: bug 1514118 - have CertVerifier use any third-party roots rather than going through NSS r=jcj
Dana Keeler <dkeeler@mozilla.com> - Fri, 01 Feb 2019 22:01:00 +0000 - rev 456502
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
bug 1514118 - have CertVerifier use any third-party roots rather than going through NSS r=jcj Before this patch, if the enterprise roots feature were enabled, nsNSSComponent would gather any such roots and temporarily import them into NSS so that CertVerifier could use them during path building and trust querying. This turned out to be problematic in part because doing so would require unlocking the user's key DB if they had a password. This patch implements a scheme whereby nsNSSComponent can give these extra roots directly to CertVerifier, thus bypassing NSS and any need to unlock/modify any DBs. This should also provide a path forward for other improvements such as not repeatedly searching through all certificates on all tokens, which has inefficiencies (see e.g. bug 1478148). Differential Revision: https://phabricator.services.mozilla.com/D18156
b7597732606e96cd3337c316b5771ae09e9b8ab9: Bug 1501623 - Dispatch an input event from UrlbarInput::setValueFromResult. r=adw
Dão Gottwald <dao@mozilla.com> - Fri, 01 Feb 2019 22:54:45 +0000 - rev 456501
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1501623 - Dispatch an input event from UrlbarInput::setValueFromResult. r=adw Differential Revision: https://phabricator.services.mozilla.com/D18351
7213808d10e0e5f417d21ccf938d0ba3e614c9ed: Bug 1524129 - don't allow accidentally passing actors via the wrong managing actor in IPDL messages; r=nika
Alex Gaynor <agaynor@mozilla.com> - Fri, 01 Feb 2019 22:06:59 +0000 - rev 456500
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1524129 - don't allow accidentally passing actors via the wrong managing actor in IPDL messages; r=nika Differential Revision: https://phabricator.services.mozilla.com/D18263
432ae563202be639d203852c53f7457ab08e7fac: Bug 1523285 - Don't clip outlines of a button input and such. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 Feb 2019 22:15:34 +0000 - rev 456499
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1523285 - Don't clip outlines of a button input and such. r=bzbarsky Sorry, should've seen this :( Differential Revision: https://phabricator.services.mozilla.com/D17834
d1b835c9d5ce607ec63c4fc2a39eebbddb01f487: Bug 1523812 - Handle changing the selection when there isn't already a selection. r=adw
Dão Gottwald <dao@mozilla.com> - Fri, 01 Feb 2019 22:34:43 +0000 - rev 456498
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1523812 - Handle changing the selection when there isn't already a selection. r=adw Differential Revision: https://phabricator.services.mozilla.com/D18337
d39849743a9c25ac34a1ad76874f33b5b09b1c96: Bug 1521604 Part 3: Add a test of parentFlexElement. r=dholbert
Brad Werth <bwerth@mozilla.com> - Fri, 01 Feb 2019 22:30:45 +0000 - rev 456497
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521604 Part 3: Add a test of parentFlexElement. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D17433
e23801bb3b78d664fac0726a0609a2996e3f0cfe: Bug 1521604 Part 2: Create a Node chrome-only parentFlexElement property, for use by devtools. r=dholbert,bzbarsky
Brad Werth <bwerth@mozilla.com> - Fri, 01 Feb 2019 22:29:34 +0000 - rev 456496
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521604 Part 2: Create a Node chrome-only parentFlexElement property, for use by devtools. r=dholbert,bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D17308
6d3b8198f3995d6400433eddd85ae040ecdba310: Bug 1521604 Part 1: Hoist the flushing version of GetPrimaryFrame from Element to nsIContent. r=bzbarsky
Brad Werth <bwerth@mozilla.com> - Fri, 01 Feb 2019 22:28:54 +0000 - rev 456495
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521604 Part 1: Hoist the flushing version of GetPrimaryFrame from Element to nsIContent. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D17713
bcb403c04f1c869e7a64636077deb8f6a9ef2aff: Backed out 7 changesets (bug 1521907) for failing at unit/test_bug1151385.js on a CLOSED TREE.
Gurzau Raul <rgurzau@mozilla.com> - Sat, 02 Feb 2019 00:58:16 +0200 - rev 456494
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Backed out 7 changesets (bug 1521907) for failing at unit/test_bug1151385.js on a CLOSED TREE. Backed out changeset ef04359ccf0d (bug 1521907) Backed out changeset ac1c61bf61e9 (bug 1521907) Backed out changeset df09b7be63c5 (bug 1521907) Backed out changeset 585fa0024d46 (bug 1521907) Backed out changeset e593c29aaff4 (bug 1521907) Backed out changeset ac2e180a35b6 (bug 1521907) Backed out changeset 270b1db9ea81 (bug 1521907)
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip