f3821529e27617e69d4d4c2547c275a03f6a731a: Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 03 May 2019 19:24:03 +0000 - rev 472800
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1548118 Part 1 - Advance the column count at the end of the while loop. r=dbaron We use `columnCount == aConfig.mBalanceColCount - 1` in other places to determine if we are at the last column. Advancing the column count at the end of the loop make the condition consistent. Differential Revision: https://phabricator.services.mozilla.com/D29433
0f7f3f92c585491b347a3f9151d8c1af152da722: Bug 1543247 - Part 2: Install `visualmetrics.py` prerequisites. r=ahal
Nick Alexander <nalexander@mozilla.com> - Mon, 06 May 2019 23:56:59 +0000 - rev 472799
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1543247 - Part 2: Install `visualmetrics.py` prerequisites. r=ahal Under the hood, browsertime invokes a certain `visualmetrics.py` script. That script depends on `ffmpeg` and ImageMagick's `convert`, `compare`, and `mogrify` commands. It also depends on certain Python packages. So this installs those dependencies, and then wires up the evaluation environment such that `./mach browsertime` can find the dependencies. It also adds a `./mach visualmetrics` command for processing a captured MP4 file in the same way that browsertime processes such a file. In order to avoid downloading dependencies multiple time, the existing artifact cache is extracted. This is a small first step towards [Bug 1526021](https://bugzilla.mozilla.org/show_bug.cgi?id=1526021), which might want to use this artifact cache as well. At this time, hashes and filesizes are not verified. During development, the upstream files changed multiple times, and it's not worth being completely locked down while experimenting with this functionality. If we start running this code in automation or in more sensitive environments, we can build fetch tasks and TC indexes to streamline the artifact gathering process. It is expected that a future mach command will want to invoke browsertime without suffering the overhead of invoking Python (and mach, which is itself bulky) so a nod is given to exposing the relevant environment pieces. During testing, it was discovered that [MozillaBuild doesn't ship git](https://bugzilla.mozilla.org/show_bug.cgi?id=1503028), so that git repositories can't be used out-of-the-box on Windows. So instead we use a [tarball link from github.com/$USER/$REPO/tarball/$COMMIT-LIKE](https://github.blog/2008-03-03-tarball-downloads/). Differential Revision: https://phabricator.services.mozilla.com/D29442
d407071dd7932a0d8e271a9dd58bf1aa000c700a: Bug 1543247 - Part 1: Add `mach browsertime` command that installs and invokes browsertime. r=Standard8,ahal
Nick Alexander <nalexander@mozilla.com> - Mon, 06 May 2019 23:56:49 +0000 - rev 472798
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1543247 - Part 1: Add `mach browsertime` command that installs and invokes browsertime. r=Standard8,ahal [browsertime](https://github.com/sitespeedio/browsertime) is a harness for running performance tests, similar to Mozilla's Raptor testing framework. The Performance Team is using it locally with some success, but we're running a heavily modified toolchain that is challenging to install. This mach command is intended to be leverage for getting more folks able to use browsertime easily. In particular, the version of browsertime that this installs has nalexander's changes to support testing GeckoView-based vehicles. If this approach meets with approval, I'll continue to follow-up with additional configuration and tooling layers to make it even easier to drive GeckoView-based vehicles. I elected to piggy-back install on the eslint installation process, since this is very similar. To that end, I generalized what was there very slightly. I elected not to try to move the existing code into a more obvious shared location, although it might be possible, because it wasn't clear what contexts the existing code would be invoked from. In particular I wasn't certain the code could rely on a complete mozbuild checkout. I did need to ensure the local Node.js binary is early on the PATH; this was an issue I ran into with my initial Node/Yarn prototyping many months ago. At heart the issue is that package scripts in the wild invoke a bare `node` or `npm` command; if there was a culture of invoking $NODE or $NPM, this wouldn't be necessary. There's no harm doing it for ESlint, and it will help the next person who wants to install an NPM package for tooling in this manner. Differential Revision: https://phabricator.services.mozilla.com/D26820
ae79b7fca45dc376e7f024da7f1ca84d81062868: Bug 1500228 - Upload config.status as a build artifact. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Mon, 06 May 2019 23:37:06 +0000 - rev 472797
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1500228 - Upload config.status as a build artifact. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D29771
4574274db3f95575dca7da08e16d6f20242fcb2a: Backed out changeset 5d97da3c65b5 (bug 1548941) for Valgrind failure
Dorel Luca <dluca@mozilla.com> - Tue, 07 May 2019 02:36:13 +0300 - rev 472796
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Backed out changeset 5d97da3c65b5 (bug 1548941) for Valgrind failure
d2d67ffc31fcaab22a60feb8394a3d01ab7ce52d: Bug 1548916 - Add support for specifying a custom path for app version files. r=firefox-build-system-reviewers,mshal
Ryan VanderMeulen <ryanvm@gmail.com> - Mon, 06 May 2019 23:19:44 +0000 - rev 472795
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1548916 - Add support for specifying a custom path for app version files. r=firefox-build-system-reviewers,mshal Differential Revision: https://phabricator.services.mozilla.com/D29918
16545e6e556eb031b325e6012cf27419f5c56091: Merge mozilla-central to autoland. a=merge CLOSED TREE
Oana Pop Rus <opoprus@mozilla.com> - Tue, 07 May 2019 01:33:06 +0300 - rev 472794
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
df46098ba4b559b4b62b8f05c51bacc424a9075b: Bug 1544610 - Part 1 - Have certerror captive portal message exchanges happen over RPM. r=johannh
prathiksha <prathikshaprasadsuman@gmail.com> - Fri, 03 May 2019 23:30:35 +0000 - rev 472793
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1544610 - Part 1 - Have certerror captive portal message exchanges happen over RPM. r=johannh Differential Revision: https://phabricator.services.mozilla.com/D28539
500cdbe0977e74d4c166ff56cfeaa6690c9c71bf: Bug 1546732 - enable jittest on try, mozilla-central for windows10-aarch64 r=gbrown
Edwin Gao <egao@mozilla.com> - Mon, 06 May 2019 22:00:35 +0000 - rev 472792
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1546732 - enable jittest on try, mozilla-central for windows10-aarch64 r=gbrown Differential Revision: https://phabricator.services.mozilla.com/D30128
83b1e5ce0132a17e6565fe55341f4c73c5c913a4: Bug 1525640 - Add nsIHttpChannelInternal.isResolvedByTRR r=dragana
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 06 May 2019 16:38:16 +0000 - rev 472791
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1525640 - Add nsIHttpChannelInternal.isResolvedByTRR r=dragana Differential Revision: https://phabricator.services.mozilla.com/D26884
3b43b5e97f9e60f110a98869ca748956c47cda5a: Bug 1525640 - Rename nsIHttpChannelInternal.trr to .isHttpServiceChannel to avoid confusion r=dragana
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 06 May 2019 16:37:01 +0000 - rev 472790
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1525640 - Rename nsIHttpChannelInternal.trr to .isHttpServiceChannel to avoid confusion r=dragana Differential Revision: https://phabricator.services.mozilla.com/D26883
406e4a9a3f758ae2c030b7b9437b8e0835876028: Bug 1525640 - Pass TRR status from sockettransport to channel r=dragana
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 06 May 2019 16:47:14 +0000 - rev 472789
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1525640 - Pass TRR status from sockettransport to channel r=dragana Differential Revision: https://phabricator.services.mozilla.com/D26882
39077226dac335e743f7465fb91349d76ded1922: Backed out 2 changesets (bug 1548568) for Valgrind failure. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Tue, 07 May 2019 01:13:06 +0300 - rev 472788
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Backed out 2 changesets (bug 1548568) for Valgrind failure. CLOSED TREE Backed out changeset b7d27dc874df (bug 1548568) Backed out changeset dadb3b3dad5f (bug 1548568)
f776e9e5e817c9f1acd0451e915042089e80ce14: Backed out changeset 1f47ae47ceac (bug 1546383) for Spidermonkey failures in js\src\jit-test\tests\cacheir\getter-primitive-value.js. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Tue, 07 May 2019 00:56:51 +0300 - rev 472787
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Backed out changeset 1f47ae47ceac (bug 1546383) for Spidermonkey failures in js\src\jit-test\tests\cacheir\getter-primitive-value.js. CLOSED TREE
cf7b6547cfb26608ba79093ed78f85a56dfbfd56: Bug 1549589 - scroll-snap-coordinate shouldn't use NotInitial. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 06 May 2019 21:31:16 +0000 - rev 472786
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1549589 - scroll-snap-coordinate shouldn't use NotInitial. r=hiro The initial value for this is indeed `none` (and thus empty). The Rust code was confused. This property is disabled by default these days, and I think the get_initial_value() function, which is what could get confused, is not called for this property, so I think this shouldn't be observable. Differential Revision: https://phabricator.services.mozilla.com/D30124
93e59a14b907071d2059c66f8391ed6c0904ca3c: Bug 1548303 - Make it easier to resize the Picture-in-Picture player window. r=dthayer
Mike Conley <mconley@mozilla.com> - Mon, 06 May 2019 20:34:49 +0000 - rev 472785
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1548303 - Make it easier to resize the Picture-in-Picture player window. r=dthayer This is made easier by making the window-dragging region inset by 5px on each side. Depends on D30100 Differential Revision: https://phabricator.services.mozilla.com/D30101
818f9fcee08eafbce5f298634327da6f023ad11e: Bug 1546362 - Avoid strange white border when switching focus to and from the Picture-in-Picture player window. r=dthayer
Mike Conley <mconley@mozilla.com> - Mon, 06 May 2019 20:46:16 +0000 - rev 472784
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1546362 - Avoid strange white border when switching focus to and from the Picture-in-Picture player window. r=dthayer I'm not 100% sure why this fixes the issue, but I suspect it's because we used to set chromemargin on the window _after_ it had had a chance to lay itself out. It seems we can sidestep the issue by putting the chromemargin on the <html> node directly. There's the remaining issue where due to rounding, sometimes a very thin (1px) white border will be displayed around one part of the player window. This has been split out to bug 1549542. Differential Revision: https://phabricator.services.mozilla.com/D30100
0762225c24094c033013ab87c6574c4a0f1a39bd: Bug 1549538 - Fix win64 artifact builds based on inbound. r=nalexander
Chris Manchester <cmanchester@mozilla.com> - Mon, 06 May 2019 21:05:52 +0000 - rev 472783
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1549538 - Fix win64 artifact builds based on inbound. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D30115
e391c48bc166bf4cba9dafe7b5c1d1310444269f: Bug 1548884 - Enable the synced bookmarks mirror on Nightly and Beta. r=tcsc
Lina Cambridge <lina@yakshaving.ninja> - Mon, 06 May 2019 20:40:20 +0000 - rev 472782
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1548884 - Enable the synced bookmarks mirror on Nightly and Beta. r=tcsc The number of Sync users on these channels is low compared to Release, so we can do this without a gradual rollout. This also lets more users test the new bookmark sync engine without manually flipping the pref. Differential Revision: https://phabricator.services.mozilla.com/D29859
07ec0bc698e352f0701a0079996ec9143886ffed: Backed out changeset ef8c4674d0b0 (bug 1549383) for Build bustage. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Tue, 07 May 2019 00:14:08 +0300 - rev 472781
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Backed out changeset ef8c4674d0b0 (bug 1549383) for Build bustage. CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip