eeff570a825a7370902317ae5dc53862d4f82c7e: Bug 1537537. Improve the MOZ_CAN_RUN_SCRIPT analysis reporting around invalid args. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:52:50 +0000 - rev 465428
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1537537. Improve the MOZ_CAN_RUN_SCRIPT analysis reporting around invalid args. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24258
664d49ea52757224083e93a9742e676bb8689ef4: Bug 1536736. Allow constexpr things in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:52:33 +0000 - rev 465427
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536736. Allow constexpr things in the MOZ_CAN_RUN_SCRIPT analysis. r=andi Since these are compile-time constants, they can't exactly go away on us due to running script, right? Differential Revision: https://phabricator.services.mozilla.com/D24195
1133a148d29c657567b6985e08af96adab3328f7: Bug 1536825. Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:50:55 +0000 - rev 465426
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536825. Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis. r=andi We need to typecheck the trivials too, not just the final thing after trivials are stripped, because casts are trivials. Differential Revision: https://phabricator.services.mozilla.com/D24186
15a5f72d591f9af00b5379495e8d7258e5840226: Bug 1536724. Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:49:11 +0000 - rev 465425
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536724. Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24120
9acf9a003aa388a9d7efd11fb2a9031b6a7ed7df: Bug 1536719. Fix handling of member method calls in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:48:33 +0000 - rev 465424
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536719. Fix handling of member method calls in the MOZ_CAN_RUN_SCRIPT analysis. r=andi The old code for member method calls did the following: 1) Find the member method calls. 2) Look at their "this" expression. 3) If the "this" is an operator call, check for any of the arguments of the operator call being invalid. 4) Otherwise (if not an operator call) check for the "this" value being invalid. This wasn't right, because the "is invalid" check checks the type and only considers refcounted things. So if the code looked something like "foo[i]->call_method()", we would look at the types of "foo" and "i" and determine that none of those are refcounted types so there is nothing invalid here (since "foo" is some sort of array type and "i" is an integer). The new setup just checks whether the "this" value is invalid, which does the type check on the "this" value itself; in the "foo[i]->call_method()" case on "foo[i]". We then adjust the exclusions in InvalidArg to consider operator-> on known-live things valid, to allow the thing that we were really trying to accomplish with the "check for an operator call" bits: "stackRefPtr->some_method()". The test coverage being added for the made-up TArray type is meant to catch things like the geolocation issue that was being hidden by the buggy behavior. I'm not using nsTArray itself because some header included by nsTArray.h tries to define operator new/delete bits inline and that triggers warnings that then cause a clang-plugin test failure, because they're unexpected. Differential Revision: https://phabricator.services.mozilla.com/D24117
6365c8d87a5c8811f5dda4e4417450515e1f6bc3: Bug 1536336. Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:47:22 +0000 - rev 465423
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536336. Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs. r=andi "this" is guaranteed to stay alive as long as other MOZ_CAN_RUN_SCRIPT conditions hold, and its const members can't change value and drop their refs. Differential Revision: https://phabricator.services.mozilla.com/D23997
323b02ea2926c6762c63730b43c57eaca0e73dc1: Bug 1536653 - browser/ manual ESLint no-throw-literal fixes. r=Gijs
Ian Moody <moz-ian@perix.co.uk> - Wed, 20 Mar 2019 10:15:03 +0000 - rev 465422
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536653 - browser/ manual ESLint no-throw-literal fixes. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D24111
2775470a624f84e16c66813af09f703f8aab9f51: Bug 1536653 - browser/ automated ESLint no-throw-literal fixes. r=Gijs
Ian Moody <moz-ian@perix.co.uk> - Wed, 20 Mar 2019 10:17:42 +0000 - rev 465421
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536653 - browser/ automated ESLint no-throw-literal fixes. r=Gijs Result of running: $ mach eslint -funix browser/ | sed -Ee 's/:.+//' - | xargs sed -E \ -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \ -e 's/throw \(/throw new Error(/g' -i Differential Revision: https://phabricator.services.mozilla.com/D24110
f981cbb72ac2b9802839dd6b84758dbcd8be4ce4: Bug 1536648 - accessible/ manual ESLint no-throw-literal fixes. r=Jamie
Ian Moody <moz-ian@perix.co.uk> - Wed, 20 Mar 2019 00:23:17 +0000 - rev 465420
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536648 - accessible/ manual ESLint no-throw-literal fixes. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D24107
10b750eab8164e7cd6fa8315e2bd04cc9001e8b0: Bug 1423917 - P10 - Remove .tmp file in idb drectories in the 2_1to2_2 upgrade; r=asuth
Tom Tung <shes050117@gmail.com> - Wed, 20 Mar 2019 13:32:49 +0000 - rev 465419
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1423917 - P10 - Remove .tmp file in idb drectories in the 2_1to2_2 upgrade; r=asuth Differential Revision: https://phabricator.services.mozilla.com/D21733
f285d37402e2d138d4567e623c6a578e942ff8e5: Bug 1423917 - P9 - Remove asmjs client in the 2_1to2_2 upgrade for QuotaManager; r=luke
Tom Tung <shes050117@gmail.com> - Wed, 13 Mar 2019 15:59:34 +0000 - rev 465418
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1423917 - P9 - Remove asmjs client in the 2_1to2_2 upgrade for QuotaManager; r=luke Differential Revision: https://phabricator.services.mozilla.com/D21732
5584de41d293aff4d2eff05c4cd884e87f876028: Bug 1423917 - P7 - Ignore invalid origin files during upgrading; r=asuth
Tom Tung <shes050117@gmail.com> - Wed, 20 Mar 2019 13:32:47 +0000 - rev 465417
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1423917 - P7 - Ignore invalid origin files during upgrading; r=asuth After this patch, invalid origin shouldn't block upgrade anymore. However, we should be aware of that if an invild origin somehow can be recoverd to a valid origin, then upgrade that origin is required. Depends on D21730 Differential Revision: https://phabricator.services.mozilla.com/D21731
330622caa8b7aa6acb553910d0b228157a0b2fcb: Bug 1423917 - P6 - Having a test to verify the version2_1To2_2 upgrade removes obsolete origins and isn't blocked by an invalid origin; r=asuth
Tom Tung <shes050117@gmail.com> - Wed, 20 Mar 2019 13:32:45 +0000 - rev 465416
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1423917 - P6 - Having a test to verify the version2_1To2_2 upgrade removes obsolete origins and isn't blocked by an invalid origin; r=asuth Depends on D21729 Differential Revision: https://phabricator.services.mozilla.com/D21730
1a87608f65c3c4cf6abfd9288636a2d3049f86fa: Bug 1423917 - P5 - Introduce a minor upgrade on QuotaManager to clean obsolete origins; r=asuth
Tom Tung <shes050117@gmail.com> - Wed, 20 Mar 2019 13:31:10 +0000 - rev 465415
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1423917 - P5 - Introduce a minor upgrade on QuotaManager to clean obsolete origins; r=asuth Depends on D21728 Differential Revision: https://phabricator.services.mozilla.com/D21729
497e09d55cc56d171d132726017d68daa5c201f5: Bug 1423917 - P4 - Support moz-safe-about://home in OriginParser and make it obsolete; r=asuth
Tom Tung <shes050117@gmail.com> - Wed, 20 Mar 2019 13:30:18 +0000 - rev 465414
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1423917 - P4 - Support moz-safe-about://home in OriginParser and make it obsolete; r=asuth Depends on D21727 Differential Revision: https://phabricator.services.mozilla.com/D21728
a3af1bcb734844d30a203d8af6670d57972d14a9: Bug 1423917 - P3 - Teach the OriginParser "chrome" origin; r=asuth
Tom Tung <shes050117@gmail.com> - Wed, 20 Mar 2019 13:28:55 +0000 - rev 465413
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1423917 - P3 - Teach the OriginParser "chrome" origin; r=asuth This patch makes OriginParser only treats "chrome" origin as a valid origin. For the rest kinds of origins with chrome schema, the OriginParser would just treat them as obsolete origins. Differential Revision: https://phabricator.services.mozilla.com/D21727
d24302372a6718247f5bbd6d1c8467baa954d7d8: Bug 1450893 - Add pref for list of domains excluded from TRR r=dragana
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 21 Mar 2019 12:41:41 +0000 - rev 465412
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1450893 - Add pref for list of domains excluded from TRR r=dragana Differential Revision: https://phabricator.services.mozilla.com/D24291
da9099238d4fa1fd520508743cae5a06168ef5ed: Bug 1450893 - Add way to clear DNS cache r=dragana
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 21 Mar 2019 12:41:39 +0000 - rev 465411
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1450893 - Add way to clear DNS cache r=dragana Differential Revision: https://phabricator.services.mozilla.com/D24300
3e21362cd4dca93964b0ffa8296838aae82cd349: Bug 1536387 - Part 2: enhance the range for allowed http cache storage key tag character values, r=michal
Honza Bambas <honzab.moz@firemni.cz> - Thu, 21 Mar 2019 13:01:15 +0000 - rev 465410
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536387 - Part 2: enhance the range for allowed http cache storage key tag character values, r=michal Differential Revision: https://phabricator.services.mozilla.com/D24342
30454922473818f48661f81b29b097b2e718e0d0: Bug 1530481 - Support encoded snapshots in Firefox Origin Telemetry. r=janerik
Chris H-C <chutten@mozilla.com> - Thu, 21 Mar 2019 09:54:03 +0000 - rev 465409
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1530481 - Support encoded snapshots in Firefox Origin Telemetry. r=janerik The threading and promise handling is kept at the TelemetryImpl level deliberately to facilitate testing. It also turns out that hangs/modules do more-or-less the same split for their off-thread collection, so in retrospect it is the obvious choice. For the batch ID we're using the app build id as discussed. Differential Revision: https://phabricator.services.mozilla.com/D22606
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip