ecb1ebb963155e84185700424c4af0f4f03562ff: Bug 1499426 - Only create AudioInputProcessing once in MediaEngineWebRTCAudio::Start. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 05 Nov 2018 11:23:39 +0100 - rev 444552
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Bug 1499426 - Only create AudioInputProcessing once in MediaEngineWebRTCAudio::Start. r=pehrsons
c27b21d98ce4c497aede277dce8bcd058ba3b886: Bug 1500017 - Use triple buffer with DXGI_SWAP_EFFECT_FLIP_SEQUENTIAL SwapChain r=mattwoodrow
sotaro <sotaro.ikeda.g@gmail.com> - Mon, 05 Nov 2018 18:58:37 +0900 - rev 444551
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Bug 1500017 - Use triple buffer with DXGI_SWAP_EFFECT_FLIP_SEQUENTIAL SwapChain r=mattwoodrow
4a54c96fade967ad9337862f31f62fc55f44d819: Merge mozilla-central to inbound. a=merge CLOSED TREE
Margareta Eliza Balazs <ebalazs@mozilla.com> - Mon, 05 Nov 2018 11:53:19 +0200 - rev 444550
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Merge mozilla-central to inbound. a=merge CLOSED TREE
16f9bded4e5bd8f317caf844a4a989ea15ef736a: Bug 1185808 - Improve devtool notification box layout when overflowing. r=pbro
Vincent R <grosbouddha@gmail.com> - Thu, 01 Nov 2018 01:22:18 +0100 - rev 444549
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Bug 1185808 - Improve devtool notification box layout when overflowing. r=pbro - Make notificationbox buttons and closing affordance visible when overflowing, - Apply ellipsis to message when overflowing (using the width=0 to not break flex layout), - Add title to show potentially truncated message on hover, - Simplify layout (remove the unnecessary nested flexbox layout). TESTED=Locally using some mocked notification buttons. Run styleeditor and shared/component tests.
2605ac0d5cd7cc7edf3179ff9831f73ee92c2d23: Bug 1502045 - Honour cookie permissions correctly in 3rd party contexts, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 05 Nov 2018 10:18:05 +0100 - rev 444548
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Bug 1502045 - Honour cookie permissions correctly in 3rd party contexts, r=ehsan
0dc423641071812046dc811599246c6e96c32189: Bug 1497426 - Add source.label support for native Toast Notification. r=aklotz
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 09 Oct 2018 16:26:42 +0900 - rev 444547
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Bug 1497426 - Add source.label support for native Toast Notification. r=aklotz XUL version of notification and macOS's notification center show source label ("via <URL>" to show origin URL). Windows's toast notification should show it like XUL version. Windows 10 anniversary update or later has placement=attribution attribute for this usages. https://blogs.msdn.microsoft.com/tiles_and_toasts/2016/05/23/notificationsextensions-updated-for-anniversary-update-of-windows-10/#toastattribution is more detail about attribution text, so we should use it. As example, screenshots of this change are attached in this bug. Differential Revision: https://phabricator.services.mozilla.com/D8196
8bc2bb564ad01e967566688e6544cbcdcd72fa2a: Backed out changeset d139f68fd874 (bug 1500017) for build bustages on RenderCompositorANGLE.cpp
Cosmin Sabou <csabou@mozilla.com> - Mon, 05 Nov 2018 09:36:05 +0200 - rev 444546
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Backed out changeset d139f68fd874 (bug 1500017) for build bustages on RenderCompositorANGLE.cpp
d139f68fd874510ece138ac2a8879ab0156072f2: Bug 1500017 - Use triple buffer with DXGI_SWAP_EFFECT_FLIP_SEQUENTIAL SwapChain r=mattwoodrow
sotaro <sotaro.ikeda.g@gmail.com> - Mon, 05 Nov 2018 15:54:10 +0900 - rev 444545
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Bug 1500017 - Use triple buffer with DXGI_SWAP_EFFECT_FLIP_SEQUENTIAL SwapChain r=mattwoodrow
4bd285695bad731be29d5f8c750040bb3cc101ea: No Bug - Add bug numbers for FIXME comments in BinAST code. r=me DONTBUILD comment only
Tooru Fujisawa <arai_a@mac.com> - Mon, 05 Nov 2018 13:45:09 +0900 - rev 444544
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
No Bug - Add bug numbers for FIXME comments in BinAST code. r=me DONTBUILD comment only
6231a4da0ebe72edd019cac34d57b5c386070cba: Backed out changeset 91d5d2c4b1b9 (bug 1497426) due to mistaking merge
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 05 Nov 2018 12:38:07 +0900 - rev 444543
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Backed out changeset 91d5d2c4b1b9 (bug 1497426) due to mistaking merge
91d5d2c4b1b9a11f09a1ca26f946956eb7eee29e: Bug 1497426 - Add source.label support for native Toast Notification. r=aklotz
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 09 Oct 2018 16:26:42 +0900 - rev 444542
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Bug 1497426 - Add source.label support for native Toast Notification. r=aklotz XUL version of notification and macOS's notification center show source label ("via <URL>" to show origin URL). Windows's toast notification should show it like XUL version. Windows 10 anniversary update or later has placement=attribution attribute for this usages. https://blogs.msdn.microsoft.com/tiles_and_toasts/2016/05/23/notificationsextensions-updated-for-anniversary-update-of-windows-10/#toastattribution is more detail about attribution text, so we should use it. As example, screenshots of this change are attached in this bug. Differential Revision: https://phabricator.services.mozilla.com/D8196
2c369f37574ac8be128b853f9f4f466dbfe6cd76: Bug 1504080 - Fix two comments in nursery code r=jonco
Paul Bone <pbone@mozilla.com> - Wed, 10 Oct 2018 20:35:40 +1100 - rev 444541
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Bug 1504080 - Fix two comments in nursery code r=jonco + Comment currentStartChunk_ in more detail + Remove misplaced comment about allocation during maybeResizeNursery, this code no-longer does any allocation.
881a67c2941279c07463c782d5aa65e49e96d281: Bug 1504080 - Add Nursery::stats() r=jonco
Paul Bone <pbone@mozilla.com> - Thu, 01 Nov 2018 13:20:40 +1100 - rev 444540
Push 34997 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:59:47 +0000
Bug 1504080 - Add Nursery::stats() r=jonco Add a new function for a commonly accesses structure.
e160f0a60e4fc9cc6e77dd57644d74d4c6cc88dd: Merge autoland to mozilla-central. a=merge
Gurzau Raul <rgurzau@mozilla.com> - Tue, 06 Nov 2018 11:52:42 +0200 - rev 444539
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Merge autoland to mozilla-central. a=merge
53647b724d3bbc77055bd9167fa125c5d52e4eda: Backed out changeset cdfaa36dcd55 (bug 1503536) for perma assertion failure at media/webrtc/MediaEngineWebRTCAudio.cpp a=backout
Gurzau Raul <rgurzau@mozilla.com> - Tue, 06 Nov 2018 11:51:57 +0200 - rev 444538
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Backed out changeset cdfaa36dcd55 (bug 1503536) for perma assertion failure at media/webrtc/MediaEngineWebRTCAudio.cpp a=backout
b4e4e74aa3ccb6673df2a4b62249706e5999fcd6: Bug 1502786 - Break cycle between PureOmxPlatformLayer and OmxDataDecoder r=jya
Takuro Ashie <ashie@clear-code.com> - Tue, 06 Nov 2018 02:56:36 +0000 - rev 444537
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1502786 - Break cycle between PureOmxPlatformLayer and OmxDataDecoder r=jya OmxDataDecoder, OmxPromiseLayer and PureOmxPlatformLayer consist circular reference by RefPtr, and no one sever the reference. As a result their refcount never decrease to 0. This commit sever it at PureOmxPlatformLayer::Shutdown() which is called by OmxDataDecoder. Differential Revision: https://phabricator.services.mozilla.com/D10028
b765559ddc3a9d0b54f3665de95407799e58e317: Backed out 5 changesets (bug 1456555) for reftests failuress on /reftests/svg/text/pattern-content.svg.
Brindusan Cristian <cbrindusan@mozilla.com> - Tue, 06 Nov 2018 07:39:19 +0200 - rev 444536
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Backed out 5 changesets (bug 1456555) for reftests failuress on /reftests/svg/text/pattern-content.svg. Backed out changeset 0f2854553c21 (bug 1456555) Backed out changeset 5e3b20a19162 (bug 1456555) Backed out changeset 6cc965ecc095 (bug 1456555) Backed out changeset 595abbb5bf3e (bug 1456555) Backed out changeset c4df6309a5be (bug 1456555)
50f1edbfb52c2dd1e8074c29bf0d00c5ad08e2f7: Bug 1499507 - Allow the compiler to generate a non-atomic increment instruction for the stack pointer increment. r=njn
Markus Stange <mstange@themasta.com> - Tue, 06 Nov 2018 04:35:13 +0000 - rev 444535
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499507 - Allow the compiler to generate a non-atomic increment instruction for the stack pointer increment. r=njn This change reduces the binary size on macOS x64 by around 50KB. Here's a diff of the impact on the code generated for Attr_Binding::get_specified in the Mac build. It's a bit hard to read because %r12 and %rbx swap their function, but what happens in this method is that "movq %r12, %rcx" goes away, and the two instructions "leal 0x1(%r12) %eax" and "movl %eax, 0x10(%rbx)" turn into an "incl 0x10(%r12)". So the old code was preserving the original value of profilingStack->stackPointer in a register, and then using it later to compute the incremented stackPointer. The new code uses an "incl" instruction for the stackPointer increment and doesn't worry that the stackPointer value might have changed since the stack size check at the start of the function. (It can't have changed.) before: %rbx has the ProfilingStack*, %r12 has profilingStack->stackPointer after: %r12 has the ProfilingStack*, %rbx has profilingStack->stackPointer @@ -3,37 +3,35 @@ movq %rsp, %rbp pushq %r15 pushq %r14 pushq %r12 pushq %rbx subq $0x10, %rsp movq %rcx, %r14 movq %rdx, %r15 - movq 0x80(%rdi), %rbx - movq %rbx, -40(%rbp) - testq %rbx, %rbx + movq 0x80(%rdi), %r12 + movq %r12, -40(%rbp) + testq %r12, %r12 je loc_xxxxx - movl 0x10(%rbx), %r12d - cmpl (%rbx), %r12d + movl 0x10(%r12), %ebx + cmpl (%r12), %ebx jae loc_xxxxx - movq 0x8(%rbx), %rax - movq %r12, %rcx - shlq $0x5, %rcx - leaq aAttr, %rdx ; "Attr" - movq %rdx, (%rax,%rcx) - leaq aSpecified, %rdx ; "specified" - movq %rdx, 0x8(%rax,%rcx) - leaq -40(%rbp), %rdx - movq %rdx, 0x10(%rax,%rcx) - movl $0x3a1, 0x1c(%rax,%rcx) - leal 0x1(%r12), %eax - movl %eax, 0x10(%rbx) + movq 0x8(%r12), %rax + shlq $0x5, %rbx + leaq aAttr, %rcx ; "Attr" + movq %rcx, (%rax,%rbx) + leaq aSpecified, %rcx ; "specified" + movq %rcx, 0x8(%rax,%rbx) + leaq -40(%rbp), %rcx + movq %rcx, 0x10(%rax,%rbx) + movl $0x3a1, 0x1c(%rax,%rbx) + incl 0x10(%r12) movq %r15, %rdi call __ZNK7mozilla3dom4Attr9SpecifiedEv ; mozilla::dom::Attr::Specified() const movzxl %al, %eax movabsq $0xfff9000000000000, %rcx orq %rax, %rcx movq %rcx, (%r14) movq -40(%rbp), %rax @@ -47,11 +45,11 @@ popq %rbx popq %r12 popq %r14 popq %r15 popq %rbp ret ; endp - movq %rbx, %rdi + movq %r12, %rdi call __ZN14ProfilingStack18ensureCapacitySlowEv ; ProfilingStack::ensureCapacitySlow() jmp loc_xxxxx Depends on D9205 Differential Revision: https://phabricator.services.mozilla.com/D9206
5ec157cbbdd11c216e996e2cc763bd087620cb11: Bug 1499507 - Use AUTO_PROFILER_LABEL_DYNAMIC_FAST for WebIDL APIs. r=bzbarsky
Markus Stange <mstange@themasta.com> - Tue, 06 Nov 2018 04:34:58 +0000 - rev 444534
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499507 - Use AUTO_PROFILER_LABEL_DYNAMIC_FAST for WebIDL APIs. r=bzbarsky This means that our binary does not need to include concatenated strings such as "set CanvasRenderingContext2D.fillStyle". It only needs to contain the individual strings "CanvasRenderingContext2D" and "fillStyle" which are most likely already present in the binary. This change reduces the binary size on macOS x64 by around 200KB. Here's a diff of the impact on the code generated for Attr_Binding::get_specified in the Mac build. This change makes us generate slightly more code, which is very much offset by the reduction in the amount of strings we ship. @@ -15,22 +15,23 @@ movl 0x10(%rbx), %r12d cmpl (%rbx), %r12d jae loc_xxxxx movq 0x8(%rbx), %rax movq %r12, %rcx shlq $0x5, %rcx - leaq aGetAttrspecifi, %rdx ; "get Attr.specified" + leaq aAttr, %rdx ; "Attr" movq %rdx, (%rax,%rcx) - movq $0x0, 0x8(%rax,%rcx) + leaq aSpecified, %rdx ; "specified" + movq %rdx, 0x8(%rax,%rcx) leaq -40(%rbp), %rdx movq %rdx, 0x10(%rax,%rcx) - movl $0x71, 0x1c(%rax,%rcx) + movl $0x3a1, 0x1c(%rax,%rcx) leal 0x1(%r12), %eax movl %eax, 0x10(%rbx) movq %r15, %rdi call __ZNK7mozilla3dom4Attr9SpecifiedEv ; mozilla::dom::Attr::Specified() const movzxl %al, %eax movabsq $0xfff9000000000000, %rcx orq %rax, %rcx Depends on D9204 Differential Revision: https://phabricator.services.mozilla.com/D9205
408a37a9e42b9fa9d219641c240a6cc98e9ea756: Bug 1499507 - Add AUTO_PROFILER_LABEL_DYNAMIC_FAST which allows specifying flags. r=njn
Markus Stange <mstange@themasta.com> - Tue, 06 Nov 2018 04:33:45 +0000 - rev 444533
Push 34996 by rgurzau@mozilla.com at Tue, 06 Nov 2018 09:53:23 +0000
Bug 1499507 - Add AUTO_PROFILER_LABEL_DYNAMIC_FAST which allows specifying flags. r=njn Depends on D9203 Differential Revision: https://phabricator.services.mozilla.com/D9204
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip