eb57c8ac9c338629a6d5949bba5df020909de766: Bug 1357639 - part9 : wait tab event to make sure media started successfully. r=sebastian
Alastor Wu <alwu@mozilla.com> - Mon, 08 May 2017 14:10:59 +0800 - rev 357398
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1357639 - part9 : wait tab event to make sure media started successfully. r=sebastian Since the robocop tests would run on super slow emulator on try, and then we can't wait the tab's audible state change within the MAX_WAIT_MS time. It might need more time. So, we should check the media has been started by waiting the "Tab:MediaPlaybackChange" event, and then to check other tab's attribute. In addition, move the tab attribute checking independently into new functions, so that we would clearly see that we have four things need to check in function checkIfMediaPlayingSuccess(). - tab's media playing state - media notification UI - tab's audio playing state - audio focus state MozReview-Commit-ID: 8S0Ems23iPX
99965090d3d111a21e85c243068534f598200b04: Bug 1357639 - part8 : add annotiation @RobocopTarget. r=sebastian
Alastor Wu <alwu@mozilla.com> - Mon, 08 May 2017 14:10:56 +0800 - rev 357397
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1357639 - part8 : add annotiation @RobocopTarget. r=sebastian To make sure these functions can be used in robocop test. MozReview-Commit-ID: KPAKOrg5Ows
ac34f641df9502f354e0b876629e844017f6ff65: Bug 1357639 - part7 : add check for notification's content. r=sebastian
Alastor Wu <alwu@mozilla.com> - Mon, 08 May 2017 14:10:54 +0800 - rev 357396
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1357639 - part7 : add check for notification's content. r=sebastian Add check for media notification's small icon, title and content text. MozReview-Commit-ID: AOhag8gQVqs
4a9d90bd04af4c616805736f14da6179097df9cb: Bug 1357639 - part6 : list all test tasks in the ctor. r=sebastian
Alastor Wu <alwu@mozilla.com> - Mon, 08 May 2017 14:10:51 +0800 - rev 357395
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1357639 - part6 : list all test tasks in the ctor. r=sebastian It's easy to know what test tasks we'll run in this test. MozReview-Commit-ID: DdtFp4pOXlC
9b6f4262f550da01a5a2f42ef139cae8482473fd: Bug 1357639 - part5 : create new type test class for media playback. r=sebastian
Alastor Wu <alwu@mozilla.com> - Mon, 08 May 2017 14:10:48 +0800 - rev 357394
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1357639 - part5 : create new type test class for media playback. r=sebastian Create new test class for reducing the redundant code and can provide more flexibility for adding new related test in the future. MozReview-Commit-ID: 2f3O8vfHo12
1d82eb12f45330786ca37032da07663da4dc9481: Bug 1357639 - part4 : add Fennec test for media control and audio focus. r=sebastian
Alastor Wu <alwu@mozilla.com> - Mon, 08 May 2017 14:10:46 +0800 - rev 357393
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1357639 - part4 : add Fennec test for media control and audio focus. r=sebastian Add robocop tests and mochitest chrome. MozReview-Commit-ID: JofkKRSNdB5
8f3190d4e3e41928cc57ea0fb7e186a285847fb4: Bug 1357639 - part3 : change audio focus state before notifying observers. r=sebastian
Alastor Wu <alwu@mozilla.com> - Mon, 08 May 2017 14:10:43 +0800 - rev 357392
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1357639 - part3 : change audio focus state before notifying observers. r=sebastian Notify observer might cause the method (notifyStoppedPlaying) is called by C++ side, and we should change our internal state before calling the method. MozReview-Commit-ID: 5xNXhGmAIrR
49e6be4c1e58371a41a7a826e43944489564a0dc: Bug 1357639 - part2 : use enum for audio focus states. r=sebastian
Alastor Wu <alwu@mozilla.com> - Mon, 08 May 2017 14:10:41 +0800 - rev 357391
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1357639 - part2 : use enum for audio focus states. r=sebastian MozReview-Commit-ID: LwLxs7WS5XF
5211eb9a9b95026375177ee01171420f8ff85a78: Bug 1357639 - part1 : change tab's media playing state when the tab is controlled by media control. r=sebastian
Alastor Wu <alwu@mozilla.com> - Mon, 08 May 2017 14:10:39 +0800 - rev 357390
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1357639 - part1 : change tab's media playing state when the tab is controlled by media control. r=sebastian MozReview-Commit-ID: HGuMXut29uB
d0b06894933dddf6ecb4a46b88e2065806a860e3: Bug 1308143 - Clean up ExtendedValidation.cpp. r=keeler
Cykesiopka <cykesiopka.bmo@gmail.com> - Tue, 09 May 2017 00:53:21 +0800 - rev 357389
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1308143 - Clean up ExtendedValidation.cpp. r=keeler In general, the changes here attempt to: 1. Fix up the style to match modern PSM style. 2. Shorten unnecessarily long code. 3. Reduce global scope pollution. MozReview-Commit-ID: GFyqFgV0RLD
739be3e2b91ccfd9ec1d9173067bdac4362b6551: Bug 1363538 - Remove some derelict testing code from XPCShellImpl.cpp. r=mrbkap
Andrew McCreight <continuation@gmail.com> - Tue, 09 May 2017 14:35:23 -0700 - rev 357388
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1363538 - Remove some derelict testing code from XPCShellImpl.cpp. r=mrbkap MozReview-Commit-ID: 96UyB317H0W
0b2bc96e10403f097daf3b2d5e00da4700c87a5b: Bug 1358136 - No hover/mouseover state in high contrast theme. r=dao
Drew Willcoxon <adw@mozilla.com> - Fri, 28 Apr 2017 19:07:13 -0700 - rev 357387
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1358136 - No hover/mouseover state in high contrast theme. r=dao MozReview-Commit-ID: 3mca9DN0IM9
fc53ac8389fdbc812d2edb04993d1947f343c1c0: Bug 1363551 - Remove unused TabsLayoutRecyclerAdapter. r=sebastian
Tom Klein <twointofive@gmail.com> - Tue, 09 May 2017 17:37:02 -0500 - rev 357386
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1363551 - Remove unused TabsLayoutRecyclerAdapter. r=sebastian MozReview-Commit-ID: EMsVY1Edime
eab436c452e9a539c4e8f3943ffdf3c8cdcbb3b2: Bug 1363215 - Replace calls to __define{Getter,Setter}__ on top-level this with Object.defineProperty. r=Gijs
Andrew McCreight <continuation@gmail.com> - Mon, 08 May 2017 14:07:34 -0700 - rev 357385
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1363215 - Replace calls to __define{Getter,Setter}__ on top-level this with Object.defineProperty. r=Gijs __define{Getter,Setter}__ are deprecated, and are not defined on NonSyntacticVariablesObjects, so these calls get in the way of sharing globals between different .jsms. Probably only the DownloadUtils.jsm change is really needed for that. configurable and enumerable are both set to true to match the existing behavior. If enumerable is set to false, then tests fail, because some of the getters overwrite the getter with a regular property. MozReview-Commit-ID: 1OZF45fIAQ
64913c949426363461f068b016c4d4fdbcd0d601: Bug 1363443 - Use Cu.isModuleLoaded to see if the module is loaded in PlacesCategoriesStarter.js. r=mak
Andrew McCreight <continuation@gmail.com> - Mon, 08 May 2017 14:56:18 -0700 - rev 357384
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1363443 - Use Cu.isModuleLoaded to see if the module is loaded in PlacesCategoriesStarter.js. r=mak Cu.isModuleLoaded is more direct, and also the current method will break if jsms begin to share globals, as in bug 1186409. This patch is by billm from bug 1186409. MozReview-Commit-ID: KoHMTJpmHg2
96dd4bfde83ce3113238b538d75fddd6f64665ab: Bug 1363475 - Fix TaskTracer build failure. r=njn
Markus Stange <mstange@themasta.com> - Thu, 04 May 2017 17:26:54 -0400 - rev 357383
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1363475 - Fix TaskTracer build failure. r=njn MozReview-Commit-ID: 7ENK05KNcGn
e31b45db8b71df66ea1ddacbee09b99e2d9f430f: Merge m-c to autoland, a=merge
Wes Kocher <wkocher@mozilla.com> - Tue, 09 May 2017 14:59:18 -0700 - rev 357382
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Merge m-c to autoland, a=merge
219c5bfc40a21801ebe0286b2e78430d9d8f29a5: Bug 1363046 - Update neterror/certerror page design for Photon. r=dao
Johann Hofmann <jhofmann@mozilla.com> - Tue, 09 May 2017 16:43:15 -0400 - rev 357381
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1363046 - Update neterror/certerror page design for Photon. r=dao MozReview-Commit-ID: 5RakjD72FwV
dba495fc3c06371e86f13fa2866cb3d1d535d75c: Bug 1353349 - Don't attempt to put empty profiles into the processes array. r=froydnj
Markus Stange <mstange@themasta.com> - Tue, 09 May 2017 15:40:50 -0400 - rev 357380
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1353349 - Don't attempt to put empty profiles into the processes array. r=froydnj MozReview-Commit-ID: HFjLEaqippx
8dcfb6dd839349e64b6e135c67732066c266016c: Bug 1356675 - Show manual update on cant-apply status r=rstrong
Doug Thayer <dothayer@mozilla.com> - Thu, 04 May 2017 10:12:52 -0700 - rev 357379
Push 31791 by cbook@mozilla.com at Wed, 10 May 2017 13:06:37 +0000
Bug 1356675 - Show manual update on cant-apply status r=rstrong If there is an update available but the user can't apply it, we publish a notification on the update-available topic with the status "cant-apply". This was previously being ignored by browser.js. This should fix the bug in question on Windows 10. MozReview-Commit-ID: 1twRvYEXbiT
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip