ea669e7b7e93f039ca0c68c7c8a32fab78495e08: Bug 1525588 - Do not enable CFG on ARM builds, as it causes undiagnosed failures. r=dmajor
Tom Ritter <tom@mozilla.com> - Wed, 06 Feb 2019 11:42:24 -0600 - rev 457611
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525588 - Do not enable CFG on ARM builds, as it causes undiagnosed failures. r=dmajor
ef55dfe19ef057ca21bd417b2f5d3c5781214852: No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
ffxbld <ffxbld@mozilla.com> - Thu, 07 Feb 2019 13:54:00 +0000 - rev 457610
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D18967
6e17a2d88817afc47d8967a7d765500b08a0dae0: Bug 1356943 - Only show a tree in the storage sidebar when it is useful r=pbro
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 07 Feb 2019 09:33:42 +0000 - rev 457609
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1356943 - Only show a tree in the storage sidebar when it is useful r=pbro pbro did r+ this patch some time back but it kept breaking try. The only differences between then and now are: 1. `devtools/client/storage/ui.js:859` was reverted to using "" instead of undefined to fix test issues. 2. A bad check for mathematical values was replaced with a `MATH_REGEX` check `devtools/client/storage/ui.js:64,941-943` A new try run is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0212fe328f13991ece396bccb44668d821cb4218&group_state=expanded Differential Revision: https://phabricator.services.mozilla.com/D18578
bdef8bbcf4932da65c95ac54a08ed20648a7fca0: Bug 1523335 - Make use of parentFlexElement in Flexbox inspector r=pbro
Michael Ratcliffe <mratcliffe@mozilla.com> - Wed, 06 Feb 2019 17:35:20 +0000 - rev 457608
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1523335 - Make use of parentFlexElement in Flexbox inspector r=pbro This gives a very noticable increase in speed. When Brad finishes https://bugzil.la/1523336 we can stop walking the DOM and simply use `parentFlexElement` and `parentGridElement`. #### Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=47d38f2c7dca6ca764862c8b00921644a974a975&group_state=expanded Differential Revision: https://phabricator.services.mozilla.com/D18674
f946a261f4fc355d5e3a2d25d5e7e5557bbd6dd5: Bug 1523556 - [Linux/Gtk+] Don't apply titlebar shape mask to maximized windows, r=dao
Martin Stransky <stransky@redhat.com> - Thu, 07 Feb 2019 12:28:48 +0000 - rev 457607
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1523556 - [Linux/Gtk+] Don't apply titlebar shape mask to maximized windows, r=dao Differential Revision: https://phabricator.services.mozilla.com/D18823
6836ad129868dac54c41b17f0d70f6e5c962506e: Bug 1525629. Move wrapper denial warning state to RealmPrivate. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 07 Feb 2019 00:26:40 +0000 - rev 457606
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525629. Move wrapper denial warning state to RealmPrivate. r=bholley This is supposed to be per-global state, and we're planning to have multiple globals per compartment. Differential Revision: https://phabricator.services.mozilla.com/D18850
dda7c63c1c185ca67f5bb7a67855f3d96f407edc: Bug 1525332 - Lazy load components and modules we don't need right away at console initialization; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 06 Feb 2019 14:00:59 +0000 - rev 457605
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525332 - Lazy load components and modules we don't need right away at console initialization; r=Honza. There was quite some file that was required directly but that may not be used until later (or maybe never), which means we were doing extra work. Lazily loading those files seems to improve opening time significantly. Differential Revision: https://phabricator.services.mozilla.com/D18819
526f7b418884ec46195b4f7f03f14d7a609bb248: Bug 1465700. Remove the now-unused JS_DeprecatedGetCompartmentPrincipals API. r=jandem
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 30 Jan 2019 08:45:49 +0000 - rev 457604
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1465700. Remove the now-unused JS_DeprecatedGetCompartmentPrincipals API. r=jandem Differential Revision: https://phabricator.services.mozilla.com/D18036
25b050d6d1e9d926424fa0c6a2754f4ce3838722: Bug 1514049. Remove xpc::GetCompartmentPrincipal. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 30 Jan 2019 19:16:12 +0000 - rev 457603
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1514049. Remove xpc::GetCompartmentPrincipal. r=bholley Differential Revision: https://phabricator.services.mozilla.com/D18035
54964c38d7902f71e0d821b22f8acf1206bdf957: Bug 1514050 part 2. Stop recomputing cross-compartment wrappers on document.domain changes. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 30 Jan 2019 19:02:34 +0000 - rev 457602
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1514050 part 2. Stop recomputing cross-compartment wrappers on document.domain changes. r=bholley The change to test_clonewrapper.xul is because in the new setup we've already tried handing an object across origins via chrome code, so it has a cached (opaque) wrapper. When we set document.domain and pass the same object again, we end up picking up the cached wrapper when we try to wrap across the compartment boundary, so don't grant access when perhaps we should... This does lead to a possible spec violation in the following situation: 1) Two documents (A, B) start out same-site but different-origin. 2) Privileged code (system or extension) puts a reference to an object from site A into site B. This object gets an opaque CCW. 3) Both sites set document.domain to become same-effective-script-origin and then site B goes through the site A Window and the object graph hanging off it and gets to the object involved. It gets an opaque CCW when it should have a transparent CCW. We could fix this if we kept recomputing wrappers on document.domain change and just fixed the compartment filter used by the recomputation. But this seems like a pretty rare situation, and not one web sites can get into without an assist from a somewhat buggy extension or system code, so let's see whether we can just live with it and remove the recomputation. Differential Revision: https://phabricator.services.mozilla.com/D18032
97aaced3f817773ab004df571077806b59632555: Bug 1514050 part 1. Change the cross-compartment wrappers we use for web objects so we can avoid recomputing them when document.domain changes. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 05:26:48 +0000 - rev 457601
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1514050 part 1. Change the cross-compartment wrappers we use for web objects so we can avoid recomputing them when document.domain changes. r=bholley We want to use a transparent CCW if there is any pair of globals, one from each compartment, which are, or have ever been, same origin-domain in the HTML spec sense. This is obviously required in the "are now same origin-domain" case, and in the "were same origin-domain" case it's required because there may be existing transparent CCWs between the compartments and we don't want them to become opaque due to a roundtrip through the compartment boundary. In practice, we need to consider two cases: 1) The two compartments started out same-origin. In this case the two CompartmentOriginInfos will have matching (in the Equals() sense) GetPrincipalIgnoringDocumentDomain(). They will also have matching SiteRef(), of course. 2) The two compartments started out different-origin but then at some point two globals in the compartments ended up same origin-domain. That requires that the two globals be same TLD+1 and have both set document.domain. So in this case the two CompartmentOriginInfos have matching SiteRef() and both test true for HasChangedDocumentDomain(). We only need to worry about this for web compartments, which means that we only need to worry about cases when security checks are symmetric (i.e. originSubsumesTarget == targetSubsumesOrigin) and neither compartment is forcing Xrays. Differential Revision: https://phabricator.services.mozilla.com/D18031
9611438fd389756583f1cdc330bd4725810bcb38: Bug 1524244 - Make the netmonitor localhost icon use a smaller size and inherit currentColor; r=Honza
Florens Verschelde <florens@fvsch.com> - Thu, 07 Feb 2019 12:22:04 +0000 - rev 457600
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1524244 - Make the netmonitor localhost icon use a smaller size and inherit currentColor; r=Honza Differential Revision: https://phabricator.services.mozilla.com/D18211
bea77f447a7ada7e7339a39e5948f37d701fa00d: Backed out 3 changesets (bug 1523272) for Browser-chrome and tv failures in browser/components/preferences/in-content/tests/siteData/browser_siteData3.js
Dorel Luca <dluca@mozilla.com> - Thu, 07 Feb 2019 13:55:33 +0200 - rev 457599
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Backed out 3 changesets (bug 1523272) for Browser-chrome and tv failures in browser/components/preferences/in-content/tests/siteData/browser_siteData3.js Backed out changeset ddf39b3e96df (bug 1523272) Backed out changeset 8fbf00832008 (bug 1523272) Backed out changeset 7250b9f956b6 (bug 1523272)
ce0770fa1ddfcd095a4e6fcda578010458f9fc0e: Bug 1524223 - Fix flaky test browser_multiselect_tabs_move_to_new_window_contextmenu.js. r=jaws
Oriol Brufau <oriol-bugzilla@hotmail.com> - Thu, 07 Feb 2019 04:01:15 +0000 - rev 457598
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1524223 - Fix flaky test browser_multiselect_tabs_move_to_new_window_contextmenu.js. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D18820
b1514d57bcdc98b0accb4f727ad0d91380ea5f28: Bug 1517496 - Make misused string test also check fluent files, r=jaws,flod
Yuan Cheng <chengy12@msu.edu> - Thu, 07 Feb 2019 10:38:24 +0000 - rev 457597
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1517496 - Make misused string test also check fluent files, r=jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D18524
c90fe3ee1999efedec2bddca08db72b8975fc561: Bug 1525371 - followup: fix rusttests to reopen the CLOSED TREE.
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Feb 2019 11:38:23 +0100 - rev 457596
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525371 - followup: fix rusttests to reopen the CLOSED TREE.
d9be4af74c4b90d08a03fbce96bdabf7dca9faf8: Bug 1525371 - Fix a very subtle invalidation bug exposed by test_initial_computation.html. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Feb 2019 18:12:17 +0100 - rev 457595
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525371 - Fix a very subtle invalidation bug exposed by test_initial_computation.html. r=jwatt Now that there's no ArenaRefPtr, the styles aren't cleared when the shell goes away (due to an iframe becoming display: none or what not). This caused a few very confusing failures in test_initial_computation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2746a05ce7b20759a820d6f26a55a3200d8e6b8&selectedJob=226267113 Which holds on to a reference of a style on a display: none iframe[1], reframes it periodically[2], exposing this bug. For now, keep the id of the shell we got the style from around. When we support computing styles in display: none iframes this may need more work, but that's out of the scope of this bug. [1]: https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/layout/style/test/test_initial_computation.html#56 [2]: https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/layout/style/test/test_initial_computation.html#147 Differential Revision: https://phabricator.services.mozilla.com/D18853
56eeff69792c1809cd2dd51a77ea276cde635cdc: Bug 1525371 - Remove ArenaRefPtr. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Feb 2019 20:25:22 +0100 - rev 457594
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525371 - Remove ArenaRefPtr. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D18735
525e804dc7e63855e026be9557af15340d71455a: Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Feb 2019 17:45:54 +0100 - rev 457593
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D18734
c944db09eff52b26d73e00f561beefa200a8bef0: Bug 1525371 - Kill ComputedStyle::ComputedData. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Feb 2019 17:44:57 +0100 - rev 457592
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525371 - Kill ComputedStyle::ComputedData. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D18733
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip